Timeline



May 23, 2012:

11:58 PM Changeset in webkit [118327] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, merge the arguments fix in r118138 to get bots green.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):

11:55 PM Changeset in webkit [118326] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: Web Inspector single line fix for r118162.

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._populateChildren):

11:24 PM Changeset in webkit [118325] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG CFA should record if a node can OSR exit
https://bugs.webkit.org/show_bug.cgi?id=86905

Reviewed by Oliver Hunt.

Merged r117931 from dfgopt.

Adds a NodeFlag that denotes nodes that are known to not have OSR exits.
This ought to aid any backwards analyses that need to know when a
backward flow merge might happen due to a side exit.

Also added assertions into speculationCheck() that ensure that we did not
mark a node as non-exiting and then promptly compile in an exit. This
helped catch some minor bugs where we were doing unnecessary speculation
checks.

This is a perf-neutral change. The speculation checks that this removes
were not on hot paths of major benchmarks.

  • bytecode/PredictedType.h:

(JSC):
(JSC::isAnyPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::speculateInt32Unary):
(AbstractState):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):

  • dfg/DFGNode.h:

(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(Node):
(JSC::DFG::Node::setCanExit):
(JSC::DFG::Node::canExit):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

10:51 PM Changeset in webkit [118324] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should not do unnecessary indirections when storing to objects
https://bugs.webkit.org/show_bug.cgi?id=86959

Reviewed by Oliver Hunt.

Merged r117819 from dfgopt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByOffsetLoadElimination):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:33 PM Changeset in webkit [118323] by fpizlo@apple.com
  • 28 edits
    18 adds in trunk

DFG should optimize aliased uses of the Arguments object of the current call frame
https://bugs.webkit.org/show_bug.cgi?id=86552

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Merged r117542 and r117543 from dfgopt.

Performs must-alias and escape analysis on uses of CreateArguments, and if
a variable is must-aliased to CreateArguments and does not escape, then we
turn all uses of that variable into direct arguments accesses.

36% speed-up on V8/earley leading to a 2.3% speed-up overall in V8.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::uncheckedArgumentsRegister):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::argumentsThatWereNotCreated):
(ValueRecovery):
(JSC::ValueRecovery::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAdjacencyList.h:

(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdgeFromBag):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

  • dfg/DFGGPRInfo.h:

(GPRInfo):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::collectGarbage):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::executableFor):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler.h:

(JSC::DFG::OSRExitCompiler::OSRExitCompiler):
(OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isArgumentsAlias):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):

LayoutTests:

Rubber stamped by Geoff Garen.

Merged r117542 from dfgopt.

Added a bunch of tests that check that our optimizations for aliased uses of the
'arguments' object are robust against various forms of JavaScript crazy.

  • fast/js/dfg-arguments-alias-escape-expected.txt: Added.
  • fast/js/dfg-arguments-alias-escape.html: Added.
  • fast/js/dfg-arguments-alias-expected.txt: Added.
  • fast/js/dfg-arguments-alias.html: Added.
  • fast/js/dfg-arguments-cross-code-origin-expected.txt: Added.
  • fast/js/dfg-arguments-cross-code-origin.html: Added.
  • fast/js/dfg-arguments-mixed-alias-expected.txt: Added.
  • fast/js/dfg-arguments-mixed-alias.html: Added.
  • fast/js/dfg-arguments-osr-exit-expected.txt: Added.
  • fast/js/dfg-arguments-osr-exit.html: Added.
  • fast/js/dfg-arguments-unexpected-escape-expected.txt: Added.
  • fast/js/dfg-arguments-unexpected-escape.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arguments-alias-escape.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-alias.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-cross-code-origin.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-arguments-mixed-alias.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-osr-exit.js: Added.

(baz):
(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-unexpected-escape.js: Added.

(baz):
(foo):
(bar):

10:24 PM Changeset in webkit [118322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

sort the array 'non_wrapper_types'
https://bugs.webkit.org/show_bug.cgi?id=87335

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-23
Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorV8.pm:
9:56 PM FeatureFlags edited by tkent@chromium.org
Add CSS3_FLEXBOX (diff)
9:39 PM Changeset in webkit [118321] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Change EFL debug build name with more detail one
https://bugs.webkit.org/show_bug.cgi?id=87254

Reviewed by Ryosuke Niwa.

EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
In addition, remove efl-linux-debug triggerable since nobody uses it.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
9:23 PM Changeset in webkit [118320] by hayato@chromium.org
  • 3 edits in trunk/LayoutTests

Add a test case of event dispatching which uses inactive insertion points.
https://bugs.webkit.org/show_bug.cgi?id=87229

Reviewed by Darin Adler.

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
8:59 PM Changeset in webkit [118319] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Document.elementFromPoint exposes inner element of Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87235

Reviewed by Dimitri Glazkov.

Source/WebCore:

Document::elementFromPoint didn't consider nested Shadow DOM.
The container node should be adjusted up to document TreeScope beyond ShadowRoot TreeScope.

Test: fast/dom/shadow/element-from-point-in-nested-shadow.html

  • dom/Document.cpp:

(WebCore::Document::elementFromPoint):

LayoutTests:

  • fast/dom/shadow/element-from-point-in-nested-shadow-expected.txt: Added.
  • fast/dom/shadow/element-from-point-in-nested-shadow.html: Added.
8:48 PM Changeset in webkit [118318] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r118297.
http://trac.webkit.org/changeset/118297
https://bugs.webkit.org/show_bug.cgi?id=87338

It caused several layout failures on Mac (Requested by
sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

  • fast/block/float/floats-with-margin-should-not-wrap-expected.html: Removed.
  • fast/block/float/floats-with-margin-should-not-wrap.html: Removed.
8:45 PM Changeset in webkit [118317] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Document.caretRangeFromPoint exposes inner elemnet of Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87231

Reviewed by Dimitri Glazkov.

Source/WebCore:

Document::caretRangeFromPoint didn't consider nested Shadow DOM.
The container node should be adjusted up to document TreeScope beyond ShadowRoot TreeScope.

Test: fast/dom/shadow/caret-range-from-point-in-nested-shadow.html

  • dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

LayoutTests:

  • fast/dom/shadow/caret-range-from-point-in-nested-shadow-expected.txt: Added.
  • fast/dom/shadow/caret-range-from-point-in-nested-shadow.html: Added.
8:42 PM Changeset in webkit [118316] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk

Crash in RenderTableCol::nextColumn
https://bugs.webkit.org/show_bug.cgi?id=87314

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/table/canvas-column-in-column-group.html

fast/table/columngroup-inside-columngroup.html

The issue comes from elements not abiding by the display property (e.g. canvas). This means
that any renderer with display: table-column would pass the current isChildAllowed check and
would confuse our algorithm to iterate.

We were getting away with allowing those children as table columns or column groups don't
paint themselves but it's better to just not allow such children in the first place.

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::isChildAllowed):
Fixed the logic to only accept proper column renderer (RenderTableCol with display: column
to ignore column-groups). Also removed an unneeded NULL-check.

LayoutTests:

  • fast/table/canvas-column-in-column-group-expected.txt: Added.
  • fast/table/canvas-column-in-column-group.html: Added.
  • fast/table/columngroup-inside-columngroup-expected.txt: Added.
  • fast/table/columngroup-inside-columngroup.html: Added.
8:11 PM Changeset in webkit [118315] by rakuco@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[EFL] Gardening after r118203 and r118171.

Remove wrong expectations added in r118171 and unskip passing
tests after r118203.

  • platform/efl/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
  • platform/efl/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
  • platform/efl/test_expectations.txt:
7:44 PM Changeset in webkit [118314] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION: compositing/video/video-poster.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=87199

Reviewed by Maciej Stachowiak.

No new tests; fixes failing compositing/video/video-poster.html test.

Instead of creating the video layer directly, simply allow the layer
to be created in updateStates() by changing the definition of
isReadyForVideoSetup() to bypass the m_isAllowedToRender check if
the player reports a video track is present. This causes the video layer
to be created and for future calls to prepareForRendering() to result
in calls to mediaPlayerRenderingModeChanged().

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup):
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):

7:43 PM Changeset in webkit [118313] by rakuco@webkit.org
  • 3 edits in trunk

[CMake] Unreviewed, add ENABLE_CSS3_FLEXBOX after r118304.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
7:41 PM Changeset in webkit [118312] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Unbreak popup menus.
https://bugs.webkit.org/show_bug.cgi?id=87325

Reviewed by David Levin.

http://svn.webkit.org/repository/webkit/trunk@117607 added this function, but the
Chromium/Mac build doesn't use the file added in that change and hence didn't have
the category method.. Adding it doesn't help, as the category calls a
10.7-only function. Just don't use the category for chromium/mac. Fixes
http://crbug.com/129418

  • platform/mac/WebCoreNSCellExtras.h:
7:38 PM Changeset in webkit [118311] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] Fix WebCore library path and rebaseline result
https://bugs.webkit.org/show_bug.cgi?id=86355

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-23
Reviewed by Dirk Pranke.

Currently EFL DRT uses wrong WebCore library path when running DRT.
Therefore, this patch adjusted the path correctly.

Tools:

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

LayoutTests:

  • platform/efl/test_expectations.txt: Added some cases to skipped list since we don't support those at this stage
7:34 PM Changeset in webkit [118310] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFGCapabilities should not try to get an arguments register from code blocks that don't have one
https://bugs.webkit.org/show_bug.cgi?id=87332

Reviewed by Andy Estes.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

7:28 PM Changeset in webkit [118309] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG should have sparse conditional constant propagation
https://bugs.webkit.org/show_bug.cgi?id=86580

Reviewed by Oliver Hunt.

Merged r117370 from dfgopt.

This enhances CFA so that if it suspects at any point during the fixpoint that a
branch will only go one way, then it only propagates in that one way.

This vastly increases the opportunities for CFG simplification. For example, it
enables us to evaporate this loop:

for (var i = 0; i < 1; ++i) doThings(i);

As a result, it uncovered loads of bugs in the CFG simplifier. In particular:

  • Phi fixup was assuming that all Phis worth fixing up are shouldGenerate(). That's not true; we also fixup Phis that are dead.


  • GetLocal fixup was assuming that it's only necessary to rewire links to a GetLocal, and that the GetLocal's own links don't need to be rewired. Untrue, because the GetLocal may not be rewirable (first block has no GetLocal for r42 but second block does have a GetLocal), in which case it will refer to a Phi in the second block. We need it to refer to a Phi from the first block to ensure that subsequent transformations work.


  • Tail operand fixup was ignoring the fact that Phis in successors may contain references to the children of our tail variables. Hence, successor Phi child substitution needs to use the original second block variable table as its prior, rather than trying to reconstruct the prior later (since by that point the children of the second block's tail variables will have been fixed up, so we will not know what the prior would have been).
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::branchDirectionToString):
(AbstractState):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::recordPossibleIncomingReference):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::changeEdge):

7:19 PM Changeset in webkit [118308] by kov@webkit.org
  • 6 edits
    4 adds in releases/WebKitGTK/webkit-1.8

Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html

fast/mutation/transient-gc-crash.html

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/clear-transient-without-delivery-expected.txt: Added.
  • fast/mutation/clear-transient-without-delivery.html: Added.
  • fast/mutation/transient-gc-crash-expected.txt: Added.
  • fast/mutation/transient-gc-crash.html: Added.
7:18 PM Changeset in webkit [118307] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 109058 - [MutationObservers] Clear pending mutation records on disconnect()
https://bugs.webkit.org/show_bug.cgi?id=78639

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/disconnect-cancel-pending.html

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.

LayoutTests:

  • fast/mutation/disconnect-cancel-pending-expected.txt: Added.
  • fast/mutation/disconnect-cancel-pending.html: Added.
7:18 PM Changeset in webkit [118306] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 113291 - WorkerEventQueue::close might access deleted WorkerEventQueue::EventDispatcherTask.
https://bugs.webkit.org/show_bug.cgi?id=83202

On closing the event queue, WorkerEventQueue cancels all the tasks associated with events.
The tasks in their turn delete themselves from the map whenever task gets executed.
However if shutdown occurs when task is in queue but before task gets executed, the task will be deleted without execution.
This patch makes sure that no deleted tasks stay in WorkerEventQueue, by task removing itself in destructor.

Reviewed by David Levin.

Covered by existing tests.

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::EventDispatcherTask::~EventDispatcherTask):
(WorkerEventQueue::EventDispatcherTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):

7:08 PM Changeset in webkit [118305] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87208

Unreviewed, skipping new test that can have side effects.

  • platform/mac/Skipped:
7:03 PM Changeset in webkit [118304] by ojan@chromium.org
  • 16 edits in trunk

add back the ability to disable flexbox
https://bugs.webkit.org/show_bug.cgi?id=87147

Reviewed by Tony Chang.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
6:57 PM Changeset in webkit [118303] by shinyak@chromium.org
  • 3 edits
    4 adds in trunk

[Shadow] mousewheel event isn't fired on nodes in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87218

Reviewed by Dimitri Glazkov.

Source/WebCore:

EventHander::handleWheelEvent re-targets an event to a shadow ancestor node,
however it should be done by adjusting event target. So we don't need to have it.

Tests: fast/dom/shadow/wheel-event-in-shadow-dom.html

fast/dom/shadow/wheel-event-on-input-in-shadow-dom.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

  • fast/dom/shadow/wheel-event-in-shadow-dom-expected.txt: Added.
  • fast/dom/shadow/wheel-event-in-shadow-dom.html: Added.
  • fast/dom/shadow/wheel-event-on-input-in-shadow-dom-expected.txt: Added.
  • fast/dom/shadow/wheel-event-on-input-in-shadow-dom.html: Added.
6:56 PM Changeset in webkit [118302] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117161
BUG=122029
Review URL: https://chromiumcodereview.appspot.com/10444003

6:53 PM Changeset in webkit [118301] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an unused setter in CachedResource.h.
https://bugs.webkit.org/show_bug.cgi?id=87324

CachedResource::setInLiveDecodedResourcesList was defined in r24925, but it has
been unused.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-05-23
Reviewed by Darin Adler.

  • loader/cache/CachedResource.h:
6:50 PM Changeset in webkit [118300] by cevans@google.com
  • 2 edits in branches/chromium/1132/Source/WebCore/loader/cache

Merge 117376
BUG=128497
Review URL: https://chromiumcodereview.appspot.com/10441007

6:47 PM Changeset in webkit [118299] by hayato@chromium.org
  • 5 edits in trunk

Adjust a target node of a mouse event correctly when a distributed text node is clicked.
https://bugs.webkit.org/show_bug.cgi?id=86999

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make EventHandler::updateMouseEventTargetNode() be aware of shadow dom subtree
so that an insertion point can receive an event when a distributed text node is clicked.

Tests: fast/dom/shadow/shadow-dom-event-dispatching.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
6:40 PM Changeset in webkit [118298] by shinyak@chromium.org
  • 3 edits
    4 adds in trunk

[Shadow] drop event is not fired on nodes in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=85774

Reviewed by Dimitri Glazkov.

Source/WebCore:

EventHander::updateDragAndDrop re-targets an event to a shadow ancestor node,
however it should be done by adjusting event target. So we don't need to have it.

Tests: fast/dom/shadow/drop-event-for-input-in-shadow.html

fast/dom/shadow/drop-event-in-shadow.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop):

LayoutTests:

Confirms drop event is fired on div and input in Shadow DOM.

  • fast/dom/shadow/drop-event-for-input-in-shadow-expected.txt: Added.
  • fast/dom/shadow/drop-event-for-input-in-shadow.html: Added.
  • fast/dom/shadow/drop-event-in-shadow-expected.txt: Added.
  • fast/dom/shadow/drop-event-in-shadow.html: Added.
6:31 PM Changeset in webkit [118297] by eae@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION (115573): Incorrect rounding of margins for floats
https://bugs.webkit.org/show_bug.cgi?id=87319

Reviewed by Eric Seidel.

Source/WebCore:

In RenderBlock::computeInlinePreferredLogicalWidths we used a float to
accumulate margins for floating children while the children themselves
represent their margins as LayoutUnits. Due to lack of rounding this can
cause the block to be too small at certain certain zoom levels, causing
unwanted wrapping.

This patch changes computeInlinePreferredLogicalWidths to use a
LayoutUnit to accumulate the margins and thus ensures that the margin
values are rounded the same way.

Test: fast/block/float/floats-with-margin-should-not-wrap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

Add new test ensuring that using margins with floats doesn't cause
undesired wrapping.

  • fast/block/float/floats-with-margin-should-not-wrap-expected.html: Added.
  • fast/block/float/floats-with-margin-should-not-wrap.html: Added.
6:29 PM Changeset in webkit [118296] by cevans@google.com
  • 2 edits in branches/chromium/1132/Source/WebCore/html

Merge 116642
BUG=126015
Review URL: https://chromiumcodereview.appspot.com/10450008

6:22 PM Changeset in webkit [118295] by cevans@google.com
  • 3 edits
    8 copies in branches/chromium/1132

Merge 116458
BUG=125919
Review URL: https://chromiumcodereview.appspot.com/10445006

6:12 PM Changeset in webkit [118294] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116860
BUG=127368
Review URL: https://chromiumcodereview.appspot.com/10450007

6:09 PM Changeset in webkit [118293] by cevans@google.com
  • 2 edits in branches/chromium/1132

Merge 116618
BUG=127587
Review URL: https://chromiumcodereview.appspot.com/10446008

6:09 PM Changeset in webkit [118292] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused declarations in MemoryCache.h
https://bugs.webkit.org/show_bug.cgi?id=87323

It is originated from r75912.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-05-23
Reviewed by Darin Adler.

  • loader/cache/MemoryCache.h:
6:07 PM Changeset in webkit [118291] by eric@webkit.org
  • 20 edits
    3 adds in trunk

Add seamless layout code (and pass most of the remaining seamless tests)
https://bugs.webkit.org/show_bug.cgi?id=86608

Reviewed by Ojan Vafai.

Source/WebCore:

This patch contains almost all the layout changes needed for seamless iframes.
I removed the scroll-bar avoiding code at the last moment, as it didn't
work for platforms other than mac-lion. I'll add that, as well as the
HTMLIFrameElement.seamless idl attribute in a follow-up patch.

Seamless iframes piggy-back a bit on the existing frame-flattening
logic, however seamless is different from frame-flattening in a few ways:

  • Frame flattening can only ever make an iframe larger (seamless just behaves like a normal div).
  • Frame flattening disables scrollbars (seamless frames behave like normal overflow: auto divs).
  • Seamless only has to work with iframes (flattening works with frame/frameset as well).
  • Seamless support shrink-wrap size negotiation when the iframe is inline.

Test: fast/frames/seamless/seamless-percent-height.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): map inline -> inline-block for seamless iframes.

  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):

  • Seamless iframes don't manage their own style recalc.

(WebCore::Document::recalcStyle):

  • We should make sure our parent is resolved before we are, but currently that causes some tests to crash I don't have a test to demonstrate this need yet, as presumably it's fulfilled through other codepaths atm.
  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayout): Do the cheaper check first.
(WebCore::FrameView::isInChildFrameWithFrameFlattening): Make frameview layout abort child layouts like how frame flattening does.

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport): Disable the stretch-to-viewport quirk for seamless iframes (it makes no sense and breaks the layout code).

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::computeLogicalHeight):

  • This function is needed for the child document to participate in the normal block shrink-wrap algorithm. Thankfully all the shrink-wrap logic is in RenderBox instead of RenderBlock. In the future we may make RenderIframe a RenderBlock for the seamless case. We may just split RenderIframe into two renderers.

(WebCore::RenderIFrame::computeLogicalWidth):
(WebCore::RenderIFrame::shouldComputeSizeAsReplaced):

  • seamless iframes behave like blocks, not inline replaced elements.

(WebCore):
(WebCore::RenderIFrame::isInlineBlockOrInlineTable):

  • Behave like an inline-block when marked inline.

(WebCore::RenderIFrame::minPreferredLogicalWidth):

  • When asked for our pref widths, return those of our child document.

(WebCore::RenderIFrame::maxPreferredLogicalWidth):
(WebCore::RenderIFrame::isSeamless): helper function
(WebCore::RenderIFrame::contentRootRenderer): helper function
(WebCore::RenderIFrame::flattenFrame): seamless iframes never use the frame-flattening feature.
(WebCore::RenderIFrame::layoutSeamlessly): The guts of seamless layout.
(WebCore::RenderIFrame::layout):

  • rendering/RenderIFrame.h:

(WebCore):
(RenderIFrame):

LayoutTests:

Add a test for percent height in child documents, as well as
disabling the expand-to-fill-viewport quirk of html/body elements
in quirks mode.
Also update all the expectations now that we pass almost all the tests.

  • fast/frames/seamless/resources/percent-square.html: Added.
  • fast/frames/seamless/resources/two-inline-blocks.html:
  • fast/frames/seamless/seamless-basic-expected.txt:
  • fast/frames/seamless/seamless-float-expected.txt:
  • fast/frames/seamless/seamless-inherited-origin-expected.txt:
  • fast/frames/seamless/seamless-inherited-origin.html:
  • fast/frames/seamless/seamless-inline-expected.txt:
  • fast/frames/seamless/seamless-nested-expected.txt:
  • fast/frames/seamless/seamless-percent-height-expected.txt: Added.
  • fast/frames/seamless/seamless-percent-height.html: Added.
  • fast/frames/seamless/seamless-quirks-expected.txt:
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt:
  • fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
6:04 PM Changeset in webkit [118290] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows build.

  • bytecode/CodeBlock.h:
  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canCompileOpcodes):

  • dfg/DFGCommon.h:

(DFG):

6:00 PM Changeset in webkit [118289] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] GraphicsContext should avoid converting rotation angle to degrees
https://bugs.webkit.org/show_bug.cgi?id=87317

Reviewed by Noam Rosenthal.

The angle for rotate is already in radians, so we should take advantage of it
by using QTransform::rotateRadians, rather than converting it back internally.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::rotate):

5:58 PM Changeset in webkit [118288] by tony@chromium.org
  • 2 edits in trunk/Tools

Remove the Chromium Grid Layout bot from the waterfall
https://bugs.webkit.org/show_bug.cgi?id=87311

Reviewed by Ryosuke Niwa.

I removed the compiler define in r117613, so we don't need a separate
bot to compile/test this code.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:49 PM Changeset in webkit [118287] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1132

Merge 116653
BUG=124870
Review URL: https://chromiumcodereview.appspot.com/10451004

5:46 PM Changeset in webkit [118286] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116698
BUG=125921
Review URL: https://chromiumcodereview.appspot.com/10452002

5:43 PM Changeset in webkit [118285] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Merge r116524 onto the 536 branch, since r116473 was merged onto the branch in r117121.

  • platform/mac/Skipped:
5:39 PM Changeset in webkit [118284] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1132

Merge 117748
BUG=128159
Review URL: https://chromiumcodereview.appspot.com/10442006

5:36 PM Changeset in webkit [118283] by cevans@google.com
  • 3 edits
    4 copies in branches/chromium/1132

Merge 116914
BUG=125555
Review URL: https://chromiumcodereview.appspot.com/10447005

5:35 PM Changeset in webkit [118282] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Merge r117163 onto the 536 branch, since r116960 was merged onto the branch in 117157.

  • platform/mac-lion/Skipped:
5:30 PM Changeset in webkit [118281] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

AX: Prevents assertion from potentially dereferencing null pointer.
https://bugs.webkit.org/show_bug.cgi?id=87290

Patch by David Tseng <dtseng@google.com> on 2012-05-23
Reviewed by Chris Fleizach.

Changes to assertions. Coverage by existing tests.

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):

5:25 PM Changeset in webkit [118280] by cevans@google.com
  • 9 edits
    2 copies in branches/chromium/1132

Merge 116476
BUG=117413
Review URL: https://chromiumcodereview.appspot.com/10442005

5:19 PM Changeset in webkit [118279] by tony@chromium.org
  • 7 edits
    2 adds in trunk

auto margins on flexbox should allocate space in the cross direction
https://bugs.webkit.org/show_bug.cgi?id=86913

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/auto-margins.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::hasAutoMarginsInCrossAxis):
(WebCore):
(WebCore::RenderFlexibleBox::updateAutoMarginsInCrossAxis):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): If we have flex-align: baseline and auto margins, we ignore flex-align: baseline.
(WebCore::RenderFlexibleBox::alignChildren): auto margins apply before flex-align.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/auto-margins-expected.html: Added.
  • css3/flexbox/auto-margins.html: Added. These are the test cases in the spec.
  • css3/flexbox/flex-align-vertical-writing-mode.html: Fix tests with auto margins and add more tests.

Also reduce the height so it's easier to see the test cases (these vertical tests don't check the height).

  • css3/flexbox/flex-align.html: Fix tests with auto margins and add more tests.
  • css3/flexbox/flex-flow-auto-margins.html: Fix results now that we handle auto in the cross direction.
5:18 PM Changeset in webkit [118278] by fpizlo@apple.com
  • 19 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should optimize inlined uses of arguments.length and arguments[i]
https://bugs.webkit.org/show_bug.cgi?id=86327

Reviewed by Gavin Barraclough.

Merged r117017 from dfgopt.

Turns inlined uses of arguments.length into a constant.

Turns inlined uses of arguments[constant] into a direct reference to the
argument.

Big win on micro-benchmarks. Not yet a win on V8 because the hot uses of
arguments.length and arguments[i] are aliased. I'll leave the aliasing
optimizations to a later patch.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/DFGExitProfile.h:

(FrequentExitSite):
(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::QueryableExitProfile::hasExitSite):
(QueryableExitProfile):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp: Added.

(DFG):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::performArgumentsSimplification):

  • dfg/DFGArgumentsSimplificationPhase.h: Added.

(DFG):

  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::executableFor):
(DFG):

  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::executableFor):
(Graph):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(Node):
(JSC::DFG::Node::unlinkedLocal):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:15 PM Changeset in webkit [118277] by jberlin@webkit.org
  • 1 edit
    1 delete in branches/safari-536-branch/LayoutTests

Finish rolling r116340 into the 536 branch.

  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
5:15 PM Changeset in webkit [118276] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Enable the CCLayerTreeHostTestCanDrawBlocksDrawing test in single-threaded mode
https://bugs.webkit.org/show_bug.cgi?id=87308

Reviewed by James Robinson.

Chromium bug: http://crbug.com/127481

Unit test: CCLayerTreeHostTestCanDrawBlocksDrawing.runSingleThread

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::didCommit):
(WTF):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommit):

5:13 PM Changeset in webkit [118275] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed, rolling out r118120.
http://trac.webkit.org/changeset/118120
https://bugs.webkit.org/show_bug.cgi?id=87193

some LayoutTests crash since the patch passes a NULL to
Null(isolate)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

5:12 PM Changeset in webkit [118274] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r118129.
http://trac.webkit.org/changeset/118129
https://bugs.webkit.org/show_bug.cgi?id=87202

some LayoutTests crash since the patch passes a NULL to
Null(isolate)

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):

5:11 PM Changeset in webkit [118273] by haraken@chromium.org
  • 22 edits in trunk/Source/WebCore

Unreviewed, rolling out r118133.
http://trac.webkit.org/changeset/118133
https://bugs.webkit.org/show_bug.cgi?id=87207

some LayoutTests crash since the patch passes a NULL to
Null(isolate)

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

5:10 PM Changeset in webkit [118272] by haraken@chromium.org
  • 28 edits in trunk/Source/WebCore

Unreviewed, rolling out r118134.
http://trac.webkit.org/changeset/118134
https://bugs.webkit.org/show_bug.cgi?id=87209

some LayoutTests crash since the patch passes a NULL to
Null(isolate)

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):
(WebCore::toV8):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
(WebCore::toV8Slow):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

5:09 PM Changeset in webkit [118271] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Skip more CSS Regions related tests on the 536 branch.

  • platform/mac/Skipped:
5:05 PM Changeset in webkit [118270] by fpizlo@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

DFG should be able to optimize foo.apply(bar, arguments)
https://bugs.webkit.org/show_bug.cgi?id=86306

Reviewed by Gavin Barraclough.

Merge r116912 from dfgopt.

Enables compilation of op_jneq_ptr and some forms of op_call_varargs.

Also includes a bunch of bug fixes that were made necessary by the increased
pressure on the CFG simplifier.

This is a 1-2% win on V8.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::canCompileWithDFGInternal):
(JSC::EvalCodeBlock::canCompileWithDFGInternal):
(JSC::FunctionCodeBlock::canCompileWithDFGInternal):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::canCompileWithDFG):
(JSC::CodeBlock::canCompileWithDFGState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getLocalLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
(DFG):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:

(Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):

  • jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • tools/CodeProfile.cpp:

(JSC::CodeProfile::sample):

4:55 PM Changeset in webkit [118269] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Refactored WeakBlock to use malloc, clarify behavior
https://bugs.webkit.org/show_bug.cgi?id=87318

Reviewed by Filip Pizlo.

We want to use malloc so we can make these smaller than 4KB,
since an individual MarkedBlock will usually have fewer than
4KB worth of weak pointers.

  • heap/Heap.cpp:

(JSC::Heap::markRoots): Renamed visitLiveWeakImpls to visit, since
we no longer need to distinguish from "visitDeadWeakImpls".

Renamed "visitDeadWeakImpls" to "reap" because we're not actually
doing any visiting -- we're just tagging things as dead.

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create):
(JSC::WeakBlock::destroy):
(JSC::WeakBlock::WeakBlock): Malloc!

(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap): Renamed as above.

  • heap/WeakBlock.h:

(WeakBlock): Reduced to 3KB, as explained above.

  • heap/WeakSet.cpp:

(JSC::WeakSet::visit):
(JSC::WeakSet::reap):

  • heap/WeakSet.h:

(WeakSet): Updated for renames, and to match WebKit style.

4:53 PM Changeset in webkit [118268] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Fix typo in r118235.

  • http/tests/workers/worker-importScriptsOnError-expected.txt:
4:41 PM Changeset in webkit [118267] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking a pair of fast/history layout tests as flaky (TEXT).
https://bugs.webkit.org/show_bug.cgi?id=87321

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:36 PM Changeset in webkit [118266] by jberlin@webkit.org
  • 2 edits
    1 delete in branches/safari-536-branch/LayoutTests

Roll in r116340 to the 536 branch (needed test cleanup that didn't make the branch cut).

  • platform/mac-wk2/Skipped:
  • platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Removed.
4:30 PM Changeset in webkit [118265] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] http/tests/cache/history-only-cached-subresource-loads{-max-age-https}.html are now
failing with TEXT differences, so updated failure expectations.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [118264] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Roll out r116176 on the 536 branch, since r116009 was rolled out on the 536 branch.

r116176 updated the test in response to the switch to FractionalLayoutUnits, but the
LayoutUnits changes were rolled out of the 536 branch.

  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
4:14 PM Changeset in webkit [118263] by commit-queue@webkit.org
  • 12 edits
    6 adds in trunk

Add a Setting to make position:fixed form a new stacking context
https://bugs.webkit.org/show_bug.cgi?id=87186

Patch by James Robinson <jamesr@chromium.org> on 2012-05-23
Reviewed by Adam Barth.

Source/WebCore:

position:fixed elements form a new stacking context in several mobile WebKit ports and in the Qt port always. To
be consistent across devices, we want to try turning it on everywhere. This will likely cause compatibility
issues, so we need a runtime setting in order to stage the change carefully.

Tests: fast/block/positioning/fixed-position-stacking-context.html

fast/block/positioning/fixed-position-stacking-context2.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setFixedPositionCreatesStackingContext):
(WebCore::Settings::fixedPositionCreatesStackingContext):
(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setFixedPositionCreatesStackingContext):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setFixedPositionCreatesStackingContext):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

Adds layout tests that confirm we don't creates stacking contexts for position:fixed by default, but we do when
the fixedPositionCreatesStackingContext Setting is true.

Qt and Blackberry will need different expectations since they set this via an #ifdef

  • fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
  • fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
  • fast/block/positioning/fixed-position-stacking-context.html: Added.
  • fast/block/positioning/fixed-position-stacking-context2-expected.png: Added.
  • fast/block/positioning/fixed-position-stacking-context2-expected.txt: Added.
  • fast/block/positioning/fixed-position-stacking-context2.html: Added.
4:12 PM Changeset in webkit [118262] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Use after free in JSC::DFG::ByteCodeParser::processPhiStack
https://bugs.webkit.org/show_bug.cgi?id=87312
<rdar://problem/11518848>

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

4:06 PM Changeset in webkit [118261] by jamesr@google.com
  • 17 edits in trunk

[chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port
https://bugs.webkit.org/show_bug.cgi?id=87177

Reviewed by Eric Seidel.

Source/WebKit/chromium:

Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard
CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This
property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts
to be created that otherwise would not be, breaking "desktop" pages.

This turns the feature off until we can figure out how to deal with the compatibility issues.

  • features.gypi:

LayoutTests:

Mark test depending on ENABLE(OVERFLOW_SCROLLING) as an expected failure since the define is off.

  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [118260] by jberlin@webkit.org
  • 3 edits in branches/safari-536-branch/LayoutTests

Roll out 116019 on the 536 branch, since r116009 was rolled out on the 536 branch.

r116019 updated the test in response to the switch to FractionalLayoutUnits, but the
LayoutUnits changes were rolled out of the 536 branch.

  • fast/events/zoom-dblclick-expected.txt:
  • fast/events/zoom-dblclick.html:
3:56 PM Changeset in webkit [118259] by kbr@google.com
  • 6 edits
    23 copies in branches/chromium/1132

Merge 117918 - Must set/reset pixel unpack alignment to 1 during texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=86877

Reviewed by James Robinson.

Source/WebCore:

Set pixel unpack alignment to 1 during upload, resetting afterward.

Tests: fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html

fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):

Set pixel unpack alignment to 1 during upload; reset afterward.

LayoutTests:

Incorporated several tests from WebGL conformance suite at Khronos
as layout tests, verifying upload to all packed pixel formats.

There were difficulties incorporating the video-related variants
of these tests; Bug 87042 has been filed to track their addition.

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-canvas.js: Added.

(generateTest.init):
(generateTest.runOneIteration):
(generateTest.runTest):
(generateTest):

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-image-data.js: Added.

(generateTest.init):
(generateTest.runOneIteration):
(generateTest.runTest):
(generateTest):

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-image.js: Added.

(generateTest.init):
(generateTest.runOneIteration):
(generateTest.runTestOnImage):
(generateTest.runTest.newImage.onload):
(generateTest.runTest):
(generateTest.runTest2.newImage.onload):
(generateTest.runTest2):
(generateTest.runTest3):
(generateTest):

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:

TBR=kbr@google.com
Review URL: https://chromiumcodereview.appspot.com/10441002

3:28 PM Changeset in webkit [118258] by jcivelli@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Provides a way to cancel an external popup menu before it is shown.
https://bugs.webkit.org/show_bug.cgi?id=83474

Reviewed by Kent Tamura.

  • src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::show):

3:25 PM Changeset in webkit [118257] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

It should be possible to make C function calls from DFG code on ARM in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87313

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

3:22 PM Changeset in webkit [118256] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] fast/url/path.html with Qt5 differ results on both WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=77380

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-23
Reviewed by Kenneth Rohde Christiansen.

The test pass on qt5-wk2, but not on qt5-wk1.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
3:20 PM Changeset in webkit [118255] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Turn off the inspector tests on the 536 branch.

  • platform/mac/Skipped:
3:04 PM Changeset in webkit [118254] by Michael Nordman
  • 4 edits in trunk/Source

Source/WebCore: [chromium] DomStorage events handling needs TLC (3)
https://bugs.webkit.org/show_bug.cgi?id=87031
https://code.google.com/p/chromium/issues/detail?id=128482
Create WebCore::Storage instances as a side effect of attaching storage event handlers.
This allows storage events in chromium to be propagated with less IPC chatter.

Worth noting that in non-chromium ports, creation of the localStorage instance can have
an additional side effect of scheduling a background task to read the area's values
from disk, which given the interest in events is probably a beneficial side effect.

Reviewed by Adam Barth.

No new tests. Existing tests cover this.

  • page/DOMWindow.cpp:

(WebCore::didAddStorageEventListener):
(WebCore::DOMWindow::addEventListener):

Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (3)
https://bugs.webkit.org/show_bug.cgi?id=87031
https://code.google.com/p/chromium/issues/detail?id=128482
Only queue storage events for Documents which have allocated
a WebCore::Storage instance since pages that have attached onstorage
event handlers must have a non-null Storage instance.

Reviewed by Adam Barth.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
(WebCore::StorageAreaProxy::isEventSource):

2:59 PM Changeset in webkit [118253] by msaboff@apple.com
  • 5 edits in trunk/Source/WebCore

Crash in fast/files/read tests during Garbage Collection
https://bugs.webkit.org/show_bug.cgi?id=87165

Reviewed by Alexey Proskuryakov.

Changed hasPendingActivity() processing to use ActiveDOMObject::hasPendingActivity()
and associated setPendingActivity() / unsetPendingActivity().

Fixed two existing tests with change.

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::signalCompletion):

  • Modules/filesystem/FileWriter.h:
  • fileapi/FileReader.cpp:

(WebCore::FileReader::readInternal):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):

  • fileapi/FileReader.h:
2:59 PM Changeset in webkit [118252] by jsbell@chromium.org
  • 8 edits
    1 delete in trunk/Source

Unreviewed, rolling out r118218.
http://trac.webkit.org/changeset/118218
https://bugs.webkit.org/show_bug.cgi?id=87299

breaks webkit win builder (Requested by pilgrim_google on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):

  • chromium/public/WebLocalizedString.h: Removed.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::queryLocalizedString):

  • public/platform/WebLocalizedString.h:

(WebKit):

  • src/LocalizedStrings.cpp:

(WebCore::query):

2:56 PM Changeset in webkit [118251] by kbr@google.com
  • 1 edit
    2 deletes in trunk/LayoutTests

webgl/context-lost failing on Lion
https://bugs.webkit.org/show_bug.cgi?id=81284

Unreviewed test expectations update. The fix for Bug 87136 fixed
the underlying bug here; adjusting test expectations.

  • platform/mac-snowleopard/fast/canvas/webgl/context-lost-expected.txt: Removed.
  • platform/mac/fast/canvas/webgl/context-lost-expected.txt: Removed.
2:54 PM Changeset in webkit [118250] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add vollick to list of contributors.
https://bugs.webkit.org/show_bug.cgi?id=87305

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-23
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers.py:
2:51 PM Changeset in webkit [118249] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in run-ins with continuations while moving back to original position.
https://bugs.webkit.org/show_bug.cgi?id=87264

Reviewed by Julien Chaffraix.

Source/WebCore:

Run-in that are now placed in sibling block can break up into continuation
chains when new children are added to it. We cannot easily send them back to their
original place since that requires writing integration logic with RenderInline::addChild
and all other places that might cause continuations to be created (without blowing away
|this|). Disabling this feature for now to prevent crashes.

Test: fast/runin/runin-continuations-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::moveRunInToOriginalPosition):

LayoutTests:

  • fast/runin/runin-continuations-crash-expected.txt: Added.
  • fast/runin/runin-continuations-crash.html: Added.
2:48 PM ImportingThirdPartyTests edited by jacobg@adobe.com
(diff)
2:47 PM Changeset in webkit [118248] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderInline::linesVisualOverflowBoundingBox.
https://bugs.webkit.org/show_bug.cgi?id=85804

Reviewed by Dave Hyatt.

Source/WebCore:

Defer layout of replaced elements to the next line break function.
We shouldn't do it while we are clearing our inline chilren
lineboxes in full layout mode.

Test: fast/block/inline-children-root-linebox-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/block/inline-children-root-linebox-crash-expected.txt: Added.
  • fast/block/inline-children-root-linebox-crash.html: Added.
2:47 PM ImportingThirdPartyTests edited by jacobg@adobe.com
(diff)
2:46 PM Changeset in webkit [118247] by crogers@google.com
  • 5 edits
    2 adds in trunk

Source/WebCore: AudioParam must support fan-in (multiple audio connections) (take 2)
https://bugs.webkit.org/show_bug.cgi?id=83610

Reviewed by Kenneth Russell.

This re-lands bug: https://bugs.webkit.org/show_bug.cgi?id=83610
Now that a fix has been landed: http://trac.webkit.org/changeset/118099

Test: webaudio/audioparam-summingjunction.html

  • Modules/webaudio/AudioParam.cpp:
  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
Sums intrinsic parameter value with all audio-rate connections.

(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
Support multiple connections.

(WebCore::AudioParam::hasSampleAccurateValues):
If we have one or more audio-rate connections.

(WebCore::AudioParam::AudioParam):
AudioParam now sub-classes AudioSummingJunction.

LayoutTests: AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610

Reviewed by Kenneth Russell.

  • webaudio/audioparam-connect-audioratesignal.html:
  • webaudio/audioparam-summingjunction-expected.txt: Added.
  • webaudio/audioparam-summingjunction.html: Added.
2:44 PM ImportingThirdPartyTests edited by jacobg@adobe.com
(diff)
2:37 PM Changeset in webkit [118246] by ericu@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

There are no shared worker filesystem tests
https://bugs.webkit.org/show_bug.cgi?id=83828

Reviewed by David Levin.

  • fast/filesystem/resources/file-writer-events.js:

Minor tweak to prevent double-import of js-test-pre.js

  • fast/filesystem/resources/shared-worker-stub.js: Added.

Stub that imports js-test-pre.js for shared workers, so that we don't
actually import the test script until postMessage has somewhere to go.

  • fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Added.
  • fast/filesystem/workers/file-writer-events-shared-worker.html: Added.

The new test, running the same old file-writer-events.js that runs in
document and worker context.

  • fast/js/resources/js-test-pre.js:

Previously it looked like startWorker supported creating shared workers;
there was an option, but it was a lie. If you used it, it was
completely broken. This adds a functional minimal implementation.
(startWorker.worker.port.onmessage):
(startWorker):
(.self.onconnect.workerPort.onmessage):
(.self.onconnect):
(.description):
(.testFailed):
(.testPassed):
(.finishJSTest):
(.debug):

  • platform/chromium/test_expectations.txt:

DumpRenderTree and test_shell don't support shared workers; you have to
run this by hand in Chrome.

2:25 PM ImportingThirdPartyTests edited by jacobg@adobe.com
(diff)
2:15 PM Changeset in webkit [118245] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (117623) - Entering/exiting fullscreen HTML5 videos, there is a quick animated fade
https://bugs.webkit.org/show_bug.cgi?id=87294

Reviewed by Darin Adler.

When setting the sublayers array on the layer hosting view, wrap the call in a CATransaction which disables
animations.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateAcceleratedCompositingMode:WebKit::]):

2:13 PM Changeset in webkit [118244] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Fix chromium_android_unittest
https://bugs.webkit.org/show_bug.cgi?id=87196

Reviewed by Tony Chang.

Update unit tests after ChromiumAndroidPort supported apk based
DumpRenderTree.

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
(ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)

2:13 PM Changeset in webkit [118243] by jsbell@chromium.org
  • 3 edits in branches/chromium/1132/Source/WebCore

Merge 118039 - Source/WebCore: Fix iframe printing.
https://bugs.webkit.org/show_bug.cgi?id=85118

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-05-22
Reviewed by Darin Adler, Eric Seidel.

Patch fixed two issues by disabling special handling of subframes for printing.

  1. Regression. Division by zero when forceLayoutForPagination called for subframes

and page sizes set to zero.

  1. Old issue. RendererView adjusted layout of subframes for printing and set invalid

dimensions. Sometimes it caused missing iframe when printed.

Test: printing/iframe-print.html

  • page/Frame.cpp:

(WebCore::Frame::setPrinting): Calls forceLayoutForPagination for root frames only.
(WebCore::Frame::resizePageRectsKeepingRatio): Added ASSERTs to catch division by zero.

  • rendering/RenderView.cpp: Replaced printing() with shouldUsePrintingLayout() for most calls.

(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):
(WebCore::RenderView::layout):
(WebCore::RenderView::shouldUsePrintingLayout): Returns true only if printing enabled and it's a root frame.
(WebCore::RenderView::viewRect):
(WebCore::RenderView::viewHeight):
(WebCore::RenderView::viewWidth):

  • rendering/RenderView.h:

TBR=commit-queue@webkit.org,vitalybuka@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10427008

2:02 PM Changeset in webkit [118242] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

[watchlist] Add myself and create a watch rule to catch Attribute related patches
https://bugs.webkit.org/show_bug.cgi?id=87303

Reviewed by Alexis Menard.

  • Scripts/webkitpy/common/config/watchlist:
1:58 PM Changeset in webkit [118241] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87092

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-23
Reviewed by Adam Barth.

Source/WebCore:

Remove readonly keyword from the webkitIntent attribute. This is
needed otherwise the [Replaceable] extended attribute has not effect
with JSC. This is tested by webintents/web-intents-delivery-reuse.html
test case.

  • Modules/intents/DOMWindowIntents.idl:

LayoutTests:

Remove webintents/web-intents-delivery-reuse.html from test
expectations now that window.webkitIntent is really replaceable and
now that the test is passing.

  • platform/efl/test_expectations.txt:
1:52 PM Changeset in webkit [118240] by fpizlo@apple.com
  • 19 edits in trunk/Source/JavaScriptCore

DFG should be able to inline functions that use arguments reflectively
https://bugs.webkit.org/show_bug.cgi?id=86132

Reviewed by Oliver Hunt.

Merged r116838 from dfgopt.

This turns on inlining of functions that use arguments reflectively, but it
does not do any of the obvious optimizations that this exposes. I'll save that
for another patch - the important thing for now is that this contains all of
the plumbing necessary to make this kind of inlining sound even in bizarro
cases like an inline callee escaping the arguments object to parts of the
inline caller where the arguments are otherwise dead. Or even more fun cases
like where you've inlined to an inline stack that is three-deep, and the
function on top of the inline stack reflectively accesses the arguments of a
function that is in the middle of the inline stack. Any subsequent
optimizations that we do for the obvious cases of arguments usage in inline
functions will have to take care not to break the baseline functionality that
this patch plumbs together.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:
  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::someCodeBlockForPossiblyInlinedCode):

  • interpreter/CallFrame.h:

(ExecState):
(JSC::ExecState::someCodeBlockForPossiblyInlinedCode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArgumentsFromVMCode):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):
(JSC):
(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/Arguments.h:

(Arguments):
(JSC::Arguments::create):
(JSC::Arguments::finishCreation):
(JSC):

1:51 PM Changeset in webkit [118239] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Every OSR exit on ARM results in a crash
https://bugs.webkit.org/show_bug.cgi?id=87307

Reviewed by Geoffrey Garen.

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

1:47 PM Changeset in webkit [118238] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Refactored heap tear-down to use normal value semantics (i.e., destructors)
https://bugs.webkit.org/show_bug.cgi?id=87302

Reviewed by Oliver Hunt.

This is a step toward incremental DOM finalization.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::~CopiedSpace):

  • heap/CopiedSpace.h:

(CopiedSpace): Just use our destructor, instead of relying on the heap
to send us a special message at a special time.

  • heap/Heap.cpp:

(JSC::Heap::Heap): Use OwnPtr for m_markListSet because this is not Sparta.

(JSC::Heap::~Heap): No need for delete or freeAllBlocks because normal
destructors do this work automatically now.

(JSC::Heap::lastChanceToFinalize): Just call lastChanceToFinalize on our
sub-objects, and assume it does the right thing. This improves encapsulation,
so we can add items requiring finalization to our sub-objects.

  • heap/Heap.h: Moved m_blockAllocator to get the right destruction order.
  • heap/MarkedSpace.cpp:

(Take):
(JSC):
(JSC::Take::Take):
(JSC::Take::operator()):
(JSC::Take::returnValue): Moved to the top of the file so it can be used
in another function.

(JSC::MarkedSpace::~MarkedSpace): Delete all outstanding memory, like a good
destructor should.

(JSC::MarkedSpace::lastChanceToFinalize): Moved some code here from the heap,
since it pertains to our internal implementation details.

  • heap/MarkedSpace.h:

(MarkedSpace):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::lastChanceToFinalize):

  • heap/WeakBlock.h:

(WeakBlock):

  • heap/WeakSet.cpp:

(JSC::WeakSet::lastChanceToFinalize):

  • heap/WeakSet.h:

(WeakSet): Stop using a special freeAllBlocks() callback and just implement
lastChanceToFinalize.

1:43 PM Changeset in webkit [118237] by pilgrim@chromium.org
  • 12 edits
    4 copies
    4 adds in trunk/Source

[Chromium] Move themeEngine to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87268

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::themeEngine):

  • chromium/public/android: Added.
  • chromium/public/android/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

  • chromium/public/linux: Added.
  • chromium/public/linux/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

  • chromium/public/mac: Added.
  • chromium/public/mac/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(ScrollbarInfo):
(WebKit::WebThemeEngine::paintScrollbarThumb):

  • chromium/public/win: Added.
  • chromium/public/win/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(WebKit::WebThemeEngine::paintSpinButton):
(WebKit::WebThemeEngine::paintProgressBar):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::sandboxSupport):

  • public/platform/android/WebThemeEngine.h:
  • public/platform/linux/WebThemeEngine.h:
  • public/platform/mac/WebThemeEngine.h:
  • public/platform/win/WebThemeEngine.h:
  • src/AssertMatchingEnums.cpp:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::paintButton):
(WebCore::PlatformSupport::paintMenuList):
(WebCore::PlatformSupport::paintScrollbarArrow):
(WebCore::PlatformSupport::paintScrollbarThumb):
(WebCore::PlatformSupport::paintScrollbarTrack):
(WebCore::PlatformSupport::paintSpinButton):
(WebCore::PlatformSupport::paintTextField):
(WebCore::PlatformSupport::paintTrackbar):
(WebCore::PlatformSupport::paintProgressBar):
(WebCore::PlatformSupport::getThemePartSize):
(WebCore::PlatformSupport::paintThemePart):

1:41 PM Changeset in webkit [118236] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

ASSERT failure toRenderProgress in HTMLProgressElement::didElementStateChange
https://bugs.webkit.org/show_bug.cgi?id=87274

Reviewed by Darin Adler.

Source/WebCore:

Progress bar can't run-in. Prevent it from becoming a run-in, leading to an
unworkable RenderInline.

Test: fast/runin/progress-run-in-crash.html

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::didElementStateChange):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded):

LayoutTests:

  • fast/runin/progress-run-in-crash-expected.txt: Added.
  • fast/runin/progress-run-in-crash.html: Added.
1:39 PM Changeset in webkit [118235] by jberlin@webkit.org
  • 3 edits in branches/safari-536-branch/LayoutTests

Roll back in the gardening done after r116039 for the 536 branch.

It was rolled out accidentally in r116070 when rolling out the changes related to r116009.

  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • http/tests/workers/worker-importScriptsOnError-expected.txt:
1:35 PM Changeset in webkit [118234] by dpranke@chromium.org
  • 5 edits in trunk/Tools

garden-o-matic should not fetch from debug bots if it also knows about the release bots
https://bugs.webkit.org/show_bug.cgi?id=86916

Reviewed by Adam Barth.

This change pushes all of the logic for rebaselining a cluster
of failures (a list of tests failing a list of suffixes on a
list of bots) onto the server, so there is a single call from
the web page; we will then be able to optimize the performance
of the rebaselining better.

Also remove the 'optimizebaseline' entry point on garden-o-matic
(and the client-side call) since we don't need it any more.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaselineall):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1:30 PM Changeset in webkit [118233] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

Remove minimum and maximum scroll position as they are no
longer required due to changes in ScrollViewBase.
https://bugs.webkit.org/show_bug.cgi?id=87298

Patch by Genevieve Mak <gmak@rim.com> on 2012-05-23
Reviewed by Antonio Gomes.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

  • WebKitSupport/InRegionScrollableArea.h:

(InRegionScrollableArea):

1:27 PM Changeset in webkit [118232] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Skip a test failing on the 536 branch due to missing WTR support.

  • platform/wk2/Skipped:
1:21 PM Changeset in webkit [118231] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Mac DRT should be able to load external URLs for replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=86191

Reviewed by Alexey Proskuryakov.

Let external URL requests go through if the test file is not a local file or hosted at localhost.
e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
"DumpRenderTree http://localhost:8000/".

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(isLocalhost):
(hostIsUsedBySomeTestsToGenerateError):
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

1:12 PM Changeset in webkit [118230] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] UI thread unnecessarily blocks on WebKit thread when servicing requestAnimationFrames
https://bugs.webkit.org/show_bug.cgi?id=87289

Patch by Andrew Lo <anlo@rim.com> on 2012-05-23
Reviewed by Antonio Gomes.

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

If UI thread cannot acquire DisplayRefreshMonitor mutex immediately,
avoid blocking on the mutex, it can trigger the frame change on the next
animation tick instead.

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

12:54 PM Changeset in webkit [118229] by Lucas Forschler
  • 5 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r117860.

12:43 PM Changeset in webkit [118228] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[Qt][Wk2] Assertion failure when selecting an option in select list with size attribute greater than one
https://bugs.webkit.org/show_bug.cgi?id=86974

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-23
Reviewed by Simon Hausmann.

Select list with size attribute greater than one will not initially have any
item in selected state (if no option has 'selected' tag), resulting in
m_selectedModelIndex in WebPopupMenuProxyQt to be invalid. Hence, need to check
whether the old index is invalid before accessing the item at that index.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml: Added new test that tests selection in a select list with size attribute value of 2.
  • UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Added.
  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::PopupMenuItemModel::select): Check whether old index is valid before accessing

the item at that index.

12:41 PM Changeset in webkit [118227] by Lucas Forschler
  • 12 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r117729.

12:38 PM Changeset in webkit [118226] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk/Source/WebCore

Implement DOM4 DOMError
https://bugs.webkit.org/show_bug.cgi?id=87055

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-23
Reviewed by Adam Barth.

Implement the DOMError class and it's IDL interface.

No new tests. Not testable yet, as it's not used.

  • WebCore.gypi:
  • dom/DOMError.cpp: Added.

(WebCore):
(WebCore::DOMError::DOMError):

  • dom/DOMError.h: Added.

(WebCore):
(DOMError):
(WebCore::DOMError::create):
(WebCore::DOMError::name):

  • dom/DOMError.idl: Added.
12:22 PM Changeset in webkit [118225] by kbr@google.com
  • 6 edits in trunk

REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing on Mac bots.
https://bugs.webkit.org/show_bug.cgi?id=87136

Reviewed by Stephen White.

Source/WebCore:

Fixed longstanding bug in GraphicsContext3D constructor in Mac
port, and logic error in tracking of texture bound to unit 0. Also
fixed up Cairo port's constructor by code inspection. This code is
ripe for cleanup; Bug 87198 filed for this.

Covered by existing tests.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Initialize missing members.

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Correctly initialize m_activeTexture.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::bindTexture):

Fix logic error in tracking of texture bound to unit 0.

LayoutTests:

Unskipped tests.

  • platform/mac/Skipped:
12:20 PM Internals_Hackathon edited by marcelo.lira@openbossa.org
(diff)
12:12 PM Changeset in webkit [118224] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Skip the IFrame Seamless tests on the 536 branch because IFRAME_SEAMLESS is diabled on the 536 branch.

  • platform/mac/Skipped:
12:09 PM Changeset in webkit [118223] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Change acceptMIMETypes member to acceptTypes now that file extensions are legal accept types
https://bugs.webkit.org/show_bug.cgi?id=87271

Patch by Raymes Khoury <raymes@chromium.org> on 2012-05-23
Reviewed by Darin Fisher.

  • public/WebFileChooserParams.h:

(WebFileChooserParams):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

12:03 PM Changeset in webkit [118222] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r117698.

12:01 PM Changeset in webkit [118221] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Skip the CSS Regions tests on the 536 branch because CSS_REGIONS is disabled on the 536 branch.

  • platform/mac/Skipped:
12:00 PM Changeset in webkit [118220] by Lucas Forschler
  • 5 edits in branches/safari-536-branch/Source

Merged r117744.

11:57 AM Changeset in webkit [118219] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Layers on main thread should get a RenderSurface for animating transform only if masksToBounds is true also
https://bugs.webkit.org/show_bug.cgi?id=87184

Reviewed by James Robinson.

Source/WebCore:

Layers on main thread get a RenderSurface if their impl counterpart may
have a RenderSurface due to its animating transform. We currently create
a RenderSurface for all layers with an animating transform and
a descendant that drawsContents. But a RenderSurface on impl also
implies that the layer masksToBounds. So only make a RenderSurface on
main thread when the layer also masksToBounds.

Modified unit test CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

11:53 AM Changeset in webkit [118218] by pilgrim@chromium.org
  • 8 edits
    1 copy in trunk/Source

[Chromium] Move queryLocalizedString to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85762

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::queryLocalizedString):

  • chromium/public/WebLocalizedString.h: Added.

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::getPluginList):

  • public/platform/WebLocalizedString.h:
  • src/LocalizedStrings.cpp:

(WebCore::query):

11:51 AM Changeset in webkit [118217] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117625.

11:49 AM Changeset in webkit [118216] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source/WebCore

Merged r117501.

11:47 AM Changeset in webkit [118215] by Lucas Forschler
  • 3 edits
    4 copies in branches/safari-536-branch

Merged r116543.

11:45 AM Changeset in webkit [118214] by Lucas Forschler
  • 3 edits
    6 copies in branches/safari-536-branch

Merged r116486.

11:45 AM Changeset in webkit [118213] by Chris Fleizach
  • 4 edits
    2 adds in trunk

Source/WebCore: Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
https://bugs.webkit.org/show_bug.cgi?id=86029

Reviewed by Abhishek Arya.

Test: accessibility/content-changed-notification-causes-crash.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isDetached):
(AccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::contentChanged):

LayoutTests: Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
https://bugs.webkit.org/show_bug.cgi?id=86029

Reviewed by Abhishek Arya.

  • accessibility/content-changed-notification-causes-crash-expected.txt: Added.
  • accessibility/content-changed-notification-causes-crash.html: Added.
11:36 AM Changeset in webkit [118212] by Lucas Forschler
  • 18 edits in branches/safari-536-branch/Source

Merged r116319.

11:33 AM Internals_Hackathon edited by jesus@webkit.org
(diff)
11:31 AM Changeset in webkit [118211] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r116188): After exiting full screen, Safari window is frozen, then inline video speeds through frames as it catches up with audio
https://bugs.webkit.org/show_bug.cgi?id=87206

Reviewed by Darin Adler.

When re-enabling the Safari window's autodisplay flag, also force the window to re-display.
Otherwise, the window will not repaint itself until it is forced to by user interaction.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):

11:29 AM Changeset in webkit [118210] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Encapsulated some calculations for whether portions of the heap are empty
https://bugs.webkit.org/show_bug.cgi?id=87210

Reviewed by Gavin Barraclough.

This is a step toward incremental DOM finalization.

  • heap/Heap.cpp:

(JSC::Heap::~Heap): Explicitly call freeAllBlocks() instead of relying
implicitly on all blocks thinking they're empty. In future, we may
choose to tear down the heap without first setting all data structures
to "empty".

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::gatherDirtyCells): Renamed markCountIsZero to isEmpty,
in preparation for making it check for outstanding finalizers in addition
to marked cells.

  • heap/MarkedSpace.cpp:

(Take):
(JSC::Take::Take):
(JSC::Take::operator()):
(JSC::Take::returnValue):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::freeAllBlocks): Refactored the "Take" functor to support
a conditional isEmpty check, so it dould be shared by shrink() and freeAllBlocks().

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::WeakBlock):
(JSC::WeakBlock::visitLiveWeakImpls):
(JSC::WeakBlock::visitDeadWeakImpls):

  • heap/WeakBlock.h:

(WeakBlock):
(JSC::WeakBlock::isEmpty):

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep):
(JSC::WeakSet::shrink): Use isEmpty(), in preparation for changes in
its implementation.

11:24 AM Changeset in webkit [118209] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Fix memory leak in FontHolder.
https://bugs.webkit.org/show_bug.cgi?id=87281

Reviewed by Kevin Ollivier.

11:23 AM Changeset in webkit [118208] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening - one more media/track test is crashy.

  • platform/chromium/test_expectations.txt:
11:22 AM Changeset in webkit [118207] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Make sure we do not create a substitute font if the facename is not found.
https://bugs.webkit.org/show_bug.cgi?id=87280

Reviewed by Kevin Ollivier.

11:17 AM Changeset in webkit [118206] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Implement transparency layer support.
https://bugs.webkit.org/show_bug.cgi?id=87279

Reviewed by Kevin Ollivier.

11:11 AM Changeset in webkit [118205] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

GenericClock loses precision due to float->double conversion.
https://bugs.webkit.org/show_bug.cgi?id=87227

Reviewed by Darin Adler.

No new tests; fixes media/media-controller-time.html on Chromium.

Only narrow to float after the entire calculation is complete. This requires now() and m_offset
to be double-precision.

  • platform/ClockGeneric.cpp:

(ClockGeneric::currentTime):
(ClockGeneric::now): Make double-precision.

  • platform/ClockGeneric.h:

(ClockGeneric): Make m_offset double-precision.

11:11 AM Changeset in webkit [118204] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

PlatformClockCM has uninitialized m_rate member.
https://bugs.webkit.org/show_bug.cgi?id=87217

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-controller-time.html

Initialize the m_rate member to a default of 1 (second-per-second), matching the implementation
of ClockGeneric.

  • platform/mac/PlatformClockCM.mm:

(PlatformClockCM::PlatformClockCM):

LayoutTests:

  • media/media-controller-time-expected.txt: Added.
  • media/media-controller-time.html: Added.
11:02 AM Changeset in webkit [118203] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r118096.
http://trac.webkit.org/changeset/118096
https://bugs.webkit.org/show_bug.cgi?id=87285

caused multiple crashes on the mac bots (Requested by
jessieberlin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

  • dom/ContainerNodeAlgorithms.h:
11:00 AM Changeset in webkit [118202] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit/chromium

Build fix.

Not reviewed.

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

10:46 AM Changeset in webkit [118201] by commit-queue@webkit.org
  • 2 edits in trunk

[BlackBerry] Reset JS state for each test
https://bugs.webkit.org/show_bug.cgi?id=86899

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-05-23
Reviewed by Nikolas Zimmermann.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp: (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
10:41 AM Changeset in webkit [118200] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

fast/sub-pixel/layout-boxes-with-zoom.html fails at 166% zoom on Windows only
https://bugs.webkit.org/show_bug.cgi?id=87282

Unreviewed. Marking fast/sub-pixel/layout-boxes-with-zoom.html as failing on Chromium Windows.

  • platform/chromium/test_expectations.txt:
10:33 AM Changeset in webkit [118199] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Speed up traverseNextNode when called on a ContainerNode or Element
https://bugs.webkit.org/show_bug.cgi?id=87224

Reviewed by Geoffrey Garen.

  • dom/ContainerNode.h: Added overrides of traverseNextNode for ContainerNode.

That way, when we know at compile time something is ContainerNode, we can
skip a branch at the start of this hot function.

10:32 AM Changeset in webkit [118198] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] In wxWebKit release builds on MSW, keep release settings but also build the
debug symbols for easier debugging.
https://bugs.webkit.org/show_bug.cgi?id=87151

Reviewed by Kevin Ollivier.

10:31 AM Changeset in webkit [118197] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use PluginDataNone.cpp always when NETSCAPE_PLUGIN_API is OFF
https://bugs.webkit.org/show_bug.cgi?id=87096

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-23
Reviewed by Andy Estes.

Fix a build error by adding an extra check in PluginData.cpp to use
PluginStrategy only when NETSCAPE_PLUGIN_API is ON.

No new tests. This is only a build fix.

  • plugins/PluginData.cpp:

(WebCore):

10:29 AM Changeset in webkit [118196] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Fix scrollbar drawing under wxGTK.
https://bugs.webkit.org/show_bug.cgi?id=87150

Reviewed by Kevin Ollivier.

10:21 AM Changeset in webkit [118195] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening - inspector/profiler/heap-snapshot-summary-show-ranges.html
flakes on non-debug test runs too.

  • platform/chromium/test_expectations.txt:
10:17 AM Changeset in webkit [118194] by Antti Koivisto
  • 39 edits in trunk/Source/WebCore

Rename StyleSheetInternal to StyleSheetContents
https://bugs.webkit.org/show_bug.cgi?id=87272

Reviewed by Andreas Kling.

The name is more descriptive and the code reads better.

Plain "StyleSheet" would be good too but that is a CSSOM type and the name can't be used without
changing idl code generation and resolving bunch of other issues.

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):

  • css/CSSImportRule.h:

(WebCore):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::setParentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(StyleRuleImport):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSRule.cpp:

(WebCore::CSSRule::parserContext):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetContents::estimatedSizeInBytes):
(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::~StyleSheetContents):
(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::ruleCount):
(WebCore::StyleSheetContents::clearCharsetRule):
(WebCore::StyleSheetContents::clearRules):
(WebCore::StyleSheetContents::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):
(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):
(WebCore::StyleSheetContents::isLoading):
(WebCore::StyleSheetContents::checkLoaded):
(WebCore::StyleSheetContents::notifyLoadedSheet):
(WebCore::StyleSheetContents::startLoadingDynamicSheet):
(WebCore::StyleSheetContents::rootStyleSheet):
(WebCore::StyleSheetContents::singleOwnerNode):
(WebCore::StyleSheetContents::singleOwnerDocument):
(WebCore::StyleSheetContents::completeURL):
(WebCore::StyleSheetContents::addSubresourceStyleURLs):
(WebCore::StyleSheetContents::parentStyleSheet):
(WebCore::StyleSheetContents::registerClient):
(WebCore::StyleSheetContents::unregisterClient):
(WebCore::StyleSheetContents::addedToMemoryCache):
(WebCore::StyleSheetContents::removedFromMemoryCache):
(WebCore::CSSStyleSheet::createInline):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::willMutateRules):
(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::cssRules):

  • css/CSSStyleSheet.h:

(WebCore::StyleSheetContents::create):
(StyleSheetContents):
(WebCore::StyleSheetContents::copy):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::contents):
(CSSStyleSheet):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(WebCore):
(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore):
(PropertySetCSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):

  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • css/StyleResolver.cpp:

(RuleSet):
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::styleSheetsUseRemUnits):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

  • loader/cache/CachedCSSStyleSheet.h:

(WebCore):
(CachedCSSStyleSheet):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

10:16 AM Changeset in webkit [118193] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening - add timeout and crash expectations for a few tests.

  • platform/chromium/test_expectations.txt:
9:56 AM Changeset in webkit [118192] by Darin Adler
  • 99 edits in trunk/Source/WebCore

Use ContainerNode instead of Node where possible
https://bugs.webkit.org/show_bug.cgi?id=87220

Reviewed by Geoffrey Garen.

It's better to use a more specific type; in some cases we even generate
more efficient code if we have a more specific type. Also, we want any
type casts to be as close as possible to the corresponding type checks,
so eliminating these uses of toContainerNode is a plus, also.

  • dom/ContainerNodeAlgorithms.h: Changed insertionPoint to be a ContainerNode

instead of a Node. Fixed spelling error "inseretions". Changed
(WebCore::ChildFrameDisconnector::Target::Target): Changed type of frame owner
element to HTMLFrameOwnerElement from Node.

  • dom/DocumentType.cpp:

(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):

  • dom/DocumentType.h:
  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):

  • dom/Element.h:
  • dom/Node.cpp:

(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):

  • dom/Node.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

  • dom/ProcessingInstruction.h:
  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::insertedInto):

  • dom/ScriptElement.h:
  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):

  • html/FormAssociatedElement.h:
  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):

  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInsertions):

  • html/HTMLBodyElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInsertions):
(WebCore::HTMLFormElement::removedFrom):

  • html/HTMLFormElement.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInsertions):

  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):

  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):

  • html/HTMLInputElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):

  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):

  • html/HTMLMapElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):

  • html/HTMLMediaElement.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::insertedInto):

  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):

  • html/HTMLObjectElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::insertedInto):

  • html/HTMLOptionElement.h:
  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::insertedInto):

  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::insertedInto):

  • html/HTMLSelectElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):

  • html/HTMLSourceElement.h:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):

  • html/HTMLStyleElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::insertedInto):

  • html/HTMLTextFormControlElement.h:
  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):

  • html/HTMLTitleElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::removedFrom):

  • html/HTMLTrackElement.h:
  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

  • mathml/MathMLMathElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::removedFrom):

  • svg/SVGElement.h:
  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):

  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):

  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::insertedInto):

  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):

  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::insertedInto):

  • svg/SVGImageElement.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::insertedInto):

  • svg/SVGScriptElement.h:
  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):

  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):

  • svg/SVGStyledElement.h:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):

  • svg/SVGTRefElement.h:
  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedInto):

  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):

  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):

  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

  • svg/SVGVKernElement.h:
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):

  • svg/animation/SVGSMILElement.h:

Changed arguments of insertedInto and removedFrom to ContainerNode instead of Node.
Did the same with didNotifyDescendantInsertions, while fixing the typo in its name.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Put a typecast toHTMLElement here.
The check for isListElement and isLegacyAppleStyleSpan takes care of the type checking.
(WebCore::ReplaceSelectionCommand::insertAsListItems): Changed this function to take
an HTMLElement instead of a Node, then we can drop use of the toContainerNode function.

  • editing/ReplaceSelectionCommand.h:
  • editing/TextIterator.cpp: Fixed a typo in a comment.
9:47 AM Changeset in webkit [118191] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

9:46 AM Changeset in webkit [118190] by Lucas Forschler
  • 1 copy in tags/Safari-536.13.1

New Tag.

9:46 AM Changeset in webkit [118189] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

9:44 AM Changeset in webkit [118188] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r117539.

9:32 AM Changeset in webkit [118187] by Darin Adler
  • 2 edits in trunk/Source/WTF

Optimize iteration of empty hash tables
https://bugs.webkit.org/show_bug.cgi?id=87215

Reviewed by Geoffrey Garen.

Iteration of empty hash tables was showing up on simple page loading
profiles due to the use of hash tables in the
NodeListsNodeData::invalidateCaches and
NodeListsNodeData::invalidateCachesThatDependOnAttributes functions.
It's worth optimizing the case of an empty table.

  • wtf/HashTable.h:

(WTF::HashTable::begin): Return the known-good end iterator when the
table is empty. This makes iterating an empty table faster because we
avoid skipping empty and deleted buckets.

9:30 AM Changeset in webkit [118186] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Add crashing expectation for more media/track tests:
track-language-preference.html, track-load-from-element-readyState.html, and
track-webvtt-tc019-cue-size.html - tracked in http://webkit.org/b/87258

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
9:20 AM Changeset in webkit [118185] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unskip sub-pixel tests on chromium now that they flag has been turned on (in r 117815).

  • platform/chromium/test_expectations.txt:
9:17 AM Changeset in webkit [118184] by eae@chromium.org
  • 14 edits
    2 adds in trunk/LayoutTests

Add test for subpixel precision in DOM APIs
https://bugs.webkit.org/show_bug.cgi?id=85534

Reviewed by Eric Seidel.

Add test for increased precision due to subpixel support in the
getBoundingClientRect api. Also test that clientWidth returns the pixel
snapped value.

  • fast/sub-pixel/client-rect-has-subpixel-precision-expected.html: Added.
  • fast/sub-pixel/client-rect-has-subpixel-precision.html: Added.
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Mark as skipped on all platforms but chromium for now.

9:07 AM Changeset in webkit [118183] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Add an API to enable and disable composited layer indicators
https://bugs.webkit.org/show_bug.cgi?id=87053

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-23
Reviewed by Carlos Garcia Campos.

Add a WebKitSetting that allows the client to enable and disable debug
borders and repaint counters for accelerated content.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Added.
(webKitSettingsGetProperty): Added.
(webkit_settings_class_init): Add the new property.
(webkit_settings_set_draw_compositing_indicators): Added.
(webkit_settings_get_draw_compositing_indicators): Added.

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API points to the

documentation.

  • UIProcess/API/gtk/test/TestWebKitSettings.h: Add a new unit test.
9:02 AM Changeset in webkit [118182] by commit-queue@webkit.org
  • 16 edits in trunk

Web Inspector: filter out debugging stuff from the heap class view
https://bugs.webkit.org/show_bug.cgi?id=86723

Source/WebCore:

We mark objects that are accessible from user roots (e.g. Window)
with pageObject attribute. This fix filters out all non-pageObjects
from the classes view.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-23
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.isPageObject):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):

LayoutTests:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-23
Reviewed by Yury Semikhatsky.

  • inspector/profiler/heap-snapshot-comparison-dom-groups-change.html:
  • inspector/profiler/heap-snapshot-comparison-show-all.html:
  • inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html:
  • inspector/profiler/heap-snapshot-containment-show-all.html:
  • inspector/profiler/heap-snapshot-containment-show-next.html:
  • inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html:
  • inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html:
  • inspector/profiler/heap-snapshot-dominators-show-all.html:
  • inspector/profiler/heap-snapshot-dominators-show-next.html:
  • inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html:
  • inspector/profiler/heap-snapshot-dominators-sorting.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):

  • inspector/profiler/heap-snapshot.html:
8:50 AM Changeset in webkit [118181] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Move myself to reviewers.

  • Scripts/webkitpy/common/config/committers.py:
8:32 AM Changeset in webkit [118180] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

[EFL][DRT] Today's ingredients for a green bot
https://bugs.webkit.org/show_bug.cgi?id=87244

Unreviewed, EFL gardening.

Some rebaselines, and moving out a set of new crashes that
need more investigation.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-23

  • platform/efl/fast/css-generated-content/inline-display-types-expected.png:
  • platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/efl/fast/inline-block/001-expected.png:
  • platform/efl/fast/inline-block/001-expected.txt:
  • platform/efl/test_expectations.txt:
7:29 AM Changeset in webkit [118179] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Add crashing expectation for media/video-src-invalid-remove.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
7:26 AM Changeset in webkit [118178] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSSRegions]Implement NamedFlow::name attribute
https://bugs.webkit.org/show_bug.cgi?id=79645

Source/WebCore:

Implementation for the NamedFlow::name attribute per the CSS Regions WD 3-May-2012 recommendation:
http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-23
Reviewed by Andreas Kling.

Test: fast/regions/webkit-named-flow-name.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::name):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Test for the NamedFlow::name attribute per the CSS Regions WD 3-May-2012 recommendation:
http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-23
Reviewed by Andreas Kling.

  • fast/regions/webkit-named-flow-name-expected.txt: Added.
  • fast/regions/webkit-named-flow-name.html: Added.
7:16 AM Changeset in webkit [118177] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Let the compiler generate FontFamily's copy ctor and assignment operator.

Blindly rubberstamped by the brave Antti Koivisto.

  • platform/graphics/FontFamily.cpp:
  • platform/graphics/FontFamily.h:
7:08 AM Changeset in webkit [118176] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

CSSParser: Simplify StylePropertySet creation.
<http://webkit.org/b/87259>

Reviewed by Alexis Menard.

Turn CSSParser's filteredProperties() into createStylePropertySet() which filters the parsed
properties and creates a new StylePropertySet, adopting the vector to avoid the Vector copy we
were previously incurring.

Added a StylePropertyVector typedef for Vector<CSSProperty, 4> since we need to pass this type
to the constructor for Vector::swap() to work.

And thus StylePropertySet::create(const Vector<CSSProperty>&, CSSParserMode) became
StylePropertySet::adopt(StylePropertyVector&, CSSParserMode).

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):

  • css/CSSParser.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
(SameSizeAsStylePropertySet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::adopt):
(StylePropertySet):

7:05 AM Changeset in webkit [118175] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Kill some frivolous null-checking of Element::m_attributeData.
<http://webkit.org/b/87248>

Reviewed by Antti Koivisto.

Replace unnecessary Element::m_attributeData with assertions where it makes sense.
Others are flat out removed because it should be obvious from context that it's non-null.
E.g if an attribute has changed, we're obviously storing it somewhere.

Also added a short-circuit to Element::normalize() if there are no Attr objects
associated with the element.

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::attributeChanged):
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::normalizeAttributes):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

6:54 AM Changeset in webkit [118174] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Let Element::detachAttribute() handle removal of the attribute.
<http://webkit.org/b/87242>

Reviewed by Antti Koivisto.

All the call sites were removing the attribute after detaching it, so move
that into detachAttribute(). The function name already made it sound like it
removes the attribute anyway.

Also sprinkle some assertions wrt being called with guaranteed presence of
attributeData() and the provided index in the attribute vector.

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttributeNode):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):

6:50 AM Changeset in webkit [118173] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Streamline Element teardown for the no-Attr-objects case.
<http://webkit.org/b/87228>

Reviewed by Antti Koivisto.

Dodge one function call in ~Element() if the element has no Attr objects
associated (the typical case.)

Renamed detachAttributes to detachAttrObjectsFromElement to reduce ambiguity.

  • dom/Element.cpp:

(WebCore::Element::~Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::clearAttributes):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

6:48 AM Changeset in webkit [118172] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r118157.
http://trac.webkit.org/changeset/118157
https://bugs.webkit.org/show_bug.cgi?id=87100

Newly added tests are not connected to 8483 bug.
editing/style directory should be unskiped first.

  • platform/efl/test_expectations.txt:
6:39 AM Changeset in webkit [118171] by commit-queue@webkit.org
  • 166 edits
    1 copy
    19 adds in trunk/LayoutTests

[EFL][DRT] Rebaseline test results for BUG 86355
https://bugs.webkit.org/show_bug.cgi?id=86956

Unreviewed, EFL gardening.

Updated test results for BUG 86355.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-23

  • platform/efl/compositing/animation/state-at-end-event-transform-layer-expected.png:
  • platform/efl/compositing/animation/state-at-end-event-transform-layer-expected.txt:
  • platform/efl/compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
  • platform/efl/compositing/color-matching/image-color-matching-expected.png:
  • platform/efl/compositing/color-matching/image-color-matching-expected.txt:
  • platform/efl/compositing/color-matching/pdf-image-match-expected.png:
  • platform/efl/compositing/color-matching/pdf-image-match-expected.txt:
  • platform/efl/compositing/compositing-visible-descendant-expected.png:
  • platform/efl/compositing/compositing-visible-descendant-expected.txt:
  • platform/efl/compositing/direct-image-compositing-expected.png:
  • platform/efl/compositing/direct-image-compositing-expected.txt:
  • platform/efl/compositing/generated-content-expected.png:
  • platform/efl/compositing/generated-content-expected.txt:
  • platform/efl/compositing/geometry/abs-position-inside-opacity-expected.png:
  • platform/efl/compositing/geometry/abs-position-inside-opacity-expected.txt:
  • platform/efl/compositing/geometry/clipping-foreground-expected.png:
  • platform/efl/compositing/geometry/clipping-foreground-expected.txt:
  • platform/efl/compositing/geometry/composited-html-size-expected.png:
  • platform/efl/compositing/geometry/composited-html-size-expected.txt:
  • platform/efl/compositing/geometry/fixed-in-composited-expected.png:
  • platform/efl/compositing/geometry/fixed-in-composited-expected.txt:
  • platform/efl/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/efl/compositing/geometry/layer-due-to-layer-children-deep-expected.txt:
  • platform/efl/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/efl/compositing/geometry/layer-due-to-layer-children-expected.txt:
  • platform/efl/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
  • platform/efl/compositing/geometry/outline-change-expected.png:
  • platform/efl/compositing/geometry/outline-change-expected.txt:
  • platform/efl/compositing/geometry/partial-layout-update-expected.png:
  • platform/efl/compositing/geometry/partial-layout-update-expected.txt:
  • platform/efl/compositing/geometry/root-layer-update-expected.png:
  • platform/efl/compositing/geometry/root-layer-update-expected.txt:
  • platform/efl/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png:
  • platform/efl/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt:
  • platform/efl/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/efl/compositing/geometry/video-fixed-scrolling-expected.txt:
  • platform/efl/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/efl/compositing/geometry/video-opacity-overlay-expected.txt:
  • platform/efl/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/efl/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/efl/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/efl/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
  • platform/efl/compositing/images/direct-image-background-color-expected.png:
  • platform/efl/compositing/images/direct-image-background-color-expected.txt:
  • platform/efl/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/efl/compositing/layers-inside-overflow-scroll-expected.txt:
  • platform/efl/compositing/masks/direct-image-mask-expected.png:
  • platform/efl/compositing/masks/direct-image-mask-expected.txt:
  • platform/efl/compositing/masks/masked-ancestor-expected.png:
  • platform/efl/compositing/masks/masked-ancestor-expected.txt:
  • platform/efl/compositing/masks/multiple-masks-expected.png:
  • platform/efl/compositing/masks/multiple-masks-expected.txt:
  • platform/efl/compositing/masks/simple-composited-mask-expected.png:
  • platform/efl/compositing/masks/simple-composited-mask-expected.txt:
  • platform/efl/compositing/overflow/ancestor-overflow-expected.png:
  • platform/efl/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
  • platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/efl/compositing/overflow/overflow-compositing-descendant-expected.txt:
  • platform/efl/compositing/overflow/overflow-positioning-expected.png:
  • platform/efl/compositing/overflow/overflow-positioning-expected.txt:
  • platform/efl/compositing/overflow/overflow-scroll-expected.png:
  • platform/efl/compositing/overflow/overflow-scroll-expected.txt:
  • platform/efl/compositing/overflow/parent-overflow-expected.png:
  • platform/efl/compositing/overflow/parent-overflow-expected.txt:
  • platform/efl/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/efl/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/efl/compositing/overflow/scrollbar-painting-expected.png:
  • platform/efl/compositing/overflow/scrollbar-painting-expected.txt:
  • platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
  • platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
  • platform/efl/compositing/plugins/1x1-composited-plugin-expected.txt: Added.
  • platform/efl/compositing/plugins/composited-plugin-expected.png:
  • platform/efl/compositing/plugins/composited-plugin-expected.txt:
  • platform/efl/compositing/plugins/large-to-small-composited-plugin-expected.txt: Added.
  • platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/efl/compositing/reflections/animation-inside-reflection-expected.txt:
  • platform/efl/compositing/reflections/compositing-change-inside-reflection-expected.png:
  • platform/efl/compositing/reflections/compositing-change-inside-reflection-expected.txt:
  • platform/efl/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/efl/compositing/reflections/deeply-nested-reflections-expected.txt:
  • platform/efl/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/efl/compositing/reflections/load-video-in-reflection-expected.txt:
  • platform/efl/compositing/reflections/masked-reflection-on-composited-expected.png:
  • platform/efl/compositing/reflections/masked-reflection-on-composited-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-animated-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-mask-change-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-mask-change-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-on-overflow-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-opacity-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-opacity-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-size-change-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-size-change-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-transformed-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-transformed2-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/efl/compositing/reflections/nested-reflection-transition-expected.txt:
  • platform/efl/compositing/reflections/reflection-in-composited-expected.png:
  • platform/efl/compositing/reflections/reflection-in-composited-expected.txt:
  • platform/efl/compositing/reflections/reflection-opacity-expected.png:
  • platform/efl/compositing/reflections/reflection-opacity-expected.txt:
  • platform/efl/compositing/reflections/reflection-ordering-expected.png:
  • platform/efl/compositing/reflections/reflection-ordering-expected.txt:
  • platform/efl/compositing/reflections/reflection-positioning-expected.png:
  • platform/efl/compositing/reflections/reflection-positioning-expected.txt:
  • platform/efl/compositing/reflections/reflection-positioning2-expected.png:
  • platform/efl/compositing/reflections/reflection-positioning2-expected.txt:
  • platform/efl/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/efl/compositing/reflections/simple-composited-reflections-expected.txt:
  • platform/efl/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/efl/compositing/reflections/transform-inside-reflection-expected.txt:
  • platform/efl/compositing/repaint/become-overlay-composited-layer-expected.png:
  • platform/efl/compositing/repaint/become-overlay-composited-layer-expected.txt:
  • platform/efl/compositing/repaint/composited-document-element-expected.png:
  • platform/efl/compositing/repaint/composited-document-element-expected.txt:
  • platform/efl/compositing/repaint/layer-repaint-expected.png:
  • platform/efl/compositing/repaint/layer-repaint-expected.txt:
  • platform/efl/compositing/repaint/layer-repaint-rects-expected.png:
  • platform/efl/compositing/repaint/layer-repaint-rects-expected.txt:
  • platform/efl/compositing/repaint/opacity-between-absolute-expected.png:
  • platform/efl/compositing/repaint/opacity-between-absolute-expected.txt:
  • platform/efl/compositing/repaint/opacity-between-absolute2-expected.png:
  • platform/efl/compositing/repaint/opacity-between-absolute2-expected.txt:
  • platform/efl/compositing/self-painting-layers-expected.png:
  • platform/efl/compositing/self-painting-layers-expected.txt:
  • platform/efl/compositing/shadows/shadow-drawing-expected.png:
  • platform/efl/compositing/shadows/shadow-drawing-expected.txt:
  • platform/efl/compositing/sibling-positioning-expected.png:
  • platform/efl/compositing/sibling-positioning-expected.txt:
  • platform/efl/compositing/text-on-large-layer-expected.png:
  • platform/efl/compositing/text-on-large-layer-expected.txt:
  • platform/efl/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/efl/compositing/transitions/scale-transition-no-start-expected.txt:
  • platform/efl/compositing/transitions/singular-scale-transition-expected.png:
  • platform/efl/compositing/transitions/singular-scale-transition-expected.txt:
  • platform/efl/compositing/video/video-background-color-expected.png:
  • platform/efl/compositing/video/video-background-color-expected.txt:
  • platform/efl/compositing/visibility/visibility-composited-expected.png: Added.
  • platform/efl/compositing/visibility/visibility-composited-expected.txt: Added.
  • platform/efl/compositing/visibility/visibility-composited-transforms-expected.png: Copied from LayoutTests/platform/efl/mathml/presentation/fenced-expected.png.
  • platform/efl/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
  • platform/efl/mathml/presentation/attributes-expected.png:
  • platform/efl/mathml/presentation/attributes-expected.txt:
  • platform/efl/mathml/presentation/fenced-expected.png:
  • platform/efl/mathml/presentation/fenced-expected.txt:
  • platform/efl/mathml/presentation/fenced-mi-expected.png:
  • platform/efl/mathml/presentation/fenced-mi-expected.txt:
  • platform/efl/mathml/presentation/fractions-expected.png:
  • platform/efl/mathml/presentation/fractions-expected.txt:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/efl/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/efl/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/efl/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/efl/mathml/presentation/sub-expected.png:
  • platform/efl/mathml/presentation/sub-expected.txt:
  • platform/efl/mathml/presentation/subsup-expected.png:
  • platform/efl/mathml/presentation/subsup-expected.txt:
  • platform/efl/mathml/presentation/sup-expected.png:
  • platform/efl/mathml/presentation/sup-expected.txt:
  • platform/efl/mathml/presentation/tables-expected.png:
  • platform/efl/mathml/presentation/tables-expected.txt:
  • platform/efl/mathml/presentation/tokenElements-expected.png:
  • platform/efl/mathml/presentation/tokenElements-expected.txt:
  • platform/efl/mathml/presentation/under-expected.png:
  • platform/efl/mathml/presentation/under-expected.txt:
  • platform/efl/mathml/presentation/underover-expected.png:
  • platform/efl/mathml/presentation/underover-expected.txt:
6:37 AM Changeset in webkit [118170] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Implements the registerProtocolHandler method and option.
https://bugs.webkit.org/show_bug.cgi?id=73638

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-23
Reviewed by Andreas Kling.

  • Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
6:31 AM Changeset in webkit [118169] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Fix crashing expectation for several media/ LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
6:23 AM Changeset in webkit [118168] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Set crashing expectation for several media/ LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
6:09 AM Changeset in webkit [118167] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix incomplete switch statement in CSSParser after r118082
https://bugs.webkit.org/show_bug.cgi?id=87250

Reviewed by Alexis Menard.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

6:05 AM Changeset in webkit [118166] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

Unreviewed, rolling out r118105.
http://trac.webkit.org/changeset/118105
https://bugs.webkit.org/show_bug.cgi?id=87255

New LayoutTest is causing several cookie tests to fail on
numerous bots (Requested by steveblock on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

Source/WebCore:

  • platform/blackberry/CookieJarBlackBerry.cpp:

(WebCore::setCookies):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):
(WebCore):

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):

  • platform/blackberry/CookieMap.h:

(CookieMap):

LayoutTests:

  • http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Removed.
  • http/tests/cookies/js-get-and-set-http-only-cookie.php: Removed.
  • http/tests/cookies/script-tests/js-get-and-set-http-only-cookie.js: Removed.
6:04 AM Changeset in webkit [118165] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Small refactoring WebPage::confirmComposition.
https://bugs.webkit.org/show_bug.cgi?id=87243

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-05-23
Reviewed by Kenneth Rohde Christiansen.

Change nested if into an early return to reduce complexity.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::confirmComposition):

6:00 AM Changeset in webkit [118164] by zandobersek@gmail.com
  • 6 edits in trunk

[Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
https://bugs.webkit.org/show_bug.cgi?id=87221

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - covered by fast/events/keydown-leftright-keys.html.

Windows key code for shift, control and alt keys should respect the
left or right position of that key. This way the DOM location code of
a key event is properly determined for these keys.

  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):

Tools:

Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
rightShift key names into proper GDK key symbols.

  • DumpRenderTree/gtk/EventSender.cpp:

(createKeyPressEvent):

LayoutTests:

Remove failing test expectations for fast/events/keydown-leftright-keys.html,
the test should pass now.

  • platform/gtk/test_expectations.txt:
5:15 AM Changeset in webkit [118163] by ahf@0x90.dk
  • 2 edits
    1 add in trunk/Source/WebKit2

[Qt] Missing tests for the evaluateJavaScript API
https://bugs.webkit.org/show_bug.cgi?id=86351

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:
  • UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Added.
5:08 AM Changeset in webkit [118162] by loislo@chromium.org
  • 6 edits in trunk

Web Inspector: eliminate getters from HeapSnapshot.js
https://bugs.webkit.org/show_bug.cgi?id=87241

getters can't be inlined by engine at the moment.
I found that conversion getters into functions gives us about 600 ms

RESULT heap-snapshot: switch-to-containment-view= 1920 ms
vs
RESULT heap-snapshot: switch-to-containment-view= 1367 ms

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdge.prototype.hasStringName):
(WebInspector.HeapSnapshotEdge.prototype.isElement):
(WebInspector.HeapSnapshotEdge.prototype.isHidden):
(WebInspector.HeapSnapshotEdge.prototype.isWeak):
(WebInspector.HeapSnapshotEdge.prototype.isInternal):
(WebInspector.HeapSnapshotEdge.prototype.isInvisible):
(WebInspector.HeapSnapshotEdge.prototype.isShortcut):
(WebInspector.HeapSnapshotEdge.prototype.name):
(WebInspector.HeapSnapshotEdge.prototype.node):
(WebInspector.HeapSnapshotEdge.prototype.nodeIndex):
(WebInspector.HeapSnapshotEdge.prototype.rawEdges):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotEdge.prototype.type):
(WebInspector.HeapSnapshotEdge.prototype._hasStringName):
(WebInspector.HeapSnapshotEdge.prototype._name):
(WebInspector.HeapSnapshotEdge.prototype._nameOrIndex):
(WebInspector.HeapSnapshotEdgeIterator.prototype.index):
(WebInspector.HeapSnapshotEdgeIterator.prototype.setIndex):
(WebInspector.HeapSnapshotEdgeIterator.prototype.item):
(WebInspector.HeapSnapshotRetainerEdge):
(WebInspector.HeapSnapshotRetainerEdge.prototype.clone):
(WebInspector.HeapSnapshotRetainerEdge.prototype.hasStringName):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isElement):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isHidden):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isInternal):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isInvisible):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isShortcut):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isWeak):
(WebInspector.HeapSnapshotRetainerEdge.prototype.name):
(WebInspector.HeapSnapshotRetainerEdge.prototype.node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.nodeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.setRetainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype._node):
(WebInspector.HeapSnapshotRetainerEdge.prototype._edge):
(WebInspector.HeapSnapshotRetainerEdge.prototype.toString):
(WebInspector.HeapSnapshotRetainerEdge.prototype.type):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.first):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.hasNext):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.index):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.setIndex):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.item):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.next):
(WebInspector.HeapSnapshotNode.prototype.canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.distanceToWindow):
(WebInspector.HeapSnapshotNode.prototype.className):
(WebInspector.HeapSnapshotNode.prototype.dominatorIndex):
(WebInspector.HeapSnapshotNode.prototype.edges):
(WebInspector.HeapSnapshotNode.prototype.edgesCount):
(WebInspector.HeapSnapshotNode.prototype.flags):
(WebInspector.HeapSnapshotNode.prototype.id):
(WebInspector.HeapSnapshotNode.prototype.isHidden):
(WebInspector.HeapSnapshotNode.prototype.isNative):
(WebInspector.HeapSnapshotNode.prototype.isSynthetic):
(WebInspector.HeapSnapshotNode.prototype.isWindow):
(WebInspector.HeapSnapshotNode.prototype.isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshotNode.prototype.isDetachedDOMTree):
(WebInspector.HeapSnapshotNode.prototype.isRoot):
(WebInspector.HeapSnapshotNode.prototype.name):
(WebInspector.HeapSnapshotNode.prototype.rawEdges):
(WebInspector.HeapSnapshotNode.prototype.retainedSize):
(WebInspector.HeapSnapshotNode.prototype.retainers):
(WebInspector.HeapSnapshotNode.prototype.selfSize):
(WebInspector.HeapSnapshotNode.prototype.type):
(WebInspector.HeapSnapshotNode.prototype._name):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNode.prototype._nextNodeIndex):
(WebInspector.HeapSnapshotNode.prototype._type):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshotNodeIterator.prototype.hasNext):
(WebInspector.HeapSnapshotNodeIterator.prototype.index):
(WebInspector.HeapSnapshotNodeIterator.prototype.setIndex):
(WebInspector.HeapSnapshotNodeIterator.prototype.item):
(WebInspector.HeapSnapshotNodeIterator.prototype.next):
(WebInspector.HeapSnapshot.prototype._allNodes):
(WebInspector.HeapSnapshot.prototype.rootNode):
(WebInspector.HeapSnapshot.prototype.get totalSize):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
(WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
(WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.isEmpty):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.item):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotEdgesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotNodesProvider):
(WebInspector.HeapSnapshotNodesProvider.prototype.nodePosition):
(WebInspector.HeapSnapshotNodesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByNodeField):

  • inspector/front-end/HeapSnapshotGridNodes.js:
  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty):

LayoutTests:

  • inspector/profiler/heap-snapshot.html:
5:00 AM Changeset in webkit [118161] by yurys@chromium.org
  • 7 edits in trunk

Web Inspector: Debugger should correctly show catch scope
https://bugs.webkit.org/show_bug.cgi?id=87197

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • bindings/v8/DebuggerScript.js: In case of Catch scope the scope object

is a synthetic one which means that it contains all standard object properties.
When passing this object further we need to leave only properties available in
the catch block(only variable thar stores the exception in fact).

LayoutTests:

Added test for "catch" block to the debugger test.

  • inspector/debugger/debugger-expand-scope-expected.txt:
  • inspector/debugger/debugger-expand-scope.html:
  • platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:
4:34 AM Changeset in webkit [118160] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=87233

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-23

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
4:19 AM Changeset in webkit [118159] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

[Qt] FloatSize Qt Support
https://bugs.webkit.org/show_bug.cgi?id=87237

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-23
Reviewed by Andreas Kling.

Source/WebCore:

No new functionality. No new tests.

  • Target.pri:
  • platform/graphics/FloatSize.h:

(FloatSize):

  • platform/graphics/qt/FloatSizeQt.cpp: Added.

(WebCore::FloatSize::FloatSize):
(WebCore::FloatSize::operator QSizeF):

Source/WebKit2:

Basic cleanup possible to new Qt support in FloatSize.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::layoutSize):

4:03 AM Changeset in webkit [118158] by vestbo@webkit.org
  • 11 edits
    2 adds in trunk

[Qt] Make the web view's url property follow the active url

https://bugs.webkit.org/show_bug.cgi?id=77554

The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.

In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.

An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.

Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.

Reviewed by Simon Hausmann.

3:56 AM Changeset in webkit [118157] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening editing/style tests, missing baselines.
https://bugs.webkit.org/show_bug.cgi?id=87100

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-23

  • platform/efl/test_expectations.txt: added tests regarding 84839 bug, missing baselines.
3:54 AM Changeset in webkit [118156] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt] Race condition in LayerTreeHost/Proxy can cause blank rendering
https://bugs.webkit.org/show_bug.cgi?id=87239

Reviewed by Kenneth Rohde Christiansen.

On the UI process side the WebLayerTreeRenderer/LayerTreeHostProxy pair is
created with m_active = false, which makes it ignore any incoming layer updates.
It remains inactive until the ContentsSGNode is created and setActive(true) is called.

On the web process side the LayerTreeHost is created with m_waitingForUIProcess = false.

Those two variables must be in sync, otherwise a race condition can
happen: The web process sends updates to the ui process before the
ContentsSGNode is created. This can happen for example when re-using an
existing WebProcess to create a QQuickWebView and load a page very fast
from the disk cache. The update arrives on the ui process side, but it
is discarded because setActive(true) hasn't been called yet. As a
result any updates that would for example create and populate the tiles
required for rendering are ignored.

This patch ensures that the variables are initialized with the same values and that calling
setActive(true) will trigger the rendering of the next frame.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setActive):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):

3:50 AM Changeset in webkit [118155] by vestbo@webkit.org
  • 5 edits in trunk

[Qt] Remove references to $$QT_SOURCE_TREE

With a modularized Qt, it's ambigious. What we really want is qtbase,
which qtcore is a proxy for (we assume it will always live in qtbase).

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-05-23
Reviewed by Tor Arne Vestbø.

3:49 AM Changeset in webkit [118154] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Enable HeapSnapshotRealWorker in production mode.
https://bugs.webkit.org/show_bug.cgi?id=87240

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-23
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

3:39 AM Changeset in webkit [118153] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix qmake conditional for c++-11 compat warnings

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-05-23
Reviewed by Tor Arne Vestbø.

3:08 AM Changeset in webkit [118152] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: inspector's Find is not consuming event as of r117974.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype.handleShortcut):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.handleShortcut):

2:55 AM Changeset in webkit [118151] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: enable drag-an-drop from the navigator panel.
https://bugs.webkit.org/show_bug.cgi?id=87238

Reviewed by Vsevolod Vlasov.

Making tree item draggable.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorSourceTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement.prototype._onmousedown.callback):
(WebInspector.NavigatorSourceTreeElement.prototype._onmousedown):
(WebInspector.NavigatorSourceTreeElement.prototype._ondragstart):

2:31 AM Changeset in webkit [118150] by apavlov@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/inspector/front-end/inspector.css

Merge 116946 - Web Inspector: [Styles] css properties copied into clipboard contain extra line breaks before color values
https://bugs.webkit.org/show_bug.cgi?id=86372

Reviewed by Vsevolod Vlasov.

The "display: block" property found in the ".swatch-inner" CSS class was causing the issue
(an additional \n was rendered in the plain text value).

  • inspector/front-end/inspector.css:

(.swatch-inner):

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388247

1:50 AM Changeset in webkit [118149] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKit spends ~20% of time in HTMLTextAreaElement::defaultValue() when opening a review page
https://bugs.webkit.org/show_bug.cgi?id=86813

Reviewed by Eric Seidel.

Replace String and calls to String::operator+= by StringBuilder and calls to append respectively.
While there are other optimizations we can implement such as not replacing all nodes in the shadow DOM,
or not serializing the value when detecting whether the value had changed, they require considerable
amount of refactoring and this change alone seems to buy us a lot so let us defer those 'til later time.

Also avoid the redundant call to setValue in childrenChanged when the value is dirty.
This should halve the time we spend in setting the value.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::defaultValue):

1:32 AM Changeset in webkit [118148] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Make QtWebError return the failing URL as a QString instead of QUrl

We don't want to use QUrl inside QtWebKit (only in the API layer), due
to how QUrl normalizes the url.

Reviewed by Simon Hausmann.

1:25 AM Changeset in webkit [118147] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][DRT] Webarchives tests gardening
https://bugs.webkit.org/show_bug.cgi?id=87225

Unreviewed. The EFL port has no support for webarchives, so the related testcases should
be put to test_expectations as expected to fail.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-23

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
12:56 AM Changeset in webkit [118146] by Carlos Garcia Campos
  • 14 edits
    8 adds in trunk/Source/WebKit2

[GTK] Add inspector API to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=87113

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/C/gtk/WKInspectorClientGtk.cpp: Added.

(WKInspectorSetInspectorClientGtk):

  • UIProcess/API/C/gtk/WKInspectorClientGtk.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebInspector.cpp: Added.

(webkitWebInspectorFinalize):
(webkit_web_inspector_init):
(webkit_web_inspector_class_init):
(openWindow): Emit WebKitWebInspector::open-window singal.
(didClose): Emit WebKitWebInspector::closed signal.
(bringToFront): Emit WebKitWebInspector::bring-to-front singal.
(inspectedURLChanged): Set the inspected URI and emit
GObject::notify signal if it changed.
(attach): Emit WebKitWebInspector::attach signal.
(detach): Emit WebKitWebInspector::detach signal.
(didChangeAttachedHeight): Set the attached height and emit
GObject::notify signal if it changed.
(webkitWebInspectorCreate): Ceate a new WebKitWebInspector object
for the given WKInspector. Also initialize and set the inspector
client.
(webkit_web_inspector_get_web_view): Return the web view used to
render the inspector.
(webkit_web_inspector_get_inspected_uri): Return the URI that is
being inspected.
(webkit_web_inspector_is_attached): Whether the inspector view is
currently attached.
(webkit_web_inspector_attach): Request to attach the inspector.
(webkit_web_inspector_detach): Request to detach the inspector.
(webkit_web_inspector_show): Request to show the inspector.
(webkit_web_inspector_close): Request to close the inspector.
(webkit_web_inspector_get_attached_height): Return the height that
the inspector view should have when attached.

  • UIProcess/API/gtk/WebKitWebInspector.h: Added.
  • UIProcess/API/gtk/WebKitWebInspectorPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_inspector): Return the WebKitWebInspector
associated to the web view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitWebInspector.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ad new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_web_inspector_get_type.

  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new test for the

inspector API.

  • UIProcess/API/gtk/tests/TestInspector.cpp: Added.

(testInspectorDefault):
(testInspectorCustom):
(testInspectorWindowDestroyed):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::showInWindowAndWaitUntilMapped): Add optional
parameter to create a toplevel or popup window.
(WebViewTest::resizeView): Helper function to set the widget
allocation to a given size.

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2.h: Include WebKitWebInspector.h
  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::inspectorView): Return the view used
to render the inspector.

  • UIProcess/gtk/WebInspectorClientGtk.cpp: Added.

(WebKit::WebInspectorClientGtk::openWindow):
(WebKit::WebInspectorClientGtk::didClose):
(WebKit::WebInspectorClientGtk::bringToFront):
(WebKit::WebInspectorClientGtk::inspectedURLChanged):
(WebKit::WebInspectorClientGtk::attach):
(WebKit::WebInspectorClientGtk::detach):
(WebKit::WebInspectorClientGtk::didChangeAttachedHeight):

  • UIProcess/gtk/WebInspectorClientGtk.h: Added.
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::inspectorViewDestroyed): Close the inspector page when
the inspector view is destroyed, instead of when the inspector
window is deleted, because the inspector view can now be inside a
window created by the user.
(WebKit::WebInspectorProxy::initializeInspectorClientGtk):
Initialze the inspector client.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add a
weak pointer to the inspector view to make sure it's NULL when
destroyed.
(WebKit::WebInspectorProxy::createInspectorWindow): Call
openWindow on the inspector client, and return early if the
callback was handled.
(WebKit::WebInspectorProxy::platformOpen): Connect to destroy
signal of the inspector view to close the page when the view is
destroyed.
(WebKit::WebInspectorProxy::platformDidClose): Call didClose on
the inspector client.
(WebKit::WebInspectorProxy::platformBringToFront): Call
bringToFront on the inspector client, and return early if the
callback was handled.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Call
inspectedURLChanged on the inspector client.
(WebKit::WebInspectorProxy::platformAttach): Call attach on the
inspector client and return if the callback was handled.
(WebKit::WebInspectorProxy::platformDetach): Call detach on the
inspector client and return if the callback was handled.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Call
didChangeAttachedHeight on the inspector client.

12:55 AM Changeset in webkit [118145] by fpizlo@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog entry to indicate that the last commit was merged from the dfgopt branch.

12:53 AM Changeset in webkit [118144] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should allow inlining in case of certain arity mismatches
https://bugs.webkit.org/show_bug.cgi?id=86059

Reviewed by Geoff Garen.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

12:45 AM Changeset in webkit [118143] by aboxhall@chromium.org
  • 5 edits in trunk

AX: Contenteditable tables should always be exposed as data tables
https://bugs.webkit.org/show_bug.cgi?id=87052

Reviewed by Chris Fleizach.

Source/WebCore:

Tested in accessibility/table-detection.html.

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable): Return true if the node is contenteditable.

LayoutTests:

  • accessibility/table-detection.html:
12:43 AM Changeset in webkit [118142] by commit-queue@webkit.org
  • 14 edits
    1 add in trunk

[EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
https://bugs.webkit.org/show_bug.cgi?id=85956

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-23
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add new "load,provisional,failed" signal on the frame and the view to
complement the "load,provisional" one.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidFailProvisionalLoad):

  • ewk/ewk_frame.cpp:

(ewk_frame_load_provisional_failed):

  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:
  • ewk/ewk_view.cpp:

(ewk_view_load_provisional_failed):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:

Tools:

Catch new "load,provisional,failed" signal and print
didFailProvisionalLoadWithError messages when LayoutTestController's
dumpFrameLoadCallbacks() returns true. Also make sure the
didFailLoadWithError message is not printed in case of provisional
load failure.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
(DumpRenderTreeChrome::onFrameLoadError):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip test cases which expect the DumpRenderTree to print
didFailProvisionalLoadWithError messages.
Add EFL expectation for
http/tests/loading/pdf-commit-load-callbacks.html.

  • platform/efl/Skipped:
  • platform/efl/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.

Use same expectation as for Qt.

  • platform/efl/test_expectations.txt:
12:40 AM Changeset in webkit [118141] by fpizlo@apple.com
  • 3 edits in branches/dfgopt/Source/JavaScriptCore

DFG CSE should eliminate redundant WeakJSConstants
https://bugs.webkit.org/show_bug.cgi?id=87179

Reviewed by Gavin Barraclough.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::weakConstantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNode.h:

(JSC::DFG::Node::weakConstant):

12:37 AM Changeset in webkit [118140] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
https://bugs.webkit.org/show_bug.cgi?id=86366

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-23
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add helper function to DumpRenderTreeSupportEfl to set the validation
message timer magnification.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Call Settings::setValidationMessageTimerMagnification(-1) between the tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Unskip fast/forms/validation-message-appearance.html and add EFL
expectation.

  • platform/efl/Skipped:
  • platform/efl/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/efl/fast/forms/validation-message-appearance-expected.txt: Added.
12:37 AM Changeset in webkit [118139] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a typo per Darin's comment.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRuns):

12:30 AM Changeset in webkit [118138] by fpizlo@apple.com
  • 12 edits in branches/dfgopt/Source/JavaScriptCore

DFG CSE should do redundant store elimination
https://bugs.webkit.org/show_bug.cgi?id=87161

Reviewed by Oliver Hunt.

This patch adds redundant store elimination. For example, consider this
code:

o.x = 42;
o.x = 84;

If o.x is speculated to be a well-behaved field, the first assignment is
unnecessary, since the second just overwrites it. We would like to
eliminate the first assignment in these cases. The need for this
optimization arises mostly from stores that our runtime requires. For
example:

o = {f:1, g:2, h:3};

This will have four assignments to the structure for the newly created
object - one assignment for the empty structure, one for {f}, one for
{f, g}, and one for {f, g, h}. We would like to only have the last of
those assigments in this case.

Intriguingly, doing so for captured variables breaks the way arguments
simplification used to work. Consider that prior to either arguments
simplification or store elimination we will have IR that looks like:

a: SetLocal(r0, Empty)
b: SetLocal(r1, Empty)
c: GetLocal(r0)
d: CreateArguments(@c)
e: SetLocal(r0, @d)
f: SetLocal(r1, @d)

Then redundant store elimination will eliminate the stores that
initialize the arguments registers to Empty, but then arguments
simplification eliminates the stores that initialize the arguments to
the newly created arguments - and at this point we no longer have any
stores to the arguments register, leading to hilarious crashes. This
patch therefore changes arguments simplification to replace
CreateArguments with JSConstant(Empty) rather than eliminating the
SetLocals. But this revealed bugs where arguments simplification was
being overzealous, so I fixed those bugs.

This is a minor speed-up on V8/early and a handful of other tests.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::uncheckedActivationRegister):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarStoreElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::uncheckedActivationRegisterFor):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isPhantomArguments):
(Node):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasStructureTransitionData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:29 AM Changeset in webkit [118137] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118001, r118011 and r118105.

  • platform/gtk/test_expectations.txt:
12:29 AM Changeset in webkit [118136] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

DFG variable capture analysis should work even if the variables arose through inlining
https://bugs.webkit.org/show_bug.cgi?id=85945

Reviewed by Oliver Hunt.

Merged r116555 from dfgopt.

This just changes how the DFG queries whether a variable is captured. It does not
change any user-visible behavior.

As part of this change, I further solidified the policy that the CFA behaves in an
undefined way for captured locals and queries about their values will not yield
reliable results. This will likely be changed in the future, but for now it makes
sense.

One fun part about this change is that it recognizes that the same variable may
be both captured and not, at the same time, because their live interval spans
inlining boundaries. This only happens in the case of arguments to functions that
capture their arguments, and this change treats them with just the right touch of
conservatism: they will be treated as if captured by the caller as well as the
callee.

Finally, this also adds captured variable reasoning to the InlineCallFrame, which
I thought might be useful for later tooling.

This is perf-neutral, since it does it does not make the DFG take advantage of this
new functionality in any way. In particular, it is still the case that the DFG will
not inline functions that use arguments reflectively or that create activations.

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::needsActivation):
(JSC::CodeBlock::argumentIsCaptured):
(JSC::CodeBlock::localIsCaptured):
(JSC::CodeBlock::isCaptured):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCFGSimplificationPhase.cpp:

(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::nameOfVariableAccessData):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::needsActivation):
(JSC::DFG::Graph::usesArguments):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isCaptured):

12:13 AM Changeset in webkit [118135] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip a now passing test.
12:11 AM Changeset in webkit [118134] by haraken@chromium.org
  • 28 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8::Null() in custom bindings (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=87209

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8::Null() in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):
(WebCore::toV8):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
(WebCore::toV8Slow):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

12:06 AM Changeset in webkit [118133] by haraken@chromium.org
  • 22 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8::Null() in custom bindings (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=87207

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8::Null() in custom bindings.

Also this patch makes V8DeviceMotionEventCustom::createAccelerationObject()
and V8DeviceMotionEventCustom::createRotationRateObject() static.

No tests. No change in behavior.

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

May 22, 2012:

11:59 PM Changeset in webkit [118132] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new, but failing tests.
  • platform/qt/printing/iframe-print-expected.png: Added after r118039.
  • platform/qt/printing/iframe-print-expected.txt: Added after r118039.
11:48 PM Changeset in webkit [118131] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

[Refactoring] ElementShadow::m_needsRedistributing should be on ContentDistributor
https://bugs.webkit.org/show_bug.cgi?id=87216

Reviewed by Kentaro Hara.

Moved ElementShadow::m_needsRedistributing to ContentDistributor::m_needsRedistributing

No new tests. No behavior change.

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsRedistributing):
(WebCore::ElementShadow::setNeedsRedistributing):

  • dom/ElementShadow.h:

(ElementShadow):

  • dom/ShadowRoot.h: Removed outdated declarations.
  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ContentDistributor):

  • html/shadow/ContentDistributor.h:

(WebCore::ContentDistributor::needsRedistributing):
(WebCore::ContentDistributor::setNeedsRedistributing):
(WebCore::ContentDistributor::clearNeedsRedistributing):

11:42 PM Changeset in webkit [118130] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a failing test.

  • platform/qt/Skipped:
11:36 PM Changeset in webkit [118129] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8::Null() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=87202

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8::Null() in CodeGeneratorV8.pm.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):

11:21 PM Changeset in webkit [118128] by kling@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Restore order to the ChangeLogiverse.

11:17 PM Changeset in webkit [118127] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Short-circuit Element::attrIfExists() when the Element has no Attr list.
<http://webkit.org/b/87214>

Patch by Hayato Ito <hayato@chromium.org> on 2012-05-22
Reviewed by Ryosuke Niwa.

This function was lukewarm on Dromaeo/dom-attr (0.4% of samples.)
Added an early return if !hasAttrList() to avoid the function call overhead of
ElementAttributeData::attrIfExists().

  • dom/Element.cpp:

(WebCore::Element::attrIfExists):

11:07 PM Changeset in webkit [118126] by fpizlo@apple.com
  • 10 edits in branches/dfgopt/Source/JavaScriptCore

Unreviewed, rollout http://trac.webkit.org/changeset/118108
https://bugs.webkit.org/show_bug.cgi?id=87161

The redundant store elimination is overzealous in some cases, because
it fails to catch implicit reads of captured local variables.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):

  • dfg/DFGCSEPhase.cpp:

(CSEPhase):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasStructureTransitionData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:40 PM Changeset in webkit [118125] by hayato@chromium.org
  • 5 edits in trunk

Remove an assertion since an event's target might be a shadow root if a text node is clicked.
https://bugs.webkit.org/show_bug.cgi?id=87072

Reviewed by Dimitri Glazkov.

Source/WebCore:

Tests: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching.html:
10:25 PM Changeset in webkit [118124] by Darin Adler
  • 3 edits in trunk/Tools
  • Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
10:24 PM Changeset in webkit [118123] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

[EFL] Implements the registerProtocolHandler method and option.
https://bugs.webkit.org/show_bug.cgi?id=73638

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-22
Reviewed by Andreas Kling.

The registerProtocolHandler() method allows Web sites to register themselves
as possible handlers for particular schemes.

http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler

.:

  • Source/cmake/OptionsEfl.cmake: Adds the build option.
  • Source/cmakeconfig.h.cmake: Adds the build option.

Source/WebCore:

  • CMakeLists.txt: Add page/NavigatorRegisterProtocolHandler.idl into WebCore_IDL_FILES.

Source/WebKit:

  • PlatformEfl.cmake: Adds the new file into the source list.

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp: Adds a new function.

(WebCore):
(WebCore::customHandlersDataCreate): Creates and fills the data object.
(WebCore::customHandlersDataDelete): Deletes the data object.
(WebCore::ChromeClientEfl::registerProtocolHandler): Registers a protocol and the handler of it.

  • WebCoreSupport/ChromeClientEfl.h: Adds a prototype.

(ChromeClientEfl):

  • ewk/ewk_custom_handlers.cpp: Added.

(ewk_custom_handlers_register_protocol_handler):

  • ewk/ewk_view.h: Adds Data structure.
  • ewk/ewk_view_private.h: Adds private function.

LayoutTests:

  • platform/efl/fast/dom/register-protocol-handler-expected.txt: Added.
10:20 PM Changeset in webkit [118122] by Stephanie Lewis
  • 1 edit
    2 adds in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=87208
Unreviewed, checking in failing results.

  • platform/mac/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
10:03 PM Changeset in webkit [118121] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Apply viewport tag initial-scale only once
https://bugs.webkit.org/show_bug.cgi?id=82949

Patch by Alexandre Elias <aelias@google.com> on 2012-05-22
Reviewed by Adam Barth.

First, check that isPageScaleFactorSet return false before setting
initial-scale. We need to call dispatchViewportPropertiesDidChange()
when the viewport width changes, since that's an input to the viewport
tag calculation. When this happens, we shouldn't pop back to initial
scale.

Second, check that isNewNavigation is true when deciding to clear
isPageScaleFactorIsSet in didCommitLoad. We only want to clear it on
the very first commit, otherwise we'll pop back to initial scale if
the user zooms in before the load is complete.

New test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didCommitLoad):

9:56 PM Changeset in webkit [118120] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

[V8][Performance] Pass Isolate to v8::Null() in V8Node::toV8()
https://bugs.webkit.org/show_bug.cgi?id=87193

Reviewed by Adam Barth.

This patch improves the performance of Bindings/undefined-first-child.html by 58.7%,
Bindings/undefined-get-element-by-id.html by 26.8%,
Dromaeo/dom-query.html(getElementById (not in document)) by 9.8%,
and Dromaeo/dom-query.html(getElementsByName (not in document)) by 2.1%.
These benchmarks test the performance of accessing an undefined Node object.

Performance test results in my Linux desktop:

[Bindings/undefined-first-child.html]

  • without my patch RESULT Bindings: undefined-first-child= 481.843775891 runs/s median= 474.934036939 runs/s, stdev= 17.7753278263 runs/s, min= 471.204188482 runs/s, max= 534.629404617 runs/s
  • with my patch RESULT Bindings: undefined-first-child= 764.720531908 runs/s median= 803.515696424 runs/s, stdev= 54.7402312963 runs/s, min= 688.806888069 runs/s, max= 807.061790668 runs/s

[Bindings/undefined-get-element-by-id.html]

  • without my patch RESULT Bindings: undefined-get-element-by-id= 236.642705579 runs/s median= 234.527786832 runs/s, stdev= 5.77090297761 runs/s, min= 231.362467866 runs/s, max= 246.305418719 runs/s
  • with my patch RESULT Bindings: undefined-get-element-by-id= 300.031032067 runs/s median= 303.797468354 runs/s, stdev= 6.99060409266 runs/s, min= 287.581699346 runs/s, max= 304.955527319 runs/s

[Dromaeo/dom-query.html(getElementById (not in document))]

  • without my patch 2855.80runs/s ±0.30%
  • with my patch 3136.20runs/s ±0.22%

[Dromaeo/dom-query.html(getElementsByName (not in document))]

  • without my patch 2198.00runs/s ±0.50%
  • with my patch 2243.40runs/s ±3.39%

Currently v8::Null() looks up Isolate, which is a bottleneck of
V8Node::toV8() for undefined Nodes. This patch removes the Isolate
look-up by passing Isolate to v8::Null(), like v8::Null(isolate).

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateHeader):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h: Updated run-bindings-tests results.

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

9:32 PM Changeset in webkit [118119] by shawnsingh@chromium.org
  • 2 edits in branches/chromium/1132/Source

Merge 117645 - [chromium] add back-face visibility check for renderSurfaces
https://bugs.webkit.org/show_bug.cgi?id=86870

Reviewed by Adrienne Walker.

Source/WebCore:

Test added CCLayerTreeHostCommonTest::verifyBackFaceCullingWithPreserves3dForFlatteningSurface

Chromium was not checking back-face visibility for renderSurfaces
that needed it. This patch adds that check and the appropriate
unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerIsInExisting3DRenderingContext):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383299

9:27 PM Changeset in webkit [118118] by morrita@google.com
  • 6 edits in trunk

REGRESSION(r116629) tests for <style scoped> is crashing
https://bugs.webkit.org/show_bug.cgi?id=87191

Source/WebCore:

Reviewed by Kent Tamura.

unregisterWithScopingNode() and registerWithScopingNode() doesn't follow
refactoring around removedFrom(), insertedInto() and willRemove().
This change aligns them to such recent changes.

No new tests. Covered by existing tests.

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::unregisterWithScopingNode)
(WebCore::HTMLStyleElement::insertedInto):

  • Allowed registerWithScopingNode() only for in-document traversal. That is how it originally did.

(WebCore::HTMLStyleElement::removedFrom):

  • Gave ex-parent to unregisterWithScopingNode().
  • html/HTMLStyleElement.h:

(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(HTMLStyleElement):

LayoutTests:

  • Unskipped accidentally skipped test for <style scoped>.
  • Updated outdated expectations.

Reviewed by Kent Tamura.

  • fast/css/style-scoped/style-scoped-in-shadow-expected.txt:
  • platform/chromium/test_expectations.txt:
9:24 PM Changeset in webkit [118117] by shawnsingh@chromium.org
  • 6 edits
    2 copies
    5 moves
    6 adds
    1 delete in trunk

Improve W3C conformance of backface-visibility
https://bugs.webkit.org/show_bug.cgi?id=84195

Reviewed by Adrienne Walker.

Source/WebCore:

Tests: compositing/backface-visibility/backface-visibility-3d.html

compositing/backface-visibility/backface-visibility-hierarchical-transform.html
compositing/backface-visibility/backface-visibility-non3d.html
compositing/backface-visibility/backface-visibility-simple.html

Unit Tests: CCLayerTreeHostCommonTest::verifyBackFaceCullingWithoutPreserves3d

CCLayerTreeHostCommonTest::verifyBackFaceCullingWithPreserves3d

Also updated a few other layout and unit tests.

This patch updates chromium to conform to the W3C spec on CSS
transforms, Section 12 about backface visibility. This patch also
updates layout tests to reflect the latest W3C spec. In
particular, rule #1 on section 12, http://dev.w3.org/csswg/css3-transforms/#backface-visibility-property
states which transforms should be used to determine backface-visibility.

Because chromium has an additional quirk of the concept of render
surfaces, unit tests needed to be updated as well.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerIsRootOfNewRenderingContext):
(WebCore):
(WebCore::isLayerBackFaceVisible):
(WebCore::isSurfaceBackFaceVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

LayoutTests:

  • compositing/backface-visibility-hierarchical-transform-expected.png: Removed.
  • compositing/backface-visibility/backface-visibility-3d-expected.png: Added.
  • compositing/backface-visibility/backface-visibility-3d-expected.txt: Copied from LayoutTests/compositing/backface-visibility-expected.txt.
  • compositing/backface-visibility/backface-visibility-3d.html: Added.
  • compositing/backface-visibility/backface-visibility-hierarchical-transform-expected.png: Added.
  • compositing/backface-visibility/backface-visibility-hierarchical-transform-expected.txt: Renamed from LayoutTests/compositing/backface-visibility-hierarchical-transform-expected.txt.
  • compositing/backface-visibility/backface-visibility-hierarchical-transform.html: Renamed from LayoutTests/compositing/backface-visibility-hierarchical-transform.html.
  • compositing/backface-visibility/backface-visibility-non3d-expected.png: Added.
  • compositing/backface-visibility/backface-visibility-non3d-expected.txt: Copied from LayoutTests/compositing/backface-visibility-expected.txt.
  • compositing/backface-visibility/backface-visibility-non3d.html: Added.
  • compositing/backface-visibility/backface-visibility-simple-expected.png: Renamed from LayoutTests/compositing/backface-visibility-expected.png.
  • compositing/backface-visibility/backface-visibility-simple-expected.txt: Renamed from LayoutTests/compositing/backface-visibility-expected.txt.
  • compositing/backface-visibility/backface-visibility-simple.html: Renamed from LayoutTests/compositing/backface-visibility.html.
  • platform/mac/test_expectations.txt:
9:18 PM Changeset in webkit [118116] by commit-queue@webkit.org
  • 12 edits
    6 deletes in trunk

Unreviewed, rolling out r118095.
http://trac.webkit.org/changeset/118095
https://bugs.webkit.org/show_bug.cgi?id=87201

"Causing crashes on Mac in
WebCore::StyleResolver::adjustRenderStyle (Requested by
sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-22

Source/WebCore:

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

  • fast/block/positioning/fixed-position-stacking-context-expected.png: Removed.
  • fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
  • fast/block/positioning/fixed-position-stacking-context.html: Removed.
  • fast/block/positioning/fixed-position-stacking-context2-expected.png: Removed.
  • fast/block/positioning/fixed-position-stacking-context2-expected.txt: Removed.
  • fast/block/positioning/fixed-position-stacking-context2.html: Removed.
9:14 PM Changeset in webkit [118115] by wangxianzhu@chromium.org
  • 5 edits
    2 moves
    1 add in trunk

[Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
https://bugs.webkit.org/show_bug.cgi?id=86922

Source/WebKit/chromium:

Reviewed by Kent Tamura.

  • All.gyp: Added DumpRenderTree_apk into dependencies for Android.

Tools:

Because we have new platformInit() in TestShellAndroid.cpp, and
we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
is split into TestShellPosix.cpp and TestShellX11.cpp.

Reviewed by Kent Tamura.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.

(platformInit):

  • DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
  • DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
  • DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).

(AlarmHandler):
(TestShell::waitTestFinished):

  • DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1

(openStartupDialog): from TestShellGtk.cpp
(checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
(setupFontconfig):
(platformInit):

9:00 PM Changeset in webkit [118114] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

NULL ptr in WebCore::RenderBlock::layoutRunsAndFloatsInRange
https://bugs.webkit.org/show_bug.cgi?id=77786

Reviewed by Ryosuke Niwa.

Source/WebCore:

InlineBidiResolver adds one fake TextRun for isolated inlines in the process of creating the
list of TextRuns to send to the UBA. After the UBA has been run and the TextRuns reordered,
we re-run InlineBidiResolver rooted in the isolate and replace the fake run with those
generated by the subsequent pass by calling the method BidiRunList::replaceRunWithRuns.
This method assumes there are runs to replace the fake run with.

Positioned inline children are ignored when creating TextRuns, so when an isolated inline
has only positioned children we end up with an empty set of runs to pass to replaceRunWithRuns.
Ideally, we'd remove the fake run and not replace it with anything, but BidiRunList keeps
a pointer to the logically last run, which we're unable to easily re-determine after the UBA
has been run. Instead, we leave the fake run in the list and simply avoid calling
replaceRunWithRuns when we don't have any replacement runs.

Test: fast/block/line-layout/crash-in-isolate-with-positioned-child.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRuns):

LayoutTests:

  • fast/block/line-layout/crash-in-isolate-with-positioned-child-expected.txt: Added.
  • fast/block/line-layout/crash-in-isolate-with-positioned-child.html: Added.
8:56 PM Changeset in webkit [118113] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Refactor generation code for non-standard functions
https://bugs.webkit.org/show_bug.cgi?id=87185

Reviewed by Kentaro Hara.

No behavior change. Just a refactoring.

  • bindings/scripts/CodeGeneratorV8.pm:

(IsStandardFunction): Introduce a new function to check if a
function can be in a batch registration.
(GenerateNonStandardFunction): Factor out a code to generate
non-standard functions.
(GenerateImplementation):
Use IsStandardFunction and GenerateNonStandardFunction.

8:48 PM Changeset in webkit [118112] by fpizlo@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

DFG should support op_get_argument_by_val and op_get_arguments_length
https://bugs.webkit.org/show_bug.cgi?id=85911

Reviewed by Oliver Hunt.

Merged r116467 from dfgopt.

This adds a simple and relatively conservative implementation of op_get_argument_by_val
and op_get_arguments_length. We can optimize these later. For now it's great to have
the additional coverage.

This patch appears to be perf-neutral.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
8:36 PM Changeset in webkit [118111] by hayato@chromium.org
  • 7 edits in trunk

Make ComposedShadowTreeWalker traverse inactive insertion points correctly.
https://bugs.webkit.org/show_bug.cgi?id=86830

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fixed InsertionPoint::isActive() issue, which may return true
wrongly even if the insertion point is not in Shadow DOM subtree.
Now ComposedShadowTreeWalker can traverse inactive insertion
points correctly using InsertionPoint::isActive().

Test: fast/dom/shadow/composed-shadow-tree-walker.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::escapeFallbackContentElement):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::isActive):

  • html/shadow/InsertionPoint.h:

(WebCore::isActiveInsertionPoint):
(WebCore):

LayoutTests:

  • fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
  • fast/dom/shadow/composed-shadow-tree-walker.html:
8:23 PM Changeset in webkit [118110] by pilgrim@chromium.org
  • 8 edits in trunk/Source

[Chromium] Call canAccelerate2dCanvas directly
https://bugs.webkit.org/show_bug.cgi?id=86893

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::canAccelerate2dCanvas):

Source/WebCore:

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::shouldAccelerate):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore):

8:23 PM Changeset in webkit [118109] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[Blackberry]Pages contain video or audio tags should be in pageCache
https://bugs.webkit.org/show_bug.cgi?id=87116

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-22
Reviewed by George Staikos.

There is not any reason to disable pageCache for video/audio
tags probably. By my testing, Back and Forward are working for
those pages contain video and audio tags.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::canCachePage):

8:19 PM Changeset in webkit [118108] by fpizlo@apple.com
  • 10 edits in branches/dfgopt/Source/JavaScriptCore

DFG CSE should do redundant store elimination
https://bugs.webkit.org/show_bug.cgi?id=87161

Reviewed by Oliver Hunt.

This patch adds redundant store elimination. For example, consider this
code:

o.x = 42;
o.x = 84;

If o.x is speculated to be a well-behaved field, the first assignment is
unnecessary, since the second just overwrites it. We would like to
eliminate the first assignment in these cases. The need for this
optimization arises mostly from stores that our runtime requires. For
example:

o = {f:1, g:2, h:3};

This will have four assignments to the structure for the newly created
object - one assignment for the empty structure, one for {f}, one for
{f, g}, and one for {f, g, h}. We would like to only have the last of
those assigments in this case.

Intriguingly, doing so for captured variables breaks the way arguments
simplification used to work. Consider that prior to either arguments
simplification or store elimination we will have IR that looks like:

a: SetLocal(r0, Empty)
b: SetLocal(r1, Empty)
c: GetLocal(r0)
d: CreateArguments(@c)
e: SetLocal(r0, @d)
f: SetLocal(r1, @d)

Then redundant store elimination will eliminate the stores that
initialize the arguments registers to Empty, but then arguments
simplification eliminates the stores that initialize the arguments to
the newly created arguments - and at this point we no longer have any
stores to the arguments register, leading to hilarious crashes. This
patch therefore changes arguments simplification to replace
CreateArguments with JSConstant(Empty) rather than eliminating the
SetLocals. But this revealed bugs where arguments simplification was
being overzealous, so I fixed those bugs.

This is a minor speed-up on V8/early and a handful of other tests.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarStoreElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasStructureTransitionData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:07 PM Changeset in webkit [118107] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87199
Unreviewed, add failing test to skipped list.

  • platform/mac/Skipped:
7:58 PM Changeset in webkit [118106] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Unreviewed, update result missed by http://trac.webkit.org/changeset/117673.

  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt:
7:49 PM Changeset in webkit [118105] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

[BlackBerry] Possible to clobber httponly cookie.
https://bugs.webkit.org/show_bug.cgi?id=86067

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-22
Reviewed by Rob Buis.

Source/WebCore:

If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.php

  • platform/blackberry/CookieJarBlackBerry.cpp:

(WebCore::setCookies):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::shouldRejectNotHttpCookie):
(WebCore):

  • platform/blackberry/CookieManager.h:

LayoutTests:

  • http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
  • http/tests/cookies/js-get-and-set-http-only-cookie.php: Added.
  • http/tests/cookies/script-tests/js-get-and-set-http-only-cookie.js: Added.
7:48 PM Changeset in webkit [118104] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Don't drop children of a RenderSurface from the renderSurfaceLayerList when then position of the surface in its clipRect is not known
https://bugs.webkit.org/show_bug.cgi?id=87181

Reviewed by Adrienne Walker.

Source/WebCore:

We want to avoid dropping things from the renderSurfaceLayerList on main
thread when they may be in the renderSurfaceLayerList on impl thread due
to animation. A render surface would drop all its children if its
contentRect was clipped to become empty by its parent. But when the
surface is being animated, then we can't be sure how its parent will
clip the surface's content, so we don't clip it at all.

Chromium bug: http://crbug.com/128739

Unit test: CCLayerTreeHostCommonTest.verifyClipRectCullsSurfaceWithoutVisibleContent

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

7:37 PM Changeset in webkit [118103] by commit-queue@webkit.org
  • 15 edits in trunk

[EFL][DRT] Implement touch event
https://bugs.webkit.org/show_bug.cgi?id=86720

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-22
Reviewed by Hajime Morita.

Currently EFL DRT doesn't support touch event.
Therefore, this patch enabled it and implemented some eventSender function callbacks.

.:

  • Source/cmake/FindEFL.cmake: Add ecore-input to dependency check.
  • Source/cmake/OptionsEfl.cmake: Enable touch event option.

Source/WebCore:

  • platform/PlatformTouchEvent.h:

(PlatformTouchEvent): Implement meta state.

  • platform/efl/PlatformTouchEventEfl.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): Implement meta state.

Source/WebKit/efl:

  • ewebkit.pc.in:
  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

  • ewk/ewk_frame.h:

Tools:

  • DumpRenderTree/efl/EventSender.cpp:

(TouchEventInfo::TouchEventInfo):
(TouchEventInfo):
(touchPointList):
(sendTouchEvent):
(addTouchPointCallback):
(touchStartCallback):
(updateTouchPointCallback):
(touchMoveCallback):
(cancelTouchPointCallback):
(touchCancelCallback):
(releaseTouchPointCallback):
(touchEndCallback):
(clearTouchPointsCallback):
(setTouchModifierCallback):

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/Skipped:
7:34 PM Changeset in webkit [118102] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG should support op_tear_off_arguments
https://bugs.webkit.org/show_bug.cgi?id=85847

Reviewed by Michael Saboff.

Merged r116378 from dfgopt.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

7:30 PM Changeset in webkit [118101] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87187
<rdar://problem/11511011> acid3 fails on WebKit2 (87187)

Unreviewed, checking in failing results.

  • platform/mac-wk2/http/tests/misc/acid3-expected.txt:
7:19 PM Changeset in webkit [118100] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Fix chromium_android_unittest
https://bugs.webkit.org/show_bug.cgi?id=87196

Not reviewed.
Temporarily disable chromium_android_unittest.

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest):
(ChromiumAndroidDriverTest):

7:11 PM Changeset in webkit [118099] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

AudioNodeOutput::disconnectAllParams() must take care when iterating through its parameter list
https://bugs.webkit.org/show_bug.cgi?id=87190

Reviewed by Kenneth Russell.

No new tests. Covered by existing tests.

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::disconnectAllParams):

7:03 PM Changeset in webkit [118098] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

<shadow> and <content> should be hidden behind ContextEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=87063

This change repalces "runtimeConditional" tag definition property
with new "contextConditional" property, which refers
ContextEnabledFeatures instead of RuntimeEnabledFeatures.

Reviewed by Dimitri Glazkov.

No new tests. DRT cannot test this. No behaviour change on DRT.

  • dom/make_names.pl:

(defaultTagPropertyHash):
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • html/HTMLTagNames.in:
6:58 PM Changeset in webkit [118097] by morrita@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium][API] Introduce WebPermissionClient::allowWebComponents()
https://bugs.webkit.org/show_bug.cgi?id=87097

Reviewed by Kent Tamura.

  • Added WebPermissionClient::allowWebComponents(), and
  • Implemented FrameLoaderClientImpl::shadowDOMAllowed() using it.
  • public/WebPermissionClient.h:

(WebPermissionClient):
(WebKit::WebPermissionClient::allowWebComponents):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::shadowDOMAllowed):
(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

6:53 PM Changeset in webkit [118096] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix a crash in HTMLFormControlElement::disabled().
https://bugs.webkit.org/show_bug.cgi?id=86534

Reviewed by Hajime Morita.

Node::removedFrom() was not called in some cases. This patch fixes it.

No new tests. It's almost impossible to make a reliable test.

  • dom/ContainerNodeAlgorithms.h:

Remove inDocument() check so that Node::removedFrom() is called even if
a parent node in an orphan tree is deleted but a child node remains,

6:41 PM Changeset in webkit [118095] by jamesr@google.com
  • 12 edits
    6 adds in trunk

Add a Setting to make position:fixed form a new stacking context
https://bugs.webkit.org/show_bug.cgi?id=87186

Reviewed by Adam Barth.

Source/WebCore:

position:fixed elements form a new stacking context in several mobile WebKit ports and in the Qt port always. To
be consistent across devices, we want to try turning it on everywhere. This will likely cause compatibility
issues, so we need a runtime setting in order to stage the change carefully.

Tests: fast/block/positioning/fixed-position-stacking-context.html

fast/block/positioning/fixed-position-stacking-context2.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setFixedPositionCreatesStackingContext):
(WebCore::Settings::fixedPositionCreatesStackingContext):
(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setFixedPositionCreatesStackingContext):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setFixedPositionCreatesStackingContext):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

Adds layout tests that confirm we don't creates stacking contexts for position:fixed by default, but we do when
the fixedPositionCreatesStackingContext Setting is true.

Qt and Blackberry will need different expectations since they set this via an #ifdef

  • fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
  • fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
  • fast/block/positioning/fixed-position-stacking-context.html: Added.
  • fast/block/positioning/fixed-position-stacking-context2-expected.png: Added.
  • fast/block/positioning/fixed-position-stacking-context2-expected.txt: Added.
  • fast/block/positioning/fixed-position-stacking-context2.html: Added.
6:39 PM Changeset in webkit [118094] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

RenderInline::absoluteRects does some incorrect layout math
https://bugs.webkit.org/show_bug.cgi?id=87036

Reviewed by Eric Seidel.

Source/WebCore:

http://trac.webkit.org/changeset/88297/trunk/Source/WebCore/rendering/RenderInline.cpp
contained a typo. We should accumulate offsets, not add sizes to
offsets.

Test: fast/inline/boundingBox-with-continuation.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore):

LayoutTests:

  • fast/inline/boundingBox-with-continuation-expected.txt: Added.
  • fast/inline/boundingBox-with-continuation.html: Added.
6:28 PM Changeset in webkit [118093] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

CopiedSpace::contains doesn't check for oversize blocks
https://bugs.webkit.org/show_bug.cgi?id=87180

Reviewed by Geoffrey Garen.

When doing a conservative scan we use CopiedSpace::contains to determine if a particular
address points into the CopiedSpace. Currently contains() only checks if the address
points to a block in to-space, which means that pointers to oversize blocks may not get scanned.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):

  • heap/CopiedSpace.h: Refactored CopiedSpace so that all blocks (oversize and to-space) are

in a single hash set and bloom filter for membership testing.
(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::contains): We check for the normal block first. Since the oversize blocks are
only page aligned, rather than block aligned, we have to re-mask the ptr to check if it's in
CopiedSpace. Also added a helper function of the same name that takes a CopiedBlock* and checks
if it's in CopiedSpace so that check isn't typed out twice.
(JSC):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::addNewBlock):

6:13 PM Changeset in webkit [118092] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Do some more clean up on the WK2 Skipped list.

Add bug numbers, remove tests that have been fixed, and consolidate tests that are already
covered elsewhere in the file.

  • platform/wk2/Skipped:
6:12 PM Changeset in webkit [118091] by jberlin@webkit.org
  • 6 edits in trunk

WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=64313

Reviewed by Jon Honeycutt.

Tools:

Add it.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Make sure to generate the binding.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setDefersLoading):
Call WKBundlePageSetDefersLoading.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

  • platform/wk2/Skipped:

Remove a test that uses setDefersLoading from the WK2 Skipped list.

6:02 PM Changeset in webkit [118090] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Don't force the visibleLayerRect to be empty for animating layers whose front face is not visible
https://bugs.webkit.org/show_bug.cgi?id=86886

Reviewed by Adrienne Walker.

Source/WebCore:

Previously we would force the visibleLayerRect to be empty for these
animating layers, and then special case the pre-painting code to
paint them if they were within some size limit, to avoid having the
layer steal too much memory.

Instead, just use the visibleLayerRect given to the layer. Since the
transform flips the layer such that its back face is visible, it will
also compute a visibleLayerRect in the front face of the layer, and
its size will be bounded by the viewport. This will cause the
layer to be painted with visible priority instead of prepainted, but
ensures the visible parts of the layer is painted and ready to go when
the animation flips the layer around.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleLayerRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

5:41 PM Changeset in webkit [118089] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Run DumpRenderTree as an apk (python part)
https://bugs.webkit.org/show_bug.cgi?id=86923

chromium_android.py is modified to support running DumpRenderTree as
an apk, so that we can run the tests (e.g. video) requiring features
implemented in Java on Android.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.default_child_processes):
(ChromiumAndroidPort.check_wdiff):
(ChromiumAndroidPort.check_build):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.skipped_layout_tests):
(ChromiumAndroidPort):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._get_crash_log):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._run_adb_command):
(ChromiumAndroidPort._get_last_stacktrace):
(ChromiumAndroidPort._get_logcat):
(ChromiumAndroidPort._setup_performance):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._command_wrapper):
(ChromiumAndroidDriver.cmd_line):
(ChromiumAndroidDriver._file_exists_on_device):
(ChromiumAndroidDriver._deadlock_detector):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._write_command_and_read_line):
(ChromiumAndroidDriver._output_image):
(ChromiumAndroidDriver._get_stderr):

5:38 PM Changeset in webkit [118088] by jsbell@chromium.org
  • 6 edits in trunk/Tools

[Chromium] Reverting r118084 - webkit_tests failing on chromium mac.

Unreviewed gardening.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.driver_name):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_overrides_and_builder_names):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

5:23 PM Changeset in webkit [118087] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r98359): Video does not render on http://panic.com/dietcoda/
https://bugs.webkit.org/show_bug.cgi?id=87171

Reviewed by Maciej Stachowiak.

No new tests; behavior is very timing specific and only occurs on a subset of all platforms.

Instead of calling prepareForRendering() from metadataLoaded(), which may fail and cause subsequent
calls to prepareForRendering() to short circuit, call createVideoLayer() directly, which achieves
the original goals of the fix for http://webkit.org/b/70448, but without breaking subsequent calls
to prepareForRendering() if called at the wrong time.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):

5:21 PM Changeset in webkit [118086] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Add a quirk for applications that depend on the relative ordering of progressCompleted/didFinishLoad
https://bugs.webkit.org/show_bug.cgi?id=87178
<rdar://problem/11468434>

Reviewed by Maciej Stachowiak.

Some applications depend on the relative ordering of progressCompleted/didFinishLoad, which was changed
to be more correct in http://trac.webkit.org/changeset/94105. For applications built before 94105, we can
provide the old behavior. For the time being, this will only apply to Mail.app.

No new tests, will not affect behavior for any application except Mail.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setNeedsDidFinishLoadOrderQuirk):
(WebCore::Settings::needsDidFinishLoadOrderQuirk):

Add plumbing for the quirk to flip the relative ordering of progressCompleted/didFinishLoad back
to the behavior before http://trac.webkit.org/changeset/94105. Make it apply to any Mail.app linked
against WebKit before that revision.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm:

(-[WebView _needsDidFinishLoadOrderQuirk]):
(-[WebView _preferencesChanged:]):

5:21 PM Changeset in webkit [118085] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
https://bugs.webkit.org/show_bug.cgi?id=87176

Reviewed by Tony Chang.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
5:09 PM Changeset in webkit [118084] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
https://bugs.webkit.org/show_bug.cgi?id=87128

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.driver_name):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_driver_name_option):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

4:59 PM Changeset in webkit [118083] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

CopiedBlock and MarkedBlock should have proper value semantics (i.e., destructors)
https://bugs.webkit.org/show_bug.cgi?id=87172

Reviewed by Oliver Hunt and Phil Pizlo.

This enables MarkedBlock to own non-trivial sub-objects that require
destruction. It also fixes a FIXME about casting a CopiedBlock to a
MarkedBlock at destroy time.

CopiedBlock and MarkedBlock now accept an allocation chunk at create
time and return it at destroy time. Their client is expected to
allocate, recycle, and destroy these chunks.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::releaseFreeBlocks):
(JSC::BlockAllocator::blockFreeingThreadMain): Don't call MarkedBlock::destroy
because we expect that to be called before a block is put on our free
list now. Do manually deallocate our allocation chunk because that's
our job now.

  • heap/BlockAllocator.h:

(BlockAllocator):
(JSC::BlockAllocator::allocate): Allocate never fails now. This is a
cleaner abstraction because only one object does all the VM allocation
and deallocation. Caching is an implementation detail.

(JSC::BlockAllocator::deallocate): We take an allocation chunk argument
instead of a block because we now expect the block to have been destroyed
before we recycle its memory. For convenience, we still use the HeapBlock
class as our linked list node. This is OK because HeapBlock is a POD type.

  • heap/CopiedBlock.h:

(CopiedBlock):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::destroy):
(JSC::CopiedBlock::CopiedBlock): Added proper create and destroy functions,
to match MarkedBlock.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::getFreshBlock):
(JSC::CopiedSpace::freeAllBlocks):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::recycleBlock): Make sure to call destroy before
returning a block to the BlockAllocator. Otherwise, our destructors
won't run. (If we get this wrong now, we'll get a compile error.)

  • heap/HeapBlock.h:

(JSC::HeapBlock::HeapBlock): const!

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateBlock): No need to distinguish between
create and recycle -- MarkedBlock always accepts memory allocated by
its client now.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create): Don't allocate memory -- we assume that we're
passed already-allocated memory, to clarify the responsibility for VM
recycling.

(JSC::MarkedBlock::destroy): Do run our destructor before giving back
our VM -- that is the whole point of this patch.

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(MarkedBlock):

  • heap/MarkedSpace.cpp: const!

(JSC::MarkedSpace::freeBlocks): Make sure to call destroy before
returning a block to the BlockAllocator. Otherwise, our destructors
won't run. (If we get this wrong now, we'll get a compile error.)

4:59 PM Changeset in webkit [118082] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Move some CSS regions properties to CSSParser::isValidKeywordPropertyAndValue.
https://bugs.webkit.org/show_bug.cgi?id=87169

Reviewed by Tony Chang.

Move some CSS regions properties to the fast path implemented by
CSSParser::isValidKeywordPropertyAndValue.

No new tests : Existing tests should cover.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

4:56 PM Changeset in webkit [118081] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac WK2] platform/mac-wk2/plugins/mouse-events-scaled.html failing
https://bugs.webkit.org/show_bug.cgi?id=87182

Add expected (failing?) results to get the bots green.

  • platform/mac-wk2/plugins/mouse-events-scaled-expected.txt:
4:41 PM Changeset in webkit [118080] by pilgrim@chromium.org
  • 9 edits
    2 copies in trunk/Source

[Chromium] Move cookieJar to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86755

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::cookieJar):

  • chromium/public/WebCookie.h: Added.

(WebKit):
(WebKit::WebCookie::WebCookie):
(WebCookie):

  • chromium/public/WebCookieJar.h: Added.

(WebKit):
(WebCookieJar):
(WebKit::WebCookieJar::setCookie):
(WebKit::WebCookieJar::cookies):
(WebKit::WebCookieJar::cookieRequestHeaderFieldValue):
(WebKit::WebCookieJar::rawCookies):
(WebKit::WebCookieJar::deleteCookie):
(WebKit::WebCookieJar::cookiesEnabled):
(WebKit::WebCookieJar::~WebCookieJar):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebCookie.h:
  • public/platform/WebCookieJar.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::themeEngine):

  • src/PlatformSupport.cpp:

(WebCore::getCookieJar):

4:28 PM Changeset in webkit [118079] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

4:25 PM Changeset in webkit [118078] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setPrinting
https://bugs.webkit.org/show_bug.cgi?id=42693

Add printing/iframe-print.html to the WK2 Skipped list.

  • platform/wk2/Skipped:
4:18 PM Changeset in webkit [118077] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip test added in r118001.

Skip it while the necessary mechanisms are not implemented by the
port.

  • platform/efl/test_expectations.txt:
4:05 PM Changeset in webkit [118076] by eae@chromium.org
  • 13 edits
    2 adds in trunk/Source/WebCore

Represents margins as box and simplify writing mode logic
https://bugs.webkit.org/show_bug.cgi?id=86952

Reviewed by Eric Seidel.

Add a new class, FractionalLayoutBox, that represents the four sides of a
box and change RenderBox to use it to represent margins.

The new box class is intended to be used to represent things like
margins, paddings and borders where the current rect class isn't a good
fit. It also encapsulated a lot of the horizontal/vertical writing mode
and bidi logic allowing it to be reused.

No new tests, no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FractionalLayoutBoxExtent.cpp: Added.
  • platform/graphics/FractionalLayoutBoxExtent.h: Added.
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderScrollbarPart.cpp:
  • rendering/RenderScrollbarPart.h:
3:58 PM Changeset in webkit [118075] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Replace 'throwTypeError(); return Undefined();' with 'return throwTypeError();'
https://bugs.webkit.org/show_bug.cgi?id=87106

Reviewed by Adam Barth.

This patch replaces

throwTypeError();
return v8::Undefined();

with

return throwTypeError();

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunctionCallback):
(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):

3:52 PM Changeset in webkit [118074] by mitz@apple.com
  • 3 edits
    6 adds in trunk

REGRESSION (r105513): CSS max-width is not applied to SVG element
https://bugs.webkit.org/show_bug.cgi?id=87050

Reviewed by Darin Adler.

Source/WebCore:

Tests: svg/css/max-height.html

svg/css/max-width.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Changed to also call into the base
class implementation of this function if max-width was specified.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Changed to call into the bas class
implementation of this function if either height or max-height were specified.

LayoutTests:

  • svg/css/max-height-expected.png: Added.
  • svg/css/max-height-expected.txt: Added.
  • svg/css/max-height.html: Added.
  • svg/css/max-width-expected.png: Added.
  • svg/css/max-width-expected.txt: Added.
  • svg/css/max-width.html: Added.
3:49 PM Changeset in webkit [118073] by Lucas Forschler
  • 1 copy in tags/Safari-536.13

New Tag.

3:48 PM Changeset in webkit [118072] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r116492.

3:47 PM Changeset in webkit [118071] by haraken@chromium.org
  • 22 edits in trunk/Source/WebCore

[V8] Pass Isolate to throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=87111

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwTypeError() in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

3:44 PM Changeset in webkit [118070] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test_expectations update, added bug number for a couple of skipped tests.

  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [118069] by Lucas Forschler
  • 1 delete in tags/Safari-536.13

Remove Tag.

3:39 PM Changeset in webkit [118068] by Lucas Forschler
  • 1 copy in tags/Safari-536.13

New Tag.

3:36 PM Changeset in webkit [118067] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
3:27 PM Changeset in webkit [118066] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Functions dispatched by dispatchAfterEnsuringUpdatedScrollPosition can be called after drawing area has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=87173
<rdar://problem/11474087>

Reviewed by Beth Dakin.

Don't try to call forceRepaint if the drawing area has already been destroyed.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):

3:26 PM Changeset in webkit [118065] by jsbell@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

[Chromium] Add missing baselines for r118039.

Unreviewed gardening.

  • platform/chromium-linux/printing/iframe-print-expected.png: Added.
  • platform/chromium-mac-leopard/printing/iframe-print-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/iframe-print-expected.png: Added.
  • platform/chromium-mac/printing/iframe-print-expected.png: Added.
  • platform/chromium-mac/printing/iframe-print-expected.txt: Added.
  • platform/chromium-win/printing/iframe-print-expected.png: Added.
  • platform/chromium-win/printing/iframe-print-expected.txt: Added.
3:23 PM Changeset in webkit [118064] by jberlin@webkit.org
  • 2 edits in trunk/Tools

WTR fix after r118001.

Rubber-stamped by Alexey Proskuryakov.

Update the WTR implementation of keyDown to match the DRT one changed in r118001.

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::keyDown):

3:22 PM Changeset in webkit [118063] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[V8] Replace 'setDOMException(); return Undefined();' with 'return setDOMException();'
https://bugs.webkit.org/show_bug.cgi?id=87102

Reviewed by Adam Barth.

This patch replaces

setDOMException();
return v8::Undefined();

with

return setDOMException();

In addition, just in case, this patch replaces

if (...)

setDOMException();

return v8::Undefined();

with

if (...)

return setDOMException();

return v8::Undefined();

because people might insert some code just above
'return v8::Undefined()' in the future.

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:

(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

3:11 PM Changeset in webkit [118062] by commit-queue@webkit.org
  • 10 edits in trunk

[Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
https://bugs.webkit.org/show_bug.cgi?id=86684

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-05-22
Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebFrame.h:

(WebFrame):

  • public/WebPlugin.h:

(WebPlugin):

  • public/WebPrintParams.h:

(WebKit::WebPrintParams::WebPrintParams):
(WebPrintParams):

  • src/WebFrameImpl.cpp:

(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printBegin):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::numberOfPages):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printPage):

3:08 PM Changeset in webkit [118061] by mrobinson@webkit.org
  • 3 edits in trunk/Source/WebCore

[TextureMapper] [Cairo] Implement repaint counters
https://bugs.webkit.org/show_bug.cgi?id=87062

Reviewed by Gustavo Noronha Silva.

No new tests. This just adds a debugging feature that shouldn't
affect the normal drawing of a page.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Now, if repaint counters are
enabled, increment the repaint count and call drawRepaintCounter.
(WebCore::TextureMapperLayer::drawRepaintCounter): Added.

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer): Added declaration for drawRepaintCounter.

2:56 PM Changeset in webkit [118060] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Crash when a plug-in view outlives its containing WebPage
https://bugs.webkit.org/show_bug.cgi?id=87163
<rdar://problem/10849258>

Reviewed by Dan Bernstein.

In rare cases, when a plug-in is kept alive for some reason it can outlive its WebPage. When that happens,
the PluginView destructor will try to access the (deleted) web page and we'll crash.

Fix this by making the WebPage destructor iterate over all the registered plug-ins and null out the m_webPage pointer.
Don't try to access the WebPage object if it's null.

Also, remove PLATFORM(MAC) ifdefs around the HashSet of known plug-in views as well as the member functions that access the set;
we want this to be cross platform now.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::webPageDestroyed):
(WebKit):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
(WebKit::WebPage::scalePage):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

2:55 PM Changeset in webkit [118059] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose setMediaPlaybackRequiresUserGesture via WebSettings
https://bugs.webkit.org/show_bug.cgi?id=87164

Reviewed by Eric Seidel.

This is used by the Chromium Android port.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMediaPlaybackRequiresUserGesture):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

2:50 PM LayoutUnit edited by eae@chromium.org
(diff)
2:50 PM Changeset in webkit [118058] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WK2 Skipped list should be updated to reflect that
https://bugs.webkit.org/show_bug.cgi?id=57515 has been fixed.
https://bugs.webkit.org/show_bug.cgi?id=87170.

Reviewed by Brady Eidson.

Remove the tests from the Skipped list that now pass, separate out the test that crashes with
its own entry, and correctly cover the shadow dom tests.

  • platform/wk2/Skipped:
2:29 PM Changeset in webkit [118057] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116357
BUG=124530
Review URL: https://chromiumcodereview.appspot.com/10413058

2:27 PM Changeset in webkit [118056] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 116357
BUG=124530
Review URL: https://chromiumcodereview.appspot.com/10413057

2:24 PM Changeset in webkit [118055] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117224
BUG=125730
Review URL: https://chromiumcodereview.appspot.com/10411078

2:22 PM Changeset in webkit [118054] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add unit testing for WebTransformationMatrix::blend()
https://bugs.webkit.org/show_bug.cgi?id=87066

Reviewed by Adrienne Walker.

8 more unit tests added:
WebTransformationMatrixTest.verifyBlendForTranslation
WebTransformationMatrixTest.verifyBlendForScale
WebTransformationMatrixTest.verifyBlendForSkewX
WebTransformationMatrixTest.verifyBlendForSkewY
WebTransformationMatrixTest.verifyBlendForRotationAboutX
WebTransformationMatrixTest.verifyBlendForRotationAboutY
WebTransformationMatrixTest.verifyBlendForRotationAboutZ
WebTransformationMatrixTest.verifyBlendForCompositeTransform

  • tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):
(WebKit):
(WebKit::printTransform):

2:21 PM Changeset in webkit [118053] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 117224
BUG=125730
Review URL: https://chromiumcodereview.appspot.com/10408073

2:17 PM Changeset in webkit [118052] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Use the same animation begin time while updating compositing layers
https://bugs.webkit.org/show_bug.cgi?id=87080

Reviewed by Dean Jackson.

Tidied up some beginAnimationUpdate/endAnimationUpdate logic,
but further cleaning is required. We currently bracket some calls
to recaclcStyle() with begin/endAnimationUpdate, but not all.
We don't bracket layout, or compositing updates. This patch
adds bracketing around compositing updates, in order to be
able to add some assertions in a later patch that rely on
RenderLayer::currentTransform() giving consistent results,
since currentTransform() depends on the animation begin time.

Made AnimationController::beginAnimationUpdate() and
AnimationController::endAnimationUpdate() nestable by adding
a counter.

Added a stack-based class, AnimationUpdateBlock, which
calls begin/endAnimationUpdate.

Replaced calls to begin/endAnimationUpdate in Document::updateStyleIfNeeded()
and Document::styleResolverChanged() with AnimationUpdateBlock. Filed a bug
to cover other calls to recalcStyle which might need this (87159).

Removed a call to beginAnimationUpdate() in Document::implicitOpen(),
which was added in r42415. I believe that r57390 makes this unnecessary,
and was not able to reproduce the original bug after removing it. It
was the only unpaired beginAnimationUpdate call.

Made AnimationControllerPrivate::getAnimatedStyleForRenderer() not
use a new beginTime each time it was called, so its beginTime now
depends on some earlier beginAnimationUpdate.

Fixed CSSComputedStyleDeclaration::getPropertyCSSValue() to use
an AnimationUpdateBlock so that calls to computed style do
use the current time to compute an animating value (as before).

Not testable.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • dom/Document.cpp:

(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::implicitOpen):
(WebCore::Document::styleResolverChanged):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationController::AnimationController):
(WebCore::AnimationController::beginAnimationUpdate):
(WebCore::AnimationController::endAnimationUpdate):

  • page/animation/AnimationController.h:

(AnimationController):
(WebCore):
(AnimationUpdateBlock):
(WebCore::AnimationUpdateBlock::AnimationUpdateBlock):
(WebCore::AnimationUpdateBlock::~AnimationUpdateBlock):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

2:02 PM Changeset in webkit [118051] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 116683
BUG=126723
Review URL: https://chromiumcodereview.appspot.com/10409080

2:01 PM Changeset in webkit [118050] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1084

Merge 116683
BUG=126723
Review URL: https://chromiumcodereview.appspot.com/10332302

1:57 PM Changeset in webkit [118049] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162

Add editing/inserting/typing-space-to-trigger-smart-link.html to the WK2 Skipped list.

  • platform/wk2/Skipped:
1:55 PM Changeset in webkit [118048] by Lucas Forschler
  • 2 edits in tags/Safari-536.12.1/Source/WebKit2

Merged r116492.

1:54 PM Changeset in webkit [118047] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

echo-inspan.pl is missing a semicolon on line 14, freaks out Apache on multiple regression tests
https://bugs.webkit.org/show_bug.cgi?id=86023

Reviewed by Eric Seidel.

This typo was causing a syntax error, making us lose test coverage.

  • http/tests/security/xssAuditor/open-iframe-src-expected.txt: Rebased result.
  • http/tests/security/xssAuditor/open-script-src-expected.txt: Ditto.
  • http/tests/security/xssAuditor/resources/echo-inspan.pl:
1:53 PM Changeset in webkit [118046] by Lucas Forschler
  • 4 edits in tags/Safari-536.12.1/Source

Versioning.

1:51 PM Changeset in webkit [118045] by Lucas Forschler
  • 1 copy in tags/Safari-536.12.1

New Tag.

1:50 PM Changeset in webkit [118044] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r117613): Dromaeo/jslib-style-prototype regressed by 20%
https://bugs.webkit.org/show_bug.cgi?id=87142

Reviewed by Alexis Menard.

Move CSSPropertyDisplay back into isValidKeywordPropertyAndValue.
Pass in the parser context so we can check whether we're grid or not.

No new tests. Covered by Dromaeo/jslib-style-prototype perf test.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFont):

1:48 PM Changeset in webkit [118043] by imasaki@chromium.org
  • 12 edits
    2 copies in branches/chromium/1132

Merge 116900 - Volume slider needs to be displayed below the mute button
https://bugs.webkit.org/show_bug.cgi?id=85990

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-13
Reviewed by Dimitri Glazkov.

Source/WebCore:

Added back code for rendering offset, but used only when the volume slider
needs to be displayed below the controls.

Test: media/media-volume-slider-rendered-below.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Changed positioning of the slider to absolute, otherwise it is not possible to position it from the layout() method.

  • css/mediaControlsQuickTime.css:

Added back the double mute-button and changed the z-index of the original button. When the slider is displayed
the second mute button is actually there.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Added copy.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeTransparent): Disabled the possible of hiding controls. WebVTT rendering
in the place of controls when these are visible is not possible with the current code.
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
Checked if the absolute coordinates of the corner of the slider would be rendered outside the page. This part of the
code is faulty if display:none is toggled on the controls.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create):

LayoutTests:

Updated tests expectation and marked failing tests accordingly.

  • media/media-volume-slider-rendered-below.html: Added.
  • media/media-volume-slider-rendered-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Updated.
  • platform/mac/media/audio-controls-rendering-expected.txt: Updated (z-index change).
  • platform/mac/media/controls-after-reload-expected.txt: Same.
  • platform/mac/media/controls-strict-expected.txt: Same.
  • platform/mac/media/video-controls-rendering-expected.txt: Same.
  • platform/mac/media/video-display-toggle-expected.txt: Same.
  • platform/mac/media/video-playing-and-pause-expected.txt: Same.
  • platform/mac/test_expectations.txt: Updated.

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10412040

1:37 PM Changeset in webkit [118042] by jsbell@chromium.org
  • 4 edits in branches/chromium/1132/Source/WebCore/Modules/indexeddb

Merge 116562 - IndexedDB: call abort handler when there are problems committing
https://bugs.webkit.org/show_bug.cgi?id=85841

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-09
Reviewed by Ojan Vafai.

No new tests. Every existing test that calls commit() is testing
the success side of this, and this only throws when there are
LevelDB errors, which is exactly what we're trying to diagnose
with this patch.

  • Modules/indexeddb/IDBBackingStore.h:

(Transaction):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(Transaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::commit):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10422005

1:37 PM Changeset in webkit [118041] by Simon Fraser
  • 8 edits
    8 copies in trunk

.: == Rolled over to ChangeLog-2012-05-22 ==

Source/JavaScriptCore: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebCore: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebKit/chromium: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebKit/gtk: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebKit2: == Rolled over to ChangeLog-2012-05-22 ==

Tools: == Rolled over to ChangeLog-2012-05-22 ==

LayoutTests: == Rolled over to ChangeLog-2012-05-22 ==

1:30 PM Changeset in webkit [118040] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] platform/chromium/.../visibility-simple-*-layer.html fails intermittently on Windows bots.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
1:26 PM Changeset in webkit [118039] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Source/WebCore: Fix iframe printing.
https://bugs.webkit.org/show_bug.cgi?id=85118

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-05-22
Reviewed by Darin Adler, Eric Seidel.

Patch fixed two issues by disabling special handling of subframes for printing.

  1. Regression. Division by zero when forceLayoutForPagination called for subframes

and page sizes set to zero.

  1. Old issue. RendererView adjusted layout of subframes for printing and set invalid

dimensions. Sometimes it caused missing iframe when printed.

Test: printing/iframe-print.html

  • page/Frame.cpp:

(WebCore::Frame::setPrinting): Calls forceLayoutForPagination for root frames only.
(WebCore::Frame::resizePageRectsKeepingRatio): Added ASSERTs to catch division by zero.

  • rendering/RenderView.cpp: Replaced printing() with shouldUsePrintingLayout() for most calls.

(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):
(WebCore::RenderView::layout):
(WebCore::RenderView::shouldUsePrintingLayout): Returns true only if printing enabled and it's a root frame.
(WebCore::RenderView::viewRect):
(WebCore::RenderView::viewHeight):
(WebCore::RenderView::viewWidth):

  • rendering/RenderView.h:

LayoutTests: LayoutTest for iframe printing.
https://bugs.webkit.org/show_bug.cgi?id=85118

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-05-22
Reviewed by Darin Adler, Eric Seidel.

  • printing/iframe-print-expected.txt: Added.
  • printing/iframe-print.html: Added.
  • printing/resources/iframe-subframe-vertical-rl.html: Added.
  • printing/resources/iframe-subframe.html: Added.
1:23 PM Changeset in webkit [118038] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] getPlatformThreadRegisters() should fetch target thread's registers
https://bugs.webkit.org/show_bug.cgi?id=87148

Patch by Yong Li <yoli@rim.com> on 2012-05-22
Reviewed by George Staikos.

Our previous implementation of getPlatformThreadRegisters() read registers in current
thread's context but it is supposed to read the target thread's registers.

  • heap/MachineStackMarker.cpp:

(JSC::getPlatformThreadRegisters):

1:21 PM Changeset in webkit [118037] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116551
BUG=125563
Review URL: https://chromiumcodereview.appspot.com/10412039

1:20 PM Changeset in webkit [118036] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 116551
BUG=125563
Review URL: https://chromiumcodereview.appspot.com/10411077

1:20 PM Changeset in webkit [118035] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2012-05-22 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • wtf/RAMSize.cpp: (WTF::computeRAMSize): sysctl expects a uint64_t, so use that and then cast back to size_t. Since it's coneivable that a 32bit process would run on a system with more than 4GB RAM, I added a paranoid check for that condition.
1:17 PM Changeset in webkit [118034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix tests being flaky when multiple draws occur in between commits
https://bugs.webkit.org/show_bug.cgi?id=83935

Tests that are verifying events in a commit/draw lock-step pattern, should use
sourceFrameNumber() not frameNumber() on the impl side.
Otherwise they will fail if the same frame is drawn more than once in
between commits (which is perfectly legal and could happen for example
because we draw without a new commit because we are still in BEGIN_FRAME
or updating resources).

Patch by Daniel Sievers <sievers@chromium.org> on 2012-05-22
Reviewed by Adrienne Walker.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestFractionalScroll::drawLayersOnCCThread):

1:15 PM Changeset in webkit [118033] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116864
BUG=126040
Review URL: https://chromiumcodereview.appspot.com/10411076

1:14 PM Changeset in webkit [118032] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 116864
BUG=126040
Review URL: https://chromiumcodereview.appspot.com/10414055

1:03 PM Changeset in webkit [118031] by jberlin@webkit.org
  • 2 edits in trunk/Source/WTF

Build fix.

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):
If you say you are going to return a size_t, actually return a size_t.

1:02 PM Changeset in webkit [118030] by fpizlo@apple.com
  • 20 edits in trunk/Source/JavaScriptCore

DFG should support reflective arguments access
https://bugs.webkit.org/show_bug.cgi?id=85721

Reviewed by Oliver Hunt.

Merged r116345 from dfgopt.

This adds support for op_create_arguments to the DFG. No other arguments-related
opcodes are added by this change, though it does add a lot of the scaffolding
necessary for the other ops.

This also adds GetByVal/PutByVal optimizations for Arguments.

Finally, this rationalizes slowPathCall with no return. Previously, that would
work via callOperation() overloads that took InvalidGPRReg as the return GPR.
But that creates awful ambiguity, since we had template functions that were
polymorphic over all parameters except the second, which was a GPRReg, and a
bunch of non-template overloads that also potentially had GPRReg as the second
argument. I finally started to hit this ambiguity and was getting absolutely
bizarre compiler errors, that made me feel like I was programming in SML. So,
I changed the no-argument overloads to take NoResultTag instead, which made
everything sensible again by eliminating the overload ambiguity.

This is a ~7% speed-up on V8/earley and neutral elsewhere.

  • bytecode/PredictedType.h:

(JSC::isArgumentsPrediction):
(JSC):
(JSC::isActionableMutableArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::unmodifiedArgumentsRegister):
(Node):
(JSC::DFG::Node::shouldSpeculateArguments):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(DFG):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Arguments.h:

(ArgumentsData):
(Arguments):
(JSC::Arguments::offsetOfData):

12:54 PM Changeset in webkit [118029] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116325
BUG=126406
Review URL: https://chromiumcodereview.appspot.com/10399133

12:53 PM Changeset in webkit [118028] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 116325
BUG=126406
Review URL: https://chromiumcodereview.appspot.com/10416046

12:39 PM Changeset in webkit [118027] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116545
BUG=127366
Review URL: https://chromiumcodereview.appspot.com/10407103

12:37 PM Changeset in webkit [118026] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 116545
BUG=127366
Review URL: https://chromiumcodereview.appspot.com/10408066

12:34 PM Changeset in webkit [118025] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 116669
BUG=127367
Review URL: https://chromiumcodereview.appspot.com/10422003

12:33 PM Changeset in webkit [118024] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 116669
BUG=127367
Review URL: https://chromiumcodereview.appspot.com/10414053

12:30 PM Changeset in webkit [118023] by cevans@google.com
  • 3 edits
    10 copies in branches/chromium/1132

Merge 117012
BUG=124625
Review URL: https://chromiumcodereview.appspot.com/10388233

12:28 PM Changeset in webkit [118022] by cevans@google.com
  • 3 edits
    10 copies in branches/chromium/1084

Merge 117012
BUG=124625
Review URL: https://chromiumcodereview.appspot.com/10408065

12:26 PM Changeset in webkit [118021] by fpizlo@apple.com
  • 15 edits in branches/dfgopt/Source/JavaScriptCore

DFG ConvertThis should just be a CheckStructure if the structure is known
https://bugs.webkit.org/show_bug.cgi?id=87057

Reviewed by Gavin Barraclough.

This gives ValueProfile the ability to track singleton values - i.e. profiling
sites that always see the same value.

That is then used to profile the structure in op_convert_this.

This is then used to optimize op_convert_this into a CheckStructure if the
structure is always the same.

That then results in better CSE in inlined code that uses 'this', since
previously we couldn't CSE accesses on 'this' from different inline call frames.

Also fixed a bug where we were unnecessarily flushing 'this'.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):

  • bytecode/LazyOperandValueProfile.h:

(CompressedLazyOperandValueProfileHolder):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(ValueProfileBase):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSValue.h:

(JSValue):

  • runtime/Structure.h:

(JSC::JSValue::structureOrUndefined):
(JSC):

12:23 PM Changeset in webkit [118020] by rafael.lobo@openbossa.org
  • 4 edits in trunk

[Qt] canvas/philip/tests/2d.path.stroke.overlap.html fails with Qt-4.6.2 or higher
https://bugs.webkit.org/show_bug.cgi?id=40362

Reviewed by Noam Rosenthal.

Source/WebCore:

Before drawing the stroke from a certain path, it should make the union of the stroke areas.
The previous implementation didn't consider that so the intersection was painted twice.
By using QPainterPathStroker, we create a QPainterPath on top of the platform path, and
then we fill it with the expected brush. This way we avoid repainting areas.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::fillPathStroke):
(WebCore):
(WebCore::GraphicsContext::strokePath):

LayoutTests:

  • platform/qt/Skipped: Unskip test after fix.
12:17 PM Changeset in webkit [118019] by ggaren@apple.com
  • 14 edits
    2 adds in trunk/Source

GC allocation trigger should be tuned to system RAM
https://bugs.webkit.org/show_bug.cgi?id=87039

Reviewed by Darin Adler.

../JavaScriptCore:

This helps avoid OOM crashes on small platforms, and helps avoid "too much GC"
performance issues on big platforms.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::collect):

  • heap/Heap.h:

(Heap): GC balances between a fixed minimum and a proportional multiplier,
which are limited based on system RAM.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):

  • runtime/JSGlobalData.h:

(JSGlobalData): Renamed HeapSize to HeapType because the exact size is
influenced by the heap type, but not determined by it.

../WTF:

Added a helper function for measuring system RAM.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/AmountOfRAM.cpp: Added.

(WTF):
(WTF::computeAmountOfRAM):
(WTF::amountOfRAM):

  • wtf/AmountOfRAM.h: Added.

(WTF):

  • wtf/CMakeLists.txt:
  • wtf/StdLibExtras.h:

(WTF):

12:10 PM Changeset in webkit [118018] by barraclough@apple.com
  • 23 edits in trunk

Disable private names by default in WebCore
https://bugs.webkit.org/show_bug.cgi?id=87088

Reviewed by Geoff Garen.

r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
These are probably not yet ready to be web-facing, so disabling by default in WebCore.
Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.

Source/JavaScriptCore:

  • jsc.cpp:

(GlobalObject):
(GlobalObject::javaScriptExperimentsEnabled):

  • Implemented new trap to opt-in to private names support.
  • runtime/JSGlobalObject.cpp:

(JSC):
(JSC::JSGlobalObject::reset):

  • Only add the Name property to the global object if experiments are enabled.
  • runtime/JSGlobalObject.h:

(GlobalObjectMethodTable):

  • Added new trap to enabled experiments.

(JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):

  • Set the global object's m_experimentsEnabled state on construction.

(JSC::JSGlobalObject::javaScriptExperimentsEnabled):

  • Defaults to off.

Source/WebCore:

  • WebCore.exp.in:
    • Added export.
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):
(WebCore::JSDOMWindowBase::javaScriptExperimentsEnabled):

  • Override default from JSC, enable based on corresponding Setting.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • Added declaration for javaScriptExperimentsEnabled.
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setJavaScriptExperimentsEnabled):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::javaScriptExperimentsEnabled):

  • Added Setting, reflecting WebPreference.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setJavaScriptExperimentsEnabled:]):
(-[WebPreferences javaScriptExperimentsEnabled]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

  • Added JavaScriptExperimentsEnabled to WebPreferences.

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaScriptExperimentsEnabled):
(WKPreferencesGetJavaScriptExperimentsEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • Added JavaScriptExperimentsEnabled to WebPreferences.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • Enable private name support in DRT.
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

  • Enable private name support in WKTR.
12:09 PM Changeset in webkit [118017] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117304
BUG=128336
Review URL: https://chromiumcodereview.appspot.com/10409072

12:08 PM Changeset in webkit [118016] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 117304
BUG=128336
Review URL: https://chromiumcodereview.appspot.com/10412038

12:02 PM Changeset in webkit [118015] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

Merge 116717
BUG=124992
Review URL: https://chromiumcodereview.appspot.com/10421016

12:00 PM Changeset in webkit [118014] by cevans@google.com
  • 1 edit in branches/chromium/1084/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

Merge 116717
BUG=124992
Review URL: https://chromiumcodereview.appspot.com/10412037

12:00 PM Changeset in webkit [118013] by eae@chromium.org
  • 5 edits in trunk/LayoutTests

REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=87145

Reviewed by Levi Weintraub.

Fix zoom-in-length-round-trip to support subpixel support turned on or off.

  • fast/css/zoom-in-length-round-trip.html:
11:50 AM Changeset in webkit [118012] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

!HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build
https://bugs.webkit.org/show_bug.cgi?id=87141

Reviewed by Eric Seidel.

In the Chromium Android build there is still one remaining dependency
on object files in the accessibility directory:
AccessibilityObject::actionVerb. I missed this function in my previous
patch, but this patch changes it to be an inline stub.

  • accessibility/AccessibilityObject.cpp:

(WebCore):

  • accessibility/AccessibilityObject.h:

(WebCore):
(WebCore::actionVerb):
(WebCore::AccessibilityObject::lineForPosition):
(WebCore::AccessibilityObject::updateBackingStore):

11:46 AM Changeset in webkit [118011] by jsbell@chromium.org
  • 12 edits
    3 adds in trunk

IndexedDB: Support Array-type key paths
https://bugs.webkit.org/show_bug.cgi?id=84207

Reviewed by Tony Chang.

Source/WebCore:

Implement IDB spec behavior that key paths can be arrays of strings; when
evaluated, these yield arrays of keys, providing compound key support. Also
changes exception types to match the spec.

Test: storage/indexeddb/keypath-arrays.html
Test: storage/indexeddb/keypath-basics.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Look for both string and array in option dict,
throw exceptions for forbidden combinations of key generator and key paths.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Handle special cases (accepted and forbidden).
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):
(WebCore::IDBObjectStore::createIndex): Overloads to satisfy IDL overloads and optional dicts.

  • Modules/indexeddb/IDBObjectStore.idl: Add DOMString array overload.
  • bindings/v8/IDBBindingUtilities.cpp: Implement spec logic for evaluating array key paths.

(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore):

LayoutTests:

  • storage/indexeddb/keypath-arrays-expected.txt: Added.
  • storage/indexeddb/keypath-arrays.html: Added.
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(cleanDatabase):

  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/resources/keypath-arrays.js: Added.

(test.request.onsuccess):
(test):
(openSuccess.request.onsuccess):
(openSuccess):
(testKeyPaths.checkStore.request.onsuccess):
(testKeyPaths.checkStore):
(testKeyPaths.checkIndex.request.onsuccess):
(testKeyPaths.checkIndex):
(testKeyPaths):

  • storage/indexeddb/resources/keypath-basics.js:
11:37 AM Changeset in webkit [118010] by mrobinson@webkit.org
  • 6 edits in trunk/Source

[GTK] REGRESSION(r116135): Keys that confirm composition trigger a default action
https://bugs.webkit.org/show_bug.cgi?id=86925

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. Creating tests for GTK+ input methods is quite difficult, as they
can differ from machine to machine. It's also hard to simulate composition
sequences.

  • platform/gtk/CompositionResults.h: Instead of holding composition results, just

keep a flag describing whether or not this event had results.
(CompositionResults):

Source/WebKit/gtk:

Instead of sending composition results with a keydown event, simply send whether
or not the event had results. Activate the results after processing the event. This
allows for input methods to modify the DOM after the keydown event and to still
prevent the default action during handleInputMethodKeydown.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::respondToChangedSelection): This patch removes the m_updatingComposition
so we no longer have to check it here.
(WebKit::EditorClient::keyboardEventHadCompositionResults): Added.
(WebKit::EditorClient::handleInputMethodKeydown): Now prevent the default action when
the keyboard event had composition results.
(WebKit::EditorClient::EditorClient):

  • WebCoreSupport/EditorClientGtk.h: Remove the m_updatingComposition member, as it's no

longer used.

  • WebCoreSupport/WebViewInputMethodFilter.cpp:

(WebKit::WebViewInputMethodFilter::sendKeyEventWithCompositionResults): Now send the
composition results after the key event.

11:34 AM Changeset in webkit [118009] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

Fix a small syntax error in the GTK+ API test runner.

Reviewed by Gustavo Noronha Silva.

  • gtk/run-api-tests:

(TestRunner._setup_testing_environment): When reporting the error use
the correct Python format string syntax.

11:30 AM Changeset in webkit [118008] by cevans@google.com
  • 14 edits
    2 copies in branches/chromium/1084

Merge 116174
BUG=124617
Review URL: https://chromiumcodereview.appspot.com/10383285

11:18 AM Changeset in webkit [118007] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
https://bugs.webkit.org/show_bug.cgi?id=86962

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-22
Reviewed by Gustavo Noronha Silva.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setCacheModel): Sets WEBKIT_CACHE_MODEL_WEB_BROWSER if argument is 2.

11:11 AM Changeset in webkit [118006] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][DRT] Key modifier bit flags have enum type.
https://bugs.webkit.org/show_bug.cgi?id=86838

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-22
Reviewed by Antonio Gomes.

Refactoring. Key modifier flags are unsigned int.
Key modifier bit flags used have enum type. It caused problems as a key can have several modifiers
at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift)
would have been out of EvasKeyModifier enum.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(setEvasModifiers):
(modifiersFromJSValue):
(mouseDownCallback):
(mouseUpCallback):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):

11:11 AM Changeset in webkit [118005] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Assertion failure (toRenderBox() called on a RenderInline) beneath RenderBlock::blockBeforeWithinSelectionRoot()
https://bugs.webkit.org/show_bug.cgi?id=86500

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/block/line-layout/selection-highlight-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Demoted the object local variable to
RenderObject, changed use of parentBox() to parent(), and added toRenderBlock() in two places.

LayoutTests:

  • fast/block/line-layout/selection-highlight-crash-expected.txt: Added.
  • fast/block/line-layout/selection-highlight-crash.html: Added.
10:58 AM Changeset in webkit [118004] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] jquery/attributes.html SLOW -> TIMEOUT

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:53 AM Changeset in webkit [118003] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=87145
REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots

  • platform/mac/Skipped: Skipping until Levi Weintraub can explore the regression.
10:51 AM Changeset in webkit [118002] by rwlbuis@webkit.org
  • 4 edits
    2 adds in trunk

ASSERTs in RenderInline::layout()
https://bugs.webkit.org/show_bug.cgi?id=63365

Patch by Rob Buis <rbuis@rim.com> on 2012-05-22
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Do not allow creation of renderers for text content children in elements by default.
Subclasses like SVGTextElement override this behavior.
This also fixes the <a><textPath</a> case because the <a> parent decides to allow <textPath> or not:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environment

Test: svg/custom/disallowed-text-content-rendering.svg

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

LayoutTests:

Test text content element children inside elements.

  • svg/custom/disallowed-text-content-rendering-expected.txt: Added.
  • svg/custom/disallowed-text-content-rendering.svg: Added.
10:45 AM Changeset in webkit [118001] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
https://bugs.webkit.org/show_bug.cgi?id=86694

Source/WebCore:

As KeyboardEvent for left/right location key, e.g. left-control,
right-control, provides DOM_KEY_LOCATION_STANDARD as keyLocation property,
modified KeyCodeConversion to make PlatformKeyboardEvent
provide virtual keycodes with location information, e.g. VK_LCONTROL or
VK_RCONTROL, and modified KeyboardEvent to generate location information
from the virtual keycodes, e.g. genrating DOM_KEY_LOCATION_LEFT for
VK_LCONTROL. KeyboardEvent also removes location information from
the virtual keycodes, e.g. genrating VK_CONTROL for VK_LCONTROL.
The location property is defined in the W3C DOM3 specification:
http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-22
Reviewed by Alexey Proskuryakov.

Test: fast/events/keydown-leftright-keys.html

  • dom/KeyboardEvent.cpp:

(WebCore::windowsVirtualKeyCodeWithoutLocation):
Added a function which removes location information from a given
keycode. For example, when VK_LCONTROL is given, returns VK_CONTROL.
(WebCore::keyLocationCode):
Added a function which provides location information from a given
keycode. For example, when VK_LCONTROL is given,
returns DOM_KEY_LOCATION_LEFT.
(WebCore::KeyboardEvent::KeyboardEvent):
Initialized m_keyLocation by using the above keyLocationCode.
(WebCore::KeyboardEvent::keyCode):
Modified to use the above two functions to initialize keycode property
and keylocation property.

  • platform/chromium/KeyCodeConversionAndroid.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::windowsKeyCodeForKeyCode):
Modified these keycode conversions to return keycodes with location
information, e.g. modified keycode conversions returns VK_LCONTROL
for left control.

Tools:

Modify keyDown to create left- and right- control, shift, and alt
keyevent for a test to check that keyLocation property can have
DOM_KEY_LOCATION_LEFT for left-control, shift, and alt, and
DOM_KEY_LOCATION_RIGHT for right-control, shift, and alt.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-22
Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::keyDown):

  • DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController keyDown:withModifiers:withLocation:]):

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-22
Reviewed by Alexey Proskuryakov.

  • fast/events/keydown-leftright-keys-expected.txt: Added.
  • fast/events/keydown-leftright-keys.html: Added.
10:42 AM Changeset in webkit [118000] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL] EFL's DRT needs to print information about received Web Intents
https://bugs.webkit.org/show_bug.cgi?id=86864

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-22
Reviewed by Adam Barth.

.:

Enable Web Intents by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

  • ewk/ewk_intent.cpp:

(ewk_intent_suggestions_get): Add function to retrieve suggested
service URLs for an intent.
(ewk_intent_extra_names_get): Add function to retrieve names of
extra metadata for an intent.
(ewk_intent_new): Correctly initialize Ewk_Intent members to avoid
crashes.
(ewk_intent_free): Unref shared strings.

  • ewk/ewk_intent.h:

Tools:

Catch "intent,new" signal in EFL's DumpRenderTree and dump information
about the intent. This output is expected by several webintents test
cases.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentNew):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip a few Web Intents tests that are passing now that the
functionality is enabled by default on EFL port.

  • platform/efl/test_expectations.txt:
10:41 AM Changeset in webkit [117999] by pfeldman@chromium.org
  • 15 edits in trunk/Source/WebCore

Web Inspector: provide content-related actions on the sources panel.
https://bugs.webkit.org/show_bug.cgi?id=87144

Reviewed by Vsevolod Vlasov.

Now that the authoring focus moved to the Source panel, context menu actions should follow:

  • refactored context menu actions to be provider-based
  • edited call sites to add applicable actions.
  • English.lproj/localizedStrings.js:
  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextMenu.prototype.appendApplicableItems):

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.unregisterHandler):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems.doSave):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype.searchCanceled):
(WebInspector.NetworkPanel.prototype.appendApplicableItems.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.appendApplicableItems):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):

  • inspector/front-end/UIUtils.js:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.js:

(WebInspector._doLoadedDoneWithCapabilities.get if):

10:38 AM Changeset in webkit [117998] by zmo@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp

Merge 117814 - Restore WebGL's framebuffer binding after DrawingBuffer's prepareBackBuffer()
https://bugs.webkit.org/show_bug.cgi?id=87032

Reviewed by James Robinson.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::prepareBackBuffer): restore the user's framebuffer binding if there is one.

TBR=zmo@google.com

10:37 AM Changeset in webkit [117997] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=87138

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-22

  • platform/efl/test_expectations.txt:
10:33 AM Changeset in webkit [117996] by gavinp@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Remove old staging enum value WebURLRequest::TargetType::TargetIsPrerender
https://bugs.webkit.org/show_bug.cgi?id=85021

Reviewed by Adam Barth.

  • chromium/public/WebURLRequest.h:
10:32 AM Changeset in webkit [117995] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

Give FileInputType a setFiles() method, let Drag-n-Drop call it.
https://bugs.webkit.org/show_bug.cgi?id=87139

Reviewed by Ojan Vafai.

filesChosen(), the FileChooserClient callback, used to modify
m_fileList directly. Instead, convert the FileChooserClient
data to a FileList and pass that to a factored-out setFiles()
method. This is in preparation to making the files property
writable.

Pure refactoring, no functionality change.

  • html/FileInputType.cpp:

(WebCore::FileInputType::toFileList):
(WebCore::FileInputType::setFiles):
(WebCore::FileInputType::filesChosen):
(WebCore):

  • html/FileInputType.h:

(FileInputType):

10:25 AM Changeset in webkit [117994] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Intent::create() throws is service is "url://a url"
https://bugs.webkit.org/show_bug.cgi?id=86873

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-22
Reviewed by Adam Barth.

Remove checks in webintents/web-intents-obj-constructor.html which are
valid for Google URL but fail with KURL.

  • webintents/web-intents-obj-constructor-expected.txt:
  • webintents/web-intents-obj-constructor.html:
10:18 AM Changeset in webkit [117993] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Truncating multiplication on integers should not OSR exit every time
https://bugs.webkit.org/show_bug.cgi?id=85752

Reviewed by Gavin Barraclough.

Merge r116264 from dfgopt.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::mulShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMul):

10:13 AM Changeset in webkit [117992] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: JavaScriptSourceFrame should be based on JavaScriptSource not UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=87135

Reviewed by Pavel Feldman.

Source/WebCore:

Renamed _uiSourceCode to _javaScriptSource in JavaScriptSourceFrame.
Removed unused uiSourceCode getter from JavaScriptSourceFrame.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/script-formatter-breakpoints.html:
  • inspector/debugger/script-formatter-console.html:
  • inspector/debugger/source-frame-count.html:
10:04 AM Changeset in webkit [117991] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

add OVERRIDE annotations to classes derived from CCAnimationCurve
https://bugs.webkit.org/show_bug.cgi?id=87073

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-22
Reviewed by James Robinson.

No new tests required.

  • platform/graphics/chromium/cc/CCAnimationCurve.h:
9:58 AM Changeset in webkit [117990] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

add OVERRIDE annotations to CCThreadTask
https://bugs.webkit.org/show_bug.cgi?id=87074

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-22
Reviewed by James Robinson.

No new tests required.

  • platform/graphics/chromium/cc/CCThreadTask.h:
9:47 AM Changeset in webkit [117989] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Move asserts in CCLayerTreeHostTest::dispatch*
https://bugs.webkit.org/show_bug.cgi?id=87134

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-22
Reviewed by Adrienne Walker.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimateAndCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::dispatchSetVisible):
(WTF::CCLayerTreeHostTest::dispatchSetInvisible):

9:43 AM Changeset in webkit [117988] by jchaffraix@webkit.org
  • 8 edits
    6 adds in trunk

Centralize and clean-up table column iteration
https://bugs.webkit.org/show_bug.cgi?id=87051

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/table/caption-between-column-and-column-group.html

fast/table/caption-between-column-group-and-column.html
fast/table/caption-between-columns.html

The existing code had duplications between different classes and some
of the iterating functions could use a better place. That's what this
change solves, along with several renamings.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColumnGroupWithColumnChildren):
Renamed isTableColGroup to this to better reflect what it checks.
Also added a new function: nextColumn.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Updated after isTableColGroup renaming.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::firstColumn):
Added this new function to get the first column (or column group).

(WebCore::RenderTable::colElement):
Cleaned up this function: switched the loop to a 'for' now that the
helper functions make it easy. Cleaned up the ordering and the naming.

  • rendering/RenderTable.h:

Added firstColumn.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
Updated to use nextColumn().

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::nextColumn):
Added this new helper function to centralize the code to iterate over columns.

LayoutTests:

Those tests just validate and enforce what we were already doing that were
not covered by any existing tests.

  • fast/table/caption-between-column-and-column-group-expected.html: Added.
  • fast/table/caption-between-column-and-column-group.html: Added.
  • fast/table/caption-between-column-group-and-column-expected.html: Added.
  • fast/table/caption-between-column-group-and-column.html: Added.
  • fast/table/caption-between-columns-expected.html: Added.
  • fast/table/caption-between-columns.html: Added.
9:41 AM Changeset in webkit [117987] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Make color of spelling check marker cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=87095

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-22
Reviewed by Adam Barth.

Pixel layout is RGBA on Android, while it is BGRA on other platforms.

No new tests. To run tests on Android.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

9:41 AM Changeset in webkit [117986] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] Add support to enable/disable DOM paste
https://bugs.webkit.org/show_bug.cgi?id=85040

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-22
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add support to enable/disable DOM paste setting so that document.execCommand()
allows paste command when this setting is enabled. Also, update documentation
for scripts_can_access_clipboard setting in ewk_view.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_access_clipboard_set):

  • ewk/ewk_view.h:

Tools:

Enable JavascriptCanAccessClipboard setting on each test startup so
that test cases which rely on clipboard can be unskipped.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Unskip a few clipboard related tests which are now passing.

  • platform/efl/test_expectations.txt:
9:32 AM Changeset in webkit [117985] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
https://bugs.webkit.org/show_bug.cgi?id=87125

Patch by Konrad Piascik <kpaiscik@rim.com> on 2012-05-22
Reviewed by Rob Buis.

Removed unimplemented methods that are no longer part of InspectorClient and added
a new stub for InspectorStateClient::updateInspectorStateCookie

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
(WebCore):

  • WebCoreSupport/InspectorClientBlackBerry.h:

(InspectorClientBlackBerry):

9:22 AM Changeset in webkit [117984] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Skip asserting test in win debug following subpixel layout changes.
https://bugs.webkit.org/show_bug.cgi?id=87137

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
9:17 AM Changeset in webkit [117983] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=86284

Unreviewed, removing test expectations for tests that should pass now
that the web view is repainted before dumping pixel results.

  • platform/gtk/test_expectations.txt:
9:10 AM Changeset in webkit [117982] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=87136
REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing on Mac bots.

  • platform/mac/Skipped: Skipping tests until Kenneth Russel can take a look.
9:10 AM Changeset in webkit [117981] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Expand damage from the background-blurred layer to ensure readback is only including pixels below that layer
https://bugs.webkit.org/show_bug.cgi?id=86884

Reviewed by Adrienne Walker.

Source/WebCore:

Consider layers in back-to-front order A, B, and C, where layer B has
a blur background filter applied, and C exactly covers A. When B does
its readback to perform its blur, it should include the pixels of A
not C. With partial swap, if B is damaged, that damaged area will read
pixels from outside of the damage rect. Those pixels should use the
contents of A, not C, so we must expand the damage to ensure we redraw
all pixels that are going to be included in the blur for the current
frame.

Also, when a layer below B has damage outside the contentBounds of B
but within its blur radius, then that damage will be blurred inside B,
so expand all damage within B's blurred contentBounds.

Unit test: CCDamageTrackerTest.verifyDamageForBackgroundBlurredChild

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::expandRectWithFilters):
(WebCore::expandDamageRectInsideRectWithFilters):
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

9:07 AM Changeset in webkit [117980] by mihnea@adobe.com
  • 12 edits
    2 adds in trunk

[CSSRegions] Add region styling support for color property
https://bugs.webkit.org/show_bug.cgi?id=85633

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/region-style-color.html

This patch extends the region styling support. In addition to background-color, it adds
the possibility of styling color in regions.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore):
(WebCore::RenderFlowThread::checkRegionsWithStyling):

  • rendering/RenderFlowThread.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):

  • rendering/RenderRegion.h:

(RenderRegion):
(ObjectRegionStyleInfo):

LayoutTests:

Added region-style-color.html and its associated ref test for testing the color in region style rules.
Modified region-style-image-background-color/region-style-inline-background-color since background color
can be styled for inline/replaced elements.

  • fast/regions/region-style-color-expected.html: Added.
  • fast/regions/region-style-color.html: Added.
  • fast/regions/region-style-image-background-color.html:
  • fast/regions/region-style-inline-background-color-expected.html:
  • fast/regions/region-style-inline-background-color.html:
8:57 AM Changeset in webkit [117979] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=87114

Reviewed by Nate Chapin.

GenerateSetDOMException() is used by only one place. This patch removes it.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

8:55 AM Changeset in webkit [117978] by dgrogan@chromium.org
  • 8 edits
    1 copy
    1 add in trunk/Source

IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

8:41 AM Changeset in webkit [117977] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-05-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Follow-up patch after r117975, as the strict approach fires assertions.

CSS generated content can violate the ASSERT(child->isSVGInline()
child->isSVGInlineText()) logic.
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::subtreeChildWasAdded): (WebCore::RenderSVGText::subtreeChildWillBeRemoved):
8:24 AM Changeset in webkit [117976] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

Chromium AX: Crash when menulist adds selected option via document.write
https://bugs.webkit.org/show_bug.cgi?id=87028

Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/chromium/accessibility/add-to-menu-list-crashes.html

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):

LayoutTests:

  • platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added.
  • platform/chromium/accessibility/add-to-menu-list-crashes.html: Added.
8:21 AM Changeset in webkit [117975] by Nikolas Zimmermann
  • 5 edits
    2 adds in trunk

Crash in WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap
https://bugs.webkit.org/show_bug.cgi?id=86781

Reviewed by Rob Buis.

Source/WebCore:

Always invalidate the text positioning element cache if the <text> render subtree mutates.
Currently only RenderSVGInlineText renderers are tracked correctly, RenderSVGInline
renderers like RenderSVGTSpan didn't cause text positioning element cache mutations
so far. Fix that.

Test: svg/custom/bug86781.html

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::removeChild):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::removeChild):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

LayoutTests:

  • svg/custom/bug86781-expected.txt: Added.
  • svg/custom/bug86781.html: Added.
8:04 AM Changeset in webkit [117974] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: make "Go to source" shortcut accessible from all panels.
https://bugs.webkit.org/show_bug.cgi?id=87132

Reviewed by Vsevolod Vlasov.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype.handleShortcut):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
(WebInspector.OpenResourceDialog.show):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.handleShortcut):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):

7:48 AM Changeset in webkit [117973] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: speedUp buildAggregates.
https://bugs.webkit.org/show_bug.cgi?id=87131

Engine can't inline getters and use fast-case if the function has for(i in object) loops.

Reviewed by Yury Semikhatsky.

No logic changes.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.classIndex):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):

7:44 AM Changeset in webkit [117972] by Nikolas Zimmermann
  • 1 edit
    3 adds in trunk/LayoutTests

2012-05-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Re-add expected results for three tests that were missing.

  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
7:42 AM Changeset in webkit [117971] by Nikolas Zimmermann
  • 15 edits
    4 adds
    2 deletes in trunk

Crash in WebCore::RenderSVGContainer::paint
https://bugs.webkit.org/show_bug.cgi?id=86392

Reviewed by Rob Buis.

Source/WebCore:

Modernize the <marker> code, switch to the same design pattern used for handling zero-length subpaths.
Decouple the generation of the marker start/mid/end positions from the actual usage of these information.
Only generate those marker positions if the underlying Path changes, and never else.

When figuring out the bounds for a shape, access to current set of RenderSVGResourceMarker start/mid/end resources
and ask the marker resources for their bounds using the previously figured out marker positions on the Path.
Drawing markers is handled in the same way.

Remove SVGMarkerLayoutInfo alltogether which stored raw pointers to the RenderSVGResourceMarkers.
We assumed that those objects would stay alive from layout() to paint(), but that assumption is wrong.

Tests: svg/custom/bug86392.html

svg/custom/marker-zero-length-linecaps-expected.svg
svg/custom/marker-zero-length-linecaps.svg

  • CMakeLists.txt: Remove SVGMarkerLayoutInfo.*.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/svg/RenderSVGAllInOne.cpp: Ditto.
  • rendering/svg/RenderSVGShape.cpp: Handle markers just like the existing zero leng subpath code, which is superior.

(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
(WebCore::RenderSVGShape::paint):
(WebCore::markerForType):
(WebCore::RenderSVGShape::markerRect):
(WebCore::RenderSVGShape::inflateWithStrokeAndMarkerBounds):
(WebCore::RenderSVGShape::drawMarkers):
(WebCore::RenderSVGShape::processMarkerPositions):

  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):

  • rendering/svg/SVGMarkerData.h:

(WebCore::MarkerPosition::MarkerPosition):
(MarkerPosition):
(WebCore::SVGMarkerData::SVGMarkerData):
(WebCore::SVGMarkerData::updateFromPathElement):
(WebCore::SVGMarkerData::pathIsDone):
(SVGMarkerData):
(WebCore::SVGMarkerData::currentAngle):

  • rendering/svg/SVGMarkerLayoutInfo.cpp: Removed.
  • rendering/svg/SVGMarkerLayoutInfo.h: Removed.
  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::resourcesCacheFromRenderObject):
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject):

  • rendering/svg/SVGResourcesCache.h:

(SVGResourcesCache):

LayoutTests:

  • svg/custom/bug86392-expected.txt: Added.
  • svg/custom/bug86392.html: Added.
  • svg/custom/marker-zero-length-linecaps-expected.svg: Added.
  • svg/custom/marker-zero-length-linecaps.svg: Added.
7:32 AM Changeset in webkit [117970] by apavlov@chromium.org
  • 8 edits in trunk/Source

[Chromium] Implement the ContextMenuItem SubMenu type
https://bugs.webkit.org/show_bug.cgi?id=86625

Reviewed by Pavel Feldman.

Source/WebCore:

This change is the WebKit part of a two-sided patch that adds subMenuItems to ContextMenuItem
and introduces code needed to handle it properly.

  • platform/ContextMenuItem.h:

(PlatformMenuItemDescription): Add a Vector for subMenuItems.

  • platform/PlatformMenuDescription.h:

(WebCore): Introduce a meaningful typedef for PlatformMenuDescription in Chromium.

  • platform/chromium/ContextMenuChromium.cpp:

(WebCore::ContextMenu::itemWithAction): Search submenus when looking up a requested action id.
(WebCore::ContextMenu::platformDescription): Return a real PlatformMenuDescription rather than 0.

  • platform/chromium/ContextMenuItemChromium.cpp:

(WebCore::ContextMenuItem::ContextMenuItem): Set submenu if one has been passed in.
(WebCore::ContextMenuItem::platformSubMenu): Return real subMenuItems instead of an empty PlatformMenuDescription.
(WebCore::ContextMenuItem::setSubMenu): Implemented.
(WebCore):

Source/WebKit/chromium:

  • public/WebMenuItemInfo.h:

(WebMenuItemInfo): Add the SubMenu type and a vector of subMenuItems.

  • src/ContextMenuClientImpl.cpp:

(WebKit::populateSubMenuItems): A recursive implementation that populates submenu items as well as other item types.
(WebKit):
(WebKit::ContextMenuClientImpl::populateCustomMenuItems): Consider submenus when populating WebMenuItemInfos.

7:06 AM Changeset in webkit [117969] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: use canvas to render timeline category strips in overview pane
https://bugs.webkit.org/show_bug.cgi?id=87109

Reviewed by Pavel Feldman.

  • use canvas, not DOM to represent timeline category strips in the default overview mode
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview): propagate to TimelineCategoryStrips;
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged): force update of category strips;
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.setShowShortEvents):
(WebInspector.TimelineCategoryStrips):
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord): process one record;
(WebInspector.TimelineCategoryStrips.prototype.update): re-draw everything;
(WebInspector.TimelineCategoryStrips.prototype.setShowShortEvents):
(WebInspector.TimelineCategoryStrips.prototype._renderBar): render single bar;
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.createFillStyle): utility methods to create gradients for category bars;
(WebInspector.TimelinePresentationModel.createFillStyleForCategory):
(WebInspector.TimelineCategory):

7:04 AM Changeset in webkit [117968] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Clean up internal viewport animation API
https://bugs.webkit.org/show_bug.cgi?id=87130

Reviewed by Simon Hausmann.

const'ify classes which should be const.

There is now only one method which can animate, animateItemRectVisible
which is used for also animating the contents back into valid bounds.
The valid bounds are computed using a separate method. It is now more
clear when an animation is used or not and asserts are added for
ensuring no concurrent animations as well as proper update deferring.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::didChangeViewportProperties):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::itemRectFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::nearestValidBounds):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

7:02 AM Changeset in webkit [117967] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=87122

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-22

  • platform/efl/test_expectations.txt:
6:55 AM Changeset in webkit [117966] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: [regression] dynamically created script tab is bound to the document resource.
https://bugs.webkit.org/show_bug.cgi?id=87119

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/debugger/dynamic-script-tag.html

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger.didSetBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.rawLocationToUILocation):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location.prototype.update):

LayoutTests:

  • inspector/debugger/dynamic-script-tag-expected.txt: Added.
  • inspector/debugger/dynamic-script-tag.html: Added.
6:50 AM Changeset in webkit [117965] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: JavaScript breakpoints disappear when Ctrl+S is pressed for the script without changes.
https://bugs.webkit.org/show_bug.cgi?id=87121

Reviewed by Pavel Feldman.

JavaScriptSourceFrame and StylesSourceFrame should not commit working copy unless UISourceCode is dirty.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSourceFrame.prototype.commitEditing):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.commitWorkingCopy):

6:47 AM Changeset in webkit [117964] by alexis.menard@openbossa.org
  • 2 edits in trunk/Tools

[Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
https://bugs.webkit.org/show_bug.cgi?id=87044

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-22
Reviewed by Alexis Menard.

Use sendOrQueueEvent instead of m_testController->mainWebView()->sendEvent

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::keyDown):

6:28 AM Changeset in webkit [117963] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][DRT] Gardening of fast/spatial-navigation tests.
https://bugs.webkit.org/show_bug.cgi?id=87112

Unreviewed gardening. Unskipped some fast/spatial-navigation tests after r117218.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-22

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
6:25 AM Changeset in webkit [117962] by loislo@chromium.org
  • 4 edits in trunk

Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
https://bugs.webkit.org/show_bug.cgi?id=87124

I found that in all dominators related functions we use nodeOrdinals.
At the moment we divide nodeIndex to nodeFieldCount and this operation too expensive for these simple algorithms.

Reviewed by Yury Semikhatsky.

Covered by existing tests.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):

LayoutTests:

  • inspector/profiler/heap-snapshot.html:
6:07 AM Changeset in webkit [117961] by yurys@chromium.org
  • 3 edits
    1 add in trunk/Source/WebCore

Web Inspector: annotate InjectedScriptSource.js for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=87120

Reviewed by Pavel Feldman.

Annotated InjectedScriptSource.js for closure compiler. Replaced call of undefined
_isPrimitiveValue function with isPrimitiveValue.

  • inspector/InjectedScriptExterns.js: Added. External APIs used in InjectedScriptSource.js

(console.log):
(InjectedScriptHost.prototype.storageId):
(InjectedScriptHost.prototype.functionDetails):
(InjectedScriptHost.prototype.isHTMLAllCollection):
(InjectedScriptHost.prototype.internalConstructorName):
(InjectedScriptHost.prototype.copyText):
(InjectedScriptHost.prototype.clearConsoleMessages):
(InjectedScriptHost.prototype.inspectedObject):
(InjectedScriptHost.prototype.databaseId):
(InjectedScriptHost.prototype.inspect):
(InjectedScriptHost.prototype.type):
(InjectedScriptHost.prototype.getEventListeners):
(JavaScriptCallFrame.prototype.scopeType):

  • inspector/InjectedScriptSource.js:
6:03 AM Changeset in webkit [117960] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Speed up CCLayerTreeHostTestTickAnimationWhileBackgrounded
https://bugs.webkit.org/show_bug.cgi?id=86871

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-22
Reviewed by James Robinson.

Source/WebCore:

With this patch, the background animation timer is lazily created,
allowing for different time intervals to be used. In particular, a
very short interval for unit tests.

Unit tests: CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThread

CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setBackgroundTickingEnabled):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::animateLayers):
(WebCore::CCLayerTreeHostImpl::lowFrequencyAnimationInterval):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setVisible):

Source/WebKit/chromium:

Use a shorter time interval for background animation ticking so that
unit tests can run faster.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
(MockLayerTreeHostImpl):

5:35 AM Changeset in webkit [117959] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Test expectations need updating
https://bugs.webkit.org/show_bug.cgi?id=87115

Unreviewed EFL gardening. Update expectations for 2 test cases which
are failing after r117932.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-22

  • platform/efl/test_expectations.txt:
5:22 AM Changeset in webkit [117958] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Styles] Odd synthetic shorthands may appear in the style
https://bugs.webkit.org/show_bug.cgi?id=87081

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/resources/elements-panel-styles.css:

(.foo):

5:14 AM Changeset in webkit [117957] by hayato@chromium.org
  • 6 edits in trunk

Fix crashes when a mouse points a <svg> element in shadow DOM subtree.
https://bugs.webkit.org/show_bug.cgi?id=86795

Reviewed by Nikolas Zimmermann.

Source/WebCore:

<svg> elements in shadow dom subtree are still not supported.
This fixes only crashes.

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules):

  • page/EventHandler.cpp:

(WebCore::instanceAssociatedWithShadowTreeElement):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching.html:
5:06 AM Changeset in webkit [117956] by kling@webkit.org
  • 3 edits
    2 adds in trunk

DOM Attr objects pointing to "style" attribute should force reification when read.
<http://webkit.org/b/87076>

Reviewed by Antti Koivisto.

Source/WebCore:

Make sure that the "style" attribute is reserialized as needed when it gets retrieved
through an Attr object. This fixes a bug where updating an element's inline style
through the CSSOM API, and then retrieving the style attribute through an Attr node
that was previously created by element.getAttributeNode() would return the old style
attribute value.

Test: fast/dom/attr-style-too-lazy.html

  • dom/Attr.cpp:

(WebCore::Attr::value):

LayoutTests:

  • fast/dom/attr-style-too-lazy-expected.txt: Added.
  • fast/dom/attr-style-too-lazy.html: Added.
4:59 AM Changeset in webkit [117955] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Structure test_expectations.txt into meaningful sections
https://bugs.webkit.org/show_bug.cgi?id=86628

Unreviewed, EFL gardening.

Organizing test_expectations.txt into categories.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-22

  • platform/efl/test_expectations.txt:
4:57 AM Changeset in webkit [117954] by kling@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for attribute selector invalidation triggering recursive style recalc.
<http://webkit.org/b/21346>

Reviewed by Antti Koivisto.

Bug 21346 was already fixed somewhere in the semirecent past, so here's the provided
test case as form of a layout test to make sure we don't regress this again.

  • fast/css/attribute-selector-recursive-update-on-setAttribute-expected.txt: Added.
  • fast/css/attribute-selector-recursive-update-on-setAttribute.html: Added.
4:54 AM Changeset in webkit [117953] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: HeapProfiler: upstream retainedSize calculation.
https://bugs.webkit.org/show_bug.cgi?id=87107

This patch upstreams V8::HeapSnapshotGenerator::CalculateRetainedSizes function to front-end.
After that we will be able to drop retainedSize field from the snapshot serialized data.
See meta-bug https://bugs.webkit.org/show_bug.cgi?id=87089

Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot.html: add counter for the _calculateRetainedSize method.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get retainedSize):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

LayoutTests:

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot.html:
4:54 AM Changeset in webkit [117952] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Mini clean ups in the interaction engine
https://bugs.webkit.org/show_bug.cgi?id=87013

Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

Assert that we are suspended.

(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

Never zoom to any area if suspended which indicates other
animation or user interaction.

(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

If immediate is set, ignore suspension.

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

Improve the comment.

4:44 AM Changeset in webkit [117951] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap-to-zoom overshoot animation
https://bugs.webkit.org/show_bug.cgi?id=87108

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-22
Reviewed by Kenneth Rohde Christiansen.

Defines a simple animation curve that combines a large
ease-out (overshoot) with a small ease-in (correction).
Uses that curve for zooming animation.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::physicalOvershoot):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

4:43 AM Changeset in webkit [117950] by kkristof@inf.u-szeged.hu
  • 4 edits
    1 delete in trunk/LayoutTests

NRWT results.html page should show a count of the number of tests in each category
https://bugs.webkit.org/show_bug.cgi?id=64215

Reviewed by Ojan Vafai.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
  • platform/chromium-win/fast/harness/results-expected.txt: Removed.
4:39 AM Changeset in webkit [117949] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remaining duplicated test in Skipped and test_expectations.txt after r117932
https://bugs.webkit.org/show_bug.cgi?id=87103

Unreviewed EFL gardening. Remove from Skipped file a test that is
already in test_expectations.txt to make the style script happy.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-22

  • platform/efl/Skipped:
4:24 AM Changeset in webkit [117948] by commit-queue@webkit.org
  • 2 edits
    19 adds in trunk/LayoutTests

[EFL] Add missing test baselines
https://bugs.webkit.org/show_bug.cgi?id=87110

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-22

  • platform/efl/css1/font_properties/font-expected.txt: Added.
  • platform/efl/css1/text_properties/line_height-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt: Added.
  • platform/efl/http/tests/misc/acid2-expected.png:
  • platform/efl/http/tests/misc/acid2-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
4:21 AM Changeset in webkit [117947] by zandobersek@gmail.com
  • 7 edits in trunk

[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=86284

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add an additional method to the ChromeClient through which it is
possible to bypass the painting timer and force an immediate repaint of
the current dirty regions.

Add a new method to DumpRenderTreeSupportGtk class that calls that
method, making it possible to force an instant paint from
DumpRenderTree.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::paint): Only delay the painting if the paint is
not forced.
(WebKit::ChromeClient::forcePaint):
(WebKit):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getFrameChildren): Refactor getFrameChildren
to use the kit() function on the core child frames rather than using
the FrameLoaderClient of that frame, which is what the kit() function does in the first
place. This makes it possible to remove the inclusion of the FrameLoaderClientGtk.h
header which causes symbol name conflicts when included along with ChromeClientGtk.h
that originate in the Xlib headers included through the former header.
(DumpRenderTreeSupportGtk::forceWebViewPaint):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Paint the current dirty regions of the web view once more before
dumping pixel results.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dump):

4:16 AM Changeset in webkit [117946] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

Change RenderBlock to user RenderBox/RenderInline writing mode logic
https://bugs.webkit.org/show_bug.cgi?id=87040

Reviewed by Eric Seidel.

Remove unnecessary writing mode logic in RenderBlock and use the
implementation in RenderBox and RenderInline instead.

No new tests, no change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::marginStart):
(WebCore::RenderInline::marginEnd):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

  • rendering/RenderInline.h:

(RenderInline):

4:00 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
3:56 AM Changeset in webkit [117945] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Add a failing test expectation for a CSS test modified in r117815
(subpixel layout changes) and a GTK-specific baseline for a test
introduced in r117803.

  • platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
3:52 AM Changeset in webkit [117944] by commit-queue@webkit.org
  • 6 edits in trunk

[WebSocket] WebSocket object should fire a simple event named error when it is required to fail the websocket connection.
https://bugs.webkit.org/show_bug.cgi?id=86958

Source/WebCore:

Patch by Li Yin <li.yin@intel.com> on 2012-05-22
Reviewed by Kent Tamura.

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
If the user agent was required to fail the websocket connection or the
WebSocket connection is closed with prejudice, fire a simple event
named error at the WebSocket object.

Tests: http/tests/websocket/tests/hybi/close.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessageError):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):

LayoutTests:

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
If the user agent was required to fail the websocket connection or the
WebSocket connection is closed with prejudice, fire a simple event
named error at the WebSocket object.

Patch by Li Yin <li.yin@intel.com> on 2012-05-22
Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/close-expected.txt:
  • http/tests/websocket/tests/hybi/close.html:
3:49 AM Changeset in webkit [117943] by kenneth@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt] Make the resizing code more straight forward
https://bugs.webkit.org/show_bug.cgi?id=87015

Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewFlickablePrivate):

3:45 AM Changeset in webkit [117942] by kenneth@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit2

[Qt] Add UI tests for fit-to-view
https://bugs.webkit.org/show_bug.cgi?id=86857

Reviewed by Simon Hausmann.

Make sure to always emit contentsScaleCommitted when the
contents size changes, so that it can be used for testing.

Also add a method to do single taps.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qwebkittest.cpp:

(touchPoint):
(QWebKitTest::touchTap):
(QWebKitTest::touchDoubleTap):

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Added.
3:15 AM Changeset in webkit [117941] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove an entry for css3/filters/custom/filter-repaint-custom-rotated.html
https://bugs.webkit.org/show_bug.cgi?id=85868

The failure was fixed by ENABLE_SUBPIXEL_LAYOUT.

  • platform/chromium/test_expectations.txt:
2:53 AM Changeset in webkit [117940] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: allow showing selected object in another heap profiler view
https://bugs.webkit.org/show_bug.cgi?id=87098

Reviewed by Vsevolod Vlasov.

Added 2 context menu actions: 1) to jump from a node in the heap snapshot summary
view to the same node in the dominators view; 2) to jump from a node in the dominators
view to the same node in the summary view.

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid): "sorting complete" event is only dispatched on
when the data grid is populated. If we switch to already populated data grid the event is not
dispatched. However when switching between different views of a heap snapshot we want to track
the moment when the data grid is shown and populated. I added
WebInspector.HeapSnapshotSortableDataGrid.Events.ContentShown for such cases. The event will always
be dispatched after the data grid is shown and its content is populated.
(WebInspector.HeapSnapshotSortableDataGrid.prototype.wasShown):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._sortingComplete):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.populateContextMenu):
(WebInspector.HeapSnapshotView.prototype.changeView.dataGridContentShown):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._onSelectedViewChanged):
(WebInspector.HeapSnapshotView.prototype._changeView):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):

2:24 AM Changeset in webkit [117939] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unskipped a test and updated its expectation.
https://bugs.webkit.org/show_bug.cgi?id=87099

Reviewed by Csaba Osztrogonác.

  • css1/units/rounding-expected.txt:
  • platform/qt/Skipped:
2:22 AM Changeset in webkit [117938] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: show more button node should have height multiple of row height
https://bugs.webkit.org/show_bug.cgi?id=87104

Reviewed by Vsevolod Vlasov.

Made "show more" button height multiple of the data grid row height.

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):

  • inspector/front-end/dataGrid.css:

(.data-grid button):

2:04 AM Changeset in webkit [117937] by eae@chromium.org
  • 1 edit
    5 adds
    3 deletes in trunk/LayoutTests

Unreviewed chromium windows rebaselines.

  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/20110323: Added.
  • platform/chromium-win-xp/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug131020-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug43854-2-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug59354-expected.png: Removed.
1:52 AM Changeset in webkit [117936] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening. Skip failing tests after r117815.
https://bugs.webkit.org/show_bug.cgi?id=87099

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-05-22
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
1:48 AM Changeset in webkit [117935] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] dumpAsText() output of Qt-DRT differs from other DRTs
https://bugs.webkit.org/show_bug.cgi?id=69718

Gardening, add Qt specific expected file for svg/custom/bug86119.html
introduced in r117792, because it lacks a trailing whitespace on Qt platform.

Patch by János Badics <János Badics> on 2012-05-22
Reviewed by Csaba Osztrogonác.

  • platform/qt/svg/custom/bug86119-expected.txt: Added.
1:46 AM Changeset in webkit [117934] by Simon Hausmann
  • 5 edits in trunk

GCC 4.7 and C++11 support.
https://bugs.webkit.org/show_bug.cgi?id=86465

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-22
Reviewed by Darin Adler.

Source/WTF:

Detect C++11 mode in GCC 4.7 and set appropiate compiler feature flags.
Turn C++11 override control into a compiler feature flag.
Fix non-clang support of compiler feature CXX_DELETED_FUNCTIONS.

  • wtf/Compiler.h:
  • wtf/Noncopyable.h:

Tools:

Update detection of C++11 mode in GCC.

  • qmake/mkspecs/features/unix/default_post.prf:
1:38 AM Changeset in webkit [117933] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Add an optional 'isolate' argument to throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=87070

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch adds an optional 'isolate' argument to throwTypeError(),
and passes Isolate to throwTypeError()s. In a following patch,
I'll pass Isolate to all throwTypeError("message")s.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::throwTypeError):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorSetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

1:36 AM Changeset in webkit [117932] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=87093

Unreviewed EFL gardening. Remove from Skipped file tests that are
already in test_expectations.txt to make the style script happy.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-22

  • platform/efl/Skipped:
1:17 AM Changeset in webkit [117931] by fpizlo@apple.com
  • 11 edits in branches/dfgopt/Source/JavaScriptCore

DFG CFA should record if a node can OSR exit
https://bugs.webkit.org/show_bug.cgi?id=86905

Reviewed by Oliver Hunt.

Adds a NodeFlag that denotes nodes that are known to not have OSR exits.
This ought to aid any backwards analyses that need to know when a
backward flow merge might happen due to a side exit.

Also added assertions into speculationCheck() that ensure that we did not
mark a node as non-exiting and then promptly compile in an exit. This
helped catch some minor bugs where we were doing unnecessary speculation
checks.

This is a perf-neutral change. The speculation checks that this removes
were not on hot paths of major benchmarks.

  • bytecode/PredictedType.h:

(JSC):
(JSC::isAnyPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::speculateInt32Unary):
(AbstractState):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):

  • dfg/DFGNode.h:

(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(Node):
(JSC::DFG::Node::setCanExit):
(JSC::DFG::Node::canExit):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

1:01 AM Changeset in webkit [117930] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Mark two tests as skipped while we figure out why they are failing.

  • platform/chromium/test_expectations.txt:
12:53 AM Changeset in webkit [117929] by yosin@chromium.org
  • 10 edits in trunk/Source/WebCore

[Forms][Meter][Progress] Change function signature of parseToDoubleForNumberType
https://bugs.webkit.org/show_bug.cgi?id=87077

Reviewed by Hajime Morita.

This patch changes function signature of parseToDoubleForNumberType and
parseToDoubleForNumberTypeWithDecimalPlaces to return double value instead
of bool for reducing code in call sites for ease of maintenance. This patch
also allows to use functional style of using these functions.

No new tests. This patch doesn't change behavior.

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min): Changed for using double return value.
(WebCore::HTMLMeterElement::max): Changed for using double return value.
(WebCore::HTMLMeterElement::value): Changed for using double return value.
(WebCore::HTMLMeterElement::low): Changed for using double return value.
(WebCore::HTMLMeterElement::high): Changed for using double return value.
(WebCore::HTMLMeterElement::optimum): Changed for using double return value.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value): Changed for using double return value.
(WebCore::HTMLProgressElement::max): Changed for using double return value.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::typeMismatchFor): Changed for using double return value.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed for using double return value.
(WebCore::NumberInputType::parseToDouble): Changed for using double return value.
(WebCore::NumberInputType::parseToDoubleWithDecimalPlaces): Changed for using double return value.
(WebCore::NumberInputType::visibleValue): Changed for using double return value.
(WebCore::NumberInputType::sanitizeValue): Changed for using double return value.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::parseToDouble): Changed for using double return value.

  • html/StepRange.cpp:

(WebCore::StepRange::parseStep): Changed for using double return value.

  • html/StepRange.h:

(WebCore::StepRange::defaultValue): Added "const" attribute
(WebCore::StepRange::proportionFromValue): Added "const" attribute
(WebCore::StepRange::valueFromProportion): Added "const" attribute

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType): Changed for using double return value. Added one parameter function.
(WebCore::parseToDoubleForNumberTypeWithDecimalPlaces): Changed for using double return value. Added function for providing default fallback value.

  • html/parser/HTMLParserIdioms.h: Changed function prototype and added one parameter prototypes.
  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition): Changed for using double return value.

12:50 AM Changeset in webkit [117928] by haraken@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION r110315: Event handler throws TypeError for an input element with name="arguments"
https://bugs.webkit.org/show_bug.cgi?id=86991

Reviewed by Ojan Vafai.

Source/WebCore:

Original Chromium bug: http://code.google.com/p/chromium/issues/detail?id=128723

Consider the following html:

<html><body><form>
<input type="hidden" name="arguments"></input>
<div onclick="onclicked()" id="divInsideForm">Click here</div>
</form></body>
<script>
function onclicked() {

alert("onclicked");

}
</script>
</html>

If we click "Click here", JavaScript throws "Uncaught TypeError: undefined has no properties".

This is a regression caused by r110315. V8LazyEventListener should not use
'arguments' to retrieve the execution contexts, since 'arguments' can be
shadowed by JavaScript.

This patch changes V8LazyEventListener so that it retrieves contexts
by this[2], this[1] and this[0].

Test: fast/forms/form-input-named-arguments.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

The added test checks whether an event handler is successfully invoked
for an input element with name="arguments".

  • fast/forms/form-input-named-arguments-expected.txt: Added.
  • fast/forms/form-input-named-arguments.html: Added.
12:47 AM Changeset in webkit [117927] by eae@chromium.org
  • 67 edits
    25 adds
    35 deletes in trunk/LayoutTests

Chromium linux and mac rebaselines.

  • css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/chromium-linux-x86/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-linux-x86/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-004-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-linux/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.png: Added.
  • platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-mac-leopard/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug215629-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug106816-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug139524-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug159108-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug215629-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-win-vista/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-32-expected.txt: Added.
  • platform/chromium-win-vista/editing/inserting: Added.
  • platform/chromium-win-vista/editing/inserting/4959067-expected.txt: Added.
  • platform/chromium-win-vista/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-win-vista/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
  • platform/chromium-win-xp/editing/inserting: Added.
  • platform/chromium-win-xp/editing/inserting/4959067-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom: Added.
  • platform/chromium-win-xp/svg/zoom/page: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug59354-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/chromium-win/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-32-expected.txt:
  • platform/chromium-win/editing/inserting/4959067-expected.txt:
  • platform/chromium-win/fast/dom/Document: Removed.
  • platform/chromium-win/fast/repaint/reflection-repaint-test-expected.png:
  • platform/chromium-win/fast/repaint/transform-layout-repaint-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug106816-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug139524-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug159108-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug215629-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug83786-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_center-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-win/transforms/2d/zoom-menulist-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.png:
  • platform/chromium/fast/dom/Document: Added.
  • platform/chromium/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt: Removed.
  • platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug215629-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
  • platform/efl/transforms/svg-vs-css-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug215629-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
  • platform/gtk/transforms/svg-vs-css-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • tables/mozilla/bugs/bug215629-expected.txt: Added.
  • tables/mozilla/bugs/bug43854-2-expected.txt: Added.
  • tables/mozilla/bugs/bug83786-expected.txt: Added.
  • tables/mozilla/marvin/x_table_align_center-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
  • transforms/svg-vs-css-expected.txt: Added.
12:42 AM Changeset in webkit [117926] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] setDOMException() should return v8::Handle<v8::Value>()
https://bugs.webkit.org/show_bug.cgi?id=87083

Reviewed by Adam Barth.

The following patterns are used here and there in V8 bindings:

setDOMException();
return v8::Handle<v8::Value>();

and

setDOMException();
return v8::Undefined();

By returning v8::Handle<v8::Value>() from setDOMException(), we can simplify the above patterns into this:

return setDOMException();

This patch just replaces the code in CodeGeneratorV8.pm. I'll replace
all other custom bindings in a follow-up patch.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSetDOMException):
(GenerateFunctionCallback):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

12:40 AM Changeset in webkit [117925] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

Unreviewed expectations update against r117989.

  • bindings/scripts/test/V8/V8Float64Array.cpp:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp:
  • bindings/scripts/test/V8/V8TestException.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
  • bindings/scripts/test/V8/V8TestNode.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
12:30 AM Changeset in webkit [117924] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: migrate dominatorIndex code to the front-end calculated dominatorsTree.
https://bugs.webkit.org/show_bug.cgi?id=87024

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
(WebInspector.HeapSnapshot.prototype._init):

12:25 AM Changeset in webkit [117923] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Replace 'throwError(); return Undefined();' with 'return throwError()'
https://bugs.webkit.org/show_bug.cgi?id=87079

Reviewed by Adam Barth.

This patch replaces

throwError();
return v8::Undefined();

with

return throwError();

No tests. No change in behavior.

  • bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::OnSleepDetected):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

12:18 AM Changeset in webkit [117922] by eae@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline of fast/loader/recursive-before-unload-crash.html

  • platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt: Added.
12:15 AM Changeset in webkit [117921] by eae@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Even more unreviewed chromium test expectation updates.

  • platform/chromium-linux-x86/platform/chromium/compositing/filters: Removed.
  • platform/chromium-linux-x86/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/filters: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
12:13 AM Changeset in webkit [117920] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] WebViewHost should use ENABLE guards for some features.
https://bugs.webkit.org/show_bug.cgi?id=87087

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-22
Reviewed by Kent Tamura.

These features are disabled on OS(ANDROID) and so shouldn't be
compiled when the feature is off.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:10 AM Changeset in webkit [117919] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

REGRESSION(r117861): It made almost all tests crash on Qt
https://bugs.webkit.org/show_bug.cgi?id=87082

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-05-22
Reviewed by Csaba Osztrogonác.

Using OwnArrayPtr is a bad idea if you allocate array with fastCalloc.

  • wtf/FastBitVector.h:

(WTF::FastBitVector::FastBitVector):
(WTF::FastBitVector::~FastBitVector):
(FastBitVector):
(WTF::FastBitVector::operator=):
(WTF::FastBitVector::resize):
(WTF::FastBitVector::setAll):
(WTF::FastBitVector::clearAll):
(WTF::FastBitVector::set):

May 21, 2012:

11:58 PM Changeset in webkit [117918] by kbr@google.com
  • 8 edits
    7 copies
    16 adds in trunk

Must set/reset pixel unpack alignment to 1 during texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=86877

Reviewed by James Robinson.

Source/WebCore:

Set pixel unpack alignment to 1 during upload, resetting afterward.

Tests: fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html

fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):

Set pixel unpack alignment to 1 during upload; reset afterward.

LayoutTests:

Incorporated several tests from WebGL conformance suite at Khronos
as layout tests, verifying upload to all packed pixel formats.

There were difficulties incorporating the video-related variants
of these tests; Bug 87042 has been filed to track their addition.

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-canvas.js: Added.

(generateTest.init):
(generateTest.runOneIteration):
(generateTest.runTest):
(generateTest):

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-image-data.js: Added.

(generateTest.init):
(generateTest.runOneIteration):
(generateTest.runTest):
(generateTest):

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-image.js: Added.

(generateTest.init):
(generateTest.runOneIteration):
(generateTest.runTestOnImage):
(generateTest.runTest.newImage.onload):
(generateTest.runTest):
(generateTest.runTest2.newImage.onload):
(generateTest.runTest2):
(generateTest.runTest3):
(generateTest):

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
11:52 PM Changeset in webkit [117917] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: "Deactivate All Breakpoints" should visually get reflected in Breakpoints pane.
https://bugs.webkit.org/show_bug.cgi?id=86844

Patch by Sam D <dsam2912@gmail.com> on 2012-05-21
Reviewed by Pavel Feldman.

Added an option for activate/deactivate breakpoints into Breakpoints
pane section. Style properties has been attached with
breakpoint list to reflect active state of breakpoints.

No new tests. UI Change.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):

  • inspector/front-end/inspector.css:

(.breakpoints-list-deactivated):

11:51 PM Changeset in webkit [117916] by eae@chromium.org
  • 14 edits
    2 adds in trunk/LayoutTests

Unreviewed table rebaselines for chromium.

  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33137-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug33137-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
11:44 PM Changeset in webkit [117915] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Simplify RTL root layer adjustment
https://bugs.webkit.org/show_bug.cgi?id=85672

Patch by Alexandre Elias <aelias@google.com> on 2012-05-21
Reviewed by Adrienne Walker.

The compositor needs a translation to compensate for a nonzero
scrollOrigin to avoid painting at negative coordinates on RTL pages.
Previously, we were recomputing it from first principles; this change
directly reads it off the actual scrollOrigin.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

(WebViewImpl):

11:43 PM Changeset in webkit [117914] by eae@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed chromium test expectation updates.

  • platform/chromium-linux-x86/fast/html: Added.
  • platform/chromium-linux-x86/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-win-xp/fast/html: Added.
  • platform/chromium-win-xp/fast/html/details-writing-mode-expected.png: Added.
11:40 PM Changeset in webkit [117913] by leviw@chromium.org
  • 2 edits
    1 add
    5 deletes in trunk/LayoutTests

Unreviewed. Even more test expectations being updated post-r117815.

  • platform/chromium-win-vista/svg/custom/svg-fonts-with-no-element-reference-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/svg-fonts-with-no-element-reference-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
11:28 PM Changeset in webkit [117912] by caio.oliveira@openbossa.org
  • 42 edits in trunk/LayoutTests

Avoid using window.internals when internals is enough after r117771
https://bugs.webkit.org/show_bug.cgi?id=87059

Reviewed by Darin Adler.

Revision r117771 introduced a style change in the layout tests that was not
intended. This patch amends this by using "window.internals" only when checking
for the internals object. Once we know internals is there, we use directly.

This conforms to the style used for layoutTestController in the affected tests.

  • editing/deleting/delete-ligature-003.html:
  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/whitespace-pre-1.html:
  • editing/execCommand/script-tests/query-command-state.js:

(runTests):

  • editing/execCommand/script-tests/query-text-alignment.js:

(runRangeTests):

  • editing/execCommand/script-tests/toggle-compound-styles.js:
  • editing/selection/5195166-1.html:
  • editing/selection/5354455-1.html:
  • editing/selection/caret-mode-paragraph-keys-navigation.html:
  • editing/selection/collapse-selection-in-bidi.html:
  • editing/selection/context-menu-text-selection.html:
  • editing/selection/directionality-after-undo-replace.html:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/extend-selection-after-double-click.html:
  • editing/selection/move-by-word-visually-crash-test-1.html:
  • editing/selection/move-by-word-visually-crash-test-2.html:
  • editing/selection/move-by-word-visually-crash-test-3.html:
  • editing/selection/move-by-word-visually-crash-test-4.html:
  • editing/selection/move-by-word-visually-crash-test-5.html:
  • editing/selection/move-by-word-visually-crash-test-css-generated-content.html:
  • editing/selection/move-by-word-visually-crash-test-textarea.html:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html:
  • editing/selection/move-by-word-visually-mac.html:
  • editing/selection/move-by-word-visually-multi-line.html:
  • editing/selection/move-by-word-visually-multi-space.html:
  • editing/selection/move-by-word-visually-null-box.html:
  • editing/selection/move-by-word-visually-single-space-inline-element.html:
  • editing/selection/move-by-word-visually-single-space-one-element.html:
  • editing/selection/move-by-word-visually-textarea.html:
  • editing/selection/move-by-word-visually-wrong-left-right.html:
  • editing/selection/programmatic-selection-on-mac-is-directionless.html:
  • editing/selection/rtl-move-selection-right-left.html:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js:
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
  • editing/selection/script-tests/shift-click.js:

(runShiftClickTest):

  • editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
  • editing/style/iframe-onload-crash-mac.html:
  • editing/style/iframe-onload-crash-unix.html:
  • editing/style/iframe-onload-crash-win.html:
  • fast/events/backspace-navigates-back.html:
  • fast/forms/selection-direction.html:
11:25 PM Changeset in webkit [117911] by leviw@chromium.org
  • 3 edits
    12 adds
    6 deletes in trunk/LayoutTests

Unreviewed gardening. Updating more tests post r117815.

  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.txt: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/chromium-linux/fast/borders/bidi-009a-expected.txt: Added.
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-linux/fast/forms/007-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win-xp/css1: Added.
  • platform/chromium-win-xp/css1/formatting_model: Added.
  • platform/chromium-win-xp/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
11:11 PM Changeset in webkit [117910] by leviw@chromium.org
  • 3 edits
    12 adds
    3 deletes in trunk/LayoutTests

Unreviewed Gardening. More updates after r117815.

  • platform/chromium-linux-x86/svg/zoom/page: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core: Removed.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/standards1-expected.png: Removed.
  • platform/chromium/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Added.
  • platform/chromium/svg/custom/viewBox-hit-expected.txt: Added.
11:05 PM Changeset in webkit [117909] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove some dead code in CSSStyleModel.js.
https://bugs.webkit.org/show_bug.cgi?id=87048

Reviewed by Pavel Feldman.

Remove dead and unused code in CSSStyleModel.js.

No new tests : the code is supposedly dead so we should not have
any regressions.

  • inspector/front-end/CSSStyleModel.js:
10:58 PM Changeset in webkit [117908] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Marking svg/animations/animate-path-animation-qQ-tT-inverse.html and
svg/animations/svgnumberoptionalnumber-animation-4.html as timing out.

  • platform/chromium/test_expectations.txt:
10:46 PM Changeset in webkit [117907] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

!HAVE(ACCESSIBILITY) should be able to build without linking in any code from WebCore/accessibility
https://bugs.webkit.org/show_bug.cgi?id=87035

Reviewed by Chris Fleizach.

The OS(ANDROID) already builds with !HAVE(ACCESSIBILITY), but because
there are a few straggling references to objects in the
WebCore/accessibility directory, we end up pulling in a bunch of code
into the binary that we don't need.

This patch stubs out a few more functions for !HAVE(ACCESSIBILITY) so
we can link without any objects from WebCore/accessibility. This patch
also locks in that property by actually excluding the
WebCore/accessibility directory from the build on OS(ANDROID).

  • WebCore.gyp/WebCore.gyp:
  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::rootObjectForFrame):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::contentChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AccessibilityObject.h:

(WebCore):
(WebCore::AccessibilityObject::updateBackingStore):
(WebCore::AccessibilityObject::lineForPosition):
(WebCore::AccessibilityObject::children):

10:46 PM Changeset in webkit [117906] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed cleanup of chromium test_expectations file.

  • platform/chromium/test_expectations.txt:
10:39 PM Changeset in webkit [117905] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

DFG should be able to compute dominators
https://bugs.webkit.org/show_bug.cgi?id=85269

Unreviewed trivial 32 bit buildfix after r117861.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

10:32 PM Changeset in webkit [117904] by leviw@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

Unreviewed gardening. Yet more rebaselining from r117815.

  • platform/chromium-mac-leopard/platform/chromium/media/video-scales-in-media-document-expected.txt: Removed.
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
10:17 PM Changeset in webkit [117903] by leviw@chromium.org
  • 698 edits
    103 adds
    110 deletes in trunk/LayoutTests

Unreviewed gardening. Even more rebaselining from r117815.

  • css1/formatting_model/inline_elements-expected.txt: Added.
  • css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
  • css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Added.
  • css2.1/t1508-c527-font-09-b-expected.txt: Added.
  • fast/backgrounds/background-position-parsing-expected.txt: Added.
  • fast/block/positioning/047-expected.txt: Added.
  • fast/borders/bidi-009a-expected.png: Added.
  • fast/borders/bidi-009a-expected.txt: Added.
  • fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
  • fast/encoding/denormalised-voiced-japanese-chars-expected.txt: Added.
  • fast/flexbox/flex-hang-expected.txt: Replaced.
  • fast/forms/007-expected.txt: Added.
  • fast/forms/button-default-title-expected.txt: Added.
  • fast/html/details-marker-style-expected.txt: Added.
  • fast/html/details-writing-mode-expected.txt: Added.
  • fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Replaced.
  • fast/invalid/missing-end-tag-expected.txt: Added.
  • fast/line-grid/line-align-left-edges-expected.txt: Added.
  • fast/parser/style-script-head-test-expected.txt: Added.
  • fast/table/max-width-integer-overflow-expected.png: Added.
  • fast/table/max-width-integer-overflow-expected.txt: Added.
  • fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Replaced.
  • fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Replaced.
  • platform/chromium-linux-x86/fast/dom/Document: Added.
  • platform/chromium-linux-x86/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium-linux-x86/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium-linux-x86/fast/forms/basic-selects-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/html: Removed.
  • platform/chromium-linux-x86/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/inline: Removed.
  • platform/chromium-linux-x86/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/parser: Added.
  • platform/chromium-linux-x86/fast/parser/style-script-head-test-expected.png: Added.
  • platform/chromium-linux-x86/fast/table: Removed.
  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/dom/Document: Added.
  • platform/chromium-linux/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium-linux/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium-linux/fast/flexbox/flex-hang-expected.txt: Added.
  • platform/chromium-linux/fast/gradients/radial-centered-expected.txt: Removed.
  • platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.png: Added.
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Added.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/chromium-mac-leopard/css1/basic/inheritance-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/acid_test-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/width-expected.png:
  • platform/chromium-mac-leopard/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-mac-leopard/css1/font_properties/font_size-expected.png:
  • platform/chromium-mac-leopard/css1/font_properties/font_weight-expected.png:
  • platform/chromium-mac-leopard/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-mac-leopard/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-mac-leopard/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac-leopard/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-mac-leopard/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-mac-leopard/css1/text_properties/text_indent-expected.png:
  • platform/chromium-mac-leopard/css1/units/length_units-expected.png:
  • platform/chromium-mac-leopard/css1/units/percentage_units-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png:
  • platform/chromium-mac-leopard/css2.1/t040302-c61-phys-len-00-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/chromium-mac-leopard/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1205-c565-list-pos-00-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1506-c525-font-wt-00-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1508-c527-font-09-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-leopard/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-text-overflow-ellipsis-expected.png:
  • platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac-leopard/fast/block/basic/001-expected.png:
  • platform/chromium-mac-leopard/fast/block/basic/011-expected.png:
  • platform/chromium-mac-leopard/fast/block/basic/015-expected.png:
  • platform/chromium-mac-leopard/fast/block/basic/016-expected.png:
  • platform/chromium-mac-leopard/fast/block/basic/019-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/002-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/013-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/100-expected.png:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/block/positioning/047-expected.png:
  • platform/chromium-mac-leopard/fast/block/positioning/051-expected.png:
  • platform/chromium-mac-leopard/fast/borders/bidi-009a-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-mac-leopard/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-mac-leopard/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-mac-leopard/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/011-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/013-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/014-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/015-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac-leopard/fast/css/004-expected.png:
  • platform/chromium-mac-leopard/fast/css/005-expected.png:
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac-leopard/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-mac-leopard/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/chromium-mac-leopard/fast/css/empty-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/ex-after-font-variant-expected.png:
  • platform/chromium-mac-leopard/fast/css/fieldset-display-row-expected.png:
  • platform/chromium-mac-leopard/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/first-line-text-decoration-expected.png:
  • platform/chromium-mac-leopard/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
  • platform/chromium-mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-mac-leopard/fast/css/hsl-color-expected.png:
  • platform/chromium-mac-leopard/fast/css/inline-properties-important-expected.png:
  • platform/chromium-mac-leopard/fast/css/invalid-percentage-property-expected.png:
  • platform/chromium-mac-leopard/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-mac-leopard/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-align-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac-leopard/fast/css/transform-default-parameter-expected.png:
  • platform/chromium-mac-leopard/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac-leopard/fast/dom/Document: Added.
  • platform/chromium-mac-leopard/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium-mac-leopard/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-mac-leopard/fast/dynamic/012-expected.png:
  • platform/chromium-mac-leopard/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/chromium-mac-leopard/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/001-expected.png:
  • platform/chromium-mac-leopard/fast/forms/006-expected.png:
  • platform/chromium-mac-leopard/fast/forms/007-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-leopard/fast/forms/button-default-title-expected.png:
  • platform/chromium-mac-leopard/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-with-float-expected.png:
  • platform/chromium-mac-leopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-leopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-leopard/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-mac-leopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-leopard/fast/forms/formmove-expected.png:
  • platform/chromium-mac-leopard/fast/forms/formmove2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/indeterminate-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-leopard/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-mac-leopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac-leopard/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-marker-style-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open6-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-leopard/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-leopard/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-mac-leopard/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-mac-leopard/fast/invalid/010-expected.png:
  • platform/chromium-mac-leopard/fast/invalid/014-expected.png:
  • platform/chromium-mac-leopard/fast/invalid/junk-data-expected.png:
  • platform/chromium-mac-leopard/fast/invalid/missing-end-tag-expected.png:
  • platform/chromium-mac-leopard/fast/invalid/missing-end-tag-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/invalid/nestedh3s-expected.png:
  • platform/chromium-mac-leopard/fast/invalid/residual-style-expected.png:
  • platform/chromium-mac-leopard/fast/parser/style-script-head-test-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/Document: Added.
  • platform/chromium-mac-snowleopard/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium-mac-snowleopard/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/gradients/radial-centered-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/css1/box_properties/acid_test-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/box_properties/width-expected.png:
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-mac/css1/font_properties/font_size-expected.png:
  • platform/chromium-mac/css1/font_properties/font_weight-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png:
  • platform/chromium-mac/css1/units/length_units-expected.png:
  • platform/chromium-mac/css1/units/percentage_units-expected.png:
  • platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/chromium-mac/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-mac/css2.1/20110323/inline-block-replaced-height-008-expected.png:
  • platform/chromium-mac/css2.1/20110323/inline-replaced-height-008-expected.png:
  • platform/chromium-mac/css2.1/t040302-c61-phys-len-00-b-expected.png:
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-mac/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-mac/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t1205-c565-list-pos-00-b-expected.png:
  • platform/chromium-mac/css2.1/t1506-c525-font-wt-00-b-expected.png:
  • platform/chromium-mac/css2.1/t1508-c527-font-09-b-expected.png:
  • platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • platform/chromium-mac/editing/selection/drag-start-event-client-x-y-expected.txt: Added.
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac/fast/block/basic/001-expected.png:
  • platform/chromium-mac/fast/block/basic/011-expected.png:
  • platform/chromium-mac/fast/block/basic/015-expected.png:
  • platform/chromium-mac/fast/block/basic/016-expected.png:
  • platform/chromium-mac/fast/block/basic/019-expected.png:
  • platform/chromium-mac/fast/block/float/002-expected.png:
  • platform/chromium-mac/fast/block/float/013-expected.png:
  • platform/chromium-mac/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/chromium-mac/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/100-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/block/positioning/047-expected.png:
  • platform/chromium-mac/fast/block/positioning/051-expected.png:
  • platform/chromium-mac/fast/borders/bidi-009a-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-mac/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-mac/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-mac/fast/css-generated-content/011-expected.png:
  • platform/chromium-mac/fast/css-generated-content/013-expected.png:
  • platform/chromium-mac/fast/css-generated-content/014-expected.png:
  • platform/chromium-mac/fast/css-generated-content/015-expected.png:
  • platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac/fast/css/004-expected.png:
  • platform/chromium-mac/fast/css/005-expected.png:
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
  • platform/chromium-mac/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • platform/chromium-mac/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png:
  • platform/chromium-mac/fast/css/fieldset-display-row-expected.png:
  • platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/first-line-text-decoration-expected.png:
  • platform/chromium-mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
  • platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-mac/fast/css/hsl-color-expected.png:
  • platform/chromium-mac/fast/css/inline-properties-important-expected.png:
  • platform/chromium-mac/fast/css/invalid-percentage-property-expected.png:
  • platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-mac/fast/css/text-align-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/css/transform-default-parameter-expected.png:
  • platform/chromium-mac/fast/css/word-space-extra-expected.png:
  • platform/chromium-mac/fast/dom/Document: Added.
  • platform/chromium-mac/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium-mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/dynamic/012-expected.png:
  • platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/flexbox/flex-hang-expected.png:
  • platform/chromium-mac/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/006-expected.png:
  • platform/chromium-mac/fast/forms/007-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/button-default-title-expected.png:
  • platform/chromium-mac/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
  • platform/chromium-mac/fast/forms/fieldset-with-float-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/formmove-expected.png:
  • platform/chromium-mac/fast/forms/formmove2-expected.png:
  • platform/chromium-mac/fast/forms/indeterminate-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png:
  • platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-mac/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac/fast/gradients/radial-centered-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-open6-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-mac/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-mac/fast/invalid/010-expected.png:
  • platform/chromium-mac/fast/invalid/014-expected.png:
  • platform/chromium-mac/fast/invalid/junk-data-expected.png:
  • platform/chromium-mac/fast/invalid/missing-end-tag-expected.png:
  • platform/chromium-mac/fast/invalid/nestedh3s-expected.png:
  • platform/chromium-mac/fast/invalid/residual-style-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium-mac/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/chromium-mac/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
  • platform/chromium-win-vista/css1/formatting_model: Added.
  • platform/chromium-win-vista/css1/formatting_model/horizontal_formatting-expected.png: Added.
  • platform/chromium-win-vista/css1/units: Added.
  • platform/chromium-win-vista/css1/units/percentage_units-expected.png: Added.
  • platform/chromium-win-vista/fast/css-generated-content: Removed.
  • platform/chromium-win-vista/fast/dom/Document: Added.
  • platform/chromium-win-vista/fast/dom/Document/CaretRangeFromPoint: Added.
  • platform/chromium-win-vista/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/chromium-win-vista/fast/forms/basic-selects-expected.txt: Removed.
  • platform/chromium-win-vista/fast/html: Removed.
  • platform/chromium-win-vista/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-win-vista/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/chromium-win-vista/fast/parser: Added.
  • platform/chromium-win-vista/fast/parser/style-script-head-test-expected.png: Added.
  • platform/chromium-win-vista/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/chromium-win-xp/fast/css-generated-content: Removed.
  • platform/chromium-win-xp/fast/forms/basic-selects-expected.txt: Removed.
  • platform/chromium-win-xp/fast/gradients: Removed.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.txt: Removed.
  • platform/chromium-win-xp/fast/html: Removed.
  • platform/chromium-win-xp/fast/html/details-marker-style-expected.txt: Removed.
  • platform/chromium-win-xp/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/chromium-win-xp/fast/parser: Added.
  • platform/chromium-win-xp/fast/parser/style-script-head-test-expected.png: Added.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/chromium-win/css1/basic/inheritance-expected.png:
  • platform/chromium-win/css1/box_properties/acid_test-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/css1/box_properties/width-expected.png:
  • platform/chromium-win/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-win/css1/font_properties/font_size-expected.png:
  • platform/chromium-win/css1/font_properties/font_weight-expected.png:
  • platform/chromium-win/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-win/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/inline_elements-expected.txt:
  • platform/chromium-win/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-win/css1/text_properties/text_indent-expected.png:
  • platform/chromium-win/css1/units/percentage_units-expected.png:
  • platform/chromium-win/css1/units/rounding-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-008-expected.png:
  • platform/chromium-win/css2.1/t040302-c61-phys-len-00-b-expected.png:
  • platform/chromium-win/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/chromium-win/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-win/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-win/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/chromium-win/css2.1/t1205-c565-list-pos-00-b-expected.png:
  • platform/chromium-win/css2.1/t1506-c525-font-wt-00-b-expected.png:
  • platform/chromium-win/css2.1/t1508-c527-font-09-b-expected.png:
  • platform/chromium-win/css2.1/t1508-c527-font-09-b-expected.txt:
  • platform/chromium-win/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/select-text-overflow-ellipsis-expected.png:
  • platform/chromium-win/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/chromium-win/fast/block/basic/001-expected.png:
  • platform/chromium-win/fast/block/basic/011-expected.png:
  • platform/chromium-win/fast/block/basic/015-expected.png:
  • platform/chromium-win/fast/block/basic/016-expected.png:
  • platform/chromium-win/fast/block/basic/019-expected.png:
  • platform/chromium-win/fast/block/float/002-expected.png:
  • platform/chromium-win/fast/block/float/013-expected.png:
  • platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/chromium-win/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/100-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-win/fast/block/positioning/047-expected.png:
  • platform/chromium-win/fast/block/positioning/047-expected.txt:
  • platform/chromium-win/fast/block/positioning/051-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/chromium-win/fast/borders/bidi-009a-expected.txt:
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-win/fast/css-generated-content/011-expected.png:
  • platform/chromium-win/fast/css-generated-content/013-expected.png:
  • platform/chromium-win/fast/css-generated-content/014-expected.png:
  • platform/chromium-win/fast/css-generated-content/015-expected.png:
  • platform/chromium-win/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-win/fast/css/004-expected.png:
  • platform/chromium-win/fast/css/005-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
  • platform/chromium-win/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
  • platform/chromium-win/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
  • platform/chromium-win/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.
  • platform/chromium-win/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/chromium-win/fast/css/empty-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/fieldset-display-row-expected.png:
  • platform/chromium-win/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/first-line-text-decoration-expected.png:
  • platform/chromium-win/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
  • platform/chromium-win/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-win/fast/css/hsl-color-expected.png:
  • platform/chromium-win/fast/css/inline-properties-important-expected.png:
  • platform/chromium-win/fast/css/invalid-percentage-property-expected.png:
  • platform/chromium-win/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/text-align-expected.png:
  • platform/chromium-win/fast/css/text-overflow-input-expected.png:
  • platform/chromium-win/fast/css/transform-default-parameter-expected.png:
  • platform/chromium-win/fast/css/word-space-extra-expected.png:
  • platform/chromium-win/fast/dom/Document/CaretRangeFromPoint: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-win/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Removed.
  • platform/chromium-win/fast/dynamic/012-expected.png:
  • platform/chromium-win/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/chromium-win/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/chromium-win/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/document-elementFromPoint-expected.txt: Removed.
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/flexbox/flex-hang-expected.png:
  • platform/chromium-win/fast/flexbox/flex-hang-expected.txt: Added.
  • platform/chromium-win/fast/forms/001-expected.txt:
  • platform/chromium-win/fast/forms/006-expected.png:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/basic-buttons-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-win/fast/forms/basic-selects-expected.png:
  • platform/chromium-win/fast/forms/basic-selects-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/button-default-title-expected.png:
  • platform/chromium-win/fast/forms/button-default-title-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.png:
  • platform/chromium-win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
  • platform/chromium-win/fast/forms/fieldset-with-float-expected.png:
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-win/fast/forms/listbox-bidi-align-expected.png:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
  • platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/chromium-win/fast/inline/continuation-outlines-expected.png:
  • platform/chromium-win/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-win/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/chromium-win/fast/invalid/010-expected.png:
  • platform/chromium-win/fast/invalid/014-expected.png:
  • platform/chromium-win/fast/invalid/014-expected.txt:
  • platform/chromium-win/fast/invalid/junk-data-expected.png:
  • platform/chromium-win/fast/invalid/missing-end-tag-expected.png:
  • platform/chromium-win/fast/invalid/nestedh3s-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-win/fast/parser/style-script-head-test-expected.png: Added.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Added.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium/css1: Added.
  • platform/chromium/css1/units: Added.
  • platform/chromium/css1/units/rounding-expected.txt: Added.
  • platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/chromium/fast/block: Added.
  • platform/chromium/fast/block/positioning: Added.
  • platform/chromium/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
  • platform/chromium/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
  • platform/chromium/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
  • platform/chromium/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
  • platform/chromium/fast/css/getComputedStyle: Added.
  • platform/chromium/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLProgressElement: Added.
  • platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
  • platform/chromium/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
  • platform/chromium/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
  • platform/chromium/fast/events/document-elementFromPoint-expected.txt: Added.
  • platform/chromium/fast/flexbox: Added.
  • platform/chromium/fast/flexbox/flex-hang-expected.txt: Added.
  • platform/chromium/fast/line-grid: Added.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium/fast/parser/style-script-head-test-expected.txt: Added.
  • platform/chromium/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium/fast/transforms: Added.
  • platform/chromium/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/chromium/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/css1/formatting_model/inline_elements-expected.txt: Removed.
  • platform/efl/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Removed.
  • platform/efl/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
  • platform/efl/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
  • platform/efl/fast/backgrounds/background-position-parsing-expected.txt: Removed.
  • platform/efl/fast/block/positioning/047-expected.txt: Removed.
  • platform/efl/fast/borders/bidi-009a-expected.png: Removed.
  • platform/efl/fast/borders/bidi-009a-expected.txt: Removed.
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.txt: Removed.
  • platform/efl/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/efl/fast/forms/007-expected.txt: Removed.
  • platform/efl/fast/forms/button-default-title-expected.txt: Removed.
  • platform/efl/fast/html/details-marker-style-expected.txt: Removed.
  • platform/efl/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/efl/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/efl/fast/invalid/missing-end-tag-expected.txt: Removed.
  • platform/efl/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/efl/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/efl/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/efl/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt: Removed.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Removed.
  • platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/background-position-parsing-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/047-expected.txt: Removed.
  • platform/gtk/fast/borders/bidi-009a-expected.png: Removed.
  • platform/gtk/fast/borders/bidi-009a-expected.txt: Removed.
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
  • platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt: Removed.
  • platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
  • platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.txt: Removed.
  • platform/gtk/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/gtk/fast/forms/007-expected.txt: Removed.
  • platform/gtk/fast/forms/button-default-title-expected.txt: Removed.
  • platform/gtk/fast/html/details-marker-style-expected.txt: Removed.
  • platform/gtk/fast/html/details-writing-mode-expected.txt: Removed.
  • platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/gtk/fast/invalid/missing-end-tag-expected.txt: Removed.
  • platform/gtk/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/gtk/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/gtk/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/gtk/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/basic-selects-expected.txt: Removed.
  • platform/mac/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/mac/fast/html/details-marker-style-expected.txt: Removed.
  • platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/mac/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/qt/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
  • platform/qt/fast/flexbox/flex-hang-expected.txt: Added.
  • platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/qt/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/qt/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
10:11 PM Changeset in webkit [117902] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Use stack-allocated BitArray in StylePropertySet serialization.
<http://webkit.org/b/87071>

Reviewed by Anders Carlsson.

Use BitArray instead of BitVector to track seen properties in StylePropertySet::asText().
This removes two heap allocations from this path.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):

10:08 PM Changeset in webkit [117901] by eae@chromium.org
  • 5 edits
    3 adds
    6 deletes in trunk/LayoutTests

Unreviewed chromium rebaseline for compositing, zoom and border changes.

  • platform/chromium-linux-x86/svg/zoom/page: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/filters: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
9:59 PM Changeset in webkit [117900] by eae@chromium.org
  • 16 edits
    35 adds
    87 deletes in trunk/LayoutTests

Rebaselined chromium mac 10.5 and 10.6 tests for subpixel change in r117815.
Non-chromium-mac changes are due to expectations optimization.

  • fast/borders/border-image-side-reduction-expected.txt: Added.
  • fast/multicol/column-count-with-rules-expected.txt: Added.
  • fast/multicol/column-rules-expected.txt: Added.
  • fast/multicol/column-rules-stacking-expected.txt: Added.
  • fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • fast/multicol/max-height-columns-block-expected.txt: Added.
  • fast/reflections/opacity-reflection-transform-expected.txt: Added.
  • fast/table/008-expected.txt: Added.
  • fast/text/international/bidi-listbox-expected.txt: Added.
  • fast/transforms/transformed-document-element-expected.txt: Added.
  • http/tests/misc/iframe404-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/vertical-lr/float-multicol-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
  • platform/chromium-mac-leopard/fast/regions/render-region-renderer-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/delete-into-nested-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/misc/iframe404-expected.txt: Removed.
  • platform/chromium-mac-leopard/platform/chromium/media/video-scales-in-media-document-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/unqualified-hover-strict-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Removed.
  • platform/chromium-mac/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug10633-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-win-vista/fast/multicol/vertical-rl: Removed.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
  • platform/chromium-win-vista/http/tests/misc/iframe404-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/borders/border-image-side-reduction-expected.txt: Removed.
  • platform/efl/fast/multicol/column-count-with-rules-expected.txt: Removed.
  • platform/efl/fast/multicol/column-rules-expected.txt: Removed.
  • platform/efl/fast/multicol/column-rules-stacking-expected.txt: Removed.
  • platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt: Removed.
  • platform/efl/fast/multicol/max-height-columns-block-expected.txt: Removed.
  • platform/efl/fast/reflections/opacity-reflection-transform-expected.txt: Removed.
  • platform/efl/fast/table/008-expected.txt: Removed.
  • platform/efl/fast/text/international/bidi-listbox-expected.txt: Removed.
  • platform/efl/fast/transforms/transformed-document-element-expected.txt: Removed.
  • platform/efl/http/tests/misc/iframe404-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug10633-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug113424-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug13118-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug26553-expected.png: Removed.
  • platform/efl/tables/mozilla/bugs/bug26553-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug42187-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug55527-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug69187-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug25707-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug72393-expected.txt: Removed.
  • platform/gtk/fast/borders/border-image-side-reduction-expected.txt: Removed.
  • platform/gtk/fast/multicol/column-count-with-rules-expected.txt: Removed.
  • platform/gtk/fast/multicol/column-rules-expected.txt: Removed.
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Removed.
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Removed.
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Removed.
  • platform/gtk/fast/reflections/opacity-reflection-transform-expected.txt: Removed.
  • platform/gtk/fast/table/008-expected.txt: Removed.
  • platform/gtk/fast/text/international/bidi-listbox-expected.txt: Removed.
  • platform/gtk/fast/transforms/transformed-document-element-expected.txt: Removed.
  • platform/gtk/http/tests/misc/iframe404-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug10633-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug113424-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug13118-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug26553-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug26553-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug42187-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug55527-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug67915-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug69187-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug25707-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug72393-expected.txt: Removed.
  • platform/mac/fast/table/008-expected.txt: Removed.
  • platform/qt/fast/table/008-expected.txt: Removed.
  • tables/mozilla/bugs/bug10633-expected.txt: Added.
  • tables/mozilla/bugs/bug113235-1-expected.txt: Added.
  • tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • tables/mozilla/bugs/bug113424-expected.txt: Added.
  • tables/mozilla/bugs/bug13118-expected.txt: Added.
  • tables/mozilla/bugs/bug26553-expected.png: Added.
  • tables/mozilla/bugs/bug26553-expected.txt: Added.
  • tables/mozilla/bugs/bug2886-2-expected.txt: Added.
  • tables/mozilla/bugs/bug42187-expected.txt: Added.
  • tables/mozilla/bugs/bug55527-expected.txt: Added.
  • tables/mozilla/bugs/bug67915-1-expected.txt: Added.
  • tables/mozilla/bugs/bug69187-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug25707-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug72393-expected.txt: Added.
9:48 PM Changeset in webkit [117899] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Qt build fix against r117898.

  • Target.pri:
9:18 PM Changeset in webkit [117898] by morrita@google.com
  • 21 edits
    2 copies in trunk/Source/WebCore

[V8] Shadow DOM should be per-window-configurable.
https://bugs.webkit.org/show_bug.cgi?id=86555

Reviewed by Kentaro Hara.

This change introduces an IDL attribute named "V8EnabledAtContext"
which allows DOMWindow properties to be turned on or off per
windows basis. RuntimeEnabledFeatures::xxxAllowed() method decides the availability.

  • CodeGeneratorV8.pm now accepts V8EnabledAtContext and allows such properties to be configured per-Object basis, instead of per-ObjectTemplate basis. The script generates V8Window::installPerContextProperties(), which injects such per-object-turnable properties to newly created DOMWindow wrapper.
  • Added RuntimeEnabledFeatures::shadowDOMAllowed(DOMWindow*) which is used to decide the shadow dom availability of Shadow DOM feature. It delegates the call to FrameLoaderClient::shadowDOMAllowed() to make the decision.
  • The new IDL attribute is applied to DOMWindow.WebKitShadowRoot.
  • Updated existing shadowDOMEnabled() call sites with shadowDOMAllowed().

No new tests except run-bindings-test. This isn't testable from
DRT and this change itself doesn't chagne the behaviour. It needs
a client implementation.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/ContextEnabledFeatures.cpp: Added.

(WebCore):
(WebCore::ContextEnabledFeatures::shadowDOMEnabled):

  • bindings/generic/ContextEnabledFeatures.h: Added.

(WebCore):
(ContextEnabledFeatures):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GetContextEnableFunction):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::enabledAtContextAttr1AttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enabledAtContextAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledAtContextAttr2AttrGetter):
(WebCore::TestObjV8Internal::enabledAtContextAttr2AttrSetter):
(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Adopted installPerContextProperties()

  • bindings/v8/V8Proxy.h:

(WebCore):
(WebCore::configureAttribute): Generalized to accept both ObjectTemplate and Object.

  • dom/Position.cpp: Adopted ContextEnabledFeatures

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/ShadowRoot.idl:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • html/shadow/HTMLContentElement.cpp: Adopted ContextEnabledFeatures

(WebCore::contentTagName):
(WebCore::HTMLContentElement::create):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::shadowDOMAllowed): Added with a default behavior.

  • page/DOMWindow.cpp:
  • page/DOMWindow.idl:
9:08 PM Changeset in webkit [117897] by tony@chromium.org
  • 7 edits
    2 adds in trunk

auto margins on flexbox should allocate space in the flex direction
https://bugs.webkit.org/show_bug.cgi?id=83086

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/flex-flow-auto-margins.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::autoMarginOffsetInMainAxis):
(WebCore):
(WebCore::RenderFlexibleBox::updateAutoMarginsInMainAxis):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Update the margins on the RenderBox *after* we do the final child layout.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-algorithm-with-margins-expected.txt:
  • css3/flexbox/flex-algorithm-with-margins.html: Added safe centering test case.
  • css3/flexbox/flex-flow-auto-margins-expected.txt: Added.
  • css3/flexbox/flex-flow-auto-margins.html: Added.
  • css3/flexbox/flex-pack.html: Fixed old results.
9:05 PM Changeset in webkit [117896] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline for r117865.

  • platform/chromium-mac/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
9:01 PM Changeset in webkit [117895] by leviw@chromium.org
  • 90 edits
    32 adds
    18 deletes in trunk/LayoutTests

Unreviewed. Updating more Chromium test expectations following r117815.

  • ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/nested-columns-expected.txt: Removed.
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt: Added.
  • platform/chromium-mac/compositing/overflow/theme-affects-visual-overflow-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/overflow: Added.
  • platform/chromium-win-vista/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-win-vista/tables/mozilla/marvin: Added.
  • platform/chromium-win-vista/tables/mozilla/marvin/tables_align_center-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png: Added.
  • platform/chromium-win-xp/compositing/overflow: Added.
  • platform/chromium-win-xp/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-win-xp/tables/mozilla/marvin: Added.
  • platform/chromium-win-xp/tables/mozilla/marvin/tables_align_center-expected.png: Added.
  • platform/chromium-win/compositing/overflow/theme-affects-visual-overflow-expected.txt:
  • platform/chromium-win/plugins/embed-attributes-style-expected.txt:
  • platform/chromium-win/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-win/svg/custom/viewBox-hit-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17130-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug17130-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug3309-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5538-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8032-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.txt:
  • platform/chromium-win/tables/mozilla/core/margins-expected.png:
  • platform/chromium-win/tables/mozilla/core/margins-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/other/test3-expected.png:
  • platform/chromium-win/tables/mozilla/other/test6-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1647-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1647-expected.png: Removed.
  • platform/gtk/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1647-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
8:47 PM Changeset in webkit [117894] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] EFL's DumpRenderTree does not print didReceiveTitle messages
https://bugs.webkit.org/show_bug.cgi?id=85971

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-21
Reviewed by Antonio Gomes.

Tools:

Listen for the "title,changed" signal on the frames instead of the
view so that we get notified for other frame than the main one.
Print out the didReceiveTitle messages which are expected if
LayoutTestController's dumpFrameLoadCallbacks() returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameTitleChanged):
(DumpRenderTreeChrome::onFrameCreated):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip http/tests/loading/redirect-with-no-location-crash.html now
that EFL's DumpRenderTree prints out the expected didReceiveTitle
messages.

  • platform/efl/Skipped:
8:37 PM Changeset in webkit [117893] by eae@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Remove platform specific ref-test expectations for chromium as ref-tests appears not to support platform specific results.

  • platform/chromium/fast/regions/floats-basic-in-variable-width-regions-expected.html: Removed.
  • platform/chromium/fast/regions/overflow-in-uniform-regions-expected.html: Removed.
  • platform/chromium/fast/regions/render-region-renderer-expected.html: Removed.
  • platform/chromium/test_expectations.txt:
8:36 PM Changeset in webkit [117892] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 113284 - Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Fix an issue when removing elements with reflections from the document.

Test: compositing/reflections/remove-reflection.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::willBeDestroyed):

LayoutTests: REGRESSION(112939): compositing/reflections/backface-hidden-reflection.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Test that removes reflected elements.

  • compositing/reflections/remove-reflection-expected.txt: Added.
  • compositing/reflections/remove-reflection.html: Added.

Conflicts:

Source/WebCore/platform/graphics/GraphicsLayer.cpp

8:36 PM Changeset in webkit [117891] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8

Merge 112939 - Fix issue with reflections and composited layers
https://bugs.webkit.org/show_bug.cgi?id=82636

Source/WebCore:

Reviewed by Alexey Proskuryakov

When tearing down GraphicsLayers which referene eachother via m_replicatedLayer/m_replicaLayer,
we need to clean up the replica layer pointers.

No new tests; tested by existing compositing and repaint tests.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::setReplicatedByLayer):

LayoutTests:

Reviewed by Alexey Proskuryakov

Unskip some compositing tests that should pass now.

  • platform/mac-wk2/Skipped:

Conflicts:

LayoutTests/platform/mac-wk2/Skipped
Source/WebCore/platform/graphics/GraphicsLayer.cpp

8:30 PM Changeset in webkit [117890] by gyuyoung.kim@samsung.com
  • 4 edits
    1 add in trunk/Source/WebCore

[EFL] Add inital mediaControlsEflfullscreen.css for fullscreen control UI
https://bugs.webkit.org/show_bug.cgi?id=86988

Reviewed by Eric Carlson.

In order to support fullscreen feature, EFL port needs to have new css file for fullscreen media control UI.

No new tests because this patch is covered by existing tests.

  • PlatformEfl.cmake:
  • css/mediaControlsEflFullscreen.css: Added.

(video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(video::-webkit-media-controls-mute-button):
(video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-current-time-display):
(video::-webkit-media-controls-time-remaining-display):
(video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-volume-slider-container):
(video::-webkit-media-controls-volume-slider):
(video::-webkit-media-controls-seek-back-button):
(video::-webkit-media-controls-seek-forward-button):
(video::-webkit-media-controls-fullscreen-button):
(video::-webkit-media-controls-rewind-button):
(video::-webkit-media-controls-return-to-realtime-button):
(video::-webkit-media-controls-toggle-closed-captions-button):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::extraFullScreenStyleSheet):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

8:28 PM WebKitIDL edited by morrita@google.com
(diff)
8:05 PM Changeset in webkit [117889] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog

Merge 107075 - [Qt] New http/tests/security/ introduced r107046 fail
https://bugs.webkit.org/show_bug.cgi?id=78093

Unskip these tests and rebaselines for Qt and GTK.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-08
Reviewed by Csaba Osztrogonác.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

Conflicts:

LayoutTests/platform/gtk/Skipped

8:04 PM Changeset in webkit [117888] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog

Merge 107069 - Unreviewed. Rebaselined the test that has been failing since r107046.

  • http/tests/security/cross-frame-access-put-expected.txt:
8:04 PM Changeset in webkit [117887] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8

Merge 107046 - Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

  • page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

  • http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
  • http/tests/security/cross-frame-access-frameelement.html: Added.
  • http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
8:04 PM Changeset in webkit [117886] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116551 - Crash from removal of a line break object
https://bugs.webkit.org/show_bug.cgi?id=85997

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-09
Reviewed by David Hyatt.

Source/WebCore:

Regression from r115343. That replaced a call to setNeedsLayout()
with a separate call that used a different bit during linebox
invalidation after renderer child removal. There are special cases
where layout isn't marked on parent nodes just from the removal, so
line dirtying needs to explicitly mark ancestors for layout.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setAncestorLineBoxDirty):

LayoutTests:

Test case to exercise crashing condition in bug 85997.

  • fast/block/line-layout/line-break-removal-near-textarea-crash-expected.txt: Added
  • fast/block/line-layout/line-break-removal-near-textarea-crash.html: Added
8:04 PM Changeset in webkit [117885] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115343 - Crash from removal of line break object after layout
https://bugs.webkit.org/show_bug.cgi?id=75461

Source/WebCore:

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-26
Reviewed by David Hyatt.

There is a condition where objects can get removed from underneath
inlines while they represent a line break object in a RootInlineBox
of an ancestor block. If an intermediary inline has already been
marked as needing layout, then the line box will not get dirtied
because dirtyLineFromChangedChild thinks it already has been.

This patch introduces a new set in RenderObject to indicate whether
an ancestral line box corresponding to the current line has been
marked dirty or not. dirtyLinesFromChangedChild() can use this set
rather than m_selfNeedsLayout, so it will not be confused if a
container was dirtied for some other reason that did not affect the
line box.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Use the new
set rather than m_selfNeedsLayout in the container to determine
whether to continue propagating upward.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::s_ancestorLineboxDirtySet): Instantiate the
static member.
(WebCore::RenderObject::willBeDestroyed): Clears the object from the
linebox set when it is being destroyed.

  • rendering/RenderObject.h:

(WebCore::RenderObject::s_ancestorLineboxDirtySet): Added static
member set.
(WebCore::RenderObject::setNeedsLayout): Clears the
object from the linebox set when layout bits are getting cleared.
(WebCore::RenderObject::ancestorLineBoxDirty): Added.
(WebCore::RenderObject::setAncestorLineBoxDirty): Added.

LayoutTests:

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-25
Reviewed by David Hyatt.

Test exercising crashing condition in bug 75461.

  • fast/block/line-layout/line-break-obj-removal-crash-expected.txt: Added
  • fast/block/line-layout/line-break-obj-removal-crash.html: Added
8:03 PM Changeset in webkit [117884] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 109406 - Prevent layout root to remain set on renderers getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=79953

Reviewed by Eric Seidel.

Implement Julien Chaffraix's idea.

  • page/FrameView.h:

(WebCore::FrameView::clearLayoutRoot): helper to clear layout root.

  • rendering/RenderObject.cpp:

(WebCore::clearLayoutRootIfNeeded): if we know we are going
away and we are the view's layout root, then we need to reset the layout
root to prevent being used.
(WebCore):
(WebCore::RenderObject::willBeDestroyed): call clearLayoutRootIfNeeded at end.

8:03 PM Changeset in webkit [117883] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/test_expectations.txt

Mark new test as expected to pass or have diff text, but not crash!

8:03 PM Changeset in webkit [117882] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 113229 - Source/WebCore: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

Test: fast/html/pending-stylesheet-crash.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::removedFromDocument):

LayoutTests: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

  • fast/html/pending-stylesheet-crash-expected.txt: Added.
  • fast/html/pending-stylesheet-crash.html: Added.
8:02 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
8:01 PM Changeset in webkit [117881] by eae@chromium.org
  • 11 edits
    11 adds in trunk/LayoutTests

Unreviewed chromium svg rebaselines and test expectation updates post r117815.

  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/chromium-win-vista/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/chromium-win-xp/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/chromium/test_expectations.txt:
7:57 PM Changeset in webkit [117880] by inferno@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Unreviewed. Rebaseline for r117865.

  • platform/chromium-linux/fast/runin/runin-between-list-marker-and-before-content-expected.png: Removed.
  • platform/chromium-win/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
7:56 PM Changeset in webkit [117879] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL] Unreviewed, reverting r116461.

r116461 caused a regression in the pixel tests, as scrollbars
stopped being rendered in the PNGs.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

7:51 PM Changeset in webkit [117878] by eae@chromium.org
  • 1 edit
    3 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium mac rebaseline for svg zoom tests.

  • platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
7:46 PM Changeset in webkit [117877] by eae@chromium.org
  • 5 edits
    8 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium linux and windows rebaselines.

  • fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/chromium-linux-x86/platform: Added.
  • platform/chromium-linux-x86/platform/chromium: Added.
  • platform/chromium-linux-x86/platform/chromium/compositing: Added.
  • platform/chromium-linux-x86/platform/chromium/compositing/filters: Added.
  • platform/chromium-linux-x86/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/efl/fast/borders/border-image-side-reduction-expected.png: Removed.
  • platform/gtk/fast/borders/border-image-side-reduction-expected.png: Removed.
7:33 PM Changeset in webkit [117876] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117309
BUG=120912

7:32 PM Changeset in webkit [117875] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 117309
BUG=120912
Review URL: https://chromiumcodereview.appspot.com/10388225

7:31 PM Changeset in webkit [117874] by eae@chromium.org
  • 5 edits
    3 adds in trunk/LayoutTests

Unreviewed rebaselines for chromium mac and windows.

  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/standards1-expected.txt: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/standards1-expected.png: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/standards1-expected.png:
7:31 PM Changeset in webkit [117873] by haraken@chromium.org
  • 24 edits in trunk/Source/WebCore

[V8] Remove V8Proxy::notHandledByInterceptor()
https://bugs.webkit.org/show_bug.cgi?id=86831

Reviewed by Adam Barth.

This patch replaces 'return V8Proxy::notHandledByInterceptor()'
with 'return v8::Handle<v8::Value>()'. See the discussion in
https://bugs.webkit.org/show_bug.cgi?id=85330 for more details.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunctionCallback):
(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):

  • bindings/v8/V8Collection.h:

(WebCore::collectionNamedPropertyGetter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectSetProperty):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::throwError):

  • bindings/v8/V8Proxy.h:

(WebCore):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:

(WebCore::npObjectNamedGetter):
(WebCore::npObjectNamedSetter):
(WebCore::npObjectIndexedGetter):
(WebCore::npObjectIndexedSetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyGetter):
(WebCore::storageSetter):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

7:27 PM Changeset in webkit [117872] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline for r117865.

  • platform/chromium-linux/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added.
7:18 PM Changeset in webkit [117871] by eae@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Chromium linux rebaselines post sub-pixel switch.

  • platform/chromium-linux/fast/borders/bidi-012-expected.txt: Added.
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.txt: Added.
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.txt: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.txt: Added.
7:04 PM Changeset in webkit [117870] by beidson@apple.com
  • 4 edits
    1 add in trunk

<rdar://problem/11460336> and https://bugs.webkit.org/show_bug.cgi?id=87061
WKPageGetScaleFactor can return 0.0 after a session is restored

Reviewed by Beth Dakin.

Source/WebKit2:

API test WKPageGetScaleFactorNotZero added.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState): Tell the UI Process the scale factor

is 1.0 if it has never been manually set.

Tools:

Loads a simple page, creates a session from it, restores that session, then
queries the page scale factor for the appropriate value of 1.0.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::createSessionState):
(TestWebKitAPI::TEST):

6:55 PM Changeset in webkit [117869] by andersca@apple.com
  • 5 edits
    2 adds in trunk

Flash player buttons do not work when page is zoomed in
https://bugs.webkit.org/show_bug.cgi?id=87056
<rdar://problem/11491501>

Reviewed by Oliver Hunt.

Source/WebKit2:

Use the page scale factor when computing the plug-in to root view transform, otherwise we'll compute an
incorrect transform for plug-ins inside subframes. Also, make sure that viewGeometryDidChange is called for all plug-ins
when scaling the page since otherwise it won't be called unless the scroll position changes.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pageScaleFactorDidChange):
(WebKit):
(WebKit::PluginView::viewGeometryDidChange):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scalePage):

LayoutTests:

  • platform/mac-wk2/plugins/mouse-events-scaled-iframe-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-scaled-iframe.html: Added.
6:53 PM Changeset in webkit [117868] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink FontDescription object size
https://bugs.webkit.org/show_bug.cgi?id=86950

Reviewed by Alexey Proskuryakov.

Reduce object size of FontDescription by 8 bytes on 64-bit, 4 bytes on 32-bit systems.
Note that this means Font, StyleInheritedData and RenderSVGInlineText shrink too.

  • platform/graphics/FontDescription.cpp:
  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::script):
(FontDescription):

6:49 PM Changeset in webkit [117867] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Chromium compile fix, unreviewed.

Fixed is defined in WebCore and is a typedef in the OS X 10.5 SDK headers, so it needs an explicit WebCore::
prefix to be unambiguous on mac.

  • tests/FilterOperationsTest.cpp:

(WebKit::TEST):

6:45 PM Changeset in webkit [117866] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Style guide change: Uses of "std::" should be explicitly qualified.
https://bugs.webkit.org/show_bug.cgi?id=87043

Patch by Peter Kasting <pkasting@google.com> on 2012-05-21
Reviewed by Ryosuke Niwa.

  • coding/coding-style.html:
6:36 PM Changeset in webkit [117865] by inferno@chromium.org
  • 12 edits
    1 move
    5 adds
    2 deletes in trunk

Regression(r117482): Run-in crashes relating to generated content and inline line box clearing.
https://bugs.webkit.org/show_bug.cgi?id=86879

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/generated-content-crash.html

fast/runin/move-run-in-original-position-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use the new helper
placeRunInIfNeeded. Do not place the run-in if it is a generated container since
the caller such as updateBeforeAfterContent might be keeping a reference to it
and adding children to it later.
(WebCore::destroyRunIn): Add ability to clear line box tree for inlines.
(WebCore::RenderBlock::placeRunInIfNeeded): Helper to place run-in. Add an
argument to not modify generated content during addChild, it should be moved
only at end of updateBeforeAfterContent.
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded):
(WebCore::RenderBlock::runInIsPlacedIntoSiblingBlock): helper to tell if this run-in
is actually placed into the next sibling block.
(WebCore::RenderBlock::moveRunInToOriginalPosition):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::deleteLineBoxTree): like RenderBlock, add a helper
for deleteLineBoxTree. Virtualizing this might not be good, since this is
the only call site for inline line box tree clearing and RenderBlock::deleteLineBoxTree
is called a lot.

  • rendering/RenderObjectChildList.cpp:

(WebCore::createRendererForBeforeAfterContent): fix a typo.
(WebCore::RenderObjectChildList::updateBeforeAfterContent): If insertBefore is equal
to the intruded run-in, then set it to next sibling so that new child will come after it. At
the end, place the generatedContainer if it is a run-in.

LayoutTests:

These tests need to show dump render tree to show the correct location of run-in placement. All
renderings match IE and Opera.

  • fast/lists/parent-box-not-box-crash-expected.txt: Rebaselined, since now run-in functions correctly

by being the first child before list marker.

  • fast/runin/generated-content-crash-expected.png: Added.
  • fast/runin/generated-content-crash-expected.txt: Added.
  • fast/runin/generated-content-crash.html: Added.
  • fast/runin/move-run-in-original-position-crash-expected.png: Added.
  • fast/runin/move-run-in-original-position-crash-expected.txt: Added.
  • fast/runin/move-run-in-original-position-crash.html: Added.
  • fast/runin/runin-between-list-marker-and-before-content-expected.png:
  • fast/runin/runin-between-list-marker-and-before-content-expected.txt: Rebaselined, since now run-in

functions correctly by being the first child before list marker.

6:10 PM Changeset in webkit [117864] by jamesr@google.com
  • 31 edits
    2 adds
    1 delete in trunk/Source

[chromium] Port chromium compositor to use WebFilterOperation(s)
https://bugs.webkit.org/show_bug.cgi?id=87046

Reviewed by Adrienne Walker.

Source/Platform:

This changes WebFilterOperation / WebFilterOperations from being simple wrappers over WebCore types to being
standalone. WebFilterOperation is a plain old data struct with some convenience constuctors and type
assertions. Each WebFilterOperation contains a type tag and the parameters needed for each filter.
WebFilterOperations represents an ordered list of WebFilterOperation instances and can be copied around as
needed. It also exposes a few convenience functions about how the filters will modify pixels.

  • Platform.gypi:
  • chromium/public/WebFilterOperation.h:

(WebFilterOperation):
(WebKit::WebFilterOperation::type):
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::dropShadowOffset):
(WebKit::WebFilterOperation::dropShadowColor):
(WebKit::WebFilterOperation::createGrayscaleFilter):
(WebKit::WebFilterOperation::createSepiaFilter):
(WebKit::WebFilterOperation::createSaturateFilter):
(WebKit::WebFilterOperation::createHueRotateFilter):
(WebKit::WebFilterOperation::createInvertFilter):
(WebKit::WebFilterOperation::createBrightnessFilter):
(WebKit::WebFilterOperation::createContrastFilter):
(WebKit::WebFilterOperation::createOpacityFilter):
(WebKit::WebFilterOperation::createBlurFilter):
(WebKit::WebFilterOperation::createDropShadowFilter):
(WebKit::WebFilterOperation::equals):
(WebKit::WebFilterOperation::WebFilterOperation):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebFilterOperations.h:

(WebKit):
(WebKit::WebFilterOperations::WebFilterOperations):
(WebKit::WebFilterOperations::operator=):
(WebFilterOperations):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/src/WebFilterOperations.cpp: Added.

(WebKit):
(WebFilterOperationsPrivate):
(WebKit::WebFilterOperations::initialize):
(WebKit::WebFilterOperations::destroy):
(WebKit::WebFilterOperations::assign):
(WebKit::WebFilterOperations::equals):
(WebKit::WebFilterOperations::append):
(WebKit::WebFilterOperations::clear):
(WebKit::WebFilterOperations::isEmpty):
(WebKit::spreadForStdDeviation):
(WebKit::WebFilterOperations::getOutsets):
(WebKit::WebFilterOperations::hasFilterThatMovesPixels):
(WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):
(WebKit::WebFilterOperations::size):
(WebKit::WebFilterOperations::at):

Source/WebCore:

This converts all compositor implementation logic to use WebFilterOperation(s) directly instead of the WebCore
types. GraphicsLayerChromium bridges between a WebCore::FilterOperations to WebFilterOperations, doing the
necessary type conversions and checking for filters that our compositor implementation supports. This cleans up
the chromium compositor's dependencies and removes any thread constraints from WebCore::FilterOperation /
WebCore::FilterOperations.

Covered by existing layout tests and unit tests in FilterOperationsTest.cpp

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/support/WebFilterOperations.cpp: Moved to Source/Platform/chromium/src/
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::copyWebCoreFilterOperationsToWebFilterOperations):
(WebCore):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setFilters):
(WebCore::LayerChromium::setBackgroundFilters):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::filters):
(WebCore::LayerChromium::backgroundFilters):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::setFilters):
(WebCore::RenderSurfaceChromium::filters):
(WebCore::RenderSurfaceChromium::setBackgroundFilters):
(WebCore::RenderSurfaceChromium::backgroundFilters):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::expandDamageRectWithFilters):
(WebCore::expandDamageRectInsideRectWithFilters):
(WebCore::CCDamageTracker::updateDamageTrackingState):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(WebKit):
(WebCore):
(CCDamageTracker):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setFilters):
(WebCore::CCLayerImpl::setBackgroundFilters):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::filters):
(WebCore::CCLayerImpl::backgroundFilters):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::applyFilters):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setFilters):
(WebCore::CCRenderSurface::filters):
(CCRenderSurface):
(WebCore::CCRenderSurface::setBackgroundFilters):
(WebCore::CCRenderSurface::backgroundFilters):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.h:

(WebKit):
(CCRenderSurfaceFilters):

  • testing/Internals.cpp:

(WebCore::Internals::setBackgroundBlurOnNode):

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/AssertMatchingEnums.cpp:
  • src/WebLayer.cpp:

(WebKit::WebLayer::setFilters):
(WebKit::WebLayer::setBackgroundFilters):

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::createSurface):
(WebKitTests::CCOcclusionTrackerTest::createDrawingSurface):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):

  • tests/FilterOperationsTest.cpp: Added. Tests the existing behavior of WebCore::FilterOperations::getOutsets and makes sure WebFilterOperations' behavior matches.

(WebKit):
(WebKit::TEST):

  • tests/GraphicsLayerChromiumTest.cpp:
5:54 PM Changeset in webkit [117863] by leviw@chromium.org
  • 329 edits
    73 adds
    108 deletes in trunk/LayoutTests

Unreviewed. Yet more updated test expectations following r117815.

  • css2.1/t090501-c414-flt-03-b-g-expected.txt: Added.
  • fast/borders/bidi-012-expected.txt: Added.
  • fast/css/css2-system-fonts-expected.txt: Added.
  • fast/lists/ordered-list-with-no-ol-tag-expected.txt: Added.
  • fast/multicol/column-break-with-balancing-expected.txt: Added.
  • fast/multicol/float-multicol-expected.txt: Added.
  • fast/multicol/layers-in-multicol-expected.txt: Added.
  • fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.
  • fast/multicol/scrolling-overflow-expected.txt: Added.
  • fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
  • fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-1-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-10-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-2-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-3-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-4-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-5-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-6-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-7-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-8-expected.txt: Added.
  • fast/repaint/line-flow-with-floats-9-expected.txt: Added.
  • fast/ruby/ruby-inline-table-expected.txt: Added.
  • fast/selectors/032-expected.txt: Added.
  • fast/selectors/unqualified-hover-quirks-expected.txt: Added.
  • fast/table/009-expected.txt: Added.
  • fast/table/014-expected.txt: Added.
  • fast/table/041-expected.txt: Added.
  • fast/table/nested-percent-height-table-expected.txt: Added.
  • fast/table/percent-heights-expected.txt: Added.
  • fast/text/basic/012-expected.txt: Added.
  • fast/text/basic/generic-family-reset-expected.txt: Added.
  • fast/text/line-breaks-expected.txt: Added.
  • fast/transforms/bounding-rect-zoom-expected.txt: Added.
  • fast/writing-mode/fieldsets-expected.txt: Added.
  • platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/max-height-columns-block-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/overflow-across-columns-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/overflow-across-columns-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-mac-leopard/fast/overflow/overflow_hidden-expected.png:
  • platform/chromium-mac-leopard/fast/overflow/overflow_hidden-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/chromium-mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/chromium-mac-leopard/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/chromium-mac-leopard/fast/regions/bottom-overflow-out-of-first-region-expected.png:
  • platform/chromium-mac-leopard/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
  • platform/chromium-mac-leopard/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac-leopard/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac-leopard/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-mac-leopard/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/chromium-mac-leopard/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/ruby/ruby-inline-table-expected.png:
  • platform/chromium-mac-leopard/fast/selectors/032-expected.png:
  • platform/chromium-mac-leopard/fast/selectors/166-expected.png:
  • platform/chromium-mac-leopard/fast/selectors/unqualified-hover-quirks-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/009-expected.png:
  • platform/chromium-mac-leopard/fast/table/014-expected.png:
  • platform/chromium-mac-leopard/fast/table/041-expected.png:
  • platform/chromium-mac-leopard/fast/table/absolute-table-at-bottom-expected.png:
  • platform/chromium-mac-leopard/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/table/nested-percent-height-table-expected.png:
  • platform/chromium-mac-leopard/fast/table/percent-heights-expected.png:
  • platform/chromium-mac-leopard/fast/text/basic/012-expected.png:
  • platform/chromium-mac-leopard/fast/text/basic/013-expected.png:
  • platform/chromium-mac-leopard/fast/text/basic/generic-family-reset-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-mac-leopard/fast/text/line-breaks-expected.png:
  • platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-leopard/fast/text/whitespace/024-expected.png:
  • platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-mac-leopard/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-mac-leopard/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png:
  • platform/chromium-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/chromium-mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/chromium-mac-leopard/http/tests/misc/iframe404-expected.png:
  • platform/chromium-mac-leopard/http/tests/misc/iframe404-expected.txt: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-leopard/svg/text/small-fonts-in-html5-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
  • platform/chromium-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/css1/font_properties/font-expected.txt: Added.
  • platform/chromium-mac/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/lists/ordered-list-with-no-ol-tag-expected.png:
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-mac/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-across-columns-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-mac/fast/overflow/overflow_hidden-expected.png:
  • platform/chromium-mac/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/chromium-mac/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.png:
  • platform/chromium-mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
  • platform/chromium-mac/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-inline-table-expected.png:
  • platform/chromium-mac/fast/selectors/032-expected.png:
  • platform/chromium-mac/fast/selectors/166-expected.png:
  • platform/chromium-mac/fast/selectors/unqualified-hover-quirks-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac/fast/table/009-expected.png:
  • platform/chromium-mac/fast/table/014-expected.png:
  • platform/chromium-mac/fast/table/041-expected.png:
  • platform/chromium-mac/fast/table/absolute-table-at-bottom-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
  • platform/chromium-mac/fast/table/nested-percent-height-table-expected.png:
  • platform/chromium-mac/fast/table/percent-heights-expected.png:
  • platform/chromium-mac/fast/text/basic/012-expected.png:
  • platform/chromium-mac/fast/text/basic/013-expected.png:
  • platform/chromium-mac/fast/text/basic/generic-family-reset-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-mac/fast/text/line-breaks-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/whitespace/024-expected.png:
  • platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/chromium-mac/http/tests/misc/iframe404-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-win-vista/compositing/reflections: Removed.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win-vista/css1/font_properties: Added.
  • platform/chromium-win-vista/css1/font_properties/font-expected.txt: Added.
  • platform/chromium-win-vista/css1/text_properties/vertical_align-expected.png: Added.
  • platform/chromium-win-vista/fast/images: Removed.
  • platform/chromium-win-vista/fast/multicol: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-win-vista/fast/ruby: Removed.
  • platform/chromium-win-vista/fast/text/basic: Removed.
  • platform/chromium-win-vista/fast/writing-mode/broken-ideographic-font-expected.txt: Added.
  • platform/chromium-win-vista/http/tests/misc/iframe404-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-win-xp/compositing/reflections: Removed.
  • platform/chromium-win-xp/compositing/shadows: Removed.
  • platform/chromium-win-xp/fast/css/css2-system-fonts-expected.txt:
  • platform/chromium-win-xp/fast/images: Removed.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-win-xp/fast/text/line-breaks-expected.png:
  • platform/chromium-win-xp/fast/text/line-breaks-expected.txt:
  • platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt: Added.
  • platform/chromium-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/css1/font_properties/font-expected.txt:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/chromium-win/fast/borders/bidi-012-expected.txt:
  • platform/chromium-win/fast/css/continuationCrash-expected.txt:
  • platform/chromium-win/fast/css/css2-system-fonts-expected.txt:
  • platform/chromium-win/fast/css/hsla-color-expected.png:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
  • platform/chromium-win/fast/css/rgb-float-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-win/fast/lists/ordered-list-with-no-ol-tag-expected.png:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.png:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/overflow-across-columns-expected.png:
  • platform/chromium-win/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-win/fast/multicol/positive-leading-expected.png:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-win/fast/overflow/overflow_hidden-expected.png:
  • platform/chromium-win/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/chromium-win/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.png:
  • platform/chromium-win/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
  • platform/chromium-win/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-win/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/chromium-win/fast/regions/overflow-size-change-with-stacking-context-expected.png:
  • platform/chromium-win/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
  • platform/chromium-win/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.png:
  • platform/chromium-win/fast/selectors/032-expected.png:
  • platform/chromium-win/fast/selectors/166-expected.png:
  • platform/chromium-win/fast/selectors/unqualified-hover-quirks-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-win/fast/table/009-expected.png:
  • platform/chromium-win/fast/table/014-expected.png:
  • platform/chromium-win/fast/table/041-expected.png:
  • platform/chromium-win/fast/table/absolute-table-at-bottom-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
  • platform/chromium-win/fast/table/nested-percent-height-table-expected.png:
  • platform/chromium-win/fast/table/percent-heights-expected.png:
  • platform/chromium-win/fast/text/basic/012-expected.png:
  • platform/chromium-win/fast/text/basic/013-expected.png:
  • platform/chromium-win/fast/text/basic/generic-family-reset-expected.png:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-win/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-win/fast/text/international/thai-line-breaks-expected.txt:
  • platform/chromium-win/fast/text/line-breaks-expected.png:
  • platform/chromium-win/fast/text/line-breaks-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-win/fast/text/whitespace/024-expected.png:
  • platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-win/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/chromium-win/http/tests/misc/iframe404-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/text/small-fonts-in-html5-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/css1/font_properties/font-expected.txt: Removed.
  • platform/efl/css2.1/t090501-c414-flt-03-b-g-expected.txt: Removed.
  • platform/efl/fast/borders/bidi-012-expected.txt: Removed.
  • platform/efl/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.txt: Removed.
  • platform/efl/fast/multicol/column-break-with-balancing-expected.txt: Removed.
  • platform/efl/fast/multicol/float-multicol-expected.txt: Removed.
  • platform/efl/fast/multicol/layers-in-multicol-expected.txt: Removed.
  • platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.txt: Removed.
  • platform/efl/fast/multicol/scrolling-overflow-expected.txt: Removed.
  • platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Removed.
  • platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Removed.
  • platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
  • platform/efl/fast/multicol/span/anonymous-style-inheritance-expected.txt: Removed.
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt: Removed.
  • platform/efl/fast/ruby/ruby-inline-table-expected.txt: Removed.
  • platform/efl/fast/selectors/032-expected.txt: Removed.
  • platform/efl/fast/selectors/unqualified-hover-quirks-expected.txt: Removed.
  • platform/efl/fast/table/009-expected.txt: Removed.
  • platform/efl/fast/table/014-expected.txt: Removed.
  • platform/efl/fast/table/041-expected.txt: Removed.
  • platform/efl/fast/table/nested-percent-height-table-expected.txt: Removed.
  • platform/efl/fast/table/percent-heights-expected.txt: Removed.
  • platform/efl/fast/text/basic/012-expected.txt: Removed.
  • platform/efl/fast/text/basic/generic-family-reset-expected.txt: Removed.
  • platform/efl/fast/text/line-breaks-expected.txt: Removed.
  • platform/efl/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
  • platform/efl/fast/writing-mode/fieldsets-expected.txt: Removed.
  • platform/gtk/css2.1/t090501-c414-flt-03-b-g-expected.txt: Removed.
  • platform/gtk/fast/borders/bidi-012-expected.txt: Removed.
  • platform/gtk/fast/css/css2-system-fonts-expected.txt: Removed.
  • platform/gtk/fast/lists/ordered-list-with-no-ol-tag-expected.txt: Removed.
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Removed.
  • platform/gtk/fast/multicol/float-multicol-expected.txt: Removed.
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Removed.
  • platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt: Removed.
  • platform/gtk/fast/multicol/scrolling-overflow-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Removed.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt: Removed.
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt: Removed.
  • platform/gtk/fast/ruby/ruby-inline-table-expected.txt: Removed.
  • platform/gtk/fast/selectors/032-expected.txt: Removed.
  • platform/gtk/fast/selectors/unqualified-hover-quirks-expected.txt: Removed.
  • platform/gtk/fast/table/009-expected.txt: Removed.
  • platform/gtk/fast/table/014-expected.txt: Removed.
  • platform/gtk/fast/table/041-expected.txt: Removed.
  • platform/gtk/fast/table/nested-percent-height-table-expected.txt: Removed.
  • platform/gtk/fast/table/percent-heights-expected.txt: Removed.
  • platform/gtk/fast/text/basic/012-expected.txt: Removed.
  • platform/gtk/fast/text/basic/generic-family-reset-expected.txt: Removed.
  • platform/gtk/fast/text/line-breaks-expected.txt: Removed.
  • platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/fieldsets-expected.txt: Removed.
  • platform/mac-snowleopard/css1/font_properties/font-expected.txt: Removed.
  • platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Removed.
5:53 PM Changeset in webkit [117862] by tkent@chromium.org
  • 1 edit
    3 adds in trunk/PerformanceTests

Add performance tests for <textarea>
https://bugs.webkit.org/show_bug.cgi?id=86994

Reviewed by Ryosuke Niwa.

  • DOM/textarea-dom.html: Added.
  • DOM/textarea-edit.html: Added.
  • Parser/textarea-parsing.html: Added.
5:51 PM Changeset in webkit [117861] by fpizlo@apple.com
  • 13 edits
    3 adds in trunk/Source

DFG should be able to compute dominators
https://bugs.webkit.org/show_bug.cgi?id=85269

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Merged r115754 from dfgopt.

Implements a naive dominator calculator, which is currently just used to
print information in graph dumps. I've enabled it by default mainly to
be able to track its performance impact. So far it appears that there is
none, which is unsurprising given that the number of basic blocks in most
procedures is small.

Also tweaked bytecode dumping to reveal more useful information about the
nature of the code block.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • dfg/DFGDominators.cpp: Added.

(DFG):
(JSC::DFG::Dominators::Dominators):
(JSC::DFG::Dominators::~Dominators):
(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::iterateForBlock):

  • dfg/DFGDominators.h: Added.

(DFG):
(Dominators):
(JSC::DFG::Dominators::invalidate):
(JSC::DFG::Dominators::computeIfNecessary):
(JSC::DFG::Dominators::isValid):
(JSC::DFG::Dominators::dominates):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

Source/WTF:

Reviewed by Oliver Hunt.

Merged r115754 from dfgopt.

Added a bitvector class suitable for cheap static analysis. This class
differs from BitVector in that instead of optimizing for space, it
optimizes for execution time. Its API is also somewhat less friendly,
which is intentional; it's meant to be used in places where you know
up front how bit your bitvectors are going to be.

  • GNUmakefile.list.am:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/FastBitVector.h: Added.

(WTF):
(FastBitVector):
(WTF::FastBitVector::FastBitVector):
(WTF::FastBitVector::operator=):
(WTF::FastBitVector::numBits):
(WTF::FastBitVector::resize):
(WTF::FastBitVector::setAll):
(WTF::FastBitVector::clearAll):
(WTF::FastBitVector::set):
(WTF::FastBitVector::setAndCheck):
(WTF::FastBitVector::equals):
(WTF::FastBitVector::merge):
(WTF::FastBitVector::filter):
(WTF::FastBitVector::exclude):
(WTF::FastBitVector::clear):
(WTF::FastBitVector::get):
(WTF::FastBitVector::arrayLength):

5:49 PM Changeset in webkit [117860] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Cleanup of Calls to operationStrCat and operationNewArray and Use Constructor after r117729
https://bugs.webkit.org/show_bug.cgi?id=87027

Reviewed by Oliver Hunt.

Change calls to operationStrCat and operationNewArray to provide the
pointer to the EncodedJSValue* data buffer instead of the ScratchBuffer
that contains it. Added a ScratchBuffer::create() function.
This is a clean-up to r117729.

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalData.h:

(JSC::ScratchBuffer::create):
(JSC::ScratchBuffer::dataBuffer):
(JSC::JSGlobalData::scratchBufferForSize):

5:37 PM Changeset in webkit [117859] by barraclough@apple.com
  • 57 edits
    10 adds in trunk

Add support for private names
https://bugs.webkit.org/show_bug.cgi?id=86509

Reviewed by Oliver Hunt.

The spec isn't final, but we can start adding support to allow property maps
to contain keys that aren't identifiers.

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • Only expose public named properties over the JSC API.
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
    • Added new files to build system.
  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

  • Added support for property access with name objects.
  • interpreter/CallFrame.h:

(JSC::ExecState::privateNamePrototypeTable):

  • Added hash table for NamePrototype
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • Added support for property access with name objects.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Added support for property access with name objects.
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opIn):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • Added support for property access with name objects.
  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • Added hash table for NamePrototype
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::privateNameStructure):
(JSC::JSGlobalObject::symbolTableHasProperty):

  • Added new global properties.
  • runtime/JSType.h:
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::isName):

  • Added type for NameInstances, for fast isName check.
  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):

  • symbol table lookup should take a PropertyName.
  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:

(JSC::HashTable::entry):

  • entry lookup should take a PropertyName.
  • runtime/NameConstructor.cpp: Added.

(JSC):
(JSC::NameConstructor::NameConstructor):
(JSC::NameConstructor::finishCreation):
(JSC::constructPrivateName):
(JSC::NameConstructor::getConstructData):
(JSC::NameConstructor::getCallData):

  • runtime/NameConstructor.h: Added.

(JSC):
(NameConstructor):
(JSC::NameConstructor::create):
(JSC::NameConstructor::createStructure):

  • Added constructor.
  • runtime/NameInstance.cpp: Added.

(JSC):
(JSC::NameInstance::NameInstance):
(JSC::NameInstance::destroy):

  • runtime/NameInstance.h: Added.

(JSC):
(NameInstance):
(JSC::NameInstance::createStructure):
(JSC::NameInstance::create):
(JSC::NameInstance::privateName):
(JSC::NameInstance::nameString):
(JSC::NameInstance::finishCreation):
(JSC::isName):

  • Added instance.
  • runtime/NamePrototype.cpp: Added.

(JSC):
(JSC::NamePrototype::NamePrototype):
(JSC::NamePrototype::finishCreation):
(JSC::NamePrototype::getOwnPropertySlot):
(JSC::NamePrototype::getOwnPropertyDescriptor):
(JSC::privateNameProtoFuncToString):

  • runtime/NamePrototype.h: Added.

(JSC):
(NamePrototype):
(JSC::NamePrototype::create):
(JSC::NamePrototype::createStructure):

  • Added prototype.
  • runtime/PrivateName.h: Added.

(JSC):
(PrivateName):
(JSC::PrivateName::PrivateName):
(JSC::PrivateName::uid):

  • A private name object holds a StringImpl that can be used as a unique key in a property map.
  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):

  • Strings should only match keys in the table that are identifiers.
  • runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
(JSC::PropertyName::asIndex):
(JSC::operator==):
(JSC::operator!=):

  • replaced impl() & ustring() with uid() [to get the raw impl] and publicName() [impl or null, if not an identifier].
  • runtime/Structure.cpp:

(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::getPropertyNamesFromStructure):

  • runtime/Structure.h:

(JSC::Structure::get):

  • call uid() to get a PropertyName raw impl, for use as a key.

Source/WebCore:

Test: fast/js/names.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyIDForJSCSSPropertyName):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString):
(WebCore::objectToStringFunctionGetter):

  • bindings/js/JSDOMBinding.h:

(WebCore::propertyNameToString):
(WebCore::propertyNameToAtomicString):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::getMethod):

  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
(JSC::Bindings::ObjcClass::fallbackObject):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):

  • Removed PropertyName::impl(), call publicName() to get the string associated with a name.

Source/WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyClass::methodsNamed):
(WebKit::ProxyClass::fieldNamed):
(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

  • Removed PropertyName::impl(), call publicName() to get the string associated with a name.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::methodGetter):

  • Removed PropertyName::impl(), call publicName() to get the string associated with a name.

Source/WTF:

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(StringImpl):
(WTF::StringImpl::createEmptyUnique):
(WTF::StringImpl::isEmptyUnique):

  • Allow empty string impls to be allocated, which can be used as unique keys.

LayoutTests:

  • fast/js/names-expected.txt: Added.
  • fast/js/names.html: Added.
  • fast/js/script-tests/names.js: Added.
    • Added test cases.
5:28 PM Changeset in webkit [117858] by timothy_horton@apple.com
  • 8 edits in trunk/Source/WebCore

GeneratorGeneratedImage should cache intermediate images
https://bugs.webkit.org/show_bug.cgi?id=86906
<rdar://problem/11484852>

Reviewed by Dean Jackson.

Cache generated images in GeneratorGeneratedImage. The cache is invalidated:

a) if the Generator's hash changes.
b) if the rendered size changes.
c) if the cached image is incompatible with the destination context (acceleration state or CTM scale).
d) after one second of disuse.

Add a hash() function to Generator, which should be implemented in subclasses
to provide a straightforward way to determine if Generators have been mutated
in a way that will affect the resultant rendering.

No new tests, performance optimization. Correctness is covered by the multitude of existing gradient tests.

  • platform/graphics/Generator.h:

(Generator):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern):

  • platform/graphics/GeneratorGeneratedImage.h:

(WebCore):
(GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
(GeneratedImageCacheTimer):
(WebCore::GeneratorGeneratedImage::GeneratedImageCacheTimer::GeneratedImageCacheTimer):
(WebCore::GeneratorGeneratedImage::GeneratedImageCacheTimer::restart):

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient):
(WebCore::Gradient::addColorStop):
(WebCore::Gradient::sortStopsIfNecessary):
(WebCore::Gradient::setSpreadMethod):
(WebCore::Gradient::setGradientSpaceTransform):
(WebCore::Gradient::hash):

  • platform/graphics/Gradient.h:

(WebCore::Gradient::setP0):
(WebCore::Gradient::setP1):
(WebCore::Gradient::setStartRadius):
(WebCore::Gradient::setEndRadius):
(Gradient):
(WebCore::Gradient::clearHashCache):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::isCompatibleWithBuffer):
(WebCore):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

5:27 PM Changeset in webkit [117857] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r117634.

5:24 PM Changeset in webkit [117856] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r117623.

5:24 PM Changeset in webkit [117855] by eae@chromium.org
  • 6 edits
    1 delete in trunk

Fix bug in paintNinePieceImage exposed by subpixel change
https://bugs.webkit.org/show_bug.cgi?id=87060

Reviewed by Levi Weintraub.

Source/WebCore:

Fix rounding in paintNinePieceImage where the left/right images where
drawn on subpixel bounds.

Covered by existing tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png: Removed.
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png:
5:23 PM Changeset in webkit [117854] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117652.

5:21 PM Changeset in webkit [117853] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-536-branch/Source/WebCore

Merged r117607.

5:18 PM Changeset in webkit [117852] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536-branch

Merged r117537.

5:16 PM Changeset in webkit [117851] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536-branch

Merged r117523.

5:14 PM Changeset in webkit [117850] by Lucas Forschler
  • 5 edits in branches/safari-536-branch/Source/WebKit2

Merged r117516.

5:11 PM Changeset in webkit [117849] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit/mac

Merged r117510.

5:09 PM Changeset in webkit [117848] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merged r117502.

5:07 PM Changeset in webkit [117847] by Lucas Forschler
  • 3 edits
    6 copies in branches/safari-536-branch

Merged r117366.

5:06 PM Changeset in webkit [117846] by leviw@chromium.org
  • 46 edits
    41 adds
    33 deletes in trunk/LayoutTests

Unreviewed. More rebaselines following r117815.

  • fast/lists/008-expected.txt: Added.
  • fast/lists/008-vertical-expected.txt: Added.
  • fast/media/mq-relative-constraints-08-expected.txt: Added.
  • fast/overflow/infiniteRecursionGuard-expected.txt: Added.
  • fast/overflow/overflow-rtl-expected.txt: Added.
  • fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • fast/table/multiple-captions-display-expected.png: Added.
  • fast/table/table-hspace-align-center-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added.
  • platform/chromium-linux-x86/http/tests/navigation: Removed.
  • platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/lists/008-expected.png:
  • platform/chromium-mac-leopard/fast/overflow/infiniteRecursionGuard-expected.png:
  • platform/chromium-mac-leopard/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-leopard/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/control-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-leopard/fast/selectors/unqualified-hover-strict-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/table-hspace-align-center-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/vertical-baseline-alignment-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-flexbox-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/table-percent-height-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/lists/008-expected.png:
  • platform/chromium-mac/fast/lists/008-vertical-expected.png:
  • platform/chromium-mac/fast/overflow/infiniteRecursionGuard-expected.png:
  • platform/chromium-mac/fast/overflow/overflow-update-transform-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/table-percent-height-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/selectors/unqualified-hover-strict-expected.png:
  • platform/chromium-mac/fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • platform/chromium-mac/fast/table/multiple-captions-display-expected.png:
  • platform/chromium-mac/fast/table/table-hspace-align-center-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-win-vista/http/tests/navigation: Removed.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-win/fast/forms/search-rtl-expected.png:
  • platform/chromium-win/fast/multicol/break-properties-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/span/clone-flexbox-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/span/clone-summary-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium/fast/multicol/break-properties-expected.txt: Added.
  • platform/chromium/fast/multicol/span: Added.
  • platform/chromium/fast/multicol/span/clone-flexbox-expected.txt: Added.
  • platform/chromium/fast/multicol/span/clone-summary-expected.txt: Added.
  • platform/chromium/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
  • platform/chromium/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/lists/008-expected.txt: Removed.
  • platform/efl/fast/lists/008-vertical-expected.txt: Removed.
  • platform/efl/fast/media/mq-relative-constraints-08-expected.txt: Removed.
  • platform/efl/fast/overflow/infiniteRecursionGuard-expected.txt: Removed.
  • platform/efl/fast/overflow/overflow-rtl-expected.txt: Removed.
  • platform/efl/fast/overflow/overflow-rtl-vertical-expected.txt: Removed.
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Removed.
  • platform/efl/fast/table/multiple-captions-display-expected.png: Removed.
  • platform/efl/fast/table/table-hspace-align-center-expected.txt: Removed.
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/fast/lists/008-expected.txt: Removed.
  • platform/gtk/fast/lists/008-vertical-expected.txt: Removed.
  • platform/gtk/fast/media/mq-relative-constraints-08-expected.txt: Removed.
  • platform/gtk/fast/overflow/infiniteRecursionGuard-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-rtl-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt: Removed.
  • platform/gtk/fast/selectors/unqualified-hover-strict-expected.txt: Removed.
  • platform/gtk/fast/table/multiple-captions-display-expected.png: Removed.
  • platform/gtk/fast/table/table-hspace-align-center-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
5:05 PM Changeset in webkit [117845] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-536-branch

Merged r117365.

5:00 PM Changeset in webkit [117844] by Lucas Forschler
  • 7 edits in branches/safari-536-branch

Merged r117326.

4:58 PM Changeset in webkit [117843] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117314.

4:56 PM Changeset in webkit [117842] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117313.

4:54 PM Changeset in webkit [117841] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 113292 - Layout Test http/tests/websocket/tests/hybi/workers/worker-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83173

Reviewed by David Levin.

Try to deflake the test by

  • decreasing the number of reloads in the test, and
  • changing the URL of WebSocket to silence random console messages.
  • http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html:

Reloading 100 times seemed too much, as Chromium debug bots frequently time out.

  • http/tests/websocket/tests/hybi/workers/resources/worker-reload.js:

Use a real URL to avoid random console messages.

4:54 PM Changeset in webkit [117840] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 113189 - [GTK] ASSERT in SocketStreamHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=83123

Reviewed by Martin Robinson.

Do not try to reuse a GOwnPtr as calling outPtr() causes an
assertion if the pointer is already valid. Also do not try to
close the IOStream if it was not created.

This patch fixes
http/tests/websocket/tests/hybi/workers/worker-reload.html but I
am leaving it skipped until webkit.org/b/83124 is fixed.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::connectedCallback):

4:54 PM Changeset in webkit [117839] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r117193.

4:53 PM Changeset in webkit [117838] by kov@webkit.org
  • 10 edits
    4 adds in releases/WebKitGTK/webkit-1.8

Merge 113138 - Crash in WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=82873

Reviewed by David Levin.

Source/WebCore:

WorkerThreadableWebSocketChannel::Bridge should properly handle the cases where inter-thread
callback is not called due to the termination of the worker run loop. Specifically, the bridge
should not send its "this" pointer to the main thread, because the bridge object may be freed
in the worker thread before the main thread starts to process.

Test: http/tests/websocket/tests/hybi/workers/worker-reload.html

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::peer):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCreateWebSocketChannel):
Renamed from setUseHixie76Protocol, as this funtion now also sets m_peer.
Sets m_syncMethodDone to true, because this function is called in the end of
synchronous wait of Bridge::initialize().
(WebCore::ThreadableWebSocketChannelClientWrapper::clearPeer):
(WebCore::ThreadableWebSocketChannelClientWrapper::useHixie76Protocol):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

Add WorkerThreadableWebSocketChannel::Peer which is initialized after the creation of
WebSocketChannel in the main thread.
(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
Don't do synchronous wait in the constructor, as a member function may be called
during the wait before the constructor finishes. The meat of the constructor has
moved to initialize() function.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::~Bridge):
(WorkerContextDidInitializeTask):
(WebCore::WorkerContextDidInitializeTask::create):
(WebCore::WorkerContextDidInitializeTask::~WorkerContextDidInitializeTask):
(WebCore::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
Don't pass "this" object to the main thread. Receive the pointer to the peer object
via ThreadableWebSocketChannelClientWrapper which is ThreadSafeRefCounted<>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
m_peer may be NULL, and we should not do anything in that case.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::derefThreadableWebSocketChannel):
(Bridge):

  • workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):

  • workers/WorkerLoaderProxy.h:

(WorkerLoaderProxy::postTaskForModeToWorkerContext):
Return bool to indicate whether postTask was successful or not. This is necessary
to avoid memory leaks of Peer object in Bridge::initialize() function.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):

  • workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

Source/WebKit/chromium:

Change the function signature of WorkerLoaderProxy::postTaskForModeToWorkerContext().

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):

  • src/WebSharedWorkerImpl.h:

(WebSharedWorkerImpl):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):

  • src/WebWorkerClientImpl.h:

(WebWorkerClientImpl):

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/worker-reload.js: Added.
  • http/tests/websocket/tests/hybi/workers/worker-reload-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/worker-reload.html: Added.
4:50 PM Changeset in webkit [117837] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117336.

4:48 PM Changeset in webkit [117836] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r117185.

4:47 PM Changeset in webkit [117835] by rakuco@webkit.org
  • 2 edits in trunk

[EFL] Unreviewed build fix when ENABLE_VIDEO is off and ENABLE_VIDEO_TRACK is not.

Do not enable VIDEO_TRACK if VIDEO itself has been disabled.

  • Source/cmake/OptionsEfl.cmake:
4:46 PM Changeset in webkit [117834] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r117201.

4:44 PM Changeset in webkit [117833] by leviw@chromium.org
  • 243 edits
    50 adds
    84 deletes in trunk/LayoutTests

Unreviewed test expectation updates following r117815.

  • platform/chromium-linux-x86/svg/zoom: Added.
  • platform/chromium-linux-x86/svg/zoom/page: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/svg/custom/bug45331-expected.png:
  • platform/chromium-mac-leopard/svg/custom/bug45331-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.png:
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png:
  • platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.png:
  • platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/rootmost-svg-xy-attrs-expected.png:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug106816-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug126742-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug139524-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug159108-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17130-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17130-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug3309-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug3309-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug33137-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5538-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8032-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/margins-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/test3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/test6-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/custom/bug45331-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/junk-data-expected.png:
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-expected.png:
  • platform/chromium-mac/svg/custom/path-bad-data-expected.png:
  • platform/chromium-mac/svg/custom/rootmost-svg-xy-attrs-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-mac/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/chromium-mac/svg/hixie/error/012-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-a-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug17130-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug17130-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug3309-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug3309-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug5538-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug8032-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/tables/mozilla/core/margins-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test3-expected.png:
  • platform/chromium-mac/tables/mozilla/other/test6-expected.png:
  • platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/chromium-win-vista/svg/custom/bug45331-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
  • platform/chromium-win-xp/svg/custom/bug45331-expected.txt: Added.
  • platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/custom/bug45331-expected.png:
  • platform/chromium-win/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/custom/junk-data-expected.png:
  • platform/chromium-win/svg/custom/missing-xlink-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/rootmost-svg-xy-attrs-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/chromium-win/svg/hixie/error/012-expected.png:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium/svg/as-image: Added.
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
  • platform/chromium/svg/custom/fractional-rects-expected.txt: Added.
  • platform/chromium/svg/custom/js-update-container-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug106816-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug126742-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug131020-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug159108-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug17130-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug3309-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug33137-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug5538-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1128-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug21518-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug22122-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1055-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug106816-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug126742-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug131020-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug139524-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug159108-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug17130-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug17130-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug3309-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug3309-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug33137-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug46480-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug46480-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug5538-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug7112-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug7112-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug8032-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/marvin/backgr_index-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/text: Removed.
  • platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • svg/zoom/page/zoom-background-images-expected.txt: Added.
  • svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • tables/mozilla/bugs/bug1055-1-expected.txt: Added.
  • tables/mozilla/bugs/bug106816-expected.txt: Added.
  • tables/mozilla/bugs/bug126742-expected.txt: Added.
  • tables/mozilla/bugs/bug131020-expected.txt: Added.
  • tables/mozilla/bugs/bug139524-2-expected.txt: Added.
  • tables/mozilla/bugs/bug159108-expected.txt: Added.
  • tables/mozilla/bugs/bug17130-1-expected.txt: Added.
  • tables/mozilla/bugs/bug17130-2-expected.txt: Added.
  • tables/mozilla/bugs/bug19061-1-expected.txt: Added.
  • tables/mozilla/bugs/bug19061-2-expected.txt: Added.
  • tables/mozilla/bugs/bug3309-1-expected.txt: Added.
  • tables/mozilla/bugs/bug3309-2-expected.txt: Added.
  • tables/mozilla/bugs/bug33137-expected.txt: Added.
  • tables/mozilla/bugs/bug46480-1-expected.txt: Added.
  • tables/mozilla/bugs/bug46480-2-expected.txt: Added.
  • tables/mozilla/bugs/bug5538-expected.txt: Added.
  • tables/mozilla/bugs/bug7112-1-expected.txt: Added.
  • tables/mozilla/bugs/bug7112-2-expected.txt: Added.
  • tables/mozilla/bugs/bug8032-1-expected.txt: Added.
  • tables/mozilla/marvin/backgr_index-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug1128-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug21518-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug22122-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt: Added.
  • tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt: Added.
4:42 PM Changeset in webkit [117832] by eae@chromium.org
  • 10 edits
    1 add in trunk/Source/WebCore

Move padding/margin/offset writing mode logic from RenderStyle to LengthBox
https://bugs.webkit.org/show_bug.cgi?id=86970

Reviewed by Eric Seidel.

Move writing mode and bidi logic for paddings, margins and offsets from
RenderStyle to LengthBox. This way the same logic can be used for all
three removing unnecessary code duplication.

No new tests, no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/LengthBox.cpp: Added.
  • platform/LengthBox.h:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
4:38 PM Changeset in webkit [117831] by Lucas Forschler
  • 3 edits in branches/safari-536-branch/Source/JavaScriptCore

Merged r117183.

4:32 PM Changeset in webkit [117830] by jsbell@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed gardening. Updating Skipped file names following bulk move in r117816.

  • platform/mac-lion/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
4:29 PM WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
4:26 PM Changeset in webkit [117829] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536-branch

Merged r116864.

4:18 PM Changeset in webkit [117828] by leviw@chromium.org
  • 49 edits
    49 adds
    57 deletes in trunk/LayoutTests

Unreviewed gardening. Updating Chromium-Windows expectations following r117815. Optimizebaselines also caused
a number of efl/gtk test expectations to be coalesced.

  • css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Added.
  • fast/compact/001-expected.txt: Added.
  • fast/css/acid2-expected.txt: Added.
  • fast/css/acid2-pixel-expected.txt: Added.
  • fast/css/font-size-negative-expected.txt: Added.
  • fast/css/line-height-negative-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • fast/flexbox/011-expected.txt: Added.
  • fast/inline-block/002-expected.txt: Added.
  • fast/inline/002-expected.txt: Added.
  • fast/lists/003-expected.txt: Added.
  • fast/lists/003-vertical-expected.txt: Added.
  • fast/overflow/007-expected.txt: Added.
  • fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • fast/repaint/transform-translate-expected.txt: Added.
  • fast/replaced/007-expected.txt: Added.
  • fast/table/035-expected.txt: Added.
  • fast/table/035-vertical-expected.txt: Added.
  • fast/table/table-display-types-strict-expected.txt: Added.
  • fast/table/tableInsideCaption-expected.txt: Added.
  • fast/transforms/transforms-with-zoom-expected.txt: Added.
  • platform/chromium-mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/chromium-win-vista/css1: Added.
  • platform/chromium-win-vista/css1/text_properties: Added.
  • platform/chromium-win-vista/css1/text_properties/line_height-expected.txt: Added.
  • platform/chromium-win-vista/fast/compact: Added.
  • platform/chromium-win-vista/fast/compact/001-expected.png: Added.
  • platform/chromium-win-vista/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-win-vista/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/chromium-win-vista/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-win-vista/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-win-vista/fast/inline-block/002-expected.png: Added.
  • platform/chromium-win-vista/fast/inline/002-expected.png: Added.
  • platform/chromium-win-vista/fast/table/tableInsideCaption-expected.png: Added.
  • platform/chromium-win-vista/fast/text/whitespace: Added.
  • platform/chromium-win-vista/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/acid2-expected.txt: Added.
  • platform/chromium-win-vista/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-win-xp/fast/compact: Added.
  • platform/chromium-win-xp/fast/compact/001-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/chromium-win-xp/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-win-xp/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/inline-block/002-expected.png: Added.
  • platform/chromium-win-xp/fast/inline/002-expected.png: Added.
  • platform/chromium-win-xp/fast/table/tableInsideCaption-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-win/css1/text_properties/line_height-expected.txt:
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.png:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/chromium-win/fast/compact/001-expected.png:
  • platform/chromium-win/fast/compact/001-expected.txt:
  • platform/chromium-win/fast/css/acid2-expected.txt:
  • platform/chromium-win/fast/css/acid2-pixel-expected.png:
  • platform/chromium-win/fast/css/acid2-pixel-expected.txt:
  • platform/chromium-win/fast/css/font-size-negative-expected.png:
  • platform/chromium-win/fast/css/font-size-negative-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/line-height-negative-expected.png:
  • platform/chromium-win/fast/css/line-height-negative-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium-win/fast/flexbox/011-expected.png:
  • platform/chromium-win/fast/flexbox/011-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/inline-block/002-expected.png:
  • platform/chromium-win/fast/inline-block/002-expected.txt:
  • platform/chromium-win/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win/fast/inline/002-expected.png:
  • platform/chromium-win/fast/inline/002-expected.txt:
  • platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
  • platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/overflow/007-expected.png:
  • platform/chromium-win/fast/overflow/007-expected.txt:
  • platform/chromium-win/fast/parser/entity-comment-in-style-expected.txt:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/chromium-win/fast/repaint/delete-into-nested-block-expected.png:
  • platform/chromium-win/fast/repaint/delete-into-nested-block-expected.txt:
  • platform/chromium-win/fast/repaint/transform-absolute-child-expected.png:
  • platform/chromium-win/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/chromium-win/fast/repaint/transform-translate-expected.png:
  • platform/chromium-win/fast/repaint/transform-translate-expected.txt:
  • platform/chromium-win/fast/replaced/007-expected.txt:
  • platform/chromium-win/fast/table/035-expected.png:
  • platform/chromium-win/fast/table/035-expected.txt:
  • platform/chromium-win/fast/table/035-vertical-expected.png:
  • platform/chromium-win/fast/table/035-vertical-expected.txt:
  • platform/chromium-win/fast/table/040-expected.txt:
  • platform/chromium-win/fast/table/040-vertical-expected.txt:
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-win/fast/table/table-display-types-strict-expected.txt:
  • platform/chromium-win/fast/table/tableInsideCaption-expected.png:
  • platform/chromium-win/fast/table/tableInsideCaption-expected.txt:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.txt:
  • platform/chromium-win/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-win/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/chromium-win/fast/transforms/transforms-with-zoom-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-expected.txt:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-win/http/tests/misc/acid2-pixel-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.png:
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium/fast/inline: Removed.
  • platform/chromium/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Removed.
  • platform/efl/css1/text_properties/line_height-expected.txt: Removed.
  • platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/efl/fast/compact/001-expected.txt: Removed.
  • platform/efl/fast/css/acid2-expected.txt: Removed.
  • platform/efl/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/efl/fast/css/font-size-negative-expected.txt: Removed.
  • platform/efl/fast/css/line-height-negative-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/efl/fast/flexbox/011-expected.txt: Removed.
  • platform/efl/fast/inline-block/002-expected.txt: Removed.
  • platform/efl/fast/inline/002-expected.txt: Removed.
  • platform/efl/fast/lists/003-expected.txt: Removed.
  • platform/efl/fast/lists/003-vertical-expected.txt: Removed.
  • platform/efl/fast/overflow/007-expected.txt: Removed.
  • platform/efl/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
  • platform/efl/fast/repaint/transform-translate-expected.txt: Removed.
  • platform/efl/fast/replaced/007-expected.txt: Removed.
  • platform/efl/fast/table/035-expected.txt: Removed.
  • platform/efl/fast/table/035-vertical-expected.txt: Removed.
  • platform/efl/fast/table/table-display-types-strict-expected.txt: Removed.
  • platform/efl/fast/table/tableInsideCaption-expected.txt: Removed.
  • platform/efl/fast/transforms/transforms-with-zoom-expected.txt: Removed.
  • platform/efl/http/tests/misc/acid2-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/fast/compact/001-expected.txt: Removed.
  • platform/gtk/fast/css/acid2-expected.txt: Removed.
  • platform/gtk/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/gtk/fast/css/font-size-negative-expected.txt: Removed.
  • platform/gtk/fast/css/line-height-negative-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
  • platform/gtk/fast/flexbox/011-expected.txt: Removed.
  • platform/gtk/fast/inline-block/002-expected.txt: Removed.
  • platform/gtk/fast/inline/002-expected.txt: Removed.
  • platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
  • platform/gtk/fast/lists/003-expected.txt: Removed.
  • platform/gtk/fast/lists/003-vertical-expected.txt: Removed.
  • platform/gtk/fast/overflow/007-expected.txt: Removed.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
  • platform/gtk/fast/repaint/transform-translate-expected.txt: Removed.
  • platform/gtk/fast/replaced/007-expected.txt: Removed.
  • platform/gtk/fast/table/035-expected.txt: Removed.
  • platform/gtk/fast/table/035-vertical-expected.txt: Removed.
  • platform/gtk/fast/table/table-display-types-strict-expected.txt: Removed.
  • platform/gtk/fast/table/tableInsideCaption-expected.txt: Removed.
  • platform/gtk/fast/transforms/transforms-with-zoom-expected.txt: Removed.
  • platform/mac/fast/transforms/transforms-with-zoom-expected.txt: Removed.
  • platform/qt/fast/css/font-size-negative-expected.txt: Removed.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
4:15 PM Changeset in webkit [117827] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2] Remove a useless #if on Tools/WebKitTestRunner/TestController.cpp
https://bugs.webkit.org/show_bug.cgi?id=87047

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-21
Reviewed by Alexis Menard.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

4:00 PM Changeset in webkit [117826] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Source/WebCore: Improving console error for CSP-blocked setTimeout and setInterval evaluation.
https://bugs.webkit.org/show_bug.cgi?id=86943

Patch by Mike West <mkwst@chromium.org> on 2012-05-21
Reviewed by Adam Barth.

If the inspector is open, a stack trace is generated before calling
ContentSecurityPolicy::allowEval, and passed through to
ContentSecurityPolicy::reportViolation for use in the console message.

Test: http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html

http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowEval):
(WebCore):
(WebCore::isAllowedByAllWithCallStack):
(WebCore::isAllowedByAllWithURL):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectToSource):

  • page/ContentSecurityPolicy.h:

(WebCore):

LayoutTests: Blocking setTimeout and setInterval evaluation with CSP should include a stack trace in the console warning.
https://bugs.webkit.org/show_bug.cgi?id=86943

Patch by Mike West <mkwst@chromium.org> on 2012-05-21
Reviewed by Adam Barth.

  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval-expected.txt: Added.
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html: Added.
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout-expected.txt: Added.
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html: Added.
3:57 PM Changeset in webkit [117825] by piman@chromium.org
  • 3 edits in trunk/Source

Don't force rendering in finishAllRendering
https://bugs.webkit.org/show_bug.cgi?id=86919

Reviewed by James Robinson.

After we acquire the texture layers on the main thread, we can't draw.
In particular if we destroyed the texture ids used previously by
TextureLayerChromium, drawing before a commit would cause a
bind-after-destroy.

Tested by CCLayerTreeHostTestFinishAllRendering.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

3:33 PM Changeset in webkit [117824] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed gardening. Updating expectations after r117815.

  • platform/chromium-linux-x86/fast/regions: Added.
  • platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
3:32 PM Changeset in webkit [117823] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Bytecode dumps should contain data about the state of get_by_id caches
https://bugs.webkit.org/show_bug.cgi?id=85246

Reviewed by Gavin Barraclough.

Merge r115694 from dfgopt.

Changed the DFG bytecode parser (and the code that calls it) to be able
to call codeBlock->dump() on the code blocks being parsed.

Changed bytecode dumping to be able to print the state of get_by_id
caches inline with the bytecode.

Removed the old StructureStubInfo dumping code, which no longer worked
right, and was incapable of telling us information about chain and list
accesses.

This change does not add dumping for put_by_id caches. We can add that
at a later time.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitStructures):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::jitCompile):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::parse):

  • dfg/DFGByteCodeParser.h:

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGOSRExitCompiler.cpp:
  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

  • runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

3:03 PM Changeset in webkit [117822] by oliver@apple.com
  • 1 edit
    8 adds in trunk/LayoutTests

Add new test results for mac

2:58 PM Changeset in webkit [117821] by eae@chromium.org
  • 1077 edits
    43 adds in trunk/LayoutTests

Unreviewed chromium linux and windows rebaselines for sub-pixel flag change commited as r117815.

  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
  • platform/chromium-linux/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-linux/css1/basic/inheritance-expected.png:
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/box_properties/width-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-linux/css1/font_properties/font-expected.txt:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/css1/font_properties/font_weight-expected.png:
  • platform/chromium-linux/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-linux/css1/text_properties/text_indent-expected.png:
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-linux/css1/units/percentage_units-expected.png:
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png:
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/css2.1/t040302-c61-phys-len-00-b-expected.png:
  • platform/chromium-linux/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
  • platform/chromium-linux/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-linux/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
  • platform/chromium-linux/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
  • platform/chromium-linux/css2.1/t1205-c565-list-pos-00-b-expected.png:
  • platform/chromium-linux/css2.1/t1506-c525-font-wt-00-b-expected.png:
  • platform/chromium-linux/css2.1/t1508-c527-font-09-b-expected.png:
  • platform/chromium-linux/css2.1/t1508-c527-font-09-b-expected.txt:
  • platform/chromium-linux/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-linux/css3/filters/huge-region-expected.png: Added.
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-32-expected.txt: Added.
  • platform/chromium-linux/editing/inserting/4959067-expected.txt: Added.
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/editing/selection/select-text-overflow-ellipsis-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/basic/001-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/basic/015-expected.png:
  • platform/chromium-linux/fast/block/basic/016-expected.png:
  • platform/chromium-linux/fast/block/basic/019-expected.png:
  • platform/chromium-linux/fast/block/float/002-expected.png:
  • platform/chromium-linux/fast/block/float/013-expected.png:
  • platform/chromium-linux/fast/block/float/avoiding-float-centered-expected.png:
  • platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/chromium-linux/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/100-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/block/positioning/047-expected.png:
  • platform/chromium-linux/fast/block/positioning/047-expected.txt:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-linux/fast/compact/001-expected.png:
  • platform/chromium-linux/fast/css-generated-content/011-expected.png:
  • platform/chromium-linux/fast/css-generated-content/013-expected.png:
  • platform/chromium-linux/fast/css-gene