Timeline
Jul 17, 2012:
- 11:50 PM Changeset in webkit [122922] by
-
- 4 edits in trunk/Source
Decimal constructor with 99999999999999999 loses last digit
https://bugs.webkit.org/show_bug.cgi?id=91579
Reviewed by Kent Tamura.
Source/WebCore:
This patch changes maximum coefficient value handling in Decimal::EncodedData
constructor not to lose the last digit. It was used ">=" operator for
comparison instead of ">" operator.
Tests: WebKit/chromium/tests/DecimalTest.cpp
- platform/Decimal.cpp:
(WebCore::Decimal::EncodedData::EncodedData): Replace ">=" to ">" for
not getting rid of the last digit for maximum coefficient value.
Source/WebKit/chromium:
This patch adds test cases for Decimal::EncodedData constructors for
testing edge cases in addition to common cases which they aren't
covered by other test cases.
- tests/DecimalTest.cpp:
(EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of
writing test cases for verifying components of Decimal::EncodedData.
(TEST_F): Added a new test entry DecimalTest.Constructor.
- 11:31 PM Changeset in webkit [122921] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Web Inspector: followup fix for r122920.
Add collected Loaders size to InspectorMemoryBlock
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
- 10:58 PM Changeset in webkit [122920] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: show loaders memory consumption on the memory chart.
https://bugs.webkit.org/show_bug.cgi?id=90686
Reviewed by Pavel Feldman.
Size of FrameLoader, DocumentLoader, ResourceLoader and their resources should be shown on the memory pie chart.
It is covered by existing WebInspector performance tests infrastructure.
- WebCore.exp.in:
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore):
(WebCore::MemoryClassInfo::addInstrumentedHashSet):
(WebCore::MemoryClassInfo::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedHashSet):
(WebCore::MemoryInstrumentation::addVector):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::domTreeInfo):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore):
- loader/DocumentLoader.h:
(WebCore):
(DocumentLoader):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
(WebCore):
- loader/FrameLoader.h:
(WebCore):
(FrameLoader):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
(WebCore):
- loader/ResourceLoader.h:
(WebCore):
(ResourceLoader):
- page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
(WebCore):
- page/Frame.h:
(WebCore):
(Frame):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
(WebCore):
- platform/SharedBuffer.h:
(WebCore):
(SharedBuffer):
- 9:42 PM Changeset in webkit [122919] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG 32-bit PutById transition stub passes the payload/tag arguments to a DFG operation in the wrong order
https://bugs.webkit.org/show_bug.cgi?id=91576
Reviewed by Gavin Barraclough.
- dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):
- 9:18 PM Changeset in webkit [122918] by
-
- 3 edits2 adds in trunk
Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/date/calendar-picker-type-change-onclick.html
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::defaultEventHandler):
It's possible that this function is called when the element is detached
from the document tree.
LayoutTests:
- fast/forms/date/calendar-picker-type-change-onclick-expected.txt: Added.
- fast/forms/date/calendar-picker-type-change-onclick.html: Added.
- 9:16 PM Changeset in webkit [122917] by
-
- 3 edits in trunk/Source/WebCore
Form state: Make a new class handling HashMap<FormElementKey, Deque<>>
https://bugs.webkit.org/show_bug.cgi?id=91480
Reviewed by Hajime Morita.
This is a preparation of Bug 91209, "Form state restore: Need to
identify a from by its content."
Make a new class which is responsible to handle "HashMap<FormElementKey,
Deque<FormControlState>, FormElementKeyHash, FormElementKeyHashTraits>."
Also, move the FormElementKey class declaration and related structs from
FormController.h to FormController.cpp because FormElementKey is used
only in FormController.cpp.
No new tests. Just a refactoring.
- html/FormController.cpp:
(WebCore::FormElementKey): Moeved from FormController.h.
(WebCore::FormElementKey::FormElementKey):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKey::~FormElementKey): ditto.
(WebCore::FormElementKey::operator=): ditto.
(WebCore::FormElementKey::ref): ditto.
(WebCore::FormElementKey::deref): ditto.
(WebCore::operator==): Moved from FormController.h
(FormElementKeyHash): ditto.
(WebCore::FormElementKeyHash::equal): ditto.
(WebCore::FormElementKeyHash::hash):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKeyHashTraits::constructDeletedValue):
Moved from FormController.h
(WebCore::FormElementKeyHashTraits::isDeletedValue): ditto.
(WebCore::SavedFormState): Added.
(WebCore::SavedFormState::isEmpty):
(WebCore::SavedFormState::SavedFormState): Added. The constructor.
(WebCore::SavedFormState::create): Added. A factory function.
(WebCore::SavedFormState::appendControlState):
Moved some code from FormController::setStateForNewFormElements.
(WebCore::SavedFormState::takeControlState):
Moved some code from FormController::takeStateForFormElement.
(WebCore::FormController::setStateForNewFormElements):
- Creates SavedFormState if needed.
- Uses SavedFormState::appendControlState.
(WebCore::FormController::takeStateForFormElement):
Uses SavedFormState.
- html/FormController.h:
(FormController):
- 9:09 PM Changeset in webkit [122916] by
-
- 2 edits in trunk/Source/WebKit/chromium
Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
https://bugs.webkit.org/show_bug.cgi?id=91572
Reviewed by Kent Tamura.
This patch introduces EXPECT_DECIMAL_STREQ macro to replace EXPECT_EQ
with String class for displaying text string rather than object dump
for ease of debugging test cases.
- tests/DecimalTest.cpp:
(DecimalTest::stepDown): Changed to return Decimal instead of String
to use EXPECT_DECIMAL_STREQ.
(DecimalTest::stepUp): ditto.
(TEST_F): Replaced EXPECT_EQ + String class to EXPECT_DECIMAL_STREQ.
- 9:05 PM Changeset in webkit [122915] by
-
- 5 edits2 adds in trunk
[Shadow DOM] Some distribution invalidation can drop necessary reattachment.
https://bugs.webkit.org/show_bug.cgi?id=88843
Reviewed by Dimitri Glazkov.
Source/WebCore:
Following scenario caused this problem:
- Inserting a Text node as a shadow child triggers invalidateDistribution(), which doen't reattach the shadow's host element.
- Then inserting a <content> element after that triggers another invalidateDistribution(), which should reattach its host because <content> can affect not only distribution of new nodes, but also existing distribution.
- Since the first invalidateDistribution() has marked the distribution as invalidated, the second invalidateDistribution() call returns early without any reattachment, even though it needs one.
This change adds InvalidationType parameter to invalidateDistribution(), which asks ElementShadow to
reattach the host regardless of its validity state. InsertionPoint::insertedInto() uses
this flag to ensure that its insertion always results a reattachment.
Test: fast/dom/shadow/content-after-style.html
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Passes InvalidationType.
(WebCore::ElementShadow::removeAllShadowRoots): Passes InvalidationType.
(WebCore::ElementShadow::invalidateDistribution): Added a InvalidationType parameter.
- dom/ElementShadow.h:
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto): Passes InvalidationType.
LayoutTests:
- fast/dom/shadow/content-after-style-expected.html: Added.
- fast/dom/shadow/content-after-style.html: Added.
- 7:45 PM Changeset in webkit [122914] by
-
- 6 edits in trunk/Tools
[Chromium-Android] Run ref tests together to avoid expensive driver restarts
https://bugs.webkit.org/show_bug.cgi?id=91533
Reviewed by Dirk Pranke.
Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
chromium-android uses another way because it can't support multiple drivers.
It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
a normal test in --no-pixel-tests mode). However restarting driver is expensive on
Android (several seconds each time). To reduce the cost, a command line option
'--shard-ref-tests' is added to group ref tests in dedicated shards.
The option is by default enabled on Android.
Will remove the option once DRT supports switching pixel test mode during one run.
(https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_by_directory):
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 6:26 PM Changeset in webkit [122913] by
-
- 3 edits in trunk/Tools
NRWT The time before server_process kills DRT should be variable
https://bugs.webkit.org/show_bug.cgi?id=91542
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-17
Reviewed by Dirk Pranke.
Added the ability to configure the amount of time
server_process waits before killing the DRT process
during the call to stop.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.variable.process_kill_time):
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.stop):
- 6:16 PM Changeset in webkit [122912] by
-
- 7 edits in trunk/Source/WebCore
Teach CodeGenerator to support for static, readonly, attributes
https://bugs.webkit.org/show_bug.cgi?id=88920
<rdar://problem/11650330>
Reviewed by Oliver Hunt.
Update the parser to be able to accept the static keyword for attribute. We will treat static attributes
like custom static functions. They call the implementing class directly, and pass in the ExecState as a script context.
- bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeGetterName): Factor out the construction of the attribute getter function name.
(GetAttributeSetterName): Factor out the construction of the attribute setter function name.
(GenerateHeader): Determine that a class has read-write properties only if there is a read-write attribute that
is not static.
(GenerateAttributesHashTable): Skip static attributes in the object hash table. They will be added to the constructor
hash table.
(GenerateImplementation): Look for static attributes to add to the constructor hash table. Make a call to the static
function in the class.
- bindings/scripts/IDLParser.pm:
(ParseInterface): Update the processing because of the regex change.
- bindings/scripts/IDLStructure.pm: Update the attribute regex.
- bindings/scripts/test/JS/JSTestObj.cpp: Update test results.
- bindings/scripts/test/JS/JSTestObj.h: Update test results.
- bindings/scripts/test/TestObj.idl: Add test cases.
- 6:12 PM Changeset in webkit [122911] by
-
- 8 edits4 moves in trunk/Source/WebCore
[Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
https://bugs.webkit.org/show_bug.cgi?id=91458
Reviewed by Tony Chang.
There are HarfbuzzFace class (for old-harfbuzz) and HarfBuzzFace (for harfbuzz-ng) class. The difference is too subtle. Make them more distinct.
No new tests. No changes in behavior.
- WebCore.gyp/WebCore.gyp: Rename HarfBuzzFace to HarfBuzzNGFace.
- WebCore.gypi: Ditto.
- platform/graphics/FontPlatformData.h: Ditto.
(FontPlatformData):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm: Ditto.
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.
(FontPlatformData):
- platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp.
(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp.
(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):
- platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.h.
(WebCore):
(HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::create):
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
- 6:08 PM Changeset in webkit [122910] by
-
- 3 edits in trunk/Source/WebCore
Record metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90534
Reviewed by Jian Li.
We are removing ArrayBuffer support in Blob constructor (in favor of
ArrayBufferView) but before doing that we should record its use relative to ArrayBufferView.
http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
No new tests as this has no functional changes.
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
- 6:07 PM Changeset in webkit [122909] by
-
- 13 edits in trunk
IndexedDB: Key generator state not maintained across connections
https://bugs.webkit.org/show_bug.cgi?id=91456
Reviewed by Tony Chang.
Source/WebCore:
Explicitly store key generator state for each object store in the backing store,
rather than deriving it from the maximum key in the data (which violates the spec
if data is deleted).
This change eliminates a (fragile) per-store cache of the value to simplify the
code. A cache could be re-introduced, requiring an "onbeforecommit" hook for
object stores, but it seems cleaner to save that for a follow-up patch.
Test: storage/indexeddb/key-generator.html
- Modules/indexeddb/IDBBackingStore.h: New APIs for getting/setting generator states.
(IDBBackingStore):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getObjectStores): Read generator state (but currently ignored).
(WebCore::IDBLevelDBBackingStore::createObjectStore): Write generator state.
(WebCore):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber): Update, optionally
checking to see if the new value is greater than the old. (If caller got the value via
getKeyGeneratorCurrentNumber it is safe to skip the check.)
- Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
- Modules/indexeddb/IDBLevelDBCoding.h:
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): Ditch the cache.
(WebCore::IDBObjectStoreBackendImpl::put): No need for abort task.
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Use the newfangled APIs below.
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
Source/WebKit/chromium:
Add stub method implementations to test class.
- tests/IDBFakeBackingStore.h:
LayoutTests:
Added key generator test case that spans database connections.
- storage/indexeddb/key-generator-expected.txt:
- storage/indexeddb/resources/key-generator.js:
(testAcrossConnections.request.onsuccess.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess):
(testAcrossConnections.doFirstWrite.request.onsuccess):
(testAcrossConnections.doFirstWrite):
(testAcrossConnections.closeAndReopen.request.onsuccess):
(testAcrossConnections.closeAndReopen):
(testAcrossConnections.doSecondWrite.request.onsuccess):
(testAcrossConnections.doSecondWrite.trans.oncomplete):
(testAcrossConnections.doSecondWrite):
- 5:59 PM Changeset in webkit [122908] by
-
- 2 edits in branches/chromium/1132
Merge 122212 - RTL calendar picker for <input type=date> is too narrow and clipped
https://bugs.webkit.org/show_bug.cgi?id=90864
Reviewed by Kentaro Hara.
.:
- ManualTests/forms/calendar-picker.html:
- Add isRTL:true for the arabic setting
- Reset the iframe size when the setting is changed.
Source/WebCore:
Tests: ManualTests/forms/calendar-picker.html
- Resources/calendarPicker.js:
(fixWindowSize):
Checks the left edge of elemenets in RTL.
(layout): Add dir=ltr for the manual test, which re-uses the document.
TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800003
- 5:58 PM Changeset in webkit [122907] by
-
- 2 edits in trunk/Tools
webkitdirs.pm should fallback to uname -m if arch is not present.
https://bugs.webkit.org/show_bug.cgi?id=91543
Reviewed by Martin Robinson.
It seems that coreutils is moving away from the 'arch' command. Archlinux
for example doesn't ship it anymore (coreutils 8.17). We can then fallback
to 'uname -m' to find out the architecture.
- Scripts/webkitdirs.pm:
(determineArchitecture):
- 5:49 PM Changeset in webkit [122906] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed chromium windows rebaseline for r122883.
- platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
- platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Added.
- platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Added.
- platform/chromium-win-xp/fast/inline/002-expected.png:
- 5:35 PM Changeset in webkit [122905] by
-
- 7 edits in trunk
IndexedDB: createIndex should throw INVALID_ACCESS_ERR instead of NOT_SUPPORTED_ERR
https://bugs.webkit.org/show_bug.cgi?id=91553
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-17
Reviewed by Tony Chang.
Source/WebCore:
Update createIndex to throw an INVALID_ACCESS_ERR
as per the IndexedDB spec.
No new tests: existing tests have been updated
- Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
- Modules/indexeddb/IDBDatabaseException.h:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
LayoutTests:
Update to match IndexedDB spec.
- storage/indexeddb/keypath-arrays-expected.txt:
- storage/indexeddb/resources/keypath-arrays.js:
(openSuccess.request.onsuccess):
(openSuccess):
- 5:32 PM Changeset in webkit [122904] by
-
- 5 edits in trunk/Tools
nrwt: rename printer.print_update to printer.write_update to match metered_stream
https://bugs.webkit.org/show_bug.cgi?id=91557
Reviewed by Ojan Vafai.
Now that all of the printing logic is in printer.py, I want the
public interface to printer to follow the meteredstream
interface where possible. renaming write_update() gets us close.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
(Manager._set_up_run):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
(Manager._clobber_old_results):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.write_update):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_write_update):
- 5:30 PM Changeset in webkit [122903] by
-
- 6 edits in trunk/LayoutTests
Remove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
https://bugs.webkit.org/show_bug.cgi?id=88230
Unreviewed update of test expecatations.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 5:26 PM Changeset in webkit [122902] by
-
- 3 edits in trunk/Tools
Fix a bug where optimize-baselines would incorrectly fail to optimize
https://bugs.webkit.org/show_bug.cgi?id=91551
Reviewed by Adam Barth.
In some cases, optimize-baseline would correctly optimize the results, but because
we weren't filtering the virtual ports out of _results_by_port_name, we thought
that we had failed to optimize.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
(BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
(BaselineOptimizer.optimize): Filter out virtual ports.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
(BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
(BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
(BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
(BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.
- 5:21 PM Changeset in webkit [122901] by
-
- 7 edits in trunk/Tools
[Chromium] Add --encode-binary command line option for DRT
https://bugs.webkit.org/show_bug.cgi?id=91532
Reviewed by Adam Barth.
When the option presents, DRT will encode binary output data in base64.
ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
binary data output.
This change is a refactoring to replace the original hard-coded code for Android.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestEventPrinter.cpp:
(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
(TestEventPrinter::handleImage):
(TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
- DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dump):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
(TestShell::setEncodeBinary):
- Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
(ChromiumAndroidPort.init):
- 5:16 PM Changeset in webkit [122900] by
-
- 3 edits1 delete in trunk/Source/WebCore
DragImageChromiumMac.cpp is never compiled and can be removed
https://bugs.webkit.org/show_bug.cgi?id=91545
Reviewed by Tony Chang.
This file would only be compiled on chromium-mac, but it's excluded
from that build. This is likely left over from the CG configuration.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/DragImageChromiumMac.cpp: Removed.
- 5:12 PM Changeset in webkit [122899] by
-
- 10 edits in trunk/LayoutTests
Unreviewed chromium lion/snowleopard rebaseline for r122883.
- platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
- platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/chromium-mac/fast/block/basic/014-expected.png:
- platform/chromium-mac/fast/inline/002-expected.png:
- platform/chromium-mac/fast/table/table-display-types-strict-expected.png:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- 5:03 PM Changeset in webkit [122898] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r122884.
http://trac.webkit.org/changeset/122884
https://bugs.webkit.org/show_bug.cgi?id=91408
Broke the chromium-win build.
- public/WebIDBMetadata.h:
(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):
- 4:39 PM Changeset in webkit [122897] by
-
- 3 edits in trunk/Tools
nrwt: move per-test result output into printing.py
https://bugs.webkit.org/show_bug.cgi?id=91465
Reviewed by Ojan Vafai.
This moves the last substantive logging/printing code from the
manager into printing.py. Subsequent patches in this thread can
largely focus on cleaning up printing.py and will leave the rest
of the code alone.
This patch also removes manager.update() and
manager.update_summary(), two routines that were no longer being
used or needed (they have been dead for a long time but I didn't
notice them until now).
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.results_directory):
(Manager._look_for_new_crash_logs):
(Manager._update_summary_with_result):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_finished_test):
- 4:27 PM Changeset in webkit [122896] by
-
- 4 edits2 adds in trunk
Assertion failure/crash on Windows when using a font in an SVG
element with an unresaonbly large font size
https://bugs.webkit.org/show_bug.cgi?id=91273
Radar: <rdar://problem/8355401>
Source/WebCore:
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-17
Reviewed by Tim Horton.
When using a font in an SVG element with an unreasonably large
font size in Windows, WebKit crashes. The problem has to do with
font sizes overflowing into negative values in the Windows specific code.
The fix is to cap the font sizes to something reasonable when the font style is getting processed.
The fix will apply to both CSS and SVG so that behaviour is consistent.
Test: svg/text/font-size-too-large-crash.svg
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):
This is where the font size capping now occurs. Caps size to 1000000.
Both CSS and SVG reach the font size capping code here.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Capping here removed, moved to StyleBuilder.cpp.
LayoutTests:
Patch by Roger Fong <roger_fong@apple.com> on 2012-07-17
Reviewed by Tim Horton.
Test to make sure that having an overly large font size won't crash on Windows.
- svg/text/font-size-too-large-crash-expected.txt: Added.
- svg/text/font-size-too-large-crash.svg: Added.
- 4:23 PM Changeset in webkit [122895] by
-
- 17 edits3 adds in trunk
Add parsing and style application for css3-images image-orientation
https://bugs.webkit.org/show_bug.cgi?id=89624
Patch by David Barr <davidbarr@chromium.org> on 2012-07-17
Reviewed by Tony Chang.
The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
Source/WebCore:
Test: fast/css/image-orientation/image-orientation.html
- css/CSSComputedStyleDeclaration.cpp: Add computed style for image-orientation.
(WebCore): Add CSSPropertyImageOrientation to computedProperties.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Map CSSPropertyImageOrientation using cast operator from PrimitiveValueMappings.
- css/CSSParser.cpp: Add parsing rule for image-orientation.
(WebCore::CSSParser::parseValue): Parse the value of CSSPropertyImageOrientation as an angle.
- css/CSSPrimitiveValueMappings.h: Add mappings between CSSPrimitiveValue and ImageOrientationEnum.
(WebCore): Add conditional include for ImageOrientation.h.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map the natural orientations to angles.
(WebCore::CSSPrimitiveValue::operator ImageOrientationEnum): Round angles away from zero to quarter turns and map to the natural orientations.
- css/CSSProperty.cpp: Add CSSPropertyImageOrientation.
(WebCore::CSSProperty::isInheritedProperty): Map CSSPropertyImageOrientation inherited.
- css/CSSPropertyNames.in: Add image-orientation.
- css/StyleBuilder.cpp: Add style application logic for CSSPropertyImageOrientation.
(WebCore::StyleBuilder::StyleBuilder): Map CSSPropertyImageOrientation to RenderStyle::imageOrientation with type ImageOrientationEnum.
- css/StyleResolver.cpp: Handle CSSPropertyImageOrientation.
(WebCore::StyleResolver::applyProperty): Expect CSSPropertyImageOrientation to be handled by StyleBuilder.
- rendering/style/RenderStyle.h: Add imageOrientation, setImageOrientation and initialImageOrientation.
- rendering/style/StyleRareInheritedData.cpp: Add m_imageOrientation.
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageOrientation to default and copy contructors.
(WebCore::StyleRareInheritedData::operator==): Include m_imageOrientation in comparison.
- rendering/style/StyleRareInheritedData.h: Add m_imageOrientation.
(StyleRareInheritedData): Add 4-bit field m_imageOrientation, mapping to ImageOrientationEnum.
LayoutTests:
- fast/css/image-orientation/image-orientation-expected.txt: Added.
- fast/css/image-orientation/image-orientation.html: Added.
- platform/chromium/TestExpectations: Skip tests until image-orientation implementation lands.
- platform/efl/TestExpectations: Skip tests until image-orientation implementation lands.
- platform/gtk/TestExpectations: Skip tests until image-orientation implementation lands.
- platform/mac/TestExpectations: Skip tests until image-orientation implementation lands.
- platform/qt/TestExpectations: Skip tests until image-orientation implementation lands.
- 4:20 PM Changeset in webkit [122894] by
-
- 6 edits in trunk/Tools
nrwt: move config-specific logging to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91450
Reviewed by Ojan Vafai.
More refactoring ... this moves the 'config' output to
printing.py.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._resize_shards):
(Manager._run_tests):
(Manager._upload_json_files):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.get_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_config):
(Printer.print_workers_and_shards):
(Printer._print_config):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_fallback_path_in_config):
(Testprinter.test_print_config):
- 4:20 PM Changeset in webkit [122893] by
-
- 2 edits in trunk/LayoutTests
Fix two mistakes I made when modifying TestExpectations.
Apparently the MAC modifier and the FAIL result don't do what I think they do.
- platform/mac/TestExpectations: Remove MAC and replace FAIL with IMAGE.
- 4:18 PM Changeset in webkit [122892] by
-
- 2 edits in trunk/Tools
nrwt: clean up logging when we're only running one chunk of the tests
https://bugs.webkit.org/show_bug.cgi?id=91447
Reviewed by Ojan Vafai.
Apparently we were creating a 'tests_run.txt' in the results
directory if we were only running one chunk of the tests; after
3+ years of hacking on this code, that was news to me, so I'm
guessing no one uses this. I'm removing this, and changing the
_print_expected calls to debug messages to simplify the
layering.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):
- 4:15 PM Changeset in webkit [122891] by
-
- 1 edit2 moves4 deletes in trunk/LayoutTests
Unreviewed, optimize baselines for fast/block/float/02[68].html .
- fast/block/float/026-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/026-expected.txt.
- fast/block/float/028-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/028-expected.txt.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Removed.
- platform/gtk/fast/block/float/026-expected.txt: Removed.
- platform/gtk/fast/block/float/028-expected.txt: Removed.
- 4:13 PM Changeset in webkit [122890] by
-
- 2 edits in trunk/LayoutTests
[Mac] REGRESSION (r122494): Running platform/mac/plugins/root-object-premature-delete-crash.html results in a crash
https://bugs.webkit.org/show_bug.cgi?id=91505
Skip this test so we don't see it in the results.
- platform/mac/Skipped:
- 4:12 PM Changeset in webkit [122889] by
-
- 2 edits in trunk/Tools
Fix regression in style checker introduced in r122868.
https://bugs.webkit.org/show_bug.cgi?id=91470
Unreviewed, build fix.
- Scripts/webkitpy/style/checkers/cpp.py:
(_FileState.init):
- 4:11 PM Changeset in webkit [122888] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] REGRESSION(r122768, r122771): They broke jquery/data.html and inspector/elements/edit-dom-actions.html
https://bugs.webkit.org/show_bug.cgi?id=91476
Reviewed by Mark Hahnenberg.
The 32-bit repatching code was not correctly adapted to the new world where there may not always
be an available scratch register. Fixed it by ensuring that the scratch register we select does
not overlap with the value tag.
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
- 4:08 PM Changeset in webkit [122887] by
-
- 4 edits in trunk/Tools
nrwt: move the bulk of the "expected" output to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91442
Reviewed by Ojan Vafai.
More printing-related refactoring. This moves all of the code
that prints the results we expect to get, but doesn't move a few
dangling printfs (those'll get hit in a later patch).
No functional changes; covered by existing tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.print_config):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_expected):
(Printer):
(Printer._print_expected_results_of_type):
(Printer._num_digits):
(Printer._print_expected):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_expected):
- 4:06 PM Changeset in webkit [122886] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r122215) - RenderObject::willRenderImage crashes on null view()
https://bugs.webkit.org/show_bug.cgi?id=91525
Reviewed by Julien Chaffraix.
Fix by doing an early out check. This is intended to fix the crash in
http://crbug.com/137161.
No new test, because unfortunately a layout test is ill-suited to
reproing this kind of Document creation/destruction bug.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
- 4:05 PM Changeset in webkit [122885] by
-
- 2 edits in trunk/LayoutTests
[Mac] REGRESSION (r122651): fast/text/descent-clip-in-scaled-page.html fails
https://bugs.webkit.org/show_bug.cgi?id=91552
- platform/mac/TestExpectations: Mark the test as expected to fail.
- 4:04 PM Changeset in webkit [122884] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=91408
Reviewed by Adam Barth.
This is in support of the new upgradeneeded versioning api.
intVersion will eventually replace the WebString version member.
- public/WebIDBMetadata.h:
(WebIDBMetadata): The spec uses unsigned long long for version
numbers but we use int64_t here so that we can use -1 as a sentinel.
It indicates that a database still uses a string version.
- 3:51 PM Changeset in webkit [122883] by
-
- 36 edits2 adds in trunk
vertical-align: middle causes overflow with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=91464
Reviewed by Eric Seidel.
Source/WebCore:
Using vertical-align: middle in combination with an overflow value other
than visible can cause the overflow height to be computed incorrectly.
Test: fast/sub-pixel/vertical-align-middle-overflow.html
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
Round verticalPosition after calculation instead of flooring the result
of the xHeight calculation. By flooring it the resulting value is in
effect rounded up which can cause the height of the box to grow by one.
By rounding the resulting value thevertical position is more accurate and
the off by one error is avoided.
LayoutTests:
Add new test for vertical-align: middle and adjust existing results to
reflect the improved alignment calculation.
- fast/sub-pixel/vertical-align-middle-overflow-expected.txt: Added.
- fast/sub-pixel/vertical-align-middle-overflow.html: Added.
- platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
- platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
- platform/chromium-linux/fast/inline/002-expected.png:
- platform/chromium-linux/fast/table/table-display-types-strict-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png:
- platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
- platform/chromium-mac-snowleopard/fast/inline/002-expected.png:
- platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/css1/text_properties/vertical_align-expected.txt:
- platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
- platform/chromium-mac/fast/block/basic/014-expected.txt:
- platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
- platform/chromium-win/fast/block/basic/014-expected.txt:
- platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
- platform/chromium-win/fast/inline/002-expected.txt:
- platform/chromium-win/fast/table/table-display-types-strict-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/fast/inline/002-expected.txt:
- platform/mac/fast/replaced/008-expected.png:
- platform/mac/fast/table/table-display-types-strict-expected.txt:
- 3:49 PM Changeset in webkit [122882] by
-
- 2 edits in branches/chromium/1180/Source/WebCore/svg
Merge 122278
BUG=136296
Review URL: https://chromiumcodereview.appspot.com/10778043
- 3:34 PM Changeset in webkit [122881] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/dom/Element.cpp
Merge 122188
BUG=135698
Review URL: https://chromiumcodereview.appspot.com/10783039
- 3:22 PM Changeset in webkit [122880] by
-
- 4 edits in trunk/LayoutTests
A couple of UI nits about the flagging feature in results.html
https://bugs.webkit.org/show_bug.cgi?id=86798
Reviewed by Dirk Pranke.
-Clicking the flag unflags it now
-There's a flag all link for each test list
-Make the flag list always show up at the bottom of the viewport
when there are flagged tests. This makes it both less annoying
and easier to understand what's going on when you flag a test.
This required wrapping all the content in a div so that we could
make the body be a flexbox.
- fast/harness/resources/results-test.js:
(runSingleRowTest):
- fast/harness/results.html:
- 3:16 PM Changeset in webkit [122879] by
-
- 234 edits in trunk/LayoutTests
[Qt] fast/forms tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91504
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-17
Reviewed by Alexis Menard.
Updated expected Qt results for most fast/forms layout tests, after testfonts changes made by bug 85203.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/qt-5.0/fast/forms/box-shadow-override-expected.png:
- platform/qt-5.0/fast/forms/box-shadow-override-expected.txt:
- platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
- platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
- platform/qt-5.0/fast/forms/input-disabled-color-expected.png:
- platform/qt-5.0/fast/forms/input-disabled-color-expected.txt:
- platform/qt-5.0/fast/forms/listbox-bidi-align-expected.txt:
- platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
- platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png:
- platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/qt-5.0/fast/forms/search-rtl-expected.png:
- platform/qt-5.0/fast/forms/search-rtl-expected.txt:
- platform/qt-5.0/fast/forms/select-background-none-expected.txt:
- platform/qt-5.0/fast/forms/select-baseline-expected.png:
- platform/qt-5.0/fast/forms/select-baseline-expected.txt:
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
- platform/qt-5.0/fast/forms/textarea-align-expected.png:
- platform/qt-5.0/fast/forms/textarea-align-expected.txt:
- platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.png:
- platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/qt/fast/forms/003-expected.txt:
- platform/qt/fast/forms/004-expected.txt:
- platform/qt/fast/forms/006-expected.txt:
- platform/qt/fast/forms/007-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label05-expected.txt:
- platform/qt/fast/forms/basic-inputs-expected.png:
- platform/qt/fast/forms/basic-inputs-expected.txt:
- platform/qt/fast/forms/basic-selects-expected.png:
- platform/qt/fast/forms/basic-selects-expected.txt:
- platform/qt/fast/forms/basic-textareas-quirks-expected.png:
- platform/qt/fast/forms/basic-textareas-quirks-expected.txt:
- platform/qt/fast/forms/blankbuttons-expected.png:
- platform/qt/fast/forms/blankbuttons-expected.txt:
- platform/qt/fast/forms/button-align-expected.png:
- platform/qt/fast/forms/button-align-expected.txt:
- platform/qt/fast/forms/button-cannot-be-nested-expected.png:
- platform/qt/fast/forms/button-cannot-be-nested-expected.txt:
- platform/qt/fast/forms/button-default-title-expected.txt:
- platform/qt/fast/forms/button-generated-content-expected.png:
- platform/qt/fast/forms/button-generated-content-expected.txt:
- platform/qt/fast/forms/button-inner-block-reuse-expected.png:
- platform/qt/fast/forms/button-inner-block-reuse-expected.txt:
- platform/qt/fast/forms/button-positioned-expected.png:
- platform/qt/fast/forms/button-positioned-expected.txt:
- platform/qt/fast/forms/button-sizes-expected.png:
- platform/qt/fast/forms/button-sizes-expected.txt:
- platform/qt/fast/forms/button-style-color-expected.png:
- platform/qt/fast/forms/button-style-color-expected.txt:
- platform/qt/fast/forms/button-submit-expected.txt:
- platform/qt/fast/forms/button-table-styles-expected.png:
- platform/qt/fast/forms/button-table-styles-expected.txt:
- platform/qt/fast/forms/button-text-transform-expected.png:
- platform/qt/fast/forms/button-text-transform-expected.txt:
- platform/qt/fast/forms/caret-rtl-expected.txt:
- platform/qt/fast/forms/control-clip-expected.txt:
- platform/qt/fast/forms/control-clip-overflow-expected.png:
- platform/qt/fast/forms/control-clip-overflow-expected.txt:
- platform/qt/fast/forms/control-restrict-line-height-expected.png:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/disabled-select-change-index-expected.png:
- platform/qt/fast/forms/disabled-select-change-index-expected.txt:
- platform/qt/fast/forms/encoding-test-expected.png:
- platform/qt/fast/forms/encoding-test-expected.txt:
- platform/qt/fast/forms/fieldset-align-expected.png:
- platform/qt/fast/forms/fieldset-align-expected.txt:
- platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
- platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- platform/qt/fast/forms/fieldset-with-float-expected.txt:
- platform/qt/fast/forms/file/file-input-direction-expected.png:
- platform/qt/fast/forms/file/file-input-direction-expected.txt:
- platform/qt/fast/forms/file/file-input-disabled-expected.png:
- platform/qt/fast/forms/file/file-input-disabled-expected.txt:
- platform/qt/fast/forms/float-before-fieldset-expected.png:
- platform/qt/fast/forms/float-before-fieldset-expected.txt:
- platform/qt/fast/forms/floating-textfield-relayout-expected.png:
- platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
- platform/qt/fast/forms/form-added-to-table-expected.txt:
- platform/qt/fast/forms/form-hides-table-expected.png:
- platform/qt/fast/forms/form-hides-table-expected.txt:
- platform/qt/fast/forms/form-in-malformed-markup-expected.txt:
- platform/qt/fast/forms/formmove-expected.txt:
- platform/qt/fast/forms/formmove2-expected.txt:
- platform/qt/fast/forms/formmove3-expected.png:
- platform/qt/fast/forms/formmove3-expected.txt:
- platform/qt/fast/forms/hidden-listbox-expected.txt:
- platform/qt/fast/forms/image-border-expected.txt:
- platform/qt/fast/forms/indeterminate-expected.txt:
- platform/qt/fast/forms/input-align-expected.png:
- platform/qt/fast/forms/input-align-expected.txt:
- platform/qt/fast/forms/input-align-image-expected.txt:
- platform/qt/fast/forms/input-appearance-bkcolor-expected.png:
- platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/qt/fast/forms/input-appearance-disabled-expected.png:
- platform/qt/fast/forms/input-appearance-disabled-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.png:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.png:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/qt/fast/forms/input-appearance-readonly-expected.png:
- platform/qt/fast/forms/input-appearance-readonly-expected.txt:
- platform/qt/fast/forms/input-appearance-selection-expected.png:
- platform/qt/fast/forms/input-appearance-selection-expected.txt:
- platform/qt/fast/forms/input-appearance-visibility-expected.png:
- platform/qt/fast/forms/input-appearance-visibility-expected.txt:
- platform/qt/fast/forms/input-baseline-expected.png:
- platform/qt/fast/forms/input-baseline-expected.txt:
- platform/qt/fast/forms/input-button-sizes-expected.png:
- platform/qt/fast/forms/input-button-sizes-expected.txt:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/qt/fast/forms/input-field-text-truncated-expected.png:
- platform/qt/fast/forms/input-field-text-truncated-expected.txt:
- platform/qt/fast/forms/input-first-letter-expected.txt:
- platform/qt/fast/forms/input-no-renderer-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/qt/fast/forms/input-readonly-dimmed-expected.png:
- platform/qt/fast/forms/input-readonly-dimmed-expected.txt:
- platform/qt/fast/forms/input-readonly-empty-expected.png:
- platform/qt/fast/forms/input-readonly-empty-expected.txt:
- platform/qt/fast/forms/input-spaces-expected.png:
- platform/qt/fast/forms/input-spaces-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.png:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-double-click-expected.png:
- platform/qt/fast/forms/input-text-double-click-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.png:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.png:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/input-text-word-wrap-expected.png:
- platform/qt/fast/forms/input-text-word-wrap-expected.txt:
- platform/qt/fast/forms/input-width-expected.png:
- platform/qt/fast/forms/input-width-expected.txt:
- platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
- platform/qt/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
- platform/qt/fast/forms/menulist-clip-expected.png:
- platform/qt/fast/forms/menulist-clip-expected.txt:
- platform/qt/fast/forms/menulist-deselect-update-expected.txt:
- platform/qt/fast/forms/menulist-no-overflow-expected.txt:
- platform/qt/fast/forms/menulist-option-wrap-expected.png:
- platform/qt/fast/forms/menulist-option-wrap-expected.txt:
- platform/qt/fast/forms/menulist-style-color-expected.png:
- platform/qt/fast/forms/menulist-style-color-expected.txt:
- platform/qt/fast/forms/minWidthPercent-expected.png:
- platform/qt/fast/forms/minWidthPercent-expected.txt:
- platform/qt/fast/forms/negativeLineHeight-expected.png:
- platform/qt/fast/forms/negativeLineHeight-expected.txt:
- platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
- platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
- platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
- platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
- platform/qt/fast/forms/option-index-expected.txt:
- platform/qt/fast/forms/option-script-expected.txt:
- platform/qt/fast/forms/option-strip-whitespace-expected.txt:
- platform/qt/fast/forms/option-text-clip-expected.txt:
- platform/qt/fast/forms/placeholder-position-expected.png:
- platform/qt/fast/forms/placeholder-position-expected.txt:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/qt/fast/forms/range/input-appearance-range-expected.png:
- platform/qt/fast/forms/range/input-appearance-range-expected.txt:
- platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png:
- platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
- platform/qt/fast/forms/range/slider-padding-expected.png:
- platform/qt/fast/forms/range/slider-padding-expected.txt:
- platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
- platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/qt/fast/forms/search-styled-expected.png:
- platform/qt/fast/forms/search-styled-expected.txt:
- platform/qt/fast/forms/search-vertical-alignment-expected.png:
- platform/qt/fast/forms/search-vertical-alignment-expected.txt:
- platform/qt/fast/forms/select-align-expected.txt:
- platform/qt/fast/forms/select-block-background-expected.txt:
- platform/qt/fast/forms/select-change-listbox-size-expected.txt:
- platform/qt/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/qt/fast/forms/select-change-popup-to-listbox-expected.txt:
- platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/qt/fast/forms/select-disabled-appearance-expected.txt:
- platform/qt/fast/forms/select-display-none-style-resolve-expected.txt:
- platform/qt/fast/forms/select-empty-option-height-expected.txt:
- platform/qt/fast/forms/select-initial-position-expected.txt:
- platform/qt/fast/forms/select-item-background-clip-expected.txt:
- platform/qt/fast/forms/select-list-box-with-height-expected.txt:
- platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.png:
- platform/qt/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
- platform/qt/fast/forms/select-overflow-scroll-expected.png:
- platform/qt/fast/forms/select-overflow-scroll-expected.txt:
- platform/qt/fast/forms/select-overflow-scroll-inherited-expected.png:
- platform/qt/fast/forms/select-overflow-scroll-inherited-expected.txt:
- platform/qt/fast/forms/select-selected-expected.txt:
- platform/qt/fast/forms/select-size-expected.txt:
- platform/qt/fast/forms/select-style-expected.txt:
- platform/qt/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/qt/fast/forms/targeted-frame-submission-expected.png:
- platform/qt/fast/forms/targeted-frame-submission-expected.txt:
- platform/qt/fast/forms/text-style-color-expected.png:
- platform/qt/fast/forms/text-style-color-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/qt/fast/forms/textarea-scrollbar-expected.png:
- platform/qt/fast/forms/textarea-scrollbar-expected.txt:
- platform/qt/fast/forms/textarea-scrolled-type-expected.png:
- platform/qt/fast/forms/textarea-scrolled-type-expected.txt:
- platform/qt/fast/forms/textfield-focus-ring-expected.png:
- platform/qt/fast/forms/textfield-focus-ring-expected.txt:
- platform/qt/fast/forms/textfield-outline-expected.png:
- platform/qt/fast/forms/textfield-outline-expected.txt:
- platform/qt/fast/forms/textfield-overflow-by-value-update-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.png:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- 3:08 PM Changeset in webkit [122878] by
-
- 14 edits in trunk/LayoutTests
[Qt] svg/transforms tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91501
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-17
Reviewed by Alexis Menard.
Updated expected Qt results for most svg/transforms layout tests, after testfonts changes made by bug 85203.
- platform/qt-5.0/Skipped:
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
- platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
- platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.txt:
- platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.png:
- platform/qt/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/qt/svg/transforms/svg-css-transforms-expected.png:
- platform/qt/svg/transforms/svg-css-transforms-expected.txt:
- 3:05 PM Changeset in webkit [122877] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 122293
BUG=135071
Review URL: https://chromiumcodereview.appspot.com/10704255
- 2:47 PM Changeset in webkit [122876] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove unnecessary clearWindow() calls and the method itself
https://bugs.webkit.org/show_bug.cgi?id=91540
RIM PR 174365
Reviewed by Adam Treat.
If we resume the backingstore right afterwards with
RenderAndBlit then that'll fill the whole visible area
with content, making a clearWindow() call unnecessary.
This call is a remnant from ages ago, and is well suited
to disappear into nothingness.
(There is still a clearWindow() call, with rect argument,
which we continue using. This commit only removes the
rect-less version.)
- Api/BackingStore.cpp:
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
- 2:43 PM Changeset in webkit [122875] by
-
- 5 edits in trunk/Source/WebCore
Move zero-length-subpaths from RenderSVGShape to RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=90716
Reviewed by Nikolas Zimmermann.
Previously zero-length-subpath code was present in RenderSVGShape but it is
only needed in RenderSVGPath. This patch moves the zero-length-subpath code
to RenderSVGPath.
In this change, we gain:
1) Ellipses, Circles, and Rects will no longer carry an empty Vector nor
checks for zero-length subpaths which (per the spec) they cannot have.
2) RenderSVGShape, the superclass of all shape rendering, has been
drastically simplified by removing 70 lines of code that only applies
to Path rendering. This generally aids in code understandability.
The patch is primarily a straightforward code move but useStrokeStyleToFill
needs further explanation:
Zero-length-subpaths are drawn using rectangular and circular paths which
are filled.
Previously in RenderSVGShape::fillAndStrokePath, strokePath was called for
the main path with ApplyToStrokeMode and then strokePath was called for
each zero-length-subpath with ApplyToFillMode.
ApplyToFillMode had the effect of setting the context's stroke style to
the fill style so zero-length-subpaths were "filled" with the stroke style.
After this patch, the context is only setup once (which is faster!) using
ApplyToStrokeMode so we manually set the stroke style to the fill style
using useStrokeStyleToFill.
No new tests, just a refactoring.
- rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGPath::calculateUpdatedStrokeBoundingBox):
(WebCore::useStrokeStyleToFill):
(WebCore::RenderSVGPath::strokeShape):
(WebCore::RenderSVGPath::shapeDependentStrokeContains):
(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::zeroLengthLinecapPath):
(WebCore::RenderSVGPath::zeroLengthSubpathRect):
(WebCore::RenderSVGPath::updateZeroLengthSubpaths):
- rendering/svg/RenderSVGPath.h:
(RenderSVGPath):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::strokeShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::fillAndStrokeShape):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::calculateStrokeBoundingBox):
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::hasPath):
(WebCore::RenderSVGShape::hasNonScalingStroke):
(RenderSVGShape):
(WebCore::RenderSVGShape::strokeBoundingBox):
- 2:33 PM Changeset in webkit [122874] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Mark media/media-continues-playing-after-replace-source.html as flaky.
- platform/chromium/TestExpectations:
- 1:56 PM Changeset in webkit [122873] by
-
- 6 edits2 adds in trunk
invalidateNodeListCachesInAncestors walks up ancestors even when an attribute that doesn't invalidate node lists changes
https://bugs.webkit.org/show_bug.cgi?id=91530
Reviewed by Ojan Vafai.
Source/WebCore:
The bug was caused by invalidateNodeListCachesInAncestors not calling Document::shouldInvalidateNodeListCaches with
attrName. Done that.
This chance revealed a bug in shouldInvalidateTypeOnAttributeChange that we weren't checking form attribute changes for
RadioNodeList and HTMLCollection, so fixed the bug.
Also renamed Document::clearNodeListCaches to invalidateNodeListCaches to match the name convention used elsewhere,
and added a new version of DynamicNodeListCacheBase::invalidateCache that takes attrName to reduce the code duplication.
Test: fast/forms/elements-invalidate-on-form-attribute-invalidation.html
- dom/Document.cpp:
(WebCore::Document::invalidateNodeListCaches):
- dom/Document.h:
(Document):
- dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange):
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListCachesInAncestors):
(WebCore::NodeListsNodeData::invalidateCaches):
LayoutTests:
Add a regression test for invalidating HTMLFormColletion on form attribute changes. This invalidation worked before
because we weren't properly exiting early in Node::invalidateNodeListCachesInAncestors and
Document::invalidateNodeListCaches invalidated all node lists regardless of the attribute type.
- fast/forms/elements-invalidate-on-form-attribute-invalidation-expected.txt: Added.
- fast/forms/elements-invalidate-on-form-attribute-invalidation.html: Added.
- 1:44 PM Changeset in webkit [122872] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG getBBox does not update bound after path data change
https://bugs.webkit.org/show_bug.cgi?id=82629
Reviewed by Dirk Schulze.
The bug appears to have been fixed - adding a test for it.
- svg/custom/path-bbox-update-expected.txt: Added.
- svg/custom/path-bbox-update.html: Added.
- 1:24 PM Changeset in webkit [122871] by
-
- 3 edits2 copies1 add in trunk/LayoutTests
[chromium] Unreviewed gardening. Add baselines after r122861.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/float/026-expected.txt.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/block/float/028-expected.txt.
- platform/chromium-mac/fast/block/float/026-expected.txt:
- platform/chromium-mac/fast/block/float/028-expected.txt:
- platform/chromium-mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
- 1:18 PM Changeset in webkit [122870] by
-
- 81 edits47 adds11 deletes in trunk/Source
Update ANGLE in WebKit
https://bugs.webkit.org/show_bug.cgi?id=89039
Reviewed by Dean Jackson and Mark Rowe.
Update ANGLE to r1170, with the following modifications:
(1) Use Bison 2.3 instead of Bison 2.4.2 to generate ExpressionParser.cpp and
glslang_tab.cpp. I had to modify ExpressionParser.y to make it compatible with Bison
2.3. The changes have been contributed back to ANGLE in r1224.
(2) Continue to recognize QNX as POSIX in ANGLE. This has been contributed back to ANGLE
in r1223.
(3) Rename ANGLE/src/compiler/preprocessor/new/Diagnostic.cpp to DiagnosticBase.cpp.
Rename ANGLE/src/compiler/preprocessor/new/DirectiveHandler.cpp to DirectiveHandlerBase.cpp.
With the introduction of ANGLE's new preprocessor, there were two files named Diagnostic.cpp
in ANGLE under different folders. This caused problems on the QT build when their object
files, both named Diagnostic.o, tried to go in the same folder. Renaming one of them to
DiagnosticBase.cpp avoids this conflict. The same situation occurred with
DirectiveHandler.cpp. I will work on contributing this change back to ANGLE for future
updates.
(4) Add the following lines to glslang.y and ExpressionParser.y:
#define YYENABLE_NLS 0
#define YYLTYPE_IS_TRIVIAL 1
Bison 2.3 doesn't first check that these macros are defined before reading their value,
which causes the QT build to fail.
We work around this issue in the same way in CSSGrammar.y.
I will work on contributing this change back to ANGLE.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj:
- include/GLES2/gl2ext.h:
- include/GLSLANG/ShaderLang.h:
- src/build_angle.xcodeproj/project.pbxproj:
- src/common/angleutils.h:
- src/common/debug.cpp:
(gl):
(gl::output):
(gl::trace):
(gl::perfActive):
(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):
(gl::ScopedPerfEventHelper::~ScopedPerfEventHelper):
- src/common/version.h:
- src/compiler/BuiltInFunctionEmulator.cpp:
(BuiltInFunctionEmulator::IdentifyFunction):
- src/compiler/BuiltInFunctionEmulator.h:
- src/compiler/Compiler.cpp:
(isWebGLBasedSpec):
(TCompiler::compile):
(TCompiler::rewriteCSSShader):
(TCompiler::enforceTimingRestrictions):
(TCompiler::enforceFragmentShaderTimingRestrictions):
(TCompiler::enforceVertexShaderTimingRestrictions):
- src/compiler/DetectDiscontinuity.cpp: Added.
(sh::DetectLoopDiscontinuity::traverse):
(sh):
(sh::DetectLoopDiscontinuity::visitBranch):
(sh::DetectLoopDiscontinuity::visitAggregate):
(sh::containsLoopDiscontinuity):
(sh::DetectGradientOperation::traverse):
(sh::DetectGradientOperation::visitUnary):
(sh::DetectGradientOperation::visitAggregate):
(sh::containsGradientOperation):
- src/compiler/DetectDiscontinuity.h: Added.
(sh):
(DetectLoopDiscontinuity):
(DetectGradientOperation):
- src/compiler/Diagnostics.cpp: Added.
(TDiagnostics::TDiagnostics):
(TDiagnostics::~TDiagnostics):
(TDiagnostics::writeInfo):
(TDiagnostics::writeDebug):
(TDiagnostics::print):
- src/compiler/Diagnostics.h: Added.
(TDiagnostics):
(TDiagnostics::infoSink):
- src/compiler/DirectiveHandler.cpp: Added.
(getBehavior):
(TDirectiveHandler::TDirectiveHandler):
(TDirectiveHandler::~TDirectiveHandler):
(TDirectiveHandler::handleError):
(TDirectiveHandler::handlePragma):
(TDirectiveHandler::handleExtension):
(TDirectiveHandler::handleVersion):
- src/compiler/DirectiveHandler.h: Added.
(TDirectiveHandler):
(TDirectiveHandler::pragma):
(TDirectiveHandler::extensionBehavior):
- src/compiler/ExtensionBehavior.h:
(getBehaviorString):
- src/compiler/Initialize.cpp:
(BuiltInConstants):
(TBuiltIns::initialize):
(IdentifyBuiltIns):
- src/compiler/InitializeParseContext.cpp: Added.
(InitializeParseContextIndex):
(FreeParseContextIndex):
(InitializeGlobalParseContext):
(FreeParseContext):
(GetGlobalParseContext):
- src/compiler/InitializeParseContext.h:
(TThreadParseContextRec):
- src/compiler/Intermediate.cpp:
(TIntermediate::addSelection):
- src/compiler/MapLongVariableNames.cpp:
- src/compiler/OutputHLSL.cpp:
(sh::str):
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::~OutputHLSL):
(sh::OutputHLSL::output):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitUnary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::traverseStatements):
(sh):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::decorateField):
- src/compiler/OutputHLSL.h:
(sh):
(OutputHLSL):
- src/compiler/ParseHelper.cpp:
(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::trace):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::constErrorCheck):
(TParseContext::integerErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::arraySetMaxSize):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::handleExtensionDirective):
(TParseContext::handlePragmaDirective):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::structNestingErrorCheck):
(PaParseStrings):
- src/compiler/ParseHelper.h:
(TParseContext::TParseContext):
(TParseContext):
(TParseContext::infoSink):
(TParseContext::extensionBehavior):
(TParseContext::pragma):
- src/compiler/PoolAlloc.cpp:
(TAllocation::checkGuardBlock):
- src/compiler/Pragma.h: Added.
(TPragma):
(TPragma::TPragma):
- src/compiler/RenameFunction.h: Added.
(RenameFunction):
(RenameFunction::RenameFunction):
(RenameFunction::visitAggregate):
- src/compiler/ShHandle.h:
(TCompiler):
- src/compiler/ShaderLang.cpp:
(getVariableInfo):
- src/compiler/SymbolTable.cpp:
(TType::buildMangledName):
- src/compiler/TranslatorHLSL.cpp:
- src/compiler/UnfoldSelect.cpp: Removed.
- src/compiler/UnfoldSelect.h: Removed.
- src/compiler/UnfoldShortCircuit.cpp: Added.
(sh::UnfoldShortCircuit::UnfoldShortCircuit):
(sh):
(sh::UnfoldShortCircuit::traverse):
(sh::UnfoldShortCircuit::visitBinary):
(sh::UnfoldShortCircuit::visitSelection):
(sh::UnfoldShortCircuit::visitLoop):
(sh::UnfoldShortCircuit::getNextTemporaryIndex):
- src/compiler/UnfoldShortCircuit.h: Added.
(sh):
(UnfoldShortCircuit):
- src/compiler/ValidateLimitations.cpp:
- src/compiler/debug.cpp:
- src/compiler/depgraph: Added.
- src/compiler/depgraph/DependencyGraph.cpp: Added.
(TDependencyGraph::TDependencyGraph):
(TDependencyGraph::~TDependencyGraph):
(TDependencyGraph::createArgument):
(TDependencyGraph::createFunctionCall):
(TDependencyGraph::getOrCreateSymbol):
(TDependencyGraph::createSelection):
(TDependencyGraph::createLoop):
(TDependencyGraph::createLogicalOp):
(TGraphLogicalOp::getOpString):
- src/compiler/depgraph/DependencyGraph.h: Added.
(TGraphNode):
(TGraphNode::TGraphNode):
(TGraphNode::~TGraphNode):
(TGraphParentNode):
(TGraphParentNode::TGraphParentNode):
(TGraphParentNode::~TGraphParentNode):
(TGraphParentNode::addDependentNode):
(TGraphArgument):
(TGraphArgument::TGraphArgument):
(TGraphArgument::~TGraphArgument):
(TGraphArgument::getIntermFunctionCall):
(TGraphArgument::getArgumentNumber):
(TGraphFunctionCall):
(TGraphFunctionCall::TGraphFunctionCall):
(TGraphFunctionCall::~TGraphFunctionCall):
(TGraphFunctionCall::getIntermFunctionCall):
(TGraphSymbol):
(TGraphSymbol::TGraphSymbol):
(TGraphSymbol::~TGraphSymbol):
(TGraphSymbol::getIntermSymbol):
(TGraphSelection):
(TGraphSelection::TGraphSelection):
(TGraphSelection::~TGraphSelection):
(TGraphSelection::getIntermSelection):
(TGraphLoop):
(TGraphLoop::TGraphLoop):
(TGraphLoop::~TGraphLoop):
(TGraphLoop::getIntermLoop):
(TGraphLogicalOp):
(TGraphLogicalOp::TGraphLogicalOp):
(TGraphLogicalOp::~TGraphLogicalOp):
(TGraphLogicalOp::getIntermLogicalOp):
(TDependencyGraph):
(TDependencyGraph::begin):
(TDependencyGraph::end):
(TDependencyGraph::beginSamplerSymbols):
(TDependencyGraph::endSamplerSymbols):
(TDependencyGraph::beginUserDefinedFunctionCalls):
(TDependencyGraph::endUserDefinedFunctionCalls):
(TDependencyGraphTraverser):
(TDependencyGraphTraverser::TDependencyGraphTraverser):
(TDependencyGraphTraverser::visitSymbol):
(TDependencyGraphTraverser::visitArgument):
(TDependencyGraphTraverser::visitFunctionCall):
(TDependencyGraphTraverser::visitSelection):
(TDependencyGraphTraverser::visitLoop):
(TDependencyGraphTraverser::visitLogicalOp):
(TDependencyGraphTraverser::getDepth):
(TDependencyGraphTraverser::incrementDepth):
(TDependencyGraphTraverser::decrementDepth):
(TDependencyGraphTraverser::clearVisited):
(TDependencyGraphTraverser::markVisited):
(TDependencyGraphTraverser::isVisited):
- src/compiler/depgraph/DependencyGraphBuilder.cpp: Added.
(TDependencyGraphBuilder::build):
(TDependencyGraphBuilder::visitAggregate):
(TDependencyGraphBuilder::visitFunctionDefinition):
(TDependencyGraphBuilder::visitFunctionCall):
(TDependencyGraphBuilder::visitAggregateChildren):
(TDependencyGraphBuilder::visitSymbol):
(TDependencyGraphBuilder::visitBinary):
(TDependencyGraphBuilder::visitAssignment):
(TDependencyGraphBuilder::visitLogicalOp):
(TDependencyGraphBuilder::visitBinaryChildren):
(TDependencyGraphBuilder::visitSelection):
(TDependencyGraphBuilder::visitLoop):
(TDependencyGraphBuilder::connectMultipleNodesToSingleNode):
- src/compiler/depgraph/DependencyGraphBuilder.h: Added.
(TDependencyGraphBuilder):
(TNodeSetStack):
(TDependencyGraphBuilder::TNodeSetStack::TNodeSetStack):
(TDependencyGraphBuilder::TNodeSetStack::~TNodeSetStack):
(TDependencyGraphBuilder::TNodeSetStack::getTopSet):
(TDependencyGraphBuilder::TNodeSetStack::pushSet):
(TDependencyGraphBuilder::TNodeSetStack::popSet):
(TDependencyGraphBuilder::TNodeSetStack::popSetIntoNext):
(TDependencyGraphBuilder::TNodeSetStack::insertIntoTopSet):
(TDependencyGraphBuilder::TNodeSetStack::clear):
(TNodeSetMaintainer):
(TDependencyGraphBuilder::TNodeSetMaintainer::TNodeSetMaintainer):
(TDependencyGraphBuilder::TNodeSetMaintainer::~TNodeSetMaintainer):
(TNodeSetPropagatingMaintainer):
(TDependencyGraphBuilder::TNodeSetPropagatingMaintainer::TNodeSetPropagatingMaintainer):
(TDependencyGraphBuilder::TNodeSetPropagatingMaintainer::~TNodeSetPropagatingMaintainer):
(TLeftmostSymbolMaintainer):
(TDependencyGraphBuilder::TLeftmostSymbolMaintainer::TLeftmostSymbolMaintainer):
(TDependencyGraphBuilder::TLeftmostSymbolMaintainer::~TLeftmostSymbolMaintainer):
(TDependencyGraphBuilder::TDependencyGraphBuilder):
(TDependencyGraphBuilder::build):
- src/compiler/depgraph/DependencyGraphOutput.cpp: Added.
(TDependencyGraphOutput::outputIndentation):
(TDependencyGraphOutput::visitArgument):
(TDependencyGraphOutput::visitFunctionCall):
(TDependencyGraphOutput::visitSymbol):
(TDependencyGraphOutput::visitSelection):
(TDependencyGraphOutput::visitLoop):
(TDependencyGraphOutput::visitLogicalOp):
(TDependencyGraphOutput::outputAllSpanningTrees):
- src/compiler/depgraph/DependencyGraphOutput.h: Added.
(TDependencyGraphOutput):
(TDependencyGraphOutput::TDependencyGraphOutput):
- src/compiler/depgraph/DependencyGraphTraverse.cpp: Added.
(TGraphNode::traverse):
(TGraphParentNode::traverse):
(TGraphArgument::traverse):
(TGraphFunctionCall::traverse):
(TGraphSymbol::traverse):
(TGraphSelection::traverse):
(TGraphLoop::traverse):
(TGraphLogicalOp::traverse):
- src/compiler/glslang.h:
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(yy_buffer_state):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(yyensure_buffer_stack):
(yy_scan_bytes):
(yyget_leng):
(string_input):
(yyerror):
(glslang_finalize):
(glslang_scan):
- src/compiler/glslang_tab.cpp:
- src/compiler/intermediate.h:
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::~TIntermAggregate):
(TIntermAggregate::isUserDefined):
(TIntermAggregate):
(TIntermTraverser::~TIntermTraverser):
- src/compiler/osinclude.h:
- src/compiler/preprocessor/atom.c:
(FindHashLoc):
(PrintAtomTable):
- src/compiler/preprocessor/cpp.c:
(CPPpragma):
(readCPPline):
(PredefineIntMacro):
(MacroExpand):
- src/compiler/preprocessor/cpp.h:
- src/compiler/preprocessor/memory.h:
- src/compiler/preprocessor/new: Added properties allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs, allow-tabs and allow-tabs.
- src/compiler/preprocessor/new/Context.cpp: Removed.
- src/compiler/preprocessor/new/Context.h: Removed.
- src/compiler/preprocessor/new/Diagnostics.h: Added.
(pp):
(Diagnostics):
- src/compiler/preprocessor/new/DiagnosticsBase.cpp: Added.
(pp):
(pp::Diagnostics::~Diagnostics):
(pp::Diagnostics::report):
(pp::Diagnostics::severity):
- src/compiler/preprocessor/new/DirectiveHandler.h: Added.
(pp):
(DirectiveHandler):
- src/compiler/preprocessor/new/DirectiveHandlerBase.cpp: Added.
(pp):
(pp::DirectiveHandler::~DirectiveHandler):
- src/compiler/preprocessor/new/DirectiveParser.cpp: Added.
(getDirective):
(isConditionalDirective):
(isEOD):
(skipUntilEOD):
(isMacroNameReserved):
(isMacroPredefined):
(pp):
(DefinedParser):
(pp::DefinedParser::DefinedParser):
(pp::DefinedParser::lex):
(pp::DirectiveParser::DirectiveParser):
(pp::DirectiveParser::lex):
(pp::DirectiveParser::parseDirective):
(pp::DirectiveParser::parseDefine):
(pp::DirectiveParser::parseUndef):
(pp::DirectiveParser::parseIf):
(pp::DirectiveParser::parseIfdef):
(pp::DirectiveParser::parseIfndef):
(pp::DirectiveParser::parseElse):
(pp::DirectiveParser::parseElif):
(pp::DirectiveParser::parseEndif):
(pp::DirectiveParser::parseError):
(pp::DirectiveParser::parsePragma):
(pp::DirectiveParser::parseExtension):
(pp::DirectiveParser::parseVersion):
(pp::DirectiveParser::parseLine):
(pp::DirectiveParser::skipping):
(pp::DirectiveParser::parseConditionalIf):
(pp::DirectiveParser::parseExpressionIf):
(pp::DirectiveParser::parseExpressionIfdef):
- src/compiler/preprocessor/new/DirectiveParser.h: Added.
(pp):
(DirectiveParser):
(ConditionalBlock):
(pp::DirectiveParser::ConditionalBlock::ConditionalBlock):
- src/compiler/preprocessor/new/ExpressionParser.cpp: Added.
(yysyntax_error):
(yylex):
(yyerror):
(pp):
(pp::ExpressionParser::ExpressionParser):
(pp::ExpressionParser::parse):
- src/compiler/preprocessor/new/ExpressionParser.h: Added.
(pp):
(ExpressionParser):
- src/compiler/preprocessor/new/ExpressionParser.y: Added.
- src/compiler/preprocessor/new/Input.cpp: Added property allow-tabs.
(pp::Input::Input):
(pp::Input::read):
- src/compiler/preprocessor/new/Input.h: Added property allow-tabs.
(pp):
(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):
(pp::Input::Location::Location):
(pp::Input::readLoc):
- src/compiler/preprocessor/new/Lexer.cpp: Added.
(pp):
(pp::Lexer::~Lexer):
- src/compiler/preprocessor/new/Lexer.h: Added.
(pp):
(Lexer):
- src/compiler/preprocessor/new/Macro.cpp: Added property allow-tabs.
(pp::Macro::equals):
- src/compiler/preprocessor/new/Macro.h: Added property allow-tabs.
(pp):
(pp::Macro::Macro):
(Macro):
- src/compiler/preprocessor/new/MacroExpander.cpp: Added.
(pp):
(TokenLexer):
(pp::TokenLexer::TokenLexer):
(pp::TokenLexer::lex):
(pp::MacroExpander::MacroExpander):
(pp::MacroExpander::~MacroExpander):
(pp::MacroExpander::lex):
(pp::MacroExpander::getToken):
(pp::MacroExpander::ungetToken):
(pp::MacroExpander::isNextTokenLeftParen):
(pp::MacroExpander::pushMacro):
(pp::MacroExpander::popMacro):
(pp::MacroExpander::expandMacro):
(pp::MacroExpander::collectMacroArgs):
(pp::MacroExpander::replaceMacroParams):
- src/compiler/preprocessor/new/MacroExpander.h: Added.
(pp):
(MacroExpander):
(MacroContext):
(pp::MacroExpander::MacroContext::MacroContext):
(pp::MacroExpander::MacroContext::empty):
(pp::MacroExpander::MacroContext::get):
(pp::MacroExpander::MacroContext::unget):
- src/compiler/preprocessor/new/Preprocessor.cpp: Added property allow-tabs.
(PreprocessorImpl):
(pp::PreprocessorImpl::PreprocessorImpl):
(pp):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::predefineMacro):
(pp::Preprocessor::lex):
- src/compiler/preprocessor/new/Preprocessor.h: Added property allow-tabs.
(pp):
(Preprocessor):
- src/compiler/preprocessor/new/SourceLocation.h: Added.
(pp):
(pp::SourceLocation::SourceLocation):
(SourceLocation):
(pp::SourceLocation::equals):
(pp::operator==):
(pp::operator!=):
- src/compiler/preprocessor/new/Token.cpp: Added property allow-tabs.
(pp::Token::reset):
(pp::Token::equals):
(pp::Token::setAtStartOfLine):
(pp::Token::setHasLeadingSpace):
(pp):
(pp::Token::setExpansionDisabled):
(pp::operator<<):
- src/compiler/preprocessor/new/Token.h: Added property allow-tabs.
(pp::Token::Token):
(Token):
(pp::Token::atStartOfLine):
(pp::Token::hasLeadingSpace):
(pp::Token::expansionDisabled):
(pp::operator==):
(pp):
(pp::operator!=):
- src/compiler/preprocessor/new/Tokenizer.cpp: Added.
(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(pp):
(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::~Tokenizer):
(pp::Tokenizer::init):
(pp::Tokenizer::setFileNumber):
(pp::Tokenizer::setLineNumber):
(pp::Tokenizer::lex):
(pp::Tokenizer::initScanner):
(pp::Tokenizer::destroyScanner):
- src/compiler/preprocessor/new/Tokenizer.h: Added.
(pp):
(Tokenizer):
(Context):
- src/compiler/preprocessor/new/Tokenizer.l: Added.
- src/compiler/preprocessor/new/generate_parser.sh: Added property allow-tabs.
- src/compiler/preprocessor/new/pp.l: Removed.
- src/compiler/preprocessor/new/pp.y: Removed.
- src/compiler/preprocessor/new/pp_lex.cpp: Removed.
- src/compiler/preprocessor/new/pp_tab.cpp: Removed.
- src/compiler/preprocessor/new/pp_tab.h: Removed.
- src/compiler/preprocessor/new/pp_utils.h: Added.
- src/compiler/preprocessor/new/preprocessor.vcproj: Added.
- src/compiler/preprocessor/new/stl_utils.h: Removed.
- src/compiler/preprocessor/new/token_type.h: Removed.
- src/compiler/preprocessor/preprocess.h:
- src/compiler/preprocessor/scanner.c:
(InitScannerInput):
- src/compiler/preprocessor/scanner.h:
- src/compiler/preprocessor/symbols.h:
- src/compiler/preprocessor/tokens.c:
(ReadToken):
(DumpTokenStream):
- src/compiler/preprocessor/tokens.h:
- src/compiler/timing: Added.
- src/compiler/timing/RestrictFragmentShaderTiming.cpp: Added.
(RestrictFragmentShaderTiming::RestrictFragmentShaderTiming):
(RestrictFragmentShaderTiming::enforceRestrictions):
(RestrictFragmentShaderTiming::validateUserDefinedFunctionCallUsage):
(RestrictFragmentShaderTiming::beginError):
(RestrictFragmentShaderTiming::isSamplingOp):
(RestrictFragmentShaderTiming::visitArgument):
(RestrictFragmentShaderTiming::visitSelection):
(RestrictFragmentShaderTiming::visitLoop):
(RestrictFragmentShaderTiming::visitLogicalOp):
- src/compiler/timing/RestrictFragmentShaderTiming.h: Added.
(RestrictFragmentShaderTiming):
(RestrictFragmentShaderTiming::numErrors):
- src/compiler/timing/RestrictVertexShaderTiming.cpp: Added.
(RestrictVertexShaderTiming::visitSymbol):
- src/compiler/timing/RestrictVertexShaderTiming.h: Added.
(RestrictVertexShaderTiming):
(RestrictVertexShaderTiming::RestrictVertexShaderTiming):
(RestrictVertexShaderTiming::enforceRestrictions):
(RestrictVertexShaderTiming::numErrors):
- src/libEGL/Display.cpp:
(egl):
(egl::Display::getDepthTextureSupport):
(egl::Display::getTexturePool):
- src/libEGL/Display.h:
(Display):
- src/libEGL/Surface.cpp:
(egl::Surface::Surface):
(egl::Surface::release):
(egl::Surface::resetSwapChain):
(egl::Surface::swapRect):
(egl):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):
- src/libEGL/Surface.h:
(Surface):
- src/libEGL/libEGL.cpp:
- src/libGLESv2/Context.cpp:
(gl::Context::makeCurrent):
(gl::Context::markDxUniformsDirty):
(gl):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::supportsDepthTextures):
(gl::Context::initExtensionString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::applyDeclaration):
- src/libGLESv2/Context.h:
(Context):
- src/libGLESv2/Framebuffer.cpp:
(gl::Framebuffer::~Framebuffer):
(gl):
(gl::Framebuffer::getNullColorbuffer):
(gl::Framebuffer::completeness):
- src/libGLESv2/Framebuffer.h:
(Framebuffer):
- src/libGLESv2/Program.cpp:
(gl):
(gl::AttributeBindings::AttributeBindings):
(gl::AttributeBindings::~AttributeBindings):
(gl::InfoLog::InfoLog):
(gl::InfoLog::~InfoLog):
(gl::InfoLog::getLength):
(gl::InfoLog::getLog):
(gl::InfoLog::appendSanitized):
(gl::InfoLog::append):
(gl::InfoLog::reset):
(gl::Program::Program):
(gl::Program::~Program):
(gl::Program::attachShader):
(gl::Program::detachShader):
(gl::Program::getAttachedShadersCount):
(gl::AttributeBindings::bindAttributeLocation):
(gl::Program::bindAttributeLocation):
(gl::Program::link):
(gl::AttributeBindings::getAttributeBinding):
(gl::Program::unlink):
(gl::Program::getProgramBinary):
(gl::Program::setProgramBinary):
(gl::Program::getInfoLogLength):
(gl::Program::getInfoLog):
(gl::Program::getActiveAttribute):
(gl::Program::getActiveAttributeCount):
(gl::Program::getActiveAttributeMaxLength):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::validate):
(gl::Program::isValidated):
- src/libGLESv2/Program.h:
(gl):
(AttributeBindings):
(InfoLog):
(Program):
- src/libGLESv2/ProgramBinary.cpp: Added.
(gl::str):
(gl):
(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::ProgramBinary::ProgramBinary):
(gl::ProgramBinary::~ProgramBinary):
(gl::ProgramBinary::getPixelShader):
(gl::ProgramBinary::getVertexShader):
(gl::ProgramBinary::getAttributeLocation):
(gl::ProgramBinary::getSemanticIndex):
(gl::ProgramBinary::getUsedSamplerRange):
(gl::ProgramBinary::getSamplerMapping):
(gl::ProgramBinary::getSamplerTextureType):
(gl::ProgramBinary::getUniformLocation):
(gl::ProgramBinary::setUniform1fv):
(gl::ProgramBinary::setUniform2fv):
(gl::ProgramBinary::setUniform3fv):
(gl::ProgramBinary::setUniform4fv):
(gl::transposeMatrix):
(gl::ProgramBinary::setUniformMatrix2fv):
(gl::ProgramBinary::setUniformMatrix3fv):
(gl::ProgramBinary::setUniformMatrix4fv):
(gl::ProgramBinary::setUniform1iv):
(gl::ProgramBinary::setUniform2iv):
(gl::ProgramBinary::setUniform3iv):
(gl::ProgramBinary::setUniform4iv):
(gl::ProgramBinary::getUniformfv):
(gl::ProgramBinary::getUniformiv):
(gl::ProgramBinary::dirtyAllUniforms):
(gl::ProgramBinary::applyUniforms):
(gl::ProgramBinary::compileToBinary):
(gl::ProgramBinary::packVaryings):
(gl::ProgramBinary::linkVaryings):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::ProgramBinary::linkUniforms):
(gl::ProgramBinary::defineUniform):
(gl::ProgramBinary::createUniform):
(gl::ProgramBinary::decorateAttribute):
(gl::ProgramBinary::undecorateUniform):
(gl::ProgramBinary::applyUniformnbv):
(gl::ProgramBinary::applyUniformnfv):
(gl::ProgramBinary::applyUniform1iv):
(gl::ProgramBinary::applyUniform2iv):
(gl::ProgramBinary::applyUniform3iv):
(gl::ProgramBinary::applyUniform4iv):
(gl::ProgramBinary::applyUniformniv):
(gl::ProgramBinary::isValidated):
(gl::ProgramBinary::getActiveAttribute):
(gl::ProgramBinary::getActiveAttributeCount):
(gl::ProgramBinary::getActiveAttributeMaxLength):
(gl::ProgramBinary::getActiveUniform):
(gl::ProgramBinary::getActiveUniformCount):
(gl::ProgramBinary::getActiveUniformMaxLength):
(gl::ProgramBinary::validate):
(gl::ProgramBinary::validateSamplers):
(gl::ProgramBinary::getDxDepthRangeLocation):
(gl::ProgramBinary::getDxDepthLocation):
(gl::ProgramBinary::getDxCoordLocation):
(gl::ProgramBinary::getDxHalfPixelSizeLocation):
(gl::ProgramBinary::getDxFrontCCWLocation):
(gl::ProgramBinary::getDxPointsOrLinesLocation):
- src/libGLESv2/ProgramBinary.h: Added.
(gl):
(Uniform):
(gl::Uniform::RegisterInfo::RegisterInfo):
(RegisterInfo):
(gl::Uniform::RegisterInfo::set):
(UniformLocation):
(ProgramBinary):
(Sampler):
- src/libGLESv2/Renderbuffer.cpp:
(gl):
(gl::RenderbufferTexture2D::RenderbufferTexture2D):
(gl::RenderbufferTexture2D::~RenderbufferTexture2D):
(gl::RenderbufferTexture2D::addProxyRef):
(gl::RenderbufferTexture2D::releaseProxy):
(gl::RenderbufferTexture2D::getRenderTarget):
(gl::RenderbufferTexture2D::getDepthStencil):
(gl::RenderbufferTexture2D::getWidth):
(gl::RenderbufferTexture2D::getHeight):
(gl::RenderbufferTexture2D::getInternalFormat):
(gl::RenderbufferTexture2D::getD3DFormat):
(gl::RenderbufferTexture2D::getSamples):
(gl::RenderbufferTexture2D::getSerial):
(gl::RenderbufferTextureCubeMap::RenderbufferTextureCubeMap):
(gl::RenderbufferTextureCubeMap::~RenderbufferTextureCubeMap):
(gl::RenderbufferTextureCubeMap::addProxyRef):
(gl::RenderbufferTextureCubeMap::releaseProxy):
(gl::RenderbufferTextureCubeMap::getRenderTarget):
(gl::RenderbufferTextureCubeMap::getDepthStencil):
(gl::RenderbufferTextureCubeMap::getWidth):
(gl::RenderbufferTextureCubeMap::getHeight):
(gl::RenderbufferTextureCubeMap::getInternalFormat):
(gl::RenderbufferTextureCubeMap::getD3DFormat):
(gl::RenderbufferTextureCubeMap::getSamples):
(gl::RenderbufferTextureCubeMap::getSerial):
(gl::DepthStencilbuffer::getDepthStencil):
- src/libGLESv2/Renderbuffer.h:
(gl):
(RenderbufferTexture2D):
(RenderbufferTextureCubeMap):
- src/libGLESv2/Shader.cpp:
(gl::Shader::getInfoLog):
(gl::Shader::getSourceImpl):
- src/libGLESv2/Shader.h:
(Shader):
(VertexShader):
- src/libGLESv2/Texture.cpp:
(gl::ConvertTextureFormatType):
(gl::IsTextureFormatRenderable):
(gl::GetTextureUsage):
(gl):
(gl::Image::createSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaDataSSE2):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::getUsage):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::TextureStorage2D::TextureStorage2D):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getD3DFormat):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isCompressed):
(gl::Texture2D::isDepth):
(gl::Texture2D::createTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getDepthStencil):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getD3DFormat):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCompressed):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::getRenderbuffer):
- src/libGLESv2/Texture.h:
(Image):
(TextureStorage):
(Texture):
(TextureStorage2D):
(Texture2D):
(TextureStorageCubeMap):
(TextureCubeMap):
- src/libGLESv2/VertexDataManager.cpp:
(gl::VertexDataManager::prepareVertexData):
- src/libGLESv2/libGLESv2.cpp:
(checkTextureFormatType):
(validateSubImageParams2D):
(validateSubImageParamsCube):
- src/libGLESv2/libGLESv2.vcproj:
- src/libGLESv2/mathutil.h:
(gl):
- src/libGLESv2/utilities.cpp:
(gl::IsDepthTexture):
(gl):
(gl::ComputePixelSize):
(gl::ExtractFormat):
(gl::ExtractType):
(es2dx::ConvertCubeFace):
(es2dx::ConvertRenderbufferFormat):
(dx2es::GetStencilSize):
(dx2es::GetDepthSize):
(dx2es::IsDepthTextureFormat):
(dx2es):
(dx2es::IsStencilTextureFormat):
(dx2es::ConvertDepthStencilFormat):
- src/libGLESv2/utilities.h:
(gl):
(dx2es):
Source/WebCore:
No new tests. No change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- 12:47 PM Changeset in webkit [122869] by
-
- 4 edits in trunk/Source
Versioning.
- 12:40 PM Changeset in webkit [122868] by
-
- 20 edits in trunk
[EFL] Replace 0 by NULL in public headers documentation
https://bugs.webkit.org/show_bug.cgi?id=91470
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-17
Reviewed by Dirk Pranke.
Source/WebKit/efl:
Use NULL instead of 0 for pointer types in public
C headers.
- ewk/ewk_contextmenu.h:
- ewk/ewk_cookies.h:
- ewk/ewk_frame.h:
- ewk/ewk_intent.h:
- ewk/ewk_intent_request.h:
- ewk/ewk_network.h:
- ewk/ewk_security_origin.h:
- ewk/ewk_settings.h:
- ewk/ewk_view.h:
- ewk/ewk_window_features.h:
Source/WebKit2:
Use NULL instead of 0 for pointer types in public
C headers.
- UIProcess/API/efl/ewk_intent.h:
- UIProcess/API/efl/ewk_intent_service.h:
- UIProcess/API/efl/ewk_url_request.h:
- UIProcess/API/efl/ewk_url_response.h:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_web_resource.h:
Tools:
Fix style checking to properly detect C headers as C
files. Without this change, the style script would
complain if we use NULL (instead of 0 / null) in C
headers.
- Scripts/webkitpy/style/checkers/cpp.py:
(_FileState.init):
(_FileState.is_c):
(_FileState.is_c_or_objective_c):
- 12:17 PM Changeset in webkit [122867] by
-
- 2 edits in trunk/Source/WebCore
Crash in SVGStopElement::stopColorIncludingOpacity
https://bugs.webkit.org/show_bug.cgi?id=90814
Reviewed by Dirk Schulze.
No new tests as there should be no change in functionality.
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::stopColorIncludingOpacity): Added a check for null
renderer and style. It is hard to see how this is happening because
the code is only invoked if the parent gradient has a renderer, and it seems
the stop element should always have a renderer when the parent has a renderer.
Still, it obviously can happen and does so frequently enough to generate multiple
Chromium crash reports per day. The fix is marked with a FIXME, as we expect to
remove this code entirely soon.
- 12:01 PM Changeset in webkit [122866] by
-
- 6 edits in trunk/Tools
[chromium] remove --test-shell support from DRT
https://bugs.webkit.org/show_bug.cgi?id=86927
Reviewed by Adam Barth.
Now no one use --test-shell. All of us use the standard DRT mode.
- DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)
(runTest):
(main):
- DumpRenderTree/chromium/TestEventPrinter.cpp:
(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::~TestEventPrinter):
(TestEventPrinter::handleTestHeader):
(TestEventPrinter::handleTimedOut):
(TestEventPrinter::handleTextHeader):
(TestEventPrinter::handleTextFooter):
(TestEventPrinter::handleAudioHeader):
(TestEventPrinter::handleAudioFooter):
(TestEventPrinter::handleImage): Removed the unused filename parameter.
(TestEventPrinter::handleTestFooter):
- DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter): Made it a concrete class because we have only one implementation.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dumpImage):
- DumpRenderTree/chromium/TestShell.h:
(TestParams): Removed pixelFileName field.
(TestShell):
- 11:57 AM EFLWebKitCodingStyle edited by
- (diff)
- 11:50 AM Changeset in webkit [122865] by
-
- 2 edits4 copies in branches/chromium/1180
Merge 122224 - Input type=range issue with events not being raised when value set in js
https://bugs.webkit.org/show_bug.cgi?id=84674
Source/WebCore:
Fix dispatching of change and click events for the input slider.
Prior to the fix, change events were not fired if the new value
matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb
element was repositioned under the cursor on mouse down.
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.
Tests: fast/events/click-range-slider.html
fast/events/onchange-range-slider.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
LayoutTests:
Ensure that click and change events are properly triggered for range
sliders. Prior to the fix, change events were not fired if the new
value matched the value at last change notification based on expected
behavior for text fields. Clicks were not fired if the thumb element
was positioned under the cursor on mouse down.
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-10
Reviewed by Kent Tamura.
- fast/events/click-range-slider-expected.txt: Added.
- fast/events/click-range-slider.html: Added.
- fast/events/onchange-range-slider-expected.txt: Added.
- fast/events/onchange-range-slider.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10783036
- 11:44 AM Changeset in webkit [122864] by
-
- 4 edits in trunk/LayoutTests
results.html should handle flaky tests differently
https://bugs.webkit.org/show_bug.cgi?id=90892
Reviewed by Dirk Pranke.
-Put tests that failed both runs into the main failures table.
-Put flaky passes below the list of timeout tests.
- fast/harness/resources/results-test.js:
- fast/harness/results-expected.txt:
- fast/harness/results.html:
- 11:42 AM Changeset in webkit [122863] by
-
- 4 edits in trunk/LayoutTests
results.html doesn't hide the right data when not showing expected failures
https://bugs.webkit.org/show_bug.cgi?id=90889
Reviewed by Dirk Pranke.
-Properly hide test lists that have no unexpected items.
-Show the correct counts of tests in each test list when only showing unexpected.
-Always show tests with stderr output.
-Put tests with expected crash/timeout in the crash/timeout lists.
- fast/harness/resources/results-test.js:
- fast/harness/results.html:
- 11:27 AM Changeset in webkit [122862] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, remove timeout lines for tests on snowleopard that no longer apply.
- platform/chromium/TestExpectations:
- 11:22 AM Changeset in webkit [122861] by
-
- 9 edits2 adds in trunk
Incorrect offset used for scrollWidth/Height calculation
https://bugs.webkit.org/show_bug.cgi?id=91461
Reviewed by Eric Seidel.
Source/WebCore:
Due to a different offset being used to calculate the scrollWidth/Height
and pixelSnappedClientWidth/Height the scroll value can be off by one in
same cases. This can causes scrollbars to appear even when there is no
overflow.
Test: fast/sub-pixel/block-with-margin-overflow.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
Change location offset passed to snapSizeToPixel to include x() to match
offset used by pixelSnappedClientWidth.
(WebCore::RenderBox::scrollHeight):
Change location offset passed to snapSizeToPixel to include y() to match
offset used by pixelSnappedClientHeight.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Change calculation to use pixelSnappedClientWidth/Height as it is
subtracted from the pixel snapped scrollWidth/Height values.
(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Change RenderLayer versions of scrollWidth/Height to include x()/y() as
per the RenderBox versions.
LayoutTests:
Add new test ensuring that a block that shouldn't have overflow doesn't
have scrollbars.
- fast/sub-pixel/block-with-margin-overflow-expected.html: Added.
- fast/sub-pixel/block-with-margin-overflow.html: Added.
- platform/chromium-win/fast/block/float/026-expected.txt:
- platform/chromium-win/fast/block/float/028-expected.txt:
- platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
Update test expectations that incorrectly had overflow.
- 11:15 AM Changeset in webkit [122860] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. Remove duplicate lines added in r122857.
- platform/chromium/TestExpectations:
- 11:11 AM Changeset in webkit [122859] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, stop marking all editing tests as slow.
The cause for the flakiness was determined to be hardware related.
- platform/chromium/TestExpectations:
- 11:09 AM Changeset in webkit [122858] by
-
- 2 edits in trunk/LayoutTests
[Mac] REGRESSION (r122494): Running platform/mac/plugins/root-object-premature-delete-crash.html results in a crash
https://bugs.webkit.org/show_bug.cgi?id=91505
Unreviewed.
- platform/mac/TestExpectations: Mark the test as expected to crash.
- 11:07 AM Changeset in webkit [122857] by
-
- 27 edits4 copies1 add4 deletes in trunk/LayoutTests
[chromium] Unreviewed gardening. These tests are in chromium's test_expectations.txt and can be rebaselined (skia change in r4600).
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
- platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Removed.
- platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt:
- platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Removed.
- platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt:
- platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.txt:
- platform/chromium-linux/svg/hixie/perf/002-expected.png:
- platform/chromium-linux/svg/hixie/perf/002-expected.txt:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/hixie/perf/001-expected.txt.
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/hixie/perf/002-expected.txt.
- platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
- platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac/svg/hixie/perf/001-expected.png:
- platform/chromium-mac/svg/hixie/perf/001-expected.txt:
- platform/chromium-mac/svg/hixie/perf/002-expected.png:
- platform/chromium-mac/svg/hixie/perf/002-expected.txt:
- platform/chromium-win-xp/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/hixie/perf/001-expected.txt.
- platform/chromium-win-xp/svg/hixie/perf/002-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/hixie/perf/002-expected.txt.
- platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
- platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.txt:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.txt:
- platform/chromium/TestExpectations:
- 11:01 AM Changeset in webkit [122856] by
-
- 1 copy in tags/Safari-537.1
New Tag.
- 10:42 AM Changeset in webkit [122855] by
-
- 3 edits in trunk/Tools
remove ChromiumDriver from NRWT
https://bugs.webkit.org/show_bug.cgi?id=88478
Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.
(ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- 10:40 AM Changeset in webkit [122854] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
Merge 122791 - [chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438
Reviewed by Kenneth Russell.
r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.
This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10704248
- 10:35 AM Changeset in webkit [122853] by
-
- 4 edits in branches/chromium/1180
Merge 122552 - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched
https://bugs.webkit.org/show_bug.cgi?id=91197
Reviewed by Kent Tamura.
Source/WebCore:
This patch fixes implementation of Decimal::ceiling() and floor().
They return wrong value for small fractional numbers.
The bug is occurred when:
- Step-able input type, e.g. number, date, datetime, and so on.
- Current value is step mismatched
- Current value is smaller than step
- Step up/down by spin button
because spin button up/down actions are implemented in InputType::setpUpFromRenderer
which calls Decimal::ceiling() and floor() for step mismatched case.
Tests: fast/forms/number/number-stepup-stepdown-from-renderer.html: Added test cases
WebKit/chromium/tests/DecimalTest.cpp: Added test cases
- platform/Decimal.cpp:
(WebCore::Decimal::ceiling): Changed to return 1 for positive small fractional number.
(WebCore::Decimal::floor): Changed to return -1 for negative small fractional number.
Source/WebKit/chromium:
This patch adds test cases for Decimal::ceiling() and floor() of
positive/negative small fractional numbers.
- tests/DecimalTest.cpp:
(TEST_F):
LayoutTests:
This patch adds new test cases.
- fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Updated for new test cases.
- fast/forms/number/number-stepup-stepdown-from-renderer.html: Added new test cases.
TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10786036
- 10:32 AM Changeset in webkit [122852] by
-
- 2 edits in trunk/Tools
Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 10:29 AM Changeset in webkit [122851] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 10:19 AM Changeset in webkit [122850] by
-
- 5 edits in trunk/Tools
Unreviewed, rolling out r122828.
http://trac.webkit.org/changeset/122828
https://bugs.webkit.org/show_bug.cgi?id=91516
DumpRenderTree crashes after printing test results. (Requested
by vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-17
- DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
- DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::accessibilityController):
(TestShell):
- 10:14 AM Changeset in webkit [122849] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Remove tests that have been passing consistently according to the flakiness dashboard.
- platform/chromium/TestExpectations:
- 9:54 AM Changeset in webkit [122848] by
-
- 6 edits in trunk/Source/WebCore
Rename CSS Exclusions CSSWrapShape class properties to match Exclusion shape function parameters
https://bugs.webkit.org/show_bug.cgi?id=89669
Patch by Hans Muller <hmuller@adobe.com> on 2012-07-17
Reviewed by Dirk Schulze.
Renamed left,top properties in the exclusion shape types to better match the specification
http://dev.w3.org/csswg/css3-exclusions/#shapes-from-svg-syntax:
WrapShapeRectangle, CSSWrapShapeRectangle - left,top should be x, y
WrapShapeCircle, CSSWrapShapeCircle - left,top should be centerX, centerY
WrapShapeEllipse, CSSWrapShapeEllipse - left,top should be centerX, centerY
No new tests or tests revisions were needed, the existing tests cover these APIs.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):
- css/CSSWrapShapes.cpp:
(WebCore::CSSWrapShapeRectangle::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
- css/CSSWrapShapes.h:
(WebCore::CSSWrapShapeRectangle::x):
(WebCore::CSSWrapShapeRectangle::y):
(WebCore::CSSWrapShapeRectangle::setX):
(WebCore::CSSWrapShapeRectangle::setY):
(CSSWrapShapeRectangle):
(WebCore::CSSWrapShapeCircle::centerX):
(WebCore::CSSWrapShapeCircle::centerY):
(WebCore::CSSWrapShapeCircle::setCenterX):
(WebCore::CSSWrapShapeCircle::setCenterY):
(CSSWrapShapeCircle):
(WebCore::CSSWrapShapeEllipse::centerX):
(WebCore::CSSWrapShapeEllipse::centerY):
(WebCore::CSSWrapShapeEllipse::setCenterX):
(WebCore::CSSWrapShapeEllipse::setCenterY):
(CSSWrapShapeEllipse):
- css/WrapShapeFunctions.cpp:
(WebCore::valueForWrapShape):
(WebCore::wrapShapeForValue):
- rendering/style/WrapShapes.h:
(WebCore::WrapShapeRectangle::x):
(WebCore::WrapShapeRectangle::y):
(WebCore::WrapShapeRectangle::setX):
(WebCore::WrapShapeRectangle::setY):
(WrapShapeRectangle):
(WebCore::WrapShapeCircle::centerX):
(WebCore::WrapShapeCircle::centerY):
(WebCore::WrapShapeCircle::setCenterX):
(WebCore::WrapShapeCircle::setCenterY):
(WrapShapeCircle):
(WebCore::WrapShapeEllipse::centerX):
(WebCore::WrapShapeEllipse::centerY):
(WebCore::WrapShapeEllipse::setCenterX):
(WebCore::WrapShapeEllipse::setCenterY):
(WrapShapeEllipse):
- 9:32 AM Changeset in webkit [122847] by
-
- 29 edits in trunk
Web Inspector: implement search / replace in source files (behind experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=91394
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change adds "loop" parameter to the go to next / previous search + adds a UI component
for search / replace of text in the sources panel. New UI component is behind the experiment.
- English.lproj/localizedStrings.js:
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._updateFilter):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.performSearch):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
(WebInspector.Panel.prototype.canSearchAndReplace):
(WebInspector.Panel.prototype.replaceSelectionWith):
(WebInspector.Panel.prototype.replaceAllWith):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype.showSearchField):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onInput):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._toggleReplaceVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.createSearchRegex):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.commitEditing):
- inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype._commitEditing):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/inspector.css:
(.search-replace):
(.search-replace:focus):
(.toolbar-search-navigation-controls):
(.toolbar-search-navigation.enabled):
(.toolbar-search):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search button):
(.toolbar-search button:active):
(.toolbar-search-control):
(.toolbar-replace-control):
(.toolbar-search-navigation.enabled:active):
(.toolbar-search-navigation.toolbar-search-navigation-prev):
(.toolbar-search-navigation.toolbar-search-navigation-prev.enabled:active):
(.toolbar-search-navigation.toolbar-search-navigation-next):
(.toolbar-search-navigation.toolbar-search-navigation-next.enabled:active):
(.drawer-header-close-button):
(.inspector-footer):
LayoutTests:
- inspector/debugger/pause-in-inline-script.html:
- inspector/debugger/script-formatter.html:
- inspector/debugger/source-url-comment.html:
- inspector/editor/indentation.html:
- inspector/editor/text-editor-line-breaks.html:
- inspector/editor/text-editor-model.html:
- inspector/editor/text-editor-undo-redo.html:
- 8:25 AM Changeset in webkit [122846] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations fix.
- platform/chromium/TestExpectations:
- 7:51 AM Changeset in webkit [122845] by
-
- 26 edits7 deletes in trunk
[Qt][V8] Remove the V8 related codepaths and configuration
https://bugs.webkit.org/show_bug.cgi?id=90863
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-07-17
Reviewed by Simon Hausmann.
.:
- Source/api.pri:
- WebKit.pro:
Source/WebCore:
No new tests because no new functionality.
- DerivedSources.pri:
- Target.pri:
- WebCore.gypi:
- WebCore.pri:
- bindings/v8/ScriptCachedFrameData.cpp:
- bindings/v8/ScriptCachedFrameData.h:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptControllerQt.cpp: Removed.
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):
- config.h:
Source/WebKit/qt:
- Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize):
- Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):
- WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
- v8/ForwardingHeaders/v8-debug.h: Removed.
- v8/ForwardingHeaders/v8-preparser.h: Removed.
- v8/ForwardingHeaders/v8-profiler.h: Removed.
- v8/ForwardingHeaders/v8-testing.h: Removed.
- v8/ForwardingHeaders/v8.h: Removed.
- v8/ForwardingHeaders/v8stdint.h: Removed.
Source/WTF:
- WTF.pri:
Tools:
- Scripts/build-webkit: Remove --v8 option.
- 7:45 AM Changeset in webkit [122844] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Don't use deprecated soup API in WebKit2APITests/TestResources
https://bugs.webkit.org/show_bug.cgi?id=91496
Reviewed by Martin Robinson.
soup_message_headers_get() is deprecated, use
soup_message_headers_get_one() instead.
- UIProcess/API/gtk/tests/TestResources.cpp:
(serverCallback):
- 6:51 AM Changeset in webkit [122843] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=91479
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-17
- platform/efl/Skipped:
- platform/efl/TestExpectations:
- 6:46 AM Styling Form Controls edited by
- (diff)
- 6:45 AM Changeset in webkit [122842] by
-
- 25 edits in trunk/LayoutTests
[Qt] fast/box-{shadow,sizing} tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91397
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-17
Reviewed by Simon Hausmann.
Updated expected Qt results for most box-shadow/ and box-sizing layout tests,
after testfonts changes made by bug 85203.
- platform/qt-5.0/Skipped:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- platform/qt/fast/box-shadow/basic-shadows-expected.txt:
- platform/qt/fast/box-shadow/border-radius-big-expected.png:
- platform/qt/fast/box-shadow/border-radius-big-expected.txt:
- platform/qt/fast/box-shadow/box-shadow-radius-expected.txt:
- platform/qt/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/qt/fast/box-shadow/box-shadow-transformed-expected.txt:
- platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.txt:
- platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
- platform/qt/fast/box-shadow/inset-box-shadows-expected.txt:
- platform/qt/fast/box-shadow/inset-expected.png:
- platform/qt/fast/box-shadow/inset-expected.txt:
- platform/qt/fast/box-shadow/scaled-box-shadow-expected.png:
- platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt:
- platform/qt/fast/box-shadow/transform-fringing-expected.png:
- platform/qt/fast/box-shadow/transform-fringing-expected.txt:
- platform/qt/fast/box-sizing/box-sizing-expected.png:
- platform/qt/fast/box-sizing/box-sizing-expected.txt:
- platform/qt/fast/box-sizing/panels-one-expected.png:
- platform/qt/fast/box-sizing/panels-one-expected.txt:
- platform/qt/fast/box-sizing/panels-two-expected.png:
- platform/qt/fast/box-sizing/panels-two-expected.txt:
- 6:23 AM Changeset in webkit [122841] by
-
- 4 edits in trunk
[QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
https://bugs.webkit.org/show_bug.cgi?id=91390
Reviewed by Zoltan Herczeg.
Fix the regression by using the proper imagetype conversion in ImageBuffer::platformTransformColorSpace.
The test is unskipped.
Source/WebCore:
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
LayoutTests:
- platform/qt/Skipped:
- 6:00 AM Drosera edited by
- (diff)
- 5:30 AM Changeset in webkit [122840] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix a typo in WebKit2APITests/TestResources
https://bugs.webkit.org/show_bug.cgi?id=91495
Reviewed by Xan Lopez.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceLoading):
(testWebResourceResponse):
(testWebResourceMimeType):
(testWebResourceActiveURI):
- 5:21 AM Changeset in webkit [122839] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r122824.
Patch by János Badics <János Badics> on 2012-07-17
- platform/qt/Skipped:
- 5:11 AM Changeset in webkit [122838] by
-
- 43 edits in trunk/Source
Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
https://bugs.webkit.org/show_bug.cgi?id=91196
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-17
Reviewed by Pavel Feldman.
Source/WebCore:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel. Also refactored
InspectorController::connectFrontend() to receive
InspectorFrontendChannel.
No new test as code refactoring done.
- inspector/InspectorClient.h:
(WebCore):
(InspectorClient):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::reconnectFrontend):
- inspector/InspectorController.h:
(WebCore):
(InspectorController):
- loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::openInspectorFrontend):
(WebCore::EmptyInspectorClient::hideHighlight):
Source/WebKit/blackberry:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::enableWebInspector):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::openInspectorFrontend):
- WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
Source/WebKit/chromium:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::openInspectorFrontend):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::openInspectorFrontend):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
Source/WebKit/efl:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::openInspectorFrontend):
- WebCoreSupport/InspectorClientEfl.h:
(InspectorClientEfl):
Source/WebKit/gtk:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend):
- WebCoreSupport/InspectorClientGtk.h:
(InspectorClient):
Source/WebKit/mac:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
Source/WebKit/qt:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
- WebCoreSupport/InspectorClientQt.h:
(InspectorClientQt):
Source/WebKit/win:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
Source/WebKit/wince:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::openInspectorFrontend):
- WebCoreSupport/InspectorClientWinCE.h:
(InspectorClientWinCE):
Source/WebKit/wx:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::openInspectorFrontend):
- WebKitSupport/InspectorClientWx.h:
(InspectorClientWx):
Source/WebKit2:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
- 4:37 AM Changeset in webkit [122837] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r122768, r122771) - it made ~ 160 fails on WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91490
Unreviewed gardening.
Patch by János Badics <János Badics> on 2012-07-17
- platform/qt-5.0-wk2/Skipped:
- 4:27 AM Changeset in webkit [122836] by
-
- 25 edits1 copy6 adds in trunk
Unreviewed, rolling out r122834.
http://trac.webkit.org/changeset/122834
https://bugs.webkit.org/show_bug.cgi?id=91492
it broke the chromium (Requested by kkristof on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-17
.:
- Source/api.pri:
- WebKit.pro:
Source/WebCore:
- DerivedSources.pri:
- Target.pri:
- WebCore.pri:
- bindings/v8/ScriptCachedFrameData.cpp:
(WebCore):
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
- bindings/v8/ScriptCachedFrameData.h:
(WebCore):
(ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptControllerQt.cpp: Copied from Source/WebCore/bindings/v8/ScriptCachedFrameData.cpp.
(WebCore):
(WebCore::ScriptController::qtScriptEngine):
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):
- config.h:
Source/WebKit/qt:
- Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
(QtWebElementRuntime::initialize):
- Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
(Bindings):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore):
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
(WebCore::FrameLoaderClientQt::willReleaseScriptContext):
(WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext):
(WebCore::FrameLoaderClientQt::createDocumentLoader):
- WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):
- v8/ForwardingHeaders/v8-debug.h: Added.
- v8/ForwardingHeaders/v8-preparser.h: Added.
- v8/ForwardingHeaders/v8-profiler.h: Added.
- v8/ForwardingHeaders/v8-testing.h: Added.
- v8/ForwardingHeaders/v8.h: Added.
- v8/ForwardingHeaders/v8stdint.h: Added.
Source/WTF:
- WTF.pri:
Tools:
- Scripts/build-webkit:
- 4:11 AM Changeset in webkit [122835] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Paste primary selection when middle clicking in X11 WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91411
Reviewed by Xan Lopez.
Handle middle click events to paste primary selection as expected
in any X11 application.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent): Call handleMousePressedEvent() for GTK+
platform.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add handleMousePressedEvent() for GTK+ platform.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::handleMousePressedEvent): Handle middle click
events to paste primary selection like we do in WebKit1.
- 3:58 AM Changeset in webkit [122834] by
-
- 25 edits7 deletes in trunk
[Qt][V8] Remove the V8 related codepaths and configuration
https://bugs.webkit.org/show_bug.cgi?id=90863
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-07-17
Reviewed by Simon Hausmann.
.:
- Source/api.pri:
- WebKit.pro:
Source/WebCore:
No new tests, because there is no new functionality.
- DerivedSources.pri:
- Target.pri:
- WebCore.pri:
- bindings/v8/ScriptCachedFrameData.cpp:
- bindings/v8/ScriptCachedFrameData.h:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptControllerQt.cpp: Removed.
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):
- config.h:
Source/WebKit/qt:
- Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize):
- Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):
- WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
- v8/ForwardingHeaders/v8-debug.h: Removed.
- v8/ForwardingHeaders/v8-preparser.h: Removed.
- v8/ForwardingHeaders/v8-profiler.h: Removed.
- v8/ForwardingHeaders/v8-testing.h: Removed.
- v8/ForwardingHeaders/v8.h: Removed.
- v8/ForwardingHeaders/v8stdint.h: Removed.
Source/WTF:
- WTF.pri:
Tools:
- Scripts/build-webkit: Remove --v8 option.
- 3:36 AM Changeset in webkit [122833] by
-
- 3 edits in trunk/Tools
[Qt] Add --use-test-fonts option to Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=91402
Reviewed by Tor Arne Vestbø.
Same stuff that already exists for QtTestBrowser.
- MiniBrowser/qt/MiniBrowser.pro:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
- 3:23 AM Changeset in webkit [122832] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable registerProtocolHandler for Blackberry
https://bugs.webkit.org/show_bug.cgi?id=90422
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-07-17
Reviewed by George Staikos.
Implements APIs were added in Custom Scheme Handler specification
which is at http://dev.w3.org/html5/spec/Overview.html#custom-handlers.
Test cases:
fast/dom/register-protocol-handler.html
fast/dom/unregister-protocol-handler.html
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
(WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- 2:59 AM Changeset in webkit [122831] by
-
- 2 edits in trunk/Source/WebCore
"in body" insertion mode, "any other end tag" step 2.1 is updated
https://bugs.webkit.org/show_bug.cgi?id=91473
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-17
Reviewed by Eric Seidel.
The HTML5 spec is updated to change the 'end tag' processing to not imply
its own end tag, since that makes no sense. Step 2.1 now says
"Generate implied end tags, except for elements with the same tag name as the token."
Modified to follow the updated spec. Also removed the first FIXME because now
ElementRecord can't be deleted by the preceeding call.
This patch does not actually change the behavior because of the previous
check (aborts if generateImpliedEndTags has already popped the node for the token),
so no new tests.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
- 2:45 AM Changeset in webkit [122830] by
-
- 137 edits12 copies55 adds in trunk/LayoutTests
[Qt] platfrom/qt/editing/inserting tests needs update after test font change.
https://bugs.webkit.org/show_bug.cgi?id=91378.
Unreviewed rebaseline.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
- platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
- platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
- platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/editing/inserting/12882-expected.png: Added.
- platform/qt/editing/inserting/12882-expected.txt:
- platform/qt/editing/inserting/4278698-expected.png:
- platform/qt/editing/inserting/4278698-expected.txt:
- platform/qt/editing/inserting/4840662-expected.png: Added.
- platform/qt/editing/inserting/4840662-expected.txt:
- platform/qt/editing/inserting/4875189-1-expected.png: Added.
- platform/qt/editing/inserting/4875189-1-expected.txt:
- platform/qt/editing/inserting/4875189-2-expected.png: Added.
- platform/qt/editing/inserting/4875189-2-expected.txt:
- platform/qt/editing/inserting/4959067-expected.png: Added.
- platform/qt/editing/inserting/4959067-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.png:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/inserting/4960120-2-expected.png: Added.
- platform/qt/editing/inserting/4960120-2-expected.txt:
- platform/qt/editing/inserting/5002441-expected.png: Added.
- platform/qt/editing/inserting/5002441-expected.txt:
- platform/qt/editing/inserting/5058163-1-expected.png: Added.
- platform/qt/editing/inserting/5058163-1-expected.txt:
- platform/qt/editing/inserting/5058163-2-expected.png: Added.
- platform/qt/editing/inserting/5058163-2-expected.txt:
- platform/qt/editing/inserting/5156401-2-expected.png: Added.
- platform/qt/editing/inserting/5156401-2-expected.txt:
- platform/qt/editing/inserting/5418891-expected.png: Added.
- platform/qt/editing/inserting/5418891-expected.txt:
- platform/qt/editing/inserting/5510537-expected.png: Added.
- platform/qt/editing/inserting/5510537-expected.txt:
- platform/qt/editing/inserting/5549929-2-expected.png: Added.
- platform/qt/editing/inserting/5549929-2-expected.txt:
- platform/qt/editing/inserting/5549929-3-expected.png: Added.
- platform/qt/editing/inserting/5549929-3-expected.txt:
- platform/qt/editing/inserting/6703873-expected.png: Added.
- platform/qt/editing/inserting/6703873-expected.txt:
- platform/qt/editing/inserting/before-after-input-element-expected.png:
- platform/qt/editing/inserting/before-after-input-element-expected.txt:
- platform/qt/editing/inserting/break-blockquote-after-delete-expected.png: Added.
- platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/qt/editing/inserting/editable-html-element-expected.png:
- platform/qt/editing/inserting/editable-html-element-expected.txt:
- platform/qt/editing/inserting/editable-inline-element-expected.png: Added.
- platform/qt/editing/inserting/editable-inline-element-expected.txt:
- platform/qt/editing/inserting/edited-whitespace-1-expected.png: Added.
- platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
- platform/qt/editing/inserting/editing-empty-divs-expected.png:
- platform/qt/editing/inserting/editing-empty-divs-expected.txt:
- platform/qt/editing/inserting/insert-3654864-fix-expected.txt: Removed.
- platform/qt/editing/inserting/insert-3775316-fix-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
- platform/qt/editing/inserting/insert-3775316-fix-expected.txt:
- platform/qt/editing/inserting/insert-3778059-fix-expected.png: Added.
- platform/qt/editing/inserting/insert-3778059-fix-expected.txt:
- platform/qt/editing/inserting/insert-3800346-fix-expected.png: Added.
- platform/qt/editing/inserting/insert-3800346-fix-expected.txt:
- platform/qt/editing/inserting/insert-3851164-fix-expected.txt: Removed.
- platform/qt/editing/inserting/insert-after-delete-001-expected.png:
- platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
- platform/qt/editing/inserting/insert-at-end-01-expected.png: Added.
- platform/qt/editing/inserting/insert-at-end-01-expected.txt:
- platform/qt/editing/inserting/insert-at-end-02-expected.png: Added.
- platform/qt/editing/inserting/insert-at-end-02-expected.txt:
- platform/qt/editing/inserting/insert-br-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
- platform/qt/editing/inserting/insert-br-001-expected.txt:
- platform/qt/editing/inserting/insert-br-002-expected.png: Added.
- platform/qt/editing/inserting/insert-br-002-expected.txt:
- platform/qt/editing/inserting/insert-br-003-expected.png:
- platform/qt/editing/inserting/insert-br-003-expected.txt:
- platform/qt/editing/inserting/insert-br-004-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-3851164-fix-expected.png.
- platform/qt/editing/inserting/insert-br-004-expected.txt:
- platform/qt/editing/inserting/insert-br-005-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
- platform/qt/editing/inserting/insert-br-005-expected.txt:
- platform/qt/editing/inserting/insert-br-006-expected.png:
- platform/qt/editing/inserting/insert-br-006-expected.txt:
- platform/qt/editing/inserting/insert-br-007-expected.png:
- platform/qt/editing/inserting/insert-br-007-expected.txt:
- platform/qt/editing/inserting/insert-br-008-expected.png:
- platform/qt/editing/inserting/insert-br-008-expected.txt:
- platform/qt/editing/inserting/insert-br-009-expected.png:
- platform/qt/editing/inserting/insert-br-009-expected.txt:
- platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
- platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.txt:
- platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.png:
- platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
- platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.png:
- platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/qt/editing/inserting/insert-br-quoted-001-expected.png: Added.
- platform/qt/editing/inserting/insert-br-quoted-001-expected.txt:
- platform/qt/editing/inserting/insert-br-quoted-002-expected.png: Added.
- platform/qt/editing/inserting/insert-br-quoted-002-expected.txt:
- platform/qt/editing/inserting/insert-br-quoted-003-expected.png: Added.
- platform/qt/editing/inserting/insert-br-quoted-003-expected.txt:
- platform/qt/editing/inserting/insert-br-quoted-004-expected.png: Added.
- platform/qt/editing/inserting/insert-br-quoted-004-expected.txt:
- platform/qt/editing/inserting/insert-br-quoted-005-expected.png: Added.
- platform/qt/editing/inserting/insert-br-quoted-005-expected.txt:
- platform/qt/editing/inserting/insert-br-quoted-006-expected.png: Added.
- platform/qt/editing/inserting/insert-br-quoted-006-expected.txt:
- platform/qt/editing/inserting/insert-div-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
- platform/qt/editing/inserting/insert-div-001-expected.txt:
- platform/qt/editing/inserting/insert-div-002-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
- platform/qt/editing/inserting/insert-div-002-expected.txt:
- platform/qt/editing/inserting/insert-div-003-expected.png:
- platform/qt/editing/inserting/insert-div-003-expected.txt:
- platform/qt/editing/inserting/insert-div-004-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
- platform/qt/editing/inserting/insert-div-004-expected.txt:
- platform/qt/editing/inserting/insert-div-005-expected.png: Added.
- platform/qt/editing/inserting/insert-div-005-expected.txt:
- platform/qt/editing/inserting/insert-div-006-expected.png:
- platform/qt/editing/inserting/insert-div-006-expected.txt:
- platform/qt/editing/inserting/insert-div-007-expected.png:
- platform/qt/editing/inserting/insert-div-007-expected.txt:
- platform/qt/editing/inserting/insert-div-008-expected.png:
- platform/qt/editing/inserting/insert-div-008-expected.txt:
- platform/qt/editing/inserting/insert-div-009-expected.txt: Removed.
- platform/qt/editing/inserting/insert-div-010-expected.txt: Removed.
- platform/qt/editing/inserting/insert-div-011-expected.png: Added.
- platform/qt/editing/inserting/insert-div-011-expected.txt:
- platform/qt/editing/inserting/insert-div-012-expected.png: Added.
- platform/qt/editing/inserting/insert-div-012-expected.txt:
- platform/qt/editing/inserting/insert-div-013-expected.png: Added.
- platform/qt/editing/inserting/insert-div-013-expected.txt:
- platform/qt/editing/inserting/insert-div-014-expected.png: Added.
- platform/qt/editing/inserting/insert-div-014-expected.txt:
- platform/qt/editing/inserting/insert-div-015-expected.png: Added.
- platform/qt/editing/inserting/insert-div-015-expected.txt:
- platform/qt/editing/inserting/insert-div-016-expected.png: Added.
- platform/qt/editing/inserting/insert-div-016-expected.txt:
- platform/qt/editing/inserting/insert-div-017-expected.png: Added.
- platform/qt/editing/inserting/insert-div-017-expected.txt:
- platform/qt/editing/inserting/insert-div-018-expected.png: Added.
- platform/qt/editing/inserting/insert-div-018-expected.txt:
- platform/qt/editing/inserting/insert-div-019-expected.png: Added.
- platform/qt/editing/inserting/insert-div-019-expected.txt:
- platform/qt/editing/inserting/insert-div-020-expected.png: Added.
- platform/qt/editing/inserting/insert-div-020-expected.txt:
- platform/qt/editing/inserting/insert-div-022-expected.png: Added.
- platform/qt/editing/inserting/insert-div-022-expected.txt:
- platform/qt/editing/inserting/insert-div-023-expected.png:
- platform/qt/editing/inserting/insert-div-023-expected.txt:
- platform/qt/editing/inserting/insert-div-024-expected.png:
- platform/qt/editing/inserting/insert-div-024-expected.txt:
- platform/qt/editing/inserting/insert-div-025-expected.png:
- platform/qt/editing/inserting/insert-div-025-expected.txt:
- platform/qt/editing/inserting/insert-div-026-expected.png: Added.
- platform/qt/editing/inserting/insert-div-026-expected.txt:
- platform/qt/editing/inserting/insert-div-027-expected.png: Added.
- platform/qt/editing/inserting/insert-div-027-expected.txt:
- platform/qt/editing/inserting/insert-paragraph-01-expected.png: Added.
- platform/qt/editing/inserting/insert-paragraph-01-expected.txt:
- platform/qt/editing/inserting/insert-paragraph-02-expected.png: Added.
- platform/qt/editing/inserting/insert-paragraph-02-expected.txt:
- platform/qt/editing/inserting/insert-paragraph-03-expected.png: Added.
- platform/qt/editing/inserting/insert-paragraph-03-expected.txt:
- platform/qt/editing/inserting/insert-paragraph-04-expected.png: Added.
- platform/qt/editing/inserting/insert-paragraph-04-expected.txt:
- platform/qt/editing/inserting/insert-paragraph-05-expected.png: Added.
- platform/qt/editing/inserting/insert-paragraph-05-expected.txt:
- platform/qt/editing/inserting/insert-space-in-empty-doc-expected.png:
- platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
- platform/qt/editing/inserting/insert-tab-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
- platform/qt/editing/inserting/insert-tab-001-expected.txt:
- platform/qt/editing/inserting/insert-tab-002-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
- platform/qt/editing/inserting/insert-tab-002-expected.txt:
- platform/qt/editing/inserting/insert-tab-004-expected.png: Renamed from LayoutTests/platform/qt/editing/inserting/insert-3851164-fix-expected.png.
- platform/qt/editing/inserting/insert-tab-004-expected.txt:
- platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.png:
- platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png:
- platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
- platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.png: Renamed from LayoutTests/platform/qt/editing/inserting/insert-3654864-fix-expected.png.
- platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.txt:
- platform/qt/editing/inserting/insert-text-with-newlines-expected.png:
- platform/qt/editing/inserting/insert-text-with-newlines-expected.txt:
- platform/qt/editing/inserting/line-break-expected.png: Added.
- platform/qt/editing/inserting/line-break-expected.txt:
- platform/qt/editing/inserting/multiple-lines-selected-expected.png:
- platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-01-expected.png: Added.
- platform/qt/editing/inserting/paragraph-separator-01-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-02-expected.png: Added.
- platform/qt/editing/inserting/paragraph-separator-02-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-03-expected.png:
- platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
- platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
- platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/qt/editing/inserting/redo-expected.png:
- platform/qt/editing/inserting/redo-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-001-expected.png: Added.
- platform/qt/editing/inserting/return-key-with-selection-001-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-002-expected.png: Added.
- platform/qt/editing/inserting/return-key-with-selection-002-expected.txt:
- platform/qt/editing/inserting/return-key-with-selection-003-expected.png:
- platform/qt/editing/inserting/return-key-with-selection-003-expected.txt:
- platform/qt/editing/inserting/typing-001-expected.png:
- platform/qt/editing/inserting/typing-001-expected.txt:
- platform/qt/editing/inserting/typing-002-expected.png:
- platform/qt/editing/inserting/typing-002-expected.txt:
- platform/qt/editing/inserting/typing-003-expected.png:
- platform/qt/editing/inserting/typing-003-expected.txt:
- platform/qt/editing/inserting/typing-around-br-001-expected.png:
- platform/qt/editing/inserting/typing-around-br-001-expected.txt:
- platform/qt/editing/inserting/typing-around-image-001-expected.png:
- platform/qt/editing/inserting/typing-around-image-001-expected.txt:
- 2:20 AM Changeset in webkit [122829] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91477
- platform/chromium/TestExpectations:
- 2:09 AM Changeset in webkit [122828] by
-
- 5 edits in trunk/Tools
[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459
Reviewed by Ryosuke Niwa.
Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.
- DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
- DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::accessibilityController):
(TestShell):
- 2:05 AM Changeset in webkit [122827] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r122768 or r122771.
https://bugs.webkit.org/show_bug.cgi?id=91476
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-17
- platform/qt/Skipped:
- 1:45 AM Changeset in webkit [122826] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after 122816. Skipped fast/dom/shadow/shadowdom-for-media.html
because ENABLE(SHADOW_DOM) is disabled on Qt.
Patch by János Badics <János Badics> on 2012-07-17
- platform/qt/Skipped:
- 1:37 AM Changeset in webkit [122825] by
-
- 3 edits2 adds in trunk
[Regression] Infinite loop in document.elementFromPoint
https://bugs.webkit.org/show_bug.cgi?id=90820
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Node::shadowAncestorNode returns the caller node itself for SVGElement. However,
since we have already implemented event retargeting algorithm in Shadow DOM, we don't have to
take a special care of SVGElement for Node.shadowAncestorNode() now.
This patch will removes the special care code and fixes infinite loop in document.elementFromPoint().
Test: svg/hittest/svg-use-element-from-point.html
- dom/Node.cpp:
(WebCore::Node::shadowAncestorNode):
LayoutTests:
- svg/hittest/svg-use-element-from-point-expected.txt: Added.
- svg/hittest/svg-use-element-from-point.html: Added.
- 1:27 AM Changeset in webkit [122824] by
-
- 26 edits25 adds in trunk
Shadow DOM for img element
https://bugs.webkit.org/show_bug.cgi?id=90532
Reviewed by Hajime Morita.
Source/WebCore:
This patch adds Shadow DOM support for img element.
According to the Shadow DOM spec, img element should behave like having a user agent Shadow DOM.
However, if we add Shadow DOM to img by default, it will cause performance regression and memory bloat.
So, we would like to postpone adding a Shadow DOM to img until when we really need it. In other words,
we add our User Agent Shadow DOM to img just before a user adds Author Shadow DOM.
The User Agent Shadow DOM for img has only one element, which displays an image. If img has
a Shadow DOM, img will behave like <span style="display: inline-block"> by default. The display style can
be chagned using CSS though.
This patch also adds ImageLoaderClient. The element we render an image and the element we take an argument
from were the same, however not they might be different. We would like to encapsulate the fact into
ImageLoaderClient.
Tests: fast/dom/shadow/shadowdom-for-image-alt-update.html
fast/dom/shadow/shadowdom-for-image-alt.html
fast/dom/shadow/shadowdom-for-image-content.html
fast/dom/shadow/shadowdom-for-image-dynamic.html
fast/dom/shadow/shadowdom-for-image-event-click.html
fast/dom/shadow/shadowdom-for-image-in-shadowdom.html
fast/dom/shadow/shadowdom-for-image-map.html
fast/dom/shadow/shadowdom-for-image-style.html
fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html
fast/dom/shadow/shadowdom-for-image-with-width-and-height.html
fast/dom/shadow/shadowdom-for-image.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/html.css:
(img):
- html/HTMLImageElement.cpp:
(WebCore::ImageElement::setImageIfNecessary):
(WebCore):
(WebCore::ImageElement::createRendererForImage):
(WebCore::HTMLImageElement::willAddAuthorShadowRoot): When we don't have a user agent Shadow DOM yet
we add it.
(WebCore::HTMLImageElement::createShadowSubtree):
(WebCore::HTMLImageElement::imageElement):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::createRenderer): If a user agent Shadow DOM is attached, we create
Renderer from style, instead of creating RenderImage.
(WebCore::HTMLImageElement::attach):
(WebCore::HTMLImageElement::innerElement):
- html/HTMLImageElement.h:
(WebCore):
(ImageElement):
(HTMLImageElement):
(WebCore::HTMLImageElement::sourceElement):
(WebCore::HTMLImageElement::refSourceElement):
(WebCore::HTMLImageElement::derefSourceElement):
(WebCore::HTMLImageElement::imageRenderer):
(WebCore::HTMLImageElement::imageLoader):
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::HTMLImageLoader):
(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::sourceURI):
(WebCore::HTMLImageLoader::notifyFinished):
- html/HTMLImageLoader.h:
(HTMLImageLoader):
- html/HTMLInputElement.h:
- html/HTMLObjectElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLTagNames.in:
- html/HTMLVideoElement.h:
- html/shadow/ImageInnerElement.cpp: Added.
(WebCore):
(WebCore::ImageInnerElement::ImageInnerElement):
(WebCore::ImageInnerElement::hostImage):
(WebCore::ImageInnerElement::imageLoader):
(WebCore::ImageInnerElement::attach):
(WebCore::ImageInnerElement::createRenderer):
- html/shadow/ImageInnerElement.h: Added.
(WebCore):
(ImageInnerElement):
(WebCore::ImageInnerElement::imageRenderer):
(WebCore::ImageInnerElement::create):
(WebCore::isImageInnerElement):
(WebCore::toImageInnerElement):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore):
(WebCore::ImageLoader::document):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::renderImageResource):
(WebCore::ImageLoader::updatedHasPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
- loader/ImageLoader.h:
(WebCore):
(ImageLoader):
(WebCore::ImageLoader::client):
- loader/ImageLoaderClient.h: Added.
(WebCore):
(ImageLoaderClient): Provides the necessary interfaces to ImageLoader.
(WebCore::ImageLoaderClient::~ImageLoaderClient):
(ImageLoaderClientBase):
(WebCore::ImageLoaderClientBase::sourceElement):
(WebCore::ImageLoaderClientBase::imageElement):
(WebCore::ImageLoaderClientBase::refSourceElement):
(WebCore::ImageLoaderClientBase::derefSourceElement):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
(WebCore::RenderImage::hostImageElement):
(WebCore):
- rendering/RenderImage.h:
(WebCore):
(RenderImage):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
- svg/SVGImageElement.h:
(SVGImageElement):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::SVGImageLoader):
(WebCore::SVGImageLoader::dispatchLoadEvent):
(WebCore::SVGImageLoader::sourceURI):
- svg/SVGImageLoader.h:
(SVGImageLoader):
LayoutTests:
Contains the following test cases.
(1) ShadowDOM is attached to an img element and use a shadow element
(2) ShadowDOM is attached to an img element and use a content element
(3) width and height are specified
(4) src attribute is dynamically changed
(5) multiple ShadowDOMs are attached to an img element
(6) ShadowDOM is attached to an img element in Shadow DOM
(7) event retargetting
(8) img with display: none, display: inline, display: block
(9) image map
(10) alt text
(11) alt text with dynamic update
- fast/dom/shadow/shadowdom-for-image-alt-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-alt-update-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-alt-update.html: Added.
- fast/dom/shadow/shadowdom-for-image-alt.html: Added.
- fast/dom/shadow/shadowdom-for-image-content-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-content.html: Added.
- fast/dom/shadow/shadowdom-for-image-dynamic-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-dynamic.html: Added.
- fast/dom/shadow/shadowdom-for-image-event-click-expected.txt: Added.
- fast/dom/shadow/shadowdom-for-image-event-click.html: Added.
- fast/dom/shadow/shadowdom-for-image-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-in-shadowdom-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-in-shadowdom.html: Added.
- fast/dom/shadow/shadowdom-for-image-map-expected.txt: Added.
- fast/dom/shadow/shadowdom-for-image-map.html: Added.
- fast/dom/shadow/shadowdom-for-image-style-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-style.html: Added.
- fast/dom/shadow/shadowdom-for-image-with-multiple-shadow-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html: Added.
- fast/dom/shadow/shadowdom-for-image-with-width-and-height-expected.html: Added.
- fast/dom/shadow/shadowdom-for-image-with-width-and-height.html: Added.
- fast/dom/shadow/shadowdom-for-image.html: Added.
- 1:22 AM Changeset in webkit [122823] by
-
- 10 edits in trunk/Source/WebCore
Internals: Remove injectPagePopupController()
https://bugs.webkit.org/show_bug.cgi?id=91471
Reviewed by Hajime Morita.
r122558 introduced injectPagePopupController(), however we'd like to
avoid adding such JavaScript binding code. We can avoid it by exposing a
PagePopupController for a mock and injecting the following code to the
popup document:
<script>window.pagePopupController = window.internals.pagePopupController</script>
No new tests. This is a kind of refactoring.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::pagePopupController):
Added. Accessor for PagePopupControler owned by the MockPagePopupDriver.
- testing/InternalSettings.h:
(InternalSettings): Declare pagePopupController() for Internals::pagePopupController().
- testing/Internals.cpp:
(WebCore::Internals::pagePopupController):
Added. This uses InternalSettings::pagePopupController().
- testing/Internals.h:
(Internals): Declare pagePopupController() for Internals.idl.
- testing/Internals.idl: Declare pagePopupController.
- testing/MockPagePopupDriver.cpp:
Moved m_pagePopupController from MockPagePopup to MockPagePopupDriver.
(WebCore::MockPagePopup::MockPagePopup):
Added a script element to prepare window.pagePopupController.
Removed a callsite of injectPagePopupController().
(WebCore::MockPagePopupDriver::openPagePopup):
(WebCore::MockPagePopupDriver::closePagePopup):
- testing/MockPagePopupDriver.h:
(WebCore::MockPagePopupDriver::pagePopupController):
Accessor for a PagePopupController object.
(MockPagePopupDriver): Add RefPtr<PagePopupController> data member.
- testing/v8/WebCoreTestSupport.cpp: Remove injectPagePopupController().
- testing/v8/WebCoreTestSupport.h: ditto.
- 1:11 AM Changeset in webkit [122822] by
-
- 2 edits2 moves in trunk/Tools
[Chromium] Move TextInputController into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91457
Reviewed by Ryosuke Niwa.
This patch is purely moving code. TextInputController is one of the
objects exposed to JavaScript and so should be in the TestRunner
library.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
- DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
- 1:10 AM Changeset in webkit [122821] by
-
- 4 edits in trunk/Tools
[Chromium] TextInputController shouldn't know about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91455
Reviewed by Kent Tamura.
This patch uses the same pattern we used for the
AccessibilityController to remove the dependency on TestShell.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
- DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::TextInputController):
(TextInputController::insertText):
(TextInputController::doCommand):
(TextInputController::setMarkedText):
(TextInputController::unmarkText):
(TextInputController::hasMarkedText):
(TextInputController::markedRange):
(TextInputController::selectedRange):
(TextInputController::firstRectForCharacterRange):
(TextInputController::validAttributesForMarkedText):
(TextInputController::setComposition):
- DumpRenderTree/chromium/TextInputController.h:
(WebKit):
(TextInputController):
(TextInputController::setWebView):
- 1:02 AM Changeset in webkit [122820] by
-
- 5 edits in trunk/LayoutTests
Unreviewed chromium tests rebaselines after r122791.
- platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- 1:00 AM Changeset in webkit [122819] by
-
- 29 edits2 copies7 adds in trunk/LayoutTests
Unreviewed chromium tests rebaselines after r122785.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/chromium-linux-x86/fast/reflections/reflection-with-zoom-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png.
- platform/chromium-linux/fast/borders/border-image-scaled-gradient-expected.png:
- platform/chromium-linux/fast/css/transformed-mask-expected.png:
- platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png:
- platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png:
- platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
- platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
- platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png:
- platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/transformed-mask-expected.png:
- platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png:
- platform/chromium-mac/fast/css/transformed-mask-expected.png:
- platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png:
- platform/chromium-mac/fast/gradients/css3-radial-gradients-expected.png:
- platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png:
- platform/chromium-mac/fast/gradients/css3-repeating-radial-gradients-expected.png:
- platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-win-xp/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/chromium-win-xp/fast/reflections/reflection-with-zoom-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png.
- platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png:
- platform/chromium-win/fast/css/transformed-mask-expected.png:
- platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png:
- platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png:
- platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png:
- platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
- 12:59 AM Changeset in webkit [122818] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed buildfix from Zoltan Herczeg after 122768.
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
- 12:52 AM Changeset in webkit [122817] by
-
- 14 edits in trunk/Source
[EFL] Move codes related to theme setting from Widget to RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=89842
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
WebKit/Efl uses custom theme for Scrollbar, RenderTheme and Cursor.
However, theme information itself is in WidgetEfl so it is accessed by
calling recursive function.
Because theme is managed by each page, this patch moves codes related to
theme from WidgetEfl to RenderThemeEfl which is contained by page.
- platform/Widget.h: Removed functions related to theme.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::setThemePath): Added to set theme path.
(WebCore::RenderThemeEfl::createEdje): Updated method to use RenderThemeEfl's theme.
(WebCore::RenderThemeEfl::RenderThemeEfl):
- platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::themePath): Added to get theme path
- platform/efl/ScrollbarEfl.cpp: Updated method to use RenderThemeEfl's theme.
(ScrollbarEfl::setParent):
- platform/efl/WidgetEfl.cpp: Removed codes related theme.
(WidgetPrivate):
Source/WebKit:
- CMakeLists.txt: Added html/shadow to WebKit_INCLUDE_DIRECTORIES.
Source/WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_view_create_for_view): Removed codes which set theme in FrameView.
- ewk/ewk_view.cpp:
(ewk_view_theme_set): Called RenderThemeEfl::setThemePath instead of setting theme in FrameView.
Source/WebKit2:
- CMakeLists.txt: Added html/shadow to WebKit_INCLUDE_DIRECTORIES.
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::setThemePath): Called RenderThemeEfl::setThemePath instead of setting theme in FrameView.
- 12:26 AM Changeset in webkit [122816] by
-
- 7 edits2 adds in trunk
HTMLMediaElement should not use Element::ensureShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=77936
Reviewed by Hajime Morita.
Source/WebCore:
a video element and an audio element add UserAgentShadowRoot dynamically, and they assume that it's the oldest ShadowRoot.
However an AuthorShadowRoot could be added by a user before a video element and an audio element add UserAgentShadowRoot.
It breaks the assumption that the UserAgentShadowRoot is the oldest.
If the UserAgentShadowRoot is not the oldest, the AuthorShadowRoot a page author added might be ignored.
Since the timing to add UserAgentShadowRoot is not known by a user, the fact that UserAgentShadorRoot is
not the oldest will cause inconsistent behavior.
Adding AuthorShadowRoot to a video element and an audio element is allowed by this patch.
Test: fast/dom/shadow/shadowdom-for-media.html
- dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createShadowSubtree):
(WebCore):
(WebCore::HTMLMediaElement::willAddAuthorShadowRoot):
(WebCore::HTMLMediaElement::createMediaControls):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
LayoutTests:
Adding Shadow DOM to a video element and an audio element is allowed now.
- fast/dom/shadow/shadow-disable-expected.txt:
- fast/dom/shadow/shadow-disable.html:
- fast/dom/shadow/shadowdom-for-media-expected.txt: Added.
- fast/dom/shadow/shadowdom-for-media.html: Added.
- 12:24 AM Styling Form Controls edited by
- (diff)
- 12:23 AM Changeset in webkit [122815] by
-
- 7 edits in trunk/LayoutTests
[Forms] Test expectations of datetime/datetime-local/time should not contain milliseconds when they aren't expected
https://bugs.webkit.org/show_bug.cgi?id=91469
Reviewed by Kent Tamura.
This patch gets rid of unexpected millisecond strings from both test
cases and expected text.
This is adaptation of behavior change caused by r119948, introducing
decimal arithmetic, which corrected the expression step mod 1000 used
in BaseDateAndTimeInputType::serialize for checking adding milliseconds
or not, which converts internal date time representation into string.
Before r119948, we used fmod(step, 1000) for this. However, it doesn't
return mathematically correct value when quotient is very large, e.g.
fmod(3.40282346e+38, 1000) returns 616 on x86 linux, although we
expect that it is 0.
- fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for big step value tests.
- fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: ditto.
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: ditto.
- fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: ditto.
- fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for a big step value test and expected value's fractinal second is zero.
- fast/forms/time/time-stepup-stepdown-from-renderer.html: ditto.
- 12:19 AM Changeset in webkit [122814] by
-
- 2 edits3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped:
- platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
- 12:18 AM Styling Form Controls edited by
- Add a section for <input type=date> (diff)
- 12:11 AM Changeset in webkit [122813] by
-
- 12 edits in trunk
Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=89055
Patch by David Barr <davidbarr@chromium.org> on 2012-07-17
Reviewed by Kent Tamura.
The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
Add a configuration option for CSS image-orientation support, disabling it by default.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
- 12:08 AM Changeset in webkit [122812] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Chromium Mac build after <http://trac.webkit.org/changeset/122802>
(https://bugs.webkit.org/show_bug.cgi?id=91451)
Remove unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
This instance variable has remained unused since it was added in
<http://trac.webkit.org/changeset/116718> (https://bugs.webkit.org/show_bug.cgi?id=85725).
I'm unclear as to why the Chromium Mac build began to complain about this
unused instance variable following <http://trac.webkit.org/changeset/122802>, since this
code has been in the tree for a while and we previously instantiated AbsoluteQuadsGeneratorContext
with wasFixed (even though it wasn't used). Regardless, we should remove the unused
instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
- rendering/RenderInline.cpp:
(WebCore): Remove AbsoluteQuadsGeneratorContext::m_wasFixed.
(WebCore::RenderInline::absoluteQuads):
Jul 16, 2012:
- 11:43 PM Changeset in webkit [122811] by
-
- 1 edit2 deletes in trunk/Source/WebKit/chromium
Unreviewed. Remove two empty directories.
- public/linuxish: Removed.
- src/linuxish: Removed.
- 11:37 PM FeatureFlags edited by
- (diff)
- 11:27 PM Changeset in webkit [122810] by
-
- 25 edits6 adds in trunk/Source
Add RegisterProtocolHandlerClient to the Modules/protocolhandler
https://bugs.webkit.org/show_bug.cgi?id=90940
Reviewed by Hajime Morita.
Source/WebCore:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In addition, NavigatorRegisterProtocolHandler should be supplementable.
No new tests. Covered by existing tests.
- GNUmakefile.list.am:
- Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:
(WebCore::NavigatorRegisterProtocolHandler::from):
(WebCore::NavigatorRegisterProtocolHandler::create):
(WebCore):
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered):
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::supplementName):
(WebCore::provideRegisterProtocolHandlerTo):
- Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:
(WebCore):
(NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::client):
- Modules/protocolhandler/RegisterProtocolHandlerClient.h: Added.
(WebCore):
(RegisterProtocolHandlerClient):
- WebCore.gypi:
- loader/EmptyClients.h:
- page/ChromeClient.h:
(ChromeClient):
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::setCookies):
(WebCore::getRawCookies):
Source/WebKit:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
- PlatformEfl.cmake: Add RegisterProtocolHandlerEfl files and include path.
Source/WebKit/chromium:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, RegisterProtocolHandlerClientImpl class is added to ChromeClientImpl files.
In addition, existing functions related to protocol handler in ChromeClientImpl class are moved to
RegisterProtocolHandlerClientImpl class.
- WebKit.gyp:
- src/ChromeClientImpl.cpp: Implement RegisterProtocolHandlerClientImpl class.
(WebKit):
(WebKit::RegisterProtocolHandlerClientImpl::create):
(WebKit::RegisterProtocolHandlerClientImpl::RegisterProtocolHandlerClientImpl):
(WebKit::RegisterProtocolHandlerClientImpl::registerProtocolHandler):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
(RegisterProtocolHandlerClientImpl):
(WebKit::RegisterProtocolHandlerClientImpl::~RegisterProtocolHandlerClientImpl):
(WebKit):
- src/WebViewImpl.cpp: Register RegisterProtocolHandlerClientImpl in order to support supplement.
(WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
Source/WebKit/efl:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient
In order to support this, RegisterProtocolHandlerClientEfl class is added and ewk_view registers
RegisterProtocolHandlerClientEfl. In addition, existing concrete functions in ChromeClientEfl are moved
to RegisterProtocolHandlerClientEfl.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
- WebCoreSupport/ChromeClientEfl.h:
- WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp: Added.
(WebCore):
(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::RegisterProtocolHandlerClientEfl::RegisterProtocolHandlerClientEfl):
(WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
(WebCore::RegisterProtocolHandlerClientEfl::isProtocolHandlerRegistered):
(WebCore::RegisterProtocolHandlerClientEfl::unregisterProtocolHandler):
- WebCoreSupport/RegisterProtocolHandlerClientEfl.h: Added.
(RegisterProtocolHandlerClientEfl):
(WebCore::RegisterProtocolHandlerClientEfl::~RegisterProtocolHandlerClientEfl):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit/gtk:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, RegisterProtocolHandlerClientGtk class is added and webview registers
RegisterProtocolHandlerClientGtk. In addition, existing concrete functions in ChromeClientGtk are moved
to RegisterProtocolHandlerClientGtk.
- GNUmakefile.am:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
- WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp: Added.
(WebKit):
(WebKit::RegisterProtocolHandlerClient::RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::registerProtocolHandler):
- WebCoreSupport/RegisterProtocolHandlerClientGtk.h: Added.
(WebKit):
(RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::~RegisterProtocolHandlerClient):
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
Source/WebKit2:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, WebRegisterProtocolHandlerClient class is added. However, this is not implemented yet.
In addition, existing virtual functions in WebChromeClient are moved to WebRegisterProtocolHandlerClient.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h: Added.
(WebKit):
(WebRegisterProtoclHandlerClient):
(WebKit::WebRegisterProtoclHandlerClient::isProtocolHandlerRegistered):
(WebKit::WebRegisterProtoclHandlerClient::unregisterProtocolHandler):
- 11:27 PM Changeset in webkit [122809] by
-
- 2 edits2 moves in trunk/Tools
[Chromium] Move Task.(cpp|h) into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91446
Reviewed by Ryosuke Niwa.
Task is a dependency of EventSender, which needs to move into TestRunner.a.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
- DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
- 11:19 PM Changeset in webkit [122808] by
-
- 2 edits4 moves in trunk/Tools
[Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91443
Reviewed by Tony Chang.
Purely a file move (and a sorting of #includes).
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
- DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
- 10:11 PM Changeset in webkit [122807] by
-
- 2 edits in trunk/Source/WebKit/chromium
REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing.
https://bugs.webkit.org/show_bug.cgi?id=91244
Reviewed by Kent Tamura.
This patch enables and updates disabled test cases of DecimalTest
caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor()
for small fraction numbers and added test cases. Fixes in r122552
itself is correct however, it didn't update existing tests for very small
fraction numbers.
- tests/DecimalTest.cpp:
(TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000),
ceiling rounds number toward positive infinity.
(TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000),
floor rounds number toward negative infinity.
- 9:37 PM Changeset in webkit [122806] by
-
- 17 edits4 adds in trunk
.: Expose an export for the iconUrl list so Internals can use it
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
- Source/autotools/symbols.filter: export iconURLs
Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
As it turns out, it can contain stale URLs in the case that some script
manipulates the DOM, which breaks scripts trying to reset the favicon
URL. Also added a method in Internals to allow tests to get the list of
icon
Tests: fast/dom/icon-url-change.html
fast/dom/icon-url-list.html
- WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
- dom/Document.cpp:
(WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
(WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
(WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace
- dom/Document.h:
(Document): removed the addIconURL method which is no longer used
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
(WebCore):
(WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor
- html/HTMLLinkElement.h:
(HTMLLinkElement): declared the icon type and size accessors
- testing/Internals.cpp:
(WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
(WebCore):
- testing/Internals.h:
(Internals): declared the method for unit testing the icon URL list
- testing/Internals.idl: exported the Document::iconURLs function
Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
- win/WebKit2.def: export the DocumentL::iconURLs function
LayoutTests: Add some new unit tests to test the favicon changing dynamically
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
- fast/dom/icon-url-change-expected.txt: Added.
- fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
- fast/dom/icon-url-list-expected.txt: Added.
- fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
- fast/dom/icon-url-property-expected.txt: update unit test expectations
- fast/dom/icon-url-property.html: update and enable existing favicon test
- platform/chromium/TestExpectations: reenable the url-property test
- 9:33 PM Changeset in webkit [122805] by
-
- 12 edits in trunk
WebCore needs WEBCORE_TESTING macro to mark methods being exported for testing.
https://bugs.webkit.org/show_bug.cgi?id=90764
Patch by Hajime Morrita <morrita@chromium.org> on 2012-07-16
Reviewed by Adam Barth.
.:
Removed symbols which are now covered by WEBCORE_TESTING.
- Source/autotools/symbols.filter:
Source/WebCore:
Defined WEBCORE_TESTING based on USE(EXPORT_MACROS_FOR_TESTING) and
applied it to FrameDestructionObserver.
- bindings/js/JSDOMGlobalObject.h: Removed conflicting symbols
- page/FrameDestructionObserver.h: Added WEBKIT_TESTING
(FrameDestructionObserver):
- platform/PlatformExportMacros.h:
Source/WebKit2:
Removed symbols which are now covered by WEBCORE_TESTING.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Source/WTF:
Added USE(EXPORT_MACROS_FOR_TESTING) and enabled it on GTK and Windows.
- wtf/ExportMacros.h:
- wtf/Platform.h:
- 9:00 PM Changeset in webkit [122804] by
-
- 4 edits in trunk/Tools
[Chromium] AccessibilityController shouldn't know anything about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91441
Reviewed by Tony Chang.
This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
- DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::getFocusedElement):
(AccessibilityController::getRootElement):
- DumpRenderTree/chromium/AccessibilityController.h:
(WebKit):
(AccessibilityController):
(AccessibilityController::setWebView):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
- 8:51 PM Changeset in webkit [122803] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Implement decidePolicyForResponse in policy client
https://bugs.webkit.org/show_bug.cgi?id=91401
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-16
Reviewed by Kenneth Rohde Christiansen.
Provide implementation for decidePolicyForResponse callback
in WebKit2 EFL's policy client.
- UIProcess/API/efl/ewk_view_policy_client.cpp:
(decidePolicyForResponseCallback):
(ewk_view_policy_client_attach):
- 8:26 PM Changeset in webkit [122802] by
-
- 5 edits2 adds in trunk
REGRESSION: RenderInline::absoluteQuads produces incorrect results for fixed position.
https://bugs.webkit.org/show_bug.cgi?id=91451
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-16
Reviewed by Simon Fraser.
Source/WebCore:
RenderInline::absoluteQuads relies on copies of RenderGeometryMap,
created indirectly by passing AbsoluteQuadsGeneratorContext object by
value. These copies are unsafe because the individual transform steps
within the geometry map include a owned poitner to their respective
transform.
Modify the callee methods to take context by reference and disable
copy constructor for RenderGeometryMap.
Test: fast/inline/inline-fixed-position-boundingbox.html
- rendering/RenderGeometryMap.h:
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep): Add missing
m_offset to copy constructor initialization list.
(RenderGeometryMap): Disable copy constructor.
- rendering/RenderInline.cpp: Pass context object by reference.
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
- rendering/RenderInline.h:
(RenderInline::generateLineBoxRects): Update method declarations to
show pass by reference context parameter.
(RenderInline::generateCulledLineBoxRects): Ditto.
LayoutTests:
Add a regression test for boundingBox of an inline element with fixed position.
- fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
- fast/inline/inline-fixed-position-boundingbox.html: Added.
- 8:24 PM Changeset in webkit [122801] by
-
- 3 edits2 adds in trunk
Some events should be always stopped at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=90436
Reviewed by Ryosuke Niwa.
Source/WebCore:
The spec is here:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped
Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):
LayoutTests:
- fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt: Added.
- fast/dom/shadow/events-stopped-at-shadow-boundary.html: Added.
- 8:20 PM Changeset in webkit [122800] by
-
- 4 edits2 adds in trunk/Tools
[Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=91312
Reviewed by Ryosuke Niwa.
Looking forward to moving more objects into TestRunner.a, we're going
to need an object to own all the interfaces and to put them through
their lifecycle.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
- DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
- 8:09 PM Changeset in webkit [122799] by
-
- 14 edits in trunk
[EFL][WK2] Add APIs to support theme.
https://bugs.webkit.org/show_bug.cgi?id=90107
Reviewed by Hajime Morita.
Source/WebKit2:
RenderThemeEfl uses edj file to render native theme of form elements.
This patch provides default theme and a way to change edj theme file for
WebKit2/Efl.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_base_add):
(ewk_view_theme_set):
(ewk_view_theme_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::setThemePath):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::setThemePath):
Tools:
Override default theme path for MiniBrowser and WebKitTestRunner.
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/efl/main.c:
(browserCreate):
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 8:01 PM Changeset in webkit [122798] by
-
- 29 edits2 adds in trunk
[EFL][DRT] Implement dumpFrameScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=87638
Reviewed by Hajime Morita.
Tools:
- DumpRenderTree/efl/DumpRenderTree.cpp:
(dumpFrameScrollPosition): Implemented.
(shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
LayoutTests:
Updated expected results to dump scrolled position.
- platform/efl/compositing/geometry/fixed-in-composited-expected.txt:
- platform/efl/compositing/geometry/horizontal-scroll-composited-expected.txt:
- platform/efl/compositing/geometry/video-fixed-scrolling-expected.txt:
- platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
- platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt:
- platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt:
- platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
- platform/efl/fast/dom/focus-contenteditable-expected.txt:
- platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt:
- platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt:
- platform/efl/fast/dynamic/anchor-lock-expected.txt:
- platform/efl/fast/events/autoscroll-expected.txt:
- platform/efl/fast/events/reveal-link-when-focused-expected.txt:
- platform/efl/fast/layers/scroll-rect-to-visible-expected.txt:
- platform/efl/fast/multicol/scrolling-overflow-expected.txt: Added.
- platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
- platform/efl/fast/overflow/overflow_hidden-expected.txt:
- platform/efl/fast/overflow/position-fixed-transform-clipping-expected.txt:
- platform/efl/fast/overflow/scrollRevealButton-expected.txt:
- platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.txt:
- platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
- platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
- platform/efl/fast/repaint/fixed-expected.txt:
- platform/efl/fast/repaint/fixed-move-after-scroll-expected.txt:
- platform/efl/fast/repaint/fixed-tranformed-expected.txt:
- platform/efl/fast/repaint/repaint-during-scroll-expected.txt:
- platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
- platform/efl/transforms/2d/transform-fixed-container-expected.txt:
- 7:25 PM Changeset in webkit [122797] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r119948): [Form] HTMLInputElement.valueAsNumber for input type "month" should return number of month since January 1970
https://bugs.webkit.org/show_bug.cgi?id=91211
Reviewed by Kent Tamura.
This patch changes BaseDateAndTimeInputType::valueAsDouble() to call
virtual function parseToNumber() which "month" input type overrides
instead of non-virtual function parseToDouble() which returns number
of milliseconds.
No new tests. Existing test (fast/form/month/input-valueasnumber-month.html) coverts this, although it is disabled.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Changed to call parseToNumber().
(WebCore::BaseDateAndTimeInputType::parseToNumber): Changed to what parseToDouble() did.
- html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Remove parseToDouble().
- 7:10 PM Changeset in webkit [122796] by
-
- 3 edits in trunk/LayoutTests
Unreviewed chromium mac rebaseline of fast/text/textIteratorNilRenderer for r122769.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- 6:43 PM Changeset in webkit [122795] by
-
- 9 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out 122790 because it broke the Windows build. I'm not
sure what to do with exported symbols that are predicated on NDEBUG.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- bytecode/CodeBlock.cpp:
(JSC):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
- interpreter/Interpreter.h:
(Interpreter):
- jsc.cpp:
(GlobalObject::finishCreation):
- 6:39 PM Changeset in webkit [122794] by
-
- 29 edits1 delete in trunk/LayoutTests
Unreviewed chromium mac/win rebaseline for r122769.
- platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-win-xp/css1: Removed.
- platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-win/css1/basic/inheritance-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
- 6:38 PM Changeset in webkit [122793] by
-
- 2 edits in branches/chromium/1180
Merge 122212 -
RTL calendar picker for <input type=date> is too narrow and clipped
https://bugs.webkit.org/show_bug.cgi?id=90864
Reviewed by Kentaro Hara.
.:
- ManualTests/forms/calendar-picker.html:
- Add isRTL:true for the arabic setting
- Reset the iframe size when the setting is changed.
Source/WebCore:
Tests: ManualTests/forms/calendar-picker.html
- Resources/calendarPicker.js:
(fixWindowSize):
Checks the left edge of elemenets in RTL.
(layout): Add dir=ltr for the manual test, which re-uses the document.
TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10780025
- 6:33 PM Changeset in webkit [122792] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/html/ImageInputType.cpp
Merge 122418 -
Accessing width or height of a detached image input element causes crash
https://bugs.webkit.org/show_bug.cgi?id=90885
Reviewed by Kentaro Hara.
Source/WebCore:
Test: fast/forms/image/width-and-height-of-detached-input.html
- html/ImageInputType.cpp:
(WebCore::ImageInputType::height): Add null check for m_imageLoader.
(WebCore::ImageInputType::width): ditto.
LayoutTests:
- fast/forms/image/width-and-height-of-detached-input-expected.txt: Added.
- fast/forms/image/width-and-height-of-detached-input.html: Added.
TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10780024
- 6:24 PM Changeset in webkit [122791] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438
Reviewed by Kenneth Russell.
r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.
This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
- 6:14 PM Changeset in webkit [122790] by
-
- 9 edits in trunk/Source/JavaScriptCore
dumpCallFrame is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=91444
Reviewed by Gavin Barraclough.
Various changes have been made to the SF calling convention, but
dumpCallFrame has not been updated to reflect these changes.
That resulted in both bogus information, as well as numerous
assertions of sadness.
This patch makes dumpCallFrame actually work again and adds the
wonderful feature of telling you the name of the variable that a
register reflects, or what value it contains.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
A really innefficient mechanism for finding the name of a local register.
This should only ever be used by debug code so this should be okay.
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
Debug builds no longer throw away a functions symbol table, this allows
us to actually perform a register# to name mapping
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
We weren't propogating the bytecode offset here leading to assertions
in debug builds when dumping bytecode of DFG compiled code.
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
Rework to actually be correct.
(JSC::getCallerInfo):
Return the byteocde offset as well now, given we have to determine it
anyway.
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
- interpreter/Interpreter.h:
(Interpreter):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionDumpCallFrame):
Give debug builds of JSC a method for calling dumpCallFrame so we can
inspect a callframe without requiring us to break in a debugger.
- 5:57 PM Changeset in webkit [122789] by
-
- 1 edit2 adds in trunk/Tools
NRWRT Should provide a VS project to work on
https://bugs.webkit.org/show_bug.cgi?id=91436
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-16
Reviewed by Dirk Pranke.
Adding VS2010 project for modifying webkitpy. Uses pytools
<http://pytools.codeplex.com> which integrates python into
Visual Studio.
- Scripts/webkitpy/webkitpy.pyproj: Added.
- Scripts/webkitpy/webkitpy.sln: Added.
- 5:57 PM Changeset in webkit [122788] by
-
- 6 edits1 add in trunk/Source
Vertical alternate glyph (GSUB) support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81389
Patch by Koji Ishii <Koji Ishii> on 2012-07-16
Reviewed by Tony Chang.
Source/WebCore:
This patch adds support for reading 'GSUB' OpenType table to get
vertical alternate glyphs.
http://www.microsoft.com/typography/otspec/gsub.htm
Like bug 81326, this code isn't on any code path yet.
Tests: WebKit/chromium/tests/OpenTypeVerticalDataTest.cpp
- platform/graphics/opentype/OpenTypeTypes.h:
(WebCore::OpenType::validateTable): Moved from OpenTypeVerticalData.cpp for unit tests.
(OpenType):
(TableBase): Ditto.
(WebCore::OpenType::TableBase::isValidEnd):
(WebCore::OpenType::TableBase::validatePtr):
(WebCore::OpenType::TableBase::validateOffset):
- platform/graphics/opentype/OpenTypeVerticalData.cpp:
(OpenType): Added several OpenType tables used by 'GSUB' table.
(CoverageTable):
(Coverage1Table):
(Coverage2Table):
(RangeRecord):
(SubstitutionSubTable):
(WebCore::OpenType::SubstitutionSubTable::coverage):
(SingleSubstitution2SubTable):
(LookupTable):
(WebCore::OpenType::LookupTable::getSubstitutions):
(LookupList):
(WebCore::OpenType::LookupList::lookup):
(FeatureTable):
(WebCore::OpenType::FeatureTable::getGlyphSubstitutions):
(FeatureList):
(FeatureRecord):
(WebCore::OpenType::FeatureList::feature):
(LangSysTable):
(WebCore::OpenType::LangSysTable::feature):
(ScriptTable):
(LangSysRecord):
(WebCore::OpenType::ScriptTable::defaultLangSys):
(ScriptList):
(ScriptRecord):
(WebCore::OpenType::ScriptList::script):
(WebCore::OpenType::ScriptList::defaultScript):
(WebCore::OpenType::ScriptList::defaultLangSys):
(GSUBTable):
(WebCore::OpenType::GSUBTable::scriptList):
(WebCore::OpenType::GSUBTable::featureList):
(WebCore::OpenType::GSUBTable::lookupList):
(WebCore::OpenType::GSUBTable::defaultLangSys):
(WebCore::OpenType::GSUBTable::feature):
(WebCore::OpenType::GSUBTable::getVerticalGlyphSubstitutions):
(WebCore::OpenTypeVerticalData::OpenTypeVerticalData):
(WebCore::OpenTypeVerticalData::loadMetrics): Split code to load metrics from ctor.
(WebCore::OpenTypeVerticalData::loadVerticalGlyphSubstitutions): Load the vertical alternate Glyph substitution table.
(WebCore):
(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs): Substitute Glyph IDs with vertical alternate Glyph IDs.
- platform/graphics/opentype/OpenTypeVerticalData.h:
(OpenTypeVerticalData): Added m_verticalGlyphMap.
Source/WebKit/chromium:
Tests for pointer validations for OpenType tables.
- WebKit.gypi:
- tests/OpenTypeVerticalDataTest.cpp: Added.
(WebCore):
(TestTable):
(WebCore::TestTable::validateOffset):
(WebCore::TEST):
- 5:52 PM Changeset in webkit [122787] by
-
- 6 edits in trunk/Source/WebCore
Fix spelling of EnforceIFrameAllowFullScreenRequirement and ExemptIFrameAllowFullScreenRequirement.
https://bugs.webkit.org/show_bug.cgi?id=91437
Reviewed by Adrienne Walker.
Document contained spelling errors of 'FulScreen' instead of 'FullScreen'
for the FullScreenCheckType enumeration.
No test changes needed.
- dom/Document.cpp:
(WebCore::Document::requestFullScreenForElement):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::webkitRequestFullscreen):
(WebCore::Element::webkitRequestFullScreen):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
- 5:48 PM Changeset in webkit [122786] by
-
- 2 edits in trunk/Source/WebCore
Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why
https://bugs.webkit.org/show_bug.cgi?id=91174
Reviewed by Kent Tamura.
Clarified the explanation.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer):
- 5:46 PM Changeset in webkit [122785] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r120033.
http://trac.webkit.org/changeset/120033
https://bugs.webkit.org/show_bug.cgi?id=91454
Broke background gradients (Requested by smfr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
- 5:44 PM Changeset in webkit [122784] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp
Revert 120033 - GeneratorGeneratedImage should cache images for the non-tiled case
https://bugs.webkit.org/show_bug.cgi?id=87094
Patch by Jin Yang <jin.a.yang@intel.com> on 2012-06-11
Reviewed by Simon Fraser.
Source/WebCore:
We cache the generated image if generator is not changed. By compared
with generating image on the fly, it will lose a little pixel precision
and several layout tests should be rebaselined. With this patch, the IE test
drive benchmark "Bayou" can gain about 50%.
No new tests. Performance optimization.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
LayoutTests:
Update expectations: added failures for baselines to come.
- platform/chromium/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10787031
- 5:43 PM Changeset in webkit [122783] by
-
- 4 edits6 moves1 delete in trunk/Tools
[Chromium] Move GamepadController into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91311
Reviewed by Tony Chang.
GamepadController looks like a simple class to move into TestRunner.a
because it has almost zero dependence on TestShell.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
- DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
- DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
- DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
- GamepadController depends on these bindings helpers.
- DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
- DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
- Just moved these files and removed the unused TestShell references.
- DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
- No longer needed.
- DumpRenderTree/chromium/TestShell.cpp:
- Update call to constructor to avoid passing in this.
- 5:31 PM Changeset in webkit [122782] by
-
- 8 edits3 adds in trunk
IndexedDB: Implement spec updates to IDBTransaction.error
https://bugs.webkit.org/show_bug.cgi?id=91409
Reviewed by Tony Chang.
Source/WebCore:
The Indexed DB spec was updated to resolve some edge cases around the
IDBTransaction.error attribute. It was agreed that accessing error should
never throw, error should be null if the transaction is not finished or
abort() was explicitly called, an appropriate error should be returned if
a commit failed, and a generic AbortError should be used if a request
callback throws. These cases are now handled per spec, except that a reason
is not provided for the commit failure (it's always UnknownError).
Test: storage/indexeddb/transaction-error.html
storage/indexeddb/transaction-abort.html
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent): Refactor some nested if() blocks; don't
re-abort the transaction if dispatching in response to an abort.
(WebCore::IDBRequest::uncaughtExceptionInEventHandler): Abort transaction
only if not already aborting, and set it's error to AbortError.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Set error if abort triggered by back end.
- Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::db): Move impl to header file.
(WebCore::IDBTransaction::error): Move impl to header file, simplify.
(IDBTransaction):
- Modules/indexeddb/IDBTransaction.idl: The error attribute no longer throws.
LayoutTests:
Update transaction-abort test to accomodate refinements in the spec around
IDBTransaction.error and add a dedicated test to exercise all spec behavior
for the property.
- storage/indexeddb/resources/transaction-abort.js:
(startTest):
(firstAdd):
(secondAdd):
(transactionAborted):
- storage/indexeddb/resources/transaction-error.js: Added.
(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(startTest.trans.onabort):
(startTest):
(testErrorFromRequest.request.onerror):
(testErrorFromRequest.trans.onabort):
(testErrorFromRequest):
(testErrorFromException.request.onerror):
(testErrorFromException.trans.onabort):
(testErrorFromException):
- storage/indexeddb/transaction-abort-expected.txt:
- storage/indexeddb/transaction-error-expected.txt: Added.
- storage/indexeddb/transaction-error.html: Added.
- 5:31 PM Changeset in webkit [122781] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix WebFrameTest flakiness due to synthetic mouse events
https://bugs.webkit.org/show_bug.cgi?id=91428
Patch by Alexandre Elias <aelias@google.com> on 2012-07-16
Reviewed by Adam Barth.
Synthetic mouse move events on scrolling can cause segfaults in
WebFrameTest due to delayed callbacks on the message loop after
state destruction. This is currently only affecting
the Android port, but has the potential to affect other platforms in the
future.
We can avoid the issue by disabling the deviceSupportsMouse
setting, which shouldn't be needed by any WebFrameTest.
- tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::createWebViewAndLoad):
- 5:03 PM Changeset in webkit [122780] by
-
- 10 edits in trunk
Source/WebCore: IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.
Refactor IndexWriter to depend only on IDBIndexMetadata and on
(databaseId, objectStoreId, indexId) so that it can talk directly
to the backing store, and also eventually be moved into the renderer.
This also introduces IDBObjectStoreBackendInterface::putWithIndexKeys
as a replacement for IDBObjectStoreBackendInterface::put, already
stubbed out in the chromium port. It will fully replace put()
after both chromium and webkit sides have reached alignment.
No new tests as this is just a refactor and existing tests cover
correctness.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
- Modules/indexeddb/IDBIndexBackendImpl.h:
- Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
Source/WebKit/chromium: IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.
Stub out implementations of putWithIndexKeys(), already implemented
on the chromium side.
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::putWithIndexKeys):
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
- src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
Tools: [Chromium-android] Don't use test_shell mode of DRT
https://bugs.webkit.org/show_bug.cgi?id=88542
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-07-16
Reviewed by Dirk Pranke.
Test shell mode is about to be removed.
Switch to use DRT mode for chromium-android.
Summary of changes:
- ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
- Conforms to the DRT mode protocol for input/output of DumpRenderTree.
- Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
- DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter::handleImage): Outputs base64 on Android.
- DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit): Changed err_file to err_fifo, required by python ServerProcess.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
(ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver.cmd_line):
(ChromiumAndroidDriver._deadlock_detector):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver.start):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._command_from_driver_input):
(ChromiumAndroidDriver._read_prompt):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_driver_cmd_line):
(ChromiumAndroidDriverTest.test_cmd_line):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.test_drt_cmd_line):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_command_from_driver_input):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.init): Added universal_newlines to handle Android 'adb shell' line ends.
(ServerProcess._start):
(ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
(ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
(ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input):
(WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(MockServerProcess.read_stdout):
(MockServerProcess.start):
(MockServerProcess):
(MockServerProcess.stop):
(MockServerProcess.kill):
(WebKitDriverTest.test_read_block):
(WebKitDriverTest.test_read_binary_block):
(WebKitDriverTest.test_read_base64_block):
- 4:58 PM Changeset in webkit [122779] by
-
- 13 edits in trunk/Source
IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.
Source/WebCore:
Refactor IndexWriter to depend only on IDBIndexMetadata and on
(databaseId, objectStoreId, indexId) so that it can talk directly
to the backing store, and also eventually be moved into the renderer.
This also introduces IDBObjectStoreBackendInterface::putWithIndexKeys
as a replacement for IDBObjectStoreBackendInterface::put, already
stubbed out in the chromium port. It will fully replace put()
after both chromium and webkit sides have reached alignment.
No new tests as this is just a refactor and existing tests cover
correctness.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
- Modules/indexeddb/IDBIndexBackendImpl.h:
- Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
Source/WebKit/chromium:
Stub out implementations of putWithIndexKeys(), already implemented
on the chromium side.
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::putWithIndexKeys):
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
- src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
- 4:47 PM Changeset in webkit [122778] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Layout Test plugins/embed-attributes-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91445
Started failing around r122770
- platform/chromium/TestExpectations:
- 4:46 PM Changeset in webkit [122777] by
-
- 6 edits in trunk/Tools
nrwt: move a bunch of printing code from manager.py to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91439
Reviewed by Ojan Vafai.
All of the logic that handles what gets logged should eventually
live in printing.py; this patch moves a large chunk of code that
prints all of the stuff after the run completes.
There are no functional changes, this is just moving code
around. Covered by existing tests (updated as necessary).
This code is all pretty messy and most of it should be deleted
(or extracted after the fact from results.json), but I'm saving
that for further patches. My goal is just to manager.py to a
more manageable state.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._num_digits):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ResultSummaryTest.summarized_results):
- Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.init):
(ResultSummary.add):
Here we had to add a list of the slow tests to the result
summary so that we didn't need to call back into the manager and
the test expectations object to figure out if a test is SLOW.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_results):
(Printer):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):
- 4:45 PM Changeset in webkit [122776] by
-
- 15 edits in trunk/Source
[chromium] Unify compositor quad transforms into content space
https://bugs.webkit.org/show_bug.cgi?id=91350
Reviewed by Kenneth Russell.
Source/WebCore:
For the purpose of simplification and as a first step towards removing
any transform that takes a centered rect, remove the ability of layers
to override the quad transform. All quads and quad transforms operate
on content space with the origin in the top left.
The gutter quads used to use the root layer (that doesn't draw
content) as the layer to create the shared quad state from. This is
now created manually as a layer without bounds should never in general
need a shared quad state created for it.
No change in functionality; tested by existing layout and unit tests.
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::createSharedQuadState):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
Source/WebKit/chromium:
Update tests to add bounds/contentBounds properties to layers. This
exposed a bug in the quad culler tests where the draw transform was
incorrectly being set to the origin transform rather than being a
transform that operates on centered layer rects. Fixed this bug.
- tests/CCQuadCullerTest.cpp:
- tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
- tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::createLayer):
- 4:05 PM Changeset in webkit [122775] by
-
- 7 edits in trunk
IndexedDB: Resolve test and IDL FIXMEs for a handful of landed patches
https://bugs.webkit.org/show_bug.cgi?id=91423
Reviewed by Tony Chang.
Source/WebCore:
IDBObjectStore.createIndex() had a hack to handle a null keyPath argument for the
DOMString[] overload and treat it as the string "null". Now that IDL arrays are not
nullable by default following r121817 this hack can be removed and the binding layer
will automagically coerce to DOMString.
Test: storage/indexeddb/keypath-basics.html
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex): Remove special case for null in DOMString[] overload.
- Modules/indexeddb/IDBObjectStore.idl: Remove Nullable suffix from DOMString[] overload
so that the DOMString overload will match null.
LayoutTests:
Resolve a couple of test-only FIXMEs: range deletion is now supported and
empty transactions commit.
- storage/indexeddb/key-generator-expected.txt:
- storage/indexeddb/resources/database-closepending-flag.js:
(testDatabaseClosingSteps): Don't need a dummy request to keep transaction alive.
- storage/indexeddb/resources/key-generator.js: Can test a range delete now.
- 3:52 PM Changeset in webkit [122774] by
-
- 3 edits2 adds in trunk/Tools
[Chromium] Create a stub TestRunner.a target
https://bugs.webkit.org/show_bug.cgi?id=91309
Reviewed by Ryosuke Niwa.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
- 3:48 PM Changeset in webkit [122773] by
-
- 13 edits5 adds in trunk
Resolve CSS Exclusions shapeInside, shapeOutside properties to Length based WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=89670
Patch by Bear Travis <betravis@adobe.com> on 2012-07-16
Reviewed by Dirk Schulze.
Source/WebCore:
Layout of CSS Exclusions requires length based WrapShape classes,
rather than the existing CSSValue based CSSWrapShape classes. This
patch adds length based WrapShape analogs to the CSSWrapShapes, and
modifies RenderStyle to use a WrapShape instead of a CSSWrapShape.
The translation between WrapShape and CSSWrapShape classes
is handled by helper functions in the new WrapShapeFunctions files.
StyleBuilder resolves CSSWrapShapes to WrapShapes for layout use.
CSSComputedStyleDeclaration translates WrapShapes to CSSWrapShapes
for style use.
There are existing tests that cover the style serialization / resolution
in fast/exclusions/parsing-wrap-shape-inside.html and
fast/exclusions/parsing/wrap-shape-outside.html
Test: fast/exclusions/parsing-wrap-shape-lengths.html
- CMakeLists.txt: Build system changes for adding new files
- GNUmakefile.list.am: Ditto
- Target.pri: Ditto
- WebCore.gypi: Ditto
- WebCore.vcproj/WebCore.vcproj: Ditto
- WebCore.xcodeproj/project.pbxproj: Ditto
- css/CSSComputedStyleDeclaration.cpp: Translate WrapShapes back to CSSWrapShapes
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSWrapShapes.h: Mostly changing functions to be const
(WebCore::CSSWrapShapeRectangle::type):
(WebCore::CSSWrapShapeCircle::type):
(WebCore::CSSWrapShapeEllipse::type):
(WebCore::CSSWrapShapePolygon::getXAt):
(WebCore::CSSWrapShapePolygon::getYAt):
(WebCore::CSSWrapShapePolygon::values):
(WebCore::CSSWrapShapePolygon::type):
- css/StyleBuilder.cpp: Resolve CSSWrapShapes to WrapShapes
(WebCore):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):
- css/WrapShapeFunctions.cpp: Added.
(WebCore):
(WebCore::valueForWrapShape):
(WebCore::convertToLength):
(WebCore::wrapShapeForValue):
- css/WrapShapeFunctions.h: Added.
(WebCore):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- rendering/style/WrapShapes.h: Added.
(WebCore):
(WrapShape):
(WebCore::WrapShape::~WrapShape):
(WebCore::WrapShape::WrapShape):
(WrapShapeRectangle):
(WebCore::WrapShapeRectangle::create):
(WebCore::WrapShapeRectangle::left):
(WebCore::WrapShapeRectangle::top):
(WebCore::WrapShapeRectangle::width):
(WebCore::WrapShapeRectangle::height):
(WebCore::WrapShapeRectangle::cornerRadiusX):
(WebCore::WrapShapeRectangle::cornerRadiusY):
(WebCore::WrapShapeRectangle::setLeft):
(WebCore::WrapShapeRectangle::setTop):
(WebCore::WrapShapeRectangle::setWidth):
(WebCore::WrapShapeRectangle::setHeight):
(WebCore::WrapShapeRectangle::setCornerRadiusX):
(WebCore::WrapShapeRectangle::setCornerRadiusY):
(WebCore::WrapShapeRectangle::type):
(WebCore::WrapShapeRectangle::WrapShapeRectangle):
(WrapShapeCircle):
(WebCore::WrapShapeCircle::create):
(WebCore::WrapShapeCircle::left):
(WebCore::WrapShapeCircle::top):
(WebCore::WrapShapeCircle::radius):
(WebCore::WrapShapeCircle::setLeft):
(WebCore::WrapShapeCircle::setTop):
(WebCore::WrapShapeCircle::setRadius):
(WebCore::WrapShapeCircle::type):
(WebCore::WrapShapeCircle::WrapShapeCircle):
(WrapShapeEllipse):
(WebCore::WrapShapeEllipse::create):
(WebCore::WrapShapeEllipse::top):
(WebCore::WrapShapeEllipse::left):
(WebCore::WrapShapeEllipse::radiusX):
(WebCore::WrapShapeEllipse::radiusY):
(WebCore::WrapShapeEllipse::setTop):
(WebCore::WrapShapeEllipse::setLeft):
(WebCore::WrapShapeEllipse::setRadiusX):
(WebCore::WrapShapeEllipse::setRadiusY):
(WebCore::WrapShapeEllipse::type):
(WebCore::WrapShapeEllipse::WrapShapeEllipse):
(WrapShapePolygon):
(WebCore::WrapShapePolygon::create):
(WebCore::WrapShapePolygon::windRule):
(WebCore::WrapShapePolygon::values):
(WebCore::WrapShapePolygon::getXAt):
(WebCore::WrapShapePolygon::getYAt):
(WebCore::WrapShapePolygon::setWindRule):
(WebCore::WrapShapePolygon::appendPoint):
(WebCore::WrapShapePolygon::type):
(WebCore::WrapShapePolygon::WrapShapePolygon):
LayoutTests:
Test that wrap shapes accept different length types
Wrap shape parsing and serialization is tested by parsing-wrap-shape-inside/outside
- fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Added.
- fast/exclusions/parsing-wrap-shape-lengths.html: Added.
- 3:34 PM Changeset in webkit [122772] by
-
- 2 edits in trunk/LayoutTests
[chromium] Assign some bug numbers to failing tests.
- platform/chromium/TestExpectations:
- 3:17 PM Changeset in webkit [122771] by
-
- 1 edit2 adds in trunk/Source/JavaScriptCore
Unreviewed, adding forgotten files.
- dfg/DFGRegisterSet.h: Added.
(DFG):
(RegisterSet):
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):
- dfg/DFGScratchRegisterAllocator.h: Added.
(DFG):
(ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
- 3:17 PM Changeset in webkit [122770] by
-
- 3 edits2 adds in trunk
Fix compositing layers in columns when in paginated mode
https://bugs.webkit.org/show_bug.cgi?id=91425
Reviewed by Dave Hyatt.
Source/WebCore:
Enhance a hack that was added to allow composited layers to
display in columns to work for paginated mode, where the
RenderView is renderer with columns.
Test: compositing/columns/composited-in-paginated.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
LayoutTests:
Testcase with a composited layer in a paginated document,
that dumps layers.
- compositing/columns/composited-in-paginated-expected.txt: Added.
- compositing/columns/composited-in-paginated.html: Added.
- 3:10 PM Changeset in webkit [122769] by
-
- 23 edits2 adds in trunk
Inconsistent rounding in table layout causes background color to bleed through
https://bugs.webkit.org/show_bug.cgi?id=91410
Reviewed by Eric Seidel.
Source/WebCore:
At certain zoom levels a rounding error in the table layout code cases
the table background color to bleed through between cells. Tables layout
happens on pixel bounds however the paint offset wasn't correctly rounded.
Test: fast/sub-pixel/table-rows-no-gaps.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
Round paintOffset before passing it to the paint method of the children.
LayoutTests:
Add test to ensure that the table background color doesn't bleed through
when the table and a cell are positioned on a subpixel bound.
- fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
- fast/sub-pixel/table-rows-no-gaps.html: Added.
- platform/chromium-linux/css1/basic/inheritance-expected.png:
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
Updated expectations to match new rounding logic. The new results better
match the rendering prior to turning on subpixel layout.
- platform/efl/Skipped:
- platform/mac-lion/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/Skipped:
- platform/qt-4.8/Skipped:
- platform/qt/Skipped:
- platform/win-wk2/Skipped:
- platform/win-xp/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
Mark new test as skipped on platforms that have not enabled subpixel
layout.
- 3:08 PM Changeset in webkit [122768] by
-
- 17 edits in trunk/Source/JavaScriptCore
DFG PutById transition should handle storage allocation, and inline it
https://bugs.webkit.org/show_bug.cgi?id=91337
Reviewed by Oliver Hunt.
This enables the patching of DFG PutById to handle the out-of-line storage
allocation case. Furthermore, it inlines out-of-line storage allocation (and
reallocation) into the generated stubs.
To do this, this patch adds the ability to store the relevant register
allocation state (i.e. the set of in-use registers) in the structure stub
info so that the stub generation code can more flexibly select scratch
registers: sometimes it needs none, sometimes one - or sometimes up to
three. Moreover, to make the stub generation register allocation simple and
maintainable, this patch introduces a reusable scratch register allocator
class. This register allocator understands that some registers are in use by
the main path code and so must be spilled as necessary, other registers are
locked for use in the stub itself and so cannot even be spilled, while still
others may be allocated for scratch purposes. A scratch register that is
used must be spilled. If a register is locked, it cannot be used as a
scratch register. If a register is used, it can be used as a scratch
register so long as it is spilled.
This is a sub-1% speed-up on V8 and neutral elsewhere.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerCodeRef.h:
(FunctionPtr):
(JSC::FunctionPtr::FunctionPtr):
- bytecode/StructureStubInfo.h:
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
- dfg/DFGGPRInfo.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::isInUse):
(RegisterBank):
- dfg/DFGRegisterSet.h: Added.
(DFG):
(RegisterSet):
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
- dfg/DFGScratchRegisterAllocator.h: Added.
(DFG):
(ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::usedRegisters):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
- heap/CopiedAllocator.h:
(CopiedAllocator):
(JSC::CopiedAllocator::fastPathShouldSucceed):
(JSC):
- 2:35 PM Changeset in webkit [122767] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r122739.
http://trac.webkit.org/changeset/122739
https://bugs.webkit.org/show_bug.cgi?id=91424
Broke mac builds (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16
- inspector/CodeGeneratorInspector.py:
(flatten_list):
- 2:30 PM Changeset in webkit [122766] by
-
- 11 edits in trunk/Source/WebCore
[chromium] Remove non-ephemeral data from RenderSurface as it duplicates data from the owning layer
https://bugs.webkit.org/show_bug.cgi?id=91418
Reviewed by Adrienne Walker.
This removes the filters and masks from render surfaces, and makes them
used directly from the owning layer. Also removes skipsDraw from
surfaces as it was just not used at all.
Covered by existing tests.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::filters):
(WebCore::LayerChromium::backgroundFilters):
(WebCore::LayerChromium::hasMask):
(WebCore::LayerChromium::hasReplica):
(WebCore::LayerChromium::replicaHasMask):
(LayerChromium):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::hasMask):
(WebCore::CCLayerImpl::hasReplica):
(WebCore::CCLayerImpl::replicaHasMask):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::calculateMemoryForRenderSurfaces):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::finishedRenderTarget):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToRenderTarget):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::appendQuads):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
- 2:18 PM Changeset in webkit [122765] by
-
- 2 edits in trunk/Source/WTF
Unreviewed build fix.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 2:13 PM Changeset in webkit [122764] by
-
- 6 edits in trunk/Tools
test-webkitpy: clean up logging to make it ninja-esque
https://bugs.webkit.org/show_bug.cgi?id=91297
Reviewed by Adam Barth.
This patch changes the output of test-webkitpy to be closer to
what ninja produces. Namely:
If you are running with stderr writing to a tty (and not -v), we
will no longer print '...' as tests complete. Instead, we use a
metered stream and print entries of the form:
'[X/Y] test_name passed/failed/erred'
where X is the current test # and Y is the total number of tests.
If you are running with stderr piped to a file or other non-tty
object (or with -v), you get the same output, one per line for
every test.
In addition, if tests fail or err out, you get the stack trace
immediately; you don't have to wait until the end of the run.
Lastly, this change cleans up the unit tests for test-webkitpy
itself to not confuse the logger and to work cleanly w/ multiple
processes. It looks like between this and all the clean up in
MessagePool that happened as it landed, we can now run
multiprocessing tests in parallel.
- Scripts/webkitpy/test/finder.py:
(Finder._default_names):
- Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.setUp):
(FinderTest.tearDown):
- Scripts/webkitpy/test/printer.py:
(Printer.init):
(Printer.configure):
(Printer.print_started_test):
(Printer.print_finished_test):
(Printer._test_line):
(Printer.print_result):
- Scripts/webkitpy/test/runner.py:
(Runner.run):
- Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.setUp):
(RunnerTest):
(RunnerTest.tearDown):
(RunnerTest.assert_run):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
- 2:13 PM Changeset in webkit [122763] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Layout Test svg/W3C-SVG-1.1/animate-elem-39-t.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=91421
This test is flaky (crashing) on the Win7 bot and has been for some time.
- platform/chromium/TestExpectations:
- 2:11 PM Changeset in webkit [122762] by
-
- 3 edits in branches/chromium/1180/Source/WebCore/inspector
Merge 120822 - Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567
Reviewed by Pavel Feldman.
When inspector state is restored only report existing context ids
if "did commit load" even has already been dispatched.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::restore):
- inspector/PageRuntimeAgent.h:
(WebCore):
(WebCore::PageRuntimeAgent::create):
(PageRuntimeAgent):
TBR=yurys@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10779021
- 2:06 PM Changeset in webkit [122761] by
-
- 11 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=91299
Paginated views should restrict available height to column height
-and corresponding-
<rdar://problem/11152108>
Reviewed by Dan Bernstein.
Source/WebCore:
Now that RenderViews can have columns, availableLogicalHeight needs to consider
that column height, much like how availableLogicalWidth already considers column
width.
availableLogicalHeight is newly virtual, like the already-virtual
availableLogicalWidth.
- rendering/RenderBox.h:
(RenderBox):
Check with the columnHeight.
- rendering/RenderView.cpp:
(WebCore):
(WebCore::RenderView::availableLogicalHeight):
- rendering/RenderView.h:
setPagination now takes pageLength as an optional parameter.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setPagination):
- testing/InternalSettings.h:
(WebCore::InternalSettings::setPagination):
(InternalSettings):
- testing/InternalSettings.idl:
- testing/Internals.cpp:
(WebCore::Internals::setPagination):
- testing/Internals.h:
(WebCore::Internals::setPagination):
(Internals):
- testing/Internals.idl:
LayoutTests:
New test.
- fast/multicol/resources/big-green.png: Added.
- fast/multicol/shrink-to-column-height-for-pagination.html: Added.
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
- 2:06 PM Changeset in webkit [122760] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Adobe Web Platform Team Blog is missing from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=91407
Reviewed by Andreas Kling.
Adding Adobe Web Platform Team Blog feed to Planet WebKit.
- config.ini:
- 2:06 PM Changeset in webkit [122759] by
-
- 3 edits in trunk/Tools
test-webkitpy: handle failures properly when running in parallel
https://bugs.webkit.org/show_bug.cgi?id=91416
Reviewed by Tony Chang.
It turns out that unittest.TestResults contain a handle to the
test method itself, which isn't picklable; it's sufficient to just
store the test name instead of the actual method. By doing so
we can move the test_name() method from the printer to the
runner where it belongs (so the printer is less dependent on the
unittest framework's data structures).
This change should really have a test but I don't know how to
write one that properly captures the behavior and won't cause
test-webkitpy itself to fail. I've verified the fix by hand, at
least, in the meantime.
- Scripts/webkitpy/test/printer.py:
(Printer.init):
(Printer.print_result):
- Scripts/webkitpy/test/runner.py:
(_test_name):
(Runner.all_test_names):
(_Worker.handle):
- 1:48 PM Changeset in webkit [122758] by
-
- 4 edits in trunk/LayoutTests
Fix Layout Test pointer-lock/locked-element-removed-from-dom.html flakiness.
https://bugs.webkit.org/show_bug.cgi?id=91373
Reviewed by Adrienne Walker.
pointer-lock-test-harness corrected to no longer silently allow too many
asynchronous doNextStep calls in a test. The locked-element-removed-from-dom test
generated too many events and incorrectly exited the test early.
- platform/chromium/TestExpectations:
Re-enabled locked-element-removed-from-dom test.html
- pointer-lock/locked-element-removed-from-dom.html:
Absorb extra doNextStep.
- pointer-lock/resources/pointer-lock-test-harness.js:
(doNextStep.setTimeout):
Fail tests that call doNextStep too many times.
- 1:44 PM Changeset in webkit [122757] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Any webpage can crash webkit via qnx.callExtensionMethod assuming 'this' is the 'qnx' object.
https://bugs.webkit.org/show_bug.cgi?id=91419
Run the following in inspector to crash WebKit
qnx.callExtensionMethod.apply(window, []);
In the c++ that handles the function it assumes that when callExtensionMethod
is called that 'this' is the object 'qnx'. The qnx object has a hidden
variable that the code casts and uses, but when 'this' is not qnx such as the
example this will cause a crash. Any website can insert the above JavaScript
to cause the crash.
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-16
Reviewed by Yong Li.
- WebCoreSupport/ClientExtension.cpp:
(clientExtensionMethod):
- 1:39 PM Changeset in webkit [122756] by
-
- 23 edits in trunk/Source
[chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into
https://bugs.webkit.org/show_bug.cgi?id=91288
Reviewed by Adrienne Walker.
Source/WebCore:
Always use pointers to layers when discussing render targets instead of
pointing directly to a RenderSurface.
Covered by existing tests.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::createRenderSurface):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::renderTarget):
(WebCore::LayerChromium::setRenderTarget):
(LayerChromium):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/RenderSurfaceChromium.h:
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::dumpLayerProperties):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::renderTarget):
(WebCore::CCLayerImpl::setRenderTarget):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateLayerScissorRect):
(WebCore::calculateSurfaceScissorRect):
(WebCore::calculateVisibleContentRect):
(WebCore::computeScrollCompensationForThisLayer):
(WebCore::calculateDrawTransformsInternal):
(WebCore::pointIsClippedBySurfaceOrClipRect):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::enterLayer):
(WebCore::::leaveLayer):
(WebCore::::enterRenderTarget):
(WebCore::::finishedRenderTarget):
(WebCore):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToRenderTarget):
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore::::layerScissorRectInTargetSurface):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::StackObject::StackObject):
(StackObject):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::appendSurface):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
- tests/CCQuadCullerTest.cpp:
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeTiledLayerChromium::setTexturePriorities):
- tests/LayerChromiumTest.cpp:
- 1:31 PM Changeset in webkit [122755] by
-
- 3 edits2 adds in trunk
SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326
Reviewed by Simon Fraser.
SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.
Source/WebCore:
Test: svg/animations/smil-setcurrenttime-crash.svg
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
- svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
- svg/animations/smil-setcurrenttime-crash.svg: Added.
- 1:29 PM Changeset in webkit [122754] by
-
- 12 edits in trunk/Source
[BlackBerry] Upstream WebGL Code
https://bugs.webkit.org/show_bug.cgi?id=91143
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-16
Reviewed by Rob Buis.
This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation.
Source/WebCore:
No new tests, because there is no new functionality.
- platform/graphics/GraphicsContext3D.h: Add a value for TI Imagination chipsets on BlackBerry platforms
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp: Multiple downstream changes
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore):
(WebCore::GraphicsContext3D::logFrameBufferStatus):
(WebCore::GraphicsContext3D::readPixelsIMG): BlackBerry-specific fix for Imagination hardware.
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary whitespace.
(Extensions3DOpenGL):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Hack to fix ANGLE-generated code on BlackBerry platforms.
- platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(Extensions3DOpenGLCommon):
- platform/graphics/opengl/Extensions3DOpenGLES.cpp: I am not in a position to change system headers from correct to incorrect.
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisample):
(WebCore::Extensions3DOpenGLES::supportsExtension):
- platform/graphics/opengl/Extensions3DOpenGLES.h: I am not in a position to change system headers from correct to incorrect.
(Extensions3DOpenGLES):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Add a BlackBerry-specific anti-aliasing fix.
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore):
Source/WebKit:
- PlatformBlackBerry.cmake: Define WTF_USE_OPENGL_ES_2 on WebGL-enabled builds.
- 1:06 PM Changeset in webkit [122753] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add dfg switch to create_jit_stubs script
https://bugs.webkit.org/show_bug.cgi?id=91256
Reviewed by Geoffrey Garen.
- create_jit_stubs: Add a switch to enable or disable the generation of
stub functions in #if ENABLE(DFG_JIT) conditions.
- 12:55 PM Changeset in webkit [122752] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Layout Test fast/frames/calculate-fixed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=91415
Has been intermittently failing TEXT since at least r122699.
- platform/chromium/TestExpectations:
- 12:50 PM Changeset in webkit [122751] by
-
- 1 edit3 copies in branches/chromium/1180
Merge 122529 - [chromium] Root invalidations for RTL pages need to be in the right space
https://bugs.webkit.org/show_bug.cgi?id=91155
Reviewed by Kenneth Russell.
Source/WebKit/chromium:
The root layer has a translation on it when placed in the tree, so any
invalidations on this layer likewise need to be adjusted.
This adjustment is due to the fact that compositor layers all have the
origin in the upper left corner of the layer, but this is not always
the origin for graphics layers. Rather than making compositor layers
have to deal with a potential offset, we change the transform when
inserting the layer into the tree. Invalidations need to be similarly
transformed from document space into compositor layer space.
The need for this offset is due to the definition of the initial
containing block. RTL pages (pages with dir=RTL on the body) start
scrolled all the way to the right, and the origin is in the upper left
hand corner of this initial viewport. Thus on RTL pages with
horizontal overflow, the left of the document is in negative CSS
space.
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::invalidateRect):
LayoutTests:
Add a test that demonstrates this problem. Before the code fix, the
test shows just a red square because the invalidation for the style
change repaints the wrong rect.
- compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
- compositing/rtl/rtl-overflow-invalidation-expected.txt: Added.
- compositing/rtl/rtl-overflow-invalidation.html: Added.
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10782018
- 12:37 PM Changeset in webkit [122750] by
-
- 6 edits in trunk/Tools
test-webkitpy: run tests in parallel
https://bugs.webkit.org/show_bug.cgi?id=91294
Reviewed by Ojan Vafai.
This change adds support for running tests in parallel. This is
not yet on by default, since the logging isn't very pretty w/
parallel tests.
Also, there are some (multiprocessing-related) tests that can't be
run in parallel and so we skip them in that situation; I need to
come up with a mechanism for dealing with this, since you
apparently can't use multiprocessing as both a parent and a
child process.
- Scripts/webkitpy/test/finder.py:
(Finder.find_names):
(Finder._default_names):
- Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester.run):
- Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_no_tests_found):
- Scripts/webkitpy/test/runner.py:
(Runner.run):
- Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
- 12:35 PM Changeset in webkit [122749] by
-
- 4 edits in trunk/Tools
test-webkitpy: use message pools
https://bugs.webkit.org/show_bug.cgi?id=91292
Reviewed by Ojan Vafai.
Restructure the test-running code to be message-driven and
use a MessagePool; note that this does not yet actually run the
tests in parallel.
Also clean up the unit tests so that the fake loader is passed
to the _Worker properly, and reduce a lot of the cut&pasted code
in the tests.
No functional changes; covered by existing tests.
- Scripts/webkitpy/test/printer.py:
(Printer.print_started_test):
(Printer.print_finished_test):
- Scripts/webkitpy/test/runner.py:
(Runner.init):
(Runner.run):
(Runner.handle):
(_Worker):
(_Worker.init):
(_Worker.handle):
- Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.assert_run):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
- 12:32 PM Changeset in webkit [122748] by
-
- 6 edits7 adds in trunk/LayoutTests
Cleanup a bunch of invalid BUG* lines. Rebaseline tests that were straightfoward
rebaselines and update the expectations to match what's actually happening on the bots.
- platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/reflections/inline-crash-expected.png: Added.
- platform/chromium-mac-snowleopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/solid-color-context-restore-expected.png: Added.
- platform/chromium-mac/fast/reflections/inline-crash-expected.png: Added.
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/chromium-mac/transforms/2d/zoom-menulist-expected.png: Added.
- platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- 12:09 PM Changeset in webkit [122747] by
-
- 7 edits2 adds in trunk
Position grid items by row/column index
https://bugs.webkit.org/show_bug.cgi?id=91293
Reviewed by Ojan Vafai.
Source/WebCore:
Do some initial grid positioning. Only handle the simple case where tracks are
fixed values and don't properly size the grid items. This gives us something to
work with and starts implementing the "Grid Track Sizing Algorithm":
http://dev.w3.org/csswg/css3-grid-layout/#grid-track-sizing-algorithm0
Test: fast/css-grid-layout/place-cell-by-index.html
- rendering/RenderGrid.cpp:
(RenderGrid::GridTrack): Data structure for holding the track size. UsedBreadth matches the terminology
used in the spec.
(WebCore::RenderGrid::layoutBlock): Pull in some boiler plate code and put the
grid specific code in layoutGridItems.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Implement part of the grid track sizing algorithm.
(WebCore::RenderGrid::layoutGridItems): Compute the size of grid tracks, layout and position children.
(WebCore::RenderGrid::findChildLogicalPosition): Map track sizes to the actual position of the child.
- rendering/RenderGrid.h:
- rendering/style/RenderStyle.h: Just return a copy of Length rather than a reference to Length. This seems
more consistent with other getters that return a Length.
LayoutTests:
Add a test for grid layout in each writing mode direction. The height in vertical writing mode is incorrect for now.
- fast/css-grid-layout/containing-block-grids-expected.html: Scope <p> around text only.
- fast/css-grid-layout/containing-block-grids.html: Fix missing closing </div>.
- fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
- fast/css-grid-layout/place-cell-by-index.html: Added.
- 12:06 PM Changeset in webkit [122746] by
-
- 4 edits in trunk/Source
[chromium] Only apply page scale delta to root scroll layer
https://bugs.webkit.org/show_bug.cgi?id=91374
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-07-16
Reviewed by Adrienne Walker.
Source/WebCore:
When the user pinch-zooms the web page though the Chromium compositor, the
per-layer page scale delta is used to keep track of the difference between the
page scale on the compositor thread versus the main thread. On the next
commit to the main thread these values are reset to 1.
When calculating layer positions, the compositor applies a layer's page scale
delta both to the layer itself as well as all of its children. Since we are
currently updating the page scale delta on all scrollable layers, this results
in scrollable child layers getting scaled multiple times.
This patch changes the compositor to only apply the page scale delta on the
root scroll layer.
New unit test: CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
Source/WebKit/chromium:
New unit test
CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly to verify
the transformation of child layer while pinch zooming.
- tests/CCLayerTreeHostImplTest.cpp:
- 11:59 AM Changeset in webkit [122745] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Improve about:memory page
https://bugs.webkit.org/show_bug.cgi?id=87676
Patch by Yong Li <yoli@rim.com> on 2012-07-16
Reviewed by Rob Buis.
Add a table for process memory usage summary for easy read.
- WebCoreSupport/AboutData.cpp:
(WebCore::memoryPage):
- 11:40 AM Changeset in webkit [122744] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] Use newer version of platform API to implement callOnMainThread
https://bugs.webkit.org/show_bug.cgi?id=91404
Patch by Adam Treat <atreat@rim.com> on 2012-07-16
Reviewed by Yong Li.
Right now we're using an outdated API that involves a virtual function call for no reason.
Use the new API that is much more direct and to the point.
- wtf/blackberry/MainThreadBlackBerry.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
- 11:28 AM Changeset in webkit [122743] by
-
- 17 edits in trunk/Source
Remove setController from BatteryClient
https://bugs.webkit.org/show_bug.cgi?id=90944
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-16
Reviewed by Adam Barth.
Source/WebCore:
BatteryClient doesn't need to keep m_controller,
because BatteryController can be accessed using BatteryController::from().
Remove BatteryClient::setController function.
No new tests. Covered by existing tests.
- Modules/battery/BatteryClient.h:
- Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::BatteryController):
Source/WebKit/blackberry:
BatteryClient doesn't need to keep m_controller,
because BatteryController can be accessed using BatteryController::from().
Remove m_controller and Add webPagePrivate to BatteryClientBlackBerry.
And change all m_controller to BatteryController::from.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- WebCoreSupport/BatteryClientBlackBerry.cpp:
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::onLevelChange):
(WebCore::BatteryClientBlackBerry::onChargingChange):
(WebCore::BatteryClientBlackBerry::onChargingTimeChange):
(WebCore::BatteryClientBlackBerry::onDischargingTimeChange):
- WebCoreSupport/BatteryClientBlackBerry.h:
(BatteryClientBlackBerry):
Source/WebKit/chromium:
Remove virtual identifier from setController because setController is removed from WebCore::BatteryClient.
In addition, BatteryController is set to instance of BatteryClientImpl in the constructor of WebViewImpl.
- src/BatteryClientImpl.h:
(BatteryClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Source/WebKit/efl:
BatteryClient doesn't need to keep m_controller,
because BatteryController can be accessed using BatteryController::from().
Remove m_controller and Add ewk view evas object to BatteryClientEfl.
And change all m_controller to BatteryController::from.
- WebCoreSupport/BatteryClientEfl.cpp:
(BatteryClientEfl::BatteryClientEfl):
(BatteryClientEfl::didChangeBatteryStatus):
- WebCoreSupport/BatteryClientEfl.h:
(BatteryClientEfl):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit2:
Remove WebBatteryClient::setController function.
- WebProcess/WebCoreSupport/WebBatteryClient.cpp:
- WebProcess/WebCoreSupport/WebBatteryClient.h:
(WebBatteryClient):
- 11:21 AM Changeset in webkit [122742] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Make Ewk_Navigation_Policy_Decision ref counted
https://bugs.webkit.org/show_bug.cgi?id=91343
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-16
Reviewed by Antonio Gomes.
Make Ewk_Navigation_Policy_Decision ref counted so that the
client can make navigation policy decisions asynchronously
by ref'ing the Ewk_Navigation_Policy_Decision object passed
with the "policy,*" signals.
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_ref):
(ewk_navigation_policy_decision_unref):
- UIProcess/API/efl/ewk_navigation_policy_decision.h:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_policy_client.cpp:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
- 11:16 AM Changeset in webkit [122741] by
-
- 3 edits2 adds4 deletes in trunk
Invalid
script-noncedirectives should block script execution.
https://bugs.webkit.org/show_bug.cgi?id=91353
Patch by Mike West <mkwst@chromium.org> on 2012-07-16
Reviewed by Adam Barth.
Source/WebCore:
If the
script-nonceContent Security Policy directive contains an
invalid value, we should fail loudly, throwing a warning to the console
and denying execution of script on the page. The is in line with the
current state of the experimental CSP 1.1 Editors Draft[1].
[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-nonce--experimental
Test: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
Check against null rather than empty for early exit, otherwise
only compare nonces if the stored nonce isn't empty.
(WebCore::CSPDirectiveList::parseScriptNonce):
Assign the empty string if nonce is invalid.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html: Removed.
Replaced these two tests with the following.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html: Added.
This tests variously invalid nonces to ensure they block execution.
- 11:14 AM Changeset in webkit [122740] by
-
- 3 edits in trunk/Source/WebCore
[Android] remove RenderThemeChromiumAndroid::paintMediaFullscreenButton()
https://bugs.webkit.org/show_bug.cgi?id=91291
Patch by Min Qin <qinmin@chromium.org> on 2012-07-16
Reviewed by Adam Barth.
The recent media control refactoring added paintMediaFullscreenButton() in RenderThemeChromiumSkia.
Since RenderThemeChromiumAndroid inherits from that class, we don't need to redefine this function.
No test needed as this change just removes an unnecessary override.
- rendering/RenderThemeChromiumAndroid.cpp:
- rendering/RenderThemeChromiumAndroid.h:
- 11:10 AM Changeset in webkit [122739] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: fix output write logic to support incremental build
https://bugs.webkit.org/show_bug.cgi?id=90642
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-07-16
Reviewed by Yury Semikhatsky.
A small intermediate writer is added. It handles comparing old and new source before actual writing.
- inspector/CodeGeneratorInspector.py:
(flatten_list):
(SmartOutput):
(SmartOutput.init):
(SmartOutput.write):
(SmartOutput.close):
- 11:04 AM Changeset in webkit [122738] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Layout Test storage/indexeddb/cursor-update-value-argument-required.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=91403
This test crashes occasionally, not sure how long it has been flaky.
- platform/chromium/TestExpectations:
- 11:01 AM Changeset in webkit [122737] by
-
- 4 edits in trunk/Source
[chromium] Incorrect assertion: Replicas will cause a RenderPass to be removed twice
https://bugs.webkit.org/show_bug.cgi?id=91328
Reviewed by Adrienne Walker.
Source/WebCore:
We asserted that we would never attempt to remove a render pass that had
already been removed. This was incorrect as a surface with a replica has
two quads and both may cause us to attempt its removal. We must handle
this case gracefully.
Test: CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):
Source/WebKit/chromium:
Add replicas to the surfaces in the test.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest):
(CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
- 10:56 AM UsingGitWithWebKit edited by
- Remove extraneous word "this" to make the sentence read well. (diff)
- 10:51 AM Changeset in webkit [122736] by
-
- 76 edits in trunk/LayoutTests
[Qt] platform/qt/editing/execCommand tests update after the font change.
https://bugs.webkit.org/show_bug.cgi?id=91246.
Unreviewed rebaseline.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/editing/execCommand/4580583-1-expected.png:
- platform/qt/editing/execCommand/4580583-1-expected.txt:
- platform/qt/editing/execCommand/4580583-2-expected.png:
- platform/qt/editing/execCommand/4580583-2-expected.txt:
- platform/qt/editing/execCommand/4641880-1-expected.png:
- platform/qt/editing/execCommand/4641880-1-expected.txt:
- platform/qt/editing/execCommand/4641880-2-expected.png:
- platform/qt/editing/execCommand/4641880-2-expected.txt:
- platform/qt/editing/execCommand/4747450-expected.png:
- platform/qt/editing/execCommand/4747450-expected.txt:
- platform/qt/editing/execCommand/4916402-expected.png:
- platform/qt/editing/execCommand/4916402-expected.txt:
- platform/qt/editing/execCommand/4916541-expected.png:
- platform/qt/editing/execCommand/4916541-expected.txt:
- platform/qt/editing/execCommand/4924441-expected.png:
- platform/qt/editing/execCommand/4924441-expected.txt:
- platform/qt/editing/execCommand/5080333-1-expected.png:
- platform/qt/editing/execCommand/5080333-1-expected.txt:
- platform/qt/editing/execCommand/5080333-2-expected.png:
- platform/qt/editing/execCommand/5080333-2-expected.txt:
- platform/qt/editing/execCommand/5136770-expected.png:
- platform/qt/editing/execCommand/5136770-expected.txt:
- platform/qt/editing/execCommand/5138441-expected.png:
- platform/qt/editing/execCommand/5138441-expected.txt:
- platform/qt/editing/execCommand/5142012-1-expected.png:
- platform/qt/editing/execCommand/5142012-1-expected.txt:
- platform/qt/editing/execCommand/5142012-2-expected.png:
- platform/qt/editing/execCommand/5142012-2-expected.txt:
- platform/qt/editing/execCommand/5190926-expected.png:
- platform/qt/editing/execCommand/5190926-expected.txt:
- platform/qt/editing/execCommand/5481523-expected.png:
- platform/qt/editing/execCommand/5481523-expected.txt:
- platform/qt/editing/execCommand/5482023-expected.png:
- platform/qt/editing/execCommand/5482023-expected.txt:
- platform/qt/editing/execCommand/5569741-expected.png:
- platform/qt/editing/execCommand/5569741-expected.txt:
- platform/qt/editing/execCommand/create-list-with-hr-expected.png:
- platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
- platform/qt/editing/execCommand/find-after-replace-expected.png:
- platform/qt/editing/execCommand/find-after-replace-expected.txt:
- platform/qt/editing/execCommand/findString-2-expected.png:
- platform/qt/editing/execCommand/findString-2-expected.txt:
- platform/qt/editing/execCommand/findString-expected.png:
- platform/qt/editing/execCommand/findString-expected.txt:
- platform/qt/editing/execCommand/format-block-with-trailing-br-expected.png:
- platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
- platform/qt/editing/execCommand/indent-empty-root-expected.png:
- platform/qt/editing/execCommand/indent-empty-root-expected.txt:
- platform/qt/editing/execCommand/indent-list-item-expected.png:
- platform/qt/editing/execCommand/indent-list-item-expected.txt:
- platform/qt/editing/execCommand/indent-selection-expected.png:
- platform/qt/editing/execCommand/indent-selection-expected.txt:
- platform/qt/editing/execCommand/insert-list-and-stitch-expected.png:
- platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
- platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
- platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
- platform/qt/editing/execCommand/insertImage-expected.png:
- platform/qt/editing/execCommand/insertImage-expected.txt:
- platform/qt/editing/execCommand/nsresponder-indent-expected.png:
- platform/qt/editing/execCommand/nsresponder-indent-expected.txt:
- platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
- platform/qt/editing/execCommand/nsresponder-outdent-expected.txt:
- platform/qt/editing/execCommand/paste-1-expected.png:
- platform/qt/editing/execCommand/paste-1-expected.txt:
- platform/qt/editing/execCommand/paste-2-expected.png:
- platform/qt/editing/execCommand/paste-2-expected.txt:
- platform/qt/editing/execCommand/print-expected.png:
- platform/qt/editing/execCommand/print-expected.txt:
- platform/qt/editing/execCommand/remove-list-from-range-selection-expected.png:
- platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
- platform/qt/editing/execCommand/remove-list-item-1-expected.png:
- platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
- platform/qt/editing/execCommand/selectAll-expected.png:
- platform/qt/editing/execCommand/selectAll-expected.txt:
- 9:23 AM Changeset in webkit [122735] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: native memory: fix instrumentation for string members
https://bugs.webkit.org/show_bug.cgi?id=91384
Reviewed by Pavel Feldman.
It was possible to report a string member via addMember instead of addString.
This patch is fixing the problem and adding a link time guard.
Covered by existing inspector performance tests infrastructure.
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(WebCore):
(WebCore::MemoryClassInfo::addString):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
- 9:16 AM Changeset in webkit [122734] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed buildfix after r122729. Typo fix.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
- 8:49 AM Changeset in webkit [122733] by
-
- 2 edits in trunk/LayoutTests
jquery/manipulation.html times out in release too.
- platform/chromium/TestExpectations:
- 8:39 AM Changeset in webkit [122732] by
-
- 2 edits2 copies14 moves4 adds1 delete in trunk/LayoutTests
[Qt] remaining compositing tests after rebaseline for new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91377
Unreviewed rebaseline.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.txt: Removed.
- platform/qt/compositing/backing/no-backing-for-clip-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt.
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt.
- platform/qt/compositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt.
- platform/qt/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.png.
- platform/qt/compositing/geometry/composited-html-size-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.txt.
- platform/qt/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-in-columns-expected.txt.
- platform/qt/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
- platform/qt/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt.
- platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt.
- platform/qt/compositing/iframes/composited-iframe-scroll-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
- platform/qt/compositing/iframes/composited-iframe-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/composited-iframe-scroll-expected.txt.
- platform/qt/compositing/iframes/iframe-content-flipping-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.png.
- platform/qt/compositing/iframes/iframe-content-flipping-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/iframe-content-flipping-expected.txt.
- platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt.
- platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
- platform/qt/compositing/overflow/theme-affects-visual-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.png.
- platform/qt/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
- 8:28 AM Changeset in webkit [122731] by
-
- 2 edits in trunk/Tools
[Qt] Fix Qt5 module dependencies
https://bugs.webkit.org/show_bug.cgi?id=91388
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-16
Reviewed by Laszlo Gombos.
Removed ancient qtscript and qtxmlpatterns module dependencies.
- qmake/qt_webkit.pri:
- 8:25 AM Changeset in webkit [122730] by
-
- 2 edits in trunk/LayoutTests
Update expectations : rebaseline images after skia 4600 lands
https://bugs.webkit.org/show_bug.cgi?id=91392
Reviewed by NOBODY : expectations change only
- platform/chromium/TestExpectations:
- 8:05 AM Changeset in webkit [122729] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed buildfix from Zoltan Herczeg after r122677.
Implement missing add32 function to MacroAssemblerARM.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(MacroAssemblerARM):
- 7:56 AM Changeset in webkit [122728] by
-
- 2 edits in trunk/Tools
run-webkit-test returns 254 at exit even when it succeeds
https://bugs.webkit.org/show_bug.cgi?id=91370
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-16
Reviewed by Simon Hausmann.
sys.exit() is implemented by raising SystemExit which inherits from
BaseException. Since we are catching BaseException, run_webkit_tests.py
was always returning an error code.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 7:56 AM Changeset in webkit [122727] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix inconsistent DLL linkage on Windows with WebKit1
https://bugs.webkit.org/show_bug.cgi?id=91375
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-16
Reviewed by Laszlo Gombos.
Export QWebHistoryItemPrivate as required for tests. Unfortunately we cannot use
Q_AUTOTEST_EXPORT outside of Qt.
- Api/qwebhistory_p.h:
- 7:56 AM Changeset in webkit [122726] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed. Remove unnecessary executable bits after r122720.
- platform/graphics/ImageSource.h:
- platform/graphics/qt/ImageBufferQt.cpp:
- platform/graphics/qt/ImageDecoderQt.cpp:
- platform/graphics/qt/ImageQt.cpp:
- platform/graphics/qt/StillImageQt.h:
- platform/graphics/qt/TransparencyLayer.h:
- 7:54 AM Changeset in webkit [122725] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Text selection with touch hold does not start on text field in some cases
https://bugs.webkit.org/show_bug.cgi?id=91267
Patch by Yongxin Dai <yodai@rim.com> on 2012-07-16
Reviewed by Antonio Gomes.
Input fields host node is by spec non-editable unless the field itself has content editable enabled.
We enable selection if the shadow tree for the input field is selectable.
PR # 173450
Reviewed Internally by Mike Fenton.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 7:50 AM Changeset in webkit [122724] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
https://bugs.webkit.org/show_bug.cgi?id=91390
Unreviewed gardening.
Skip until proper fix.
- platform/qt/Skipped: Add the test to the skiplist
- 7:31 AM Changeset in webkit [122723] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Fix TestExpectations after r122718.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-16
- platform/qt/TestExpectations:
- 7:29 AM Changeset in webkit [122722] by
-
- 4 edits24 moves95 adds70 deletes in trunk/LayoutTests
[Qt] compositing tests need rebaseline with new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91234
Unreviewed rebaseline.
Rebaseline compositing tests. Move expectations from qt-5.0-wk2 to qt because these
results should not vary across Qt versions. Co-authored with Csaba Osztrogonác. Some
tests were produced uncorrect result, I keep skipped them and filed
https://bugs.webkit.org/show_bug.cgi?id=91377. Compositing tests are still skipped on
qt-4.8 and qt-5.0-wk1.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/generated-content-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/generated-content-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/masked-reflection-on-composited-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-mask-change-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/reflection-in-composited-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/self-painting-layers-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.txt: Removed.
- platform/qt/animations/3d/change-transform-in-end-event-expected.txt: Removed.
- platform/qt/animations/3d/state-at-end-event-transform-expected.png: Added.
- platform/qt/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
- platform/qt/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
- platform/qt/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/qt/compositing/color-matching/image-color-matching-expected.txt: Added.
- platform/qt/compositing/color-matching/pdf-image-match-expected.png: Added.
- platform/qt/compositing/color-matching/pdf-image-match-expected.txt: Added.
- platform/qt/compositing/compositing-visible-descendant-expected.png: Added.
- platform/qt/compositing/compositing-visible-descendant-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.txt.
- platform/qt/compositing/direct-image-compositing-expected.png: Added.
- platform/qt/compositing/direct-image-compositing-expected.txt: Added.
- platform/qt/compositing/generated-content-expected.png: Added.
- platform/qt/compositing/generated-content-expected.txt: Added.
- platform/qt/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
- platform/qt/compositing/geometry/abs-position-inside-opacity-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.txt.
- platform/qt/compositing/geometry/clipping-foreground-expected.png: Added.
- platform/qt/compositing/geometry/clipping-foreground-expected.txt: Added.
- platform/qt/compositing/geometry/fixed-in-composited-expected.png: Added.
- platform/qt/compositing/geometry/fixed-in-composited-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.txt.
- platform/qt/compositing/geometry/fixed-position-expected.png: Added.
- platform/qt/compositing/geometry/fixed-position-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.txt.
- platform/qt/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/qt/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.txt.
- platform/qt/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/qt/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/qt/compositing/geometry/outline-change-expected.png: Added.
- platform/qt/compositing/geometry/outline-change-expected.txt: Added.
- platform/qt/compositing/geometry/partial-layout-update-expected.png: Added.
- platform/qt/compositing/geometry/partial-layout-update-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.txt.
- platform/qt/compositing/geometry/root-layer-update-expected.png: Added.
- platform/qt/compositing/geometry/root-layer-update-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.txt.
- platform/qt/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
- platform/qt/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt.
- platform/qt/compositing/geometry/video-fixed-scrolling-expected.png: Added.
- platform/qt/compositing/geometry/video-fixed-scrolling-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.txt.
- platform/qt/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/qt/compositing/iframes/composited-iframe-alignment-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.txt.
- platform/qt/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
- platform/qt/compositing/iframes/iframe-copy-on-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.txt.
- platform/qt/compositing/images/direct-image-background-color-expected.png: Added.
- platform/qt/compositing/images/direct-image-background-color-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.txt.
- platform/qt/compositing/masks/direct-image-mask-expected.png: Added.
- platform/qt/compositing/masks/direct-image-mask-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.txt.
- platform/qt/compositing/masks/masked-ancestor-expected.png: Added.
- platform/qt/compositing/masks/masked-ancestor-expected.txt: Added.
- platform/qt/compositing/masks/multiple-masks-expected.png: Added.
- platform/qt/compositing/masks/multiple-masks-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.txt.
- platform/qt/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/qt/compositing/masks/simple-composited-mask-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.txt.
- platform/qt/compositing/overflow/ancestor-overflow-expected.png:
- platform/qt/compositing/overflow/ancestor-overflow-expected.txt:
- platform/qt/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
- platform/qt/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.txt.
- platform/qt/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/qt/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
- platform/qt/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/qt/compositing/overflow/overflow-positioning-expected.txt: Added.
- platform/qt/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/qt/compositing/overflow/overflow-scroll-expected.txt: Added.
- platform/qt/compositing/overflow/parent-overflow-expected.png: Added.
- platform/qt/compositing/overflow/parent-overflow-expected.txt: Added.
- platform/qt/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/qt/compositing/overflow/scroll-ancestor-update-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.txt.
- platform/qt/compositing/overflow/scrollbar-painting-expected.png: Added.
- platform/qt/compositing/overflow/scrollbar-painting-expected.txt: Added.
- platform/qt/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/qt/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
- platform/qt/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
- platform/qt/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
- platform/qt/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
- platform/qt/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
- platform/qt/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/qt/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
- platform/qt/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/qt/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
- platform/qt/compositing/reflections/reflection-in-composited-expected.png: Added.
- platform/qt/compositing/reflections/reflection-in-composited-expected.txt: Added.
- platform/qt/compositing/reflections/reflection-on-composited-expected.png: Added.
- platform/qt/compositing/reflections/reflection-on-composited-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/reflection-on-composited-expected.txt.
- platform/qt/compositing/reflections/reflection-opacity-expected.png: Added.
- platform/qt/compositing/reflections/reflection-opacity-expected.txt: Added.
- platform/qt/compositing/reflections/reflection-ordering-expected.png: Added.
- platform/qt/compositing/reflections/reflection-ordering-expected.txt: Added.
- platform/qt/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/qt/compositing/reflections/reflection-positioning-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.txt.
- platform/qt/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/qt/compositing/reflections/reflection-positioning2-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.txt.
- platform/qt/compositing/reflections/simple-composited-reflections-expected.png: Added.
- platform/qt/compositing/reflections/simple-composited-reflections-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.txt.
- platform/qt/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
- platform/qt/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
- platform/qt/compositing/repaint/composited-document-element-expected.png: Added.
- platform/qt/compositing/repaint/composited-document-element-expected.txt: Added.
- platform/qt/compositing/repaint/layer-repaint-expected.png: Added.
- platform/qt/compositing/repaint/layer-repaint-expected.txt: Added.
- platform/qt/compositing/repaint/layer-repaint-rects-expected.png: Added.
- platform/qt/compositing/repaint/layer-repaint-rects-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.txt.
- platform/qt/compositing/repaint/opacity-between-absolute-expected.png: Added.
- platform/qt/compositing/repaint/opacity-between-absolute-expected.txt: Added.
- platform/qt/compositing/repaint/opacity-between-absolute2-expected.png: Added.
- platform/qt/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
- platform/qt/compositing/self-painting-layers-expected.png: Added.
- platform/qt/compositing/self-painting-layers-expected.txt: Added.
- platform/qt/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/qt/compositing/shadows/shadow-drawing-expected.txt: Added.
- platform/qt/compositing/sibling-positioning-expected.png: Added.
- platform/qt/compositing/sibling-positioning-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/sibling-positioning-expected.txt.
- platform/qt/compositing/text-on-large-layer-expected.png: Added.
- platform/qt/compositing/text-on-large-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.txt.
- platform/qt/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/qt/compositing/transitions/scale-transition-no-start-expected.txt: Added.
- platform/qt/compositing/transitions/singular-scale-transition-expected.png: Added.
- platform/qt/compositing/transitions/singular-scale-transition-expected.txt: Added.
- 7:08 AM Changeset in webkit [122721] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91386
- platform/chromium/TestExpectations:
- 6:50 AM Changeset in webkit [122720] by
-
- 35 edits1 copy in trunk/Source
[Qt] Change NativeImagePtr from QPixmap* to QImage*
https://bugs.webkit.org/show_bug.cgi?id=88785
Reviewed by Simon Hausmann.
Since we use raster engine there is no difference between QPixmap and QImage, so we are going
to use QImage everywhere where it is possible. This refactoring contains the change of the
NativeImagePtr typedef from QPixmap* to QImage* and covers the related modifications.
Part of the change is similar to Viatcheslav Ostapenko's internal work.
Covered by existing tests.
Source/WebCore:
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapAssignToElementMethod::invoke):
(JSC::Bindings::QtPixmapInstance::variantFromObject):
- platform/DragImage.h:
(WebCore):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/Image.h:
(Image):
- platform/graphics/ImageSource.h:
(WebCore):
- platform/graphics/gstreamer/ImageGStreamer.h:
- platform/graphics/gstreamer/ImageGStreamerQt.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
- platform/graphics/qt/ImageBufferDataQt.h:
(ImageBufferData):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageFrame::asNewNativeImage):
- platform/graphics/qt/ImageQt.cpp:
(graphics):
(loadResourceImage):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::setPlatformResource):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::create):
- platform/graphics/qt/NativeImageQt.h: Added.
(WebCore):
(NativeImageQt):
(WebCore::NativeImageQt::defaultFormatForAlphaEnabledImages):
(WebCore::NativeImageQt::defaultFormatForOpaqueImages):
- platform/graphics/qt/PatternQt.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::StillImage):
(WebCore::StillImage::~StillImage):
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore::StillImage::size):
(WebCore::StillImage::nativeImageForCurrentFrame):
(WebCore::StillImage::draw):
- platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::create):
(WebCore::StillImage::createForRendering):
(StillImage):
- platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
(TransparencyLayer):
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::createReadOnlyImage):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):
- platform/qt/CursorQt.cpp:
(WebCore::createCustomCursor):
- platform/qt/DragImageQt.cpp:
(WebCore::createDragImageFromImage):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage):
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
- Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
- Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):
(QWebSettings::setWebGraphic):
(QWebSettings::webGraphic):
- WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
Source/WebKit2:
- Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createImage):
- UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQImageToShareableBitmap):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
- 6:44 AM Changeset in webkit [122719] by
-
- 762 edits in trunk/LayoutTests
[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242
Unreviewed rebaseline.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-16
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/tables/layering/paint-test-layering-1-expected.png:
- platform/qt/tables/layering/paint-test-layering-1-expected.txt:
- platform/qt/tables/layering/paint-test-layering-2-expected.png:
- platform/qt/tables/layering/paint-test-layering-2-expected.txt:
- platform/qt/tables/mozilla/bugs/45621-expected.png:
- platform/qt/tables/mozilla/bugs/45621-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10009-expected.png:
- platform/qt/tables/mozilla/bugs/bug10009-expected.txt:
- platform/qt/tables/mozilla/bugs/bug100334-expected.png:
- platform/qt/tables/mozilla/bugs/bug100334-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10036-expected.png:
- platform/qt/tables/mozilla/bugs/bug10036-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10039-expected.png:
- platform/qt/tables/mozilla/bugs/bug10039-expected.txt:
- platform/qt/tables/mozilla/bugs/bug101201-expected.png:
- platform/qt/tables/mozilla/bugs/bug101201-expected.txt:
- platform/qt/tables/mozilla/bugs/bug101674-expected.png:
- platform/qt/tables/mozilla/bugs/bug101674-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10269-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10565-expected.png:
- platform/qt/tables/mozilla/bugs/bug10565-expected.txt:
- platform/qt/tables/mozilla/bugs/bug106158-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug106158-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug106158-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug10633-expected.png:
- platform/qt/tables/mozilla/bugs/bug10633-expected.txt:
- platform/qt/tables/mozilla/bugs/bug106816-expected.png:
- platform/qt/tables/mozilla/bugs/bug106816-expected.txt:
- platform/qt/tables/mozilla/bugs/bug108340-expected.png:
- platform/qt/tables/mozilla/bugs/bug108340-expected.txt:
- platform/qt/tables/mozilla/bugs/bug109043-expected.png:
- platform/qt/tables/mozilla/bugs/bug109043-expected.txt:
- platform/qt/tables/mozilla/bugs/bug11026-expected.png:
- platform/qt/tables/mozilla/bugs/bug11026-expected.txt:
- platform/qt/tables/mozilla/bugs/bug110566-expected.png:
- platform/qt/tables/mozilla/bugs/bug110566-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113424-expected.png:
- platform/qt/tables/mozilla/bugs/bug113424-expected.txt:
- platform/qt/tables/mozilla/bugs/bug11384q-expected.png:
- platform/qt/tables/mozilla/bugs/bug11384q-expected.txt:
- platform/qt/tables/mozilla/bugs/bug11384s-expected.png:
- platform/qt/tables/mozilla/bugs/bug11384s-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1188-expected.png:
- platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
- platform/qt/tables/mozilla/bugs/bug11944-expected.png:
- platform/qt/tables/mozilla/bugs/bug11944-expected.txt:
- platform/qt/tables/mozilla/bugs/bug119786-expected.png:
- platform/qt/tables/mozilla/bugs/bug119786-expected.txt:
- platform/qt/tables/mozilla/bugs/bug12008-expected.png:
- platform/qt/tables/mozilla/bugs/bug12008-expected.txt:
- platform/qt/tables/mozilla/bugs/bug120364-expected.png:
- platform/qt/tables/mozilla/bugs/bug120364-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1220-expected.png:
- platform/qt/tables/mozilla/bugs/bug1220-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1224-expected.png:
- platform/qt/tables/mozilla/bugs/bug1224-expected.txt:
- platform/qt/tables/mozilla/bugs/bug12268-expected.png:
- platform/qt/tables/mozilla/bugs/bug12268-expected.txt:
- platform/qt/tables/mozilla/bugs/bug123862-expected.png:
- platform/qt/tables/mozilla/bugs/bug123862-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1261-expected.png:
- platform/qt/tables/mozilla/bugs/bug1261-expected.txt:
- platform/qt/tables/mozilla/bugs/bug126742-expected.png:
- platform/qt/tables/mozilla/bugs/bug126742-expected.txt:
- platform/qt/tables/mozilla/bugs/bug12709-expected.png:
- platform/qt/tables/mozilla/bugs/bug12709-expected.txt:
- platform/qt/tables/mozilla/bugs/bug127267-expected.png:
- platform/qt/tables/mozilla/bugs/bug127267-expected.txt:
- platform/qt/tables/mozilla/bugs/bug128229-expected.png:
- platform/qt/tables/mozilla/bugs/bug128229-expected.txt:
- platform/qt/tables/mozilla/bugs/bug12908-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug12910-expected.png:
- platform/qt/tables/mozilla/bugs/bug12910-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1296-expected.png:
- platform/qt/tables/mozilla/bugs/bug1296-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1302-expected.png:
- platform/qt/tables/mozilla/bugs/bug1302-expected.txt:
- platform/qt/tables/mozilla/bugs/bug131020-expected.png:
- platform/qt/tables/mozilla/bugs/bug131020-expected.txt:
- platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.png:
- platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.txt:
- platform/qt/tables/mozilla/bugs/bug13105-expected.png:
- platform/qt/tables/mozilla/bugs/bug13105-expected.txt:
- platform/qt/tables/mozilla/bugs/bug13118-expected.png:
- platform/qt/tables/mozilla/bugs/bug13118-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1318-expected.png:
- platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
- platform/qt/tables/mozilla/bugs/bug13196-expected.png:
- platform/qt/tables/mozilla/bugs/bug13196-expected.txt:
- platform/qt/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug13484-expected.png:
- platform/qt/tables/mozilla/bugs/bug13484-expected.txt:
- platform/qt/tables/mozilla/bugs/bug13526-expected.png:
- platform/qt/tables/mozilla/bugs/bug13526-expected.txt:
- platform/qt/tables/mozilla/bugs/bug138725-expected.png:
- platform/qt/tables/mozilla/bugs/bug138725-expected.txt:
- platform/qt/tables/mozilla/bugs/bug139524-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug139524-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug139524-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug139524-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/qt/tables/mozilla/bugs/bug14159-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug14159-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug14159-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug14159-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1430-expected.png:
- platform/qt/tables/mozilla/bugs/bug1430-expected.txt:
- platform/qt/tables/mozilla/bugs/bug14323-expected.png:
- platform/qt/tables/mozilla/bugs/bug14323-expected.txt:
- platform/qt/tables/mozilla/bugs/bug145572-expected.png:
- platform/qt/tables/mozilla/bugs/bug145572-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1474-expected.png:
- platform/qt/tables/mozilla/bugs/bug1474-expected.txt:
- platform/qt/tables/mozilla/bugs/bug149275-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug149275-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug149275-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug149275-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug14929-expected.png:
- platform/qt/tables/mozilla/bugs/bug14929-expected.txt:
- platform/qt/tables/mozilla/bugs/bug15247-expected.png:
- platform/qt/tables/mozilla/bugs/bug15247-expected.txt:
- platform/qt/tables/mozilla/bugs/bug15544-expected.png:
- platform/qt/tables/mozilla/bugs/bug15544-expected.txt:
- platform/qt/tables/mozilla/bugs/bug157890-expected.png:
- platform/qt/tables/mozilla/bugs/bug157890-expected.txt:
- platform/qt/tables/mozilla/bugs/bug159108-expected.png:
- platform/qt/tables/mozilla/bugs/bug159108-expected.txt:
- platform/qt/tables/mozilla/bugs/bug16012-expected.png:
- platform/qt/tables/mozilla/bugs/bug16012-expected.txt:
- platform/qt/tables/mozilla/bugs/bug16252-expected.png:
- platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17130-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17130-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug17130-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17138-expected.png:
- platform/qt/tables/mozilla/bugs/bug17138-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17168-expected.png:
- platform/qt/tables/mozilla/bugs/bug17168-expected.txt:
- platform/qt/tables/mozilla/bugs/bug175455-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17548-expected.png:
- platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
- platform/qt/tables/mozilla/bugs/bug17587-expected.png:
- platform/qt/tables/mozilla/bugs/bug17587-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1800-expected.png:
- platform/qt/tables/mozilla/bugs/bug1800-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1802-expected.png:
- platform/qt/tables/mozilla/bugs/bug1802-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1802s-expected.png:
- platform/qt/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1809-expected.png:
- platform/qt/tables/mozilla/bugs/bug1809-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1818-5-expected.png:
- platform/qt/tables/mozilla/bugs/bug1818-5-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1828-expected.png:
- platform/qt/tables/mozilla/bugs/bug1828-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18359-expected.png:
- platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18440-expected.png:
- platform/qt/tables/mozilla/bugs/bug18440-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18558-expected.png:
- platform/qt/tables/mozilla/bugs/bug18558-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18664-expected.png:
- platform/qt/tables/mozilla/bugs/bug18664-expected.txt:
- platform/qt/tables/mozilla/bugs/bug18955-expected.png:
- platform/qt/tables/mozilla/bugs/bug18955-expected.txt:
- platform/qt/tables/mozilla/bugs/bug19061-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug19061-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug19356-expected.png:
- platform/qt/tables/mozilla/bugs/bug19356-expected.txt:
- platform/qt/tables/mozilla/bugs/bug194024-expected.png:
- platform/qt/tables/mozilla/bugs/bug194024-expected.txt:
- platform/qt/tables/mozilla/bugs/bug19599-expected.png:
- platform/qt/tables/mozilla/bugs/bug19599-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2050-expected.png:
- platform/qt/tables/mozilla/bugs/bug2050-expected.txt:
- platform/qt/tables/mozilla/bugs/bug20579-expected.png:
- platform/qt/tables/mozilla/bugs/bug20579-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2065-expected.png:
- platform/qt/tables/mozilla/bugs/bug2065-expected.txt:
- platform/qt/tables/mozilla/bugs/bug20804-expected.png:
- platform/qt/tables/mozilla/bugs/bug20804-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2123-expected.png:
- platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
- platform/qt/tables/mozilla/bugs/bug21299-expected.png:
- platform/qt/tables/mozilla/bugs/bug21299-expected.txt:
- platform/qt/tables/mozilla/bugs/bug215629-expected.png:
- platform/qt/tables/mozilla/bugs/bug215629-expected.txt:
- platform/qt/tables/mozilla/bugs/bug21918-expected.png:
- platform/qt/tables/mozilla/bugs/bug21918-expected.txt:
- platform/qt/tables/mozilla/bugs/bug22019-expected.png:
- platform/qt/tables/mozilla/bugs/bug22019-expected.txt:
- platform/qt/tables/mozilla/bugs/bug220536-expected.png:
- platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
- platform/qt/tables/mozilla/bugs/bug22246-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug22246-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug22246-2a-expected.png:
- platform/qt/tables/mozilla/bugs/bug22246-2a-expected.txt:
- platform/qt/tables/mozilla/bugs/bug22246-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug22246-3a-expected.png:
- platform/qt/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/qt/tables/mozilla/bugs/bug222846-expected.png:
- platform/qt/tables/mozilla/bugs/bug222846-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2267-expected.png:
- platform/qt/tables/mozilla/bugs/bug2267-expected.txt:
- platform/qt/tables/mozilla/bugs/bug227123-expected.png:
- platform/qt/tables/mozilla/bugs/bug227123-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2296-expected.png:
- platform/qt/tables/mozilla/bugs/bug2296-expected.txt:
- platform/qt/tables/mozilla/bugs/bug23151-expected.png:
- platform/qt/tables/mozilla/bugs/bug23151-expected.txt:
- platform/qt/tables/mozilla/bugs/bug23235-expected.png:
- platform/qt/tables/mozilla/bugs/bug23235-expected.txt:
- platform/qt/tables/mozilla/bugs/bug23299-expected.png:
- platform/qt/tables/mozilla/bugs/bug23299-expected.txt:
- platform/qt/tables/mozilla/bugs/bug24200-expected.png:
- platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
- platform/qt/tables/mozilla/bugs/bug24503-expected.png:
- platform/qt/tables/mozilla/bugs/bug24503-expected.txt:
- platform/qt/tables/mozilla/bugs/bug24627-expected.png:
- platform/qt/tables/mozilla/bugs/bug24627-expected.txt:
- platform/qt/tables/mozilla/bugs/bug24661-expected.png:
- platform/qt/tables/mozilla/bugs/bug24661-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2469-expected.png:
- platform/qt/tables/mozilla/bugs/bug2469-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/qt/tables/mozilla/bugs/bug24880-expected.png:
- platform/qt/tables/mozilla/bugs/bug24880-expected.txt:
- platform/qt/tables/mozilla/bugs/bug25004-expected.png:
- platform/qt/tables/mozilla/bugs/bug25004-expected.txt:
- platform/qt/tables/mozilla/bugs/bug25086-expected.png:
- platform/qt/tables/mozilla/bugs/bug25086-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2509-expected.png:
- platform/qt/tables/mozilla/bugs/bug2509-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2516-expected.png:
- platform/qt/tables/mozilla/bugs/bug2516-expected.txt:
- platform/qt/tables/mozilla/bugs/bug25663-expected.png:
- platform/qt/tables/mozilla/bugs/bug25663-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2585-expected.png:
- platform/qt/tables/mozilla/bugs/bug2585-expected.txt:
- platform/qt/tables/mozilla/bugs/bug26178-expected.png:
- platform/qt/tables/mozilla/bugs/bug26178-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2684-expected.png:
- platform/qt/tables/mozilla/bugs/bug2684-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27038-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug275625-expected.png:
- platform/qt/tables/mozilla/bugs/bug275625-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2757-expected.png:
- platform/qt/tables/mozilla/bugs/bug2757-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2763-expected.png:
- platform/qt/tables/mozilla/bugs/bug2763-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2773-expected.png:
- platform/qt/tables/mozilla/bugs/bug2773-expected.txt:
- platform/qt/tables/mozilla/bugs/bug278266-expected.png:
- platform/qt/tables/mozilla/bugs/bug278266-expected.txt:
- platform/qt/tables/mozilla/bugs/bug278385-expected.png:
- platform/qt/tables/mozilla/bugs/bug278385-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27993-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug28341-expected.png:
- platform/qt/tables/mozilla/bugs/bug28341-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2886-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2886-expected.png:
- platform/qt/tables/mozilla/bugs/bug2886-expected.txt:
- platform/qt/tables/mozilla/bugs/bug28928-expected.png:
- platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29058-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug29058-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29157-expected.png:
- platform/qt/tables/mozilla/bugs/bug29157-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29326-expected.png:
- platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29429-expected.png:
- platform/qt/tables/mozilla/bugs/bug29429-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2947-expected.png:
- platform/qt/tables/mozilla/bugs/bug2947-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2962-expected.png:
- platform/qt/tables/mozilla/bugs/bug2962-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2973-expected.png:
- platform/qt/tables/mozilla/bugs/bug2973-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2981-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2997-expected.png:
- platform/qt/tables/mozilla/bugs/bug2997-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30273-expected.png:
- platform/qt/tables/mozilla/bugs/bug30273-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30332-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug30332-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30332-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug30332-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30418-expected.png:
- platform/qt/tables/mozilla/bugs/bug30418-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30559-expected.png:
- platform/qt/tables/mozilla/bugs/bug30559-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30692-expected.png:
- platform/qt/tables/mozilla/bugs/bug30692-expected.txt:
- platform/qt/tables/mozilla/bugs/bug30985-expected.png:
- platform/qt/tables/mozilla/bugs/bug30985-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3103-expected.png:
- platform/qt/tables/mozilla/bugs/bug3103-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3191-expected.png:
- platform/qt/tables/mozilla/bugs/bug3191-expected.txt:
- platform/qt/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug32205-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug32205-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug32205-5-expected.png:
- platform/qt/tables/mozilla/bugs/bug32205-5-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3260-expected.png:
- platform/qt/tables/mozilla/bugs/bug3260-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3263-expected.png:
- platform/qt/tables/mozilla/bugs/bug3263-expected.txt:
- platform/qt/tables/mozilla/bugs/bug32841-expected.png:
- platform/qt/tables/mozilla/bugs/bug32841-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3309-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug3309-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug33137-expected.png:
- platform/qt/tables/mozilla/bugs/bug33137-expected.txt:
- platform/qt/tables/mozilla/bugs/bug33855-expected.png:
- platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
- platform/qt/tables/mozilla/bugs/bug34176-expected.png:
- platform/qt/tables/mozilla/bugs/bug34176-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3454-expected.png:
- platform/qt/tables/mozilla/bugs/bug3454-expected.txt:
- platform/qt/tables/mozilla/bugs/bug35662-expected.png:
- platform/qt/tables/mozilla/bugs/bug35662-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3681-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug3681-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3681-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug3681-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3718-expected.png:
- platform/qt/tables/mozilla/bugs/bug3718-expected.txt:
- platform/qt/tables/mozilla/bugs/bug38916-expected.png:
- platform/qt/tables/mozilla/bugs/bug38916-expected.txt:
- platform/qt/tables/mozilla/bugs/bug39209-expected.png:
- platform/qt/tables/mozilla/bugs/bug39209-expected.txt:
- platform/qt/tables/mozilla/bugs/bug3977-expected.png:
- platform/qt/tables/mozilla/bugs/bug3977-expected.txt:
- platform/qt/tables/mozilla/bugs/bug40828-expected.png:
- platform/qt/tables/mozilla/bugs/bug40828-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4093-expected.png:
- platform/qt/tables/mozilla/bugs/bug4093-expected.txt:
- platform/qt/tables/mozilla/bugs/bug41890-expected.png:
- platform/qt/tables/mozilla/bugs/bug41890-expected.txt:
- platform/qt/tables/mozilla/bugs/bug42187-expected.png:
- platform/qt/tables/mozilla/bugs/bug42187-expected.txt:
- platform/qt/tables/mozilla/bugs/bug42443-expected.png:
- platform/qt/tables/mozilla/bugs/bug42443-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4284-expected.png:
- platform/qt/tables/mozilla/bugs/bug4284-expected.txt:
- platform/qt/tables/mozilla/bugs/bug43039-expected.png:
- platform/qt/tables/mozilla/bugs/bug43039-expected.txt:
- platform/qt/tables/mozilla/bugs/bug43204-expected.png:
- platform/qt/tables/mozilla/bugs/bug43204-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4382-expected.png:
- platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4385-expected.png:
- platform/qt/tables/mozilla/bugs/bug4385-expected.txt:
- platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug43854-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug43854-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4427-expected.png:
- platform/qt/tables/mozilla/bugs/bug4427-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4429-expected.png:
- platform/qt/tables/mozilla/bugs/bug4429-expected.txt:
- platform/qt/tables/mozilla/bugs/bug44505-expected.png:
- platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
- platform/qt/tables/mozilla/bugs/bug44523-expected.png:
- platform/qt/tables/mozilla/bugs/bug44523-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4501-expected.png:
- platform/qt/tables/mozilla/bugs/bug4501-expected.txt:
- platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug45055-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug45055-expected.png:
- platform/qt/tables/mozilla/bugs/bug45055-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4520-expected.png:
- platform/qt/tables/mozilla/bugs/bug4520-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4523-expected.png:
- platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4527-expected.png:
- platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
- platform/qt/tables/mozilla/bugs/bug45486-expected.png:
- platform/qt/tables/mozilla/bugs/bug45486-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4576-expected.png:
- platform/qt/tables/mozilla/bugs/bug4576-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46268-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46268-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46268-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46268-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46623-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46924-expected.png:
- platform/qt/tables/mozilla/bugs/bug46924-expected.txt:
- platform/qt/tables/mozilla/bugs/bug46944-expected.png:
- platform/qt/tables/mozilla/bugs/bug46944-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4739-expected.png:
- platform/qt/tables/mozilla/bugs/bug4739-expected.txt:
- platform/qt/tables/mozilla/bugs/bug47432-expected.png:
- platform/qt/tables/mozilla/bugs/bug47432-expected.txt:
- platform/qt/tables/mozilla/bugs/bug48028-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug48028-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4803-expected.png:
- platform/qt/tables/mozilla/bugs/bug4803-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4849-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug4849-expected.png:
- platform/qt/tables/mozilla/bugs/bug4849-expected.txt:
- platform/qt/tables/mozilla/bugs/bug48827-expected.png:
- platform/qt/tables/mozilla/bugs/bug48827-expected.txt:
- platform/qt/tables/mozilla/bugs/bug50695-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug50695-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug51037-expected.png:
- platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
- platform/qt/tables/mozilla/bugs/bug51140-expected.png:
- platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
- platform/qt/tables/mozilla/bugs/bug51727-expected.png:
- platform/qt/tables/mozilla/bugs/bug51727-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5188-expected.png:
- platform/qt/tables/mozilla/bugs/bug5188-expected.txt:
- platform/qt/tables/mozilla/bugs/bug52505-expected.png:
- platform/qt/tables/mozilla/bugs/bug52505-expected.txt:
- platform/qt/tables/mozilla/bugs/bug52506-expected.png:
- platform/qt/tables/mozilla/bugs/bug52506-expected.txt:
- platform/qt/tables/mozilla/bugs/bug53891-expected.png:
- platform/qt/tables/mozilla/bugs/bug53891-expected.txt:
- platform/qt/tables/mozilla/bugs/bug54450-expected.png:
- platform/qt/tables/mozilla/bugs/bug54450-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5538-expected.png:
- platform/qt/tables/mozilla/bugs/bug5538-expected.txt:
- platform/qt/tables/mozilla/bugs/bug55527-expected.png:
- platform/qt/tables/mozilla/bugs/bug55527-expected.txt:
- platform/qt/tables/mozilla/bugs/bug55545-expected.png:
- platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
- platform/qt/tables/mozilla/bugs/bug55694-expected.png:
- platform/qt/tables/mozilla/bugs/bug55694-expected.txt:
- platform/qt/tables/mozilla/bugs/bug56563-expected.png:
- platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
- platform/qt/tables/mozilla/bugs/bug57300-expected.png:
- platform/qt/tables/mozilla/bugs/bug57300-expected.txt:
- platform/qt/tables/mozilla/bugs/bug57378-expected.png:
- platform/qt/tables/mozilla/bugs/bug57378-expected.txt:
- platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug57828-expected.png:
- platform/qt/tables/mozilla/bugs/bug57828-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5797-expected.png:
- platform/qt/tables/mozilla/bugs/bug5797-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5798-expected.png:
- platform/qt/tables/mozilla/bugs/bug5798-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5799-expected.png:
- platform/qt/tables/mozilla/bugs/bug5799-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5835-expected.png:
- platform/qt/tables/mozilla/bugs/bug5835-expected.txt:
- platform/qt/tables/mozilla/bugs/bug5838-expected.png:
- platform/qt/tables/mozilla/bugs/bug5838-expected.txt:
- platform/qt/tables/mozilla/bugs/bug58402-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug58402-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug59354-expected.png:
- platform/qt/tables/mozilla/bugs/bug59354-expected.txt:
- platform/qt/tables/mozilla/bugs/bug60013-expected.png:
- platform/qt/tables/mozilla/bugs/bug60013-expected.txt:
- platform/qt/tables/mozilla/bugs/bug60749-expected.png:
- platform/qt/tables/mozilla/bugs/bug60749-expected.txt:
- platform/qt/tables/mozilla/bugs/bug60804-expected.png:
- platform/qt/tables/mozilla/bugs/bug60804-expected.txt:
- platform/qt/tables/mozilla/bugs/bug60807-expected.png:
- platform/qt/tables/mozilla/bugs/bug60807-expected.txt:
- platform/qt/tables/mozilla/bugs/bug60992-expected.png:
- platform/qt/tables/mozilla/bugs/bug60992-expected.txt:
- platform/qt/tables/mozilla/bugs/bug6184-expected.png:
- platform/qt/tables/mozilla/bugs/bug6184-expected.txt:
- platform/qt/tables/mozilla/bugs/bug625-expected.png:
- platform/qt/tables/mozilla/bugs/bug625-expected.txt:
- platform/qt/tables/mozilla/bugs/bug6304-expected.png:
- platform/qt/tables/mozilla/bugs/bug6304-expected.txt:
- platform/qt/tables/mozilla/bugs/bug63785-expected.png:
- platform/qt/tables/mozilla/bugs/bug63785-expected.txt:
- platform/qt/tables/mozilla/bugs/bug6404-expected.png:
- platform/qt/tables/mozilla/bugs/bug6404-expected.txt:
- platform/qt/tables/mozilla/bugs/bug647-expected.png:
- platform/qt/tables/mozilla/bugs/bug647-expected.txt:
- platform/qt/tables/mozilla/bugs/bug650-expected.png:
- platform/qt/tables/mozilla/bugs/bug650-expected.txt:
- platform/qt/tables/mozilla/bugs/bug6674-expected.png:
- platform/qt/tables/mozilla/bugs/bug6674-expected.txt:
- platform/qt/tables/mozilla/bugs/bug67864-expected.png:
- platform/qt/tables/mozilla/bugs/bug67864-expected.txt:
- platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug68912-expected.png:
- platform/qt/tables/mozilla/bugs/bug68912-expected.txt:
- platform/qt/tables/mozilla/bugs/bug68998-expected.png:
- platform/qt/tables/mozilla/bugs/bug68998-expected.txt:
- platform/qt/tables/mozilla/bugs/bug69187-expected.png:
- platform/qt/tables/mozilla/bugs/bug69187-expected.txt:
- platform/qt/tables/mozilla/bugs/bug69382-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug69382-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug709-expected.png:
- platform/qt/tables/mozilla/bugs/bug709-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7121-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug7121-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug72359-expected.png:
- platform/qt/tables/mozilla/bugs/bug72359-expected.txt:
- platform/qt/tables/mozilla/bugs/bug727-expected.png:
- platform/qt/tables/mozilla/bugs/bug727-expected.txt:
- platform/qt/tables/mozilla/bugs/bug73321-expected.png:
- platform/qt/tables/mozilla/bugs/bug73321-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7342-expected.png:
- platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7471-expected.png:
- platform/qt/tables/mozilla/bugs/bug7471-expected.txt:
- platform/qt/tables/mozilla/bugs/bug75250-expected.png:
- platform/qt/tables/mozilla/bugs/bug75250-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7714-expected.png:
- platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
- platform/qt/tables/mozilla/bugs/bug78162-expected.png:
- platform/qt/tables/mozilla/bugs/bug78162-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8032-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug80762-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug80762-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug81934-expected.png:
- platform/qt/tables/mozilla/bugs/bug81934-expected.txt:
- platform/qt/tables/mozilla/bugs/bug82946-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug82946-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug83786-expected.png:
- platform/qt/tables/mozilla/bugs/bug83786-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8381-expected.png:
- platform/qt/tables/mozilla/bugs/bug8381-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8411-expected.png:
- platform/qt/tables/mozilla/bugs/bug8411-expected.txt:
- platform/qt/tables/mozilla/bugs/bug86220-expected.png:
- platform/qt/tables/mozilla/bugs/bug86220-expected.txt:
- platform/qt/tables/mozilla/bugs/bug86708-expected.png:
- platform/qt/tables/mozilla/bugs/bug86708-expected.txt:
- platform/qt/tables/mozilla/bugs/bug88035-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug88035-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug88035-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug88035-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8858-expected.png:
- platform/qt/tables/mozilla/bugs/bug8858-expected.txt:
- platform/qt/tables/mozilla/bugs/bug8950-expected.png:
- platform/qt/tables/mozilla/bugs/bug8950-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9123-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9123-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug92143-expected.png:
- platform/qt/tables/mozilla/bugs/bug92143-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug9271-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug92868-expected.png:
- platform/qt/tables/mozilla/bugs/bug92868-expected.txt:
- platform/qt/tables/mozilla/bugs/bug93363-expected.png:
- platform/qt/tables/mozilla/bugs/bug93363-expected.txt:
- platform/qt/tables/mozilla/bugs/bug963-expected.png:
- platform/qt/tables/mozilla/bugs/bug963-expected.txt:
- platform/qt/tables/mozilla/bugs/bug96334-expected.png:
- platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
- platform/qt/tables/mozilla/bugs/bug96343-expected.png:
- platform/qt/tables/mozilla/bugs/bug96343-expected.txt:
- platform/qt/tables/mozilla/bugs/bug965-expected.png:
- platform/qt/tables/mozilla/bugs/bug965-expected.txt:
- platform/qt/tables/mozilla/bugs/bug97138-expected.png:
- platform/qt/tables/mozilla/bugs/bug97138-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9879-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug99923-expected.png:
- platform/qt/tables/mozilla/bugs/bug99923-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug127040-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug127040-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.png:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/core/borders-expected.png:
- platform/qt/tables/mozilla/core/borders-expected.txt:
- platform/qt/tables/mozilla/core/box_sizing-expected.png:
- platform/qt/tables/mozilla/core/box_sizing-expected.txt:
- platform/qt/tables/mozilla/core/captions-expected.png:
- platform/qt/tables/mozilla/core/captions-expected.txt:
- platform/qt/tables/mozilla/core/cell_heights-expected.png:
- platform/qt/tables/mozilla/core/cell_heights-expected.txt:
- platform/qt/tables/mozilla/core/col_span-expected.png:
- platform/qt/tables/mozilla/core/col_span-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_auto-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_auto-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_auto_per-expected.png:
- platform/qt/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_fix_auto-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_auto-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/qt/tables/mozilla/core/col_widths_fix_per-expected.png:
- platform/qt/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/qt/tables/mozilla/core/margins-expected.png:
- platform/qt/tables/mozilla/core/margins-expected.txt:
- platform/qt/tables/mozilla/core/misc-expected.png:
- platform/qt/tables/mozilla/core/misc-expected.txt:
- platform/qt/tables/mozilla/core/nested1-expected.png:
- platform/qt/tables/mozilla/core/nested1-expected.txt:
- platform/qt/tables/mozilla/core/one_row-expected.png:
- platform/qt/tables/mozilla/core/one_row-expected.txt:
- platform/qt/tables/mozilla/core/row_span-expected.png:
- platform/qt/tables/mozilla/core/row_span-expected.txt:
- platform/qt/tables/mozilla/core/table_frame-expected.png:
- platform/qt/tables/mozilla/core/table_frame-expected.txt:
- platform/qt/tables/mozilla/core/table_heights-expected.png:
- platform/qt/tables/mozilla/core/table_heights-expected.txt:
- platform/qt/tables/mozilla/core/table_rules-expected.png:
- platform/qt/tables/mozilla/core/table_rules-expected.txt:
- platform/qt/tables/mozilla/core/table_widths-expected.png:
- platform/qt/tables/mozilla/core/table_widths-expected.txt:
- platform/qt/tables/mozilla/dom/appendCol2-expected.png:
- platform/qt/tables/mozilla/dom/appendCol2-expected.txt:
- platform/qt/tables/mozilla/dom/appendRowsExpand1-expected.png:
- platform/qt/tables/mozilla/dom/appendRowsExpand1-expected.txt:
- platform/qt/tables/mozilla/dom/appendTbodyExpand1-expected.png:
- platform/qt/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteCellsShrink1-expected.png:
- platform/qt/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteCellsShrink2-expected.png:
- platform/qt/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
- platform/qt/tables/mozilla/dom/deleteCol1-expected.png:
- platform/qt/tables/mozilla/dom/deleteCol1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteCol2-expected.png:
- platform/qt/tables/mozilla/dom/deleteCol2-expected.txt:
- platform/qt/tables/mozilla/dom/deleteCol3-expected.png:
- platform/qt/tables/mozilla/dom/deleteCol3-expected.txt:
- platform/qt/tables/mozilla/dom/deleteColGroup1-expected.png:
- platform/qt/tables/mozilla/dom/deleteColGroup1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteColGroup2-expected.png:
- platform/qt/tables/mozilla/dom/deleteColGroup2-expected.txt:
- platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.png:
- platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
- platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
- platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
- platform/qt/tables/mozilla/dom/insertCellsExpand1-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsExpand1-expected.txt:
- platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.txt:
- platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
- platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.png:
- platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
- platform/qt/tables/mozilla/dom/insertColGroups1-expected.png:
- platform/qt/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/qt/tables/mozilla/dom/insertColGroups2-expected.png:
- platform/qt/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/qt/tables/mozilla/dom/insertCols1-expected.png:
- platform/qt/tables/mozilla/dom/insertCols1-expected.txt:
- platform/qt/tables/mozilla/dom/insertCols2-expected.png:
- platform/qt/tables/mozilla/dom/insertCols2-expected.txt:
- platform/qt/tables/mozilla/dom/insertCols3-expected.png:
- platform/qt/tables/mozilla/dom/insertCols3-expected.txt:
- platform/qt/tables/mozilla/dom/insertCols4-expected.png:
- platform/qt/tables/mozilla/dom/insertCols4-expected.txt:
- platform/qt/tables/mozilla/dom/insertCols5-expected.png:
- platform/qt/tables/mozilla/dom/insertCols5-expected.txt:
- platform/qt/tables/mozilla/dom/insertRowsExpand1-expected.png:
- platform/qt/tables/mozilla/dom/insertRowsExpand1-expected.txt:
- platform/qt/tables/mozilla/dom/insertRowsRebuild1-expected.png:
- platform/qt/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
- platform/qt/tables/mozilla/dom/tableDom-expected.png:
- platform/qt/tables/mozilla/dom/tableDom-expected.txt:
- 6:37 AM EFLWebKit edited by
- (diff)
- 6:13 AM EFLWebKit edited by
- (diff)
- 5:45 AM EFLWebKit edited by
- (diff)
- 5:43 AM Changeset in webkit [122718] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Adding flaky tests to TextExpectations.
https://bugs.webkit.org/show_bug.cgi?id=91379
https://bugs.webkit.org/show_bug.cgi?id=91376
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-16
- platform/qt/TestExpectations:
- 5:42 AM Changeset in webkit [122717] by
-
- 19 edits in trunk/Source/WebCore
Web Inspector: moving forward to the better memory instrumentation API
https://bugs.webkit.org/show_bug.cgi?id=91259
Reviewed by Pavel Feldman.
I'm trying to remove unnecessary complexity of the API
reportInstrumentedObject and reportInstrumentedPointer will be replaced with addInstrumentedMember
The same will happen with reportPointer, reportObject pair.
Also info.report* will be replaced with info.add*
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addInstrumentedMember):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addMember):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedMember):
(WebCore::MemoryInstrumentation::OwningTraits::addMember):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore::MemoryInstrumentation::addMemberImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore::MemoryClassInfo::addHashMap):
(WebCore::MemoryClassInfo::addHashSet):
(WebCore::MemoryClassInfo::addListHashSet):
(WebCore::MemoryClassInfo::addVector):
(WebCore::MemoryClassInfo::addString):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- 5:37 AM Changeset in webkit [122716] by
-
- 306 edits8 adds in trunk/LayoutTests
[Qt] platform/qt/editing/selection tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91088
Unreviewed rebaseline.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-16
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/editing/selection/13804-expected.png:
- platform/qt/editing/selection/13804-expected.txt:
- platform/qt/editing/selection/14971-expected.png:
- platform/qt/editing/selection/14971-expected.txt:
- platform/qt/editing/selection/3690703-2-expected.png:
- platform/qt/editing/selection/3690703-2-expected.txt:
- platform/qt/editing/selection/3690703-expected.png:
- platform/qt/editing/selection/3690703-expected.txt:
- platform/qt/editing/selection/3690719-expected.png:
- platform/qt/editing/selection/3690719-expected.txt:
- platform/qt/editing/selection/4397952-expected.png:
- platform/qt/editing/selection/4397952-expected.txt:
- platform/qt/editing/selection/4402375-expected.png:
- platform/qt/editing/selection/4402375-expected.txt:
- platform/qt/editing/selection/4776665-expected.png:
- platform/qt/editing/selection/4776665-expected.txt:
- platform/qt/editing/selection/4818145-expected.png:
- platform/qt/editing/selection/4818145-expected.txt:
- platform/qt/editing/selection/4866671-expected.png:
- platform/qt/editing/selection/4866671-expected.txt:
- platform/qt/editing/selection/4889598-expected.png:
- platform/qt/editing/selection/4889598-expected.txt:
- platform/qt/editing/selection/4895428-2-expected.png:
- platform/qt/editing/selection/4895428-2-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.png:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4932260-1-expected.png:
- platform/qt/editing/selection/4932260-1-expected.txt:
- platform/qt/editing/selection/4932260-2-expected.png:
- platform/qt/editing/selection/4932260-2-expected.txt:
- platform/qt/editing/selection/4932260-3-expected.png:
- platform/qt/editing/selection/4932260-3-expected.txt:
- platform/qt/editing/selection/4947387-expected.png:
- platform/qt/editing/selection/4947387-expected.txt:
- platform/qt/editing/selection/4960116-expected.png:
- platform/qt/editing/selection/4960116-expected.txt:
- platform/qt/editing/selection/4960137-expected.png:
- platform/qt/editing/selection/4960137-expected.txt:
- platform/qt/editing/selection/4975120-expected.png:
- platform/qt/editing/selection/4975120-expected.txt:
- platform/qt/editing/selection/4983858-expected.png:
- platform/qt/editing/selection/4983858-expected.txt:
- platform/qt/editing/selection/5007143-2-expected.png:
- platform/qt/editing/selection/5007143-2-expected.txt:
- platform/qt/editing/selection/5007143-expected.png:
- platform/qt/editing/selection/5007143-expected.txt:
- platform/qt/editing/selection/5057506-2-expected.png:
- platform/qt/editing/selection/5057506-2-expected.txt:
- platform/qt/editing/selection/5057506-expected.png:
- platform/qt/editing/selection/5057506-expected.txt:
- platform/qt/editing/selection/5076323-1-expected.png:
- platform/qt/editing/selection/5076323-1-expected.txt:
- platform/qt/editing/selection/5076323-2-expected.png:
- platform/qt/editing/selection/5076323-2-expected.txt:
- platform/qt/editing/selection/5076323-3-expected.png:
- platform/qt/editing/selection/5076323-3-expected.txt:
- platform/qt/editing/selection/5081257-1-expected.png:
- platform/qt/editing/selection/5081257-1-expected.txt:
- platform/qt/editing/selection/5081257-2-expected.png:
- platform/qt/editing/selection/5081257-2-expected.txt:
- platform/qt/editing/selection/5099303-expected.png:
- platform/qt/editing/selection/5099303-expected.txt:
- platform/qt/editing/selection/5131716-1-expected.png:
- platform/qt/editing/selection/5131716-1-expected.txt:
- platform/qt/editing/selection/5131716-2-expected.png:
- platform/qt/editing/selection/5131716-2-expected.txt:
- platform/qt/editing/selection/5131716-3-expected.png:
- platform/qt/editing/selection/5131716-3-expected.txt:
- platform/qt/editing/selection/5131716-4-expected.png:
- platform/qt/editing/selection/5131716-4-expected.txt:
- platform/qt/editing/selection/5195166-2-expected.png:
- platform/qt/editing/selection/5195166-2-expected.txt:
- platform/qt/editing/selection/5234383-1-expected.png:
- platform/qt/editing/selection/5234383-1-expected.txt:
- platform/qt/editing/selection/5234383-2-expected.png:
- platform/qt/editing/selection/5234383-2-expected.txt:
- platform/qt/editing/selection/5240265-expected.png:
- platform/qt/editing/selection/5240265-expected.txt:
- platform/qt/editing/selection/5354455-2-expected.png:
- platform/qt/editing/selection/5354455-2-expected.txt:
- platform/qt/editing/selection/6476-expected.png:
- platform/qt/editing/selection/6476-expected.txt:
- platform/qt/editing/selection/7152-1-expected.png:
- platform/qt/editing/selection/7152-1-expected.txt:
- platform/qt/editing/selection/7152-2-expected.png:
- platform/qt/editing/selection/7152-2-expected.txt:
- platform/qt/editing/selection/addRange-expected.png:
- platform/qt/editing/selection/addRange-expected.txt:
- platform/qt/editing/selection/after-line-wrap-expected.png:
- platform/qt/editing/selection/after-line-wrap-expected.txt:
- platform/qt/editing/selection/caret-and-focus-ring-expected.png:
- platform/qt/editing/selection/caret-and-focus-ring-expected.txt:
- platform/qt/editing/selection/caret-before-select-expected.png:
- platform/qt/editing/selection/caret-before-select-expected.txt:
- platform/qt/editing/selection/clear-selection-expected.png:
- platform/qt/editing/selection/clear-selection-expected.txt:
- platform/qt/editing/selection/click-start-of-line-expected.png:
- platform/qt/editing/selection/click-start-of-line-expected.txt:
- platform/qt/editing/selection/contenteditable-click-inside-expected.png:
- platform/qt/editing/selection/contenteditable-click-inside-expected.txt:
- platform/qt/editing/selection/display-table-text-expected.png:
- platform/qt/editing/selection/display-table-text-expected.txt:
- platform/qt/editing/selection/doubleclick-crash-expected.png:
- platform/qt/editing/selection/doubleclick-crash-expected.txt:
- platform/qt/editing/selection/drag-in-iframe-expected.png:
- platform/qt/editing/selection/drag-in-iframe-expected.txt:
- platform/qt/editing/selection/drag-select-1-expected.png:
- platform/qt/editing/selection/drag-select-1-expected.txt:
- platform/qt/editing/selection/editable-html-element-expected.png:
- platform/qt/editing/selection/editable-html-element-expected.txt:
- platform/qt/editing/selection/editable-non-editable-crash-expected.png:
- platform/qt/editing/selection/editable-non-editable-crash-expected.txt:
- platform/qt/editing/selection/end-of-document-expected.png:
- platform/qt/editing/selection/end-of-document-expected.txt:
- platform/qt/editing/selection/expanding-selections-expected.png:
- platform/qt/editing/selection/expanding-selections-expected.txt:
- platform/qt/editing/selection/expanding-selections2-expected.png:
- platform/qt/editing/selection/expanding-selections2-expected.txt:
- platform/qt/editing/selection/extend-by-character-001-expected.png:
- platform/qt/editing/selection/extend-by-character-001-expected.txt:
- platform/qt/editing/selection/extend-by-character-002-expected.png:
- platform/qt/editing/selection/extend-by-character-002-expected.txt:
- platform/qt/editing/selection/extend-by-character-003-expected.png:
- platform/qt/editing/selection/extend-by-character-003-expected.txt:
- platform/qt/editing/selection/extend-by-character-004-expected.png:
- platform/qt/editing/selection/extend-by-character-004-expected.txt:
- platform/qt/editing/selection/extend-by-character-005-expected.png:
- platform/qt/editing/selection/extend-by-character-005-expected.txt:
- platform/qt/editing/selection/extend-by-character-006-expected.png:
- platform/qt/editing/selection/extend-by-character-006-expected.txt:
- platform/qt/editing/selection/extend-by-sentence-001-expected.png:
- platform/qt/editing/selection/extend-by-sentence-001-expected.txt:
- platform/qt/editing/selection/extend-by-word-001-expected.png:
- platform/qt/editing/selection/extend-by-word-001-expected.txt:
- platform/qt/editing/selection/extend-by-word-002-expected.png:
- platform/qt/editing/selection/extend-by-word-002-expected.txt:
- platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
- platform/qt/editing/selection/extend-inside-transforms-backward-expected.txt:
- platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
- platform/qt/editing/selection/extend-inside-transforms-forward-expected.txt:
- platform/qt/editing/selection/fake-doubleclick-expected.png:
- platform/qt/editing/selection/fake-doubleclick-expected.txt:
- platform/qt/editing/selection/focus-body-expected.png:
- platform/qt/editing/selection/focus-body-expected.txt:
- platform/qt/editing/selection/focus_editable_html-expected.png:
- platform/qt/editing/selection/focus_editable_html-expected.txt:
- platform/qt/editing/selection/iframe-expected.png:
- platform/qt/editing/selection/iframe-expected.txt:
- platform/qt/editing/selection/image-before-linebreak-expected.png:
- platform/qt/editing/selection/image-before-linebreak-expected.txt:
- platform/qt/editing/selection/inline-closest-leaf-child-expected.png:
- platform/qt/editing/selection/inline-closest-leaf-child-expected.txt:
- platform/qt/editing/selection/inline-table-expected.png:
- platform/qt/editing/selection/inline-table-expected.txt:
- platform/qt/editing/selection/leave-requested-block-expected.png:
- platform/qt/editing/selection/leave-requested-block-expected.txt:
- platform/qt/editing/selection/line-wrap-1-expected.png:
- platform/qt/editing/selection/line-wrap-1-expected.txt:
- platform/qt/editing/selection/line-wrap-2-expected.png:
- platform/qt/editing/selection/line-wrap-2-expected.txt:
- platform/qt/editing/selection/mixed-editability-1-expected.png:
- platform/qt/editing/selection/mixed-editability-1-expected.txt:
- platform/qt/editing/selection/mixed-editability-2-expected.png:
- platform/qt/editing/selection/mixed-editability-2-expected.txt:
- platform/qt/editing/selection/mixed-editability-3-expected.png:
- platform/qt/editing/selection/mixed-editability-3-expected.txt:
- platform/qt/editing/selection/mixed-editability-4-expected.png:
- platform/qt/editing/selection/mixed-editability-4-expected.txt:
- platform/qt/editing/selection/mixed-editability-5-expected.png:
- platform/qt/editing/selection/mixed-editability-5-expected.txt:
- platform/qt/editing/selection/mixed-editability-6-expected.png:
- platform/qt/editing/selection/mixed-editability-6-expected.txt:
- platform/qt/editing/selection/mixed-editability-7-expected.png:
- platform/qt/editing/selection/mixed-editability-7-expected.txt:
- platform/qt/editing/selection/mixed-editability-8-expected.png:
- platform/qt/editing/selection/mixed-editability-8-expected.txt:
- platform/qt/editing/selection/mixed-editability-9-expected.png:
- platform/qt/editing/selection/mixed-editability-9-expected.txt:
- platform/qt/editing/selection/move-3875618-fix-expected.png:
- platform/qt/editing/selection/move-3875618-fix-expected.txt:
- platform/qt/editing/selection/move-3875641-fix-expected.png:
- platform/qt/editing/selection/move-3875641-fix-expected.txt:
- platform/qt/editing/selection/move-backwords-by-word-001-expected.png:
- platform/qt/editing/selection/move-backwords-by-word-001-expected.txt:
- platform/qt/editing/selection/move-between-blocks-no-001-expected.png:
- platform/qt/editing/selection/move-between-blocks-no-001-expected.txt:
- platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
- platform/qt/editing/selection/move-between-blocks-yes-001-expected.txt:
- platform/qt/editing/selection/move-by-character-001-expected.png:
- platform/qt/editing/selection/move-by-character-001-expected.txt:
- platform/qt/editing/selection/move-by-character-002-expected.png:
- platform/qt/editing/selection/move-by-character-002-expected.txt:
- platform/qt/editing/selection/move-by-character-003-expected.png:
- platform/qt/editing/selection/move-by-character-003-expected.txt:
- platform/qt/editing/selection/move-by-character-004-expected.png:
- platform/qt/editing/selection/move-by-character-004-expected.txt:
- platform/qt/editing/selection/move-by-character-005-expected.png:
- platform/qt/editing/selection/move-by-character-005-expected.txt:
- platform/qt/editing/selection/move-by-character-6-expected.png:
- platform/qt/editing/selection/move-by-character-6-expected.txt:
- platform/qt/editing/selection/move-by-line-001-expected.png:
- platform/qt/editing/selection/move-by-line-001-expected.txt:
- platform/qt/editing/selection/move-by-line-002-expected.png:
- platform/qt/editing/selection/move-by-line-002-expected.txt:
- platform/qt/editing/selection/move-by-sentence-001-expected.png:
- platform/qt/editing/selection/move-by-sentence-001-expected.txt:
- platform/qt/editing/selection/move-by-sentence-linebreak-expected.png:
- platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
- platform/qt/editing/selection/move-by-word-001-expected.png:
- platform/qt/editing/selection/move-by-word-001-expected.txt:
- platform/qt/editing/selection/node-removal-1-expected.png:
- platform/qt/editing/selection/node-removal-1-expected.txt:
- platform/qt/editing/selection/node-removal-2-expected.png:
- platform/qt/editing/selection/node-removal-2-expected.txt:
- platform/qt/editing/selection/paragraph-granularity-expected.png:
- platform/qt/editing/selection/paragraph-granularity-expected.txt:
- platform/qt/editing/selection/previous-line-position-expected.png:
- platform/qt/editing/selection/previous-line-position-expected.txt:
- platform/qt/editing/selection/range-between-block-and-inline-expected.png:
- platform/qt/editing/selection/range-between-block-and-inline-expected.txt:
- platform/qt/editing/selection/replace-selection-1-expected.png:
- platform/qt/editing/selection/replace-selection-1-expected.txt:
- platform/qt/editing/selection/replaced-boundaries-1-expected.png:
- platform/qt/editing/selection/replaced-boundaries-1-expected.txt:
- platform/qt/editing/selection/replaced-boundaries-2-expected.png:
- platform/qt/editing/selection/replaced-boundaries-2-expected.txt:
- platform/qt/editing/selection/replaced-boundaries-3-expected.png:
- platform/qt/editing/selection/replaced-boundaries-3-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
- platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/qt/editing/selection/select-all-001-expected.png:
- platform/qt/editing/selection/select-all-001-expected.txt:
- platform/qt/editing/selection/select-all-002-expected.png:
- platform/qt/editing/selection/select-all-002-expected.txt:
- platform/qt/editing/selection/select-all-003-expected.png:
- platform/qt/editing/selection/select-all-003-expected.txt:
- platform/qt/editing/selection/select-all-004-expected.png:
- platform/qt/editing/selection/select-all-004-expected.txt:
- platform/qt/editing/selection/select-all-005-expected.png:
- platform/qt/editing/selection/select-all-005-expected.txt:
- platform/qt/editing/selection/select-all-006-expected.png:
- platform/qt/editing/selection/select-all-006-expected.txt:
- platform/qt/editing/selection/select-all-iframe-expected.png:
- platform/qt/editing/selection/select-all-iframe-expected.txt:
- platform/qt/editing/selection/select-box-expected.png:
- platform/qt/editing/selection/select-box-expected.txt:
- platform/qt/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/qt/editing/selection/select-element-paragraph-boundary-expected.txt:
- platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
- platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
- platform/qt/editing/selection/selectNode-expected.png:
- platform/qt/editing/selection/selectNode-expected.txt:
- platform/qt/editing/selection/selectNodeContents-expected.png:
- platform/qt/editing/selection/selectNodeContents-expected.txt:
- platform/qt/editing/selection/selection-3748164-fix-expected.png:
- platform/qt/editing/selection/selection-3748164-fix-expected.txt:
- platform/qt/editing/selection/selection-actions-expected.png:
- platform/qt/editing/selection/selection-actions-expected.txt:
- platform/qt/editing/selection/selection-background-expected.png:
- platform/qt/editing/selection/selection-background-expected.txt:
- platform/qt/editing/selection/selection-button-text-expected.png:
- platform/qt/editing/selection/selection-button-text-expected.txt:
- platform/qt/editing/selection/table-caret-1-expected.png:
- platform/qt/editing/selection/table-caret-1-expected.txt:
- platform/qt/editing/selection/table-caret-2-expected.png:
- platform/qt/editing/selection/table-caret-2-expected.txt:
- platform/qt/editing/selection/table-caret-3-expected.png:
- platform/qt/editing/selection/table-caret-3-expected.txt:
- platform/qt/editing/selection/triple-click-in-pre-expected.png:
- platform/qt/editing/selection/triple-click-in-pre-expected.txt:
- platform/qt/editing/selection/unrendered-space-expected.png:
- platform/qt/editing/selection/unrendered-space-expected.txt:
- platform/qt/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
- platform/qt/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
- platform/qt/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
- platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/qt/editing/selection/word-granularity-expected.png:
- platform/qt/editing/selection/word-granularity-expected.txt:
- platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
- platform/qt/editing/selection/wrapped-line-caret-1-expected.txt:
- platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
- platform/qt/editing/selection/wrapped-line-caret-2-expected.txt:
- 5:18 AM Changeset in webkit [122715] by
-
- 19 edits in trunk/Source/WebCore
Unreviewed, rolling out r122714.
http://trac.webkit.org/changeset/122714
https://bugs.webkit.org/show_bug.cgi?id=91380
It broke mac compilation (Requested by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::reportObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::reportPointer):
(WebCore::MemoryClassInfo::reportInstrumentedPointer):
(WebCore::MemoryClassInfo::reportInstrumentedObject):
(WebCore::MemoryClassInfo::reportPointer):
(WebCore::MemoryClassInfo::reportObject):
(WebCore::MemoryClassInfo::reportHashMap):
(WebCore::MemoryClassInfo::reportHashSet):
(WebCore::MemoryClassInfo::reportListHashSet):
(WebCore::MemoryClassInfo::reportVector):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::reportString):
(WebCore):
(WebCore::MemoryInstrumentation::reportInstrumentedPointer):
(WebCore::MemoryInstrumentation::reportInstrumentedObject):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportListHashSet):
(WebCore::MemoryInstrumentation::reportVector):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- 5:00 AM Changeset in webkit [122714] by
-
- 19 edits in trunk/Source/WebCore
Web Inspector: moving forward to the better memory instrumentation API
https://bugs.webkit.org/show_bug.cgi?id=91259
Reviewed by Pavel Feldman.
I'm trying to remove unnecessary complexity of the API
reportInstrumentedObject and reportInstrumentedPointer will be replaced with addInstrumentedMember
The same will happen with reportPointer, reportObject pair.
Also info.report* will be replaced with info.add*
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addInstrumentedMember):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addMember):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedMember):
(WebCore::MemoryInstrumentation::OwningTraits::addMember):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore::MemoryInstrumentation::addMemberImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore::MemoryClassInfo::addHashMap):
(WebCore::MemoryClassInfo::addHashSet):
(WebCore::MemoryClassInfo::addListHashSet):
(WebCore::MemoryClassInfo::addVector):
(WebCore::MemoryClassInfo::addString):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- 4:48 AM Changeset in webkit [122713] by
-
- 17 edits in trunk/Source/WebCore
Web Inspector: native memory instrumentation: extract instrumentation methods into MemoryClassInfo
https://bugs.webkit.org/show_bug.cgi?id=91227
Reviewed by Pavel Feldman.
void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
MemoryClassInfo<Node> info(memoryObjectInfo, this, MemoryInstrumentation::DOM);
info.visitBaseClass<ScriptWrappable>(this);
info.addMember(m_notInstrumentedPointer); automatically detects poniter/reference
info.addInstrumentedMember(m_next);
info.addHashSet<MemoryInstrumentation::NonClass>(m_aHash); NonClass value_type (report only size of internal template structures)
info.addHashSet<MemoryInstrumentation::NotInstrumentedClass>(m_aHashSet); not instrumented value_type (use sizeof)
info.addHashSet<MemoryInstrumentation::InstrumentedClass>(m_aHashSet); instrumented value_type (call visit)
}
The change is covered by existing tests for native memory snapshot.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::objectSize):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(WebCore::MemoryClassInfo::visitBaseClass):
(WebCore::MemoryClassInfo::reportInstrumentedPointer):
(WebCore::MemoryClassInfo::reportInstrumentedObject):
(WebCore::MemoryClassInfo::reportPointer):
(WebCore::MemoryClassInfo::reportObject):
(WebCore::MemoryClassInfo::reportHashMap):
(WebCore::MemoryClassInfo::reportHashSet):
(WebCore::MemoryClassInfo::reportListHashSet):
(WebCore::MemoryClassInfo::reportVector):
(WebCore::MemoryClassInfo::reportString):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- 4:28 AM Changeset in webkit [122712] by
-
- 252 edits1 copy2 adds in trunk/LayoutTests
[Qt] Update test expectations. Unskip now passing tests.
https://bugs.webkit.org/show_bug.cgi?id=91085.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16
Reviewed by Csaba Osztorgonác.
- platform/qt-5.0/Skipped:
- platform/qt/editing/deleting/4922367-expected.png:
- platform/qt/editing/deleting/4922367-expected.txt:
- platform/qt/editing/deleting/5099303-expected.png:
- platform/qt/editing/deleting/5099303-expected.txt:
- platform/qt/editing/deleting/5126166-expected.png:
- platform/qt/editing/deleting/5126166-expected.txt:
- platform/qt/editing/deleting/5144139-2-expected.png:
- platform/qt/editing/deleting/5144139-2-expected.txt:
- platform/qt/editing/deleting/5206311-1-expected.png:
- platform/qt/editing/deleting/5206311-1-expected.txt:
- platform/qt/editing/deleting/5272440-expected.png:
- platform/qt/editing/deleting/5272440-expected.txt:
- platform/qt/editing/deleting/5369009-expected.png:
- platform/qt/editing/deleting/5369009-expected.txt:
- platform/qt/editing/deleting/5433862-2-expected.png:
- platform/qt/editing/deleting/5433862-2-expected.txt:
- platform/qt/editing/deleting/5483370-expected.png:
- platform/qt/editing/deleting/5483370-expected.txt:
- platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
- platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/qt/editing/deleting/delete-3608445-fix-expected.png:
- platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
- platform/qt/editing/deleting/delete-3608462-fix-expected.png:
- platform/qt/editing/deleting/delete-3608462-fix-expected.txt:
- platform/qt/editing/deleting/delete-3775172-fix-expected.png:
- platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
- platform/qt/editing/deleting/delete-3800834-fix-expected.png:
- platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
- platform/qt/editing/deleting/delete-3857753-fix-expected.png:
- platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
- platform/qt/editing/deleting/delete-3865854-fix-expected.png:
- platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
- platform/qt/editing/deleting/delete-3928305-fix-expected.png:
- platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
- platform/qt/editing/deleting/delete-4083333-fix-expected.png:
- platform/qt/editing/deleting/delete-4083333-fix-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-001-expected.png:
- platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.png:
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.png:
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/qt/editing/deleting/delete-and-undo-expected.png:
- platform/qt/editing/deleting/delete-and-undo-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/qt/editing/deleting/delete-at-start-or-end-expected.png:
- platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-001-expected.png:
- platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-002-expected.png:
- platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-003-expected.png:
- platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-011-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/qt/editing/deleting/delete-br-001-expected.png:
- platform/qt/editing/deleting/delete-br-001-expected.txt:
- platform/qt/editing/deleting/delete-br-002-expected.png:
- platform/qt/editing/deleting/delete-br-002-expected.txt:
- platform/qt/editing/deleting/delete-br-003-expected.png:
- platform/qt/editing/deleting/delete-br-003-expected.txt:
- platform/qt/editing/deleting/delete-br-004-expected.png:
- platform/qt/editing/deleting/delete-br-004-expected.txt:
- platform/qt/editing/deleting/delete-br-005-expected.png:
- platform/qt/editing/deleting/delete-br-005-expected.txt:
- platform/qt/editing/deleting/delete-br-006-expected.png:
- platform/qt/editing/deleting/delete-br-006-expected.txt:
- platform/qt/editing/deleting/delete-br-007-expected.png:
- platform/qt/editing/deleting/delete-br-007-expected.txt:
- platform/qt/editing/deleting/delete-br-008-expected.png:
- platform/qt/editing/deleting/delete-br-008-expected.txt:
- platform/qt/editing/deleting/delete-br-009-expected.png:
- platform/qt/editing/deleting/delete-br-009-expected.txt:
- platform/qt/editing/deleting/delete-br-010-expected.png:
- platform/qt/editing/deleting/delete-br-010-expected.txt:
- platform/qt/editing/deleting/delete-br-013-expected.png:
- platform/qt/editing/deleting/delete-br-013-expected.txt:
- platform/qt/editing/deleting/delete-character-001-expected.png:
- platform/qt/editing/deleting/delete-character-001-expected.txt:
- platform/qt/editing/deleting/delete-contiguous-ws-001-expected.png:
- platform/qt/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-first-list-item-expected.png:
- platform/qt/editing/deleting/delete-first-list-item-expected.txt:
- platform/qt/editing/deleting/delete-hr-expected.png:
- platform/qt/editing/deleting/delete-hr-expected.txt:
- platform/qt/editing/deleting/delete-image-001-expected.png:
- platform/qt/editing/deleting/delete-image-001-expected.txt:
- platform/qt/editing/deleting/delete-image-002-expected.png:
- platform/qt/editing/deleting/delete-image-002-expected.txt:
- platform/qt/editing/deleting/delete-image-003-expected.png:
- platform/qt/editing/deleting/delete-image-003-expected.txt:
- platform/qt/editing/deleting/delete-image-004-expected.png:
- platform/qt/editing/deleting/delete-image-004-expected.txt:
- platform/qt/editing/deleting/delete-leading-ws-001-expected.png:
- platform/qt/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-line-001-expected.png:
- platform/qt/editing/deleting/delete-line-001-expected.txt:
- platform/qt/editing/deleting/delete-line-002-expected.png:
- platform/qt/editing/deleting/delete-line-002-expected.txt:
- platform/qt/editing/deleting/delete-line-003-expected.png:
- platform/qt/editing/deleting/delete-line-003-expected.txt:
- platform/qt/editing/deleting/delete-line-004-expected.png:
- platform/qt/editing/deleting/delete-line-004-expected.txt:
- platform/qt/editing/deleting/delete-line-005-expected.png:
- platform/qt/editing/deleting/delete-line-005-expected.txt:
- platform/qt/editing/deleting/delete-line-006-expected.png:
- platform/qt/editing/deleting/delete-line-006-expected.txt:
- platform/qt/editing/deleting/delete-line-007-expected.png:
- platform/qt/editing/deleting/delete-line-007-expected.txt:
- platform/qt/editing/deleting/delete-line-008-expected.png:
- platform/qt/editing/deleting/delete-line-008-expected.txt:
- platform/qt/editing/deleting/delete-line-009-expected.png:
- platform/qt/editing/deleting/delete-line-009-expected.txt:
- platform/qt/editing/deleting/delete-line-010-expected.png:
- platform/qt/editing/deleting/delete-line-010-expected.txt:
- platform/qt/editing/deleting/delete-line-011-expected.png:
- platform/qt/editing/deleting/delete-line-011-expected.txt:
- platform/qt/editing/deleting/delete-line-012-expected.png:
- platform/qt/editing/deleting/delete-line-012-expected.txt:
- platform/qt/editing/deleting/delete-line-013-expected.png:
- platform/qt/editing/deleting/delete-line-013-expected.txt:
- platform/qt/editing/deleting/delete-line-014-expected.png:
- platform/qt/editing/deleting/delete-line-014-expected.txt:
- platform/qt/editing/deleting/delete-line-015-expected.png:
- platform/qt/editing/deleting/delete-line-015-expected.txt:
- platform/qt/editing/deleting/delete-line-016-expected.png:
- platform/qt/editing/deleting/delete-line-016-expected.txt:
- platform/qt/editing/deleting/delete-line-017-expected.png:
- platform/qt/editing/deleting/delete-line-017-expected.txt:
- platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
- platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
- platform/qt/editing/deleting/delete-line-end-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-listitem-001-expected.png:
- platform/qt/editing/deleting/delete-listitem-001-expected.txt:
- platform/qt/editing/deleting/delete-listitem-002-expected.png:
- platform/qt/editing/deleting/delete-listitem-002-expected.txt:
- platform/qt/editing/deleting/delete-selection-001-expected.png:
- platform/qt/editing/deleting/delete-selection-001-expected.txt:
- platform/qt/editing/deleting/delete-to-select-table-expected.png:
- platform/qt/editing/deleting/delete-to-select-table-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.png:
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.png:
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-ws-fixup-001-expected.png:
- platform/qt/editing/deleting/delete-ws-fixup-001-expected.txt:
- platform/qt/editing/deleting/delete-ws-fixup-002-expected.png:
- platform/qt/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/qt/editing/deleting/delete-ws-fixup-003-expected.png:
- platform/qt/editing/deleting/delete-ws-fixup-003-expected.txt:
- platform/qt/editing/deleting/delete-ws-fixup-004-expected.png:
- platform/qt/editing/deleting/delete-ws-fixup-004-expected.txt:
- platform/qt/editing/deleting/deletionUI-single-instance-expected.png:
- platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
- platform/qt/editing/deleting/forward-delete-expected.png:
- platform/qt/editing/deleting/forward-delete-expected.txt:
- platform/qt/editing/deleting/list-item-1-expected.png:
- platform/qt/editing/deleting/list-item-1-expected.txt:
- platform/qt/editing/deleting/merge-different-styles-expected.png:
- platform/qt/editing/deleting/merge-different-styles-expected.txt:
- platform/qt/editing/deleting/merge-endOfParagraph-expected.png:
- platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/qt/editing/deleting/merge-no-br-expected.png:
- platform/qt/editing/deleting/merge-no-br-expected.txt:
- platform/qt/editing/deleting/merge-unrendered-space-expected.png:
- platform/qt/editing/deleting/merge-unrendered-space-expected.txt:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/qt/editing/deleting/move-nodes-001-expected.png:
- platform/qt/editing/deleting/move-nodes-001-expected.txt:
- platform/qt/editing/deleting/non-smart-delete-expected.png:
- platform/qt/editing/deleting/non-smart-delete-expected.txt:
- platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
- platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/qt/editing/deleting/smart-delete-001-expected.png:
- platform/qt/editing/deleting/smart-delete-001-expected.txt:
- platform/qt/editing/deleting/smart-delete-002-expected.png:
- platform/qt/editing/deleting/smart-delete-002-expected.txt:
- platform/qt/editing/deleting/smart-delete-003-expected.png: Added.
- platform/qt/editing/deleting/smart-delete-003-expected.txt:
- platform/qt/editing/deleting/smart-delete-004-expected.png: Added.
- platform/qt/editing/deleting/smart-delete-004-expected.txt:
- platform/qt/editing/deleting/table-cells-expected.png:
- platform/qt/editing/deleting/table-cells-expected.txt:
- platform/qt/editing/deleting/transpose-empty-expected.png: Copied from LayoutTests/platform/qt/editing/deleting/delete-at-start-or-end-expected.png.
- platform/qt/editing/deleting/type-delete-after-quote-expected.png:
- platform/qt/editing/deleting/type-delete-after-quote-expected.txt:
- 4:04 AM Changeset in webkit [122711] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, marked test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=91373
- platform/chromium/TestExpectations:
- 3:40 AM Changeset in webkit [122710] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91372
- platform/chromium/TestExpectations:
- 3:14 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 2:56 AM Changeset in webkit [122709] by
-
- 1 copy in releases/WebKitGTK/webkit-1.9.5
Tagging the WebKitGTK+ 1.9.5 release
- 2:43 AM Changeset in webkit [122708] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and configure.ac for 1.9.5 release
.:
- configure.ac: Bump version number.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.9.5.
- 2:38 AM Changeset in webkit [122707] by
-
- 7 edits in trunk
Unreviewed. Fix make distcheck.
Source/WebCore:
- GNUmakefile.am: Add missing idl directory.
- GNUmakefile.list.am: Add missing files to compilation.
Source/WebKit2:
- UIProcess/API/gtk/tests/GNUmakefile.am: Add test resources to
EXTRA_DIST.
Tools:
- GNUmakefile.am: Add missing file to compilation.
- 1:53 AM Changeset in webkit [122706] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Implement message loop instrumentation for timeline
https://bugs.webkit.org/show_bug.cgi?id=88325
Patch by Eugene Klyuchnikov <eustas.big@gmail.com> on 2012-07-16
Reviewed by Pavel Feldman.
Message loop instrumentation will show when the render thread is busy.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
Added new experiment.
- inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.get dividersLabelBarElement):
Exposed label bar element.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._resetPanel):
Cleanups recorded tasks.
(WebInspector.TimelinePanel.prototype._refresh):
Updates CPU bar.
(WebInspector.TimelinePanel.prototype._refreshRecords):
Ditto.
(WebInspector.TimelinePanel.prototype._refreshCpuBars.compareEndTime):
Ditto.
(WebInspector.TimelinePanel.prototype._refreshCpuBars):
Ditto.
(WebInspector.TimelinePanel.prototype._enableMainThreadMonitoringExperiment):
Adds CPU bar to UI.
(WebInspector.TimelinePanel.prototype._showPopover):
Fix NPE.
(WebInspector.TimelineCalculator.prototype.computeTime):
Utility for position to time conversion.
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
Remenbers clientWidth.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
Define CPU bar colors.
- inspector/front-end/timelinePanel.css:
(.timeline-cpu-bars):
CPU bar styles.
(.timeline-cpu-bars-label):
Ditto.
- 1:41 AM Changeset in webkit [122705] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark fast/forms/number/spin-button-gets-disabled-or-readonly.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=91367
Unreviewed EFL gardening. Mark fast/forms/number/spin-button-gets-disabled-or-readonly.html
as flaky.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-16
- platform/efl/TestExpectations:
- 1:41 AM EFLWebKitTests edited by
- (diff)
- 1:31 AM Changeset in webkit [122704] by
-
- 39 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines for MathML Presentation
layout tests. The tests are currently marked as flaky so bots should
do some more iterations to see if that's still the case or those
expectations will be removed.
- platform/gtk/mathml/presentation/attributes-expected.png:
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.png:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.png:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.png:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.png:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png: Added.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/gtk/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
- platform/gtk/mathml/presentation/over-expected.png:
- platform/gtk/mathml/presentation/over-expected.txt:
- platform/gtk/mathml/presentation/roots-expected.png:
- platform/gtk/mathml/presentation/roots-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.png:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.png:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.png:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/sub-expected.png:
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.png:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.png:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.png:
- platform/gtk/mathml/presentation/tables-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.png:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.png:
- platform/gtk/mathml/presentation/under-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.png:
- platform/gtk/mathml/presentation/underover-expected.txt:
- 12:54 AM Changeset in webkit [122703] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening, generating baselines for three tests that pass
but require specific baselines. Also removing their test expectations.
- platform/gtk/TestExpectations:
- platform/gtk/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
- platform/gtk/fast/profiler/dead-time-expected.txt: Added.
- platform/gtk/fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
- 12:45 AM Changeset in webkit [122702] by
-
- 5 edits2 adds in trunk/Source/WebKit
Source/WebKit: Add accessible for QWebView.
https://bugs.webkit.org/show_bug.cgi?id=91073
Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-07-16
Reviewed by Simon Hausmann.
Add classes to enable accessibility on the widget level.
- WebKit.pri:
- WebKit1.pro:
Source/WebKit/qt: Accessible Widget for QWebView
https://bugs.webkit.org/show_bug.cgi?id=91073
Added classes that allow navigation to the web view widget.
This is the glue to later access webkit's accessible objects
though the Qt accessibility framework.
Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-07-16
Reviewed by Simon Hausmann.
- Api/qwebview.cpp:
(QWebView::QWebView):
- Api/qwebviewaccessible.cpp: Added.
(accessibleInterfaceFactory):
(QWebFrameAccessible::QWebFrameAccessible):
(QWebFrameAccessible::frame):
(QWebFrameAccessible::parent):
(QWebFrameAccessible::text):
(QWebFrameAccessible::childCount):
(QWebFrameAccessible::child):
(QWebFrameAccessible::indexOfChild):
(QWebFrameAccessible::state):
(QWebFrameAccessible::role):
(QWebFrameAccessible::navigate):
(QWebPageAccessible::QWebPageAccessible):
(QWebPageAccessible::page):
(QWebPageAccessible::text):
(QWebPageAccessible::parent):
(QWebPageAccessible::child):
(QWebPageAccessible::childCount):
(QWebPageAccessible::indexOfChild):
(QWebPageAccessible::navigate):
(QWebPageAccessible::role):
(QWebPageAccessible::state):
(QWebViewAccessible::QWebViewAccessible):
(QWebViewAccessible::view):
(QWebViewAccessible::childCount):
(QWebViewAccessible::child):
- Api/qwebviewaccessible_p.h: Added.
(QWebFrameAccessible):
(QWebPageAccessible):
(QWebViewAccessible):
- 12:24 AM Changeset in webkit [122701] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r122681.
http://trac.webkit.org/changeset/122681
https://bugs.webkit.org/show_bug.cgi?id=91363
Patch introduces crashes in debug builds for GTK and EFL ports
(Requested by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):
- 12:11 AM Changeset in webkit [122700] by
-
- 3 edits in trunk/Source/WebCore
Compilation failure in StyleResolver.cpp (clang)
https://bugs.webkit.org/show_bug.cgi?id=89892
Reviewed by Ryosuke Niwa.
Patch adds assertions that unreachable code is in fact not reached.
Covered by fast/css/variables tests.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Jul 15, 2012:
- 11:50 PM Changeset in webkit [122699] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip the new failing test.
- platform/qt/Skipped:
- 11:44 PM Changeset in webkit [122698] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark a few media tests as flaky on RELEASE bot as well
https://bugs.webkit.org/show_bug.cgi?id=91361
Unreviewed EFL gardening. Mark a few media test as flaky on
the RELEASE bot as well.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
- platform/efl/TestExpectations:
- 11:25 PM Changeset in webkit [122697] by
-
- 9 edits in trunk/Source/WebKit2
[EFL][WK2] Define destructors for Ewk structures
https://bugs.webkit.org/show_bug.cgi?id=91338
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
Reviewed by Kentaro Hara.
Add destructors to Ewk structures and move
memory freeing code from *_free() or *_unref()
functions to the destructors.
- UIProcess/API/efl/ewk_intent.cpp:
(_Ewk_Intent::_Ewk_Intent):
(_Ewk_Intent):
(_Ewk_Intent::~_Ewk_Intent):
(ewk_intent_unref):
- UIProcess/API/efl/ewk_intent_service.cpp:
(_Ewk_Intent_Service):
(_Ewk_Intent_Service::~_Ewk_Intent_Service):
(ewk_intent_service_unref):
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):
- UIProcess/API/efl/ewk_url_request.cpp:
(_Ewk_Url_Request):
(_Ewk_Url_Request::~_Ewk_Url_Request):
(ewk_url_request_unref):
- UIProcess/API/efl/ewk_url_response.cpp:
(_Ewk_Url_Response):
(_Ewk_Url_Response::~_Ewk_Url_Response):
(ewk_url_response_unref):
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_del):
- UIProcess/API/efl/ewk_web_error.cpp:
(_Ewk_Web_Error):
(_Ewk_Web_Error::~_Ewk_Web_Error):
(ewk_web_error_free):
- UIProcess/API/efl/ewk_web_resource.cpp:
(_Ewk_Web_Resource):
(_Ewk_Web_Resource::~_Ewk_Web_Resource):
(ewk_web_resource_unref):
- 11:22 PM Changeset in webkit [122696] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip css3/flexbox/flexbox-overflow-auto.html
https://bugs.webkit.org/show_bug.cgi?id=91360
Unreviewed EFL gardening. Skip css3/flexbox/flexbox-overflow-auto.html
which started failing after r122681.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
- platform/efl/TestExpectations:
- 11:15 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:07 PM Changeset in webkit [122695] by
-
- 2 edits in trunk/LayoutTests
[EFL] Disable perf tests for DEBUG builds
https://bugs.webkit.org/show_bug.cgi?id=91358
Unreviewed EFL gardening. Disable performance tests
in DEBUG builds since they are really slow and there
are very few benefits in running them.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
- platform/efl/TestExpectations:
- 10:32 PM EFLWebKitCodingStyle edited by
- Add "Use "void" for empty parameter of public APIs" (diff)
- 10:26 PM Changeset in webkit [122694] by
-
- 8 edits2 adds in trunk
Fix calculation of rgba's alpha in CSS custom text
https://bugs.webkit.org/show_bug.cgi?id=91355
Reviewed by Ryosuke Niwa.
Source/WebCore:
Alpha values are stored as an 8 bit value. To convert this to a float in the
range [0,1], we need to divide by 255, not 256.
Test: fast/css/rgba-custom-text.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
LayoutTests:
- css3/calc/color-hsl-expected.txt:
- css3/calc/color-rgb-expected.txt:
- editing/execCommand/query-command-value-background-color-expected.txt:
- editing/execCommand/query-command-value-background-color.html:
- fast/css/rgba-custom-text-expected.txt: Added.
- fast/css/rgba-custom-text.html: Added.
- media/track/track-cue-rendering-expected.txt:
- 8:22 PM Changeset in webkit [122693] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Add a API for getting security origin string
https://bugs.webkit.org/show_bug.cgi?id=90936
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-15
Reviewed by Ryosuke Niwa.
Support to change from Ewk_Security_Origin to string on the API level.
Add ewk_security_origin_string_get for getting security origin string.
- ewk/ewk_security_origin.cpp:
(_Ewk_Security_Origin):
(ewk_security_origin_string_get):
(ewk_security_origin_free):
(ewk_security_origin_new):
- ewk/ewk_security_origin.h:
- 7:53 PM Changeset in webkit [122692] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] We shouldn't call didFinishLoading for the old request when a new request has been sent by notifyAuthReceived.
https://bugs.webkit.org/show_bug.cgi?id=90962
Reviewed by Rob Buis.
We start a new NetworkJob with credentials after receiving 401/407 status.
We should not release resources in webcore when the old job is closed because
they are needed by the new one.
We should do as 3XX.
No new tests. No change in behaviour.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::shouldReleaseClientResource):
(WebCore::NetworkJob::handleRedirect):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- 7:29 PM Changeset in webkit [122691] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Move icon database to application data directory.
https://bugs.webkit.org/show_bug.cgi?id=91195
Patch by Jonathan Dong <Jonathan Dong> on 2012-07-15
Reviewed by Rob Buis.
RIM PR: 156852
Create icon database in application data directory instead of
database or local storage directory, by doing this we can make
things easier when clearing database or local storage data files.
Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>
- WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
- 7:27 PM Changeset in webkit [122690] by
-
- 2 edits in trunk/LayoutTests
[EFL] Several media tests are flaky in DEBUG mode
https://bugs.webkit.org/show_bug.cgi?id=91347
Unreviewed EFL gardening. Add to TestExpectations a
few media tests which are flaky in DEBUG mode only.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
- platform/efl/TestExpectations:
- 7:26 PM Changeset in webkit [122689] by
-
- 3 edits2 adds in trunk
REGRESSION(r122660): Cannot iterate over HTMLCollection that contains non-child descendent nodes in some conditions
https://bugs.webkit.org/show_bug.cgi?id=91334
Reviewed by Ojan Vafai.
Source/WebCore:
The bug was caused by using lastChild() as the starting node for traversePreviousNode. Since it's the inverse of
Node::traverseNextNode(), which visits nodes in pre order, we must start our search from the last descendent node,
which is visited traverseNextNode immediately before reaching the root node.
Test: fast/dom/htmlcollection-backwards-subtree-iteration.html
- html/HTMLCollection.cpp:
(WebCore::lastDescendent):
(WebCore):
(WebCore::itemBeforeOrAfter):
LayoutTests:
Add a regression test. Without this patch, it results in an console error in release builds and an assertion failure
in debug builds.
- fast/dom/htmlcollection-backwards-subtree-iteration-expected.txt: Added.
- fast/dom/htmlcollection-backwards-subtree-iteration.html: Added.
- 7:25 PM Changeset in webkit [122688] by
-
- 7 edits in trunk/Source/WebKit
[EFL] Move files guarded by #ifdef to existing file list.
https://bugs.webkit.org/show_bug.cgi?id=91336
Reviewed by Ryosuke Niwa.
Some EFL files are already guared by #ifdef. So, cmake files doesn't need to guard
them again. In addition, some files are missing #ifdef guard its header files.
Source/WebKit:
- PlatformEfl.cmake:
Source/WebKit/efl:
- WebCoreSupport/DeviceMotionClientEfl.h:
- WebCoreSupport/InspectorClientEfl.h:
- WebCoreSupport/NetworkInfoClientEfl.h:
- WebCoreSupport/VibrationClientEfl.h:
- 6:41 PM Changeset in webkit [122687] by
-
- 381 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in fast/js, layers, leaks, line-grid, lists, loader, loading, media, mediastream, multicol, and mutation tests
https://bugs.webkit.org/show_bug.cgi?id=91315
Reviewed by Adam Barth.
- fast/js/:
- fast/layers/add-layer-with-nested-stacking.html:
- fast/layers/assert-RenderLayer-update-positions.html:
- fast/layers/clip-rects-assertion.html:
- fast/layers/clip-rects-transformed-2.html:
- fast/layers/clip-rects-transformed.html:
- fast/layers/generated-layer-scrollbar-crash.html:
- fast/layers/inline-dirty-z-order-lists.html:
- fast/layers/layer-content-visibility-change.html:
- fast/layers/layer-visibility.html:
- fast/layers/nested-layers-1.html:
- fast/layers/nested-layers-2.html:
- fast/layers/nested-layers-3.html:
- fast/layers/nested-layers-4.html:
- fast/layers/remove-layer-with-nested-stacking.html:
- fast/layers/remove-only-this-layer-update.html:
- fast/layers/removed-by-scroll-handler.html:
- fast/layers/resize-layer-deletion-crash.html:
- fast/layers/scroll-with-transform-composited-layer.html:
- fast/layers/scroll-with-transform-layer.html:
- fast/layers/scrollByLines-overflow-no-layer.html:
- fast/layers/visible-layer-with-hidden-parent.html:
- fast/layers/zindex-hit-test.html:
- fast/leaks/001.html:
- fast/leaks/002.html:
- fast/leaks/003.html-disabled:
- fast/line-grid/line-grid-nested.html:
- fast/lists/alpha-boundary-values.html:
- fast/lists/alpha-list-wrap.html:
- fast/lists/calc-width-with-space.html:
- fast/lists/decimal-leading-zero.html:
- fast/lists/drag-into-marker.html:
- fast/lists/item-not-in-list-line-wrapping.html:
- fast/lists/li-values.html:
- fast/lists/list-style-type-dynamic-change.html:
- fast/lists/ol-nested-items-dynamic-insert.html:
- fast/lists/ol-nested-items-dynamic-remove.html:
- fast/lists/ol-nested-items.html:
- fast/lists/ol-nested-list-dynamic-insert.html:
- fast/lists/ol-nested-list-dynamic-remove.html:
- fast/lists/ol-nested-list.html:
- fast/lists/ol-reversed-dynamic-simple.html:
- fast/lists/ol-reversed-dynamic.html:
- fast/lists/ol-reversed-nested-items.html:
- fast/lists/ol-reversed-nested-list.html:
- fast/lists/ol-reversed-simple.html:
- fast/lists/ol-reversed-simple.xhtml:
- fast/lists/ol-start-roman.html:
- fast/lists/parent-box-not-box-crash.html:
- fast/lists/positioned-count-crash.html:
- fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html:
- fast/lists/resources/dump-list.js:
(dumpListItemAsHTML):
(testListItemMarkerEqualsListItemText):
- fast/lists/w3-css3-list-styles-alphabetic.html:
- fast/lists/w3-css3-list-styles-fallback-style.html:
- fast/lists/w3-css3-list-styles-numeric.html:
- fast/lists/w3-css3-list-styles-symbolic.html:
- fast/lists/w3-css3-lower-armenian.html:
- fast/lists/w3-css3-upper-armenian.html:
- fast/lists/w3-list-styles.html:
- fast/loader/:
- fast/media/color-does-not-include-alpha.html:
- fast/media/invalid-lengths.html:
- fast/media/lifetime.html:
- fast/media/matchmedium-query-api.html:
- fast/media/media-query-list-01.html:
- fast/media/media-query-list-02.html:
- fast/media/media-query-list-03.html:
- fast/media/media-query-list-04.html:
- fast/media/media-query-list-05.html:
- fast/media/media-query-list-06.html:
- fast/media/media-query-list-07.html:
- fast/media/media-query-list-callback.html:
- fast/media/media-svg-crash.html:
- fast/media/mq-pointer.html:
- fast/media/print-restores-previous-mediatype.html:
- fast/media/update-media-query-css-parser.html:
- fast/media/view-mode-media-feature.html:
- fast/multicol/:
- fast/mutation/end-of-task-delivery.html:
- fast/mutation/inline-event-listener.html:
- fast/mutation/mutation-callback-non-element-crash.html:
- platform/chromium/fast/loader/create-view-target-blank.html:
- platform/chromium/fast/loader/resources/done.html:
- platform/gtk/fast/loader/crash-display-local-directory.html:
- platform/mac/fast/loader/file-url-mimetypes-2.html:
- platform/mac/fast/loader/file-url-mimetypes-3.html:
- platform/mac/fast/loader/file-url-mimetypes.html:
- platform/mac/fast/loader/non-html-load-event.html:
- platform/mac/fast/loader/webarchive-encoding-respected.html:
- platform/qt/fast/loader/user-stylesheet-qrc-path.html:
- 6:13 PM Changeset in webkit [122686] by
-
- 2 edits in trunk/Tools
Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.
- Scripts/webkitpy/common/config/watchlist:
- 5:36 PM Changeset in webkit [122685] by
-
- 2 edits in trunk/Tools
Unreviewed. Add gyuyoung.kim@samsung.com to watch list.
- Scripts/webkitpy/common/config/watchlist:
- 4:01 PM Changeset in webkit [122684] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix case sensitive build issue.
Unreviewed build fix.
- WebView/WebPreferences.mm:
- 2:26 PM Changeset in webkit [122683] by
-
- 4 edits2 adds in trunk
Windowless WebView not firing JavaScript load event if there is a media element
https://bugs.webkit.org/show_bug.cgi?id=91331
Reviewed by Eric Carlson.
Source/WebCore:
In prepareForLoad we start deferring the load event. If we fall into this
clause where the page can not start loading media we bail, potentially
indefinitely waiting until we can start loading media. Since we can not
be certain this will ever happen, we should stop deferring the page's
load event.
Test: WebKit1.WindowlessWebViewWithMedia TestWebKitAPI test. The only
way this path was reachable right now is on the mac port.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):
Tools:
Test a windowless WebView loading a page with a media element. The load
event should happen on the next spin of the run loop, but we spin check
the page, with a timeout of 250ms.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
- TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.
(-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
(TestWebKitAPI::TEST):
- 1:24 PM Changeset in webkit [122682] by
-
- 3 edits in trunk/Source/WebKit/mac
Make WebPreferencesPrivate a simple struct
https://bugs.webkit.org/show_bug.cgi?id=91330
Reviewed by Filip Pizlo.
To avoid taking time creating a new Objective-C object for WebPreferencesPrivate, we can just make
it a simple struct.
- WebView/WebPreferences.h:
- WebView/WebPreferences.mm:
(WebPreferencesPrivate):
(WebPreferencesPrivate::WebPreferencesPrivate):
Replace the Objective-C WebPreferencesPrivate by a struct.
Remove IBCreatorID from the object as it is unused.
Use RetainPtr for the Objective-C attribute to avoid tracking their memory manually.
(-[WebPreferences initWithIdentifier:]):
Change the order of the initialization to avoid allocating anyting if a WebPreferences exists
for the identifier.
Both [NSObject init] and WebPreferencesPrivate allocation are moved after the fast path.
(-[WebPreferences initWithCoder:]):
(-[WebPreferences encodeWithCoder:]):
(-[WebPreferences dealloc]):
(-[WebPreferences identifier]):
(-[WebPreferences _valueForKey:]):
(-[WebPreferences _setStringValue:forKey:]):
(-[WebPreferences _setIntegerValue:forKey:]):
(-[WebPreferences _setFloatValue:forKey:]):
(-[WebPreferences _setBoolValue:forKey:]):
(-[WebPreferences _setLongLongValue:forKey:]):
(-[WebPreferences _setUnsignedLongLongValue:forKey:]):
- 1:15 PM Changeset in webkit [122681] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
https://bugs.webkit.org/show_bug.cgi?id=91348
Reviewed by Anders Carlsson.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged): Added an early return if the scroll position
did not, in fact, change. This avoids the call to ScrollAnimator::notifyContentAreaScrolled,
which is what causes the scroll bars to flash.
- 8:40 AM Changeset in webkit [122680] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/text/descent-clip-in-scaled-page.html
https://bugs.webkit.org/show_bug.cgi?id=91342
Unreviewed EFL gardening. Skip new test added in r122651
that fails on EFL port because our LayoutTestController
does not implement setSubpixelTextPositioning().
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
- platform/efl/TestExpectations:
- 5:10 AM Changeset in webkit [122679] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip css2.1/20110323/vertical-align-boxes-001.htm
https://bugs.webkit.org/show_bug.cgi?id=91340
Unreviewed EFL gardening. Skipping new test introduced in
r122663 which is failing on EFL port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
- platform/efl/TestExpectations:
Jul 14, 2012:
- 10:23 PM Changeset in webkit [122678] by
-
- 11 edits in trunk/Source/JavaScriptCore
DFG PutByVal opcodes should accept more than 3 operands
https://bugs.webkit.org/show_bug.cgi?id=91332
Reviewed by Oliver Hunt.
Turned PutByVal/PutByValAlias into var-arg nodes, so that we can give them
4 or more operands in the future.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::varArgNumChildren):
(Graph):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::varArgChild):
(JSC::DFG::Graph::child):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:02 PM Changeset in webkit [122677] by
-
- 15 edits in trunk/Source/JavaScriptCore
Rationalize and optimize storage allocation
https://bugs.webkit.org/show_bug.cgi?id=91303
Reviewed by Oliver Hunt.
This implements a backwards bump allocator for copied space storage
allocation, shown in pseudo-code below:
pointer bump(size) {
pointer tmp = allocator->remaining;
tmp -= size;
if (tmp < 0)
fail;
allocator->remaining = tmp;
return allocator->payloadEnd - tmp - size;
}
The advantage of this allocator is that it:
- Only requires one comparison in the common case where size is known to not be huge, and this comparison can be done by checking the sign bit of the subtraction.
- Can be implemented even when only one register is available. This register is reused for both temporary storage during allocation and for the result.
- Preserves the behavior that memory in a block is filled in from lowest address to highest address, which allows for a cheap reallocation fast path.
- Is resilient against the block used for allocation being the last one in virtual memory, thereby otherwise leading to the risk of overflow in the bump pointer, despite only doing one branch.
In order to implement this allocator using the smallest possible chunk
of code, I refactored the copied space code so that all of the allocation
logic is in CopiedAllocator, and all of the state is in either
CopiedBlock or CopiedAllocator. This should make changing the allocation
fast path easier in the future.
In order to do this, I needed to add some new assembler support,
particularly for various forms of add(address, register) and negPtr().
This is performance neutral. The purpose of this change is to facilitate
further inlining of storage allocation without having to reserve
additional registers or emit too much code.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::addPtr):
(MacroAssembler):
(JSC::MacroAssembler::negPtr):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::add32):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
(MacroAssemblerX86):
- assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::addPtr):
(JSC::MacroAssemblerX86_64::negPtr):
- assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::addl_mr):
(JSC::X86Assembler::addq_mr):
(JSC::X86Assembler::negq_r):
- heap/CopiedAllocator.h:
(CopiedAllocator):
(JSC::CopiedAllocator::isValid):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::tryAllocate):
(JSC):
(JSC::CopiedAllocator::tryReallocate):
(JSC::CopiedAllocator::forceAllocate):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::setCurrentBlock):
(JSC::CopiedAllocator::currentCapacity):
- heap/CopiedBlock.h:
(CopiedBlock):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payloadEnd):
(JSC):
(JSC::CopiedBlock::payloadCapacity):
(JSC::CopiedBlock::data):
(JSC::CopiedBlock::dataEnd):
(JSC::CopiedBlock::dataSize):
(JSC::CopiedBlock::wilderness):
(JSC::CopiedBlock::wildernessEnd):
(JSC::CopiedBlock::wildernessSize):
(JSC::CopiedBlock::size):
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
- heap/CopiedSpace.h:
(CopiedSpace):
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC):
- heap/MarkStack.cpp:
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):
- heap/SlotVisitor.h:
(JSC::SlotVisitor::SlotVisitor):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicStorage):
(JSC::JIT::emitAllocateJSArray):
- 7:19 PM Changeset in webkit [122676] by
-
- 25 edits in trunk/Source
Enable AVCF hardware video decoding
https://bugs.webkit.org/show_bug.cgi?id=90015
<rdar://problem/10770317>
Reviewed by Anders Carlsson.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter): New, return the client's graphics
device adapter.
- html/HTMLMediaElement.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::graphicsDeviceAdapter): New.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::graphicsDeviceAdapter): New, ask the media element for the graphics
device adapter.
- platform/graphics/MediaPlayer.h:
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Soft-link AVCFPlayerSetDirect3DDevice
and AVCFPlayerEnableHardwareAcceleratedVideoDecoderKey.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL): Pass the current d3d9
device interface to the AVFWrapper.
(WebCore::AVFWrapper::createAssetForURL): If the d3d9 device implements IDirect3DDevice9Ex,
tell the AVAsset to enable hardware video decoding.
(WebCore::AVFWrapper::createPlayer): Pass the d3d9 device to the player if it implements IDirect3DDevice9Ex.
- platform/graphics/ca/win/CACFLayerTreeHost.h:
(WebCore::CACFLayerTreeHost::graphicsDeviceAdapter): New, default implementation.
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
(WebCore::LegacyCACFLayerTreeHost::graphicsDeviceAdapter): New, default implementation.
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::graphicsDeviceAdapter): New.
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
- platform/win/SoftLinking.h: Define SOFT_LINK_DLL_IMPORT_OPTIONAL, SOFT_LINK_LOADED_LIBRARY,
and SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL.
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::graphicsDeviceAdapter): New, return the view's graphics adapter.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebView.cpp:
(WebView::graphicsDeviceAdapter): New, return the layer tree host's graphics adapter.
- WebView.h:
(WebCore):
(WebView):
Source/WebKit2:
- DerivedSources.make: Define HAVE_AVCF if necessary.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit):
(WebKit::WebChromeClient::graphicsDeviceAdapter): New, return the layer tree host's
graphics adapter.
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebProcess/WebPage/LayerTreeHost.h:
(WebCore):
(LayerTreeHost):
(WebKit::LayerTreeHost::graphicsDeviceAdapter): New, default implementation.
- WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
(LayerTreeHostCAWin):
- 4:31 PM Changeset in webkit [122675] by
-
- 6 edits1 add in trunk
[Mac] Do not try to update the cache model for every WebPreferences change
https://bugs.webkit.org/show_bug.cgi?id=91302
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-14
Reviewed by Joseph Pecoraro.
Source/WebKit/mac:
WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
we can just listen to updates of the CacheModel property.
- WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _postCacheModelChangedNotification]):
(-[WebPreferences setCacheModel:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(+[WebView initialize]):
(+[WebView _cacheModelChangedNotification:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 2:56 PM Changeset in webkit [122674] by
-
- 2 edits in trunk/Source/WebCore
Fix Chromium Mac build failure after r122670.
- platform/graphics/mac/ComplexTextController.cpp:
- 2:45 PM Changeset in webkit [122673] by
-
- 2 edits in trunk/Source/WebCore
Fix the Snow Leopard build.
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Fix a typo in the condition so that Snow Leopard
continues to take the expected path.
- 2:38 PM Changeset in webkit [122672] by
-
- 4 edits2 adds in trunk
Accessing the last item in children should be a constant time operation
https://bugs.webkit.org/show_bug.cgi?id=91320
Reviewed by Ojan Vafai.
Source/WebCore:
Traverse nodes from the last item when the target offset we're looking for is closer to the last item
than to the cached item. e.g. if the cached item was at offset 0 in the collection and length was 100,
we should not be looking for the item at offset 95 from the cached item.
Note that this trick can be only used in HTML collection that supports itemBefore and when the length
cache is available.
Also broke shouldSearchFromFirstItem into smaller logical pieces to clarify the intents.
Test: perf/htmlcollection-last-item.html
- html/HTMLCollection.cpp:
(WebCore):
(WebCore::HTMLCollection::isLastItemCloserThanLastOrCachedItem):
(WebCore::HTMLCollection::isFirstItemCloserThanCachedItem):
(WebCore::HTMLCollection::item):
- html/HTMLCollection.h:
(HTMLCollection):
LayoutTests:
Added an asymptotic time complexity test.
- perf/htmlcollection-last-item-expected.txt: Added.
- perf/htmlcollection-last-item.html: Added.
- 2:34 PM Changeset in webkit [122671] by
-
- 2 edits in trunk/Source/WebCore
Fix the Windows build.
- platform/network/cf/DNSCFNet.cpp: Fix the condition to take Windows in to account.
- 2:11 PM Changeset in webkit [122670] by
-
- 60 edits in trunk/Source/WebCore
Make it explicit which code paths iOS should use when doing checks based on OS X versions.
Rubber-stamped by David Kilzer.
- WebCore.exp.in:
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityTable.h:
- accessibility/mac/AXObjectCacheMac.mm:
- editing/mac/EditorMac.mm:
- loader/MainResourceLoader.cpp:
- loader/MainResourceLoader.h:
- page/AlternativeTextClient.h:
- page/mac/SettingsMac.mm:
- platform/LocalizedStrings.cpp:
- platform/MemoryPressureHandler.cpp:
- platform/audio/mac/AudioBusMac.mm:
- platform/graphics/Gradient.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
- platform/graphics/ca/mac/TileCache.mm:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/cg/ImageCG.cpp:
- platform/graphics/cg/ImageSourceCG.cpp:
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/mac/ComplexTextController.cpp:
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
- platform/graphics/mac/FontCacheMac.mm:
- platform/graphics/mac/FontCustomPlatformData.cpp:
- platform/graphics/mac/FontMac.mm:
- platform/graphics/mac/GraphicsContextMac.mm:
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- platform/mac/DisplaySleepDisabler.cpp:
- platform/mac/DisplaySleepDisabler.h:
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
- platform/mac/MemoryPressureHandlerMac.mm:
- platform/mac/SharedTimerMac.mm:
- platform/mac/SuddenTermination.mm:
- platform/mac/WebFontCache.mm:
- platform/network/Credential.h:
- platform/network/ResourceHandle.h:
- platform/network/cf/DNSCFNet.cpp:
- platform/network/cf/ProxyServerCFNet.cpp:
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
- platform/network/mac/AuthenticationMac.mm:
- platform/network/mac/CookieStorageMac.mm:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/mac/ResourceRequestMac.mm:
- platform/network/mac/WebCoreURLResponse.mm:
- platform/text/TextChecking.h:
- platform/text/cf/HyphenationCF.cpp:
- platform/text/mac/HyphenationMac.mm:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerCompositor.cpp:
- 12:28 PM Changeset in webkit [122669] by
-
- 4 edits in trunk/Source/WTF
Unreviewed, build fix.
- wtf/Assertions.cpp:
- wtf/Platform.h:
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 7:09 AM Changeset in webkit [122668] by
-
- 5 edits in trunk/LayoutTests
[Tests] Unskip not failing tests previously relying on LTC::nodesFromRect implementation
https://bugs.webkit.org/show_bug.cgi?id=46600
Reviewed by Ryosuke Niwa.
These tests no longer relies on LayoutTestController.nodesFromRect but on Internals, and should work
in all platforms.
- platform/chromium/TestExpectations:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 3:53 AM Changeset in webkit [122667] by
-
- 6 edits1 delete in trunk
Unreviewed, rolling out r122665.
http://trac.webkit.org/changeset/122665
https://bugs.webkit.org/show_bug.cgi?id=91321
Broke Mac builds (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-14
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences setCacheModel:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(+[WebView initialize]):
(+[WebView _preferencesChangedNotification:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
- 2:50 AM Changeset in webkit [122666] by
-
- 3 edits in trunk/LayoutTests
Skip test added in r122663 on Qt and GTK
Unreviewed, gardening.
Qt has 1px difference tracked under
Gtk has a platform-specific rendering issue with the test.
- platform/gtk/TestExpectations:
- platform/qt/Skipped:
- 2:03 AM Changeset in webkit [122665] by
-
- 6 edits1 add in trunk
[Mac] Do not try to update the cache model for every WebPreferences change
https://bugs.webkit.org/show_bug.cgi?id=91302
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-13
Reviewed by Joseph Pecoraro.
Source/WebKit/mac:
WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
we can just listen to updates of the CacheModel property.
- WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _postCacheModelChangedNotification]):
(-[WebPreferences setCacheModel:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(+[WebView initialize]):
(+[WebView _cacheModelChangedNotification:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 1:59 AM Changeset in webkit [122664] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r122614.
http://trac.webkit.org/changeset/122614
https://bugs.webkit.org/show_bug.cgi?id=91317
Broke performance tests (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-14
- bindings/v8/V8Binding.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
- 1:57 AM Changeset in webkit [122663] by
-
- 3 edits2 adds in trunk
CSS 2.1 failure: vertical-align-boxes-001 fails
https://bugs.webkit.org/show_bug.cgi?id=90626
Reviewed by Eric Seidel.
Source/WebCore:
Tests: css2.1/20110323/vertical-align-boxes-001.htm
A percentage value vertical-align is always a percentage of the actual line-height rather than
the margin box per http://www.w3.org/TR/CSS21/visudet.html#propdef-vertical-align: 'Percentages:
refer to the 'line-height' of the element itself'. Confusingly, RenderBox::lineheight() is a
shorthand into the dimensions of the margin box for replaced elements in the other vertical-align
cases, i.e. where it's the margin box that's relevant rather than the 'line-height'. So rather than patch RenderBox's
lineHeight() to somehow consider the percentage cases, just give percentage vertical-align the full computedLineHeight()
rather than lineHeight()'s margin box.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
LayoutTests:
- css2.1/20110323/vertical-align-boxes-001-expected.html: Added.
- css2.1/20110323/vertical-align-boxes-001.htm: Added. This patch fixes the 'percentage' case in this test so that it calculates 50% of the line-height of 60px rather than 50% of the img's margin-box of -8px.
- 1:09 AM Changeset in webkit [122662] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, marking http/tests/misc/webtiming-origins.html as flaky.
- platform/gtk/TestExpectations:
- 12:19 AM Changeset in webkit [122661] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening, adding an image expectation for a test introduced
in r122651. Also creating platform-specific baselines for two File API tests
that behave differently because of function overloading problems but pass otherwise,
and skipping a test for correct viewport of sites with Mobile DTD which GTK port
does not (yet) support.
- platform/gtk/TestExpectations:
- platform/gtk/fast/files/create-blob-url-crash-expected.txt: Added.
- platform/gtk/fast/files/url-required-arguments-expected.txt: Added.
- 12:08 AM Changeset in webkit [122660] by
-
- 11 edits2 adds in trunk
Iterating backwards over HTMLCollection is O(n2)
https://bugs.webkit.org/show_bug.cgi?id=91306
Reviewed by Anders Carlsson.
Source/WebCore:
Fixed the bug by introducing itemBefore that iterates nodes backwards to complement itemAfter.
Unfortunately, some HTML collections such as HTMLFormCollection and HTMLTableRowsCollection have
its own itemAfter function and writing an equivalent itemBefore is somewhat tricky. For now,
added a new boolean flag indicating whether a given HTML collection supports itemBefore or not,
and left those HTML collections that override itemAfter alone.
This also paves our way to share more code between DynamicNodeList and HTMLCollection.
Test: perf/htmlcollection-backwards-iteration.html
- dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Takes ItemBeforeSupportType.
(WebCore::DynamicNodeListCacheBase::supportsItemBefore): Added.
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::setItemCache): Replaced a FIXME by an assertion now that
we can.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::HTMLAllCollection): Supports itemBefore since it doesn't override
itemAfter.
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::isAcceptableElement): Made it a static local function instead of a static member.
(WebCore::nextNode): Templatized.
(WebCore::itemBeforeOrAfter): Extracted from itemAfter and templatized.
(WebCore::HTMLCollection::itemBefore): Added.
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::shouldSearchFromFirstItem): Added. Determines whether we should reset
the item cache to the first item. We obviously do if the cache is invalid. If the target offset
is after the cached offset, then we shouldn't go back regardless of availability of itemBefore.
Otherwise, we go back to the first item iff itemBefore is not available or the distance from
the cached offset to the target offset is greater than the target offset itself.
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item): Use the term "offset" to match the terminology elsewhere.
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem): Ditto. Also added the logic to iterate
nodes backwards using itemBefore. Once we're in this branch, we should always find a matching
item since the target offset was less than the cached offset, and offsets are non-negative.
If we had ever reached the end of the loop without finding an item, it indicates that the cache
has been invalid and we have some serious bug elsewhere.
- html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Supports itemBefore since it doesn't
override itemAfter.
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection): Doesn't support itemBefore as it overrides
itemAfter.
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
LayoutTests:
Add an asymptotic time complexity test.
- perf/htmlcollection-backwards-iteration-expected.txt: Added.
- perf/htmlcollection-backwards-iteration.html: Added.
Jul 13, 2012:
- 8:45 PM Changeset in webkit [122659] by
-
- 5 edits in trunk/Tools
run-webkit-test outputs the wrong number of tests executed when some are skipped.
https://bugs.webkit.org/show_bug.cgi?id=89894
Reviewed by Ojan Vafai.
Fix the logging of the actual number of tests run so that tests
that are skipped aren't included.
Also revamp the 'expected' output so we distinguish the number
of tests found from the number of tests run (to account for
--repeat-each and --iterations).
Covered by existing tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
(Manager._log_num_workers):
(Manager.run):
(Manager._print_result_summary):
- Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.init):
(ResultSummary.add):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_one_line_summary):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_one_line_summary):
- 8:05 PM Changeset in webkit [122658] by
-
- 10 edits in trunk/Source
[chromium] Add 'self-managed' option to CCPrioritizedTexture to enable render-surface and canvas use cases.
https://bugs.webkit.org/show_bug.cgi?id=91177
Patch by Eric Penner <epenner@google.com> on 2012-07-13
Reviewed by Adrienne Walker.
Source/WebCore:
This makes the render-surface memory use case generic as 'self-managed' textures,
as this use case is popping up in other places (eg. canvases). It's exactly the
same idea except we can have as many place-holders as we want at arbitrary
priorities.
This already tested by the render surface unit tests which now also use the
generic placeholder.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::setPrioritiesForSurfaces):
(WebCore):
(WebCore::CCLayerTreeHost::setPrioritiesForLayers):
(WebCore::CCLayerTreeHost::prioritizeTextures):
(WebCore::CCLayerTreeHost::calculateMemoryForRenderSurfaces):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:
(WebCore::CCPrioritizedTexture::CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setToSelfManagedMemoryPlaceholder):
- platform/graphics/chromium/cc/CCPrioritizedTexture.h:
(CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setIsSelfManaged):
(WebCore::CCPrioritizedTexture::isSelfManaged):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::destroyBacking):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
(CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::memoryForSelfManagedTextures):
Source/WebKit/chromium:
- tests/CCPrioritizedTextureTest.cpp:
(WTF::TEST_F):
- tests/TiledLayerChromiumTest.cpp:
- 7:09 PM Changeset in webkit [122657] by
-
- 2 edits in trunk/Tools
nrwt: actually print the exception name and message for otherwise unhandled exceptions
https://bugs.webkit.org/show_bug.cgi?id=91305
Reviewed by Adam Barth.
Two more places where I was printing the stack trace but not the
exception itself :(. These two spots can't easily be
unit-tested, but I tested them by hand.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
- 7:07 PM Changeset in webkit [122656] by
-
- 5 edits in trunk
Internals: Clean up the mock PagePopupDriver correctly.
https://bugs.webkit.org/show_bug.cgi?id=91250
Source/WebCore:
Unreviewed, a trivial testing code fix.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::reset):
Resetting PaePopupDriver here instead of Backup::restoreTo.
Also, close the mock popup before resetting PagePopupDriver by clearing m_pagePopupDriver.
- testing/MockPagePopupDriver.cpp:
(WebCore::MockPagePopupDriver::~MockPagePopupDriver):
Close the popup.
LayoutTests:
- platform/chromium/TestExpectations: Remove CRASH expectation for date-apparance.html.
- 7:03 PM Changeset in webkit [122655] by
-
- 12 edits in trunk/Source
Remove Widget from screenColorProfile
https://bugs.webkit.org/show_bug.cgi?id=91300
Patch by Tony Payne <tpayne@chromium.org> on 2012-07-13
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/Platform.h:
(Platform): Updated comment to reflect that we no longer have a type param.
Source/WebCore:
Chromium, the only platform implementing screenColorProfile, does not
need the Widget, so removing for simplicity.
Covered by existing tests.
- platform/PlatformScreen.h:
(WebCore): Updated comment to remove reference to type param that no
longer exists and removed Widget param.
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenColorProfile): Removed widget param.
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenColorProfile): Removed widget param.
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenColorProfile): Removed widget param.
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenColorProfile): Removed widget param.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile): removed param to
match screenColorProfile()'s new spec.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenColorProfile): Removed widget param.
- platform/qt/PlatformScreenQt.cpp:
(WebCore::screenColorProfile): Removed widget param.
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenColorProfile): Removed widget param.
- 6:49 PM Changeset in webkit [122654] by
-
- 5 edits1 add in trunk/Source
Source/WebCore: [chromium] Add flushes to CCTextureUpdater::update
https://bugs.webkit.org/show_bug.cgi?id=89035
Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-13
Reviewed by Adrienne Walker.
Automatic flushes are being removed from the command buffer, so
this moves the flushes into the CCTextureUpdater itself.
CCTextureUpdaterTest added to verify texture upload/flushing patterns.
- platform/graphics/chromium/cc/CCGraphicsContext.h:
(WebCore::CCGraphicsContext::flush):
(CCGraphicsContext):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore):
(WebCore::CCTextureUpdater::update): Manual flushes added here.
Source/WebKit/chromium: Add flushes to CCTextureUpdater::update
https://bugs.webkit.org/show_bug.cgi?id=89035
Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-13
Reviewed by Adrienne Walker.
CCTextureUpdaterTest added to verify texture upload/flushing patterns.
- WebKit.gypi:
- tests/CCTextureUpdaterTest.cpp: Added.
- 6:08 PM Changeset in webkit [122653] by
-
- 4 edits2 adds in trunk
REGRESSION: RenderInline boundingBox ignores relative position offset
https://bugs.webkit.org/show_bug.cgi?id=91168
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-13
Reviewed by Simon Fraser.
Source/WebCore:
RenderGeometryMap, used for caching the transform to the view,
expects the first mapping pushed, to be that of the view itself.
RenderInline was instead pushing it's own offset first. Besides
the offset of the view itself was not being pushed.
Relaxed the RenderGeometryMap restriction that the first pushed
step should be of the view. It is sufficient that the view's mapping
is pushed in the first call to pushMappingsToAncestor. Modified
RenderInline to push the offset of the view also to the geometry map.
Test: fast/inline/inline-relative-offset-boundingbox.html
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushMappingsToAncestor): Add assertion to
check if mapping to view was pushed in first invocation.
(WebCore::RenderGeometryMap::pushView): Correct assertion that checks
if the view's mapping is the first one to be applied.
(WebCore::RenderGeometryMap::stepInserted): Use isRenderView to check if
a mapping step belongs to a view instead of using mapping size.
(WebCore::RenderGeometryMap::stepRemoved): Ditto.
- rendering/RenderInline.cpp:
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::AbsoluteQuadsGeneratorContext):
Push mappings all the way up to and including the view.
LayoutTests:
Add a regression test for boundingBox of an inline element with relative position offsets.
- fast/inline/inline-relative-offset-boundingbox-expected.txt: Added.
- fast/inline/inline-relative-offset-boundingbox.html: Added.
- 6:03 PM Changeset in webkit [122652] by
-
- 43 edits1 move1 add1 delete in trunk/Source
Move WebCore/platform/text/Base64 to WTF/wtf/text
https://bugs.webkit.org/show_bug.cgi?id=91162
Reviewed by Adam Barth.
Source/WebCore:
No new tests. Files moving only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::generateSecWebSocketKey):
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::convertToDataURL):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::createDigest):
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::sharedBufferContent):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
- loader/archive/mhtml/MHTMLParser.cpp:
(WebCore::MHTMLParser::parseNextPart):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::CGImageToDataURL):
- platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
- platform/graphics/wince/ImageBufferWinCE.cpp:
- platform/graphics/wx/ImageBufferWx.cpp:
- platform/network/DataURL.cpp:
(WebCore::handleDataURL):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader):
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
Source/WebKit/blackberry:
- Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::base64DecodePolicyForWTF):
(BlackBerry::WebKit::base64Decode):
(BlackBerry::WebKit::base64EncodePolicyForWTF):
(BlackBerry::WebKit::base64Encode):
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::setUserStyleSheetString):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
Source/WTF:
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/text/Base64.cpp: Renamed from Source/WebCore/platform/text/Base64.cpp.
(WTF):
(WTF::base64Encode):
(WTF::base64Decode):
(WTF::base64DecodeInternal):
- wtf/text/Base64.h: Renamed from Source/WebCore/platform/text/Base64.h.
(WTF):
(WTF::base64Encode):
- 5:52 PM Changeset in webkit [122651] by
-
- 5 edits2 adds in trunk
[Chromium] Sometimes bottom of text is truncated when page has a fractional scale
https://bugs.webkit.org/show_bug.cgi?id=88684
Reviewed by Tony Chang.
Source/WebCore:
When the page has a fractional scale, the ascent and descent part of the fonts might be fractional.
If the descent part is rounded down, the bottom of the text might be truncated when displayed
when subpixel text positioning is enabled.
To avoid that, borrow one unit from the ascent when possible.
Test: fast/text/descent-clip-in-scaled-page.html
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint): Moved NoPreference handling into querySystemForRenderStyle so that fontRenderStyle() can have actual styles without NoPreference.
(WebCore::FontPlatformData::querySystemForRenderStyle): Added NoPreference handling (moved from setupPaint)
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
(WebCore::FontPlatformData::fontRenderStyle): Added to let SimpleFontDataSkia access the font render styles.
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
New test case.
- fast/text/descent-clip-in-scaled-page-expected.html: Added.
- fast/text/descent-clip-in-scaled-page.html: Added.
- 5:44 PM Changeset in webkit [122650] by
-
- 19 edits1 add in trunk/Source/JavaScriptCore
OfflineASM Pretty printing and commenting enhancements.
https://bugs.webkit.org/show_bug.cgi?id=91281
Patch by Mark Lam <mark.lam@apple.com> on 2012-07-13
Reviewed by Filip Pizlo.
Added some minor pretty printing in the OfflineASM.
Also added infrastruture for adding multiple types of comments and
annotations with the ability to enable/disable them in the generated
output as desired.
- GNUmakefile.list.am: add new file config.rb.
- llint/LLIntOfflineAsmConfig.h: Added OFFLINE_ASM_BEGIN, OFFLINE_ASM_END, and OFFLINE_ASM_LOCAL_LABEL macros. This will allow us to redefine these for other backends later.
- llint/LowLevelInterpreter32_64.asm: Add a small example of instruction annotations for now.
- llint/LowLevelInterpreter64.asm: Add a small example of instruction annotations for now.
- offlineasm/armv7.rb: Added handling of annotations.
- offlineasm/asm.rb: Added machinery to dump the new comments and annotations. Also added some indentations to make the output a little prettier.
- offlineasm/ast.rb: Added annotation field in class Instruction.
- offlineasm/backends.rb:
- offlineasm/config.rb: Added. Currently only contains commenting options. This file is meant to be a centralized place for build config values much like config.h for JavaScriptCore.
- offlineasm/generate_offset_extractor.rb:
- offlineasm/instructions.rb:
- offlineasm/offsets.rb:
- offlineasm/opt.rb:
- offlineasm/parser.rb: Parse and record annotations.
- offlineasm/registers.rb:
- offlineasm/self_hash.rb:
- offlineasm/settings.rb:
- offlineasm/transform.rb:
- offlineasm/x86.rb: Added handling of annotations.
- 5:44 PM Changeset in webkit [122649] by
-
- 2 edits in trunk/Source/WebCore
Remove an assertion after r122637.
- dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange):
- 5:33 PM Changeset in webkit [122648] by
-
- 4 edits1 add in trunk
Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
https://bugs.webkit.org/show_bug.cgi?id=91116
.:
Patch by Josh Hawn <jhawn@apple.com> on 2012-07-12
Reviewed by Simon Fraser.
- Source/WebKit2/UIProcess/WebContext.cpp: WebContext::getWebCoreStatistics():
Now invalidates callback if no m_process.
Tools:
Patch by Josh Hawn <jhawn@apple.com> on 2012-07-13
Reviewed by Simon Fraser.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Added new test file.
- TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Added.
(TestWebKitAPI::wkContextGetStatisticsCallback):
Tests that callback function receives an error.
(TestWebKitAPI::TEST):
Creates a dummy web context object (no web process).
Calls WKContextGetStatistics with the web context and test callback.
The test callback should get an expected error.
- 5:15 PM Changeset in webkit [122647] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Improve the mobile theme slightly
https://bugs.webkit.org/show_bug.cgi?id=90806
Reviewed by Kenneth Rohde Christiansen.
Improve drawing of the mobile theme's controls' background.
Ensure the focus ring never appears with the mobile theme, since it
looks bad in combination with the highlights.
No new tests. The painting code from the mobile theme is still
not covered specifically (it will when we revive pixel tests).
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore):
(WebCore::addPointToOctants): Added. This is simply a helper to avoid
doing too much duplicate work in drawControlBackground.
(WebCore::drawControlBackground): Rely on the octant logic added above
and take the opportunity to increase the granularity.
(WebCore::borderPen):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
- platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::supportsFocusRing):
- 4:55 PM Changeset in webkit [122646] by
-
- 4 edits3 adds in trunk
ASSERTION FAILED: use.useKind() != DoubleUse
https://bugs.webkit.org/show_bug.cgi?id=91082
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The implementation of Branch() was unwisely relying on register allocation state
to decide what speculations to perform. That's never correct.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
- fast/js/dfg-mispredict-variable-but-prove-int-expected.txt: Added.
- fast/js/dfg-mispredict-variable-but-prove-int.html: Added.
- fast/js/script-tests/dfg-mispredict-variable-but-prove-int.js: Added.
(foo):
- 4:39 PM Changeset in webkit [122645] by
-
- 5 edits in trunk/Tools
test-webkitpy: move printing-related code out of the runner
https://bugs.webkit.org/show_bug.cgi?id=91289
Reviewed by Ryosuke Niwa.
More refactoring ... this moves all printing-related stuff out
of runner.py and into printer.py.
No functional changes; covered by existing tests.
- Scripts/webkitpy/test/main.py:
(Tester._run_tests):
- Scripts/webkitpy/test/printer.py:
(Printer.init):
(Printer):
(Printer.test_name):
(Printer.print_started_test):
(Printer.print_finished_test):
(Printer.print_result):
- Scripts/webkitpy/test/runner.py:
(Runner.init):
(Runner.all_test_names):
(Runner.run):
- Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
- 4:36 PM Changeset in webkit [122644] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r122640.
http://trac.webkit.org/changeset/122640
https://bugs.webkit.org/show_bug.cgi?id=91298
LLInt apparently does not expect to mark these (Requested by
olliej on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-13
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):
(JSC::CodeBlock::stronglyVisitStrongReferences):
- 4:36 PM Changeset in webkit [122643] by
-
- 4 edits1 copy in trunk/Tools
webkitpy: split printing/logging code for test-webkitpy out into a new class
https://bugs.webkit.org/show_bug.cgi?id=91282
Reviewed by Ojan Vafai.
This patch is the first step at splitting all of the
printing/logging code out separately from the actual
test-running code.
This is just moving stuff around; no new functionality and no
new tests needed.
- Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.setUp):
- Scripts/webkitpy/test/main.py:
(Tester.init):
(Tester._parse_args):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):
- Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_no_tests_found):
- Scripts/webkitpy/test/printer.py: Added.
(Printer):
(Printer.init):
(Printer.configure):
(Printer.configure.filter):
(_CaptureAndPassThroughStream):
(_CaptureAndPassThroughStream.init):
(_CaptureAndPassThroughStream.write):
(_CaptureAndPassThroughStream._message_is_from_pdb):
(_CaptureAndPassThroughStream.flush):
(_CaptureAndPassThroughStream.getvalue):
- 4:34 PM Changeset in webkit [122642] by
-
- 2 edits in trunk/Source/WebCore
Remove an always-failing table-wrapping check in RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=91286
Reviewed by Eric Seidel.
Due to the structure of the code, this test is always failing (newChild->isTableCell()
is true to get in the branch).
The changeset adding the code didn't add testing so I poundered adding the mentioned test,
which is passing. However the test would need to be blindly changed to be included in our
test harness. I would also expect this code to be exercised by other table tests anyway.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Removed never-reached branch. While at it, removed a 'what' comment in the same file.
- 4:23 PM Changeset in webkit [122641] by
-
- 9 edits in trunk/Source/WebCore
Use LayoutBoxExtent for image outsets
https://bugs.webkit.org/show_bug.cgi?id=91166
Reviewed by Tony Chang.
Change RenderStyle and calling code to use LayoutBoxExtent for image
outsets and remove text direction and writing mode versions of the
outline getters from RenderStyle as LayoutBoxExtent provides the same
functionality.
No new tests, no change in functionality.
- platform/graphics/FractionalLayoutBoxExtent.h:
- platform/graphics/FractionalLayoutBoxExtent.cpp:
(WebCore::FractionalLayoutBoxExtent::logicalTop):
(WebCore::FractionalLayoutBoxExtent::logicalBottom):
Add logicalTop and logicalBottom methods to go with the existing
logicalLeft and logicalRight ones.
- platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::expand):
Add FractionalLayoutBoxExtent version of expand method.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets and the logicalTop/Bottom/Left/Right methods.
(WebCore::clipRectForNinePieceImageStrip):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::maskClipRect):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets and the new FractionalLayoutRect::expand method.
(WebCore::RenderBox::addVisualEffectOverflow):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Change implementation to use the new FractionalLayoutBoxExtent version of
borderImageOutsets and the new FractionalLayoutRect::expand method.
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::imageOutsets):
Change getImageOutsets to return a FractionalLayoutBoxExtent object and
rename to imageOutsets to match the webkit naming convention for getters.
Remove getBorderImageHorizontalOutsets, getBorderImageVerticalOutsets,
getBorderImageInlineDirectionOutsets, getImageHorizontalOutsets,
getImageVerticalOutsets and getBorderImageBlockDirectionOutsets methods
as the same functionality is provided by FractionalLayoutBoxExtent.
- 4:12 PM Changeset in webkit [122640] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt fails to mark structures stored in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=91296
Reviewed by Geoffrey Garen.
LLInt stores structures in the bytecode, so we need to visit the appropriate
instructions as we would if we were running in the classic interpreter.
This requires adding additional checks for the LLInt specific opcodes, and
the lint specific variants of operand ordering.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):
(JSC::CodeBlock::stronglyVisitStrongReferences):
- 3:57 PM Changeset in webkit [122639] by
-
- 5 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=91278
Improve block margin estimation function to account for not having a layout and for quirks mode
Reviewed by Simon Fraser.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::marginBeforeEstimateForChild):
Revise marginBeforeEstimateForChild so that it computes block margins for the grandchild before
recurring. This includes the quirks margin information as well. This ensures that the margins are
up-to-date when checked, even before the object has had its first layout.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeBlockDirectionMargins):
- rendering/RenderBox.h:
(RenderBox):
Add consts in order to compile.
- 3:46 PM Changeset in webkit [122638] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix crash due to unguarded use of renderer in select
popup.
https://bugs.webkit.org/show_bug.cgi?id=91287
Reviewed by Rob Buis.
No known testcase for this. Found in the wild.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValueAndClosePopup):
- 3:44 PM Changeset in webkit [122637] by
-
- 11 edits in trunk/Source/WebCore
NodeLists should not invalidate on irreleavnt attribute changes
https://bugs.webkit.org/show_bug.cgi?id=91277
Reviewed by Ojan Vafai.
Explicitely check the invalidation type and the changed attribute in NodeListNodeData::invalidateCaches
and ElementRareData::clearHTMLCollectionCaches to only invalidate node lists affected by the change.
Also merged invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged
as invalidateNodeListCachesInAncestors since they're almost identical after r122498.
In addition, moved shouldInvalidateNodeListForType from Document.cpp to DynamicNodeList.h and renamed it to
shouldInvalidateTypeOnAttributeChange since it needs to called in Node.cpp and ElementRareData.h.
- dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
- dom/Document.cpp:
(WebCore::Document::registerNodeListCache): Calls isRootedAtDocument() instead of directly comparing
the value of NodeListRootType in order to prepare for the bug 80269.
(WebCore::Document::unregisterNodeListCache): Ditto.
(WebCore): shouldInvalidateNodeListForType is moved to DynamicNodeList.h
(WebCore::Document::shouldInvalidateNodeListCaches):
- dom/DynamicNodeList.h:
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Moved from Document.cpp.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/ElementRareData.h:
(WebCore::ElementRareData::clearHTMLCollectionCaches): Takes const QualifiedName* to compare against
the invalidation type of HTML collections via shouldInvalidateTypeOnAttributeChange.
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListCachesInAncestors): Merged invalidateNodeListCachesInAncestors and
invalidateNodeListsCacheAfterChildrenChanged. Also pass attrName to clearHTMLCollectionCaches.
(WebCore::NodeListsNodeData::invalidateCaches): Compares attrName against the invalidation type of
node lists via shouldInvalidateTypeOnAttributeChange.
(WebCore):
- dom/Node.h:
(Node):
- dom/NodeRareData.h:
(WebCore::NodeRareData::ensureNodeLists): Merged NodeRareData::createNodeLists.
(WebCore::NodeRareData::clearChildNodeListCache): Moved from Node.cpp.
(NodeRareData):
- html/HTMLCollection.h:
(HTMLCollectionCacheBase):
- 3:37 PM Changeset in webkit [122636] by
-
- 2 edits in trunk/Source/WebCore
Refactor RenderTable to use the section's iteration functions.
https://bugs.webkit.org/show_bug.cgi?id=89751
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-07-13
Reviewed by Julien Chaffraix.
Removing anti-pattern wherever possible from RenderTable code. Also, modifying
RenderTable sections' iterations to use helper functions.
No new tests required for this change since no change in behavior is expected.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::setCellLogicalWidths):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
Removed anti-patterns involving iterations over RenderObjects.
(WebCore::RenderTable::outerBorderAfter):
Modified RenderTable sections' iteration to use helper functions.
- 3:35 PM Changeset in webkit [122635] by
-
- 2 edits in trunk/Source/WebCore
Threadsafety issues in WebScriptObject
https://bugs.webkit.org/show_bug.cgi?id=90849
Reviewed by Geoff Garen.
Updated fix for this bug. The JSC API lock needs to be acquired also in JSObject.
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject JSObject]):
- 3:25 PM Changeset in webkit [122634] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip fast/css/font-face-download-error.html
https://bugs.webkit.org/show_bug.cgi?id=91279
Unreviewed EFL gardening. Unskip passing test
fast/css/font-face-download-error.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-13
- platform/efl/TestExpectations:
- 3:19 PM Changeset in webkit [122633] by
-
- 2 edits in trunk/LayoutTests
Remove supressions for flashplayer crash
https://bugs.webkit.org/show_bug.cgi?id=91283
Reviewed by Tony Chang.
These tests don't crash any more now that I've corrected the
configuration on the bots.
- platform/chromium/TestExpectations:
- 2:29 PM Changeset in webkit [122632] by
-
- 29 edits38 deletes in trunk
[Navigation Timing] Imported W3C tests contain duplicates and are DOS formatted
https://bugs.webkit.org/show_bug.cgi?id=91184
Reviewed by Adam Barth.
The upstream 'html5' tests are just duplicates of the 'html' tests.
Tools:
- Scripts/import-w3c-performance-wg-tests:
LayoutTests:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_document_readiness_exist.html: Converted to *NIX newline format.
- http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_attributes_exist.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_redirectCount_none.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_enums.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_no_previous_document.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_readwrite.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_exist.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_client_redirect.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_server_redirect.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html:
- http/tests/w3c/webperf/approved/navigation-timing/html/test_unique_performance_objects.html:
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_open-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_open.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_readiness_exist-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_document_readiness_exist.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigate_within_document-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigate_within_document.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_attributes_exist-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_attributes_exist.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_redirectCount_none-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_redirectCount_none.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_backforward-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_backforward.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_enums-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_enums.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_reload-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_navigation_type_reload.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_no_previous_document-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_no_previous_document.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_readwrite-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_readwrite.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_exist-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_exist.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_order-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_attributes_order.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_client_redirect-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_client_redirect.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_reload-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_reload.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_server_redirect-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_server_redirect.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect.html: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_unique_performance_objects-expected.txt: Removed.
- http/tests/w3c/webperf/approved/navigation-timing/html5/test_unique_performance_objects.html: Removed.
- http/tests/w3c/webperf/resources/blank_page_green.htm:
- http/tests/w3c/webperf/resources/blank_page_green_with_onunload.htm:
- http/tests/w3c/webperf/resources/blank_page_meta_redirect.htm:
- http/tests/w3c/webperf/resources/blank_page_unload.htm:
- http/tests/w3c/webperf/resources/blank_page_yellow.htm:
- http/tests/w3c/webperf/resources/blank_page_yellow_with_onunload.htm:
- http/tests/w3c/webperf/resources/pagevistestharness.js:
(pv_test):
(test_feature_exists):
(test_equals):
(add_async_result_assert):
(TabSwitch):
- http/tests/w3c/webperf/resources/webperftestharness.js:
(test_true):
- platform/chromium/TestExpectations:
- 2:16 PM Changeset in webkit [122631] by
-
- 3 edits in trunk/Tools
webkitpy: hide yield_to_caller from callers in MessagePool :)
https://bugs.webkit.org/show_bug.cgi?id=91269
Reviewed by Adam Barth.
yield_to_caller() was an optimization/hack to allow us to run
both manager and worker in a single process/loop without
starving the manager while the worker is running tests. The
worker was required to call yield_to_caller() periodically. It
turns out that I can get equivalent responsiveness by yielding
inside the MessagePool every time the worker posts a message, and this
allows me to no longer need the worker to call the routine. Thus
I rename yield_to_caller() to _yield_to_manager() to be a little
clearer about its purpose.
Tested by existing tests.
- Scripts/webkitpy/common/message_pool.py:
(_Worker.run):
(_Worker.post):
(_Worker._yield_to_manager):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle):
- 2:10 PM Changeset in webkit [122630] by
-
- 4 edits4 adds in trunk
DelayNode doesn't work if delayTime.value == delayTime.maxValue
https://bugs.webkit.org/show_bug.cgi?id=90357
Patch by Raymond Toy <Raymond Toy> on 2012-07-13
Reviewed by Kenneth Russell.
Source/WebCore:
Increase delay buffer size slightly so that the read and write
pointers don't become equal when the delay and the max delay are
the same.
Tests: webaudio/delaynode-max-default-delay.html
webaudio/delaynode-max-nondefault-delay.html
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore): Moved SmoothingTimeConstant to WebCore namespace.
(WebCore::DelayDSPKernel::DelayDSPKernel): Add some additional checks to prevent crashes; use bufferLengthForDelay to compute buffer length.
(WebCore::DelayDSPKernel::bufferLengthForDelay): New function to compute buffer length.
- Modules/webaudio/DelayDSPKernel.h:
(DelayDSPKernel): Declare bufferLengthForDelay.
LayoutTests:
New tests to test the case when the delay node delay equals the
maximum allowed delay. Add one test for the default maximum delay
and a second test with a user-set maximum delay.
- webaudio/delaynode-max-default-delay-expected.txt: Added.
- webaudio/delaynode-max-default-delay.html: Added.
- webaudio/delaynode-max-nondefault-delay-expected.txt: Added.
- webaudio/delaynode-max-nondefault-delay.html: Added.
- 2:03 PM Changeset in webkit [122629] by
-
- 2 edits in trunk/Source/WebCore
Always aggressively preload on iOS
https://bugs.webkit.org/show_bug.cgi?id=91276
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-13
Reviewed by Simon Fraser.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
- 1:45 PM Changeset in webkit [122628] by
-
- 4 edits4 deletes in trunk
Restructure V8Utilities::extractTransferables() with help of toV8Sequence()
https://bugs.webkit.org/show_bug.cgi?id=91208
Patch by Vineet Chaudhary <Vineet> on 2012-07-13
Reviewed by Kentaro Hara.
Source/WebCore:
We can remove the specialised check for MessagePort from V8Utilities::extractTransferables()
using toV8Sequence() as it validates the passed object for sequence type per WebIDL spec.
No new test as just refactoring.
Existing tests under fast/dom/Window/window-* fast/dom/events/*
covers tests.
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
LayoutTests:
We can remove the specialised check for MessagePort from V8Utilities::extractTransferables()
using toV8Sequence() as it validates the passed object for sequence type per WebIDL spec.
Removing port specific expected results.
- platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Removed.
- platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Removed.
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
- platform/chromium/fast/events/constructors/message-event-constructor-expected.txt: Removed.
- platform/chromium/fast/events/message-port-multi-expected.txt: Rebaselined.
- 1:40 PM Changeset in webkit [122627] by
-
- 1 edit1 add in trunk/Tools
EWSTools should be able to build a commit-queue instance from scratch
https://bugs.webkit.org/show_bug.cgi?id=91264
Reviewed by Eric Seidel.
I've been using this script to build commit-queue instances on Google
Compute Engine and it seems to work.
- EWSTools/GoogleComputeEngine/build-commit-queue.sh: Added.
- 1:37 PM Changeset in webkit [122626] by
-
- 6 edits4 adds in trunk
Pointer Lock handles disconnected DOM elements
https://bugs.webkit.org/show_bug.cgi?id=77029
Reviewed by Adrienne Walker.
Source/WebCore:
Pointer Lock Controller now checks when elements or documents are
removed, and unlocks if the target element is being removed.
Tests: pointer-lock/locked-element-iframe-removed-from-dom.html
pointer-lock/locked-element-removed-from-dom.html
- dom/Document.cpp:
(WebCore::Document::detach):
- dom/Element.cpp:
(WebCore::Element::removedFrom):
(WebCore::Element::webkitRequestPointerLock):
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::elementRemoved):
(WebCore):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::enqueueEvent):
- page/PointerLockController.h:
(WebCore):
(PointerLockController):
LayoutTests:
Two new tests that verify pointer lock is released when the target
is removed from the document.
- pointer-lock/locked-element-iframe-removed-from-dom-expected.txt: Added.
- pointer-lock/locked-element-iframe-removed-from-dom.html: Added.
- pointer-lock/locked-element-removed-from-dom-expected.txt: Added.
- pointer-lock/locked-element-removed-from-dom.html: Added.
- 1:35 PM Changeset in webkit [122625] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. storage/indexeddb/cursor-key-order.html has starting crashing on occassion.
https://bugs.webkit.org/show_bug.cgi?id=91275
Not sure how far back the crashes go, but happens with reasonably high frequency.
- platform/chromium/TestExpectations:
- 1:12 PM Changeset in webkit [122624] by
-
- 4 edits in trunk/Source/JavaScriptCore
[BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175
Patch by Yong Li <yoli@rim.com> on 2012-07-13
Reviewed by Rob Buis.
Implement GCActivityCallback and HeapTimer for BlackBerry port.
- heap/HeapTimer.cpp:
(JSC):
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::timerDidFire):
(JSC::HeapTimer::synchronize):
(JSC::HeapTimer::invalidate):
(JSC::HeapTimer::didStartVMShutdown):
- heap/HeapTimer.h:
(HeapTimer):
- runtime/GCActivityCallbackBlackBerry.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):
- 12:58 PM Changeset in webkit [122623] by
-
- 46 edits1 move in trunk/LayoutTests
Move layout checking js script into LayoutTest/resources and generalize
https://bugs.webkit.org/show_bug.cgi?id=91268
Reviewed by Ojan Vafai.
flexbox.js contains helper scripts for verifying the size and position of nodes.
I will be writing similar tests for grid, so move the js file into a location
for sharing and generalize the script.
- css3/flexbox/align-absolute-child.html: Change include path and call.
- css3/flexbox/auto-height-dynamic.html:
- css3/flexbox/columns-auto-size.html:
- css3/flexbox/flex-algorithm-min-max.html:
- css3/flexbox/flex-algorithm-with-margins.html:
- css3/flexbox/flex-algorithm.html:
- css3/flexbox/flex-align-column.html:
- css3/flexbox/flex-align-end.html:
- css3/flexbox/flex-align-max.html:
- css3/flexbox/flex-align-percent-height.html:
- css3/flexbox/flex-align-stretch.html:
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- css3/flexbox/flex-flow-auto-margins.html:
- css3/flexbox/flex-flow-border.html:
- css3/flexbox/flex-flow-margins-auto-size.html:
- css3/flexbox/flex-flow-margins.html:
- css3/flexbox/flex-flow-orientations.html:
- css3/flexbox/flex-flow-overflow.html:
- css3/flexbox/flex-flow-padding.html:
- css3/flexbox/flex-flow.html:
- css3/flexbox/flex-item-child-overflow.html:
- css3/flexbox/flex-item-min-size.html:
- css3/flexbox/flex-justify-content.html:
- css3/flexbox/flex-no-flex.html:
- css3/flexbox/flexitem.html:
- css3/flexbox/floated-flexbox.html:
- css3/flexbox/line-wrapping.html:
- css3/flexbox/multiline-align-content-horizontal-column.html:
- css3/flexbox/multiline-align-content.html:
- css3/flexbox/multiline-align-self.html:
- css3/flexbox/multiline-column-auto.html:
- css3/flexbox/multiline-justify-content.html:
- css3/flexbox/multiline-reverse-wrap-overflow.html:
- css3/flexbox/multiline.html:
- css3/flexbox/nested-stretch.html:
- css3/flexbox/orthogonal-flex-directions.html:
- css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
- css3/flexbox/position-absolute-child.html:
- css3/flexbox/preferred-widths-orthogonal.html:
- css3/flexbox/preferred-widths.html:
- css3/flexbox/style-change.html:
- css3/flexbox/true-centering.html:
- css3/flexbox/writing-modes.html:
- resources/check-layout.js: Renamed from LayoutTests/css3/flexbox/resources/flexbox.js.
(.): Rename checkFlexboxen to checkLayout that takes a CSS selector. Hide functions in a closure.
- 12:54 PM Changeset in webkit [122622] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Re-enable indexeddb in test_shell
https://bugs.webkit.org/show_bug.cgi?id=91161
Reviewed by Tony Chang.
IDB used to be allowed to run if webView->permissionClient() was NULL,
as is the case in test_shell. This was inadvertently changed in
http://wkb.ug/90310.
We still don't have an automated test for this (http://crbug.com/113738)
Tested manually:
- In test_shell:
1) Open an IDB page
2) Verify IDB has permission to open a DB
- In chrome:
1) Open an IDB page
2) Verify IDB has permission to open a DB
3) Revoke IDB permissions in chrome://chrome/settings/content
4) Reload the IDB page
5) Verify IDB doesn't have permission to open a DB
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
- 12:48 PM Changeset in webkit [122621] by
-
- 16 edits in trunk/Source/WebCore
HTMLCollection should use DynamicNodeList's invalidation model
https://bugs.webkit.org/show_bug.cgi?id=90326
Reviewed by Anders Carlsson.
Make HTMLCollection invalidated upon attribute and children changes instead of invalidating it on demand
by comparing DOM tree versions. Node that HTMLCollections owned by Document are invalidated with other
document-rooted node lists in m_listsInvalidatedAtDocument for simplicity although this mechanism is
normally used for node lists owned by a non-Document node that contains nodes outside of its subtree.
ItemProperties and FormControls are more "traditional" users of the mechanism.
Also, merged DynamicNodeList::invalidateCache and HTMLCollection::invalidateCache.
- dom/Document.cpp:
(WebCore::Document::registerNodeListCache): Renamed. No longer takes NodeListInvalidationType or
NodeListRootType since they can be obtained from the cache base. Increment the node list counter for
InvalidateOnIdNameAttrChange when a HTMLCollection is passed in since all HTMLCollections need to be
invalidated on id or name content attribute changes due to named getters.
(WebCore::Document::unregisterNodeListCache): Ditto.
(WebCore::shouldInvalidateNodeListForType):
(WebCore::Document::shouldInvalidateNodeListCaches):
(WebCore::Document::clearNodeListCaches):
- dom/Document.h:
(WebCore): Added InvalidateOnIdNameAttrChange, InvalidateOnHRefAttrChange, and InvalidateOnAnyAttrChange.
(Document):
- dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeListCacheBase::invalidateCache): Added. Invalidates caches of both DynamicNodeList
and HTMLCollection. We can't afford to use virtual function calls here because this function is called on
all node lists and HTML collections owned by ancestors of an element under which a node is added, removed,
or its attributes are changed.
(WebCore):
- dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Initializes member variables directly
instead of calling clearCache now that DynamicNodeListCacheBase::invalidateCache has become polymorphic.
(DynamicNodeListCacheBase): Increased the number of bits for m_invalidationType since we now have 9
invalidation types.
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::clearHTMLCollectionCaches): Added.
(WebCore::ElementRareData::adoptTreeScope): Added; similar to NodeRareData::adoptTreeScope.
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Clears HTML collection caches as well as
node list caches.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Ditto.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::adoptTreeScope):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope): Calls ElementRareData's adoptTreeScope as well as
NodeRareData's.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::namedItemWithIndex):
- html/HTMLCollection.cpp:
(WebCore::rootTypeFromCollectionType): Added. As mentioned above, treat all Document-owned HTML collection
as if rooted at document for convenience.
(WebCore::invalidationTypeExcludingIdAndNameAttributes): Added. Since all HTML collection requires
invalidation on id and name content attribute changes, which is taken care by the special logic in
Document::registerNodeListCache, exclude those two attributes from consideration.
(WebCore::HTMLCollection::HTMLCollection): Calls Document::registerNodeListCache.
(WebCore::HTMLCollection::~HTMLCollection): Calls Document::unregisterNodeListCache.
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
- html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollectionCacheBase): Removed m_cacheTreeVersion and clearCache since they're no longer used.
(HTMLCollection):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::namedItem):
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLOptionsCollection.h:
(HTMLOptionsCollection):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::updateNameCache):
- html/HTMLPropertiesCollection.h:
(WebCore::HTMLPropertiesCollection::invalidateCache):
- 12:45 PM Changeset in webkit [122620] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed GTK gardening, adding a baseline required after unskipping
fast/files/workers/worker-read-blob-async.html in r122612.
- platform/gtk/fast/files: Added.
- platform/gtk/fast/files/workers: Added.
- platform/gtk/fast/files/workers/worker-read-blob-async-expected.txt: Added.
- 12:40 PM Changeset in webkit [122619] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove incorrect debug assertion in LayerRendererChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=91260
Reviewed by Adrienne Walker.
ASSERT(!clipped) was being triggered after skinny almost-degenerate
quads went through anti-aliasing inflation, and then were being
transformed back from device space to local space. It turns out
this assertion is too aggressive, and we don't yet have an obvious
need to change the behavior on the clipped==true case.
No new tests needed, this patch fixes only comments and debug code.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPassQuad):
fixed a comment.
(WebCore::LayerRendererChromium::drawTileQuad):
fixed a similar comment, removed unnecessary assertion.
- 12:11 PM Changeset in webkit [122618] by
-
- 2 edits in trunk/Tools
webkitpy: make worker.start() and worker.stop() optional in the messagepool
https://bugs.webkit.org/show_bug.cgi?id=91170
Reviewed by Ojan Vafai.
test-webkitpy will use messagepool workers that don't actually
have any per-worker state, so they don't need start() and stop()
methods. Now we will only call the methods if they exist; this
means that workers only need to expose a handle() method.
- Scripts/webkitpy/common/message_pool.py:
(_Worker.terminate):
(_Worker.run):
- 12:10 PM Changeset in webkit [122617] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines for the fast/backgrounds/size/zero.html
test as required after r121296.
- platform/gtk/TestExpectations:
- platform/gtk/fast/backgrounds/size/zero-expected.png: Added.
- platform/gtk/fast/backgrounds/size/zero-expected.txt:
- 12:08 PM Changeset in webkit [122616] by
-
- 3 edits2 adds in trunk
Remove assert in localCoordinateSpaceTransform()
https://bugs.webkit.org/show_bug.cgi?id=91189
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The assert in localCoordinateSpaceTransform was added to catch subclasses forgetting
to override the method but it is better to simply return the identity matrix.
This scenario can occur when we break the SVG content model, such as asking for
the CTM of a <g> element inside a <tspan>. This is undefined in the spec because
tspan is not a subclass of SVGLocatable but both Firefox and Opera
implement this by returning the identity matrix.
Test: svg/custom/invalid-ctm.svg
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
LayoutTests:
- svg/custom/invalid-ctm-expected.txt: Added.
- svg/custom/invalid-ctm.svg: Added.
- 12:08 PM Changeset in webkit [122615] by
-
- 4 edits in trunk/Tools
NRWT doesn't print exceptions
https://bugs.webkit.org/show_bug.cgi?id=91129
Reviewed by Ojan Vafai.
Although we printed exceptions in most cases, if an unexpected
exception (like a runtime error) was raised when creating a
port, we wouldn't. This patch fixes that, and also cleans up
how we were logging exceptions from the workers to be less
verbose.
Because of the corner cases where these errors are occurring,
it's difficult to write automated unit tests for them. I've
tested it quite a bit by hand, though.
- Scripts/webkitpy/common/message_pool.py:
(_MessagePool._close):
(_MessagePool._handle_worker_exception):
(_Worker.run):
(_Worker._raise):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):
- 12:05 PM Changeset in webkit [122614] by
-
- 2 edits in trunk/Source/WebCore
[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251
Reviewed by Adam Barth.
Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.
I tried to find some cases where this change reduces memory usage,
but couldn't due to sensitive behavior of GC.
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
- 12:00 PM Changeset in webkit [122613] by
-
- 2 edits in trunk/LayoutTests
IndexedDB: Add unexpectedUpgradeNeededCallback to shared.js
https://bugs.webkit.org/show_bug.cgi?id=91176
Reviewed by Tony Chang.
This is just used in our layout tests. It's the simplest possible piece
I could break off of the upgradeneeded changes.
No tests because no change in behavior expected.
- storage/indexeddb/resources/shared.js:
(unexpectedBlockedCallback):
(unexpectedUpgradeNeededCallback):
- 11:50 AM Changeset in webkit [122612] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, removing timeout expectations for a few
File API tests while hoping the problems have now gone away.
- platform/gtk/TestExpectations:
- 11:46 AM Changeset in webkit [122611] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Gardening failure cases on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=91219
Unreviewed EFL gardening. Skip the new failing tests and add
platform-specific results for fallback-content.html to get the
bot greener.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-13
- platform/efl/TestExpectations:
- platform/efl/fast/canvas/fallback-content-expected.txt: Added.
- 11:45 AM Changeset in webkit [122610] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Make the v8 i18n API dependency conditional for Android, disable strict aliasing
https://bugs.webkit.org/show_bug.cgi?id=91240
Reviewed by Adam Barth.
Disable the v8 internationalization API for Chromium Android, as it's
disabled and not always available in checkouts. Furthermore, disable
strict aliasing for the webkit_remaining target, similar to what
x11-based builds are doing (see the webcore_prerequisites target).
- WebCore.gyp/WebCore.gyp:
- 11:43 AM Changeset in webkit [122609] by
-
- 2 edits8 adds in trunk/LayoutTests
Unreviewed GTK gardening, adding baselines and expectations required
after r122509 and r122528.
- platform/gtk/TestExpectations:
- platform/gtk/http/tests/w3c: Added.
- platform/gtk/http/tests/w3c/webperf: Added.
- platform/gtk/http/tests/w3c/webperf/approved: Added.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing: Added.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html: Added.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Added.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html5: Added.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect-expected.txt: Added.
- 11:25 AM WebKit Team edited by
- (diff)
- 11:15 AM Changeset in webkit [122608] by
-
- 7 edits in trunk/Source/WebCore
[CallWith=XXX] arguments should be placed at the head of method arguments
https://bugs.webkit.org/show_bug.cgi?id=91217
Reviewed by Adam Barth.
The EFL build with the ENABLE_FILE_SYSTEM flag caused a build error,
because CodeGeneratorJS.pm assumes webkitEntries(ScriptExecutionContext*, HTMLInputElement*)
but the actual signature is webkitEntries(HTMLInputElement*, ScriptExecutionContext*) (bug 91185).
Per https://trac.webkit.org/wiki/WebKitIDL#CallWith, [CallWith=XXX] arguments should be placed
at the head of the arguments. (i.e. the behavior of CodeGeneratorJS.pm is correct.)
Thus the correct fix is (1) to change the signature of webkitEntries() and webkitGetAsEntry()
so that ScriptExecutionContext* comes first and (2) to modify CodeGeneratorV8.pm to support the order.
Test: bindings/scripts/test/TestObj.idl
- Modules/filesystem/DataTransferItemFileSystem.h: Placed ScriptExecutionContext* at the head of arguments.
(DataTransferItemFileSystem):
- Modules/filesystem/HTMLInputElementFileSystem.cpp: Ditto.
(WebCore::HTMLInputElementFileSystem::webkitEntries):
- Modules/filesystem/HTMLInputElementFileSystem.h: Ditto.
(HTMLInputElementFileSystem):
- Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Ditto.
(WebCore::DataTransferItemFileSystem::webkitGetAsEntry):
- bindings/scripts/CodeGeneratorV8.pm: Modified to support the correct order.
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallString):
- bindings/scripts/test/V8/V8TestInterface.cpp: Updated run-bindings-tests results.
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
- 11:11 AM Changeset in webkit [122607] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
PrettyPatch.rb complains about missing checksum for new pixel results
https://bugs.webkit.org/show_bug.cgi?id=88368
Reviewed by Tony Chang.
When adding or removing a file, we incorrectly iterpreted not having an image
as not having a checksum.
- PrettyPatch/PrettyPatch.rb:
- PrettyPatch/PrettyPatch_test.rb:
I tried to fix the TempFile issue in these tests, but after a couple hours
of banging my head against this, I have no idea what's breaking.
- 10:57 AM Changeset in webkit [122606] by
-
- 4 edits in trunk
enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
https://bugs.webkit.org/show_bug.cgi?id=91194
Patch by Wei James <james.wei@intel.com> on 2012-07-13
Reviewed by Adam Barth.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 10:55 AM Changeset in webkit [122605] by
-
- 2 edits in trunk/Tools
[GTK] Gardening: update API tests skipped list
https://bugs.webkit.org/show_bug.cgi?id=91224
Unreviewed gardening.
Skip "next" and "previous" tests of FindController until bug #91083
is fixed.
Patch by Simon Pena <Simon Pena> on 2012-07-13
- gtk/run-api-tests:
(TestRunner):
- 10:39 AM Changeset in webkit [122604] by
-
- 6 edits in trunk/Source/WebCore
[BlackBerry] Some small changes in network code
https://bugs.webkit.org/show_bug.cgi?id=90974
Reviewed by Rob Buis.
- Set status in NetworkJob/SocketStreamHandleBlackBerry so that
its wrapped stream can also query the stream result.
- pass download attribute to NetworkRequest.
RIM PR# 171555
Reviewed internally by Lyon Chen and Joe Mason.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyClose):
- platform/network/blackberry/NetworkJob.h:
(WebCore::NetworkJob::status):
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::platformTargetTypeForRequest):
- platform/network/blackberry/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::status):
(SocketStreamHandle):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::notifyStatusReceived):
(WebCore::SocketStreamHandle::notifyClose):
- 10:32 AM Changeset in webkit [122603] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Remove uiSourceCode from Resource.
https://bugs.webkit.org/show_bug.cgi?id=91201
Reviewed by Pavel Feldman.
Removed Resource._uiSourceCode field as it is not used anymore.
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isHidden):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
- 10:28 AM Changeset in webkit [122602] by
-
- 2 edits in trunk/Source/WebKit/chromium
webkit_unit_test CCLayerTreeHostImplTest.testRemoveRenderPasses started failing.
https://bugs.webkit.org/show_bug.cgi?id=91245
Reviewed by Adrienne Walker.
- tests/CCLayerTreeHostImplTest.cpp:
- 10:25 AM Changeset in webkit [122601] by
-
- 9 edits in trunk
[CMake] Proper handling of ENABLE_API_TESTS build option
https://bugs.webkit.org/show_bug.cgi?id=91221
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-13
Reviewed by Rob Buis.
.:
Make the flag reusable across the ports using CMake. We are about to enable the WTF,
WebCore and WebKit 2 API's at Tools/TestWebKitAPI and other ports using CMake can get
it almost for free.
- CMakeLists.txt:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit:
Build unit tests only if ENABLE_API_TESTS is set.
- PlatformEfl.cmake:
Source/WebKit2:
Build unit tests only if ENABLE_API_TESTS is set.
- PlatformEfl.cmake:
- 10:24 AM Changeset in webkit [122600] by
-
- 25 edits in trunk/Source/WebCore
Unreviewed, rolling out r122450 and r122580.
http://trac.webkit.org/changeset/122450
http://trac.webkit.org/changeset/122580
https://bugs.webkit.org/show_bug.cgi?id=91263
Caused multiple regressions on ClusterFuzz (Requested by
inferno-sec on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-13
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):
- css/StylePropertySet.cpp:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::createAttributeData):
(WebCore):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
(WebCore::Element::attributeData):
(Element):
(WebCore::Element::reportMemoryUsage):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::setClass):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItemIndex):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportInstrumentedPointer):
(WebCore::MemoryObjectInfo::reportPointer):
(WebCore::MemoryObjectInfo::reportInstrumentedObject):
(WebCore::MemoryObjectInfo::reportObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryObjectInfo::reportHashMap):
(WebCore::MemoryObjectInfo::reportHashSet):
(WebCore::MemoryObjectInfo::reportListHashSet):
(WebCore::MemoryObjectInfo::reportVector):
(WebCore::MemoryObjectInfo::reportString):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::objectSize):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- dom/StyledElement.cpp:
(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
- dom/StyledElement.h:
(WebCore::StyledElement::ensureInlineStyle):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
- 10:23 AM Changeset in webkit [122599] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add support for attributes to define keyboard and enter key type on the Virtual Keyboard
https://bugs.webkit.org/show_bug.cgi?id=91248
Reviewed by Antonio Gomes.
PR 174733.
Add data-blackberry-virtual-keyboard-type and
data-blackberry-virtual-keyboard-enter-key to
enable configuration of the desired virtual keyboard
using element attributes.
Reviewed Internally by Gen Mak.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertStringToKeyboardType):
(WebKit):
(BlackBerry::WebKit::keyboardTypeAttribute):
(BlackBerry::WebKit::convertStringToKeyboardEnterKeyType):
(BlackBerry::WebKit::keyboardEnterKeyTypeAttribute):
(BlackBerry::WebKit::InputHandler::setElementFocused):
- 10:19 AM Changeset in webkit [122598] by
-
- 6 edits in trunk/Source/WebCore
Remove down-casting to BitmapImage in GraphicsContext::drawImage.
https://bugs.webkit.org/show_bug.cgi?id=90755
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-13
Reviewed by Simon Fraser.
Add a BitmapImage draw method which takes RespectImageOrientationEnum enum as
the last argument for CG. Then we can remove the conditional down-casting in
GraphicsContext::drawImage.
This change is needed for parallel image decoders. Because parallel image
decoders use a Bitmap image wrapper class which extends Image (not Bitmap), the
down-casting above causes the loss of RespectImageOrientationEnum which must be
passed to BitmapImage.
No new tests, no behavior change.
- platform/graphics/BitmapImage.cpp:
- platform/graphics/BitmapImage.h:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
- platform/graphics/Image.cpp:
(WebCore::Image::draw):
(WebCore):
- platform/graphics/Image.h:
(Image):
- 10:09 AM Changeset in webkit [122597] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Make new public Ewk headers as installable
https://bugs.webkit.org/show_bug.cgi?id=91232
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-13
Reviewed by Antonio Gomes.
Make new public Ewk headers installable.
- PlatformEfl.cmake:
- 10:06 AM Changeset in webkit [122596] by
-
- 2 edits2 copies in branches/chromium/1132
Merging r118589 into 1132
- 9:53 AM Changeset in webkit [122595] by
-
- 2 edits in trunk/Source/JavaScriptCore
[WIN] Fix compilation of DFGRepatch.cpp
https://bugs.webkit.org/show_bug.cgi?id=91241
Reviewed by Geoffrey Garen.
Use intptr_t instead of uintptr_t when calling CodeLocationCommon::dataLabelPtrAtOffset(int)
to fix MSVC "unary minus operator applied to unsigned type, result still unsigned" warning.
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- 9:35 AM Changeset in webkit [122594] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix ARM_TRADITIONAL JIT for COMPILER(MSVC) and COMPILER(RVCT) after r121885
https://bugs.webkit.org/show_bug.cgi?id=91238
Reviewed by Zoltan Herczeg.
r121885 changed the assembler instruction only for COMPILER(GCC).
Use the same instructions for the other compilers too.
- jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiTrampolineEnd):
(JSC::ctiVMThrowTrampoline):
- 9:22 AM Changeset in webkit [122593] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, updated chromium test expectations.
https://bugs.webkit.org/show_bug.cgi?id=91252
- platform/chromium/TestExpectations:
- 9:18 AM Changeset in webkit [122592] by
-
- 2 edits in trunk/LayoutTests
Also mark its evil twin as flaky.
- platform/chromium/TestExpectations:
- 9:16 AM Changeset in webkit [122591] by
-
- 2 edits in trunk/LayoutTests
Note this test as flaky.
- platform/chromium/TestExpectations:
- 9:13 AM Changeset in webkit [122590] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, updated test expectations.
http://bugs.webkit.org/show_bug.cgi?id=91255
- platform/chromium/TestExpectations:
- 9:11 AM Changeset in webkit [122589] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=91247
Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>
PR: 175432
On yahoo.com, the web page stopped zooming while trying to pinch as
WebPageClient::resetBitmapZoomScale(double) was being called by
WebPagePrivate::zoomToInitialScaleOnLoad() after load finished.
And also yahoo.com was keeping updating layout, which made it really
bad that zoomToInitialScaleOnLoad() was called many times when load
finished and the load type was FrameLoadTypeStandard or FrameLoadTypeSame.
As we only care about the situation that dispatchDidFirstVisuallyNonEmptyLayout()
happens after load finished, we can move the code to that method and
set a flag for WebPage layoutFinished() and zoomToInitialScaleOnLoad()
instead. In this way, we can ensure that the flag is only enabled when
dispatchDidFirstVisuallyNonEmptyLayout() is called after load finished
and get rid of calling zoomToInitialScaleOnLoad() lots of times when
keeping updating layout in such kind of situation.
Internally reviewed by Arvid Nilsson
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::setShouldZoomToInitialScaleAfterLoadFinished):
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
- 9:00 AM Changeset in webkit [122588] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening, updated test expectations.
https://bugs.webkit.org/show_bug.cgi?id=91254
- platform/chromium/TestExpectations:
- 8:53 AM Changeset in webkit [122587] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use fillBuffer() instead of a user-defined background image.
https://bugs.webkit.org/show_bug.cgi?id=91180
RIM PR 171458
Reviewed by Rob Buis.
Internally reviewed by Andrew Lo.
By using Platform::Graphics::fillBuffer() to fill the
overscroll area, we save graphics memory for the buffer
that the background image was occupying.
Also adapt checkerboard drawing as it is now done using
fillBuffer() which replaces checkerBuffer().
In the same go, use the opportunity of the WebSettings
API change to make it more consistent, renaming the
OverZoomColor setting to OverScrollColor.
- Api/BackingStore.cpp:
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::overScrollColor):
(BlackBerry::WebKit::WebSettings::setOverScrollColor):
(BlackBerry::WebKit::WebSettings::isEnableDefaultOverScrollBackground):
(BlackBerry::WebKit::WebSettings::setEnableDefaultOverScrollBackground):
- Api/WebSettings.h:
- 8:51 AM Changeset in webkit [122586] by
-
- 7 edits in trunk/Source/WebCore
Fix QtWebKit build with OpenGLES after GC3D/E3D refactor
https://bugs.webkit.org/show_bug.cgi?id=91156
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-07-13
Reviewed by Noam Rosenthal.
Adds several build fixes.
- platform/graphics/GraphicsContext3D.h:
Use E3DOpenGLES instead of previously removed E3DQt.
- platform/graphics/OpenGLESShims.h:
Enable defines for Qt.
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::blitFramebuffer):
(WebCore):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisample):
(WebCore::Extensions3DOpenGLES::copyTextureCHROMIUM):
Added pure virtual stubs.
(WebCore::Extensions3DOpenGLES::supportsExtension):
Remove PROC suffix. See bug #91130.
- platform/graphics/opengl/Extensions3DOpenGLES.h:
(Extensions3DOpenGLES):
Added pure virtual stubs.
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
Readded missing function after removed in r122250.
(WebCore):
Use PLATFORM(BLACKBERRY) guard around port-specific include.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
Added USE(OPENGL_ES_2) guard instead of always loading the OpenGL extensions.
- 8:47 AM Changeset in webkit [122585] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, marked chromium test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=91252
- platform/chromium/TestExpectations:
- 8:36 AM Changeset in webkit [122584] by
-
- 17 edits6 adds in trunk
Form of FormAssociatedElement is not updated when id target changes.
https://bugs.webkit.org/show_bug.cgi?id=91042
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/update-form-attribute-element.html
This patch introduces the IdTargetObserver and IdTargetObserverRegistry class.
They can be used to be notified when the element that an id is pointing to (the id target)
changes.
- CMakeLists.txt: Added IdTargetObserverRegistry.{h,cpp} and IdTargetObserver.{h,cpp}
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/DOMAllInOne.cpp:
- dom/IdTargetObserver.cpp: Added. When you want notified of changes to an id target, you should create a new class that inherits this.
(WebCore):
(WebCore::IdTargetObserver::IdTargetObserver):
(WebCore::IdTargetObserver::~IdTargetObserver):
- dom/IdTargetObserver.h: Added.
(WebCore):
(IdTargetObserver):
- dom/IdTargetObserverRegistry.cpp: Added.
(WebCore):
(WebCore::IdTargetObserverRegistry::create):
(WebCore::IdTargetObserverRegistry::addObserver): Register an IdTargetObserver to observe an id target.
(WebCore::IdTargetObserverRegistry::removeObserver): Unregisters an IdTargetObserver from observing.
(WebCore::IdTargetObserverRegistry::notifyObserversInternal):
- dom/IdTargetObserverRegistry.h: Added.
(WebCore):
(IdTargetObserverRegistry):
(WebCore::IdTargetObserverRegistry::IdTargetObserverRegistry):
(WebCore::IdTargetObserverRegistry::notifyObservers): Calls idTargetChanged on all observers for an id. Inlining first part of function for performance.
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::addElementById): Calls IdTargetObserverRegistry::notifyObservers because the id target might have changed.
(WebCore::TreeScope::removeElementById): Ditto.
- dom/TreeScope.h:
(WebCore):
(WebCore::TreeScope::idTargetObserverRegistry):
(TreeScope):
- html/FormAssociatedElement.cpp: Observer for id targets defined by the form attribute.
(WebCore::FormAssociatedElement::didMoveToNewDocument):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver): Creates and sets up a new FormAttributeTargetObserver.
(WebCore):
(WebCore::FormAssociatedElement::formAttributeTargetChanged):
(WebCore::FormAttributeTargetObserver::create):
(WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver):
(WebCore::FormAttributeTargetObserver::idTargetChanged):
- html/FormAssociatedElement.h:
(FormAssociatedElement):
- html/FormController.cpp:
- html/FormController.h:
(FormController):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::removedFrom):
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Modified to take a range. It
scans the range and returns the index to insert the element in m_associatedElement.
(WebCore::HTMLFormElement::formElementIndex): Modified to only scan the elements in
m_associatedElement that precede and follow the form element.
- html/HTMLFormElement.h:
(HTMLFormElement):
LayoutTests:
- fast/forms/update-form-attribute-element-expected.txt: Added.
- fast/forms/update-form-attribute-element.html: Added.
- 8:32 AM Changeset in webkit [122583] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardneing, skip failing chromium test.
- platform/chromium/TestExpectations:
- 8:31 AM Changeset in webkit [122582] by
-
- 9 edits1 add in trunk/Source/WebCore
Optimizing blend filter to ARM-NEON with intrinsics
https://bugs.webkit.org/show_bug.cgi?id=90949
Reviewed by Zoltan Herczeg.
The feBlend SVG filter modes can be greatly fasten up with ARM-NEON since
we are able to calculate with 2 pixels (8 channels) at the same time.
The code is written with NEON intrinsics and it doesn't affect the
general - it has the same behaviour as the original algorithm.
With this NEON optimization the calculation is ~4.5 times faster for each mode.
Existing tests cover this issue.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::platformApplyGeneric):
(WebCore):
(WebCore::FEBlend::platformApplySoftware):
- platform/graphics/filters/FEBlend.h:
(FEBlend):
- platform/graphics/filters/arm/FEBlendNEON.h: Added.
(WebCore):
(FEBlendUtilitiesNEON):
(WebCore::FEBlendUtilitiesNEON::div255): integer divison with 255
(WebCore::FEBlendUtilitiesNEON::normal): calculate normal mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::multiply): calculate multiply mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::screen): calculate screen mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::darken): calculate darken mode blending for two pixels
(WebCore::FEBlendUtilitiesNEON::lighten): calculate lighten mode blending for two pixels
(WebCore::FEBlend::platformApplyNEON):
- 8:15 AM Changeset in webkit [122581] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening chromium tests rebaseline.
- platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt:
- 8:09 AM Changeset in webkit [122580] by
-
- 17 edits in trunk/Source/WebCore
Web Inspector: native memory instrumentation: extract instrumentation methods into MemoryClassInfo
https://bugs.webkit.org/show_bug.cgi?id=91227
Reviewed by Pavel Feldman.
void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
MemoryClassInfo<Node> info(memoryObjectInfo, this, MemoryInstrumentation::DOM);
info.visitBaseClass<ScriptWrappable>(this);
info.addMember(m_notInstrumentedPointer); automatically detects poniter/reference
info.addInstrumentedMember(m_next);
info.addHashSet<MemoryInstrumentation::NonClass>(m_aHash); NonClass value_type (report only size of internal template structures)
info.addHashSet<MemoryInstrumentation::NotInstrumentedClass>(m_aHashSet); not instrumented value_type (use sizeof)
info.addHashSet<MemoryInstrumentation::InstrumentedClass>(m_aHashSet); instrumented value_type (call visit)
}
The change is covered by existing tests for native memory snapshot.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- css/StylePropertySet.h:
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/Element.h:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::objectSize):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(WebCore::MemoryClassInfo::visitBaseClass):
(WebCore::MemoryClassInfo::reportInstrumentedPointer):
(WebCore::MemoryClassInfo::reportInstrumentedObject):
(WebCore::MemoryClassInfo::reportPointer):
(WebCore::MemoryClassInfo::reportObject):
(WebCore::MemoryClassInfo::reportHashMap):
(WebCore::MemoryClassInfo::reportHashSet):
(WebCore::MemoryClassInfo::reportListHashSet):
(WebCore::MemoryClassInfo::reportVector):
(WebCore::MemoryClassInfo::reportString):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
- platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
- 8:05 AM Changeset in webkit [122579] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r122528. Skipped some new tests.
https://bugs.webkit.org/show_bug.cgi?id=91218
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-07-13
- platform/qt/Skipped:
- 8:02 AM Changeset in webkit [122578] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: align scope filters
https://bugs.webkit.org/show_bug.cgi?id=91213
Reviewed by Vsevolod Vlasov.
- inspector/front-end/elementsPanel.css:
(.crumbs):
- inspector/front-end/inspector.css:
(.status-bar > div):
(.scope-bar):
(.scope-bar li):
(.scope-bar li.all):
- inspector/front-end/networkLogView.css:
- 7:58 AM Changeset in webkit [122577] by
-
- 2 edits1 add in trunk/LayoutTests
[GTK] Gardening: new baseline after r122550 and rebaseline after r122556
https://bugs.webkit.org/show_bug.cgi?id=91235
Unreviewed gardening.
Add new baseline for fast/canvas/fallback-content.html added in r122550, and
rebaseline fast/regions/region-style-block-background-color2.html after r122556.
Patch by Simon Pena <Simon Pena> on 2012-07-13
- platform/gtk/fast/canvas/fallback-content-expected.txt: Added.
- platform/gtk/fast/regions/region-style-block-background-color2-expected.txt:
- 7:48 AM Changeset in webkit [122576] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed gardening: skip failing webkit unit test.
- tests/CCLayerTreeHostImplTest.cpp:
- 7:41 AM Changeset in webkit [122575] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed gardening, skip failing webkit_unit_tests.
- tests/DecimalTest.cpp:
(TEST_F):
- 7:30 AM Changeset in webkit [122574] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: too many hardcoded strings in InspectorBackendDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=89198
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-07-13
Reviewed by Yury Semikhatsky.
Instead of generating error message string on every call (mostly for nothing),
error message is generated deeper inside the handler and only command name
is passed every time.
- inspector/CodeGeneratorInspector.py:
(Generator.process_command):
- 7:00 AM Changeset in webkit [122573] by
-
- 7 edits1 add in trunk/Source
[BlackBerry] Update about:* pages
https://bugs.webkit.org/show_bug.cgi?id=91121
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-13
Reviewed by Yong Li.
Update the about:config pages, and improve the aesthetics of the about:build, about:version, about:credits, about:memory, about:config, and similar pages.
No new tests, because there is no new funtionality.
Source/WebCore:
- platform/network/blackberry/NetworkJob.cpp: Update the aesthetics of about:* pages
Source/WebKit/blackberry:
- WebCoreSupport/AboutData.cpp:
(WebCore):
(WebCore::writeFeatures):
(WebCore::numberToHTMLTr): Converted to template function, added bool specialization to write "true" and "false" instead of "1" and "0"
(WebCore::configPage):
(WebCore::memoryPage):
- WebCoreSupport/AboutTemplate.html.cpp: Template for BlackBerry about:* pages.
- 6:53 AM Changeset in webkit [122572] by
-
- 2 edits in trunk/Source/WebCore
Fix checking for optional DeviceOrientationEvent.absolute in JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=91225
Patch by Olivier Blin <Olivier Blin> on 2012-07-13
Reviewed by Steve Block.
This issue comes from r105036
- bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
- 6:47 AM Changeset in webkit [122571] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Implement disk cache in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90797
Reviewed by Xan Lopez.
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::getCacheDiskFreeSize): Use an ASSERT instead of an early
return since the cache feature is now always added to the session.
(WebKit::WebProcess::platformSetCacheModel): Get the cache from
the session and set the maximum cache size as computed by
calculateCacheSizes().
(WebKit::WebProcess::platformClearResourceCaches): Call
soup_cache_clear().
(WebKit::WebProcess::platformTerminate): Make sure all pending
data is saved to the disk before the web process finishes.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): Create a SoupCache feature and add it
to the default SoupSession.
- 6:41 AM Changeset in webkit [122570] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix disk cache size computation in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91226
Reviewed by Xan Lopez.
We are passing the free disk space value in bytes to
calculateCacheSizes() which expects values in MB.
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 6:20 AM EFLWebKit edited by
- (diff)
- 6:19 AM EFLWebKitTests edited by
- (diff)
- 5:56 AM Changeset in webkit [122569] by
-
- 3 edits in trunk/Source/WebCore
[CSS Regions] Fix build for bug 89000
https://bugs.webkit.org/show_bug.cgi?id=91215
Patch by Andrei Bucur <abucur@adobe.com> on 2012-07-13
Reviewed by Kentaro Hara.
Remove the unused variable m_state that was a leftover from a previous version of the patch.
Tests: No new tests, build fix.
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
- dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
- 5:53 AM Changeset in webkit [122568] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase test after r122550.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-13
- platform/qt/fast/canvas/fallback-content-expected.txt: Added.
- 5:52 AM EFLWebKitTests edited by
- (diff)
- 5:51 AM EFLWebKitTests edited by
- (diff)
- 5:51 AM EFLWebKitTests edited by
- (diff)
- 5:49 AM EFLWebKitTests created by
- 5:08 AM Changeset in webkit [122567] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] WebKit2 crash when going back/forward
https://bugs.webkit.org/show_bug.cgi?id=91220
Reviewed by Xan Lopez.
For some reason when a page is loaded from the backforward list,
when the didCommitLoadForFrame callback is called for the main
frame, the callback didInitiateLoadForResource hasn't been called
yet, so we don't even have a main resource at that point. We were
assuming we always had a main resource with a response. For now we
just check whether we have a resource before trying to set the
certificate to fix the crash, but we need to figue out why this is
happening an how to properly fix it.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(didCommitLoadForFrame): Check whether we have a main resource
before setting the certificate.
- 5:03 AM Changeset in webkit [122566] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Use eina stringsharing for Ewk_Web_Resource's url
https://bugs.webkit.org/show_bug.cgi?id=91200
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-13
Reviewed by Kenneth Rohde Christiansen.
Use eina stringsharing for Ewk_Web_Resource's url
for consistency.
- UIProcess/API/efl/ewk_web_resource.cpp:
(_Ewk_Web_Resource):
(_Ewk_Web_Resource::_Ewk_Web_Resource):
(ewk_web_resource_unref):
(ewk_web_resource_url_get):
- UIProcess/API/efl/ewk_web_resource.h:
- 4:44 AM Changeset in webkit [122565] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] WebKitWebView::mouse-target-changed is not emitted when moved to/from edtiable content
https://bugs.webkit.org/show_bug.cgi?id=91216
Reviewed by Xan Lopez.
The problem is that the function to check whether two hit test
results are equal doesn't check the editable flag.
- UIProcess/API/gtk/WebKitHitTestResult.cpp:
(webkitHitTestResultCompare): Check also the editable flag.
- 4:43 AM Changeset in webkit [122564] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Add const to the parameter of getters in ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=90954
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-13
Reviewed by Kentaro Hara.
Move initialization of strings for protocol and host to the ewk_security_origin_new method,
which allows to add const qualifier for ewk_security_origin_protocol_get and ewk_security_origin_host_get.
In addition, add null checks to the getters.
- ewk/ewk_security_origin.cpp:
(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_new):
- ewk/ewk_security_origin.h:
- 4:32 AM BuildingQtOnLinux edited by
- (diff)
- 4:31 AM BuildingQtOnLinux edited by
- (diff)
- 4:24 AM Changeset in webkit [122563] by
-
- 7 edits in trunk/Source
[EFL] Add *explicit* keyword to constructor which has a parameter
https://bugs.webkit.org/show_bug.cgi?id=91207
Reviewed by Zoltan Herczeg.
Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
- WebCoreSupport/InspectorClientEfl.h:
(InspectorClientEfl):
- WebCoreSupport/PageClientEfl.h:
(PageClientEfl):
- WebCoreSupport/VibrationClientEfl.h:
(VibrationClientEfl):
Source/WebKit2:
- WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext::WebFrameNetworkingContext):
- 4:19 AM BuildingQtOnLinux edited by
- Update with set up details regarding building on QtCreator. (diff)
- 4:16 AM Changeset in webkit [122562] by
-
- 13 edits3 adds in trunk
[Chromium] Fix bugs in HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=90951
Reviewed by Tony Chang.
Source/WebCore:
The current implementation has following problems:
- Cannot render RTL text if the TextRun is divided into more than two HarfBuzzRun.
- Script handling in TextRun partitioning is incorrect.
- Inaccurate calculation of selection rect.
- Wrong rendering position when the first glyph of the TextRun have non-zero offsets in terms of HarfBuzz.
To fix these problems I rewrote HarfBuzzShaper class. Here is the summary:
- Divide the whole range of TextRun first, then shape them in visual order.
- Divide TextRun in the same way of old-harfbuzz's hb_utf16_script_run_next().
- Prefer float than int when calculating selection.
- Adjust the drawing point after shaping.
Added tests covers the fix except for the last problem. The last problem will be covered
by fast/text/international/complex-joining-using-gpos.html after chromium linux port switches
to use HarfBuzzShaper.
Tests: fast/text/shaping/shaping-script-order.html
fast/text/shaping/shaping-selection-rect.html
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawComplexText): Adjusts point after shaping.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore):
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndAdvance): Offsets are no longer needed.
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset): Calculates character offset based on advance.
(WebCore::normalizeCharacters): Added.
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::shape): Divides TextRun first, then shapes them.
(WebCore::HarfBuzzShaper::adjustStartPoint): Added.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns): Added.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Added.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Followed other changes.
(WebCore::HarfBuzzShaper::selectionRect): Use float for calculating selection.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzShaper): Holds the start index of character. Removed unnecessary variables.
(WebCore::HarfBuzzShaper::HarfBuzzRun::create): Ditto.
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::fontData): Added.
(WebCore::HarfBuzzShaper::HarfBuzzRun::startIndex): Ditto.
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphs): Ditto.
(WebCore::HarfBuzzShaper::HarfBuzzRun::advances): Ditto.
LayoutTests:
Add tests for harfbuzz-ng shaper. I tried to use -expected.html style expectations,
but it didn't work because there are very slight difference between CoreText and HarfBuzz in
rendering result.
- fast/text/shaping/shaping-script-order.html: Added.
- fast/text/shaping/shaping-selection-rect.html: Added.
- platform/chromium/TestExpectations: Need rebaseline.
- platform/efl/TestExpectations: Skip added tests because the port doesn't use harfbuzz.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/Skipped: Ditto.
- platform/wincairo/Skipped: Ditto.
- platform/wk2/Skipped: Ditto.
- 4:03 AM Changeset in webkit [122561] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r122545.
http://trac.webkit.org/changeset/122545
https://bugs.webkit.org/show_bug.cgi?id=91185
We found that this was a wrong fix
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 4:01 AM Changeset in webkit [122560] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r122553.
http://trac.webkit.org/changeset/122553
https://bugs.webkit.org/show_bug.cgi?id=91198
We found that this was a wrong fix
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 3:59 AM Changeset in webkit [122559] by
-
- 9 edits in trunk/Source/WebCore
Change the timing of form state restore
https://bugs.webkit.org/show_bug.cgi?id=89962
Reviewed by Hajime Morita.
For a preparation to fix a form identification problem (Bug 91209),
restore controls states when the parsing of their owner forms is
completed. For controls without owners, their states are restored when
their parsing is completed as ever.
No new tests. This doesn't change observable behavior.
- html/FormController.cpp:
(WebCore::ownerFormForState):
Added. This code was used in formKey(), and restoreControlState*() use it.
(WebCore::FormKeyGenerator::formKey): Use ownerFormForState(). No behavior change.
(WebCore::FormController::restoreControlStateFor):
Moved some code from HTMLFormControlElementWithState::finishParsingChildren().
The difference is we don't resotre state if this control is owned by a form.
(WebCore::FormController::restoreControlStateIn):
Restore states of associated controls. This is called from
finishParsingChildren() for <form>.
- html/FormController.h:
(FormController):
- Declare restoreControlStateFor() and restoreControlStateIn().
- Make takeStateForFormElement() private.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::isFormControlElementWithState):
Added. The default implementation returns false.
- html/FormAssociatedElement.h:
(FormAssociatedElement):
Added isFormControlElementWithState() for FormController::restoreControlStateIn().
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
Some code was moved to FormController:restoreControlStateFor().
(WebCore::HTMLFormControlElementWithState::isFormControlElementWithState):
Added. Returns true.
- html/HTMLFormControlElementWithState.h:
(HTMLFormControlElementWithState): Declare isFormControlElementWithState().
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::finishParsingChildren):
Added. Calls FormController::restoreControlStateIn().
- html/HTMLFormElement.h:
(HTMLFormElement): Declare finishParsingChildren().
- 3:35 AM Changeset in webkit [122558] by
-
- 16 edits2 copies5 adds in trunk
Make calendar pickers testable
https://bugs.webkit.org/show_bug.cgi?id=84827
Reviewed by Hajime Morita.
Source/WebCore:
WebCore:
- Add PagePopupDriver, an interface to open/close a PagePopup.
- Add setPagePopupDriver() to ChromeClient in order to inject a
PagePopupDriver for testing.
Internals:
Add MockPagePopupDriver, which creates a MockPagePopup, which creates a
normal <iframe> in the top-level document, and load the popup content on
it. MockPagePopupDriver is enabled by
internals.settings.setEnableMockPagePopup(true).
Test: fast/forms/date/calendar-picker-appearance.html
- WebCore.gypi: Add new files.
- WebCore.xcodeproj/project.pbxproj: Add files to make this buildable.
- page/ChromeClient.h:
(ChromeClient): Add function for PagePopupDriver.
- loader/EmptyClients.h: Add empty implementations for PagePopupDriver functions.
- page/PagePopupDriver.h: Added.
(PagePopupDriver):
(WebCore::PagePopupDriver::~PagePopupDriver):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo): Reset the mock PagePopupDriver.
(WebCore::InternalSettings::setEnableMockPagePopup):
Register MockPagePopupDriver to ChromeClient.
- testing/InternalSettings.h:
(InternalSettings): Declare setEnableMockPagePopup().
- testing/InternalSettings.idl: ditto.
- testing/MockPagePopupDriver.cpp: Added.
(MockPagePopup): Pseudo PagePopup implementation with the standard <iframe>.
(WebCore::MockPagePopupDriver::MockPagePopupDriver): Added.
(WebCore::MockPagePopupDriver::create): Added.
(WebCore::MockPagePopupDriver::~MockPagePopupDriver): Added.
(WebCore::MockPagePopupDriver::openPagePopup):
Added. An override of PagePopupDriver function. This creates a MockPagePopup.
(WebCore::MockPagePopupDriver::closePagePopup):
Added. An override of PagePopupDriver function. This deletes the MockPagePopup.
- testing/MockPagePopupDriver.h:
(MockPagePopupDriver): Added.
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectPagePopupController):
Added. Production code uses per-Page context feature framework. However
MockPagePopup uses the same page as the host page. So we can't use the
framework and need to inject window.pagePopupController manually.
- testing/v8/WebCoreTestSupport.h:
(WebCoreTestSupport): Add injectPagePopupController().
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::ChromeClientImpl):
Initialize m_pagePopupDriver with the WebViewImpl.
(WebKit::ChromeClientImpl::openPagePopup):
Just calls PagePoupDriver::openPagePopup().
(WebKit::ChromeClientImpl::closePagePopup):
Just calls PagePoupDriver::closePagePopup().
(WebKit::ChromeClientImpl::setPagePopupDriver):
- src/ChromeClientImpl.h:
(ChromeClientImpl): Add setPagePopupDriver
- src/WebViewImpl.h:
(WebViewImpl):
WebViewImpl implements PagePopupDriver. openPagePopup() and
closePagePopup() override members of PagePopupDriver.
LayoutTests:
- fast/forms/date/calendar-picker-appearance-expected.txt: Added.
- fast/forms/date/calendar-picker-appearance.html: Added.
- platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png: Added.
- platform/chromium/TestExpectations:
- 3:21 AM Changeset in webkit [122557] by
-
- 6 edits in trunk
Web Inspector: mute the native looks of the selects in the console.
https://bugs.webkit.org/show_bug.cgi?id=91120
Reviewed by Vsevolod Vlasov.
This is necessary for Mac now that we don't use border images for select.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._updateIsolatedWorldSelector):
(WebInspector.ConsoleView.prototype._appendIsolatedContextOption):
(WebInspector.ConsoleView.prototype._currentEvaluationContext):
(WebInspector.ConsoleView.prototype._currentIsolatedContextId):
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarComboBox):
(WebInspector.StatusBarComboBox.prototype.addOption):
(WebInspector.StatusBarComboBox.prototype.removeOption):
(WebInspector.StatusBarComboBox.prototype.removeOptions):
(WebInspector.StatusBarComboBox.prototype.selectedOption):
- inspector/front-end/inspector.css:
(.status-bar-select-container):
(select.status-bar-item):
(.console-context):
- 3:01 AM Changeset in webkit [122556] by
-
- 28 edits1 copy1 add in trunk
[CSS Regions] Fix the lifecycle for the flow objects and their renderers
https://bugs.webkit.org/show_bug.cgi?id=89000
Patch by Andrei Bucur <abucur@adobe.com> on 2012-07-13
Reviewed by Eric Seidel.
Source/WebCore:
This patch adds the concept of a NamedFlowCollection, owned by the document, that keeps track of
all the named flows that exist in the Document. This collection contains a ListHashSet of weak references to
all the existing NamedFlows in the document. This is not a managed set because the CREATED flows are referenced from the renderer and
the NULL flows are only cached, they should be destructible.
Two named flows are considered to be equal if they have the same name.
I've changed the NamedFlow state to depend on the existence of its renderer. A flow thread that has a renderer will also have a NamedFlow object.
A flow thread without a renderer can have a NamedFlow object, but only in the NULL state. It's possible for a NamedFlow object to jump from the
NULL state to the CREATED state if it was not destroyed (e.g. it was referenced from JS). Keeping track of the NULL state flows that have listeners will be important
so when they go back to the CREATED state, the listeners would still be there.
Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/
Tests: The old tests have been modified to take into account the new behavior
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore):
(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::namedFlows):
- dom/Document.h:
(WebCore):
(Document):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::~WebKitNamedFlow):
(WebCore::WebKitNamedFlow::create):
(WebCore):
(WebCore::WebKitNamedFlow::name):
(WebCore::WebKitNamedFlow::overset):
(WebCore::nodeInFlowThread):
(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore::WebKitNamedFlow::getContent):
(WebCore::WebKitNamedFlow::setRenderer):
- dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::getFlowState):
(WebCore::WebKitNamedFlow::switchFlowState):
- dom/WebKitNamedFlowCollection.cpp: Added.
(WebCore):
(WebCore::WebKitNamedFlowCollection::WebKitNamedFlowCollection):
(WebCore::WebKitNamedFlowCollection::length): An O(1) operation
(WebCore::WebKitNamedFlowCollection::item): An O(N) operation
(WebCore::WebKitNamedFlowCollection::flowByName): An O(1) operation
(WebCore::WebKitNamedFlowCollection::ensureNamedFlowInCreatedState): An O(1) operation
(WebCore::WebKitNamedFlowCollection::moveNamedFlowToNullState): An O(1) operation
(WebCore::WebKitNamedFlowCollection::discardNamedFlow): An O(1) operation
(WebCore::WebKitNamedFlowCollection::documentDestroyed):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashFunctions::hash):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashFunctions::equal):
(WebKitNamedFlowCollection::NamedFlowHashFunctions):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashTranslator::hash):
(WebCore::WebKitNamedFlowCollection::NamedFlowHashTranslator::equal):
- dom/WebKitNamedFlowCollection.h: Copied from Source/WebCore/dom/WebKitNamedFlow.h.
(WebCore):
(WebKitNamedFlowCollection):
(WebCore::WebKitNamedFlowCollection::create):
(WebCore::WebKitNamedFlowCollection::document):
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::removeFlowThread):
(WebCore):
- rendering/FlowThreadController.h:
(FlowThreadController):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore):
(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::flowThreadName):
(WebCore::RenderNamedFlowThread::willBeDestroyed):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::canBeDestroyed):
LayoutTests:
These tests expected getFlowByName() to return a valid object even for the NULL flows. They've been modified to
reflect the new behavior.
- fast/regions/get-regions-by-content-node2-expected.txt:
- fast/regions/get-regions-by-content-node2.html:
- fast/regions/webkit-named-flow-flow-added.html:
- fast/regions/webkit-named-flow-get-content-expected.txt:
- fast/regions/webkit-named-flow-get-content.html:
- fast/regions/webkit-named-flow-invalid-name.html:
- fast/regions/webkit-named-flow-modified-flow.html:
- fast/regions/webkit-named-flow-non-existing-flow.html:
- fast/regions/webkit-named-flow-removed-flow.html:
- platform/chromium-win/fast/regions/region-style-block-background-color2-expected.txt:
- platform/mac/fast/regions/region-style-block-background-color2-expected.txt:
- 2:38 AM Changeset in webkit [122555] by
-
- 2 edits in trunk/Source/WebCore
[V8Bindings] Implement generalised method to validates that the passed object is a sequence type.
https://bugs.webkit.org/show_bug.cgi?id=91056
Patch by Vineet Chaudhary <Vineet> on 2012-07-13
Reviewed by Kentaro Hara.
Currently the V8 implementation validates that the passed object is a sequence type only
for MessagePort in V8Utilities::extractTransferables().
There should be generalised method for other types too.
Spec URL: http://www.w3.org/TR/2012/WD-WebIDL-20120207/#es-sequence
No new test, Just refactoring. There should be no behavioral changes.
- bindings/v8/V8Binding.h:
(WebCore::toV8Sequence): Added implementation of toV8Sequence().
- 2:20 AM Changeset in webkit [122554] by
-
- 13 edits4 adds in trunk
[Qt][WK2] Implement GraphicsSurface for Linux/GLX.
https://bugs.webkit.org/show_bug.cgi?id=90881
Source/WebCore:
Add a GLX based GraphicsSurface implementation for Linux.
Native X windows are being used for exchanging textures
with the UIProcess.
Reviewed by Noam Rosenthal.
- Target.pri:
- WebCore.pri:
- platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::create):
Move creating GraphicsSurface instance into
platformCreate/platformImport functions to allow
platform specific creation based on the provided flags.
(WebCore::GraphicsSurface::GraphicsSurface):
(WebCore::GraphicsSurface::~GraphicsSurface):
Call platformDestroy when destroying a GraphicsSurface.
(WebCore):
- platform/graphics/surfaces/GraphicsSurface.h:
Make platformCreate/platformImport functions static
to be able to call these from the static create function.
Add Destructor prototype and add GraphicsSurfacePrivate member.
(WebCore):
(GraphicsSurface):
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
Insert creation of GraphicsSurface instance.
This allows having a platform specific creation mechanism
for GLX.
- platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp: Added.
(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
Add an OffScreenRootWindow singelton that is being used
as a parent for all native offscreen windows.
(GraphicsSurfacePrivate):
This class is used to manage all the X related resources
such as opening a display or creating XPixmaps etc.
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
Open a connection to the X server and create a
QOpenGLContext that can be used to resolve GL functions.
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
Properly cleanup and release all the X resources again.
(WebCore::GraphicsSurfacePrivate::createSurface):
Create a surface that is placed off screen and can be
used as a rendering target by the WebProcess.
(WebCore::GraphicsSurfacePrivate::createPixmap):
Create a GLXPixmap from the XWindow that was previously
redirected by the WebProcess. This GLXPixmap can then be
bound to a texture and being painted on screen by the
UIProcess.
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):
Initialize all the function pointers for the GL functions used.
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
Bind the GLXPixmap to a texture.
(WebCore::GraphicsSurface::platformCopyToGLTexture):
Not beeing implemented for GLX.
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
Blit origin fbo onto the GraphicsSurface's backing.
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
Source/WebKit2:
Add a GLX based GraphicsSurface implementation for Linux.
Reviewed by Noam Rosenthal.
- Shared/ShareableSurface.cpp:
(WebKit::ShareableSurface::create):
Only create a GraphicsSurface from a ShareableSurface::Handle
in case the Handle contains a valid GraphicsSurface token.
Otherwise fall back to creating a ShareableBitmap.
- UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::createLayerTileUniqueKey):
Create a unique key for a surface based on tileID and layerID.
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
Even when GraphicsSurface is enabled, not all ShareableSurfaces
will necessarily be backed by a GraphicsSurface. In case of
a ShareableSurface being backed by a ShareableBitmap instead,
the GraphicsSurface token will always be null.
So instead of using the GraphicsSurface token as a key for
storing surfaces in a map, we create a unique key from
layerID and tileID.
- UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
Tools:
Enable GraphicsSurface for Linux based platforms
whenever the Xcomposite extension is available.
Reviewed by Noam Rosenthal.
- qmake/config.tests/libXcomposite/libXcomposite.cpp: Added.
(main):
- qmake/config.tests/libXcomposite/libXcomposite.pro: Added. Add a configure test to detect Xcomposite extension and activate GraphicsSurface on linux in case the extension is available.
- qmake/configure.pri:
- qmake/mkspecs/features/features.prf:
- 2:05 AM Changeset in webkit [122553] by
-
- 2 edits in trunk/Source/WebCore
CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
https://bugs.webkit.org/show_bug.cgi?id=91198
Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-13
Reviewed by Kentaro Hara.
'SetterExpression' should use 'push' to make arguments, rather than 'unshift'.
No new tests. Covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 1:56 AM Changeset in webkit [122552] by
-
- 7 edits in trunk
REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched
https://bugs.webkit.org/show_bug.cgi?id=91197
Reviewed by Kent Tamura.
Source/WebCore:
This patch fixes implementation of Decimal::ceiling() and floor().
They return wrong value for small fractional numbers.
The bug is occurred when:
- Step-able input type, e.g. number, date, datetime, and so on.
- Current value is step mismatched
- Current value is smaller than step
- Step up/down by spin button
because spin button up/down actions are implemented in InputType::setpUpFromRenderer
which calls Decimal::ceiling() and floor() for step mismatched case.
Tests: fast/forms/number/number-stepup-stepdown-from-renderer.html: Added test cases
WebKit/chromium/tests/DecimalTest.cpp: Added test cases
- platform/Decimal.cpp:
(WebCore::Decimal::ceiling): Changed to return 1 for positive small fractional number.
(WebCore::Decimal::floor): Changed to return -1 for negative small fractional number.
Source/WebKit/chromium:
This patch adds test cases for Decimal::ceiling() and floor() of
positive/negative small fractional numbers.
- tests/DecimalTest.cpp:
(TEST_F):
LayoutTests:
This patch adds new test cases.
- fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Updated for new test cases.
- fast/forms/number/number-stepup-stepdown-from-renderer.html: Added new test cases.
- 1:23 AM Changeset in webkit [122551] by
-
- 2 edits in trunk/Tools
nrwt: don't choke when printing invalid utf-8 to stderr
https://bugs.webkit.org/show_bug.cgi?id=91181
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_stderr):
- 1:06 AM Changeset in webkit [122550] by
-
- 9 edits2 adds in trunk
Should be possible to focus elements within canvas fallback content
https://bugs.webkit.org/show_bug.cgi?id=87898
Reviewed by Chris Fleizach.
Source/WebCore:
Patches isFocusable in dom/Node.cpp and html/HTMLFormControlElement.cpp
to make elements focusable if they're a descendent of a canvas element
if they would otherwise have been focusable but just didn't have
a renderer. Adds a bit to ElementRareData to efficiently keep track
of elements in a canvas subtree.
Test: fast/canvas/fallback-content.html
- dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::setIsInCanvasSubtree):
(WebCore):
(WebCore::Element::isInCanvasSubtree):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::isFocusable):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::attach):
(WebCore):
- html/HTMLCanvasElement.h:
(HTMLCanvasElement):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isFocusable):
LayoutTests:
- fast/canvas/fallback-content-expected.txt: Added.
- fast/canvas/fallback-content.html: Added.
- 12:45 AM Changeset in webkit [122549] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed inspector test fix.
- http/tests/inspector/network/resources/style.css: Added.
(body):
- 12:39 AM Changeset in webkit [122548] by
-
- 5 edits in trunk/Tools
test-webkitpy: more class renaming cleanup
https://bugs.webkit.org/show_bug.cgi?id=91182
Reviewed by Adam Barth.
More removing of the unnecessary "Test" prefix.
- Scripts/webkitpy/test/finder.py:
(_DirectoryTree):
(Finder.add_tree):
- Scripts/webkitpy/test/main.py:
(Tester._run_tests):
- Scripts/webkitpy/test/runner.py:
(Runner):
- Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
- 12:26 AM Changeset in webkit [122547] by
-
- 19 edits1 move5 adds1 delete in trunk/Source
[GTK] Add API to get HTTPS status to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=91100
Reviewed by Martin Robinson.
Source/WebCore:
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::soupMessageCertificate): Return the
certificate.
(WebCore::ResourceResponse::setSoupMessageCertificate): Set a
certificate.
(WebCore::ResourceResponse::soupMessageTLSErrors): Return the TLS
errors.
(WebCore::ResourceResponse::setSoupMessageTLSErrors): Set TLS
errors.
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage): Set the certificate
and TLS errors to the newly created SoupMessage.
(WebCore::ResourceResponse::updateFromSoupMessage): Get the
certificate and TLS errors from the SoupMessage.
Source/WebKit2:
Add webkit_uri_response_get_https_status() to return
GTlsCertificate and GTlsCertificateFlags with information about
the SSL certificate and the possible errors with the certificate.
- GNUmakefile.list.am: Add new files to compilation.
- PlatformEfl.cmake: Ditto.
- Shared/efl/PlatformCertificateInfo.h: Removed.
- Shared/soup/PlatformCertificateInfo.cpp: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode): Encode the
GTlsCertificate and GTlsCertificateFlags.
(WebKit::PlatformCertificateInfo::decode): Decode
PlatformCertificateInfo into a GTlsCertificate and GTlsCertificateFlags.
- Shared/soup/PlatformCertificateInfo.h: Renamed from Source/WebKit2/Shared/gtk/PlatformCertificateInfo.h.
(WebKit::PlatformCertificateInfo::certificate): Return the certificate.
(WebKit::PlatformCertificateInfo::tlsErrors): Return the TLS errors
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(didCommitLoadForFrame): Set the certificate of the current frame
to the response of the main resource.
- UIProcess/API/gtk/WebKitURIResponse.cpp:
(webkit_uri_response_get_https_status): Return GTlsCertificate and
GTlsCertificateFlags.
(webkitURIResponseSetCertificateInfo): Update the internal
ResourceResponse with the GTlsCertificate and GTlsCertificateFlags
of the given PlatformCertificateInfo.
- UIProcess/API/gtk/WebKitURIResponse.h:
- UIProcess/API/gtk/WebKitURIResponsePrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestMain.h:
(Test::getResourcesDir): Helper function to get the resources
directory of the WebKit2 API tests.
- UIProcess/API/gtk/tests/TestSSL.cpp: Added.
(testSSL):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebKitTestServer.cpp:
(WebKitTestServer::WebKitTestServer): Add support por SSL test
servers.
- UIProcess/API/gtk/tests/WebKitTestServer.h:
(WebKitTestServer): Add ssl parameter to create a HTTPS server.
- UIProcess/API/gtk/tests/resources/test-cert.pem: Added.
- UIProcess/API/gtk/tests/resources/test-key.pem: Added.
Source/WTF:
Add support for GByteArray.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
(WTF):
- wtf/gobject/GTypedefs.h:
- 12:20 AM Changeset in webkit [122546] by
-
- 5 edits2 adds in trunk
RadioNodeList is not updated upon input type change
https://bugs.webkit.org/show_bug.cgi?id=91178
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Invalidate the radio node lists when type content attribute changes since it excludes
image type input elements.
Test: fast/forms/radionodelist-image-type.html
- dom/Document.cpp:
(WebCore::shouldInvalidateNodeListForType):
- dom/Document.h: Renamed InvalidateOnIdNameForAttrChange to InvalidateOnFormAttrChange
since listing all attribute name isn't useful at this point.
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
LayoutTests:
Add a regression test.
- fast/forms/radionodelist-image-type-expected.txt: Added.
- fast/forms/radionodelist-image-type.html: Added.
