Timeline



Aug 8, 2012:

11:39 PM Changeset in webkit [125155] by inferno@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebKit/chromium/features.gypi

Revert 116356 - Disable Iframe seamless for m22.
BUG=138422
Review URL: https://chromiumcodereview.appspot.com/10826222

11:23 PM Changeset in webkit [125154] by hclam@chromium.org
  • 6 edits
    6 adds in trunk

Source/WebCore: Remove image decoding in some BitmapImage metadata functions
https://bugs.webkit.org/show_bug.cgi?id=93171

Reviewed by Simon Fraser.

These two metadata functions were decoding an entire frame:

  • frameOrientationAtIndex
  • frameHasAlphaAtIndex

This change removes image decoding from these two methods. This is for
preparation of having asynchronous image decoding, intending to reduce
code location that trigger image decoding.

frameOrientationAtIndex() doesn't require decoding a frame. This method
is only implemented in CG port in ImageSourceCG.cpp which doesn't do
image decoding.

frameHasAlphaAtIndex() is used to optimize certain drawing operations
and accelerated compositing. This change uses a heuristic for non-CG
port to determine if an image has alpha. If an image is not yet
decoded the function answers having alpha. Only if a frame is decoded
and cached that the alpha state of the frame is returned. This is an
admissible heuristic that postpone answering the question until a frame
is decoded.

Tested this change with a fully loaded image and partially loaded image
with background color.

Test: http/tests/images/jpg-img-partial-load.html

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore::BitmapImage::frameOrientationAtIndex):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameHasAlphaAtIndex):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameHasAlphaAtIndex):
(WebCore):

  • platform/image-decoders/ImageDecoder.h:

(ImageDecoder):

LayoutTests: Test rendering JPEG <img> with CSS background
https://bugs.webkit.org/show_bug.cgi?id=93171

Reviewed by Simon Fraser.

Tests defer answering the alpha state for BitmapImage not yet
decoded doesn't affect rendering results.

Test: http/tests/images/jpg-img-partial-load.html

Tests the rendering results of a partially loaded JPEG image.
The image should be green in the top region and blue in the
lower region. The blue is the background color revealed by
full alpha of the undecoded region.

  • fast/images/resources/green-256x256.jpg: Added.
  • http/tests/images/jpg-img-partial-load-expected.png: Added.
  • http/tests/images/jpg-img-partial-load-expected.txt: Added.
  • http/tests/images/jpg-img-partial-load.html: Added.
  • http/tests/resources/load-and-stall.php: Added.
10:50 PM Changeset in webkit [125153] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

update bot parsing of new-run-webkit-tests' output
https://bugs.webkit.org/show_bug.cgi?id=93537

Patch by Dirk Pranke <dpranke@chromium.org> on 2012-08-08
Reviewed by Ryosuke Niwa.

This change updates the way we parse the output from
new-run-webkit-tests on the bots so that we can show a summary
of the results properly after I re-land the changes that were
reverted in r124994 and r124870.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests._parseNewRunWebKitTestsOutput):

10:29 PM Changeset in webkit [125152] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r125146.
http://trac.webkit.org/changeset/125146
https://bugs.webkit.org/show_bug.cgi?id=93578

Would like to study fast/dom/Window/timer-null-script-
execution-context.html behavior change (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-08

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
(WebCore::JSDOMWindowBase::allowsAccessFrom):

  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):

  • bindings/js/JSDOMWindowCustom.h:

(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):
(WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
(WebCore::JSDOMWindowBase::allowsAccessFromPrivate):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

10:27 PM Changeset in webkit [125151] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skip CoreAnimation plugin model tests on android
https://bugs.webkit.org/show_bug.cgi?id=90586

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-08
Reviewed by Adam Barth.

  • platform/chromium/TestExpectations:
10:21 PM Changeset in webkit [125150] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Skip platform/mac/editing/deleting/backward-delete.html on android
https://bugs.webkit.org/show_bug.cgi?id=90585

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-08
Reviewed by Adam Barth.

  • platform/chromium/TestExpectations:
9:49 PM Changeset in webkit [125149] by kinuko@chromium.org
  • 41 edits
    1 delete in trunk

Unprefix window.webkitURL
https://bugs.webkit.org/show_bug.cgi?id=93034

Reviewed by Jian Li.

Adding unprefixed window.URL as other browsers like FireFox and Opera 12 seem to have the API unprefixed.
(This patch doesn't remove webkitURL yet as Safari and Chrome has exposed the URL for a while now.)

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html

  • page/DOMWindow.cpp:
  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

LayoutTests:

Changed most of the window.URL test code to use unprefixed version.
To verify webkitURL is still available left webkitURL related tests in
fast/dom/DOMURL/check-instanceof-domurl-functions.html.

  • editing/pasteboard/data-transfer-items-image-png.html:
  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt:
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html:
  • fast/dom/HTMLAnchorElement/anchor-download-unset.html:
  • fast/dom/HTMLAnchorElement/anchor-download.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/window-domurl-crash.html:
  • fast/files/apply-blob-url-to-img.html:
  • fast/files/apply-blob-url-to-xhr.html:
  • fast/files/create-blob-url-crash.html:
  • fast/files/domurl-script-execution-context-crash.html:
  • fast/files/revoke-blob-url.html:
  • fast/files/url-null-expected.txt:
  • fast/files/url-null.html:
  • fast/files/url-required-arguments-expected.txt:
  • fast/files/url-required-arguments.html:
  • fast/files/workers/inline-worker-via-blob-url.html:
  • fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
  • fast/js/constructor-length.html:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • http/tests/security/mixedContent/blob-url-in-iframe.html:
  • platform/chromium-win/compositing/geometry/object-clip-rects-assertion-expected.txt:
  • platform/chromium/fast/files/url-required-arguments-expected.txt:
  • platform/chromium/media/video-capture-preview.html:
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/gtk/fast/files/url-required-arguments-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/fast/js/constructor-length-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/qt-5.0/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:31 PM FeatureFlags edited by shanestephens@google.com
(diff)
9:26 PM Changeset in webkit [125148] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

nested fragment parser test slow on Android
https://bugs.webkit.org/show_bug.cgi?id=90438

Patch by Wei James <james.wei@intel.com> on 2012-08-08
Reviewed by Ryosuke Niwa.

  • platform/chromium/TestExpectations:
9:16 PM Changeset in webkit [125147] by morrita@google.com
  • 11 edits
    2 adds in trunk

[SVG] load events shouldn't be fired during Node::insrtedInto()
https://bugs.webkit.org/show_bug.cgi?id=92969

Reviewed by Ryosuke Niwa.

Source/WebCore:

Event dispatches during insertedInto() allow event handlers to
break DOM tree cosistency. This chagne makes them async for load
events which are dispatched during insertedInto() call. This
prevents event handlers from breaking tree consistency while the
notification traversal.

Test: svg/custom/loadevents-async.html

  • svg/SVGElement.cpp:

(WebCore::SVGElement::sendSVGLoadEventIfPossibleAsynchronously): Added.
(WebCore):
(WebCore::SVGElement::svgLoadEventTimerFired): Added.
(WebCore::SVGElement::svgLoadEventTimer):

  • Added a stub. Implemented in SVGScriptElement, SVGStopElement, SVGUseElement where the load event happens.
  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGExternalResourcesRequired.cpp:

(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):

  • Replaces event dispatch call with async version.
  • svg/SVGScriptElement.h:
  • svg/SVGStyleElement.h:
  • svg/SVGUseElement.h:

LayoutTests:

  • svg/custom/loadevents-async-expected.txt: Added.
  • svg/custom/loadevents-async.html: Added.
8:52 PM Changeset in webkit [125146] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

Implement JSDOMWindow*::allowsAccessFrom* in terms of BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=93407

Reviewed by Eric Seidel.

This patch removes allowsAccessFrom and implements the security checks
in terms of shouldAllowAccessToFrame directly. There shouldn't be any
change in behavior.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore):
(WebCore::shouldAllowAccessFrom):

  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):

  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

8:51 PM Changeset in webkit [125145] by tony@chromium.org
  • 10 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r125143.
http://trac.webkit.org/changeset/125143
https://bugs.webkit.org/show_bug.cgi?id=93573

Doesn't compile on Mac (Requested by tonywork on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-08

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/NativeImagePtr.h: Removed.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:
7:53 PM Changeset in webkit [125144] by Lucas Forschler
  • 110 edits in branches/safari-536.26-branch/Source

Merged <rdar://problem/12050720>

7:35 PM Changeset in webkit [125143] by kseo@webkit.org
  • 10 edits
    1 add in trunk/Source/WebCore

Extract the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.
https://bugs.webkit.org/show_bug.cgi?id=93466

Patch by Huang Dongsung <luxtella@company100.net> on 2012-08-08
Reviewed by Adam Barth.

Image.h includes ImageSource.h in order to know the definition of NativeImagePtr.
But Image does not need to know the definition of ImageSource. So, this patch
extracts the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.

This is a preparation for asynchronous image decoding. Async decoding
will need a callback function, which sends a NativeImagePtr to clients, and the
callback must know the definition of NativeImagePtr, not ImageSource.

No new tests, behavior is unchanged.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/NativeImagePtr.h: Added.

(WebCore):

7:29 PM Changeset in webkit [125142] by commit-queue@webkit.org
  • 15 edits in trunk

Compile flag for CSS Hierarchies
https://bugs.webkit.org/show_bug.cgi?id=92433

Patch by Shane Stephens <shanestephens@google.com> on 2012-08-08
Reviewed by Tony Chang.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Note that this flag is disabled on all platforms for now.

No new tests since there's no functional change.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
7:26 PM Changeset in webkit [125141] by tkent@chromium.org
  • 4 edits in trunk/Source

[Chromium-mac] Switch to LocalizedNumberMac from LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=93432

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. Covered by fast/forms/number/number-lossless-localization.html,
and WebKit/chromium/tests/LocaleMacTest.cpp.

  • WebCore.gyp/WebCore.gyp:

Exclude locale-relatef files for ICU, and include files for Mac.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

Add some tests for number localization. They are similar to tests in
LocaleWinTest and LocalizedNumberICUTest.cpp
(LocaleMacTest):
(LocaleMacTest::decimalSeparator):
(TEST_F):
(testNumberIsReversible):
(testNumbers):

7:22 PM Changeset in webkit [125140] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

css3/flexbox/content-height-with-scrollbars.html failing on non-fractional pixel layout machines
https://bugs.webkit.org/show_bug.cgi?id=93530

Unreviewed, fixing the test to not depend on rounding behavior.

  • css3/flexbox/content-height-with-scrollbars-expected.html: Use a fixed width.
  • css3/flexbox/content-height-with-scrollbars.html: Use a fixed width.
  • platform/efl/TestExpectations: Remove failing expectation.
  • platform/gtk/TestExpectations: Remove failing expectation.
  • platform/mac/TestExpectations: Remove failing expectation.
7:09 PM Changeset in webkit [125139] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed TestExpectations cleanup and a new baseline.

  • platform/chromium/TestExpectations:
  • platform/chromium/http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
7:05 PM Changeset in webkit [125138] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Fix invalid test
https://bugs.webkit.org/show_bug.cgi?id=93543

Reviewed by Kentaro Hara.

The HTMLMediaElement.prototype.NETWORK_NO_SOURCE is non writable so assigning to the element instance should
be ignored.

  • media/network-no-source-const-shadow-expected.txt:
  • media/network-no-source-const-shadow.html:
6:53 PM FeatureFlags edited by tkent@chromium.org
Add a comment to FILTERS (diff)
6:46 PM Changeset in webkit [125137] by kerz@chromium.org
  • 2 edits
    1 copy in branches/chromium/1229/Source

Merge 125077 - Crash when reloading a Chromium "platform" app
https://bugs.webkit.org/show_bug.cgi?id=93497

Reviewed by Eric Seidel.

Source/WebCore:

The framework for Chromium "platform" apps executes a big blob of
script during the didCreateScriptContext callback. This blob of scripts
interacts with a bunch of JavaScript objects and triggers a number of
security checks.

When reloading a frame, the didCreateScriptContext is called during
Frame::setDocument (as a consequence of calling
ScriptController::updateDocument). At that time, the SecurityOrigin
object hasn't yet been copied over to the DOMWindow, and we crash
trying to grab it.

The long-term fix for this bug is to fix
https://bugs.webkit.org/show_bug.cgi?id=75793, at which point there
will no longer be a SecurityOrigin object on DOMWindow. In the
meantime, however, we can fix this crash by null checking the
DOMWindow's SecurityOrigin object.

  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):

Source/WebKit/chromium:

Test that we don't crash when executing script during the
didCreateScriptContext callback.

  • tests/WebFrameTest.cpp:
  • tests/data/hello_world.html: Added.

TBR=abarth@webkit.org

6:45 PM Changeset in webkit [125136] by kerz@chromium.org
  • 1 add in branches/chromium/1229/codereview.settings

add codereview settings

6:29 PM Changeset in webkit [125135] by benjamin@webkit.org
  • 9 edits in trunk

Use char* instead of LChar* for the public interface of String construction from literals
https://bugs.webkit.org/show_bug.cgi?id=93402

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-08
Reviewed by Michael Saboff.

Source/JavaScriptCore:

Update JSC' Identifier to use StringImpl::createFromLiteral with a char*.

  • runtime/Identifier.cpp:

(JSC::IdentifierASCIIStringTranslator::translate):

Source/WTF:

When the initialization from literal was added, some constructor/initialization function were
using LChar for convenience.

Since those function should only take ASCII characters, using LChar* could cause confusion. This
patch intents to clarify this by using char* for all those APIs.

  • wtf/text/AtomicString.cpp:

(WTF::CharBufferFromLiteralDataTranslator::hash):
(WTF::CharBufferFromLiteralDataTranslator::equal):
(WTF::CharBufferFromLiteralDataTranslator::translate):
(WTF::AtomicString::addFromLiteralData):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(AtomicString):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):

Tools:

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

6:14 PM Changeset in webkit [125134] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.26-branch

Merged r123121. <rdar://problem/11942016>

6:11 PM Changeset in webkit [125133] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

EventDispatcher::dispatchSimulatedClick should not reuse the same EventDispatcher instance.
https://bugs.webkit.org/show_bug.cgi?id=93452

Reviewed by Dimitri Glazkov.

This is a follow up patch after r124975. There is yet another
place where the same EventDispatcher instance is reused across
event dispatching.

In addition to that, in order to simulate a real click, we must
different dispatchers because we must recalculate event ancestors
each time. Current implementation wrongly freezes event ancestors
at the first event dispatching.

No new tests, no change in functionality.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:

(EventDispatcher):

6:10 PM Changeset in webkit [125132] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

writeHelperGetString in V8HTMLDocument uses += to concatenate strings
https://bugs.webkit.org/show_bug.cgi?id=93035

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-08-08
Reviewed by Adam Barth.

Use a StringBuilder instead of String concatenation because StringBuilder is generally faster.

No new functionality, so no new tests.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::writeHelperGetString):

6:07 PM Changeset in webkit [125131] by dpranke@chromium.org
  • 2 edits
    1 move in trunk/Tools

nrwt: rename finder.py to layout_test_finder.py
https://bugs.webkit.org/show_bug.cgi?id=93557

Reviewed by Ryosuke Niwa.

One last cleanup per old review feedback from rniwa.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.

(LayoutTestFinder):
(LayoutTestFinder.init):
(LayoutTestFinder.find_tests):
(LayoutTestFinder._strip_test_dir_prefixes):
(LayoutTestFinder._strip_test_dir_prefix):
(LayoutTestFinder._read_test_names_from_file):
(LayoutTestFinder._strip_comments):
(LayoutTestFinder.skip_tests):
(LayoutTestFinder.split_into_chunks):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
6:04 PM Changeset in webkit [125130] by enne@google.com
  • 8 edits in trunk/Source

[chromium] Move scrollbar pointer into WebScrollbarThemePainter
https://bugs.webkit.org/show_bug.cgi?id=93541

Reviewed by James Robinson.

Source/Platform:

Update WebScrollbarThemePainter to encapsulate a pointer to the
scrollbar as well. Lion scrollbars and RenderScrollbars are both
incompatible with wrapping a scrollbar in a WebScrollbar.

ScrollbarTheme(Chromium)Mac attaches extra data to a scrollbar based
on the pointer value (via a static map keyed on the pointer) so
passing an object that returns all the same values for the
ScrollbarThemeClient interface but has a different pointer will fail
to paint.

RenderScrollbar does static casts on the ScrollbarThemeClient pointer
that it is passed, assuming that it is the same. Therefore, it also
cannot use a WebScrollbar.

To fix this, push the real scrollbar pointer into the painter.

  • chromium/public/WebScrollbarThemePainter.h:

(WebCore):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
(WebScrollbarThemePainter):

Source/WebCore:

Update clients of WebScrollbarThemePainter.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

Source/WebKit/chromium:

Fix WebScrollbarThemePainter implementation to make direct calls on
the scrollbar rather than through the WebScrollbarThemeClientImpl
adapter.

  • src/WebScrollbarThemePainter.cpp:

(WebKit::WebScrollbarThemePainter::assign):
(WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
(WebKit::WebScrollbarThemePainter::paintTrackBackground):
(WebKit::WebScrollbarThemePainter::paintBackTrackPart):
(WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
(WebKit::WebScrollbarThemePainter::paintBackButtonStart):
(WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
(WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
(WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
(WebKit::WebScrollbarThemePainter::paintTickmarks):
(WebKit::WebScrollbarThemePainter::paintThumb):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

6:02 PM Changeset in webkit [125129] by Lucas Forschler
  • 4 edits
    13 copies in branches/safari-536.26-branch

Merged r120096.

5:56 PM Changeset in webkit [125128] by Alexandru Chiculita
  • 5 edits
    3 adds in trunk

[CSS Shaders] Invalid shaders should act as pass-through filters
https://bugs.webkit.org/show_bug.cgi?id=93405

Reviewed by Dean Jackson.

Source/WebCore:

If the shader fails to apply then clearShaderResult will just copy the result of the previous filter
to the output of the current filter.

Test: css3/filters/custom/invalid-custom-filter-shader.html

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::platformApplySoftware):
(WebCore):
(WebCore::FECustomFilter::clearShaderResult):
(WebCore::FECustomFilter::applyShader):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

  • rendering/style/StyleCustomFilterProgram.h: The test was exposing the fact that if the shaders were referencing the same

file then StyleCustomFilterProgram will never complete the load. Having the same file for both the vertex and the fragment shader
cannot really work, because the shaders would not compile anyway, thus triggering an invalid shader.
I'm fixing it part of this change because the current test actually exposes that on Safari Mac builds. See the note in the LayoutTest/ChangeLog.
(WebCore::StyleCustomFilterProgram::notifyFinished):

LayoutTests:

Note that invalid-custom-filter-shader-expected.html is actually using another builtin filter,
just to make sure we trigger the whole FilterEffectRenderer on the images, otherwise the result will be
slightly different because of the conversion errors. Having another filter like grayscale(0) will trigger
the same precission errors on the result of the expected html.

  • css3/filters/custom/invalid-custom-filter-shader-expected.html: Added.
  • css3/filters/custom/invalid-custom-filter-shader.html: Added.
  • css3/filters/resources/invalid-shader.vs: Added.
5:52 PM Changeset in webkit [125127] by Lucas Forschler
  • 13 edits
    3 copies in branches/safari-536.26-branch

Merged r123936. <rdar://problem/11979239>

5:41 PM Changeset in webkit [125126] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Rewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=93382

Reviewed by Eric Seidel.

This patch rewires the same-origin policy checks in the JavaScriptCore
bindings to use the implementation in BindingSecurity.cpp, which is now
shared by JavaScriptCore and V8. There are still a few places were we
use the JSDOMWindowCustom-based code path, but I plan to change those
in a follow up patch in the interest of keeping this patch as small as
possible.

This patch as two main benefits:

1) We no longer need to maintain duplicate code in the JSC and the V8

bindings for as delicate an area as the same-origin check.
Previously, the two implementations accomplished the same task using
a slightly different mechansim. After this patch, they use the same
mechanism, which means we only need to convince ourselves that one
implementation is correct.

2) This patch will make it easier to remove DOMWindow::m_securityOrigin

because there will be only one piece of code that needs to change.
Prior to this patch, we would have had to change both
implementations of the same-origin policy not to rely upon
DOMWindow::m_securityOrigin.

  • bindings/js/BindingState.cpp:

(WebCore::immediatelyReportUnsafeAccessTo):
(WebCore):

  • bindings/js/BindingState.h:

(WebCore):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToNode):
(WebCore::shouldAllowAccessToFrame):

5:40 PM Changeset in webkit [125125] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8
https://bugs.webkit.org/show_bug.cgi?id=93535

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-08-08
Reviewed by Dimitri Glazkov.

This enables putting two fingers on the track pad to show overlay scroll bars on 10.8+.

  • src/mac/WebInputEventFactory.mm:

(WebKit::phaseForNSEventPhase):

5:34 PM Changeset in webkit [125124] by beidson@apple.com
  • 3 edits
    3 adds in trunk

Google search query text reverts to original search query after multiple searches
<rdar://problem/10800686> and https://bugs.webkit.org/show_bug.cgi?id=93544

Reviewed by Darin Adler.

Source/WebCore:

For security sensitive fields we normally clear "autocomplete=off" form elements when
restoring a page from the page cache.

If the element is textual and has a defaultValue then "clearing" it actually restores
the default value.

There's no scenario we can imagine where that makes sense so we should not reset the
value in such fields.

Test: fast/forms/autocomplete-off-with-default-value-does-not-clear.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute): Update suspension callback registration as needed.
(WebCore::HTMLInputElement::needsSuspensionCallback): Don't reset text fields with a non-empty default value.

LayoutTests:

  • fast/forms/autocomplete-off-with-default-value-does-not-clear-expected.txt: Added.
  • fast/forms/autocomplete-off-with-default-value-does-not-clear.html: Added.
  • fast/forms/resources/go-back.html: Added.
5:19 PM Changeset in webkit [125123] by rniwa@webkit.org
  • 11 edits
    2 adds in trunk/Tools

Add Perf EWS IRC bot
https://bugs.webkit.org/show_bug.cgi?id=92913

Reviewed by Dirk Pranke.

Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
based on IRC requests.

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.head_svn_revision): The actual implementation returns string, so match that.
(MockSCM.svn_revision): Ditto.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.add_attachment_to_bug): Added mimetype.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.add_attachment_to_bug): Ditto.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.copytree): Added.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.copytree): Added.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests

that had assumed revision numbers were integers.
(test_run_with_json_output):
(test_run_with_description):
(test_run_generates_json_by_default):
(test_run_generates_and_show_results_page):
(test_run_with_json_source):
(test_run_with_multiple_repositories):

  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/perfalizer.py: Added.

(PerfalizerTask):
(PerfalizerTask.init):
(PerfalizerTask._copy_build_product_without_patch):
(PerfalizerTask.run):
(PerfalizerTask.parent_command):
(PerfalizerTask.run_webkit_patch):
(PerfalizerTask._json_path):
(PerfalizerTask._results_page_path):
(PerfalizerTask._run_perf_test):
(PerfalizerTask.run_command):
(PerfalizerTask.command_passed):
(PerfalizerTask.command_failed):
(PerfalizerTask.refetch_patch):
(PerfalizerTask.expected_failures):
(PerfalizerTask.build_style):
(PerfTest): IRC command.
(PerfTest.execute):
(Perfalizer): IRC bot.
(Perfalizer.begin_work_queue):
(Perfalizer.work_item_log_path):
(Perfalizer._is_old_failure):
(Perfalizer.next_work_item):
(Perfalizer.process_work_item):
(Perfalizer.handle_unexpected_error):
(Perfalizer.handle_script_error):

  • Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.

(PerfalizerTaskTest):
(PerfalizerTaskTest._create_and_run_perfalizer):
(PerfalizerTaskTest._create_and_run_perfalizer.logger):
(PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
(PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
(PerfalizerTaskTest.test_run):
(PerfalizerTaskTest.test_run_with_clean_fails):
(PerfalizerTaskTest.test_run_with_update_fails):
(PerfalizerTaskTest.test_run_with_build_fails):
(PerfalizerTaskTest.test_run_with_perf_test_fails):
(PerfalizerTaskTest.test_run_without_results_page):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.

  • Scripts/webkitpy/tool/commands/upload_unittest.py:

(test_attach_to_bug): Ditto.
(test_attach_to_bug_no_description_or_comment): Ditto.

5:18 PM Changeset in webkit [125122] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Creating "basic waveform" Oscillator nodes is not efficient
https://bugs.webkit.org/show_bug.cgi?id=93194

Patch by Raymond Toy <Raymond Toy> on 2012-08-08
Reviewed by Chris Rogers.

Source/WebCore:

Cache the wavetables for the basic types so they don't have to be
recomputed every time.

Also fix a bug where oscillator type was always set to CUSTOM
instead of the specified oscillator type. Test added for this.

Test: webaudio/oscillator-basic.html

  • Modules/webaudio/Oscillator.cpp:

(WebCore):
(WebCore::Oscillator::setType): Use cached wavetables; fix bug in
setting the oscillator type.

  • Modules/webaudio/Oscillator.h:

(Oscillator): Define static variables to hold cached wavetables.

LayoutTests:

Add test to verify that the returned oscillator type is the same
as what was set.

  • webaudio/oscillator-basic-expected.txt: Added.
  • webaudio/oscillator-basic.html: Added.
5:18 PM Changeset in webkit [125121] by commit-queue@webkit.org
  • 2 edits in trunk

[BlackBerry] Fix "-fPIC" define in the BlackBerry build
https://bugs.webkit.org/show_bug.cgi?id=93548

Patch by Ming Xie <mxie@rim.com> on 2012-08-08
Reviewed by Rob Buis.

In the current CMake release (version 2.8.5), ${CMAKE_SHARED
_LIBRARY_C_FLAGS} and ${CMAKE_SHARED_LIBRARY_CXX_FLAGS} is
set to empty (See cmake/Modules/Platform/QNX.cmake)

This breaks the assumption which WebKit CMake build system
makes in Source/cmake/WebKitHelper.cmake

  • Source/cmake/OptionsBlackBerry.cmake:
5:16 PM Changeset in webkit [125120] by tsepez@chromium.org
  • 8 edits
    3 adds in trunk

Avoid ASSERT(m_workerContext->isSharedWorkerContext()) in WorkerScriptController::initScript()
https://bugs.webkit.org/show_bug.cgi?id=93521

Reviewed by Adam Barth.

Source/WebCore:

Changes WorkerContext and its subclasses so that we do not call functions that rely upon subclass
virtual methods from the superclass constructor.

Test: http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html

  • workers/DedicatedWorkerContext.cpp:

(WebCore):
(WebCore::DedicatedWorkerContext::create):
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):

  • workers/DedicatedWorkerContext.h:

(DedicatedWorkerContext):

  • workers/SharedWorkerContext.cpp:

(WebCore):
(WebCore::SharedWorkerContext::create):
(WebCore::SharedWorkerContext::SharedWorkerContext):

  • workers/SharedWorkerContext.h:

(SharedWorkerContext):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::WorkerContext):
(WebCore::WorkerContext::applyContentSecurityPolicyFromString):
(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/resources/worker-set-timeout.js: Added.
  • http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html: Added.
5:01 PM Changeset in webkit [125119] by dino@apple.com
  • 2 edits in trunk/LayoutTests

(r124484) inspector/device-orientation-success.html failing on Mac ports
https://bugs.webkit.org/show_bug.cgi?id=93552

Unreviewed test expectations update. inspector/device-orientation-success.html missing console output.

  • platform/mac/TestExpectations:
4:59 PM Changeset in webkit [125118] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

CanvasRenderContext2D::setFont() should ignore inherited properties and default keyword value
https://bugs.webkit.org/show_bug.cgi?id=93491

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Treat "inherit" as an invalid value. Also ignore the "default"
keyword that was previously treated as a font family. This second
change was done in the property validation and will also affect the
CSS font parsing, but it is probably harmless since font doesn't
recognize the default keyword anyway.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFamily):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

Unskipped tests that are now passing after this fix and removed wrong
expectations.

  • platform/chromium/TestExpectations:
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Removed.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Removed.
  • platform/qt/Skipped:
4:59 PM Changeset in webkit [125117] by jamesr@google.com
  • 8 edits in trunk/Source/WebKit/chromium

[chromium] Fix up includes and types in chromium compositor unit tests
https://bugs.webkit.org/show_bug.cgi?id=93553

Reviewed by Adrienne Walker.

This removes some unused GraphicsContext3DPrivate.h includes and adds some includes that were being implicitely
depending upon - mostly for wtf/PassOwnPtr.h.

  • tests/CCLayerTreeHostTest.cpp:

(::CCLayerTreeHostTestCommit::beginTest):
(::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):

  • tests/CCRenderSurfaceFiltersTest.cpp:
  • tests/CompositorFakeWebGraphicsContext3D.h:
  • tests/FakeGraphicsContext3DTest.cpp:
  • tests/FakeWebScrollbarThemeGeometry.h:
  • tests/TextureCopierTest.cpp:
  • tests/ThrottledTextureUploaderTest.cpp:
4:56 PM Changeset in webkit [125116] by jamesr@google.com
  • 7 edits in trunk/Source/WebCore

[chromium] Add missing OVERRIDE and virtual annotations in compositor
https://bugs.webkit.org/show_bug.cgi?id=93438

Reviewed by Adrienne Walker.

As the title suggests.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/SolidColorLayerChromium.h:

(SolidColorLayerChromium):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

4:55 PM Changeset in webkit [125115] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkit-patch rebaseline-expectations needs to support multiple expectations files
https://bugs.webkit.org/show_bug.cgi?id=89051

Reviewed by Adam Barth.

fixed the bug described above, added unit test in
test_expectations_unittest, and updated the tool tests
to not contain all of the "missing skia expectations" warnings.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.remove_rebaselined_tests):
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RebaseliningTest.assertRemove):
(RebaseliningTest.test_remove):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations._update_expectations_files):
(RebaselineExpectations.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_expectations):

4:50 PM Changeset in webkit [125114] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Refactor tile flags.
https://bugs.webkit.org/show_bug.cgi?id=93059

Patch by Eric Penner <epenner@google.com> on 2012-08-08
Reviewed by Adrienne Walker.

Source/WebCore:

This has become a general refactoring patch to make updateTiles easier
to work with. The 'updated' flag had become convoluted and incorrect
and the function had lots of special cases piled into it which
makes for tangled depedancies that are hard to reason with.

This refactors the updated flag into two flags ('validForFrame',
and 'occluded') for the two purposes it is actually used for,
simplifies the use of those flags.

'validForFrame' is improved to work for all tiles that are not dirty
before painting begins, rather than just the tiles that get touched via
updateTiles().

This refactors updateTiles() into several functions that more clearly
illustrate all the depedancies that have accumulated in there. After
doing that I managed to separate the occlusion pass from the painting
passes, ecapsulating the difficult dependancies in one documented
function 'markOcclusionsAndRequestTextures'.

Now update tiles doesn't need the 'idle' flag, and returns didPaint
as an out-param. The last remaining wierd output is m_failedPaint
which is needed in place of m_skipsIdlePaint to prevent infinite
paints from being requested.

As a last step I was going to merge LayerChromium::update() and
LayerChromium::needsMoreUpdates() by having update() just return
a boolean, but this proved to be a big change so I'm holding off
on that. That would let us remove the m_failedPaint and get rid
of needsIdlePaint() altogether.

Tested by many existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

Source/WebKit/chromium:

Minor fixes to existing tests.

  • tests/TiledLayerChromiumTest.cpp:
4:47 PM Changeset in webkit [125113] by ap@apple.com
  • 4 edits in trunk/Tools

[WK2] MiniBrowser crashes on quit if any windows were previously closed
https://bugs.webkit.org/show_bug.cgi?id=93529

Reviewed by John Sullivan.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]): (-[BrowserAppDelegate newWindow:]): (-[BrowserAppDelegate browserWindowWillClose:]): (-[BrowserAppDelegate applicationWillTerminate:]): (-[BrowserAppDelegate frontmostBrowserWindowController]): Track browser windows explicitly, not relying on [NSApp windows]. Closed windows are not automatically removed from the list until deallocated, so a refcounting error can result in working on a closed window.
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here. Releasing data members is -dealloc's job. (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that the window is no longer open. Autorelease self, making sure that WKView and then WebPageProxy get released. (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef. WKView is responsible for its lifetime. (closePage): Ditto.
4:42 PM Changeset in webkit [125112] by Lucas Forschler
  • 3 edits in branches/safari-536.26-branch/Source/WebCore

Merged r120328. <rdar://problem/12050720>

4:39 PM Changeset in webkit [125111] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

css3/calc/transitions-dependent.html was causing css3/calc/transitions.html to fail
https://bugs.webkit.org/show_bug.cgi?id=93515

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-08
Reviewed by Tim Horton.

The transitions-dependent.html test was causing the transitions.html test to fail.
This was a result of a timeout callback set in the first test that was only being fired
in the second test because the first test did not use waitUntilDone/notifyDone.
The second test printed out an extra TypeError: 'undefined' error message because the callback
was defined in the first test and was thus 'undefined' by the time it was called while the second test
was running.

In addition, the test contained the following line:
window.addEventListener("load", function() { waitForAnimationStart(runTest(expectedValues)); }, false);
which does not work as intended because the parameter to waitForAnimationStart should have been a function
that calls runTest, not the call to the runTest function itself, which calls the method immediately.

  • css3/calc/transitions-dependent.html:

Added waitUntilDone/notifyDone.
Fixed function parameter.

4:37 PM Changeset in webkit [125110] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r119740. <rdar://problem/12050720>

4:36 PM Changeset in webkit [125109] by fmalita@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening: Chromium results for compositing/repaint/newly-composited-on-scroll.html.

  • platform/chromium-mac/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
  • platform/chromium-win/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
4:27 PM Changeset in webkit [125108] by jamesr@google.com
  • 20 edits in trunk/Source/WebKit/chromium

[chromium] Clean up WebKit.h and WebKitPlatformSupport.h includes in chromium/src
https://bugs.webkit.org/show_bug.cgi?id=93539

Reviewed by Adam Barth.

Most of these files don't need either WebKit.h or WebKitPlatformSupport.h. Some need <public/Platform.h>, and
some are relying on the forwarding headers. This updates includes to what is actually needed and points platform
includes at <public/Foo.h> instead of "platform/Foo.h" where possible.

  • src/ApplicationCacheHostInternal.h:
  • src/AssociatedURLLoader.cpp:
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):

  • src/BlobRegistryProxy.cpp:
  • src/ChromiumCurrentTime.cpp:
  • src/ChromiumOSRandomSource.cpp:
  • src/ChromiumThreading.cpp:
  • src/EditorClientImpl.cpp:
  • src/FrameLoaderClientImpl.cpp:
  • src/IDBFactoryBackendProxy.cpp:
  • src/LocalizedStrings.cpp:
  • src/PlatformMessagePortChannel.cpp:
  • src/WebCompositorInputHandlerImpl.cpp:
  • src/WebMediaPlayerClientImpl.cpp:
  • src/WebPluginContainerImpl.cpp:
  • src/WebViewImpl.cpp:
  • src/WebWorkerClientImpl.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerFileWriterCallbacksBridge.cpp:
4:23 PM Changeset in webkit [125107] by Lucas Forschler
  • 3 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124811. <rdar://problem/12049461>

4:19 PM Changeset in webkit [125106] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening: compositing/plugins/no-backing-store.html yields incorrect results.

  • platform/chromium/TestExpectations:
4:14 PM Changeset in webkit [125105] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124102. <rdar://problem/11992689>

4:09 PM Changeset in webkit [125104] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=93393
Overflow regions sometimes repaint incorrectly after going into or
coming out of compositing mode
-and corresponding-
<rdar://problem/12006463>

Reviewed by Simon Fraser.

My first patch to fix this bug removed an if (parent()) check that is
needed to prevent a table crash seen in
fast/table/table-row-compositing-repaint-crash.html
The parent() check was actually added originally to prevent this same
crash. See http://trac.webkit.org/changeset/110456
This patch adds that check back, but really we should delay the
computation of repaint rects if layout has not happened yet.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

3:40 PM Changeset in webkit [125103] by dino@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r124416): fast/forms/basic-selects.html failing on Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=93538

Unreviewed test expectations update after regression from r124416 on Mac ports.

  • platform/mac/TestExpectations:
3:28 PM Changeset in webkit [125102] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

Avoid backing store on layers created for CoreAnimation plugins
https://bugs.webkit.org/show_bug.cgi?id=93526
<rdar://problem/12052828>

Patch by Simon Fraser <Simon Fraser> on 2012-08-08
Reviewed by Dean Jackson.

Test for backing store on CoreAnimation-based plugins in various
configurations.

  • compositing/plugins/no-backing-store-expected.txt: Added.
  • compositing/plugins/no-backing-store.html: Added.
3:17 PM Changeset in webkit [125101] by Simon Fraser
  • 3 edits
    2 adds in trunk

Avoid backing store on layers created for CoreAnimation plugins
https://bugs.webkit.org/show_bug.cgi?id=93526
<rdar://problem/12052828>

Reviewed by Dean Jackson.

Source/WebCore:

We create a compositing layer for <embed> objects whose plug-in supports
the CoreAnimation rendering model. When the embed's renderer is not styled,
we can avoid allocating backing store for it.

Test: compositing/plugins/no-backing-store.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::isCompositedPlugin):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

LayoutTests:

Test for backing store on CoreAnimation-based plugins in various
configurations.

  • compositing/plugins/no-backing-store-expected.txt: Added.
  • compositing/plugins/no-backing-store.html: Added.
3:16 PM Changeset in webkit [125100] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION: Crash when plug-in initialization fails
https://bugs.webkit.org/show_bug.cgi?id=93534
<rdar://problem/12059786>

Reviewed by Simon Fraser.

Protect the PluginProxy while calling out to functions that could cause it to be destroyed.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::didFailToCreatePluginInternal):

3:13 PM Changeset in webkit [125099] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[Chromium] Updating fast/canvas/webgl/gl-teximage.html to prevent valid variations in results from causing test failures.
https://bugs.webkit.org/show_bug.cgi?id=89494

Patch by Jeff Timanus <twiz@chromium.org> on 2012-08-08
Reviewed by Adrienne Walker.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html: Only display the actual percentage of passing pixels when outside of DRT.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
3:12 PM Changeset in webkit [125098] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Make isTransparentSilverlightBackgroundValue handle all the possible transparent colors
https://bugs.webkit.org/show_bug.cgi?id=93532

Reviewed by Simon Fraser.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::isTransparentSilverlightBackgroundValue):
Check for all the possible transparent colors and assume that the color is opaque otherwise.

(WebKit::NetscapePlugin::initialize):
Pass the lowercase string to isTransparentSilverlightBackgroundValue.

3:10 PM Changeset in webkit [125097] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html
https://bugs.webkit.org/show_bug.cgi?id=92904

Unreviewed test expectations update. The IMAGE test was passing on Lion and Mountain Lion.

  • platform/mac/TestExpectations:
3:05 PM CoordinatedGraphicsSystem edited by noam.rosenthal@nokia.com
(diff)
3:05 PM Changeset in webkit [125096] by Lucas Forschler
  • 5 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r125081. <rdar://problem/12059544>

2:57 PM Changeset in webkit [125095] by jamesr@google.com
  • 16 edits in trunk/Source/WebKit/chromium

[chromium] Clean up includes in compositor unit tests
https://bugs.webkit.org/show_bug.cgi?id=93531

Reviewed by Adrienne Walker.

This removes unused includes and updates Platform API headers to use the <public/Web...> style paths.

  • tests/CCAnimationTestCommon.cpp:
  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/CCOcclusionTrackerTest.cpp:
  • tests/CCTextureUpdateControllerTest.cpp:
  • tests/CCThreadedTest.cpp:
  • tests/FakeWebGraphicsContext3D.h:
  • tests/LayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/WebCompositorInputHandlerImplTest.cpp:
  • tests/WebLayerTest.cpp:
  • tests/WebLayerTreeViewTest.cpp:
2:56 PM Changeset in webkit [125094] by wangxianzhu@chromium.org
  • 4 edits in trunk

[Chromium-Android] Apply all Linux layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=92653

Reviewed by Adam Barth.

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.

LayoutTests:

We used to let chromium_android.py replace all 'LINUX' to 'LINUX ANDROID' in test expectations on Android to automatically inherit all test expectations of chromium-linux.
As a step of upstreaming chromium-android, now we actually update TestExpectations.

In this change, 'LINUX's are replaced to 'LINUX ANDROID', *except* those:
1) already have 'ANDROID',
2) not applicable or not to be tested on Android, e.g. plugins, inspector, non-virtual gpu tests, etc. Instead we add SKIP rules for them.

  • platform/chromium/TestExpectations:
2:54 PM Changeset in webkit [125093] by dino@apple.com
  • 2 edits in trunk/LayoutTests

css3/flexbox/content-height-with-scrollbars.html failing image test on Lion and MountainLion
https://bugs.webkit.org/show_bug.cgi?id=93530

Unreviewed test expectations update.

  • platform/mac/TestExpectations:
2:52 PM Changeset in webkit [125092] by arv@chromium.org
  • 5 edits
    2 adds in trunk

DOM4: classList should be defined on Element and not on HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=93015

Reviewed by Adam Barth.

DOM4 specs that Element should have the classList WebIDL attribute. This moves the
attribute to the correct IDL file.

Source/WebCore:

Test: fast/dom/Element/class-list.html

  • dom/Element.idl:
  • html/HTMLElement.idl:

LayoutTests:

  • fast/dom/Element/class-list-expected.txt: Added.
  • fast/dom/Element/class-list.html: Added.
2:49 PM Changeset in webkit [125091] by Beth Dakin
  • 12 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=92275
Need a way to get a snapshot image that does not show the selection
-and corresponding-
<rdar://problem/11956802>

Reviewed by Anders Carlsson.

../WebCore:

New function FrameView::paintContentsForSnapshot() has the option to
exclude selection from the snapshot.

Export new function

  • WebCore.exp.in:

Clear the selection from the RenderView when selection is to be excluded. Restore
all of this information via FrameSelection::updateAppearance() after calling
paintContents().

  • page/FrameView.cpp:

(WebCore::FrameView::paintContentsForSnapshot):
(WebCore):

  • page/FrameView.h:

../WebKit2:

Added new API WKBundlePageCreateSnapshotWithOptions()

New enum SnapshotOptions tracks whether snapshots should exclude
selection highlighting in addition to tracking whether the image is
sharable like the original ImageOptions.

  • Shared/API/c/WKImage.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::snapshotOptionsFromImageOptions):
(WebKit):
(WebKit::toSnapshotOptions):

  • Shared/ImageOptions.h:

New API.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotWithOptions):

These existing APIs all now call
WebPage::scaledSnapshotWithOptions().
(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):
(WKBundlePageCreateScaledSnapshotInDocumentCoordinates):

This patch removes WebPage::snapshotInViewCoordinates(),
WebPage::snapshotInDocumentCoordinates(), and
WebPage::scaledSnapshotInDocumentCoordinates(). All of the logic is
now consolidated into WebPage::scaledSnapshotWithOptions(). It turns
out that we never did anything different for document coordinates
versus view coordinates, so that complexity could just be eliminated
outright.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::snapshotOptionsToImageOptions):
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

2:48 PM Changeset in webkit [125090] by benjamin@webkit.org
  • 2 edits in trunk/PerformanceTests

Calling internals from the performance test runner prevents manual running
https://bugs.webkit.org/show_bug.cgi?id=93527

Reviewed by Ryosuke Niwa.

Since r125065, it is impossible to run the Performance tests manually. The problem is
"internals" is not defined when running outside the test runner, so the whole script
evaluation fails.

  • resources/runner.js: Verify is window.internals is available before invoking something on it.
2:19 PM Changeset in webkit [125089] by Lucas Forschler
  • 4 edits in branches/safari-536.25-branch/Source

Versioning.

2:17 PM Changeset in webkit [125088] by jamesr@google.com
  • 16 edits in trunk/Source

[chromium] Only use public Platform API in NonCompositedContentHost
https://bugs.webkit.org/show_bug.cgi?id=93423

Reviewed by Adrienne Walker.

Source/Platform:

Adds setters to control text antialiasing and checkerboarding behavior for content layers.

  • chromium/public/WebContentLayer.h:

(WebContentLayer):

Source/WebCore:

This renames the "NonCompositedContentHost" flag to "useLCDText", which is the primary purpose of the flag. We
also use this flag to control whether we have border texels or not on the "root" layer, but I can't think of a
clean name that encapsulates both behaviors.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setUseLCDText):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::useLCDText):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setUseLCDText):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setUseLCDText):
(WebCore::CCLayerImpl::useLCDText):
(CCLayerImpl):

Source/WebKit/chromium:

Switches to using Web*Layer APIs in NonCompositedContentHost instead of reaching in to the LayerChromium and
updates unit tests for the nonCompositedContent->useLCDText flag rename.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::setUseLCDText):
(WebKit):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):

  • src/WebViewImpl.cpp:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerChromiumTest.cpp:
2:15 PM Changeset in webkit [125087] by Lucas Forschler
  • 5 edits in branches/safari-536.25-branch/Source/WebKit2

Merged r125081 -> <rdar://problem/12056765>

2:09 PM Changeset in webkit [125086] by Beth Dakin
  • 5 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=93393
Overflow regions sometimes repaint incorrectly after going into or
coming out of compositing mode
-and corresponding-
<rdar://problem/12006463>

Reviewed by Simon Fraser.

Source/WebCore:

New RenderLayer function computeRepaintRectsIncludingDescendants()

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::computeRepaintRectsIncludingDescendants):

  • rendering/RenderLayer.h:

(RenderLayer):

It is not sufficient to compute repaint rects just for the current
layer when compositing changes. They must be recomputed for all
descendant layers as well.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

LayoutTests:

  • compositing/repaint/newly-composited-on-scroll.html: Added.
  • platform/mac/compositing/repaint/newly-composited-on-scroll-expected.png: Added.
  • platform/mac/compositing/repaint/newly-composited-on-scroll-expected.txt: Added.
2:08 PM Changeset in webkit [125085] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r124710-r124713): media/video-seek-past-end-paused.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93394

Unreviewed. Adding the correct results for failing tests on Mac.

  • platform/mac/media/video-seek-past-end-paused-expected.txt:
2:04 PM Changeset in webkit [125084] by commit-queue@webkit.org
  • 6 edits in trunk/Source

IndexedDB: new enums and openCursor stub
https://bugs.webkit.org/show_bug.cgi?id=93410

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-08
Reviewed by Adam Barth.

Source/WebCore:

Introduce a new TaskType enum that will be used to prioritize
internal tasks. This is preliminary staging for
https://bugs.webkit.org/show_bug.cgi?id=91125.

No new tests, coming in bug 91125.

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

This stubs out the TaskType and Direction enums that will be
required to land the chromium side of
https://bugs.webkit.org/show_bug.cgi?id=91125.

  • public/WebIDBCursor.h:
  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::setIndexKeys):
(WebKit::WebIDBObjectStore::setIndexesReady):
(WebIDBObjectStore):
(WebKit::WebIDBObjectStore::openCursor):

  • public/WebIDBTransaction.h:
2:02 PM Changeset in webkit [125083] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Implement about:memory-live
https://bugs.webkit.org/show_bug.cgi?id=93153

Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>

Implementing about:memory-live to track memory peaks:

  • about:memory-live/start: start tracking memory peaks.
  • about:memory-live: show memory peaks every 30ms.
  • about:memory-live/stop: stop tracking and show memory peaks.

Mainly track the following memory peaks:

  • Total used memory (malloc + JSC).
  • Total committed memory.
  • Total mapped memory.

Add total committed memory for about:memory

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::memoryPage):
(WebKit):
(MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::isActive):
(BlackBerry::WebKit::MemoryTracker::clear):
(BlackBerry::WebKit::MemoryTracker::peakTotalUsedMemory):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemory):
(BlackBerry::WebKit::MemoryTracker::peakTotalMappedMemory):
(BlackBerry::WebKit::MemoryTracker::MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::instance):
(BlackBerry::WebKit::MemoryTracker::start):
(BlackBerry::WebKit::MemoryTracker::stop):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
(BlackBerry::WebKit::memoryLivePage):
(BlackBerry::WebKit::aboutData):

1:49 PM Changeset in webkit [125082] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add MountainLion WebKit Bots.
https://bugs.webkit.org/show_bug.cgi?id=93417

Patch by Josh Hawn <jhawn@apple.com> on 2012-08-08
Reviewed by Stephanie Lewis.

Mountain Lion is now available, so we've added the appropriate Apple bots,
mirroring the configuration of the Lion bots.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

Added 10 "apple-mini-###" slaves.
Added MountainLion Builders and Schedulers.

1:33 PM Changeset in webkit [125081] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Make the Silverlight CAOpenGLLayer opaque if we know the plug-in contents is opaque to reduce blending
https://bugs.webkit.org/show_bug.cgi?id=93508
<rdar://problem/12056765>

Reviewed by Simon Fraser.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/Plugins/PluginQuirks.h:

Rename the MakeTransparentIfBackgroundAttributeExists quirk to MakeOpaqueUnlessTransparentSilverlightBackgroundAttributeExists
since we'll explicitly check for opaque background colors (at least one opaque background color for now), instead of just making the
plug-in transparent whenever there's a background specified.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::isTransparentSilverlightBackgroundValue):
Helper function for determining if a background value is transparent. Just check for opaque black now and treat everything else as transparent.

(WebKit::NetscapePlugin::initialize):
Call isTransparentSilverlightBackgroundValue.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::makeCGLPresentLayerOpaque):
Helper function for grabbing the CGLPresentLayer from the layer hierarchy and setting it to be opaque.

(WebKit::NetscapePlugin::updatePluginLayer):
Call makeCGLPresentLayerOpaque if the plug-in has the MakeOpaqueUnlessTransparentSilverlightBackgroundAttributeExists quirk and
the plug-in is not transparent.

1:32 PM Changeset in webkit [125080] by Lucas Forschler
  • 1 copy in branches/safari-536.25-branch

New branch.

1:14 PM Changeset in webkit [125079] by pfeldman@chromium.org
  • 33 edits
    3 copies in trunk

REGRESSION(r125046): Breaks debug build (assertion in protocol type checks) (Requested by pfeldman on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=93505

Not reviewed: roll out.

Source/WebCore:

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:

(ConsoleMessage):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::wrapObject):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._printArray):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):

  • inspector/front-end/DOMExtension.js:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection):

  • inspector/front-end/PropertiesSection.js:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):

  • inspector/front-end/Section.js:
  • inspector/front-end/inspector.css:

(.console-group-messages .section .header .title):
(.section .properties .name, .event-properties .name):

LayoutTests:

  • inspector/console/command-line-api-inspect-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-eval-global.html:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-collections.html:
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • inspector/console/console-log-document-proto-expected.txt:
  • inspector/console/console-log-document-proto.html:
  • inspector/console/console-log-toString-object-expected.txt:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt:
  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-eval-global-expected.txt: Copied from LayoutTests/inspector/console/console-eval-global-expected.txt.
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/inspector/console/console-format-expected.txt: Copied from LayoutTests/inspector/console/console-format-expected.txt.
  • platform/chromium/inspector/console/console-log-document-proto-expected.txt:
  • platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt:
  • platform/chromium/inspector/elements/event-listener-sidebar-expected.txt: Copied from LayoutTests/inspector/elements/event-listener-sidebar-expected.txt.
1:13 PM Changeset in webkit [125078] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Enable occlusion tracker in the occlusion tests for surface cacheing
https://bugs.webkit.org/show_bug.cgi?id=93500

Reviewed by Adrienne Walker.

The occlusion tracker is not being used in these tests except to do
scissoring. We want to test occlusion with these occlusion tests,
and when scissoring is not part of occlusion tracker, these
tests would become useless otherwise.

  • tests/CCLayerTreeHostImplTest.cpp:
1:03 PM Changeset in webkit [125077] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Source

Crash when reloading a Chromium "platform" app
https://bugs.webkit.org/show_bug.cgi?id=93497

Reviewed by Eric Seidel.

Source/WebCore:

The framework for Chromium "platform" apps executes a big blob of
script during the didCreateScriptContext callback. This blob of scripts
interacts with a bunch of JavaScript objects and triggers a number of
security checks.

When reloading a frame, the didCreateScriptContext is called during
Frame::setDocument (as a consequence of calling
ScriptController::updateDocument). At that time, the SecurityOrigin
object hasn't yet been copied over to the DOMWindow, and we crash
trying to grab it.

The long-term fix for this bug is to fix
https://bugs.webkit.org/show_bug.cgi?id=75793, at which point there
will no longer be a SecurityOrigin object on DOMWindow. In the
meantime, however, we can fix this crash by null checking the
DOMWindow's SecurityOrigin object.

  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):

Source/WebKit/chromium:

Test that we don't crash when executing script during the
didCreateScriptContext callback.

  • tests/WebFrameTest.cpp:
  • tests/data/hello_world.html: Added.
12:59 PM WebInspector edited by dietass80@hotmail.com
(diff)
12:55 PM Changeset in webkit [125076] by commit-queue@webkit.org
  • 6 edits in trunk

[WK2] Coding style violation was brought with r125031
https://bugs.webkit.org/show_bug.cgi?id=93503

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-08
Reviewed by Alexey Proskuryakov.

WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.

Source/WebKit2:

  • Shared/API/c/WKURLResponse.cpp:

(WKURLResponseCopyMIMEType):

  • Shared/API/c/WKURLResponse.h:

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveResponseForResource):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.

12:39 PM Changeset in webkit [125075] by peter@chromium.org
  • 2 edits in trunk/Websites/planet.webkit.org

Remove several non-updated blogs from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=92973

Reviewed by Eric Seidel.

Adam Treat's blog was last updated in 2009.
Justin Haygood's blog was last updated in 2008.
Mike Smith seems to have moved to Google+ entirely.
Pierre-Luc Beaudoin's blog is unavailable, cached copy says the last (non-WebKit specific update) was in 2010.
Cameron Zwarich' summer of JSC no longer exists.
Anthony Ricaud's blog was last updated in 2009.

  • config.ini:
12:33 PM Changeset in webkit [125074] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Mac port after http://trac.webkit.org/changeset/125051

Add CachedImageClient.h to project.

  • WebCore.xcodeproj/project.pbxproj:
12:27 PM Changeset in webkit [125073] by Lucas Forschler
  • 4 edits in tags/Safari-536.26.4/Source

Versioning.

12:22 PM Changeset in webkit [125072] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.4

New Tag.

12:21 PM Changeset in webkit [125071] by tonikitoo@webkit.org
  • 7 edits
    1 copy
    2 moves in trunk/Source/WebKit

[BlackBerry] Tie up the scrolling machinery to the graphics tree when applicable for in-region scroll
https://bugs.webkit.org/show_bug.cgi?id=93482
PR #187672
Make InRegionScroller a simple public webkit/ API
PR #188677

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

In order to prepare InRegionScroller to be a public API
in webkit/, the patch:

1) Renamed the current InRegionScroller class to InRegionScrollerPrivate;
2) Moved InRegionScroller.cpp|h from WebKitSupport/ to Api/;
3) Renamed InRegionScroller.h to InRegionScroller_p.h;
4) Added a new public class implementation to InRegionScroller.h;
5) Adapted WebPage and TouchEventHandler classes to use InRegionScroller::d directly.

The most important API here is '::compositedSetScrollPosition'

It is a UI/Compositing thread method only and sets the associated LayerCompositingThread
(camouflaged as a unsigned) for each created InRegionScrollableArea that supports
composited scrolling.

The way ::compositedSetScrollPosition "scrolls" a layer is by setting the boundsOrigin
property to the LayerCompositingThread's 'override' property in the UI/Compositing thread.

  • PlatformBlackBerry.cmake: Build system adaptation.
  • Api/InRegionScroller.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.cpp.

(WebKit):
(BlackBerry::WebKit::InRegionScroller::InRegionScroller):
(BlackBerry::WebKit::InRegionScroller::~InRegionScroller):
(BlackBerry::WebKit::InRegionScroller::compositedSetScrollPosition):
(BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
(BlackBerry::WebKit::InRegionScrollerPrivate::setNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::node):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset):
(BlackBerry::WebKit::InRegionScrollerPrivate::hasNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScroll):
(BlackBerry::WebKit::InRegionScrollerPrivate::compositedSetScrollPosition):
(BlackBerry::WebKit::InRegionScrollerPrivate::scrollBy):
(BlackBerry::WebKit::InRegionScrollerPrivate::inRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::scrollNodeRecursively):
(BlackBerry::WebKit::InRegionScrollerPrivate::scrollRenderer):
(BlackBerry::WebKit::InRegionScrollerPrivate::adjustScrollDelta):
(BlackBerry::WebKit::canScrollInnerFrame):
(BlackBerry::WebKit::canScrollRenderBox):
(BlackBerry::WebKit::parentLayer):
(BlackBerry::WebKit::enclosingLayerNode):
(BlackBerry::WebKit::isNonRenderViewFixedPositionedContainer):
(BlackBerry::WebKit::pushBackInRegionScrollable):

  • Api/InRegionScroller.h: Copied from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.

(WebKit):
(InRegionScroller):

  • Api/InRegionScroller_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InRegionScroller.h.

(WebCore):
(WebKit):
(InRegionScrollerPrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::scrollBy):
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStatusChanged):
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::inRegionScroller):
(WebKit):

  • Api/WebPage.h:

(WebKit):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

12:20 PM Changeset in webkit [125070] by tonikitoo@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make WebOverlayPrivate::scheduleCompositingRun a WebPagePrivate method.
https://bugs.webkit.org/show_bug.cgi?id=93480
PR #188682

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

... this way it can be used by others.

No behavioural change. Another preparation patch.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):

  • Api/WebPage_p.h:

(WebPagePrivate):

12:20 PM Changeset in webkit [125069] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Add boundsOrigin accessors to LayerOverride
https://bugs.webkit.org/show_bug.cgi?id=93479
PR #188677

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

This is needed in order to allow us to directly set the boundsOrigin value
to the LayerCompositingThread and avoid it to get overridden by the respective
LayerWebKitThread's boundsOrigin value in the next commit.

No new tests, since this is another preparation PR.

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::updateAnimations):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerOverride::isBoundsOriginSet):
(WebCore::LayerOverride::boundsOrigin):
(WebCore::LayerOverride::setBoundsOrigin):
(LayerOverride):
(WebCore::LayerOverride::LayerOverride):

12:19 PM Changeset in webkit [125068] by tonikitoo@webkit.org
  • 7 edits in trunk/Source/WebCore

[BlackBerry] Propagate GraphicsLayer::boundsOrigin down to the platform layers
https://bugs.webkit.org/show_bug.cgi?id=93478
PR #188657

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

This property will be set from both WebKit and Compositing/UI
threads in order to fast scroll block elements.

No new tests, as it is a mid-step patch.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::setBoundsOrigin):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::updateBoundsOrigin):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::setBoundsOrigin):

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::boundsOrigin):
(LayerData):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::updateLayersRecursive):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::setBoundsOrigin):
(LayerWebKitThread):

12:14 PM Changeset in webkit [125067] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

Unreviewed, rolling out r124887.
http://trac.webkit.org/changeset/124887
https://bugs.webkit.org/show_bug.cgi?id=93504

Dependent API being removed. (Requested by mfenton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-08

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:
  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):
(WebKit):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

12:11 PM Changeset in webkit [125066] by peter@chromium.org
  • 3 edits in trunk/Tools

Buildmaster changes in preparation of a Chromium Android tester
https://bugs.webkit.org/show_bug.cgi?id=92251

Reviewed by Adam Barth.

Slightly update the build master's configuration in preparation of adding
a Chromium Android tester.

The change in built-product-archive is required as the out/ directory
for Android has a number of unstripped .so binaries and unaligned APKs,
causing the default release.zip file to be 2.7 gigabytes. By excluding
these file types, the file is only 59.7 megabytes. We can't disable
them for all of Chromium, as Mac and Linux do use their .so files.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ArchiveBuiltProduct): Pass the full platform name instead of just the

generic type, i.e. chromium-android instead of chromium.

(ExtractBuiltProduct): Dito, stay consistent for this script.
(RunUnitTests): Pass --chromium-android as well as --chromium. Since we

now read the full platform name, stay on the safe side with 'win'
even though there (as far as I know) is no win-* platform.

(RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed

at all, but we'll be needing different handling here.

(unitTestsSupported): Next to refactoring work required, as we'll be

running this test on a device, there is no reason to disable this
in the master's configuration.

  • BuildSlaveSupport/built-product-archive:

(main): Determine the generic platform.
(archiveBuiltProduct): Use an identical set of ignorePatterns, but

extend the list with .so, .pak and -unaligned.apk for Android.

12:09 PM Changeset in webkit [125065] by zoltan@webkit.org
  • 2 edits in trunk/PerformanceTests

Set access to MemoryInfo enabled for the performance tests
https://bugs.webkit.org/show_bug.cgi?id=92498

Reviewed by Ryosuke Niwa.

We need access to console.memory for the memory measurements.

  • resources/runner.js:
12:07 PM Changeset in webkit [125064] by fmalita@chromium.org
  • 5 edits
    3 deletes in trunk/LayoutTests

[chromium][win] Rebaseline css3/filters/custom tests
https://bugs.webkit.org/show_bug.cgi?id=93404

Unreviewed gardening: updating Chromium results after 125044.

  • platform/chromium-linux-x86/css3/filters/custom/effect-color-check-expected.png: Removed.
  • platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Removed.
  • platform/chromium-win-xp/css3/filters/custom/effect-color-check-expected.png: Removed.
  • platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium/TestExpectations:
11:55 AM Changeset in webkit [125063] by dino@apple.com
  • 1 edit in trunk/Source/WebCore/platform/mac/ClipboardMac.h

Another unreviewed build fix after http://trac.webkit.org/changeset/125051

11:54 AM Changeset in webkit [125062] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding expectations for three tests that are flaky crashers:

  • editing/inserting/insert-character-in-first-letter-crash.html
  • fast/history/nested-visited-test.html
  • fast/css/first-letter-text-fragment-crash.html
  • platform/gtk/TestExpectations:
11:52 AM Changeset in webkit [125061] by Nate Chapin
  • 5 edits
    4 adds in trunk/Source

[chromium] Upstream android's FlingAnimator
https://bugs.webkit.org/show_bug.cgi?id=92900

Reviewed by James Robinson.

No new tests yet, will be added once this code is called.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(WebKit::Platform::createFlingAnimator):

  • chromium/public/WebFlingAnimator.h: Added.

(WebKit):
(WebFlingAnimator):
(WebKit::WebFlingAnimator::~WebFlingAnimator):

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/support/PlatformGestureCurveFactory.cpp: Added.

(WebKit):
(WebKit::PlatformGestureCurveFactory::get):
(WebKit::PlatformGestureCurveFactory::createCurve):
(WebKit::PlatformGestureCurveFactory::setWebFlingAnimatorForTest):

  • platform/chromium/support/PlatformGestureCurveFactory.h: Added.

(WebKit):
(PlatformGestureCurveFactory):

  • platform/chromium/support/WebFlingAnimatorToGestureCurveAdapter.h: Added.

(WebKit):
(WebFlingAnimatorToGestureCurveAdapter):
(WebKit::WebFlingAnimatorToGestureCurveAdapter::create):
(WebKit::WebFlingAnimatorToGestureCurveAdapter::WebFlingAnimatorToGestureCurveAdapter):

11:50 AM Changeset in webkit [125060] by Lucas Forschler
  • 19 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124720. <rdar://problem/12035601>

11:38 AM Changeset in webkit [125059] by annacc@chromium.org
  • 18 edits
    1 move
    3 adds
    1 delete in trunk

Update HTMLMediaElement to the new OO MediaSource API.
https://bugs.webkit.org/show_bug.cgi?id=91775

Reviewed by Eric Carlson.

This patch rips out the old-style MediaSource API and allows a
MediaSource object to be attached to HTMLMediaElement.
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

Source/WebCore:

Tests: updates to http/tests/media/media-source/*

http/tests/media/media-source/video-media-source-add-and-remove-buffers.html
http/tests/media/media-source/video-media-source-objects.html

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove old style API resources.
(WebCore::HTMLMediaElement::parseAttribute): Remove old style event attribute.
(WebCore::HTMLMediaElement::prepareForLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::loadResource): Get MediaSource object from blob registry

look up and, if found, set it's MediaPlayer pointer to the current MediaPlayer.

(WebCore::HTMLMediaElement::noneSupported): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaEngineError): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened): Set source state to "open".
(WebCore::HTMLMediaElement::mediaPlayerSourceURL): Change to new blob URL.
(WebCore::HTMLMediaElement::seek): Check if source state is "closed".
(WebCore::HTMLMediaElement::setSourceState): Helper function so that we don't have to

keep checking for m_mediaSource.

(WebCore::HTMLMediaElement::userCancelledLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::createMediaPlayer): If the current MediaPlayer is re-

created, notify the MediaSource and reset its MediaPlayer.

  • html/HTMLMediaElement.h: Remove old style API code and add a MediaSource object.

(HTMLMediaElement):

  • html/HTMLMediaElement.idl: Remove old style API.

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceBuffer):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):

  • http/tests/media/media-source/video-media-source-abort-expected.txt:
  • http/tests/media/media-source/video-media-source-abort.html:
  • http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt.
  • http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Added.
  • http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Removed.
  • http/tests/media/media-source/video-media-source-errors-expected.txt:
  • http/tests/media/media-source/video-media-source-errors.html:
  • http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
  • http/tests/media/media-source/video-media-source-event-attributes.html:
  • http/tests/media/media-source/video-media-source-objects-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-objects.html: Added.
  • http/tests/media/media-source/video-media-source-play-expected.txt:
  • http/tests/media/media-source/video-media-source-play.html:
  • http/tests/media/media-source/video-media-source-seek-expected.txt:
  • http/tests/media/media-source/video-media-source-seek.html:
  • http/tests/media/media-source/video-media-source-state-changes-expected.txt:
  • http/tests/media/media-source/video-media-source-state-changes.html:
11:38 AM Changeset in webkit [125058] by abarth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Stop running tests on the mac-ews while we wait for more
hardware. As requested by lforschler.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
11:36 AM Changeset in webkit [125057] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Mac port after http://trac.webkit.org/changeset/125051

  • platform/mac/ClipboardMac.mm:
11:34 AM Changeset in webkit [125056] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Evolution, empathy no longer build with webkint 1.9.6: webkit_dom_html_element_set_class_name is gone
https://bugs.webkit.org/show_bug.cgi?id=93384

Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-08
Reviewed by Adam Barth.

Provide custom backwards compatibility wrappers for HTMLElement
className accessors, since the attribute was moved to Element. The
previous fix attempted to define the attribute twice (once in each
class), but this is wrong, just provide again the old accessors
making them forward to the new methods.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_element_get_class_name): provide again
get_class_name for backwards compatibility.
(webkit_dom_html_element_set_class_name): provide again
set_class_name for backwards compatibility.

  • bindings/gobject/WebKitDOMCustom.h: ditto.
  • html/HTMLElement.idl: remove the className attribute

definition. Since it's already present in Element this will break
our bindings.

11:29 AM Changeset in webkit [125055] by ojan@chromium.org
  • 6 edits
    6 adds in trunk

percentage height/width values in quirks mode are incorrectly resolved in flexbox children
https://bugs.webkit.org/show_bug.cgi?id=81809

Reviewed by Tony Chang.

Source/WebCore:

When computing percentage logical heights we need to use the RenderBox helper methods
to make sure we handle all the edge cases correctly (e.g. walk up the containing block
ancestor chain in quirks mode until we find a definite size).

For widths, the containing block always has a definite size, so all we need to do
is call computeContentBoxLogicalWidth(valueForLength(...)), although I'm not sure
this does the right thing for the intrinsic sizing keywords.

Tests: css3/flexbox/box-sizing-min-max-sizes.html

css3/flexbox/percentage-sizes-quirks.html
css3/flexbox/percentage-sizes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalClientHeight):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisSizeForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/box-sizing-min-max-sizes-expected.txt: Added.
  • css3/flexbox/box-sizing-min-max-sizes.html: Added.
  • css3/flexbox/percentage-sizes-expected.txt: Added.
  • css3/flexbox/percentage-sizes-quirks-expected.txt: Added.
  • css3/flexbox/percentage-sizes-quirks.html: Added.
  • css3/flexbox/percentage-sizes.html: Added.
11:18 AM Changeset in webkit [125054] by scherkus@chromium.org
  • 4 edits
    2 adds in trunk

Fire suspend event whenever network state is set to NETWORK_IDLE.
https://bugs.webkit.org/show_bug.cgi?id=93052

Reviewed by Eric Carlson.

There was a regression in the Chromium port (http://crbug.com/139511) that revealed we didn't
have a layout test for suspend events. Upon further investigation it appeared we also had a bug
where we didn't fire the suspend event when a media engine reported they had completely loaded
the media.

Covered by new test http/tests/media/video-load-suspend.html.

Source/WebCore:

  • html/HTMLMediaElement.cpp: Move firing of suspend event to changeNetworkStateFromLoadingToIdle

(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):

LayoutTests:

  • http/tests/media/video-load-suspend-expected.txt: Added.
  • http/tests/media/video-load-suspend.html: Added.
  • media/event-attributes-expected.txt: Updated to include suspend event.
11:12 AM Changeset in webkit [125053] by Lucas Forschler
  • 29 edits
    6 copies in branches/safari-536.26-branch

Merged r116291. <rdar://problem/12035601>

10:57 AM Changeset in webkit [125052] by tsepez@chromium.org
  • 4 edits
    2 adds in trunk

Video element image loader must persist after element detach.
https://bugs.webkit.org/show_bug.cgi?id=90801

Reviewed by Eric Carlson.

We rely on the OwnPtr in the element to cleanup the loader.

Source/WebCore:

Test: fast/dom/beforeload/remove-video-poster-in-beforeload-listener.html

  • html/HTMLVideoElement.cpp:

(WebCore):

  • html/HTMLVideoElement.h:

(HTMLVideoElement):

LayoutTests:

  • fast/dom/beforeload/remove-video-poster-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-video-poster-in-beforeload-listener.html: Added.
10:54 AM Changeset in webkit [125051] by commit-queue@webkit.org
  • 16 edits
    1 add in trunk/Source/WebCore

Improve RenderObject.h compile time - split CachedImage and CachedImageClient
https://bugs.webkit.org/show_bug.cgi?id=93400

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-08
Reviewed by Eric Seidel.

Splits loader/cache/CachedImage.h into two files. The remaining changes are to repair existing #includes

No new tests. No changes to existing functions/functionality.

  • css/CSSCrossfadeValue.h:
  • loader/ImageLoader.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:

(WebCore):

  • loader/cache/CachedImageClient.h: Added.

(WebCore):
(CachedImageClient):
(WebCore::CachedImageClient::~CachedImageClient):
(WebCore::CachedImageClient::expectedType):
(WebCore::CachedImageClient::resourceClientType):
(WebCore::CachedImageClient::imageChanged):
(WebCore::CachedImageClient::willRenderImage):

  • platform/chromium/ClipboardChromium.h:
  • rendering/RenderObject.h:

(WebCore):

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h:

(WebCore):

  • rendering/style/StyleCachedImageSet.h:
  • svg/graphics/SVGImage.cpp:
10:46 AM Changeset in webkit [125050] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r123171): <svg> element with intrinsic size and max-width gets sized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=93388

Reviewed by Beth Dakin.

Source/WebCore:

Test: svg/css/max-width-3.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox): Added code to set
m_intrinsicSize in the no-contentRenderer branch of this function so that the calls to
RenderBox::computeReplacedLogical{Height,Width} in the end use the right intrinsic size.
This is similar to what the contentRenderer branch of this function already does.

LayoutTests:

  • svg/css/max-width-3-expected.html: Added.
  • svg/css/max-width-3.html: Added.
10:38 AM Changeset in webkit [125049] by peter@chromium.org
  • 6 edits in trunk/Tools

The cr-android EWS should actually be building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=93489

Reviewed by Adam Barth.

The cr-android EWS bots should be building Chromium for Android, which
requires some additional flags to Chromium's default configuration.

  • Scripts/webkitdirs.pm:

(buildChromium):

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(ChromiumAndroidPort):
(ChromiumAndroidPort.update_webkit_command):
(ChromiumAndroidPort.build_webkit_command):

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_chromium_android_port):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(ChromiumAndroidEWS):

  • Scripts/webkitpy/tool/steps/update_unittest.py:

(UpdateTest.test_update_command_non_interactive):
(UpdateTest.test_update_command_interactive):

10:31 AM Changeset in webkit [125048] by keishi@webkit.org
  • 12 edits
    1 add
    1 delete in trunk

Make slider tick mark snapping threshold configurable for each platform
https://bugs.webkit.org/show_bug.cgi?id=93429

Reviewed by Kent Tamura.

Source/WebCore:

This makes the slider tick mark snapping threshold configurable for each platform.
And we increase the threshold for the Chromium port.

No new tests. Covered by range-snap-to-datalist.html.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::sliderTickSnappingThreshold):
(WebCore):

  • rendering/RenderTheme.h:

(RenderTheme):
(WebCore::RenderTheme::sliderTickSnappingThreshold): Returns the threshold distance to the tick mark for snapping to occur.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::sliderTickSnappingThreshold):
(WebCore):

  • rendering/RenderThemeChromiumCommon.h:

(RenderThemeChromiumCommon):

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm:

(WebCore):
(WebCore::RenderThemeChromiumMac::sliderTickSnappingThreshold):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore):
(WebCore::RenderThemeChromiumSkia::sliderTickSnappingThreshold):

  • rendering/RenderThemeChromiumSkia.h:

LayoutTests:

  • fast/forms/datalist/range-snap-to-datalist-expected.txt: Removed.
  • fast/forms/datalist/range-snap-to-datalist.html: Changed so we can use this test for different snapping thresholds.
  • platform/chromium/fast/forms/datalist/range-snap-to-datalist-expected.txt: Added.
10:24 AM Changeset in webkit [125047] by commit-queue@webkit.org
  • 17 edits in trunk

Until CSP fully supports paths, we should log a warning if we encounter a source with a path.
https://bugs.webkit.org/show_bug.cgi?id=93468

Patch by Mike West <mkwst@chromium.org> on 2012-08-08
Reviewed by Adam Barth.

Source/WebCore:

CSP 1.0 ignores path components of sources in directives' source lists.
'script-src http://example.com/path/to/directory' is treated exactly the
same as 'script-src http://example.com'. It's likely that this behavior
will change in CSP 1.1, which could break with developers' expectations.
This patch adds a warning when a path is encountered, alerting
developers to the fact that their current source is interpreted
differently than they might expect.

See http://crbug.com/128493 for additional context and discussion.

Tests for this change are covered by updating the existing Content
Security Policy tests to include the new console warnings.

  • page/ContentSecurityPolicy.cpp:

(CSPSourceList):
(WebCore::CSPSourceList::CSPSourceList):

Passing the directive name down into CSPSourceList so that we can
generate informative error messages.

(WebCore::CSPSourceList::parse):

Create a 'path' string, pass it into 'parseSource', and use it after
parsing each source to determine whether a warning should be sent.

(WebCore::CSPSourceList::parseSource):

Adding a 'path' argument so that we can see whether or not a
specific source should generate a warning.

(WebCore::CSPDirective::CSPDirective):

Passing the directive name down into CSPSourceList so that we can
generate informative error messages.

(WebCore::ContentSecurityPolicy::reportIgnoredPathComponent):

Generate the new warning message.

(WebCore):

  • page/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html:

All of the SecurityPolicy API tests with source lists contained
sources with a trailing /. I've fixed that oversight.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-05.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-06.html:

Updating the text of the test, and updating them to include the new
console warnings.

10:22 AM Changeset in webkit [125046] by pfeldman@chromium.org
  • 33 edits
    3 deletes in trunk

Web Inspector: generate preview for the objects dumped into the console upon logging.
https://bugs.webkit.org/show_bug.cgi?id=35801

Reviewed by Vsevolod Vlasov.

Source/WebCore:

As of today, dumping an object (array) into console will result in objects' properties being
read upon console object expansion (i.e. lazily). This means that dumping the same object while
mutating it will be hard to debug using the console.

This change starts generating abbreviated previews for objects / arrays at the moment of their
logging and passes this information along into the front-end. This only happens when the front-end
is already opened, it only works for console.log(), not live console interaction.

Covered by the existing console tests + collections test has been expanded to capture both: pre and post-
front-end opening scenarios.

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:

(ConsoleMessage):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::wrapObject):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addConsoleMessage):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._printArray):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):

  • inspector/front-end/DOMExtension.js:

(Element.prototype.createTextChild):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection):

  • inspector/front-end/PropertiesSection.js:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get previewProperties):

  • inspector/front-end/Section.js:
  • inspector/front-end/inspector.css:

(.console-group-messages .section .header .title):
(.section .console-formatted-node):
(.console-object-preview):
(.section .properties .name, .event-properties .name, .console-formatted-object .name):

LayoutTests:

  • inspector/console/command-line-api-inspect-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-eval-global.html:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-collections.html:
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • inspector/console/console-log-document-proto-expected.txt:
  • inspector/console/console-log-document-proto.html:
  • inspector/console/console-log-toString-object-expected.txt:
  • inspector/debugger/watch-expressions-panel-switch-expected.txt:
  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-eval-global-expected.txt: Removed.
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/inspector/console/console-format-expected.txt: Removed.
  • platform/chromium/inspector/console/console-log-document-proto-expected.txt:
  • platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt:
  • platform/chromium/inspector/elements/event-listener-sidebar-expected.txt: Removed.
10:18 AM Changeset in webkit [125045] by Philippe Normand
  • 5 edits in trunk

[GStreamer] media/media-continues-playing-after-replace-source.html fails
https://bugs.webkit.org/show_bug.cgi?id=86310

Reviewed by Eric Carlson.

Source/WebCore:

Reset the player's network and ready states, this allows the media
player client to potentially emit a timeupdate event while the new
location is being loaded. States are synchronized again after the
pipeline pre-rolled.

No new tests but fixes
media/media-continues-playing-after-replace-source.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

LayoutTests:

Unflag now passing media test on GTK and EFL.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
10:13 AM Changeset in webkit [125044] by Alexandru Chiculita
  • 19 edits in trunk

[Chromium] Skia assert triggered by custom filter unmultiplied results
https://bugs.webkit.org/show_bug.cgi?id=92758

Reviewed by Dean Jackson.

Source/WebCore:

The FECustomFilter (which renders the CSS Shaders) used premultiplied colors for both input and ouput.
The problem with that is that some shaders do not pre-multiply the values and the reality is that
we cannot trust the shader to do that. The easy way would be to use only unpremultiplied colors and do the
computation in C++ code. This will be changed when the mix blending is implemented to do that in the shader itself.

No new tests, just updated existing tests to take unpremultiplied colors instead.

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::platformApplySoftware):

LayoutTests:

Updated the shaders to output un-premultiplied colors. Also, updated the output results where needed.

  • css3/filters/custom/custom-filter-shader-cache-expected.png:
  • css3/filters/custom/effect-color-check-expected.png:
  • css3/filters/custom/effect-custom-combined-missing-expected.png:
  • css3/filters/custom/effect-custom-expected.png:
  • css3/filters/custom/effect-custom-parameters-expected.png:
  • css3/filters/custom/filter-repaint-custom-expected.png:
  • css3/filters/custom/missing-custom-filter-shader-expected.png:
  • css3/filters/resources/color-add.fs:
  • css3/filters/resources/color-fill.fs:
  • platform/chromium/TestExpectations: Disabled the following tests on Windows. They need a rebaseline.
  • platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
10:07 AM Changeset in webkit [125043] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix after r125041.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveResponse): Fix arguments order of the
notifyGstTagsOnPad() call.

10:00 AM Changeset in webkit [125042] by commit-queue@webkit.org
  • 27 edits
    18 deletes in trunk/Source/WebCore

Remove All Custom binding code for TypedArray.
https://bugs.webkit.org/show_bug.cgi?id=93371

Patch by Vineet Chaudhary <Vineet> on 2012-08-08
Reviewed by Kentaro Hara.

Removing Custom bindings completely with help of [TypedArray] attribute.

Tests: TestTypedArray.idl
There should not be any behavioral change and all tests should pass.

  • GNUmakefile.list.am: Removed Custom files.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • UseV8.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSFloat32ArrayCustom.cpp: Removed.
  • bindings/js/JSFloat64ArrayCustom.cpp: Removed.
  • bindings/js/JSInt16ArrayCustom.cpp: Removed.
  • bindings/js/JSInt32ArrayCustom.cpp: Removed.
  • bindings/js/JSInt8ArrayCustom.cpp: Removed.
  • bindings/js/JSUint16ArrayCustom.cpp: Removed.
  • bindings/js/JSUint32ArrayCustom.cpp: Removed.
  • bindings/js/JSUint8ArrayCustom.cpp: Removed.
  • bindings/js/JSUint8ClampedArrayCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader): Skip implementaion for TypedArray.
(GenerateImplementation): Skip implementaion for TypedArray.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction): Skip implementaion for TypedArray.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): Generates binding for set() call.
(GenerateConstructorDefinition): ConstructorTemplate implementation for TypedArray.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader): Skip implementaion for TypedArray.
(GenerateImplementation): Skip implementaion for TypedArray.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback): Generates binding for setCallback().
(GenerateTypedArrayConstructorCallback): Generates binding for constructorCallback().
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt: Support ConstructorTemplate for TypedArray as well.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Binding tests results.

(WebCore::toJS):
(WebCore::JSFloat64Array::indexSetter):
(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
(WebCore::jsFloat64ArrayPrototypeFunctionSet):

  • bindings/scripts/test/JS/JSFloat64Array.h: Binding tests results.
  • bindings/scripts/test/TestTypedArray.idl: Binding tests.
  • bindings/scripts/test/V8/V8Float64Array.cpp: Binding tests results.

(WebCore::Float64ArrayV8Internal::setCallback):
(Float64ArrayV8Internal):
(WebCore):
(WebCore::V8Float64Array::constructorCallback):
(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Float64ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Int16ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Int32ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Int8ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Removed.
  • html/canvas/Float32Array.idl: Using [ConstructorTemplate = TypedArray] instead of custom implementaion.
  • html/canvas/Float64Array.idl: Ditto.
  • html/canvas/Int16Array.idl: Ditto.
  • html/canvas/Int32Array.idl: Ditto.
  • html/canvas/Int8Array.idl: Ditto.
  • html/canvas/Uint16Array.idl: Ditto.
  • html/canvas/Uint32Array.idl: Ditto.
  • html/canvas/Uint8Array.idl: Ditto.
  • html/canvas/Uint8ClampedArray.idl: Ditto.
9:52 AM Changeset in webkit [125041] by Philippe Normand
  • 7 edits in trunk

[GStreamer] 0.11 build broken (again)
https://bugs.webkit.org/show_bug.cgi?id=93474

Reviewed by Martin Robinson.

.:

  • configure.ac: Disable media-stream build if GStreamer 0.11

support is enabled, due to farstream-0.1 still messing up with
gstreamer-0.10 include path.

Source/WebCore:

Adapt the GStreamer media player backend to the latest GStreamer
0.11 API changes.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(gstObjectIsFloating):

  • platform/graphics/gstreamer/GStreamerVersioning.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveResponse):

9:32 AM Changeset in webkit [125040] by ap@apple.com
  • 3 edits in trunk/Tools

[WK2] MiniBrowser crashes on window.open()
https://bugs.webkit.org/show_bug.cgi?id=93413

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindowController.m: (createNewPage): This is a "create" API, so it needs to return a retained result.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame): When this function is called, URL appears to be poorly defined. Sometimes, it's the new URL, other times it's the old one. An "old" URL is null in a new page.
8:42 AM Changeset in webkit [125039] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] Compile errors with OpenGLES2
https://bugs.webkit.org/show_bug.cgi?id=93206

Patch by Loïc Yhuel <loic.yhuel@softathome.com> on 2012-08-08
Reviewed by Noam Rosenthal.

Fix build with OpenGLES2 on Linux desktop

Source/WebCore:

  • platform/graphics/OpenGLESShims.h: removed unused define conflicting with gl2ext.h from ANGLE

Tools:

  • qmake/mkspecs/features/features.prf: Don't use GLX with OpenGLES2
8:18 AM Changeset in webkit [125038] by peter@chromium.org
  • 4 edits in trunk/Tools

Introduce cr-android bots in the EWS system
https://bugs.webkit.org/show_bug.cgi?id=93472

Reviewed by Adam Barth.

This adds the queue to the EWS scripts. Two builders are ready to be
attached to the queue. All webkitpy tests pass with this change applied.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(ChromiumAndroidEWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest.test_builder_ewses):

8:10 AM Changeset in webkit [125037] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ build with GTK2 after r121475.

  • TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Add missing

include required when building with GTK2.

7:42 AM BuildBot edited by jocelyn.turcotte@nokia.com
Remove spam (diff)
7:41 AM Changeset in webkit [125036] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add relayout after updating fixed reported size
https://bugs.webkit.org/show_bug.cgi?id=93116
PR #160059

Patch by Ed Baker <edbaker@rim.com> on 2012-08-08
Reviewed by Antonio Gomes.

Reviewed internally by Antonio Gomes.

On an orientation change and after fixed reported size is
updated perform a layout and update the fixed elements after
scrolling. This will recalculate the height and width of
fixed position elements using percentage values with the
new fixed reported size. Otherwise using the old fixed reported
size in the new orientation overflowing or clipping could occur.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

7:40 AM Changeset in webkit [125035] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/Source/WebKit2

[EFL] EFL Webkit needs a class wrapping eina stringshare
https://bugs.webkit.org/show_bug.cgi?id=93229

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Added a new auxiliary class wrapping Eina Stringshare and providing
more convenient C++ interface for using it.

  • PlatformEfl.cmake:
  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp: Added.

(:m_string):
(WKEinaSharedString::~WKEinaSharedString):
(WKEinaSharedString::operator=):

  • UIProcess/API/cpp/efl/WKEinaSharedString.h: Added.

(WebKit):

7:09 AM Changeset in webkit [125034] by kbalazs@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Snowshoe desktop crashes when opening a new tab
https://bugs.webkit.org/show_bug.cgi?id=92753

Reviewed by Jocelyn Turcotte.

Change back forceRepaint to consider the UI process state.
It has been tweaked to satisfy the needs of WKPageForceRepaint but
it has other callers so this new behavior was not safe. This patch
implements WebPage::forceRepaintAsync for testing purposes. It is
done by LayerTreeCoordinator that holds the callback and sends the
reply message in the next flushPendingLayerChanges. In theory it
could be implemented for the non conposited path in DrawingAreaImpl
as well but neither it is needed nor can I test it.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::forceRepaintAsync):
(WebKit):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaintAsync):
(WebKit):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::forceRepaintAsync):

6:21 AM Changeset in webkit [125033] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: store last evaluation result in $_
https://bugs.webkit.org/show_bug.cgi?id=93377

Reviewed by Vsevolod Vlasov.

Source/WebCore:

All "console" evaluations end up in that variable on command line API.

Test: inspector/console/console-last-result.html

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/console/console-last-result-expected.txt: Added.
  • inspector/console/console-last-result.html: Added.
6:19 AM Changeset in webkit [125032] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Qt] Port internal findMethodIndex method matcher to use JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93463

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Based on patch by No'am Rosenthal.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::setException):
(Bindings):
(JSC::Bindings::findMethodIndex): Fixed also coding style while at it.
(JSC::Bindings::QtRuntimeMetaMethod::call): Use new findMethodIndex. The
created JSValueRefs should not need GC protection because we only support
up to 10 method arguments and thus they will live on the stack storage
of the vector.

  • bridge/qt/qt_runtime.h:

(Bindings):

Source/WebKit/qt:

Adjust the expectations of the unit test for some of the exceptions the
method throws when signals/slots cannot be found/matched. The C API doesn't allow
us to create syntax (type) errors, only generic error exceptions.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::callQtInvokable):

6:18 AM Changeset in webkit [125031] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] [WTR] Provide Resource Response dumping.
https://bugs.webkit.org/show_bug.cgi?id=93454

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Several new getter functions were added to WKURLResponse and WKURL, so that WTR has
necessary data for dumping.

  • Shared/API/c/WKURL.cpp:

(WKURLCopyLastPathComponent):

  • Shared/API/c/WKURL.h:
  • Shared/API/c/WKURLResponse.cpp:

(WKURLResponseCopyURL): Returns URL of the response.
(WKURLResponseCopyMimeType): Returns MIME type of the response.

  • Shared/API/c/WKURLResponse.h:
  • Shared/WebURL.h:

(WebKit::WebURL::lastPathComponent): Returns last path component of the URL.
(WebURL):

Tools:

Added missing dumpResourceResponseMIMETypes() method to testRunner. Provided resource response dumping.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveResponseForResource):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpProgressFinishedCallback):
(WTR::LayoutTestController::dumpResourceResponseMIMETypes):
(WTR::LayoutTestController::shouldDumpResourceResponseMIMETypes):
(LayoutTestController):

6:15 AM Changeset in webkit [125030] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Make ewk_view inheritable in the WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=90054

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Make the ewk_view inheritable by exposing ewk_view_smart_class_set()
API. Additionally, the ewk_view_smart_add() API is added to create
Evas_Object for WebKit2 EFL. The default initialization is done in the
ewk_view_smart_add(), so the object which inherits the ewk_view should
use ewk_view_smart_add() instead of evas_object_smart_add() to create
Evas_Object.

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_new_from_WKContext):

  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_smart_class_set):
(_ewk_view_smart_class_new):
(_ewk_view_initialize):
(_ewk_view_add_with_smart):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):

  • UIProcess/API/efl/ewk_view.h:
6:13 AM Changeset in webkit [125029] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Add unit test for QObject bindings for scriptable plugins
https://bugs.webkit.org/show_bug.cgi?id=93462

Reviewed by Kenneth Rohde Christiansen.

The bindings code is subject to refactoring in the future, so added a unit test to verify that
accessing an embedded QWidget from JavaScript goes through the QObject bindings.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge):
(TestPluginWidget):
(TestPluginWidget::TestPluginWidget):
(TestPluginWidget::slotWithReturnValue):
(TestWebPage):
(TestWebPage::TestWebPage):
(TestWebPage::createPlugin):
(tst_QObjectBridge::scriptablePlugin):

6:11 AM Changeset in webkit [125028] by apavlov@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: move setTouchEventEmulationEnabled from DOMAgent to PageAgent
https://bugs.webkit.org/show_bug.cgi?id=93437

Reviewed by Pavel Feldman.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::restore):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::clearFrontend):
(WebCore::InspectorPageAgent::restore):
(WebCore):
(WebCore::InspectorPageAgent::updateTouchEventEmulationInPage):
(WebCore::InspectorPageAgent::setTouchEmulationEnabled):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):

6:04 AM Changeset in webkit [125027] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt on Linux.

  • platform/qt/GamepadsQt.cpp:
5:53 AM Changeset in webkit [125026] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Support DataList for <input type="range">
https://bugs.webkit.org/show_bug.cgi?id=92634

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

DataList theme for EFL is implemented. DataList feature of
<input type="range"> is supported.

Test: fast/forms/datalist/input-list.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintSliderTrack):
(WebCore::RenderThemeEfl::sliderTickSize):
(WebCore::RenderThemeEfl::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

LayoutTests:

Update platform/efl/fast/forms/datalist/input-list-expected.txt because
range type of data list feature is passed.

  • platform/efl/fast/forms/datalist/input-list-expected.txt:
5:51 AM Changeset in webkit [125025] by commit-queue@webkit.org
  • 15 edits
    2 moves in trunk/Source/WebCore

Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
https://bugs.webkit.org/show_bug.cgi?id=93253

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-08
Reviewed by Pavel Feldman.

Renaming DOMNodeHighlighter to InspectorOverlay where necessary.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorOverlay.cpp: Renamed from Source/WebCore/inspector/DOMNodeHighlighter.cpp.

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::highlightRect):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):

  • inspector/InspectorOverlay.h: Renamed from Source/WebCore/inspector/DOMNodeHighlighter.h.

(WebCore):
(HighlightConfig):
(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):
(WebCore::InspectorOverlay::create):

  • inspector/InspectorPageAgent.cpp:
  • inspector/PageDebuggerAgent.cpp:
  • page/GestureTapHighlighter.h:
  • testing/Internals.cpp:
5:42 AM Changeset in webkit [125024] by allan.jensen@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] WebProcess hangs on plugin initialization.
https://bugs.webkit.org/show_bug.cgi?id=93272

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching): Ensure PluginProcessConnectionManager is informed of plugin crashes.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Let setIsInWindow set canStartMedia asynchronously.

5:33 AM Changeset in webkit [125023] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][Win] Fix compilation of DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93461

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-08
Reviewed by Tor Arne Vestbø.

DRT includes stdint.h, for which we have wrappers in Source/JavaScriptCore/os-win32. Use these not only
for libraries but any building template.

  • qmake/mkspecs/features/default_post.prf:
5:11 AM Changeset in webkit [125022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Blackberry] missing a Multipart header when m_multipartResponse is null
https://bugs.webkit.org/show_bug.cgi?id=93440

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-08-08
Reviewed by George Staikos.

when m_multipartResponse is null, we just created new one but not called
setHTTPHeaderField. So we missed this received multipart Header. We should
call setHTTPHeaderField for each reveived header.

No new tests, because those current multipart test cases (http/tests/multipart/*)
are enough.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyMultipartHeaderReceived):

4:56 AM Changeset in webkit [125021] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactor console logging out of CSPDirectiveList into ContentSecurityPolicy
https://bugs.webkit.org/show_bug.cgi?id=93205

Patch by Mike West <mkwst@chromium.org> on 2012-08-08
Reviewed by Adam Barth.

We currently pass a protected resource's ScriptExecutionContext down
into CSPDirectiveList in order to log errors, grab the SecurityOrigin,
resolve relative URLs, and one or two other bits. This implementation
requires us to maintain state inside of low-level objects that shouldn't
really know about the ScriptExecutionContext, and makes logging errors
difficult, as CSPDirectiveList is the only piece of the puzzle that can
interact with the console.

This patch removes the dependence on ScriptExecutionContext, replacing
it with a pointer to the ContentSecurityPolicy object itself. The low-
level objects like CSPDirectiveList now make requests to the policy
object, which understands how to resolve them. This gives a cleaner
separation between the CSP implementation and the rest of WebCore, and
opens the door for future patches that teach the remaining low-level
objects about the policy in which they're contained in order to improve
error logging.

This should be a purely internal refactoring of the location from which
warnings are logged to the console. No new tests have been added; the
behavior should be covered by the existing CSP tests.

  • page/ContentSecurityPolicy.cpp:

(CSPSourceList):
(WebCore::CSPSourceList::CSPSourceList):

Pass the policy object into CSPSourceList, rather than a pointer to
ScriptExecutionContext.

(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::addSourceSelf):

Read the SecurityOrigin from the policy object, rather than from the
ScriptExecutionContext.

(WebCore::CSPDirective::CSPDirective):

Pass the policy object into CSPDirective, rather than a pointer to
ScriptExecutionContext. Use it to read the protected resource's
URL.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):

Pass the policy object into CSPSourceList, rather than a pointer to
ScriptExecutionContext.

(WebCore::CSPDirectiveList::create):

Move the enforcement of eval restrictions out of CSPDirectiveList,
and into ContentSecurityPolicy::ContentSecurityPolicy.

(WebCore::CSPDirectiveList::reportViolation):

Move most of the logic out of this method, and into
ContentSecurityPolicy::reportViolation.

(WebCore::CSPDirectiveList::parseDirective):

Use the policy object for logging.

(WebCore::CSPDirectiveList::parseReportURI):

Use the policy object for logging, and URL completion.

(WebCore::CSPDirectiveList::parseScriptNonce):

Use the policy object for logging.

(WebCore::CSPDirectiveList::setCSPDirective):

Use the policy object for logging.

(WebCore::CSPDirectiveList::applySandboxPolicy):

Use the policy object for logging, and move enforcement to
ContentSecurityPolicy::enforceSandboxFlags.

(WebCore::CSPDirectiveList::addDirective):

Use the policy object for logging.

(WebCore::ContentSecurityPolicy::didReceiveHeader):

Pass the policy object to CSPDirectiveList, and disable eval if
necessary after parsing the policy.

(WebCore::ContentSecurityPolicy::securityOrigin):
(WebCore):
(WebCore::ContentSecurityPolicy::url):
(WebCore::ContentSecurityPolicy::completeURL):
(WebCore::ContentSecurityPolicy::enforceSandboxFlags):

Move the enforcement of the sandbox directive out of
CSPDirectiveList and into the policy object.

(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
(WebCore::ContentSecurityPolicy::reportDuplicateDirective):
(WebCore::ContentSecurityPolicy::reportInvalidNonce):

Move CSPDirectiveList::logXXX out to the policy object. The
directive list is now responsible for reporting errors and
violations; the policy decides what to do with them.

(WebCore::ContentSecurityPolicy::logToConsole):

Wrap the call to addConsoleMessage to make it simpler for the
various ContentSecurityPolicy::reportXXX methods.

  • page/ContentSecurityPolicy.h:

(WebCore):

4:44 AM Changeset in webkit [125020] by haraken@chromium.org
  • 6 edits
    2 moves in trunk/Source/WebCore

[V8] Rename V8Helpers to V8BindingHelpers
https://bugs.webkit.org/show_bug.cgi?id=93318

Reviewed by Eric Seidel.

For naming consistency, a file including binding utility methods
should be prefixed by "V8Binding". In a follow-up patch, I'll move
methods from V8Binding to V8BindingHelpers.

In addition this patch makes V8Binding.h include V8BindingHelpers.h,
and removes #include V8BindingHelpers.h from binding files.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8BindingHelpers.cpp: Renamed from Source/WebCore/bindings/v8/V8Helpers.cpp.

(WebCore):
(WebCore::toV8Context):
(WebCore::toV8Proxy):

  • bindings/v8/V8BindingHelpers.h: Renamed from Source/WebCore/bindings/v8/V8Helpers.h.

(WebCore):

  • bindings/v8/V8NPObject.cpp:
4:20 AM Changeset in webkit [125019] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
https://bugs.webkit.org/show_bug.cgi?id=93457

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-08
Reviewed by Csaba Osztrogonác.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpProgressFinishedCallback): Added constness.

3:49 AM QtWebKit edited by jocelyn.turcotte@nokia.com
Remove spam (diff)
3:46 AM QtWebKit edited by jocelyn.turcotte@nokia.com
Update the mailing list link (diff)
3:43 AM Changeset in webkit [125018] by Patrick Gansterer
  • 4 edits in trunk/Source

Remove ce_time.(cpp|h) from list of source files
https://bugs.webkit.org/show_bug.cgi?id=93446

Reviewed by Simon Hausmann.

r125004 removed the last dependency on functions defined in ce_time.cpp.

Source/JavaScriptCore:

  • Target.pri:

Source/WTF:

  • wtf/PlatformWinCE.cmake:
3:38 AM Changeset in webkit [125017] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

'class WrapperTypeInfo' should be 'struct WrapperTypeInfo'

Unreviewed. Build fix for r125015.

  • bindings/v8/V8BindingPerIsolateData.h:

(WebCore):

3:22 AM Changeset in webkit [125016] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when inspecting an element with border-image
https://bugs.webkit.org/show_bug.cgi?id=93380

Patch by Matt Arsenault <arsenm2@gmail.com> on 2012-08-08
Reviewed by Tim Horton.

Source/WebCore:

The second value in the CSSPair should be the same as the first if
we are in a shorthand and the next value is not a
border-image-repeat keyword.

Test: fast/css/parse-border-image-repeat-null-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBorderImageRepeat):

LayoutTests:

Add a test that ensures css Text on a border image shorthand with
border-image-repeat does not crash.

  • fast/css/parse-border-image-repeat-null-crash-expected.txt: Added.
  • fast/css/parse-border-image-repeat-null-crash.html: Added.
3:20 AM Changeset in webkit [125015] by haraken@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebCore

[V8] Factor out V8BindingPerIsolateData from V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=93333

Reviewed by Adam Barth.

This patch moves V8BindingPerIsolateData to V8BindingPerIsolateData.{h,cpp}.

To avoid circular #include dependency, I used OwnPtrs for m_stringCache,
m_integerCache, m_hiddenPropertyName and m_gcEventData.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::isolateGCEventData):
(WebCore::ScriptGCEvent::addEventListener):
(WebCore::ScriptGCEvent::removeEventListener):
(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(GCEventData):
(WebCore):

  • bindings/v8/V8BindingPerIsolateData.cpp: Added.

(WebCore):
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::create):
(WebCore::V8BindingPerIsolateData::ensureInitialized):
(WebCore::V8BindingPerIsolateData::dispose):
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):

  • bindings/v8/V8BindingPerIsolateData.h: Added.

(WebCore):
(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::current):
(WebCore::V8BindingPerIsolateData::rawTemplateMap):
(WebCore::V8BindingPerIsolateData::templateMap):
(WebCore::V8BindingPerIsolateData::toStringName):
(WebCore::V8BindingPerIsolateData::toStringTemplate):
(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::stringCache):
(WebCore::V8BindingPerIsolateData::integerCache):
(WebCore::V8BindingPerIsolateData::allStores):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::auxiliaryContext):
(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
(WebCore::V8BindingPerIsolateData::domDataStore):
(WebCore::V8BindingPerIsolateData::setDOMDataStore):
(WebCore::V8BindingPerIsolateData::recursionLevel):
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::V8BindingPerIsolateData::internalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::incrementInternalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementInternalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::gcEventData):
(WebCore::V8BindingPerIsolateData::setShouldCollectGarbageSoon):
(WebCore::V8BindingPerIsolateData::clearShouldCollectGarbageSoon):
(WebCore::V8BindingPerIsolateData::shouldCollectGarbageSoon):

3:16 AM Changeset in webkit [125014] by pfeldman@chromium.org
  • 5 edits in trunk

Source/WebCore: Web Inspector: show whitespace nodes if they are the only tag's children.
https://bugs.webkit.org/show_bug.cgi?id=93441

Reviewed by Vsevolod Vlasov.

Pass whitespace node info into the front-end when it is the only element's child.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):

LayoutTests: Web Inspector: show white space nodes if they are the only tag's children.
https://bugs.webkit.org/show_bug.cgi?id=93441

Reviewed by Vsevolod Vlasov.

  • inspector/elements/set-outer-html-2-expected.txt:
  • inspector/styles/styles-update-from-js.html:
2:50 AM Changeset in webkit [125013] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Set the fixed layout setting before creating the page
https://bugs.webkit.org/show_bug.cgi?id=93374

Reviewed by Noam Rosenthal.

Any page setting should preferrable be set before creating the page
but fixed layout was set after the initialization of the web page.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewFlickablePrivate::initialize):

2:45 AM Changeset in webkit [125012] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

[V8] Pass Isolate to ArrayValue and Dictionary
https://bugs.webkit.org/show_bug.cgi?id=93315

Reviewed by Adam Barth.

This patch passes Isolate to ArrayValue and Dictionary.

Rationale 1: We want to replace V8Proxy::throwError(ExceptionCode)
with setDOMException(ExceptionCode, Isolate*). For the replacement,
we need to pass Isolate to V8Utilities::extractTransferables().
To pass Isolate to V8Utilities::extractTransferables(), ( ...omitted... ),
we need to pass Isolate to ArrayValue and Dictionary.

Rationale 2: JSC already passes ExecState to ArrayValue and Dictionary.

Tests: storage/indexeddb/*

fast/files/*

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):
(JSValueToNative):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::optionsObjectCallback):

  • bindings/v8/ArrayValue.cpp:

(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::get):

  • bindings/v8/ArrayValue.h:

(WebCore::ArrayValue::ArrayValue):
(ArrayValue):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::operator=):
(WebCore::Dictionary::get):

  • bindings/v8/Dictionary.h:

(Dictionary):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

2:16 AM Changeset in webkit [125011] by yurys@chromium.org
  • 3 edits
    4 adds in trunk

Web Inspector: cached images memory instrumentation regression after r124744
https://bugs.webkit.org/show_bug.cgi?id=93366

Reviewed by Vsevolod Vlasov.

Source/WebCore:

CachedImage memory usage data no includes size of both encoded and
decoded data.

Test: inspector/profiler/memory-instrumentation-cached-images.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

LayoutTests:

Added a sanity test checking that memory usage data includes decoded image size.

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-cached-images.html: Added.
2:10 AM Changeset in webkit [125010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Atomics.h has incorrect GCC test for ext/atomicity.h when using LSB compilers
https://bugs.webkit.org/show_bug.cgi?id=51974

Patch by Alvaro Lopez Ortega <alvaro@alobbs.com> on 2012-08-08
Reviewed by Simon Hausmann.

  • wtf/Atomics.h: Inhibits the inclusion of the atomicity.h GNU C++

extension when compiling with a LSB compliant compiler. Thanks to
Craig Scott for the new precompiler check code.

1:43 AM Changeset in webkit [125009] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Optimize Element::hasAttribute() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90273

Reviewed by Adam Barth.

Based on the observation described in this ChangeLog
(http://trac.webkit.org/changeset/121439), this patch optimizes the
performance of Element::hasAttribute() by replacing String with AtomicString.

Performance test: https://bugs.webkit.org/attachment.cgi?id=150144

hasAttribute (Chromium/Linux):
329.60ms => 259.00ms

hasAttributeNS (Chromium/Linux):
549.60ms => 435.80ms

  • dom/Element.cpp:

(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):

  • dom/Element.h:

(Element):

1:24 AM Changeset in webkit [125008] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Optimize Element::removeAttribute() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90265

Reviewed by Adam Barth.

Based on the observation described in this ChangeLog
(http://trac.webkit.org/changeset/121439), this patch optimizes
Element::removeAttribute() by replacing String with AtomicString.

Performance test: https://bugs.webkit.org/attachment.cgi?id=150140

removeAttribute (Chromium/Linux):
334.20ms => 240.60ms

removeAttributeNS (Chromium/Linux):
552.80ms => 421.60ms

  • dom/Element.cpp:

(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeNS):

  • dom/Element.h:

(Element):

1:13 AM Changeset in webkit [125007] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove Element::ensureShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=77608

Reviewed by Ryosuke Niwa.

Since Element::ensureShadowRoot is not used anymore, we can remove this safely.

No new tests, no change in behavior.

  • WebCore.order:
  • dom/Element.cpp:
  • dom/Element.h:

(Element):

12:51 AM Changeset in webkit [125006] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove an unused member variable.

Unreviewed, build fix for r124990.

  • dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::ChildNodesLazySnapshot):
(ChildNodesLazySnapshot):

12:39 AM Changeset in webkit [125005] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: TabbedPane should use floating point width values for measuring.
https://bugs.webkit.org/show_bug.cgi?id=93349

Reviewed by Pavel Feldman.

TabbedPane now uses getBoundingClientRect().width instead of offsetWidth for more precise calculation.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._totalWidth):
(WebInspector.TabbedPane.prototype._updateTabsDropDown):
(WebInspector.TabbedPane.prototype._measureDropDownButton):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPaneTab.prototype._measure):

12:31 AM Changeset in webkit [125004] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Use GetTimeZoneInformation() for getting the timezone name
https://bugs.webkit.org/show_bug.cgi?id=91936

Reviewed by Ryosuke Niwa.

The MS CRT implementation of strftime calls the same functions in the background.
Using them directly avoids the overhead of parsing the format string and removes
the dependency on strftime() for WinCE where this function does not exist.

  • runtime/DateConversion.cpp:

(JSC::formatTime):

12:13 AM Changeset in webkit [125003] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

'highlight' should not be parsed for a composite operation
https://bugs.webkit.org/show_bug.cgi?id=92615

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

r88144 removed support for highlight as a composite operation but did
not update the parser.

Test: fast/backgrounds/composite-highlight-is-invalid.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillProperty):

LayoutTests:

  • fast/backgrounds/composite-highlight-is-invalid-expected.txt: Added.
  • fast/backgrounds/composite-highlight-is-invalid.html: Added.
12:12 AM Changeset in webkit [125002] by mario@webkit.org
  • 8 edits in trunk/Source/WebKit2

[WK2] Add new C API to generate MHTML data from the UI process
https://bugs.webkit.org/show_bug.cgi?id=89872

Reviewed by Anders Carlsson.

Add new C API in the UI Process, using ENABLE(MHTML) guards as needed.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetContentsAsMHTMLData):

  • UIProcess/API/C/WKPage.h:

Implementation in the UI Process's WebPage proxy object.

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::getContentsAsMHTMLData):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

Implementation in the WebProcess, relying in WebCore::MHTMLArchive.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::getContentsAsMHTMLData):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
12:06 AM Changeset in webkit [125001] by toyoshim@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, adding new results for chromium.

http://trac.webkit.org/changeset/124986 this change added new results
for Mac and it has a high priority. Then, we need to add specific
results for chromium.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-08

  • platform/chromium/media/video-seek-past-end-paused-expected.txt: Added.
12:02 AM Changeset in webkit [125000] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

showNodePath should show the age of ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=93347

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-08
Reviewed by Ryosuke Niwa.

No new tests, because this patch is for fixing a bug of a method for
debugging. If NDEBUG is defined, the method is not compiled.

  • dom/Node.cpp:

(WebCore::Node::showNodePathForThis):
Fixed the bug to obtain the oldest shadow root from a shadow root.
oldestShadowRootFor only works for an element node, not for a shadow root.

Aug 7, 2012:

11:58 PM Changeset in webkit [124999] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Remove fail expectations for tests that should not be
crashing anymore after r124997.

  • platform/gtk/TestExpectations: Update test expectations.
11:49 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update roadmap after 1.9.6 release (diff)
11:49 PM Changeset in webkit [124998] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

Remove fractionDigits argument of WebCore::convertToLocalizedNumber()
https://bugs.webkit.org/show_bug.cgi?id=93435

Reviewed by Kentaro Hara.

Remove the fractionDigits argument of convertToLocalizedNumber because
we don't use it any more. Also, we can remove
parseToDoubleForNumberTypeWithDecimalPlaces() functions, which are used
to obtain the fractionDigits argument.

No new tests because of no behavior changes.

  • platform/text/LocalizedNumber.h:

(WebCore): Remove the fractionDigits argument of convertToLocalizedNumber.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::convertToLocalizedNumber): ditto.

  • platform/text/LocalizedNumberNone.cpp:

(WebCore::convertToLocalizedNumber): ditto.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::convertToLocalizedNumber): ditto.

  • platform/text/win/LocalizedNumberWin.cpp:

(WebCore::convertToLocalizedNumber): ditto.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::localizeValue):
Remove the code to make the decimalPlace value.

  • html/parser/HTMLParserIdioms.cpp:

Remove parseToDoubleForNumberTypeWithDecimalPlaces.

  • html/parser/HTMLParserIdioms.h: ditto.
11:47 PM Changeset in webkit [124997] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
https://bugs.webkit.org/show_bug.cgi?id=63611

Reviewed by Ryosuke Niwa.

Ensure document's layout is up-to-date before using TextIterator
to properly calculate the offset for a text change when emitting
accessibility related signals in GTK.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Call
to document->updateLayout() before using TextIterator.

11:46 PM Changeset in webkit [124996] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectation.
https://bugs.webkit.org/show_bug.cgi?id=93225

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-07

  • platform/chromium/TestExpectations:
11:31 PM Changeset in webkit [124995] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectation.
https://bugs.webkit.org/show_bug.cgi?id=93439

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-07

  • platform/chromium/TestExpectations:
11:23 PM Changeset in webkit [124994] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed typo fix after r124988.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

11:01 PM Changeset in webkit [124993] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline for chromium Mac10.7

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-07

  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
10:51 PM Changeset in webkit [124992] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after http://trac.webkit.org/changeset/124975

Remove assertion introduced in r124975.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:

(EventDispatcher):

10:43 PM Changeset in webkit [124991] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r124969.
http://trac.webkit.org/changeset/124969
https://bugs.webkit.org/show_bug.cgi?id=93436

Causes assertion failure in RenderQueue (Requested by toyoshim
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-07

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

  • rendering/RenderQuote.cpp:

(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):
(WebCore::RenderQuote::renderName):
(WebCore):
(WebCore::RenderQuote::placeQuote):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):

  • rendering/RenderQuote.h:

(RenderQuote):
(WebCore::RenderQuote::isQuote):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore):
(RenderView):
(WebCore::RenderView::addRenderQuote):
(WebCore::RenderView::removeRenderQuote):
(WebCore::RenderView::hasRenderQuotes):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

10:38 PM Changeset in webkit [124990] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Optimize ChildNode{Insertion,Removal}Notifier::notify() by lazily taking a snapshot of child nodes
https://bugs.webkit.org/show_bug.cgi?id=92965

Reviewed by Adam Barth.

This patch improves performance of Dromaeo/dom-modify by 8.2% in both Chromium and Safari.

[Mac/Safari] 4590.33 runs/s => 4965.79 runs/s (+8.18%)
[Chromium/Linux] 3970.63 runs/s => 4299.65 runs/s (+8.29%)

notifyDescendantRemovedFromDocument() cannot iterate child nodes in this way:

void notifyDescendantRemovedFromDocument(Node* node) {

for (Node* child = node->firstChild(); child; child = child->nextSibling()) {

...;
notifyNodeRemovedFromDocument(child);

}

}

This is because notifyNodeRemovedFromDocument(child) might dispatch events
and the events might change child trees. To avoid security issues, the current
code takes a snapshot of child nodes before starting the iteration.

void notifyDescendantRemovedFromDocument(Node* node) {

NodeVector children;
getChildNodes(node, children); Take a snapshot.
for (int i = 0; i < children.size(); i++) {

...;
notifyNodeRemovedFromDocument(children[i]);

}

}

Based on the observation that in almost all cases events won't be dispatched
from inside notifyNodeRemovedFromDocument(), this patch implements
a "lazy" snapshot. The snapshot is taken at the point where
EventDispatcher::dispatchEvent() is invoked. The snapshot is not taken unless
any event is dispatched.

No tests. Confirm that all existing tests pass.
Actually, at present there is (should be) no case where an event is
dispatched from inside notifyNodeRemovedFromDocument(). Even DOMNodeInserted
and DOMNodeRemoved events are not dispatched. Originally the snapshot was
implemented "just in case" to protect the code from future attacks.
I manually confirmed that the lazy snapshot works correctly by inserting
takeChildNodesSnapshot() to notifyDescendantRemovedFromDocument()
in a random manner.

  • dom/ContainerNode.cpp:

(WebCore):

  • dom/ContainerNode.h:

(ChildNodesLazySnapshot):
(WebCore::ChildNodesLazySnapshot::ChildNodesLazySnapshot):
(WebCore::ChildNodesLazySnapshot::~ChildNodesLazySnapshot):
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::nextSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):
(WebCore::ChildNodesLazySnapshot::takeChildNodesLazySnapshot):
(WebCore):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

10:38 PM Changeset in webkit [124989] by commit-queue@webkit.org
  • 25 edits
    1 copy
    1 add in trunk

[WK2][EFL] Implement accelerated compositing on WK2 Efl port
https://bugs.webkit.org/show_bug.cgi?id=89840

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-08-07
Reviewed by Noam Rosenthal.

.:

Implement accelerated composition with TiledBackingStore on WK2 Efl port.
This implementation is based on COORDINATED_GRAPHICS.
Add COORDINATED_GRAPHICS related definitions in OptionsEfl.cmake.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

Implement accelerated composition with TiledBackingStore on WK2 Efl port.
This implementation is based on COORDINATED_GRAPHICS.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • Shared/ShareableSurface.cpp:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didChangeContentsSize):
(WebKit):

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/efl/ViewportProcessor.cpp: Added.

(WebKit):
(WebKit::ViewportProcessor::ViewportProcessor):
(WebKit::ViewportProcessor::~ViewportProcessor):
(WebKit::ViewportProcessor::display):
(WebKit::ViewportProcessor::updateViewportSize):
(WebKit::ViewportProcessor::setVisibleContentsRect):
(WebKit::ViewportProcessor::didChangeContentsSize):

  • UIProcess/API/efl/ViewportProcessor.h: Added.

(WebKit):
(ViewportProcessor):
(WebKit::ViewportProcessor::create):
(WebKit::ViewportProcessor::drawingArea):
(WebKit::ViewportProcessor::viewSize):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_smart_calculate):
(ewk_view_base_add):
(ewk_view_display):
(ewk_view_contents_size_changed):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::didChangeContentsSize):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit):

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

Tools:

Implement accelerated composition with TiledBackingStore on WK2 Efl port.
Add OPENGL_LIBRARIES in CMakeList.txt.

  • MiniBrowser/efl/CMakeLists.txt:
  • WebKitTestRunner/PlatformEfl.cmake:
10:34 PM Changeset in webkit [124988] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[NRWT] REGRESSION(r124967): New tests without expected results handled as failures
https://bugs.webkit.org/show_bug.cgi?id=93434

Reviewed by Tony Chang.

Change back "missing results" to "no expected result found", because master.cfg's results parser expects it.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

10:25 PM Changeset in webkit [124987] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

percentage margins + flex incorrectly overflows the flexbox
https://bugs.webkit.org/show_bug.cgi?id=93411

Reviewed by Tony Chang.

Source/WebCore:

Percent margins should always be computed with respect to the containing
block's width, not it's height. We were getting this wrong in column flows.

Test: css3/flexbox/percent-margins.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMarginValue):
(WebCore):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/percent-margins-expected.txt: Added.
  • css3/flexbox/percent-margins.html: Added.
10:22 PM Changeset in webkit [124986] by eric.carlson@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION (r124710-r124713): media/video-seek-past-end-paused.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93394

Unreviewed. Adding new results for failing tests on Mac.

  • platform/mac/media/video-seek-past-end-paused-expected.txt: Added.
10:06 PM Changeset in webkit [124985] by haraken@chromium.org
  • 21 edits in trunk/Source/WebCore

[V8] Replace throwError(ExceptionCode, Isolate*) with setDOMException(ExceptionCode, Isolate*) in v8/* and v8/custom/*
https://bugs.webkit.org/show_bug.cgi?id=93226

Reviewed by Eric Seidel.

Now throwError(ExceptionCode, Isolate*) is equivalent to
setDOMException(ExceptionCode, Isolate*). We can replace the former with
the latter. After this replacement, the rule becomes simple and sane:
"Use throwError() for throwing JavaScript errors, use setDOMException()
for throwing DOM exceptions".

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):

10:02 PM Changeset in webkit [124984] by haraken@chromium.org
  • 23 edits in trunk/Source/WebCore

[V8] Replace v8::Handle<v8::Value>() in custom bindings with v8Undefined()
https://bugs.webkit.org/show_bug.cgi?id=93215

Reviewed by Eric Seidel.

We should use v8Undefined() everywhere in V8 bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::traceCallback):
(WebCore::V8Console::assertCallback):
(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::GetNamedProperty):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:

(WebCore::npObjectNamedGetter):
(WebCore::npObjectNamedSetter):
(WebCore::npObjectIndexedGetter):
(WebCore::npObjectIndexedSetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyGetter):
(WebCore::storageSetter):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

9:59 PM Changeset in webkit [124983] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Make it possible to build without QtQuick

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-08-07
Reviewed by Simon Hausmann.

  • Source/QtWebKit.pro:
  • Source/tests.pri:
9:55 PM Changeset in webkit [124982] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] always set PolicyAction to PolicyIgnore if the chrome returns false for acceptNavigationRequest
https://bugs.webkit.org/show_bug.cgi?id=93251

Reviewed by George Staikos.

In acceptNavigationRequest(), webkit will ask if the chrome will accept the navigation request.
We will take this chance to see if the request is an internal-webkit protocol, otherwise,
we will try to launch an external application to handle the request, and ask webkit to ignore
the request by returning false in acceptNavigationRequest().

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

9:38 PM Changeset in webkit [124981] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

[V8] Replace v8::Handle<v8::Value>() in bindings/v8/* with v8Undefined()
https://bugs.webkit.org/show_bug.cgi?id=93211

Reviewed by Eric Seidel.

We should use v8Undefined() everywhere in V8 bindings.
Replacing v8::Local<v8::Value>() etc with v8Undefined() can cause build
errors due to type conversion mismatch. I'll do the replacement in follow-up
patches.

No tests. No change in behavior.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::handleV8DebugEvent):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.cpp:

(WebCore::batchConfigureCallbacks):

  • bindings/v8/V8Collection.h:

(WebCore::getV8Object):
(WebCore::collectionNamedPropertyGetter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):
(WebCore::V8Proxy::throwError):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

9:34 PM Changeset in webkit [124980] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix regression in credential storage when using Negotiate auth
https://bugs.webkit.org/show_bug.cgi?id=93386

Patch by Joe Mason <jmason@rim.com> on 2012-08-07
Reviewed by George Staikos.

r124205 regressed credential storage and lookup. It added code to update the scheme used in
credential storage if the scheme chosen by the network stack is different from that requested by
webkit (currently this is only used when webkit requests Negotiate auth, but the Negotiate
infrastructure isn't set up correctly, so the network stack falls back to another auth type, usually
NTLM). But the credentials are saved when a "success" status is received, and the scheme in the
credentials is not updated until notifyAuthReceived is called to report the actual auth scheme used.
The result is that the credentials are stored with the wrong auth scheme and can never be retreived.

Fixed by delaying the credential save until notifyAuthReceived.

RIM PR 166514
Internally reviewed by George Staikos

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived): Stop storing credentials here.
(WebCore::NetworkJob::notifyAuthReceived): Store credentials here instead.

9:15 PM Changeset in webkit [124979] by tkent@chromium.org
  • 6 edits
    2 adds in trunk

[Mac] Do not reformat numbers in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=93236

Reviewed by Hajime Morita.

Source/WebCore:

We had bugs such as stripping leading zeros, dropping lower digits of
large numbers because we parse a user-input string to a double value,
and generate a string from the double value.

In order to avoid such reformatting, we use
platform/text/NumberLocalizer, which maps ASCII digits to the
corresponding localized digits.

Test: fast/forms/number/number-lossless-localization.html

  • WebCore.xcodeproj/project.pbxproj:

Add the following files:

  • platform/text/NumberLocalizer.cpp
  • platform/text/NumberLocalizer.h
  • platform/mac/LocaleMac.h
  • platform/mac/LocaleMac.mm
  • platform/text/mac/LocaleMac.h:

(LocaleMac): Inherit NumberLocalizer, and declare
initializeNumberLocalizerData() for it.
Add m_didInitializeNumberData flag.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::LocaleMac): Initialize m_didInitializeNumberData
(WebCore::LocaleMac::initializeNumberLocalizerData):
Added. Prepare data for number localization, and call
NumberLocalizer::setNumberLocalizerData().
A tricky part is to format 9876543210 for m_locale. It seems OSX doesn't
have API to get localized digits.

  • platform/text/mac/LocalizedNumberMac.mm:

Remove many lines, and calls the corresponding functions of LocaleMac.
(WebCore::convertToLocalizedNumber):
(WebCore::convertFromLocalizedNumber):
(WebCore::localizedDecimalSeparator):

LayoutTests:

  • fast/forms/number/number-lossless-localization-expected.txt: Added.
  • fast/forms/number/number-lossless-localization.html: Added.
9:07 PM Changeset in webkit [124978] by haraken@chromium.org
  • 3 edits
    1 move in trunk/Source/WebCore

[V8] Move V8BindingMacros.h from bindings/v8/custom/ to bindings/v8/
https://bugs.webkit.org/show_bug.cgi?id=93254

Reviewed by Eric Seidel.

V8BindingMacros.h should exist in bindings/v8/.
This patch also moves related enums from V8Binding.h to V8BindingMacros.h.

No tests. No change in behavior.

  • WebCore.gypi:
  • bindings/v8/V8BindingMacros.h: Renamed from Source/WebCore/bindings/v8/custom/V8BindingMacros.h.

(WebCore):

9:01 PM Changeset in webkit [124977] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] StringCache::m_lastStringImpl and StringCache::m_lastV8String should be in sync
https://bugs.webkit.org/show_bug.cgi?id=93065

Reviewed by Eric Seidel.

StringCache::m_lastStringImpl caches a StringImpl that was accessed most
recently. StringCache::m_lastV8String caches Persistent<String> corresponding
to the StringImpl. Hence m_lastStringImpl and m_lastV8String should be in sync.

However, StringCache::remove() breaks the sync. StringCache::remove() clears
m_lastStringImpl but does not clear m_lastV8String. As far as I analyze the code,
this won't cause any problem, but we should fix it just in case.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::remove):

8:48 PM Changeset in webkit [124976] by yosin@chromium.org
  • 2 edits in trunk/Source/WTF

[WTF] Add using WTF::msPerHour into DateMath.h
https://bugs.webkit.org/show_bug.cgi?id=93428

Reviewed by Kent Tamura.

This patch adds "using WTF::msPerHour" into DateMath.h for some codes
which will use it, e.g. bug 92960. Note: DateMath.h already has had
using statements for msPerDay, msPerMinute and msPerSecond.

  • wtf/DateMath.h: Added "using WTF::msPerHour".
8:09 PM Changeset in webkit [124975] by hayato@chromium.org
  • 4 edits in trunk/Source/WebCore

Don't re-use the same EventDispatcher instance to dispatch events.
https://bugs.webkit.org/show_bug.cgi?id=93322

Reviewed by Dimitri Glazkov.

It is potentially dangerous to call
EventDispatcher::dispatchEvent(PassRefPtr<Event>) twice for the
same EventDispatcher instance. Some member functions in
EventDispatcher assume that dispatchEvent(PassRefPtr<Event>) is
never called more than once in its life cycle.

For example, EventDispatcher::ensureEventAncestor never
recalculates ancestors of node even when
dispatchEvent(PassRefPtr<Event)) is called again with a different
event parameter.

A 'dblclick' event violates this rule. A 'dblclick' dispatching
reuses the same dispatcher instance. So stop re-using the same
dispatcher and add ASSERT to make sure dispatchEvent() is never
called more than once.

No new tests, no change in functionality.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:

(EventDispatcher):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

8:06 PM Changeset in webkit [124974] by jsbell@chromium.org
  • 7 edits
    1 add in trunk

Layout Test storage/indexeddb/intversion-omit-parameter.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=92952

Reviewed by Tony Chang.

Source/WebCore:

Account for events being propagated from the back-end to front-end after
front-end context is stopped (i.e. document is being destroyed). The IDBRequest
lifecycle was tightened up in http://trac.webkit.org/changeset/123275 with more
asserts but the stopped state wasn't accounted for.

Test: [chromium] webkit_unit_tests --gtest_filter='IDBRequestTest.EventsAfterStopping'

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):

Source/WebKit/chromium:

Added test to exercise WebCore::IDBRequest event callbacks after
the script context has stopped and ensure no asserts are hit.

  • WebKit.gypi:
  • tests/IDBRequestTest.cpp: Added.

(WebCore):
(WebCore::TEST):

LayoutTests:

Remove expectation now that flakiness should be resolved.

  • platform/chromium/TestExpectations:
7:52 PM Changeset in webkit [124973] by dpranke@chromium.org
  • 2 edits in trunk/Tools

REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=93192

Unreviewed, build fix.

Disabling the test for now as PrettyPatch is just broken on win32.

  • Scripts/webkitpy/common/prettypatch_unittest.py:

(test_pretty_diff_encodings):

7:41 PM Changeset in webkit [124972] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Optimize Element::getAttributeNode() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90274

Reviewed by Adam Barth.

Based on the observation described in this ChangeLog
(http://trac.webkit.org/changeset/121439), this patch optimizes
the performance of Element::getAttributeNode() by replacing String
with AtomicString.

Performance test: https://bugs.webkit.org/attachment.cgi?id=150147

getAttributeNode (Chromium/Linux):
375.20ms => 310.80ms

getAttributeNodeNS (Chromium/Linux):
684.40ms => 539.00ms

  • dom/Element.cpp:

(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):

  • dom/Element.h:

(Element):

7:27 PM Changeset in webkit [124971] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124829. <rdar://problem/12043768>

7:25 PM Changeset in webkit [124970] by Michelangelo De Simone
  • 3 edits in trunk/Source/WebCore

CSSParser::parseTransform() refactor to accept valueList as argument
https://bugs.webkit.org/show_bug.cgi?id=93295

Reviewed by Darin Adler.

CSS::parseTranform() is now accepting the related CSSParserValueList as
argument. This change will be used by the code to parse the 3d-transforms
within the custom() function, see bug #71443.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransform):

  • css/CSSParser.h:
7:16 PM Changeset in webkit [124969] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Reimplement RenderQuote placement algorithm
https://bugs.webkit.org/show_bug.cgi?id=93056

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-08-07
Reviewed by Eric Seidel.

Greatly simplify the code that maintains the linked list of RenderQuotes. Now RenderQuote
is placed into the linked list in computePreferredLogicalWidths on first access and is
detached when destroyed (or explicitly removed).

The new algorithm doesn't require walking up the tree of renderers when there are no
RenderQuotes in the tree yet, and also removes the need to walk over every subtree
when inserting in rendererSubtreeAttached.

No new tests because this patch doesn't change any behavior.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): Call detachQuote when removing from a child list.
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeDestroyed): Call detachQuote to ensure all destroyed quotes are detached.
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths): Attach quote before computing the width.
(WebCore):
(WebCore::RenderQuote::attachQuote): Puts the RenderQuote in the linked list of quotes and computes the depth.
(WebCore::RenderQuote::detachQuote): Removes the quote from the linked list.
(WebCore::RenderQuote::updateDepth):

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return StyleDifferenceLayout if quotes change and remove check in styleDidChange in RenderQuote.

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore):
(WebCore::RenderView::setRenderQuoteHead):
(WebCore::RenderView::renderQuoteHead): Stores the first quote in the document.
(RenderView):

7:09 PM Changeset in webkit [124968] by haraken@chromium.org
  • 29 edits in trunk/Source/WebCore

[V8] Remove a bunch of Persistent::New()s on setJSWrapperForXXXObject()
https://bugs.webkit.org/show_bug.cgi?id=93342

Reviewed by Adam Barth.

There are a lot of custom bindings like this:

V8DOMWrapper::setJSWrapperForDOMObject(impl.release(), v8::Persistent<v8::Object>::New(args.Holder()));

Manually written Persistent::New() is error-prone. We can remove the
Persistent::New() by allocating the Persistent handle inside
setJSWrapperForDOMObject().

A new setJSWrapperForDOMObject() receives a wrapper object, allocates
the Persistent handle of the wrapper object, and return the Persistent handle.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

6:50 PM Changeset in webkit [124967] by dpranke@chromium.org
  • 5 edits in trunk/Tools

[NRWT] Would like an output mode similar to ORWT verbose one
https://bugs.webkit.org/show_bug.cgi?id=88702

Reviewed by Ryosuke Niwa.

Change the --verbose logging for new-run-webkit-tests so that
it matches ORWT more; we just print one line per test. Use
--debug-rwt-logging to get the full debug stream (aka old ORWT
--verbose).

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_retrying_and_flaky_tests):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(print_options):
(Printer._print_result_summary_entry):
(Printer._print_one_line_summary):
(Printer._print_test_result):
(Printer._print_baseline):
(Printer._print_unexpected_results):

6:46 PM Changeset in webkit [124966] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

Evolution, empathy no longer build with webkint 1.9.6: webkit_dom_html_element_set_class_name is gone
https://bugs.webkit.org/show_bug.cgi?id=93384

Reviewed by Adam Barth.

The GObject bindings do not do inheritance so when className was moved from HTMLElement to Element,
webkit_dom_html_element_set_class_name was no longer defined. This patch re-adds the binding for the
GObject bindings to HTMLElement.

No new tests.

  • html/HTMLElement.idl:
6:24 PM Changeset in webkit [124965] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

fix chromium win build after r124945
https://bugs.webkit.org/show_bug.cgi?id=93421

Unreviewed, build fix.

Two Efl files were removed in r124945 but we forgot to remove
them from WebCore.gypi.

  • WebCore.gypi:
6:23 PM Changeset in webkit [124964] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124714. <rdar://problem/12035618>

6:22 PM Changeset in webkit [124963] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Mac port after http://trac.webkit.org/changeset/124954

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::isKeyboardFocusable):

6:18 PM Changeset in webkit [124962] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Move setIsolatedWorldSecurityOrigin() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=93334

Reviewed by Adam Barth.

The goal is to move factor out V8Proxy methods to ScriptController.
As a starting point, this patch moves setIsolatedWorldSecurityOrigin().

isolatedWorlds() and isolatedWorldSecurityOrigins() are temporary methods.
They will be soon removed after moving all related methods
and m_isolatedWorlds and m_isolatedWorldSecurityOrigins.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):
(WebCore::V8Proxy::isolatedWorlds):
(WebCore::V8Proxy::isolatedWorldSecurityOrigins):

6:17 PM Changeset in webkit [124961] by Lucas Forschler
  • 32 edits
    8 copies in branches/safari-536.26-branch

Merged r124815. <rdar://problem/12043765>

6:10 PM Changeset in webkit [124960] by yosin@chromium.org
  • 3 edits
    2 adds in trunk

translateZ(0) shifts file name in file input
https://bugs.webkit.org/show_bug.cgi?id=69248

Reviewed by Simon Fraser.

Source/WebCore:

This patch changes to use relative y-coordinate rather than absolute
y-coordinate for baseline of text of input type "file" what we've already
done for file icon y-coordinate.

Test: file-appearance-transform-no-effects.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject): Changed to use paintOffset
instead of absoluteBoundingBoxRectIgnoringTransforms().

LayoutTests:

This patch introduces a new test for input type "file" with CSS transform
translate(0).

  • fast/forms/file/file-appearance-transform-no-effects-expected.html: Added. "-webkit-transform: translate(0)" should not have visual effects.
  • fast/forms/file/file-appearance-transform-no-effects.html: Added.
6:10 PM Changeset in webkit [124959] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r124652. <rdar://problem/12043765>

6:08 PM Changeset in webkit [124958] by dpranke@chromium.org
  • 14 edits in trunk/Tools

nrwt: handle errors from image diff better
https://bugs.webkit.org/show_bug.cgi?id=92934

Reviewed by Ojan Vafai.

Re-land the change in r124801 with a fix ... in the case where
the ImageDiff is passed a tolerance and passes the fuzzy check,
we were returning the wrong value (missing an empty error
string) and crashing; this patch fixes that and adds a test for
that case (TestImageDiffer.test_image_diff_passed).

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_diff_image_crashed):

  • Scripts/webkitpy/layout_tests/port/image_diff.py:

(ImageDiffer.diff_image):
(ImageDiffer._read):

  • Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:

(TestImageDiffer.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.test_diff_image_crashed):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_diff_image_crashed.make_proc):

  • Scripts/webkitpy/layout_tests/port/server_process_mock.py:

(MockServerProcess.init):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

6:06 PM Changeset in webkit [124957] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: --no-build isn't working
https://bugs.webkit.org/show_bug.cgi?id=93415

Reviewed by Ryosuke Niwa.

Turns out our optimization to avoid calling
webkit-build-directory N times for each worker broke --no-build.

Fixing, and adding a test.

Also, the gtk port wasn't using the default check_build() logic,
but I don't know why not. Removing their custom hook and will
verify that this is okay in the review ...

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.check_build):
(Port._build_path):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.test_check_build):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(test_path_to_apache_config_file):
(test_check_build):
(test_check_build.build_driver_called):

6:06 PM Changeset in webkit [124956] by Lucas Forschler
  • 8 edits in branches/safari-536.26-branch

Merged r124649. <rdar://problem/12043765>

5:56 PM Changeset in webkit [124955] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace throwError(ExceptionCode, Isolate*) with
setDOMException(ExceptionCode, Isolate*) in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=93223

Reviewed by Adam Barth.

Now throwError(ExceptionCode, Isolate*) is equivalent to
setDOMException(ExceptionCode, Isolate*). We can replace the former
with the latter. After this replacement, the rule becomes simple
and sane: "Use throwError() for throwing JavaScript errors, use
setDOMException() for throwing DOM exceptions".

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::V8TestObj::constructorCallback):

5:54 PM Changeset in webkit [124954] by fsamuel@chromium.org
  • 17 edits in trunk/Source

Allow plugins to decide whether they are keyboard focusable
https://bugs.webkit.org/show_bug.cgi?id=88958

Reviewed by Anders Carlsson.

Source/WebCore:

  • dom/Node.h:

(WebCore::Node::isPluginElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

  • html/HTMLEmbedElement.h:

(HTMLEmbedElement):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetForJSBindings):

  • html/HTMLObjectElement.h:

(HTMLObjectElement):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::pluginWidget):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):
(WebCore):
(WebCore::HTMLPlugInElement::isPluginElement):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::supportsKeyboardFocus):

Source/WebKit/chromium:

  • public/WebPlugin.h:

(WebKit::WebPlugin::supportsKeyboardFocus):

  • src/WebInputEventConversion.cpp:

(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::supportsKeyboardFocus):
(WebKit):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

5:46 PM Changeset in webkit [124953] by annacc@chromium.org
  • 22 edits
    4 copies
    1 add in trunk/Source/WebCore

Create a MediaSource object.
https://bugs.webkit.org/show_bug.cgi?id=91773

Reviewed by Eric Carlson.

MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing:
https://bugs.webkit.org/show_bug.cgi?id=91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

New MediaSource object:

  • Modules/mediasource/MediaSource.cpp: Added.
  • Modules/mediasource/MediaSource.h: Added.
  • Modules/mediasource/MediaSource.idl: Added.

Create a registry for the blob storage and lookup:

  • Modules/mediasource/MediaSourceRegistry.cpp: Added.
  • Modules/mediasource/MediaSourceRegistry.h: Added.

Connect SourceBuffer to MediaSource:

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.

  • Modules/mediasource/SourceBuffer.h:

(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):

  • Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
  • Modules/mediasource/SourceBufferList.h:

Make MediaSource an EventTarget:

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Enable creation of MediaSource object URL from JavaScript:

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:

(WebCore):
(DOMURL):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: create a new sourceURLs list for storing

reigstered MediaSource URLS.

(WebCore::PublicURLManager::contextDestroyed): make sure everything is

removed from the sourceURLs list upon destruction.

(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs): getter for the sourceURLs list.

New MediaSource constructor:

  • page/DOMWindow.idl:
5:44 PM Changeset in webkit [124952] by haraken@chromium.org
  • 6 edits in trunk/Source

[V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods
https://bugs.webkit.org/show_bug.cgi?id=93209

Reviewed by Adam Barth.

By implementing V8Proxy::registerExtensionIfNeeded(), we can remove
registeredExtensionWithV8() and registerExtension().

No tests. No change in behavior.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::createNewContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::registerExtensionIfNeeded):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

Source/WebKit/chromium:

  • src/WebScriptController.cpp:

(WebKit::WebScriptController::registerExtension):

5:18 PM Changeset in webkit [124951] by Lucas Forschler
  • 5 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124510. <rdar://problem/12023616>

5:11 PM Changeset in webkit [124950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add new gclient-managed cc directory to Source/WebKit/chromium/.gitignore
https://bugs.webkit.org/show_bug.cgi?id=93403

Patch by James Robinson <jamesr@chromium.org> on 2012-08-07
Reviewed by Eric Seidel.

  • .gitignore:
5:08 PM Changeset in webkit [124949] by rniwa@webkit.org
  • 5 edits
    1 add in trunk

run-perf-tests should support --no-show-results
https://bugs.webkit.org/show_bug.cgi?id=93409

Reviewed by Dirk Pranke.

PerformanceTests:

Add a flot as a separate file and load it as an external resource.

Also include scripts as external resources from both local filesystem and webkit.org
so that it continues to work regardless of where you put it.

It breaks when someone else receives the file and save it somewhere and doesn't have
a network connection but that seems like a scenario we don't care that much.

  • resources/jquery.flot.min.js: Added.
  • resources/results-template.html:

Tools:

Add the support for --no-show-results.

Also replace only local paths to jquery and flot instead of embedding them.
The results page is still standalone in that it tries to load scripts
from both webkit.org and local filesystem.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_output_files):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner_and_setup_results_template):
(test_run_generates_and_show_results_page):
(test_run_respects_no_show_results):

5:05 PM Changeset in webkit [124948] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r124489. <rdar://problem/12021003>

4:58 PM Changeset in webkit [124947] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.26-branch

Merged r124463. <rdar://problem/12022148>

4:54 PM Changeset in webkit [124946] by gyuyoung.kim@samsung.com
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Unskip fast/dom/HTMLLinkElement/subresource.html
https://bugs.webkit.org/show_bug.cgi?id=93345

Reviewed by Eric Seidel.

In subresource.html case, existing expected result is for chromium port. So,
new subresource-expected.txt is needed for EFL port.

  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/HTMLLinkElement/subresource-expected.txt: Added.
4:52 PM Changeset in webkit [124945] by ryuan.choi@samsung.com
  • 8 edits
    1 move
    1 add
    1 delete in trunk/Source

[EFL] Remove PlatformTouchEventEfl and PlatformTouchPointEfl
https://bugs.webkit.org/show_bug.cgi?id=93270

Reviewed by Eric Seidel.

Source/WebCore:

PlatformTouchEventEfl and PlatformTouchPointEfl initialize PlatformTouchEvent
directly from Ewk_TouchEvent which is WebKit1/Efl API and they can not be
shared with WebKit2/Efl.

In order to remove this WebKit dependency from WebCore, this patch removes Efl
specific codes from PlatformTouchXXX and adds the classes which convert
Ewk_Touch_XXX to PlatformTouchXXX.

No new tests. Just a refactoring.

  • PlatformEfl.cmake: Removed PlatformTouchEventEfl.cpp and PlatformTouchPointEfl.cpp
  • platform/PlatformTouchEvent.h: Removed Efl specific codes.

(PlatformTouchEvent):

  • platform/PlatformTouchPoint.h: Ditto.

(PlatformTouchPoint):

  • platform/efl/PlatformTouchEventEfl.cpp: Removed.
  • platform/efl/PlatformTouchPointEfl.cpp: Removed.

Source/WebKit:

  • PlatformEfl.cmake: Added ewk_touch_event.cpp

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

  • ewk/ewk_touch_event.cpp: Added.

(WebKitPlatformTouchPoint):
(WebKitPlatformTouchPoint::WebKitPlatformTouchPoint):
Added to initialize members of PlatformTouchPoint.
(WebKitPlatformTouchEvent):
(WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
Added to initialize members of PlatformTouchEvent.
(EWKPrivate):
(EWKPrivate::platformTouchEvent):
Converted Ewk_Touch_Event to PlatformTouchEvent.

  • ewk/ewk_touch_event_private.h:

(EWKPrivate):

4:50 PM Changeset in webkit [124944] by Lucas Forschler
  • 6 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r124393. <rdar://problem/12043765>

4:47 PM Changeset in webkit [124943] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.3

New Tag.

4:45 PM Changeset in webkit [124942] by Lucas Forschler
  • 3 edits
    1 add in branches/safari-536.26-branch/WebKitLibraries

Merged r124363. <rdar://problem/12011861>

4:44 PM Changeset in webkit [124941] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Avoid dependending on implicit WebString -> String conversion in compositor
https://bugs.webkit.org/show_bug.cgi?id=93408

Reviewed by Adrienne Walker.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::initialize):

4:38 PM Changeset in webkit [124940] by haraken@chromium.org
  • 5 edits
    2 adds in trunk/Source/WebCore

[V8] Factor out V8Binding methods that configures DOM attributes and methods
https://bugs.webkit.org/show_bug.cgi?id=93239

Reviewed by Adam Barth.

V8Binding is messy. This patch factors out V8Binding methods that configures
DOM attributes and methods into another file. This patch just moves the methods
from V8Binding.{h,cpp} to V8ConfigureDOMAttributesAndMethods.{h,cpp}.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8ConfigureDOMAttributesAndMethods.cpp: Added.

(WebCore):
(WebCore::batchConfigureAttributes):
(WebCore::batchConfigureConstants):
(WebCore::batchConfigureCallbacks):
(WebCore::configureTemplate):

  • bindings/v8/V8ConfigureDOMAttributesAndMethods.h: Added.

(WebCore):
(BatchedAttribute):
(WebCore::configureAttribute):
(BatchedConstant):
(BatchedCallback):

4:37 PM Changeset in webkit [124939] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123942. <rdar://problem/11979232>

4:31 PM Changeset in webkit [124938] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Replace all V8 undefined values in the rest of custom bindings with v8Undefined()
https://bugs.webkit.org/show_bug.cgi?id=93220

Reviewed by Eric Seidel.

We should use v8Undefined() everywhere in V8 bindings.
This patch replaces all V8 undefined values in the rest of custom bindings
with v8Undefined().

No tests. No change in behavior.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyQuery): Simple refactoring not related to
this patch. Since other bindings are using 0 instead of v8::None, we should use 0 here too.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

4:30 PM Changeset in webkit [124937] by Lucas Forschler
  • 8 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123930. <rdar://problem/11979235>

4:24 PM Changeset in webkit [124936] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

Add Bruno Abinader's blog feed to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=92985

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-07
Reviewed by Eric Seidel.

  • config.ini:
4:19 PM Changeset in webkit [124935] by Lucas Forschler
  • 9 edits in branches/safari-536.26-branch/Source

Merged r123907. <rdar://problem/12043772>

4:14 PM Changeset in webkit [124934] by Lucas Forschler
  • 15 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123811. <rdar://problem/12043772>

4:13 PM Changeset in webkit [124933] by haraken@chromium.org
  • 30 edits in trunk/Source/WebCore

[V8] Remove #include V8BindingMacros.h
https://bugs.webkit.org/show_bug.cgi?id=93312

Reviewed by Eric Seidel.

We are factoring out V8Binding methods to separate files.
After the refactoring, V8Binding.h will include binding related
header files (e.g. V8BindingMacros.h, V8BindingHelper.h, etc), so that
custom V8 binding files just need to include V8Binding.h only.

We can remove '#include V8BindingMacros.h' from V8 binding files.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(ConvertToV8Parameter):

  • bindings/scripts/test/V8/V8Float64Array.cpp:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/custom/V8BlobCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
  • bindings/v8/custom/V8IntentConstructor.cpp:
  • bindings/v8/custom/V8MutationObserverCustom.cpp:
  • bindings/v8/custom/V8PerformanceCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebKitAnimationCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
3:58 PM Changeset in webkit [124932] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Clean up WebScriptController.h comments
https://bugs.webkit.org/show_bug.cgi?id=93399

Reviewed by Adam Barth.

Remove references to overloaded WebScriptController::registerExtension
variants. They were removed in r68666.

  • public/WebScriptController.h:

(WebScriptController):

3:56 PM Changeset in webkit [124931] by haraken@chromium.org
  • 13 edits in trunk/Source

[V8] Remove #include Frame.h from V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=93326

Reviewed by Adam Barth.

We want to remove unnecessary #include in V8Binding.h
to avoid circular include dependency.

No tests. No change in behavior.

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
  • bindings/scripts/test/V8/V8TestNode.cpp:
  • bindings/v8/ScheduledAction.cpp:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8SVGDocumentCustom.cpp:
  • testing/v8/WebCoreTestSupport.cpp:

Source/WebKit/chromium:

  • src/WebBindings.cpp:
3:55 PM Changeset in webkit [124930] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Refactor magic numbers in the ARM port of DFG-JIT
https://bugs.webkit.org/show_bug.cgi?id=93348

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-07
Reviewed by Eric Seidel.

Introduce new names for hard-coded magic numbers.
Refactor constant with confusing names to more descriptive ones.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::patchConstantPoolLoad):
(JSC::ARMAssembler::getOp2):
(JSC::ARMAssembler::genInt):
(JSC::ARMAssembler::getImm):
(JSC::ARMAssembler::moveImm):
(JSC::ARMAssembler::encodeComplexImm):
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::emitInstruction):
(JSC::ARMAssembler::ands_r):
(JSC::ARMAssembler::eors_r):
(JSC::ARMAssembler::subs_r):
(JSC::ARMAssembler::rsbs_r):
(JSC::ARMAssembler::adds_r):
(JSC::ARMAssembler::adcs_r):
(JSC::ARMAssembler::sbcs_r):
(JSC::ARMAssembler::rscs_r):
(JSC::ARMAssembler::tst_r):
(JSC::ARMAssembler::teq_r):
(JSC::ARMAssembler::cmp_r):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::orrs_r):
(JSC::ARMAssembler::movs_r):
(JSC::ARMAssembler::bics_r):
(JSC::ARMAssembler::mvns_r):
(JSC::ARMAssembler::muls_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::dtrh_u):
(JSC::ARMAssembler::dtrh_ur):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::getLdrImmAddress):
(JSC::ARMAssembler::getLdrImmAddressOnPool):
(JSC::ARMAssembler::patchConstantPoolLoad):
(JSC::ARMAssembler::repatchCompact):
(JSC::ARMAssembler::replaceWithJump):
(JSC::ARMAssembler::replaceWithLoad):
(JSC::ARMAssembler::replaceWithAddressComputation):
(JSC::ARMAssembler::getOp2Byte):
(JSC::ARMAssembler::getOp2Half):
(JSC::ARMAssembler::getImm16Op2):
(JSC::ARMAssembler::placeConstantPoolBarrier):
(JSC::ARMAssembler::getConditionalField):

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

3:53 PM Changeset in webkit [124929] by haraken@chromium.org
  • 5 edits
    2 adds in trunk/Source/WebCore

[V8] Factor out V8Binding classes that manage V8 value's cache
https://bugs.webkit.org/show_bug.cgi?id=93343

Reviewed by Adam Barth.

We are factoring out V8Binding methods to separate files.
This patch moves V8Binding classes that manage V8 value's cache
to V8ValueCache.{h,cpp}.

No tests. No change in behavior.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8ValueCache.cpp: Added.

(WebCore):
(WebCore::makeExternalString):
(WebCore::cachedStringCallback):
(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):
(WebCore::IntegerCache::createSmallIntegers):
(WebCore::IntegerCache::~IntegerCache):

  • bindings/v8/V8ValueCache.h: Added.

(WebCore):
(StringCache):
(WebCore::StringCache::StringCache):
(WebCore::StringCache::v8ExternalString):
(WebCore::StringCache::clearOnGC):
(WebCoreStringResource):
(WebCore::WebCoreStringResource::WebCoreStringResource):
(WebCore::WebCoreStringResource::~WebCoreStringResource):
(WebCore::WebCoreStringResource::data):
(WebCore::WebCoreStringResource::length):
(WebCore::WebCoreStringResource::webcoreString):
(WebCore::WebCoreStringResource::atomicString):
(WebCore::WebCoreStringResource::visitStrings): This method is used by inspector
and thus is not performance-critical. To avoid circular #include dependency,
I moved the implementation to cpp.
(WebCore::WebCoreStringResource::toStringResource):
(IntegerCache):
(WebCore::IntegerCache::IntegerCache):
(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):

3:39 PM Changeset in webkit [124928] by dpranke@chromium.org
  • 4 edits in trunk/Tools

test-webkitpy hangs in a new checkout on snow leopard
https://bugs.webkit.org/show_bug.cgi?id=93301

Reviewed by Ryosuke Niwa.

This change works around what appears to be a bug in Python
2.6.1 (the version that ships on Mac Snow Leopard) that causes
the multiprocessing module to hang after we use the
autoinstaller; I'm guessing it's some sort of python sockets
issue. I was unable to reproduce this with 2.6.5 or newer
versions of Python.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller.install):

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mechanize):
(AutoinstallImportHook._install_pep8):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_buildbot):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_irc):
(AutoinstallImportHook._install_webpagereplay):
(AutoinstallImportHook._install):
(autoinstall_everything):

3:30 PM Changeset in webkit [124927] by jamesr@google.com
  • 20 edits in trunk/Source

[chromium] Switch PlatformLayer typedef to Platform API type for PLATFORM(CHROMIUM)
https://bugs.webkit.org/show_bug.cgi?id=93335

Reviewed by Adrienne Walker.

Source/Platform:

Add APIs to control scrolling behavior on WebScrollableLayer.

  • chromium/public/WebScrollableLayer.h:

(WebScrollableLayer):

Source/WebCore:

This converts the PlatformLayer typedef to WebKit::WebLayer (part of the chromium Platform API) for the
Chromium port. This involves some odd const_cast<>s in places since cross-platform interfaces assume that
PlatformLayer is a potentially heavy implementation class, but WebLayer is a thin smart pointer type.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):

  • platform/graphics/PlatformLayer.h:

(WebKit):
(WebCore):

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::layer):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(Canvas2DLayerBridge):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::layer):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setDrawsContent):
(WebCore::GraphicsLayerChromium::setContentsVisible):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::primaryLayer):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::updateChildList):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

Source/WebKit/chromium:

Update for new PlatformLayer typedef. This removes knowledge of WebCore::LayerChromium from all classes
except for NonCompositedContentHost, which still punches through for a few minor APIs that I'll address
in a separate patch.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::scrollLayer):
(WebKit::NonCompositedContentHost::notifySyncRequired):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::platformLayer):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::platformLayer):

  • src/WebPluginContainerImpl.h:

(WebCore):
(WebPluginContainerImpl):

  • src/WebScrollableLayer.cpp:

(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setRootGraphicsLayer):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::TEST_F):

3:22 PM Changeset in webkit [124926] by kerz@chromium.org
  • 1 copy in branches/chromium/1229

Branch for Chromium 1229

3:01 PM Changeset in webkit [124925] by jamesr@google.com
  • 11 edits in trunk/Source

[chromium] Use WebCompositor interface in Platform API instead of CCProxy to query threaded compositor status
https://bugs.webkit.org/show_bug.cgi?id=93398

Reviewed by Adam Barth.

Source/Platform:

Adds thread status query interfaces to WebCompositor for WebKit code that wants to know if we are in threaded
mode.

  • chromium/public/WebCompositor.h:

(WebCompositor):

Source/WebCore:

Converts non-compositor code that cares about threaded compositing status over to query WebCompositor instead of
CCProxy.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
  • platform/chromium/support/WebCompositorImpl.cpp:

(WebKit):
(WebKit::WebCompositor::threadingEnabled):
(WebKit::WebCompositor::onCompositorThread):
(WebKit::WebCompositorImpl::threadingEnabled):

  • platform/chromium/support/WebCompositorImpl.h:

(WebCompositorImpl):

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

Source/WebKit/chromium:

Converts non-compositor code that cares about threaded compositing status over to query WebCompositor instead of
CCProxy.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::scheduleComposite):

2:54 PM Changeset in webkit [124924] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Knob slot animation is flipped
https://bugs.webkit.org/show_bug.cgi?id=93396

Reviewed by Beth Dakin.

When painting the scrollbar knob slot, use rectForPart: since it correctly takes the expansion transition state into account.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::scrollbarPainterPaint):

2:53 PM Changeset in webkit [124923] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/Source/WebKit2

[Qt] New API tests introuduced in r119723 marked as fail, but pass
https://bugs.webkit.org/show_bug.cgi?id=88870

Reviewed by Alexis Menard.

Revert r119723, because there are 2 failing tests, and the author and
the reviewer of the original patch ignore the bug report long time ago.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml: Removed.
2:46 PM Changeset in webkit [124922] by benjamin@webkit.org
  • 6 edits in trunk/Source

Use the initialization from literal for JSC's Identifiers
https://bugs.webkit.org/show_bug.cgi?id=93193

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patches modify Identifier ot take advantage of the new initialization from literal.

In addition to the memory savings (~600bytes per instance), this gives us a 2% speed
improvement on CommonIdentifiers on average.

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):
Null and empty strings are forbidden for literal initialization. Use the most efficient constructors
instead of a literal.

  • runtime/Identifier.cpp:

(IdentifierASCIIStringTranslator):
Rename IdentifierCStringTranslator to IdentifierASCIIStringTranslator to make the text encoding
explicit.
(JSC::IdentifierASCIIStringTranslator::hash):
(JSC::IdentifierASCIIStringTranslator::equal):
(JSC::IdentifierASCIIStringTranslator::translate): Use the fast initialization from literal.
(JSC::Identifier::add):

  • runtime/Identifier.h:

(JSC::Identifier::Identifier):

Source/WTF:

  • wtf/text/StringImpl.h: Update the names for the HashTranslator used by Identifier.
2:42 PM Changeset in webkit [124921] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merged r124259. <rdar://problem/12043772>

2:36 PM Changeset in webkit [124920] by hclam@chromium.org
  • 9 edits
    1 move in trunk/LayoutTests

Share http/tests/media/video-load-and-stall.cgi for other tests
https://bugs.webkit.org/show_bug.cgi?id=93389

Reviewed by Eric Carlson.

Moving http/tests/media/video-laod-and-stall.cgi to
http/tests/resources/load-and-stall.cgi.

Also changes tests that use this file to point to the new location.

  • http/tests/media/remove-while-loading.html:
  • http/tests/media/video-play-stall-before-meta-data.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/resources/load-and-stall.cgi: Renamed from LayoutTests/http/tests/media/video-load-and-stall.cgi.
  • http/tests/security/contentSecurityPolicy/media-src-allowed.html:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked.html:
  • platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
2:33 PM Changeset in webkit [124919] by enne@google.com
  • 2 edits in trunk/Source/WebCore

50% fixed position coverage slow scroll heuristic is incorrect when invalidations aren't clipped
https://bugs.webkit.org/show_bug.cgi?id=92011

Reviewed by Simon Fraser.

The heuristic in scrollContentsFastPath to slow scroll by invalidating
the entire frame if fixed position elements cover 50% of the frame
takes away the ability of ports to make their own decisions about how
to best handle invalidations. Therefore, remove this heuristic.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

2:31 PM Changeset in webkit [124918] by kpiascik@rim.com
  • 4 edits in trunk/Source

[BlackBerry] Change how devicePixelRatio is set.
https://bugs.webkit.org/show_bug.cgi?id=93385

Reviewed by Antonio Gomes.

Source/WebCore:

Update the theme to adjust to a constant devicePixelRatio.

Not testable.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::determineFullScreenMultiplier):

Source/WebKit/blackberry:

Change devicePixelRatio to be set immediately after the page is created based
on the WebSetting.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

2:23 PM Changeset in webkit [124917] by jamesr@google.com
  • 7 edits
    5 moves in trunk/Source

Source/Platform: [chromium] Move WebCompositor interface into Platform API
https://bugs.webkit.org/show_bug.cgi?id=93391

Reviewed by Adam Barth.

WebCompositor is logically part of the Platform API, along with WebLayerTreeView and the WebLayer types.

  • chromium/public/WebCompositor.h: Renamed from Source/WebKit/chromium/public/WebCompositorClient.h.

(WebKit):
(WebCompositor):
(WebKit::WebCompositor::~WebCompositor):

Source/WebCore: [chromium] Move WebCompositor interface into Platform API
https://bugs.webkit.org/show_bug.cgi?id=93391

Reviewed by Adam Barth.

Moves the support files for WebCompositor into WebCore/platform/support/. CCThreadImpl is a helper class used
only by WebCompositorImpl.

Refactor/renaming only, so no new tests.

  • WebCore.gypi:
  • platform/chromium/support/CCThreadImpl.cpp: Renamed from Source/WebKit/chromium/src/CCThreadImpl.cpp.

(WebKit):
(GetThreadIDTask):
(WebKit::GetThreadIDTask::GetThreadIDTask):
(WebKit::GetThreadIDTask::~GetThreadIDTask):
(WebKit::GetThreadIDTask::run):
(CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::~CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::run):
(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::~CCThreadImpl):
(WebKit::CCThreadImpl::postTask):
(WebKit::CCThreadImpl::postDelayedTask):
(WebKit::CCThreadImpl::threadID):
(WebKit::CCThreadImpl::CCThreadImpl):

  • platform/chromium/support/CCThreadImpl.h: Renamed from Source/WebKit/chromium/src/CCThreadImpl.h.

(WebKit):
(CCThreadImpl):

  • platform/chromium/support/WebCompositorImpl.cpp: Renamed from Source/WebKit/chromium/src/WebCompositorImpl.cpp.

(WebKit):
(WebKit::WebCompositor::initialize):
(WebKit::WebCompositor::shutdown):
(WebKit::WebCompositor::setPerTilePaintingEnabled):
(WebKit::WebCompositor::setPartialSwapEnabled):
(WebKit::WebCompositor::setAcceleratedAnimationEnabled):
(WebKit::WebCompositorImpl::initialize):
(WebKit::WebCompositorImpl::initialized):
(WebKit::WebCompositorImpl::shutdown):

  • platform/chromium/support/WebCompositorImpl.h: Renamed from Source/WebKit/chromium/src/WebCompositorImpl.h.

(WebCore):
(WebKit):
(WebCompositorImpl):

Source/WebKit/chromium: [chromium] Move WebCompositor interface into Platform AP
https://bugs.webkit.org/show_bug.cgi?id=93391

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebCompositor.h:
  • src/WebLayerTreeViewImpl.cpp:
2:14 PM Changeset in webkit [124916] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-536.26-branch

Merged r121929. <rdar://problem/12044194>

1:33 PM Changeset in webkit [124915] by dino@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93387

Unreviewed. Temporarily skipping failing tests on Mac.

  • platform/mac/TestExpectations:
1:21 PM Changeset in webkit [124914] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in ContainerNode::cloneChildNodes.
https://bugs.webkit.org/show_bug.cgi?id=93378

Reviewed by Levi Weintraub.

Source/WebCore:

Re-enabling the editing delete button controller in cloneChildNode was causing style changes,
thereby causing load events to fire. The load event can blow our nodes from underneath. This causes
crashes when we are nested inside cloneChildNodes. The patch just skips the delete button controller's
container element from being cloned and removes the hacky enable/disable logic.

Test: fast/dom/clone-node-load-event-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::cloneChildNodes):

LayoutTests:

  • fast/dom/clone-node-load-event-crash-expected.txt: Added.
  • fast/dom/clone-node-load-event-crash.html: Added.
1:15 PM Changeset in webkit [124913] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] [FullScreen] No need to scroll 'x' to 0 before entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=91750
PR #178293

Reviewed by Rob Buis.
Patchby Antonio Gomes <agomes@rim.com>

We are not adjusting the 'left' CSS property of the fullscreen wrapper
properly, so no need to scroll 'x' to 0 anymore.

Internally reviewed by Jacky Jiang.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):

1:15 PM Changeset in webkit [124912] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry][FullScreen] Remove the set/reset of touch modes code when entering/leaving fullscreen
https://bugs.webkit.org/show_bug.cgi?id=92520
PR #184511

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

Internally reviewed by Gen Mak.

Remove touch mode set/reset when entering/leaving fullscreen
for media elements through the new FULLSCREEN_API code path.
The client now handles it.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:06 PM Changeset in webkit [124911] by kpiascik@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add missing include in FrameLoaderClienBlackBerry after Base64 moved.
https://bugs.webkit.org/show_bug.cgi?id=93383

Reviewed by Rob Buis.

Base64 moved from platform/text to wtf/text, need to add mssing
include.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1:04 PM Changeset in webkit [124910] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-536.26-branch

Merged r118236. <rdar://problem/11942147>

12:52 PM Changeset in webkit [124909] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=93381

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._push_executable): Remove temporary lines as the chromium change has been landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150371
(ChromiumAndroidDriver._setup_performance): Update all scaling governor files.
(ChromiumAndroidDriver._teardown_performance): Update all scaling governor files.

12:49 PM Changeset in webkit [124908] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source

GraphicsLayerAnimation shouldn't use HashMap<String>
https://bugs.webkit.org/show_bug.cgi?id=93284

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use a vector containing all the animations instead of a map of String to Vector.
The HashMap contains very few elements, which makes it inefficient relatively to a vector.
This has been shown to be a bottleneck in valgrind.

Covered by existing animation tests.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::remove):
(WebCore::GraphicsLayerAnimations::apply):

  • platform/graphics/GraphicsLayerAnimation.h:

(GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimation::name):
(GraphicsLayerAnimations):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

Source/WebKit2:

Apply the changes to GraphicsLayerAnimation API.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):

12:30 PM Changeset in webkit [124907] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, TestExpectations update.
https://bugs.webkit.org/show_bug.cgi?id=72039

12:25 PM Changeset in webkit [124906] by wjmaclean@chromium.org
  • 6 edits in trunk

[chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
https://bugs.webkit.org/show_bug.cgi?id=93286

Reviewed by James Robinson.

Tools:

Adds support to generate GestureTapDown events from EventSender, to facilitate
link highlighting layout tests.

Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.

  • DumpRenderTree/chromium/TestRunner/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureTapDown):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/EventSender.h:

(EventSender):

LayoutTests:

Adds support to generate GestureTapDown events from EventSender, to facilitate
link highlighting layout tests.

Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.

  • platform/chromium/plugins/gesture-events-expected.txt:
  • platform/chromium/plugins/gesture-events.html:
12:09 PM Changeset in webkit [124905] by kpiascik@rim.com
  • 3 edits
    2 moves in trunk/Source/WebKit

[BlackBerry] InspectorOverlay class duplicated in WebCore
https://bugs.webkit.org/show_bug.cgi?id=93124

Reviewed by Rob Buis.

Source/WebKit:

Updated InspectorOverlay build path.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Moved files to better align with namespace names.

  • WebKitSupport/InspectorOverlay.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp.

(WebKit):
(BlackBerry::WebKit::InspectorOverlay::create):
(BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
(BlackBerry::WebKit::InspectorOverlay::paintContents):
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
(BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::clear):
(BlackBerry::WebKit::InspectorOverlay::update):

  • WebKitSupport/InspectorOverlay.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h.

(WebCore):
(WebKit):
(InspectorOverlay):
(InspectorOverlayClient):
(BlackBerry::WebKit::InspectorOverlay::setClient):
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

12:03 PM Changeset in webkit [124904] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk

[Qt] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=90637

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-08-07
Reviewed by Alexis Menard.

Source/WebCore:

Adds support for Gamepad API on the Qt port.

The implementation of this class relies on the Linux
kernel joystick API.

Gamepad devices are recognized through the GamepadsQt
class, which uses the udev library to watch for connection,
disconnection and other gamepad related events.

Tests for this feature already exist.

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.pri:
  • platform/qt/GamepadsQt.cpp: Added.

(WebCore):
(GamepadDeviceLinuxQt):
(WebCore::GamepadDeviceLinuxQt::create):
(WebCore::GamepadDeviceLinuxQt::GamepadDeviceLinuxQt):
(WebCore::GamepadDeviceLinuxQt::~GamepadDeviceLinuxQt):
(WebCore::GamepadDeviceLinuxQt::readCallback):
(GamepadsQt):
(WebCore::GamepadsQt::GamepadsQt):
(WebCore::GamepadsQt::~GamepadsQt):
(WebCore::GamepadsQt::isGamepadDevice):
(WebCore::GamepadsQt::onGamePadChange):
(WebCore::GamepadsQt::registerDevice):
(WebCore::GamepadsQt::unregisterDevice):
(WebCore::GamepadsQt::updateGamepadList):
(WebCore::sampleGamepads):

Tools:

If the libudev library is present, the GAMEPAD flag is
turned on by default for the Qt port.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.prf:

LayoutTests:

This does not unskip the gamepad tests for the Qt port, since the flag is
optional the test would not pass without it. The user may unskip it manually.

On the other hand, the gamepad-polling-access.html test is still expected
to fail because it requires additional test infrastructure.
See https://bugs.webkit.org/show_bug.cgi?id=92873

  • platform/qt/TestExpectations:
12:01 PM Changeset in webkit [124903] by rwlbuis@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] Turn on CSS Variables
https://bugs.webkit.org/show_bug.cgi?id=93376

Reviewed by Antonio Gomes.

Turn on CSS Variables for BlackBerry port.

  • Scripts/webkitperl/FeatureList.pm:
11:55 AM Changeset in webkit [124902] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r124865): It broke the ARM Chromium build
https://bugs.webkit.org/show_bug.cgi?id=93364

Patch by Joshua Bell <jsbell@chromium.org> on 2012-08-07
Reviewed by Csaba Osztrogonác.

Mark large constant with LL to satisfy a picky compiler.

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

11:44 AM Changeset in webkit [124901] by reed@google.com
  • 2 edits in trunk/Source/WebCore

reimplement fastMod w/o (soon to be) private skia macros
https://bugs.webkit.org/show_bug.cgi?id=93370

Reviewed by Adrienne Walker.

fastMod() reimplemented (same functionality) to stop using soon-to-be private macros in
SkMath.h. The new version is functionally identical.

No new tests -- existing layouttests exercise GraphicsContext::strokeArc(), the only caller

  • platform/graphics/skia/GraphicsContextSkia.cpp:
11:44 AM Changeset in webkit [124900] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/LayoutTests

Move test cases related to link prerender to Skipped list except for chromium port
https://bugs.webkit.org/show_bug.cgi?id=93355

Reviewed by Adam Barth.

Below two test cases have tested by each port, which doesn't enable LINK_PRERENDER macro.
These test cases need to be moved to Skipped file until this feature is supported by each port.

fast/dom/HTMLLinkElement/prerender-insert-after-stop.html
fast/dom/HTMLLinkElement/prerender-remove-after-stop.html

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
11:31 AM Changeset in webkit [124899] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding back platform-specific expectations that
somehow got removed in r124874.

  • platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
11:29 AM Changeset in webkit [124898] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Add CCDelayBasedTimeSource::setTimebaseAndInterval
https://bugs.webkit.org/show_bug.cgi?id=92825

Patch by Brian Anderson <brianderson@chromium.org> on 2012-08-07
Reviewed by James Robinson.

Allows CCDelayBaseTimeSource to have it's timebase and interval updated
on the fly. Accounts for double ticking due to jitter or resetting the
timer multiple times quickly.

CCDelayBasedTimeSourceTest updated with two tests for proper handling
of jittery timebase/interval source and immediate handling of
significant timebase/interval changes.

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::nextTickTime):
(WebCore):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::setTimebaseAndInterval):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
11:17 AM Changeset in webkit [124897] by Alexandru Chiculita
  • 14 edits
    4 adds in trunk

[CSS Shaders] Reuse precompiled shaders across elements
https://bugs.webkit.org/show_bug.cgi?id=88427

Reviewed by Dean Jackson.

Source/WebCore:

Added CustomFilterProgramInfo as a link between the CustomFilterProgram and the CustomFilterCompiledProgram.
CustomFilterGlobalContext now acts as a cache for the compiled shaders. Note that only the shaders displayed on the page
are cached, making it useful in animations or when more elements share the same shader filter.

For CSS Shaders we need two files, vertex and fragment shaders, so that's why we have a CustomFilterProgram.
CustomFilterProgram is the platform object, so StyleCustomFilterProgram implements it and is referenced from the RenderStyle.

StyleCustomFilterProgram is also the one that actually keeps references to the CachedShaders and has all the loading logic.
The only problem is that there might be multiple StyleCustomFilterProgram with the same set of CachedShaders.
That's why in this patch I've added CustomFilterProgramInfo as a simple class to be used as a key in a hash map.

For now CustomFilterProgramInfo should act similar to a pair<String, String>. There's only one exception: one of the strings
is allowed to be null. A null string is the placeholder for the default shader.

Note that alpha compositing and blending will be added to the CustomFilterProgramInfo after the mix()
function parsing will land in https://bugs.webkit.org/show_bug.cgi?id=90101 .

Test: css3/filters/custom/custom-filter-shader-reuse.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
(WebCore::CustomFilterCompiledProgram::getDefaultShaderString): Returns the default shader based on the type.
(WebCore):
(WebCore::CustomFilterCompiledProgram::compileShader): Added check for isNull and used the default shader in that case.
(WebCore::CustomFilterCompiledProgram::~CustomFilterCompiledProgram): Added call to CustomFilterGlobalContext::removeCompiledProgram.

  • platform/graphics/filters/CustomFilterCompiledProgram.h:

(WebCore::CustomFilterCompiledProgram::detachFromGlobalContext): Called from ~CustomFilterGlobalContext, so that it doesn't call into a deleted object later when ~CustomFilterCompiledProgram is called. It should only happen when CustomFilterGlobalContext dies before the
CustomFilterCompiledPrograms that it caches.
(WebCore):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::getCompiledProgram): Gets or creates a compiled shader for a specific CustomFilterProgramInfo.
(WebCore):
(WebCore::CustomFilterGlobalContext::removeCompiledProgram): Called by ~CustomFilterCompiledProgram.

  • platform/graphics/filters/CustomFilterGlobalContext.h:

(WebCore):
(CustomFilterGlobalContext):

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::programInfo):

  • platform/graphics/filters/CustomFilterProgram.h:

(WebCore):

  • platform/graphics/filters/CustomFilterProgramInfo.cpp: Added.

(WebCore):
(WebCore::hashPossiblyNullString): We need to allow null strings in the hash, so this is a helper to check for isNull
before asking for the hash.
(WebCore::CustomFilterProgramInfo::CustomFilterProgramInfo):
(WebCore::CustomFilterProgramInfo::isEmptyValue):
(WebCore::CustomFilterProgramInfo::isHashTableDeletedValue):
(WebCore::CustomFilterProgramInfo::hash):
(WebCore::CustomFilterProgramInfo::operator==):

  • platform/graphics/filters/CustomFilterProgramInfo.h: Added.

(WebCore):
(CustomFilterProgramInfo):
(WebCore::CustomFilterProgramInfo::vertexShaderString):
(WebCore::CustomFilterProgramInfo::fragmentShaderString):
(WebCore::CustomFilterProgramInfoHash::hash):
(WebCore::CustomFilterProgramInfoHash::equal):
(CustomFilterProgramInfoHash): Structures needed to make this a key in the hash map.
(CustomFilterProgramInfoHashTraits):
(WebCore::CustomFilterProgramInfoHashTraits::isEmptyValue): I've used the deleted strings value to mark a deleted
CustomFilterProgramInfo object. Those are not safe to compare to deleted, so there's a need to set safeToCompareToEmptyOrDeleted to false, meaning that there's a need to manually check for empty values.
(WTF):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::initializeContext): Moved to using the cached shader instead.

LayoutTests:

Added a new test to check for cases when CSS Shaders are removed and readded. Two cases are verified in the new test:

  1. When all the shaders are removed.
  2. When only some of the shaders are removed.
  • css3/filters/custom/custom-filter-shader-reuse-expected.txt: Added.
  • css3/filters/custom/custom-filter-shader-reuse.html: Added.
11:13 AM Changeset in webkit [124896] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Fix GTK+ build with GTK2 after r120918.

  • tests/testwebview.c:
9:30 AM Changeset in webkit [124895] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed build fix after r124879.

Patch by Florin Malita <fmalita@chromium.org> on 2012-08-07

  • WebCore.gypi: Remove deleted file references.
8:58 AM Changeset in webkit [124894] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] We should fail the HTTP auth silently for non-main loads
in the non-viewer process.
https://bugs.webkit.org/show_bug.cgi?id=93230

Reviewed by Rob Buis.

No way to test this in WebKit.

  • platform/network/blackberry/NetworkJob.cpp: Add early return.

(WebCore::NetworkJob::sendRequestWithCredentials):

8:40 AM Changeset in webkit [124893] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Typing backslash in Console traverses the panel history when using German keyboard layout
https://bugs.webkit.org/show_bug.cgi?id=93357

Reviewed by Vsevolod Vlasov.

For some reason, in the German keyboard layout keyIdentifier for '\' is the same as that for '['
in the ordinary English-US layout.
Remove a too-safe-side check and never switch panels on key combinations that result in "keypress" events.

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._keyPress):

8:28 AM Changeset in webkit [124892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GL scissor test is accidentally turned off
https://bugs.webkit.org/show_bug.cgi?id=93360
PR #161020

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-07
Reviewed by Antonio Gomes.

The GL scissor test is accidentally turned off inside drawTextures().
This is wrong and should be removed.

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):

8:28 AM Changeset in webkit [124891] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Add test expectation after r124874
https://bugs.webkit.org/show_bug.cgi?id=93367

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-07

  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
8:06 AM Changeset in webkit [124890] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

ASSERTION FAILED: isEndOfParagraph(endOfParagraphToMove) crash on fast/lists/list-marker-remove-crash.html after r124739
https://bugs.webkit.org/show_bug.cgi?id=93247

Unreviewed gardening. Add DEBUG modifier for fast/lists/list-marker-remove-crash.html, because there are asserts in debug mode only.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
8:04 AM Changeset in webkit [124889] by Simon Hausmann
  • 16 edits in trunk

[Qt] Make it possible to build without QtQuick

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-08-07
Reviewed by Simon Hausmann.

.:

  • Source/QtWebKit.pro:
  • Source/tests.pri:

Source/WebKit:

  • WebKit1.pri:

Source/WebKit2:

  • Target.pri:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.cpp:
  • UIProcess/API/qt/tests/util.h:
  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):

  • WebKit2.pri:

Tools:

  • Tools.pro:
  • qmake/mkspecs/features/features.prf:
7:51 AM Changeset in webkit [124888] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in InlineFlowBox::deleteLine.
https://bugs.webkit.org/show_bug.cgi?id=88795

Reviewed by Tony Chang.

Source/WebCore:

When we move the fullscreen object from its parent to RenderFullScreen, we forgot to clear the
line box tree underneath the object's containing block and mark it for layout. Before the patch,
the containing block never got laid out and maintained references to removed line boxes (since the
object moved under RenderFullScreen did get laid out and its lineboxes replaced with new ones).

Test: fullscreen/full-screen-line-boxes-crash.html

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::wrapRenderer):

LayoutTests:

  • fullscreen/full-screen-line-boxes-crash-expected.txt: Added.
  • fullscreen/full-screen-line-boxes-crash.html: Added.
7:32 AM Changeset in webkit [124887] by mifenton@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update API for spell checking suggestions.
https://bugs.webkit.org/show_bug.cgi?id=93356

Reviewed by Antonio Gomes.

PR 163283.

Add connections for updated spell checking options request API. Move
all this logic into InputHandler.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
(WebKit):
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

  • WebKitSupport/InputHandler.h:

(Platform):
(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

6:52 AM Changeset in webkit [124886] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Do not disable network tracking while profiling cpu.
https://bugs.webkit.org/show_bug.cgi?id=93359

Reviewed by Yury Semikhatsky.

Removed network tracking enabling/disabling machinery.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType.prototype.buttonClicked):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

6:52 AM Changeset in webkit [124885] by Csaba Osztrogonác
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
6:50 AM Changeset in webkit [124884] by commit-queue@webkit.org
  • 96 edits in trunk/Source

Web Inspector: make the MemoryClassInfo class a not-template
https://bugs.webkit.org/show_bug.cgi?id=93265

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-08-07
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::reportDescendantMemoryUsage):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::reportDescendantMemoryUsage):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::reportDescendantMemoryUsage):

  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):

  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::reportDescendantMemoryUsage):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportDescendantMemoryUsage):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reportDescendantMemoryUsage):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::reportDescendantMemoryUsage):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reportBaseClassMemoryUsage):

  • css/CSSRuleList.cpp:

(WebCore::StaticCSSRuleList::reportMemoryUsage):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::reportMemoryUsage):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reportDescendantMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):

  • css/CSSValue.cpp:

(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::reportDescendantMemoryUsage):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::reportDescendantMemoryUsage):

  • css/FontValue.cpp:

(WebCore::FontValue::reportDescendantMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::reportDescendantMemoryUsage):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::reportDescendantMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):

  • css/WebKitCSSMixFunctionValue.cpp:

(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::reportMemoryUsage):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::reportMemoryUsage):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::reportMemoryUsage):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::reportMemoryUsage):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::reportDescendantMemoryUsage):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::reportDescendantMemoryUsage):

Source/WebKit/chromium:

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::Instrumented::reportMemoryUsage):
(WebCore::InstrumentedRefPtr::reportMemoryUsage):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
(WebCore::InstrumentedOther::reportMemoryUsage):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(WebCore::NonVirtualInstrumented::reportMemoryUsage):

6:10 AM Changeset in webkit [124883] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed trivial fix: Missed HAVE_QT5 removal as part of r124879

Fixes failing auto-test.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::enumerate_data):

6:02 AM Changeset in webkit [124882] by commit-queue@webkit.org
  • 1 edit
    90 deletes in trunk/LayoutTests

[GTK] Remove duplicated platform test expectations
https://bugs.webkit.org/show_bug.cgi?id=93352

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-07
Reviewed by Martin Robinson.

Remove platform test expectations that are the same as the global
expectations.

  • platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Removed.
  • platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-line-011-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-tab-001-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-tab-004-expected.txt: Removed.
  • platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5780697-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/gtk/editing/selection/after-line-break-expected.txt: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
  • platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Removed.
  • platform/gtk/editing/style/smoosh-styles-003-expected.txt: Removed.
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Removed.
  • platform/gtk/editing/style/style-boundary-002-expected.txt: Removed.
  • platform/gtk/editing/style/style-boundary-003-expected.txt: Removed.
  • platform/gtk/editing/style/typing-style-001-expected.txt: Removed.
  • platform/gtk/editing/style/typing-style-002-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/start-ignoring-before-expected.txt: Removed.
  • platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusDashed01-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusDashed02-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusDashed03-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusDotted01-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusDotted02-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusDotted03-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusSolid01-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusSolid02-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusSolid03-expected.txt: Removed.
  • platform/gtk/fast/borders/borderRadiusSolid04-expected.txt: Removed.
  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Removed.
  • platform/gtk/fast/css-generated-content/before-content-continuation-chain-expected.txt: Removed.
  • platform/gtk/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-cache-bug-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-repeated-url-expected.txt: Removed.
  • platform/gtk/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/gtk/fast/css/hsla-color-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
  • platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
  • platform/gtk/fast/dynamic/dirty-float-in-clean-line-expected.txt: Removed.
  • platform/gtk/fast/dynamic/float-at-line-break-expected.txt: Removed.
  • platform/gtk/fast/dynamic/unicode-bidi-expected.txt: Removed.
  • platform/gtk/fast/forms/implicit-submission-expected.txt: Removed.
  • platform/gtk/fast/forms/onselect-textarea-expected.txt: Removed.
  • platform/gtk/fast/html/details-position-expected.txt: Removed.
  • platform/gtk/fast/lists/inline-before-content-after-list-marker-expected.txt: Removed.
  • platform/gtk/fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
  • platform/gtk/fast/reflections/reflection-masks-expected.txt: Removed.
  • platform/gtk/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
  • platform/gtk/fast/ruby/float-overhang-from-ruby-text-expected.txt: Removed.
  • platform/gtk/fast/ruby/overhang-horizontal-expected.txt: Removed.
  • platform/gtk/fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Removed.
  • platform/gtk/fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Removed.
  • platform/gtk/fast/ruby/overhang-vertical-expected.txt: Removed.
  • platform/gtk/fast/ruby/overhang-vertical-no-overlap1-expected.txt: Removed.
  • platform/gtk/fast/ruby/overhang-vertical-no-overlap2-expected.txt: Removed.
  • platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.
  • platform/gtk/fast/ruby/ruby-remove-no-base-expected.txt: Removed.
  • platform/gtk/fast/ruby/ruby-text-before-child-split-expected.txt: Removed.
  • platform/gtk/fast/runin/runin-div-before-child-expected.txt: Removed.
  • platform/gtk/fast/runin/runin-into-div-with-float-child-expected.txt: Removed.
  • platform/gtk/fast/runin/runin-not-go-into-float-expected.txt: Removed.
  • platform/gtk/fast/runin/runin-table-before-child-expected.txt: Removed.
  • platform/gtk/fast/table/max-width-integer-overflow-expected.txt: Removed.
  • platform/gtk/fast/text/justify-nbsp-expected.txt: Removed.
  • platform/gtk/fast/text/setData-dirty-lines-expected.txt: Removed.
  • platform/gtk/fast/text/splitText-dirty-lines-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
  • platform/gtk/http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/send-undefined-and-null-expected.txt: Removed.
  • platform/gtk/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/svg/custom/getSubStringLength-expected.txt: Removed.
  • platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt: Removed.
  • platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt: Removed.
  • platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
  • platform/gtk/svg/dom/altGlyph-dom-expected.txt: Removed.
  • platform/gtk/svg/dom/css-transforms-expected.txt: Removed.
  • platform/gtk/svg/hixie/links/001-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-expected.txt: Removed.
5:52 AM Changeset in webkit [124881] by toyoshim@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed, rebaseline.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-07

  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
5:45 AM Changeset in webkit [124880] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

[EFL] Add new baselines after r124754
https://bugs.webkit.org/show_bug.cgi?id=93350

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-07

  • platform/efl/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
  • platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
5:06 AM Changeset in webkit [124879] by Simon Hausmann
  • 85 edits
    9 deletes in trunk

[Qt] Remove Qt 4 specific code paths
https://bugs.webkit.org/show_bug.cgi?id=88161

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/api.pri:
  • WebKit.pro:

Source/WebCore:

  • Target.pri:
  • WebCore.pri:
  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getPropertyNames):
(JSC::Bindings::QtInstance::stringValue):
(JSC::Bindings::QtField::setValueToInstance):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

  • bridge/qt/qt_runtime_qt4.cpp: Removed.
  • editing/qt/SmartReplaceQt.cpp: Removed.
  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::tabsToAllFormControls):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/OpenGLShims.cpp:

(WebCore::getProcAddress):

  • platform/graphics/OpenGLShims.h:
  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(PlatformVideoWindow::PlatformVideoWindow):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::create):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::getCurrentGLContext):

  • platform/qt/DeviceMotionProviderQt.h:
  • platform/qt/DeviceOrientationProviderQt.h:
  • platform/qt/KURLQt.cpp:

(WebCore::KURL::operator QUrl):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/qt/QWebPageClient.h:

(QWebPageClient):

  • platform/qt/RenderThemeQt.cpp:
  • platform/text/qt/TextBreakIteratorQt.cpp: Removed.
  • plugins/qt/PluginContainerQt.cpp: Removed.
  • plugins/qt/PluginContainerQt.h: Removed.
  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::isPluginBlacklisted):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::setFocus):
(WebCore::PluginView::paintUsingXPixmap):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::getVisualAndColormap):
(WebCore::PluginView::platformStart):

  • plugins/win/PluginViewWin.cpp:

(windowHandleForPageClient):

Source/WebKit:

  • WebKit.pri:
  • WebKit1.pri:
  • WebKit1.pro:

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::sceneEvent):

  • Api/qgraphicswebview.h:
  • Api/qwebframe.cpp:
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:

(QWebPage::event):

  • Api/qwebpage.h:
  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

  • Api/qwebview.cpp:

(QWebView::QWebView):
(QWebView::event):

  • Api/qwebview.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::setToolTip):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin):

  • WebCoreSupport/GeolocationClientQt.cpp:
  • WebCoreSupport/GeolocationClientQt.h:
  • WebCoreSupport/PageClientQt.cpp:

(createPlatformGraphicsContext3DFromWidget):
(QWebPageClient::ownerWindow):

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):

  • declarative/declarative.pro:
  • declarative/plugin.cpp:
  • declarative/public.pri:
  • examples/platformplugin/WebPlugin.cpp:

(WebPlugin::createExtension):

  • examples/platformplugin/WebPlugin.h:

(WebPlugin):

  • examples/platformplugin/platformplugin.pro:
  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::arrayObjectEnumerable):
(tst_QObjectBridge::ownership):
(tst_QObjectBridge::qObjectWrapperWithSameIdentity):

  • tests/tests.pri:
  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

(gatherAPI):

  • WebKit2.pri:

Source/WTF:

  • WTF.pri:
  • WTF.pro:
  • wtf/qt/StringQt.cpp:

(WTF::String::String):
(WTF::String::operator QString):

  • wtf/qt/UtilsQt.h: Removed.
  • wtf/qt/compat/QGuiApplication: Removed.
  • wtf/qt/compat/qguiapplication.h: Removed.
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF):

  • wtf/text/StringImpl.h:

(StringImpl):

Tools:

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::touchCancel):
(EventSender::sendTouchEvent):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/main.cpp:

(main):

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::setDiskCache):

  • qmake/configure.pri:
  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/functions.prf:
  • qmake/mkspecs/features/qtwebkit.prf: Removed.
  • qmake/mkspecs/features/unix/default_pre.prf:
4:52 AM Changeset in webkit [124878] by caseq@chromium.org
  • 9 edits
    3 adds in trunk

Web Inspector: implement reusable progress bar
https://bugs.webkit.org/show_bug.cgi?id=93267

Source/WebCore:

  • Generic progress bar implementation to be used

by various long-running operations in inspector.

Test: inspector/progress-bar.html

Reviewed by Pavel Feldman.

  • WebCore.gypi: Added ProgressBar.js
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • inspector/compile-front-end.py: ditto.
  • inspector/front-end/AdvancedSearchController.js: renamed style for stop button.

(WebInspector.SearchView):

  • inspector/front-end/ProgressBar.js: Added.

(WebInspector.Progress): Interface for both ProgressIndicator and SubProgress.
(WebInspector.Progress.prototype.setTotalWork):
(WebInspector.Progress.prototype.setTitle):
(WebInspector.Progress.prototype.setWorked):
(WebInspector.Progress.prototype.done):
(WebInspector.Progress.prototype.isCanceled):
(WebInspector.ProgressIndicator): A UI control that implements Progress.
(WebInspector.ProgressIndicator.prototype.show):
(WebInspector.ProgressIndicator.prototype.hide):
(WebInspector.ProgressIndicator.prototype.done):
(WebInspector.ProgressIndicator.prototype._cancel):
(WebInspector.ProgressIndicator.prototype.isCanceled):
(WebInspector.ProgressIndicator.prototype.setTitle):
(WebInspector.ProgressIndicator.prototype.setTotalWork):
(WebInspector.ProgressIndicator.prototype.setWorked):
(WebInspector.CompositeProgress): A progress bar that is composed of several SubProgress bars and uses a Progress to display total progress of all tasks.
(WebInspector.CompositeProgress.prototype._childDone):
(WebInspector.CompositeProgress.prototype.createSubProgress):
(WebInspector.CompositeProgress.prototype._update):
(WebInspector.SubProgress): A child of CompositeProgress, implements Progress interface.
(WebInspector.SubProgress.prototype.isCanceled):
(WebInspector.SubProgress.prototype.setTitle):
(WebInspector.SubProgress.prototype.done):
(WebInspector.SubProgress.prototype.setTotalWork):
(WebInspector.SubProgress.prototype.setWorked):

  • inspector/front-end/WebKit.qrc: Added ProgressBar.js
  • inspector/front-end/inspector.css:

(.progress-bar-stop-button-item):
(.progress-bar-stop-button .glyph):
(.progress-bar-container):
(.progress-bar-container span):
(.progress-bar-container progress):
(.progress-bar-container button.status-bar-item):

  • inspector/front-end/inspector.html:

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/progress-bar-expected.txt: Added.
  • inspector/progress-bar.html: Added.
4:34 AM Changeset in webkit [124877] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
https://bugs.webkit.org/show_bug.cgi?id=93277

Reviewed by Jocelyn Turcotte.

MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
when registering multiple touch points based on pressed mouse buttons
and sends inconsistent touch events to the WebView which triggers an
assert in the pinch gesture recognizer.
MiniBrowserApplication::updateTouchPoint should only register multiple
touch points if the Ctrl button is pressed else it should ignore the
update request.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::updateTouchPoint):

4:28 AM Changeset in webkit [124876] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: display function scope in UI
https://bugs.webkit.org/show_bug.cgi?id=90631

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-08-07
Reviewed by Yury Semikhatsky.

Two new tree element types added: function scope group node and scope node.
Scope node is only used to represent closure and catch scopes. Scopes that
have a real object beneath are represented as a property node.
A method that reads properties from RemoteObject and populate tree element
is factored out from RemoteObjectTreeElement for reuse.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.Populate.callback):
(WebInspector.ObjectPropertyTreeElement.Populate):
(WebInspector.FunctionScopeMainTreeElement):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
(WebInspector.FunctionScopeMainTreeElement.prototype.onattach):
(WebInspector.FunctionScopeMainTreeElement.prototype.update):
(WebInspector.ScopeTreeElement):
(WebInspector.ScopeTreeElement.prototype.onpopulate):
(WebInspector.ScopeTreeElement.prototype.onattach):
(WebInspector.ScopeTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObjectProperty.fromScopeValue):

3:46 AM Changeset in webkit [124875] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk/Source/WebKit2

[EFL][WK2] Add back forward list API
https://bugs.webkit.org/show_bug.cgi?id=92345

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-07
Reviewed by Kenneth Rohde Christiansen.

Added new Back Forward list API to EFL WK2. Ewk_Back_Forward_List and
Ewk_Back_Forward_List_Item structures were added. The new API is
mostly the same as one from UIProcess/API/C/{ WKBackForwardList.h, WKBackForwardListItem.h }.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_back_forward_list.cpp: Added.

(_Ewk_Back_Forward_List):
(_Ewk_Back_Forward_List::_Ewk_Back_Forward_List):
(getOrCreateItem):
(webkit_back_forward_list_current_item_get):
(webkit_back_forward_list_back_item_get):
(webkit_back_forward_list_forward_item_get):
(webkit_back_forward_list_item_at_index_get):
(webkit_back_forward_list_length_get):
(ewk_back_forward_list_changed):
(ewk_back_forward_list_new):
(ewk_back_forward_list_free):

  • UIProcess/API/efl/ewk_back_forward_list.h: Added.
  • UIProcess/API/efl/ewk_back_forward_list_item.cpp: Added.

(getItemProperty):
(_Ewk_Back_Forward_List_Item):
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):
(_Ewk_Back_Forward_List_Item::~_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_ref):
(ewk_back_forward_list_item_unref):
(ewk_back_forward_list_item_uri_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_uri_get):
(ewk_back_forward_list_item_new):

  • UIProcess/API/efl/ewk_back_forward_list_item.h: Added.
  • UIProcess/API/efl/ewk_back_forward_list_item_private.h: Added.
  • UIProcess/API/efl/ewk_back_forward_list_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_back_forward_list_get): New function to get back-forward list.

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didChangeBackForwardList): The callback added to update back-forward list items cache.
(ewk_view_loader_client_attach):

3:26 AM Changeset in webkit [124874] by allan.jensen@nokia.com
  • 63 edits
    14 deletes in trunk/LayoutTests

Unreviewed gardening. Rebased affected subpixel-sensitive tests after r124745.

  • fast/multicol/nested-columns-expected.txt:
  • fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/multicol/nested-columns-expected.txt: Removed.
  • platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt: Removed.
  • platform/gtk/fast/multicol/nested-columns-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt: Removed.
3:12 AM Changeset in webkit [124873] by Csaba Osztrogonác
  • 2 edits
    27 deletes in trunk/LayoutTests

[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Unreviewed gardening, remove unnecessary expected files and unskip now passing tests after r124808.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/editing/deleting/5144139-2-expected.txt: Removed.
  • platform/qt-5.0-wk2/editing/pasteboard/4806874-expected.txt: Removed.
  • platform/qt-5.0-wk2/editing/pasteboard/input-field-1-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-disabled-color-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-align-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-align-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-setinnerhtml-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/textarea-setinnerhtml-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/table/003-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/table/003-expected.txt: Removed.
  • platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.txt: Removed.
2:41 AM WebKitIDL edited by Vineet
(diff)
2:27 AM Changeset in webkit [124872] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

[V8] Remove custom toV8() calls for TypedArray.
https://bugs.webkit.org/show_bug.cgi?id=93248

Patch by Vineet Chaudhary <Vineet> on 2012-08-07
Reviewed by Kentaro Hara.

With the support of [TypedArray] we can remove the custom calls toV8().
TypedArray spec : http://www.khronos.org/registry/typedarray/specs/latest/#7

Tests: TestTypedArray.idl
Tests under below folders should pass as this does not cause any behavioral changes.

fast/canvas/webgl
compositing/webgl

  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSUint8ClampedArrayCustom.cpp:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation): Modified Generator code to generate bindings for toV8().
(IsWrapperType):
(GetTypeNameOfExternalTypedArray): Method to get view type of TypedArray.

  • bindings/scripts/test/V8/V8Float64Array.cpp: Tests results.

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp: Removed custom call toV8().
  • bindings/v8/custom/V8Float64ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Int16ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Int32ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Int8ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp: Ditto.
  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Ditto.
  • html/canvas/Int8Array.idl: Using TypedArray.
  • html/canvas/Uint8Array.idl: Ditto.
  • html/canvas/Uint8ClampedArray.idl: Ditto.
2:24 AM Changeset in webkit [124871] by Simon Hausmann
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][Win] Remove pthreads linkage

Reviewed by Csaba Osztrogonác.

After r124823 linkage to pthreads is not needed anymore for the Windows
build.

2:15 AM Changeset in webkit [124870] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=93346

Rubber-stamped by Simon Hausmann.

Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_retrying_and_flaky_tests):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._print_unexpected_results):

1:50 AM Changeset in webkit [124869] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Refactor emit*Inst functions and introduce toARMWord functions in DFG-JIT's traditional ARM port
https://bugs.webkit.org/show_bug.cgi?id=93266

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-07
Reviewed by Csaba Osztrogonác.

First part of a bigger refactoring issue trying to make traditional
ARM DFG-JIT port easier to read and understand.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::emitInstruction):
(JSC::ARMAssembler::emitDoublePrecisionInstruction):
(JSC::ARMAssembler::emitSinglePrecisionInstruction):
(JSC::ARMAssembler::and_r):
(JSC::ARMAssembler::ands_r):
(JSC::ARMAssembler::eor_r):
(JSC::ARMAssembler::eors_r):
(JSC::ARMAssembler::sub_r):
(JSC::ARMAssembler::subs_r):
(JSC::ARMAssembler::rsb_r):
(JSC::ARMAssembler::rsbs_r):
(JSC::ARMAssembler::add_r):
(JSC::ARMAssembler::adds_r):
(JSC::ARMAssembler::adc_r):
(JSC::ARMAssembler::adcs_r):
(JSC::ARMAssembler::sbc_r):
(JSC::ARMAssembler::sbcs_r):
(JSC::ARMAssembler::rsc_r):
(JSC::ARMAssembler::rscs_r):
(JSC::ARMAssembler::tst_r):
(JSC::ARMAssembler::teq_r):
(JSC::ARMAssembler::cmp_r):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::orr_r):
(JSC::ARMAssembler::orrs_r):
(JSC::ARMAssembler::mov_r):
(JSC::ARMAssembler::movw_r):
(JSC::ARMAssembler::movt_r):
(JSC::ARMAssembler::movs_r):
(JSC::ARMAssembler::bic_r):
(JSC::ARMAssembler::bics_r):
(JSC::ARMAssembler::mvn_r):
(JSC::ARMAssembler::mvns_r):
(JSC::ARMAssembler::mul_r):
(JSC::ARMAssembler::muls_r):
(JSC::ARMAssembler::mull_r):
(JSC::ARMAssembler::vmov_f64_r):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vabs_f64_r):
(JSC::ARMAssembler::vneg_f64_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_d):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::dtrh_u):
(JSC::ARMAssembler::dtrh_ur):
(JSC::ARMAssembler::dtrh_d):
(JSC::ARMAssembler::dtrh_dr):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::fdtr_d):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::vmov_vfp64_r):
(JSC::ARMAssembler::vmov_arm64_r):
(JSC::ARMAssembler::vmov_vfp32_r):
(JSC::ARMAssembler::vmov_arm32_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vcvt_u32_f64_r):
(JSC::ARMAssembler::vcvt_f64_f32_r):
(JSC::ARMAssembler::vcvt_f32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):
(JSC::ARMAssembler::clz_r):
(JSC::ARMAssembler::bx):
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::toARMWord):
(ARMAssembler):

1:44 AM Changeset in webkit [124868] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt/TestExpectations:
1:39 AM Changeset in webkit [124867] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: [regression r121673] restore link between the command and the result.
https://bugs.webkit.org/show_bug.cgi?id=93280

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-08-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Passing lost parameter along.

Test: inspector/console/console-originating-command.html

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.runScript.runCallback):
(WebInspector.ConsoleView.prototype.runScript):
(WebInspector.ConsoleView.prototype._printResult):

LayoutTests:

  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):

  • inspector/console/console-originating-command-expected.txt: Added.
  • inspector/console/console-originating-command.html: Added.
1:38 AM WebKit Team edited by haraken@chromium.org
(diff)
1:35 AM WebKit Team edited by haraken@chromium.org
(diff)
1:33 AM Changeset in webkit [124866] by commit-queue@webkit.org
  • 15 edits in trunk/Source

CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=93081

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-07
Reviewed by Adam Barth.

Source/WebCore:

CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.
The whole NavigatorRegisterProtocolHandler interface is conditional on REGISTER_PROTOCOL_HANDLER
CUSTOM_SCHEME_HANDLER-specific methods only are conditional on CUSTOM_SCHEME_HANDLER.

No new tests. No new functionality is added.

  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:

(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):

  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:

(NavigatorRegisterProtocolHandler):

  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl:
  • Modules/protocolhandler/RegisterProtocolHandlerClient.h:

Source/WebKit:

Modified PlatformEfl.cmake so that CUSTOM_SCHEME_HANDLER flag cannot act without REGISTER_PROTOCOL_HANDLER being set.

  • PlatformEfl.cmake:

Source/WebKit/efl:

CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:

(WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
  • ewk/ewk_custom_handler.cpp:

(ewk_custom_handler_register_protocol_handler):

  • ewk/ewk_custom_handler_private.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit2:

CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.

  • WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h:

(WebRegisterProtocolHandlerClient):

1:16 AM Changeset in webkit [124865] by commit-queue@webkit.org
  • 4 edits in trunk/Source

IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-07
Reviewed by Kentaro Hara.

To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):

1:15 AM Changeset in webkit [124864] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add ewk_view_find_client.h / cpp for wrapping WKPageSetPageFindClient.
https://bugs.webkit.org/show_bug.cgi?id=90927

Patch by Hyerim Bae <hyerim.bae@samsung.com> on 2012-08-07
Reviewed by Kentaro Hara.

Add ewk_view_find_client.h / files for wrapping WKPageSetPageFindClient,
add didFindString callback member of WKPageSetPageFindClient.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):
(ewk_view_text_found):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_find_client.cpp: Added.

(toEwkView):
(didFindString):
(ewk_view_find_client_attach):

  • UIProcess/API/efl/ewk_view_find_client_private.h: Added.
  • UIProcess/API/efl/ewk_view_private.h:
12:48 AM Changeset in webkit [124863] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Move some inspector tests into TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=92884

Unreviewed gardening.

New baselines after r123703.

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-08-07

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
12:45 AM Changeset in webkit [124862] by kbalazs@webkit.org
  • 4 edits in trunk/Tools

[NRWT] runs platform specific tests that it shouldn't with --force
https://bugs.webkit.org/show_bug.cgi?id=91089

Reviewed by Dirk Pranke.

Ignore other platform's directories from platform/.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._expanded_paths):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_platform_tests_are_found):
Updated integration test in accordance to the new behavior.

12:41 AM Changeset in webkit [124861] by zandobersek@gmail.com
  • 5 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after r124697. Also skipping two modal dialog tests that
take 30 seconds to run but are expected to fail.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/css/nested-layers-with-hover-expected.txt: Added.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
12:12 AM Changeset in webkit [124860] by joone@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Marked the following test cases as known failures
tracked by the bug 93228.

inspector/debugger/debugger-activation-crash2.html
inspector/debugger/debugger-set-breakpoint-regex.html
inspector/debugger/pause-in-internal-script.html
inspector/debugger/script-formatter-breakpoints.html
inspector/debugger/set-breakpoint.html
inspector/debugger/watch-expressions-panel-switch.html

  • platform/efl/TestExpectations:
12:00 AM Changeset in webkit [124859] by arko@motorola.com
  • 17 edits
    2 adds in trunk

Microdata: itemType[index] must be undefined for out-of-range index.
https://bugs.webkit.org/show_bug.cgi?id=92988

Reviewed by Kentaro Hara.

Source/WebCore:

Made changes in IndexedGetter property so that it returns undefined
for out-of-range index.
Spec: http://www.w3.org/TR/WebIDL/#idl-indexed-properties
Firefox and Opera's behavior is consistent with the spec. Both returns
undefined for out-of-range index.

Also renamed the function name collectionStringOrNullIndexedPropertyGetter and
setCollectionStringOrNullIndexedGetter to collectionStringOrUndefinedIndexedPropertyGetter
and setCollectionStringOrUndefinedIndexedGetter respectively.

Test: fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationIndexer):

  • bindings/v8/V8Collection.h:

(WebCore::collectionStringOrUndefinedIndexedPropertyGetter):
(WebCore::setCollectionStringOrUndefinedIndexedGetter):

LayoutTests:

Added a test to verify itemType[index], itemRef[index], itemProp[index]
behavior for out-of-range index.

Rebased existing test cases for IndexedGetter property.

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:
  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
  • fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index-expected.txt: Added.
  • fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html: Added.
  • fast/dom/StyleSheet/css-medialist-item-expected.txt:
  • fast/dom/StyleSheet/script-tests/css-medialist-item.js:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/resources/database-basics.js:

(createObjectStore):

  • storage/indexeddb/resources/objectstore-basics.js:

(checkMetadata):

Aug 6, 2012:

11:54 PM Changeset in webkit [124858] by dgrogan@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Make leveldb store integer versions and migrate old schemas
https://bugs.webkit.org/show_bug.cgi?id=92883

Reviewed by Tony Chang.

Our first schema change. If an existing DB doesn't have integer
versions, this will add one to all object stores in the origin.

No new tests - chrome test for the migration forthcoming. Will involve
starting with a leveldb directory from an old build of chrome, opening
it up with the migration code in place, and checking the new database.
http://codereview.chromium.org/10826159/

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::putVarInt):
(WebCore):
(WebCore::setUpMetadata):
Uses the ASSERT-but-still-handle-corruption pattern recently discussed
in https://bugs.webkit.org/show_bug.cgi?id=92725#c13.

(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
Because we can't store negative numbers, store 0 instead of -1.

(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):

  • Modules/indexeddb/IDBLevelDBCoding.h:
  • Modules/indexeddb/IDBMetadata.h:
11:40 PM Changeset in webkit [124857] by commit-queue@webkit.org
  • 20 edits
    5 deletes in trunk/Source/WebCore

Unreviewed, rolling out r124780.
http://trac.webkit.org/changeset/124780
https://bugs.webkit.org/show_bug.cgi?id=93340

We don't want an incomplete feature set for the chromium
branch cut. (Requested by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/mediasource/MediaSource.cpp: Removed.
  • Modules/mediasource/MediaSource.h: Removed.
  • Modules/mediasource/MediaSource.idl: Removed.
  • Modules/mediasource/MediaSourceRegistry.cpp: Removed.
  • Modules/mediasource/MediaSourceRegistry.h: Removed.
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered):
(WebCore::SourceBuffer::append):
(WebCore::SourceBuffer::abort):

  • Modules/mediasource/SourceBuffer.h:

(WebCore::SourceBuffer::create):
(WebCore::SourceBuffer::clear):
(SourceBuffer):

  • Modules/mediasource/SourceBufferList.cpp:
  • Modules/mediasource/SourceBufferList.h:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • html/DOMURL.cpp:
  • html/DOMURL.h:

(WebCore):
(DOMURL):

  • html/DOMURL.idl:
  • page/DOMWindow.idl:
11:37 PM Changeset in webkit [124856] by gyuyoung.kim@samsung.com
  • 6 edits in trunk

[EFL] Enable link prefetch
https://bugs.webkit.org/show_bug.cgi?id=93281

Reviewed by Kentaro Hara.

.:

  • Source/cmake/OptionsEfl.cmake: Enable LINK_PREFETCH by default.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.

LayoutTests:

Unskip test cases related to link prefetch feature except for fast/dom/HTMLLinkElement/subresource.html.

  • platform/efl/TestExpectations:
11:34 PM Changeset in webkit [124855] by toyoshim@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, rebaseline again for chromium-linux-x86.
See, also r124850.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
11:07 PM Changeset in webkit [124854] by Csaba Osztrogonác
  • 14 edits in trunk/Tools

Unreviewed, rolling out r124801.
http://trac.webkit.org/changeset/124801
https://bugs.webkit.org/show_bug.cgi?id=93338

It broke NRWT (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/image_diff.py:

(ImageDiffer.diff_image):
(ImageDiffer._read):

  • Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:

(TestImageDiffer.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/server_process_mock.py:

(MockServerProcess.init):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

10:58 PM Changeset in webkit [124853] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r124798.
http://trac.webkit.org/changeset/124798
https://bugs.webkit.org/show_bug.cgi?id=93337

We don't want an incomplete feature set for the chromium
branch cut. (Requested by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/PublicURLManager.h:

(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):

10:54 PM Changeset in webkit [124852] by commit-queue@webkit.org
  • 18 edits
    1 move
    1 add
    1 delete in trunk

Unreviewed, rolling out r124848.
http://trac.webkit.org/changeset/124848
https://bugs.webkit.org/show_bug.cgi?id=93336

Caused 3 tests to crash on chromium Linux32/Mac10.6/Linux
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::mediaEngineError):
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::webkitSourceBuffered):
(WebCore::HTMLMediaElement::webkitSourceAppend):
(WebCore::HTMLMediaElement::webkitSourceAbort):
(WebCore::HTMLMediaElement::webkitSourceEndOfStream):
(WebCore::HTMLMediaElement::webkitSourceState):
(WebCore::HTMLMediaElement::setSourceState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::createMediaPlayer):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceId):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):
(MediaSourceTest.getSourceStateName):

  • http/tests/media/media-source/video-media-source-abort-expected.txt:
  • http/tests/media/media-source/video-media-source-abort.html:
  • http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Removed.
  • http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt.
  • http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Added.
  • http/tests/media/media-source/video-media-source-errors-expected.txt:
  • http/tests/media/media-source/video-media-source-errors.html:
  • http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
  • http/tests/media/media-source/video-media-source-event-attributes.html:
  • http/tests/media/media-source/video-media-source-play-expected.txt:
  • http/tests/media/media-source/video-media-source-play.html:
  • http/tests/media/media-source/video-media-source-seek-expected.txt:
  • http/tests/media/media-source/video-media-source-seek.html:
  • http/tests/media/media-source/video-media-source-state-changes-expected.txt:
  • http/tests/media/media-source/video-media-source-state-changes.html:
10:47 PM Changeset in webkit [124851] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

[Chromium]duplicated command line options in Android LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=93233

Patch by Wei James <james.wei@intel.com> on 2012-08-06
Reviewed by Tony Chang.

Duplicated options found in Android layout test command line:
--encode-binary and --enable-hardware-gpu.

If there are multiple ChromiumAndroidPort instances,
these two options will be appended for multiple times.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.additional_drt_flag):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.additional_drt_flag):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidTwoPortsTest):
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.cmd_line):

10:47 PM Changeset in webkit [124850] by toyoshim@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline for chromium-linux-x86.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmethod-attribute-button-html-expected.txt: Added.
9:48 PM Changeset in webkit [124849] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline for r124836.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
9:41 PM Changeset in webkit [124848] by annacc@chromium.org
  • 18 edits
    1 move
    1 add
    1 delete in trunk

Update HTMLMediaElement to the new OO MediaSource API.
https://bugs.webkit.org/show_bug.cgi?id=91775

Reviewed by Eric Carlson.

This patch rips out the old-style MediaSource API and allows a
MediaSource object to be attached to HTMLMediaElement.
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-add-and-remove-buffers.html

Tests: updates to http/tests/media/media-source/*

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove old style API resources.
(WebCore::HTMLMediaElement::parseAttribute): Remove old style event attributes.
(WebCore::HTMLMediaElement::prepareForLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::loadResource): Get MediaSource object from blob registry

look up and, if found, set it's MediaPlayer pointer to the current MediaPlayer.

(WebCore::HTMLMediaElement::noneSupported): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaEngineError): Set source state to "closed".
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened): Set source state to "open".
(WebCore::HTMLMediaElement::mediaPlayerSourceURL): Change to new blob URL.
(WebCore::HTMLMediaElement::seek): Check if source state is "closed".
(WebCore::HTMLMediaElement::setSourceState): Helper function so that we don't have to

keep checking for m_mediaSource.

(WebCore::HTMLMediaElement::userCancelledLoad): Set source state to "closed".
(WebCore::HTMLMediaElement::createMediaPlayer): If the current MediaPlayer is re-

created, notify the MediaSource and reset its MediaPlayer.

  • html/HTMLMediaElement.h: Remove old style API code and add a MediaSource object.

(HTMLMediaElement):

  • html/HTMLMediaElement.idl: Remove old style API.

LayoutTests:

  • http/tests/media/media-source/media-source.js:

(MediaSourceTest.SegmentHelper):
(MediaSourceTest.SegmentHelper.prototype.addSourceBuffer):
(MediaSourceTest.SegmentHelper.prototype.appendInitSegment):
(MediaSourceTest.SegmentHelper.prototype.appendMediaSegment):
(MediaSourceTest.SegmentHelper.prototype.appendUntilEndOfStream):
(MediaSourceTest.setSrcToMediaSourceTestURL):
(MediaSourceTest.defaultOnErrorChecks):
(MediaSourceTest.runOnSourceOpen.eventHandlerFunction):
(MediaSourceTest.runOnSourceOpen):
(MediaSourceTest.logSourceState):
(MediaSourceTest.expectSourceState):

  • http/tests/media/media-source/video-media-source-abort-expected.txt:
  • http/tests/media/media-source/video-media-source-abort.html:
  • http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Renamed from LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt.
  • http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Added.
  • http/tests/media/media-source/video-media-source-add-and-remove-ids.html: Removed.
  • http/tests/media/media-source/video-media-source-errors-expected.txt:
  • http/tests/media/media-source/video-media-source-errors.html:
  • http/tests/media/media-source/video-media-source-event-attributes-expected.txt:
  • http/tests/media/media-source/video-media-source-event-attributes.html:
  • http/tests/media/media-source/video-media-source-play-expected.txt:
  • http/tests/media/media-source/video-media-source-play.html:
  • http/tests/media/media-source/video-media-source-seek-expected.txt:
  • http/tests/media/media-source/video-media-source-seek.html:
  • http/tests/media/media-source/video-media-source-state-changes-expected.txt:
  • http/tests/media/media-source/video-media-source-state-changes.html:
9:08 PM Changeset in webkit [124847] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

BindingSecurity::shouldAllowAccessToFrame shouldn't use a raw boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=93323

Reviewed by Eric Seidel.

As requested by Eric. This patch also renames the function to match its
counterpart in the JavaScriptCore bindings.

  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToFrame):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
(WebCore::BindingSecurity::allowSettingFrameSrcToJavascriptUrl):

  • bindings/generic/BindingSecurity.h:

(BindingSecurity):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):
(WebCore::V8DOMWindow::eventAccessorGetter):
(WebCore::V8DOMWindow::eventAccessorSetter):
(WebCore::V8DOMWindow::openerAccessorSetter):
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::indexedSecurityCheck):
(WebCore::V8History::namedSecurityCheck):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::toStringCallback):
(WebCore::V8Location::indexedSecurityCheck):
(WebCore::V8Location::namedSecurityCheck):

9:06 PM Changeset in webkit [124846] by yutak@chromium.org
  • 14 edits
    5 adds in trunk

WebSocket.send() should accept ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90877

Reviewed by Kent Tamura.

Source/WebCore:

Accept ArrayBufferView as an argument of WebSocket.send() to comply with recent change
in specification: <http://html5.org/tools/web-apps-tracker?from=7084&to=7085>.

Once WebSocket.send(ArrayBuffer) was removed from the specification, but added back
in <http://html5.org/tools/web-apps-tracker?from=7202&to=7203>. Thus the functionality
of send(ArrayBuffer) is kept as-is.

Tests: http/tests/websocket/tests/hybi/send-arraybufferview.html

http/tests/websocket/tests/hybi/workers/send-arraybufferview.html

  • Modules/websockets/ThreadableWebSocketChannel.h:

Change the signature of send() to receive offset and length so the clients can send
subrange of an ArrayBuffer.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
WebSocket.send(ArrayBufferView) is added, which puts the sub region of the given
ArrayBuffer into the outgoing frame queue.

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.idl:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

  • Modules/websockets/WebSocketChannel.h:

(WebSocketChannel):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
Send only necessary part of data to the main thread.

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
(Bridge):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send): Accept ArrayBufferView in send().

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback): Ditto.

Source/WebKit/chromium:

  • src/WebSocketImpl.cpp:

(WebKit::WebSocketImpl::sendArrayBuffer):
Apply change in function signature of WebSocketChannel::send().

LayoutTests:

Two tests are added to check whether WebSocket.send(ArrayBufferView) works in the
main thread and in a worker.

  • http/tests/websocket/tests/hybi/send-arraybufferview-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-arraybufferview.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/send-arraybufferview.js: Added.
  • http/tests/websocket/tests/hybi/workers/send-arraybufferview-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/send-arraybufferview.html: Added.
8:59 PM Changeset in webkit [124845] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Add gyp variable to control which compositor target is depended on
https://bugs.webkit.org/show_bug.cgi?id=93165

Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

This adds a use_libcc_for_compositor gyp variable to control whether webcore_platform links in the compositor
code from the webcore_chromium_compositor target or from cc from the chromium repo.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
8:59 PM Changeset in webkit [124844] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTest: fast/forms/input-set-composition-scroll.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93320

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

fast/forms/input-set-composition-scroll.html is failing after r120145
because TestInputController::setComposition() method has not been implemented.
It was added to skip list on Mac, see https://bugs.webkit.org/show_bug.cgi?id=89845 but not on Windows.

  • platform/win/Skipped:

Adding test to skip list.

8:43 PM Changeset in webkit [124843] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Crash in GenericEventQueue::timerFired since the owner of GenericEventQueue is deleted during dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=92946

Reviewed by Eric Carlson.

Source/WebCore:

In GenericEventQueue::timerFired(), the owner of GenericEventQueue might be deleted.
We have to protect the owner of GenericEventQueue during dispatching events.

Test: media/event-queue-crash.html

  • dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::timerFired): Added a protection.

LayoutTests:

  • media/event-queue-crash-expected.txt: Added.
  • media/event-queue-crash.html: Added.
8:40 PM Changeset in webkit [124842] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Remove IDBRequest::finishCursor() and plumbing
https://bugs.webkit.org/show_bug.cgi?id=93274

Reviewed by Tony Chang.

Delete an unused flag and code for setting it, rendered obsolete in r123275.

No new tests - no functional changes.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::close):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

8:37 PM Changeset in webkit [124841] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
https://bugs.webkit.org/show_bug.cgi?id=93319

Patch by James Robinson <jamesr@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/Platform:

Adds a few more entry points to WebLayer that are being used by GraphicsLayerChromium.

  • chromium/public/WebLayer.h:

(WebLayer):

Source/WebCore:

Gets rid of all (but one) of the remaining unwrap<LayerChromium>() calls in GraphicsLayer chromium to avoid
punching through the WebLayer API. Covered by many layout tests, mostly in compositing/

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

Source/WebKit/chromium:

  • src/WebLayer.cpp:

(WebKit::WebLayer::setChildren):
(WebKit):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::clearRenderSurface):

8:18 PM Changeset in webkit [124840] by piman@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=93313

Reviewed by James Robinson.

Sync points already landed chromium-side, mailbos at https://chromiumcodereview.appspot.com/10829209/

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::insertSyncPoint):
(WebKit::WebGraphicsContext3D::waitSyncPoint):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::genMailboxCHROMIUM):
(WebKit::WebGraphicsContext3D::produceTextureCHROMIUM):
(WebKit::WebGraphicsContext3D::consumeTextureCHROMIUM):

8:00 PM Changeset in webkit [124839] by enne@google.com
  • 16 edits
    1 copy
    1 move
    1 add in trunk/Source

[chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
https://bugs.webkit.org/show_bug.cgi?id=93308

Reviewed by James Robinson.

Source/Platform:

Convert WebScrollbarThemeGeometry to be an interface. Update
WebScrollbarLayer to take a pointer to this interface.

  • chromium/public/WebScrollbarLayer.h:

(WebScrollbarLayer):

  • chromium/public/WebScrollbarThemeGeometry.h:

(WebScrollbarThemeGeometry):

Source/WebCore:

Convert WebScrollbarThemeGeometry to be an interface. Create a new
WebScrollbarThemeGeometryNative implementation to wrap a native theme
pointer.

Update ScrollbarLayerChromium/CCScrollbarLayerImpl to use a pointer to
this interface rather than a concrete member variable. Because both
layer types need to access the theme during painting or compositing
and either layer could go away at any time, the theme is cloned during
commit rather than dealing with refcounting across threads or having
one layer type be the sole owner.

  • WebCore.gypi:
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

  • platform/chromium/support/WebScrollbarThemeGeometryNative.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarThemeGeometry.cpp.

(WebKit):
(WebKit::WebScrollbarThemeGeometryNative::create):
(WebKit::WebScrollbarThemeGeometryNative::WebScrollbarThemeGeometryNative):
(WebKit::WebScrollbarThemeGeometryNative::clone):
(WebKit::WebScrollbarThemeGeometryNative::thumbPosition):
(WebKit::WebScrollbarThemeGeometryNative::thumbLength):
(WebKit::WebScrollbarThemeGeometryNative::trackPosition):
(WebKit::WebScrollbarThemeGeometryNative::trackLength):
(WebKit::WebScrollbarThemeGeometryNative::hasButtons):
(WebKit::WebScrollbarThemeGeometryNative::hasThumb):
(WebKit::WebScrollbarThemeGeometryNative::trackRect):
(WebKit::WebScrollbarThemeGeometryNative::thumbRect):
(WebKit::WebScrollbarThemeGeometryNative::minimumThumbLength):
(WebKit::WebScrollbarThemeGeometryNative::scrollbarThickness):
(WebKit::WebScrollbarThemeGeometryNative::backButtonStartRect):
(WebKit::WebScrollbarThemeGeometryNative::backButtonEndRect):
(WebKit::WebScrollbarThemeGeometryNative::forwardButtonStartRect):
(WebKit::WebScrollbarThemeGeometryNative::forwardButtonEndRect):
(WebKit::WebScrollbarThemeGeometryNative::constrainTrackRectToTrackPieces):
(WebKit::WebScrollbarThemeGeometryNative::splitTrack):

  • platform/chromium/support/WebScrollbarThemeGeometryNative.h: Added.

(WebKit):
(WebScrollbarThemeGeometryNative):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::setScrollbarGeometry):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):
(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(WebCore::CCScrollbarLayerImpl::scrollbarGeometry):
(CCScrollbarLayerImpl):

Source/WebKit/chromium:

Now that WebScrollbarThemeGeometry can have different implementations,
create a FakeWebScrollbarThemeGeometry for testing purposes rather
than just overriding a geometry-related virtual.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebScrollbarLayer.cpp:

(WebKit::WebScrollbarLayer::create):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/FakeWebScrollbarThemeGeometry.h: Added.

(WebKit):
(FakeWebScrollbarThemeGeometry):
(WebKit::FakeWebScrollbarThemeGeometry::create):

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

7:49 PM Changeset in webkit [124838] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] About: shows PAGE_CACHE not enabled.
https://bugs.webkit.org/show_bug.cgi?id=93216

Reviewed by Antonio Gomes.

Page cache is a feature that can be enabled/disabled at runtime, there's no
MACRO named PAGE_CACHE to control the feature.

  • WebCoreSupport/AboutDataEnableFeatures.in:
7:44 PM Changeset in webkit [124837] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

IndexedDB: Throw proper exceptions
https://bugs.webkit.org/show_bug.cgi?id=85513

Reviewed by Tony Chang.

Test all of the exception throwing clauses in the spec, unless they are
well covered elsewhere (indicated by a comment in the script).

  • storage/indexeddb/exceptions-expected.txt: Added.
  • storage/indexeddb/exceptions.html: Added.
  • storage/indexeddb/resources/exceptions.js: Added.

(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(testDatabase.request.onsuccess.trans.oncomplete):
(testDatabase.request.onsuccess):
(testDatabase):
(prepareStoreAndIndex.request.onsuccess):
(prepareStoreAndIndex):
(testObjectStore.request.onsuccess.trans.oncomplete):
(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex):
(testCursor.makeCursor.request.onsuccess):
(testCursor.makeCursor):
(testCursor.makeKeyCursor.request.onsuccess):
(testCursor.makeKeyCursor):
(testCursor.makeReverseCursor.request.onsuccess):
(testCursor.makeReverseCursor):
(testCursor.makeInlineCursor.request.onsuccess):
(testCursor.makeInlineCursor):
(testCursor.testCursorAdvance):
(testCursor.testCursorContinue):
(testCursor.testCursorDelete):
(testCursor.testCursorUpdate):
(testCursor.makeReadOnlyCursor.request.onsuccess):
(testCursor.makeReadOnlyCursor):
(testCursor.doReadOnlyCursorTests):
(testCursor):
(testTransaction):

7:18 PM Changeset in webkit [124836] by keishi@webkit.org
  • 6 edits
    6 adds
    2 deletes in trunk/LayoutTests

[Chromium] Rebaseline test color-suggestion-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92444

Unreviewed.

  • platform/chromium-linux-x86/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
  • platform/chromium/TestExpectations:
7:04 PM Changeset in webkit [124835] by abarth@webkit.org
  • 17 edits
    2 adds in trunk/Source/WebCore

JSC should use BindingState to determine the activeDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=93307

Reviewed by Eric Seidel.

This patch moves activeDOMWindow from JSDOMBindings.cpp to
BindingState.cpp. This is a first step towards sharing the core
security logic in the bindings between JavaScriptCore and V8. Once the
logic is shared, we will be able to refactor the logic to avoid the
need for DOMWindow::m_securityOrigin.

This patch doesn't actually share any code (yet). It just sets the
stage by creating BindingState as a typedef of ExecState and adding the
appropriate files to the build systems.

This patch also renames activeWindow and firstWindow in the V8 bindings
to activeDOMWindow and firstDOMWindow to match the names in the
JavaScriptCore bindings.

  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore):

  • bindings/js/JSDOMBinding.h:

(WebCore):

  • bindings/v8/BindingState.cpp:

(WebCore::activeDOMWindow):
(WebCore::firstDOMWindow):

  • bindings/v8/BindingState.h:

(WebCore):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::locationAccessorSetter):
(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorSetter):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::hashAccessorSetter):
(WebCore::V8Location::hostAccessorSetter):
(WebCore::V8Location::hostnameAccessorSetter):
(WebCore::V8Location::hrefAccessorSetter):
(WebCore::V8Location::pathnameAccessorSetter):
(WebCore::V8Location::portAccessorSetter):
(WebCore::V8Location::protocolAccessorSetter):
(WebCore::V8Location::searchAccessorSetter):
(WebCore::V8Location::reloadCallback):
(WebCore::V8Location::replaceCallback):
(WebCore::V8Location::assignCallback):

7:01 PM Changeset in webkit [124834] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium-Mac] Use the default locale only if the browser locale matches to it
https://bugs.webkit.org/show_bug.cgi?id=93227

Reviewed by Hajime Morita.

For a calendar picker, we have used month names and day-of-week names
obtained from the OS default locale. However, the year-month format and
[Today] [Clear] labels are decided with the browser locale. It made
calendar pickers with mixed languages.

To make calendar pickers with a single language, we use the OS default
locale only if the browser locale matches to it.

No new tests. Behavior for locale setting is not testable in WebKit.

  • platform/text/mac/LocaleMac.mm:

(WebCore::languageFromLocale):
A helper for determineLocale. This returns the language part of the
specified locale identifier.
(WebCore::determineLocale):
If the browser language matches to the language of the current NSLocale,
returns the current NSLocale. Otherwise, returns a NSLocale with the
browser language.
Note that [NSLolca localeIdentifier] returns a string in
<language>_<country> format though defaultLanguage() in Chromium returns
a string in <language>-<country> format.
(WebCore::LocaleMac::currentLocale):
Use determineLocale.

6:57 PM Changeset in webkit [124833] by macpherson@chromium.org
  • 3 edits
    2 adds in trunk

Handle variables in CSSParser::parseValidPrimitive(), preventing null return value.
https://bugs.webkit.org/show_bug.cgi?id=93235

Reviewed by Tony Chang.

Source/WebCore:

By returning null here (and failing to handle the variable) the current code would cause null pointer dereferences in StyleResolver at several points.
Instead we create a primitive value for the variable reference and return it.

Test: fast/css/variables/invalid-font-reference.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive):

LayoutTests:

Exercises the code path where variables are parsed in CSSParser::parseValidPrimitive().

  • fast/css/variables/invalid-font-reference-expected.txt: Added.
  • fast/css/variables/invalid-font-reference.html: Added.
6:52 PM WebKitGTK edited by toybabyyou@gmail.com
(diff)
6:50 PM LayoutUnit edited by toybabyyou@gmail.com
(diff)
6:49 PM LayoutTestDashboards edited by toybabyyou@gmail.com
(diff)
6:46 PM Changeset in webkit [124832] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Update chromium DEPS r150037 -> r150169
https://bugs.webkit.org/show_bug.cgi?id=93309

As the title says. Unreviewed.

Patch by James Robinson <jamesr@chromium.org> on 2012-08-06

  • DEPS:
6:45 PM Changeset in webkit [124831] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTest: fast/forms/validation-message-user-modify.html fails.
https://bugs.webkit.org/show_bug.cgi?id=93207

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

This test uses the "required" form element property which currently does not work on Safari,
see <rdar://problem/119655018>.
This test should not be run.

  • platform/win/Skipped:

Adding test to skip list.

6:41 PM Changeset in webkit [124830] by commit-queue@webkit.org
  • 32 edits
    2 moves in trunk/Source

[Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue.
https://bugs.webkit.org/show_bug.cgi?id=93293

Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/WebCore:

No new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:

(WebCore::HeadsUpDisplayLayerChromium::update):

  • platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:

(HeadsUpDisplayLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(WebCore):
(ScrollbarLayerChromium):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::update):

  • platform/graphics/chromium/TextureLayerChromium.h:

(TextureLayerChromiumClient):
(TextureLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCTextureUpdateController.cpp:

(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h:

(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.cpp.

(WebCore):
(WebCore::CCTextureUpdateQueue::CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::~CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::appendFullUpload):
(WebCore::CCTextureUpdateQueue::appendPartialUpload):
(WebCore::CCTextureUpdateQueue::appendCopy):
(WebCore::CCTextureUpdateQueue::takeFirstFullUpload):
(WebCore::CCTextureUpdateQueue::takeFirstPartialUpload):
(WebCore::CCTextureUpdateQueue::takeFirstCopy):
(WebCore::CCTextureUpdateQueue::hasMoreUpdates):

  • platform/graphics/chromium/cc/CCTextureUpdateQueue.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore):
(CCTextureUpdateQueue):
(WebCore::CCTextureUpdateQueue::fullUploadSize):
(WebCore::CCTextureUpdateQueue::partialUploadSize):
(WebCore::CCTextureUpdateQueue::copySize):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore):
(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebExternalTextureLayer.cpp:

(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCTextureUpdateControllerTest.cpp:
  • tests/CCThreadedTest.cpp:
  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
6:34 PM Changeset in webkit [124829] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Clear out the TileCache backpointer for all tile layers when the tile cache is destroyed
https://bugs.webkit.org/show_bug.cgi?id=93317
<rdar://problem/11566543>

Reviewed by Dean Jackson.

It seems that in some rare cases, the tile cache layer can be destroyed in the same transaction as tile layers
are being asked to paint. Make sure to null out the TileCache back pointer for all layers in the TileCache destructor.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::~TileCache):

6:19 PM Changeset in webkit [124828] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r121803. <rdar://problem/11968346>

6:14 PM Changeset in webkit [124827] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.26-branch

Merged r120845. <rdar://problem/12035599>

6:07 PM Changeset in webkit [124826] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Cleanup configure.ac build options output
https://bugs.webkit.org/show_bug.cgi?id=93245

Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-06
Reviewed by Laszlo Gombos.

Remove duplicated elements, sort alphabetically.

  • configure.ac: ditto.
5:50 PM Changeset in webkit [124825] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Unreviewed, rolling out r124816.
http://trac.webkit.org/changeset/124816
https://bugs.webkit.org/show_bug.cgi?id=93311

made some tests crash (Requested by noamr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

Source/WebCore:

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::apply):

  • platform/graphics/GraphicsLayerAnimation.h:

(GraphicsLayerAnimation):
(GraphicsLayerAnimations):
(WebCore::GraphicsLayerAnimations::remove):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):

5:47 PM Changeset in webkit [124824] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[CSS Exclusions] Add a command-line flag to enable / disable exclusions
https://bugs.webkit.org/show_bug.cgi?id=91420

Patch by Bear Travis <betravis@adobe.com> on 2012-08-06
Reviewed by Dimitri Glazkov.

Adding the interface code to expose the css exclusions runtime flag to
Chromium.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures): Adding getters/setters for cssExclusions

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCSSExclusions):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSExclusionsEnabled):

5:29 PM Changeset in webkit [124823] by Patrick Gansterer
  • 6 edits in trunk/Source

[WIN] Remove dependency on pthread from MachineStackMarker
https://bugs.webkit.org/show_bug.cgi?id=68429

Reviewed by Geoffrey Garen.

Windows has no support for calling a destructor for thread specific data.
Since we need more control over creating and deleting thread specific keys
we can not simply extend WTF::ThreadSpecific with this functionality.

All thread specific keys created via the new API get stored in a list.
After a thread function finished we iterate over this list and call
the registered destructor for every item if needed.

Source/JavaScriptCore:

  • heap/MachineStackMarker.cpp: Use the new functions instead of pthread directly.

(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):

  • heap/MachineStackMarker.h:

(MachineThreads):

Source/WTF:

  • wtf/ThreadSpecific.h:

(WTF):
(WTF::threadSpecificKeyCreate): Added wrapper around pthread_key_create.
(WTF::threadSpecificKeyDelete): Added wrapper around pthread_key_delete.
(WTF::threadSpecificSet): Added wrapper around pthread_setspecific.
(WTF::threadSpecificGet): Added wrapper around pthread_getspecific.

  • wtf/ThreadSpecificWin.cpp:
5:17 PM Changeset in webkit [124822] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Rollout r116203. <rdar://problem/11932288>

5:14 PM Changeset in webkit [124821] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/JavaScriptCore

Merge <rdar://problem/11781190>

5:00 PM Changeset in webkit [124820] by commit-queue@webkit.org
  • 28 edits
    2 adds
    2 deletes in trunk

[CSS Shaders] Parse mix function
https://bugs.webkit.org/show_bug.cgi?id=90101

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-08-06
Reviewed by Dirk Schulze.

Source/WebCore:

Parse the mix function syntax for CSS Shaders as defined in the Filter Effects spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#FilterFunction

The fragment shader argument of the custom filter function can now be a mix function with
the following syntax:

mix(<uri> [ <blend-mode>
<alpha-compositing> ]?)

For example:
-webkit-filter: custom(url(shader.vert) mix(url(shader.frag multiply source-over))

The Filter Effects spec references the Compositing and Blending spec, which defines the
supported blend modes and alpha compositing modes.

Blend modes:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blend-mode

This patch adds all of the blend modes in the spec.

Alpha compositing modes:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#alpha-compositing

This patch does not add any new CSS values for alpha compositing. Currently, we parse the
values that are the same between the spec and the -webkit-background-composite property,
including:

clear
copy
source-over
source-in
source-out
source-atop
destination-over
destination-in
destination-out
destination-atop
xor

In the future, we may need to add the following CSS values for alpha compositing:

lighter
destination

This is currently under discussion on the www-style mailing list:
http://lists.w3.org/Archives/Public/www-style/2012Aug/0123.html

No new test files. Add test cases in:

css3/filters/script-tests/custom-filter-property-computed-style.js:
css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
css3/filters/script-tests/custom-filter-property-parsing.js:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSParser.cpp:

(WebCore::CSSParser::isBlendMode):
(WebCore):
(WebCore::CSSParser::isCompositeOperator):
(WebCore::CSSParser::parseMixFunction):
(WebCore::CSSParser::parseCustomFilter):

  • css/CSSParser.h:

(WebCore):

  • css/CSSParserValues.h:

(WebCore::CSSParserValueList::currentIndex):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator BlendMode):

  • css/CSSValue.cpp:

(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:

(WebCore::CSSValue::isWebKitCSSMixFunctionValue):
(CSSValue):

  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/WebKitCSSMixFunctionValue.cpp: Added.

(WebCore):
(WebCore::WebKitCSSMixFunctionValue::WebKitCSSMixFunctionValue):
(WebCore::WebKitCSSMixFunctionValue::customCssText):
(WebCore::WebKitCSSMixFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):

  • css/WebKitCSSMixFunctionValue.h: Added.

(WebCore):
(WebKitCSSMixFunctionValue):
(WebCore::WebKitCSSMixFunctionValue::create):

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::CustomFilterProgram):

  • platform/graphics/filters/CustomFilterProgram.h:

(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings):
(CustomFilterProgramMixSettings):
(WebCore):

  • rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::create):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):

LayoutTests:

Add tests for custom filter mix function parsing as defined in the Filter Effects spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#FilterFunction

Remove some mac-wk2 and chromium expectations because they are the same as the general
expectations.

  • css3/filters/custom/custom-filter-property-computed-style-expected.txt:
  • css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/custom-filter-property-computed-style.js:
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed.
4:58 PM Changeset in webkit [124819] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123780. <rdar://problem/11979232>

4:54 PM Rebaseline edited by pkasting@chromium.org
(diff)
4:51 PM Changeset in webkit [124818] by Lucas Forschler
  • 18 edits
    4 copies in branches/safari-536.26-branch/Source

Merged r123778. <rdar://problem/11979232>

4:46 PM Changeset in webkit [124817] by Patrick Gansterer
  • 5 edits in trunk/Source/JavaScriptCore

Unify JSC date and time formating functions
https://bugs.webkit.org/show_bug.cgi?id=92282

Reviewed by Geoffrey Garen.

Replace the existing functions for formating GregorianDateTime
with one single function. This removes some code duplications
in DatePrototype and is a preperation to fix encoding issues,
since we can add UChar* values to the resulting string now.

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

  • runtime/DateConversion.h:

(JSC):

  • runtime/DatePrototype.cpp:

(JSC::formateDateInstance):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):

4:43 PM Changeset in webkit [124816] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source

GraphicsLayerAnimation shouldn't use HashMap<String>
https://bugs.webkit.org/show_bug.cgi?id=93284

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use a vector containing all the animations instead of a map of String to Vector.
The HashMap contains very few elements, which makes it inefficient relatively to a vector.
This has been shown to be a bottleneck in valgrind.

Covered by existing animation tests.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimations::hasActiveAnimationsOfType):
(WebCore::GraphicsLayerAnimations::hasRunningAnimations):
(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::pause):
(WebCore::GraphicsLayerAnimations::remove):
(WebCore::GraphicsLayerAnimations::apply):

  • platform/graphics/GraphicsLayerAnimation.h:

(GraphicsLayerAnimation):
(WebCore::GraphicsLayerAnimation::name):
(GraphicsLayerAnimations):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

Source/WebKit2:

Apply the changes to GraphicsLayerAnimation API.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):

4:42 PM Changeset in webkit [124815] by beidson@apple.com
  • 32 edits
    1 copy
    7 adds in trunk

Out-of-process plug-ins should support asynchronous initialization
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919

Reviewed by Anders Carlsson.

Source/WebKit2:

If a plug-in has been deemed capable of asynchronous initialization when run out of process...
...then do that!

Add flags to communicate that this plugin create is meant to create a plug-in already requested asynchronously and
to include whether or not the initialize call should include an artificial delay (for testing):

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):

  • PluginProcess/PluginCreationParameters.h:

(PluginCreationParameters):

Add a flag for the UI Process to tell the PluginProcess that it supports asynchronous initialization:

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::PluginProcessCreationParameters):
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

Allow the UI Process to pass along whether the plug-on supports asynchronous initialization:

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):

  • UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

  • UIProcess/WebProcessProxy.messages.in:

Allow the Plugin Process to pass whether or not it supports asynchronous initialization, originally determined
in the UI Process, along to the WebProcess:

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::initializePluginProcess):
(WebKit::PluginProcess::createWebProcessConnection):

  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • UIProcess/Plugins/PluginProcessProxy.messages.in:

Add a flag so PluginProcessConnections remember whether or not they support asynchronous initialization:

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::setSupportsAsynchronousPluginInitialization):
(WebKit):

  • WebProcess/Plugins/PluginProcessConnection.h:

(WebKit::PluginProcessConnection::create):
(WebKit::PluginProcessConnection::supportsAsynchronousPluginInitialization):
(PluginProcessConnection):

Create PluginProcessConnections with the flag passed down from the PluginProcess about whether or not they
support asynchronous initialization:

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):

Responding to messages from the WebProcess, most of the heavy decision making in asynchronous initialization is here:

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::asynchronousInstanceIDsToIgnore): A set of instance IDs to *not* create asynchronously later because we know

we no longer need to.

(WebKit):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::destroyPlugin): If the plug-in doesn't exist but is awaiting asynchronous creation, flag

this instance ID in the "asynchronous ignore set".

(WebKit::WebProcessConnection::createPluginInternal): Renamed from createPlugin, actually does the plug-in creation.
(WebKit::WebProcessConnection::createPlugin): Adds the instance ID to the "asynchronous ignore set" then calls createPluginInternal.
(WebKit::WebProcessConnection::createPluginAsynchronously): If the instance ID is in the "asynchronous ignore set", remove it from the

set and do nothing else. Otherwise, perform the initialization and then send the asynchronous result back to the WebProcess.

  • PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

  • PluginProcess/WebProcessConnection.messages.in:

Add helpers for asynchronous initialization that all plug-in types must implement:

  • WebProcess/Plugins/Plugin.h:

(Plugin):

Add helpers for asynchronous initialization that plug-in controllers can override:

  • WebProcess/Plugins/PluginController.h:

(PluginController):
(WebKit::PluginController::asynchronousPluginInitializationEnabled):
(WebKit::PluginController::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::PluginController::artificialPluginInitializationDelayEnabled):

Give PluginProxys the ability to initialize either asynchronously or synchronously, and also the ability to synchronously
wait for previously asynchronous initialization (in case their PluginScriptObject is required):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::initialize): Store the plugin creation parameters as a member, and decide whether to try synchronous

or asynchronous initialization.

(WebKit):
(WebKit::PluginProxy::canInitializeAsynchronously): Answer based on preferences and what the PluginProcessConnection says

that it supports.

(WebKit::PluginProxy::waitForAsynchronousInitialization): Synchronously wait on initialization when asynchronous initialization

was previously requested.

(WebKit::PluginProxy::initializeSynchronously):
(WebKit::PluginProxy::didCreatePlugin): Double-check that we're still expecting asynchronous initialization, then call

through to didCreatePluginInternal.

(WebKit::PluginProxy::didCreatePluginInternal): Handle completion of initialization (both synchronously and asynchronously)
(WebKit::PluginProxy::didFailToCreatePlugin): Double-check that we're still expecting asynchronous initialization, then call

through to didFailToCreatePluginInternal.

(WebKit::PluginProxy::didFailToCreatePluginInternal): Handle failure to initialize (both synchronously and asynchronously)
(WebKit::PluginProxy::destroy):

  • WebProcess/Plugins/PluginProxy.h:

(WebKit):
(WebKit::PluginProxy::isInitializingAsynchronously):
(PluginProxy):

  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView): Always destroy the plug-in even if it hasn't been initialized yet, as it might be initializing

right now.

(WebKit::PluginView::initializePlugin): Don't handle the result of initialization immediately. Break that out in to two

methods that will be called later.

(WebKit):
(WebKit::PluginView::didFailToInitializePlugin):
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::scriptObject): If we truly need the script object, then wait for a synchronous initialization of the plug-in.
(WebKit::PluginView::asynchronousPluginInitializationEnabled):
(WebKit::PluginView::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::PluginView::artificialPluginInitializationDelayEnabled):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

These methods shouldn't be called in the PluginProcess, only in the WebProcess:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::didInitializePlugin):
(WebKit):
(WebKit::PluginControllerProxy::didFailToInitializePlugin):

  • PluginProcess/PluginControllerProxy.h:

(PluginControllerProxy):

NetscapePlugin is for in-process plug-ins:

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):
(WebKit::NetscapePlugin::waitForAsynchronousInitialization):
(WebKit::NetscapePlugin::isInitializingAsynchronously):

Built-in PDFView is currently only in-process:

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

(BuiltInPDFView):
(WebKit::BuiltInPDFView::waitForAsynchronousInitialization):
(WebKit::BuiltInPDFView::isInitializingAsynchronously):

Tools:

Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
for testing asynchronous plug-in initialization.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.

(SlowNPPNew):
(SlowNPPNew::SlowNPPNew):
(SlowNPPNew::NPP_New):

LayoutTests:

Add tests to make sure a plug-in with a long running NPP_New does not block the web thread.

  • platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-expected.txt: Added.
  • platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple-expected.txt: Added.
  • platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple.html: Added.
  • platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization.html: Added.
  • platform/mac-wk2/plugins/slow/resources/asynchronous-plugin-initialization-multiple-finish.html: Added.
4:35 PM Changeset in webkit [124814] by Lucas Forschler
  • 13 edits in branches/safari-536.26-branch/Source

Merged r123775. <rdar://problem/11979232>

4:33 PM Changeset in webkit [124813] by abarth@webkit.org
  • 5 edits
    1 move in trunk/Source

[Chromium] WebTouchCandidatesInfo should be part of the Client API
https://bugs.webkit.org/show_bug.cgi?id=93088

Reviewed by Eric Seidel.

Source/Platform:

All the input related interfaces are part of the client (rather than
the platform) part of the API. This patch moves WebTouchCandidatesInfo
to the client part of the API.

  • Platform.gypi:
  • chromium/public/WebTouchCandidatesInfo.h: Removed.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebTouchCandidatesInfo.h: Copied from Source/Platform/chromium/public/WebTouchCandidatesInfo.h.
  • src/WebViewImpl.cpp:
4:29 PM Changeset in webkit [124812] by Lucas Forschler
  • 11 edits in branches/safari-536.26-branch/Source/WebCore

Merged r123747. <rdar://problem/11979232>

4:23 PM Changeset in webkit [124811] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=93199
REGRESSION (r124489): Crash in FrameView::scrollContentsFastPath when
scrolling Facebook and Google image search
-and corresponding-
<rdar://problem/12035066>

Reviewed by Anders Carlsson.

As the comment in setShouldUpdateScrollLayerPositionOnMainThread()
indicates, the goal of adding a call to
updateMainFrameScrollPositionAndScrollLayerPosition() within that
function was just to make sure the layer position was up-to-date
since that is what is not kept up to date when scrolling is happening
on the scrolling thread. So I'm fixing this crash by having that code
ONLY update the layer position instead of also updating the scroll
position, since it was updating the scroll position that led to this
crash.

New function updateMainFrameScrollLayerPosition() will update JUST
the layer position.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPosition):

Update just the layer position here instead of the layer position and
the scroll position.
(WebCore)::

4:22 PM Changeset in webkit [124810] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Virtual test suites fail
https://bugs.webkit.org/show_bug.cgi?id=92515

Reviewed by Dirk Pranke.

The failure is because our bypassing of DriverProxy.
Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
and restart DRT when the command line changes.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
(ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
(ChromiumAndroidDriver.start): Restart DRT when the command line changes.
(ChromiumAndroidDriver._start_once):

4:19 PM Changeset in webkit [124809] by wangxianzhu@chromium.org
  • 6 edits in trunk/Tools

Remove NRWT --shard-ref-tests
https://bugs.webkit.org/show_bug.cgi?id=91539

This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
(https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):
(Sharder.shard_tests):
(Sharder._shard_in_two):
(Sharder._shard_by_directory):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(SharderTests):
(SharderTests.get_test_input):
(SharderTests.get_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_in_two):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._test_input_for_file):
(Manager._test_is_slow):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

4:05 PM Changeset in webkit [124808] by commit-queue@webkit.org
  • 5 edits in trunk

[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-08-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WTR wasn't using the proper font types provided by testfonts directory.
The same approach as DRT was applied and now it takes info from QFont to
update the store variable.

  • UIProcess/qt/WebPreferencesQt.cpp:

(WebKit::setStringValueIfInUserDefaults):
(WebKit):
(WebKit::WebPreferences::platformInitializeStore):

Tools:

Initializing TestFonts information into WTR binary. Doing it
later leads to wrong font names usage (Dejavu Serif instead
of Liberation Serif).

  • WebKitTestRunner/Target.pri:
  • WebKitTestRunner/qt/main.cpp:

(main):

4:03 PM Changeset in webkit [124807] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add twiz@{chromium|google}.org to the set of non-committer contributors.
https://bugs.webkit.org/show_bug.cgi?id=93288

Patch by Jeff Timanus <twiz@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers.py:
4:01 PM Changeset in webkit [124806] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Testcase LayoutTests/editing/input/editable-container-with-word-wrap-normal.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=93287

Patch by Pravin D <pravind.2k4@gmai.com> on 2012-08-06
Reviewed by Ryosuke Niwa.

The testcase uses 'End' keypress event emulation to scroll the caret to the end of the line. As the behavior of 'End' keypress
is platform dependent, replacing it platform independent code.

  • editing/input/editable-container-with-word-wrap-normal-expected.txt:
  • editing/input/editable-container-with-word-wrap-normal.html: Replaced 'End' keypress event with testRunner's execCommand() to make testcase behavior independent of platform.
4:01 PM Changeset in webkit [124805] by noam.rosenthal@nokia.com
  • 10 edits in trunk/Source/WebKit2

[Qt] Use GraphicsLayerAnimation in LayerTreeCoordinator
https://bugs.webkit.org/show_bug.cgi?id=93147

Reviewed by Kenneth Rohde Christiansen

Allow controlling animations outside of WebCore. This is an intermediate step before moving
to threaded animations.

CoordinatedGraphicsLayer maintains the GraphicsLayerAnimation structures, and applies the
animation interpolation at the right time, before syncing the rest of the layer info and
the visible contents rect.

This also allows sending shorter IPC messages for animated opacity/transform changes,
without the rest of the layer info.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setLayerAnimatedOpacity):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimatedTransform):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setAnimatedOpacity):
(WebKit):
(WebKit::LayerTreeRenderer::setAnimatedTransform):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):

account for the animated transform in the visible rect.

(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::removeAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore::CoordinatedGraphicsLayer::setAnimatedTransform):
(WebCore::CoordinatedGraphicsLayer::setAnimatedOpacity):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit):
(WebKit::LayerTreeCoordinator::setLayerAnimatedOpacity):
(WebKit::LayerTreeCoordinator::setLayerAnimatedTransform):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

3:30 PM Changeset in webkit [124804] by dimich@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug
https://bugs.webkit.org/show_bug.cgi?id=93297

Patch by Adrienne Walker <enne@google.com> on 2012-08-06
Reviewed by James Robinson.

This is a quick fix to get debug unit tests working again by
implementing a virtual function that has ASSERT_NOT_REACHED in the
base class version.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::scrollPosition):

3:24 PM Changeset in webkit [124803] by abarth@webkit.org
  • 3 edits in trunk/Tools

REGRESSION(124789): EWS errors out because --print option is missing
https://bugs.webkit.org/show_bug.cgi?id=93299

Unreviewed.

The --print option doesn't exist anymore. Let's try --quiet instead.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
2:59 PM Changeset in webkit [124802] by rniwa@webkit.org
  • 5 edits in trunk

run-webkit-tests should have ability to add description to its JSON output
https://bugs.webkit.org/show_bug.cgi?id=93296

Reviewed by Dirk Pranke.

PerformanceTests:

Parse description and show it with the WebKit revision on the results page. Also use bar graphs
instead of line graphs since we're not depicting the time series here per arv's suggestion.
Finally, add the ability to adjust y-axis between the adjusted value and 0 (plot even doesn't adjust
y-axis automatically now) by a mouse click.

  • resources/results-template.html:

Tools:

Add --description option.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._generate_and_show_results):
(PerfTestsRunner._generate_results_dict):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_with_description):

2:00 PM Changeset in webkit [124801] by dpranke@chromium.org
  • 14 edits in trunk/Tools

nrwt: handle errors from image diff better
https://bugs.webkit.org/show_bug.cgi?id=92934

Reviewed by Ojan Vafai.

Currently if ImageDiff crashes, returns a weird exit code, or
produces any stderr output, it's basically swallowed. This
change ensures that we log errors to stderr, and also appends
the error to the stderr for the test (so it'll show up in
results.html).

Most importantly, it'll cause diff_image() to fail and we'll
report ImageHashMismatch ... this may be kinda untrue, but I
think it's better than ignoring the error.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
(TestResultWriterTest):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.diff_image):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_diff_image_crashed):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

  • Scripts/webkitpy/layout_tests/port/image_diff.py:

(ImageDiffer.diff_image):
(ImageDiffer._read):

  • Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:

(TestImageDiffer.test_diff_image):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.test_diff_image_crashed):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_diff_image):
(PortTestCase):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_diff_image_crashed.make_proc):

  • Scripts/webkitpy/layout_tests/port/server_process_mock.py:

(MockServerProcess.init):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.diff_image):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_tolerance.ImageDiffTestPort.diff_image):

1:46 PM Changeset in webkit [124800] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: clean up printing.py
https://bugs.webkit.org/show_bug.cgi?id=93026

Reviewed by Dirk Pranke.

This patch cleans up the implementation of printing.py now
that we're not using all the original complexity.

There should be no changes in functionality and everything
should be covered by the existing tests.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.init):
(Printer.del):
(Printer.print_config):
(Printer.print_found):
(Printer.print_expected):
(Printer.print_workers_and_shards):
(Printer):
(Printer._print_expected_results_of_type):
(Printer.print_results):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
(Printer._print_one_line_summary):
(Printer.print_finished_test):
(Printer._print_test_result):
(Printer._print_test_trace):
(Printer._print_baseline):
(Printer._print_unexpected_test_result):
(Printer._print_progress):
(Printer._print_unexpected_results):
(Printer._print_unexpected_results.add_result):
(Printer._print_quiet):
(Printer._print_default):
(Printer._print_debug):
(Printer._print_for_bot):
(Printer.write_update):
(Printer.writeln):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.get_printer):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):

1:42 PM Changeset in webkit [124799] by andersca@apple.com
  • 9 edits in trunk

If the Apple Java plug-in is blocked and no runtime is installed, don't load it
https://bugs.webkit.org/show_bug.cgi?id=93289
<rdar://problem/11730092>

Reviewed by Dan Bernstein.

Source/WebKit2:

If the Apple Java plug-in is blocked, but there's no Java runtime installed (or the Java plug-in is disabled),
don't even include it in the plug-in info store.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.

  • UIProcess/Plugins/PluginInfoStore.h:

(PluginInfoStore):
shouldBlockPlugin can be static.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):
Return false if the Apple Java plug-in is blocked but Java isn't installed or enabled.

(WebKit::PluginInfoStore::shouldBlockPlugin):
Since this is static now, it shouldn't be const.

WebKitLibraries:

Add WKJLIsRuntimeAndWebComponentsInstalled().

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
1:41 PM Changeset in webkit [124798] by annacc@chromium.org
  • 3 edits in trunk/Source/WebCore

MediaSource should use it's own list of source URLs
https://bugs.webkit.org/show_bug.cgi?id=93285

Reviewed by Eric Carlson.

r124780 added MediaSource objects to PublicURLManager's streamURLs list,
piggy-backing on MEDIA_STREAM. This patch creates a sourceURLs list so
that MediaSource can stand on its own.

Test: builds on Andriod even when MEDIA_STREAM is disabled.

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • html/PublicURLManager.h:

(WebCore::PublicURLManager::contextDestroyed):
(PublicURLManager):
(WebCore::PublicURLManager::sourceURLs):

1:31 PM Changeset in webkit [124797] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Unbreak debug builds with the 10.7 SDK
https://bugs.webkit.org/show_bug.cgi?id=93202

Reviewed by James Robinson.

FMGetATSFontRefFromFont() is not available with the 10.7 SDK
when targetting 10.6. Don't delete this code completely yet,
it's still used with the 10.6 SDK when targetting 10.6 (which
chromium's build bots use).

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore):

1:31 PM Changeset in webkit [124796] by Lucas Forschler
  • 25 edits in branches/safari-536.26-branch/Source

Merged r122676. <rdar://problem/11932587>

1:22 PM Changeset in webkit [124795] by dpranke@chromium.org
  • 2 edits in trunk/Tools

change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=93043

Reviewed by Ryosuke Niwa.

in preparation for the cleanup of the logging flags in new-run-webkit-tests.

  • Scripts/run-webkit-tests:
12:56 PM Changeset in webkit [124794] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Layout Test: Windows specific tests needed for fast/css/getComputedStyle/computed-style.html & computed-style-without-renderer.html
https://bugs.webkit.org/show_bug.cgi?id=93033

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-06
Reviewed by Tim Horton.

Windows specific computed-style and computed-style-without-renderer tests are needed since CSS3 Flexbox is disabled on windows,
see https://bugs.webkit.org/show_bug.cgi?id=92047, new CSS3 Flexbox properties no longer used.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
12:17 PM Changeset in webkit [124793] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

need tests to ensure flexboxes play nicely with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=70771

Reviewed by Tony Chang.

Source/WebCore:

Anytime we grab the width/height off of the RenderStyle, we need to adjust
it for box-sizing. Fortunately, we only do this two places in RenderFlexibleBox.
Also, delete crossAxisLength since it's unused.

Test: css3/flexbox/box-sizing.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/box-sizing-expected.txt: Added.
  • css3/flexbox/box-sizing.html: Added.
12:04 PM Changeset in webkit [124792] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber
https://bugs.webkit.org/show_bug.cgi?id=93019

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-06
Reviewed by Pavel Feldman.

Source/WebCore:

Add test for WebInspector.linkifyStringAsFragment()

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

LayoutTests:

parseInt the RegExp match for lineNumber
New test case added to linkify.html

  • inspector/debugger/linkifier-expected.txt:
  • inspector/debugger/linkifier.html:
11:46 AM Changeset in webkit [124791] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, linting TestExpectations.

  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [124790] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit/chromium

Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=93127

Patch by Nasko Oskov <nasko@chromium.org> on 2012-08-06
Reviewed by Adam Barth.

Add support in the API to monitor and create frame hierarchy to allow replicating it
across different instances of WebKit.

  • public/WebDocument.h:

(WebDocument): Added createElement.

  • public/WebFrame.h: Added assignedName.
  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created.
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter.

  • public/WebNode.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):

  • src/WebDocument.cpp:

(WebKit::WebDocument::createElement): Added to allow for creating frame elements.
(WebKit):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API.
(WebKit):
(WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed
to the unique name, generated by WebKit.
(WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame.

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebNode.cpp:

(WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM.
(WebKit):

  • tests/WebFrameTest.cpp:
11:31 AM Changeset in webkit [124789] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: clean up logging, part 1
https://bugs.webkit.org/show_bug.cgi?id=93018

Reviewed by Ojan Vafai.

remove --print, --help-printing from nrwt, add three new options:
--quiet, which just logs warnings,errors, and unexpected results
--debug-rwt-logging, a new name for --verbose
--details, to get the old --print trace-everything behavior

This patch does not implement the new "one line per test"
--verbose behavior specified in bug 88702, and there's a bunch
of internal cleanup I can do in printing.py that I'll defer to
a later patch to make things easier to review.

This patch deletes a lot of unit tests that are no longer
necessary since there aren't so many logging combinations.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(parse_args):
(passing_run):
(StreamTestingMixin.assertContains):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_full_results_html):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_additional_platform_directory):
(RebaselineTest.assertBaselines):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(print_options):
(Printer.init):
(Printer.enabled):
(Printer.print_unexpected_results):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(TestUtilityFunctions.test_print_options):
(Testprinter.get_result_summary):
(Testprinter.test_configure_and_cleanup):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_unexpected_results):
(test_details):
(test_default):
(test_quiet):
(test_verbose):

11:29 AM Changeset in webkit [124788] by wangxianzhu@chromium.org
  • 4 edits in trunk/Tools

[Chromium-Android] Store test executable, data and fonts in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91910

/data/local/tmp is a directory with permission 0777 by default.
Place DumpRenderTree resources here so that both the native test app and
the NRWT script can access them even if adb shell isn't running as root.

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.driver_cmd_line):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._push_executable):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest.make_port):
(ChromiumAndroidPortTest.test_expectations_files):
(ChromiumAndroidDriverTest.test_drt_cmd_line):

11:19 AM Changeset in webkit [124787] by Lucas Forschler
  • 4 edits in tags/Safari-537.3.1/Source

Versioning

11:15 AM Changeset in webkit [124786] by Lucas Forschler
  • 1 copy in tags/Safari-537.3.1

New Tag.

11:15 AM Changeset in webkit [124785] by inferno@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Re-expose layoutTestController as various fuzzers depend on it
https://bugs.webkit.org/show_bug.cgi?id=93282

Reviewed by Ryosuke Niwa.

Unfortunately, various fuzzers used in the Chromium project still depends on
window.layoutTestController. Re-expose the object while they're making the transition.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::bindJSObjectsToWindow):

10:59 AM Changeset in webkit [124784] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 move
    1 add in trunk/Source

[Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
https://bugs.webkit.org/show_bug.cgi?id=92596

Patch by David Reveman <reveman@chromium.org> on 2012-08-06
Reviewed by Adrienne Walker.

Source/WebCore:

The CCTextureUpdater interface is used by the main thread to queue
texture updates. The CCTextureUpdateController constructor takes a
CCTextureUpdater and contains the logic required to perform texture
uploads and texture copies. This class is only used by the impl thread.

No new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):

  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::copyTexture):

  • platform/graphics/chromium/TextureCopier.h:

(Parameters):
(TextureCopier):
(AcceleratedTextureCopier):

  • platform/graphics/chromium/TextureUploader.h:

(Parameters):
(TextureUploader):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

  • platform/graphics/chromium/ThrottledTextureUploader.h:

(ThrottledTextureUploader):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Added.

(WebCore):
(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::updateTextures):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::~CCTextureUpdateController):
(WebCore::CCTextureUpdateController::hasMoreUpdates):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):

  • platform/graphics/chromium/cc/CCTextureUpdateController.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h.

(WebCore):
(CCTextureUpdateController):
(WebCore::CCTextureUpdateController::create):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::appendFullUpload):
(WebCore::CCTextureUpdater::appendPartialUpload):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::takeFirstFullUpload):
(WebCore::CCTextureUpdater::takeFirstPartialUpload):
(WebCore::CCTextureUpdater::takeFirstCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):
(WebCore::CCTextureUpdater::fullUploadSize):
(WebCore::CCTextureUpdater::partialUploadSize):
(WebCore::CCTextureUpdater::copySize):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
(CCThreadProxy):

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/WebExternalTextureLayer.cpp:
  • tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp.
  • tests/CCTiledLayerTestCommon.h:

(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):

  • tests/TextureCopierTest.cpp:

(TEST):

  • tests/TiledLayerChromiumTest.cpp:
10:46 AM Changeset in webkit [124783] by inferno@chromium.org
  • 8 edits
    2 adds in trunk

Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.

Source/WebCore:

In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.

Test: fast/lists/list-marker-remove-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

LayoutTests:

  • fast/lists/list-marker-remove-crash-expected.txt: Added.
  • fast/lists/list-marker-remove-crash.html: Added.
10:43 AM Changeset in webkit [124782] by shawnsingh@chromium.org
  • 6 edits in trunk/Source

[chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
https://bugs.webkit.org/show_bug.cgi?id=85808

Reviewed by Adrienne Walker.

Source/WebCore:

When computing the screen-space transforms, z values were not
being flattened when they should be. This caused incorrect
clipping due to occlusion tracking that relied on the screen-space
transform. The fix is to flatten the screen-space transform just
like the "sublayerMatrix" is flattened, when the layer does not
preserve-3d.

In addition to making the simple fix, it was convenient to make a
helper function for the flattening code.

Additional unit test added to exercise that flattening code:

CCLayerTreeHostCommonTest.verifyTransformsForFlatteningLayer

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::CCMathUtil::flattenTransformTo2d):
(WebCore):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(CCMathUtil):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
10:37 AM Changeset in webkit [124781] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545

Unreviewed trivial test fix after r124765.

  • http/tests/inspector-enabled/dedicated-workers-list.html:
10:28 AM Changeset in webkit [124780] by annacc@chromium.org
  • 20 edits
    4 copies
    1 add in trunk/Source/WebCore

Create a MediaSource object.
https://bugs.webkit.org/show_bug.cgi?id=91773

Reviewed by Eric Carlson.

MediaSource object is needed in order to implement the new
object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing:
https://bugs.webkit.org/show_bug.cgi?id=91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

New MediaSource object:

  • Modules/mediasource/MediaSource.cpp: Added.
  • Modules/mediasource/MediaSource.h: Added.
  • Modules/mediasource/MediaSource.idl: Added.

Create a registry for the blob storage and lookup:

  • Modules/mediasource/MediaSourceRegistry.cpp: Added.
  • Modules/mediasource/MediaSourceRegistry.h: Added.

Connect SourceBuffer to MediaSource:

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::buffered): Forward call to MediaSource.
(WebCore::SourceBuffer::append): Ditto.
(WebCore::SourceBuffer::abort): Ditto.

  • Modules/mediasource/SourceBuffer.h:

(WebCore::SourceBuffer::create): Add a MediaSource to the constructor.
(WebCore::SourceBuffer::clear): Clear the MediaSource.
(SourceBuffer):

  • Modules/mediasource/SourceBufferList.cpp: include SourceBuffer.h
  • Modules/mediasource/SourceBufferList.h:

Make MediaSource an EventTarget:

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Enable creation of MediaSource object URL from JavaScript:

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL):

  • html/DOMURL.h:

(WebCore):
(DOMURL):

  • html/DOMURL.idl:

New MediaSource constructor:

  • page/DOMWindow.idl:
10:04 AM Changeset in webkit [124779] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

Simplify CSSOM style declaration's grabbing at internals.
<http://webkit.org/b/93261>

Reviewed by Antti Koivisto.

It was already the case that StylePropertySets exposed in CSSOM were guaranteed mutable,
so remove the mechanism to convert immutable backing objects to mutable ones.

Made ensureCSSStyleDeclaration() non-const to prevent callers that may have an
immutable StylePropertySet from wrapping a CSSOM object around it.

  • css/PropertySetCSSStyleDeclaration.h:

(PropertySetCSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

Remove indirection and access StylePropertySet member directly.

  • css/StylePropertySet.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):

Made these two non-const. CSSOM wrappers should only ever be constructed around
mutable StylePropertySets.
Also added ASSERT(isMutable()).

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

Cast away the constness of StyledElement::attributeStyle(). It's not pretty,
but these objects are guaranteed mutable, and there's an assertion to protect
us in ensureCSSStyleDeclaration() if something changes in the future.

9:39 AM Changeset in webkit [124778] by commit-queue@webkit.org
  • 11 edits in trunk

Web Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events
https://bugs.webkit.org/show_bug.cgi?id=92739

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-08-06
Reviewed by Pavel Feldman.

Source/WebCore:

Implemented "namedFlowCreated" and "namedFlowRemoved" events.

Modified test: inspector/styles/protocol-css-regions-commands.html.

  • dom/WebKitNamedFlowCollection.cpp:

(WebCore::WebKitNamedFlowCollection::ensureFlowWithName):
(WebCore::WebKitNamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):

LayoutTests:

Modified test so that it validates the implemented events.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
9:38 AM Changeset in webkit [124777] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.9.6

Tagging the WebKitGTK+ 1.9.6 release

9:30 AM Changeset in webkit [124776] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Crash in FrameLoader::stopAllLoaders.
https://bugs.webkit.org/show_bug.cgi?id=90805

Reviewed by Nate Chapin.

Calling m_provisionalDocumentLoader->stopLoading() can blow away the frame
from underneath. Protect it with a RefPtr.

No new tests. We don't have a reliable testcase to reproduce this. However,
the crash and free stack from ClusterFuzz point clearly at the bug.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopAllLoaders):

9:07 AM Changeset in webkit [124775] by zandobersek@gmail.com
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening, rebaselining a few HTMLProgressElement tests
after changes in r124754.

  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
8:53 AM Changeset in webkit [124774] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r124692): webarchive/loading/javascript-url-iframe-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=93190

Reviewed by Adam Barth.

Apparently we can't just edit the markup in a webarchive file. Re-generated webarchive file
from a locally copied markup.

  • webarchive/loading/resources/javascript-url-iframe-crash.webarchive:
8:29 AM Changeset in webkit [124773] by hbono@chromium.org
  • 6 edits in trunk

Source/WebCore: Rolling out my r123067 and r123572
https://bugs.webkit.org/show_bug.cgi?id=93234

Reviewed by Ryosuke Niwa.

This change manually rolls out my r123067 and r123572 (except layout tests)
because it renders RTL text to a wrong place when an RTL element shows a
vertical scrollbar at its left side.

No new tests because this change rolls out my changes.

  • dom/Element.cpp:

(WebCore::Element::clientLeft):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintObject):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::topLeftLocationOffset):

LayoutTests: Rolling out for r123067 and r123572
https://bugs.webkit.org/show_bug.cgi?id=93234

Reviewed by Ryosuke Niwa.

This change marks tests that fail when rolling out my r123067 and r123572.

  • platform/chromium/TestExpectations:
8:24 AM Changeset in webkit [124772] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Regions] Add the NamedFlow.getRegions() API
https://bugs.webkit.org/show_bug.cgi?id=93240

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-06
Reviewed by Andreas Kling.

Source/WebCore:

This patch adds the NamedFlow.getRegions() API call as specified by http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow .
For now, WebKit supports only one type of regions, Element. The Region interface will be introduced when other interfaces will be capable
of becoming regions.

New test: fast/regions/webkit-named-flow-get-regions.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContent): Add a check not to include the pseudo-elements that are regions; those don't have a node attached.
(WebCore::WebKitNamedFlow::getRegions):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-named-flow
The test also verifies the regions are returned in document order.

  • fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
  • fast/regions/webkit-named-flow-get-regions.html: Added.
8:21 AM Changeset in webkit [124771] by commit-queue@webkit.org
  • 9 edits
    2 moves
    2 adds
    2 deletes in trunk

[CSS Regions] Rename regionOverflow to regionOverset
https://bugs.webkit.org/show_bug.cgi?id=93256

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-06
Reviewed by Andreas Kling.

Source/WebCore:

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-region-regionoverset
The regionOverflow property has been renamed to regionOverset in the latest working draft. This patch applies the change both externally and
internally in the code.

Tests: No new tests because this is not a functional change.

  • dom/Element.cpp:

(WebCore::Element::renderRegion): Convenience method to access the renderer for a region element.
(WebCore):
(WebCore::Element::webkitRegionOverset):

  • dom/Element.h:

(WebCore):

  • dom/Element.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOversetRect):

  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/#dom-region-regionoverset

The tests have been adapted to use webkitRegionOverset rather than webkitRegionOverflow.

  • fast/regions/element-region-overflow-state-expected.txt: Removed.
  • fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Removed.
  • fast/regions/element-region-overset-state-expected.txt: Added.
  • fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
  • fast/regions/element-region-overset-state-vertical-rl.html: Renamed from LayoutTests/fast/regions/element-region-overflow-state-vertical-rl.html.
  • fast/regions/element-region-overset-state.html: Renamed from LayoutTests/fast/regions/element-region-overflow-state.html.
  • fast/regions/webkit-named-flow-first-empty-region-index.html:
7:54 AM Changeset in webkit [124770] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=89382

Reviewed by Ryosuke Niwa.

Allow to load an external resource as the main frame
and allow all subsequent external loads for such a main
frame. This behavior is necessary for being able to run
performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::isLocalHost):
(WTR):
(WTR::isHTTPOrHTTPSScheme):
(WTR::InjectedBundlePage::willSendRequestForFrame):

7:39 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
7:14 AM Changeset in webkit [124769] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent
https://bugs.webkit.org/show_bug.cgi?id=93257

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-06
Reviewed by Pavel Feldman.

Moving error string setting inside highlightConfigFromInspectorObject.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

7:09 AM Changeset in webkit [124768] by yurys@chromium.org
  • 71 edits in trunk/Source/WebCore

Web Inspector: add memory instrumentation for CSSValue and its descendants
https://bugs.webkit.org/show_bug.cgi?id=93130

Reviewed by Pavel Feldman.

Added memory footprint reporting routine to CSSValue and its descendants.

Memory reporing for CSSValue is organized in a following way:

  • CSSValue implements reportMemoryUsage method that switches by the value type and calls reportDescendantMemoryUsage on the concrete type
  • There may be some intermediate classes in the inheritance chain between CSSValue and the leaf class implementing reportDescendantMemoryUsage. Those intermediate classes implement reportBaseClassMemoryUsage method that can be called from a descendant to collect memory information for the base class members. Having reportDescendantMemoryUsage only on the leaf classes prevents us from accidentally adding the intermediate classes to the switch block in the CSSValue::reportMemoryUsage.
  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSAspectRatioValue.h:

(CSSAspectRatioValue):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSBorderImageSliceValue.h:

(CSSBorderImageSliceValue):

  • css/CSSCalculationValue.cpp:

(WebCore):
(WebCore::CSSCalcValue::reportDescendantMemoryUsage):
(CSSCalcPrimitiveValue):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(CSSCalcValue):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSCanvasValue.h:

(CSSCanvasValue):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSCursorImageValue.h:

(CSSCursorImageValue):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSFunctionValue.h:

(CSSFunctionValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):

  • css/CSSGradientValue.h:

(CSSGradientColorStop):
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
(WebCore):

  • css/CSSImageGeneratorValue.h:

(CSSImageGeneratorValue):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):

  • css/CSSImageSetValue.h:

(ImageWithScale):
(CSSImageSetValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSImageValue.h:

(CSSImageValue):

  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSInheritedValue.h:

(CSSInheritedValue):

  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSInitialValue.h:

(CSSInitialValue):

  • css/CSSLineBoxContainValue.cpp:

(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSLineBoxContainValue.h:

(CSSLineBoxContainValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):

  • css/CSSTimingFunctionValue.h:

(CSSLinearTimingFunctionValue):
(CSSCubicBezierTimingFunctionValue):
(CSSStepsTimingFunctionValue):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSUnicodeRangeValue.h:

(CSSUnicodeRangeValue):

  • css/CSSValue.cpp:

(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
(TextCloneCSSValue):
(WebCore::CSSValue::reportMemoryUsage):
(WebCore):

  • css/CSSValue.h:

(WebCore):
(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):
(WebCore):

  • css/CSSValueList.h:

(CSSValueList):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
(CSSVariableValue):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
(WebCore):

  • css/FontFeatureValue.h:

(FontFeatureValue):

  • css/FontValue.cpp:

(WebCore::FontValue::reportDescendantMemoryUsage):
(WebCore):

  • css/FontValue.h:

(FontValue):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::reportDescendantMemoryUsage):
(WebCore):

  • css/ShadowValue.h:

(ShadowValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
(WebCore):

  • css/WebKitCSSFilterValue.h:

(WebKitCSSFilterValue):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
(WebCore):

  • css/WebKitCSSSVGDocumentValue.h:

(WebKitCSSSVGDocumentValue):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
(WebCore):

  • css/WebKitCSSShaderValue.h:

(WebKitCSSShaderValue):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
(WebCore):

  • css/WebKitCSSTransformValue.h:

(WebKitCSSTransformValue):

  • dom/MemoryInstrumentation.cpp:

(WebCore::MemoryInstrumentation::addString):
(WebCore):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addHashCountedSet):
(WebCore::MemoryClassInfo::addMember):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::reportDescendantMemoryUsage):
(WebCore):

  • svg/SVGColor.h:

(SVGColor):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::reportDescendantMemoryUsage):
(WebCore):

  • svg/SVGPaint.h:

(SVGPaint):

7:09 AM Changeset in webkit [124767] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline for Mac10.6 against r124752

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
7:05 AM Changeset in webkit [124766] by toyoshim@chromium.org
  • 4 edits
    3 adds
    7 deletes in trunk/LayoutTests

Unreviewed, rebaseline for r124754.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
  • platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
  • platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
6:51 AM Changeset in webkit [124765] by yurys@chromium.org
  • 16 edits in trunk/Source

Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
https://bugs.webkit.org/show_bug.cgi?id=92545

Reviewed by Pavel Feldman.

Source/WebCore:

  • Replaced WorkerAgent.setWorkerInspectionEnabled with WorkerAgent.enable/disable
  • Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers() that tells if inspector front-end on the given platform can launch dedicated worker front-end.
  • inspector/Inspector.json:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canInspectWorkers):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::enable):
(WebCore):
(WebCore::InspectorWorkerAgent::disable):

  • inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):
(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers()
that tells if inspector front-end on the given platform can launch dedicated worker
front-end.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canInspectWorkers):
(WebKit):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

  • src/js/DevTools.js:
6:45 AM Changeset in webkit [124764] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.9.6 release

.:

  • configure.ac: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.9.6.
6:43 AM Changeset in webkit [124763] by mario@webkit.org
  • 8 edits in trunk/Source

[WK2][GTK] Improvements for the new spell-checking API
https://bugs.webkit.org/show_bug.cgi?id=93262

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Provide a way to ask TextCheckerEnchant helper class for the list
of languages currently available for the spell checking feature.

  • platform/text/gtk/TextCheckerEnchant.cpp:

(enchantDictDescribeCallback): Renamed from
getAvailableDictionariesCallback, for consistency.
(TextCheckerEnchant::updateSpellCheckingLanguages): Updated usage
of getAvailableDictionariesCallback to enchantDictDescribeCallback.
(TextCheckerEnchant::getSpellCheckingLanguages): New. Will build
and return a String with a comma-separated list of languages
currently in use by the spell checking feature.

  • platform/text/gtk/TextCheckerEnchant.h:

(TextCheckerEnchant): Added new function getSpellCheckingLanguages.

Source/WebKit2:

Improve the way the new spell-checking API is implemented, by
using better internal representations for data, documenting better
the new functions and using better unit tests.

  • UIProcess/API/gtk/WebKitTextChecker.cpp:

(WebKitTextChecker::getSpellCheckingLanguages): Just return the
value previously cached when calling to the setter function.
(WebKitTextChecker::setSpellCheckingLanguages): Update the text
checker in WebCore and cache the value returned from it.

  • UIProcess/API/gtk/WebKitTextChecker.h:

(WebKitTextChecker): Use a CString instead of an String to cache
the list of spell checking languages. Update getter and setter.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate): No need to cache the spell checking
languages here anymore.
(webkit_web_context_get_spell_checking_languages): Improve
both implementation and documentation to be more consistent.
(webkit_web_context_set_spell_checking_languages): Make
'languages' a mandatory (non-NULL) parameter. Update documentation.

  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextSpellChecker): Test even more situations.

6:35 AM Changeset in webkit [124762] by kbalazs@webkit.org
  • 3 edits in trunk/Tools

[WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
https://bugs.webkit.org/show_bug.cgi?id=93120

Reviewed by Csaba Osztrogonác.

Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
so it will be able to detect an unresponsive web process.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_timeout_ms):

  • WebKitTestRunner/TestController.cpp:

(WTR):

6:30 AM Changeset in webkit [124761] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-06

  • platform/qt/Skipped: Skip new SHADOW_DOM tests.
  • platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Rebase after r124754.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Rebase after r124754.
6:14 AM Changeset in webkit [124760] by kling@webkit.org
  • 14 edits in trunk/Source/WebCore

Pass presentational attribute StylePropertySets by const pointer where possible.
<http://webkit.org/b/93187>

Reviewed by Antti Koivisto.

Minor cleanup to enforce (at compile time) the fact that no methods that have the
side-effect of incurring immutable-to-mutable-StylePropertySet conversion.

This was already covered by assertions, we're just making it stricter and adding
some documentational flavor.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::attributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):
(StyledElement):
(WebCore::StyledElement::attributeStyle):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

6:04 AM Changeset in webkit [124759] by commit-queue@webkit.org
  • 12 edits
    11 adds in trunk

Add DeviceProximityEvent interface
https://bugs.webkit.org/show_bug.cgi?id=92942

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-06
Reviewed by Kentaro Hara.

Source/WebCore:

Spec : http://www.w3.org/TR/proximity/#idl-def-DeviceProximityEvent

Add DeviceProximityEvent interface of Proximity Events.
And add onwebkitdeviceproximity event handler to the DOMWindow.

Tests: fast/dom/Proximity/check-event-deviceproximity.html

fast/dom/Proximity/create-event-deviceproximity.html
fast/events/constructors/device-proximity-event-constructor.html

  • CMakeLists.txt:
  • Modules/proximity/DeviceProximityEvent.cpp: Added.

(WebCore):
(WebCore::DeviceProximityEvent::DeviceProximityEvent):

  • Modules/proximity/DeviceProximityEvent.h: Added.

(WebCore):
(WebCore::DeviceProximityEventInit::DeviceProximityEventInit):
(DeviceProximityEventInit):
(DeviceProximityEvent):
(WebCore::DeviceProximityEvent::~DeviceProximityEvent):
(WebCore::DeviceProximityEvent::create):
(WebCore::DeviceProximityEvent::value):
(WebCore::DeviceProximityEvent::min):
(WebCore::DeviceProximityEvent::max):
(WebCore::DeviceProximityEvent::interfaceName):

  • Modules/proximity/DeviceProximityEvent.idl: Added.
  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:

LayoutTests:

Add tests for creating and handling the DeviceProximityEvent.

  • fast/dom/Proximity/check-event-deviceproximity-expected.txt: Added.
  • fast/dom/Proximity/check-event-deviceproximity.html: Added.
  • fast/dom/Proximity/create-event-deviceproximity-expected.txt: Added.
  • fast/dom/Proximity/create-event-deviceproximity.html: Added.
  • fast/events/constructors/device-proximity-event-constructor-expected.txt: Added.
  • fast/events/constructors/device-proximity-event-constructor.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
6:03 AM Changeset in webkit [124758] by abecsi@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] Remove workarounds from input event handling
https://bugs.webkit.org/show_bug.cgi?id=93125

Reviewed by Jocelyn Turcotte.

Since input event propagation in Qt5 has been fixed we can remove
the workarounds introduced to prevent the QML WebView from receiving
input events targeting a child dialog.
To do this the childMouseEventFilter function has to be changed to
force touch and mouse events through the default propagation path.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebView::childMouseEventFilter):
(QQuickWebView::touchEvent):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate):

  • UIProcess/qt/QtDialogRunner.cpp:

(WebKit::QtDialogRunner::run):

  • UIProcess/qt/WebColorChooserProxyQt.cpp:

(WebKit::WebColorChooserProxyQt::createItem):
(WebKit::WebColorChooserProxyQt::endChooser):

  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):

5:35 AM Changeset in webkit [124757] by Carlos Garcia Campos
  • 6 edits in trunk

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing header file.

Source/WebCore:

  • GNUmakefile.list.am: Remove unexistent header file.

Tools:

  • GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
5:27 AM Changeset in webkit [124756] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
https://bugs.webkit.org/show_bug.cgi?id=82724

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-06
Reviewed by Csaba Osztrogonác.

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::removeAllVisitedLinks):

LayoutTests:

  • platform/efl/Skipped:
5:02 AM Changeset in webkit [124755] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

[JSC] Remove custom JSBindings for constructArrayBufferView()
https://bugs.webkit.org/show_bug.cgi?id=93097

Patch by Vineet Chaudhary <Vineet> on 2012-08-06
Reviewed by Kentaro Hara.

Currently TypedArray files have the custom implementation of constructArrayBufferView().
We can can remove these modifying CodeGeneratorJS.pm

Tests: TestTypedArray.idl

  • bindings/js/JSFloat32ArrayCustom.cpp: Removed custom call constructArrayBufferView().
  • bindings/js/JSFloat64ArrayCustom.cpp: Ditto.
  • bindings/js/JSInt16ArrayCustom.cpp: Ditto.
  • bindings/js/JSInt32ArrayCustom.cpp: Ditto.
  • bindings/js/JSUint16ArrayCustom.cpp: Ditto.
  • bindings/js/JSUint32ArrayCustom.cpp: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Modified Generator code to generate bindings for

constructArrayBufferView()
(GenerateConstructorDefinition):

  • bindings/scripts/IDLAttributes.txt: Added [TypedArray] attribute.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Tests result.

(WebCore::JSFloat64ArrayConstructor::getConstructData):
(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):

  • bindings/scripts/test/TestTypedArray.idl: Test.
  • html/canvas/Float32Array.idl: Using [TypedArray].
  • html/canvas/Float64Array.idl: Ditto.
  • html/canvas/Int16Array.idl: Ditto.
  • html/canvas/Int32Array.idl: Ditto.
  • html/canvas/Uint16Array.idl: Ditto.
  • html/canvas/Uint32Array.idl: Ditto.
5:00 AM Changeset in webkit [124754] by shinyak@chromium.org
  • 16 edits
    13 adds in trunk

AuthorShadowDOM for progress element
https://bugs.webkit.org/show_bug.cgi?id=91969

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for progress element.

According to the Shadow DOM spec, a progress element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'progress' bar. In this patch, we change the inner structure
of a progress element so that we can distribute an element having RenderProgress to AuthorShadowDOM.

Before this patch, a progress element has the following inner structure.

<progress>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- ProgressBarElement
|
+-- ProgressValueElement

After this patch, a progress element will have the following inner structure.

<progress>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot

|
+-- ProgressInnerElement

|
+-- ProgressBarElement
|
+-- ProgressValueElement

Tests: fast/dom/shadow/shadowdom-for-progress-dynamic.html

fast/dom/shadow/shadowdom-for-progress-multiple.html
fast/dom/shadow/shadowdom-for-progress-with-style.html
fast/dom/shadow/shadowdom-for-progress-without-appearance.html
fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html
fast/dom/shadow/shadowdom-for-progress.html

  • css/html.css:

(progress::-webkit-progress-inner-element):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createRenderer):
(WebCore::HTMLProgressElement::renderProgress): Returns RenderProgress gotten from UserAgentShadowDOM.
(WebCore):
(WebCore::HTMLProgressElement::willAddAuthorShadowRoot):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::createShadowSubtree): Creates a new Shadow DOM structure.

  • html/HTMLProgressElement.h:

(WebCore):
(WebCore::HTMLProgressElement::hasAuthorShadowRoot):
(HTMLProgressElement):
(WebCore::isHTMLProgressElement):
(WebCore::toHTMLProgressElement):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressShadowElement::progressElement):
(WebCore::ProgressInnerElement::ProgressInnerElement): We introduce a new element having RenderProgress
so that we can distribute an element having RenderProgress to AuthorShadowDOM.
(WebCore):
(WebCore::ProgressInnerElement::create):
(WebCore::ProgressInnerElement::shadowPseudoId):
(WebCore::ProgressInnerElement::createRenderer):
(WebCore::ProgressInnerElement::rendererIsNeeded):

  • html/shadow/ProgressShadowElement.h:

(ProgressShadowElement):
(WebCore):
(ProgressInnerElement):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::progressElement):

  • rendering/RenderProgress.h:

(RenderProgress):

LayoutTests:

Contains the following tests:

(1) progress element with AuthorShadowDOM
(2) progress element with multiple AuthorShadowDOM with a shadow element
(3) progress element with multiple AuthorShadowDOM without a shadow element
(4) progress element with AuthorShadowDOM with dynamic value update
(5) progress element with AuthorShadowDOM with style
(6) progress element with AuthorShadowDOM with -webkit-appearance: none

  • fast/dom/HTMLProgressElement/progress-clone-expected.txt:
  • fast/dom/HTMLProgressElement/progress-clone.html:
  • fast/dom/HTMLProgressElement/progress-element-markup-expected.txt:
  • fast/dom/shadow/resources/replaced-element-styles.css: Added.

(.progress-like):
(.progress-inner-element-like):

  • fast/dom/shadow/shadowdom-for-progress-dynamic-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-dynamic.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-multiple-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-multiple.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-with-style-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-with-style.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-without-appearance-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-without-appearance.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-without-shadow-element-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html: Added.
  • fast/dom/shadow/shadowdom-for-progress.html: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
  • platform/mac/TestExpectations:
4:37 AM Changeset in webkit [124753] by keishi@webkit.org
  • 12 edits in trunk

Remove minimum window size for PagePopup
https://bugs.webkit.org/show_bug.cgi?id=93100

Reviewed by Kent Tamura.

Source/WebCore:

DOMWindow had a minimum size of 100x100 pixels. We need to remove that limit for PagePopup window.

No new tests. Covered in platform/chromium/fast/forms/color/color-suggestion-picker-{one,two}-row-appearance.html.

  • Resources/colorSuggestionPicker.css:

(.color-swatch-container):

  • page/ChromeClient.h:

(WebCore::ChromeClient::minimumWindowSize):
(ChromeClient):

  • page/DOMWindow.cpp:

(WebCore):
(WebCore::DOMWindow::adjustWindowRect): Asks Chrome::minimumWindowSize for minimum window size.

  • page/DOMWindow.h:

(DOMWindow):

Source/WebKit/chromium:

  • src/WebPagePopupImpl.cpp: Returns 0x0 so the page popup can be smaller than 100x100.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html: Added background color so we can check that we don't have extra white area.
  • platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html: Ditto.
4:06 AM Changeset in webkit [124752] by toyoshim@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed, rebaseline for r124745.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • platform/chromium-mac/fast/block/float/032-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
3:30 AM Changeset in webkit [124751] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip new asserting tests to paint the bots green.

  • platform/qt/Skipped:
3:29 AM Changeset in webkit [124750] by arko@motorola.com
  • 4 edits
    2 adds in trunk

Microdata: document.getItems() must treat no token as no parameter.
https://bugs.webkit.org/show_bug.cgi?id=93071

Reviewed by Ryosuke Niwa.

Source/WebCore:

document.getItems() must return all top-level microdata items in the
document when no tokens specified in the argument.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#dom-document-getitems

Test: fast/dom/MicroData/getitems-empty-string-as-arg.html

  • dom/Document.cpp:

(WebCore::Document::getItems): Create an empty string identifier when typeNames is null string
to map such request in the cache.

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::undefinedItemType): Changed undefinedItemType() to empty string.
(WebCore::MicroDataItemList::nodeMatches): Return true if m_typeNames contains no token.

LayoutTests:

Added test to verify that document.getItems() returns all top-level
microdata items in the document when no tokens specified in the argement.

  • fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Added.
  • fast/dom/MicroData/getitems-empty-string-as-arg.html: Added.
3:19 AM Changeset in webkit [124749] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=91632

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-08-06
Reviewed by Pavel Feldman.

Extracted struct HighlightInfo from struct HighlightData in DOMNodeHighlighter.
Now InspectorOverlay receives node or rect to highlight together with highlightInfo.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::highlightRect):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):

  • inspector/DOMNodeHighlighter.h:

(HighlightConfig):
(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(InspectorDOMAgent):

3:17 AM Changeset in webkit [124748] by hayato@chromium.org
  • 1 edit
    18 deletes in trunk/LayoutTests

Remove unused png files from platform/chromium-linux/fast/css/variables.
https://bugs.webkit.org/show_bug.cgi?id=93232

Reviewed by Tony Chang.

  • platform/chromium-linux/fast/css/variables/block-cycle-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/colors-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/declaration-block-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/font-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/image-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/import-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/inline-style-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/invalid-variable-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/margin-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/misplaced-import-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/misplaced-variables-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/multiple-blocks-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/multiple-term-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/override-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/print-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/remove-variable-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/set-variable-test-expected.png: Removed.
  • platform/chromium-linux/fast/css/variables/shorthand-test-expected.png: Removed.
2:57 AM Changeset in webkit [124747] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: Web Inspector: single line test fix for r124744.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

2:44 AM Changeset in webkit [124746] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r124739.
http://trac.webkit.org/changeset/124739
https://bugs.webkit.org/show_bug.cgi?id=93241

newly added test crash on chromium linux debug (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-06

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

LayoutTests:

  • fast/lists/list-marker-remove-crash-expected.txt: Removed.
  • fast/lists/list-marker-remove-crash.html: Removed.
2:38 AM Changeset in webkit [124745] by allan.jensen@nokia.com
  • 7 edits in trunk

Fix layoutMod in fractional layout units.
https://bugs.webkit.org/show_bug.cgi?id=92374

Reviewed by Levi Weintraub.

Source/WebCore:

The modulo operation is upgraded from only being performed in integer to
being performed in fractionalLayoutUnits, so that it returns an accurate
remainder for fractionalLayoutUnit division.

An alternative modulo operation is added and used to find the remainder
after division with natural integer results, for instance, the remainding
height after pagination.

No new functionality. No new tests.

  • platform/FractionalLayoutUnit.h:

(WebCore::intMod):
(WebCore::operator%):

  • rendering/LayoutTypes.h:

(WebCore::layoutMod):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):

LayoutTests:

Mark minor pixel changes in the baseline as expected failures.

  • platform/chromium/TestExpectations:
2:12 AM Changeset in webkit [124744] by loislo@chromium.org
  • 29 edits in trunk/Source/WebCore

Web Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=91734

Reviewed by Yury Semikhatsky.

Old version of native memory instrumentation doesn't mark the memory cache objects as visited.
As a result MI could count the same objects multiple times.
The new version just traverses through MemoryCache the same way as through DOM.
Also not all the cached resource types were counted.

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:
  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedCSSStyleSheet.h:

(WebCore):
(CachedCSSStyleSheet):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedFont.h:

(CachedFont):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedImage.h:

(CachedImage):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedRawResource.h:

(WebCore):
(CachedRawResource):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedResource.h:

(WebCore):
(CachedResource):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedResourceHandle.h:

(WebCore):
(CachedResourceHandleBase):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore):
(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.h:

(WebCore):
(CachedResourceLoader):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedSVGDocument.h:

(CachedSVGDocument):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedScript.h:

(WebCore):
(CachedScript):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedShader.h:

(WebCore):
(CachedShader):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
(WebCore):

  • loader/cache/CachedXSLStyleSheet.h:

(WebCore):
(CachedXSLStyleSheet):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):
(WebCore):

  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

  • platform/PurgeableBuffer.h:

(WebCore):
(PurgeableBuffer):

1:55 AM FeatureFlags edited by gyuyoung.kim@samsung.com
(diff)
1:46 AM FeatureFlags edited by gyuyoung.kim@samsung.com
(diff)
1:27 AM Changeset in webkit [124743] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/forms/range/slider-mouse-events.html and fast/forms/range/slider-onchange-event.html fail after r124625
https://bugs.webkit.org/show_bug.cgi?id=93231

Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-06

  • platform/qt-5.0-wk2/Skipped:
1:02 AM Changeset in webkit [124742] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit

[EFL] [GTK] Register Protocol Handler Client is never deleted
https://bugs.webkit.org/show_bug.cgi?id=92745

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-06
Reviewed by Gustavo Noronha Silva.

Added usage of OwnPtr to manage register protocol handler client pointer.

Source/WebKit/efl:

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:

(WebCore::RegisterProtocolHandlerClientEfl::create): Factory function returning smart pointer.
(WebCore):

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.h:

(RegisterProtocolHandlerClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Source/WebKit/gtk:

  • WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp:

(WebKit::RegisterProtocolHandlerClient::create): Factory function returning smart pointer.
(WebKit):

  • WebCoreSupport/RegisterProtocolHandlerClientGtk.h:

(RegisterProtocolHandlerClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
1:00 AM Changeset in webkit [124741] by mario@webkit.org
  • 10 edits
    2 adds in trunk

[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=90268

Reviewed by Martin Robinson.

Source/WebKit2:

Add a simple spell checking API to WK2, allowing to enable/disable
this feature and to define a list of languages associated to it.

  • GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
  • GNUmakefile.list.am: Added new files

Added new internal class that will act both as the implementation
of TextCheckerClient and as the object WebKitWebContext will
depend on to implement the newly added API.

  • UIProcess/API/gtk/WebKitTextChecker.cpp: Added.

(toTextChecker):
(continuousSpellCheckingEnabledCallback):
(setContinuousSpellCheckingEnabledCallback):
(checkSpellingOfStringCallback):
(guessesForWordCallback):
(learnWordCallback):
(ignoreWordCallback):
(WebKitTextChecker::~WebKitTextChecker):
(WebKitTextChecker::create):
(WebKitTextChecker::WebKitTextChecker):
(WebKitTextChecker::checkSpellingOfString):
(WebKitTextChecker::getGuessesForWord):
(WebKitTextChecker::learnWord):
(WebKitTextChecker::ignoreWord):
(WebKitTextChecker::setSpellCheckingEnabled):
(WebKitTextChecker::setSpellCheckingLanguages):

  • UIProcess/API/gtk/WebKitTextChecker.h: Added.

(WebKitTextChecker):
(WebKitTextChecker::isSpellCheckingEnabled):
(WebKitTextChecker::getSpellCheckingLanguages):

Added WKTextChecker to WebKitPrivate.h, needed in WebKitTextChecker.

  • UIProcess/API/gtk/WebKitPrivate.h:

Add new API to WebKitWebContext to allow enabling/disabling this
spell checking feature, and to set/get the list of languages used
to decide which dictionaries will be consulted.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_get_spell_checking_enabled): New API.
(webkit_web_context_set_spell_checking_enabled): Ditto.
(webkit_web_context_get_spell_checking_languages): Ditto.
(webkit_web_context_set_spell_checking_languages): Ditto.

  • UIProcess/API/gtk/WebKitWebContext.h:

New tests for checking the new API added to WebKitWebContext.

  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextSpellChecker):
(beforeAll):

Update documentation with new sections and symbols.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Ignore WebKitTextChecker.* private files for gtk-doc.

  • gtk/generate-gtkdoc:

(get_webkit2_options):

12:57 AM Changeset in webkit [124740] by toyoshim@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline for chromium gardening.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2012-08-06

  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
12:50 AM Changeset in webkit [124739] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash in WebCore::RenderListItem::updateMarkerLocation
https://bugs.webkit.org/show_bug.cgi?id=90476

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-06
Reviewed by Abhishek Arya.

Source/WebCore:

In some cases an anonymous block is destroyed when its last child is
removed. RenderListItem did not expect this and has it's own logic for
cleaning up such blocks when the list marker is removed. Detect this
case in RenderBlock::removeChild to defer to the logic in RenderListItem::updateListMarker.

Test: fast/lists/list-marker-remove-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

LayoutTests:

  • fast/lists/list-marker-remove-crash-expected.txt: Added.
  • fast/lists/list-marker-remove-crash.html: Added.
12:33 AM Changeset in webkit [124738] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Roll out r124728 because of build bot test fail.

  • Scripts/webkitpy/common/config/watchlist:
12:27 AM Changeset in webkit [124737] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing tests.

  • platform/qt/Skipped:
12:13 AM Changeset in webkit [124736] by loislo@chromium.org
  • 20 edits in trunk/Source/WebCore

Web Inspector: NMI: replace addString with addMember overload function.
https://bugs.webkit.org/show_bug.cgi?id=93201

Reviewed by Yury Semikhatsky.

It is impossible to implement nice instrumentation for template containers
content when we have different function names for different types.

Drive by: fix the most annoing warning in Element.h detected by our clang plugin.

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::reportDescendantMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::reportMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.cpp:

(WebCore::MemoryInstrumentation::addObject):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addMember):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

Aug 5, 2012:

11:39 PM Changeset in webkit [124735] by tkent@chromium.org
  • 8 edits
    1 add in trunk/Source

[Chromium-win] Use system locale for number representation
https://bugs.webkit.org/show_bug.cgi?id=93085

Reviewed by Hajime Morita.

Source/WebCore:

We have used LocaleICU for number localization (presentation of <input
type=number>) even on Windows. This patch introduces number localization
feature with Windows API to LocaleWin, and we stop using LocaleICU on
Windows.

Tests: Add new test cases to WebKit/chromium/tests/LocaleWinTest.cpp.

  • WebCore.gyp/WebCore.gyp:
  • Stop using LocaleICU.{cpp,h} and LocalizedNumberICU.cpp.
  • Add LocalizedNumberWin.cpp.
  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::LocaleWin):

  • Initialize m_didInitializeNumberData.
  • Use getLocaleInfo() to obtain LOCALE_IFIRSTDAYOFWEEK.

(WebCore::LocaleWin::getLocaleInfo):
Added. A helper to obtain integer locale value.
(WebCore::LocaleWin::initializeNumberLocalizerData):
Added. Prepare data for number localization, and pass it to NumberLocalizer.

  • platform/text/LocaleWin.h:

(LocaleWin): Inherit NumberLocalizer, and declare some new members.

  • platform/text/win/LocalizedNumberWin.cpp: Added.

(WebCore::convertToLocalizedNumber):
Forward to the corresponding function of LocaleWin.
(WebCore::convertFromLocalizedNumber): ditto.
(WebCore::localizedDecimalSeparator): ditto.

Source/WebKit/chromium:

  • WebKit.gypi:

Don't include Localized*ICUTest.cpp in Windows and OSX. They are unnecessary.

  • tests/LocaleWinTest.cpp:

(LocaleWinTest): Add some LCID symbols.
(LocaleWinTest::decimalSeparator):
A helper for LocaleWinTest.decimalSeparator.
(TEST_F(LocaleWinTest, decimalSeparator)):
A test for LocaleWin::localizedDecimalSeparator(). This is a copy of the
corresponding test in LocalizedNumberICUTest.cpp.
(testNumberIsReversible):
A test helper LocaleWinTest.localizedNumberRoundTrip. This is a copy of
the corresponding test in LocalizedNumberICUTest.cpp.
(testNumbers): ditto.
(TEST_F(LocaleWinTest, localizedNumberRoundTrip)):
Tests for LocaleWin changes. This is a copy of the corresponding tests
in LocalizedNumberICUTest.cpp.

11:35 PM Changeset in webkit [124734] by yosin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] form tests are flaky, mostly on Linux
https://bugs.webkit.org/show_bug.cgi?id=78620

Unreviewed. Update test expecations for

fast/forms/formaction-attribute.html
fast/forms/formmethod-attribute-button-html.html
fast/forms/formmethod-attribute-input-html.html

based on the latest dashboard.

  • platform/chromium/TestExpectations:
11:31 PM Changeset in webkit [124733] by pdr@google.com
  • 4 edits
    2 adds in trunk

Fix assertion during detach of SVG wrappers without baseVal
https://bugs.webkit.org/show_bug.cgi?id=93063

Reviewed by Nikolas Zimmermann.

Source/WebCore:

r131583 introduced a change where SVGAnimatedListPropertyTearOff required
a baseVal to be set before detaching wrappers. This caused an assertion
to be hit if no baseVal was set.
This patch changes this behavior so that wrappers are detached even if
no baseVal is set.

Test: svg/animations/dynamic-modify-transform-without-baseval.html

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize): Extracted this static method for detaching wrappers without needing an SVGListProperty.
(SVGListProperty):
(WebCore::SVGListProperty::detachListWrappers):

LayoutTests:

  • svg/animations/dynamic-modify-transform-without-baseval-expected.txt: Added.
  • svg/animations/dynamic-modify-transform-without-baseval.html: Added.
11:09 PM Changeset in webkit [124732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp
https://bugs.webkit.org/show_bug.cgi?id=93224

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-05
Reviewed by Kentaro Hara.

Need to remove DeviceMotionEvent.h and DeviceOrientationEvent.h from Document.cpp.
They are not used anymore in that file.

No new tests. No change in behavior.

  • dom/Document.cpp:
10:10 PM Changeset in webkit [124731] by yosin@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] fast/forms/focus2.html fails
https://bugs.webkit.org/show_bug.cgi?id=45061

Unreviewed. Chromium DRT sets tabsToLink to false. So, Chrimium DRT doesn't set focus to anchor.

  • platform/chromium/TestExpectations: Removed fast/forms/focus2.html
  • platform/chromium/fast/forms/focus2-expected.txt: Added.
8:27 PM Changeset in webkit [124730] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[CMAKE] Move media source files from #ifdef ENABLE(MEDIA_SOURCE) to existing file list
https://bugs.webkit.org/show_bug.cgi?id=93219

Reviewed by Hajime Morita.

r122688 removed duplicating #ifdef guards from CMakeLists.txt. But, ENABLE_MEDIA_SOURCE is added to
CMakeList using duplicating #ifdef again.

No new tests. No change in behavior.

  • CMakeLists.txt:
8:16 PM Changeset in webkit [124729] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Web Inspector: [JSC] implement setting breakpoints by line:column
https://bugs.webkit.org/show_bug.cgi?id=53003

Source/JavaScriptCore:

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
Reviewed by Geoffrey Garen.

Add a counter to Lexer to record the column info of each Token. Add a column parameter to
op_debug, cti_op_debug, and _llint_op_debug byte-code command.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitDebugHook):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

  • debugger/Debugger.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):

  • interpreter/Interpreter.h:

(Interpreter):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

  • parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):

  • parser/Lexer.h:

(Lexer):
(JSC::Lexer::currentColumnNumber):
(JSC::::lexExpectIdentifier):

  • parser/NodeConstructors.h:

(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):

  • parser/Nodes.cpp:

(JSC::StatementNode::setLoc):
(JSC):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

  • parser/Nodes.h:

(Node):
(JSC::Node::columnNo):
(ExpressionNode):
(StatementNode):
(JSC::StatementNode::column):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):

  • parser/Parser.cpp:

(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

  • parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::tokenLocation):
(Parser):
(JSC::Parser::getTokenName):
(JSC::::parse):

  • parser/ParserTokens.h:

(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
(JSToken):

  • parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::closeBraceToken):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

Source/WebCore:

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05
Reviewed by Geoffrey Garen.

Since JSC can provide column info now, ScriptDebugServer can use it to support "Pretty Print"
debug mode. The related interfaces derived from JSC::Debugger was added a parameter.

No new tests for this patch.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore):
(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):

  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

Source/WebKit/mac:

Unreviewed, just changed the interface according the changes of base class JSC::Debugger.

No JSC can provide the column info of current JS statement, mac porting can use it to support
"Pretty Print" debug mode.

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-05

  • WebView/WebScriptDebugger.h:

(WebScriptDebugger):

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):

7:45 PM Changeset in webkit [124728] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Change my email address for watch list.

  • Scripts/webkitpy/common/config/watchlist:
7:40 PM Changeset in webkit [124727] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectation updates.

  • platform/chromium/TestExpectations: assign bug for fast/text/international/bold-bengali.html
7:35 PM Changeset in webkit [124726] by macpherson@chromium.org
  • 2 edits in trunk/LayoutTests

Enable fast/css/variables tests by default for chromium.
https://bugs.webkit.org/show_bug.cgi?id=92610

Reviewed by Tony Chang.

Since variables are now compiled in by default on chromium there is no reason not to run these tests.

  • platform/chromium/TestExpectations:
6:50 PM Changeset in webkit [124725] by joone@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Marked the following test cases as known failures
tracked by the bug 93213, 93214, 92956, 93212.

fast/text/international/text-spliced-font.html
http/tests/loading/307-after-303-after-post.html
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
http/tests/incremental/slow-utf8-text.pl

  • platform/efl/TestExpectations:
6:36 PM Changeset in webkit [124724] by benjamin@webkit.org
  • 4 edits
    4 adds in trunk

Assert in checkValidity() in hashtable.h from WebGeolocationManager::didFailToDeterminePosition() when fetching http://html5demos.com/geo
https://bugs.webkit.org/show_bug.cgi?id=80386

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-05
Reviewed by Alexey Proskuryakov.

Source/WebKit2:

WebKit2's WebGeolocationManager was delivering events without accounting that each event
can modify the list of page that need delivery.
Any page can remove itself by invoking clearWatch() from the callback function. A page can also cause another
page to be removed.

This patch solves the issue by taking a copy of the list of page before delivery. Each page is
referenced as it can be deleted during the delivery.

Unfortunately, this cannot be tested due to missing features of WebKitTestRunner.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

LayoutTests:

Add tests for clearing the Geolocation as a listener from a callback originated from the GeolocationController.

  • fast/dom/Geolocation/error-clear-watch-expected.txt: Added.
  • fast/dom/Geolocation/error-clear-watch.html: Added.
  • fast/dom/Geolocation/success-clear-watch-expected.txt: Added.
  • fast/dom/Geolocation/success-clear-watch.html: Added.
  • platform/wk2/Skipped:
6:22 PM Changeset in webkit [124723] by macpherson@chromium.org
  • 3 edits
    2 adds in trunk

Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=92461

Reviewed by Eric Seidel.

Source/WebCore:

Invalid variable lists could cause CSSGrammar.y to pass null as value to storeVariableDeclaration, so we now check for null.

Test: fast/css/variables/invalid-value-list-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::storeVariableDeclaration):

LayoutTests:

Test case that causes CSSParser::storeVariableDeclaration to be passed a null value.

  • fast/css/variables/invalid-value-list-crash-expected.txt: Added.
  • fast/css/variables/invalid-value-list-crash.html: Added.
6:19 PM Changeset in webkit [124722] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Updte text expectation.

Remove an entry for media/media-fragments/TC0010-TC0019.html.
It doesn't exist any more.

  • platform/chromium/TestExpectations:
6:12 PM Changeset in webkit [124721] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium-win] Use the default locale only if the browser locale matches to it
https://bugs.webkit.org/show_bug.cgi?id=93083

Reviewed by Hajime Morita.

For a calendar picker, we have used month names and day-of-week names
obtained from the OS default locale. However, the year-month format and
[Today] [Clear] labels are decided with the browser locale. It made
calendar pickers with mixed languages.

To make calendar pickers with a single language, we use the OS default
locale only if the browser locale matches to it.
This patch changes the behavior for Windows Vista or later. No change
for Windows XP because of API support limitation.

No new tests. Behavior for locale setting is not testable in WebKit.

  • platform/text/LocaleWin.cpp:

(determineCurrentLCID):
Added. If the system has no LocaleNameToLCID API, just returns
LOCALE_USER_DEFAULT. Otherwise, if the system locale matches to the
browser locale, it returns LOCALE_USER_DEFAULT, otherwise it returns the
LCID for the browser locale.
(WebCore::LocaleWin::currentLocale): Uses determineCurrentLCID().

6:09 PM FeatureFlags edited by tkent@chromium.org
ANIMATION_API (diff)
2:03 PM Changeset in webkit [124720] by Antti Koivisto
  • 19 edits in trunk/Source/WebCore

Don't reuse cached stylesheet with failed or canceled resource loads
https://bugs.webkit.org/show_bug.cgi?id=93203

Reviewed by Simon Fraser.

1) Go to apple.com
2) Reload repeatedly

Eventually you can get into state where some images don't load.

The problem is that a cached stylesheet may end up pointing to image resources that have been canceled (by the reload).
If this happens they stay in the canceled state even when the stylesheet is applied to a new document.

Fix by checking if all loads are complete (or pending) when restoring a cached stylesheet. The sheet is only used
if there are no failed or canceled loads. There are potential more sophisticated fixes but this is simple and safe.
Walking the sheet is fast and since it is only done on cache restore the cost is minimal.

No regression test yet though the new code does get exercised by the existing tests.

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::hasFailedOrCanceledSubresources):
(WebCore):

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::hasFailedOrCanceledSubresources):
(WebCore):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::hasFailedOrCanceledSubresources):
(WebCore):

  • css/CSSImageSetValue.h:

(CSSImageSetValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::hasFailedOrCanceledSubresources):
(WebCore):

  • css/CSSImageValue.h:

(CSSImageValue):

  • css/CSSValue.cpp:

(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore):

  • css/CSSValue.h:

(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::hasFailedOrCanceledSubresources):
(WebCore):

  • css/CSSValueList.h:

(CSSValueList):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::hasFailedOrCanceledSubresources):
(WebCore):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):
(WebCore):
(WebCore::StyleSheetContents::hasFailedOrCanceledSubresources):

  • css/StyleSheetContents.h:

(StyleSheetContents):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::loadFailedOrCanceled):

1:55 PM Changeset in webkit [124719] by Patrick Gansterer
  • 3 edits in trunk/Source/WebKit/win

[WIN] Use sizeof() for cbWndExtra values
https://bugs.webkit.org/show_bug.cgi?id=93179

Reviewed by Eric Carlson.

Using sizof() instead of hardcoding the pointer size of
the 32bit platform allows us to use the code on 64bit too.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::registerHUDWindowClass):

  • WebView.cpp:

(WebView::registerWebViewWindowClass):

1:27 PM CoordinatedGraphicsSystem.svg attached to CoordinatedGraphicsSystem by kenneth@webkit.org
11:40 AM Changeset in webkit [124718] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Move V8Proxy methods that set DOM attributes/callbacks to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=93103

Reviewed by Adam Barth.

To remove V8Proxy, we can move V8Proxy methods that set DOM
attributes/callbacks to V8Binding.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:

(WebCore::batchConfigureAttributes):
(WebCore):
(WebCore::batchConfigureCallbacks):
(WebCore::batchConfigureConstants):

  • bindings/v8/V8Binding.h:

(BatchedAttribute):
(WebCore):
(WebCore::configureAttribute):
(BatchedConstant):
(BatchedCallback):

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

(WebCore):

9:28 AM Changeset in webkit [124717] by fischman@chromium.org
  • 5 edits in trunk/LayoutTests

media/video-poster-blocked-by-willsendrequest.html isn't blocking poster on willsendrequest
https://bugs.webkit.org/show_bug.cgi?id=92824

Reviewed by Ryosuke Niwa.

Chromium/Mac/GTK DRTs appear not to clear the cache between tests so append a unique query-string param to avoid a cache hit in this test.
Filed 93195 for the chromium port, Mac has 82976, and GTK has 79760.

  • media/video-poster-blocked-by-willsendrequest.html:
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
8:39 AM Changeset in webkit [124716] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove V8Proxy::registerExtensionWithV8()
https://bugs.webkit.org/show_bug.cgi?id=93115

Reviewed by Adam Barth.

V8Proxy::registerExtensionWithV8() is used by V8Proxy::registerExtension()
only. We can remove the redundant method.

In a follow-up patch, I will implement V8Proxy::registerExtentionIfNeeded()
and remove registerExtensionWithV8() and registerExtension().

No tests. No change in behavior.

  • bindings/v8/V8Proxy.cpp:

(WebCore::staticExtensionsList): Just moved to near related methods.
(WebCore):
(WebCore::V8Proxy::extensions):
(WebCore::V8Proxy::registerExtension):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

8:37 AM CoordinatedGraphicsSystem edited by noam.rosenthal@nokia.com
(diff)
8:37 AM Changeset in webkit [124715] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove unused enum and typedefs in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93105

Reviewed by Adam Barth.

In preparation for removing V8Proxy, we can remove unused enum
and typedefs in V8Proxy.

No tests. No change in behavior.

  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

(WebCore::throwError):

Aug 4, 2012:

10:55 PM Changeset in webkit [124714] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
https://bugs.webkit.org/show_bug.cgi?id=91348

Reviewed by Andy Estes.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged): Changed to call notifyContentAreaScrolled()
only if the scroll position after the change differs from what it was before the change.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollPosition): Added an override of this ScrollableArea function.

  • rendering/RenderListBox.h:
9:31 PM WikiStart edited by glenn@skynav.com
note outdated topics (diff)
8:23 PM Changeset in webkit [124713] by fischman@chromium.org
  • 6 edits in trunk

HTMLMediaElement may fire the seeked event before currentTime reaches the seek time
https://bugs.webkit.org/show_bug.cgi?id=92881

Reviewed by Eric Carlson.

Source/WebCore:

Testing provided by media/video-seek-past-end-paused.html, hopefully demonstrating lack of redness on all ports/bots this time.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): don't finishSeek() until the media player is no longer seeking.

LayoutTests:

This is mostly a re-land of r114005, alongside a fix for HTMLMediaElement.

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • platform/chromium/TestExpectations:
7:30 PM Changeset in webkit [124712] by thakis@chromium.org
  • 2 edits in trunk/Tools

[Chromium Mac] Tests are exiting early due to failures to load missingImage.png
https://bugs.webkit.org/show_bug.cgi?id=93186

Reviewed by Ryosuke Niwa.

Add missingImage.png to DumpRenderTree.app's Resource folder.
Depends on http://crrev.com/150037 rolling into webkit first.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
7:13 PM Changeset in webkit [124711] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-04

  • DEPS:
6:24 PM Changeset in webkit [124710] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Another test fix after r124708.

  • platform/mac/editing/selection/word-thai.html:
6:21 PM Changeset in webkit [124709] by rniwa@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Rebaseline fast/css-grid-layout/place-cell-by-index.html on Qt after r124671
since the test now passes (yay!).

Skip a test added by r124673 on Qt since it uses gestureTap (tracked by the bug 66272).

  • platform/qt/Skipped:
  • platform/qt/fast/css-grid-layout: Removed.
  • platform/qt/fast/css-grid-layout/place-cell-by-index-expected.txt: Removed.
5:44 PM Changeset in webkit [124708] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Another test fixes after r124705. Revert erroneous changes in r124707 using binary editor.

  • fast/parser/test-unicode-characters-in-attribute-name.html:
  • http/tests/misc/submit-post-in-utf16be.html:
5:30 PM Changeset in webkit [124707] by rniwa@webkit.org
  • 24 edits in trunk/LayoutTests

Test fixes after r124705. There were still few tests that used layoutTestController because
they were encoded in UTF-16 and UTF-32 and neither spot light nor grep could search through.

  • editing/pasteboard/copy-paste-float.html:
  • editing/selection/thai-word-at-document-end.html:
  • fast/css/hexColor-isDigit-assert.html:
  • fast/encoding/bom-in-content-utf16.html:
  • fast/encoding/utf-32-big-endian-bom.html:
  • fast/encoding/utf-32-big-endian-nobom.xml:
  • fast/encoding/utf-32-little-endian-bom.html:
  • fast/encoding/utf-32-little-endian-nobom.xml:
  • fast/parser/test-unicode-characters-in-attribute-name.html:
  • fast/ruby/text-emphasis.html:
  • fast/text/offsetForPosition-cluster-at-zero.html:
  • http/tests/misc/submit-get-in-utf16be.html:
  • http/tests/misc/submit-get-in-utf16le.html:
  • http/tests/misc/submit-get-in-utf32be.html:
  • http/tests/misc/submit-get-in-utf32le.html:
  • http/tests/misc/submit-post-in-utf16be.html:
  • http/tests/misc/submit-post-in-utf16le.html:
  • http/tests/misc/submit-post-in-utf32be.html:
  • http/tests/misc/submit-post-in-utf32le.html:
  • http/tests/misc/url-in-utf16be.html:
  • http/tests/misc/url-in-utf16le.html:
  • http/tests/misc/url-in-utf32be.html:
  • http/tests/misc/url-in-utf32le.html:
4:49 PM Changeset in webkit [124706] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the Qt Windows build after r124654.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::glyphForCharacter): Enclosed this function in
#if !(PLATFORM(QT) && !HAVE(QRAWFONT)).

3:58 PM Changeset in webkit [124705] by rniwa@webkit.org
  • 10 edits in trunk/Tools

Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
https://bugs.webkit.org/show_bug.cgi?id=93173

Reviewed by Adam Barth.

Don't expose window.layoutTestController since all layout tests use window.testRunner
instead of window.layoutTestController as of r124685.

We can safely rename classes and files to use TestRunner once this patch is landed.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::makeWindowObject):

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(notifyTestCompletion):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::waitUntilDone):
(PluginTest::notifyDone):

  • DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:

(ConvertPoint::NPP_SetWindow):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventCarbon):
(handleEventCocoa):
(handleEventWin):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::initJSObjects):

  • Scripts/bencher:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::makeWindowObject):

3:49 PM Changeset in webkit [124704] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactor SubframeLoader::requestPlugin/loadPlugin for clarity.
https://bugs.webkit.org/show_bug.cgi?id=93138

Patch by Mike West <mkwst@chromium.org> on 2012-08-04
Reviewed by Adam Barth.

SubframeLoader::requestPlugin and SubframeLoader::loadPlugin both do a
variety of checks to determine whether or not a specific resource ought
to instantiate a plugin in a specific context. r124636[1] moved one of
those checks, but there doesn't seem to be a clear way to determine
which checks should be performed where.

This patch refactors the checks out of those two methods for clarity,
moving them all into a new method: SubframeLoader::pluginIsLoadable.
That method requires the resource URL and MIME type, as well as the
object or embed element that owns this bit of rendering. The URL
and type are used directly to determine availability, while the element
is currently used only to create a renderer on which
setPluginUnavailabilityReason can be called if the plugin is blocked by
Content Security Policy.

This patch introduces no new tests, as it shouldn't change the code's
behavior: it should be a straightforward refactoring without web-visible
side-effects.

[1]: http://trac.webkit.org/changeset/124636

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::pluginIsLoadable):

A new method that extracts the various 'Should we allow this plugin
in this context?' checks from requestPlugin and loadPlugin into ine
location, rather than spreading them across both.

(WebCore):
(WebCore::SubframeLoader::requestPlugin):
(WebCore::SubframeLoader::loadPlugin):

  • loader/SubframeLoader.h:

(SubframeLoader):

3:08 PM Changeset in webkit [124703] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: filteredItemSelectionDialog.css has wrong selector for highlights
https://bugs.webkit.org/show_bug.cgi?id=93168

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-08-04
Reviewed by Pavel Feldman.

Selector required span to be a child, but highlights are themselves span. Used descendent selector.
No new tests: I'll make one next week, to go with bug 93166

  • inspector/front-end/filteredItemSelectionDialog.css:

(.js-outline-dialog > .container > div.item span.highlight):

2:12 PM Changeset in webkit [124702] by rniwa@webkit.org
  • 8 edits in trunk/PerformanceTests

Use testRunner instead of layoutTestController in performance tests
https://bugs.webkit.org/show_bug.cgi?id=93184

Reviewed by Adam Barth.

  • Animation/balls.html:
  • Dromaeo/resources/dromaeorunner.js:
  • inspector/console-300-lines.html:
  • inspector/inspector-startup-time.html:
  • inspector/network-append-30-requests.html.broken:
  • inspector/show-panel.html.broken:
  • resources/runner.js:

(PerfTestRunner.logInfo):
(PerfTestRunner.initAndStartLoop):

12:07 PM CoordinatedGraphicsSystem edited by kenneth@webkit.org
(diff)
12:04 PM CoordinatedGraphicsSystem edited by kenneth@webkit.org
(diff)
11:24 AM CoordinatedGraphicsSystem edited by noam.rosenthal@nokia.com
Applies name changes in trunk. (diff)
10:52 AM Changeset in webkit [124701] by noam.rosenthal@nokia.com
  • 29 edits
    14 moves
    2 adds in trunk/Source

[Qt] UI_SIDE_COMPOSITING code has confusing names
https://bugs.webkit.org/show_bug.cgi?id=93164

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Renamed and consolidated code guarded under UI_SIDE_COMPOSITING, now under
USE(COORDINATED_GRAPHICS) guard and CoordinatedGraphics folders.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebLayerTreeInfo.cpp:
  • Shared/WebLayerTreeInfo.h:
  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::updatePaintNode):

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::paint):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp.
  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/texmap/LayerBackingStore.h.
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp: Renamed from Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp.
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h: Renamed from Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h.
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in: Renamed from Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.messages.in.
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp: Renamed from Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp.
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h: Renamed from Source/WebKit2/UIProcess/WebLayerTreeRenderer.h.
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit):

  • UIProcess/DrawingAreaProxy.h:

(DrawingAreaProxy):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::ContentsSGNode):
(WebKit::ContentsSGNode::layerTreeRenderer):
(ContentsSGNode):
(WebKit::QtWebPageSGNode::setRenderer):

  • UIProcess/qt/QtWebPageSGNode.h:

(WebKit):
(QtWebPageSGNode):

  • WebKit2.pri:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleAnimation):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp.
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h.
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp.
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h: Renamed from Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.h.
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp.
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h.
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.messages.in: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.messages.in.
  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

  • WebProcess/WebPage/UpdateAtlas.cpp:
  • WebProcess/WebPage/UpdateAtlas.h:
  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

Source/WTF:

Renamed UI_SIDE_COMPOSITING to COORDINATED_GRAPHICS.

  • wtf/Platform.h:
7:23 AM Changeset in webkit [124700] by loislo@chromium.org
  • 2 edits in trunk/Tools

Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.

  • clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:

(clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):

5:33 AM CoordinatedGraphicsSystem edited by kenneth@webkit.org
(diff)
5:31 AM CoordinatedGraphicsSystem edited by kenneth@webkit.org
(diff)
5:13 AM CoordinatedGraphicsSystem edited by kenneth@webkit.org
(diff)
4:21 AM CoordinatedGraphicsSystem edited by kenneth@webkit.org
(diff)
4:13 AM Changeset in webkit [124699] by robert@webkit.org
  • 12 edits
    2 adds in trunk/LayoutTests

Rebaseline Chromium results after r124697

Unreviewed, gardening.

  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium/TestExpectations:
3:29 AM Changeset in webkit [124698] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/Source/WebKit2

[WK2] Move WebIntentData from Shared to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=93175

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-04
Reviewed by Kenneth Rohde Christiansen.

Move WebIntentData from Shared to UIProcess to
prepare for MessagePorts support in WK2.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/WebIntentData.cpp: Renamed from Source/WebKit2/Shared/WebIntentData.cpp.

(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::extra):
(WebKit::WebIntentData::extras):

  • UIProcess/WebIntentData.h: Renamed from Source/WebKit2/Shared/WebIntentData.h.

(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::service):
(WebKit::WebIntentData::store):
(WebKit::WebIntentData::type):

2:59 AM Changeset in webkit [124697] by robert@webkit.org
  • 16 edits
    28 adds in trunk

CSS 2.1 failure: overflow-applies-to-001 fails
https://bugs.webkit.org/show_bug.cgi?id=93148

Reviewed by Eric Seidel.

Source/WebCore:

Overflow no longer applies to table-rows or table-row-groups, it only applies
to block containers: http://www.w3.org/TR/CSS21/visufx.html#overflow

Tests: css2.1/20110323/overflow-applies-to-001.htm

css2.1/20110323/overflow-applies-to-002.htm
css2.1/20110323/overflow-applies-to-003.htm
css2.1/20110323/overflow-applies-to-004.htm
css2.1/20110323/overflow-applies-to-005.htm
css2.1/20110323/overflow-applies-to-006.htm
css2.1/20110323/overflow-applies-to-007.htm
css2.1/20110323/overflow-applies-to-008.htm
css2.1/20110323/overflow-applies-to-009.htm
css2.1/20110323/overflow-applies-to-010.htm
css2.1/20110323/overflow-applies-to-012.htm
css2.1/20110323/overflow-applies-to-013.htm
css2.1/20110323/overflow-applies-to-014.htm
css2.1/20110323/overflow-applies-to-015.htm

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):

LayoutTests:

  • css2.1/20110323/overflow-applies-to-001-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-001.htm: Added.
  • css2.1/20110323/overflow-applies-to-002-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-002.htm: Added.
  • css2.1/20110323/overflow-applies-to-003-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-003.htm: Added.
  • css2.1/20110323/overflow-applies-to-004-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-004.htm: Added.
  • css2.1/20110323/overflow-applies-to-005-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-005.htm: Added.
  • css2.1/20110323/overflow-applies-to-006-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-006.htm: Added.
  • css2.1/20110323/overflow-applies-to-007-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-007.htm: Added.
  • css2.1/20110323/overflow-applies-to-008-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-008.htm: Added.
  • css2.1/20110323/overflow-applies-to-009-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-009.htm: Added.
  • css2.1/20110323/overflow-applies-to-010-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-010.htm: Added.
  • css2.1/20110323/overflow-applies-to-012-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-012.htm: Added.
  • css2.1/20110323/overflow-applies-to-013-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-013.htm: Added.
  • css2.1/20110323/overflow-applies-to-014-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-014.htm: Added.
  • css2.1/20110323/overflow-applies-to-015-expected.html: Added.
  • css2.1/20110323/overflow-applies-to-015.htm: Added.

Tests from the CSS test suite.

  • fast/css/nested-layers-with-hover.html: Made this dumpAsText/waitUntilDone - the test relies on a simulated hover so

wasn't meaningful as a rendertree.

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:

These are all progressions and now render the same as FF and Opera.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
2:01 AM Changeset in webkit [124696] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Unskip http/tests/security/contentSecurityPolicy tests on various ports.
https://bugs.webkit.org/show_bug.cgi?id=93178

Patch by Mike West <mkwst@chromium.org> on 2012-08-04
Reviewed by Adam Barth.

After landing r124636, the Content Security Policy object-src tests
have greened up on the Chromium port. I expect the other ports to be
equally happy. Let's reenable the tests to find out.

  • platform/efl/TestExpectations:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
1:13 AM Changeset in webkit [124695] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

BindingSecurity::shouldAllowAccessToNode shouldn't detour through Frame to find the node's document
https://bugs.webkit.org/show_bug.cgi?id=93140

Reviewed by Eric Seidel.

Previously, shouldAllowAccessToNode took a detour through the Frame to
find the Document associated with a given Node. That's crazy! Nodes
already know their documents. This patch removes the detour.

It's theoretically possible that this patch changes behavior in the
case where the Frame is 0, but I couldn't find any situations in which
we call this function on nodes in inactive documents because the
typical way you find a node worth checking security on is via
a JavaScript window object.

  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
(WebCore::BindingSecurity::allowSettingFrameSrcToJavascriptUrl):

12:49 AM Changeset in webkit [124694] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline after r124691.

  • editing/deleting/smart-editing-disabled-expected.txt:
12:31 AM Changeset in webkit [124693] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

[V8] Re-wire "target" half of the same-origin security check through Document rather than DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=93079

Reviewed by Eric Seidel.

Before this patch, we were traversing from Nodes to Frames to
DOMWindows to SecurityOrigins when determing the "target" of an
operation for the same-origin policy security check. Rather than
detouring through DOMWindow, these security checks should operate in
terms of ScriptExecutionContexts (aka Documents) because that's the
canonical place we store SecurityOrigin objects.

A future patch will re-wire the "active" part of the security check to
use ScriptExecutionContexts as well and we'll be able to remove the
extra copy of SecurityOrigin that we keep in DOMWindow.

  • bindings/generic/BindingSecurity.cpp:

(WebCore::canAccessDocument):
(WebCore::BindingSecurity::canAccessFrame):
(WebCore::BindingSecurity::shouldAllowAccessToNode):

  • bindings/v8/BindingState.cpp:

(WebCore::immediatelyReportUnsafeAccessTo):

  • bindings/v8/BindingState.h:

(WebCore):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::reportUnsafeJavaScriptAccess):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::reportUnsafeAccessTo):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

12:22 AM Changeset in webkit [124692] by rniwa@webkit.org
  • 271 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in tests still found to be using layoutTestController by grep
https://bugs.webkit.org/show_bug.cgi?id=93177

Reviewed by Adam Barth.

After this patch, neither grep nor spot light finds any tests that use layoutTestController
and we can safely land the patch on the bug 93173.

  • editing/pasteboard/input-with-visibility-hidden.html:
  • fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
  • fast/encoding/script-in-head.html:
  • fast/encoding/tag-in-title.html:
  • fast/encoding/tag-name-digit.html:
  • fast/encoding/url-host-name-non-ascii.html:
  • fast/encoding/xml-charset-utf16.html:
  • fast/encoding/xml-utf-8-default.xml:
  • fast/encoding/yahoo-mail.html:
  • fast/encoding/yentest.html:
  • fast/encoding/yentest2.html:
  • fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html:
  • fast/forms/datalist/input-appearance-range-with-datalist.html:
  • fast/forms/datalist/update-range-with-datalist.html:
  • fast/forms/input-set-composition-scroll.html:
  • fast/harness/internals-object.html:
  • fast/harness/page-cache-crash-on-data-urls.html:
  • fast/harness/perftests/perf-runner-compute-statistics.html:
  • fast/harness/resources/modal-dialog.html:
  • fast/harness/show-modal-dialog.html:
  • fast/harness/user-preferred-language.html:
  • fast/multicol/hit-test-end-of-column.html:
  • fast/multicol/hit-test-gap-between-pages-flipped.html:
  • fast/multicol/hit-test-gap-between-pages.html:
  • fast/multicol/hit-test-gap-block-axis.html:
  • fast/notifications/notifications-event-listener-crash.html:
  • fast/parser/foster-parent.html:
  • fast/ruby/after-doesnt-crash.html:
  • fast/ruby/before-block-doesnt-crash.html:
  • fast/ruby/before-doesnt-crash.html:
  • fast/ruby/before-table-doesnt-crash.html:
  • fast/ruby/generated-before-counter-doesnt-crash.html:
  • fast/ruby/modify-positioned-ruby-text-crash.html:
  • fast/ruby/parse-rp.html:
  • fast/ruby/ruby-illegal-1.html:
  • fast/ruby/ruby-illegal-2.html:
  • fast/ruby/ruby-illegal-3.html:
  • fast/ruby/ruby-illegal-4.html:
  • fast/ruby/ruby-illegal-5.html:
  • fast/ruby/ruby-illegal-6.html:
  • fast/ruby/ruby-illegal-7.html:
  • fast/ruby/ruby-illegal-combined.html:
  • fast/ruby/ruby-overhang-crash.html:
  • fast/ruby/ruby-remove-no-base.html:
  • fast/ruby/ruby-remove.html:
  • fast/ruby/ruby-text-indent.html:
  • fast/ruby/rubyDOM-insert-rt-block-1.html:
  • fast/ruby/rubyDOM-insert-rt-block-2.html:
  • fast/ruby/rubyDOM-insert-rt-block-3.html:
  • fast/ruby/rubyDOM-remove-rt-block-1.html:
  • fast/ruby/rubyDOM-remove-rt-block-2.html:
  • fast/ruby/rubyDOM-remove-rt-block-3.html:
  • fast/runin/crash-when-reparent-sibling.html:
  • fast/runin/nonblock-runin.html:
  • fast/runin/progress-run-in-crash.html:
  • fast/runin/run-in-layer-not-removed-crash.html:
  • fast/runin/runin-continuations-crash.html:
  • fast/runin/runin-reparent-crash.html:
  • fast/runin/select-runin.html:
  • fullscreen/empty-anonymous-block-continuation-crash.html:
  • http/tests/misc/SVGFont-delayed-load.html:
  • http/tests/misc/resources/a success.html:
  • http/tests/misc/resources/content-iframe.html:
  • http/tests/misc/resources/iframe-policy-1.html:
  • http/tests/misc/resources/iframe-policy-2.html:
  • http/tests/misc/resources/isindex-with-no-form-base-href-submit.html:
  • http/tests/misc/resources/isindex-with-no-form-base-href.html:
  • http/tests/misc/resources/redirect-to-external-url-iframe.html:
  • http/tests/misc/resources/slow-preload-cancel-1.html:
  • http/tests/misc/resources/success-notify-done.html:
  • http/tests/misc/resources/webtiming-cross-origin-and-back1.html:
  • http/tests/misc/script-500.html:
  • http/tests/misc/script-no-store.html:
  • http/tests/misc/set-window-opener-to-null.html:
  • http/tests/misc/single-character-pi-stylesheet.xhtml:
  • http/tests/misc/slow-loading-image-in-pattern.html:
  • http/tests/misc/slow-preload-cancel.html:
  • http/tests/misc/submit-post-keygen.html:
  • http/tests/misc/svg-image-load-outlives-gc-without-crashing.html:
  • http/tests/misc/text-refresh.html:
  • http/tests/misc/timer-vs-loading.html:
  • http/tests/misc/uncacheable-script-repeated.html:
  • http/tests/misc/unloadable-script.html:
  • http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html:
  • http/tests/misc/webtiming-origins.html:
  • http/tests/misc/will-send-request-returns-null-on-redirect.html:
  • http/tests/misc/willCacheResponse-delegate-callback.html:
  • http/tests/misc/window-dot-stop.html:
  • http/tests/misc/window-open-then-write.html:
  • http/tests/misc/write-from-dom-script.html:
  • http/tests/misc/write-while-waiting.html:
  • http/tests/misc/xslt-bad-import.html:
  • http/tests/multipart/invalid-image-data-standalone.html:
  • http/tests/multipart/invalid-image-data.html:
  • http/tests/multipart/multipart-wait-before-boundary.html:
  • http/tests/multipart/stop-crash.html:
  • http/tests/navigation/:
  • http/tests/plugins/create-v8-script-objects.html:
  • http/tests/plugins/cross-frame-object-access.html:
  • http/tests/plugins/get-url.html:
  • http/tests/plugins/geturlnotify-from-npp-destroystream.html:
  • http/tests/plugins/interrupted-get-url.html:
  • http/tests/plugins/local-geturl-from-remote.html:
  • http/tests/plugins/npapi-response-headers.html:
  • http/tests/plugins/plugin-document-has-focus.html:
  • http/tests/plugins/post-url-file.html:
  • http/tests/plugins/resources/interrupted-get-url-success.html:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
  • http/tests/plugins/third-party-cookie-accept-policy.html:
  • http/tests/resources/notify-done.html:
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html:
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html:
  • http/tests/ssl/referer-301.html:
  • http/tests/ssl/referer-303.html:
  • http/tests/storage/callbacks-are-called-in-correct-context.html:
  • http/tests/storage/resources/callbacks-are-called-in-correct-context-second-frame.html:
  • http/tests/svg/change-id-with-pending-resources.html:
  • http/tests/svg/tref-adoptNode-crash.html:
  • http/tests/uri/assign-path-with-leading-slash.html:
  • http/tests/uri/assign-path-without-leading-slash.html:
  • http/tests/uri/escaped-entity.html:
  • http/tests/uri/resolve-encoding-relative.html:
  • http/tests/uri/resources/assign-path-landing.html:
  • http/tests/uri/utf8-path.html:
  • http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:
  • http/tests/webarchive/cross-origin-stylesheet-crash.html:
  • http/tests/webarchive/test-css-url-encoding-expected.webarchive:
  • http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
  • http/tests/webarchive/test-css-url-encoding-shift-jis.html:
  • http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
  • http/tests/webarchive/test-css-url-encoding-utf-8.html:
  • http/tests/webarchive/test-css-url-encoding.html:
  • http/tests/webarchive/test-preload-resources-expected.webarchive:
  • http/tests/webarchive/test-preload-resources.html:
  • http/tests/webfont/fallback-font-while-loading.html:
  • http/tests/websocket/resources/server-failed-to-start.html:
  • http/tests/xmlhttprequest/reentrant-cancel.html:
  • inspector/device-orientation-success.html:
  • platform/chromium/TestExpectations:
  • platform/chromium/permissionclient/image-permissions.html:
  • platform/chromium/permissionclient/plugin-permission.html:
  • platform/chromium/permissionclient/script-permissions.html:
  • platform/chromium/permissionclient/storage-permission.html:
  • platform/gtk/TestExpectations:
  • platform/mac/editing/input/edit-dictated-text-with-alternative.html:
  • platform/mac/editing/input/insert-dictated-text.html:
  • platform/mac/fast/AppleScript/001.html:
  • platform/mac/fast/AppleScript/array.html:
  • platform/mac/fast/AppleScript/date.html:
  • platform/mac/fast/objc/dom-html-select-activate.html:
  • platform/mac/fast/objc/longlongTest.html:
  • platform/qt/view/fixed-layout-size.html:
  • platform/win/inverted-colors/non-composited.html:
  • platform/win/svg/W3C-SVG-1.1/resources/run-webkit-tests-epilogue.html:
  • platform/win/svg/W3C-SVG-1.1/resources/run-webkit-tests-prologue.html:
  • webarchive/loading/resources/javascript-url-iframe-crash.webarchive:
Note: See TracTimeline for information about the timeline view.