Timeline
Aug 22, 2012:
- 11:54 PM Changeset in webkit [126397] by
-
- 10 edits in trunk/Source/WebCore
Unreviewed, rolling out r126348.
http://trac.webkit.org/changeset/126348
https://bugs.webkit.org/show_bug.cgi?id=94588
We should use v8::String::NewSymbol() for symbols. See
https://bugs.webkit.org/show_bug.cgi?id=94574#c10 for more
details
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
- bindings/v8/V8Binding.h:
(WebCore):
- 11:52 PM Changeset in webkit [126396] by
-
- 2 edits in branches/safari-536.26-branch/LayoutTests
Fix another test.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
- platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt:
- 11:29 PM Changeset in webkit [126395] by
-
- 5 edits in trunk/LayoutTests
[GTK] media/video-duration-known-after-eos.html and media/media-element-play-after-eos.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=83790
Reviewed by Eric Seidel.
Refactor the tests to wait the loadedmetadata event before
starting playback and attempting any access to the duration
attribute. This is an attempt to eliminate flakyness of the tests.
- media/media-element-play-after-eos-expected.txt:
- media/media-element-play-after-eos.html:
- media/video-duration-known-after-eos.html:
- platform/gtk/TestExpectations:
- 11:10 PM Changeset in webkit [126394] by
-
- 1 edit21 adds in trunk/LayoutTests
Unreviewed Chromium gardeing.
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt: Added.
- 10:59 PM Changeset in webkit [126393] by
-
- 14 edits in trunk/Source/WebCore
[V8] Remove V8Proxy from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=94773
Reviewed by Adam Barth.
To kill V8Proxy, we can remove V8Proxy uses from CodeGeneratorV8.pm.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 10:58 PM Changeset in webkit [126392] by
-
- 9 edits2 adds in trunk
Implement UndoManager's item() method
https://bugs.webkit.org/show_bug.cgi?id=94671
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-22
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch implements UndoManager's item() method and its V8 custom binding.
We need to use custom binding here because we need to return user objects
that are stored in a hidden property of DOMTransaction wrappers, not returning
the wrappers themselves.
Test: editing/undomanager/undomanager-item.html
- bindings/js/JSUndoManagerCustom.cpp:
(WebCore::JSUndoManager::item):
(WebCore):
- bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::data):
(WebCore):
(WebCore::DOMTransaction::setData):
(WebCore::DOMTransaction::getFunction):
- bindings/v8/DOMTransaction.h:
- bindings/v8/custom/V8UndoManagerCustom.cpp:
(WebCore::V8UndoManager::transactCallback):
(WebCore::V8UndoManager::itemCallback):
(WebCore):
- editing/UndoManager.cpp:
(WebCore::UndoManager::item):
(WebCore):
- editing/UndoManager.h:
(UndoManager):
- editing/UndoManager.idl:
LayoutTests:
- editing/undomanager/undomanager-item-expected.txt: Added.
- editing/undomanager/undomanager-item.html: Added.
- 10:54 PM Changeset in webkit [126391] by
-
- 11 edits2 adds in trunk
AX: Focusable elements without a role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=94302
Reviewed by Chris Fleizach.
Source/WebCore:
Changes the accessibility logic so that a generic element that's focusable is
not ignored for accessibility, and returns its inner text as its title. That way
if you Tab to the element, a reasonable accessibility notification is generated.
One exception is the body element, because focusing the body is equivalent to
blurring the current focused element and does not result in a "focus" accessibility
notification.
Also fixes logic that determined if an element was contentEditable by making
sure it catches the case with no attribute value (e.g. <div contentEditable>),
which also implies contentEditable=true according to the spec.
Test: accessibility/focusable-div.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::nodeHasContentEditableAttributeSet):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
Adds a new test to make sure that a generic focusable element (like a div with tabindex=0)
can get focus and return an appropriate title, just like a form control or element with
an ARIA role.
Modifies three existing tests that were previously assuming that a focusable node
with no role would be ignored for accessibility ("accessibilityIsIgnored").
- accessibility/editable-webarea-context-menu-point.html:
- accessibility/focusable-div-expected.txt: Added.
- accessibility/focusable-div.html: Added.
- accessibility/table-detection.html:
- platform/mac/accessibility/listbox-hit-test.html:
- 10:08 PM FeatureFlags edited by
- Add UNDO_MANAGER (diff)
- 9:49 PM Changeset in webkit [126390] by
-
- 22 edits in trunk/Source/WebCore
Unreviewed, rolling out r126383.
http://trac.webkit.org/changeset/126383
https://bugs.webkit.org/show_bug.cgi?id=82888
Chromium win build crash
- bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
- dom/Clipboard.h:
(Clipboard):
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
- 8:46 PM Changeset in webkit [126389] by
-
- 4 edits in trunk/Source/WebCore
[V8] Move m_isolatedWorlds and m_isolatedWorldSecurityOrigins from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94770
Reviewed by Adam Barth.
Now m_isolatedWorlds and m_isolatedWorldSecurityOrigins of V8Proxy
are used by ScriptController only. We can move them to ScriptController.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::collectIsolatedContexts):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 8:42 PM Changeset in webkit [126388] by
-
- 7 edits in trunk/Source/WebCore
[V8] Move evaluate() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94768
Reviewed by Adam Barth.
To kill V8Proxy, we can move evaluate() from V8Proxy to ScriptController.
- Renamed evaluate() to compileAndRunScript() to avoid name conflict
with existing ScriptController::evaluate().
- Removed toV8Proxy() from NPV8Object, as it is no longer used.
No tests. No change in behavior.
- bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
(WebCore):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 8:38 PM Changeset in webkit [126387] by
-
- 20 edits2 adds in trunk/Source/JavaScriptCore
Array accesses should remember what kind of array they are predicted to access
https://bugs.webkit.org/show_bug.cgi?id=94448
Reviewed by Gavin Barraclough.
Introduced the notion of DFG::Array::Mode, stored in node.arrayMode(), which allows nodes
to remember how they decided to access arrays. This permits the bytecode parser to "lock in"
the mode of access if it has profiling at its disposal, and it also allows the prediction
propagator to do a fixup of the array mode later in the optimization fixpoint.
This patch adds a healthy amount of new capability (specifically the ability of the parser
to lock in an array mode regardless of type predictions) and it also blows away a lot of
messy code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.cpp: Added.
(DFG):
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
- dfg/DFGArrayMode.h: Added.
(DFG):
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeForPut):
(JSC::DFG::modesCompatibleForStorageLoad):
(JSC::DFG::modeSupportsLength):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
(Node):
(JSC::DFG::Node::arrayMode):
(JSC::DFG::Node::setArrayMode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 8:09 PM Changeset in webkit [126386] by
-
- 3 edits in trunk/Tools
Unreviewed update of my email.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 7:51 PM Changeset in webkit [126385] by
-
- 7 edits in branches/safari-536.26-branch/LayoutTests
Fix some more tests.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
- http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt:
- http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt:
- http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt:
- http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt:
- http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt:
- http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt:
- 7:33 PM Changeset in webkit [126384] by
-
- 11 edits1 add in branches/safari-536.26-branch/LayoutTests
Fix some tests on safari-536.26-branch.
https://bugs.webkit.org/show_bug.cgi?id=94759
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Mark Rowe.
- animations/animation-shorthand-name-order.html:
- compositing/repaint/newly-composited-on-scroll.html:
- editing/execCommand/crash-extend-selection-forward.html:
- fast/events/drag-display-none-element.html:
- fast/forms/autocomplete-off-with-default-value-does-not-clear.html:
- fast/forms/hidden/change-type-to-hidden-after-updating-value.html:
- fast/table/auto-table-layout-colgroup-removal-crash.html:
- fast/text/title-crash-expected.txt: Added.
- http/tests/security/video-poster-cross-origin-crash.html:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- plugins/npruntime/overrides-all-properties.html:
- 6:56 PM Changeset in webkit [126383] by
-
- 22 edits in trunk/Source/WebCore
Consider replacing return type of Clipboard::types() from HashSet<String> to Vector<String>.
https://bugs.webkit.org/show_bug.cgi?id=82888
Patch by Vineet Chaudhary <Vineet> on 2012-08-22
Reviewed by Kentaro Hara.
As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than HashSet<String>
No new tests. Exixting test should pass with this change as no behavoural changes.
- bindings/js/JSClipboardCustom.cpp: Replace data type from HashSet<> to Vector<>.
(WebCore::JSClipboard::types):
- bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.
(WebCore::V8Clipboard::typesAccessorGetter):
- dom/Clipboard.h: Ditto.
(Clipboard):
- platform/blackberry/ClipboardBlackBerry.cpp: Ditto.
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h: Ditto.
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp: Ditto.
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h: Ditto.
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp: Ditto.
(WebCore::ClipboardChromium::types):
- platform/chromium/ClipboardChromium.h: Ditto.
(ClipboardChromium):
- platform/efl/ClipboardEfl.cpp: Ditto.
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h: Ditto.
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp: Ditto.
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h: Ditto.
(ClipboardGtk):
- platform/mac/ClipboardMac.h: Ditto.
(ClipboardMac):
- platform/mac/ClipboardMac.mm: Ditto.
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp: Ditto.
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h: Ditto.
(ClipboardQt):
- platform/win/ClipboardWin.cpp: Ditto.
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h: Ditto.
(ClipboardWin):
- platform/wx/ClipboardWx.cpp: Ditto.
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h: Ditto.
(ClipboardWx):
- 6:54 PM Changeset in webkit [126382] by
-
- 1 edit4 moves20 deletes in trunk/LayoutTests
Unreviewed Chromium gardening. Optimized baselines from yesterday
with dpranke's new algorithm in webkit-patch optimize-baselines
from r126374 and r126380.
- platform/chromium-linux/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/chromium-linux/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/chromium-linux/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/chromium-linux/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/chromium-mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/chromium-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/chromium-mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/chromium-mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/chromium-win-xp/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/chromium-win-xp/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/chromium-win-xp/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/chromium-win-xp/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/chromium-win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/chromium-win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/chromium-win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/chromium-win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/chromium/fast/canvas/canvas-scale-shadowBlur-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-scale-shadowBlur-expected.txt.
- platform/chromium/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-scale-strokePath-shadow-expected.txt.
- platform/chromium/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt.
- platform/chromium/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt.
- 6:49 PM Changeset in webkit [126381] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: tests for injection/extraction of idb keys
https://bugs.webkit.org/show_bug.cgi?id=94653
Patch by Alec Flett <alecflett@chromium.org> on 2012-08-22
Reviewed by Tony Chang.
Added unit tests for key injection/extraction using
SerializedScriptValue. These were moved from chromium, now
that all uses of the API are through WebKit.
- tests/IDBKeyPathTest.cpp:
(WebCore):
(WebCore::TEST):
- 6:34 PM Changeset in webkit [126380] by
-
- 2 edits in trunk/Tools
Fix typos in r126374
https://bugs.webkit.org/show_bug.cgi?id=94665
Unreviewed, build fix.
Fix two issues that snuck in, one that caused a crash if there
were no baselines to optimize and one that occurred as a result
of failing to rename a variable when I changed the recursion to
a loop in the previous patch.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._optimize_by_pushing_results_up):
- 6:33 PM Changeset in webkit [126379] by
-
- 6 edits in trunk/Source
ThreadRestrictionVerifier should be opt-in, not opt-out
https://bugs.webkit.org/show_bug.cgi?id=94761
Reviewed by Mark Hahnenberg.
Removed explicit calls to disable the verifier, since it's off by default now.
- parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(SourceProvider):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
../WTF:
WebKit's JavaScript engine supports use on multiple threads, so default-on
is not appropriate for most of our objects, and it causes lots of suprious
assertions.
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle): No need to turn off
explicitly, since it's off by default now.
- wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier): Turn off by default.
(WTF::ThreadRestrictionVerifier::setMutexMode):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::turnOffVerification): These assertions
about state transitions were inconsistent with each other, and impossible
to maintain with default off, so I removed them.
- 6:28 PM Changeset in webkit [126378] by
-
- 41 edits4 copies6 moves4 deletes in trunk/Source
[chromium] Change WebLayer from a concrete type to a pure virtual interface
https://bugs.webkit.org/show_bug.cgi?id=94174
Reviewed by Adrienne Walker.
Source/Platform:
This changes WebLayer from a value type to a pure virtual interface and changes Web*Layers from subtypes to
standalone types that have a WebLayer. This better isolates the implementation from the interface and, since
it's not possible to re-wrap an existing layer, makes cleanup explicit instead of requiring the caller to
invoke special cleanup methods before shutdown.
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
- chromium/public/WebIOSurfaceLayer.h:
(WebIOSurfaceLayer):
- chromium/public/WebImageLayer.h:
(WebImageLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):
- chromium/public/WebScrollableLayer.h: Removed.
- chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
- chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):
- chromium/public/WebVideoLayer.h:
(WebVideoLayer):
Source/WebCore:
This updates WebCore code for the WebLayer interface changes. Classes that have ownership of specific layer
types (such as DrawingBufferChromium, Canvas2DLayerBridge and ScrollingCoordinatorChromium) hold ownership
of a specific type and a pointer to the WebLayer to GraphicsLayerChromium to be included in the final layer
tree. GraphicsLayerChromium holds a WebContentLayer and (optionally) a WebImageLayer and WebLayer (for
m_transformLayer) and assembles the final layer tree.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
- platform/graphics/chromium/LayerChromium.h:
Source/WebKit/chromium:
This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl /
NonCompositedContentHost / LinkHighlight.
- WebKit.gypi:
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::contentLayer):
(WebKit::LinkHighlight::clipLayer):
(WebKit::LinkHighlight::releaseResources):
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition):
(WebKit::LinkHighlight::startHighlightAnimation):
(WebKit::LinkHighlight::updateGeometry):
- src/LinkHighlight.h:
(LinkHighlight):
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
- src/WebContentLayer.cpp: Removed.
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):
- src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.
(WebKit):
(WebExternalTextureLayerImpl):
- src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):
- src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):
- src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):
- src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
(WebCore):
(WebKit):
(WebImageLayerImpl):
- src/WebLayer.cpp: Removed.
- src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::id):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):
- src/WebLayerImpl.h:
(WebCore):
(WebLayerImpl):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebScrollableLayer.cpp: Removed.
- src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):
- src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
(WebCore):
(WebKit):
(WebScrollbarLayerImpl):
- src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):
- src/WebSolidColorLayerImpl.h:
(WebCore):
(WebKit):
(WebSolidColorLayerImpl):
- src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):
- src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 6:27 PM Changeset in webkit [126377] by
-
- 8 edits2 adds in trunk/Source/WebCore
[V8] Move runScript() from V8Proxy to ScriptRunner
https://bugs.webkit.org/show_bug.cgi?id=94706
Reviewed by Adam Barth.
To kill V8Proxy, we can move runScript() from V8Proxy to ScriptRunner.
- ScriptRunner::runScript() should be a static method.
It should receive ScriptExecutionContext on which the script is evaluated.
- After this patch is landed, I'll remove WorkerContextExecutionContext::runScript()
and ScriptDebugServer::runScript().
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptRunner.cpp: Added.
(WebCore):
(WebCore::ScriptRunner::runScript):
- bindings/v8/ScriptRunner.h: Added.
(WebCore):
(ScriptRunner):
- bindings/v8/V8Binding.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 6:23 PM Changeset in webkit [126376] by
-
- 2 edits in trunk/Source/WebCore
[V8] OwnHandle doesn't need to support weak handles
https://bugs.webkit.org/show_bug.cgi?id=94760
Reviewed by Kentaro Hara.
No code uses makeWeak(). We can drop support for it and simplify this
class.
- bindings/v8/OwnHandle.h:
(WebCore):
(OwnHandle):
(WebCore::OwnHandle::OwnHandle):
(WebCore::OwnHandle::~OwnHandle):
(WebCore::OwnHandle::get):
(WebCore::OwnHandle::set):
(WebCore::OwnHandle::clear):
- 6:12 PM Changeset in webkit [126375] by
-
- 7 edits in trunk/Source/WebCore
[V8] Remove V8Proxy from getXPathNSResolver()
https://bugs.webkit.org/show_bug.cgi?id=94715
Reviewed by Adam Barth.
- The V8Proxy* argument of getXPathNSResolver(..., V8Proxy* = 0) is not used. We can remove it.
- We can rename getXPathNSResolver() to toXPathNSResolver().
- We can move toXPathNSResolver() from V8DOMWrapper to V8Binding, since other toXXX() methods are written in V8Binding.
- Change the return value of toXPathNSResolver() from RefPtr to PassRefPtr.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
- bindings/v8/V8Binding.cpp:
(WebCore::toXPathNSResolver):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- 6:08 PM Changeset in webkit [126374] by
-
- 3 edits in trunk/Tools
Baseline optimizer should try to optimize per-port if global optimization fails
https://bugs.webkit.org/show_bug.cgi?id=94665
Reviewed by Adam Barth.
Add a fallback strategy for optimizing baselines if the default
one fails; this one simply attempts to shift baselines up in the
tree and consolidates them if a parent and child in the fallback
path have the same result. This strategy is somewhat flawed in
that we will always put something in a parent dir even if we
"shouldn't"; for example, if chromium-mac produces a different
result from chromium-win and chromium-linux, then the new
algorithm will move the mac result into platform/chromium,
leaving chromium-mac empty. This result is still correct, but
perhaps confusing.
I haven't done much testing of this algorithm yet, so it's not
clear how many cases where this does a better job than the
default algorithm and how many it'll do a worse job.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._optimize_by_most_specific_common_directory):
(BaselineOptimizer):
(BaselineOptimizer._optimize_by_pushing_results_up):
(BaselineOptimizer._find_in_fallbackpath):
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_platform_mac_different):
- 6:07 PM Changeset in webkit [126373] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r126325.
http://trac.webkit.org/changeset/126325
https://bugs.webkit.org/show_bug.cgi?id=94644
Caused subtle but reproducible failure to call onload handler
properly in an SVG layout test in Chromium Mac Debug builds,
indicating potentially larger problem
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::decrementRequestCount):
- 6:00 PM Changeset in webkit [126372] by
-
- 17 edits13 adds in trunk
Display a TextTrackCue when snap-to-lines flag is set
https://bugs.webkit.org/show_bug.cgi?id=79751
Reviewed by Tony Chang.
Source/WebCore:
This patch implements rendering functionality for a given text track,
following closer the exact WebVTT specification. There are two new classes
which have been added in order to succesfully cover rendering when of a text
track cue.
RenderTextTrackCue handles the specific rendering algorithm required,
by checking for overlaps with other boxes that are in the same
container (these can be any other boxes, not necessarily other cues,
the video controls, for example).
TextTrackCueBox extends HTMLDivElement and is an intermediate layer
between the renderer class and the actual cue object. Its purpose is
to instantiate the particular renderer and cover all the default CSS
styling that needs to be applied to the cue.
The layout is done in two steps:
- Step 1: Layout the TextTrackCue with default CSS properties set (this is
the TextTrackCueBox decorated with the respective CSS elements)
- Step 2: RenderTextTrackCue adjusts the box position depending on the
parameters of the TextTrackCue object and the overlaps that may occur with
previously positioned cues.
Tests: media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
- CMakeLists.txt: Updated to include RenderTextTrackCue.
- GNUmakefile.list.am: Updated to include RenderTextTrackCue.
- Target.pri: Updated to include RenderTextTrackCue.
- WebCore.gypi: Updated to include RenderTextTrackCue.
- WebCore.vcproj/WebCore.vcproj: Updated to include RenderTextTrackCue.
- WebCore.xcodeproj/project.pbxproj: Updated to include RenderTextTrackCue.
- css/mediaControls.css: Removed unreliable CSS.
(video::-webkit-media-text-track-display): Removed properties.
- html/shadow/MediaControlElements.cpp: Updated to not use the new class.
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Simplified
the function by moving the check if track is rendered in TextTrack and used
the TextTrackCueBox for cues.
- html/track/TextTrack.cpp: Added a new method.
(WebCore::TextTrack::isRendered): Method that returns whether the track should
be rendered or not.
(WebCore):
- html/track/TextTrack.h: Added the isRendered method.
(TextTrack):
- html/track/TextTrackCue.cpp: Added several helper methods and
the TextTrackCueBox.
(WebCore):
(WebCore::TextTrackCueBox::TextTrackCueBox): The TextTrackCueBox extends
the HTMLDivElement and represents a bridge class between RenderTextTrackCue
and TextTrackCue. This is required as the layout is done in two steps, as
explained on top of the ChangeLog entry.
(WebCore::TextTrackCueBox::getCue): Returns the associated TextTrackCue object.
(WebCore::TextTrackCueBox::applyCSSProperties): Applies a part of the default CSS
properties, as defined by section 3.5.1 of the WebVTT specification.
(WebCore::TextTrackCueBox::shadowPseudoId): Moved the shadow pseudo id.
(WebCore::TextTrackCueBox::createRenderer): Creates the particular renderer.
(WebCore::TextTrackCue::TextTrackCue): Corrected the internal writing mode map.
(WebCore::TextTrackCue::calculateComputedLinePosition): Updated the compute line
position algorithm. This requires, however, a method to consider only rendered
tracks (and therefore will be addressed completely in subsequent changeset).
(WebCore::TextTrackCue::calculateDisplayParameters): Updated and corrected the
computed display parameters to match the current specification.
(WebCore::TextTrackCue::getDisplayTree): Update to use the TextTrackCueBox class
and moved CSS application to the respective class.
(WebCore::TextTrackCue::getPositionCoordinates): Added comment to specify in which
situation this method is used and change visibility to private.
(WebCore::TextTrackCue::getCSSWritingMode): Returns the CSS writing mode corresponding
to the cue writing mode.
(WebCore::TextTrackCue::getCSSSize): Returns the cue width / height (depending on the
writing direction.
(WebCore::TextTrackCue::getCSSPosition): Returns the default display position, that is
used in the first layout step.
- html/track/TextTrackCue.h:
(WebCore):
(TextTrackCueBox):
(WebCore::TextTrackCueBox::create): Initialization method.
(TextTrackCue):
(WebCore::TextTrackCue::getWritingDirection): Helper method to return the internal
values used to represent the writing direction.
- rendering/RenderTextTrackCue.cpp: Added.
(WebCore):
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
(WebCore::RenderTextTrackCue::layout): The rendering steps, as mentioned in
the WebVTT rendering rules. Currently, this treats only the snap-to-lines set
case. It is implemented following closely the spec, and might be subject to
change as discussions on various bugs evolve.
(WebCore::RenderTextTrackCue::initializeLayoutParameters): Steps 1 - 7.
(WebCore::RenderTextTrackCue::placeBoxInDefaultPosition): Steps 8 - 10.
(WebCore::RenderTextTrackCue::isOutside): Inline method to check if the cue is outside.
(WebCore::RenderTextTrackCue::isOverlapping): Inline method to check if the cue overlaps other boxes.
(WebCore::RenderTextTrackCue::shouldSwitchDirection): Step 12.
(WebCore::RenderTextTrackCue::moveBoxesByStep): Step 13.
(WebCore::RenderTextTrackCue::switchDirection): Steps 15 - 18.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Cue repositioning
for text track cue when the snap to lines flag is set.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Cue repositioning
for text track cue when the snap to lines flag is not set. Not implemented yet.
- rendering/RenderTextTrackCue.h: Added.
(WebCore):
(RenderTextTrackCue): Rendering class, handling the display of cues.
LayoutTests:
Test cases covering snap-to-lines horizontal and vertical positioning of cues.
- media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Added.
- media/track/track-cue-rendering-horizontal.html: Added.
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Updated.
- media/track/track-cue-rendering-vertical.html: Added.
- media/video-test.js: Updated to support pixel test dumps.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium/TestExpectations: Marking these temporarily as IMAGE fail, as they will
anyway require new baselines.
- platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/mac/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Added.
- 5:59 PM Changeset in webkit [126371] by
-
- 7 edits in trunk/Tools
add debug info, another test to webkit-patch optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=94762
Reviewed by Adam Barth.
This patch adds more debug logging for optimize-baselines so
that you can tell the before and after states and figure out
what the command is actually deciding to do.
Also, this command adds a (disabled) test for the problem in bug
- It's disabled because we don't have the fix yet (that
will be posted in a patch to that bug).
There should be no functional changes in this patch apart from
the additional logging.
Note that adding the debug logging exposed a bug in
filesystem_mock.relpath() (that would return None if the path
wasn't a subpath of the start); the real relpath computes a
relpath with parent dirs. Fixing this revealed a bad check in
the style checker's change_directory() call which was checking
for None.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer):
(BaselineOptimizer._optimize_by_most_specific_common_directory):
(BaselineOptimizer._move_baselines):
(BaselineOptimizer.optimize):
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.disabled_test_platform_mac_different):
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem):
(MockFileSystem.init):
(MockFileSystem.relpath):
- Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_sep):
- Scripts/webkitpy/style/main.py:
(change_directory):
- 5:38 PM Changeset in webkit [126370] by
-
- 8 edits in trunk/Source/WebCore
[V8] Move matchesCurrentContext() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94596
Reviewed by Adam Barth.
To kill V8Proxy:
- We can move matchesCurrentContext() from V8Proxy to ScriptController.
- We can remove V8Proxy::isolatedWorldContext() since it is not used by anybody.
- We can remove V8Proxy::finishedWithEvent() since it is empty.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::finishedWithEvent):
(WebCore::ScriptController::matchesCurrentContext):
(WebCore):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 5:36 PM Changeset in webkit [126369] by
-
- 13 edits2 adds in trunk
Source/WebCore: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819
Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.
Added a new role, Toggle Button, based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
Test: platform/gtk/accessibility/aria-toggle-button-role.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole): using buttonRoleType
to classify a button-related role.
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute): using buttonRoleType
to classify a button-related role.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaPressedIsPresent): checks if aria-pressed
attribute is present.
(WebCore::AccessibilityObject::buttonRoleType): returns a specific button-related
role if the object is a button-related role.
- accessibility/AccessibilityObject.h:
(AccessibilityObject): added new role ToggleButtonRole.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole): using buttonRoleType
to classify a button-related role.
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): added a mapping between ToggleButtonRole and
ATK_ROLE_TOGGLE_BUTTON.
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap): added a mapping between
ToggleButtonRole and NSAccessibilityButtonRole
Source/WebKit/chromium: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819
Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.
Added a new role, Toggle Button, based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
- public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that
matchs with WebCore ToggleButtonRole
- src/AssertMatchingEnums.cpp: added the assert matching rule for
WebAccessibilityRoleToggleButton and ToggleButtonRole
Tools: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819
Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.
Added a new role, Toggle Button, based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
- DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
LayoutTests: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819
Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
Reviewed by Chris Fleizach.
Added a test to verify that when aria-pressed is present, buttons
will have the appropiate role.
- platform/gtk/accessibility/aria-toggle-button-role-expected.txt: Added.
- platform/gtk/accessibility/aria-toggle-button-role.html: Added.
- 5:13 PM Changeset in webkit [126368] by
-
- 2 edits in trunk/Tools
2012-08-23 Victor Carbune <victor@rosedu.org>
Add myself to the committer list
https://bugs.webkit.org/show_bug.cgi?id=94659
Reviewed by James Robinson.
Added my email and IRC handle.
- Scripts/webkitpy/common/config/committers.py:
- 5:08 PM Changeset in webkit [126367] by
-
- 2 edits20 adds in trunk/LayoutTests
[Chromium] Need baselines for new paged-x and paged-y tests in fast/overflow after r126343
https://bugs.webkit.org/show_bug.cgi?id=94748
Unreviewed Chromium gardening. Added baselines via garden-o-matic.
- platform/chromium-linux/fast/overflow/paged-x-div-expected.png: Added.
- platform/chromium-linux/fast/overflow/paged-x-on-root-expected.png: Added.
- platform/chromium-linux/fast/overflow/paged-y-div-expected.png: Added.
- platform/chromium-linux/fast/overflow/paged-y-on-root-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/paged-x-div-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/paged-x-on-root-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/paged-y-div-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/paged-y-on-root-expected.png: Added.
- platform/chromium-mac/fast/overflow/paged-x-div-expected.png: Added.
- platform/chromium-mac/fast/overflow/paged-x-on-root-expected.png: Added.
- platform/chromium-mac/fast/overflow/paged-y-div-expected.png: Added.
- platform/chromium-mac/fast/overflow/paged-y-on-root-expected.png: Added.
- platform/chromium-win/fast/overflow/paged-x-div-expected.png: Added.
- platform/chromium-win/fast/overflow/paged-x-div-expected.txt: Added.
- platform/chromium-win/fast/overflow/paged-x-on-root-expected.png: Added.
- platform/chromium-win/fast/overflow/paged-x-on-root-expected.txt: Added.
- platform/chromium-win/fast/overflow/paged-y-div-expected.png: Added.
- platform/chromium-win/fast/overflow/paged-y-div-expected.txt: Added.
- platform/chromium-win/fast/overflow/paged-y-on-root-expected.png: Added.
- platform/chromium-win/fast/overflow/paged-y-on-root-expected.txt: Added.
- platform/chromium/TestExpectations:
Removed expected failures.
- 4:23 PM Changeset in webkit [126366] by
-
- 5 edits3 adds in trunk
IndexedDB: revert int version when version change transaction aborts
https://bugs.webkit.org/show_bug.cgi?id=94662
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/intversion-revert-on-abort.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::resetIntVersion):
One-liner modeled after resetVersion.
(WebCore):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
LayoutTests:
This is tested in some other layout tests but it should have its own,
so add intversion-revert-on-abort.html.
- storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
FAIL event.target.result.version should be 0 will be resolved at least
when we figure out if we can make the default version an integer
during the transition period.
- storage/indexeddb/intversion-revert-on-abort-expected.txt: Added.
- storage/indexeddb/intversion-revert-on-abort.html: Added.
- storage/indexeddb/resources/intversion-revert-on-abort.js: Added.
(test):
(deleteSuccess):
(firstUpgradeNeededCallback):
(openSuccess):
(secondUpgradeNeededCallback):
(errorAfterAbortCallback):
(finalSuccessCallback):
- 4:08 PM WebKit Team edited by
- (diff)
- 3:58 PM Changeset in webkit [126365] by
-
- 20 edits7 adds in trunk
Allow blocking of Web SQL databases in third-party web workers
https://bugs.webkit.org/show_bug.cgi?id=94170
Reviewed by Adam Barth.
Source/WebCore:
Web workers did not previously know anything about the document that
spawned them. This is undefined for shared workers, but for dedicated
workers, we now pipe the information through.
Tests: http/tests/security/cross-origin-worker-websql-allowed.html
http/tests/security/cross-origin-worker-websql.html
- Modules/webdatabase/WorkerContextWebDatabase.cpp: Pass information about the top origin to canAccessDatabase
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):
- WebCore.exp.in: Make SecurityOrigin::isolatedCopy const
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::isolatedCopy):
(WebCore::SecurityOrigin::canAccessStorage):
- page/SecurityOrigin.h:
- workers/DedicatedWorkerContext.cpp: Pass topOrigin
(WebCore::DedicatedWorkerContext::create):
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):
- workers/DedicatedWorkerContext.h:
(DedicatedWorkerContext):
- workers/DedicatedWorkerThread.cpp: Pass topOrigin
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerContext):
- workers/DedicatedWorkerThread.h:
(DedicatedWorkerThread):
- workers/SharedWorkerContext.cpp: Pass topOrigin
(WebCore::SharedWorkerContext::SharedWorkerContext):
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerContext):
- workers/SharedWorkerThread.h:
(SharedWorkerThread): Pass topOrigin
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
- workers/WorkerContext.h:
(WebCore::WorkerContext::topOrigin):
(WorkerContext):
- workers/WorkerMessagingProxy.cpp: Pass topOrigin
(WebCore::WorkerMessagingProxy::startWorkerContext):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h:
(WorkerThread):
Source/WebKit/chromium:
Web workers did not previously know anything about the document that
spawned them. This is undefined for shared workers, but for dedicated
workers, we now pipe the information through.
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext): Pass top document's origin
LayoutTests:
Created tests for accessing openDatabase from a third party and first party dedicated workers when third-party blocking is on and off.
- http/tests/security/cross-origin-worker-websql-allowed-expected.txt: Added.
- http/tests/security/cross-origin-worker-websql-allowed.html: Added.
- http/tests/security/cross-origin-worker-websql-expected.txt: Added.
- http/tests/security/cross-origin-worker-websql.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-worker-websql.html: Added.
- http/tests/security/resources/document-for-cross-origin-worker-websql.html: Added.
- http/tests/security/resources/worker-for-websql.js: Added.
(self.onmessage):
- 3:55 PM Changeset in webkit [126364] by
-
- 3 edits in trunk/LayoutTests
[Chromium/GTK/EFL] Flaky media/track/track-mode test.
https://bugs.webkit.org/show_bug.cgi?id=83878
Reviewed by Eric Seidel.
This test should only care that cuechange events are fired when the TextTrack
mode is set to HIDDEN or SHOWING. Because the events are asynchronous, we
shouldn't test the order of them, just that they occur.
- media/track/track-mode-expected.txt:
- media/track/track-mode.html:
- 3:52 PM Changeset in webkit [126363] by
-
- 14 edits in trunk/Source
[V8] Move context() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94593
Reviewed by Adam Barth.
Source/WebCore:
- This patch removes V8Proxy::context(Frame*).
- This patch moves V8Proxy::context() to ScriptController::context().
- This patch renames ScriptController::context() to ScriptController::currentWorldContext(),
for naming consistency with ScriptController::maintWorldContext().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::context):
(WebCore):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setNamedHiddenWindowReference):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
(WebCore::V8DOMWindow::eventAccessorGetter):
(WebCore::V8DOMWindow::eventAccessorSetter):
(WebCore::DialogHandler::dialogCreated):
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
Source/WebKit/chromium:
To kill V8Proxy, we can move context() from V8Proxy to ScriptController.
No tests. No change in behavior.
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::windowObjectCleared):
- src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
- 3:44 PM Changeset in webkit [126362] by
-
- 16 edits in trunk/Source/WebCore
[V8] Remove V8Proxy from V8DOMWrapper::instantiateV8Object()
https://bugs.webkit.org/show_bug.cgi?id=94713
Reviewed by Adam Barth.
To kill V8Proxy, V8DOMWrapper::instantiateV8Object() should receive Frame*
instead of V8Proxy*.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- 3:28 PM Changeset in webkit [126361] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: IDBRequest can be destructed during abort
https://bugs.webkit.org/show_bug.cgi?id=94618
Reviewed by Tony Chang.
If there are no script references, an IDBRequest could be kept alive
only by enqueued events. On document destruction, the parent transaction
is aborted, which aborts the request. During the abort, the enqueued events
are deleted, releasing the last reference to the IDBRequest which then
destructs in mid-method call and an "unfinished" state, hitting an assert.
This patch keeps the IDBRequest alive through the completion of the abort()
method, which will enqueue another event. In the document destruction case,
this will end up with the IDBRequest having stop() called on it which will
send the IDBRequest into EarlyDeath state, satisfying the destructor assert.
Addresses existing layout tests that behave flakily in Chromium port.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::abort):
- 3:27 PM Changeset in webkit [126360] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move precompileScript() from V8Proxy to ScriptSourceCode
https://bugs.webkit.org/show_bug.cgi?id=94701
Reviewed by Adam Barth.
To kill V8Proxy, we can move precompileScript() from V8Proxy
to ScriptSourceCode.
No tests. No change in behavior.
- bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::precompileScript):
(WebCore):
- bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 3:25 PM Changeset in webkit [126359] by
-
- 69 edits in trunk/Source
Reduce Font.h includes across project -- improves RenderObject.h compile time
https://bugs.webkit.org/show_bug.cgi?id=93629
Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-22
Reviewed by Eric Seidel.
Source/WebCore:
RenderStyle.h no longer depends on Font.h. The files that transitively
need to be updated with proper includes are fixed.
No new tests. Functionality should remain the same.
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
- bindings/objc/DOM.mm:
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSPrimitiveValue.cpp:
- css/StyleResolver.h:
- dom/CharacterData.cpp:
- dom/ElementRareData.h:
- dom/NodeRenderingContext.cpp:
- dom/Text.cpp:
- editing/TextIterator.cpp:
- editing/mac/EditorMac.mm:
- html/HTMLTitleElement.cpp:
- html/shadow/TextControlInnerElements.cpp:
- inspector/InspectorOverlay.cpp:
- page/ContextMenuController.cpp:
- page/PrintContext.cpp:
- platform/efl/RenderThemeEfl.cpp:
- platform/graphics/FontMetrics.h:
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk2.cpp:
- platform/mac/HTMLConverter.mm:
- rendering/EllipsisBox.cpp:
- rendering/FlowThreadController.cpp:
- rendering/InlineBox.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/InlineFlowBox.h:
(WebCore):
- rendering/RenderButton.cpp:
- rendering/RenderCombineText.cpp:
- rendering/RenderCombineText.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
- rendering/RenderEmbeddedObject.h:
(WebCore):
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderFullScreen.h:
- rendering/RenderImage.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderMultiColumnBlock.cpp:
- rendering/RenderRegion.h:
- rendering/RenderRuby.cpp:
- rendering/RenderRubyRun.cpp:
- rendering/RenderScrollbar.cpp:
- rendering/RenderTable.cpp:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/RenderTextControl.cpp:
- rendering/RenderTextControlMultiLine.cpp:
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderView.cpp:
- rendering/TextAutosizer.cpp:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/style/KeyframeList.h:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
(WebCore):
- rendering/style/StyleInheritedData.cpp:
- rendering/svg/RenderSVGBlock.cpp:
- rendering/svg/RenderSVGInlineText.h:
- svg/SVGLengthContext.cpp:
- svg/SVGTRefElement.cpp:
Source/WebKit/chromium:
Adds includes due to change in RenderStyle.h
- src/WebFrameImpl.cpp:
- src/mac/WebSubstringUtil.mm:
Source/WebKit/win:
Adds includes due to change in RenderStyle.h
- DOMCoreClasses.cpp:
Source/WebKit2:
Adds includes due to change in RenderStyle.h
- WebProcess/WebPage/mac/WebPageMac.mm:
- 3:23 PM Changeset in webkit [126358] by
-
- 17 edits in trunk/LayoutTests
Test cases under fast/filesystem/workers are flaky when using JSC
https://bugs.webkit.org/show_bug.cgi?id=94747
Patch by Leo Yang <leoyang@rim.com> on 2012-08-22
Reviewed by Yong Li.
These test cases sometimes can't complete because the worker object
created by startWorker() has been gc'ed before the worker thread complete.
We should reference the object to avoid it being gc'ed.
- fast/filesystem/workers/async-operations.html:
- fast/filesystem/workers/file-entry-to-uri-sync.html:
- fast/filesystem/workers/file-from-file-entry-sync.html:
- fast/filesystem/workers/file-from-file-entry.html:
- fast/filesystem/workers/file-writer-empty-blob.html:
- fast/filesystem/workers/file-writer-events.html:
- fast/filesystem/workers/file-writer-gc-blob.html:
- fast/filesystem/workers/file-writer-sync-truncate-extend.html:
- fast/filesystem/workers/file-writer-sync-write-overlapped.html:
- fast/filesystem/workers/file-writer-truncate-extend.html:
- fast/filesystem/workers/file-writer-write-overlapped.html:
- fast/filesystem/workers/simple-persistent-sync.html:
- fast/filesystem/workers/simple-persistent.html:
- fast/filesystem/workers/simple-temporary-sync.html:
- fast/filesystem/workers/simple-temporary.html:
- fast/filesystem/workers/sync-operations.html:
- 3:01 PM Changeset in webkit [126357] by
-
- 2 edits in trunk/Source/WebCore
win64 compile error fix for BinaryPropertyList.cpp
https://bugs.webkit.org/show_bug.cgi?id=94122
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-22
Reviewed by Eric Seidel.
Fixed compile errors for MSVC x64 without changing performance
- platform/cf/BinaryPropertyList.cpp:
(WebCore::BinaryPropertyListSerializer::appendStringObject):
- 2:55 PM Changeset in webkit [126356] by
-
- 2 edits in trunk/Tools
Don't unconditionally define NOMINMAX on Windows
https://bugs.webkit.org/show_bug.cgi?id=94742
Patch by Scott Graham <scottmg@chromium.org> on 2012-08-22
Reviewed by Adrienne Walker.
Avoids a warning when building on Windows when NOMINMAX is defined
elsewhere or on the command line.
- TestWebKitAPI/config.h:
- 2:55 PM Changeset in webkit [126355] by
-
- 6 edits in trunk/Source/WebCore
HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLElementStack
https://bugs.webkit.org/show_bug.cgi?id=93857
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-22
Reviewed by Eric Seidel.
HTMLTreeBuilder::furthestBlockForFormattingElement should belong to
HTMLElementStack because it traverses the element stack and finds the
furthest block for the given formatting element.
Currently, it belongs to HTMLTreeBuilder just because
isSpecialNode(const HTMLStackItem*) function used by
furthestBlockForFormattingElement is internal to HTMLTreeBuilder.
Moved isSpecialNode to HTMLStackItem and changed
furthestBlockForFormattingElement to be a method of HTMLElementStack.
No behavior change. Just a refactoring.
- html/parser/HTMLElementStack.cpp:
(WebCore):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::furthestBlockForFormattingElement):
- html/parser/HTMLElementStack.h:
(HTMLElementStack):
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::isInHTMLNamespace):
(HTMLStackItem):
(WebCore::HTMLStackItem::isNumberedHeaderElement):
(WebCore::HTMLStackItem::isTableBodyContextElement):
(WebCore::HTMLStackItem::isSpecialNode):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
- html/parser/HTMLTreeBuilder.h:
- 2:49 PM Changeset in webkit [126354] by
-
- 11 edits3 adds in trunk/Source/JavaScriptCore
Separate MarkStackThreadSharedData from MarkStack
https://bugs.webkit.org/show_bug.cgi?id=94294
Reviewed by Filip Pizlo.
MarkStackThreadSharedData is soon going to have data to allow for a parallel copying
mode too, so to separate our concerns we should split it out into its own set of files
and rename it to GCThreadSharedData. For now this is purely a cosmetic refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/GCThreadSharedData.cpp: Added.
(JSC):
(JSC::GCThreadSharedData::resetChildren):
(JSC::GCThreadSharedData::childVisitCount):
(JSC::GCThreadSharedData::markingThreadMain):
(JSC::GCThreadSharedData::markingThreadStartFunc):
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
- heap/GCThreadSharedData.h: Added.
(JSC):
(GCThreadSharedData):
- heap/Heap.h:
(Heap):
- heap/ListableHandler.h:
(ListableHandler):
- heap/MarkStack.cpp:
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
- heap/MarkStack.h:
(JSC):
(MarkStack):
(JSC::MarkStack::sharedData):
- heap/MarkStackInlineMethods.h: Added.
(JSC):
(JSC::MarkStack::append):
(JSC::MarkStack::appendUnbarrieredPointer):
(JSC::MarkStack::appendUnbarrieredValue):
(JSC::MarkStack::internalAppend):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
- heap/SlotVisitor.h:
(JSC):
(SlotVisitor):
(JSC::SlotVisitor::SlotVisitor):
- 2:42 PM Changeset in webkit [126353] by
-
- 2 edits in trunk/Tools
REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
https://bugs.webkit.org/show_bug.cgi?id=94704
Reviewed by Dirk Pranke.
Use tolerance=0 when acquiring diff image of reftest output.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_output_with_reference):
- 2:29 PM Changeset in webkit [126352] by
-
- 3 edits in trunk/Source/WebKit/chromium
Speed up compilation of tests involving WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=94639
Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-22
Reviewed by James Robinson.
EXPECT_TRANSFORMATION_MATRIX_EQ was changed to become mainly a function.
As a macro that expanded into 16 other macros, it caused an unneeded
slow down of close to 45s in the compile time of CCLayerTreeHostCommonTest
Bugs have been filed to clang and gcc noting the errant behavior:
http://llvm.org/bugs/show_bug.cgi?id=13651 and http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54337
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeTestCommon.h:
(WebKitTests):
(WebKitTests::ExpectTransformationMatrixEq):
- tests/WebTransformOperationsTest.cpp:
(TEST):
(checkProgress):
- tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):
- 2:26 PM Changeset in webkit [126351] by
-
- 8 edits in trunk/Source
[chromium] Add software bitmap resources to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93677
Patch by Alexandre Elias <aelias@google.com> on 2012-08-22
Reviewed by Adrienne Walker.
Second commit after revert.
This adds the ability to CCResourceProvider to use software bitmaps.
They are allocated as plain-old-memory, and exposed as Skia objects.
We want the ResourceProvider to be able to handle different resource
types at the same time. In practice, a default resource type is
desired for most uses within a single compositor instance, which is
specified by the default resource type. Default resource types are
expected to be mostly 1-to-1 with CCRenderer types.
New tests added by parametrizing existing CCResourceProvider tests.
Source/WebCore:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
- platform/graphics/chromium/LayerRendererChromium.h:
(DrawingFrame):
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore):
(WebCore::CCResourceProvider::createGLTexture):
(WebCore::CCResourceProvider::createBitmap):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::ScopedReadLockGL::ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::~ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL):
(WebCore::CCResourceProvider::populateSkBitmapWithResource):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::~ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::CCResourceProvider):
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(WebCore::CCResourceProvider::setCreationPolicy):
(WebCore::CCResourceProvider::creationPolicy):
(CCResourceProvider):
(ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::textureId):
(ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::textureId):
(ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::skBitmap):
(ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::skCanvas):
(Resource):
Source/WebKit/chromium:
- tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::getResourcePixels):
- 2:24 PM Changeset in webkit [126350] by
-
- 9 edits in trunk
Update the TextTrackCue Constructor
https://bugs.webkit.org/show_bug.cgi?id=88583
Reviewed by Eric Carlson.
The TextTrackCue constructor has been changed to:
[Constructor(double startTime, double endTime, DOMString text)]
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#texttrackcue
Source/WebCore:
No new tests. Update to media/track/track-add-remove-cue.html
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::create):
(TextTrackCue):
- html/track/TextTrackCue.idl:
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::createNewCue):
LayoutTests:
- media/track/track-add-remove-cue-expected.txt:
- media/track/track-add-remove-cue.html:
- 2:19 PM Changeset in webkit [126349] by
-
- 8 edits2 adds in trunk
Changing class attribute is not reflected in the classList property
https://bugs.webkit.org/show_bug.cgi?id=93665
Reviewed by Ojan Vafai.
Before this change classAttributeChanged was only called for StyledElement. With this refactoring
it gets called for all Elements when the class attribute changes.
Source/WebCore:
Test: fast/dom/Element/class-list-update.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules): To match the old behavior we only include StyledElements.
- dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::nodeMatches): Ditto.
- dom/Element.cpp:
(WebCore::Element::attributeChanged): Moved the call to parseAttribute here, from StyledElement::attributeChanged.
(WebCore::Element::parseAttribute): Moved from StyledElement.
(WebCore):
(WebCore::Element::classAttributeChanged): Ditto.
- dom/Element.h:
(Element):
(WebCore::Element::classNames): Ditto.
(WebCore):
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged): Let Element::attributeChanged call parseAttribtue instead.
(WebCore::StyledElement::parseAttribute): Move the class attribute handling to Element::parseAttribute.
- dom/StyledElement.h:
(StyledElement):
LayoutTests:
- fast/dom/Element/class-list-update-expected.txt: Added.
- fast/dom/Element/class-list-update.html: Added.
- 2:14 PM Changeset in webkit [126348] by
-
- 10 edits in trunk/Source/WebCore
[V8] Replace v8::String::NewSymbol() in CodeGeneratorV8.pm with v8String()
https://bugs.webkit.org/show_bug.cgi?id=94588
Reviewed by Eric Seidel.
v8String() is faster than String::NewSymbol().
This patch implements v8String(char*, Isolate*) and
replaces String::NewSymbol(char*) in CodeGeneratorV8.pm
with v8String(char*, Isolate*).
Performance result:
272 nano sec
static v8::Handle<v8::Value> attr3AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
v8::Handle<v8::Value> v1 = v8String(String("foo"));
v8::Handle<v8::Value> v2 = v8String(String("bar"));
if (!v1.IsEmpty() && !v2.IsEmpty())
return v8Undefined();
return v8::Null(); Never reach.
}
377 nano sec
static v8::Handle<v8::Value> attr4AttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
v8::Handle<v8::Value> v1 = v8::String::NewSymbol("foo");
v8::Handle<v8::Value> v2 = v8::String::NewSymbol("bar");
if (!v1.IsEmpty() && !v2.IsEmpty())
return v8Undefined();
return v8::Null(); Never reach.
}
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::v8String):
- html/HTMLDivElement.idl:
- 2:05 PM Changeset in webkit [126347] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Need baselines for new paged-x and paged-y tests in fast/overflow after r126343
https://bugs.webkit.org/show_bug.cgi?id=94748
Unreviewed gardening; suppressing new failures until baselines are generated.
- platform/chromium/TestExpectations:
- 1:57 PM Changeset in webkit [126346] by
-
- 2 edits in trunk/Source/WebCore
Setting WebKitEnableHTTPPipelining doesn't work if default is true
https://bugs.webkit.org/show_bug.cgi?id=94537
Reviewed by David Kilzer.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Read in the HTTP pipelining pref and
allow it to override the default pipelining behavior if it was actually set.
- 1:47 PM Changeset in webkit [126345] by
-
- 11 edits1 move108 adds1 delete in trunk
[chromium] Add touch link highlight animation layers.
https://bugs.webkit.org/show_bug.cgi?id=84487
Reviewed by James Robinson.
Adds support for creating composited touch link highlights in renderer thread. Clipping not yet
implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported.
Transform support currently limited to translation.
Source/WebCore:
Unit tests for LinkHighlight revised.
Tests: platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed): Adds notification to LinkHighlight when layer goes away.
(WebCore::GraphicsLayerChromium::updateNames): Now sets debug name for LinkHighlight layer.
(WebCore::GraphicsLayerChromium::setSize): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplay): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setLinkHighlight): Registers LinkHighlightClient* with GraphicsLayerChromium.
(WebCore::GraphicsLayerChromium::updateChildList): Now adds LinkHighlight WebLayer if highlight active.
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable): Invalidates LinkHighlight if present.
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(LinkHighlightClient): Abstract interface seen by GraphicsLayerChromium.
(WebCore::LinkHighlightClient::~LinkHighlightClient):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::linkHighlight):
- platform/graphics/chromium/LinkHighlight.cpp: Removed.
Source/WebKit/chromium:
Unit tests for LinkHighlight revised.
- WebKit.gyp:
- src/LinkHighlight.cpp: Added.
(WebKit):
(WebKit::LinkHighlight::create):
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::~LinkHighlight):
(WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight.
(WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight.
(WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers.
(WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates.
(WebKit::LinkHighlight::paintContents): If highlight active, paints highlight.
(WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation.
(WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium.
(WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate.
(WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes.
(WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position.
Computations proceed only if preceded by call to invalidate().
(WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid.
(WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout().
(WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium.
- src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.
(WebCore):
(WebKit):
(LinkHighlight):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location.
(WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location.
(WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry().
- src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
(WebKit::WebViewImpl::linkHighlight):
- tests/LinkHighlightTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/data/test_touch_link_highlight.html: Added.
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:24 PM Changeset in webkit [126344] by
-
- 8 edits in trunk/Source/WebKit/chromium
WebWidget should be able to paint into a zoomed canvas without aliasing
https://bugs.webkit.org/show_bug.cgi?id=92043
Reviewed by James Robinson.
If accelerated compositing is enabled, WebWidget::paint reads back from
the compositor rather than re-painting the widget. That approach works
well if the canvas we're rendering into is at a similar resolution to
the pixels in the compositor, but if the canvas has been scaled (e.g.,
to help the user disambiguate links), then reading back from the
compositor will cause aliasing artifacts.
This patch adds an option to paint to let the embedder request a
software re-rendering of the widget to avoid these aliasing artifacts.
- public/WebWidget.h:
(WebKit::WebWidget::paint):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::paint):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::canvasBackgroundForTransparencey):
(WebKit):
(WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
(WebViewImpl):
- 1:20 PM Changeset in webkit [126343] by
-
- 35 edits13 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=94401
Add support for making a web site become paginated using overflow:
paged-x | paged-y
-and corresponding-
<rdar://problem/11831783>
Reviewed by Dave Hyatt.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
This patch adds two new possible values for overflow-y. They are -
webkit-paged-x and -webkit-paged-y. When you set these as overflow-y
values on the html or body element, they make the RenderView
paginated, much like the API on Page.
-webkit-paged-x and -webkit-paged-y are only valid values for
overflow-y, NOT overflow-x. overflow-x defaults to a value of auto
(for now) unless it has been set to something else.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
Two new CSS value keywords.
- css/CSSValueKeywords.in:
EOverflow has two new values for pagination.
- rendering/style/RenderStyleConstants.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflow):
A bunch of existing code from StyleResolver::styleForDocument() is
moved into a helper function so that it can be called from two
places.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Even though this pagination is very similar to Page::pagination(), it
is different in one critical way. Page::pagination() will apply to
all FrameViews, even those in the page cache. For this reason,
FrameView needs to keep its own Pagination value that just applies to
this FrameView.
- page/FrameView.cpp:
- page/FrameView.h:
(WebCore):
(FrameView):
Map RenderStyle values to a Pagination::Mode.
(WebCore::paginationModeForRenderStyle):
(WebCore):
Account for paged-x and paged-y here.
(WebCore::FrameView::applyOverflowToViewport):
As is explained in the header, FrameView::pagination() will return
m_pagination if it has been set. Otherwise, it will return
Page::pagination() since currently there are no callers that need to
distinguish between the two.
(WebCore::FrameView::pagination):
(WebCore::FrameView::setPagination):
Generally this means that everywhere in WebCore should ask FrameView
for the pagination(), not Page. These call sites all look to
FrameView now.
(WebCore::FrameView::paintContents):
- rendering/RenderView.cpp:
(WebCore::RenderView::requiresColumns):
(WebCore::RenderView::calcColumnWidth):
(WebCore::RenderView::paginationUnit):
(WebCore::RenderView::viewLogicalHeight):
Since we need to define Pagination in Page.h AND FrameView.h, it is
now in its own header, Pagination.h. And therefore it is no longer
WebCore::Page::Pagination, but rather it is just WebCore::Pagination.
- page/Page.h:
(Page):
- rendering/Pagination.h: Added.
(WebCore):
(WebCore::Pagination::Pagination):
(Pagination):
(WebCore::Pagination::operator==):
(WebCore::Pagination::operator!=):
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
Certain ColumnInfo values are set based on the RenderStyle. So if
those RenderStyle values change, the ColumnInfo needs to be updated.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateColumnInfoFromStyle):
(WebCore):
- rendering/RenderBlock.h:
(RenderBlock):
Factor in paged-x and paged-y when determining if a RenderBlock
requires columns.
(WebCore::RenderBlock::requiresColumns):
RenderStyle::specifiesColumns() is an odd and probably broken
function. At the very least, it should be re-named, if not removed
entirely. It does not accurately assess if columns have been
specified. I had to add this code here because specifiesColumns()
returns false for paged-x and true for paged-y. We were hitting a
number of crashes with paged-y because of this, so I chose for the
time being to limit this check to non-root layers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
It's just Pagination now, not Page::Pagination.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::reset):
(WebCore::InternalSettings::setPagination):
Source/WebKit/mac:
WebCore::Page::Pagination is now just WebCore::Pagination.
- WebView/WebView.mm:
(-[WebView _setPaginationMode:]):
(-[WebView _paginationMode]):
(-[WebView _setPaginationBehavesLikeColumns:]):
(-[WebView _setPageLength:]):
(-[WebView _setGapBetweenPages:]):
Source/WebKit2:
WebCore::Page::Pagination is now just WebCore::Pagination.
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationMode):
(WKPageGetPaginationMode):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setPaginationMode):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
(WebKit::WebPageProxy::paginationMode):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPaginationMode):
(WebKit::WebPage::setPaginationBehavesLikeColumns):
(WebKit::WebPage::setPageLength):
(WebKit::WebPage::setGapBetweenPages):
- WebProcess/WebPage/WebPage.h:
(WebPage):
LayoutTests:
Test the parsing of the two new values.
- fast/css/overflow-property-expected.txt:
- fast/css/overflow-property.html:
New tests.
- fast/overflow/paged-x-div.html: Added.
- fast/overflow/paged-x-on-root.html: Added.
- fast/overflow/paged-y-div.html: Added.
- fast/overflow/paged-y-on-root.html: Added.
- platform/mac/fast/overflow/paged-x-div-expected.png: Added.
- platform/mac/fast/overflow/paged-x-div-expected.txt: Added.
- platform/mac/fast/overflow/paged-x-on-root-expected.png: Added.
- platform/mac/fast/overflow/paged-x-on-root-expected.txt: Added.
- platform/mac/fast/overflow/paged-y-div-expected.png: Added.
- platform/mac/fast/overflow/paged-y-div-expected.txt: Added.
- platform/mac/fast/overflow/paged-y-on-root-expected.png: Added.
- platform/mac/fast/overflow/paged-y-on-root-expected.txt: Added.
- 1:14 PM Changeset in webkit [126342] by
-
- 4 edits in trunk/Source/WebCore
[WebGL] Mac/ATI/AMD systems need to translate built-in GLSL functions
https://bugs.webkit.org/show_bug.cgi?id=94030
Reviewed by Tim Horton.
ATI/AMD GPUs on Apple platforms do not give correct values for some of
the built-in GLSL functions. Add a compile flag that is passed to ANGLE
so that, with this configuration, it will rewrite the shader to emulate
the function in code.
This is exposing some design weaknesses in the way we call ANGLE. We'll
soon need to add more compiler flags; Future bugs will likely clean
this code up. But this approach is satisfactory for the moment.
This change is tested by the Khronos WebGL conformance test suite, in particular:
conformance/glsl/functions/glsl-function-distance.html
conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-length.html
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::validateShaderSource): Test for ATI cards
on the Mac platform, and pass in an extra flag to the translation step.
- platform/graphics/ANGLEWebKitBridge.h:
(ANGLEWebKitBridge): Add a new parameter to getTranslatedShaderSourceANGLE
that accepts some extra options to pass to ANGLE.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Pass
the extra options into ANGLE's compile function.
- 12:55 PM Changeset in webkit [126341] by
-
- 8 edits2 copies in trunk
[chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=93091
Reviewed by Adam Barth.
Source/WebCore:
Fixing a FIXME that the patch obsoletes.
Covered by existing tests.
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::initialize):
Tools:
Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
to complete the infrastructure for RTCPeerConnection.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
- DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(MockWebKitPlatformSupport):
- DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
- DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::initialize):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
(WebKit):
(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
- 12:50 PM Changeset in webkit [126340] by
-
- 9 edits in trunk/Source
[chromium] Simplify updateContentRect, removing rect parameter, refactor unit tests.
https://bugs.webkit.org/show_bug.cgi?id=94165
Patch by Eric Penner <epenner@google.com> on 2012-08-22
Reviewed by Adrienne Walker.
Source/WebCore:
Remove visible rect parameter from TiledLayerChromium functions. Passing a
rect that is not the visible rect wouldn't make sense, and soon we might
need further visibility information.
In refactoring the unit tests, I removed texture manager from all tests
and put it in the test class. I also made some utility functions to
simulate the commit flow and remove tons of boilerplate code. I refactored
about half the unit tests to use the utility functions.
Refactored tests.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::needMoreUpdates):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::update):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::update):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
Source/WebKit/chromium:
Refactored tests to remove lots of boilerplate code.
- tests/CCTiledLayerTestCommon.cpp:
- tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
- tests/TiledLayerChromiumTest.cpp:
- 12:40 PM Changeset in webkit [126339] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 124282 - REGRESSION(r120979): Node list returned by getElementsByTagNameNS isn't invalidated when children changes
https://bugs.webkit.org/show_bug.cgi?id=92705
BUG=139646
Review URL: https://chromiumcodereview.appspot.com/10871021
- 12:38 PM Changeset in webkit [126338] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Make all pickers non-zoomable
https://bugs.webkit.org/show_bug.cgi?id=94729
Patch by Crystal Zhang <haizhang@rim.com> on 2012-08-22
Reviewed by Antonio Gomes.
Move HTML header initialization to PagePopupBlackBerry as that part are all the same, and make all pickers non-zoomable.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::screenSize):
(WebKit):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::writeDocument):
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::init):
(WebCore::PagePopupBlackBerry::generateHTML):
(WebCore):
- WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
(WebCore::SelectPopupClient::writeDocument):
- 12:37 PM Changeset in webkit [126337] by
-
- 2 edits in trunk/LayoutTests
Skipping css3/flexbox/flexitem.html.
https://bugs.webkit.org/show_bug.cgi?id=94723.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Simon Fraser.
- platform/mac/Skipped:
- 12:36 PM Changeset in webkit [126336] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add a check to filter out cookies that tries to set the
domain to a top level domain
https://bugs.webkit.org/show_bug.cgi?id=94722
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-22
Reviewed by Rob Buis.
Adding conditions to check whether a cookie domain is a top level domain.
If it is, throw it out when parsing.
Manual Testing by trying to insert a cookie with an invalid domain
using web-inspector. (ex: when on news.yahoo.com.hk, try to document.
cookie="test1=seeifthiscookieexist; domain=.com.hk")
PR121622
- platform/blackberry/CookieParser.cpp:
WebCore::CookieParser::parseOneCookie):
- 12:34 PM Changeset in webkit [126335] by
-
- 3 edits in trunk/Source/WebCore
Remove RenderBlock::paintEllipsisBoxes
https://bugs.webkit.org/show_bug.cgi?id=94709
Reviewed by Eric Seidel.
Remove unused method.
No change in functionality, no new tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintFloats):
- rendering/RenderBlock.h:
(RenderBlock):
- 12:32 PM Changeset in webkit [126334] by
-
- 7 edits in trunk/Tools
Merge TestExpectationSerializer into TestExpectationLine
https://bugs.webkit.org/show_bug.cgi?id=94638
Reviewed by Dimitri Glazkov.
Moved all methods except, list_to_string which was moved to TestExpectations
from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
(TestExpectationEditorTests.assert_remove_roundtrip):
(TestExpectationEditorTests.assert_update_roundtrip):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(ParseError.repr):
(TestExpectationLine):
(TestExpectationLine.create_passing_expectation):
(TestExpectationLine.to_string): Moved from TestExpectationSerializer.
(TestExpectationLine.to_csv): Ditto.
(TestExpectationLine._serialize_parsed_expectations): Ditto.
(TestExpectationLine._serialize_parsed_modifiers): Ditto.
(TestExpectationLine._format_line):
(TestExpectations.remove_configuration_from_test):
(TestExpectations.remove_rebaselined_tests):
(TestExpectations.add_skipped_tests):
(TestExpectations):
(TestExpectations.list_to_string): Moved from TestExpectationSerializer.
(TestExpectations.list_to_string.serialize):
(TestExpectations.list_to_string.nones_out):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
(TestExpectationSerializationTests.init):
(TestExpectationSerializationTests.assert_round_trip):
(TestExpectationSerializationTests.assert_list_round_trip):
(TestExpectationSerializationTests.test_unparsed_to_string):
(TestExpectationSerializationTests.test_unparsed_list_to_string):
(TestExpectationSerializationTests.test_parsed_to_string):
(TestExpectationSerializationTests.test_serialize_parsed_expectations):
(TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
(TestExpectationSerializationTests.test_format_line):
(TestExpectationSerializationTests.test_reconstitute_only_these):
- Scripts/webkitpy/tool/commands/expectations.py:
(OptimizeExpectations.execute):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.execute):
(PrintExpectations._format_lines):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningExpectationsUpdater.update_expectations):
- 12:30 PM Changeset in webkit [126333] by
-
- 6 edits7 adds in trunk
MediaStream API: Introduce RTCSessionDescription
https://bugs.webkit.org/show_bug.cgi?id=93119
Reviewed by Adam Barth.
Source/WebCore:
This patch introduces RTCSessionDescription together with its
corresponding WebCore/platform representation.
Test: fast/mediastream/RTCSessionDescription.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/DOMWindowMediaStream.idl:
- Modules/mediastream/RTCSessionDescription.cpp: Added.
(WebCore):
(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::RTCSessionDescription):
(WebCore::RTCSessionDescription::~RTCSessionDescription):
(WebCore::RTCSessionDescription::type):
(WebCore::RTCSessionDescription::setType):
(WebCore::RTCSessionDescription::sdp):
(WebCore::RTCSessionDescription::setSdp):
(WebCore::RTCSessionDescription::descriptor):
- Modules/mediastream/RTCSessionDescription.h: Added.
(WebCore):
(RTCSessionDescription):
- Modules/mediastream/RTCSessionDescription.idl: Added.
- WebCore.gypi:
- platform/mediastream/RTCSessionDescriptionDescriptor.cpp: Added.
(WebCore):
(WebCore::RTCSessionDescriptionDescriptor::create):
(WebCore::RTCSessionDescriptionDescriptor::RTCSessionDescriptionDescriptor):
(WebCore::RTCSessionDescriptionDescriptor::~RTCSessionDescriptionDescriptor):
- platform/mediastream/RTCSessionDescriptionDescriptor.h: Added.
(WebCore):
(RTCSessionDescriptionDescriptor):
(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::setType):
(WebCore::RTCSessionDescriptionDescriptor::sdp):
(WebCore::RTCSessionDescriptionDescriptor::setSdp):
LayoutTests:
- fast/mediastream/RTCSessionDescription-expected.txt: Added.
- fast/mediastream/RTCSessionDescription.html: Added.
- 12:27 PM Changeset in webkit [126332] by
-
- 2 edits in trunk/Tools
Unreviewed, add aelias@chromium.org to committers
I (aelias@chromium.org) have been approved for commit access and Apple
has confirmed receipt of my committer agreement.
- Scripts/webkitpy/common/config/committers.py:
- 12:27 PM Changeset in webkit [126331] by
-
- 3 edits2 adds in trunk
DOM manipulation crashes the browser
Creating a DOM track element by script and changing the mode crashes
results in a browser crash.
https://bugs.webkit.org/show_bug.cgi?id=94628
Reviewed by Eric Carlson.
Source/WebCore:
Simple fix that creates the text track cue list in case of mode change.
Test: media/track/track-element-dom-change-crash.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged):
LayoutTests:
- media/track/track-element-dom-change-crash-expected.txt: Added.
- media/track/track-element-dom-change-crash.html: Added.
- 12:24 PM Changeset in webkit [126330] by
-
- 2 edits in trunk/Source/WebCore
Microdata build fix.
- html/HTMLPropertiesCollection.h:
(WebCore::HTMLPropertiesCollection::updatePropertyCache):
- 12:21 PM Changeset in webkit [126329] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Adding platform-specific baseline for css3/flexbox/flexitem.html that's
required after r126257.
Removing failure expectation for fast/forms/range/range-hit-test-with-padding.html
after the test was refactored in r126252 and is now passing.
Skipping two more failing tests that take too long to fail.
- platform/gtk/TestExpectations:
- platform/gtk/css3/flexbox: Added.
- platform/gtk/css3/flexbox/flexitem-expected.txt: Added.
- 12:18 PM Changeset in webkit [126328] by
-
- 6 edits7 adds in trunk
MediaStream API: Introduce RTCIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=93117
Reviewed by Adam Barth.
Source/WebCore:
This patch introduces RTCIceCandidate together with its corresponding
WebCore/platform representation.
Test: fast/mediastream/RTCIceCandidate.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/DOMWindowMediaStream.idl:
- Modules/mediastream/RTCIceCandidate.cpp: Added.
(WebCore):
(WebCore::RTCIceCandidate::create):
(WebCore::RTCIceCandidate::RTCIceCandidate):
(WebCore::RTCIceCandidate::~RTCIceCandidate):
(WebCore::RTCIceCandidate::candidate):
(WebCore::RTCIceCandidate::sdpMid):
(WebCore::RTCIceCandidate::sdpMLineIndex):
(WebCore::RTCIceCandidate::descriptor):
- Modules/mediastream/RTCIceCandidate.h: Added.
(WebCore):
(RTCIceCandidate):
- Modules/mediastream/RTCIceCandidate.idl: Added.
- WebCore.gypi:
- platform/mediastream/RTCIceCandidateDescriptor.cpp: Added.
(WebCore):
(WebCore::RTCIceCandidateDescriptor::create):
(WebCore::RTCIceCandidateDescriptor::RTCIceCandidateDescriptor):
(WebCore::RTCIceCandidateDescriptor::~RTCIceCandidateDescriptor):
- platform/mediastream/RTCIceCandidateDescriptor.h: Added.
(WebCore):
(RTCIceCandidateDescriptor):
(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
LayoutTests:
- fast/mediastream/RTCIceCandidate-expected.txt: Added.
- fast/mediastream/RTCIceCandidate.html: Added.
- 12:09 PM Changeset in webkit [126327] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove WebFrame::setSelectionToRange
https://bugs.webkit.org/show_bug.cgi?id=94685
Patch by Iain Merrick <husky@chromium.org> on 2012-08-22
Reviewed by Adam Barth.
It has basically the same functionality as WebFrame::selectRange.
The calling code was removed in Chromium patch 152608.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
- 12:00 PM Changeset in webkit [126326] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/94679> WebCore scrolling thread leaks objects due to them being autoreleased without any autorelease pool in place
Reviewed by Dan Bernstein.
- page/scrolling/mac/ScrollingThreadMac.mm:
(WebCore::ScrollingThread::threadRunLoopSourceCallback): Ensure that an autorelease pool is in place when
dispatching functions on the scrolling thread.
- 11:44 AM Changeset in webkit [126325] by
-
- 3 edits in trunk/Source/WebCore
Failure to dispatch delegate callbacks if resource load fails synchronously
https://bugs.webkit.org/show_bug.cgi?id=94644
Reviewed by Antti Koivisto.
Resource loads can be triggered by layout after document load is
complete but before we have dispatched didFinishLoadForFrame callback.
In such cases, if the load fails synchronously due to the client
returning 0 from willSendRequest callback, we would fail to call
didFinishLoading. this was fixed for Font resources in r122446 for bug
- This fixes it in the general case by having CachedResourceLoader
call FrameLoader::checkLoadComplete() when it is done loading all
resources.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::decrementRequestCount):
- 11:33 AM Changeset in webkit [126324] by
-
- 2 edits in trunk/LayoutTests
Layout test fast/text/emphasis-overlap.html started failing differently after r126312
https://bugs.webkit.org/show_bug.cgi?id=94735
Unreviewed gardening. Suppressed failure.
- platform/chromium/TestExpectations:
- 11:17 AM Changeset in webkit [126323] by
-
- 10 edits1 move1 add108 deletes in trunk
Unreviewed, rolling out r126319.
http://trac.webkit.org/changeset/126319
https://bugs.webkit.org/show_bug.cgi?id=84487
Broke Chromium Mac build
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(GraphicsLayerChromium):
- platform/graphics/chromium/LinkHighlight.cpp: Added.
(WebCore):
(WebCore::LinkHighlight::create):
(WebCore::LinkHighlight::LinkHighlight):
(WebCore::LinkHighlight::~LinkHighlight):
(WebCore::LinkHighlight::contentLayer):
(WebCore::LinkHighlight::paintContents):
(WebCore::LinkHighlight::notifyAnimationStarted):
(WebCore::LinkHighlight::notifyAnimationFinished):
- platform/graphics/chromium/LinkHighlight.h: Renamed from Source/WebKit/chromium/src/LinkHighlight.h.
(WebCore):
(LinkHighlight):
Source/WebKit/chromium:
- WebKit.gyp:
- src/LinkHighlight.cpp: Removed.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::layout):
- src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
- tests/LinkHighlightTest.cpp:
- tests/data/test_touch_link_highlight.html: Removed.
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Removed.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Removed.
- platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Removed.
- platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Removed.
- platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Removed.
- platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Removed.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Removed.
- 11:14 AM Changeset in webkit [126322] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing after r126304
https://bugs.webkit.org/show_bug.cgi?id=94730
Unreviewed; suppressed failure for the moment.
- platform/chromium/TestExpectations:
- 10:59 AM Changeset in webkit [126321] by
-
- 2 edits in trunk/Source/WebCore
Respect system setting for rubber-banding in ScrollAnimatorMac.
https://bugs.webkit.org/show_bug.cgi?id=94356
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-08-22
Reviewed by James Robinson.
Respects user defaults setting of NSScrollViewRubberbanding,
which controls rubber-banding in other Mac OS X applications.
If NSScrollViewRubberbanding is not set, defaults to enabling
rubber banding. Otherwise, rubber banding is disabled if the
value is 0 and enabled otherwise.
No new tests since the behavior depends on system settings.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore):
(WebCore::rubberBandingEnabledForSystem):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
- 10:56 AM Changeset in webkit [126320] by
-
- 3 edits in trunk/Source/WebCore
[chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those
https://bugs.webkit.org/show_bug.cgi?id=94658
Patch by James Robinson <jamesr@chromium.org> on 2012-08-22
Reviewed by Tony Chang.
The chromium mac port hasn't supported Leopard for a while now, so remove chromium-specific code that checks
for OS X version <= Leopard.
- platform/graphics/chromium/CrossProcessFontLoading.mm:
(WebCore::FontPlatformData::loadFont):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::canSetCascadeListForCustomFont):
- 10:51 AM Changeset in webkit [126319] by
-
- 10 edits1 move112 adds1 delete in trunk
[chromium] Add touch link highlight animation layers.
https://bugs.webkit.org/show_bug.cgi?id=84487
Reviewed by James Robinson.
Adds support for creating composited touch link highlights in renderer thread. Clipping not yet
implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported.
Transform support currently limited to translation.
Source/WebCore:
Unit tests for LinkHighlight revised.
Tests: platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scroll-clip.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-clipped.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed): Adds notification to LinkHighlight when layer goes away.
(WebCore::GraphicsLayerChromium::updateNames): Now sets debug name for LinkHighlight layer.
(WebCore::GraphicsLayerChromium::setSize): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplay): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setLinkHighlight): Registers LinkHighlightClient* with GraphicsLayerChromium.
(WebCore::GraphicsLayerChromium::updateChildList): Now adds LinkHighlight WebLayer if highlight active.
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable): Invalidates LinkHighlight if present.
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(LinkHighlightClient): Abstract interface seen by GraphicsLayerChromium.
(WebCore::LinkHighlightClient::~LinkHighlightClient):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::linkHighlight):
- platform/graphics/chromium/LinkHighlight.cpp: Removed.
Source/WebKit/chromium:
Unit tests for LinkHighlight revised.
- WebKit.gyp:
- src/LinkHighlight.cpp: Added.
(WebKit):
(WebKit::LinkHighlight::create):
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::~LinkHighlight):
(WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight.
(WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight.
(WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers.
(WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates.
(WebKit::LinkHighlight::paintContents): If highlight active, paints highlight.
(WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation.
(WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium.
(WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate.
(WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes.
(WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position.
Computations proceed only if preceded by call to invalidate().
(WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid.
(WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout().
(WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium.
- src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.
(WebCore):
(WebKit):
(LinkHighlight):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location.
(WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location.
(WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry().
- src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
(WebKit::WebViewImpl::linkHighlight):
- tests/LinkHighlightTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/data/test_touch_link_highlight.html: Added.
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Added.
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Added.
- platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Added.
- platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Added.
- 10:50 AM Changeset in webkit [126318] by
-
- 2 edits in trunk/Source/WebKit2
Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
https://bugs.webkit.org/show_bug.cgi?id=93892
Reviewed by Eric Carlson.
Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
it can join the new one.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
- 10:41 AM Changeset in webkit [126317] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed Chromium gardening. Copy old Mac test expectations
(ignored anyway) for this Mac-specific test after r126219.
- platform/chromium/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
- platform/chromium/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.
- 10:33 AM Changeset in webkit [126316] by
-
- 2 edits in trunk/LayoutTests
Unskip http/tests/inspector/console-resource-errors.html.
https://bugs.webkit.org/show_bug.cgi?id=94640.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Jessie Berlin.
The test has been rebaseline'd in r126281 and no longer fails.
- platform/mac/Skipped:
- 10:19 AM Changeset in webkit [126315] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. Missing PANGO_CFLAGS.
- GNUmakefile.am:
- 10:10 AM Changeset in webkit [126314] by
-
- 35 edits1 add in trunk
Web Inspector: make "sdk" component compile independently from the rest of the front-end.
https://bugs.webkit.org/show_bug.cgi?id=94705
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change refactors the way we compile. Running "compile-front-end.py sdk" will compile sdk only.
It also introduces DOMStorageModel and DatabaseModel that are used to split model / UI layers.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.evaluate):
- inspector/Inspector.json:
- inspector/compile-front-end.py:
(dump_module):
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.clone):
(WebInspector.ConsoleMessage.prototype.location):
- inspector/front-end/DOMAgent.js:
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageUpdated):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.domStorageUpdated):
- inspector/front-end/Database.js:
(WebInspector.Database):
(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseModel):
(WebInspector.DatabaseModel.prototype.databases):
(WebInspector.DatabaseModel.prototype.databaseForId):
(WebInspector.DatabaseModel.prototype._addDatabase):
(WebInspector.DatabaseModel.prototype._sqlTransactionSucceeded):
(WebInspector.DatabaseModel.prototype._sqlTransactionFailed):
(WebInspector.DatabaseDispatcher):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
- inspector/front-end/DebuggerModel.js:
- inspector/front-end/FileUtils.js:
(WebInspector.OutputStreamDelegate.prototype.onTransferStarted):
(WebInspector.OutputStreamDelegate.prototype.onChunkTransferred):
(WebInspector.OutputStreamDelegate.prototype.onTransferFinished):
(WebInspector.OutputStreamDelegate.prototype.onError):
(WebInspector.OutputStream):
(WebInspector.OutputStream.prototype.startTransfer):
(WebInspector.OutputStream.prototype.transferChunk):
(WebInspector.OutputStream.prototype.finishTransfer):
(WebInspector.OutputStream.prototype.dispose):
- inspector/front-end/HandlerRegistry.js:
- inspector/front-end/HeapSnapshotView.js:
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._addDatabase):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.ResourcesPanel.prototype._showDatabase.get if):
(WebInspector.ResourcesPanel.prototype._showDatabase.else.get if):
(WebInspector.ResourcesPanel.prototype._showDatabase):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):
(WebInspector.ResourcesPanel.prototype._updateDatabaseTables.get if):
(WebInspector.ResourcesPanel.prototype._updateDatabaseTables.tableNamesCallback):
(WebInspector.DatabaseTreeElement.prototype.onselect):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
- inspector/front-end/Settings.js:
- inspector/front-end/Spectrum.js:
- inspector/front-end/TextEditorModel.js:
- inspector/front-end/UIString.js: Added.
(WebInspector.UIString):
- inspector/front-end/UIUtils.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
(InspectorFrontendHostAPI.prototype.platform):
(InspectorFrontendHostAPI.prototype.port):
(InspectorFrontendHostAPI.prototype.bringToFront):
(InspectorFrontendHostAPI.prototype.closeWindow):
(InspectorFrontendHostAPI.prototype.requestAttachWindow):
(InspectorFrontendHostAPI.prototype.requestDetachWindow):
(InspectorFrontendHostAPI.prototype.requestSetDockSide):
(InspectorFrontendHostAPI.prototype.setAttachedWindowHeight):
(InspectorFrontendHostAPI.prototype.moveWindowBy):
(InspectorFrontendHostAPI.prototype.setInjectedScriptForOrigin):
(InspectorFrontendHostAPI.prototype.loaded):
(InspectorFrontendHostAPI.prototype.localizedStringsURL):
(InspectorFrontendHostAPI.prototype.hiddenPanels):
(InspectorFrontendHostAPI.prototype.inspectedURLChanged):
(InspectorFrontendHostAPI.prototype.documentCopy):
(InspectorFrontendHostAPI.prototype.copyText):
(InspectorFrontendHostAPI.prototype.openInNewTab):
(InspectorFrontendHostAPI.prototype.canSave):
(InspectorFrontendHostAPI.prototype.save):
(InspectorFrontendHostAPI.prototype.canAppend):
(InspectorFrontendHostAPI.prototype.append):
(InspectorFrontendHostAPI.prototype.sendMessageToBackend):
(InspectorFrontendHostAPI.prototype.recordActionTaken):
(InspectorFrontendHostAPI.prototype.recordPanelShown):
(InspectorFrontendHostAPI.prototype.recordSettingChanged):
(InspectorFrontendHostAPI.prototype.loadResourceSynchronously):
(InspectorFrontendHostAPI.prototype.setZoomFactor):
(InspectorFrontendHostAPI.prototype.canInspectWorkers):
(SourceMapV3):
(SourceMapV3.Section):
(SourceMapV3.Offset):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector.inspect):
LayoutTests:
- http/tests/inspector-enabled/database-open.html:
- http/tests/inspector-enabled/dom-storage-open.html:
- 10:05 AM Changeset in webkit [126313] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. libWebCore needs include paths
for some bits of WebCoreGtk.
- GNUmakefile.am:
- 9:53 AM Changeset in webkit [126312] by
-
- 9 edits1 add in trunk
FontMetrics.unitsPerEm(), FontPlatformData.orientation(), SimpleFontData::platformBoundsForGlyph are not implemented on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=83512
Patch by Koji Ishii <Koji Ishii> on 2012-08-22
Reviewed by Tony Chang.
Source/WebCore:
Chromium Windows does not implement following 3 functions that are required for bug 51450.
- FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000).
- FontPlatformData.orientation() always returns Horizontal.
- SimpleFontData::platformBoundsForGlyph() always returns FloatRect().
Tony suggested in bug 51450 review to split code that is not behind
#if ENABLE(OPENTYPE_VERTICAL) to a separate patch.
Test: Following 3 existing but skipped tests are now enabled and pass.
fast/text/emphasis-overlap.html
fast/text/emphasis-avoid-ruby.html
fast/repaint/text-emphasis-v.html
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::createFontPlatformData): Add orientation.
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Add orientation.
(WebCore::FontPlatformData::operator=): Add orientation.
- platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(FontPlatformData):
(WebCore::FontPlatformData::orientation): Add orientation.
(WebCore::FontPlatformData::setOrientation): Add orientation.
(WebCore::FontPlatformData::operator==): Add orientation.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit): Set FontMetrics.unitsPerEm.
(WebCore::SimpleFontData::createScaledFontData): Add orientation.
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.
- platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Add orientation.
LayoutTests:
Chromium Windows does not implement following 3 functions that are required for bug 51450.
- FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000). This change requires rebaseline of fast/repaint/stacked-diacritics and fast/text/emphasis-overlap.
- FontPlatformData.orientation() always returns Horizontal. This has no effect as of this patch.
- SimpleFontData::platformBoundsForGlyph() always returns FloatRect(). This change improves rendering of text-emphasis and 3 existing tests pass now.
Tony suggested in bug 51450 review to split code that is not behind
#if ENABLE(OPENTYPE_VERTICAL) to a separate patch.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.png:
- platform/chromium-win/fast/text/emphasis-overlap-expected.txt: Added due to metrics change.
- platform/chromium/TestExpectations: Enabled 3 tests for Chromium Win.
- 9:36 AM Changeset in webkit [126311] by
-
- 22 edits in trunk
[WK2] Support posting injected bundle messages to a page
https://bugs.webkit.org/show_bug.cgi?id=94630
Reviewed by Sam Weinig.
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- Shared/CoreIPCSupport/InjectedBundleMessageKinds.h:
- UIProcess/API/C/WKPage.cpp: (WKPagePostMessageToInjectedBundle):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::postMessageToInjectedBundle):
- UIProcess/WebPageProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::didReceiveMessageToPage): (WebKit::InjectedBundle::didReceiveMessage):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundleClient.cpp: (WebKit::InjectedBundleClient::didReceiveMessageToPage):
- WebProcess/InjectedBundle/InjectedBundleClient.h: (InjectedBundleClient): Added a PostMessageToPage injected bundle message type, with all associated machinery. API is WKPagePostMessageToInjectedBundle(), and an associated didReceiveMessageToPage() injected bundle client function.
- WebProcess/qt/QtBuiltinBundle.cpp: (WebKit::QtBuiltinBundle::initialize): Updated for new client API.
- UIProcess/WebContext.cpp: (WebKit::WebContext::postMessageToInjectedBundle): Implemented multiple process model case.
- 9:07 AM Changeset in webkit [126310] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r125578): fast/regex/unicodeCaseInsensitive.html crash on Linux Debug Chromium
https://bugs.webkit.org/show_bug.cgi?id=94010
Reviewed by Tony Chang.
r125578 inspected the raw text run for word-end but the index it used to do so was for a normalized
version of the run that could be longer than the raw text run. So to allow proper detection of word-end
in complex text (i) do not normalize tabs to plain white-space and (ii) go back to using the normalized version
of the run for detecting word-end. There is a risk that some fonts may create glyphs for the '\t' character
but this does not turn up in any of our regression tests and the more common risk appears to be the new-line.
Test: fast/regex/unicodeCaseInsensitive.html
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::normalizeSpacesAndMirrorChars):
- 9:01 AM Changeset in webkit [126309] by
-
- 4 edits in trunk
REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
https://bugs.webkit.org/show_bug.cgi?id=94200
Reviewed by Chris Fleizach.
Tools:
Adds reference counting for AtkObjects referenced by
AccessibilityUIElementGtk. This prevents bogus results and
assertion failures on AccessibilityUIElements whose underlying
object has been deleted (as opposed to just made defunct).
This fixes two tests that were previously failing because of this bug.
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
LayoutTests:
This patch fixes two tests and removes them from gtk expectations.
- platform/gtk/TestExpectations:
- 8:54 AM Changeset in webkit [126308] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Support the communication protocol from the injected script
https://bugs.webkit.org/show_bug.cgi?id=94689
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.
Support the WebGL communication protocol from the injected script module.
- inspector/InjectedScriptWebGLModuleSource.js:
(.):
- 8:53 AM Changeset in webkit [126307] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Crash when finalizing WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=94699
Reviewed by Martin Robinson.
Create the offscreen window the first time accelerated compositing
is enabled, so that if it's never enabled the window won't be
created.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::initialize):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
- 8:47 AM Changeset in webkit [126306] by
-
- 11 edits in trunk
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435
Reviewed by Martin Robinson.
More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.
.:
- GNUmakefile.am: add variable that will hold the list of source files
for libWebCorePlatform .
Source/WebCore:
- GNUmakefile.am: add new libWebCorePlatform convenience library.
- GNUmakefile.list.am: move list of platform/* files to its own variable.
Source/WebKit/gtk:
- GNUmakefile.am: link libWebCorePlatform into libwebkitgtk
Source/WebKit2:
- GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk
Tools:
- GNUmakefile.am: link libWebCorePlatform into DRT
- 8:46 AM Changeset in webkit [126305] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build failures with harfbuzz outside standard locations
https://bugs.webkit.org/show_bug.cgi?id=93030
Reviewed by Rob Buis.
Add ${HARFBUZZ_INCLUDE_DIRS} to the list of included paths: so far
it was being implicitly pulled from evas's pkg-config file, and
used to work when WebKit-EFL's dependencies were built with
jhbuild -- in this case, harfbuzz is built before evas, which is
then built with harfbuzz support and adds the required paths to
its .pc file.
We need to include things directly to account for the case of
people not using jhbuild and thus not necessarily having harfbuzz
as an evas dependency.
- PlatformEfl.cmake:
- 8:34 AM Changeset in webkit [126304] by
-
- 13 edits4 adds in trunk
Crash in WebCore::RenderBlock::removeChild
https://bugs.webkit.org/show_bug.cgi?id=93879
Patch by Raul Hudea <rhudea@adobe.com> on 2012-08-22
Reviewed by Abhishek Arya.
Source/WebCore:
By adding the lifetime state to the RenderNamedFlowThread (r122556), it become possible for the a RenderRegion object to delete its sibling,
the RenderNamedFlowThread. This is unexpected in the rendering world and cause problems in RenderBlock::removeChild where we retain previous
and next sibling pointers.
So, all the RenderNamedFlowThread are created under a RenderFlowThreadContainer object insted of the RenderView. The new object is created only
when the first named flow is created.
Test: fast/regions/remove-flow-thread-crash.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::FlowThreadController): Added initialization for the new RenderFlowThreadContainer member
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName): Added the creation of the RenderFlowThreadContainer object and use it as a parent for all RenderNamedFlowThreads
(WebCore::FlowThreadController::styleDidChange): Inform all the RenderNamedFlowThreads that the style changed in regions (initially this code was in RenderView, but now all RenderNamedFlowThreads are children of RenderFlowThreadContainer)
(WebCore):
- rendering/FlowThreadController.h:
(WebCore):
(FlowThreadController):
- rendering/RenderFlowThreadContainer.cpp: Added.
(WebCore):
(WebCore::RenderFlowThreadContainer::RenderFlowThreadContainer):
(WebCore::RenderFlowThreadContainer::layout):
- rendering/RenderFlowThreadContainer.h: Added.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout): Skip to RenderView if the current object is an RenderFlowThreadContainer.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderFlowThreadContainer):
- rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange): Moved the code associated to RenderNamedFlowThreads to FlowThreadController:styleDidChange and call it instead.
LayoutTests:
Test the region-flow_thread sibling case
- fast/regions/remove-flow-thread-crash-expected.txt: Added.
- fast/regions/remove-flow-thread-crash.html: Added.
- 8:28 AM Changeset in webkit [126303] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496
Reviewed by Yong Li.
Cleanup some more.
- platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore):
(WebCore::createParser):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):
- 7:51 AM Changeset in webkit [126302] by
-
- 5 edits in trunk/Source/WebCore
Remove unused TextDrawingMode flags from GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=21898
Reviewed by Benjamin Poulain.
Remove TextModeClip and TextModeInvisible. These are not used by any port, and
according to https://bugs.webkit.org/show_bug.cgi?id=42110#c2 these were added
just to map CG existing flags, but are not used.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
- platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::drawText):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setTextDrawingMode):
- 7:13 AM Changeset in webkit [126301] by
-
- 9 edits in trunk
Unreviewed, rolling out r126287.
http://trac.webkit.org/changeset/126287
https://bugs.webkit.org/show_bug.cgi?id=94708
It made WK1 layout testing 3.7x slower (>1hours) (Requested by
ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22
Source/WebCore:
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::unusedWeakObjectMapCallback):
(Bindings):
(JSC::Bindings::WeakMapImpl::WeakMapImpl):
(JSC::Bindings::WeakMapImpl::~WeakMapImpl):
(JSC::Bindings::WeakMap::~WeakMap):
(JSC::Bindings::WeakMap::set):
(JSC::Bindings::WeakMap::get):
(JSC::Bindings::WeakMap::remove):
- bridge/qt/qt_instance.h:
(QtInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
Source/WebKit/qt:
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods_data):
(tst_QObjectBridge::introspectQtMethods):
LayoutTests:
- platform/qt/Skipped:
- 7:11 AM Changeset in webkit [126300] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: follow up to r126297, fixing WebCore.gypi.
- WebCore.gypi:
- 7:00 AM Changeset in webkit [126299] by
-
- 2 edits in trunk/Tools
Unreviewed buildfix for Qt-minimal after r126291
Disable smooth scrolling when request-animation-frame has been disabled either
explicitly or as part of --minimal.
- qmake/mkspecs/features/features.prf:
- 6:34 AM Changeset in webkit [126298] by
-
- 11 edits in trunk/Source
[GTK] Preferred languages and spellchecker APIs are not consistent in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=94683
Reviewed by Alejandro G. Castro.
Source/WebCore:
Use a Vector<String> instead of a comma-separated string to
get/set languages.
- platform/text/gtk/TextCheckerEnchant.cpp:
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::getSpellCheckingLanguages):
- platform/text/gtk/TextCheckerEnchant.h:
(TextCheckerEnchant):
Source/WebKit/gtk:
- webkit/webkitspellcheckerenchant.cpp:
(updateSpellCheckingLanguages): Split the languages string to pass a
Vector to updateSpellCheckingLanguages().
Source/WebKit2:
Change spell-checker and preferred languages API to use a GStrv
instead of a comma-separated string and GList. This makes the API
more consistent and convenient to use.
- UIProcess/API/gtk/WebKitTextChecker.cpp:
(WebKitTextChecker::getSpellCheckingLanguages): Return a
Vector<String> instead of a String.
(WebKitTextChecker::setSpellCheckingLanguages): Receive a
Vector<String> instead of a String.
- UIProcess/API/gtk/WebKitTextChecker.h:
(WebKitTextChecker): Use a GPtrArray to cache languages.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_spell_checking_languages):
(webkit_web_context_set_spell_checking_languages):
(webkit_web_context_set_preferred_languages):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker):
(testWebContextLanguages):
- 6:22 AM Changeset in webkit [126297] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: move NavigatorView and NavigatorOverlayController to ScriptsPanel module
https://bugs.webkit.org/show_bug.cgi?id=94693
Reviewed by Vsevolod Vlasov.
Loading them via importScript now.
- inspector/compile-front-end.py:
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/inspector.html:
- 6:21 AM Changeset in webkit [126296] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=94692
Reviewed by Kenneth Rohde Christiansen.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- 6:12 AM Changeset in webkit [126295] by
-
- 2 edits in trunk/Source/WebKit2
Wrong default for new ScrollAnimatorEnabled preference.
Reviewed by Simon Hausmann.
ScrollAnimatorEnabled introduced in r126291, should default to 'true'
to preserve existing behaviour on WK2 platforms that already enabled
SMOOTH_SCROLLING unconditionally.
- Shared/WebPreferencesStore.h:
(WebKit):
- 6:12 AM Changeset in webkit [126294] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix JSC build when DFG-JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=94694
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-22
Reviewed by Csaba Osztrogonác.
Adding an appropriate guard for fixing the build.
- bytecode/ResolveGlobalStatus.cpp:
(JSC):
- 5:56 AM WebKitGTK/WebKit2Roadmap edited by
- Move pending tasks to the new cycle (diff)
- 5:50 AM Changeset in webkit [126293] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, build fixup for r126291.
- Shared/WebPreferencesStore.h:
(WebKit):
- 5:48 AM Changeset in webkit [126292] by
-
- 5 edits in trunk
[EFL] Support slider tick mark snapping
https://bugs.webkit.org/show_bug.cgi?id=94560
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-22
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Increased the threshold for the EFL port. The value is snapped
when it clicked near tick mark.
No new tests. Covered by fast/forms/datalist/range-snap-to-datalist.html.
- platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::sliderTickSnappingThreshold):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
LayoutTests:
The expected result of fast/forms/datalist/range-snap-to-datalist.html
is updated because slider tick mark snapping threshold is changed.
- platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:
- 5:46 AM Changeset in webkit [126291] by
-
- 16 edits in trunk
[Qt] Optionally support smooth-scrolling on all platforms
https://bugs.webkit.org/show_bug.cgi?id=74926
Reviewed by Simon Hausmann.
Source/WebCore:
Make GestureAnimations depend on the GESTURE_ANIMATION feature flag,
since GestureAnimations are unused on some platforms.
- Target.pri:
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):
Source/WebKit/qt:
Expose the enable scroll animator setting.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
- Api/qwebsettings.h:
Source/WebKit2:
Expose scroll-animator preference, but ensure animated smooth scrolling
on the web process side is disabled when scrolling has been delegated
to the UI process.
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::updatePreferences):
Source/WTF:
Initialize GESTURE_ANIMATION feature flag.
- wtf/Platform.h:
Tools:
Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
setting in QtTestBrowser so it can be tested.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleScrollAnimator):
- QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):
- qmake/mkspecs/features/features.pri:
- 5:26 AM Changeset in webkit [126290] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Port convertQVariantToValue to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93889
Reviewed by Kenneth Rohde Christiansen.
Based on patch by Noam Rosenthal.
This patch is another step towards reducing the use of internal JSC API
in the Qt bridge. Most of the conversion from QVariant to JS values is
straight-forward. The biggest behavioural change is that QVariant lists
are converted on-the-spot instead of lazily. Bug #94691 tracks fixing
that.
- bridge/qt/qt_instance.cpp:
(Bindings):
(JSC::Bindings::QtField::valueFromInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::::valueAt):
- bridge/qt/qt_runtime.h:
(Bindings):
- 4:21 AM Changeset in webkit [126289] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Gardening after r126025 & r126275.
- platform/efl/TestExpectations: Unskipping one, skipping another.
- 3:59 AM Changeset in webkit [126288] by
-
- 9 edits in trunk/LayoutTests
Test and test expectation of Shadow DOM for button should be fixed.
https://bugs.webkit.org/show_bug.cgi?id=94674
Reviewed by Hajime Morita.
Now that the HTMLButtonElement was AuthroShadowDOM-ready, it's time to update the previous
failing tests for AuthroShadowDOM for button elements.
I've updated the failing tests to follow the current implementation and updated the test expectations.
- fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html:
- fast/dom/shadow/shadowdom-for-button-complex-shadow.html:
- fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html:
- fast/dom/shadow/shadowdom-for-button-only-shadow.html:
- fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html:
- fast/dom/shadow/shadowdom-for-button-without-shadow.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- 3:42 AM Changeset in webkit [126287] by
-
- 9 edits in trunk
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
https://bugs.webkit.org/show_bug.cgi?id=93897
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Before r125428 run-time methods (wrapped signals, slots or invokable
functions) were subclasses of JSInternalFunction and therefore real
function objects in the JavaScript sense. r125428 changed them to be
just callable objects, but they did not have Function.prototype as
prototype anymore for example nor was their name correct (resulting in
a layout test failure).
This patch changes run-time methods back to being real function objects
that have a correct name and have Function.prototype in their prototype
change
The objects returned by JSObjectMakeFunctionWithCallbackInjected are
light-weight internal function objects that do not support
JSObject{Set/Get}Private. Therefore we inject our own prototype right
before the Function.prototype prototype, which uses private data to
store a pointer to our C++ QtRuntimeMethod object. This complicates
the retrieval of the pointer to that instance slightly, which is why
this patch introduces the toRuntimeMethod convenience function that
looks up our prototype first and does a check for type-safety.
At the same time the patch removes the length properties from the
run-time method itself as well as connect/disconnect. The length
property on a function signifies the number of arguments, but in all
three cases that number is actually variable, because of overloading.
That is why we choose not to expose it in the first place.
In QtInstance we cache the JS wrapper objects for QtRuntimeMethod in a
JSWeakObjectMap. JSWeakObjectMap requires the stored objects to be
either the result of JSObjectMake or the global object of a context ref
(AFAICS), which is ensured using an ASSERT. Objects created via
JSObjectMakeFunctionWithCalllback do not fall into the required
category, cause a failing assertion and can therefore not be stored in
the weak object map.
Consequently this patch removes the use of JSWeakObjectMap again and
goes back to the old way of using the internal Weak<> API, for the time
being. In a future patch the storage will be simplified to not require
the use of a weak object map cache for the run-time methods anymore.
- bridge/qt/qt_instance.cpp: Remove unused WeakMap code.
- bridge/qt/qt_instance.h: Remove method cache.
(QtInstance):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
(Bindings):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod): Remove unused member variables.
Source/WebKit/qt:
Fixed some test expectations.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
can go back to testing Function.prototype.call, as it was done before r125428.
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
run-time methods back to being non-configurable, as before r125428.
LayoutTests:
- platform/qt/Skipped: Unskip test that is now passing.
- 3:37 AM Changeset in webkit [126286] by
-
- 12 edits in trunk
window.postMessage() / MessagePort.postMessage() throw wrong exception for invalid ports argument
https://bugs.webkit.org/show_bug.cgi?id=94581
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-22
Reviewed by Kentaro Hara.
Source/WebCore:
Update JSC and V8 implementations of window.postMessage() and
MessagePort.postMessage() in order to throw an
INVALID_STATE_ERR instead of a DATA_CLONE_ERR when values
in the "ports" argument are invalid. Additionally, we now
check for duplicate ports and throw an exception for this
case as well.
This change was made to comply with the latest HTML5
specification at:
http://www.w3.org/TR/html5/comms.html
No new tests, already tested by:
fast/events/constructors/message-event-constructor.html
fast/events/message-port-clone.html
fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
- dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):
LayoutTests:
Update several tests and their expected results now that an
INVALID_STATE_ERR is thrown instead of a DATA_CLONE_ERROR
when window.postMessage() / MessagePort.postMessage() are
called with invalid values in their 'ports' argument.
- fast/events/constructors/message-event-constructor-expected.txt:
- fast/events/constructors/message-event-constructor.html: Stop using duplicate
ports in the test since it throws an exception now.
- fast/events/message-port-clone-expected.txt:
- fast/events/message-port-multi-expected.txt:
- fast/events/resources/message-port-multi.js: Add check for duplicate port case.
- fast/workers/worker-context-multi-port-expected.txt:
- fast/workers/worker-multi-port-expected.txt:
- 3:30 AM Changeset in webkit [126285] by
-
- 2 edits1 delete in trunk/LayoutTests
Remove chromium/fast/js/array-functions-non-arrays-expected.txt and add WebKit bug id to chromium/TestExpectation.
https://bugs.webkit.org/show_bug.cgi?id=94682
Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-22
Reviewed by Kentaro Hara.
Only one failing test case remains in array-functions-non-arrays and it is being tracked by Bug 94681.
- platform/chromium/TestExpectations:
- platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Removed.
- 3:23 AM Changeset in webkit [126284] by
-
- 5 edits2 adds in trunk
[TouchAdjustment] Adjust to word or selection
https://bugs.webkit.org/show_bug.cgi?id=94449
Reviewed by Antonio Gomes.
Source/WebCore:
Makes each separate word a separate subtarget when context menu triggers
selections, and only the selected part of a partial selected node a
target when selections are not overridden.
Fix of reverted commit r126026, fix misplaced ASSERT.
Test: touchadjustment/context-menu-text-subtargets.html
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendQuadsToSubtargetList):
(WebCore::TouchAdjustment::appendBasicSubtargetsForNode):
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
LayoutTests:
Tests that touch-adjustment can adjust to the right subtargets within text-nodes.
- touchadjustment/context-menu-select-text.html:
- touchadjustment/context-menu-text-subtargets-expected.txt: Added.
- touchadjustment/context-menu-text-subtargets.html: Added.
- touchadjustment/resources/touchadjustment.js:
(pointToString):
(shouldBeWithin):
- 2:19 AM Changeset in webkit [126283] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Generic framework draft for tracking WebGL resources
https://bugs.webkit.org/show_bug.cgi?id=90597
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.
Wrap WebGL rendering context methods and collect a trace log if we are in capturing mode.
Stubbed code for collecting calls contributing to a WebGL resource state so that we could replay them later.
Typical scenario:
- we wrap a GL context with InjectedScript.wrapWebGLContext() and return a proxy to the inspected page
- the proxy saves all calls necessary to do a replay later - only those that modify a resource's state
- when we turn on capturing mode (InjectedScript.captureFrame), we save all WebGL calls to a trace log
- inspector/InjectedScriptSource.js:
(.):
- inspector/InjectedScriptWebGLModuleSource.js:
(.):
- 2:10 AM Changeset in webkit [126282] by
-
- 2 edits in trunk/LayoutTests
[Qt][GTK] REGRESSION(r126194): http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html fails
https://bugs.webkit.org/show_bug.cgi?id=94677
Unreviewed gardening.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-22
- platform/qt/Skipped:
- 2:09 AM Changeset in webkit [126281] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-22
- http/tests/inspector/console-resource-errors-expected.txt: Rebaseline after r126168.
- platform/qt/Skipped: Skip tests using disabled SHADOW_DOM feature.
- 1:50 AM Changeset in webkit [126280] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Add minimum transport protocol from backend to frontend
https://bugs.webkit.org/show_bug.cgi?id=88973
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.
Added the following protocol methods to communicate with the WebGL injected
module: captureFrame, getTraceLog, dropTraceLog, replayTraceLog.
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptWebGLModule.cpp:
(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::getTraceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):
- inspector/InjectedScriptWebGLModule.h:
(InjectedScriptWebGLModule):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):
- inspector/InspectorWebGLAgent.h:
(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):
- 1:47 AM Changeset in webkit [126279] by
-
- 2 edits in trunk/Source/WebCore
Remove unused field DeleteEntryRequest::m_type
https://bugs.webkit.org/show_bug.cgi?id=94680
Unreviewed build fix.
Remove this unused field. Clang warns about it and it breaks the
Chromium build.
No change in functionality, no new tests.
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
- 1:45 AM Changeset in webkit [126278] by
-
- 1 edit4 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline tests after http://trac.webkit.org/changeset/126219 .
These are the same results as platform/mac-lion, which until
r126219 were the results of platform/mac. So this is "reverting"
r126219 in terms of Chromium expectations.
- platform/chromium/fast/text/hyphenate-locale-expected.png: Added.
- platform/chromium/fast/text/hyphenate-locale-expected.txt: Added.
- platform/chromium/fast/text/justify-ideograph-vertical-expected.png: Added.
- platform/chromium/fast/text/justify-ideograph-vertical-expected.txt: Added.
- 1:44 AM Changeset in webkit [126277] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Avoid using WebKit macros in qrawwebview_p.h
https://bugs.webkit.org/show_bug.cgi?id=94648
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-08-22
Reviewed by Noam Rosenthal.
ENABLE(FEATURE) should not be used in qrawwebview_p.h because it is an API header file.
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::sendTouchEvent):
- UIProcess/API/qt/raw/qrawwebview_p.h:
- 1:42 AM Changeset in webkit [126276] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: console.time() should use performance.now()
https://bugs.webkit.org/show_bug.cgi?id=94263
Reviewed by Pavel Feldman.
- use monotonicallyIncreasingTime() instead of currentTime() for measuring time intervals
with console.time()/console.timeEnd()
- adjust precision to 3 digits after decimal point (i.e. microseconds) when formatting intervals;
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::stopTiming):
- 1:20 AM Changeset in webkit [126275] by
-
- 7 edits2 adds in trunk
Dynamically styling ShadowDom content on a node distributed to another shadow insertion point fails.
https://bugs.webkit.org/show_bug.cgi?id=92899
Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-22
Reviewed by Hajime Morita.
Source/WebCore:
Since childNeedsStyleRecalc is not cleared when parent nodes are
attached, setNeedsStyleRecalc flag is not reached Document. So,
document() doesn't run re-layout.
Test: fast/dom/shadow/shadowdom-dynamic-styling.html
- dom/ContainerNode.h:
(ContainerNode):
(WebCore::ContainerNode::detachAsNode):
Removed detachAsNode, because the below change made the method
not-used.
- dom/Element.cpp:
(WebCore::Element::detach):
Modify to invoke ContainerNode::detach when any shadow subtree is
attached. ContainerNode::detach takes care of childNeedsStyleRecalc
flag.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::invalidateDistribution):
Use SetAttached for lazyAttach instead of DoNotSetAttached, because
it is reuired to invoke ContainerNode::detach. If not, attached() is
false and reattach() invokes only attach(). This causes to leave
shadow host's childNeedsStyleRecalc flag true after
Element::recalcStyle.
LayoutTests:
- fast/dom/shadow/shadowdom-dynamic-styling-expected.txt: Added.
- fast/dom/shadow/shadowdom-dynamic-styling.html: Added.
- editing/shadow/delete-characters-in-distributed-node-crash.html:
Made the layout test robust. This patch causes commit-queue- and the
failed test is delete-characters-in-distributed-node-crash.html.
However the layout test passes when locally running run_webkit_test
i.e. no difference between actual and expected texts. And looking at
the commit-queue's report, the actual text has "PASS" message (no
crash messages).
- 1:11 AM Changeset in webkit [126274] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22
- DEPS:
- 12:50 AM Changeset in webkit [126273] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=91831
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-22
Reviewed by Vsevolod Vlasov.
InspectorAgent-side implementation of deleteEntry command.
Test will be added after JS-side implementation landed.
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::assertFrontend):
- inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.deletionCompleted):
- 12:49 AM Changeset in webkit [126272] by
-
- 2 edits in trunk/Tools
Unreviewed, adding myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 12:42 AM Changeset in webkit [126271] by
-
- 3 edits4 adds1 delete in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline tests after http://trac.webkit.org/changeset/126187 .
These are the same results as platform/mac-lion, which until
r126187 were the results of platform/mac. So this is "reverting"
r126187 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.
- platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
- platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt: Added.
- platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
- platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
- platform/chromium/TestExpectations:
- 12:31 AM Changeset in webkit [126270] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Update image expectations for these tests. The 'x' to clear out a
text field is slightly brighter on chromium-mac; this is not
material to the intent of the tests.
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- 12:24 AM Changeset in webkit [126269] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Add failure expectations for a regression in r126257. See
https://bugs.webkit.org/show_bug.cgi?id=94675
- platform/chromium/TestExpectations:
Aug 21, 2012:
- 11:58 PM Changeset in webkit [126268] by
-
- 9 edits in trunk
Web Inspector: TabbedPane: measure tab widths in batches.
https://bugs.webkit.org/show_bug.cgi?id=94484
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- Introduces global batch update schema
- Migrates Toolbar and TabbedPane to the new schema
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype._updateTabElements):
(WebInspector.TabbedPane.prototype._innerUpdateTabElements):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._measureWidths):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.width):
(WebInspector.TabbedPaneTab.prototype.setWidth):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
(WebInspector.Toolbar.prototype._innerUpdateDropdownButtonAndHideDropdown):
- inspector/front-end/UIUtils.js:
(WebInspector.startBatchUpdate):
(WebInspector.invokeOnceAfterBatchUpdate.get if):
(WebInspector.invokeOnceAfterBatchUpdate):
- inspector/front-end/inspector.js:
- inspector/front-end/utilities.js:
LayoutTests:
- inspector/start-end-batch-update-expected.txt: Added.
- inspector/start-end-batch-update.html: Added.
- inspector/tabbed-pane-tabs-to-show.html:
- 11:47 PM Changeset in webkit [126267] by
-
- 2 edits in trunk/Tools
[GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
https://bugs.webkit.org/show_bug.cgi?id=94669
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Carlos Garcia Campos.
Fix memory leaks in DRT's EventSender code.
- DumpRenderTree/gtk/EventSender.cpp:
(getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
(contextClickCallback): Use GOwnPtr to manage memory of a
newly-allocated list automatically.
- 11:43 PM Changeset in webkit [126266] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Restore expected results for Chromium after r126219. See
https://bugs.webkit.org/show_bug.cgi?id=94672 .
- platform/chromium/fast/text/emphasis-combined-text-expected.png: Added.
- platform/chromium/fast/text/emphasis-combined-text-expected.txt: Added.
- 10:46 PM Changeset in webkit [126265] by
-
- 1 edit4 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline tests after http://trac.webkit.org/changeset/126183 .
These are the same results as platform/mac-lion, which until
r126183 where the results of platform/mac. So this is "reverting"
r126183 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
- platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
- 10:19 PM Changeset in webkit [126264] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Fix TestExpectations syntax error WIN WIN7 => WIN.
- platform/chromium/TestExpectations:
- 10:04 PM Changeset in webkit [126263] by
-
- 1 edit5 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline tests after http://trac.webkit.org/changeset/126225 .
These are the same results as platform/mac-lion, which until
r126225 where the results of platform/mac. So this is "reverting"
r126225 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/chromium-mac/css2.1/t1202-counter-04-b-expected.txt: Added.
- platform/chromium-mac/css2.1/t1202-counters-04-b-expected.txt: Added.
- platform/chromium-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt: Added.
- 9:42 PM Changeset in webkit [126262] by
-
- 5 edits2 adds in trunk/Source/WebCore
[V8] Move String related code in V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=94571
Reviewed by Adam Barth.
This patch moves V8Parameter, V8ParameterBase and String related code
in V8Binding to a separate file.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
- bindings/v8/V8StringResource.cpp: Added.
- bindings/v8/V8StringResource.h: Added.
(WebCore):
- 9:36 PM Changeset in webkit [126261] by
-
- 1 edit8 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline tests after http://trac.webkit.org/changeset/126225 .
https://bugs.webkit.org/show_bug.cgi?id=94665 filed to track
optimization of these baselines.
- platform/chromium-linux-x86/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/chromium-linux/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/chromium-mac-snowleopard/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/chromium-mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/chromium-win-xp/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/chromium-win/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- 9:19 PM Changeset in webkit [126260] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening. Added file somehow missed by garden-o-matic in last rebaseline.
- platform/chromium/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
- 8:58 PM Changeset in webkit [126259] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Add test expectations for regression in r126250. See bug 94667.
- platform/chromium/TestExpectations:
- 8:56 PM Changeset in webkit [126258] by
-
- 16 edits8 adds in trunk
Implement UndoManager's automatic DOM transactions
https://bugs.webkit.org/show_bug.cgi?id=91812
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-21
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch implements automatic DOM transactions in UndoManager
by recording changes in tree structure, attributes, and character data
of nodes under undo scope host.
Tests: editing/undomanager/automatic-transaction-attribute.html
editing/undomanager/automatic-transaction-data.html
editing/undomanager/automatic-transaction-node.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMTransaction.h:
(WebCore::DOMTransaction::addTransactionStep):
(DOMTransaction):
- bindings/v8/DOMTransaction.cpp:
(DOMTransactionScope):
(WebCore::DOMTransactionScope::DOMTransactionScope):
(WebCore::DOMTransactionScope::~DOMTransactionScope):
(WebCore):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
- bindings/v8/DOMTransaction.h:
(WebCore::DOMTransaction::addTransactionStep):
(DOMTransaction):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
- dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
- dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::updateTreeAfterInsertion):
- dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
- editing/DOMTransactionStep.cpp: Added.
(WebCore):
(WebCore::NodeInsertingDOMTransactionStep::NodeInsertingDOMTransactionStep):
(WebCore::NodeInsertingDOMTransactionStep::create):
(WebCore::NodeInsertingDOMTransactionStep::unapply):
(WebCore::NodeInsertingDOMTransactionStep::reapply):
(WebCore::NodeRemovingDOMTransactionStep::NodeRemovingDOMTransactionStep):
(WebCore::NodeRemovingDOMTransactionStep::create):
(WebCore::NodeRemovingDOMTransactionStep::unapply):
(WebCore::NodeRemovingDOMTransactionStep::reapply):
(WebCore::DataReplacingDOMTransactionStep::DataReplacingDOMTransactionStep):
(WebCore::DataReplacingDOMTransactionStep::create):
(WebCore::DataReplacingDOMTransactionStep::unapply):
(WebCore::DataReplacingDOMTransactionStep::reapply):
(WebCore::AttrChangingDOMTransactionStep::AttrChangingDOMTransactionStep):
(WebCore::AttrChangingDOMTransactionStep::create):
(WebCore::AttrChangingDOMTransactionStep::unapply):
(WebCore::AttrChangingDOMTransactionStep::reapply):
- editing/DOMTransactionStep.h: Added.
(WebCore):
(DOMTransactionStep):
(WebCore::DOMTransactionStep::~DOMTransactionStep):
(NodeInsertingDOMTransactionStep):
(NodeRemovingDOMTransactionStep):
(DataReplacingDOMTransactionStep):
(AttrChangingDOMTransactionStep):
- editing/UndoManager.cpp:
(WebCore):
(WebCore::UndoManager::isRecordingAutomaticTransaction):
(WebCore::UndoManager::addTransactionStep):
- editing/UndoManager.h:
(WebCore):
(WebCore::UndoManager::setRecordingDOMTransaction):
(UndoManager):
LayoutTests:
- editing/undomanager/automatic-transaction-attribute-expected.txt: Added.
- editing/undomanager/automatic-transaction-attribute.html: Added.
- editing/undomanager/automatic-transaction-data-expected.txt: Added.
- editing/undomanager/automatic-transaction-data.html: Added.
- editing/undomanager/automatic-transaction-node-expected.txt: Added.
- editing/undomanager/automatic-transaction-node.html: Added.
- 8:35 PM Changeset in webkit [126257] by
-
- 7 edits in trunk
Fix cross-direction stretch for replaced elements in row flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237
Patch by Shezan Baig <Shezan Baig> on 2012-08-21
Reviewed by Ojan Vafai.
Source/WebCore:
When stretching, don't take into account the instrinsic size of child
replaced elements. Only the fixed size, min size, and max size of the
child should be taken into account. The logic that computed this was
moved from RenderBox::computeLogicalHeight to a new helper method
called logicalHeightConstrainedByMinMax. This helper method is now
used from RenderFlexibleBox::applyStretchAlignmentToChild, instead of
using RenderBox::computeLogicalHeight.
A similar change will need to be made for column-flowing flexboxes.
This will be addressed in https://webkit.org/b/94604.
No new tests. The existing css3/flexbox/flexitem.html test was
extended to cover this case.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::logicalHeightConstrainedByMinMax): New helper
method that is used by RenderBox::computeLogicalHeight and also by
RenderFlexibleBox::applyStretchAlignmentToChild.
(WebCore):
(WebCore::RenderBox::computeLogicalHeight): Updated to use the new
logicalHeightConstrainedByMinMax helper method.
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Use
logicalHeightConstrainedByMinMax instead of computeLogicalHeight.
LayoutTests:
Fix test cases for images stretching in the cross direction. Also,
added test cases for stretching/shrinking iframes, seamless iframes,
and also tests for vertically flowing flexboxes.
- css3/flexbox/flexitem-expected.txt:
- css3/flexbox/flexitem.html:
- 8:11 PM Changeset in webkit [126256] by
-
- 5 edits in trunk/Source/WebCore
Make an event object clonable to support an event propagation across seamless iframes.
https://bugs.webkit.org/show_bug.cgi?id=93678
Reviewed by Dimitri Glazkov.
We should clone an event object when a event propagates across
seamless iframes. Currently Event and MouseEvent are
supported. Support for other kinds of events will be addressed
later.
This is one of the pre-requirements to support an event
propagation across seamless iframes.
No new tests, no behavior change.
- dom/Event.cpp:
(WebCore::Event::cloneFor):
(WebCore):
- dom/Event.h:
(WebCore):
(Event):
- dom/MouseEvent.cpp:
(WebCore::adjustedClinetX):
(WebCore):
(WebCore::adjustedClinetY):
(WebCore::MouseEvent::cloneFor):
- dom/MouseEvent.h:
(MouseEvent):
- 8:10 PM Changeset in webkit [126255] by
-
- 1 edit28 adds in trunk/LayoutTests
Unreviewed Chromium gardening. Rebaseline tests after http://trac.webkit.org/changeset/126225 .
https://bugs.webkit.org/show_bug.cgi?id=94665 filed to track optimization of these baselines.
- platform/chromium-linux-x86/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium-linux-x86/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-linux-x86/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium-linux-x86/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/chromium-linux/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium-linux/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-linux/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium-linux/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/chromium-mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium-mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/chromium-win-xp/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium-win-xp/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-win-xp/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium-win-xp/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/chromium-win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium-win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium-win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- 7:43 PM Changeset in webkit [126254] by
-
- 7 edits5 adds in trunk
IndexedDB: IDBRequest can be GCd during event dispatch
https://bugs.webkit.org/show_bug.cgi?id=94235
Reviewed by Ojan Vafai.
Source/WebCore:
Avoid a "race" where GC may attempt to reclaim IDB objects that are marked
"done" prior to the completion of the event dispatch. The script runtime
may decide to do a GC pass before calling the event handler, releasing the
object and turning the dispatch into a no-op.
This is a partial reversion (with renames, etc) of r123275, r124842,
and r121492. Added a new test, although it does not exercise the "race"
condition directly.
Test: storage/indexeddb/pending-activity.html
storage/indexeddb/pending-activity-workers.html
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close): Let the IDBRequest know it this cursor won't
make it fire again.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest): Reintroduce "am I done?" flag.
(WebCore::IDBRequest::finishCursor): Cursors may fire events at the same
IDBRequest repeatedly, so we need to know when they're are really done.
(WebCore):
(WebCore::IDBRequest::hasPendingActivity): Test the flag.
(WebCore::IDBRequest::dispatchEvent): Set the flag.
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction): Reintroduce "am I done?" flag.
(WebCore::IDBTransaction::hasPendingActivity): Test the flag.
(WebCore::IDBTransaction::dispatchEvent): Set the flag.
- Modules/indexeddb/IDBTransaction.h:
LayoutTests:
Release references to IDBRequest and IDBTransaction objects and force GC,
to ensure that pending events are still fired. (Doesn't exercise race
condition where GC is triggered by script during dispatch itself, though.)
- storage/indexeddb/pending-activity-expected.txt: Added.
- storage/indexeddb/pending-activity-workers-expected.txt: Added.
- storage/indexeddb/pending-activity-workers.html: Added.
- storage/indexeddb/pending-activity.html: Added.
- storage/indexeddb/resources/pending-activity.js: Added.
(test):
(prepareDatabase.request.onsuccess.request.onsuccess.request.onsuccess):
(prepareDatabase.request.onsuccess.request.onsuccess):
(prepareDatabase.request.onsuccess):
(prepareDatabase):
(testTransaction):
(transactionOnComplete):
(testRequest):
(requestOnSuccess):
(testCursorRequest):
(cursorRequestOnFirstSuccess):
(cursorRequestOnSecondSuccess):
- 7:39 PM Changeset in webkit [126253] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [regression] Settings panel fails to open.
https://bugs.webkit.org/show_bug.cgi?id=94647
Unreviewed: one line JS front-end fix.
- inspector/front-end/ScriptsSearchScope.js:
- inspector/front-end/Settings.js:
- 7:17 PM Changeset in webkit [126252] by
-
- 3 edits in trunk/LayoutTests
range-hit-test-with-padding.html fails unless subpixel layout is on
https://bugs.webkit.org/show_bug.cgi?id=94585
Reviewed by Kent Tamura.
Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.
- fast/forms/range/range-hit-test-with-padding-expected.txt:
- fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.
- 7:16 PM Changeset in webkit [126251] by
-
- 4 edits2 adds in trunk
Crash in RenderTableSection::setCellLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=94291
Reviewed by Abhishek Arya.
Source/WebCore:
This issue was that splitAnonymousBoxesAroundChild would move a table section
into a newly created table *without* marking it as needing cell recalc. The table
would thus never build its structure to match its sections. The fix is to hop on
the new willBeRemovedFromTree signal so that the section invalidates itself properly.
Test: fast/table/crash-split-table-section-no-cell-recalc.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::willBeRemovedFromTree):
- rendering/RenderTableSection.h:
Replaced willBeDestroyed by willBeRemovedFromTree in RenderTableSection. This ensures that it is called
when moving sections in the tree to mark them as needing cell recalc.
LayoutTests:
- fast/table/crash-split-table-section-no-cell-recalc-expected.txt: Added.
- fast/table/crash-split-table-section-no-cell-recalc.html: Added.
- 7:05 PM Changeset in webkit [126250] by
-
- 5 edits in trunk
[Forms] multiple fields time input UI should not have two focus ring.
https://bugs.webkit.org/show_bug.cgi?id=94579
Reviewed by Hajime Morita.
Source/WebCore:
This patch adds CSS selectors to override focus style for multiple
fields time input UI.
No new tests. fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html
is updated for including focus state appearance.
- css/html.css:
(input::-webkit-datetime-edit-ampm-field:focus): Override default focus appearance.
(input::-webkit-datetime-edit-hour-field:focus): ditto
(input::-webkit-datetime-edit-millisecond-field:focus): ditto
(input::-webkit-datetime-edit-minute-field:focus): ditto
(input::-webkit-datetime-edit-second-field:focus): ditto
LayoutTests:
This patch adds a test case of focus appearance multiple fields time
input UI.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Added script to make focus appearance.
- fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Added script to set focus to input element.
- 6:50 PM Changeset in webkit [126249] by
-
- 14 edits1 add6 deletes in trunk
V8 shouldn't have its own way of printing cross-origin error messages
https://bugs.webkit.org/show_bug.cgi?id=94641
Reviewed by Eric Seidel.
Source/WebCore:
V8 used to re-implement (poorly) the code for printing out an error
message when a same-origin check failed. This patch deletes that code
in favor of just calling the WebCore version of the code. There more to
clean up here, but I had to stop before spidering over the whole
codebase.
- bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
- bindings/js/BindingState.cpp:
- bindings/js/BindingState.h:
- bindings/v8/BindingState.cpp:
(WebCore::printErrorMessageForFrame):
- bindings/v8/BindingState.h:
(WebCore):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportUnsafeJavaScriptAccess):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
LayoutTests:
Update these results to reflect the new error messages. These error
messages are both more correct and more like JavaScriptCore.
- platform/chromium/http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
- We don't use the private browsing setting to implement private browsing.
- platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
- platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
- platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt:
- platform/chromium/http/tests/security/xss-eval-expected.txt:
- Previously, we were incorrectly using the first script rather than the active script when printing the error message.
- platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
- platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
- platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
- platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
- platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
- platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
- These results are now identical to JSC.
- 6:47 PM Changeset in webkit [126248] by
-
- 6 edits2 adds in trunk
A shadow element in ShadowDOM of a button element does not work.
https://bugs.webkit.org/show_bug.cgi?id=91486
Reviewed by Dimitri Glazkov.
Source/WebCore:
Since a button element is extended from an HTMLFormControlElement, it creates a UserAgentShadowDOM
just before adding an AuthorShadowDOM. However, actually a button element does not need any UserAgentShadowDOM.
So we have to prevent it from creating UserAgentShadowDOM.
Test: fast/dom/shadow/shadowdom-for-button.html
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willAddAuthorShadowRoot):
(WebCore):
- html/HTMLButtonElement.h:
LayoutTests:
- fast/dom/shadow/shadowdom-for-button-expected.html: Added.
- fast/dom/shadow/shadowdom-for-button.html: Added.
- fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt:
- fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html: a button element
does not have user agent shadow dom anymore.
- 6:45 PM Changeset in webkit [126247] by
-
- 11 edits in trunk/Tools
Add mountain lion to perf-tests, layout tests
https://bugs.webkit.org/show_bug.cgi?id=94553
Reviewed by Adam Barth.
This patch adds support for the 'mac-mountainlion' platform and
stamps out the last references to 'mac-leopard' as a supported
name.
This patch does a small amount of refactoring to try and make
things a little clearer how we treat the "most recent version"
specially for baselines and skipped files, and so you only
should have to touch the VERSION_FALLBACK_ORDER constants on the
ports, but unfortunately changing this list changes a bunch of
the unit tests which are doing exact matches for correctness, so
you have to touch more than a couple files :(. There's probably
still more refactoring that can be done so that we don't have to
do all of this functional testing to feel completely correct.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_version):
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.init):
(ApplePort):
(ApplePort._skipped_file_search_paths):
(ApplePort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_mac):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort._build_driver_flags):
(MacPort.should_retry_crashes):
(MacPort.default_baseline_search_path):
(MacPort.operating_system):
(MacPort.default_child_processes):
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest):
(MacTest.test_skipped_file_search_paths):
(test_versions):
(test_baseline_search_path):
- Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort.default_baseline_search_path):
- 6:45 PM Changeset in webkit [126246] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Suppress crashes of new test.
- platform/chromium/TestExpectations:
- 6:42 PM Changeset in webkit [126245] by
-
- 13 edits2 adds4 deletes in trunk
Remove UndoManager's undoscope content attribute
https://bugs.webkit.org/show_bug.cgi?id=94637
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-21
Reviewed by Ryosuke Niwa.
Source/WebCore:
No new tests. Covered by existing tests.
- bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
- dom/Document.cpp:
(WebCore::Document::undoManager):
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore):
- dom/Element.h:
(Element):
- dom/Element.idl:
- dom/ElementRareData.h:
(ElementRareData):
- editing/UndoManager.cpp:
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
(WebCore):
- editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::document):
(WebCore::UndoManager::ownerNode):
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::setContentEditable):
LayoutTests:
- editing/undomanager/undomanager-reenter-expected.txt: Copied from LayoutTests/editing/undomanager/undomanager-use-after-free-expected.txt.
- editing/undomanager/undomanager-reenter.html: Copied from LayoutTests/editing/undomanager/undomanager-use-after-free.html.
- editing/undomanager/undomanager-use-after-free-expected.txt: Removed.
- editing/undomanager/undomanager-use-after-free.html: Removed.
- editing/undomanager/undoscope-attribute-expected.txt: Removed.
- editing/undomanager/undoscope-attribute.html: Removed.
- editing/undomanager/undoscopehost-use-after-free.html:
- 6:40 PM Changeset in webkit [126244] by
-
- 2 edits in trunk/LayoutTests
Skipping http/tests/inspector/console-resource-errors.html.
https://bugs.webkit.org/show_bug.cgi?id=94646.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-21
Reviewed by Brady Eidson.
Need to revert after https://bugs.webkit.org/show_bug.cgi?id=94640 is fixed.
- platform/mac/Skipped:
- 6:37 PM Changeset in webkit [126243] by
-
- 4 edits in trunk/Source
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-21
Reviewed by Chris Fleizach.
Part of the bug is due to objects which should claim to implement AtkText
failed to do so as a result of containing a mixture of inline and block
spans.
An updated unit test was provided.
Source/WebCore:
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(roleIsTextType): New method to check if a role is one expected to have
implemented the AtkText interface. Currently that is defined as:
- ParagraphRole
- HeadingRole
- DivRole
- CellRole
(getInterfaceMaskFromObject): If a role is one of the text type roles,
automatically add WAI_TEXT to the accessible object's interface mask.
Source/WebKit/gtk:
- tests/testatk.c:
(testWebkitAtkCaretOffsets): Added instances of objects containing a
mixture of inline and block spans and tested that they implement AtkText
and contain the right textual contents.
- 6:29 PM Changeset in webkit [126242] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r126216.
http://trac.webkit.org/changeset/126216
https://bugs.webkit.org/show_bug.cgi?id=94661
"Broke many Mac-WK2 tests" (Requested by bradee-oh on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
- WebProcess/com.apple.WebProcess.sb.in:
- 6:26 PM Changeset in webkit [126241] by
-
- 10 edits in trunk
Force XML comments to maintain whitespace
https://bugs.webkit.org/show_bug.cgi?id=94620
Reviewed by Pavel Feldman.
Source/WebCore:
Fix a typo in XMLViewer.css for white-space formatting. This seems
like the desired behavior so you can see, e.g., code formatted in an
XML comment.
Covered by existing xmlviewer tests in http/tests/xmlviewer/dumpAsText
- xml/XMLViewer.css:
(.comment): Fix typo.
- xml/XMLViewer.js:
(createComment): Add style to comment nodes.
LayoutTests:
Update comments to include whitespace formatting.
- http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
- http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
- http/tests/xmlviewer/dumpAsText/xul-expected.txt:
- platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:
- 6:11 PM Changeset in webkit [126240] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r126202.
http://trac.webkit.org/changeset/126202
https://bugs.webkit.org/show_bug.cgi?id=94657
Causes assertion failures on Chromium Linux dbg compositing
layout tests (Requested by dominicc on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
Source/WebCore:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::CCResourceProvider):
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(CCResourceProvider):
(WebCore::CCResourceProvider::Resource::Resource):
(Resource):
(CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::~CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::textureId):
(CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::~CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::textureId):
Source/WebKit/chromium:
- tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(WebKit::CCResourceProviderTest::getResourcePixels):
(WebKit::TEST_F):
- 6:08 PM Changeset in webkit [126239] by
-
- 8 edits in trunk
IndexedDB: Fire error at request when abort is called in upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=94402
Reviewed by Tony Chang.
Source/WebCore:
Tests - updated intversion-abort-in-initial-upgradeneeded-expected.txt
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndCompleteFired):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
Now that second-half open calls don't get abandoned on the queue, we
can ASSERT that there's at most one of them at any time.
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
Move setting m_didFireUpgradeNeededEvent before dispatching the event.
If abort is called in the event handler an error event will be
enqueued and ASSERT_WITH_MESSAGE(m_readyState == PENDING m_didFireUpgradeNeededEvent, ...) needs to pass.
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
LayoutTests:
- storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
Only remaining error in this test is versions not being reset in
memory.
- storage/indexeddb/resources/intversion-abort-in-initial-upgradeneeded.js:
(deleteSuccess):
(upgradeNeeded):
(onAbort):
(onError):
- 6:05 PM Changeset in webkit [126238] by
-
- 17 edits13 deletes in trunk
Unreviewed, rolling out r126233.
http://trac.webkit.org/changeset/126233
https://bugs.webkit.org/show_bug.cgi?id=94656
Broke Chromium Mac build (Requested by dominicc on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/mediaControls.css:
(video::-webkit-media-text-track-display):
- html/shadow/MediaControlElements.cpp:
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- html/track/TextTrack.cpp:
- html/track/TextTrack.h:
(TextTrack):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::calculateComputedLinePosition):
(WebCore::TextTrackCue::calculateDisplayParameters):
(WebCore::TextTrackCue::getDisplayTree):
(WebCore::TextTrackCue::getPositionCoordinates):
- html/track/TextTrackCue.h:
(WebCore):
(TextTrackCue):
- rendering/RenderTextTrackCue.cpp: Removed.
- rendering/RenderTextTrackCue.h: Removed.
LayoutTests:
- media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Removed.
- media/track/track-cue-rendering-horizontal.html: Removed.
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
- media/track/track-cue-rendering-vertical.html: Removed.
- media/video-test.js:
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Removed.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Removed.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Removed.
- platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
- platform/mac/media/track/track-cue-rendering-vertical-expected.png: Removed.
- platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Removed.
- 5:32 PM Changeset in webkit [126237] by
-
- 18 edits in trunk/Source/WebCore
[V8] Remove getToStringName() and getToStringTemplate() from V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94573
Reviewed by Adam Barth.
- Remove V8Binding::getToStringName() and V8Binding::getToStringTemplate().
- Replace getToStringName() with String::NewSymbol("toString").
- Fix V8PerIsolateData::getToStringTemplate() so that it caches a persistent
handle of a created FunctionTemplate. Before this patch, a FunctionTemplate
had been created for each toString().
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
(WebCore::constructorToString):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::ConfigureV8TestEventConstructorTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::ConfigureV8TestNamedConstructorTemplate):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
- bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):
- 5:25 PM Changeset in webkit [126236] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] WebGL Aquarium fails to render
https://bugs.webkit.org/show_bug.cgi?id=94634
The aquarium leaves with a glColorMask(false, false, false, true) which
caused us to fail to blit the color components of the aquarium to the
EGLImage.
Fixed by setting an appropriate color mask for a blit operation.
Reviewed by Yong Li.
No new tests, tested manually.
- platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):
- 5:23 PM Changeset in webkit [126235] by
-
- 4 edits in branches/safari-536.26-branch/Source
Versioning.
- 5:22 PM Changeset in webkit [126234] by
-
- 1 copy in tags/Safari-536.26.8
New tag.
- 5:19 PM Changeset in webkit [126233] by
-
- 17 edits15 adds in trunk
Display a TextTrackCue when snap-to-lines flag is set
https://bugs.webkit.org/show_bug.cgi?id=79751
Reviewed by Tony Chang.
Source/WebCore:
This patch implements rendering functionality for a given text track,
following closer the exact WebVTT specification. There are two new classes
which have been added in order to succesfully cover rendering when of a text
track cue.
RenderTextTrackCue handles the specific rendering algorithm required,
by checking for overlaps with other boxes that are in the same
container (these can be any other boxes, not necessarily other cues,
the video controls, for example).
TextTrackCueBox extends HTMLDivElement and is an intermediate layer
between the renderer class and the actual cue object. Its purpose is
to instantiate the particular renderer and cover all the default CSS
styling that needs to be applied to the cue.
The layout is done in two steps:
- Step 1: Layout the TextTrackCue with default CSS properties set (this is
the TextTrackCueBox decorated with the respective CSS elements)
- Step 2: RenderTextTrackCue adjusts the box position depending on the
parameters of the TextTrackCue object and the overlaps that may occur with
previously positioned cues.
Tests: media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
- CMakeLists.txt: Updated to include RenderTextTrackCue.
- GNUmakefile.list.am: Updated to include RenderTextTrackCue.
- Target.pri: Updated to include RenderTextTrackCue.
- WebCore.gypi: Updated to include RenderTextTrackCue.
- WebCore.vcproj/WebCore.vcproj: Updated to include RenderTextTrackCue.
- WebCore.xcodeproj/project.pbxproj: Updated to include RenderTextTrackCue.
- css/mediaControls.css: Removed unreliable CSS.
(video::-webkit-media-text-track-display): Removed properties.
- html/shadow/MediaControlElements.cpp: Updated to not use the new class.
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Simplified
the function by moving the check if track is rendered in TextTrack and used
the TextTrackCueBox for cues.
- html/track/TextTrack.cpp: Added a new method.
(WebCore::TextTrack::isRendered): Method that returns whether the track should
be rendered or not.
(WebCore):
- html/track/TextTrack.h: Added the isRendered method.
(TextTrack):
- html/track/TextTrackCue.cpp: Added several helper methods and
the TextTrackCueBox.
(WebCore):
(WebCore::TextTrackCueBox::TextTrackCueBox): The TextTrackCueBox extends
the HTMLDivElement and represents a bridge class between RenderTextTrackCue
and TextTrackCue. This is required as the layout is done in two steps, as
explained on top of the ChangeLog entry.
(WebCore::TextTrackCueBox::getCue): Returns the associated TextTrackCue object.
(WebCore::TextTrackCueBox::applyCSSProperties): Applies a part of the default CSS
properties, as defined by section 3.5.1 of the WebVTT specification.
(WebCore::TextTrackCueBox::shadowPseudoId): Moved the shadow pseudo id.
(WebCore::TextTrackCueBox::createRenderer): Creates the particular renderer.
(WebCore::TextTrackCue::TextTrackCue): Corrected the internal writing mode map.
(WebCore::TextTrackCue::calculateComputedLinePosition): Updated the compute line
position algorithm. This requires, however, a method to consider only rendered
tracks (and therefore will be addressed completely in subsequent changeset).
(WebCore::TextTrackCue::calculateDisplayParameters): Updated and corrected the
computed display parameters to match the current specification.
(WebCore::TextTrackCue::getDisplayTree): Update to use the TextTrackCueBox class
and moved CSS application to the respective class.
(WebCore::TextTrackCue::getPositionCoordinates): Added comment to specify in which
situation this method is used and change visibility to private.
(WebCore::TextTrackCue::getCSSWritingMode): Returns the CSS writing mode corresponding
to the cue writing mode.
(WebCore::TextTrackCue::getCSSSize): Returns the cue width / height (depending on the
writing direction.
(WebCore::TextTrackCue::getCSSPosition): Returns the default display position, that is
used in the first layout step.
- html/track/TextTrackCue.h:
(WebCore):
(TextTrackCueBox):
(WebCore::TextTrackCueBox::create): Initialization method.
(TextTrackCue):
(WebCore::TextTrackCue::getWritingDirection): Helper method to return the internal
values used to represent the writing direction.
- rendering/RenderTextTrackCue.cpp: Added.
(WebCore):
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
(WebCore::RenderTextTrackCue::layout): The rendering steps, as mentioned in
the WebVTT rendering rules. Currently, this treats only the snap-to-lines set
case. It is implemented following closely the spec, and might be subject to
change as discussions on various bugs evolve.
(WebCore::RenderTextTrackCue::initializeLayoutParameters): Steps 1 - 7.
(WebCore::RenderTextTrackCue::placeBoxInDefaultPosition): Steps 8 - 10.
(WebCore::RenderTextTrackCue::isOutside): Inline method to check if the cue is outside.
(WebCore::RenderTextTrackCue::isOverlapping): Inline method to check if the cue overlaps other boxes.
(WebCore::RenderTextTrackCue::shouldSwitchDirection): Step 12.
(WebCore::RenderTextTrackCue::moveBoxesByStep): Step 13.
(WebCore::RenderTextTrackCue::switchDirection): Steps 15 - 18.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Cue repositioning
for text track cue when the snap to lines flag is set.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Cue repositioning
for text track cue when the snap to lines flag is not set. Not implemented yet.
- rendering/RenderTextTrackCue.h: Added.
(WebCore):
(RenderTextTrackCue): Rendering class, handling the display of cues.
LayoutTests:
Test cases covering snap-to-lines horizontal and vertical positioning of cues.
- media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Added.
- media/track/track-cue-rendering-horizontal.html: Added.
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Updated.
- media/track/track-cue-rendering-vertical.html: Added.
- media/video-test.js: Updated to support pixel test dumps.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/chromium/TestExpectations: Marking these temporarily as IMAGE fail, as they will
anyway require new baselines.
- platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/mac/media/track/track-cue-rendering-vertical-expected.png: Added.
- platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Added.
- 5:18 PM Changeset in webkit [126232] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
https://bugs.webkit.org/show_bug.cgi?id=94621
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-21
Reviewed by Yong Li.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::enableQnxJavaScriptObject):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 5:18 PM Changeset in webkit [126231] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Memory leaks in TestWebKitFindController
https://bugs.webkit.org/show_bug.cgi?id=94627
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Martin Robinson.
Fix memory leaks in TestWebKitFindController by using adoptGRef
instead of just getting new reference of GdkPixbuf.
- UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide):
- 5:14 PM Changeset in webkit [126230] by
-
- 3 edits13 adds in trunk/Source/WebCore
[BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496
Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.
Add code to filter RSS content, and properly convert them to HTML
content so they can display nicely, instead of as plain text.
Following modules are included:
RSSFilterStream: the code for detecting RSS content, and controlling
the handling of these content.
RSSParserBase: the base class for the following 3 RSS parser.
RSS10Parser: the code for decoding RSS 1.0 content.
RSS20Parser: the code for decoding RSS 2.0 content.
RSSAtomParser: the code for decoding Atom format RSS content.
RSSGenerator: the code for generating HTML content based on RSS feed.
No new tests as it's not changing how HTML content is handled.
- PlatformBlackBerry.cmake:
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize):
- platform/network/blackberry/rss/RSS10Parser.cpp: Added.
(WebCore):
(WebCore::RSS10Parser::RSS10Parser):
(WebCore::RSS10Parser::parseBuffer):
(WebCore::RSS10Parser::parseXmlDoc):
(WebCore::RSS10Parser::parseItemBaseAttribute):
(WebCore::RSS10Parser::parseItem):
(WebCore::RSS10Parser::parseFeed):
- platform/network/blackberry/rss/RSS10Parser.h: Added.
(WebCore):
(RSS10Parser):
- platform/network/blackberry/rss/RSS20Parser.cpp: Added.
(WebCore):
(WebCore::RSS20Parser::RSS20Parser):
(WebCore::RSS20Parser::parseBuffer):
(WebCore::RSS20Parser::parseXmlDoc):
(WebCore::RSS20Parser::parseItemBaseAttribute):
(WebCore::RSS20Parser::parseItem):
(WebCore::RSS20Parser::parseFeed):
(WebCore::RSS20Parser::parseEnclosure):
- platform/network/blackberry/rss/RSS20Parser.h: Added.
(WebCore):
(RSS20Parser):
- platform/network/blackberry/rss/RSSAtomParser.cpp: Added.
(WebCore):
(WebCore::isRelativePath):
(WebCore::RSSAtomLink::relType):
(WebCore::RSSAtomParser::RSSAtomParser):
(WebCore::RSSAtomParser::parseBuffer):
(WebCore::RSSAtomParser::parseXmlDoc):
(WebCore::RSSAtomParser::parseItemBaseAttribute):
(WebCore::RSSAtomParser::parseItem):
(WebCore::RSSAtomParser::parseFeed):
(WebCore::RSSAtomParser::parseLink):
(WebCore::RSSAtomParser::enclosureFromLink):
(WebCore::RSSAtomParser::parseContent):
(WebCore::RSSAtomParser::parseAuthor):
(WebCore::RSSAtomParser::parseCategory):
- platform/network/blackberry/rss/RSSAtomParser.h: Added.
(WebCore):
(RSSAtomLink):
(WebCore::RSSAtomLink::RSSAtomLink):
(RSSAtomParser):
- platform/network/blackberry/rss/RSSFilterStream.cpp: Added.
(WebCore):
(WebCore::isASCIISpaceLowerByte):
(WebCore::stripWhiteSpace):
(WebCore::equalIgnoringCase):
(WebCore::isAtomMIMEType):
(WebCore::isRSSMIMEType):
(WebCore::isPotentialRSSMIMEType):
(WebCore::isRSSContent):
(WebCore::RSSTypeFromContentType):
(WebCore::RSSTypeFromContent):
(WebCore::createParser):
(WebCore::findXMLEncodingPosition):
(WebCore::findXMLLanguagePosition):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):
(WebCore::transcode):
(WebCore::transcodeContent):
(WebCore::RSSFilterStream::RSSFilterStream):
(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::notifyDataReceived):
(WebCore::RSSFilterStream::notifyClose):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::handleRSSContent):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::encoding):
(WebCore::RSSFilterStream::saveHeaders):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):
(WebCore::RSSFilterStream::sendSavedHeaders):
(WebCore::RSSFilterStream::appendData):
- platform/network/blackberry/rss/RSSFilterStream.h: Added.
(WebCore):
(RSSFilterStream):
- platform/network/blackberry/rss/RSSGenerator.cpp: Added.
(WebCore):
(WebCore::RSSGenerator::RSSGenerator):
(WebCore::RSSGenerator::~RSSGenerator):
(WebCore::RSSGenerator::generateHtml):
- platform/network/blackberry/rss/RSSGenerator.h: Added.
(WebCore):
(RSSGenerator):
- platform/network/blackberry/rss/RSSParserBase.cpp: Added.
(WebCore):
(WebCore::RSSEnclosure::RSSEnclosure):
(WebCore::RSSEnclosure::typeInEnum):
(WebCore::RSSEnclosure::suggestedName):
(WebCore::RSSFeed::RSSFeed):
(WebCore::RSSFeed::~RSSFeed):
(WebCore::RSSFeed::clear):
(WebCore::RSSItem::RSSItem):
(WebCore::RSSItem::~RSSItem):
(WebCore::RSSItem::clear):
(WebCore::RSSParserBase::RSSParserBase):
(WebCore::RSSParserBase::~RSSParserBase):
(WebCore::textFromXMLAttr):
(WebCore::textFromXMLNode):
- platform/network/blackberry/rss/RSSParserBase.h: Added.
(WebCore):
(RSSEnclosure):
(RSSItemBase):
(RSSParserBase):
- 5:14 PM Changeset in webkit [126229] by
-
- 4 edits in trunk
[GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
https://bugs.webkit.org/show_bug.cgi?id=94617
Reviewed by Martin Robinson.
Tools:
Set the 'enable-file-access-from-file-uris' setting to true when
resetting default values. The other ports do this as well, giving
documents with local security origin permission to load other
local resources.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests:
Remove failure expectation for fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
test as it now passes.
- platform/gtk/TestExpectations:
- 5:11 PM Changeset in webkit [126228] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
Introducing the VMInspector for VM debugging use.
https://bugs.webkit.org/show_bug.cgi?id=94613.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-21
Reviewed by Filip Pizlo.
Adding some utility functions for debugging the VM. This code is
presently #ifdef'd out by default.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/CallFrame.h:
(ExecState):
- interpreter/VMInspector.cpp: Added.
(JSC):
(JSC::VMInspector::getTypeName):
(JSC::VMInspector::dumpFrame0):
(JSC::VMInspector::dumpFrame):
(JSC::VMInspector::countFrames):
- interpreter/VMInspector.h: Added.
(JSC):
(VMInspector):
- 5:07 PM Changeset in webkit [126227] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent to main thread
https://bugs.webkit.org/show_bug.cgi?id=94600
Patch by Andrew Lo <anlo@rim.com> on 2012-08-21
Reviewed by Rob Buis.
http://trac.webkit.org/changeset/116792 implements destroying
DisplayRefreshMonitor after the number of unscheduled frames exceeds 10.
Part of that change involves dispatching to the main thread whether
the frame was scheduled or not.
Make the corresponding change for the BlackBerry port that was made for
DisplayRefreshMonitorMac.cpp.
Tests covered by http://trac.webkit.org/changeset/116792
- platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
- 5:06 PM Changeset in webkit [126226] by
-
- 2 edits in trunk/Source/WebCore
[Chromium/Skia] Filters should flush the SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=94602
Patch by Brian Salomon <bsalomon@google.com> on 2012-08-21
Reviewed by Stephen White.
Adds a SkCanvas::flush call to FilterBufferState::swap() to ensure the textures are updated before they are consumed by the compositor.
Covered by existing css3/filters layout tests.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
- 4:56 PM Changeset in webkit [126225] by
-
- 1 edit18 adds in trunk/LayoutTests
Rebaseline various tests for Mountain Lion that differ from the generic results.
Unreviewed (Bot gardening).
- platform/mac-lion/fast/css/pseudo-any-expected.txt: Added.
- platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
- platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
- platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
- platform/mac/fast/css/pseudo-any-expected.txt: Added.
- platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
- platform/mac/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
- platform/mac/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
- 4:55 PM Changeset in webkit [126224] by
-
- 1 edit4 adds in trunk/LayoutTests
[css3-text] Add repaint tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94480
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-21
Reviewed by Julien Chaffraix.
Changeset r125205 introduced new CSS3 property "-webkit-text-decoration-line".
This patch adds repaint layout tests for this property.
- fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Added.
- fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Added.
- fast/css3-text-decoration/repaint/repaint-text-decoration-line.html: Added.
Expected results generated from Chromium Linux build.
- 4:53 PM Changeset in webkit [126223] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Use new method to create socket handle
https://bugs.webkit.org/show_bug.cgi?id=89991
Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.
Update the way to create SocketStream as the platform API has changed.
No new tests as no change of behaviour, just API change adaptation.
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- 4:51 PM Changeset in webkit [126222] by
-
- 13 edits1 add in trunk/Source/WebCore
[V8] Move compileScript() from V8Proxy to ScriptSourceCode
https://bugs.webkit.org/show_bug.cgi?id=94561
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves compileScript() from V8Proxy
to ScriptSourceCode. This patch also removes fromWebCoreString().
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptSourceCode.cpp: Added.
(WebCore):
(WebCore::ScriptSourceCode::compileScript):
- bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
- bindings/v8/V8Binding.h:
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
- 4:48 PM Changeset in webkit [126221] by
-
- 1 edit in branches/chromium/1132/codereview.settings
update codereview settings
- 4:47 PM Changeset in webkit [126220] by
-
- 1 edit in branches/chromium/1229/codereview.settings
Update codereview settings
- 4:45 PM Changeset in webkit [126219] by
-
- 15 edits14 copies11 moves16 adds in trunk/LayoutTests
Rebaseline various tests for Mountain Lion where Mountain Lion specific results override current Lion specific results,
or in some cases match the generic results.
Unreviewed (Bot gardening).
- platform/mac-lion/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Renamed from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt.
- platform/mac-lion/css2.1/t1202-counter-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.png.
- platform/mac-lion/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
- platform/mac-lion/css2.1/t1202-counters-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.png.
- platform/mac-lion/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
- platform/mac-lion/fast/text/emphasis-combined-text-expected.png: Renamed from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.png.
- platform/mac-lion/fast/text/emphasis-combined-text-expected.txt: Copied from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.txt.
- platform/mac-lion/fast/text/fallback-traits-fixup-expected.png: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.png.
- platform/mac-lion/fast/text/fallback-traits-fixup-expected.txt: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.txt.
- platform/mac-lion/fast/text/hyphenate-locale-expected.png: Renamed from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png.
- platform/mac-lion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
- platform/mac-lion/fast/text/international/hindi-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.png.
- platform/mac-lion/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.png.
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.txt.
- platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.png.
- platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt.
- platform/mac-lion/fast/text/justify-ideograph-vertical-expected.png: Renamed from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.png.
- platform/mac-lion/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.txt.
- platform/mac-lion/http/tests/xmlhttprequest/web-apps/012-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt.
- platform/mac-lion/http/tests/xmlhttprequest/web-apps/013-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt.
- platform/mac-lion/media/audio-repaint-expected.png: Renamed from LayoutTests/platform/mac/media/audio-repaint-expected.png.
- platform/mac-lion/media/audio-repaint-expected.txt: Added.
- platform/mac-lion/media/video-size-intrinsic-scale-expected.txt: Renamed from LayoutTests/platform/mac/media/video-size-intrinsic-scale-expected.txt.
- platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Renamed from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png.
- platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt.
- platform/mac/css2.1/t1202-counter-04-b-expected.png:
- platform/mac/css2.1/t1202-counter-04-b-expected.txt:
- platform/mac/css2.1/t1202-counters-04-b-expected.png:
- platform/mac/css2.1/t1202-counters-04-b-expected.txt:
- platform/mac/fast/text/emphasis-combined-text-expected.txt:
- platform/mac/fast/text/fallback-traits-fixup-expected.png:
- platform/mac/fast/text/fallback-traits-fixup-expected.txt:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- platform/mac/fast/text/international/hindi-spacing-expected.png:
- platform/mac/fast/text/international/hindi-spacing-expected.txt:
- platform/mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
- platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt:
- 4:38 PM Changeset in webkit [126218] by
-
- 5 edits in trunk/Source/WebCore
[V8] Move toV8Context() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94597
Reviewed by Adam Barth.
To kill V8Proxy, we can move toV8Context() from V8Proxy to V8Binding.
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 4:37 PM Changeset in webkit [126217] by
-
- 8 edits3 adds in trunk/LayoutTests
Unreviewed gardening. Further rebaselining following r126110.
- platform/chromium-linux-x86/editing/selection: Added.
- platform/chromium-linux-x86/editing/selection/select-from-textfield-outwards-expected.txt: Added.
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-win-xp/editing/selection/select-from-textfield-outwards-expected.txt: Added.
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
- 4:31 PM Changeset in webkit [126216] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/11241850> Block access to xpcd in WebProcess.sb
Reviewed by Sam Weinig and Jon Honeycutt.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:30 PM Changeset in webkit [126215] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528
Patch by Gabriel Peal <gpeal@google.com> on 2012-08-21
Reviewed by Pavel Feldman.
Adds functionality to the inspector such that it is better suited to run embedded in another webpage. It adds the ability to prepopulate the timeline panel with an existing recording among other controls.
- English.lproj/localizedStrings.js:
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.dispatchQueryParameters):
(InspectorFrontendAPI.loadTimelineFromURL):
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
- inspector/front-end/InspectorView.js:
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.loadFromURL.onDataReceived):
(WebInspector.TimelineModel.prototype.loadFromURL.parseAndImportData):
(WebInspector.TimelineModel.prototype.loadFromURL.onLoad):
(WebInspector.TimelineModel.prototype.loadFromURL):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.loadFromURL):
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector.loaded):
- inspector/front-end/utilities.js:
- 4:30 PM Changeset in webkit [126214] by
-
- 8 edits3 adds in trunk
A patchable GetById right after a watchpoint should have the appropriate nop padding
https://bugs.webkit.org/show_bug.cgi?id=94635
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::padBeforePatch):
(AbstractMacroAssembler):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::patchableJump):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::moveWithPatch):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
(JSC::MacroAssemblerX86::storePtrWithPatch):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::moveWithPatch):
- jit/JumpReplacementWatchpoint.cpp:
(JSC::JumpReplacementWatchpoint::fireInternal):
LayoutTests:
- fast/js/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Added.
- fast/js/dfg-patchable-get-by-id-after-watchpoint.html: Added.
- fast/js/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Added.
(foo):
(O):
(O.prototype.f):
(P1):
(P2):
- 4:29 PM Changeset in webkit [126213] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/8900275> Remove PubSub access from WebProcess, since it is no longer necessary
Reviewed by Mark Rowe.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:24 PM Changeset in webkit [126212] by
-
- 2 edits in trunk/Tools
[Chromium] DRT produces wrong back-forward list
https://bugs.webkit.org/show_bug.cgi?id=94575
Reviewed by Adam Barth.
DRT clears its history state before running every tests. However
HistoryController in WebCore isn't reset. So, it is possible that
'isNewNavigation' flag is false even though the navigation should be
handled as "new" for DRT.
This change might fix a problem of
fast/forms/select/select-state-restore.html (Bug 90207).
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):
Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
Without this change, a navigation entry for this loading won't be recorded.
- 4:22 PM Changeset in webkit [126211] by
-
- 6 edits in trunk/Source
[BlackBerry] Add support for getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=94591
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-21
Reviewed by George Staikos.
Implement getUserMedia feature using the platform API.
Source/WebCore:
Tests in fast/mediastream cover this.
PR #153571
Reviewed internally by George Staikos.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::toWebMediaStreamSource):
(WebCore):
(WebCore::toWebMediaStreamDescriptor):
(WebCore::MediaPlayerPrivate::lookupMediaStream):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
Source/WebKit/blackberry:
PR #153571
Reviewed internally by George Staikos.
- WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore):
(WebCore::userMediaRequestsMap):
(WebCore::toMediaStreamSource):
(WebCore::toMediaStreamDescriptor):
(WebUserMediaRequestClientImpl):
(WebCore::WebUserMediaRequestClientImpl::WebUserMediaRequestClientImpl):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
(WebCore::WebUserMediaRequestClientImpl::requestFailed):
(WebCore::UserMediaClientImpl::UserMediaClientImpl):
(WebCore::UserMediaClientImpl::~UserMediaClientImpl):
(WebCore::UserMediaClientImpl::requestUserMedia):
(WebCore::UserMediaClientImpl::cancelUserMediaRequest):
(WebCore::UserMediaClientImpl::webUserMedia):
- WebCoreSupport/UserMediaClientImpl.h:
(BlackBerry):
(Platform):
(UserMediaClientImpl):
- 4:19 PM Changeset in webkit [126210] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: remove DOMNodeRemoved listener from the DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=94592
Reviewed by Yury Semikhatsky.
It seems to be not necessary.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
- 4:16 PM Changeset in webkit [126209] by
-
- 6 edits in trunk/Source/WebKit
[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=94586
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-21
Reviewed by Kentaro Hara.
Source/WebKit/blackberry:
Fix build error in the DeviceOrientationClientBlackBerry.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
- WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
(DeviceOrientationClientBlackBerry::lastOrientation):
Source/WebKit/efl:
Fix build error in the DeviceOrientationClientEfl.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
- WebCoreSupport/DeviceOrientationClientEfl.cpp:
(WebCore::DeviceOrientationClientEfl::lastOrientation):
Source/WebKit/gtk:
Fix build error in the DeviceOrientationClientGtk.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
- WebCoreSupport/DeviceOrientationClientGtk.cpp:
(WebKit::DeviceOrientationClientGtk::lastOrientation):
- 4:16 PM Changeset in webkit [126208] by
-
- 4 edits3 adds in trunk
WTF Threading leaks kernel objects on platforms that use pthreads
https://bugs.webkit.org/show_bug.cgi?id=94636
Reviewed by Geoffrey Garen.
Source/WTF:
Creating lots of Web workers on Mac platforms leaks lots of Mach ports. Eventually, the
process can exhaust its allocation of Mach ports from the kernel, which can then cause
all sorts of badness, including the inability to allocate new virtual memory from the
kernel. ThreadingPthreads.cpp and ThreadIdentifierDataPthreads.cpp need to be refactored
so that we do not leak these kernel resources. I would assume that we also leak kernel
resources on other pthreads platforms as well.
- wtf/ThreadIdentifierDataPthreads.cpp:
(WTF):
(WTF::ThreadIdentifierData::~ThreadIdentifierData): Now calls the event threadDidExit, which
handles all relevant tear-down of the thread metadata in the thread map.
- wtf/ThreadingPthreads.cpp: Added a new class called PthreadState that encapsulates the
state of a thread and the possible transitions between those states.
(PthreadState):
(WTF::PthreadState::PthreadState):
(WTF::PthreadState::joinableState): Returns the current state of the pthread.
(WTF::PthreadState::pthreadHandle): Returns the pthread_t for this particular thread. This needs to
remain valid even after the thread has exited because somebody could come along at any time in the
future and call join on the thread.
(WTF::PthreadState::didBecomeDetached): Signals that the thread was detached.
(WTF::PthreadState::didExit): Signals that the thread's exit destructor (~ThreadIdentifierData) has run.
(WTF::PthreadState::didJoin): Signals that the thread has been joined on successfully.
(WTF::PthreadState::hasExited): Returns whether or not the thread's exit destructor has run.
(WTF):
(WTF::identifierByPthreadHandle): Changed to also check hasExited() on the threads it finds in the map. We
should only have one valid pthread_t in the map, but there are other pthread_t's that need to remain in the
thread map for when somebody joins on that thread id later.
(WTF::establishIdentifierForPthreadHandle): Changed to put the allocate the new PthreadState data structure and
put it in the map.
(WTF::pthreadHandleForIdentifierWithLockAlreadyHeld):
(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion): We now do the relevant cleanup after the specified thread has been
successfully joined on depending on if the joined thread has already exited.
(WTF::detachThread): Performs relevant cleanup if the thread has already exited. Otherwise signals to the
PthreadState that the thread has been detached.
(WTF::threadDidExit): Function called by ~ThreadIdentifierData to indicate that the thread has exited.
Only cleans up after itself if the thread isn't Joinable (i.e. Joined or Detached).
LayoutTests:
Added a test that creates a bunch of workers that immediately return. This should stress
the new WTF threading code on platforms that use pthreads, so any major regressions in correctness
will probably cause this test to fail since it creates both joinable and detached threads.
- fast/js/create-lots-of-workers-expected.txt: Added.
- fast/js/create-lots-of-workers.html: Added.
- fast/js/resources/empty-worker.js: Added.
- 4:14 PM Changeset in webkit [126207] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Some public API functions don't have their symbols exported
https://bugs.webkit.org/show_bug.cgi?id=94589
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Kenneth Rohde Christiansen.
Added missing export symbol macro to these public API functions.
- UIProcess/API/efl/ewk_view.h:
- 4:09 PM Changeset in webkit [126206] by
-
- 2 edits in trunk/Source/WebCore
CodeGeneratorInspector.py: Generate guards for type validators
https://bugs.webkit.org/show_bug.cgi?id=94511
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Yury Semikhatsky.
Fix regression when building debug and one of the generated types is
disabled by a compile flag. We should generate guards for these type
validators the same way as we are doing on the include headers.
- inspector/CodeGeneratorInspector.py:
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
- 4:07 PM Changeset in webkit [126205] by
-
- 4 edits2 adds in trunk
ASSERT triggered in SVGTRefTargetEventListener::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=94487
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The current way of tracking tref target elements by id can leave stale event listeners
under certain circumstances. This patch switches to storing a target RefPtr instead
to avoid an id lookup which may not return the original/attached element.
Test: svg/custom/tref-stale-listener-crash.html
- svg/SVGTRefElement.cpp:
(SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::isAttached): use m_target instead of an explicit bool.
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::attach): save a target RefPtr instead of an id.
(WebCore::SVGTRefTargetEventListener::detach): detach the target element directly without
going through a lookup.
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::updateReferencedText): use an explicit target pointer instead of
the id-based lookup.
(WebCore::SVGTRefElement::buildPendingResource):
- svg/SVGTRefElement.h:
(SVGTRefElement):
LayoutTests:
- svg/custom/tref-stale-listener-crash-expected.txt: Added.
- svg/custom/tref-stale-listener-crash.html: Added.
- 4:06 PM Changeset in webkit [126204] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Find-in-page coordinates should use containingBlock
https://bugs.webkit.org/show_bug.cgi?id=94343
Reviewed by Julien Chaffraix.
The current implementation uses the container method to climb the render tree.
However, it would be more correct and convenient to use containingBlock instead.
Also, this patch introduces new tests for find-in-page coordinates in tables.
- src/FindInPageCoordinates.cpp:
(WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now.
(WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications.
- tests/WebFrameTest.cpp: add new tests for tables.
- tests/data/find_in_page.html:
- tests/data/find_in_page_frame.html: new tests for tables.
- 4:04 PM Changeset in webkit [126203] by
-
- 1 edit11 adds in trunk/LayoutTests
Rebaseline failing fast/canvas tests for Mountain Lion
Unreviewed (Bot gardening).
- platform/mac-lion/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/mac-lion/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/mac-lion/fast/canvas/canvas-strokePath-alpha-shadow-expected.txt: Added.
- platform/mac-lion/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/mac-lion/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/mac/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
- platform/mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- 4:00 PM Changeset in webkit [126202] by
-
- 8 edits in trunk/Source
[chromium] Add software bitmap resources to CCResourceProvider
https://bugs.webkit.org/show_bug.cgi?id=93677
Patch by Alexandre Elias <aelias@google.com> on 2012-08-21
Reviewed by Adrienne Walker.
This adds the ability to CCResourceProvider to use software bitmaps.
They are allocated as plain-old-memory, and exposed as Skia objects.
We want the ResourceProvider to be able to handle different resource
types at the same time. In practice, a default resource type is
desired for most uses within a single compositor instance, which is
specified by the default resource type. Default resource types are
expected to be mostly 1-to-1 with CCRenderer types.
New tests added by parametrizing existing CCResourceProvider tests.
Source/WebCore:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
- platform/graphics/chromium/LayerRendererChromium.h:
(DrawingFrame):
- platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore):
(WebCore::CCResourceProvider::createGLTexture):
(WebCore::CCResourceProvider::createBitmap):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::ScopedReadLockGL::ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::~ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::~ScopedWriteLockGL):
(WebCore::CCResourceProvider::populateSkBitmapWithResource):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::~ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::CCResourceProvider):
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(WebCore::CCResourceProvider::setCreationPolicy):
(WebCore::CCResourceProvider::creationPolicy):
(CCResourceProvider):
(ScopedReadLockGL):
(WebCore::CCResourceProvider::ScopedReadLockGL::textureId):
(ScopedWriteLockGL):
(WebCore::CCResourceProvider::ScopedWriteLockGL::textureId):
(ScopedReadLockSoftware):
(WebCore::CCResourceProvider::ScopedReadLockSoftware::skBitmap):
(ScopedWriteLockSoftware):
(WebCore::CCResourceProvider::ScopedWriteLockSoftware::skCanvas):
(Resource):
Source/WebKit/chromium:
- tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::getResourcePixels):
- 3:51 PM Changeset in webkit [126201] by
-
- 2 edits in trunk/Source/WebCore
Track -webkit property usage.
https://bugs.webkit.org/show_bug.cgi?id=93420
Patch by Tab Atkins <tabatkins@google.com> on 2012-08-21
Reviewed by Ojan Vafai.
First draft of an attempt to track all usage of -webkit prefixed properties across the web.
This attempt is dumb, but should provide useful data as a first-pass.
I plan to optimize this for better data collection in the future.
No tests added, as this is untestable currently.
It should have zero effect besides histogramming.
- css/CSSParser.cpp:
(WebCore::cssPropertyID):
- 3:49 PM Changeset in webkit [126200] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndDelete.
https://bugs.webkit.org/show_bug.cgi?id=93724
Patch by Oli Lan <olilan@chromium.org> on 2012-08-21
Reviewed by Ryosuke Niwa.
This adds two new methods to WebViewImpl.
1) setCompositionFromExistingText creates a new composition from the existing text
in the currently focused input field. The new composition is between the two offsets
provided, relative to the rootEditableElement. The current selection is left unchanged.
2) extendSelectionAndDelete extends the selection by the specified number of characters
before and after, and then deletes the selection. If the selection is just a caret, the effect
is to delete the specified number of characters before and after the current editing point.
These methods will be used e.g. by the Android port to implement IME functionality.
New tests WebViewTest.ExtendSelectionAndDelete and WebViewTest.SetCompositionFromExistingText
test the two new methods.
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setComposingRegion):
(WebKit):
(WebKit::extendSelectionAndDelete):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebViewTest.cpp:
- 3:41 PM Changeset in webkit [126199] by
-
- 10 edits in trunk/Source
IndexedDB: remove old update/openCursor glue
https://bugs.webkit.org/show_bug.cgi?id=94378
Patch by Alec Flett <alecflett@chromium.org> on 2012-08-21
Reviewed by Tony Chang.
Source/WebCore:
Remove old openCursor and update methods after landing
https://bugs.webkit.org/show_bug.cgi?id=91125 and removing
Chromium-side glue.
No new tests: this code is dead.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
Source/WebKit/chromium:
Remove Chromium/WebKit API for old methods that have now been
removed from chromium proper.
- public/WebIDBObjectStore.h:
- src/IDBObjectStoreBackendProxy.cpp:
- src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
- 3:35 PM Changeset in webkit [126198] by
-
- 4 edits in trunk/Source
[chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
https://bugs.webkit.org/show_bug.cgi?id=94631
Reviewed by Adrienne Walker.
Source/WebCore:
In the depths of time when dinosaurs roamed the earth, LayerChromium and CCLayerTreeHost were both reference
counted and there was a cycle between the root LayerChromium and CCLayerTreeHost. This required all users of
CCLayerTreeHost to manually break the cycle by calling setRootLayer(0) before dropping their reference to the
host. Nowadays, CCLayerTreeHost has a single owner and LayerChromiums only have a weak pointer to their host
so we should just do this cleanup ourselves instead of imposing it on callers.
Unit test added to LayerChromiumTest.cpp
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
Source/WebKit/chromium:
Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash.
- tests/LayerChromiumTest.cpp:
- 3:35 PM Changeset in webkit [126197] by
-
- 6 edits in trunk
[EFL] Enable CSS Text Decoration by default
https://bugs.webkit.org/show_bug.cgi?id=94483
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
Reviewed by Kenneth Rohde Christiansen.
.:
By enabling this feature by default, it will get tested by the bots
and we can make sure no regressions will happen.
- Source/cmake/OptionsEfl.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Remove test that will now pass from the skip list.
- platform/efl/TestExpectations:
- 3:32 PM Changeset in webkit [126196] by
-
- 8 edits2 adds in trunk
Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer constructed and destructed
https://bugs.webkit.org/show_bug.cgi?id=92993
Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-21
Reviewed by Kenneth Russell.
Call AdjustAmountOfExternalAllocatedMemory when V8ArrayBuffer
is constructed and destructed so that V8's garbage collection
heuristics can account for the memory held by these objects.
.:
- ManualTests/typed-array-memory.html: Added.
Source/WebCore:
- WebCore.gypi:
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBufferDeallocationObserver::instance):
(WebCore):
(WebCore::V8ArrayBuffer::constructorCallback):
- bindings/v8/custom/V8ArrayBufferCustom.h: Added.
(WebCore):
- bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
Source/WTF:
- wtf/ArrayBuffer.h:
(WTF):
(ArrayBufferDeallocationObserver):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBuffer::setDeallocationObserver):
(WTF::ArrayBufferContents::~ArrayBufferContents):
- 3:29 PM Changeset in webkit [126195] by
-
- 10 edits in trunk
Web Inspector: Completion events of InspectorFileSystemAgent should be fired asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=93933
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-21
Reviewed by Yury Semikhatsky.
InspectorFileSystemAgent fires completion event too early in error case. It should wait
until JS code is ready.
Source/WebCore:
Test: http/tests/inspector/filesystem/request-directory-content.html
http/tests/inspector/filesystem/request-file-content.html
http/tests/inspector/filesystem/request-metadata.html
- inspector/InspectorFileSystemAgent.cpp:
(WebCore): Add ReportErrorTask class
LayoutTests:
- http/tests/inspector/filesystem/request-directory-content-expected.txt:
- http/tests/inspector/filesystem/request-directory-content.html: Add more error case test.
- http/tests/inspector/filesystem/request-file-content-expected.txt:
- http/tests/inspector/filesystem/request-file-content.html: Add more error case test.
- http/tests/inspector/filesystem/request-filesystem-root-expected.txt:
- http/tests/inspector/filesystem/request-metadata-expected.txt:
- http/tests/inspector/filesystem/request-metadata.html: Add more error case test.
- 3:23 PM Changeset in webkit [126194] by
-
- 9 edits in trunk
Blocking a resource via Content Security Policy should trigger an Error event.
https://bugs.webkit.org/show_bug.cgi?id=89440
Patch by Mike West <mkwst@chromium.org> on 2012-08-21
Reviewed by Jochen Eisinger.
Source/WebCore:
If a CSP directive is violated, CachedResourceLoader will trigger a
console error, and return a null image. In that case, we now dispatch
an error on the relevant element.
Adjusted http/tests/security/contentSecurityPolicy/image-blocked.html
and http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
to test the new behavior.
This has the side-effect of also generating errors for images blocked by
Chromium's content settings. Adjusted
platform/chromium/permissionclient/image-permissions.html to agree with
the new behavior.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
LayoutTests:
- http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/image-blocked.html:
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt:
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html:
Adjusting existing tests to use the error event, as opposed to
hacking around the fact that it wasn't triggered.
- platform/chromium/permissionclient/image-permissions-expected.txt:
- platform/chromium/permissionclient/image-permissions.html:
Error events are now also generated for images blocked by Chromium's
content settings.
- 3:05 PM Changeset in webkit [126193] by
-
- 6 edits1 add in trunk/Source/WebCore
Web Inspector: Split out crumb list part of styles from elementsPanel.css
https://bugs.webkit.org/show_bug.cgi?id=94301
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-21
Reviewed by Pavel Feldman.
As a preparation to use BreadcrumbList on FileSystem, introduce breadcrumbList.css and
move crumb-related style entries into it from elementsPanel.css.
No new tests. This change does not make functional change.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/breadcrumbList.css: Added.
(.crumbs):
(.crumbs .crumb):
(.crumbs .crumb.collapsed > *):
(.crumbs .crumb.collapsed::before):
(.crumbs .crumb.compact .extra):
(.crumbs .crumb.dimmed):
(.crumbs .crumb.start):
(.crumbs .crumb.end):
(.crumbs .crumb.selected):
(.crumbs .crumb.selected:hover):
(.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
(.crumbs .crumb:hover):
(.crumbs .crumb.dimmed:hover):
(.crumbs .crumb.end:hover):
- inspector/front-end/elementsPanel.css:
- 3:02 PM Changeset in webkit [126192] by
-
- 7 edits2 deletes in trunk
canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails
https://bugs.webkit.org/show_bug.cgi?id=50797
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Andreas Kling.
Source/WebCore:
Add a check in fast-path parseAlphaValue() to return early
if the CSS <alphavalue> ended with an invalid digit.
Test: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html
- css/CSSParser.cpp:
(WebCore::parseAlphaValue):
LayoutTests:
Unskipped tests that are now passing after this fix and removed
wrong expectations.
- platform/chromium/TestExpectations:
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Removed.
- platform/qt/Skipped:
- 2:58 PM Changeset in webkit [126191] by
-
- 11 edits1 add in trunk
Store CString data in the CStringBuffer to avoid the double indirection
https://bugs.webkit.org/show_bug.cgi?id=94562
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-21
Reviewed by Darin Adler.
Source/Platform:
- chromium/src/WebCString.cpp:
(WebKit::WebCString::length): Update the length() computation following the changes
in CStringBuffer.
Source/WebCore:
- bindings/cpp/WebDOMCString.cpp:
(WebDOMCString::length): With the patch, CStringBuffer hold the real string length instead of the
size of the buffer including the terminating zero. WebDOMCString is updated accordingly.
Source/WTF:
Previously, any non-trivial CString would require two allocations:
1) CStringBuffer (ref-counted container for CString's data).
2) VectorBuffer's m_buffer (the actual char data).
This patches changes CStringBuffer to hold the data previously owned by
WTF::Vector and WTF::VectorBuffer. This makes CString more efficient
both in CPU time and memory use.
- wtf/text/CString.cpp:
(WTF::CStringBuffer::createUninitialized): This new method allocate the memory
for CStringBuffer and its data. We simply allocate more memory after CStringBuffer
to hold the data.
The extra memory needed to store the terminating zero is now handled by design.
(WTF::CString::CString): Move the test for "str" one level up the stack from CString::init().
This avoid double checking the pointer when using the other constructor.
(WTF::CString::init):
(WTF::CString::newUninitialized):
(WTF::CString::copyBufferIfNeeded):
- wtf/text/CString.h:
(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(CStringBuffer):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::length):
Tools:
Add test coverage for WTF::CString.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/CString.cpp:
- 2:52 PM Changeset in webkit [126190] by
-
- 139 edits in trunk/LayoutTests
Unreviewed gardening. Rebaselines following r126110.
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-linux/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/4895428-3-expected.png:
- platform/chromium-mac/editing/selection/4975120-expected.png:
- platform/chromium-mac/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
- platform/chromium-mac/fast/css/line-height-expected.png:
- platform/chromium-mac/fast/css/square-button-appearance-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/dom/isindex-001-expected.png:
- platform/chromium-mac/fast/dom/isindex-002-expected.png:
- platform/chromium-mac/fast/events/autoscroll-expected.png:
- platform/chromium-mac/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac/fast/forms/basic-buttons-expected.png:
- platform/chromium-mac/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/button-sizes-expected.png:
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/encoding-test-expected.png:
- platform/chromium-mac/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/input-align-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac/fast/forms/input-baseline-expected.png:
- platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac/fast/forms/input-spaces-expected.png:
- platform/chromium-mac/fast/forms/input-table-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-width-expected.png:
- platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac/fast/forms/text-style-color-expected.png:
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac/fast/html/details-open2-expected.png:
- platform/chromium-mac/fast/html/details-open4-expected.png:
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
- platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-mac/TestExpectations:
- 2:39 PM Changeset in webkit [126189] by
-
- 3 edits in trunk/Tools
Text Autosizing: ::first-letter pseudo-element is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=94540
Reviewed by Ojan Vafai.
Revert the changes in bugs 94517 and 94396 so that we are
actually looking for stderr output from ImageDiff and doing
image compares on ref tests on the wk2 ports again.
Also, do an actual diff_image() call if the hash checks fail on
reftests, and only fail the test if we get real diffs (or don't,
for mismatches).
Lastly, clean up the log messages to be more helpful.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._compare_output_with_reference):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
- 2:36 PM Changeset in webkit [126188] by
-
- 5 edits in trunk/Tools
_compare_image() swaps actual and expected images by mistake
https://bugs.webkit.org/show_bug.cgi?id=94567
Reviewed by Ojan Vafai.
Re-work the code so that we consistently pass (expected, actual)
across all of the compare/diff routines.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_compare_test):
(SingleTestRunner._compare_output):
(SingleTestRunner._compare_text):
(SingleTestRunner._compare_audio):
(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):
(SingleTestRunner._compare_output_with_reference):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
- 2:30 PM Changeset in webkit [126187] by
-
- 13 edits12 copies2 adds in trunk/LayoutTests
Rebaseline failing fast/writing-mode tests for Mountain Lion
Unreviewed (Bot gardening).
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png.
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png.
- platform/mac-lion/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt.
- platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.png.
- platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt.
- platform/mac-lion/fast/writing-mode/vertical-align-table-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.png.
- platform/mac-lion/fast/writing-mode/vertical-align-table-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt.
- platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png.
- platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt.
- platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-font-fallback-expected.png.
- platform/mac-lion/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt.
- platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
- platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
- platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
- platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.png:
- platform/mac/fast/writing-mode/vertical-baseline-alignment-expected.txt:
- platform/mac/fast/writing-mode/vertical-font-fallback-expected.png:
- platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
- 2:23 PM Changeset in webkit [126186] by
-
- 2 edits in trunk/Source/WebCore
Create CSS color output string on 8 bits
https://bugs.webkit.org/show_bug.cgi?id=94625
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-21
Reviewed by Andreas Kling.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
Previously, the output string for a CSS color was computed on 16 bits.
This was mainly forced by the use of String::number().
Since the double to string conversion is done on 8bits anyway, I changed
the code to use dtoa's numberToFixedPrecisionString directly instead of
String::number().
All the other parts were already on 8bits.
- 2:21 PM Changeset in webkit [126185] by
-
- 3 edits in trunk/Tools
Unreviewed. Move the commit-queue to building release only. Previously,
we built debug too, but for some reason the debug build doesn't work on
the bots. We can re-enable debug builds once we fix the underlying
problem.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.build_style):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 2:03 PM Changeset in webkit [126184] by
-
- 3 edits in trunk/Tools
TestExpectationsParser doesn't warn about test files that don't exist.
https://bugs.webkit.org/show_bug.cgi?id=94632
Reviewed by Dirk Pranke.
Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_line):
(TestExpectationParser._check_test_exists):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_warning):
- 1:35 PM Changeset in webkit [126183] by
-
- 9 edits8 copies8 moves2 adds in trunk/LayoutTests
Rebaseline failing editing/selection tests for mountain lion
https://bugs.webkit.org/show_bug.cgi?id=94629
Reviewed by Simon Fraser.
Move current Mac-specific results to platform/mac-lion and add Mountain Lion results to platform/mac
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png.
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt.
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png.
- platform/mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- 1:29 PM Changeset in webkit [126182] by
-
- 16 edits2 adds in trunk
[GTK] Using a native window for the WebView breaks GtkOverlay
https://bugs.webkit.org/show_bug.cgi?id=90085
Reviewed by Alejandro G. Castro.
.:
- configure.ac: Parse xcomposite pkg-config file during configuration.
Source/WebCore:
No new tests. This will be covered by pixel test for accelerated
compositing when they are activated.
- GNUmakefile.am: Add XComposite libraries to the linker list.
- GNUmakefile.list.am: Add RedirectedXCompositeWindow files to the source list.
Make a new section for GLX specific files.
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::sharedDisplay): Expose sharedDisplay as a static method
so that it can be called by other X11 specific code.
- platform/graphics/glx/GLContextGLX.h: Ditto.
- platform/gtk/RedirectedXCompositeWindow.cpp: Added. An implementation of a GL surface
that renders to an X-window which redirects to a pixmap.
- platform/gtk/RedirectedXCompositeWindow.h: Added.
Source/WebKit/gtk:
Rewrite AcceleratedCompositingContext for TextureMapperGL to be more similar to
the WebKit2 LayerTreeHost and switch from rendering directly to the widget window
to a window redirected to a pixmap via XComposite. The AcceleratedCompositingContext
now handles painting the non-composited content itself and no longer relies on the
ChromeClient backing store.
This fixes issues with using GtkOverlay WebKitWebView as well as making it possible
to run pixel tests with accelerated compositing turned on.
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Rename some methods to make them more similar to LayerTreeHost. Now we wait to render
the OpenGL context to the window until the widget's draw signal. Escape out of all
methods early if accelerated compositing is disabled.
- WebCoreSupport/ChromeClientGtk.cpp: Always check if accelerated compositing is on
before calling into AcceleratedCompositingContext methods. When AC is on, never paint
the backing store, deferring immediately to the AcceleratedCompositingContext. When
AC is turned on the backing store now shrinks to a small size to save memory.
- webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation): ChromeClient is now responsible for talking to the
AcceleratedCompositingContext directly.
(webkit_web_view_size_allocate): Exit early if the allocation is not a resize. This
makes some deeper logic a bit simpler and avoids accidentally doing too much work for
widget movement.
(webkit_web_view_realize): We no longer need a native window.
Source/WebKit2:
Add XComposite libraries to the linker list for WebKit2.
- GNUmakefile.am: Add XComposite
- 12:56 PM Changeset in webkit [126181] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] about:memory and about:memory-live should show numbers for the chrome process
https://bugs.webkit.org/show_bug.cgi?id=94531
Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>
PR: 190504
Add total committed memory of chrome process into about:memory and add
its peak into about:memory-live.
Internally reviewed by Yong Li and George Staikos.
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::clear):
(MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfCurrentProcess):
(BlackBerry::WebKit::MemoryTracker::peakTotalCommittedMemoryOfChromeProcess):
(BlackBerry::WebKit::MemoryTracker::MemoryTracker):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
- 12:44 PM Changeset in webkit [126180] by
-
- 2 edits in trunk/LayoutTests
[Chromium] context-creation-and-destruction layout tests are slow
https://bugs.webkit.org/show_bug.cgi?id=92287
Unreviewed; marked test slow on Linux as well.
- platform/chromium/TestExpectations:
- 12:17 PM Changeset in webkit [126179] by
-
- 2 edits in trunk/LayoutTests
fast/multicol/shrink-to-column-height-for-pagination.html fails on Mac WK2 bots
https://bugs.webkit.org/show_bug.cgi?id=94624
Unreviewed (Bot gardening).
- platform/mac-wk2/Skipped: Skip until we fix it.
- 12:12 PM Changeset in webkit [126178] by
-
- 3 edits in trunk/LayoutTests
[EFL] Layout tests gardening
https://bugs.webkit.org/show_bug.cgi?id=94594
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-21
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 11:15 AM Changeset in webkit [126177] by
-
- 9 edits in trunk/Source/WebCore
[New Multicolumn] Make column rules paint properly.
https://bugs.webkit.org/show_bug.cgi?id=94616
Reviewed by Simon Fraser.
Make the new multi-column code paint column rules and also prepare it for painting
the actual column contents.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
Remove the addRegionToThread call, since this is now done automatically in RenderRegion::insertedIntoTree.
- rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::flowThread):
Make public so that RenderMultiColumnSet can access it.
(RenderMultiColumnBlock):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnGap):
Add a column gap fetch method. It's identical to the one on RenderBlock (which will eventually go away
when we kill the old multi-column code).
(WebCore::RenderMultiColumnSet::columnRectAt):
Also identical to the RenderBlock version of this method. Gets the rect for the nth column.
(WebCore::RenderMultiColumnSet::paintReplaced):
Subclass paintReplaced in order to do column rules and contents painting.
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::paintColumnContents):
Similar to the methods on RenderBlock. The former paints the rules and the latter paints the contents of
the flow thread into the columns.
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Add the declarations of all the new methods.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::installFlowThread):
Added a new virtual function for installing flow threads when they didn't exist at construction time.
This only applies to actual CSS Regions, so the subclass of the method in RenderRegionSet just does
nothing.
(WebCore::RenderRegion::attachRegion):
Get the named flow thread code out of attachRegion, since it broke multi-column. Moved it into a
virtual function, installFlowThread, that is only used by actual CSS regions. Eventually we may
want a RenderRegion subclass that represents a region for a named flow thread only, but for now
let the code sit in installFlowThread in the base class.
- rendering/RenderRegion.h:
(RenderRegion):
Add installFlowThread declaration.
- rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::installFlowThread):
installFlowThread for region sets just does nothing, since we don't use named flow threads.
- rendering/RenderRegionSet.h:
(RenderRegionSet):
Add the override of installFlowThread.
- 11:10 AM Changeset in webkit [126176] by
-
- 5 edits in trunk/Tools
Move free functions in test_expectations to TestExpectations class
https://bugs.webkit.org/show_bug.cgi?id=94557
Reviewed by Dirk Pranke.
Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
to allow further refactoring.
- Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult.did_run_as_expected):
(JSONTestResult._tokenize):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
(TestExpectations.result_was_expected):
(TestExpectations.remove_pixel_failures):
(TestExpectations.has_pixel_failures):
(TestExpectations.suffixes_for_expectations):
(TestExpectations.matches_an_expected_result):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MockBugManager.create_bug):
(test_result_was_expected):
(test_remove_pixel_failures):
(test_suffixes_for_expectations):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations._tests_to_rebaseline):
- 11:00 AM Changeset in webkit [126175] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Build fix for !ENABLE(DRAG_SUPPORT).
- page/win/EventHandlerWin.cpp:
(WebCore):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
- 10:52 AM Changeset in webkit [126174] by
-
- 39 edits2 copies7 moves1 add3 deletes in trunk/Source
Unreviewed, rolling out r126170.
http://trac.webkit.org/changeset/126170
https://bugs.webkit.org/show_bug.cgi?id=94614
I spoke too soon
Source/Platform:
- chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
- chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
- chromium/public/WebIOSurfaceLayer.h:
(WebCore):
(WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
- chromium/public/WebImageLayer.h:
(WebCore):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebScrollableLayer.h: Copied from Source/Platform/chromium/public/WebScrollbarLayer.h.
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
- chromium/public/WebScrollbarLayer.h:
(WebCore):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebScrollbarLayer):
- chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
- chromium/public/WebVideoLayer.h:
(WebCore):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
Source/WebCore:
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::primaryLayer):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
- platform/graphics/chromium/LayerChromium.h:
Source/WebKit/chromium:
- WebKit.gypi:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
- src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp.
(WebKit):
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::clearClient):
(WebKit::WebContentLayer::setDoubleSided):
(WebKit::WebContentLayer::setContentsScale):
(WebKit::WebContentLayer::setUseLCDText):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
(WebKit):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit::WebExternalTextureLayer::setRateLimitContext):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
- src/WebExternalTextureLayerImpl.h: Removed.
- src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
- src/WebIOSurfaceLayerImpl.h: Removed.
- src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):
- src/WebLayer.cpp: Added.
(WebKit):
(WebKit::WebLayer::create):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::invalidateRect):
(WebKit::WebLayer::invalidate):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::setChildren):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::setDrawsContent):
(WebKit::WebLayer::drawsContent):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setUseParentBackfaceVisibility):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setFilters):
(WebKit::WebLayer::setBackgroundFilters):
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::setAnimationDelegate):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::hasActiveAnimation):
(WebKit::WebLayer::transferAnimationsTo):
(WebKit::WebLayer::setForceRenderSurface):
(WebKit::WebLayer::clearRenderSurface):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
- src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
- src/WebLayerImpl.h:
(WebLayerImpl):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
- src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
- src/WebScrollbarLayerImpl.h: Removed.
- src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h.
(WebKit):
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
- src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
- src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
- src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 10:51 AM Changeset in webkit [126173] by
-
- 8 edits2 adds in branches/safari-536.26-branch
Merge r122354 for <rdar://problem/12138142>.
- 10:47 AM Changeset in webkit [126172] by
-
- 2 edits in trunk/Source/WebCore
Update run-bindings-tests results after http://trac.webkit.org/changeset/126165
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
- 10:42 AM Changeset in webkit [126171] by
-
- 5 edits3 copies4 adds in trunk
Add parsing logic for allow-pointer-lock to iframe sandbox attribute.
https://bugs.webkit.org/show_bug.cgi?id=94513
Reviewed by Adam Barth.
Pointer lock was previously blocked from all sandboxed iframes.
Parsing the sandbox="allow-pointer-lock" attribute allows pages
to control the feature and enable it in sandboxed iframes.
Source/WebCore:
Tests: http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html
http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html
http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
LayoutTests:
- http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-expected.txt: Added.
- http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
- http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-expected.txt: Added.
- http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
- http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt: Added.
- http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html: Copied from LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html.
- http/tests/pointer-lock/iframe-sandboxed.html:
- http/tests/resources/pointer-lock/iframe-allows-inner-iframe.html: Added.
- http/tests/resources/pointer-lock/iframe-common.js:
(window.onmessage):
- 10:39 AM Changeset in webkit [126170] by
-
- 39 edits4 copies6 moves4 deletes in trunk/Source
Unreviewed, rolling out r126169.
http://trac.webkit.org/changeset/126169
https://bugs.webkit.org/show_bug.cgi?id=94614
Crashes already fixed downstream
Source/Platform:
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
- chromium/public/WebIOSurfaceLayer.h:
(WebIOSurfaceLayer):
- chromium/public/WebImageLayer.h:
(WebImageLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):
- chromium/public/WebScrollableLayer.h: Removed.
- chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
- chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):
- chromium/public/WebVideoLayer.h:
(WebVideoLayer):
Source/WebCore:
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
- platform/graphics/chromium/LayerChromium.h:
Source/WebKit/chromium:
- WebKit.gypi:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
- src/WebContentLayer.cpp: Removed.
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):
- src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.
(WebKit):
(WebExternalTextureLayerImpl):
- src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):
- src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):
- src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):
- src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
(WebCore):
(WebKit):
(WebImageLayerImpl):
- src/WebLayer.cpp: Removed.
- src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::id):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):
- src/WebLayerImpl.h:
(WebCore):
(WebLayerImpl):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebScrollableLayer.cpp: Removed.
- src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):
- src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
(WebCore):
(WebKit):
(WebScrollbarLayerImpl):
- src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):
- src/WebSolidColorLayerImpl.h:
(WebCore):
(WebKit):
(WebSolidColorLayerImpl):
- src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):
- src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 10:34 AM Changeset in webkit [126169] by
-
- 39 edits2 copies7 moves1 add3 deletes in trunk/Source
Unreviewed, rolling out r126076, r126099, and r126106.
http://trac.webkit.org/changeset/126076
http://trac.webkit.org/changeset/126099
http://trac.webkit.org/changeset/126106
https://bugs.webkit.org/show_bug.cgi?id=94614
Caused crashes during compositor shutdown in Aura builds of
Chromium (Requested by kbr_google on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
Source/Platform:
- chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
- chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
- chromium/public/WebIOSurfaceLayer.h:
(WebCore):
(WebIOSurfaceLayer):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
- chromium/public/WebImageLayer.h:
(WebCore):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebScrollableLayer.h: Copied from Source/Platform/chromium/public/WebScrollbarLayer.h.
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
- chromium/public/WebScrollbarLayer.h:
(WebCore):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebScrollbarLayer):
- chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
- chromium/public/WebVideoLayer.h:
(WebCore):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
Source/WebCore:
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::primaryLayer):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
- platform/graphics/chromium/LayerChromium.h:
Source/WebKit/chromium:
- WebKit.gypi:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
- src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp.
(WebKit):
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::clearClient):
(WebKit::WebContentLayer::setDoubleSided):
(WebKit::WebContentLayer::setContentsScale):
(WebKit::WebContentLayer::setUseLCDText):
(WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
(WebKit):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit::WebExternalTextureLayer::setRateLimitContext):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
- src/WebExternalTextureLayerImpl.h: Removed.
- src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
- src/WebIOSurfaceLayerImpl.h: Removed.
- src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):
- src/WebLayer.cpp: Added.
(WebKit):
(WebKit::WebLayer::create):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::invalidateRect):
(WebKit::WebLayer::invalidate):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::setChildren):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::setReplicaLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::setDrawsContent):
(WebKit::WebLayer::drawsContent):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setUseParentBackfaceVisibility):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setFilters):
(WebKit::WebLayer::setBackgroundFilters):
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):
(WebKit::WebLayer::setDebugName):
(WebKit::WebLayer::setAnimationDelegate):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::hasActiveAnimation):
(WebKit::WebLayer::transferAnimationsTo):
(WebKit::WebLayer::setForceRenderSurface):
(WebKit::WebLayer::clearRenderSurface):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
- src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
- src/WebLayerImpl.h:
(WebLayerImpl):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
- src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
- src/WebScrollbarLayerImpl.h: Removed.
- src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h.
(WebKit):
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
- src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
- src/WebSolidColorLayerImpl.h:
(WebSolidColorLayerImpl):
- src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 10:03 AM Changeset in webkit [126168] by
-
- 6 edits2 adds in trunk
Web Inspector: do not use window's eval in InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=94610
Reviewed by Yury Semikhatsky.
Source/WebCore:
Otherwise, inspector does not work when eval is overriden.
Test: inspector/console/console-eval-fake.html
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::evaluate):
(WebCore):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::evaluateCallback):
(WebCore):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
- inspector/console/console-eval-fake-expected.txt: Added.
- inspector/console/console-eval-fake.html: Added.
- 10:02 AM Changeset in webkit [126167] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accelerated In-Region Scrolling does not render correctly on rotation
https://bugs.webkit.org/show_bug.cgi?id=94608
PR #194754
Reviewed by Goerge Staikos.
Patch by Antonio Gomes <agomes@rim.com>
When one translates/scrolls a HW accelerated scrollable layer, it makes use of
the OVERRIDE mechanism. Suppose the following scenario:
- In landscape, the overflow menu is scrollable. Then the user scrolls it so
that is has scroll position of 0, -100.
- when he rotates to portrait, the menus fit well to the available space but it
still has the OVERRIDE set, so it keeps the layer translated at 0, -100.
Fix is simple: clear the override when we stop scrolling a HW accelerated layer,
when we destroy the objects.
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea):
- 10:02 AM Changeset in webkit [126166] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Properly notify WebKit when Client stops in-region scrolling
https://bugs.webkit.org/show_bug.cgi?id=94603
PR #195813
Reviewed by Goerge Staikos.
Patch by Antonio Gomes <agomes@rim.com>
Simplify the API to get a notification of when a in-region
scrolling has finished.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
Removed an unneeded parameter.
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStopped):
Ditto.
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 9:54 AM Changeset in webkit [126165] by
-
- 19 edits in trunk
Implement JSDOMWindow*::allowsAccessFrom* in terms of BindingSecurity
https://bugs.webkit.org/show_bug.cgi?id=93407
Reviewed by Eric Seidel.
Source/WebCore:
This patch removes allowsAccessFrom and implements the security checks
in terms of shouldAllowAccessToDOMWindow directly.
- bindings/generic/BindingSecurity.cpp:
(WebCore::BindingSecurity::shouldAllowAccessToDOMWindow):
(WebCore):
- bindings/generic/BindingSecurity.h:
(BindingSecurity):
- bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore):
(WebCore::shouldAllowAccessToDOMWindow):
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::shouldAllowAccessFrom):
(WebCore):
- bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):
- bindings/js/JSDOMWindowCustom.h:
- bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
LayoutTests:
These test results are now more similar (although not identical) to the
results for the V8 bindings.
- http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
- http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
- http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
- http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
- http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
- http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
- 9:43 AM Changeset in webkit [126164] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/12104508> TextIterator takes O(n2) to iterate over n empty blocks
https://bugs.webkit.org/show_bug.cgi?id=94429
Reviewed by Sam Weinig.
No new tests, because behavior is unchanged.
- editing/TextIterator.cpp:
(WebCore::TextIterator::shouldRepresentNodeOffsetZero): Enhanced the check for nodes that
cannot contain VisiblePosition to also check for zero-height blocks.
- 9:40 AM Changeset in webkit [126163] by
-
- 2 edits in trunk/LayoutTests
WKTR doesn't implement dumpWillCacheResponse().
https://bugs.webkit.org/show_bug.cgi?id=94607
Unreviewed (Bot gardening)
- platform/wk2/Skipped: Skip http/tests/misc/willCacheResponse-delegate-callback.html
- 9:32 AM Changeset in webkit [126162] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: break on exceptions decoration was lost, restoring.
Not reviewed - a follow up to 126012.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._pauseOnExceptionStateChanged.get switch):
(WebInspector.ScriptsPanel.prototype._pauseOnExceptionStateChanged):
- 9:21 AM Changeset in webkit [126161] by
-
- 7 edits in trunk
Unreviewed, rolling out r126146.
http://trac.webkit.org/changeset/126146
https://bugs.webkit.org/show_bug.cgi?id=94606
It made all tests assert (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
Source/WebCore:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod):
Source/WebKit/qt:
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods_data):
(tst_QObjectBridge::introspectQtMethods):
LayoutTests:
- platform/qt/Skipped:
- 9:17 AM Changeset in webkit [126160] by
-
- 11 edits in trunk/LayoutTests
MathML tests need rebaselining on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94393
Reviewed by Dan Bernstein.
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.txt:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- platform/mac/mathml/presentation/underover-expected.txt:
- 8:25 AM Changeset in webkit [126159] by
-
- 5 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r126150.
http://trac.webkit.org/changeset/126150
https://bugs.webkit.org/show_bug.cgi?id=94605
Breaks 73 layout tests on chromium.webkit builder (Requested
by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/V8Binding.cpp:
(StringTraits):
(WebCore):
(WebCore::v8StringToWebCoreString):
(WebCore::int32ToWebCoreStringFast):
(WebCore::int32ToWebCoreString):
- bindings/v8/V8Binding.h:
(WebCore):
(V8ParameterBase):
(WebCore::V8ParameterBase::operator String):
(WebCore::V8ParameterBase::operator AtomicString):
(WebCore::V8ParameterBase::V8ParameterBase):
(WebCore::V8ParameterBase::prepareBase):
(WebCore::V8ParameterBase::object):
(WebCore::V8ParameterBase::setString):
(WebCore::V8ParameterBase::toString):
(WebCore::::prepare):
- bindings/v8/V8StringResource.cpp: Removed.
- bindings/v8/V8StringResource.h: Removed.
- 8:15 AM Changeset in webkit [126158] by
-
- 2 edits in trunk/LayoutTests
media/media-document-audio-repaint.html is racy
https://bugs.webkit.org/show_bug.cgi?id=94454
Reviewed by Eric Carlson.
- media/media-document-audio-repaint.html: Don't rely on the play
event. Trigger the display and seek upon receipt of the pause event.
- 8:12 AM Changeset in webkit [126157] by
-
- 2 edits in trunk/Source/WebCore
Early returns in MediaPlayer setters
https://bugs.webkit.org/show_bug.cgi?id=87304
Calls to the MediaPlayerPrivate implementation can be avoided if
the value to set and the current value are equal.
Reviewed by Eric Carlson.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine): Once a new
MediaPlayerPrivate has been created propagate the playback rate
value to it, as it is done for some other attributes like preload
or preservePitch.
(WebCore::MediaPlayer::setVolume): Perform action only if current
and new values differ.
(WebCore::MediaPlayer::setMuted): Ditto.
(WebCore::MediaPlayer::setPreservesPitch): Ditto.
(WebCore::MediaPlayer::setSize): Ditto.
(WebCore::MediaPlayer::setVisible): Ditto.
(WebCore::MediaPlayer::setPreload): Ditto.
- 7:50 AM Changeset in webkit [126156] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: NMI: OwnPtr<T> was counted as RefPtr<T>
https://bugs.webkit.org/show_bug.cgi?id=94599
Reviewed by Yury Semikhatsky.
- dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryInstrumentation::addObjectImpl):
- 6:44 AM Changeset in webkit [126155] by
-
- 2 edits in trunk
Build fix for WinCE after r115348.
- Source/cmake/OptionsWindows.cmake: Removed duplicated WEBKIT_OPTION_DEFAULT_PORT_VALUE().
- 6:41 AM Changeset in webkit [126154] by
-
- 45 edits in trunk/Source
Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember.
https://bugs.webkit.org/show_bug.cgi?id=94580
Reviewed by Yury Semikhatsky.
Drive by fix: immutable ElementAttrybuteData uses the same trick with placement new as in StylePropertySet.
Source/WebCore:
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
- css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
- css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
- css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
- css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
- dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/ElementAttributeData.cpp:
(WebCore::immutableElementAttributeDataSize):
(WebCore):
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
- dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
- loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
- loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
Source/WebKit/chromium:
- tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
(WebCore):
- 6:22 AM Changeset in webkit [126153] by
-
- 2 edits in trunk/Source/WTF
Build fix for COMPILER(MSVC) && !CPU(X86) after r126023.
- wtf/MathExtras.h:
(lrint):
- 5:50 AM Changeset in webkit [126152] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Add destroy notify for register_uri_scheme
https://bugs.webkit.org/show_bug.cgi?id=94315
Reviewed by Philippe Normand.
For introspection to work correctly, a destroy notify needs to be
added to register_uri_scheme so that bindings know when to
finalize the user_data.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_register_uri_scheme):
(webkitWebContextReceivedURIRequest):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
- 5:21 AM WinCE edited by
- (diff)
- 4:03 AM Changeset in webkit [126151] by
-
- 2 edits in trunk/LayoutTests
Fix range-hit-test-with-padding.html by removing unnecessary part.
Unreviewed.
- fast/forms/range/range-hit-test-with-padding.html:
- 3:22 AM Changeset in webkit [126150] by
-
- 5 edits2 adds in trunk/Source/WebCore
[V8] Move String related code in V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=94571
Reviewed by Adam Barth.
This patch moves V8Parameter, V8ParameterBase and String related code
in V8Binding to a separate file.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
- bindings/v8/V8StringResource.cpp: Added.
- bindings/v8/V8StringResource.h: Added.
(WebCore):
- 2:50 AM Changeset in webkit [126149] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening. Skip new failing tests.
Reviewed Csaba Osztrogonác.
Patch by János Badics <János Badics> on 2012-08-21
- platform/qt/Skipped:
- 2:49 AM Changeset in webkit [126148] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 1:54 AM Changeset in webkit [126147] by
-
- 5 edits in trunk
Source/WebKit2: Unreviewed build fix for newer Qt 5: QT += qmltest does not imply QT += testlib anymore, but
the code here needs QSignalSpy from QTestLib
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
- UIProcess/API/qt/tests/qmltests/WebView.pro:
Tools: Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
self-contained. The module name is not appended automatically anymore.
- qmake/qt_webkit.pri:
- 1:54 AM Changeset in webkit [126146] by
-
- 7 edits in trunk
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
https://bugs.webkit.org/show_bug.cgi?id=93897
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Before r125428 run-time methods (wrapped signals, slots or invokable functions) were subclasses of
JSInternalFunction and therefore real function objects in the JavaScript sense. r125428 changed them
to be just callable objects, but they did not have Function.prototype as prototype anymore for example
nor was their name correct (resulting in a layout test failure).
This patch changes run-time methods back to being real function objects that have a correct name and
have Function.prototype in their prototype change
The objects returned by JSObjectMakeFunctionWithCallbackInjected are light-weight internal function objects
that do not support JSObject{Set/Get}Private. Therefore we inject our own prototype right before the
Function.prototype prototype, which uses private data to store a pointer to our C++ QtRuntimeMethod object.
This complicates the retrieval of the pointer to that instance slightly, which is why this patch introduces
the toRuntimeMethod convenience function that looks up our prototype first and does a check for type-safety.
At the same time the patch removes the length properties from the run-time method itself as well as connect/disconnect.
The length property on a function signifies the number of arguments, but in all three cases that number is
actually variable, because of overloading. That is why we choose not to expose it in the first place.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
(Bindings):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
- bridge/qt/qt_runtime.h:
(QtRuntimeMethod): Remove unused member variables.
Source/WebKit/qt:
Fixed some test expectations.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
can go back to testing Function.prototype.call, as it was done before r125428.
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
run-time methods back to being non-configurable, as before r125428.
LayoutTests:
- platform/qt/Skipped: Unskip test that is now passing.
- 1:28 AM Changeset in webkit [126145] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
fast/js/random-array-gc-stress.html has started to flakily crash in
release builds as well, so expanding the expectation.
The fast/forms/range/range-hit-test-with-padding.html test has been
failing since introduced in 126132. Adding a text expectation.
Marking one more frame flattening test as flaky.
Skipping two calendar picker tests. The feature is currently unsupported
and the tests take half a minute to run, so it's not really worth it.
- platform/gtk/TestExpectations:
- 1:12 AM Changeset in webkit [126144] by
-
- 1 edit2 adds in trunk/LayoutTests
Add another interesting test that used to fire a different ASSERT before we fixed https://bugs.webkit.org/show_bug.cgi?id=36427:
ASSERT(parents.size() >= depth + 1)
https://bugs.webkit.org/show_bug.cgi?id=84793
Reviewed by Abhishek Arya.
- fast/xpath/xpath-detached-import-assert-expected.txt: Added.
- fast/xpath/xpath-detached-import-assert.html: Added.
- 1:06 AM Changeset in webkit [126143] by
-
- 1 edit in trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
Quick build fix for the build fix ;(
- 1:04 AM Changeset in webkit [126142] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for newer Qt 5 versions: QVariant::WidgetStar has been removed,
but fortunately QMetaType has a much more powerful function available for us to use.
Thanks to Jedrzej Nowacki for the hint :)
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
- 12:33 AM Changeset in webkit [126141] by
-
- 10 edits in trunk/Source/WebCore
[V8] Remove String::New() from V8 binding (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=94574
Reviewed by Adam Barth.
Currently, V8 binding mixes String::New(), String::NewSymbol() and v8String().
String::New() should be replaced with String::NewSymbol() or v8String(),
depending on use cases:
- If it is a symbol (e.g. attribute name, constant string, etc),
String::NewSymbol() should be used. Cache of created symbols is managed by V8.
- If it is not a symbol, v8String() should be used. Cache of created strings
is managed by V8 binding (i.e. StringCache class).
This patch replaces String::New() for symbols with String::NewSymbol().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(WebCore::V8DOMConfiguration::configureAttribute):
- 12:24 AM Changeset in webkit [126140] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r126028.
http://trac.webkit.org/changeset/126028
https://bugs.webkit.org/show_bug.cgi?id=94576
it broke compilation on apple webkit win. (Requested by loislo
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptWebGLModule.cpp:
(WebCore::InjectedScriptWebGLModule::captureFrame):
- inspector/InjectedScriptWebGLModule.h:
(InjectedScriptWebGLModule):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
- inspector/InspectorWebGLAgent.h:
(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):
- 12:17 AM Changeset in webkit [126139] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: NMI: wrong size was reported for immutable StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=94489
Reviewed by Yury Semikhatsky.
Immutable StylePropertySet is created via placement new.
The rest of the allocated buffer is used as an array of CSSProperty.
This means that we don't need to report m_properties member but have to report actual size of the buffer
used for both, the object and CSSProperty array.
- css/StylePropertySet.cpp:
(WebCore::immutableStylePropertySetSize):
(WebCore):
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::reportMemoryUsage):
- dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
Aug 20, 2012:
- 11:50 PM Changeset in webkit [126138] by
-
- 2 edits in trunk/Tools
[Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
https://bugs.webkit.org/show_bug.cgi?id=94558
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.run_test):
- 11:50 PM Changeset in webkit [126137] by
-
- 7 edits in trunk/Source/WebCore
[V8] Move handleOutOfMemory() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94563
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves handleOutOfMemory() from V8Proxy to V8Binding.
No tests. No change in behavior.
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8Binding.cpp:
(WebCore::handleOutOfMemory):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::runScript):
- 11:49 PM Changeset in webkit [126136] by
-
- 6 edits in trunk/Source/WebCore
InsertionShouldCallDidNotifyDescendantInsertions should be merged to InsertionShouldCallDidNotifySubtreeInsertions
https://bugs.webkit.org/show_bug.cgi?id=94570
Reviewed by Ryosuke Niwa.
Node::didNotifySubtreeInsertions() and Node::didNotifyDescendantInsertions() are used for similar purpose and
we could unify them to the safer one, which is didNotifySubtreeInsertions().
This change replaces the last didNotifyDescendantInsertions() implementation in HTMLBodyElement with didNotifySubtreeInsertions()
then eliminates related code which is no longer used.
No new tests. Covered by existing tests.
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
- dom/Node.h: Removed didNotifyDescendantInsertions() stub and InsertionShouldCallDidNotifyDescendantInsertions enum value.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifySubtreeInsertions): morphed from didNotifyDescendantInsertions()
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto): Remove useless InsertionShouldCallDidNotifyDescendantInsertions return statement.
- 10:56 PM Changeset in webkit [126135] by
-
- 4 edits in trunk/Tools
Cleanup TestExpectationParser.parse
https://bugs.webkit.org/show_bug.cgi?id=94545
Reviewed by Dirk Pranke.
Refactor TestExpectations to simplify the code.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.parse): Merged _tokenize_list.
(TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
since the check is now done in _parser_modifiers.
(TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
(TestExpectationParser._tokenize_line): Renamed from _tokenize.
(TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
This is done on a local variable in _parse_modifiers, preserving the original case.
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
of 'rebaseline' against parsed modifiers.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(TestExpectationParserTests._tokenize):
(TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
(TestExpectationSerializerTests._tokenize):
(TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
been merged into parse.
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_csv): Preserves the case.
- 10:45 PM Changeset in webkit [126134] by
-
- 2 edits in trunk/Source/WebCore
Reduce GradientAttributes object size
https://bugs.webkit.org/show_bug.cgi?id=86151
Patch by Rob Buis <rbuis@rim.com> on 2012-08-20
Reviewed by Eric Seidel.
This reduces GradientAttributes in memory size by 8 bytes on my 64-bit system. It also
reduces the size of RenderSVGResourceLinearGradient and RenderSVGResourceRadialGradient.
- svg/GradientAttributes.h:
(WebCore::GradientAttributes::spreadMethod):
(WebCore::GradientAttributes::gradientUnits):
(GradientAttributes):
(WebCore):
(SameSizeAsGradientAttributes):
- 10:01 PM Changeset in webkit [126133] by
-
- 2 edits in trunk/Tools
[jhbuild] EFL now runs jhbuild update for every build
https://bugs.webkit.org/show_bug.cgi?id=94267
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-08-20
Reviewed by Martin Robinson.
Try to fix WinCE build by returning the empty string instead of
env when no jhbuild infrastructure is found.
- Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):
- 9:27 PM Changeset in webkit [126132] by
-
- 4 edits2 adds in trunk
Clicking input type=range with padding or border sets wrong value
https://bugs.webkit.org/show_bug.cgi?id=94473
Reviewed by Kent Tamura.
Source/WebCore:
We should take the padding and border width into account when calculating the value from the mouse location.
Test: fast/forms/range/range-hit-test-with-padding.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderTrackElementOf):
(WebCore):
(WebCore::SliderThumbElement::setPositionFromPoint):
- html/shadow/SliderThumbElement.h:
(WebCore):
LayoutTests:
- fast/forms/range/range-hit-test-with-padding-expected.txt: Added.
- fast/forms/range/range-hit-test-with-padding.html: Added.
- 9:21 PM Changeset in webkit [126131] by
-
- 6 edits2 adds in trunk
load event shouldn't fired during node insertion traversals.
https://bugs.webkit.org/show_bug.cgi?id=94447
Reviewed by Ryosuke Niwa.
Source/WebCore:
HTMLFrameElementBase::didNotifyDescendantInsertions() with empty @src
can trigger a load event during ChildNodeInsertionNotifier
traversal, whose handler can make DOM tree state inconsistent.
This change introduces a post traversal hook,
didNotifySubtreeInsertions(), for the insertion traversal and
replaces the problematic didNotifyDescendantInsertions() with it.
Since didNotifySubtreeInsertions() is invoked after the traversal,
it is safe for event handlers to mutate the tree.
Test: fast/frames/iframe-onload-and-domnodeinserted.html
- dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier): Added a post subtree notification.
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
- dom/Node.h:
(WebCore::Node::didNotifySubtreeInsertions): Newly added.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto): Now returns InsertionShouldCallDidNotifySubtreeInsertions
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Replaced didNotifyDescendantInsertions()
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
LayoutTests:
- fast/frames/iframe-onload-and-domnodeinserted-expected.txt: Added.
- fast/frames/iframe-onload-and-domnodeinserted.html: Added.
- 8:57 PM Changeset in webkit [126130] by
-
- 3 edits in trunk/Source/WebCore
Regression(r126127): Build break on multiple platforms
https://bugs.webkit.org/show_bug.cgi?id=94568
Reviewed by Hajime Morita.
Notation::cloneNode should also have ExceptionCode. We add it in this patch.
No new tests, no change in behavior.
- dom/Notation.cpp:
(WebCore::Notation::cloneNode):
- dom/Notation.h:
(Notation):
- 8:52 PM Changeset in webkit [126129] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix broken non-JIT build.
https://bugs.webkit.org/show_bug.cgi?id=94564.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-20
Reviewed by Filip Pizlo.
Added some UNUSED_PARAM() macros to make the compiler happy.
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- 8:38 PM Changeset in webkit [126128] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Select popup shows blank content when its option tags contain '\' characters
https://bugs.webkit.org/show_bug.cgi?id=94321
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-08-20
Reviewed by George Staikos.
PR 194224
When the SelectPopupClient generates HTML, if there is a character '\' in the select options'
description, we should escape it to avoid the character being interpreted as an escape character.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
- 8:22 PM Changeset in webkit [126127] by
-
- 26 edits2 adds in trunk
ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704
Reviewed by Dimitri Glazkov.
Source/WebCore:
According to the spec, ShadowRoot.cloneNode() should throw a DATA_CLONE_ERR exception. The existing implementation
returned null object instead.
We change the cloneNode() interface so that we can throw an exception from cloneNode().
Test: fast/dom/shadow/shadowroot-clonenode.html
- dom/Attr.cpp:
(WebCore::Attr::cloneNode):
- dom/Attr.h:
- dom/CDATASection.cpp:
(WebCore::CDATASection::cloneNode):
- dom/CDATASection.h:
(CDATASection):
- dom/Comment.cpp:
(WebCore::Comment::cloneNode):
- dom/Comment.h:
(Comment):
- dom/Document.cpp:
(WebCore::Document::cloneNode):
- dom/Document.h:
(Document):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::cloneNode):
- dom/DocumentFragment.h:
(DocumentFragment):
- dom/DocumentType.cpp:
(WebCore::DocumentType::cloneNode):
- dom/DocumentType.h:
(DocumentType):
- dom/Element.cpp:
(WebCore::Element::cloneNode):
- dom/Element.h:
(Element):
- dom/EntityReference.cpp:
(WebCore::EntityReference::cloneNode):
- dom/EntityReference.h:
(EntityReference):
- dom/Node.h:
(Node):
(WebCore::Node::cloneNode):
- dom/Node.idl:
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::cloneNode):
- dom/ProcessingInstruction.h:
(ProcessingInstruction):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/Text.cpp:
(WebCore::Text::cloneNode):
- dom/Text.h:
(Text):
LayoutTests:
- fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
- fast/dom/shadow/shadowroot-clonenode.html: Added.
- 8:04 PM Changeset in webkit [126126] by
-
- 5 edits in trunk/Source
[Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=94281
Reviewed by Hajime Morita.
Source/WebCore:
Tests: Add some cases to Source/WebKit/chromium/tests/LocaleWinTest.cpp
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::isLocalizedDigit): A helper for parseNumber(). This
return true if the specified character is one of native digits.
(WebCore::LocaleWin::parseNumber):
Try to parse ASCII digits, then try to parse native digtis. This
becomes a member of LocaleWin because it uses
convertFromLocalizedNumber().
(WebCore::LocaleWin::appendNumber): Apply convertToLocalizedNumber().
(WebCore::LocaleWin::appendTwoDigitsNumber): ditto.
(WebCore::LocaleWin::appendFourDigitsNumber): ditto.
- platform/text/LocaleWin.h:
(LocaleWin):
- Make some static functions member functions of LocaleWin.
- Add isLocalizedDigit().
Source/WebKit/chromium:
- tests/LocaleWinTest.cpp:
(TEST_F): Added formatting and parsing tests for Persian locale to check
native digit behavior.
- 7:59 PM Changeset in webkit [126125] by
-
- 2 edits in trunk/Tools
Add a watcher for WTF changes
Unreviewed.
Add myself as a watcher for changes in WTF.
- Scripts/webkitpy/common/config/watchlist:
- 7:49 PM Changeset in webkit [126124] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Improved how a few test
expectations were merged together in r126117.
- platform/chromium/TestExpectations:
- 7:47 PM Changeset in webkit [126123] by
-
- 4 edits in trunk/Source/WebCore
Rename collectGarbageIfNecessary() to hintForCollectGarbage()
https://bugs.webkit.org/show_bug.cgi?id=94455
Reviewed by Adam Barth.
This is a follow-up patch for r126098.
collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends
an idle notification to V8, which is just a hint for V8 to trigger GC.
To clarify the difference, this patch renames collectGarbageIfNecessary()
to hintForCollectGarbage().
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearForNavigation):
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::hintForCollectGarbage):
- bindings/v8/V8GCController.h:
(V8GCController):
- 7:35 PM Changeset in webkit [126122] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Texture layer should not generate zero textureId quads
https://bugs.webkit.org/show_bug.cgi?id=94550
Patch by Alexandre Elias <aelias@google.com> on 2012-08-20
Reviewed by Adrienne Walker.
After a context loss, CCTextureLayerImpl would clear its textureId
but continued to produce external resources and quads with the zero
textureid. Add early returns so that CCTextureLayerImpl becomes
inert after a context loss.
Added assertion in read lock so that dontUseOldResourcesAfterLostContext
test catches the problem.
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore::CCScopedLockResourceForRead::CCScopedLockResourceForRead):
- platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::didDraw):
(WebCore::CCTextureLayerImpl::didLoseContext):
- 7:33 PM Changeset in webkit [126121] by
-
- 7 edits1 add in trunk/Source
[Chromium] Make the popup positioning code testable
https://bugs.webkit.org/show_bug.cgi?id=94086
Reviewed by Hajime Morita.
Source/WebCore:
Introduce PopupContent interface in order to make a mock.
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRectInternal):
- Make it a member of PopupContainer to avoid namespace pollution.
- Use PopupContent interface.
- Make the code clearer.
- platform/chromium/PopupContainer.h:
(PopupContainer): Expose layoutAndCalculateWidgetRectInternal.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::popupContentHeight): Added.
- platform/chromium/PopupListBox.h:
(PopupContent): Added.
(PopupListBox): Inherit PopupContent.
(WebCore::PopupListBox::~PopupListBox):
Make this virtual because this class has some virtual functions.
Source/WebKit/chromium:
- WebKit.gypi: Add PopupContainerTest.cpp.
- tests/PopupContainerTest.cpp: Added.
(MockPopupContent):
(calculatePosition):
(TEST):
- 7:11 PM Changeset in webkit [126120] by
-
- 4 edits3 adds in trunk
XSSAuditor too tolerant of injected data: URLs from other "hostless" schemes.
https://bugs.webkit.org/show_bug.cgi?id=94547
Reviewed by Adam Barth.
Source/WebCore:
Check that there is a host before making same-host tests.
Test: fast/frames/xss-auditor-handles-file-urls.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::isLikelySafeResource):
- html/parser/XSSAuditor.h:
LayoutTests:
- fast/frames/resources/static-xss-vector.html: Added.
- fast/frames/xss-auditor-handles-file-urls-expected.txt: Added.
- fast/frames/xss-auditor-handles-file-urls.html: Added.
- 7:03 PM Changeset in webkit [126119] by
-
- 5 edits in trunk/Source/WebCore
Removed dead code from a very old iteration of CSS counters.
https://bugs.webkit.org/show_bug.cgi?id=94539
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-20
Reviewed by Eric Seidel.
Remove two unused shorts that were on StyleRareNonInheritedData that are no longer used.
No tests, this just removes dead code.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- 7:00 PM Changeset in webkit [126118] by
-
- 5 edits in trunk
Fix inspector with variables enabled and enable inspector variables tests by default.
https://bugs.webkit.org/show_bug.cgi?id=94296
Reviewed by Hajime Morita.
Source/WebCore:
Change from using getPropertyName static function to CSSProperty::cssName(), which can resolve variables if needed.
Covered by inspector/styles/variables.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
LayoutTests:
Fix paths to included javascript and enable tests by default on Chromium port.
- inspector/styles/variables/css-variables.html:
- platform/chromium/TestExpectations:
- 6:59 PM Changeset in webkit [126117] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fixed lint errors in TestExpectations after r126110.
- platform/chromium/TestExpectations:
- 6:50 PM Changeset in webkit [126116] by
-
- 2 edits in trunk/Source/WebCore
Cancel the outstanding vibration pattern if the pattern is 0 or an empty list
https://bugs.webkit.org/show_bug.cgi?id=94085
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-20
Reviewed by Kentaro Hara.
vibrate() method to stop the device from vibrating is getting called before the
vibration is in effect. Hence, it is failing to cancel the pre-existing instance
of processing vibration patterns.
This patch cancel the pre-existing instance of the processing vibration patterns
always when the vibrate() method called with pattern 0 or an empty list.
No new tests since there is no return value in the Vibration API to test this
particular case. Existing test fast/dom/navigator-vibration.html covers testing of
the Vibration API.
- Modules/vibration/Vibration.cpp:
(WebCore::Vibration::vibrate):
- 6:30 PM Changeset in webkit [126115] by
-
- 3 edits3 copies in branches/chromium/1229
Merge 125852
- 6:28 PM Changeset in webkit [126114] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix warnings on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=94543
Patch by Scott Graham <scottmg@chromium.org> on 2012-08-20
Reviewed by Adrienne Walker.
- tests/CCMathUtilTest.cpp:
- 6:14 PM Changeset in webkit [126113] by
-
- 8 edits in trunk/Source
Allow MutationEvents to be enabled/disabled per context
https://bugs.webkit.org/show_bug.cgi?id=94016
Reviewed by Ojan Vafai.
Source/WebCore:
Chromium wants to be able to turn MutationEvents off for some
Documents (e.g., for Apps V2). This patch makes the firing (and the
constructor on DOMWindow) of MutationEvents a per-context feature, with
the default being enabled.
No functional change (since the feature defaults to enabled).
It's not clear to me that there's a way to test this in DRT without
adding a special hook for this one feature. It will be tested in
Chromium once it's implemented in Chromium.
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::mutationEventsEnabled): Add new method,
with the default being enabled.
- dom/ContextFeatures.h:
- dom/Document.cpp:
(WebCore::Document::addMutationEventListenerTypeIfEnabled): Add new
method that checks the ContextFeature flag before adding the passed-in
listener type.
(WebCore::Document::addListenerTypeIfNeeded): Call the new method
instead of addListenerType for MutationEvent types.
- dom/Document.h:
(WebCore::Document::addListenerType): Make private to avoid anyone
outside Document from enabling MutationEvent listeners. All callers
must go through addListenerTypeIfNeeded.
Source/WebKit/chromium:
Add Chromium/WebKit API for enabling/disabling MutationEvents via
WebPermissionClient.
- public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowMutationEvents):
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
- 6:01 PM Changeset in webkit [126112] by
-
- 4 edits2 copies in branches/chromium/1229
Merge 125869 - Source/WebCore: libwebp-0.2.0: handle alpha channel if present
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
updated the Layout test webp-image-decoding.html
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
(outputMode):
switch to premultiplied-RGB if needed
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::decode):
use WebPGetFeatures() instead of WebPGetInfo(),
to detect presence of alpha channel
- platform/image-decoders/webp/WEBPImageDecoder.h:
(WEBPImageDecoder):
add a m_hasAlpha field
LayoutTests: update layout test for new libwebp-0.2.0
https://bugs.webkit.org/show_bug.cgi?id=93430
Patch by Pascal Massimino <pascal.massimino@gmail.com> on 2012-08-17
Reviewed by Adam Barth.
- fast/images/resources/test2.webp: Added.
lossy+alpha example
- fast/images/resources/test3.webp: Added.
lossless with alpha example
- fast/images/webp-image-decoding-expected.txt:
- fast/images/webp-image-decoding.html:
Updated test. Will now decode test2.webp and test3.webp too.
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10860057
- 6:00 PM Changeset in webkit [126111] by
-
- 8 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r126095.
http://trac.webkit.org/changeset/126095
https://bugs.webkit.org/show_bug.cgi?id=94555
Breaks compilation of downstream WebWidget::paint
implementations (Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-20
- public/WebWidget.h:
(WebKit::WebWidget::paint):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::paint):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
(WebViewImpl):
- 5:59 PM Changeset in webkit [126110] by
-
- 131 edits in trunk
[Sub-pixel Layout] Block selection gap repainting can leave one pixel gaps
https://bugs.webkit.org/show_bug.cgi?id=94526
Reviewed by Eric Seidel.
Source/WebCore:
Reverting RenderLayer's m_blockSelectionGapsBounds to be an IntRect and applying enclosingIntRect to the
gapRects added to the bounds. Previously, we'd end multiple block gaps and pixel snap the result, which
can yield results one pixel off in width and height.
Covered by existing tests. This undoes some of the rebaselining from when sub-pixel was enabled for Chromium.
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
LayoutTests:
Correcting pixel gap repainting reverts a bunch of chromium expectations to their pre-sub-pixel layout
versions. This largely triggers 1-pixel image diffs in input fields.
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-mac/editing/pasteboard/4806874-expected.png:
- platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/4895428-3-expected.png:
- platform/chromium-mac/editing/selection/4975120-expected.png:
- platform/chromium-mac/editing/selection/drag-select-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png:
- platform/chromium-mac/fast/css/line-height-expected.png:
- platform/chromium-mac/fast/css/square-button-appearance-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/dom/isindex-001-expected.png:
- platform/chromium-mac/fast/dom/isindex-002-expected.png:
- platform/chromium-mac/fast/events/autoscroll-expected.png:
- platform/chromium-mac/fast/events/context-no-deselect-expected.png:
- platform/chromium-mac/fast/forms/basic-buttons-expected.png:
- platform/chromium-mac/fast/forms/basic-inputs-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/button-sizes-expected.png:
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
- platform/chromium-mac/fast/forms/encoding-test-expected.png:
- platform/chromium-mac/fast/forms/fieldset-align-expected.png:
- platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/input-align-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
- platform/chromium-mac/fast/forms/input-baseline-expected.png:
- platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-mac/fast/forms/input-spaces-expected.png:
- platform/chromium-mac/fast/forms/input-table-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
- platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-width-expected.png:
- platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-mac/fast/forms/text-style-color-expected.png:
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-mac/fast/html/details-no-summary4-expected.png:
- platform/chromium-mac/fast/html/details-open-javascript-expected.png:
- platform/chromium-mac/fast/html/details-open2-expected.png:
- platform/chromium-mac/fast/html/details-open4-expected.png:
- platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/table/colspanMinWidth-expected.png:
- platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-mac/fast/table/text-field-baseline-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/hixie/mixed/003-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium/TestExpectations:
- 5:57 PM Applications using WebKit edited by
- (diff)
- 5:56 PM Applications using WebKit edited by
- (diff)
- 5:52 PM Changeset in webkit [126109] by
-
- 12 edits in trunk/Source
[V8] Move instrumentedCallFunction() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94456
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves instrumentedCallFunction() from V8Proxy
to ScriptController. Also this patch renames instrumentedCallFunction()
to callFunctionWithInstrumentation(), for consistency with callFunction().
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunction):
(WebCore):
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::resourceInfo):
(WebCore::resourceString):
(WebCore::ScriptController::callFunctionWithInstrumentation):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::call):
- bindings/v8/V8Callback.cpp:
(WebCore::invokeCallback):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp:
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
- bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
Source/WebKit/chromium:
- src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
- 5:51 PM WebInspector edited by
- (diff)
- 5:50 PM Changeset in webkit [126108] by
-
- 2 edits in trunk/LayoutTests
setMockGeolocationPosition not defined in WKTR
https://bugs.webkit.org/show_bug.cgi?id=94554
Unreviewed (bot gardening)
- platform/wk2/Skipped:
- 5:45 PM Changeset in webkit [126107] by
-
- 3 edits in trunk/Source/WebCore
Never notify of insertedIntoTree during document destruction.
https://bugs.webkit.org/show_bug.cgi?id=94535
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-08-20
Reviewed by Eric Seidel.
Never notify of insertedIntoTree during document destruction. Previously since we
avoid notifying of willBeRemovedFromTree it's possible we could have gotten several
insertedIntoTree notifications without ever being told we were removed.
No tests needed since this just closes holes related to future code.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode): Never call insertedIntoTree during document destruction.
(WebCore::RenderObjectChildList::insertChildNode): Same.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::attachRegion): Removed unneeded document destruction check.
- 5:37 PM Changeset in webkit [126106] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Initialize GraphicsLayerChromium::m_contentsLayerId when setting contents layer
https://bugs.webkit.org/show_bug.cgi?id=94552
Reviewed by Kenneth Russell.
Set it or it don't work good.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- 5:35 PM Changeset in webkit [126105] by
-
- 15 edits12 adds in trunk
Source/WebCore: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-20
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
Tests: css3/compositing/blend-mode-property-parsing-invalid.html
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateLayerBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-20
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
- css3/compositing: Added.
- css3/compositing/blend-mode-property-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid.html: Added.
- css3/compositing/blend-mode-property-parsing.html: Added.
- css3/compositing/blend-mode-property.html: Added.
- css3/compositing/script-tests: Added.
- css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Added.
(testInvalidFilterRule):
- css3/compositing/script-tests/blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testFilterRule):
- css3/compositing/script-tests/blend-mode-property.js: Added.
- platform/chromium/css3/compositing/blend-mode-property-expected.txt : Added.
- platform/chromium/css3/compositing/blend-mode-property-parsing-expected.txt : Added.
- 5:32 PM Changeset in webkit [126104] by
-
- 2 edits in trunk/Tools
[EFL] Move jhbuild dependencies based on SVN to tarballs
https://bugs.webkit.org/show_bug.cgi?id=90374
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Moved all the dependencies based on SVN to tarballs taken from a
equivalent snapshot from the official git mirror. This will make
update-webkitefl not dependent on network connection after the first
run. The bots will not fail if EFL SVN server in unreachable.
The reason why git mirror is not used directly is to minimize the
total size of source code we need to download.
- efl/jhbuild.modules:
- 5:31 PM Changeset in webkit [126103] by
-
- 12 edits in trunk/Source
[V8] Move retrieve{Window,Frame,PerContextData}() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94460
Reviewed by Adam Barth.
To kill V8Proxy, we move retrieve{Window,Frame,PerContextData}()
from V8Proxy to V8Binding. Also, this patch renames these methods as follows:
- retrieveWindow() -> toDOMWindow()
- retrieveFrame() -> toFrameIfNotDetached()
- retrievePerContextData() -> perContextDataForCurrentWorld()
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/BindingState.cpp:
(WebCore::activeDOMWindow):
(WebCore::firstDOMWindow):
(WebCore::activeFrame):
(WebCore::firstFrame):
(WebCore::currentFrame):
(WebCore::currentDocument):
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::retrieveFrameWithGlobalObjectCheck):
(WebCore::PageScriptDebugServer::getDebugListenerForContext):
(WebCore::PageScriptDebugServer::runMessageLoopOnPause):
- bindings/v8/V8Binding.cpp:
(WebCore::retrieveWindow):
(WebCore):
(WebCore::retrieveFrame):
(WebCore::retrievePerContextData):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::constructorForType):
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::V8Proxy::context):
(WebCore::V8Proxy::matchesCurrentContext):
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
- src/WebBindings.cpp:
(WebKit::makeIntArrayImpl):
(WebKit::makeStringArrayImpl):
- src/WebFrameImpl.cpp:
(WebKit::WebFrame::frameForContext):
- 5:20 PM Changeset in webkit [126102] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BLACKBERRY] Add notification if an element does not have touch move or mouse move handlers.
https://bugs.webkit.org/show_bug.cgi?id=94529
Patch by Genevieve Mak <gmak@rim.com> on 2012-08-20
Reviewed by George Staikos.
Send a notification to the client if the fat finger element does
not have a mouse move or touch move handler or if it is empty.
PR #177701
Reviewed Internally By Mike Lattanzio and Antonio Gomes.
- Api/WebPageClient.h:
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 5:16 PM Changeset in webkit [126101] by
-
- 2 edits in trunk/Tools
Lots of "error, test and reference image have different properties" in pixel test output
https://bugs.webkit.org/show_bug.cgi?id=92578
Reviewed by Dirk Pranke.
Improve ImageDiff's error reporting when test result image and expected image
differ in their properties.
- DumpRenderTree/cg/ImageDiffCG.cpp:
- 5:09 PM Changeset in webkit [126100] by
-
- 2 edits in trunk/Source/WebCore
Yank an unneccessary if added in r125810.
https://bugs.webkit.org/show_bug.cgi?id=85804
Reviewed by Levi Weintraub.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- 5:06 PM Changeset in webkit [126099] by
-
- 8 edits in trunk/Source
[chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer
https://bugs.webkit.org/show_bug.cgi?id=94544
Reviewed by Adrienne Walker.
Source/Platform:
Exposes an id so users of the WebLayer API can make identity checks for layers that they do not have ownership
of.
- chromium/public/WebLayer.h:
(WebLayer):
Source/WebCore:
GraphicsLayerChromium only keeps a weak pointer to its m_contentsLayer. When replacing it with a new contents
layer, it may be unsafe to touch the old value. It's also completely unnecessary.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
Source/WebKit/chromium:
- src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::id):
(WebKit):
- src/WebLayerImpl.h:
(WebLayerImpl):
- 5:02 PM Changeset in webkit [126098] by
-
- 7 edits in trunk/Source
[V8] Move collectGarbage() from ScriptController to V8GCController
https://bugs.webkit.org/show_bug.cgi?id=94455
Reviewed by Adam Barth.
- This patch moves collectGarbage() from ScriptController to V8GCController.
- This patch makes collectGarbage() a static method.
- This patch removes ScriptController::lowMemoryNotification()
since it is not used at all.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h:
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::collectGarbage):
(WebCore):
- bindings/v8/V8GCController.h:
(V8GCController):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::collectGarbage):
- 5:00 PM Changeset in webkit [126097] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (125759) fast/forms/file/selected-files-from-history-state.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=94549
Unreviewed (Bot gardening)
- platform/mac-wk2/Skipped:
- 4:57 PM Changeset in webkit [126096] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove V8Proxy from V8IsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=94450
Reviewed by Adam Barth.
This patch removes dependency on V8Proxy from V8IsolatedContext.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8IsolatedContext.h:
(WebCore):
(V8IsolatedContext):
- 4:57 PM Changeset in webkit [126095] by
-
- 8 edits in trunk/Source/WebKit/chromium
WebWidget should be able to paint into a zoomed canvas without aliasing
https://bugs.webkit.org/show_bug.cgi?id=92043
Reviewed by James Robinson.
If accelerated compositing is enabled, WebWidget::paint reads back from
the compositor rather than re-painting the widget. That approach works
well if the canvas we're rendering into is at a similar resolution to
the pixels in the compositor, but if the canvas has been scaled (e.g.,
to help the user disambiguate links), then reading back from the
compositor will cause aliasing artifacts.
This patch adds an option to paint to let the embedder request a
software re-rendering of the widget to avoid these aliasing artifacts.
- public/WebWidget.h:
(WebKit::WebWidget::paint):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::paint):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::canvasBackgroundForTransparencey):
(WebKit):
(WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:50 PM Changeset in webkit [126094] by
-
- 3 edits3 adds in trunk
Canvas drawImage() should draw SVG at the correct scale.
https://bugs.webkit.org/show_bug.cgi?id=94377
Source/WebCore:
Previously, drawing SVG in canvas would render at the incorrect scale
because imageSizeForRenderer did not take into account the page scale.
After this patch, we now incorporate the page scale in
CachedImage::imageSizeForRenderer().
Reviewed by Tim Horton.
Test: svg/as-image/svg-as-image-canvas.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
LayoutTests:
Reviewed by Tim Horton.
- svg/as-image/resources/100px-green-rect.svg: Added.
- svg/as-image/svg-as-image-canvas-expected.html: Added.
- svg/as-image/svg-as-image-canvas.html: Added.
- 4:48 PM Changeset in webkit [126093] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fixed erroneous line number for LLint frame when throwing exceptions.
https://bugs.webkit.org/show_bug.cgi?id=94051.
Patch by Mark Lam <mark.lam@apple.com> on 2012-08-20
Reviewed by Filip Pizlo.
For LLInt frames, before throwing an exception, adjust the PC from the
return PC back to the call PC if we are indeed at a call site.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::adjustPCIfAtCallSite):
(JSC):
(JSC::CodeBlock::bytecodeOffset):
- bytecode/CodeBlock.h:
(CodeBlock):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::fixupPCforExceptionIfNeeded):
(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- 4:45 PM Changeset in webkit [126092] by
-
- 2 edits in trunk/LayoutTests
Update TestExpectations now that stray ASSERT is fixed in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=94548
Unreviewed.
- platform/chromium/TestExpectations:
- 4:43 PM Changeset in webkit [126091] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Roll WebKit chromium DEPS forward.
- DEPS:
- 4:43 PM Changeset in webkit [126090] by
-
- 2 edits in trunk/Source/WebCore
Assertion going back to results.html page from an image diff result
https://bugs.webkit.org/show_bug.cgi?id=94143
Reviewed by Adam Barth.
Avoid redundantly setting the DOMWindow on a JSDOMWindow shell in
ScriptCachedFrameData::restore(), as we may have already done this
in ScriptController::clearWindowShell(). This avoids an assertion
on some platforms when going Back to the test results page from
a diff image.
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
- 4:39 PM Changeset in webkit [126089] by
-
- 2 edits in trunk/Tools
Unsafe vsprintf usage in TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=94522
Reviewed by Adam Barth.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
the message buffer.
(testDocumentOpen):
(testWindowOpen):
- 4:33 PM Changeset in webkit [126088] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] OES_vertex_array_object is not correctly un/binding or deleting
https://bugs.webkit.org/show_bug.cgi?id=94029
Reviewed by Ken Russell.
When the currently bound vertex array is deleted, the specification says that
the default object should be bound in its place. Also, binding a null object
as a vertex array was not actually clearing the bound object at the GL layer.
And lastly, it should not be possible to bind a deleted vertex array.
The test case for this is the public Khronos WebGL conformance suite, in particular:
conformance/extensions/oes-vertex-array-object.html
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::deleteVertexArrayOES): Check if the deleted array is
currently bound, and if so, unbind it.
(WebCore::OESVertexArrayObject::bindVertexArrayOES): Make sure never to bind an
array that has been marked as deleted.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::bindVertexArrayOES): Remove the null check on bind. We
do need to call glBindVertexArrayAPPLE with a null value in order to clear it.
- 4:25 PM Changeset in webkit [126087] by
-
- 6 edits2 moves in trunk/LayoutTests
2d.imageData.object.wrap.html has wrong expectations
https://bugs.webkit.org/show_bug.cgi?id=94089
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Updating and renaming the test to match new version in W3C approved tests.
- canvas/philip/tests/2d.imageData.object.clamp-expected.txt: Renamed from LayoutTests/canvas/philip/tests/2d.imageData.object.wrap-expected.txt.
- canvas/philip/tests/2d.imageData.object.clamp.html: Renamed from LayoutTests/canvas/philip/tests/2d.imageData.object.wrap.html.
- platform/chromium/TestExpectations: Unskipping.
- platform/efl/Skipped: Unskipping.
- platform/gtk/TestExpectations: Unskipping.
- platform/mac/Skipped: Unskipping.
- platform/qt/Skipped: Unskipping.
- 4:18 PM Changeset in webkit [126086] by
-
- 7 edits in trunk/Source
[V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94459
Reviewed by Adam Barth.
To kill V8Proxy, we can move clearForClose() and
clearForNavigation() from V8Proxy to ScriptController.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearForNavigation):
(WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::~V8Proxy):
(WebCore::V8Proxy::handleOutOfMemory):
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 4:16 PM Changeset in webkit [126085] by
-
- 2 edits in branches/safari-536.26-branch/Source/WebKit2
Merge r126041 for <rdar://problem/12133659>.
- 4:07 PM Changeset in webkit [126084] by
-
- 3 edits3 adds in trunk
CSS Masking and CSS Filters applied in wrong order
https://bugs.webkit.org/show_bug.cgi?id=94354
Reviewed by Dean Jackson.
Source/WebCore:
According to the Filter Effects spec, the order should be first filters, then masking and clipping.
Changed the order on applying the different effects in RenderLayer.
Test: css3/filters/filter-mask-clip-order.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): First filter, then mask and clip the content.
LayoutTests:
The test checks the correct order on applying CSS Masking, Filter Effects and CSS Clipping.
According to the Filter Effects spec, the order should be first filters, then masking and clipping.
- css3/filters/filter-mask-clip-order-expected.html: Added.
- css3/filters/filter-mask-clip-order.html: Added.
- css3/filters/resources/mask.png: Added.
- 3:42 PM Changeset in webkit [126083] by
-
- 13 edits in trunk/Source
[V8] Move mainWorldContext() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94453
Reviewed by Adam Barth.
This patch moves mainWorldContext() from V8Proxy to ScriptController.
In addition, this patch removes dependency on V8Proxy from WorldContextHandle.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
- bindings/v8/NPV8Object.cpp:
(WebCore::toV8Context):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::mainWorldContext):
(WebCore):
(WebCore::ScriptController::bindToWindowObject):
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/ScriptState.cpp:
(WebCore::mainWorldScriptState):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::context):
(WebCore::toV8Context):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::adjustedContext):
- bindings/v8/WorldContextHandle.h:
(WebCore):
(WorldContextHandle):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::mainWorldScriptContext):
- 3:41 PM Changeset in webkit [126082] by
-
- 2 edits in trunk/Source/JavaScriptCore
fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=94538
Reviewed by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- 3:32 PM Changeset in webkit [126081] by
-
- 2 edits in trunk/Source/JavaScriptCore
fast/js/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html crashes on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=94026
Reviewed by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
- 3:24 PM Changeset in webkit [126080] by
-
- 15 edits in trunk
Remove redundant TOUCH_LISTENER event type
https://bugs.webkit.org/show_bug.cgi?id=94524
Reviewed by Ryosuke Niwa.
Source/WebCore:
Code that needs to determine whether there are touch listeners
can instead call Document::touchEventHandlerCount(), added in r107832.
TOUCH_LISTENER didn't fit very well into the hasListenerType() model
anyway, as there's not a 1:1 correspondance between the enum value and
an event.
- dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Remove two bits of code:
the bookkeeping for TOUCH_LISTENER, and the notification into
ChromeClient (which is handled by calls to didAddTouchEventHandler in
all the places that call addListenerTypeIfNeeded).
(WebCore::Document::didRemoveTouchEventHandler): Remove bookkeeping for TOUCH_LISTENER.
- dom/Document.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Call touchEventHandlerCount instead of hasListenerType.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): ditto
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): ditto
- page/Frame.cpp:
(WebCore::Frame::setDocument): ditto
- testing/Internals.cpp: Remove hasTouchEventListener method since its
data source no longer exists.
- testing/Internals.h: ditto
(Internals):
- testing/Internals.idl: ditto
Source/WebKit/chromium:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): Remove
bookkeeping for TOUCH_LISTENER.
LayoutTests:
Removed tests for hasTouchEventListener as they're redundant
with tests for touchEventHandlerCount.
- fast/events/touch/touch-handler-count-expected.txt:
- fast/events/touch/touch-handler-count.html:
- 3:23 PM Changeset in webkit [126079] by
-
- 5 edits in trunk
[BlackBerry] Enable XHR Response BLOB
https://bugs.webkit.org/show_bug.cgi?id=94525
Reviewed by Rob Buis.
.:
Add the XHR response blob enable feature to the cmake build system and
enable it for BlackBerry.
- Source/cmake/OptionsBlackBerry.cmake: Add the feature and enable
- Source/cmakeconfig.h.cmake: Add the feature
Tools:
Turn on the XHR response blob feature for the BlackBerry port.
- Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
- 3:22 PM Changeset in webkit [126078] by
-
- 2 edits in trunk/LayoutTests
Reftest fast/text-autosizing/nested-em-line-height.html needs updating after r126058
https://bugs.webkit.org/show_bug.cgi?id=94528
Unreviewed Chromium gardening. Narrow test expectation.
- platform/chromium/TestExpectations:
- 3:20 PM WebKit Team edited by
- (diff)
- 3:08 PM Changeset in webkit [126077] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Adding suppressions for failing tests.
https://bugs.webkit.org/show_bug.cgi?id=94521
https://bugs.webkit.org/show_bug.cgi?id=94528
https://bugs.webkit.org/show_bug.cgi?id=94532
- platform/chromium/TestExpectations:
- 2:57 PM Changeset in webkit [126076] by
-
- 39 edits4 copies6 moves4 deletes in trunk/Source
[chromium] Change WebLayer from a concrete type to a pure virtual interface
https://bugs.webkit.org/show_bug.cgi?id=94174
Reviewed by Adrienne Walker.
Source/Platform:
This changes WebLayer from a value type to a pure virtual interface and changes Web*Layers from subtypes to
standalone types that have a WebLayer. This better isolates the implementation from the interface and, since
it's not possible to re-wrap an existing layer, makes cleanup explicit instead of requiring the caller to invoke
special cleanup methods before shutdown.
- chromium/public/WebContentLayer.h:
(WebContentLayer):
- chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
- chromium/public/WebIOSurfaceLayer.h:
(WebIOSurfaceLayer):
- chromium/public/WebImageLayer.h:
(WebImageLayer):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::~WebLayer):
- chromium/public/WebScrollableLayer.h:
(WebScrollableLayer):
- chromium/public/WebScrollbarLayer.h:
(WebScrollbarLayer):
- chromium/public/WebSolidColorLayer.h:
(WebKit):
(WebSolidColorLayer):
(WebKit::WebSolidColorLayer::~WebSolidColorLayer):
- chromium/public/WebVideoLayer.h:
(WebVideoLayer):
Source/WebCore:
This updates WebCore code for the WebLayer interface changes. Classes that have ownership of specific layer
types (such as DrawingBufferChromium, Canvas2DLayerBridge and ScrollingCoordinatorChromium) hold ownership
of a specific type and a pointer to the WebLayer to GraphicsLayerChromium to be included in the final layer
tree. GraphicsLayerChromium holds a WebContentLayer and (optionally) a WebImageLayer and WebLayer (for
m_transformLayer) and assembles the final layer tree.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore::scrollableLayerForGraphicsLayer):
(WebCore):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::clearLayer):
(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore):
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setBackgroundFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::setContentsTo):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentLayer):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::rootLayer):
- platform/graphics/chromium/LayerChromium.h:
Source/WebKit/chromium:
This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl /
NonCompositedContentHost.
- WebKit.gyp:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit):
(WebKit::WebContentLayerImpl::clearClient):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- src/WebExternalTextureLayer.cpp: Removed.
- src/WebExternalTextureLayerImpl.cpp: Added.
(WebKit):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::layer):
(WebKit::WebExternalTextureLayerImpl::clearClient):
(WebKit::WebExternalTextureLayerImpl::setTextureId):
(WebKit::WebExternalTextureLayerImpl::setFlipped):
(WebKit::WebExternalTextureLayerImpl::setUVRect):
(WebKit::WebExternalTextureLayerImpl::setOpaque):
(WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
(WebKit::WebExternalTextureLayerImpl::willModifyTexture):
(WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit::WebExternalTextureLayerImpl::prepareTexture):
(WebKit::WebExternalTextureLayerImpl::context):
- src/WebExternalTextureLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebContentLayer.cpp.
(WebKit):
(WebExternalTextureLayerImpl):
- src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
(WebKit):
(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
(WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
(WebKit::WebIOSurfaceLayerImpl::layer):
- src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
(WebCore):
(WebKit):
(WebIOSurfaceLayerImpl):
- src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):
(WebKit::WebImageLayerImpl::~WebImageLayerImpl):
(WebKit::WebImageLayerImpl::layer):
(WebKit::WebImageLayerImpl::setBitmap):
- src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
(WebCore):
(WebKit):
(WebImageLayerImpl):
- src/WebLayer.cpp: Removed.
- src/WebLayerImpl.cpp:
(WebKit::WebLayer::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit):
(WebKit::WebLayerImpl::invalidateRect):
(WebKit::WebLayerImpl::invalidate):
(WebKit::WebLayerImpl::addChild):
(WebKit::WebLayerImpl::insertChild):
(WebKit::WebLayerImpl::replaceChild):
(WebKit::WebLayerImpl::setChildren):
(WebKit::WebLayerImpl::removeFromParent):
(WebKit::WebLayerImpl::removeAllChildren):
(WebKit::WebLayerImpl::setAnchorPoint):
(WebKit::WebLayerImpl::anchorPoint):
(WebKit::WebLayerImpl::setAnchorPointZ):
(WebKit::WebLayerImpl::anchorPointZ):
(WebKit::WebLayerImpl::setBounds):
(WebKit::WebLayerImpl::bounds):
(WebKit::WebLayerImpl::setMasksToBounds):
(WebKit::WebLayerImpl::masksToBounds):
(WebKit::WebLayerImpl::setMaskLayer):
(WebKit::WebLayerImpl::setReplicaLayer):
(WebKit::WebLayerImpl::setOpacity):
(WebKit::WebLayerImpl::opacity):
(WebKit::WebLayerImpl::setOpaque):
(WebKit::WebLayerImpl::opaque):
(WebKit::WebLayerImpl::setPosition):
(WebKit::WebLayerImpl::position):
(WebKit::WebLayerImpl::setSublayerTransform):
(WebKit::WebLayerImpl::sublayerTransform):
(WebKit::WebLayerImpl::setTransform):
(WebKit::WebLayerImpl::transform):
(WebKit::WebLayerImpl::setDrawsContent):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::setPreserves3D):
(WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
(WebKit::WebLayerImpl::setBackgroundColor):
(WebKit::WebLayerImpl::setFilters):
(WebKit::WebLayerImpl::setBackgroundFilters):
(WebKit::WebLayerImpl::setDebugBorderColor):
(WebKit::WebLayerImpl::setDebugBorderWidth):
(WebKit::WebLayerImpl::setDebugName):
(WebKit::WebLayerImpl::setAnimationDelegate):
(WebKit::WebLayerImpl::addAnimation):
(WebKit::WebLayerImpl::removeAnimation):
(WebKit::WebLayerImpl::pauseAnimation):
(WebKit::WebLayerImpl::suspendAnimations):
(WebKit::WebLayerImpl::resumeAnimations):
(WebKit::WebLayerImpl::hasActiveAnimation):
(WebKit::WebLayerImpl::transferAnimationsTo):
(WebKit::WebLayerImpl::setForceRenderSurface):
(WebKit::WebLayerImpl::clearRenderSurface):
(WebKit::WebLayerImpl::setScrollPosition):
(WebKit::WebLayerImpl::setScrollable):
(WebKit::WebLayerImpl::setHaveWheelEventHandlers):
(WebKit::WebLayerImpl::setShouldScrollOnMainThread):
(WebKit::WebLayerImpl::setNonFastScrollableRegion):
(WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
(WebKit::WebLayerImpl::setFixedToContainerLayer):
(WebKit::WebLayerImpl::layer):
- src/WebLayerImpl.h:
(WebCore):
(WebLayerImpl):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setRootLayer):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::create):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebScrollableLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollableLayer.cpp.
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
(WebKit::WebScrollableLayer::setNonFastScrollableRegion):
(WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
(WebKit::WebScrollableLayer::setFixedToContainerLayer):
- src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
(WebKit):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
(WebKit::WebScrollbarLayerImpl::layer):
(WebKit::WebScrollbarLayerImpl::setScrollLayer):
- src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
(WebCore):
(WebKit):
(WebScrollbarLayerImpl):
- src/WebSolidColorLayerImpl.cpp:
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::layer):
(WebKit):
(WebKit::WebSolidColorLayerImpl::setBackgroundColor):
- src/WebSolidColorLayerImpl.h:
(WebCore):
(WebKit):
(WebSolidColorLayerImpl):
- src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
(WebKit::WebVideoLayerImpl::layer):
(WebKit::WebVideoLayerImpl::active):
- src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
(WebCore):
(WebKit):
(WebVideoLayerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
- src/WebViewImpl.h:
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
- tests/WebLayerTest.cpp:
- tests/WebLayerTreeViewTest.cpp:
- 2:50 PM Changeset in webkit [126075] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] CCMathUtilTest.smallestAngleBetweenVectors unit test failing
https://bugs.webkit.org/show_bug.cgi?id=94502
Reviewed by Kenneth Russell.
The test needed to use EXPECT_FLOAT_EQ instead of EXPECT_EQ. In
this patch, the test is also re-enabled.
- tests/CCMathUtilTest.cpp:
- 2:41 PM Changeset in webkit [126074] by
-
- 8 edits in trunk/Source
Move transformFriendlyBoundingBox out of Range
https://bugs.webkit.org/show_bug.cgi?id=94366
Source/WebCore:
Patch by Leandro Gracia Gil <leandrogracia@chromium.org> on 2012-08-20
Reviewed by Simon Fraser and Ryosuke Niwa.
Bug 93111 introduced a new method in Range called transformFriendlyBoundingBox.
However, this method should not have been added there in order to reduce the
dependencies between Range and the rendering code. This patch moves it to a
static method in RenderObject.
Tests: existing tests, no new feature added by this patch.
- dom/Range.cpp:
- dom/Range.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteBoundingBoxRectForRange):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
Source/WebKit/chromium:
Patch by Leandro Gracia Gil <leandrogracia@chromium.org> on 2012-08-20
Reviewed by Ryosuke Niwa.
Update the WebKit code that makes use of transformFriendlyBoundingBox.
- src/FindInPageCoordinates.cpp:
(WebKit::findInPageRectFromRange):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::selectFindMatch):
- 2:38 PM Changeset in webkit [126073] by
-
- 2 edits in trunk/Tools
Fix change for timeout detection to not crash if we have no output :)
https://bugs.webkit.org/show_bug.cgi?id=94505
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 2:34 PM Changeset in webkit [126072] by
-
- 12 edits in trunk
Replace isolate bidi-override by isolate-override https://bugs.webkit.org/show_bug.cgi?id=89746
Reviewed by Levi Weintraub.
Source/WebCore:
The combination of bidi-isolate and isolate was replaced by a single isolate-override in
http://lists.w3.org/Archives/Public/www-style/2012May/0541.html. The spec. has been updated accordingly:
http://dev.w3.org/csswg/css3-writing-modes/#unicode-bidi
To follow the specification change, added -webkit-isolate-override and removed the support for
isolate bidi-override, simplifying the CSS parser and serializer. Test: fast/text/bidi-override-isolate.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed. We can just new a CSSPrimitiveValue
constructor now.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added now that unicode-bidi always creates a signle
primitive value instead of a primitive value of css value list.
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
- css/CSSValueKeywords.in: Added -webkit-isolate-override
- css/StyleBuilder.cpp:
(WebCore): Removed ApplyPropertyUnicodeBidi since we can use ApplyPropertyDefault now.
(WebCore::StyleBuilder::StyleBuilder): Use ApplyPropertyDefault.
- platform/text/UnicodeBidi.h: Renamed OverrideIsolate to IsolateOverride to match the spec.
(WebCore::isIsolated):
(WebCore::isOverride):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRuns):
LayoutTests:
Rebaseline test expectations. These tests test the new behavior and new property value -webkit-isolate-override.
- fast/css/unicode-bidi-computed-value-expected.txt:
- fast/css/unicode-bidi-computed-value.html:
- fast/text/bidi-override-isolate.html:
- 2:32 PM Changeset in webkit [126071] by
-
- 7 edits2 adds in trunk
RenderGrid children should always be RenderBoxes
https://bugs.webkit.org/show_bug.cgi?id=94305
Reviewed by Abhishek Arya.
Source/WebCore:
During RenderGrid::layout, we assume all the children are RenderBoxes.
When removing children, if the last child is an anonymous block, we don't
want to remove the anonymous block for grids. Ensure this doesn't happen
by adding canCollapseAnonymousBlockChild to RenderBlock (flexboxen and
grid can override this method).
Test: fast/css-grid-layout/should-not-collapse-anonymous-blocks.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): Check canCollapseAnonymousBlockChild().
- rendering/RenderBlock.h:
(WebCore::RenderBlock::canCollapseAnonymousBlockChild):
(RenderBlock):
- rendering/RenderDeprecatedFlexibleBox.h: canCollapseAnonymousBlockChild returns false.
- rendering/RenderFlexibleBox.h: canCollapseAnonymousBlockChild returns false.
- rendering/RenderGrid.h: canCollapseAnonymousBlockChild returns false.
LayoutTests:
Add test case from fuzzer.
- fast/css-grid-layout/should-not-collapse-anonymous-blocks-expected.txt: Added.
- fast/css-grid-layout/should-not-collapse-anonymous-blocks.html: Added.
- 2:30 PM Changeset in webkit [126070] by
-
- 2 edits in trunk/Tools
temporarily disable ImageDiff on WK2 ports for ref tests
https://bugs.webkit.org/show_bug.cgi?id=94517
Reviewed by Brady Eidson.
ImageDiff appears to be unable to handle the pngs returned from
WebKitTestRunner, so we disable checking images by default
for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_output_with_reference):
- 2:16 PM Changeset in webkit [126069] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r126026.
http://trac.webkit.org/changeset/126026
https://bugs.webkit.org/show_bug.cgi?id=94449
Caused assertion failure in layout test touchadjustment/context-menu.html
Source/WebCore:
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendSubtargetsForNodeToList):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
LayoutTests:
- touchadjustment/context-menu-select-text.html:
- touchadjustment/context-menu-text-subtargets-expected.txt: Removed.
- touchadjustment/context-menu-text-subtargets.html: Removed.
- touchadjustment/resources/touchadjustment.js:
- 2:15 PM Changeset in webkit [126068] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Enabling DEBUG_LAYER_ANIMATION results in build break & warnings
https://bugs.webkit.org/show_bug.cgi?id=94514
Patch by Andrew Lo <anlo@rim.com> on 2012-08-20
Reviewed by Rob Buis.
Add wtf::CString definition to fix build break when enabling DEBUG_LAYER_ANIMATION
debug prints. Fix build warnings from prints.
No new tests, non-functional change.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::addAnimation):
(WebCore::GraphicsLayerBlackBerry::pauseAnimation):
- 2:12 PM Changeset in webkit [126067] by
-
- 8 edits1 delete in trunk
[JSC] SerializedScriptValue::create() should throw a DataCloneError if input is an unsupported object
https://bugs.webkit.org/show_bug.cgi?id=94493
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
Reviewed by Oliver Hunt.
Source/WebCore:
Update JSC implementation for SerializedScriptValue::create() so that
a DataCloneError is thrown when the input value is an unsupported
object. The previous implementation was not throwing any error.
This change is according to the structured clone specification at:
http://www.w3.org/TR/html5/common-dom-interfaces.html#structured-clone
This also matches the corresponding V8 implementation.
Test: fast/events/message-port-multi.html.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::serialize):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
- bindings/js/SerializedScriptValue.h:
LayoutTests:
Add checks for Function, Error and host objects arguments to
MessagePort.postMessage() in fast/events/message-port-multi.html.
According to the structured clone specification, we should throw
a DataCloneError for such input types.
- fast/dom/Window/anonymous-slot-with-changes-expected.txt:
- fast/dom/Window/anonymous-slot-with-changes.html: Update test to expect
an exception when passing a function to postMessage().
- fast/events/message-port-multi-expected.txt: Update expected result
accordingly.
- fast/events/resources/message-port-multi.js:
(testTransfers.try.f1):
- platform/chromium/fast/events/message-port-multi-expected.txt: Removed.
Now identical to global expectation.
- 2:11 PM Changeset in webkit [126066] by
-
- 9 edits2 copies in trunk/Source/WebCore
Unreviewed, rolling out r125884.
http://trac.webkit.org/changeset/125884
https://bugs.webkit.org/show_bug.cgi?id=94523
Appears to be causing a top crash in the Canary channel
(Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-20
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::mainThreadNormalWorld):
- bindings/v8/DOMWrapperWorld.h:
(WebCore):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(DOMWrapperWorld):
- bindings/v8/IsolatedWorld.cpp: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.cpp.
(WebCore):
(WebCore::IsolatedWorld::IsolatedWorld):
(WebCore::IsolatedWorld::~IsolatedWorld):
- bindings/v8/IsolatedWorld.h: Copied from Source/WebCore/bindings/v8/DOMWrapperWorld.h.
(WebCore):
(IsolatedWorld):
(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::count):
(WebCore::IsolatedWorld::id):
(WebCore::IsolatedWorld::domDataStore):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):
- bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::registerDOMDataStore):
(WebCore::V8PerIsolateData::unregisterDOMDataStore):
- 2:09 PM Changeset in webkit [126065] by
-
- 2 edits in trunk/Source/WebCore
Remove improper ASSERT in AudioParamTimeline::valuesForTimeRangeImpl()
https://bugs.webkit.org/show_bug.cgi?id=94504
Reviewed by Kenneth Russell.
AudioParamTimeline::valuesForTimeRangeImpl() is able to handle the case where there are no timeline events.
So don't ASSERT for that case.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- 2:03 PM Changeset in webkit [126064] by
-
- 2 edits in trunk/Tools
Add missing FIXME: to previous change.
https://bugs.webkit.org/show_bug.cgi?id=94505
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 2:02 PM Changeset in webkit [126063] by
-
- 3 edits2 adds in trunk
Line boxes not being dirtied correctly during inline removal
https://bugs.webkit.org/show_bug.cgi?id=93156
Reviewed by David Hyatt.
Source/WebCore:
When two inline objects were being removed from different lineboxes
in an ancestral RenderBlock, the way the RenderBlock was being marked
prevented the second linebox from being marked dirty. This causes
it to not get layout in the subsequent layout pass.
This patch causes only the descendants corresponding to actual changed
lineboxes to have their ancestorLineBoxDirty bit set, rather than
the RenderBlock that contains the lineboxes themselves.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
LayoutTests:
Test exercising crashing condition for bug 93156.
- fast/block/line-layout/double-line-break-obj-removal-crash.html: Added
- fast/block/line-layout/double-line-break-obj-removal-crash-expected.txt: Added
- 1:59 PM Changeset in webkit [126062] by
-
- 2 edits in trunk/Tools
Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
https://bugs.webkit.org/show_bug.cgi?id=94505
Reviewed by Ojan Vafai.
It looks like if the webprocess times out, WTR may tell NRWT
that the test completed, but not properly reset its internal
state, and then return stale output for subsequent tests.
This patch modifies NRWT temporarily to check for
"Timed out waiting for final message from web process" in stdout
and treat that as a timeout (and thus kill WTR); this seems
to solve the cascade of failures, but of course there's probably
still a bug in WTR that needs to be fixed.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- 1:48 PM Changeset in webkit [126061] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] detectContentIntentAround has a misleading name
https://bugs.webkit.org/show_bug.cgi?id=94349
Reviewed by Adam Barth.
The current WebViewClient API exposes a method named detectContentIntentAround.
However, this is not designed to detect any "content intent", but to allow the embedder
to detect content around a position and fire Android intents if appropriate.
This patch also disables content detection if the touched node listens to events
that consume the tap action like clicks, touch events or mouse events.
- public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::detectContentAround):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::detectContentOnTouch):
- src/WebViewImpl.h:
(WebViewImpl):
- 1:44 PM Changeset in webkit [126060] by
-
- 1 edit3 adds in trunk/LayoutTests
[css3-text] Add getComputedStyle tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94108
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Changeset r125205 introduced new CSS3 property "-webkit-text-decoration-line",
with included basic getComputedStyle* layout tests for parsing check. This
patch adds a new, more robust getComputedStyle-based layout test for this
property.
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Added.
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html: Added.
- fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js: Added.
- 1:25 PM Changeset in webkit [126059] by
-
- 2 edits in trunk/Tools
NRWT reports unexpected EOF
https://bugs.webkit.org/show_bug.cgi?id=94387
Reviewed by Adam Barth.
Stop logging "Unexpected EOF" when we are reading the last few
bytes from stdout/stderr after stopping the subprocess.
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess.stop):
- 1:23 PM Changeset in webkit [126058] by
-
- 11 edits8 adds in trunk
Text Autosizing: Only take into account block width <= document layout width.
https://bugs.webkit.org/show_bug.cgi?id=93862
Patch by John Mellor <johnme@chromium.org> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Instead of calculating the textAutosizingMultiplier purely based on the
width of each block, we now work out the maximum width of the block
that could be displayed onscreen at any one time, and use that value.
This avoids excessive text size multiplication (there's no point making
text bigger than this, since you wouldn't be able to zoom out far
enough to read it!).
To determine the maximum onscreen block width, we take the minimum of
the block width and the layoutWidth of the narrowest non-flattened
ancestor frame. Flattened frames are ignored since they don't impose a
hard limit on the maximum width that can be displayed, instead they can
stretch to fit their contents. Note that on mobile the layoutWidth of
the main frame is the fixed layout width aka viewport width.
In practice this caps the maximum multiplier to a value that depends
on the metrics of the device. For example on a Nexus S (480 x 800px
and 1.5x devicePixelRatio) with a 980px default fixed layout width,
this limits the multiplier to: 980 / (480/1.5) = 3.0625
Most pages won't have blocks that actually hit this cap, or they will
only slightly exceed it (so their multiplier will only be slightly
reduced). For example it's not uncommon for desktop pages to be
slightly wider than 980px, but they would have to additionally have
text that spans the full width of the page for this to affect them, and
even then it would merely slightly decrease their multiplier).
This will have more dramatic effects on the rare desktop pages which
give a width=device-width (or similar) mobile viewport tag (on ports
which support viewports). A follow-up patch will hopefully address this
by wrapping the text in such excessively wide blocks to the layoutWidth.
Tests: fast/text-autosizing/narrow-iframe-flattened.html
fast/text-autosizing/narrow-iframe.html
fast/text-autosizing/wide-block.html
fast/text-autosizing/wide-iframe.html
- page/FrameView.cpp:
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
Made public and const, so can be used from TextAutosizer.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Computes the minimum layout width of the parent frames, as described
above.
(WebCore::TextAutosizer::processBlock):
Limits used block width to this min layout width.
LayoutTests:
Added 4 tests: a block wider than the main frame, iframes both narrower
than and wider than the main frame, both also containing wide blocks,
and a narrow iframe expanded by frame flattening.
I verified experimentally that narrow-iframe-flattened.html passes, by
enabling frame flattening in Settings.cpp, but unfortunately it won't
get run by any bots since the only platform which currently enables
Text Autosizing (Chromium), doesn't enable frame flattening (or have
the DRT methods required to test it).
- fast/text-autosizing/font-scale-factor-expected.html:
- fast/text-autosizing/font-scale-factor.html:
- fast/text-autosizing/narrow-iframe-expected.html: Added.
- fast/text-autosizing/narrow-iframe-flattened-expected.html: Added.
- fast/text-autosizing/narrow-iframe-flattened.html: Added.
- fast/text-autosizing/narrow-iframe.html: Added.
- fast/text-autosizing/wide-block-expected.html: Added.
- fast/text-autosizing/wide-block.html: Added.
- fast/text-autosizing/wide-iframe-expected.html: Added.
- fast/text-autosizing/wide-iframe.html: Added.
- platform/chromium/TestExpectations:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 12:53 PM Changeset in webkit [126057] by
-
- 5 edits in trunk
Respect runtime flags for Device Orientation and Device Motion
https://bugs.webkit.org/show_bug.cgi?id=94479
Reviewed by Adam Barth.
Source/WebCore:
There are flags that allows disabling of device orientation and device
motion at runtime. These flags determine the availability of the
corresponding event constructors in DOMWindow.
However, the flags should also control the ability to add event
listeners for these events, otherwise the feature can be used even if
it is disabled.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
Source/WebKit/chromium:
WebRuntimeFeatures::enableDeviceMotion should not be hard-coded to
false.
- src/WebViewImpl.cpp:
(WebKit::WebView::create):
- 12:52 PM Changeset in webkit [126056] by
-
- 3 edits in trunk/Source/WebCore
Remove incorrect getBBox() code
https://bugs.webkit.org/show_bug.cgi?id=94419
Reviewed by Dirk Schulze.
SVGPathElement defines a getBBox() function that is wrong and
should use objectBoundingBox(). This patch cleans this up.
No new tests as this is just a cleanup of old code.
- svg/SVGPathElement.cpp:
(WebCore):
- svg/SVGPathElement.h:
(SVGPathElement):
- 12:50 PM Changeset in webkit [126055] by
-
- 13 edits in trunk/Source
[Chromium] Schedule texture uploads based on hard-coded timer and vsync.
https://bugs.webkit.org/show_bug.cgi?id=84281
Patch by David Reveman <reveman@chromium.org> on 2012-08-20
Reviewed by James Robinson.
Source/WebCore:
Improve interaction between vsync and texture uploads by performing
uploads in smaller batches and use a hard-coded timer to emulate
upload completion. This greatly reduces the chance of the compositor
missing a vsync due to being busy with texture uploads.
The CCScheduler client is now given a time limit when told to update
more resources. This time limit is passed to an instance of the
CCTextureUpdateController class, which is responsible for performing
texture updates until the limit is reached.
Unit tests: CCSchedulerTest.RequestCommit
CCTextureUpdateControllerTest.UpdateMoreTextures
CCTextureUpdateControllerTest.HasMoreUpdates
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::nextTickTime):
(WebCore):
- platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::processScheduledActions):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCSchedulerClient):
- platform/graphics/chromium/cc/CCTextureUpdateController.cpp:
(WebCore::CCTextureUpdateController::maxPartialTextureUpdates):
(WebCore::CCTextureUpdateController::CCTextureUpdateController):
(WebCore::CCTextureUpdateController::updateMoreTextures):
(WebCore):
(WebCore::CCTextureUpdateController::onTimerFired):
(WebCore::CCTextureUpdateController::monotonicTimeNow):
(WebCore::CCTextureUpdateController::updateMoreTexturesTime):
(WebCore::CCTextureUpdateController::updateMoreTexturesSize):
(WebCore::CCTextureUpdateController::updateMoreTexturesIfEnoughTimeRemaining):
(WebCore::CCTextureUpdateController::updateMoreTexturesNow):
- platform/graphics/chromium/cc/CCTextureUpdateController.h:
(WebCore::CCTextureUpdateController::create):
(CCTextureUpdateController):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
- tests/CCSchedulerTestCommon.h:
(WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
(WebKitTests::FakeCCTimeSource::setNextTickTime):
(FakeCCTimeSource):
- tests/CCTextureUpdateControllerTest.cpp:
- 12:36 PM Changeset in webkit [126054] by
-
- 15 edits5 adds in trunk
[css3-text] Add parsing support for -webkit-text-decoration-style
https://bugs.webkit.org/show_bug.cgi?id=94093
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-08-20
Reviewed by Julien Chaffraix.
This patch implements the "text-decoration-style" property parsing as specified
in CSS3 working draft, with "-webkit-" prefix. The specification can be found
here: http://dev.w3.org/csswg/css3-text/#text-decoration-style
Additionally, Mozilla implementation details can be found here:
https://developer.mozilla.org/en-US/docs/CSS/text-decoration-style
This is an individual task for bug 90958. Rendering support will be handled on a
different bug.
Source/WebCore:
Test: fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationStyleFlagsToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added non-bitwise TextDecorationStyle enum.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Added m_textDecorationStyle to default and copy constructors.
(WebCore::StyleRareNonInheritedData::operator==): Include m_textDecorationStyle in comparison.
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
Added m_textDecorationStyle here as it won't be used regularly.
LayoutTests:
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Added.
- fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html: Added.
- fast/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js: Added.
- 12:23 PM Changeset in webkit [126053] by
-
- 5 edits in trunk/Source/WebCore
[BlackBerry] Persist cookies not from atexit() but the new onThreadFinished()
https://bugs.webkit.org/show_bug.cgi?id=94482
RIM PR 184923
Reviewed by Yong Li.
BlackBerry::Platform recently made changes that ensure
that MessageClient threads are being shut down correctly.
A new onThreadFinished() virtual was introduced for
custom clean-up functionality and can replace the
atexit() handler that we previously used to flush cookies
to the cookie database backingstore.
No new functionality, no new tests.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore):
(WebCore::CookieDatabaseBackingStore::onThreadFinished):
(WebCore::CookieDatabaseBackingStore::sendChangesToDatabaseSynchronously):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
(CookieDatabaseBackingStore):
- platform/blackberry/CookieManager.cpp:
(WebCore):
(WebCore::cookieManager):
- platform/blackberry/CookieManager.h:
- 12:15 PM Changeset in webkit [126052] by
-
- 7 edits3 adds in trunk/Source/WebCore
[chromium] Move non-GL-specific code out of LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=93927
Patch by Alexandre Elias <aelias@google.com> on 2012-08-20
Reviewed by Adrienne Walker.
This patch moves most of the generic logic dealing with matrices and
render passes into a new class "CCDirectRenderer" that sits between
CCRenderer and LayerRendererChromium, and also publicly exposes a
few other things like the UnthrottledTextureUploader.
The plan is for the future software compositing implementation to also
derive from CCDirectRenderer, whereas the ubercompositor delegating
renderer will still derive from CCRenderer.
No new tests (no-op refactoring).
- WebCore.gypi:
- platform/graphics/chromium/GeometryBinding.cpp:
(WebCore::GeometryBinding::GeometryBinding):
- platform/graphics/chromium/GeometryBinding.h:
(GeometryBinding):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::drawQuadGeometry):
(WebCore::LayerRendererChromium::bindFramebufferToOutputSurface):
(WebCore):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::enableScissorTestRect):
(WebCore::LayerRendererChromium::disableScissorTest):
(WebCore::LayerRendererChromium::setDrawViewportSize):
(WebCore::LayerRendererChromium::makeContextCurrent):
(WebCore::LayerRendererChromium::initializeSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/TextureCopier.h:
(TextureCopier):
- platform/graphics/chromium/TextureUploader.h:
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
- platform/graphics/chromium/cc/CCDirectRenderer.cpp: Added.
(projectionMatrix):
(canvasMatrix):
(WebCore):
(WebCore::CCDirectRenderer::DrawingFrame::initializeMatrices):
(WebCore::CCDirectRenderer::DrawingFrame::initializeScissors):
(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::drawFrame):
(WebCore::CCDirectRenderer::drawRenderPass):
(WebCore::CCDirectRenderer::useRenderPass):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):
(WebCore::CCDirectRenderer::renderPassTextureSize):
(WebCore::CCDirectRenderer::renderPassTextureFormat):
- platform/graphics/chromium/cc/CCDirectRenderer.h: Added.
(WebCore):
(CCDirectRenderer):
(WebCore::CCDirectRenderer::~CCDirectRenderer):
(WebCore::CCDirectRenderer::resourceProvider):
(WebCore::CCDirectRenderer::CCDirectRenderer):
(DrawingFrame):
(WebCore::CCDirectRenderer::DrawingFrame::DrawingFrame):
(CachedTexture):
(WebCore::CCDirectRenderer::CachedTexture::create):
(WebCore::CCDirectRenderer::CachedTexture::~CachedTexture):
(WebCore::CCDirectRenderer::CachedTexture::isComplete):
(WebCore::CCDirectRenderer::CachedTexture::setIsComplete):
(WebCore::CCDirectRenderer::CachedTexture::CachedTexture):
(WebCore::CCDirectRenderer::quadVertexRect):
(WebCore::CCDirectRenderer::quadRectTransform):
- 12:10 PM Changeset in webkit [126051] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening. Fixed invalid test expectation.
- platform/chromium/TestExpectations:
- 12:04 PM Changeset in webkit [126050] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/dom/Document.cpp
Merge 126043 - webkitfullscreenchange not fired properly in iframe.
https://bugs.webkit.org/show_bug.cgi?id=93525
Reviewed by Adam Barth.
webkitCancelFullScreen exits fullscreen by invoking webkitExitFullScreen on topDocument.
However, if webkitDidExitFullScreenForElement is invoked on a descendant document, no events
get dispatched. This change starts the event dispatch delay timer on the document where
webkitCancelFullScreen was called, so that the events get dispatched. In addition, when events
are dispatched, the check whether a node has been removed is changed to also check that the
node isn't in another document, as can happen with frames. Finally, webkitExitFullscreen
is fixed to remove unnecessary code and conform to the spec.
No new tests (the existing fullscreen/exit-full-screen-iframe.html test now passes).
- dom/Document.cpp:
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired):
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10855251
- 11:55 AM Changeset in webkit [126049] by
-
- 8 edits in trunk
Unreviewed Chromium rebaselining and test failure suppressions.
Source/WebKit/chromium:
https://bugs.webkit.org/show_bug.cgi?id=94502
- tests/CCMathUtilTest.cpp:
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=94494
https://bugs.webkit.org/show_bug.cgi?id=94501
https://bugs.webkit.org/show_bug.cgi?id=94502
- platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-mac/fast/css/text-overflow-input-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium/TestExpectations:
- 11:52 AM Changeset in webkit [126048] by
-
- 11 edits in trunk/Source/WebCore
Introduce a will-be-removed-from-tree notification in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=94271
Reviewed by Abhishek Arya.
Following bug 93874, we have an insertion notification. This change adds the
matching removal notification (willBeRemovedFromTree).
Refactoring covered by existing tests.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Removed the code from here and moved it below.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
- rendering/RenderObject.h:
This is the base function that should be called by every instance.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::willBeRemovedFromTree):
- rendering/RenderListItem.h:
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::willBeRemovedFromTree):
- rendering/RenderQuote.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::willBeRemovedFromTree):
- rendering/RenderRegion.h:
Overriden functions.
- 11:33 AM Changeset in webkit [126047] by
-
- 5 edits in trunk
CSP 1.1: The 'plugin-types' warning should include details about explicit type declaration when relevant.
https://bugs.webkit.org/show_bug.cgi?id=94432
Patch by Mike West <mkwst@chromium.org> on 2012-08-20
Reviewed by Adam Barth.
Source/WebCore:
Given a 'plugin-types' Content Security Policy directive, an 'object' or
'embed' tag is blocked if it doesn't include an explicit declaration of
the plugin's expected media type. This restriction should be made clear
in the console warning that's generated.
Existing tests have been adjusted to agree with the new error string.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
If a media type fail to match the policy's restrictions, and the
declared type attribute is empty, then add another line to the
console warning, espousing the virtues of explicit declaration.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt:
- 11:23 AM Changeset in webkit [126046] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Update HUD resources as a final step to drawing a frame
https://bugs.webkit.org/show_bug.cgi?id=93743
Reviewed by Adrienne Walker.
The HUD should be painted as a last step, after the whole frame has been
generated. This introduces a new "updateHudTexture" method on the HUD layer
and has the HUD layer save itself on CCLayerTreeHostImpl so that it can
call back to this method.
This allows the CCLayerTreeHostImpl to cause the HUD layer to update its
texture as a final step before drawing the frame, allowing the HUD texture
to contain all possible information about the current frame.
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore):
(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):
(WebCore::CCHeadsUpDisplayLayerImpl::updateHudTexture):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
(CCHeadsUpDisplayLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(WebCore::CCLayerTreeHostImpl::setHudLayer):
(WebCore::CCLayerTreeHostImpl::hudLayer):
(CCLayerTreeHostImpl):
- 11:21 AM Changeset in webkit [126045] by
-
- 7 edits in trunk/Source
[chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210
Reviewed by James Robinson.
This patch issues the trace events from the animations. Animations will
report when they start and finish on the main and impl threads (via
TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they
change state.
Source/WebCore:
No new tests, only changes tracing behavior.
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::setRunState):
(WebCore::CCActiveAnimation::clone):
(WebCore):
(WebCore::CCActiveAnimation::cloneAndInitialize):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore::CCActiveAnimation::isControllingInstance):
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
Source/WebKit/chromium:
- src/WebAnimationImpl.cpp:
(WebKit::WebAnimationImpl::cloneToCCAnimation):
- tests/CCAnimationTestCommon.h:
- 11:16 AM Changeset in webkit [126044] by
-
- 2 edits in trunk/Tools
Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
https://bugs.webkit.org/show_bug.cgi?id=94506
Reviewed by Dirk Pranke.
When running WK2 tests, don't add the "abort early" command line options.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ConfigureBuild.start):
(RunWebKitTests):
(RunWebKitTests.start):
(RunWebKit2Tests.start):
- 11:11 AM Changeset in webkit [126043] by
-
- 2 edits in trunk/Source/WebCore
webkitfullscreenchange not fired properly in iframe.
https://bugs.webkit.org/show_bug.cgi?id=93525
Reviewed by Adam Barth.
webkitCancelFullScreen exits fullscreen by invoking webkitExitFullScreen on topDocument.
However, if webkitDidExitFullScreenForElement is invoked on a descendant document, no events
get dispatched. This change starts the event dispatch delay timer on the document where
webkitCancelFullScreen was called, so that the events get dispatched. In addition, when events
are dispatched, the check whether a node has been removed is changed to also check that the
node isn't in another document, as can happen with frames. Finally, webkitExitFullscreen
is fixed to remove unnecessary code and conform to the spec.
No new tests (the existing fullscreen/exit-full-screen-iframe.html test now passes).
- dom/Document.cpp:
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired):
- 11:01 AM Changeset in webkit [126042] by
-
- 2 edits in trunk/Source/WebCore
[chromium] pepper plugins sometimes are shifted by 1 pixel
https://bugs.webkit.org/show_bug.cgi?id=94257
Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-08-20
Reviewed by Levi Weintraub.
Change RenderWidget::updateWidgetGeometry() to use LayoutRect instead of IntRect to avoid unwanted truncation
(when converting from FloatRect to IntRect).
This makes sure that the optimized rendering code path of Pepper plugin
(PluginInstance::GetBitmapForOptimizedPluginPaint) has consistent coordinates with the normal WebKit rendering
code path.
No new tests because we don't have Pepper plugin tests in WebKit.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
- 9:53 AM Changeset in webkit [126041] by
-
- 2 edits in trunk/Source/WebKit2
<https://bugs.webkit.org/show_bug.cgi?id=94486>
<rdar://problem/12128557>
REGRESSION (r121482, Lion-only): Closing a popover containing a WKView can crash
Reviewed by Darin Adler.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
Avoid calling the code added in 121482 that ensures that the undo stack is cleaned up
before the WKView is moved from one window to another when the WKView is being moved
out of a popover window. This avoids a bug in OS X 10.7 that was fixed in 10.8.
While this technically reopens a potentially crashing code path that 121482 closed,
it only reopens it for WKViews that are used for text editing and that are removed
from an NSPopover at some time earlier than tear-down of the NSPopover.
- 9:44 AM WebKit Team edited by
- (diff)
- 9:39 AM Changeset in webkit [126040] by
-
- 2 edits in trunk/Source/WebCore
postMessage() in MessagePort.idl does not match spec
https://bugs.webkit.org/show_bug.cgi?id=94477
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
Reviewed by Kentaro Hara.
Update definition of postMessage() in MessagePort.idl
to match the specification at:
http://www.w3.org/TR/html5/comms.html#messageport
The first argument should be of type 'any', not
'DOMString'.
No new tests, no behavior change.
- dom/MessagePort.idl:
- 9:18 AM Changeset in webkit [126039] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Merge 125407 - [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
- 9:18 AM Changeset in webkit [126038] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 125326 - [GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-10
Rubber-stamped by Ryosuke Niwa.
Fix Apple Win build, by avoiding to generate unreachable sections
of code in AccessibilityRenderObject::passwordFieldValue().
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::passwordFieldValue):
- 9:18 AM Changeset in webkit [126037] by
-
- 7 edits in releases/WebKitGTK/webkit-1.8/Source
Merge 125321 - [GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-10
Reviewed by Chris Fleizach.
Source/WebCore:
Fix broken implementation of AtkText and AtkEditableText
interfaces in the GTK port for password input fields.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue): Call the new
function passwordFieldValue() for password input fields.
(WebCore::AccessibilityRenderObject::text): Ditto.
(WebCore::AccessibilityRenderObject::textLength): Return the
actual length of the password in the field for GTK, return -1
otherwise (not to break current behavior in other platforms).
(WebCore::AccessibilityRenderObject::doAXStringForRange): Don't
early return for password fields in GTK (will rely on text()).
(WebCore::AccessibilityRenderObject::passwordFieldValue): New, it
returns the text being actually rendered for a password input
field (normally a masked string) in GTK. It returns String() in
the rest of platforms, to ensure we don't break anything there.
(WebCore):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::passwordFieldValue): Default
implementation of this new method, returning an empty string.
(AccessibilityObject):
Ensure the 'text-insert' and 'text-remove' signals for the AtkText
interface are properly emitted for password input fields.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Make
sure we never emit the password value for an input field in plain
text when inserting or removing text. Emit the masked text instead.
Source/WebKit/gtk:
Update unit test to ensure that password input fields behave
as expected when inserting and removing characters in them.
- tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Updated unit test to
cover the special case of password input fields.
- 9:18 AM Changeset in webkit [126036] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 125181 - REGRESSION (r124997): Flaky crashes in two tests
https://bugs.webkit.org/show_bug.cgi?id=93501
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-09
Reviewed by Martin Robinson.
Add missing null check to make sure we early return if the
accessibility object does not have a valid parent exposed in the
accessibility hierarchy.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::emitTextChanged): Add missing null check.
- 9:18 AM Changeset in webkit [126035] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 124997 - REGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
https://bugs.webkit.org/show_bug.cgi?id=63611
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-08-08
Reviewed by Ryosuke Niwa.
Ensure document's layout is up-to-date before using TextIterator
to properly calculate the offset for a text change when emitting
accessibility related signals in GTK.
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Call
to document->updateLayout() before using TextIterator.
- 9:18 AM Changeset in webkit [126034] by
-
- 18 edits in releases/WebKitGTK/webkit-1.8
Merge 120956 - [GTK] Fix NPAPI plugins on Windows
https://bugs.webkit.org/show_bug.cgi?id=54531
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-21
Reviewed by Martin Robinson.
.:
Define XP_WIN on Windows for plugin support.
- GNUmakefile.am:
Source/WebCore:
Switch to using PluginPackageWin.cpp and PluginViewWin.cpp on Windows
platform, and leave plugins/gtk/ only for XP_UNIX platforms. With this
we can share a lot of code with other ports and don't have to
reimplement all the Windows-specific code in plugins/gtk/.
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/FileSystem.h:
(WebCore):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(GraphicsContextPlatformPrivate):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
- platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore):
- platform/graphics/win/GraphicsContextWin.cpp:
(WebCore):
- platform/gtk/FileSystemGtk.cpp:
(WebCore::unloadModule):
- plugins/PluginView.h:
(PluginView):
- plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):
(WebCore::registerPluginView):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):
Source/WTF:
Define ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for the GTK+ port, and
include OwnPtrWin.cpp in the list of files built on Windows.
- GNUmakefile.am:
- GNUmakefile.list.am:
- wtf/Platform.h:
- 9:18 AM Changeset in webkit [126033] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 121441 - [GTK][Win]: Fix plugin drawing to an offscreen buffer
https://bugs.webkit.org/show_bug.cgi?id=89499
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-06-28
Reviewed by Brent Fulgham.
Take into account that the GTK+ port draws to a backing store and adjust
the target rectangle calculation accordingly.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::setNPWindowRect):
- 9:13 AM Changeset in webkit [126032] by
-
- 15 edits9 deletes in trunk
Unreviewed, rolling out r125989.
http://trac.webkit.org/changeset/125989
https://bugs.webkit.org/show_bug.cgi?id=94485
"Two of the new tests always failed on Mac bots" (Requested by
bradee-oh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-20
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
- css3/compositing/blend-mode-property-expected.txt: Removed.
- css3/compositing/blend-mode-property-parsing-expected.txt: Removed.
- css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Removed.
- css3/compositing/blend-mode-property-parsing-invalid.html: Removed.
- css3/compositing/blend-mode-property-parsing.html: Removed.
- css3/compositing/blend-mode-property.html: Removed.
- css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Removed.
- css3/compositing/script-tests/blend-mode-property-parsing.js: Removed.
- css3/compositing/script-tests/blend-mode-property.js: Removed.
- 8:18 AM Changeset in webkit [126031] by
-
- 4 edits in trunk/Source
[Qt] Custom tap-highlight-color renders fully opaque
https://bugs.webkit.org/show_bug.cgi?id=94468
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Adjust the default tap-highlight-color to figure in that is will be
drawn semi-transparent.
- rendering/RenderTheme.h:
(RenderTheme):
Source/WebKit2:
Draw tap-highlight-color at 50% transparency, to better match how
existing WebKit browsers act on custom tap-highlight colors.
- WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::drawRect):
- 8:10 AM Changeset in webkit [126030] by
-
- 9 edits in trunk/Source/WebKit2
[GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html
https://bugs.webkit.org/show_bug.cgi?id=94471
Reviewed by Martin Robinson.
In WebKit1 there's code to prevent that load signals are emitted
when loading internal custom error pages. We added
webkit_web_view_replace_content() with the same idea, but it has
ended up being problematic, because it allows to add any HTML
content (in WebKit1 we assumed internal error pages never failed
and always loaded) and it's impossible to know when the load has
finished. It also required a lot of logic to handle
replace_content as an especial case, in order to hide the fact
that it loads content. This patch renames
webkit_web_view_replace_content() as
webkit_web_view_load_alternate_html() and emit load events
normally.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate):
(webkitWebViewLoadChanged):
(webkitWebViewLoadFailed):
(webkitWebViewSetEstimatedLoadProgress):
(webkitWebViewResourceLoadStarted):
(webkitWebViewGetLoadingWebResource):
(webkitWebViewRemoveLoadingWebResource):
(webkitWebViewResourceLoadFinished):
(webkit_web_view_load_alternate_html):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testLoadAlternateHTML):
(beforeAll):
- UIProcess/API/gtk/tests/TestResources.cpp:
(beforeAll):
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(beforeAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadAlternateHTML):
- UIProcess/API/gtk/tests/WebViewTest.h:
- 8:09 AM Changeset in webkit [126029] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10855246
- 8:05 AM Changeset in webkit [126028] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Add minimum transport protocol from backend to frontend
https://bugs.webkit.org/show_bug.cgi?id=88973
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-20
Reviewed by Pavel Feldman.
Added the following protocol methods to communicate with the WebGL injected
module: captureFrame, getTraceLog, dropTraceLog, replayTraceLog.
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScriptWebGLModule.cpp:
(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::getTraceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):
- inspector/InjectedScriptWebGLModule.h:
(InjectedScriptWebGLModule):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):
- inspector/InspectorWebGLAgent.h:
(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):
- 8:04 AM Changeset in webkit [126027] by
-
- 8 edits3 deletes in trunk/LayoutTests
Update canvas tests that are using CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=94474
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
Reviewed by Andreas Kling.
CanvasPixelArray is deprecated. W3C already updated these tests on the
approved tests repository. Using Uint8ClampedArray, they now pass on
WebKit.
- canvas/philip/tests/2d.imageData.create1.type.html:
- canvas/philip/tests/2d.imageData.create2.type.html:
- canvas/philip/tests/2d.imageData.get.type.html:
- platform/chromium/TestExpectations:
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.imageData.get.type-expected.txt: Removed.
- platform/qt/Skipped:
- 7:50 AM Changeset in webkit [126026] by
-
- 5 edits2 adds in trunk
[TouchAdjustment] Adjust to word or selection
https://bugs.webkit.org/show_bug.cgi?id=94449
Reviewed by Antonio Gomes.
Source/WebCore:
Makes each separate word a separate subtarget when context menu triggers
selections, and only the selected part of a partial selected node a
target when selections are not overridden.
Test: touchadjustment/context-menu-text-subtargets.html
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendQuadsToSubtargetList):
(WebCore::TouchAdjustment::appendBasicSubtargetsForNode):
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
LayoutTests:
Tests that touch-adjustment can adjust to the right subtargets within text-nodes.
- touchadjustment/context-menu-select-text.html:
- touchadjustment/context-menu-text-subtargets-expected.txt: Added.
- touchadjustment/context-menu-text-subtargets.html: Added.
- touchadjustment/resources/touchadjustment.js:
(pointToString):
(shouldBeWithin):
- 7:34 AM Changeset in webkit [126025] by
-
- 3 edits in trunk/LayoutTests
Not reviewed: fixing flaky inspector test.
- http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- 6:57 AM Changeset in webkit [126024] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Fixing the failure expectations for a flaky crasher XFrameOptions test
in debug builds. When it doesn't crash it fails due to text diff.
- platform/gtk/TestExpectations:
- 6:24 AM Changeset in webkit [126023] by
-
- 13 edits in trunk
The 2d.imageData.object.round canvas test is failing
https://bugs.webkit.org/show_bug.cgi?id=40272
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Source/WTF:
According to the Uint8ClampedArray spec (http://www.khronos.org/registry/typedarray/specs/latest/#7.1)
which references WebIDL's clamping rules, with implications defined in http://www.w3.org/TR/WebIDL/#es-octet
we need to round to nearest integer, and to the even one if exactly halfway in between.
As a solution: applying C99's lrint which, in default rounding mode, does that.
The updated version of test 2d.imageData.object.round.html test passes now.
- wtf/MathExtras.h:
(lrint): Assembly based implementation for MSVC under X86, otherwise falling back to casting.
- wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::set): lrint instead of simple rounding.
LayoutTests:
Fixing expectations for the imageData rounding test, unskipping the tests on all ports.
- canvas/philip/tests/2d.imageData.object.round.html: Fixing expected results according to "round to even in halfway case".
- fast/canvas/canvas-ImageData-behaviour-expected.txt: Fixing expected results according to "round to even in halfway case".
- fast/canvas/canvas-ImageData-behaviour.js: Fixing expected results according to "round to even in halfway case".
- platform/chromium/TestExpectations: Updating bug id for 2d.imageData.object.round.html and for wrap case, adding SVG case for rebaselining.
- platform/efl/Skipped: 2d.imageData.object.round.html
- platform/efl/TestExpectations: Moving 2d.imageData.object.wrap.html case here with new bug id.
- platform/gtk/TestExpectations: Unskippng 2d.imageData.object.round.html, updating bug id for wrap case.
- platform/mac/Skipped: Unskipping 2d.imageData.object.round.html.
- platform/qt/Skipped: Unskipping 2d.imageData.object.round.html.
- 5:45 AM Changeset in webkit [126022] by
-
- 3 edits in trunk/Source/WebKit/efl
Regression(r124945): Build is broken when touch events is disabled
https://bugs.webkit.org/show_bug.cgi?id=94466
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Added missing guards around touch events code.
- ewk/ewk_touch_event.cpp:
- ewk/ewk_touch_event_private.h:
- 5:25 AM Changeset in webkit [126021] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow
https://bugs.webkit.org/show_bug.cgi?id=94464
Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-20
Reviewed by Carlos Garcia Campos.
Provide a compatibility method to access the new 'overset'
property through the old 'overflow' name in
WebKitDOMWebKitNamedFlow. Note that trying to access it through
g_object_get directly will give a runtime warning, since the
property does not actually exist anymore; this is done purely to
maintain API compatibility.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_webkit_named_flow_get_overflow): add method.
- bindings/gobject/WebKitDOMCustom.h:
- 5:21 AM Changeset in webkit [126020] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update flaky tests to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=94467
Unreviewed EFL gardening. Mark several tests as
flaky in order to make the bots green.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
- platform/efl/TestExpectations:
- 4:52 AM Changeset in webkit [126019] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add unit tests for WKEinaSharedString
https://bugs.webkit.org/show_bug.cgi?id=94104
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
Added unit tests for WKEinaSharedString class.
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp: Added.
(checkString):
(TEST_F):
- 4:01 AM Changeset in webkit [126018] by
-
- 12 edits in trunk/Source
[chromium] Convert screen space scroll gestures to layer space
https://bugs.webkit.org/show_bug.cgi?id=92499
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-08-20
Reviewed by James Robinson.
Source/WebCore:
Scroll gestures should be converted from screen space to local layer space to
correctly apply the scroll delta to page scaled and/or transformed layers.
Visually this means that the scrolled content will always follow the user's
finger for any "well-formed" layer transform.
Wheel scroll deltas will still be directly interpreted as local layer scroll
coordinates.
We also adjust the logic for propagating ("bubbling") scroll events to parent
layers. Previously a parent layer was allowed to scroll in the screen-space
axis orthogonal to the direction the starting layer scrolled toward. For
example if a vertically scrolling layer is scrolled diagonally down and right,
the layer moves down and its parent to the right.
This patch generalizes this behavior to non-axis aligned transformed layers so
that the scrolling direction of any parent is constrained to be perpendicular
direction of movement of the starting layer. This makes the scrolling behavior
of transformed layers physically plausible. For instance, assume a 45 degree
rotated, vertically scrollable layer. Dragging your finger vertically
(relative to the layer) scrolls the layer up and down, while horizontal
movement results in the parent of the layer moving in a corresponding way.
Since generally users want to scroll a single layer in one direction, this
patch also introduces a rule that if the resulting movement of a layer is
within 45 degrees of the original scroll input, the bubbling process is
stopped. This makes it possible to reliably scroll a single layer without
affecting any of its parents.
Added new unit tests:
CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollScaledLayer
CCMathUtilTest.smallestAngleBetweenVectors
CCMathUtilTest.vectorProjection
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::scrollLayerWithScreenSpaceDelta):
(WebCore):
(WebCore::scrollLayerWithLocalDelta):
(WebCore::CCLayerTreeHostImpl::scrollBy):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::smallestAngleBetweenVectors):
(WebCore):
(WebCore::CCMathUtil::projectVector):
- platform/graphics/chromium/cc/CCMathUtil.h:
(CCMathUtil):
Source/WebKit/chromium:
Added new tests for verifying transformed layer scrolling:
CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer
CCLayerTreeHostImplTest.scrollScaledLayer
Also some tests for the introduced math utilities:
CCMathUtilTest.smallestAngleBetweenVectors
CCMathUtilTest.vectorProjection
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- tests/CCLayerTreeHostImplTest.cpp: Adjusted scroll delta in scrollChildBeyondLimit to avoid triggering the 45 degree rule.
- tests/CCLayerTreeHostTest.cpp:
- tests/CCMathUtilTest.cpp:
- tests/WebCompositorInputHandlerImplTest.cpp:
(MockCCInputHandlerClient):
(WebKit::TEST_F):
- 3:27 AM Changeset in webkit [126017] by
-
- 11 edits in trunk/Source
[GTK] Add API to set preferred languages to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90878
Source/WebCore:
Unreviewed. Fix mac build.
- WebCore.exp.in: Export WebCore::languageDidChange().
Source/WebKit2:
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages): Public API to set a
list of preferred languages sorted from most desirable to least
desirable.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextLanguages):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(resourceGetDataCallback):
(WebViewTest::mainResourceData): Moved from TestWebKitWebContext
to make it available to all WebViewTests.
- UIProcess/API/gtk/tests/WebViewTest.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged): Notify our
observer that the languages have been overriden.
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::buildAcceptLanguages): Helper function to build the
accept languages as specified in RFC 2616.
(WebKit::setSoupSessionAcceptLanguage): Set the accept-language
property of the default SoupSession.
(WebKit::languageChanged): Update the preferred languages in
SoupSession.
(WebKit::WebProcess::platformInitializeWebProcess): Add an
observer to be notified when the list of preferred languages is
updated.
(WebKit::WebProcess::platformTerminate): Remove the observer added
in platformInitializeWebProcess().
- 3:05 AM Changeset in webkit [126016] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: improve standalone test harness to allow attaching to inspector before test.
https://bugs.webkit.org/show_bug.cgi?id=94426
Reviewed by Vsevolod Vlasov.
- User can not "Debug", attach inspector to the front-end and "Continue" test execution.
- You can also assign filter from the query parameter.
- inspector/front-end/test-runner.html:
- 2:38 AM Changeset in webkit [126015] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark several inspector tests as flaky
https://bugs.webkit.org/show_bug.cgi?id=94452
Unreviewed EFL gardening. Mark several inspector
tests as flaky to make the bots green.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
- platform/efl/TestExpectations:
- 2:33 AM Changeset in webkit [126014] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Moving a couple of WONTFIX accessibility tests into the appropriate
section.
Removing crash expectations for a few accessibility tests that were fixed
in r125920.
Adding a flaky crash expectation for a XFrameOptions http test.
Adding platform-specific baselines for a few css3 compositing tests that fail
differently because of using JavaScriptCore instead of V8.
- platform/gtk/TestExpectations:
- platform/gtk/css3/compositing: Added.
- platform/gtk/css3/compositing/blend-mode-property-expected.txt: Added.
- platform/gtk/css3/compositing/blend-mode-property-parsing-expected.txt: Added.
- 2:29 AM Changeset in webkit [126013] by
-
- 3 edits in trunk/Tools
Add mountain lion to build config.
https://bugs.webkit.org/show_bug.cgi?id=94441
Reviewed by Adam Barth.
Add Mountain Lion to the build trigger configurations.
- Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
- Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
- 2:27 AM Changeset in webkit [126012] by
-
- 23 edits1 move3 adds in trunk
Web Inspector: load scripts panel lazily
https://bugs.webkit.org/show_bug.cgi?id=94416
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- removes access to WebInspector.panels.scripts and loads it lazily.
- extracts classes to their own files when classes residing in one file belong to different modules
- removes StylesPanel.js in favor of the actual classes it contains
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/compile-front-end.py:
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype.handleShortcut):
- inspector/front-end/BreakpointsSidebarPane.js:
- inspector/front-end/FilteredItemSelectionDialog.js:
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI._pendingCommands.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
- inspector/front-end/NativeBreakpointsSidebarPane.js: Added.
(WebInspector.NativeBreakpointsSidebarPane):
(WebInspector.NativeBreakpointsSidebarPane.prototype._addListElement):
(WebInspector.NativeBreakpointsSidebarPane.prototype._removeListElement):
(WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
- inspector/front-end/ScriptSnippetModel.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
- inspector/front-end/SnippetJavaScriptSourceFrame.js: Added.
(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
- inspector/front-end/StyleSheetOutlineDialog.js: Added.
(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemSubtitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
(WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):
- inspector/front-end/StyleSource.js: Renamed from Source/WebCore/inspector/front-end/StylesPanel.js.
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
(WebInspector.StyleSource):
(WebInspector.StyleSource.prototype.isEditable):
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
(WebInspector.StyleSource.prototype._callOrSetTimeout):
(WebInspector.StyleSource.prototype._commitIncrementalEdit):
(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
(WebInspector.InspectorStyleSource):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
(WebInspector._showAnchorLocation):
Source/WebKit/chromium:
- WebKit.gyp:
LayoutTests:
This change removes access to WebInspector.panels.scripts and loads it lazily.
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/filtered-item-selection-dialog-filtering.html:
- inspector/styles/edit-inspector-stylesheet.html:
- inspector/tabbed-editors-history.html:
- 2:16 AM Changeset in webkit [126011] by
-
- 2 edits in trunk/LayoutTests
[EFL] Move CSS 3 compositing tests to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=94451
Unreviewed EFL gardening. Skip css3/compositing test
cases for EFL port until we turn on CSS_COMPOSITING
compile flag.
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-20
- platform/efl/TestExpectations:
- 2:09 AM Changeset in webkit [126010] by
-
- 6 edits2 deletes in trunk
[EFL] Get rid of pango backend support once harfbuzz-ng is working
https://bugs.webkit.org/show_bug.cgi?id=92102
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20
Reviewed by Kenneth Rohde Christiansen.
.:
Removing choice of font backend, Pango detection not required any more.
- Source/cmake/FindPango.cmake: Removed.
- Source/cmake/LibFindMacros.cmake: Removed.
- Source/cmake/OptionsEfl.cmake: Removing choice of font backend.
Source/WebCore:
Removing support for Pango complex font rendering now that we HarfBuzz.
No new tests, no change in behavior.
- PlatformEfl.cmake: Removing Pango specific includes and libraries.
Source/WebKit:
Removing pango-specific includes and libraries.
- PlatformEfl.cmake: Pango sections removed.
- 2:00 AM Changeset in webkit [126009] by
-
- 12 edits in trunk
Web Inspector: prepare scripts panel to be lazily loaded
https://bugs.webkit.org/show_bug.cgi?id=94423
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- makes scripts panel read workspace data upon creation
- moves pause on script state management into the debugger model
- updates frontend API to use debugger model, not scripts panel
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.debuggerEnabled):
(WebInspector.DebuggerModel.prototype.disableDebugger):
(WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
(WebInspector.DebuggerModel.prototype._pauseOnExceptionStateChanged):
(WebInspector.DebuggerModel.prototype.get _debuggerWasDisabled):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI._pendingCommands.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
(WebInspector.ScriptsPanel.prototype._enableDebugging):
(WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.disableDebugger):
- inspector/debugger/debugger-autocontinue-on-syntax-error.html:
- inspector/debugger/debugger-pause-in-internal.html:
- inspector/debugger/debugger-pause-on-exception.html:
- inspector/debugger/scripts-panel-expected.txt:
- 1:47 AM Changeset in webkit [126008] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Adapt to changes in the platform media player API
https://bugs.webkit.org/show_bug.cgi?id=94329
PR #194237
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-20
Reviewed by Antonio Gomes.
The interface to platform's media player has changed from MMRPlayer
to PlatformPlayer. This patch adapts to this change.
And we also decided to postpone the creation of PlatformPlayer until
the loading started. This is needed because we may create different
types of player for different media sources.
This is a refactor, no new tests.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::notifyAppActivatedEvent):
(WebCore::MediaPlayerPrivate::setCertificatePath):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivate::movieLoadType):
(WebCore::MediaPlayerPrivate::setAllowPPSVolumeUpdates):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore):
(WebCore::MediaPlayerPrivate::onStateChanged):
(WebCore::MediaPlayerPrivate::onMediaStatusChanged):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::showErrorDialog):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- 1:23 AM Changeset in webkit [126007] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove FAIL expectation fixed by r126006
- platform/chromium/TestExpectations:
- 1:14 AM Changeset in webkit [126006] by
-
- 2 edits in trunk/LayoutTests
[chromium] context-menu.html fails on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94367
Reviewed by Kenneth Rohde Christiansen.
Set editing behaviour explicitly so the test behaves the same independent of host OS.
- touchadjustment/context-menu.html:
- 1:05 AM WebKit Team edited by
- (diff)
- 12:53 AM Changeset in webkit [126005] by
-
- 8 edits in trunk/Source
[V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94446
Reviewed by Adam Barth.
To kill V8Proxy, we can move contextDebugId() and setContextDebugId()
from V8Proxy to ScriptController.
No tests. No change in behavior.
Source/WebCore:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
(WebCore):
(WebCore::ScriptController::contextDebugId):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didCreateScriptContext):
- 12:47 AM Changeset in webkit [126004] by
-
- 7 edits in trunk/Source/WebCore
[V8] Move V8Proxy::newInstance() to V8ObjectConstructor
https://bugs.webkit.org/show_bug.cgi?id=94443
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves V8Proxy::newInstance() to
V8ObjectConstructor::newInstanceInFrame().
In addition, this patch does the following things:
- For consistency with V8ObjectConstructor::newInstanceInFrame(),
this patch inserts an if(v8::V8::IsDead()) check to just after
Function::NewInstance(). The check is done by V8Binding::assertIfV8IsDead().
- To avoid #include circular dependency, this patch de-inline
V8ObjectConstructor::newInstance()s. I didn't observe any perf regression.
I don't think these methods are worth being inlined, because
these methods call Function::NewInstance(), which is not inlined
and calls a bunch of heavy mehtods in V8.
No tests. No change in behavior.
- bindings/v8/NPV8Object.cpp:
(_NPN_Construct):
- bindings/v8/V8Binding.cpp:
(WebCore::assertIfV8IsDead):
(WebCore):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8ObjectConstructor.cpp:
(WebCore::V8ObjectConstructor::newInstance):
(WebCore):
(WebCore::V8ObjectConstructor::newInstanceInFrame):
- bindings/v8/V8ObjectConstructor.h:
(WebCore):
(V8ObjectConstructor):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::instrumentedCallFunction):
- 12:38 AM Changeset in webkit [126003] by
-
- 2 edits in trunk/LayoutTests
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94439
Unreviewed. Temporary disabled these tests.
- platform/chromium/TestExpectations: Add entries for these tests.
- 12:33 AM Changeset in webkit [126002] by
-
- 8 edits in trunk/Source
[V8] Move V8Proxy::m_extensions to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94444
Reviewed by Adam Barth.
Source/WebCore:
To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController.
This patch also renames extensions() to registeredExtensions() for clarification.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::registeredExtensions):
(WebCore):
(WebCore::ScriptController::registerExtensionIfNeeded):
- bindings/v8/ScriptController.h:
(WebCore):
(ScriptController):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(WebCore):
(V8Proxy):
Source/WebKit/chromium:
To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController.
No tests. No change in behavior.
- src/WebScriptController.cpp:
(WebKit::WebScriptController::registerExtension):
- 12:21 AM Changeset in webkit [126001] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: toolbar causes 8 reflows upon opening
https://bugs.webkit.org/show_bug.cgi?id=94422
Reviewed by Yury Semikhatsky.
Toolbar's overflow code causes inspector to do 8 reflows upon opening.
Fixing it via introducing batch toolbar update.
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.setCoalescingUpdate):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
- inspector/front-end/inspector.css:
(body.compact .toolbar-icon):
(body.compact .toolbar-icon.custom-toolbar-icon):
(body.compact .toolbar-item:active .toolbar-icon):
(body.compact .toolbar-label):
(body.compact .toolbar-item.resources .toolbar-icon):
(body.compact .toolbar-item.network .toolbar-icon):
(body.compact .toolbar-item.scripts .toolbar-icon):
(body.compact .toolbar-item.timeline .toolbar-icon):
(body.compact .toolbar-item.profiles .toolbar-icon):
(body.compact .toolbar-item.audits .toolbar-icon):
(body.compact .toolbar-item.console .toolbar-icon):
- inspector/front-end/inspector.js:
(WebInspector.get _setCompactMode):
(WebInspector.windowResize):
Aug 19, 2012:
- 11:51 PM Changeset in webkit [126000] by
-
- 2 edits in trunk/Source/WebCore
[V8] Replace proxy()->windowShell() in ScriptController with windowShell()
https://bugs.webkit.org/show_bug.cgi?id=94445
Reviewed by Adam Barth.
Now ScriptController owns windowShell. So ScriptController doesn't
need to get windowShell through V8Proxy.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::updateSecurityOrigin):
(WebCore::ScriptController::haveInterpreter):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::namedItemAdded):
(WebCore::ScriptController::namedItemRemoved):
- 11:11 PM Changeset in webkit [125999] by
-
- 17 edits1 add in trunk/Source/JavaScriptCore
The relationship between abstract values and structure transition watchpoints should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=94205
Reviewed by Geoffrey Garen.
This patch does a number of things related to the handling of the abstract values
arrising from values with structures known to be watchpointable:
- This rationalizes the relationship between the structure that we know an object to have *right now* based on having executed a check against that structure, and the structure that we know the object could have *in the future* based on a type check executed in the past over a structure that was watchpointable.
- We use the above to assert that structure transition watchpoints are being used soundly.
- We use the above to strength reduce CheckStructure into StructureTransitionWatchpoint whenever possible.
- This rationalizes the handling of CFA over constants that appeared in the bytecode. If at compile-time the constant has a watchpointable structure, then we can prove what structures it may have in the future. The analysis uses this to both assert that structure transition watchpoints are being used correctly, and to find opportunities for using them more aggressively.
The net effect of all of these changes is that OSR entry should work more smoothly.
It may also be a slight win due to strength reductions, though most of those strength
reductions would have already been done by the parser and the structure check hoister.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractValue.h:
(DFG):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(AbstractValue):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterValueByType):
(JSC::DFG::AbstractValue::validateType):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
(Node):
(JSC::DFG::Node::hasStructure):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::forwardSpeculationWatchpoint):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpointWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculateArray):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.h: Added.
(DFG):
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::addAll):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::isClearOrTop):
(JSC::DFG::StructureAbstractValue::isNeitherClearNorTop):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::last):
(JSC::DFG::StructureAbstractValue::speculationFromStructures):
(JSC::DFG::StructureAbstractValue::hasSingleton):
(JSC::DFG::StructureAbstractValue::singleton):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::dump):
(JSC::DFG::StructureAbstractValue::topValue):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 10:18 PM Changeset in webkit [125998] by
-
- 12 edits in trunk/Source/WebCore
[V8] Move V8Proxy::callFunction() to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94437
Reviewed by Adam Barth.
To kill V8Proxy, this patch moves callFunction() from V8Proxy to ScriptController.
No tests. No change in behavior.
- bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
- bindings/v8/NPV8Object.cpp:
(_NPN_Invoke):
(_NPN_InvokeDefault):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h:
(WebCore):
(ScheduledAction):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunction):
(WebCore):
(WebCore::ScriptController::callFunctionEvenIfScriptDisabled):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::callListenerFunction):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
- 10:11 PM Changeset in webkit [125997] by
-
- 9 edits in trunk/Source/WebCore
[Forms] Set SpinButtonElement free from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=93941
Reviewed by Kent Tamura.
This patch removes dependency to HTMLInputElement from SpinButtonElement.
Functionalities used to be calling HTMLInputElement functions are
replaced to calling functions SpinButtonOwner class.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::focusAndSelectSpinButtonOwner): Moved functionality from SpinButtonElement::defaultEventHandler.
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents): Moved code from SpinButtonElement::willRespondToMouseClickEvents
(WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents): Moved code from SpinButtonElement::forwardEvent
- html/TextFieldInputType.h:
(TextFieldInputType):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::focusAndSelectEditControlOwner): Moved functionality from SpinButtonElement::defaultEventHandler.
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerFocused): Added for DateTimeEditElement::shouldSpinButtonRespondToWheelEvents.
- html/TimeInputType.h:
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::focusAndSelectSpinButtonOwner): Added for SpinButtonElementOwner class change.
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToMouseEvents): ditto
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToWheelEvents): ditto
- html/shadow/DateTimeEditElement.h:
(EditControlOwner): Added new virtual function declarations for SpinButtonElementOwner class change.
(DateTimeEditElement): Added new function declarations for SpinButtonElementOwner.
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::defaultEventHandler): Changed to use SpinButtonElementOwner instead of HTMLInputElement.
(WebCore::SpinButtonElement::forwardEvent): ditto
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto
(WebCore::SpinButtonElement::step): ditto
(WebCore::SpinButtonElement::shouldRespondToMouseEvents): Added helper function for calling SpinButtonOwner instance.
- html/shadow/SpinButtonElement.h:
(SpinButtonOwner): Added new virtual function declarations.
(SpinButtonElement):
- 9:52 PM Changeset in webkit [125996] by
-
- 11 edits in trunk
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=94439
Reviewed by Kent Tamura.
Source/WebCore:
This patch disabled CSS selector for Firefox compatibility applied to
multiple fields time input UI, because it is supposed to apply text
field rather than multiple fields.
This patch allows us to have same appearance among Chromium-Linux,
Mac and Win.
No new tests. Following existing tests cover this change:
fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html
- css/themeWin.css: Exclude input[type="time"] selector if ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
enabled.
LayoutTests:
This patch updates expected images of multiple fields time input UI for
Chromium-Linux and CSS selectors for expected HTML file for changing
of Source/WebCore/css/themeWin.css.
- fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.css:
(.host): Changed padding property.
(.ampmField): Remove wrong property.
(.hourField): ditto
(.millisecondField): ditto
(.minuteField): ditto
(.secondField): ditto
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt:
- platform/chromium/TestExpectations: Remove Chromium-Mac disabled entries.
- 9:39 PM Changeset in webkit [125995] by
-
- 14 edits2 moves in trunk/Source/WebCore
[V8] Rename SafeAllocation to V8ObjectConstructor
https://bugs.webkit.org/show_bug.cgi?id=94436
Reviewed by Adam Barth.
For clarification.
No tests. No change in behavior.
- UseV8.cmake:
- WebCore.gypi:
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::construct):
- bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
- bindings/v8/V8Binding.h:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8NPObject.cpp:
(WebCore::createV8ObjectForNPObject):
- bindings/v8/V8ObjectConstructor.cpp: Renamed from Source/WebCore/bindings/v8/SafeAllocation.cpp.
(WebCore):
(WebCore::V8ObjectConstructor::isValidConstructorMode):
- bindings/v8/V8ObjectConstructor.h: Renamed from Source/WebCore/bindings/v8/SafeAllocation.h.
(WebCore):
(ConstructorMode):
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(V8ObjectConstructor):
(WebCore::V8ObjectConstructor::newInstance):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::createInjectedScriptHostV8Wrapper):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- 9:35 PM EFLWebKitTests edited by
- (diff)
- 9:32 PM Changeset in webkit [125994] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Put webkit compositor binding files in separate conditionally included gyp section
https://bugs.webkit.org/show_bug.cgi?id=94392
Patch by James Robinson <jamesr@chromium.org> on 2012-08-19
Reviewed by Dirk Pranke.
This allows the use_libcc_for_compositor gyp variable to control whether the webkit bindings are pulled from the
WebKit repository or an external target.
- WebKit.gyp:
- WebKit.gypi:
- 9:32 PM Changeset in webkit [125993] by
-
- 6 edits in trunk/Source/WebCore
[V8] Move m_windowShell from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94438
Reviewed by Adam Barth.
m_windowShell should be owned by ScriptController.
After this change, I can move a bunch of V8Proxy methods
that access windowShell() from V8Proxy to ScriptController.
No tests. No change in behavior.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
- bindings/v8/ScriptController.h:
(WebCore):
(WebCore::ScriptController::windowShell):
(ScriptController):
- bindings/v8/V8Binding.h:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::windowShell):
(WebCore):
- bindings/v8/V8Proxy.h:
(WebCore):
(WebCore::V8Proxy::frame):
(V8Proxy):
- 9:03 PM Changeset in webkit [125992] by
-
- 2 edits in trunk/Source/WebCore
Do not allocate SQLiteDatabase's m_openErrorMessage until its needed
https://bugs.webkit.org/show_bug.cgi?id=94434
Reviewed by Andreas Kling.
Previously, m_openErrorMessage was initialized from a static literal string whenever
the database is not open.
This patch changes the way we use m_openErrorMessage to only allocate a string in the
few cases where we need it. If there is no error message, we fallback to the previous
default string.
The goal is to prevent allocating the string unless needed. That saves initialization time
and memory.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastErrorMsg):
- 8:44 PM Changeset in webkit [125991] by
-
- 2 edits in trunk/Source/WebCore
Use initialization from literal for HTML Input type names
https://bugs.webkit.org/show_bug.cgi?id=94421
Reviewed by Kent Tamura.
AtomicString's initialization from literal is faster and use less memory.
- html/InputType.cpp:
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):
- 8:39 PM Changeset in webkit [125990] by
-
- 2 edits in trunk/Source/WebCore
Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT
https://bugs.webkit.org/show_bug.cgi?id=94420
Reviewed by Kentaro Hara.
Use the new StringBuilder::appendLiteral() instead of keeping some WTF::String in
memory.
The patch reduces memory usage.
It also reduces the binary size (-1672 bytes on x86_64).
I did not measure any difference in performance.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
- 8:33 PM Changeset in webkit [125989] by
-
- 15 edits11 adds in trunk
Source/WebCore: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-19
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
Tests: css3/compositing/blend-mode-property-parsing-invalid.html
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore):
(WebCore::RenderLayerBacking::updateLayerBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests: parse CSS attribute -webkit-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=94024
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-08-19
Reviewed by Dirk Schulze.
Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/
- css3/compositing: Added.
- css3/compositing/blend-mode-property-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid-expected.txt: Added.
- css3/compositing/blend-mode-property-parsing-invalid.html: Added.
- css3/compositing/blend-mode-property-parsing.html: Added.
- css3/compositing/blend-mode-property.html: Added.
- css3/compositing/script-tests: Added.
- css3/compositing/script-tests/blend-mode-property-parsing-invalid.js: Added.
(testInvalidFilterRule):
- css3/compositing/script-tests/blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testFilterRule):
- css3/compositing/script-tests/blend-mode-property.js: Added.
- 7:56 PM Changeset in webkit [125988] by
-
- 7 edits2 adds in trunk
DOM mutation against including <link> shouldn't trigger pending HTML parser.
https://bugs.webkit.org/show_bug.cgi?id=93641
Reviewed by Ryosuke Niwa.
Source/WebCore:
HTMLLinkElement::removedFrom() invoked Document::removePendingSheet(), which can trigger
HTMLParser that can mutate DOM tree. DOM mutation reentrancy on like this is problematic and
should be prohibited.
This change add an variation of Document::removePendingSheet() which postpones the notification
which triggers DOM mutation, and flush such pending notifications at the end of ongoing mutation.
Test: http/tests/loading/remove-child-triggers-parser.html
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeRemovalNotifier::notify): Flushed pending notifications at the end.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::removePendingSheet): Added RemovePendingSheetNotificationType parameter.
(WebCore):
(WebCore::Document::didRemoveAllPendingStylesheet): Extracted from removePendingSheet()
- dom/Document.h:
(Document):
(WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet): A flag setter.
(WebCore::Document::notifyRemovePendingSheetIfNeeded):
(WebCore):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::removedFrom): Switched to use "notification later" version of removePendingSheet()
(WebCore::HTMLLinkElement::removePendingSheet): Added RemovePendingSheetNotificationType parameter.
- html/HTMLLinkElement.h:
LayoutTests:
Note that the test content need to be such cryptic because HTML parser is involving the
captured bug and adding explanations can affect the behavior then mask the bug.
- http/tests/loading/remove-child-triggers-parser-expected.txt: Added.
- http/tests/loading/remove-child-triggers-parser.html: Added.
- 7:30 PM Changeset in webkit [125987] by
-
- 2 edits2 deletes in trunk/LayoutTests
[EFL] Gardening for fast/forms/range/thumbslider-no-parent-slider.html
https://bugs.webkit.org/show_bug.cgi?id=94334
Unreviewed gardening.
Slider thumb can not be displayed without parent slider because
current theme of EFL does not display slider thumb separately.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-19
- platform/efl/TestExpectations:
- platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
- platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- 7:25 PM Changeset in webkit [125986] by
-
- 3 edits in trunk/LayoutTests
[Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=94297
Reviewed by Kent Tamura.
This patch updates a logic for detcting multiple fields time input UI
has second field or not.
- fast/forms/time-multiple-fields/resources/time-multiple-fields-appearance.js:
(checkHasShortFormat): Added "<br>" between input elements to avoid rounding error
on calculating rendering width of input elements. When input elements are rendered on
same baseline, width of first one is 126px and second is 125px.
- platform/chromium/TestExpectations: Changed bug id of entries Chromium-Mac specific bug entry, bug 94339.
- 6:31 PM Changeset in webkit [125985] by
-
- 3 edits in trunk/Source/WebCore
Remove RefPtr from HTMLProgressElement::m_value
https://bugs.webkit.org/show_bug.cgi?id=94336
Reviewed by Kent Tamura.
To avoid reference cycles of RefPtr<Node>s, we want to remove
unnecessary RefPtr<Node>s. The rationale is described in bug 94324.
HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because
it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement
node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.
No tests. No change in behavior.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLProgressElement.h:
- 6:08 PM Changeset in webkit [125984] by
-
- 3 edits in trunk/Source/WebCore
Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_cancelButton
https://bugs.webkit.org/show_bug.cgi?id=94339
Reviewed by Kent Tamura.
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary
RefPtr<Node>s. The rationale is described in bug 94324.
SearchInputType::m_resultsButton and SearchInputType::m_cancelButton do not
need to be RefPtr<Node>s, because they are guaranteed to point to the shadow
DOM tree of the SearchInputType node, which is guaranteed to exist in the
subtree of the SearchInputType node.
No tests. No change in behavior.
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
(WebCore::SearchInputType::destroyShadowSubtree):
(WebCore::SearchInputType::subtreeHasChanged):
- html/SearchInputType.h:
(SearchInputType):
- 3:39 PM Changeset in webkit [125983] by
-
- 5 edits4 adds in trunk
CSP 1.1: Add 'plugin-types' and 'form-action' DOM API.
https://bugs.webkit.org/show_bug.cgi?id=94415
Patch by Mike West <mkwst@chromium.org> on 2012-08-19
Reviewed by Adam Barth.
Source/WebCore:
Experimental implementations of the new 'plugin-types' and 'form-action'
directives recently landed, but we neglected to add DOM API endpoints to
query their state. Those APIs have been added to the specification[1],
and this patch brings our implementation up to date.
Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html
- page/DOMSecurityPolicy.cpp:
(isAllowed):
As a drive-by, change a parameter from a KURL to a String to match
the actual template. There's no reason to stringify an empty URL
when we can just use an empty string instead.
(isAllowedWithType):
Call out to the ContentSecurityPolicy object to check the protected
resource's ability to load a given media type.
(WebCore::DOMSecurityPolicy::allowsFormAction):
Call out to the ContentSecurityPolicy object to check the protected
resource's ability to submit a form to the given URL.
(WebCore):
(WebCore::DOMSecurityPolicy::allowsPluginType):
Pipes the plugin type through 'isAllowedWithType' for resolution.
- page/DOMSecurityPolicy.h:
Add the 'allowsPluginType' and 'allowsFormAction' methods.
(DOMSecurityPolicy):
- page/DOMSecurityPolicy.idl:
Add the 'allowsPluginType' and 'allowsFormAction' methods.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowformaction.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowplugintype.html: Added.
- 2:59 PM Changeset in webkit [125982] by
-
- 14 edits in trunk/Source/JavaScriptCore
The current state of the call frame should be taken into account in the DFG for both predictions and proofs
https://bugs.webkit.org/show_bug.cgi?id=94412
Reviewed by Geoffrey Garen.
This ensures that no matter how smart the DFG gets, it'll always know through
which entrypoint OSR will try to enter, and with which values it will attempt
to do so. For prologue OSR, this has no effect other than adding the current
arguments to the argument predictions. For loop OSR, this makes our treatment
of the loop slightly more conservative - just conservative enough to ensure
that OSR succeeds.
- bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
- bytecode/CodeBlock.h:
(CodeBlock):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::setMostSpecific):
(AbstractValue):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(Graph):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::compileOptimizedFor):
- runtime/ExecutionHarness.h:
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
- 12:49 PM Changeset in webkit [125981] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add additional fields to WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=94238
Patch by Rick Byers <rbyers@chromium.org> on 2012-08-19
Reviewed by James Robinson.
Add a union to WebGestureEvent with per-event-type data, as a first
step to eliminating the overloaded delta fields.
- public/WebInputEvent.h:
(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
- 12:34 PM Changeset in webkit [125980] by
-
- 52 edits in trunk
Web Inspector: load network panel lazily
https://bugs.webkit.org/show_bug.cgi?id=94414
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change removes access to WebInspector.panels.network and loads it lazily.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.clone):
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.create):
- inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.NetworkLog.prototype.requestForId):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.compileCallback):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet):
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector._showAnchorLocation):
Source/WebKit/chromium:
- WebKit.gyp:
LayoutTests:
- http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.navigate):
(initialize_InspectorTest.InspectorTest._innerReloadPage):
- http/tests/inspector/network-test.js:
- http/tests/inspector/network/async-xhr-json-mime-type.html:
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html:
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
- http/tests/inspector/network/download.html:
- http/tests/inspector/network/network-cachedresources-with-same-urls.html:
- http/tests/inspector/network/network-clear-cache.html-disabled:
- http/tests/inspector/network/network-clear-cookies.html-disabled:
- http/tests/inspector/network/network-content-replacement-embed.html:
- http/tests/inspector/network/network-content-replacement-xhr.html:
- http/tests/inspector/network/network-cyrillic-xhr.html:
- http/tests/inspector/network/network-disable-cache-memory.html:
- http/tests/inspector/network/network-disable-cache-xhrs.html:
- http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
- http/tests/inspector/network/network-embed.html:
- http/tests/inspector/network/network-empty-xhr.html:
- http/tests/inspector/network/network-iframe-load-and-delete.html:
- http/tests/inspector/network/network-image-404.html:
- http/tests/inspector/network/network-initiator-from-console.html:
- http/tests/inspector/network/network-preview-json.html:
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/network/network-shared-worker.html:
- http/tests/inspector/network/network-sidebar-width.html:
- http/tests/inspector/network/network-size-chunked.html:
- http/tests/inspector/network/network-size-sync.html:
- http/tests/inspector/network/network-size.html:
- http/tests/inspector/network/network-worker.html:
- http/tests/inspector/network/network-xhr-async-double.html:
- http/tests/inspector/network/network-xhr-async.html:
- http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
- http/tests/inspector/network/network-xhr-sync.html:
- http/tests/inspector/network/request-parameters-decoding.html:
- http/tests/inspector/network/x-frame-options-deny.html:
- http/tests/inspector/resource-har-pages.html:
- http/tests/inspector/resource-tree/resource-tree-mimetype.html:
- 12:12 PM Changeset in webkit [125979] by
-
- 2 edits in trunk/Source/WebKit2
WebPageProxy::setCursor does not check that the view is still in an active window
https://bugs.webkit.org/show_bug.cgi?id=94427
Reviewed by Alexey Proskuryakov.
The Web process may ask to change the cursor when the view is in an active window, but
if by the time the UI process receives the message, the view is no longer in a window or the
window is not active , then the cursor should not change.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCursor): Added a check that the view is in an active window before
allowing the page to change the cursor.
- 11:34 AM Changeset in webkit [125978] by
-
- 9 edits in trunk/Source/WebKit2
Unreviewed, rolling out r125972.
http://trac.webkit.org/changeset/125972
https://bugs.webkit.org/show_bug.cgi?id=94431
Breaks AppleMac builds (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-19
- UIProcess/API/gtk/WebKitWebContext.cpp:
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest):
- UIProcess/API/gtk/tests/WebViewTest.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged):
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
- 11:30 AM Changeset in webkit [125977] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r125976.
http://trac.webkit.org/changeset/125976
https://bugs.webkit.org/show_bug.cgi?id=94430
it does not fix build. (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-19
- GNUmakefile.am:
- GNUmakefile.list.am:
- 10:15 AM Changeset in webkit [125976] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.am: Add idl files in Modules/quota to EXTRA_DIST.
- GNUmakefile.list.am: Add missing files to compilation.
- 9:24 AM Changeset in webkit [125975] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r125280-r125284): inspector/console/console-format-collections.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93748
Reviewed by Pavel Feldman.
Not reviewed - simple test fix.
- inspector/console/console-format-collections-expected.txt:
- inspector/console/console-format-collections.html:
- 5:29 AM Changeset in webkit [125974] by
-
- 5 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add API unit tests for Web Intents
https://bugs.webkit.org/show_bug.cgi?id=90454
Patch by Christophe Dumez <Christophe Dumez> on 2012-08-19
Reviewed by Kenneth Rohde Christiansen.
Add unit testing for Web intent requests,
including the "intent,request,new" signal on
the Ewk_View and the Ewk_Intent API.
- UIProcess/API/efl/ewk_view.h: Fix documentation for argument type of "intent,request,new" signal.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseClick): Add utility method to simulate a click at given
coordinates. This is needed for testing functionality that requires a user gesture.
(EWK2UnitTest):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/resources/intent-request.html: Added.
- UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(stringSortCb):
(onIntentReceived):
(TEST_F):
- 5:02 AM Changeset in webkit [125973] by
-
- 2 edits in trunk/Source/WebCore
Remove unused ElementAttributeData::removeAttribute() overload.
<http://webkit.org/b/94425>
Reviewed by Antti Koivisto.
- dom/ElementAttributeData.h:
(ElementAttributeData):
- 2:24 AM Changeset in webkit [125972] by
-
- 9 edits in trunk/Source/WebKit2
[GTK] Add API to set preferred languages to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90878
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages): Public API to set a
list of preferred languages sorted from most desirable to least
desirable.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextLanguages):
(serverCallback):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(resourceGetDataCallback):
(WebViewTest::mainResourceData): Moved from TestWebKitWebContext
to make it available to all WebViewTests.
- UIProcess/API/gtk/tests/WebViewTest.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged): Notify our
observer that the languages have been overriden.
- WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::buildAcceptLanguages): Helper function to build the
accept languages as specified in RFC 2616.
(WebKit::setSoupSessionAcceptLanguage): Set the accept-language
property of the default SoupSession.
(WebKit::languageChanged): Update the preferred languages in
SoupSession.
(WebKit::WebProcess::platformInitializeWebProcess): Add an
observer to be notified when the list of preferred languages is
updated.
(WebKit::WebProcess::platformTerminate): Remove the observer added
in platformInitializeWebProcess().
Aug 18, 2012:
- 5:57 PM Changeset in webkit [125971] by
-
- 3 edits in trunk/Source/WebCore
Refactor SVGMaskElement to inherit from StyledElement
https://bugs.webkit.org/show_bug.cgi?id=94418
Reviewed by Dirk Schulze.
Previously, SVGMaskElement inherited from SVGStyledLocatableElement which includes
several unnecessary functions (e.g., getBBox()). This patch refactors SVGMaskElement
to inherit from SVGStyledElement which matches the spec:
http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement
No new tests as this is just a refactoring.
- svg/SVGMaskElement.cpp:
(WebCore):
(WebCore::SVGMaskElement::SVGMaskElement):
- svg/SVGMaskElement.h:
- 3:56 PM Changeset in webkit [125970] by
-
- 2 edits in branches/chromium/1229/Source
Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232
Reviewed by James Robinson.
Source/WebCore:
CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.
Chromium bug: crbug.com/125482
Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
Source/WebKit/chromium:
Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.
- tests/CCLayerTreeHostImplTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829399
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857077
- 2:47 PM Changeset in webkit [125969] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] ewk_back_forward_list_item properties should be in sync with WebProcessProxy::m_backForwardListItemMap
https://bugs.webkit.org/show_bug.cgi?id=94248
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-18
Reviewed by Kenneth Rohde Christiansen.
Currently ewk_back_forward_list_item properties are initialized from
WKBackForwardListItemRef once in the constructor and then just stored.
This is erroneous approach as back forward items can be initialized within
several iterations, meaning several ipc calls to UI process and several updates
of WebProcessProxy::m_backForwardListItemMap where the items are stored.
Hence the values of ewk_back_forward_list_item properties should be updated
with the corresponding WKBackForwardListItem function invokes every time
they are called.
- UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(_Ewk_Back_Forward_List_Item): Data members have to be mutable as assigned being const pointers.
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):
(ewk_back_forward_list_item_uri_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_uri_get):
- 10:43 AM Changeset in webkit [125968] by
-
- 3 edits in trunk/Source/WebCore
CSSValueList: Reserve the exact amount of space needed when constructing from CSS parser.
(No bug URL as Bugzilla is down today.)
Reviewed by Antti Koivisto.
Use Vector::reserveInitialCapacity() when constructing a CSSValueList from a CSSParserValueList
since we have the final length available. Also inlined the trivial append() and prepend().
- css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
- css/CSSValueList.h:
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):
- 7:21 AM Changeset in webkit [125967] by
-
- 3 edits in trunk/LayoutTests
Follow up to r125966, fixing flaky tests.
- inspector/elements/event-listeners-about-blank.html:
- 2:32 AM Changeset in webkit [125966] by
-
- 22 edits in trunk
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- removed usages of WebInspector.panels.profiles.
- made panel lazily loaded
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/front-end/CPUProfileView.js: (WebInspector.CPUProfileHeader.prototype.createView):
- inspector/front-end/CSSSelectorProfileView.js: (WebInspector.CSSSelectorProfileType.prototype.buttonClicked): (WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile): (WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile): (WebInspector.CSSProfileHeader.prototype.createView):
- inspector/front-end/HeapSnapshotDataGrids.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView): (WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._profiles): (WebInspector.HeapSnapshotView.prototype.populateContextMenu): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapProfileHeader.prototype.createView):
- inspector/front-end/InspectorFrontendAPI.js: (InspectorFrontendAPI.isProfilingJavaScript): (InspectorFrontendAPI.startProfilingJavaScript): (InspectorFrontendAPI.stopProfilingJavaScript):
- inspector/front-end/NativeMemorySnapshotView.js: (WebInspector.NativeMemoryProfileHeader.prototype.createView):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfileHeader.prototype.view): (WebInspector.ProfileHeader.prototype.createView): (WebInspector.ProfilesPanel.prototype.toggleRecordButton): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId): (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu): (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent): (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
- inspector/front-end/Settings.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector._toggleSearchingForNode): (WebInspector._profilesLinkifier): (WebInspector._requestZoom.set InspectorFrontendHost): (WebInspector._requestZoom): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- WebKit.gyp:
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: make profiles panel a lazily loaded module.
https://bugs.webkit.org/show_bug.cgi?id=94351
Reviewed by Yury Semikhatsky.
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-summary-show-ranges.html:
- inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html:
- 12:20 AM Changeset in webkit [125965] by
-
- 29 edits in trunk
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- Introduces importScript that evals in debug mode and inlines for release
- Loads Element, Resources, Timeline, Audits panels lazily.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- inspector/compile-front-end.py:
- inspector/front-end/AuditsPanel.js:
- inspector/front-end/CodeMirrorTextEditor.js: (WebInspector.CodeMirrorTextEditor): (WebInspector.CodeMirrorTextEditor.prototype._toRange):
- inspector/front-end/Color.js:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
- inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.PanelDescriptor): (WebInspector.PanelDescriptor.prototype.panel):
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/SettingsScreen.js: (WebInspector.GenericSettingsTab):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
- inspector/front-end/Spectrum.js: (WebInspector.Spectrum.prototype.get outputColorFormat):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._panelDescriptors): (WebInspector.doLoadedDone):
- inspector/front-end/utilities.js:
- inspector/inline-javascript-imports.py: (main):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
- WebKit.gyp:
- scripts/concatenate_js_files.py: (OrderedJSFilesExtractor.handle_starttag):
- scripts/inline_js_imports.py: (main):
2012-08-18 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: load panels code on demand
https://bugs.webkit.org/show_bug.cgi?id=94326
Reviewed by Vsevolod Vlasov.
Showing panels prior to running tests in order to load the code for them.
- http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
- inspector/database-table-name-excaping.html:
- inspector/styles/styles-invalid-color-values.html:
- inspector/timeline-dfs.html:
