Timeline
Oct 1, 2012:
- 11:48 PM Changeset in webkit [130127] by
-
- 9 edits in trunk/Source/WebCore
Adding Localizer::dateFormat() for multiple fields date/datetime input UI
https://bugs.webkit.org/show_bug.cgi?id=98109
Reviewed by Kent Tamura.
This patch introduces Localizer::dateFormat() function for multiple
fields date/datetime/datetime-local input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.
We'll have platform specific implementations in LocaleICU, LocaleMac,
and LocaleWin.
No new tests. Other patches will add tests for this change.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::dateFormat): Added a stub.
- platform/text/LocaleICU.h:
(LocaleICU): Changed to add a declaration of dateFormat().
- platform/text/LocaleNone.cpp:
(LocaleNone): Changed to add a declaration of dateFormat().
(WebCore::LocaleNone::dateFormat): Added.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::dateFormat): Added.
- platform/text/LocaleWin.h:
(LocaleWin): Changed to add a declaration of dateFormat().
- platform/text/Localizer.h: Updates Unicode TR35 URI in a comment.
(Localizer): Changed to add a declaration of dateFormat().
- platform/text/mac/LocaleMac.h:
(LocaleMac): Changed to add a declaration of dateFormat().
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::dateFormat): Added a stub.
- 11:42 PM Changeset in webkit [130126] by
-
- 2 edits in trunk/Source/WebKit/chromium
REGRESSION(r130116): Need to update DateTimeFormatTest
https://bugs.webkit.org/show_bug.cgi?id=98120
Reviewed by Kent Tamura.
This patch updates test cases for week of month and week of year type
specifiers in DateTimeFormat class. This tests should be updated
within r130116.
- tests/DateTimeFormatTest.cpp:
(TEST_F): Changed test cases for changes of enum field value changes.
- 11:32 PM Changeset in webkit [130125] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix ASSERT introduced in
http://trac.webkit.org/changeset/130103. It turns out this case can
occur. This patch causes us to handle it the same way we did
previously.
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
- 11:22 PM Changeset in webkit [130124] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] DOMSelection should not use shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=97872
Reviewed by Ryosuke Niwa.
Since Node::shadowAncestorNode is deprecated, it should not be used.
Here, we should use TreeScope::ancestorInThisScope instead.
No new tests, covered by existing test.
- page/DOMSelection.cpp:
(WebCore::selectionShadowAncestor):
- 11:20 PM Changeset in webkit [130123] by
-
- 3 edits in trunk/Source/WebCore
ScrollView::setScrollPosition is overridden by FrameView, but is not virtual
https://bugs.webkit.org/show_bug.cgi?id=98064
Reviewed by Simon Fraser.
Virtualize ScrollView::setScrollPosition, and override it in FrameView.
No new tests, this causes subtle behavior differences in currently-untestable code.
- page/FrameView.h:
(FrameView):
- platform/ScrollView.h:
(ScrollView):
- 11:17 PM Changeset in webkit [130122] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Restore WebCore/ChangeLog lines deleted in r130097
https://bugs.webkit.org/show_bug.cgi?id=98112
Reviewed by Eric Seidel.
- 11:15 PM Changeset in webkit [130121] by
-
- 2 edits in trunk/Source/WebCore
TreeScope should not use node->shadowAncetorNode()
https://bugs.webkit.org/show_bug.cgi?id=97869
Reviewed by Ryosuke Niwa.
TreeScope uses shadowAncestorNode(), but we should use shadowHost() here. shadowAncestorNode() is deprecated.
No new tests, simple refactoring.
- dom/TreeScope.cpp:
(WebCore::TreeScope::ancestorInThisScope):
- 11:10 PM Changeset in webkit [130120] by
-
- 2 edits in branches/safari-534.58-branch/Source/WebCore
Update Localizable.strings by running update-webkit-localizable-strings.
- English.lproj/Localizable.strings:
- 11:10 PM Changeset in webkit [130119] by
-
- 11 edits in trunk
Web Inspector: move completions calculation into RuntimeModel (part 1)
https://bugs.webkit.org/show_bug.cgi?id=98053
Reviewed by Yury Semikhatsky.
Source/WebCore:
- moves current execution context state into runtime model
- moves completionsForTextPrompt and its private helpers into runtime model
- makes text prompt use generic expression stop characters by default
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._frameChanged):
(WebInspector.ConsoleView.prototype._appendContextOption):
(WebInspector.ConsoleView.prototype._contextChanged):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyPrompt):
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.setCurrentExecutionContext):
(WebInspector.RuntimeModel.prototype.currentExecutionContext):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeModel.prototype.evaluate.evalCallback):
(WebInspector.RuntimeModel.prototype.evaluate):
(WebInspector.RuntimeModel.prototype.completionsForTextPrompt):
(WebInspector.RuntimeModel.prototype._completionsForExpression.evaluated.getCompletions):
(WebInspector.RuntimeModel.prototype._completionsForExpression.evaluated):
(WebInspector.RuntimeModel.prototype._completionsForExpression.receivedPropertyNamesFromEval):
(WebInspector.RuntimeModel.prototype._completionsForExpression.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):
(WebInspector.RuntimeModel.prototype._reportCompletions):
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
LayoutTests:
- http/tests/inspector/console-cd-completions.html:
- http/tests/inspector/network/network-initiator-from-console.html:
- inspector/debugger/debugger-completions-on-call-frame.html:
- 9:57 PM Changeset in webkit [130118] by
-
- 2 edits in trunk/PerformanceTests
PerfTestRunner: Move all functions into the closure and always use double quotation for string literals
https://bugs.webkit.org/show_bug.cgi?id=98093
Reviewed by Ojan Vafai.
Move all methods of PerfTestRunner into the closure that defines it.
Also always use double quotations for string literals for consistency.
- resources/runner.js:
- 9:42 PM Changeset in webkit [130117] by
-
- 2 edits in trunk/Source/WebCore
The static function 'deleteFileSystem' in the LocalFileSystem.cpp should have another name.
https://bugs.webkit.org/show_bug.cgi?id=98106
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-01
Reviewed by Yuta Kitamura.
A build error occurs because there are two functions which have same name in the LocalFileSystem.cpp file.
One is member function of the class, and the other is a static function which is called by the member function.
So, I've tried to change the name of the static function from 'deleteFileSystem' to 'performDeleteFileSystem'.
No new functionality, no new test.
- Modules/filesystem/LocalFileSystem.cpp:
(WebCore::performDeleteFileSystem): The name of function is changed from 'deleteFileSystem'.
(WebCore::LocalFileSystem::requestFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
- 9:22 PM Changeset in webkit [130116] by
-
- 4 edits in trunk/Source/WebCore
Week specifiers defined in DateTimeFormat class are wrong.
https://bugs.webkit.org/show_bug.cgi?id=98104
Reviewed by Kent Tamura.
This patch changes week of year and week of month format specifiers
defined in DateTimeFormat class to match with Unicode technical
standard 35, LDML, Locale Data Markup Language, (http://www.unicode.org/reports/tr35/).
No new tests. Following existing tests cover this change:
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html
- html/WeekInputType.cpp:
(WebCore::WeekInputType::setupLayoutParameters): Changed to use 'w' instead of 'W'.
- platform/text/DateTimeFormat.cpp: Changed elements in lowerCaseToFieldTypeMap and upperCaseToFieldTypeMap.
- platform/text/DateTimeFormat.h: Changed FieldTypeWeekOfMonth to 'W' and FieldTypeWeekOfYear to 'w'.
- 8:47 PM Changeset in webkit [130115] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
https://bugs.webkit.org/show_bug.cgi?id=98107
RIM PR 173292
Reviewed by George Staikos.
This method is not referenced anywhere anymore,
so we should stop requiring it from WebPageClient
implementations.
- Api/WebPageClient.h:
- 8:11 PM Changeset in webkit [130114] by
-
- 2 edits in trunk/Source/WebCore
Add other <string> typed tokens to YYDEBUG token output
https://bugs.webkit.org/show_bug.cgi?id=98102
Patch by Glenn Adams <glenn@skynav.com> on 2012-10-01
Reviewed by Simon Fraser.
Add other <string> typed tokens to YYPRINT macro expansion. Minor cleanup of cast.
No new tests. For CSS lexer/parser debug usage only.
- css/CSSGrammar.y:
Add other <string> typed tokens to YYPRINT macro expansion.
Change C-type cast to function-call style cast (per darin).
- 7:37 PM Changeset in webkit [130113] by
-
- 9 edits2 moves in trunk
Calendar picker should use zero as default step base
https://bugs.webkit.org/show_bug.cgi?id=97976
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Added stepBase parameters.
Source/WebCore:
Calendar picker should be using zero as default step base for input type=date.
The spec says to use zero unless specified otherwise.
Since input type=week has another default step base, I am adding step base
to DateTimeChooserParameters.
Test: fast/forms/date/calendar-picker-with-step.html
- Resources/pagepopups/calendarPicker.js:
(handleArgumentsTimeout):
(CalendarPicker):
(CalendarPicker.prototype.stepMismatch): Use the new this.stepBase.
- html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::openPopup): Gets step base from step range.
- platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added stepBase.
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): stepBase needs 11 digits of precision when setting maximum possible date.
LayoutTests:
- fast/forms/date/calendar-picker-with-step-expected.txt: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt.
- fast/forms/date/calendar-picker-with-step.html: Renamed from LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html. Renamed because this does not test apeparance.
- 7:07 PM Changeset in webkit [130112] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
Unreviewed. Fix expected result name.
- platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
- platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt.txt: Removed.
- 6:55 PM Changeset in webkit [130111] by
-
- 6 edits3 adds in trunk/LayoutTests
Add more tests for calendar picker
https://bugs.webkit.org/show_bug.cgi?id=98034
Reviewed by Kent Tamura.
This adds basic tests for all key bindings and simple mouse operations.
- fast/forms/date/calendar-picker-common.js: Added.
(currentMonth): Returns month that the picker is currently showing.
(selectedDate):
(openPicker): Opens the calendar picker and updates popupWindow.
(sendKey):
- fast/forms/date/calendar-picker-key-operations-expected.txt:
- fast/forms/date/calendar-picker-key-operations.html:
- fast/forms/date/calendar-picker-mouse-operations-expected.txt: Added.
- fast/forms/date/calendar-picker-mouse-operations.html: Added.
- fast/forms/resources/common.js:
(cumulativeOffset):
(hoverOverElement):
(clickElement):
- platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:
- platform/gtk/TestExpectations: Added calendar-picker-mouse-operations.html.
- 6:51 PM Changeset in webkit [130110] by
-
- 7 edits2 adds in trunk
flexbox does wrong baseline item alignment in columns
https://bugs.webkit.org/show_bug.cgi?id=97948
Reviewed by Ojan Vafai.
Source/WebCore:
For columns, baseline alignment should just be flex-start. We were previously
moving the logical left edge by the ascent.
Test: css3/flexbox/align-baseline.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignmentForChild): Map baseline to flex-start for orthogonal children.
(WebCore::RenderFlexibleBox::alignChildren): Add FIXME for bug in baseline alignment.
- rendering/RenderFlexibleBox.h:
LayoutTests:
Update test cases with new baseline alignment for column.
- css3/flexbox/align-baseline-expected.html: Added.
- css3/flexbox/align-baseline.html: Added.
- css3/flexbox/flex-align-baseline-expected.txt:
- css3/flexbox/flex-align-baseline.html:
- css3/flexbox/multiline-align-self.html:
- 6:21 PM Changeset in webkit [130109] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSArray::unshiftCountSlowCase needs to clear array slots when adding space to end of array
https://bugs.webkit.org/show_bug.cgi?id=98101
Reviewed by Filip Pizlo.
Cleared new array entries when adding to end due to shifting contents to lower memory. Also
checnaged the order of moving array contents and metadata in the shift left case to avoid
clobbering the metadata with array contents. Optimized the to only make a memmove if the
count is non-zero.
- runtime/JSArray.cpp:
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::unshiftCount):
- 6:14 PM Changeset in webkit [130108] by
-
- 2 edits in trunk/Source/WebKit/gtk
[Gtk] crash when accelerated composition is turned off
https://bugs.webkit.org/show_bug.cgi?id=98099
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-01
Reviewed by Martin Robinson.
frame->view()->updateLayoutAndStyleIfNeededRecursive() may reset root
compositing layer in flushAndRenderLayers. So, we check if compositing
is enabled afterwards, and return if it is not.
This bug is handled by LayoutTests/compositing/toggle-compositing.html
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):
- 6:03 PM Changeset in webkit [130107] by
-
- 8 edits14 adds in trunk/LayoutTests
Adding appearance tests for multiple fields week input UI
https://bugs.webkit.org/show_bug.cgi?id=98006
Reviewed by Kent Tamura.
This patch adds tests for multiple fields week input UI and disables
these tests on ports which don't enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
Note: We need to do rebaseline tests to update images for Chromium-Mac
and Chromium-Win.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html: Added for checking basic appearance.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Added for checking appearance of applying CSS pseudo classes, e.g. :enabled, :invalid, and so on.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Added for checking appearance of applying CSS pseudo elements, e.g. :after, :before, and so on.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Added for checking appearance of applying CSS styles
- platform/chromium-android/TestExpectations: Changed to disable tests for multiple fields week input UI.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium/TestExpectations: Changed to disable tests for multiple fields week input UI of Mac and Win for rebaseline.
- platform/efl/TestExpectations: Changed to disable tests for multiple fields week input UI.
- platform/gtk/TestExpectations: ditto
- platform/mac/TestExpectations: ditto
- platform/qt/TestExpectations: ditto
- platform/win/TestExpectations: ditto
- 5:55 PM Changeset in webkit [130106] by
-
- 5 edits2 moves in trunk/Source/WebCore
Rename CalendarPickerElement to PickerIndicatorElement
https://bugs.webkit.org/show_bug.cgi?id=98096
Reviewed by Kent Tamura.
Renaming CalendarPickerElement to PickerIndicatorElement because we want to use it for other input types like time, week, month, datetime.
No new tests. Just a rename.
- GNUmakefile.list.am:
- WebCore.gypi:
- html/DateInputType.cpp:
(WebCore::DateInputType::createShadowSubtree):
- html/DateInputType.h:
(WebCore):
(DateInputType):
- html/shadow/PickerIndicatorElement.cpp: Renamed from Source/WebCore/html/shadow/CalendarPickerElement.cpp.
(WebCore):
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
(WebCore::PickerIndicatorElement::create):
(WebCore::PickerIndicatorElement::~PickerIndicatorElement):
(WebCore::PickerIndicatorElement::createRenderer):
(WebCore::PickerIndicatorElement::hostInput):
(WebCore::PickerIndicatorElement::defaultEventHandler):
(WebCore::PickerIndicatorElement::willRespondToMouseClickEvents):
(WebCore::PickerIndicatorElement::didChooseValue):
(WebCore::PickerIndicatorElement::didEndChooser):
(WebCore::PickerIndicatorElement::openPopup):
(WebCore::PickerIndicatorElement::closePopup):
(WebCore::PickerIndicatorElement::detach):
- html/shadow/PickerIndicatorElement.h: Renamed from Source/WebCore/html/shadow/CalendarPickerElement.h.
(WebCore):
(PickerIndicatorElement):
- 5:36 PM WebKitGTK/1.10.x edited by
- (diff)
- 5:28 PM Changeset in webkit [130105] by
-
- 45 edits in trunk/Source/WebCore
Unreviewed, rolling out r130079.
http://trac.webkit.org/changeset/130079
https://bugs.webkit.org/show_bug.cgi?id=95866
Broke the chomium windows compile.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::getFontData):
- css/CSSFontFace.h:
(CSSFontFace):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h:
(CSSFontFaceSource):
- css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSSegmentedFontFace.h:
(CSSSegmentedFontFace):
- dom/Document.cpp:
(WebCore::Document::registerCustomFont):
- dom/Document.h:
(Document):
- platform/graphics/Font.h:
(WebCore):
- platform/graphics/FontCache.cpp:
(WebCore):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::getFontData):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/FontData.h:
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/FontFallbackList.h:
(FontFallbackList):
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
- platform/graphics/FontSelector.h:
(FontSelector):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
- platform/graphics/SegmentedFontData.h:
(WebCore::FontDataRange::FontDataRange):
(WebCore::FontDataRange::fontData):
(FontDataRange):
(SegmentedFontData):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::variantFontData):
(DerivedFontData):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(GetLastResortFallbackFontProcData):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/pango/FontCachePango.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/wince/FontCacheWinCE.cpp:
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- 5:26 PM Changeset in webkit [130104] by
-
- 2 edits in trunk/Source/WebCore
Speculative GTK build fix after http://trac.webkit.org/changeset/130091
- GNUmakefile.list.am:
- 5:16 PM Changeset in webkit [130103] by
-
- 4 edits in trunk/Source/WebCore
[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-traverse gets 4% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974
Reviewed by Kentaro Hara.
Previously, we stored a pointer to a handle to a wrapper in Node. That
is an extra layer of indirection that slows down finding the wrapper
for the node. A handle is just a pointer, so we might as we just store
the handle in the Node directly. That speeds up dom-traverse by about 4%.
We were using the extra layer of indirection in IntrusiveDOMWrapperMap
to make removal more efficient. Rather than using a chunked table, we
now use a HashSet, which also lets us remove elements quickly.
- bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- 5:14 PM Changeset in webkit [130102] by
-
- 7 edits3 adds in trunk
Address a FIXME in JSArray::sort
https://bugs.webkit.org/show_bug.cgi?id=98080
<rdar://problem/12407844>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Get rid of fast sorting of sparse maps. I don't know that it's broken but I do know that we don't
have coverage for it. Then also address the FIXME in JSArray::sort regarding side-effecting
compare functions.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- runtime/JSArray.cpp:
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
- runtime/JSArray.h:
(JSArray):
- runtime/JSObject.h:
(JSC::JSObject::hasSparseMap):
(JSObject):
LayoutTests:
- fast/js/jsc-test-list:
- fast/js/script-tests/sort-with-side-effecting-comparisons.js: Added.
- fast/js/sort-with-side-effecting-comparisons-expected.txt: Added.
- fast/js/sort-with-side-effecting-comparisons.html: Added.
- 5:14 PM Changeset in webkit [130101] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r130062.
http://trac.webkit.org/changeset/130062
https://bugs.webkit.org/show_bug.cgi?id=98001
Causes a ton of gtest failures on the chromium bots.
- platform/chromium/LanguageChromium.cpp:
(WebCore::platformLanguage):
- 5:12 PM Changeset in webkit [130100] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipping flaky test on Windows: inspector/debugger/dynamic-script-tag.html.
https://bugs.webkit.org/show_bug.cgi?id=98095
- platform/win/TestExpectations:
- 4:48 PM Changeset in webkit [130099] by
-
- 7 edits in trunk
Encapsulate private properties in PerfTestRunner better
https://bugs.webkit.org/show_bug.cgi?id=97833
Reviewed by Ojan Vafai.
PerformanceTests:
This patch moves "private" methods and properties of PerfTestRunner into a closure so that they're
inaccssible from outside. Also catch exceptions from test.run, test.done, and other runner code
to ensure we call notifyDone() even if we broke tests. Otherwise DRT will timeout and we end up
waiting for 10 minutes per each broken test on bots.
- resources/runner.js:
(PerfTestRunner.gc):
(logInDocument): Extracted from PerfTestRunner.log.
(PerfTestRunner.log): Moved.
(logFatalError): Added.
(start): Renamed from PerfTestRunner._start.
(scheduleNextRun): Extracted from PerfTestRunner._runLoop. Also catch any exceptions that happen
in the runner and ignoreWarmUpAndLog so that we don't end up timing out. We call logFatalError in
such cases, which in turn ensures notifyDone() is called.
(ignoreWarmUpAndLog): Renamed from PerfTestRunner._ignoreWarmUpAndLog.
(finish): Extracted from PerfTestRunner._runLoop.
(PerfTestRunner.measureTime): Moved. The initialization of runCount is moved into start().
(measureTimeOnce): Renamed from PerfTestRunner._measureTimeOnce.
(PerfTestRunner.runPerSecond): Moved. Ditto about runCount.
(measureRunsPerSecondOnce): Renamed from PerfTestRunner._measureRunsPerSecondOnce.
(callRunAndMeasureTime): Renamed from PerfTestRunner._perSecondRunnerIterator.
LayoutTests:
Override PerfTestRunner.now instead of PerfTestRunner._perSecondRunnerIterator since the latter
is no longer exposed.
- fast/harness/perftests/runs-per-second-iterations-expected.txt:
- fast/harness/perftests/runs-per-second-iterations.html: Increase the runtime of the last 4 runs
since test.timeToRun is no longer supported by PerfTestRunner.
- fast/harness/perftests/runs-per-second-log-expected.txt:
- fast/harness/perftests/runs-per-second-log.html: Avoid use numbers that contain primes other
than 2 and 5 as runs because they cause rouding errors in PerfTestRunner.measureRunsPerSecondOnce
and make the output dependent on the underlying floating number implementation.
- 4:43 PM Changeset in webkit [130098] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Rolling out changes from http://trac.webkit.org/changeset/119130.
Tests match older results.
- platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
- platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt.txt: Added.
- 4:20 PM Changeset in webkit [130097] by
-
- 24 edits in trunk
[MathML] Baseline wrong for fractions or munder/mover with padding
https://bugs.webkit.org/show_bug.cgi?id=97990
Reviewed by Eric Seidel.
Source/WebCore:
We include any border or padding in our baseline computation. We also take this opportunity
to quit adding extra left & right padding to numerators and denominators, making our output
tighter and also more compatible with Firefox and TeX, since we are rebaselining some
fraction pixel tests now anyway.
Tests added to LayoutTests/mathml/presentation/{over,row-alignment}.xhtml
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::fixChildStyle):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::firstLineBoxBaseline):
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::firstLineBoxBaseline):
LayoutTests:
We handle any border and padding correctly, and quit adding extra left and right padding
to numerators and denominators.
- mathml/presentation/over.xhtml:
- mathml/presentation/row-alignment.xhtml:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- 4:18 PM Changeset in webkit [130096] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipped on other platforms in http://trac.webkit.org/changeset/129897.
Skipping on Windows as well.
- platform/win/TestExpectations:
- 4:14 PM Changeset in webkit [130095] by
-
- 13 edits in trunk/Source
Source/WebCore: IndexedDB: Fire error rather than raising on request creation if transaction aborts asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=93054
Reviewed by Tony Chang.
All IDB data operations are asynchronous, producing IDBRequest objects. This was implemented
by passing all data from the front-end to the back-end synchronously, and synchronously
returning an exception code back if the request was invalid. Previous changes have moved
request validation to the front-end except for the case of the back-end transaction having
asynchronously aborted in the mean time.
To eliminate that case (which would allow front-end to back-end communication to be
asynchronous in multi-process ports), change from returning an exception code to relying on
the front-end to abort the request when the abort event finally arrives.
The difference would be noticeable in scripts - in a multi-process environment:
var request1 = store.get(0);
request1.onerror = errorHandler; (A)
(B)
var request2 = store.get(0); (C)
request2.onerror = errorHandler; (D)
If the transaction back-end were to asynchronously abort at exactly point (B), then prior to
this patch an exception would be thrown at (C). With this patch, no exception but (D) would
fire, same as (A).
The back-end explicitly fires an error callback as well, as intermediate layers may rely on
this to stop tracking the pending callback.
No new layout tests - change is not observable in single-process ports.
Added webkit_unit_test IDBRequestTest.AbortErrorAfterAbort to verify that IDBRequest
is resilient to this pattern, but it was previous.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance): Back end should never fail a request.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto, and also move "is key cursor" test
here from back-end.
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunction): Change from EC to firing error.
(WebCore::IDBCursorBackendImpl::advance): Ditto.
(WebCore::IDBCursorBackendImpl::deleteFunction): Ditto, and remove test moved to FE.
(WebCore::IDBCursorBackendImpl::prefetchContinue): Ditto.
- Modules/indexeddb/IDBDatabaseError.cpp:
(WebCore::IDBDatabaseError::create): Add overload that looks up message via code.
(WebCore::IDBDatabaseError::IDBDatabaseError): Look up message via exception table.
- Modules/indexeddb/IDBDatabaseException.h: Add getErrorDescription.
- Modules/indexeddb/IDBDatabaseException.cpp: Implementation of getErrorDescription.
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor): Back end should never fail a request.
(WebCore::IDBIndex::count): Ditto.
(WebCore::IDBIndex::openKeyCursor): Ditto.
(WebCore::IDBIndex::get): Ditto.
(WebCore::IDBIndex::getKey): Ditto.
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursor): Change from EC to firing error.
(WebCore::IDBIndexBackendImpl::openKeyCursor): Ditto.
(WebCore::IDBIndexBackendImpl::count): Ditto.
(WebCore::IDBIndexBackendImpl::get): Ditto.
(WebCore::IDBIndexBackendImpl::getKey): Ditto.
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get): Back end should never fail a request.
(WebCore::IDBObjectStore::put): Ditto.
(WebCore::IDBObjectStore::deleteFunction): Ditto.
(WebCore::IDBObjectStore::clear): Ditto.
(WebCore): Ditto.
(WebCore::IDBObjectStore::openCursor): Ditto.
(WebCore::IDBObjectStore::count): Ditto.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get): Change from EC to firing error.
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction): Ditto.
(WebCore::IDBObjectStoreBackendImpl::clear): Ditto.
(WebCore::IDBObjectStoreBackendImpl::openCursor): Ditto.
(WebCore::IDBObjectStoreBackendImpl::count): Ditto.
Source/WebKit/chromium: IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
https://bugs.webkit.org/show_bug.cgi?id=94757
Reviewed by Tony Chang.
- tests/IDBRequestTest.cpp: Ensure IDBRequest can handle Error after abort.
(WebCore::TEST): Added AbortAfter
- 4:14 PM Changeset in webkit [130094] by
-
- 2 edits in trunk/LayoutTests
Add some flaky tests to match what's happening on the bots.
- platform/chromium/TestExpectations:
- 4:12 PM Changeset in webkit [130093] by
-
- 2 edits in trunk/Source/WebCore
Build fix. Clearly, these objects could be instantiated in worker threads.
Not sure why my patch asserted that we're in the main thread.
- dom/ContainerNode.h:
(WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
(WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):
- 4:08 PM Changeset in webkit [130092] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update results again after r130080.
- platform/efl/fast/canvas/canvas-render-layer-expected.txt:
- 4:05 PM Changeset in webkit [130091] by
-
- 11 edits3 moves4 adds in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=97365
ScrollingTreeState needs to be a tree of nodes
Reviewed by Simon Fraser.
This patch should not change any behavior.
Prior to this patch, ScrollingTreeState attempted to contain all of
the state information needed for the whole scrolling tree in one
object. But in the future when there are multiple nodes in the
scrolling tree, a single state object will not be sufficient.
ScrollingState should also be represented by a tree. This patch makes
scrolling state into a tree. The old ScrollingTreeState class has
become the ScrollingStateScrollingNode class since the majority of
the class represents scroll state that is specific to ScrollableAreas
and will not be applicable to fixed or sticky layers.
Some new files and some moved files.
- WebCore.xcodeproj/project.pbxproj:
Everything that used to refer to the ScrollingTreeState should now
refer to the ScrollingStateTree instead. Right now, all of this code
continues to deal with only the root node of the tree. In the future,
it will have to deal with all of the nodes.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinator::scrollingStateTreeCommitterTimerFired):
(WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinator::commitTreeState):
- page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):
This is a new abstract base class for the nodes in the
ScrollingStateTree.
- page/scrolling/ScrollingStateNode.cpp: Added.
(WebCore):
(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::~ScrollingStateNode):
(WebCore::ScrollingStateNode::appendChild):
(WebCore::ScrollingStateNode::cloneChildNodes):
(WebCore::ScrollingStateNode::traverseNext):
- page/scrolling/ScrollingStateNode.h: Added.
(WebCore):
(ScrollingStateNode):
(WebCore::ScrollingStateNode::scrollLayerDidChange):
(WebCore::ScrollingStateNode::setScrollLayerDidChange):
(WebCore::ScrollingStateNode::scrollingStateTree):
(WebCore::ScrollingStateNode::parent):
(WebCore::ScrollingStateNode::firstChild):
(WebCore::ScrollingStateNode::nextSibling):
(WebCore::ScrollingStateNode::setParent):
(WebCore::ScrollingStateNode::setFirstChild):
(WebCore::ScrollingStateNode::setNextSibling):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
- page/scrolling/mac/ScrollingStateNodeMac.mm: Copied from page/scrolling/mac/ScrollingTreeStateMac.mm.
(WebCore::ScrollingStateNode::platformScrollLayer):
(WebCore::ScrollingStateNode::setScrollLayer):
(WebCore):
Right now, the ScrollingStateScrollingNode is the only type of
ScrollingStateNode. In the future there will be, for example,
ScrollingStateFixedNodes that will have a different set of state
information to keep track of.
- page/scrolling/ScrollingStateScrollingNode.cpp: Copied from page/scrolling/ScrollingTreeState.cpp.
(WebCore::ScrollingStateScrollingNode::create):
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore):
(WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::cloneNode):
(WebCore::ScrollingStateScrollingNode::setViewportRect):
(WebCore::ScrollingStateScrollingNode::setContentsSize):
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
- page/scrolling/ScrollingStateScrollingNode.h: Copied from page/scrolling/ScrollingTreeState.h.
(ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateTree.cpp: Added.
(WebCore):
(WebCore::ScrollingStateTree::create):
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::~ScrollingStateTree):
(WebCore::ScrollingStateTree::commit):
The ScrollingStateTree manages the nodes in the tree via the root
node. It is responsible for cloning the tree and sending it over to
the scrolling thread.
- page/scrolling/ScrollingStateTree.h: Added.
(WebCore):
(ScrollingStateTree):
(WebCore::ScrollingStateTree::rootStateNode):
(WebCore::ScrollingStateTree::setHasChangedProperties):
(WebCore::ScrollingStateTree::hasChangedProperties):
(WebCore::ScrollingStateTree::setRootStateNode):
Everything that used to refer to the ScrollingTreeState should now
refer to the ScrollingStateTree instead. Right now, all of this code
continues to deal with only the root node of the tree. In the future,
it will have to deal with all of the nodes.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/ScrollingTree.h:
(WebCore):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
- page/scrolling/ScrollingTreeNode.h:
(WebCore):
(ScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
ScrollingTreeState.cpp --> ScrollingStateScrollingNode.cpp
- page/scrolling/ScrollingTreeState.cpp: Removed.
ScrollingTreeState.h --> ScrollingStateScrollingNode.h
- page/scrolling/ScrollingTreeState.h: Removed.
ScrollingTreeStateMac.mm --> ScrollingStateNodeMac.mm
- page/scrolling/mac/ScrollingTreeStateMac.mm: Removed.
- 3:55 PM Changeset in webkit [130090] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipping http/tests/security/cross-origin-local-storage-wk1.html since support for the feature on Windows has not been added yet.
https://bugs.webkit.org/show_bug.cgi?id=98079
- platform/win/Skipped:
- 3:54 PM Changeset in webkit [130089] by
-
- 3 edits in trunk/Source/WebCore
Kill transitive effects of SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=97953
Reviewed by Eric Seidel.
The dynamicPseudo/hasUnknownPseudoelements by-ref parameters that are passed into checkOneSelector make the logic harder to understand and aren't needed. Refactor the code to rid of them, replacing them instead with two flags in SelectorCheckingContext.
No change in behavior, covered by existing tests.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Rolled pseudo-element-checking code out of checkOneSelector into here, since that is where t
(WebCore::SelectorChecker::checkOneSelector): Changed to use SelectorCheckingContext rather than transitive params.
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Added two new flags.
(SelectorCheckingContext): Ditto.
- 3:41 PM Changeset in webkit [130088] by
-
- 2 edits in trunk/Source/WebCore
349kB below SelectorDataList::initialize() on Membuster3.
<http://webkit.org/b/98072>
<rdar://problem/12408605>
Reviewed by Anders Carlsson.
Make a separate pass over the CSSSelectorList to figure out the capacity needed for SelectorDataList::m_selectors.
Reduces memory consumption by 322kB on Membuster3.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::initialize):
- 3:38 PM Changeset in webkit [130087] by
-
- 2 edits in trunk/LayoutTests
Re-baseline after r130080 for Mac.
- platform/mac/fast/canvas/canvas-render-layer-expected.txt:
- 3:36 PM Changeset in webkit [130086] by
-
- 2 edits in trunk/LayoutTests
Add failing geolocation test to Mac WK2 TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=98081
- platform/mac-wk2/TestExpectations:
- 3:31 PM Changeset in webkit [130085] by
-
- 4 edits in trunk/Source/WebCore
Add a GraphicsLayerFactory getter to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=98069
Reviewed by Andreas Kling.
- page/ChromeClient.h:
(WebCore::ChromeClient::graphicsLayerFactory):
New function that can be overridden by ports to customize the layer type created for a page.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::graphicsLayerFactory):
- rendering/RenderLayerCompositor.h:
Add helper getter that's unused for now but will be called by RenderLayerBacking when creating graphics layers.
- 3:24 PM Changeset in webkit [130084] by
-
- 10 edits in trunk/Source/WebCore
Rename AssertNoEventDispatch to NoEventDispatchAssertion
https://bugs.webkit.org/show_bug.cgi?id=98075
Reviewed by Abhishek Arya.
Renamed the class.
- dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAppendChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
- dom/ContainerNode.h:
(WebCore::NoEventDispatchAssertion::NoEventDispatchAssertion):
(WebCore::NoEventDispatchAssertion::~NoEventDispatchAssertion):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
- dom/Document.cpp:
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):
- 3:22 PM Changeset in webkit [130083] by
-
- 3 edits in trunk/Tools
webkitpy should accept a different httpd.conf specified by the user
https://bugs.webkit.org/show_bug.cgi?id=98071
Reviewed by Dirk Pranke.
The existing httpd.conf variants (or lighttpd.conf, for that
matter) we have do not always suit the user's system. This is
particularly true on Linux/Unix, where Apache can be installed in
a plethora of ways and the LoadModule calls can fail to specify
the proper module paths.
For now, we start accepting the WEBKIT_HTTP_SERVER_CONF_PATH
environment variable, which allows the user to specify the
absolute path to another http server configuration file that might
work on the user's system.
In the long term, we should try to generate our configuration file
and stop requiring all the different httpd.conf files we have as
well as this hack.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._path_to_apache_config_file):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_path_to_apache_config_file):
- 3:18 PM Changeset in webkit [130082] by
-
- 4 edits in trunk/Source/WebCore
Rename Font::m_fontList to avoid confusion
https://bugs.webkit.org/show_bug.cgi?id=95867
Reviewed by Eric Seidel.
Renames Font::m_fontList to Font::m_fontFallbackList to avoid confusion
with FontFallbackList::m_fontList.
No new tests as behavior is absolutely not different.
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::operator==):
(WebCore::Font::update):
- platform/graphics/Font.h:
(WebCore::Font::fontList):
(WebCore::Font::loadingCustomFonts):
(Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
- 3:04 PM Changeset in webkit [130081] by
-
- 60 edits2 adds in trunk/Source/WebCore
Refactor layer-related logic out of RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=86022
Reviewed by David Hyatt.
This patch extracts layer-related logic into a dedicated class
(RenderLayerModelObject) and refactors dependent code to make use
of the new type instead of RenderBoxModelObject. This is in preparation
of adding non-RenderBoxModelObject layer supprt.
All methods that were using RenderBoxModelObject for layer-related
functionality are updated to work with RenderLayerModelObject
instead (a RenderLayer's renderer() can no longer be assumed to be
a RenderBoxModelObject).
No new tests: refactoring with no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/LayoutRepainter.h:
(WebCore):
(LayoutRepainter):
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::enclosingFloatPaintingLayer):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderBoxModelObject.cpp:
(WebCore):
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::updateFromStyle):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::popMappingsToAncestor):
- rendering/RenderGeometryMap.h:
(RenderGeometryMap):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateFromStyle):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::pushMappingToContainer):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::checkContainingBlockChainForPagination):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::isPositionedContainer):
(WebCore::RenderLayer::hasAncestorWithFilterOutsets):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::repaintIncludingNonCompositingDescendants):
- rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::renderer):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::renderer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::reasonForCompositing):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
- rendering/RenderListMarker.h:
(RenderListMarker):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
(WebCore::addLayers):
(WebCore::RenderObject::removeLayers):
(WebCore::RenderObject::moveLayers):
(WebCore::RenderObject::findNextLayer):
(WebCore::RenderObject::enclosingLayer):
(WebCore::RenderObject::setLayerNeedsFullRepaint):
(WebCore::RenderObject::setLayerNeedsFullRepaintForPositionedMovementLayout):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::shouldUseTransformFromContainer):
(WebCore::RenderObject::getTransformFromContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
(WebCore::RenderObject::container):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::isComposited):
- rendering/RenderObject.h:
(WebCore):
(WebCore::RenderObject::isLayerModelObject):
(RenderObject):
(WebCore::RenderObject::selectionRectForRepaint):
(WebCore::RenderObject::outlineBoundsForRepaint):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfoBase::repaintContainer):
(RenderSelectionInfoBase):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTableCell.h:
(RenderTableCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- rendering/RenderTableCol.h:
(RenderTableCol):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- rendering/RenderTableRow.h:
(RenderTableRow):
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
(WebCore::RenderText::selectionRectForRepaint):
- rendering/RenderText.h:
(RenderText):
- rendering/RenderLayerModelObject.cpp: Added.
(WebCore):
(WebCore::RenderLayerModelObject::RenderLayerModelObject):
(WebCore::RenderLayerModelObject::~RenderLayerModelObject):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::ensureLayer):
(WebCore::RenderLayerModelObject::hasSelfPaintingLayer):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::styleWillChange):
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderLayerModelObject.h: Added.
(WebCore):
(RenderLayerModelObject):
(WebCore::RenderLayerModelObject::layer):
(WebCore::RenderLayerModelObject::updateFromStyle):
(WebCore::toRenderLayerModelObject):
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::pushMappingToContainer):
(WebCore::isComposited):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::absoluteRects):
(WebCore::RenderView::absoluteQuads):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::clearSelection):
- rendering/RenderView.h:
(RenderView):
- rendering/RenderingAllInOne.cpp:
- rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::updateFromStyle):
- rendering/svg/RenderSVGBlock.h:
(RenderSVGBlock):
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
(WebCore::RenderSVGForeignObject::pushMappingToContainer):
- rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGHiddenContainer.h:
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
(WebCore::RenderSVGInline::mapLocalToContainer):
(WebCore::RenderSVGInline::pushMappingToContainer):
- rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::pushMappingToContainer):
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
- rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
(WebCore::RenderSVGRoot::pushMappingToContainer):
- rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
(WebCore::RenderSVGText::mapLocalToContainer):
(WebCore::RenderSVGText::pushMappingToContainer):
- rendering/svg/RenderSVGText.h:
(RenderSVGText):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
(WebCore::SVGRenderSupport::mapLocalToContainer):
(WebCore::SVGRenderSupport::pushMappingToContainer):
- rendering/svg/SVGRenderSupport.h:
(WebCore):
(SVGRenderSupport):
- 2:58 PM Changeset in webkit [130080] by
-
- 4 edits in trunk/LayoutTests
Set the line-height of the body to 0 to make this test not be text rendering dependent.
- fast/canvas/canvas-render-layer.html:
- platform/chromium-linux/fast/canvas/canvas-render-layer-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt:
- 2:33 PM WebKit Team edited by
- (diff)
- 2:31 PM Changeset in webkit [130079] by
-
- 45 edits in trunk/Source/WebCore
Refactor WebCore::FontData handling to clarify pointer ownership
https://bugs.webkit.org/show_bug.cgi?id=95866
Reviewed by Eric Seidel.
This patch makes all FontData and derived classes ref-counted in all
code paths that lead to caching or other retention of a
pointer. The goal is to avert crashes and memory leaks, and to bring
the code more in line with current WebKit practices.
Specifically, this patch allows us to use ref pointers for all the
FontData stored in FontFallbackList objects. The FontFallbackList can
then own custom font data and manage its lifetime (forthcoming patch).
Currently Document owns custom font data and does an end run around
FontFallbackList in deleting glyph pages and custom font data, leaving
FontFallbackList with invalid pointers.
All FontData derived classes have been switched to use static create
methods with private constructors.
All caches that hold FontData now use RefPtrs.
All methods that construct new font data now return PassRefPtr, with the
exception of code only used to generate temporary data for text run layout.
All methods that handle FontData in a call stack that passes through
FontFallbackList::fontDataAt return PassRefPtr.
Performance tested with both WebKit Perf-o-matic, which showed
performance changes in the noise, and Chrome's page cycling tests with
the acid3 benchmark set, which showed no performance difference at all.
No new tests as this is refactoring code only and has no impact on functionality.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::getFontData):
- css/CSSFontFace.h:
(CSSFontFace):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h:
(CSSFontFaceSource):
- css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSSegmentedFontFace.h:
(CSSSegmentedFontFace):
- dom/Document.cpp:
(WebCore::Document::registerCustomFont):
- dom/Document.h:
(Document):
- platform/graphics/Font.h:
(WebCore):
- platform/graphics/FontCache.cpp:
(WebCore):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::getFontData):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/FontData.h:
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/FontFallbackList.h:
(FontFallbackList):
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
- platform/graphics/FontSelector.h:
(FontSelector):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
- platform/graphics/SegmentedFontData.h:
(WebCore::FontDataRange::FontDataRange):
(WebCore::FontDataRange::fontData):
(FontDataRange):
(WebCore::SegmentedFontData::create):
(SegmentedFontData):
(WebCore::SegmentedFontData::SegmentedFontData):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::create):
(SimpleFontData):
(WebCore::SimpleFontData::variantFontData):
(DerivedFontData):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(GetLastResortFallbackFontProcData):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/pango/FontCachePango.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
- 2:30 PM Changeset in webkit [130078] by
-
- 2 edits in trunk/Tools
Unreviewed, upgrade eae to reviewer.
http://lists.webkit.org/mailman/private/webkit-committers/2012-October/000191.html
- Scripts/webkitpy/common/config/committers.py:
- 2:20 PM Changeset in webkit [130077] by
-
- 11 edits in trunk/Source/WebCore
Turn forbidEventDispatch and allowEventDispatch into a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96717
Reviewed by Abhishek Arya.
Replaced forbidEventDispatch and allowEventDispatch by AssertNoEventDispatch.
- dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
- dom/ContainerNode.h:
(AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::~AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::isEventDispatchForbidden):
(WebCore):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
- dom/Document.cpp:
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventTarget.cpp:
(WebCore):
(WebCore::EventTarget::fireEventListeners):
- dom/EventTarget.h:
(WebCore):
- dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):
- 2:00 PM Changeset in webkit [130076] by
-
- 2 edits in trunk/Source/WTF
Another SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=96286
Patch by Daniel Drake <dsd@laptop.org> on 2012-10-01
Reviewed by Filip Pizlo.
Disable LLint for the GTK build where the build target does not
support SSE2 instructions. Restores support for non-SSE2 processors
such as the AMD Geode.
- wtf/Platform.h:
- 2:00 PM Changeset in webkit [130075] by
-
- 2 edits in trunk/LayoutTests
Actually restrict to Windows debug this time.
- platform/chromium/TestExpectations:
- 1:57 PM Changeset in webkit [130074] by
-
- 2 edits in trunk/LayoutTests
Mark platform/chromium/virtual/gpu/fast/canvas/canvas-composite-alpha.html as slow
on Windows debug.
- platform/chromium/TestExpectations:
- 1:53 PM Changeset in webkit [130073] by
-
- 1 edit1 add in trunk/PerformanceTests
Add a performance test for nested <use> elements
https://bugs.webkit.org/show_bug.cgi?id=98047
Reviewed by Ryosuke Niwa.
Currently at ~5 runs per second on my workstation, but should go up significantly (100+)
after landing a fix for https://bugs.webkit.org/show_bug.cgi?id=97905.
- SVG/SvgNestedUse.html: Added.
- 1:44 PM Changeset in webkit [130072] by
-
- 4 edits1 add in trunk/Source/WebCore
Would like a way to customize the type of GraphicsLayers created on a per page basis
https://bugs.webkit.org/show_bug.cgi?id=98051
Reviewed by Simon Fraser.
Add a GraphicsLayerFactory abstract class and a new GraphicsLayer::create overload that takes
a factory object. Eventually, all calls to the old GraphicsLayer::create will be replaced with
the new version that takes an optional factory.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsLayer.h:
(WebCore):
(GraphicsLayer):
- platform/graphics/GraphicsLayerFactory.h: Added.
(WebCore):
(GraphicsLayerFactory):
(WebCore::GraphicsLayerFactory::~GraphicsLayerFactory):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
(WebCore):
- 1:23 PM Changeset in webkit [130071] by
-
- 2 edits in trunk/LayoutTests
Remove passing fast/event/dispatch-message-string-data.html from WK2 TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=96552
Appears to pass on Mountain Lion and Lion.
- platform/mac-wk2/TestExpectations:
- 1:13 PM Changeset in webkit [130070] by
-
- 3 edits in trunk/LayoutTests
[EFL] Update expectations after r129934 and r130056.
- platform/efl/fast/canvas/canvas-render-layer-expected.png:
- platform/efl/fast/canvas/canvas-render-layer-expected.txt:
- 1:12 PM Changeset in webkit [130069] by
-
- 6 edits in trunk/Source/WebCore
Consolidate more MutationObserverRegistration logic in Node
https://bugs.webkit.org/show_bug.cgi?id=98058
Reviewed by Ryosuke Niwa.
One remaining oddity of Node's MutationObserver-related interface was
that registerMutationObserver returned the resulting MutationObserverRegistration
object.
Instead, Node now internally handles resetting the observation
if the registration already exists, and updating the Document's list of
mutation observer types.
No change in behavior, refactoring only.
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::observe): Simplified to just call
Node::registerMutationObserver; nothing else is needed.
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::create): Take options and attributeFilter,
avoiding an unnecessary call to resetObservation().
(WebCore::MutationObserverRegistration::MutationObserverRegistration): ditto
- dom/MutationObserverRegistration.h:
(MutationObserverRegistration):
- dom/Node.cpp:
(WebCore::Node::registerMutationObserver): Handle observation
resetting if that observer's already registered, and update the list
of active MutationObserver types in the Document.
- dom/Node.h:
(Node):
- 12:53 PM Changeset in webkit [130068] by
-
- 2 edits in trunk/LayoutTests
Unskip the test in TestExpectations.
- platform/mac/TestExpectations: Unskip canvas/canvas-render-layer.html.
- 12:51 PM Changeset in webkit [130067] by
-
- 1 edit2 adds in trunk/LayoutTests
Add expected test results for r129934.
https://bugs.webkit.org/show_bug.cgi?id=97940
- platform/mac/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/mac/fast/canvas/canvas-render-layer-expected.txt: Added.
- 12:23 PM Changeset in webkit [130066] by
-
- 2 edits in trunk/Tools
[BlackBerry] Add a early return in buildCMakeProjectOrExit()
https://bugs.webkit.org/show_bug.cgi?id=98052
Patch by Ming Xie <mxie@rim.com> on 2012-10-01
Reviewed by Rob Buis.
This option allows our build to only run the CMake build configuration
step when environment variable GENERATE_CMAKE_PROJECT_ONLY is specified.
- Scripts/webkitdirs.pm:
(buildCMakeProjectOrExit):
- 12:21 PM Changeset in webkit [130065] by
-
- 4 edits in trunk/Tools
[webkitpy] Detect the multiple names of the wdiff binary in the Port class.
https://bugs.webkit.org/show_bug.cgi?id=98039
Reviewed by Dirk Pranke.
Unify the duplicate checks for the wdiff binary present in
different ports into the base Port class.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port._path_to_wdiff):
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._path_to_wdiff): Removed.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._path_to_wdiff): Removed.
- 12:11 PM Changeset in webkit [130064] by
-
- 2 edits in trunk/Tools
[chromium] Remove custom implementation of _path_to_apache_config_file in chromium_linux.
https://bugs.webkit.org/show_bug.cgi?id=98042
Reviewed by Dirk Pranke.
The Chromium-based ports inherit from Port these days, so get rid
of the custom implementation of _path_to_apache_config_file() in
favor of the more portable one in the Port class.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._path_to_apache_config_file):
- 12:09 PM Changeset in webkit [130063] by
-
- 2 edits in trunk/Source/WebCore
YYDEBUG doesn't print token values
https://bugs.webkit.org/show_bug.cgi?id=97896
Patch by Glenn Adams <glenn@skynav.com> on 2012-10-01
Reviewed by Simon Fraser.
Define YYPRINT macro to print token values when YYDEBUG is set.
No new tests. For CSS lexer/parser debug usage only.
- css/CSSGrammar.y:
Define YYPRINT macro to output IDENT and STRING typed tokens. Others can be added
in the future.
- 12:07 PM Changeset in webkit [130062] by
-
- 2 edits in trunk/Source/WebCore
[chromium] ASSERT that the embedder has set a default locale
https://bugs.webkit.org/show_bug.cgi?id=98001
Reviewed by Adam Barth.
The callsites assume that the default language is always defined, e.g.
Document::getCachedLocalizer. Add an ASSERT() statement so an embedder
doesn't have to guess what they did wrong.
- platform/chromium/LanguageChromium.cpp:
(WebCore::platformLanguage):
- 12:05 PM Changeset in webkit [130061] by
-
- 6 edits in trunk/Source
Fix compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=98020
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-01
Reviewed by Gyuyoung Kim.
Source/WebCore:
Fix compilation warnings in PluginView code.
No new tests, no behavior change.
- plugins/PluginView.cpp:
(WebCore::PluginView::newStream):
(WebCore::PluginView::write):
(WebCore::PluginView::getAuthenticationInfo):
- plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::invalidateRegion):
Source/WebKit2:
Fix compilation warnings related to ewk_view.
- UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
(_ewk_view_on_touch_down):
(_ewk_view_on_touch_up):
(_ewk_view_on_touch_move):
- UIProcess/API/efl/ewk_view_ui_client.cpp:
(exceededDatabaseQuota):
- 12:03 PM Changeset in webkit [130060] by
-
- 2 edits in trunk/Tools
[chromium] Remove duplicated _is_redhat_based() implementation from chromium_linux.py.
https://bugs.webkit.org/show_bug.cgi?id=98035
Reviewed by Dirk Pranke.
Since the Chromium port classes inherit from Port these days, it
can rely on the same implementation of _is_redhat_based() present
there instead of duplicating it.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._is_redhat_based): Removed.
- 11:59 AM Changeset in webkit [130059] by
-
- 2 edits in trunk/LayoutTests
Update some chromium expectations to match what's happening on the bots.
Notably, mark storage/indexeddb as [ Pass Slow ].
- platform/chromium/TestExpectations:
- 11:49 AM Changeset in webkit [130058] by
-
- 2 edits in branches/safari-534.58-branch/Source/WebKit2
Merge r124259.
2012-07-31 Anders Carlsson <andersca@apple.com>
Prefer the Oracle Java plug-in over the Apple Java plug-in
https://bugs.webkit.org/show_bug.cgi?id=92780
Reviewed by Oliver Hunt.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::findPluginWithBundleIdentifier):
Add a new helper for finding a plug-in with the given bundle identifier.
(WebKit::checkForPreferredPlugin):
Helper function for making sure that an old plug-in is never loaded if a new plug-in is found, and that the old plug-in
is removed from the list of loaded plug-ins if the new plug-in is found.
(WebKit::PluginInfoStore::shouldUsePlugin):
Prefer the Oracle Java plug-in over the Apple Java plug-in.
- 11:16 AM Changeset in webkit [130057] by
-
- 3 edits4 adds in trunk
RenderBlock incorrectly calculates pref width when a replaced object follows a RenderInline with width
https://bugs.webkit.org/show_bug.cgi?id=84624
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-01
Reviewed by Levi Weintraub.
Source/WebCore:
For the specific scenario, wherein an inline replaced element (image)
follows an inline flow object within a render block, we should allow
for that block to grow to accomodate the replaced element so as to
avoid it's overflow.
This quirk is handled well by other browsers.
Test: fast/block/block-with-inline-replaced-child.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
We should not cause our line to break for the scenario wherein an inline
replaced element follows an inline flow object.
For handling the same have introduced a flag: isPrevChildInlineFlow which
shall be set for an inline flow element.
Based on this, while handling the inline replaced elements, we either
terminate the line (for minWidth calculation) or not depending upon
this flag.
LayoutTests:
- fast/block/block-with-inline-replaced-child-expected.html: Added.
- fast/block/block-with-inline-replaced-child.html: Added.
- fast/block/resources: Added.
- fast/block/resources/50x50.gif: Added.
Added a ref test for verifying that the containing block grows to accomodate the
replaced element (image) when it follows an inline flow object.
Added a new directory under fast/block for resources.
- 10:44 AM Changeset in webkit [130056] by
-
- 2 edits4 adds in trunk/LayoutTests
Improvments to recently added test, fast/canvas/canvas-render-layer.html
https://bugs.webkit.org/show_bug.cgi?id=97940
Patch by Brian Salomon <bsalomon@google.com> on 2012-10-01
Reviewed by Ojan Vafai.
The test previously had whitespace between the canvases. This made the expectations dependent upon platform-specific text rendering. The spaces have been removed in the revised test.
- fast/canvas/canvas-render-layer.html:
- platform/chromium-linux/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/chromium-linux/fast/canvas/canvas-render-layer-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Added.
- 10:12 AM Changeset in webkit [130055] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening -- clean up expectations for passing tests.
- platform/chromium/TestExpectations:
- 10:11 AM Changeset in webkit [130054] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Save the download uri as file metadata
https://bugs.webkit.org/show_bug.cgi?id=98043
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-10-01
Reviewed by Carlos Garcia Campos.
gio/gvfs can store file metadata, let's use this to
store the download uri.
- WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveResponse): Save
the download uri as metadata.
- 9:36 AM Changeset in webkit [130053] by
-
- 2 edits in trunk/LayoutTests
Remove hixie76 websocket test from Qt 5.0 WK2 TestExpectations skipped list.
https://bugs.webkit.org/show_bug.cgi?id=98037
Unreviewed gardening.
Hixie76 websocket tests were moved to Hybi as Hixie76 was removed.
Also, the test that is removed from the skipped list is passing in
the Hybi version.
Patch by Michael Brüning <michael.bruning@digia.com> on 2012-10-01
- platform/qt-5.0-wk2/TestExpectations:
- 9:27 AM Changeset in webkit [130052] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed single line compilation fix for Canary Debug Mac.
- tests/MemoryInstrumentationTest.cpp:
- 8:56 AM Changeset in webkit [130051] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Adding platform-specific baselines for fast/canvas/canvas-render-layer.html
as required after r129934.
Skipping a calendar picker test that times out, the feature is not yet supported
on the GTK port.
Adding a flaky failure expectation for fast/dom/inline-event-attributes-release.html
that started occurring after r130000.
- platform/gtk/TestExpectations:
- platform/gtk/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/gtk/fast/canvas/canvas-render-layer-expected.txt: Added.
- 8:26 AM Changeset in webkit [130050] by
-
- 2 edits in trunk/Tools
[GTK] Rely on the general implementation for detecting the Apache server path.
https://bugs.webkit.org/show_bug.cgi?id=98033
Reviewed by Martin Robinson.
The implemenentation of _path_to_apache() in base.py already
checks for the same paths gtk.py tries; the only difference is
that all of the are tried regardless of the current distro.
Doing so is more portable, and lets us remove some distro-checking
from the code.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._path_to_apache): Remove.
- 8:26 AM Changeset in webkit [130049] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Chromium build fix.
- bindings/v8/V8DOMMap.h: included Node.h as reportMemoryUsage now uses Node definition.
- 7:46 AM Changeset in webkit [130048] by
-
- 25 edits1 add in trunk/Source
Web Inspector: provide memory instrumentation for HashMap
https://bugs.webkit.org/show_bug.cgi?id=98005
Reviewed by Pavel Feldman.
Source/WebCore:
Updated all call sites of MemoryInstrumentation::addHashMap to use generic
method of reporting memory footprint instead.
- bindings/v8/ScopedDOMDataStore.cpp:
- bindings/v8/V8Binding.cpp:
(WebCore::StringCache::reportMemoryUsage):
- bindings/v8/V8DOMMap.h:
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.cpp:
Source/WebKit/chromium:
Added unit tests for HashMap memory instrumentation.
- tests/MemoryInstrumentationTest.cpp:
(WTF):
Source/WTF:
Extracted HashMap memory instrumentation into its own file. The map's content
elements will be automatically traversed if their types are supported
by the memory instrumentation. No need to call special method for hash map
fields any more.
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- wtf/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WTF):
- wtf/MemoryInstrumentationHashMap.h: Added.
(WTF):
(WTF::SequenceMemoryInstrumentationTraits::reportMemoryUsage):
(WTF::reportMemoryUsage):
- 7:25 AM Changeset in webkit [130047] by
-
- 2 edits in trunk/Source/WebCore
Put implementation details of StyleBuilder.cpp into anonymous namespace
https://bugs.webkit.org/show_bug.cgi?id=98028
Reviewed by Pavel Feldman.
All types that are declared and used only inside StyleBuilder were moved
into anonymous namespace to avoid name conflicts with the rest of WebCore.
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder): renamed BorderImageType::Image into BorderImageType::BorderImage
as otherwise there is an ambiguity at placess where setPropertyHandler is called.
- 7:18 AM Changeset in webkit [130046] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Save original uri for downloaded files
https://bugs.webkit.org/show_bug.cgi?id=95188
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-10-01
Reviewed by Carlos Garcia Campos.
gvfs stores metadata locally, and this information can later be
used by file management applications. Based on a patch by
Alexander Larsson <alexl@redhat.com>.
- webkit/webkitdownload.cpp:
(webkit_download_open_stream_for_uri): Save the download-uri as
file metadata.
- 7:12 AM Changeset in webkit [130045] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Device pixel ratio lost upon relaunch of the web process
https://bugs.webkit.org/show_bug.cgi?id=97908
Reviewed by Jocelyn Turcotte.
Use setIntrinsicDeviceScaleFactor instead of setCustomDeviceScaleFactor
when setting the device pixel ratio to make the setting permanent.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewExperimental::setDevicePixelRatio):
- 7:07 AM Changeset in webkit [130044] by
-
- 1 edit21 deletes in trunk/LayoutTests
[EFL] Remove EFL-specific expectations for fast/regions/webkit-named-flow-*
https://bugs.webkit.org/show_bug.cgi?id=98029
Unreviewed, EFL gardening.
Removing redundant platform-specific test results for webkit-named-flow-* cases.
Fixes bot redness after API rename in r130041.
- platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Removed.
- platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Removed.
- 7:04 AM Changeset in webkit [130043] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove suppressing of VKB hiding when processing changes.
https://bugs.webkit.org/show_bug.cgi?id=98023
Reviewed by Rob Buis.
PR 215881.
Allow JS to blur the input field while processing key handling.
Reviewed Internally by Chris Hutten-Czapski
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- 5:52 AM Changeset in webkit [130042] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening -- clean up expectations for passing tests.
- platform/chromium/TestExpectations:
- 5:46 AM Changeset in webkit [130041] by
-
- 33 edits in trunk
[CSS Regions] Remove the deprecated API Document.webkitGetFlowByName
https://bugs.webkit.org/show_bug.cgi?id=97657
Patch by Andrei Bucur <abucur@adobe.com> on 2012-10-01
Reviewed by Andreas Kling.
Source/WebCore:
The Document.getFlowByName() API has been deprecated in favor of the NamedFlowCollection.namedItem(DOMString).
Link to spec: http://www.w3.org/TR/css3-regions/#the-namedflow-interface
Tests: The old tests have been adapted to use the new API.
- dom/Document.cpp:
(WebCore):
- dom/Document.h:
(Document):
- dom/Document.idl:
LayoutTests:
To minimize the code change impact, I've created a new method in helper.js getFlowByName() that emulates the
behaviour of Document.webkitGetFlowByName(). All the occurrences of Document.webkitGetFlowByName in the tests/expected results
have been replaced with getFlowByName.
- fast/regions/get-regions-by-content-horiz-bt.html:
- fast/regions/get-regions-by-content-horiz-tb.html:
- fast/regions/get-regions-by-content-vert-lr.html:
- fast/regions/get-regions-by-content-vert-rl.html:
- fast/regions/get-regions-by-content.html:
- fast/regions/get-regions-by-content2.html:
- fast/regions/resources/helper.js:
(getFlowByName):
- fast/regions/webkit-named-flow-event-add-to-flow.html:
- fast/regions/webkit-named-flow-event-no-regions.html:
- fast/regions/webkit-named-flow-event-remove-from-dom.html:
- fast/regions/webkit-named-flow-event-remove-from-flow.html:
- fast/regions/webkit-named-flow-event-target-expected.txt:
- fast/regions/webkit-named-flow-event-target.html:
- fast/regions/webkit-named-flow-event-to-null.html:
- fast/regions/webkit-named-flow-event.html:
- fast/regions/webkit-named-flow-existing-flow.html:
- fast/regions/webkit-named-flow-first-empty-region-index.html:
- fast/regions/webkit-named-flow-flow-added.html:
- fast/regions/webkit-named-flow-get-content-expected.txt:
- fast/regions/webkit-named-flow-get-content.html:
- fast/regions/webkit-named-flow-get-regions.html:
- fast/regions/webkit-named-flow-invalid-name.html:
- fast/regions/webkit-named-flow-modified-flow.html:
- fast/regions/webkit-named-flow-name.html:
- fast/regions/webkit-named-flow-non-existing-flow.html:
- fast/regions/webkit-named-flow-overset.html:
- fast/regions/webkit-named-flow-removed-flow.html:
- fast/regions/webkit-named-flow-same-object.html:
- 5:40 AM Changeset in webkit [130040] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] fast/history/multiple-classes-visited.html should be skipped
https://bugs.webkit.org/show_bug.cgi?id=98017
Unreviewed EFL gardening.
fast/history/multiple-classes-visited.html is globally skipped for WK2
but marked as explicit PASS for EFL port. Unfortunately, this test is
failing for EFL port as well so we need to remove the explicit PASS
expectation.
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-01
- platform/efl-wk2/TestExpectations:
- 5:28 AM Changeset in webkit [130039] by
-
- 2 edits in trunk/Source/WTF
Check that cplusplus is defined before comparing its value
https://bugs.webkit.org/show_bug.cgi?id=98015
Patch by Alberto Garcia <agarcia@igalia.com> on 2012-10-01
Reviewed by Xan Lopez.
If cplusplus is not defined is interpreted as having the value
0, but it produces a compilation warning with -Wundef.
This is the case with some API tests that are written in C
(JSNode.c, JSNodeList.c, minidom.c).
- wtf/Compiler.h:
- 5:24 AM Changeset in webkit [130038] by
-
- 1 edit2 adds in trunk/LayoutTests
[EFL] Generate baseline for fast/canvas/canvas-render-layer.html
https://bugs.webkit.org/show_bug.cgi?id=98018
Unreviewed EFL gardening.
Generate EFL baseline for fast/canvas/canvas-render-layer.html
test.
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-01
- platform/efl/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/efl/fast/canvas/canvas-render-layer-expected.txt: Added.
- 4:56 AM Changeset in webkit [130037] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/replaced/no-focus-ring-* tests should be skipped
https://bugs.webkit.org/show_bug.cgi?id=98012
Unreviewed EFL gardening.
Skip again fast/replaced/no-focus-ring-* tests as they are
failing on the build bots due to X not running.
Patch by Christophe Dumez <Christophe Dumez> on 2012-10-01
- platform/efl-wk2/TestExpectations:
- 4:30 AM Changeset in webkit [130036] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] WebKitDownload: use more of GOwnPtr/GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98009
Patch by Claudio Saavedra <Claudio Saavedra> on 2012-10-01
Reviewed by Carlos Garcia Campos.
Use more GOwnPtr/GRefPtr in WebKitDownload
- webkit/webkitdownload.cpp:
(webkit_download_open_stream_for_uri): Use GRefPtr
for a GFile and GOwnPtr for GError.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Use GOwnPtr for GError.
- 4:20 AM Changeset in webkit [130035] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] Fix viewport QML auto tests after the viewport changes
https://bugs.webkit.org/show_bug.cgi?id=97781
Reviewed by Simon Hausmann.
Since the viewport controller has to hold any QML-side viewport updates
while it applies and render the new requested position, this has the
effect of blocking all those tests if the view is not visible (thus
disabling the tile rendering completely in the web process).
The viewport should be unlocked after the first rendered frame for
static contents.
Fix those tests by forcing the QQuickView to be visible and by making
them wait for the first frame rather than the earlier end of provisional load.
- UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml:
- UIProcess/API/qt/tests/qmltests/common/TestWebView.qml:
- 4:19 AM Changeset in webkit [130034] by
-
- 4 edits in trunk/Source/WebKit2
[Qt] Add a loadVisuallyCommitted() signal
https://bugs.webkit.org/show_bug.cgi?id=97780
Reviewed by Kenneth Rohde Christiansen.
This signal is emitted when the first DidRenderFrame message is received from
the web process after loadCommitted.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::setNeedsDisplay):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- 4:19 AM Changeset in webkit [130033] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Move Qt-only related methods from WebPageProxy.cpp to WebPageProxyQt.cpp
Reviewed by Simon Hausmann.
- UIProcess/WebPageProxy.cpp:
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::didFindZoomableArea):
(WebKit):
(WebKit::WebPageProxy::findZoomableAreaForPoint):
(WebKit::WebPageProxy::didReceiveMessageFromNavigatorQtObject):
(WebKit::WebPageProxy::authenticationRequiredRequest):
(WebKit::WebPageProxy::proxyAuthenticationRequiredRequest):
(WebKit::WebPageProxy::certificateVerificationRequest):
- 4:19 AM Changeset in webkit [130032] by
-
- 2 edits in trunk/Source/WebCore
Make sure that the history position is applied correctly when using delegatesScrolling
https://bugs.webkit.org/show_bug.cgi?id=97778
Reviewed by Kenneth Rohde Christiansen.
The position is applied asynchronously and the UI process is the one holding the current
state. For this reason we can't rely in WebCore on ScrollView::scrollPosition holding
the current position in that case.
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- 4:19 AM Changeset in webkit [130031] by
-
- 17 edits in trunk/Source
[Qt] Decide when to apply a scrolled position to the viewport based on the rect covered by the tiles
https://bugs.webkit.org/show_bug.cgi?id=97777
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
- platform/graphics/TiledBackingStore.h:
(WebCore::TiledBackingStore::coverRect):
(WebCore::TiledBackingStore::setCoverRect):
(TiledBackingStore):
Source/WebKit2:
This patch achieves two things:
- Apply a short scroll position request directly if we already have rendered tiles at this position.
- Since our visible rect request is asynchronous, the next frame might not always be the one covering this position. This will wait for a frame that does to apply it.
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
(QRawWebViewPrivate::didRenderFrame):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/PageClient.h:
(PageClient):
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didCommitLoad):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageDidRequestScroll):
- UIProcess/PageViewportController.h:
(PageViewportController):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::didRenderFrame):
- UIProcess/qt/QtPageClient.h:
(QtPageClient):
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::didRenderFrame):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(WebCore::CoordinatedGraphicsLayer::coverRect):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
- 4:18 AM Changeset in webkit [130030] by
-
- 19 edits in trunk/Source/WebKit2
[Qt] Delay viewport position, scale and contents size updates until tiles are rendered
https://bugs.webkit.org/show_bug.cgi?id=97775
Reviewed by Kenneth Rohde Christiansen.
A few events from the web process can cause the viewport position or scale to be
adjusted in the UI process:
- Scroll position request
- Viewport attributes (initialScale, minimumScale)
- Contents size change
We previously applied those updates directly to the viewport, which would then in turn
produce a corresponding visible rect request to the web process to render the contents
at the new position/scale. This could leave the viewport showing the old content, either
by scaling the tiles, or by showing checkerboard if no contents was rendered at this
position yet. When the web process was done rendering new tiles, the proper tiles
were then shown to the user.
Since many of these updates happen during page load, all producing an itterative adjustment
to the viewport, this could show sharpness and position jitter until the final rendering
was done.
This patch makes those updates go through the PageViewportController first and then to the
QQuickWebView rather than the other way around, and keep them pending until the
LayerTreeHostProxy reports that the new tiles are ready to be shown. Since the rendering
is blocked until the page first layout is done, this apply the modifications to
the viewport only once when the first frame is ready to be shown.
- UIProcess/API/qt/qquickwebview.cpp:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewFlickablePrivate):
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
(QRawWebViewPrivate::didRenderFrame):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
- UIProcess/PageClient.h:
(PageClient):
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didCommitLoad):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::initialViewportReady):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):
- UIProcess/PageViewportController.h:
(PageViewportController):
- UIProcess/PageViewportControllerClient.h:
(PageViewportControllerClient):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
- UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::didRenderFrame):
(WebKit):
(WebKit::QtPageClient::didChangeContentsSize):
- UIProcess/qt/QtPageClient.h:
(QtPageClient):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit::QtWebPageLoadClient::didCommitLoad):
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::didRenderFrame):
(WebKit):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
- 4:17 AM Changeset in webkit [130029] by
-
- 17 edits in trunk/Source/WebKit2
[Qt] Wait for the UI process before re-enabling rendering during page load
https://bugs.webkit.org/show_bug.cgi?id=97773
Reviewed by Kenneth Rohde Christiansen.
During page navigation, WebCore might ask asynchronously the UI process to
scroll to an anchor or restored history position and the UI process will
return the corresponding visible rect to be rendered by the web process.
To avoid rendering tiles for the invalidated area by the new page layout at
the wrong position, we should do an extra message round-trip to the UI
process before resuming the rendering.
Assuming that all messages are handled in order by both the web and UI process,
sending the round-trip request in the web process once we sent all scroll
requests, contents size and viewport attributes updates and then handling
the round-trip response, we make sure that final visible rect request have
been handled already.
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::pageTransitionViewportReady):
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
(QRawWebViewPrivate):
- UIProcess/PageClient.h:
(PageClient):
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit):
- UIProcess/PageViewportController.h:
(PageViewportController):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::pageTransitionViewportReady):
(WebKit):
- UIProcess/qt/QtPageClient.h:
(QtPageClient):
- UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::commitPageTransitionViewport):
(WebKit):
(WebKit::WebPageProxy::pageTransitionViewportReady):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::frameLoadCompleted):
(WebKit::WebFrameLoaderClient::provisionalLoadStarted):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didStartPageTransition):
(WebKit):
(WebKit::WebPage::didCompletePageTransition):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::commitPageTransitionViewport):
(WebKit):
- 4:12 AM Changeset in webkit [130028] by
-
- 2 edits in trunk/Source/WebKit2
WebPrintOperationGtk destructor should be virtual
https://bugs.webkit.org/show_bug.cgi?id=98002
Patch by Alberto Garcia <agarcia@igalia.com> on 2012-10-01
Reviewed by Carlos Garcia Campos.
WebPrintOperationGtk is an abstract class which can be deleted
using a pointer to itself, yet its destructor is not virtual.
Fixes -Wdelete-non-virtual-dtor.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
(WebPrintOperationGtk):
- 4:00 AM Changeset in webkit [130027] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/WebCore:
- GNUmakefile.list.am: ClipPathOperation.h was moved.
Source/WTF:
- GNUmakefile.list.am: Add missing header files to compilation.
- 3:45 AM Changeset in webkit [130026] by
-
- 3 edits2 adds in trunk
Microdata: names.item() must return null for out of range indexes.
https://bugs.webkit.org/show_bug.cgi?id=97898
Reviewed by Kentaro Hara.
Source/WebCore:
DOMStringList.item() must return null for an invalid index.
Spec: http://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList
Removed [IsIndex] extended IDL attribute from item() method's index
parameter in DOMStringList interface.
Firefox and Opera's behavior is consistent with the spec. Both
returns null for invalid index.
Test: fast/dom/MicroData/names-item-out-of-range-index.html
- dom/DOMStringList.idl:
LayoutTests:
Added test case to ensure names.item() behavior for out of range indexes.
- fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Added.
- fast/dom/MicroData/names-item-out-of-range-index.html: Added.
- 3:36 AM Changeset in webkit [130025] by
-
- 2 edits in trunk/Tools
Unreviewed, update the URL of the Szeged SVN mirror.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:23 AM Changeset in webkit [130024] by
-
- 6 edits3 adds in trunk
[Forms] Multiple fields week input UI
https://bugs.webkit.org/show_bug.cgi?id=97877
Reviewed by Kent Tamura.
Source/WebCore:
This patch introduces multiple fields "week" input UI in DRT. We'll
enable this feature once we add tests.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
No new tests. To reduce size of this patch, other patches add tests
for multiple fields week input UI.
Note: Actual outputs of two tests
- fast/forms/week/week-input-visible-string.html
- fast/forms/week/week-stepup-stepdown-from-renderer.html
are different.
- css/thml.css:
(input::-webkit-datetime-edit-week-field): Added for field appearance.
(input::-webkit-datetime-edit-week-field:focus): Added to remove focus ring.
- html/WeekInputType.cpp:
(WebCore::WeekInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
(WebCore::WeekInputType::setupLayoutParameters): Added to set layout of multiple fields.
- html/WeekInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseWeekInputType typedef.
(WebCore::WeekInputType::WeekInputType): Changed base class name to BaseWeekInputType.
(WeekInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField): Changed to support week field.
LayoutTests:
This patch adds Chromium port specific expectations for "week" input
type tests for multiple fields week input UI.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_WEEK
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
- platform/chromium/fast/forms/week/week-input-visible-string-expected.txt: Added. Multiple fields week input UI doesn't have selection.
- platform/chromium/fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields week input UI, step down/up decrement/increment a field rather than whole value.
- 2:52 AM Changeset in webkit [130023] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening -- removed TestExpectation entries for passing tests.
- platform/chromium/TestExpectations:
- 2:43 AM Changeset in webkit [130022] by
-
- 6 edits1 move1 delete in trunk/LayoutTests
Unreviewed gardening -- rebaselined meter element tests on chromium-mac.
- fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/chromium/TestExpectations:
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Removed.
- 2:41 AM Changeset in webkit [130021] by
-
- 32 edits in trunk/Source/WebCore
Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks
https://bugs.webkit.org/show_bug.cgi?id=96730
Reviewed by Vsevolod Vlasov.
- Introduced InspectorInstrumentation::console|timeline|runtime|canvasAgentEnabled
- Using it all over the place instead of the hasFrontend (the latter is now only used once to guard hot path)
- Introduced explicit "enabled" state of the console and runtime agents
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
- bindings/js/ScriptCallStackFactory.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallWith):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
- bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
- bindings/v8/ScriptCallStackFactory.h:
(WebCore):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunctionWithInstrumentation):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore):
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
(WebCore::InspectorConsoleAgent::enabled):
(InspectorConsoleAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::enabled):
(WebCore::InspectorRuntimeAgent::enable):
(WebCore::InspectorRuntimeAgent::disable):
(InspectorRuntimeAgent):
- inspector/PageRuntimeAgent.cpp:
(PageRuntimeAgentState):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didClearWindowObject):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype._didLoadCachedResources):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
- 2:37 AM Changeset in webkit [130020] by
-
- 2 edits in trunk/Tools
Unreviewed. Create WebSocket watch list, and add myself to that list.
- Scripts/webkitpy/common/config/watchlist:
- 2:29 AM Changeset in webkit [130019] by
-
- 7 edits in trunk
[WebSocket] Setting wrong value to binaryType should not raise exception
https://bugs.webkit.org/show_bug.cgi?id=97999
Reviewed by Yuta Kitamura.
Source/WebCore:
Don't raise exception when binaryType is the wrong value.
Instead, show an error message to console.
No new tests. Updated existing test.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::setBinaryType): See the description.
- Modules/websockets/WebSocket.h:
(WebSocket): Removed ExceptionCode argument of setBinaryType().
- Modules/websockets/WebSocket.idl:
Removed "setter raises(DOMException)" and "[TreatReturnedNullStringAs=Undefined]".
They are no longer needed.
LayoutTests:
Update binary-type.html.
- http/tests/websocket/tests/hybi/binary-type-expected.txt:
- http/tests/websocket/tests/hybi/binary-type.html:
- 2:22 AM QtWebKitBuildBots edited by
- (diff)
- 2:18 AM Changeset in webkit [130018] by
-
- 5 edits in trunk/Source/WebCore
[Forms] Adding DateTimeWeekFieldElement for multiple fields "week" input UI
https://bugs.webkit.org/show_bug.cgi?id=97992
Reviewed by Kent Tamura.
This patch introduces DateTimeWeekFieldElement class for implementing
multiple fields "week" input UI.
No new tests. This patch doesn't change behavior.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement): Added.
(WebCore::DateTimeWeekFieldElement::create): Added.
(WebCore::DateTimeWeekFieldElement::populateDateTimeFieldsState): Added.
(WebCore::DateTimeWeekFieldElement::setValueAsDate): Added.
(WebCore::DateTimeWeekFieldElement::setValueAsDateTimeFieldsState): Added.
- html/shadow/DateTimeFieldElements.h:
(DateTimeWeekFieldElement): Added.
- platform/DateComponents.h:
(WebCore::DateComponents): Added declarations of static const member variables, DateComponents::maximumWeekNumber and minimumWeekNumber.
- platform/DateComponents.cpp: Added definitions of DateComponents::maximumWeekNumber and minimumWeekNumber.
(WebCore::DateComponents::maxWeekNumberInYear): Changed to use maximumWeekNumber.
(WebCore::DateComponents::parseWeek): Changed to use minimumWeekNumber.
- 2:05 AM Changeset in webkit [130017] by
-
- 2 edits15 adds in trunk/LayoutTests
Unreviewed gardening. Added expectations for 4 month-multiple-fields tests for chromium mac & win.
https://bugs.webkit.org/show_bug.cgi?id=97888
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium/TestExpectations:
- 1:46 AM Changeset in webkit [130016] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Separate CSSStyleModelResourceBinding into resource and content binding.
https://bugs.webkit.org/show_bug.cgi?id=97994
Reviewed by Pavel Feldman.
Extracted StyleContentBinding from CSSStyleModelResourceBinding.
Now CSSStyleModelResourceBinding is responsible for mapping between stylesheets and resources.
StyleContentBinding is now responsible for synchronization between stylesheet content and uiSourceCode content.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestStyleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestResourceURLForStyleSheetId):
- inspector/front-end/StyleSource.js:
(WebInspector.StyleSource.prototype._commitIncrementalEdit):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StyleContentBinding):
(WebInspector.StyleContentBinding.prototype.setStyleContent.callback):
(WebInspector.StyleContentBinding.prototype.setStyleContent):
(WebInspector.StyleContentBinding.prototype._innerSetContent.callback):
(WebInspector.StyleContentBinding.prototype._innerSetContent):
(WebInspector.StyleContentBinding.prototype._styleSheetChanged.callback):
(WebInspector.StyleContentBinding.prototype._styleSheetChanged):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
- inspector/front-end/inspector.js:
- 1:38 AM Changeset in webkit [130015] by
-
- 11 edits in trunk/Source
Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay
https://bugs.webkit.org/show_bug.cgi?id=97799
Reviewed by Pavel Feldman.
Source/WebCore:
Re-applying r129746 with test flakiness fixed.
In order to reduce the amount of port-specific code, the gutter overlay painted in the device metrics emulation mode
has been replaced by the respective functionality in the HTML-based InspectorOverlay in WebCore. The InspectorOverlay
now covers the entire WebView rather than the FrameView only.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::webViewResized):
(WebCore):
- inspector/InspectorController.h:
(WebCore):
(InspectorController):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::resize):
(WebCore):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawGutter):
(WebCore::InspectorOverlay::reset):
- inspector/InspectorOverlay.h:
(InspectorOverlay):
- inspector/InspectorOverlayPage.html: Introduce the gutter painting functionality previously found in the Chromium's
DeviceMetricsSupport class, which used to implement WebPageOverlay.
Source/WebKit/chromium:
- Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay.
- Remove the gutter overlay painting code.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- src/WebDevToolsAgentPrivate.h:
(WebDevToolsAgentPrivate):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
- 1:35 AM Changeset in webkit [130014] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unused sys/mman.h include
https://bugs.webkit.org/show_bug.cgi?id=97995
Patch by Jonathan Liu <net147@gmail.com> on 2012-10-01
Reviewed by Kentaro Hara.
The sys/mman.h is not used and removing it improves portability as not
all systems have sys/mman.h.
- jit/ExecutableAllocatorFixedVMPool.cpp:
- 1:33 AM Changeset in webkit [130013] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build after r129908.
- GNUmakefile.list.am: Add new files to compilation.
- 1:26 AM Changeset in webkit [130012] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip fast/innerHTML/innerHTML-iframe.html after r130003.
- platform/efl/TestExpectations:
- 1:01 AM Changeset in webkit [130011] by
-
- 2 edits in trunk/Source/WebCore
Remove overzealous assert in SVGElement::localAttributeToPropertyMap
https://bugs.webkit.org/show_bug.cgi?id=97291
Reviewed by Nikolas Zimmermann.
This patch removes an assert where we did not expect
SVGElement::localAttributeToPropertyMap where we did not to be called. This
function turns out to be useful and this patch removes that assert.
If we encounter a non-SVG tag during SVG parsing (e.g. <svg><price></svg>) we return a
vanilla SVGElement instance from SVGElementFactory::createSVGElement. Previously,
trying to animate this would ASSERT because it was not possible to determine the
animated type. After this patch, an empty localAttributeToPropertyMap is used so
that the animated type returned from SVGAnimateElement::determineAnimatedPropertyType
is AnimatedUnknown.
This patch simply removes an ASSERT so no test is provided.
- svg/SVGElement.cpp:
(WebCore::SVGElement::localAttributeToPropertyMap):
- 12:58 AM Changeset in webkit [130010] by
-
- 8 edits14 adds in trunk/LayoutTests
Add appearance tests for multiple fields month input UI
https://bugs.webkit.org/show_bug.cgi?id=97888
Reviewed by Kent Tamura.
This patch adds tests for multiple fields month input UI and disables
these tests on ports which don't enable both ENABLE_INPUT_TYPE_MONTH
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
Note: We need to do rebaseline tests to update images for Chromium-Mac
and Chromium-Win.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_MONTH
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html: Added for checking basic appearance.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html: Added for checking appearance of applying CSS pseudo classes, e.g. :enabled, :invalid, and so on.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html: Added for checking appearance of applying CSS pseudo elements, e.g. :after, :before, and so on.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html: Added for checking appearance of applying CSS styles
- platform/chromium-android/TestExpectations: Changed to disable tests for multiple fields month input UI.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
- platform/chromium/TestExpectations: Changed to disable tests for multiple fields month input UI of Mac and Win for rebaseline.
- platform/efl/TestExpectations: Changed to disable tests for multiple fields month input UI.
- platform/gtk/TestExpectations: ditto
- platform/mac/TestExpectations: ditto
- platform/qt/TestExpectations: ditto
- platform/win/TestExpectations: ditto
- 12:20 AM Changeset in webkit [130009] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r130004.
http://trac.webkit.org/changeset/130004
https://bugs.webkit.org/show_bug.cgi?id=97996
Test shadow-dom-modify-chardata.html is failing (Requested by
keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-01
Source/WebCore:
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
LayoutTests:
- inspector/elements/shadow-dom-modify-chardata-expected.txt: Removed.
- inspector/elements/shadow-dom-modify-chardata.html: Removed.
- 12:15 AM Changeset in webkit [130008] by
-
- 4 edits2 adds in trunk
REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893
Reviewed by Kent Tamura.
Source/WebCore:
There were two mistakes:
- An if-statement to check step attribute validity was wrong, and
- DateTiemChooserParameters.step was milleseconds when it should be number of days.
This will be changing the DateTimeChooserParameters.step to milliseconds so we can handle steps for other input types in the future.
Test: fast/forms/date/calendar-picker-appearance-with-step.html
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker):
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): If statement was wrong.
LayoutTests:
- fast/forms/date/calendar-picker-appearance-with-step-expected.txt: Added.
- fast/forms/date/calendar-picker-appearance-with-step.html: Added.
Sep 30, 2012:
- 11:13 PM Changeset in webkit [130007] by
-
- 3 edits2 adds in trunk
Sign in front of keyframe selector causes stylesheet parsing to abort
https://bugs.webkit.org/show_bug.cgi?id=96844
Patch by Glenn Adams <glenn@skynav.com> on 2012-09-30
Reviewed by Simon Fraser.
Source/WebCore:
Allow optional unary operator (+) on PERCENTAGE in keyframe selector. Test: animations/keyframe-selector-negative-percentage.html
- css/CSSGrammar.y:
Add maybe_unary_operator to PERCENTAGE on keyframe selector. Negative keyframe
selector value is already ignored in StyleKeyframe::parseKeyString.
LayoutTests:
Add test case for correct handling of negative percentage in keyframe selector.
- animations/keyframe-selector-negative-percentage-expected.txt: Added.
- animations/keyframe-selector-negative-percentage.html: Added.
- 10:56 PM Changeset in webkit [130006] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=97988
Crash on FrameTree::scopedChildCount()
Reviewed by Kent Tamura.
The series of crash reports says that there are some null pointer
access in scopedChildCount(). This change added a null guard
against Frame::document(), that can return null.
No new tests. This is tied to some specific timing and is hard to reproduce.
- page/FrameTree.cpp:
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::scopedChild):
(WebCore):
- 10:50 PM Changeset in webkit [130005] by
-
- 8 edits in trunk/Source/WebCore
Make multiple fields date/time input UI related files to available all ports
https://bugs.webkit.org/show_bug.cgi?id=97989
Reviewed by Kent Tamura.
This patch adds multiple fields date/time input UI related files for
ports not using WebCore.gyp and simplifies include directive in
MonthInputType.h and TimeInputType.h.
Added files are:
- html/BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
- html/shadow/DateTimeEditElement.{cpp,h}
- html/shadow/DateTimeFieldElement.{cpp,h}
- html/shadow/DateTimeFieldElements.{cpp,h}
- html/shadow/DateTimeNumericFieldElement.{cpp,h}
- html/shadow/DateTimeSymbolicFieldElement.{cpp,h}
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Changed to add multiple fields date/time input UI related files.
- GNUmakefile.list.am: ditto
- Target.pri: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- html/MonthInputType.h: Changed to simplify include directive for base class.
- html/TimeInputType.h: ditto
- 9:32 PM FeatureFlags edited by
- Add SATURATED_LAYOUT_ARITHMETIC (diff)
- 8:57 PM Changeset in webkit [130004] by
-
- 3 edits2 adds in trunk
Web Inspector: Modifications in a shadow tree don't update the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=97056
Reviewed by Pavel Feldman.
Source/WebCore:
Send characterDataModified event for shadow dom nodes too so they update the elements panel.
Test: inspector/elements/shadow-dom-modify-chardata.html
- dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
LayoutTests:
- inspector/elements/shadow-dom-modify-chardata-expected.txt: Added.
- inspector/elements/shadow-dom-modify-chardata.html: Added.
- 7:45 PM Changeset in webkit [130003] by
-
- 5 edits in trunk/LayoutTests
Trivial test fix after r127534.
https://bugs.webkit.org/show_bug.cgi?id=95813
Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-30
Reviewed by Kentaro Hara.
- fast/innerHTML/innerHTML-iframe-expected.txt:
- fast/innerHTML/innerHTML-iframe.html:
- platform/chromium/TestExpectations:
- platform/qt/TestExpectations:
- 7:44 PM Changeset in webkit [130002] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 7:34 PM WebKit Team edited by
- (diff)
- 6:57 PM Changeset in webkit [130001] by
-
- 4 edits2 adds in trunk
[chromium] Add a test to verify that a plugin does not receive touch-events unless it explicitly requests for them
https://bugs.webkit.org/show_bug.cgi?id=97975
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-09-30
Reviewed by Adam Barth.
Tools:
TestWebPlugin can now be configured to accept touch events or not. Use this
configurability to verify that a plugin does not receive touch events unless
it explicitly requests for them.
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::initialize):
(TestWebPlugin::parseBoolean):
- DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin):
LayoutTests:
- platform/chromium/plugins/touch-events-expected.txt: Added.
- platform/chromium/plugins/touch-events.html: Added.
- 6:30 PM Changeset in webkit [130000] by
-
- 4 edits in trunk/Source/WebCore
Split EventTargetData out of NodeRareData to reduce memory use.
<http://webkit.org/b/97987>
<rdar://problem/12403258>
Reviewed by Anders Carlsson.
Move EventTargetData to its own Node-flag/hashmap instead of piggybacking on NodeRareData.
This reduces memory consumption by 1.06MB on Membuster3. Note that NodeRareData shrinks by
one pointer as well.
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::eventTargetDataMap):
(WebCore::Node::eventTargetData):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::clearEventTargetData):
(WebCore::Node::handleLocalEvents):
- dom/Node.h:
(WebCore::Node::hasEventTargetData):
(WebCore::Node::setHasEventTargetData):
- dom/NodeRareData.h:
(NodeRareData):
- 5:28 PM Changeset in webkit [129999] by
-
- 2 edits in trunk/Source/WTF
Clean up HasTrivialConstructor/Destructor
https://bugs.webkit.org/show_bug.cgi?id=97754
Reviewed by Sam Weinig.
Mixed up the HasTrivialDestructor/Constructor case for VS2010 and later in the previous patch.
- wtf/TypeTraits.h:
- 4:31 PM Changeset in webkit [129998] by
-
- 9 edits in branches/safari-534.58-branch/Source
Merge r123907.
2012-07-27 Anders Carlsson <andersca@apple.com>
Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521
Reviewed by Sam Weinig.
Source/WebCore:
Now that <applet> behaves more like <embed> and <object>, make sure that we show the unavailable plug-in indicator
and call the correct error callbacks if we fail to instantiate the plug-in.
- WebCore.exp.in:
Export a symbol needed by WebKit2.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
Set the correct service type.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
Enable the unavailable plug-in indicator if we fail to create the java applet widget.
Source/WebKit/mac:
Check if the Java plug-in is blocked before trying to instantiate it.
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.
- 3:51 PM Changeset in webkit [129997] by
-
- 15 edits in branches/safari-534.58-branch/Source/WebCore
Merge r123811.
2012-07-26 Anders Carlsson <andersca@apple.com>
HTMLAppletElement should inherit from HTMLPlugInImageElement
https://bugs.webkit.org/show_bug.cgi?id=92320
Reviewed by Eric Seidel.
In order to simplify the class hierarchy and eventually merge HTMLPlugInImageElement and HMTLPlugInElement,
make HTMLAppletElement inherit from HTMLPlugInImageElement. While this does mean that HTMLAppletElement will grow by
a couple of words, in practice it won't matter.
Also, make RenderApplet inherit from RenderEmbeddedObject and move the plug-in instantiation to HTMLAppletElement which matches
both HTMLEmbedElement and HTMLObjectElement.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
(WebCore::HTMLAppletElement::parseAttribute):
(WebCore::HTMLAppletElement::rendererIsNeeded):
(WebCore::HTMLAppletElement::createRenderer):
(WebCore):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
(WebCore::HTMLAppletElement::updateWidget):
- html/HTMLAppletElement.h:
(HTMLAppletElement):
- html/HTMLTagNames.in:
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
- loader/SubframeLoader.h:
(SubframeLoader):
- page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
- rendering/RenderApplet.cpp:
(WebCore::RenderApplet::RenderApplet):
- rendering/RenderApplet.h:
(RenderApplet):
- rendering/RenderEmbeddedObject.h:
(WebCore::toRenderEmbeddedObject):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
- rendering/RenderObject.h:
- 2:06 PM Changeset in webkit [129996] by
-
- 3 edits in trunk/Source/WebCore
444kB below CSSParser::parseDeprecatedGradient() on Membuster3.
<http://webkit.org/b/97981>
<rdar://problem/12403058>
Reviewed by Anders Carlsson.
Slap an inline capacity of 2 on the Vector<CSSGradientColorStop> in CSSGradientValue.
This covers the majority of gradient values, and reduces memory consumption by ~250kB on Membuster3.
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::stopCount):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseGradientColorStops):
- 12:35 PM Changeset in webkit [129995] by
-
- 2 edits in trunk/Source/WebCore
Remove FIXME comments refering to non-existent code in JSDOMBinding.cpp
https://bugs.webkit.org/show_bug.cgi?id=97977
Reviewed by Adam Barth.
I did a quick grep through the code to determine where these FIXME
comments were suggesting that code should be merged. So far as I can
tell, 'immediatelyReportUnsafeAccessTo' only exists in these comments.
Just cleanup, no functional change.
- bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):
- 11:40 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:38 AM Changeset in webkit [129994] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][GTK] Add API to get the favicon for a WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=96477
Reviewed by Carlos Garcia Campos.
Provide a new simple API to synchronously try to get the favicon
associated with a WebView, if any, and to keep track of changes on
it, through a new GObject property.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate):
(webkitWebViewIconReadyCallback): Callback to handle the
'icon-ready' signal coming from WebKitFaviconDatabase.
(webkitWebViewWatchForChangesInFavicon): Connects to the
'icon-ready' signal from WebKitFaviconDatabase, to keep track of
changes in favicons, that must be related to the current view.
(webkitWebViewDisconnectFaviconDatabaseSignalHandlers):
Disconnects the handler for 'icon-ready' if needed.
(webkitWebViewGetProperty): Updated for the new "favicon" property .
(webkitWebViewFinalize): Disconnect the new signal handler.
(webkit_web_view_class_init): Definition of the new property.
(webkitWebViewEmitLoadChanged): Make sure we will be watching for
changes in the favicon from WEBKIT_LOAD_STARTED on.
(webkit_web_view_get_favicon): New API funtcion, returning the
current favicon for the WebView, if any, or NULL otherwise.
- UIProcess/API/gtk/WebKitWebView.h:
Internally expose a way to try to get the favicon associated to a
page URL synchronously, through WebKitFaviconDatabase.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseGetFaviconSync): New internal function, it
will return either 0 or a valid pointer to a cairo_surface_t.
- UIProcess/API/gtk/WebKitFaviconDatabasePrivate.h:
Add unit tests for checking this new API.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testWebViewFavicon): New unit test.
(beforeAll): Add the test to the test suite.
- 10:08 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:46 AM EFLSettingsApiTutorial edited by
- (diff)
- 9:40 AM EFLWebKit edited by
- (diff)
- 9:28 AM Changeset in webkit [129993] by
-
- 7 edits in trunk/Source/WebCore
[TextureMapper] [WebKit2] Crash in WebCore::BitmapTextureGL::updateContents
https://bugs.webkit.org/show_bug.cgi?id=97394
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-30
Reviewed by Noam Rosenthal.
When a TextureMapper is destroyed, layers can still contain references
to textures obtained from that TextureMapper's texture pool. Trying to
access an unreffed TextureMapper in the BitmapTexture's destructor
causes a crash.
Instead of storing a raw pointer to a TextureMapper, we can simply store
a reference to the underlying GraphicsContext3D. All TextureMapper
implementations use the current GL context at this moment, so one GC3D
referencing the current context is the same as any other.
- platform/graphics/texmap/TextureMapper.h: Remove the clearTexturePool
method. It's no longer used.
(WebCore::BitmapTexture::applyFilters): Add a TextureMapper* argument.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::BitmapTextureGL): Keep a reference to the
GraphicsContext3D instead of the TextureMapper.
(WebCore::BitmapTextureGL::didReset): Use the GC3D reference.
(WebCore::BitmapTextureGL::updateContents): Ditto.
(WebCore::BitmapTextureGL::applyFilters): Accept the TextureMapper as an argument.
(WebCore::BitmapTextureGL::initializeStencil): Use the GC3D reference.
(WebCore::BitmapTextureGL::clearIfNeeded): Ditto.
(WebCore::BitmapTextureGL::createFboIfNeeded): Ditto.
(WebCore::BitmapTextureGL::bind): Accept the TextureMapper as an argument.
(WebCore::BitmapTextureGL::~BitmapTextureGL): Use the GC3D reference.
(WebCore::TextureMapperGL::~TextureMapperGL): Remove the call to clearTexturePool
as it's no longer necessary.
(WebCore::TextureMapperGL::bindSurface): Ditto.
- platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL): Keep a GC3D reference instead of a TextureMapper pointer.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters): Add a TextureMapper argument.
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::applyFilters): Ditto.
- 9:03 AM WebKitGTK/1.10.x edited by
- (diff)
- 7:56 AM Changeset in webkit [129992] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][GTK] Fix issues with WebKitFaviconDatabase in debug builds
https://bugs.webkit.org/show_bug.cgi?id=97966
Reviewed by Carlos Garcia Campos.
Fix failing ASSERTs detected when running the unit tests from
TestWebKitFaviconDatabase in debug builds.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseDispose): Close IconDatabase here, which is
the right place to do it according to GObject documentation.
(webkitFaviconDatabaseFinalize): Just destroy the private data
structure and chain up to parent class's finalize method.
(webkit_favicon_database_class_init): Override dispose method.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseFinalizedCallback): Delete files when the
WebKitFaviconDatabase is being finalized, since by that time the
IconDatabase from WebCore will be already closed.
(afterAll): Add a weak reference to WebKitFaviconDatabase and
provide a GWeakNotify callback (webkitFaviconDatabaseFinalizedCallback).
- 6:59 AM FeatureFlags edited by
- Remove JAVA_BRIDGE (diff)
- 6:46 AM Changeset in webkit [129991] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Rebaseline for DateTimeNumericFieldElement should use Localizer functions.
https://bugs.webkit.org/show_bug.cgi?id=97318
- platform/chromium/TestExpectation:
- platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:
- platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:
- 4:47 AM Changeset in webkit [129990] by
-
- 2 edits in trunk/LayoutTests
[EFL] Add proper bug links to the protocol handler crashes in efl-wk2.
- platform/efl-wk2/TestExpectations:
- 4:37 AM EFLSettingsApiTutorial edited by
- (diff)
- 4:32 AM EFLSettingsApiTutorial created by
- 4:19 AM Changeset in webkit [129989] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip a few seemingly passing tests with no associated bug.
- platform/efl-wk2/TestExpectations:
Sep 29, 2012:
- 7:29 PM Changeset in webkit [129988] by
-
- 6 edits in trunk/Source/WebCore
AsyncFileSystem::openFileSystem should have FileSystemType as a parameter.
https://bugs.webkit.org/show_bug.cgi?id=97963
Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-09-29
Reviewed by Gyuyoung Kim.
FileSystemType is an important information to maintain the file system,
and AsyncFileSystem::openFileSystem need to get the type as a parameter.
And, there are "FIXME" comments about that in WebCore source codes.
No new functionality, no new tests.
- Modules/filesystem/LocalFileSystem.cpp: Add FileSystemType as a parameter of AsyncFileSystem::openFileSystem.
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):
- platform/AsyncFileSystem.cpp: ditto.
(WebCore::AsyncFileSystem::openFileSystem):
- platform/AsyncFileSystem.h: ditto.
(AsyncFileSystem):
- platform/blackberry/AsyncFileSystemBlackBerry.cpp: ditto.
(WebCore::AsyncFileSystem::openFileSystem):
- platform/gtk/AsyncFileSystemGtk.cpp: ditto.
(WebCore::AsyncFileSystem::openFileSystem):
- 3:20 PM Changeset in webkit [129987] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip test that seems to be passing now.
- platform/efl/TestExpectations:
- 3:13 PM Changeset in webkit [129986] by
-
- 2 edits2 adds in trunk/LayoutTests
[EFL] Unskip {horizontal,vertical}-scrollbar-in-rtl.html
The expectations in fast/dom are actually Mac-specific (cf.
r73063), and most other ports use their own platform-specific
results due to the differences in behavior of the Home/End keys.
The results being checked in here are in line with the other
ports, so everything seems to be OK.
- platform/efl/TestExpectations:
- platform/efl/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/efl/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
- 1:55 PM Changeset in webkit [129985] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r129982.
http://trac.webkit.org/changeset/129982
https://bugs.webkit.org/show_bug.cgi?id=97971
hit assert in fast/overflow/overflow-height-float-not-removed-
crash3.html (Requested by eae on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-29
- wtf/Platform.h:
- 1:29 PM Changeset in webkit [129984] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r129965.
http://trac.webkit.org/changeset/129965
https://bugs.webkit.org/show_bug.cgi?id=97970
Causes ASSERTs in workers (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-29
- bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
- bindings/v8/ScopedPersistent.h:
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- 1:12 PM WebKitGTK/1.10.x edited by
- (diff)
- 11:37 AM Changeset in webkit [129983] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for chromium/clank.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
- 10:43 AM Changeset in webkit [129982] by
-
- 2 edits in trunk/Source/WTF
Enable SATURATED_LAYOUT_ARITHMETIC for chromium
https://bugs.webkit.org/show_bug.cgi?id=95053
Reviewed by Abhishek Arya.
Enable the SATURATED_LAYOUT_ARITHMETIC flag for the chromium port.
This changes the behavior of FractionalLayoutUnit to clamp to the
max or min value instead of overflowing.
This may very well impact performance so the current plan is to enable
it for a couple of hours to a day to collect performance data and then
disable it again until we've had a chance to review the perf data.
- wtf/Platform.h:
- 9:03 AM Changeset in webkit [129981] by
-
- 4 edits in trunk/LayoutTests
[EFL] Rebaseline test after r129695.
- platform/efl/TestExpectations:
- platform/efl/mathml/presentation/tables-expected.png:
- platform/efl/mathml/presentation/tables-expected.txt:
- 8:47 AM Changeset in webkit [129980] by
-
- 2 edits in trunk/LayoutTests
[EFL] Revert r129978.
Skip media/unsupported-rtsp.html again, as it still fails on the
bots. I have created a proper bug for the issue now.
- platform/efl/TestExpectations:
- 8:17 AM Changeset in webkit [129979] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip fast/css/device-aspect-ratio.html
This seems to be another test with no bug report that is now
passing.
- platform/efl/TestExpectations:
- 7:54 AM Changeset in webkit [129978] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip media/unsupported-rtsp.html
The test seems to be consistently passing at least locally, let's
see if the bots agree.
- platform/efl/TestExpectations:
- 7:40 AM Changeset in webkit [129977] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning : -Wparentheses.
https://bugs.webkit.org/show_bug.cgi?id=97961
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-29
Reviewed by Kentaro Hara.
Explicit braces are added around the && statement to fix -Wparentheses warning.
- mathml/MathMLElement.h:
(WebCore::toMathMLElement):
- 5:51 AM Changeset in webkit [129976] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix build error : Link webkit2 library to ewk2UnitTestInjectedBundleSample.
https://bugs.webkit.org/show_bug.cgi?id=97622
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-29
Reviewed by Gyuyoung Kim.
There is no dependency between ewk2UnitTestInjectedBundleSample and
webkit2 library.
Because of this, on the first build, compiler tries to build
injected_bundle_sample.cpp before the forwarding headers are created.
This makes build error that the header file 'WebKit2/WKBaseSoup.h'
cannot be found.
To prevent this, webkit2 library is linked to ewk2UnitTestInjectedBundleSample.
- PlatformEfl.cmake:
- 3:22 AM Changeset in webkit [129975] by
-
- 6 edits2 adds in trunk
Scroll offset of flex items lost during relayout
https://bugs.webkit.org/show_bug.cgi?id=97706
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/flexbox/overflow-keep-scrollpos.html
Flex box does a second pass layout of the flex children.
We layout the child without scrollbars (to get the size
used for flexing), then we relayout the child at its final size.
We must not apply the scroll position during the first pass,
as it will be clamped to 0 (no scrolling possible).
- rendering/RenderBlock.h:
(RenderBlock):
Make updateScrollInfoAfterLayout public
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Delay applying scroll info until we clamp the size of the child
and get scrollbars back again. For this to work we use
RenderBlock::updateScrollInfoAfterLayout instead of the non-guarded
RenderLayer::updateScrollInfoAfterLayout.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
Add workaround for now to keep passing css3/flexbox/child-overflow.html
Basically do not postpone applying scroll changes for RenderBlocks
with opposite writing mode, as they need to have their content
overflow in the right direction.
LayoutTests:
Add a new test for testing that flex items scroll offsets are
not lost during relayout.
- css3/flexbox/overflow-keep-scrollpos-expected.txt: Added.
- css3/flexbox/overflow-keep-scrollpos.html: Added.
- css3/flexbox/child-overflow.html: Fix minor errors.
- 2:21 AM Changeset in webkit [129974] by
-
- 2 edits in trunk/Source/WebCore
Slightly improve clarity of the patch in bug 78595.
https://bugs.webkit.org/show_bug.cgi?id=97944
Reviewed by Andreas Kling.
Since all types of relations, except SubSelector are effectively ignoring the calculated value of pseudoId, make the code reflect that a bit more clearly.
No change in behavior, covered by test in bug 78595.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Added ignoreDynamicPseudo value that's given to all callsites that should ignore the result.
- 1:49 AM Changeset in webkit [129973] by
-
- 12 edits5 deletes in trunk/Source/WebCore
Remove LocalizedDate*.*
https://bugs.webkit.org/show_bug.cgi?id=97957
Reviewed by Kentaro Hara.
The functions declared in LocalizedDate.h are replaced with member
functions of Localizer. LocalizedDate.h and its implementations
are not needed any more.
No new tests. This should not change any behavior.
- GNUmakefile.list.am: Remove LocalizedDate.h and LocalizedDateNode.cpp
- WebCore.vcproj/WebCore.vcproj: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- CMakeLists.txt: Remove LocalizedDateNone.cpp
- Target.pri: ditto.
- WebCore.gyp/WebCore.gyp: Remove LocalizedDate*.*. Update a comment.
- WebCore.gypi: Remove LocalizedDate*.*.
- html/BaseDateAndTimeInputType.cpp: Use Localizer functions.
(WebCore::BaseDateAndTimeInputType::localizeValue):
(WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
- html/DateInputType.cpp: ditto.
(WebCore::DateInputType::fixedPlaceholder):
- platform/text/Localizer.h:
(Localizer): Move comments from LocalziedDate.h.
- platform/text/mac/LocaleMac.mm:
Remove unnecessary include of LocalizedDate.h.
- platform/text/LocalizedDate.h: Removed.
- platform/text/LocalizedDateICU.cpp: Removed.
- platform/text/LocalizedDateNone.cpp: Removed.
- platform/text/LocalizedDateWin.cpp: Removed.
- platform/text/mac/LocalizedDateMac.cpp: Removed.
Sep 28, 2012:
- 11:31 PM Changeset in webkit [129972] by
-
- 13 edits7 moves3 adds in trunk
[WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port
https://bugs.webkit.org/show_bug.cgi?id=91844
Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-09-28
Reviewed by Simon Hausmann.
.:
Turn on Netscape Plugin API by default for WebKit2-Efl.
- Source/cmake/OptionsEfl.cmake:
Source/WebKit2:
Implement windowless plugin and functions needed to launch PluginProcess.
- GNUmakefile.am: Change files and folders related to plugin process from gtk to unix.
- GNUmakefile.list.am: Change files and folders related to plugin process from gtk to unix.
- Platform/Logging.cpp: Add Plugins channel for LOG.
(WebKit):
(WebKit::getChannelFromName):
(WebKit::initializeLogChannelsIfNecessary):
- Platform/Logging.h:
(WebKit):
- PlatformEfl.cmake: Add files needed by plugin process.
- PluginProcess/unix/PluginControllerProxyUnix.cpp: Renamed from Source/WebKit2/PluginProcess/gtk/PluginControllerProxyGtk.cpp.
(WebKit):
(WebKit::PluginControllerProxy::platformInitialize): Add macros for gtk/efl differents.
(WebKit::PluginControllerProxy::platformDestroy):
(WebKit::PluginControllerProxy::platformGeometryDidChange):
- PluginProcess/unix/PluginProcessMainUnix.cpp: Renamed from Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp.
(WebKit):
(WebKit::webkitXError):
(WebKit::PluginProcessMainUnix):
- PluginProcess/unix/PluginProcessMainUnix.h: Renamed from Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.h.
(WebKit):
- PluginProcess/unix/PluginProcessUnix.cpp: Renamed from Source/WebKit2/PluginProcess/gtk/PluginProcessGtk.cpp.
(WebKit):
(WebKit::PluginProcess::platformInitialize):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp: Renamed from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.
(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
- UIProcess/efl/WebPageProxyEfl.cpp: Add stubs.
(WebKit::WebPageProxy::createPluginContainer):
(WebKit):
(WebKit::WebPageProxy::windowedPluginGeometryDidChange):
- WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp: Renamed from Source/WebKit2/WebProcess/Plugins/Netscape/gtk/PluginProxyGtk.cpp.
(WebKit):
(WebKit::PluginProxy::needsBackingStore):
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Plugin's windowless implementation.
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPaint):
- config.h:
- unix/PluginMainUnix.cpp: Renamed from Source/WebKit2/gtk/PluginMainGtk.cpp.
(main):
Tools:
Turn on Netscape Plugin API option by default.
- Scripts/webkitperl/FeatureList.pm:
- 7:50 PM Changeset in webkit [129971] by
-
- 9 edits in trunk/Source/WebCore
[V8] The concept of forceNewObject is unneeded (dom-traverse gets 3% faster)
https://bugs.webkit.org/show_bug.cgi?id=97943
Reviewed by Kentaro Hara.
We don't need the concept of forceNewObject. It doesn't do anything
useful and it makes the bindings slower.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateToV8Converters):
(NativeToJSValue):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- dom/make_names.pl:
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
- 7:30 PM Changeset in webkit [129970] by
-
- 3 edits in trunk/Source/WebCore
Allow any kind of v8::Handle in invokeCallback instead of requiring a v8::Persistent.
https://bugs.webkit.org/show_bug.cgi?id=97956
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-28
Reviewed by Adam Barth.
Use v8::Handle instead of v8::Persistent for the callback argument on invokeCallback.
There doesn't seem to be any reason for requiring a Persistent, and it makes it harder
to use this API.
This is factored out of http://wkbug.com/93661
No new tests, this is functionally equivalent.
- bindings/v8/V8Callback.cpp:
(WebCore::invokeCallback):
- bindings/v8/V8Callback.h:
(WebCore):
- 7:18 PM Changeset in webkit [129969] by
-
- 20 edits in trunk/Source
Remove support for method overloading from bridge code
https://bugs.webkit.org/show_bug.cgi?id=97959
Reviewed by Dan Bernstein.
Source/WebCore:
The method overloading handling was only in place for the (now removed) Java bridge.
Replace MethodList everywhere with a single Method pointer.
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.exp.in:
- bridge/c/c_class.cpp:
(JSC::Bindings::CClass::methodNamed):
- bridge/c/c_class.h:
(CClass):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CInstance::getMethod):
(JSC::Bindings::CInstance::invokeMethod):
- bridge/jsc/BridgeJSC.h:
(Bindings):
(Class):
- bridge/objc/objc_class.h:
(ObjcClass):
- bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodNamed):
- bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjcInstance::invokeMethod):
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::methodNamed):
- bridge/qt/qt_class.h:
(QtClass):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getMethod):
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
(JSC::RuntimeMethod::lengthGetter):
(JSC::callRuntimeMethod):
- bridge/runtime_method.h:
(JSC::RuntimeMethod::create):
(JSC::RuntimeMethod::method):
(RuntimeMethod):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
Source/WebKit/mac:
Update for WebCore changes; MethodList has been replaced with a single Method* everywhere.
- Plugins/Hosted/ProxyInstance.h:
(ProxyInstance):
- Plugins/Hosted/ProxyInstance.mm:
(ProxyClass):
(WebKit::ProxyClass::methodNamed):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyInstance::invokeMethod):
(WebKit::ProxyInstance::methodNamed):
- 7:16 PM Changeset in webkit [129968] by
-
- 3 edits in trunk/Source/WebCore
Fix compilation of V8DependentRetained and JSDependentRetained.
https://bugs.webkit.org/show_bug.cgi?id=97955
Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-28
Reviewed by Kentaro Hara.
Fix bad usage of putDirect and removeDirect from JSDependentRetained and fix
incorrect assumptions about how weak handles work in V8. This is refactored
out of the patch on http://wkbug.com/93661
No tests needed, this just fixes the compile and wrong usage of ScopedPersistent.
- bindings/js/JSDependentRetained.h:
(WebCore::JSDependentRetained::JSDependentRetained):
(WebCore::JSDependentRetained::retain):
(WebCore::JSDependentRetained::release):
(JSDependentRetained):
- bindings/v8/V8DependentRetained.h:
(WebCore::V8DependentRetained::V8DependentRetained):
(WebCore::V8DependentRetained::retain):
(WebCore::V8DependentRetained::weakCallback):
- 7:00 PM Changeset in webkit [129967] by
-
- 2 edits in trunk/Source/WebCore
Fix chromium build after http://trac.webkit.org/changeset/129964.
- WebCore.gypi:
- 6:35 PM Changeset in webkit [129966] by
-
- 3 edits in trunk/Source/WebCore
Crash re-entering Document layout with frame flattening enabled
https://bugs.webkit.org/show_bug.cgi?id=97841
Reviewed by Brady Eidson.
When creating a CachedFrame, clearTimers on the Frame later; it has to
be done after documentWillSuspendForPageCache(), because the style
changes that HTMLPlugInImageElement::documentWillSuspendForPageCache()
do can schedule a layout on the FrameView, and we don't want this layout
timer to fire while the page is in the page cache.
Add an assertion in FrameView::layout() that the document is not in
the page cache. Without the above change, this would assert in
the plugins/frameset-with-plugin-frame.html test.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 5:45 PM Changeset in webkit [129965] by
-
- 13 edits in trunk/Source/WebCore
Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637
Patch by Dan Carney <dcarney@google.com> on 2012-09-28
Reviewed by Adam Barth.
V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.
No new tests. No change in functionality.
- bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
- bindings/v8/ScopedPersistent.h:
(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::toIsolatedContextData):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearIsolatedShell):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(IsolatedContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::create):
(WebCore::V8DOMWindowShell::IsolatedContextData::world):
(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
(WebCore::V8DOMWindowShell::enteredIsolatedContext):
(WebCore::V8DOMWindowShell::enteredIsolatedContextData):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- 5:36 PM Changeset in webkit [129964] by
-
- 16 edits23 deletes in trunk/Source
Remove Java bridge
https://bugs.webkit.org/show_bug.cgi?id=97954
Reviewed by Sam Weinig.
The Java bridge is not used by any port; Mac now has a NPAPI Java plug-in.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
- bindings/js/ScriptController.h:
(ScriptController):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
- bridge/jni/JNIUtility.cpp: Removed.
- bridge/jni/JNIUtility.h: Removed.
- bridge/jni/JavaType.h: Removed.
- bridge/jni/JobjectWrapper.cpp: Removed.
- bridge/jni/JobjectWrapper.h: Removed.
- bridge/jni/jni_jsobject.h: Removed.
- bridge/jni/jni_jsobject.mm: Removed.
- bridge/jni/jni_objc.mm: Removed.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: Removed.
- bridge/jni/jsc/JNIUtilityPrivate.h: Removed.
- bridge/jni/jsc/JavaArrayJSC.cpp: Removed.
- bridge/jni/jsc/JavaArrayJSC.h: Removed.
- bridge/jni/jsc/JavaClassJSC.cpp: Removed.
- bridge/jni/jsc/JavaClassJSC.h: Removed.
- bridge/jni/jsc/JavaFieldJSC.cpp: Removed.
- bridge/jni/jsc/JavaFieldJSC.h: Removed.
- bridge/jni/jsc/JavaInstanceJSC.cpp: Removed.
- bridge/jni/jsc/JavaInstanceJSC.h: Removed.
- bridge/jni/jsc/JavaMethodJSC.cpp: Removed.
- bridge/jni/jsc/JavaMethodJSC.h: Removed.
- bridge/jni/jsc/JavaRuntimeObject.cpp: Removed.
- bridge/jni/jsc/JavaRuntimeObject.h: Removed.
- bridge/jni/jsc/JavaStringJSC.h: Removed.
- bridge/runtime_root.h:
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Make sure that we try to load the NPAPI Java plug-in.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
Source/WTF:
- wtf/Platform.h:
- 5:04 PM Changeset in webkit [129963] by
-
- 3 edits in trunk/Source/WebCore
Remove unused parameter in SelectorChecker::checkScrollbarPseudoClass.
https://bugs.webkit.org/show_bug.cgi?id=97941
Reviewed by Kentaro Hara.
The last parameter in checkScrollbarPseudoClass was unused, so I removed it.
No change in behavior, just refactoring.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Changed the callsite to accommodate the change.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Removed last param.
- css/SelectorChecker.h: Ditto.
- 4:58 PM Changeset in webkit [129962] by
-
- 6 edits1 add in trunk
REGRESSION(r122215) - CachedImage::likelyToBeUsedSoon crashes on accessing a deleted CachedImageClient
https://bugs.webkit.org/show_bug.cgi?id=97749
Reviewed by James Robinson.
.:
Added a manual test to demonstrate drag image and crashing.
- ManualTests/drag-image-no-crash.html: Added.
Source/WebCore:
All implementations of Clipboard set themselves as clients to CachedImage
through the JS API setDrageImage() but they do not detach during destruction.
This causes memory corruption when CachedImage tries to access a deleted client
when MemoryCache prunes and calls CachedImage::likelyToUsedSoon().
Manual test added: ManualTests/drag-image-no-crash.html
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::~ClipboardChromium):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::~ClipboardGtk):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::~ClipboardMac):
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::~ClipboardWin):
- 4:41 PM Changeset in webkit [129961] by
-
- 5 edits in trunk/Source/WebCore
Remove Instance::setDidExecuteFunction
https://bugs.webkit.org/show_bug.cgi?id=97952
Reviewed by Alexey Proskuryakov.
Instance::setDidExecuteFunction was added over 8 years ago to fix a bug where Objective-C
DOM calls weren't updating the document correctly. Nowadays we correctly invalidate the DOM tree
when these calls are made so we don't need an extra step to do so.
- bindings/js/ScriptControllerMac.mm:
(WebCore):
(WebCore::ScriptController::initJavaJSBindings):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject hasWebScriptKey:]):
(-[WebScriptObject stringRepresentation]):
(-[WebScriptObject webScriptValueAtIndex:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
- bridge/jsc/BridgeJSC.cpp:
- bridge/jsc/BridgeJSC.h:
(Instance):
- 4:38 PM Changeset in webkit [129960] by
-
- 2 edits in trunk/Source/WebKit/chromium
Add draggable property to WebDraggableRegion.
https://bugs.webkit.org/show_bug.cgi?id=97950
Reviewed by Adam Barth.
This needs to be done before we can land the patch to use new syntax for
draggable regions. This is because Chromium side code cannot enable
the changes to support new syntax side by side when this property is
not present.
- public/WebDraggableRegion.h:
(WebDraggableRegion):
- 4:14 PM Changeset in webkit [129959] by
-
- 5 edits in trunk/Source/WebKit2
<rdar://problem/12398537> WebKit2 lacks API for disabling document.cookie like -[WebView _setCookieEnabled:]
https://bugs.webkit.org/show_bug.cgi?id=97939
Reviewed by Sam Weinig.
- Shared/WebPreferencesStore.h:
(WebKit): Defined CookieEnabled key with a default value of true.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCookieEnabled): Added this setter.
(WKPreferencesGetCookieEnabled): Added this getter.
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Added a call to Settings::setCookieEnabled to push the
preference into Settings.
- 4:12 PM Changeset in webkit [129958] by
-
- 5 edits in trunk
Improve saturation arithmetic support in FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=97938
Reviewed by Levi Weintraub.
Source/WebCore:
Fix bug in FractionalLayoutUnit::setValue where greater than or
equals is used instead of greater than to clamp the values.
Add SATURATED_LAYOUT_ARITHMETIC support to round preventing it
from overflowing when adding the fraction.
Test: fast/sub-pixel/large-sizes.html
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::round):
(WebCore::FractionalLayoutUnit::setValue):
LayoutTests:
Update large sizes test to better cover values near limit.
- fast/sub-pixel/large-sizes-expected.txt:
- fast/sub-pixel/large-sizes.html:
- 4:08 PM Changeset in webkit [129957] by
-
- 3 edits in trunk/Source/WebKit2
Fix pluralization of Info.plist key.
Rubber-stamped by Anders Carlsson.
- WebProcessService/Info.plist:
- WebProcessServiceForWebKitDevelopment/Info.plist:
It's _MultipleInstances, not _MultipleInstance. :(
- 4:07 PM Changeset in webkit [129956] by
-
- 3 edits in trunk/Source/WebCore
TextureMapperGL destructor crashes
https://bugs.webkit.org/show_bug.cgi?id=97942
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-09-28
Reviewed by Noam Rosenthal.
BitmapTextureGL destructor uses a TextureMapperGL instance. The problem is that
BitmapTextureGL objects are destroyed on TextureMapper destructor and at that
time TextureMapperGL specific methods and data are not available any more.
This patch creates a new protected method TextureMapper::clearTexturePool()
that is called in TextureMapperGL's destructor.
- platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::clearTexturePool):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::~TextureMapperGL):
- 3:42 PM Changeset in webkit [129955] by
-
- 3 edits2 adds in trunk
REGRESSION(r124168): Null crash in RenderLayer::createScrollbar
https://bugs.webkit.org/show_bug.cgi?id=96863
Reviewed by Abhishek Arya.
Source/WebCore:
After r124168, we synchronously create any overflow:scroll scrollbar on the first style change - we used to wait
until layout was called. The issue is that the logic in RenderLayer assumes that our node is completely attached
when the style change is dispatched. The crash occured because the 'content' image code path in
RenderObject::createObject triggered a style change too early.
Test: scrollbars/scrollbar-content-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
We need a style associated with the new RenderImage to call setImageResource but we don't need to trigger a
style change.
LayoutTests:
- scrollbars/scrollbar-content-crash-expected.txt: Added.
- scrollbars/scrollbar-content-crash.html: Added.
- 3:05 PM Changeset in webkit [129954] by
-
- 2 edits in trunk/LayoutTests
WontFix frame flattening crash test.
- platform/chromium/TestExpectations:
- 2:51 PM Changeset in webkit [129953] by
-
- 2 edits in trunk/LayoutTests
perf/nested-combined-selectors.html is flaky on Lion as well.
- platform/chromium/TestExpectations:
- 2:41 PM Changeset in webkit [129952] by
-
- 1 edit2 adds in trunk/LayoutTests
Add two resources needed for the test added in r129944.
- plugins/resources/plugin-frame.html: Added.
- plugins/resources/plugin-page.html: Added.
- 2:32 PM Changeset in webkit [129951] by
-
- 2 edits in trunk/LayoutTests
Mark this test as Missing since it has no png on any platform.
- platform/chromium/TestExpectations:
- 2:23 PM Changeset in webkit [129950] by
-
- 1 edit8 adds in trunk/LayoutTests
Add canvas to set of elements that do not allow style sharing in order
to provoke RenderLayer creation
https://bugs.webkit.org/show_bug.cgi?id=97013
Unreviewed expectations update.
- platform/chromium-mac/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/chromium-mac/fast/canvas/canvas-render-layer-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Added.
- platform/chromium-win/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/chromium-win/fast/canvas/canvas-render-layer-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt: Added.
- 2:15 PM Changeset in webkit [129949] by
-
- 1 edit1 move3 adds in trunk/LayoutTests
[Chromium] Unreviewed rebaseline for svg/custom/clip-mask-negative-scale.svg
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt.
- 1:57 PM Changeset in webkit [129948] by
-
- 5 edits3 adds in trunk
ASSERTION in m_graph[tailNodeIndex].op() == Flush m_graph[tailNodeIndex].op() == SetLocal on plus.google.com https://bugs.webkit.org/show_bug.cgi?id=97656
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
There were two bugs here:
1) In case of multiple GetLocals to the same captured variable, the bytecode parser would linke the first,
rather than the last, of the GetLocals into the vars-at-tail table.
2) The constant folding phase was asserting that any GetLocal it eliminates must be linked into the
vars-at-tail table, when for captured variables only the last of those should be.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
LayoutTests:
- fast/js/dfg-redundant-load-of-captured-variable-proven-constant-expected.txt: Added.
- fast/js/dfg-redundant-load-of-captured-variable-proven-constant.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-redundant-load-of-captured-variable-proven-constant.js: Added.
(o.f):
- 1:57 PM Changeset in webkit [129947] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=97934
Reviewed by James Robinson.
After http://trac.webkit.org/changeset/129910, WebFrameImpl inherits
from FrameDestructionObserver, which means it no longer need to manage
its own weak pointer to WebCore::Frame.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::frameLoaderDestroyed):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::setWebCoreFrame):
- src/WebFrameImpl.h:
(WebKit::WebFrameImpl::frameView):
- 1:53 PM Changeset in webkit [129946] by
-
- 1 edit in branches/chromium/1229/Source/WebKit/chromium/features.gypi
Disable CSS sticky positioning. BUG=152681
- 1:51 PM Changeset in webkit [129945] by
-
- 2 edits in trunk/Source/WebCore
Chromium should respect 'text-rendering:geometricPrecision' by disabling hinting.
https://bugs.webkit.org/show_bug.cgi?id=97932
Patch by Ben Wagner <bungeman@chromium.org> on 2012-09-28
Reviewed by Stephen White.
When text-redering:geometricPrecision css property is present, the specification states that hinting should be disabled. This change does so.
This also provides users a more stable and sane means of achieving the result webkit-font-smoothing:antialiased has been providing by accident.
See http://crbug.com/152304 .
- platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
- 1:44 PM Changeset in webkit [129944] by
-
- 3 edits5 adds in trunk
Crash re-entering Document layout with frame flattening enabled
https://bugs.webkit.org/show_bug.cgi?id=97841
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Walking up to parent FrameViews when doing a frame-flattening
layout should walk via the Frame tree, not the Widget hierarchy.
Walking via the Frame tree ensures that we don't walk up to the
root Frame when laying out a subframe that is in the page cache.
That's bad, because the root Frame is reused for the new
page, and laying it out from a frame in the page cache causes
re-entrant layout.
Test: plugins/frameset-with-plugin-frame.html
- page/FrameView.cpp:
(WebCore::FrameView::parentFrameView):
LayoutTests:
Test that navigates from one frameset to another frameset, where
one of the subframes contains a plugin.
- plugins/frameset-with-plugin-frame-expected.txt: Added.
- plugins/frameset-with-plugin-frame.html: Added.
- plugins/resources/frame-with-plugin-subframe.html: Added.
- plugins/resources/target-frameset-frame.html: Added.
- plugins/resources/target-frameset.html: Added.
- 1:38 PM Changeset in webkit [129943] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFGStructureHoistingPhase SetLocal assumes StructureTransitionWatchpoint has a structure set
https://bugs.webkit.org/show_bug.cgi?id=97810
Reviewed by Mark Hahnenberg.
No tests because this can't happen in ToT: the structure check hoisting phase runs before any
CFA or folding, so the only StructureTransitionWatchpoints it will see are the ones inserted
by the parser. But the parser will only insert StructureTransitinWatchpoints on constants, which
will not be subject to SetLocals.
Still, it would be good to fix this in case things changed.
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 1:33 PM Changeset in webkit [129942] by
-
- 2 edits in trunk/Source/WebKit2
Pass the correct path length to _NSGetExecutablePath
https://bugs.webkit.org/show_bug.cgi?id=97935
Reviewed by Sam Weinig.
- WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:
(WebProcessServiceForWebKitDevelopmentEventHandler):
Initialize pathLength before passing it to _NSGetExecutablePath.
- 1:28 PM Changeset in webkit [129941] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline-expectations is broken
https://bugs.webkit.org/show_bug.cgi?id=97619
Reviewed by Ojan Vafai.
The new expectations format is causing two problems for
webkit-patch rebaseline expectations
1) the transformation into and out of the old syntax (which is
still used internally) is somewhat lossy, e.g., we're not
preserving the case of Bug(x) identifiers. Also, we can't
tell if the input was [ WontFix ] or [ Skip WontFix Pass ]
2) the new syntax is more lenient, allowing for multiple ways to
specify the same result, e.g., "[ Skip ]" may or may not be
missing.
As a result, we end up rewriting a whole bunch of lines for
purely syntactic differences.
Both of these things are bugs that need to be fixed, but
we should also not just rewrite lines that shouldn't be
modified.
This patch fixes the last issue (no rewriting).
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationLine._format_line):
(TestExpectations.remove_rebaselined_tests):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RebaseliningTest.test_remove):
- 1:24 PM Changeset in webkit [129940] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r129911.
http://trac.webkit.org/changeset/129911
https://bugs.webkit.org/show_bug.cgi?id=97933
Inspector test crashes on win debug (Requested by jsbell on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-28
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
- 1:14 PM Changeset in webkit [129939] by
-
- 2 edits in trunk/LayoutTests
Unskip fast/text/descent-clip-in-scaled-page.html
https://bugs.webkit.org/show_bug.cgi?id=91552
The test now passes on Mac.
- platform/mac/TestExpectations:
- 1:13 PM Changeset in webkit [129938] by
-
- 3 edits2 adds in trunk
Source/WebCore: [HarfBuzz] harfbuzz expects log_clusters to have same length as other buffers.
https://bugs.webkit.org/show_bug.cgi?id=97725
Reviewed by Tony Chang.
log_clusters should have same length as other buffers, which is number of glyphs.
Test: fast/text/international/harfbuzz-buffer-overrun.html
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::~ComplexTextController):
(WebCore::ComplexTextController::deleteGlyphArrays):
(WebCore::ComplexTextController::createGlyphArrays):
LayoutTests: [HarfBuzz] harfbuzz expects log_clusters to have same length as other buffers
https://bugs.webkit.org/show_bug.cgi?id=97725
Reviewed by Tony Chang.
Add a test case. A buffer overrun doesn't always cause immediate crash unless it runs with some
memory verification techs like WTF_FASTMALLOC_VALIDATION.
- fast/text/international/harfbuzz-buffer-overrun-expected.txt: Added.
- fast/text/international/harfbuzz-buffer-overrun.html: Added.
- 1:03 PM Changeset in webkit [129937] by
-
- 2 edits in trunk/Source/WebKit2
WebKitLoaderClient: add missing initializer.
https://bugs.webkit.org/show_bug.cgi?id=97930
Patch by Alberto Garcia <agarcia@igalia.com> on 2012-09-28
Reviewed by Martin Robinson.
WKPageLoaderClient is missing the initializer for the didLayout
field. Fixes -Wmissing-field-initializers.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
- 12:57 PM Changeset in webkit [129936] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Incorrect resampling of clipped/masked images.
https://bugs.webkit.org/show_bug.cgi?id=97409
Unreviewed expectations update.
Another pass may be required to get the remaining platforms.
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png: Updated and added property svn:mime-type.
- platform/chromium/TestExpectations:
- 12:50 PM Changeset in webkit [129935] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed Chromium Win build fix.
- src/WebViewImpl.cpp: Added "f" on initializers for floats.
(WebKit):
- tests/WebFrameTest.cpp: Added "f" on initializers for floats.
- 12:48 PM Changeset in webkit [129934] by
-
- 6 edits1 add in trunk
Source/WebCore: Add canvas to set of elements that do not allow style sharing in order to provoke RenderLayer creation
https://bugs.webkit.org/show_bug.cgi?id=97013
Patch by Brian Salomon <bsalomon@google.com> on 2012-09-28
Reviewed by James Robinson.
This allows RenderLayers to be created for canvas elements when they are accelerated. Otherwise, we can exit out of RenderObject::setStyle before the layer is created.
Test: fast/canvas/canvas-render-layer.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
LayoutTests: Add a test that checks whether accelerated canvases that change compositing status are given render layers.
https://bugs.webkit.org/show_bug.cgi?id=97013
Patch by Brian Salomon <bsalomon@google.com> on 2012-09-28
Reviewed by James Robinson.
The test creates four canvases. One is never rendered to, the second is rendered to immediately, and the third and fourth are rendered to using nested setTimeouts.
- fast/canvas/canvas-render-layer.html: Added.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 12:38 PM Changeset in webkit [129933] by
-
- 3 edits in trunk/Source/WebCore
[V8] Make v8NPObjectMap per Context
https://bugs.webkit.org/show_bug.cgi?id=97703
Reviewed by Adam Barth.
V8NPObject is a V8Object wrapper for use by the npruntime.
staticV8NPObjectMap is used for keeping record of V8NPObjects as they are created and destroyed
to ensure that an existing V8NPObject wrapper is returned for a V8Object in npCreateV8ScriptObject.
Once a context is gone, the NPObjects for the context are no longer valid and that record keeping
no longer makes sense so we clear the map.
However, because the map was static, it existed for all pages across contexts. Clearing the
map if one context is gone should not impact the V8NPObject map of other contexts.
Thus, this patch makes the V8NPObject map per context.
- bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):
- bindings/v8/V8PerContextData.h:
(WebCore):
(WebCore::V8PerContextData::v8NPObjectMap):
(V8PerContextData):
- 12:37 PM Changeset in webkit [129932] by
-
- 7 edits in trunk
virtual directories should just rename the beginning of the test path
https://bugs.webkit.org/show_bug.cgi?id=97925
Reviewed by Ojan Vafai.
Tools:
We were replacing all occurrences of the base prefix of a
virtual test suite with the virtual name, instead of just the
first. So, where we had softwarecompositing running the
compositing tests, any compositing test that actually had
"compositing" in the test base name would get that expanded
incorrectly.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.populated_virtual_test_suites):
(Port.lookup_virtual_test_base):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_tests):
- Scripts/webkitpy/layout_tests/port/test.py:
LayoutTests:
Delete references to tests that don't exist :).
- platform/chromium/TestExpectations:
- 12:30 PM Changeset in webkit [129931] by
-
- 2 edits in trunk/Source/WebCore
TextureMapperGL: fix -Wsign-compare compilation warning.
https://bugs.webkit.org/show_bug.cgi?id=97928
Patch by Alberto Garcia <agarcia@igalia.com> on 2012-09-28
Reviewed by Martin Robinson.
Use size_t rather than int to iterate over FilterOperations.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::applyFilters):
- 12:18 PM Changeset in webkit [129930] by
-
- 3 edits in trunk/Tools
Garden-o-matic sometimes things buildbot warnings are failures
https://bugs.webkit.org/show_bug.cgi?id=97926
Reviewed by Tony Chang.
It turns out the JSON clearly tells us if it's a failure.
We want to skip all warnings even if they don't have "warning" in the text.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- 12:03 PM Changeset in webkit [129929] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.xcodeproj/project.pbxproj:
- 11:54 AM Changeset in webkit [129928] by
-
- 5 edits2 adds in trunk/Source/WebKit/chromium
[Chromium]Add DoubleTap gesture
https://bugs.webkit.org/show_bug.cgi?id=90316
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-09-28
Reviewed by Adam Barth.
Added doubleTapGesture implementation and hooked it to an already present function computeScaleAndScrollForHitRect. Added 2 new tests and changed one based on the new implementation.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/get_multiple_divs_for_auto_zoom_test.html: Added.
- tests/data/get_scale_bounds_check_for_auto_zoom_test.html: Added.
- tests/data/get_scale_for_auto_zoom_into_div_test.html:
- 11:31 AM Changeset in webkit [129927] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] WebFrameImpl.cpp could use a style cleanup
https://bugs.webkit.org/show_bug.cgi?id=97924
Reviewed by Dimitri Glazkov.
This file is very old and contains a large number of style errors that
are confusing folks contributing new code to this file. Most of these
styles are Chromium-isms that crept in when the file was forked in the
Chromium repository.
- src/WebFrameImpl.cpp:
(WebKit):
(WebKit::frameContentAsPlainText):
(ChromePrintContext):
(WebKit::ChromePrintContext::spoolPage):
(WebKit::ChromePrintContext::spoolAllPagesWithBoundaries):
(ChromePluginPrintContext):
(WebKit::ChromePluginPrintContext::spoolPage):
(WebKit::WebFrameImpl::DeferredScopeStringMatches::DeferredScopeStringMatches):
(WebKit::WebFrameImpl::DeferredScopeStringMatches::doTimeout):
(WebKit::WebFrame::fromFrameOwnerElement):
(WebKit::WebFrameImpl::uniqueName):
(WebKit::WebFrameImpl::assignedName):
(WebKit::WebFrameImpl::setName):
(WebKit::WebFrameImpl::iconURLs):
(WebKit::WebFrameImpl::scrollOffset):
(WebKit::WebFrameImpl::minimumScrollOffset):
(WebKit::WebFrameImpl::maximumScrollOffset):
(WebKit::WebFrameImpl::contentsPreferredWidth):
(WebKit::WebFrameImpl::documentElementScrollHeight):
(WebKit::WebFrameImpl::hasHorizontalScrollbar):
(WebKit::WebFrameImpl::hasVerticalScrollbar):
(WebKit::WebFrameImpl::opener):
(WebKit::WebFrameImpl::setOpener):
(WebKit::WebFrameImpl::parent):
(WebKit::WebFrameImpl::top):
(WebKit::WebFrameImpl::firstChild):
(WebKit::WebFrameImpl::lastChild):
(WebKit::WebFrameImpl::nextSibling):
(WebKit::WebFrameImpl::previousSibling):
(WebKit::WebFrameImpl::traverseNext):
(WebKit::WebFrameImpl::traversePrevious):
(WebKit::WebFrameImpl::findChildByName):
(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::document):
(WebKit::WebFrameImpl::performance):
(WebKit::WebFrameImpl::windowObject):
(WebKit::WebFrameImpl::bindToWindowObject):
(WebKit::WebFrameImpl::executeScript):
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
(WebKit::WebFrameImpl::collectGarbage):
(WebKit::WebFrameImpl::checkIfRunInsecureContent):
(WebKit::WebFrameImpl::executeScriptAndReturnValue):
(WebKit::WebFrameImpl::callFunctionEvenIfScriptDisabled):
(WebKit::WebFrameImpl::mainWorldScriptContext):
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
(WebKit::WebFrameImpl::reload):
(WebKit::WebFrameImpl::reloadWithOverrideURL):
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::loadData):
(WebKit::WebFrameImpl::loadHTMLString):
(WebKit::WebFrameImpl::isLoading):
(WebKit::WebFrameImpl::stopLoading):
(WebKit::WebFrameImpl::provisionalDataSource):
(WebKit::WebFrameImpl::dataSource):
(WebKit::WebFrameImpl::previousHistoryItem):
(WebKit::WebFrameImpl::currentHistoryItem):
(WebKit::WebFrameImpl::enableViewSourceMode):
(WebKit::WebFrameImpl::isViewSourceModeEnabled):
(WebKit::WebFrameImpl::setReferrerForRequest):
(WebKit::WebFrameImpl::dispatchWillSendRequest):
(WebKit::WebFrameImpl::commitDocumentData):
(WebKit::WebFrameImpl::insertText):
(WebKit::WebFrameImpl::setMarkedText):
(WebKit::WebFrameImpl::firstRectForCharacterRange):
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::requestTextChecking):
(WebKit::WebFrameImpl::selectWordAroundPosition):
(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::getPrintPageShrink):
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printEnd):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
(WebKit::WebFrameImpl::pageSizeAndMarginsInPixels):
(WebKit::WebFrameImpl::pageProperty):
(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::reportFindInPageSelection):
(WebKit::WebFrameImpl::sendOrientationChangeEvent):
(WebKit::WebFrameImpl::addEventListener):
(WebKit::WebFrameImpl::removeEventListener):
(WebKit::WebFrameImpl::dispatchEvent):
(WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
(WebKit::WebFrameImpl::isActiveMatchFrameValid):
(WebKit::WebFrameImpl::deliverIntent):
(WebKit::WebFrameImpl::contentAsText):
(WebKit::WebFrameImpl::contentAsMarkup):
(WebKit::WebFrameImpl::renderTreeAsText):
(WebKit::WebFrameImpl::printPagesWithBoundaries):
(WebKit::WebFrameImpl::selectionBoundsRect):
(WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
(WebKit::WebFrameImpl::layerTreeAsText):
(WebKit::WebFrameImpl::initializeAsMainFrame):
(WebKit::WebFrameImpl::createChildFrame):
(WebKit::WebFrameImpl::createFrameView):
(WebKit::WebFrameImpl::fromFrame):
(WebKit::WebFrameImpl::fromFrameOwnerElement):
(WebKit::WebFrameImpl::viewImpl):
(WebKit::WebFrameImpl::setCanHaveScrollbars):
(WebKit::WebFrameImpl::setMarkerActive):
(WebKit::WebFrameImpl::ordinalOfFirstMatchForFrame):
(WebKit::WebFrameImpl::scopeStringMatchesSoon):
(WebKit::WebFrameImpl::callScopeStringMatches):
(WebKit::WebFrameImpl::invalidateIfNecessary):
(WebKit::WebFrameImpl::loadJavaScriptURL):
- 11:29 AM Changeset in webkit [129926] by
-
- 6 edits in branches/chromium/1271
Merge 129397 - MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
https://bugs.webkit.org/show_bug.cgi?id=97456
Reviewed by Adam Barth.
Renamed onnegotationneeded to onnegotiationneeded.
Source/WebCore:
Existing test updated.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::negotiationNeeded):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- dom/EventNames.h:
(WebCore):
LayoutTests:
- fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
- fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
TBR=tommyw@google.com
Review URL: https://codereview.chromium.org/10982093
- 11:19 AM Changeset in webkit [129925] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update the value of window.devicePixelRation when it is set programmatically
https://bugs.webkit.org/show_bug.cgi?id=97512
Reviewed by Rob Buis.
RIM PR 213984
Set the deviceScaleFactor of the page explicity when the
devicePixelRatio is changed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 11:16 AM Changeset in webkit [129924] by
-
- 17 edits in trunk/Source
Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
https://bugs.webkit.org/show_bug.cgi?id=97547
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-28
Reviewed by Adam Barth.
Source/WebCore:
Added MIMETypeRegistry::canShowMIMEType() function which should to be used
to detect whether a given MIME type can be shown in a page.
No new tests. No new functionality.
- WebCore.exp.in: Added MIMETypeRegistry::canShowMIMEType(). Removed MIMETypeRegistry functions that no longer need to be exported.
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::canShowMIMEType):
(WebCore):
- platform/MIMETypeRegistry.h:
(MIMETypeRegistry):
Source/WebKit/blackberry:
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebCore::FrameLoaderClientBlackBerry::canShowMIMEType().
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
Source/WebKit/efl:
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebCore::FrameLoaderClientEfl::canShowMIMEType().
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::canShowMIMEType):
Source/WebKit/gtk:
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebKit::FrameLoaderClient::canShowMIMEType().
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::canShowMIMEType):
Source/WebKit/qt:
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebCore::FrameLoaderClientQt::canShowMIMEType().
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMEType):
Source/WebKit/wince:
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebKit::FrameLoaderClientWinCE::canShowMIMEType().
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::canShowMIMEType):
Source/WebKit2:
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebKit::WebPageProxy::canShowMIMEType() and WKBundlePageCanShowMIMEType().
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
- 11:08 AM Changeset in webkit [129923] by
-
- 2 edits in trunk/LayoutTests
The virtual path for this test is incorrect. It appears to be
causing archiving problems on the Chromium Windows bots.
Skip it for now until the run-webkit-tests bug is fixed.
- platform/chromium/TestExpectations:
- 11:04 AM Changeset in webkit [129922] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] {Vibration,Battery,NetworkInfo}Provider should contain WKContextRef instead of proxy.
https://bugs.webkit.org/show_bug.cgi?id=97839
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
VibrationProvider has WKRetainPtr<WKVibrationRef> m_wkVibrationRef
which has reference for object WebVibrationProxy.
The WebVibrationProxy instance is a member of WebContext who has it
as RefPtr<WebVibrationProxy>.
A member of one class is shared with another class, but there is no
relation between the two classes.
This can become a problem when WebContext is deleted before the
VibrationProvider, WebVibrationProxy will be alive without WebContext,
because VibrationProvider also has the reference for WebVibrationProxy.
This is a problem because WebVibrationProxy should be a member of
WebContext.
To prevent this, I changed the VibrationProvider to have
WKRetainPtr<WKContextRef> instead of WKRetainPtr<WKVibrationRef>.
Same for BatteryProvider and NetworkInfoProvider.
- UIProcess/API/efl/BatteryProvider.cpp:
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):
- UIProcess/API/efl/BatteryProvider.h:
(BatteryProvider):
- UIProcess/API/efl/NetworkInfoProvider.cpp:
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
- UIProcess/API/efl/NetworkInfoProvider.h:
(NetworkInfoProvider):
- UIProcess/API/efl/VibrationProvider.cpp:
(VibrationProvider::create):
(VibrationProvider::VibrationProvider):
- UIProcess/API/efl/VibrationProvider.h:
(VibrationProvider):
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context::_Ewk_Context):
- 10:55 AM Changeset in webkit [129921] by
-
- 2 edits in trunk/LayoutTests
[Mac] Removing tests from TestExpectations
Expected failures now pass. Also see these tests have been unskipped on Chromium
(see bugs 84764, 84767, 84768, 84769, 84775, 84776).
- platform/mac/TestExpectations:
- 10:53 AM Changeset in webkit [129920] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Hard to tap on x to clear a text field
https://bugs.webkit.org/show_bug.cgi?id=97923
Reviewed by Antonio Gomes.
PR97923
Allow the shadow element for 'X' to be clickable and do not prefer
shadow content-editable div's over the 'X'.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 10:47 AM Changeset in webkit [129919] by
-
- 2 edits in trunk/LayoutTests
Removing tests from TestExpectations on Mac platform.
Bugs 86137 and 86139 have been fixed. Remove a couple ietestcenter tests from TestExpectations.
- platform/mac/TestExpectations:
- 10:42 AM Changeset in webkit [129918] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium expectations update
Adding more files to software compositing exclusions. The end?
- platform/chromium/TestExpectations:
- 10:33 AM Changeset in webkit [129917] by
-
- 4 edits in trunk/WebKitLibraries
Allow ports to override text track rendering style
<rdar://problem/12044964>
Reviewed by Jessie Berlin.
Update WKSI libraries.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 10:22 AM Changeset in webkit [129916] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Extend composited in-region scrolling to iframes/frames
https://bugs.webkit.org/show_bug.cgi?id=97922
PR #197093
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internaly reviewed by Arvid Nilsson.
Add support for composited scrolling in a inner frame level:
1) When creating an InRegionScrollableArea, for a inner scrollable frame,
cache and camouflag the appropriated scroll layer (i.e. RenderLayerCompositor::scrollLayer);
2) Differentiate what type of scroll target we are at: BlockElement or
InnerFrame;
3) Change the signature of the public methods to support and newly passed
in ScrollTarget parameter;
As a side note, this parameter is needed in order to know what class to static_cast
the GraphicsLayer::client to: in the case of a composited scrollable inner frame, the client
is a RenderLayerCompositor; in case of a composited scrollable block element, the client
is a RenderLayerBacking.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
- Api/InRegionScroller.h:
- Api/InRegionScroller_p.h:
(InRegionScrollerPrivate):
- WebCoreSupport/ChromeClientBlackBerry.h:
(WebCore::ChromeClientBlackBerry::allowedCompositingTriggers):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 10:16 AM Changeset in webkit [129915] by
-
- 1 edit in branches/chromium/1271/Source/WebCore/rendering/RenderText.cpp
Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763
Reviewed by Ryosuke Niwa.
r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.
This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).
- rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/10983086
- 10:14 AM Changeset in webkit [129914] by
-
- 4 edits2 adds in trunk
flexbox assert fails with auto-sized item with padding
https://bugs.webkit.org/show_bug.cgi?id=97606
Reviewed by Ojan Vafai.
Source/WebCore:
Depending on the denominator of FractionalLayoutUnit, we can lose precision when
converting to a float. This would cause a rounding error in flex-shrink to trigger an ASSERT.
To avoid this problem in the future, switch to using doubles for flex-shrink and flex-grow
at layout time. The CSS values themselves are still floats.
Test: css3/flexbox/negative-flex-rounding-assert.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems): Use doubles for local variables.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Pass in doubles.
(WebCore::RenderFlexibleBox::freezeViolations): Pass in doubles.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Pass in doubles.
- rendering/RenderFlexibleBox.h:
LayoutTests:
Add a test that hits an ASSERT when FractionalLayoutUnit denominator is 60.
- css3/flexbox/negative-flex-rounding-assert-expected.txt: Added.
- css3/flexbox/negative-flex-rounding-assert.html: Added.
- 9:51 AM Changeset in webkit [129913] by
-
- 32 edits in trunk/Source/WebCore
Unreviewed, rolling out r129751.
http://trac.webkit.org/changeset/129751
https://bugs.webkit.org/show_bug.cgi?id=97921
Causes crashes on mac and win (Requested by vsevik on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-28
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
- bindings/js/ScriptCallStackFactory.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallWith):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
- bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
- bindings/v8/ScriptCallStackFactory.h:
(WebCore):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunctionWithInstrumentation):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
(InspectorConsoleAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageRuntimeAgent.cpp:
(PageRuntimeAgentState):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore::PageRuntimeAgent::setReportExecutionContextCreation):
(WebCore::PageRuntimeAgent::didClearWindowObject):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::setReportExecutionContextCreation):
(WebCore):
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype._didLoadCachedResources):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
- 9:46 AM Changeset in webkit [129912] by
-
- 15 edits in trunk/Source
Add parseDateTime, formatDateTime, and dateFormatText to Localizer
https://bugs.webkit.org/show_bug.cgi?id=97885
Reviewed by Kentaro Hara.
Source/WebCore:
This is a preparation to remove LocalizedData.h.
Add the following pure virtual member functions to Localizer.
parseDateTime
formatDateTime
dateFormatText.
We rename existing parse/format functions for type=date in Locale*
classes, and extend their functionality so that they support other
date/time types. They override the new functions of Localizer.
No new tests. This should not change any behavior.
- platform/text/Localizer.h:
(Localizer): Add parseDateTime, formatDateTime, and dateFormatText.
- platform/text/LocaleICU.h:
(LocaleICU):
- Rename parseLocalizedDate to parseDateTime
- Add type argument to parseDateTime
- Rename formatLocalizedDate to formatDateTime
- Rename localizedDateFormatText to dateFormatText
- Make parseDateTime/formatDateTime/dateFormatText virtual.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::parseDateTime):
Renamed. Reject non-date types.
(WebCore::LocaleICU::formatDateTime): ditto.
(WebCore::LocaleICU::dateFormatText): Renamed.
- platform/text/LocalizedDateICU.cpp: Moved some code to LocaleICU.cpp.
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
- platform/text/LocaleNone.cpp:
Add empty implementations of parseDateTime, formatDateTime, and
dateFormatText.
(LocaleNone):
(WebCore::LocaleNone::parseDateTime):
(WebCore::LocaleNone::formatDateTime):
(WebCore::LocaleNone::dateFormatText):
- platform/text/LocaleWin.h:
(LocaleWin):
- Rename parseDate to parseDateTime
- Add type argument to parseDateTime
- Rename formatDate to formatDateTime
- Make parseDateTime/formatDateTime/dateFormatText virtual.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::parseDateTime):
Renamed. Reject non-date types.
(WebCore::LocaleWin::formatDateTime): ditto.
- platform/text/LocalizedDateWin.cpp: Moved some code to LocaleWin.cpp.
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
- platform/text/mac/LocaleMac.h:
(LocaleMac):
- Rename parseDate to parseDateTime
- Add type argument to parseDateTime
- Rename formatDate to formatDateTime
- Make parseDateTime/formatDateTime/dateFormatText virtual.
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::parseDateTime):
Renamed. Reject non-date types.
(WebCore::LocaleMac::formatDateTime): ditto.
- platform/text/mac/LocalizedDateMac.cpp: Moved some code to LocaleMac.mm.
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
Source/WebKit/chromium:
- tests/LocaleMacTest.cpp: Follow renaming of LocaleMac functions.
(LocaleMacTest::formatDate):
(LocaleMacTest::parseDate):
- tests/LocaleWinTest.cpp: Follow renaming of LocaleWin functions.
(LocaleWinTest::formatDate):
(LocaleWinTest::parseDate):
- 9:38 AM Changeset in webkit [129911] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Run multiple tasks per transaction tick
https://bugs.webkit.org/show_bug.cgi?id=97738
Reviewed by Tony Chang.
Process multiple tasks from the pending queue(s) when the timer fires. The
task may initiate new tasks that change which queue is active (e.g. indexing
operations) so the loop must re-check each tick which queue to use.
In DumpRenderTree, time to make 20k puts/20k gets dropped from 3.2s to 2.0s (-37%);
in Chromium's content_shell, the time dropped from 8.1s to 4.6s (-42%).
No new tests - just perf improvements, covered by (nearly) all existing IDB tests.
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort): Use takeFirst() to clean up code.
(WebCore::IDBTransactionBackendImpl::taskTimerFired): Process as many tasks as are available.
- 9:38 AM Changeset in webkit [129910] by
-
- 7 edits in trunk/Source/WebKit/chromium
[Chromium] Fix the find-in-page implementation for detaching frames.
https://bugs.webkit.org/show_bug.cgi?id=97807
Reviewed by Adam Barth.
Follow-up of 97688. Introduces proper test coverage for the find-in-page
feature in detaching/detached frame situations, fixing a few crashes and
ensuring that a final reply is always sent.
- public/WebNode.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::scopeStringMatches):
(WebKit::WebFrameImpl::flushCurrentScopingEffort):
(WebKit):
(WebKit::WebFrameImpl::finishCurrentScopingEffort):
(WebKit::WebFrameImpl::cancelPendingScopingEffort):
(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::setWebCoreFrame):
(WebKit::WebFrameImpl::initializeAsMainFrame):
(WebKit::WebFrameImpl::createChildFrame):
(WebKit::WebFrameImpl::shouldScopeMatches):
(WebKit::WebFrameImpl::willDetachPage):
- src/WebFrameImpl.h:
(WebFrameImpl):
- src/WebNode.cpp:
(WebKit::WebNode::remove):
(WebKit):
- tests/WebFrameTest.cpp:
- tests/data/find_in_page.html:
- 9:34 AM Changeset in webkit [129909] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Exiting fullscreen does not set the correct scroll position
https://bugs.webkit.org/show_bug.cgi?id=97917
PR #212920
Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Jacky Jiang.
Restore the zoom level and scroll position at the time when know
the fullscreen exit routine has ended (i.e. in ::setViewportSize
instead of ::exitFullScreenForElement).
Also patch caches now the scroll position instead of only the
"x scroll position.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- Api/WebPage_p.h:
(WebPagePrivate):
- 9:25 AM Changeset in webkit [129908] by
-
- 17 edits2 copies16 adds in trunk
Implement the GetStats interface on PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95193
Source/Platform:
Patch by Harald Tveit Alvestrand <harald@alvestrand.no> on 2012-09-28
Reviewed by Adam Barth.
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
(WebKit::WebRTCPeerConnectionHandler::getStats):
- chromium/public/WebRTCStatsRequest.h: added.
(WebCore):
(WebKit):
(WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::~WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::operator=):
Source/WebCore:
Specification:
http://dev.w3.org/2011/webrtc/editor/webrtc-20120920.html
Patch by Harald Tveit Alvestrand <harald@alvestrand.no> on 2012-09-28
Reviewed by Adam Barth.
The implementation consists of a pure virtual platform object
(RTCStatsRequest) that is implemented in WebCore, and stores
its information in a straightforward data hierarchy.
This patch adds the call path and the storage structures.
It does not add filling in data.
Test: fast/mediastream/RTCPeerConnection-stats.html
- CMakeLists.txt:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStats):
(WebCore):
- Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCStatsCallback.h: Added.
(WebCore):
(RTCStatsCallback):
(WebCore::RTCStatsCallback::~RTCStatsCallback):
- Modules/mediastream/RTCStatsCallback.idl: Added.
- Modules/mediastream/RTCStatsElement.cpp: Added.
(WebCore):
(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):
(WebCore::RTCStatsElement::stat):
- Modules/mediastream/RTCStatsElement.h: Added.
(WebCore):
(RTCStatsElement):
- Modules/mediastream/RTCStatsElement.idl: Added.
- Modules/mediastream/RTCStatsReport.cpp: Added.
(WebCore):
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):
- Modules/mediastream/RTCStatsReport.h: Added.
(WebCore):
(RTCStatsReport):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
- Modules/mediastream/RTCStatsReport.idl: Added.
- Modules/mediastream/RTCStatsRequestImpl.cpp: Added.
(WebCore):
(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::~RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::requestSucceeded):
(WebCore::RTCStatsRequestImpl::stop):
(WebCore::RTCStatsRequestImpl::clear):
- Modules/mediastream/RTCStatsRequestImpl.h: Added.
(WebCore):
(RTCStatsRequestImpl):
- Modules/mediastream/RTCStatsResponse.cpp: Added.
(WebCore):
(WebCore::RTCStatsResponse::create):
(WebCore::RTCStatsResponse::RTCStatsResponse):
- Modules/mediastream/RTCStatsResponse.h: Added.
(WebCore):
(RTCStatsResponse):
(WebCore::RTCStatsResponse::result):
- Modules/mediastream/RTCStatsResponse.idl: Added.
- WebCore.gypi:
- platform/chromium/support/WebRTCStatsRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebKit):
(WebKit::WebRTCStatsRequest::WebRTCStatsRequest):
(WebKit::WebRTCStatsRequest::assign):
(WebKit::WebRTCStatsRequest::reset):
(WebKit::WebRTCStatsRequest::requestSucceeded):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
- platform/mediastream/RTCStatsRequest.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h.
(WebCore):
(RTCStatsRequest):
(WebCore::RTCStatsRequest::~RTCStatsRequest):
(WebCore::RTCStatsRequest::RTCStatsRequest):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::getStats):
(WebCore):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Tools:
Patch by Harald Tveit Alvestrand <harald@alvestrand.no> on 2012-09-28
Reviewed by Adam Barth.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(RTCStatsRequestSucceededTask):
(RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(MockWebRTCPeerConnectionHandler::getStats):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
LayoutTests:
Patch by Harald Tveit Alvestrand <harald@alvestrand.no> on 2012-09-28
Reviewed by Adam Barth.
- fast/mediastream/RTCPeerConnection-stats-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-stats.html: Added.
- 9:15 AM WebKitGTK/1.10.x edited by
- (diff)
- 9:14 AM Changeset in webkit [129907] by
-
- 4 edits in trunk/Source/WebCore
471kB below StyleSheetContents::parserAppendRule() on Membuster3.
<http://webkit.org/b/97916>
Reviewed by Anders Carlsson.
Shrink-to-fit the StyleSheetContents rule vectors at the end of CSSParser::parseSheet().
~100kB progression on Membuster3.
- css/StyleSheetContents.h:
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::shrinkToFit):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSheet):
- 9:09 AM Changeset in webkit [129906] by
-
- 12 edits4 adds in trunk/Source/WebKit2
[WK2][GTK] Implement new Favicons API
https://bugs.webkit.org/show_bug.cgi?id=96476
Reviewed by Carlos Garcia Campos.
New object wrapping the internal IconDatabase from WebCore,
providing a simple asynchronous API to retrieve the favicon
associated to a page URL, and two more functions to simple query
the internal database for the URI of the icon associated to a
page, if any, and to clear the state of the internal database.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp: Added.
(_WebKitFaviconDatabasePrivate):
(webkit_favicon_database_init):
(webkitFaviconDatabaseFinalize):
(webkit_favicon_database_class_init):
(GetFaviconSurfaceAsyncData): New structure used to pass data
across the asynchronous implementation of get_favicon().
(GetFaviconSurfaceAsyncData::~GetFaviconSurfaceAsyncData):
Disconnects the cancellable if needed.
(getIconSurfaceSynchronously): Synchronously returns a pointer to
the cairo_surface with the icon's data, if available.
(deletePendingIconRequests): Removes the full list of
icon requests for a page URL.
(processPendingIconsForURI): Process any icon request that
might be still pending.
(iconDataReadyForPageURLCallback): Called from WebIconDatabase
when new data is ready for a favicon.
(webkitFaviconDatabaseCreate): Create the WebKitFaviconDatabase
object and initializes the API client for WKIconDatabaseClient.
(getOrCreatePendingIconRequests): Returns (if available) or
creates a new icon request, to be appended to the list of requests
for the same page URL.
(getIconSurfaceCancelled): Handle the case of a request being
cancelled. Must happen on the main thread.
(getIconSurfaceCancelledCallback): Callback used with
g_cancellable_connect(), which ensure getIconSurfaceCancelled() is
called from the main thread.
(setErrorForAsyncResult): Helper to set errors in the result.
(webkit_favicon_database_error_quark): New function, providint the
new error domain for errors of type WebKitFaviconDatabaseError.
(webkit_favicon_database_get_favicon): New API function, providing
an asynchronous mechanism to query the favicon for a page URL.
(webkit_favicon_database_get_favicon_finish): New API function to
finish the asyncrhonous request started with get_favicon().
(webkit_favicon_database_get_favicon_uri): New API function
to easily retrieve, if available, the URI of a favicon.
(webkit_favicon_database_clear): New API function to clear the
state of the internal icon database.
- UIProcess/API/gtk/WebKitFaviconDatabase.h: Added.
(_WebKitFaviconDatabase):
(_WebKitFaviconDatabaseClass):
- UIProcess/API/gtk/WebKitFaviconDatabasePrivate.h: Added to
internally expose webkitFaviconDatabaseCreate() to WebKitWebContext.
- UIProcess/API/gtk/WebKitPrivate.h: Import WebKit2/WKIconDatabase.h.
- GNUmakefile.list.am: Added new files.
Add a new getter in WebIconDatabase for m_urlImportCompleted.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::isUrlImportCompleted): Added this simple
getter to allow knowing from WebKitFaviconDatabase whether the
initial import has finished, needed for making some decisions.
(WebKit):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
New API in WebKitWebContext to allow obtaining a valid instance of
WebKitFaviconDatabase and to set/get the local path to be used.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(webkit_web_context_set_favicon_database_path): New API to allow
setting a path for the icon database, other than the default one.
(webkit_web_context_get_favicon_database_path): New API to
retrieve the path for the icon database currently in use.
(webkit_web_context_get_favicon_database): New API to get a valid
and properly initialized instance of WebKitFaviconDatabase.
- UIProcess/API/gtk/WebKitWebContext.h:
Make sure we have a default path set for the icon database.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultIconDatabasePath): Return the
default path to be used for the icon database.
Add unit tests for checking this new API.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp: Added.
(serverCallback): Callback for the test server.
(testSetDirectory): New unit test, checks the ability to set and
get a specific directory path for the icon database.
(testClearDatabase): New unit test, checks the ability to clear
the data in the icon database.
(testGetFavicon): New unit test, checks the ability to get a
favicon from the icon database in different situations.
(testGetFaviconURI): New unit test, checks the ability to retrieve
the URI for the favicon, if any, associated to a web page.
(deleteDatabaseFiles): Helper function to remove temporary files.
(beforeAll): Initialize the test server and add the unit tests.
(afterAll): Delete the test server and clean up.
- 9:04 AM Changeset in webkit [129905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium expectations update
Adding more files to software compositing exclusions. Sometimes they
do not crash but instead generater incorrect images.
- platform/chromium/TestExpectations:
- 8:56 AM Changeset in webkit [129904] by
-
- 4 edits in trunk/LayoutTests
[EFL] Update EFL baselines after r129874
https://bugs.webkit.org/show_bug.cgi?id=97914
Unreviewed EFL gardening.
Update baselines for failing tests after r129874.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-28
- platform/efl/fast/overflow/overflow_hidden-expected.txt:
- platform/efl/svg/hixie/cascade/002-expected.png:
- platform/efl/svg/hixie/cascade/002-expected.txt:
- 8:51 AM Changeset in webkit [129903] by
-
- 17 edits in trunk/Source
Clean up Localizer-related functions
https://bugs.webkit.org/show_bug.cgi?id=97899
Reviewed by Kentaro Hara.
Source/WebCore:
- Rename Document::getLocalizer to getCachedLocalizer
- Add default argument to getCachedLocalizer
- Add Element::localizer to reduce code size
- Rename DateTimeNumericFieldElement::localizer to localizerForOwner to avoid conflict with Element::localizer
- Add Localizer::createDefault to improve code readability
No new tests. This shouldn't make any behavior change.
- dom/Document.h:
(Document): Rename getLocalizer to getCachedLocalizer, and add default
argument.
- dom/Document.cpp:
(WebCore::Document::getCachedLocalizer): ditto.
- dom/Element.h:
(Element): Add localizer function.
- dom/Element.cpp:
(WebCore::Element::localizer): Added
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Rename localizer to localizerForOwner.
- html/shadow/DateTimeNumericFieldElement.cpp: ditto.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::localizerForOwner):
(WebCore::DateTimeNumericFieldElement::value):
- platform/text/Localizer.h:
(Localizer): Add createDefault
(WebCore::Localizer::createDefault): Implemented.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
Use Element::localizer.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::localizeValue): ditto.
(WebCore::NumberInputType::convertFromVisibleValue): ditto.
Source/WebKit/blackberry:
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::SelectPopupClient::localizer): ditto.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::localizer): ditto.
Source/WebKit/chromium:
- src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::ColorChooserUIController):
Use Localizer::createDefault
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl): ditto.
- 8:51 AM Changeset in webkit [129902] by
-
- 1 edit3 adds in trunk/LayoutTests
Adding regression test to ensure that cached call uninitialized arguments
correctly defaults to undefined.
https://bugs.webkit.org/show_bug.cgi?id=97836.
Reviewed by Geoffrey Garen.
- fast/js/cached-call-uninitialized-arguments-expected.txt: Added.
- fast/js/cached-call-uninitialized-arguments.html: Added.
- fast/js/script-tests/cached-call-uninitialized-arguments.js: Added.
(doForEach.callback.shouldBeUndefined):
(doForEach.callback):
(doForEach):
(callAfterRecursingForDepth):
- 8:45 AM Changeset in webkit [129901] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BLACKBERRY] Add isVisible method to WebTapHighlight
https://bugs.webkit.org/show_bug.cgi?id=97915
Patch by Genevieve Mak <gmak@rim.com> on 2012-09-28
Reviewed by Rob Buis.
Reviewed Internally By Andrew Lo
The isVisible() method lets us avoid dispatching to the webkit thread
if the tap highlight isn't visible.
Always clear tap highlight on Touch up when converting Touch Events
to Mouse Events.
- Api/WebTapHighlight.h:
- WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::isVisible):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 8:40 AM Changeset in webkit [129900] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Unreviewed test fixes after r129892.
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F): Fix a copy&paste error that changed the test
expectations.
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F): Revert the change here since it was already in the right
format before.
- 8:31 AM Changeset in webkit [129899] by
-
- 4 edits4 deletes in trunk/LayoutTests
[Qt] Gardening. Cleanup some Qt specific expectation.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-28
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/TestExpectations: Skip not supported Qt plugin test.
- platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Removed.
- platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
- platform/qt/TestExpectations: Skip failing test, ENABLE(MUTATION_OBSERVERS) is disabled.
- platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Rebase after r129844.
- platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
- platform/qt/plugins/qt-qwidget-plugin-expected.txt: Removed.
- 8:30 AM Changeset in webkit [129898] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: define ChunkedReader interface for compilation
https://bugs.webkit.org/show_bug.cgi?id=97904
Reviewed by Alexander Pavlov.
Otherwise, it is unclear what "source" is in the OutputStreamDelegate.
- inspector/front-end/FileUtils.js:
(WebInspector.OutputStreamDelegate.prototype.onTransferStarted):
(WebInspector.OutputStreamDelegate.prototype.onTransferFinished):
(WebInspector.OutputStreamDelegate.prototype.onChunkTransferred):
(WebInspector.OutputStreamDelegate.prototype.onError):
(WebInspector.ChunkedReader):
(WebInspector.ChunkedReader.prototype.fileSize):
(WebInspector.ChunkedReader.prototype.loadedSize):
(WebInspector.ChunkedReader.prototype.fileName):
(WebInspector.ChunkedReader.prototype.cancel):
(WebInspector.ChunkedFileReader.prototype.start):
(WebInspector.ChunkedFileReader.prototype._onChunkLoaded):
(WebInspector.ChunkedXHRReader.prototype.start):
(WebInspector.ChunkedXHRReader.prototype._onLoad):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotLoadFromFileDelegate.prototype.onTransferStarted):
(WebInspector.HeapSnapshotLoadFromFileDelegate.prototype.onChunkTransferred):
(WebInspector.HeapSnapshotLoadFromFileDelegate.prototype.onTransferFinished):
(WebInspector.HeapSnapshotLoadFromFileDelegate.prototype.onError):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModelLoadFromFileDelegate.prototype.onTransferStarted):
- 8:24 AM Changeset in webkit [129897] by
-
- 8 edits3 adds in trunk
[Chromium] Incorrect resampling of clipped/masked images.
https://bugs.webkit.org/show_bug.cgi?id=97409
Reviewed by Stephen White.
Source/WebCore:
Currently, high-quality resampling is used for translate/scale-only transforms, but when
the scale is negative the resampling subset ends up positioned incorrectly.
ImageSkia.cpp:drawResampledBitmap needs to account for negative scaling factors, and apply
only absolute values when calculating the resampling subregion in bitmap coordinates.
Thanks pdr@google.com for isolating the regression.
Test: svg/custom/clip-mask-negative-scale.svg
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap):
LayoutTests:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- svg/custom/clip-mask-negative-scale.svg: Added.
- 7:55 AM Changeset in webkit [129896] by
-
- 11 edits in trunk/Source
Unreviewed, rolling out r129882.
http://trac.webkit.org/changeset/129882
https://bugs.webkit.org/show_bug.cgi?id=97913
Repaint is incorrect on many tests (Requested by schenney on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-28
Source/WebCore:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
(WebCore):
(InspectorController):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::update):
(WebCore::buildObjectForPoint):
(WebCore::buildArrayForQuad):
(WebCore::buildObjectForHighlight):
(WebCore::InspectorOverlay::reset):
- inspector/InspectorOverlay.h:
(InspectorOverlay):
- inspector/InspectorOverlayPage.html:
Source/WebKit/chromium:
- src/WebDevToolsAgentImpl.cpp:
(OverlayZOrders):
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::paintPageOverlay):
(DeviceMetricsSupport):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- src/WebDevToolsAgentPrivate.h:
(WebDevToolsAgentPrivate):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
- 7:32 AM Changeset in webkit [129895] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium TestExpectation addition
Various software composituing tests are failing on Mac and Win.
- platform/chromium/TestExpectations:
- 7:18 AM DOMInJavaScript edited by
- (diff)
- 7:16 AM DOMInJavaScript edited by
- (diff)
- 7:16 AM Changeset in webkit [129894] by
-
- 12 edits2 deletes in trunk/Source
Unreviewed, rolling out r129825.
http://trac.webkit.org/changeset/129825
https://bugs.webkit.org/show_bug.cgi?id=97474
DOMWindow.resizeTo() is broken. Asked by Mark Pilgrim.
Source/Platform:
- Platform.gypi:
- chromium/public/WebScreenInfo.h: Removed.
Source/WebCore:
- WebCore.gypi:
- platform/Widget.h:
- platform/chromium/PageClientChromium.h: Removed.
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
- public/WebScreenInfo.h:
(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):
- src/PlatformSupport.cpp:
(WebCore::toWebWidgetClient):
(WebCore):
(WebCore::PlatformSupport::screenHorizontalDPI):
(WebCore::PlatformSupport::screenVerticalDPI):
(WebCore::PlatformSupport::screenDepth):
(WebCore::PlatformSupport::screenDepthPerComponent):
(WebCore::PlatformSupport::screenIsMonochrome):
(WebCore::PlatformSupport::screenRect):
(WebCore::PlatformSupport::screenAvailableRect):
- 7:12 AM Changeset in webkit [129893] by
-
- 2 edits in trunk/Source/WTF
Disable YARR_JIT for Windows 64 bit
https://bugs.webkit.org/show_bug.cgi?id=97772
Patch by Kai Koehne <kai.koehne@digia.com> on 2012-09-28
Reviewed by Simon Hausmann.
Using YARR_JIT requires ASSEMBLER, which in turn enables the
executable fixed allocator, which is mmap based (not available on
Windows).
- wtf/Platform.h:
- 7:05 AM DOMInJavaScript edited by
- (diff)
- 7:00 AM Changeset in webkit [129892] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Some expected and actual parameters in unit tests are reversed
https://bugs.webkit.org/show_bug.cgi?id=97624
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-28
Reviewed by Laszlo Gombos.
According to the gtest guide, ASSERT_XXX, EXPECT_XXX(expected, actual) are recommended
but some unit tests do not follow this.(http://code.google.com/p/googletest/wiki/Primer)
Google Test's failure messages are optimized for this convention.
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(schemeRequestCallback):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(on_download_requested):
(on_download_finished):
- UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(onIntentServiceRegistration):
(onIntentReceived):
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
(onFormAboutToBeSubmitted):
(checkBasicPopupMenuItem):
(showPopupMenu):
(showColorPicker):
- 6:57 AM Changeset in webkit [129891] by
-
- 3 edits in trunk/Tools
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414
Reviewed by Dirk Pranke.
This change how the XvfbDriver choose the next display. Before
this the choosing are based on the worker number but it caused
errors when several nrwt run on the same time. This add process
based free diplay search.
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.init):
(XvfbDriver._next_free_display):
(XvfbDriver._start):
(XvfbDriver.stop):
- Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest):
(XvfbDriverTest.test_start_next_worker):
- 6:55 AM Changeset in webkit [129890] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] QRawWebView tests are broke after r129545
https://bugs.webkit.org/show_bug.cgi?id=97907
Reviewed by Noam Rosenthal.
The issue here is that we set up the page loader client before initializing the page
so the message we send in WebPageProxy::initializeLoaderClient will be lost since the
page does not exists at the web process side yet. The trivial fix would be to reorder
initialization. In this patch I also moved to the new model of observing layout changes
via WKPageDidLayoutCallback since the old one will be deprecated at some time.
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(WebView::WebView):
(WebView::didLayout):
- 6:52 AM Changeset in webkit [129889] by
-
- 2 edits in branches/chromium/1229/Source/WebCore
LayerChromium::addAnimation should return false if there's no layer tree host
- 6:49 AM Changeset in webkit [129888] by
-
- 6 edits in trunk
[GTK] Enable CSS Shaders layout LayoutTests on GTK+
https://bugs.webkit.org/show_bug.cgi?id=97821
Patch by Huang Dongsung <luxtella@company100.net> on 2012-09-28
Reviewed by Martin Robinson.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled): Pass through to Settings object.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
This feature is disabled via Settings by default, but for testing,
we enable it using layoutTestController.overridePreferences. Add the
necessary plumbing for DRT.
WTR already works because support was added for Apple Mac earlier.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Feature is off by default.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference): Add handling of WebKitCSSCustomFilterEnabled.
- 6:47 AM Changeset in webkit [129887] by
-
- 3 edits in trunk/Tools
[Qt] Make NRWT use wk2/TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=97894
Reviewed by Simon Hausmann.
- Scripts/webkitpy/layout_tests/port/qt.py: Remove unnecessary _skipped_file_search_paths function.
(QtPort.expectations_files): Add wk2 if --webkit-test-runner option added.
- Scripts/webkitpy/layout_tests/port/qt_unittest.py: Remove unnecessary testskipped_file_search_paths function.
(QtPortTest._assert_search_path): Removed.
(QtPortTest.test_expectations_files): Add wk2 if --webkit-test-runner option added, and code cleanup.
- 6:44 AM Changeset in webkit [129886] by
-
- 9 edits in trunk
[WebDatabase] Error code should be CONSTRAINT_ERR if a statement fails due to a constraint failure
https://bugs.webkit.org/show_bug.cgi?id=97897
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Use CONSTRAINT_ERR error code instead of the generic DATABASE_ERR
when a statement fails due to a constraint failure. This is documented
in the W3C specification:
http://dev.w3.org/html5/webdatabase/#dom-sqlexception-code-constraint
Tests: storage/websql/sql-error-codes.html
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::execute):
- Modules/webdatabase/SQLStatementSync.cpp:
(WebCore::SQLStatementSync::execute):
- platform/sql/SQLiteDatabase.cpp:
(WebCore):
- platform/sql/SQLiteDatabase.h:
(WebCore):
LayoutTests:
Update storage/websql/sql-error-codes.html test case to check
that the CONSTRAINT_ERR error code is used when a statement
fails due to a constraint failure.
- platform/chromium/storage/websql/sql-error-codes-expected.txt:
- storage/websql/sql-error-codes-expected.txt:
- storage/websql/sql-error-codes.js:
(testConstraintFailure):
(runTest):
- 6:38 AM Changeset in webkit [129885] by
-
- 2 edits in trunk/Tools
[EFL][DRT] EFL's layoutTestController.keepWebHistory should enable visited links tracking
https://bugs.webkit.org/show_bug.cgi?id=97901
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
EFL's DRT testRunner.keepWebHistory should enable visited links tracking in order
to be consistent with WTR implementation and also several tests rely on that (fast/history).
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::keepWebHistory):
- 6:29 AM Changeset in webkit [129884] by
-
- 8 edits1 move1 add in trunk/Source/WebCore
Web Inspector: split ProgressBar.js into Progress.js and ProgressIndicator.js
https://bugs.webkit.org/show_bug.cgi?id=97902
Reviewed by Alexander Pavlov.
One is model, the other is UI component.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/Progress.js: Copied from Source/WebCore/inspector/front-end/ProgressBar.js.
- inspector/front-end/ProgressIndicator.js: Renamed from Source/WebCore/inspector/front-end/ProgressBar.js.
- inspector/front-end/UserAgentSupport.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- 6:20 AM Changeset in webkit [129883] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Should suspend page's scripted animations when WebPage is invisible
https://bugs.webkit.org/show_bug.cgi?id=97856
Patch by Andrew Lo <anlo@rim.com> on 2012-09-28
Reviewed by Antonio Gomes.
Suspend page animations when setting WebPage invisible, resume when visible.
Internal PR212788.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setVisible):
- 6:08 AM Changeset in webkit [129882] by
-
- 11 edits in trunk/Source
Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay
https://bugs.webkit.org/show_bug.cgi?id=97799
Reviewed by Pavel Feldman.
Source/WebCore:
In order to reduce the amount of port-specific code, the gutter overlay painted in the device metrics emulation mode
has been replaced by the respective functionality in the HTML-based InspectorOverlay in WebCore. The InspectorOverlay
now covers the entire WebView rather than the FrameView only.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::webViewResized):
(WebCore):
- inspector/InspectorController.h:
(WebCore):
(InspectorController):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::resize):
(WebCore):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawGutter):
(WebCore::InspectorOverlay::reset):
- inspector/InspectorOverlay.h:
(InspectorOverlay):
- inspector/InspectorOverlayPage.html: Introduce the gutter painting functionality previously found in the Chromium's
DeviceMetricsSupport class, which used to implement WebPageOverlay.
Source/WebKit/chromium:
- Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay.
- Remove the gutter overlay painting code.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- src/WebDevToolsAgentPrivate.h:
(WebDevToolsAgentPrivate):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
- 5:56 AM Changeset in webkit [129881] by
-
- 4 edits in trunk
editing/pasteboard/paste-removing-iframe.html crashes on EFL bots
https://bugs.webkit.org/show_bug.cgi?id=97892
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added missing null check to avoid a crash if the document inside
iframe is removed during the editing operation.
Test: editing/pasteboard/paste-removing-iframe.html
- editing/Editor.cpp:
(WebCore::Editor::changeSelectionAfterCommand):
LayoutTests:
Unskip editing/pasteboard/paste-removing-iframe.html
- platform/efl/TestExpectations:
- 5:48 AM Changeset in webkit [129880] by
-
- 2 edits1 delete in trunk/Source/WebKit/chromium
Web Inspector: [chromium] remove devtools_frontend.zip
https://bugs.webkit.org/show_bug.cgi?id=97650
Reviewed by Yury Semikhatsky.
This change removes the devtools_frontend zip generation and migrates to proper resource bundle for debug mode creation.
- WebKit.gyp:
- scripts/generate_devtools_zip.py: Removed.
- 5:37 AM Changeset in webkit [129879] by
-
- 4 edits in trunk/Source
[BlackBerry] Destroy thread-specific data for Platform::Graphics::Buffer on the right thread
https://bugs.webkit.org/show_bug.cgi?id=97674
Reviewed by Rob Buis.
A new API was added to BlackBerry::Platform::Graphics for destroying
thread-specific data generated on the compositing thread when we blit
buffers. The buffers are otherwise created and destroyed on the WebKit
thread, which doesn't give platform any opportunity to destroy the
thread-specific data.
This patch adds calls to the new API to avoid leaking resources.
Reviewed internally by Jakob Petsovits and Filip Spacek.
PR 214644
Source/WebCore:
Verified using manual testing.
- plugins/blackberry/PluginViewPrivateBlackBerry.cpp:
(WebCore::PluginViewPrivate::createBuffers):
(WebCore::PluginViewPrivate::destroyBuffers):
Source/WebKit/blackberry:
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::lockTileRenderingSurface):
(BlackBerry::WebKit::SurfacePool::releaseTileRenderingSurface):
(BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):
- 5:36 AM Changeset in webkit [129878] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium TestExpectation addition
Adding media/audio-repaint.html
- platform/chromium/TestExpectations:
- 5:09 AM Changeset in webkit [129877] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Canvas] log property setters too along with function calls
https://bugs.webkit.org/show_bug.cgi?id=97776
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-28
Reviewed by Pavel Feldman.
Trace logs should also contain property setter calls.
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/Inspector.json:
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._showTraceLog):
- 5:02 AM Changeset in webkit [129876] by
-
- 10 edits5 deletes in trunk/Source/WebCore
Remove LocalizedNumber*.*
https://bugs.webkit.org/show_bug.cgi?id=97876
Reviewed by Yuta Kitamura.
LocalizedNumber.h functions are replaced with Localizer class.
- CMakeLists.txt: Remove LocalizedNumberNone.*.
- GNUmakefile.list.am: ditto.
- Target.pri: ditto.
- WebCore.vcpproj/WebCore.vcproj: ditto.
- WebCore.gyp/WebCore.gyp: Remove LocalizedNumber*.*.
- WebCore.gypi: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- html/NumberInputType.cpp: Use Localizer for the element locale.
(WebCore::NumberInputType::localizeValue):
(WebCore::NumberInputType::convertFromVisibleValue):
- platform/text/Localizer.h: Move some comments from LocalizedNumber.h
- platform/text/LocalizedNumber.h: Removed.
- platform/text/LocalizedNumberICU.cpp: Removed.
- platform/text/LocalizedNumberNone.cpp: Removed.
- platform/text/mac/LocalizedNumberMac.mm: Removed.
- platform/text/win/LocalizedNumberWin.cpp: Removed.
- 4:21 AM Changeset in webkit [129875] by
-
- 12 edits1 delete in trunk/Source
Web Inspector: make HashSet memory instrumentation non-intrusive
https://bugs.webkit.org/show_bug.cgi?id=97879
Reviewed by Vsevolod Vlasov.
Source/WebKit/chromium:
Update the test for HashSet memory instrumentation. We don't add
HashSet's private objects into the set of visited objects any more
and should update the expectation accordingly.
- tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
Source/WTF:
Removed reportMemoryUsage declarations as a friend of HashSet and HashTable. Also
removed MemoryInstrumentationHashTable which is not needed if we don't have
access to HashSet's guts.
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/HashSet.h:
(WTF):
(HashSet):
- wtf/HashTable.h:
(HashTable):
- wtf/MemoryInstrumentation.h:
(WTF::MemoryClassInfo::addPrivateBuffer):
- wtf/MemoryInstrumentationHashSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashTable.h: Removed.
- 4:15 AM Changeset in webkit [129874] by
-
- 9 edits in trunk
[EFL][DRT] EFL DRT should disable visited links tracking by default
https://bugs.webkit.org/show_bug.cgi?id=97881
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit/efl:
Added aux DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks() function.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Visited links tracking is disabled by default for each test.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
LayoutTests:
Rebased fast/block/float/float-in-float-hit-testing.html and unskipped it for EFL WK2.
- platform/efl-wk2/TestExpectations:
- platform/efl/fast/block/float/float-in-float-hit-testing-expected.png:
- platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt:
- 3:59 AM Changeset in webkit [129873] by
-
- 2 edits in trunk/Source/Platform
[Forms] Add localized strings for multiple fields date/time input UI
https://bugs.webkit.org/show_bug.cgi?id=97878
Reviewed by Kent Tamura.
This patch introduces following localized string identifier for
month, time and week pickers:
- OtherMonthLabel - appeared at the last entry in suggestion list.
- OtherTimeLabel - ditto
- OtherWeekLabel - ditto
- ThisMonthButtonLabel - used in month picker
- ThisWeekButtonLabel - used in week picker
- chromium/public/WebLocalizedString.h: Added OtherMonthLabel, OtherTimeLabel, OtherWeekLabel, ThiMonthkButtonLabel, and ThisWeekButtonLabel.
- 3:49 AM Changeset in webkit [129872] by
-
- 13 edits1 add1 delete in trunk
Unreviewed, rolling out r129863.
http://trac.webkit.org/changeset/129863
https://bugs.webkit.org/show_bug.cgi?id=97173
Source/WebCore:
WK2 layout test on debug is broken by this patch.
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
Source/WebKit2:
Broken debug WK2 layout test
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):
- UIProcess/API/efl/ewk_main.h: Added.
- UIProcess/API/efl/ewk_main_private.h: Removed.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
(EWK2UnitTest::EWK2UnitTestBase::TearDown):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
Tools:
Broken debug WK2 layout test
- MiniBrowser/efl/main.c:
(quit):
(main):
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::initEcoreEvas):
(WTR::PlatformWebView::~PlatformWebView):
- WebKitTestRunner/efl/main.cpp:
(main):
- 3:39 AM Changeset in webkit [129871] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] exceededDatabaseQuota event is not handled
https://bugs.webkit.org/show_bug.cgi?id=97882
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Handle exceededDatabaseQuota callback from WKPageUIClient so
that we let the browser a chance to decide what to do when
the database quota is reached. If the browser does not handle
this, then we return a realistic default quota (5MB as
recommended by the spec).
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_database_quota_exceeded):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/ewk_view_ui_client.cpp:
(exceededDatabaseQuota):
(ewk_view_ui_client_attach):
- 3:35 AM Changeset in webkit [129870] by
-
- 7 edits in trunk
Source/WebKit2: [Qt] Use qInstallMessageHandler()
https://bugs.webkit.org/show_bug.cgi?id=96648
Patch by Kai Koehne <kai.koehne@digia.com> on 2012-09-28
Reviewed by Jocelyn Turcotte.
qInstallMsgHandler() got deprecated in Qt 5.
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::messageHandler):
(WebKit::PluginProcessMain):
- UIProcess/API/qt/tests/util.cpp:
(messageHandler):
(suppressDebugOutput):
- qt/MainQt.cpp:
(messageHandler):
(main):
Tools: [Qt] Use qInstallMessageHandler()
https://bugs.webkit.org/show_bug.cgi?id=96648
Patch by Kai Koehne <kai.koehne@digia.com> on 2012-09-28
Reviewed by Jocelyn Turcotte.
qInstallMsgHandler() got deprecated in Qt 5.
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(messageHandler):
(main):
- WebKitTestRunner/qt/main.cpp:
(messageHandler):
(main):
- 3:24 AM Changeset in webkit [129869] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Formatting on load is broken
https://bugs.webkit.org/show_bug.cgi?id=97880
Reviewed by Alexander Pavlov.
Bound formatted callback on UISourceCode and fixed callback call.
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._fireContentAvailable.formattedCallback):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
- 3:17 AM Changeset in webkit [129868] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing failure expectations for two perftests' harness tests, the
regression was swiftly fixed in r129858.
- platform/gtk/TestExpectations:
- 2:40 AM Changeset in webkit [129867] by
-
- 7 edits3 adds in trunk
[Forms] Multiple fields month input UI
https://bugs.webkit.org/show_bug.cgi?id=97299
Reviewed by Kent Tamura.
Source/WebCore:
This patch introduces multiple fields "month" input UI in DRT. We'll
enable this feature once we add tests.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_MONTH
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
No new tests. To reduce size of this patch, other patches add tests
for multiple fields month input UI.
Note: Actual outputs of two tests
- fast/forms/month/month-input-visible-string.html
- fast/forms/month/month-stepup-stepdown-from-renderer.html
are different.
- css/html.css:
(input::-webkit-datetime-edit-month-field): Added for field appearance.
(input::-webkit-datetime-edit-year-field): ditto.
(input::-webkit-datetime-edit-month-field:focus): Added to remove focus ring.
(input::-webkit-datetime-edit-year-field:focus): ditto.
- html/MonthInputType.cpp:
(WebCore::MonthInputType::formatDateTimeFieldsState): Added to format numeric value to string value as specified in HTML5 specification.
(WebCore::MonthInputType::setupLayoutParameters): Added to set layout of multiple fields.
- html/MonthInputType.h: Changed to include BaseMultipleFieldsDateAndTimeInputType.h and introduce BaseMonthInputType typedef.
(WebCore::MonthInputType::MonthInputType): Changed base class name to BaseMonthInputType.
(MonthInputType): Changed to add declarations for formatDateTimeFieldsState() and setupLayoutParameters().
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Changed to have copy of object in m_stepRange and m_dateValue member variables for being robust.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed to add initialize m_placeholderForMonth and m_placeholderForYear.
(WebCore::DateTimeEditBuilder::visitField): Changed to support month field and year field.
- html/shadow/DateTimeEditElement.h:
(LayoutParameters): Changed to add member variables, placeholderForMonth and placeholderForYear. Changed to have copy of object in stepRange member variable for being robust.
LayoutTests:
This patch adds Chromium port specific expectations for "month" input
type tests for multiple fields month input UI.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_MONTH
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
- platform/chromium/fast/forms/month/month-input-visible-string-expected.txt: Added. Multiple fields month input UI doesn't have selection.
- platform/chromium/fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Added. On multiple fields month input UI, step down/up decrement/increment a field rather than whole value.
- 2:40 AM Changeset in webkit [129866] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Clear provider on destructor of {Vibration,Battery,NetworkInfo}Provider.
https://bugs.webkit.org/show_bug.cgi?id=97528
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Constructor of {Vibration,Battery,NetworkInfo}Provider set provider
but the destructor of the classes doesn't clear provider.
This can make a problem about accessing dangling pointer.
For preventing this problem, clear provider on destructor.
- UIProcess/API/efl/BatteryProvider.cpp:
(BatteryProvider::~BatteryProvider):
- UIProcess/API/efl/NetworkInfoProvider.cpp:
(NetworkInfoProvider::~NetworkInfoProvider):
- UIProcess/API/efl/VibrationProvider.cpp:
(VibrationProvider::~VibrationProvider):
- 2:26 AM Changeset in webkit [129865] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix.
- inspector/debugger/ui-source-code-display-name.html:
- 2:24 AM Changeset in webkit [129864] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] NetworkInfo provider is not initialized in Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=97865
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-28
Reviewed by Kenneth Rohde Christiansen.
Initialize NetworkInfo provider for EFL port in Ewk_Context
with the other providers.
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
- 1:56 AM Changeset in webkit [129863] by
-
- 13 edits1 add1 delete in trunk
[EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=97173
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-28
Reviewed by Gyuyoung Kim.
Source/WebCore:
Remove codes to initialize and shutdown the EFL libraries from
RunLoopEfl.cpp. Initialization and shutdown will be done in the
ewk_main.cpp for ui process and WebProcessMainEfl.cpp for web
process.
No new tests. This patch doesn't change behavior.
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
Source/WebKit2:
Initialize and shutdown the EFL libraries in the ewk_main.cpp for ui
process and WebProcessMainEfl.cpp for web process.
Additionally, initialization and shutdown are done when ewk_context is
created and deleted, so ewk_{init,shutdown} APIs are changed to
internal function and applications don't have to call them.
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):
- UIProcess/API/efl/ewk_main.h: Removed.
- UIProcess/API/efl/ewk_main_private.h: Added.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
(EWK2UnitTest::EWK2UnitTestBase::TearDown):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
Tools:
The initialization and shutdown are done inside the webkit, so we don't
have to call them out of the webkit.
- MiniBrowser/efl/main.c:
(quit):
(main):
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::initEcoreEvas):
(WTR::PlatformWebView::~PlatformWebView):
- WebKitTestRunner/efl/main.cpp:
(main):
- 1:44 AM Changeset in webkit [129862] by
-
- 14 edits in trunk
Web Inspector: Prepare UISourceCode to transformation into File.
https://bugs.webkit.org/show_bug.cgi?id=97113
Reviewed by Pavel Feldman.
Source/WebCore:
This patch moves methods and fields from UISourceCode descendants except for the modification bindings.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.breakpointStorageId):
(WebInspector.BreakpointManager.isDivergedFromVM):
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.Breakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._restoreBreakpoints):
(set WebInspector.BreakpointManager.Storage.Item):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointsBeforeEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
- inspector/front-end/SASSSourceMapping.js:
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.evaluateScriptSnippet.get var):
(WebInspector.ScriptSnippetModel.prototype._projectWillReset):
(WebInspector.SnippetJavaScriptSource):
(WebInspector.SnippetJavaScriptSource.prototype.workingCopyChanged):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeFormatted):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
- inspector/front-end/StyleSource.js:
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.searchInContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable.formattedCallback):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.setSourceMapping):
LayoutTests:
- http/tests/inspector/workspace-test.js:
- inspector/debugger/dynamic-script-tag-expected.txt:
- inspector/debugger/network-uisourcecode-provider-expected.txt:
- inspector/debugger/resource-script-mapping-expected.txt:
- inspector/debugger/script-snippet-model.html:
- 1:41 AM Changeset in webkit [129861] by
-
- 5 edits in trunk/Source/WebCore
Move Shadow DOM inspection feature out from experiments
https://bugs.webkit.org/show_bug.cgi?id=94274
Reviewed by Pavel Feldman.
This chagne turns the showShadowDOM experiments into a settings,
adding aSettingsScreen entry for that.
- English.lproj/localizedStrings.js:
- inspector/front-end/DOMAgent.js:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- 1:29 AM Changeset in webkit [129860] by
-
- 15 edits in trunk/Source
Use Localizer in PagePopupController
https://bugs.webkit.org/show_bug.cgi?id=97862
Reviewed by Hajime Morita.
Source/WebCore:
No new tests. This doesn't change any behavior.
- page/PagePopupClient.h:
(WebCore):
(PagePopupClient): Add "localizer" member function.
- page/PagePopupController.cpp:
(WebCore::PagePopupController::localizeNumberString):
Use a Localizer object provided by PagePopupClient.
Source/WebKit/blackberry:
We need to implement PagePopupClient::localizer. These clients know the
host elements. Localizer implementations get Localizer objects from the
owner documents of the elements for the browser locale.
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::localizer): Added.
- WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient): Declare "localizer."
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::SelectPopupClient::localizer): Added.
- WebCoreSupport/DatePickerClient.h:
(DatePickerClient): Declare "localizer."
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::localizer): Added.
- WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient): Declare "localizer."
Source/WebKit/chromium:
We need to implement PagePopupClient::localizer. The current
implementations of localizer functions always return Localizer objects
for the browser locale. It's ok because other locale-dependent stuff in
PagePopup uses the browser locale, not element locale. We might want to
update this behavior later for testing i18n behavior in PagePopup.
- src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::ColorChooserUIController):
Initialize m_localizer with the browser default locale.
(WebKit::ColorChooserUIController::localizer):
Returns m_localizer.
- src/ColorChooserUIController.h:
(ColorChooserUIController): Declare localizer function and m_localizer.
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
Initialize m_localizer with the browser default locale.
(WebKit::DateTimeChooserImpl::localizer):
Returns m_localizer.
- src/DateTimeChooserImpl.h:
(DateTimeChooserImpl): Declare localizer function and m_localizer.
- 1:09 AM Changeset in webkit [129859] by
-
- 12 edits in trunk/Source
Switch monthLabels, weekDayShortLabels, and firstDayOfWeek to Localizer
https://bugs.webkit.org/show_bug.cgi?id=97874
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. This change shouldn't change any behavior.
- platform/text/Localizer.h:
(Localizer): Add monthLabels, weekDayShortLabels, and firstDayOfWeek.
- platform/text/LocalizedDate.h:
(WebCore): Remove them.
- platform/text/LocalizedDateICU.cpp:
(WebCore::localizedDateFormatText): ditto.
- platform/text/LocalizedDateWin.cpp:
(WebCore::localizedDateFormatText): ditto.
- platform/text/mac/LocalizedDateMac.cpp:
(WebCore::localizedDateFormatText): ditto.
- platform/text/LocaleICU.h:
(LocaleICU): Add virtual and OVERRIDE.
- platform/text/LocaleWin.h:
(LocaleWin):
- Add virtual and OVERRIDE.
- Move the content of firstDayOfWeek to LocaleWin.cpp because inline
definition of a virtual function is not efficient.
- platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::firstDayOfWeek): See above.
- platform/text/mac/LocaleMac.h:
(LocaleMac): Add virtual and OVERRIDE.
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
Use Localizer for the browser locale.
- 12:36 AM Changeset in webkit [129858] by
-
- 2 edits in trunk/PerformanceTests
Add back test.runCount for runPerSecond as it's used by tests in fast/harness/perftests.
- resources/runner.js:
(PerfTestRunner.runPerSecond):
- 12:12 AM Changeset in webkit [129857] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a pass expectation for a subpixel test.
Removing two failure expectations for middle-click-related tests that
started passing after r129750.
Removing failure expectation for a Shadow DOM test that started passing
after experimental CSS features have been enabled in r129604.
Removing failure expectation for http/tests/security/xss-eval.html after
the fix was relanded in r129712.
Adding failure expectations for two perftests harness tests that started
failing after r129824.
- platform/gtk/TestExpectations:
- 12:05 AM Changeset in webkit [129856] by
-
- 5 edits in trunk
Web Inspector: Elements: Show entities in edit as HTML.
https://bugs.webkit.org/show_bug.cgi?id=97798
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-09-28
Reviewed by Alexander Pavlov.
Source/WebCore:
In elements tree entities like " ", " " are shown.
But in "Edit as HTML" mode they are replaced by Unicode chars.
For better consistency, these chars should be rendered the same
way both in tree and edit field.
- inspector/front-end/ElementsTreeOutline.js:
Replaced invisible chars with entities.
LayoutTests:
Added test case for invisible chars in "Edit as HTML" mode.
- inspector/elements/edit-dom-actions-expected.txt:
- inspector/elements/edit-dom-actions.html:
- 12:03 AM Changeset in webkit [129855] by
-
- 5 edits in trunk/Source/WebCore
[Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement
https://bugs.webkit.org/show_bug.cgi?id=97864
Reviewed by Kent Tamura.
This patch is a part of preparation of implementing multiple fields
date/time input UI.
This patch introduces DateTimeMonthFieldElement and DateTimeYearFieldElement
classes for implementing multiple fields "month" input type.
Multiple fields "month" input type uses two fields for month and year
in locale dependent order. Month field display month as two digit.
Year field display year as four digits in usual case and can display
up to 6 digits to support maximum year 275760, defined in HTML5
specification.
This patch also changes default value for step down and up on empty
field to better UI in year field. Year field displays current year
when step down and up on empty field rather than minimum year 1, or
maximum year 275760.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME
and ENABLE_INPUT_MULTIPLE_FIELDS_UI.
No new tests. This patch doesn't change behavior.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement): Added.
(WebCore::DateTimeMonthFieldElement::create): Added.
(WebCore::DateTimeMonthFieldElement::populateDateTimeFieldsState): Added.
(WebCore::DateTimeMonthFieldElement::setValueAsDate): Added.
(WebCore::DateTimeMonthFieldElement::setValueAsDateTimeFieldsState): Added.
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement): Added.
(WebCore::DateTimeYearFieldElement::create): Added.
(WebCore::DateTimeYearFieldElement::defaultValueForStepDown): Added.
(WebCore::DateTimeYearFieldElement::defaultValueForStepUp): Added.
(WebCore::DateTimeYearFieldElement::populateDateTimeFieldsState): Added.
(WebCore::DateTimeYearFieldElement::setValueAsDate): Added.
(WebCore::DateTimeYearFieldElement::setValueAsDateTimeFieldsState): Added.
- html/shadow/DateTimeFieldElements.h:
(DateTimeMonthFieldElement): Added.
(DateTimeYearFieldElement): Added.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::Range::isInRange): Added for ease of checking value is in range.
(WebCore::DateTimeNumericFieldElement::defaultValueForStepDown): Added for default behavior.
(WebCore::DateTimeNumericFieldElement::defaultValueForStepUp): ditto.
(WebCore::DateTimeNumericFieldElement::stepDown): Changed to use defaultValueForStepDown instead of maximum field value.
(WebCore::DateTimeNumericFieldElement::stepUp): Changed to use defaultValueForStepUp minium field value.
(WebCore::DateTimeNumericFieldElement::value): Changed to use "%04d" when maximum field value is greater than 999 for year field.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Changed to add declarations of defaultValueForStepDown() and defaultValueForStepUp().
Sep 27, 2012:
- 11:18 PM Changeset in webkit [129854] by
-
- 4 edits in trunk/Source/WebCore
[Forms] Adding placeholder feature to DateTimeNumericElement, and update its existing subclasses.
https://bugs.webkit.org/show_bug.cgi?id=97863
Reviewed by Kent Tamura.
This patch is a part of preparation of implementing multiple fields
date/time input UI.
This patch introduces placeholder feature to DateTimeNumericElement
to display date format guide in field, e.g. displaying "dd/mm/yyyy".
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.
No new tests. This patch doesn't change behavior.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeHourFieldElement::DateTimeHourFieldElement): Changed to pass placeholder class to base class.
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): ditto
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement): ditto
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement): ditto
- html/shadow/DateTimeNumericFieldElement.cpp: Removed no more needed static function displaySizeOfNumbre().
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): Changed to add new parameter to take placeholder.
(WebCore::DateTimeNumericFieldElement::visibleValue): Changed to use m_placholder.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Changed to add a member variable m_placholder to hold placholder to DateTimeNumbericElement class.
- 11:10 PM Changeset in webkit [129853] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Empty URL gets through to acceptNavigationRequest()
https://bugs.webkit.org/show_bug.cgi?id=97076
Reviewed by George Staikos.
Invalid URLs in iframe src results in an empty URL in platform request, we should reject
such URL as early as we identify it.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
- 10:21 PM Changeset in webkit [129852] by
-
- 2 edits in trunk/Source/WebCore
Make sure Localizer class is not copyable
https://bugs.webkit.org/show_bug.cgi?id=97857
Reviewed by Kentaro Hara.
We don't intent Localizer obejcts are copyable.
- platform/text/Localizer.h:
(Localizer): Add WTF_MAKE_NONCOPYABLE.
- 10:15 PM Changeset in webkit [129851] by
-
- 5 edits in trunk/Source/WebCore
Delete some unused code. Found by -Wunused-function.
https://bugs.webkit.org/show_bug.cgi?id=97858
Reviewed by Anders Carlsson.
No intended behavior change.
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
- platform/graphics/chromium/CrossProcessFontLoading.mm:
- platform/graphics/skia/GraphicsContextSkia.cpp:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore):
- 10:03 PM Changeset in webkit [129850] by
-
- 23 edits in trunk/Source/WebKit/chromium
[Chromium] Update WebVector.h references
https://bugs.webkit.org/show_bug.cgi?id=97855
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/ApplicationCacheHost.cpp:
- src/AudioDestinationChromium.h:
- src/AutofillPopupMenuClient.cpp:
- src/CompositionUnderlineBuilder.h:
- src/CompositionUnderlineVectorBuilder.h:
- src/ContextMenuClientImpl.cpp:
- src/ExternalPopupMenu.cpp:
- src/FrameLoaderClientImpl.cpp:
- src/PlatformSupport.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebDragData.cpp:
- src/WebFileChooserCompletionImpl.h:
- src/WebFileSystemCallbacksImpl.h:
- src/WebFrameImpl.cpp:
- src/WebHistoryItem.cpp:
- src/WebIDBKeyPath.cpp:
- src/WebIDBMetadata.cpp:
- src/WebNode.cpp:
- src/WebPageSerializer.cpp:
- src/WebPageSerializerImpl.cpp:
- src/WebTextCheckingCompletionImpl.cpp:
- src/WorkerFileSystemCallbacksBridge.h:
- 9:27 PM Changeset in webkit [129849] by
-
- 2 edits in trunk/Source/WebCore
[V8] StringCache::v8ExternalString() can return a stale persistent handle
https://bugs.webkit.org/show_bug.cgi?id=97767
Reviewed by Adam Barth.
For details, see the Chromium bug: http://code.google.com/p/chromium/issues/detail?id=151902
StringCache::v8ExternalString() can return a stale persistent handle
in the following scenario:
(1) Assume that StringImpl A with value "foo" is in m_stringCache.
(2) StringImpl B with value "foo" is accessed. At this point, m_lastStringImpl
points to B, and m_lastV8String points to B's handle.
(3) A minor GC is triggered and a weak callback is called back for StringImpl A.
At this point, "foo" is removed from m_stringCache. A's handle is disposed.
However, m_lastV8String is not cleared because m_lastStringImpl (i.e. StringImpl B)
is not equal to StringImpl A. As a result, m_lastV8String points to a stale
persistent handle.
(4) The persistent handle is eventually reused in V8 and made weak again.
(5) StringImpl B with value "foo" is accessed. Then StringCache::v8ExternalString()
returns the stale persistent handle, which is already used for another purpose.
To solve the problem, we need to clear m_stringImpl and m_lastV8String when any
string wrapper is disposed. Specifically, we need to change the code like this:
static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
{
StringImpl* stringImpl = static_cast<StringImpl*>(parameter);
V8PerIsolateData::current()->stringCache()->remove(stringImpl);
wrapper.Dispose();
stringImpl->deref();
}
void StringCache::remove(StringImpl* stringImpl)
{
m_stringCache.remove(stringImpl);
if (m_lastStringImpl.get() == stringImpl) { Remove this line.
m_lastStringImpl = 0;
m_lastV8String.Clear();
}
}
Note: Removing the line might be stronger than is needed. Instead of removing
the line, we can just replace the line with 'if (m_lastV8String == wrapper)'.
However, just in case (for correctness), I'd prefer removing the line.
Given that GC won't happen so frequently, clearing the cache in every weak callback
won't affect performance.
No tests because it depends on the GC behavior and I couldn't reproduce the bug.
- bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::remove):
- 9:18 PM Changeset in webkit [129848] by
-
- 2 edits in trunk/PerformanceTests
Build fix after r129824.
- DOM/resources/dom-perf.js:
(runBenchmarkSuite):
- 9:16 PM Changeset in webkit [129847] by
-
- 2 edits in trunk/PerformanceTests
Remove unused features and reduce code duplications in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=97852
Reviewed by Kentaro Hara.
Made the following refactoring changes:
- Remove PerfTestRunner.info since it's never used.
- Moved the js heap/malloc related functions up to where they belong.
- Moved the initialization of _callsPerIteration, _test, and -description into _start, and stopped initializing _runFunction and _doneFunction since both test times now use _test object.
- Made _measureTimeOnce and _measureRunsPerSecondOnce return the measured value instead of calling ignoreWarmUpAndLog and _runLoop to share the code; they're now called in _measureRunsPerSecondOnce.
- resources/runner.js:
(PerfTestRunner.storeHeapResults): Moved.
(PerfTestRunner.getUsedMallocHeap): Moved.
(PerfTestRunner.getUsedJSHeap): Moved.
(PerfTestRunner.getAndPrintMemoryStatistics): Moved.
(PerfTestRunner._scheduleNextMeasurementOrNotifyDone): Renamed from _runLoop. Calls
ignoreWarmUpAndLog and schedules the next call.
(PerfTestRunner._measureTimeOnce): Renamed from _runner.
(PerfTestRunner._start): Renamed from initAndStartLoop.
(PerfTestRunner.measureTime):
(PerfTestRunner.runPerSecond):
(PerfTestRunner._measureRunsPerSecondOnce): Renamed from _measureRunsPerSecondOnce.
(PerfTestRunner._perSecondRunnerIterator):
- 9:04 PM Changeset in webkit [129846] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Update comment in WebFrameClient to point to new userAgent() function
https://bugs.webkit.org/show_bug.cgi?id=97854
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
- public/WebFrameClient.h:
(WebFrameClient):
- 8:57 PM Changeset in webkit [129845] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Remove unused PlatformSupport reference in ChromeClientImpl
https://bugs.webkit.org/show_bug.cgi?id=97853
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/ChromeClientImpl.cpp:
- 8:51 PM Changeset in webkit [129844] by
-
- 6 edits in trunk/Source/WebCore
CSSComputedStyleDeclaration::getPropertyCSSValue() triggering unnecessary relayouts and style recalcs
https://bugs.webkit.org/show_bug.cgi?id=97760
Reviewed by Andreas Kling.
Currently getPropertyCSSValue() (which is also used to implement the more common getPropertyValue())
calls Document::updateLayoutIgnorePendingStylesheets() unconditionally. However only a few properties
are actually layout dependent, making many of these relayouts unnecessary. Moreover, triggering full
style recalc is also often unnecessary as the current node may already have valid style even if some
other parts of the tree require recalc.
- Only trigger relayouts for layout dependent properties.
- Trigger style recalc only if the style of the current element or its ancestors is dirty.
This is a significant (several percent) progression on some real world web content based page loading
benchmarks.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::isLayoutDependentProperty):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/StyleResolver.h:
(WebCore::StyleResolver::hasViewportDependentMediaQueries):
- dom/Document.cpp:
(WebCore::Document::hasPendingStyleRecalc):
Renamed for consistency.
(WebCore::Document::hasPendingForcedStyleRecalc):
(WebCore):
- dom/Document.h:
(Document):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- 8:41 PM Changeset in webkit [129843] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove unused PlatformSupport reference in DraggedIsolatedFileSystem
https://bugs.webkit.org/show_bug.cgi?id=97851
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
- 8:15 PM Changeset in webkit [129842] by
-
- 2 edits in trunk/Source/WebCore
requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
https://bugs.webkit.org/show_bug.cgi?id=95360
Patch by Andrew Lo <anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.
Remove unnecessary code introduced in http://trac.webkit.org/changeset/129808.
No new tests because it's already covered by fast/animation/request-animation-frame-iframe2.html.
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
- 8:14 PM Changeset in webkit [129841] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Clean up includes in DateTimeChooserImpl
https://bugs.webkit.org/show_bug.cgi?id=97847
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/DateTimeChooserImpl.cpp:
- 8:05 PM Changeset in webkit [129840] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove unused PlatformSupport reference in FontCacheSkia
https://bugs.webkit.org/show_bug.cgi?id=97850
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- platform/graphics/skia/FontCacheSkia.cpp:
- 8:03 PM Changeset in webkit [129839] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Clean up includes in ColorChooserUIController
https://bugs.webkit.org/show_bug.cgi?id=97849
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/ColorChooserUIController.cpp:
- 8:01 PM Changeset in webkit [129838] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Clean up includes in PaintAggregator
https://bugs.webkit.org/show_bug.cgi?id=97848
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/painting/PaintAggregator.cpp:
- 7:59 PM Changeset in webkit [129837] by
-
- 2 edits in trunk/Source/WebCore
[Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid
https://bugs.webkit.org/show_bug.cgi?id=97846
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
- 7:57 PM Changeset in webkit [129836] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Clean up includes in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=97843
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/SocketStreamHandle.cpp:
- 7:55 PM Changeset in webkit [129835] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Clean up includes in AudioDestinationChromium
https://bugs.webkit.org/show_bug.cgi?id=97845
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/AudioDestinationChromium.cpp:
- 7:40 PM Changeset in webkit [129834] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove unused PlatformSupport reference in ClipboardChromium
https://bugs.webkit.org/show_bug.cgi?id=97840
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- platform/chromium/ClipboardChromium.cpp:
- 7:37 PM Changeset in webkit [129833] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Remove unused PlatformSupport reference in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=97842
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/WebFrameImpl.cpp:
- 7:36 PM Changeset in webkit [129832] by
-
- 12 edits in trunk
DateTimeNumericFieldElement should use Localizer functions.
https://bugs.webkit.org/show_bug.cgi?id=97318
Reviewed by Hajime Morita.
Source/WebCore:
Source/WebCore:
Use Localizer functions instead of functions in LocalizedNumber to test
i18n behavior. This affects only layout tests because
Document::getLocalizer() always returns a Localizer for the browser
locale.
To obtain a Localizer object for <input>'s locale from a deep shadow node,
we add localeIdentifier() function to DateTimeFieldElement::FieldOwner
and DateTimeEditElement::EditControlOwner interfaces.
Tests: fast/forms/time-multiple-fields/time-multiple-fields-localization.html
- html/shadow/DateTimeFieldElement.h:
(FieldOwner): Add localeIdentifier callback.
(DateTimeFieldElement): Add localeIdentifier().
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::localeIdentifier):
Added. Returns FieldOwner::localeIdentifier if m_fieldOwner is available.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Declare localizer().
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::localizer):
Returns a Localizer for DateTimeFieldElement::localeIdentifier()
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Use localizer().
(WebCore::DateTimeNumericFieldElement::value): Use localizer().
- html/shadow/DateTimeEditElement.h:
(EditControlOwner): Add localeIdentifier() callback.
(DateTimeEditElement):
Declare localeIdentifier(), which implements FieldOwner::localeIdentifier().
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::localeIdentifier):
Added. Returns EditControlOwner::localeIdentifier if m_editControlOwner is available.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare localeIdentifier(),
which implements EditControlOwner::localeIdentifier().
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::localeIdentifier):
Added. Returns <input>'s inherited locale identifier.
LayoutTests:
- platform/chromium/TestExpectations:
Need rebaseline for non-Mac results.
- platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt:
Update "ar" locale result.
- 7:16 PM Changeset in webkit [129831] by
-
- 3 edits in trunk/Source/WebCore
Implement reviewer feedback that I missed on bug 95930.
https://bugs.webkit.org/show_bug.cgi?id=97752
Reviewed by Alexey Proskuryakov.
This patch updates the indentation of function parameters in a few places,
and reserves an appropriate amount of space when using StringBuilder.
- css/CSSBasicShapes.cpp:
(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeRectangle::serializeResolvingVariables):
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
(WebCore::CSSBasicShapeEllipse::serializeResolvingVariables):
(WebCore::buildPolygonString):
- css/Rect.h:
(WebCore::Rect::serializeResolvingVariables):
(WebCore::Quad::serializeResolvingVariables):
(WebCore::Quad::generateCSSString):
- 6:43 PM Changeset in webkit [129830] by
-
- 2 edits in trunk/Source/JavaScriptCore
Put initializeHostCallReturnValue() behind #if ENABLE(JIT).
Fixes non JIT builds.
https://bugs.webkit.org/show_bug.cgi?id=97838.
Reviewed by John Sullivan.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- 6:23 PM FeatureFlags edited by
- Remove INPUT_TYPE_TIME_MULTIPLE_FIELDS (diff)
- 6:16 PM FeatureFlags edited by
- Add INPUT_MULTIPLE_FIELDS_UI (diff)
- 6:16 PM Changeset in webkit [129829] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r129823.
http://trac.webkit.org/changeset/129823
https://bugs.webkit.org/show_bug.cgi?id=97837
Cause a bunch of pixel failures on Chrome Linux that look like
real regressions (Requested by ojan on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-27
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
- 5:51 PM Changeset in webkit [129828] by
-
- 6 edits2 deletes in trunk/Source/WebKit
Get rid of more unused WK1 plug-in code
https://bugs.webkit.org/show_bug.cgi?id=97835
Reviewed by Mark Rowe.
Source/WebKit:
Remove WebNetscapeDeprecatedFunctions.c and WebNetscapeDeprecatedFunctions.h from the Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Plugins/WebBasePluginPackage.mm:
Remove JavaCFMPluginFilename #define.
(-[WebBasePluginPackage initWithPath:]):
#ifndef ppc is always true now.
(-[WebBasePluginPackage isJavaPlugIn]):
Remove JavaCFMPluginFilename.
- Plugins/WebNetscapeDeprecatedFunctions.c: Removed.
- Plugins/WebNetscapeDeprecatedFunctions.h: Removed.
Remove functions that nobody calls anymore.
- Plugins/WebNetscapePluginPackage.mm:
Remove +initialize call, the earliest version of Shockwave we now support doesn't
require us to have a valid CurApRefNum file anymore.
(-[WebNetscapePluginPackage _tryLoad]):
Remove more unused code.
- Plugins/WebPluginDatabase.h:
Remove CFM from a comment.
- 5:50 PM Changeset in webkit [129827] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fixed CallFrameClosure::resetCallFrame() to use the valid
range of argument index values.
https://bugs.webkit.org/show_bug.cgi?id=97836.
Reviewed by Gavin Barraclough.
- interpreter/CallFrame.h:
(ExecState):
- interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::resetCallFrame):
- 5:46 PM Changeset in webkit [129826] by
-
- 11 edits2 copies2 adds in trunk
[chromium] DumpRenderTree support for software compositing
https://bugs.webkit.org/show_bug.cgi?id=96853
Reviewed by James Robinson.
This adds software compositor support to DumpRenderTree. The only
thing needed is a minimal OutputSurfaceSoftware that holds a
viewport-sized bitmap. Then, I added virtual test suite
platform/chromium/virtual/softwarecompositing -- a mirror of the
compositing/ directory with --enable-software-compositing, and
expectations for not yet supported tests.
Tools:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::softwareCompositingEnabled):
(TestShell::setSoftwareCompositingEnabled):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
- DumpRenderTree/chromium/WebViewHostOutputSurface.cpp:
(WebKit::WebViewHostOutputSurface::create3d):
(WebKit):
(WebKit::WebViewHostOutputSurface::createSoftware):
(WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
(WebKit::WebViewHostOutputSurface::bindToClient):
(WebKit::WebViewHostOutputSurface::surfaceSoftware):
- DumpRenderTree/chromium/WebViewHostOutputSurface.h:
(WebKit):
(WebViewHostOutputSurface):
- DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
(WebKit):
(WebKit::WebViewHostSoftwareOutputDevice::lockForWrite):
(WebKit::WebViewHostSoftwareOutputDevice::unlockForWrite):
(WebKit::WebViewHostSoftwareOutputDevice::lockForRead):
(WebKit::WebViewHostSoftwareOutputDevice::unlockForRead):
(WebKit::WebViewHostSoftwareOutputDevice::viewportChanged):
- DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
(WebKit):
(WebViewHostSoftwareOutputDevice):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/chromium/virtual/softwarecompositing/README.txt: Added.
- 5:31 PM Changeset in webkit [129825] by
-
- 12 edits2 copies in trunk/Source
[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474
Reviewed by Adam Barth.
Source/Platform:
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.
- Platform.gypi:
- chromium/public/WebScreenInfo.h: Added.
(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):
Source/WebCore:
Part of a refactoring series. See tracking bug 82948.
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.
- WebCore.gypi:
- platform/Widget.h:
- platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.
(PageClientChromium):
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.
- public/WebScreenInfo.h:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::screenInfo):
(WebKit):
- src/ChromeClientImpl.h:
(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):
- src/PlatformSupport.cpp:
(WebCore):
- 5:26 PM Changeset in webkit [129824] by
-
- 16 edits in trunk/PerformanceTests
PerfTestRunner.run should take an object
https://bugs.webkit.org/show_bug.cgi?id=97743
Reviewed by Kentaro Hara.
Rename PerfTestRunner.run to PerfTestRunner.measureTime and make it take an object instead of
5 arguments. Also get rid of PerfTestRunner._loopsPerRun since it's no longer used (it's always 1).
- CSS/StyleSheetInsert.html:
- DOM/resources/dom-perf.js:
- Layout/floats_100_100.html:
- Layout/floats_100_100_nested.html:
- Layout/floats_20_100.html:
- Layout/floats_20_100_nested.html:
- Layout/floats_2_100.html:
- Layout/floats_2_100_nested.html:
- Layout/floats_50_100.html:
- Layout/floats_50_100_nested.html:
- Parser/html-parser.html:
- Parser/html5-full-render.html:
- SVG/SvgCubics.html:
- SVG/SvgHitTesting.html:
- resources/runner.js:
- 5:13 PM Changeset in webkit [129823] by
-
- 4 edits in trunk/Source/WebCore
[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
https://bugs.webkit.org/show_bug.cgi?id=97676
Reviewed by Tony Chang.
Use drawPosText() if possible for vertical text.
Use drawTextOnPath() only if the font doesn't have vhea/vmtx table.
No new tests. No change in behavior on LayoutTests.
Confirmed improvement in vertical text positioning using ipafont and Skia r5677.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::drawVerticalTextWithBrokenIdeographs): Added.
(WebCore):
(WebCore::Font::drawGlyphs): Draw vertical text by drawPosText() in a similar manner of FontSkia.cpp.
(WebCore::Font::drawComplexText): Disable setVerticalText(). Complex path doesn't support it now.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint): Call setVertialText().
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph): Disable setVerticalText() if the font doesn't have vertical metrics.
- 5:07 PM Changeset in webkit [129822] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r129806.
http://trac.webkit.org/changeset/129806
https://bugs.webkit.org/show_bug.cgi?id=97831
Broke windows build due to missing header (Requested by jsbell
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-27
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
- 5:05 PM Changeset in webkit [129821] by
-
- 9 edits in trunk
Source/WebKit/chromium: Remove unused methods from Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=95254
Patch by Nasko Oskov <nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.
Removing methods, which are no longer in use.
- public/WebFrame.h:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
Tools: Move DumpRenderTree to use newer version of the name method of
WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=95254
Patch by Nasko Oskov <nasko@chromium.org> on 2012-09-27
Reviewed by Adam Barth.
The WebFrame name() method is removed and replaced by better named
uniqueName() method, so DRT needs to be updated to use this new version.
Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
one more parameter, which had to be added in DRT.
- DumpRenderTree/chromium/TestShell.cpp:
(dumpFramesAsText):
(dumpFramesAsPrintedText):
(dumpFrameScrollPosition):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::unableToImplementPolicyWithError):
(WebViewHost::willCheckAndDispatchMessageEvent):
(WebViewHost::printFrameDescription):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 5:02 PM Changeset in webkit [129820] by
-
- 2 edits in trunk/LayoutTests
Delete test that no longer exists.
- platform/chromium/TestExpectations:
- 4:57 PM Changeset in webkit [129819] by
-
- 2 edits in trunk/Source/WTF
Remove the clang pragmas to disable warnings in Noncopyable.h
https://bugs.webkit.org/show_bug.cgi?id=97826
Reviewed by Beth Dakin.
Warnings about C++11 extensions are already disabled project-wide now so there's no need
to keep these pragmas.
- wtf/Noncopyable.h:
- 4:51 PM Changeset in webkit [129818] by
-
- 1 edit in branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp
Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763
Reviewed by Ryosuke Niwa.
r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.
This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).
- rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/10993072
- 4:39 PM Changeset in webkit [129817] by
-
- 2 edits in trunk/PerformanceTests
PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
https://bugs.webkit.org/show_bug.cgi?id=97741
Reviewed by Antti Koivisto.
Reset the content in the iframe in each run so that the runtime from each run follows a normal distribution.
We can cleanup this code once my patch to replace the argument list of run by an object is landed.
- CSS/StyleSheetInsert.html:
- 4:35 PM Changeset in webkit [129816] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed. Minor appearance tweaks after r129813.
- resources/results-template.html:
- 4:30 PM Changeset in webkit [129815] by
-
- 4 edits in trunk/Source
Versioning.
- 4:25 PM Changeset in webkit [129814] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763
Reviewed by Ryosuke Niwa.
r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.
This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).
- rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):
- 4:23 PM Changeset in webkit [129813] by
-
- 2 edits in trunk/PerformanceTests
Results page should warn about time-dependent distributions
https://bugs.webkit.org/show_bug.cgi?id=97818
Reviewed by Ojan Vafai.
Add a simple linear regression analysis on results page to detect time-dependent distributions.
We add a warning sign (inline SVG) when the regression gave us a slope of at least 0.01 and a R2 of at least 0.6.
Also added time-series graphs per run under the bar graphs so that humans can manually inspect them.
A nice follow up would be to add some normality test (e.g. Shapiro-Wilk) to detect bi-modal distributions
but we probably need to restructure the code to run it asynchronously since normality tests are slow.
- resources/results-template.html:
- 4:05 PM Changeset in webkit [129812] by
-
- 4 edits in tags/Safari-537.12/Source/WebKit2
Merge r129810.
- 3:48 PM Changeset in webkit [129811] by
-
- 1 copy in tags/Safari-537.12
New Tag.
- 3:37 PM Changeset in webkit [129810] by
-
- 4 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=97823
Need to bump the WKBundlePageLoaderClient version after the addition of didLayout
Reviewed by Brady Eidson.
Bump the version.
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 3:33 PM Changeset in webkit [129809] by
-
- 1 edit8 copies2 moves20 adds4 deletes in trunk/LayoutTests
IndexedDB: Split up setVersion and deleteDatabase sequencing tests
https://bugs.webkit.org/show_bug.cgi?id=97482
Reviewed by Tony Chang.
Final chapter in the trilogy of webkit.org/b/97051 and webkit.org/b/97368 -
split up some complex multi-part tests so they are easier to understand and manage.
- Split open-close-setversion -> setversion-*
- Split factory-deletedatabase-interactions -> deletedatabase-*
- storage/indexeddb/deletedatabase-blocked-expected.txt: Added.
- storage/indexeddb/deletedatabase-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt: Added.
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
- storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt: Added.
- storage/indexeddb/deletedatabase-delayed-by-versionchange.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
- storage/indexeddb/deletedatabase-not-blocked-expected.txt: Added.
- storage/indexeddb/deletedatabase-not-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
- storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Removed.
- storage/indexeddb/open-close-version-expected.txt: Removed.
- storage/indexeddb/resources/deletedatabase-blocked.js: Added.
- storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js: Added.
- storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js: Added.
- storage/indexeddb/resources/deletedatabase-not-blocked.js: Added.
- storage/indexeddb/resources/factory-deletedatabase-interactions.js: Removed.
- storage/indexeddb/resources/open-close-version.js: Removed.
- storage/indexeddb/resources/setversion-blocked-by-versionchange-close-in-blocked.js: Added.
- storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js: Added.
- storage/indexeddb/resources/setversion-blocked.js: Added.
- storage/indexeddb/resources/setversion-blocks-open.js: Added.
- storage/indexeddb/resources/setversion-blocks-setversion.js: Added.
- storage/indexeddb/resources/setversion-not-blocked.js: Added.
- storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt: Added.
- storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked-expected.txt: Added.
- storage/indexeddb/setversion-blocked-by-versionchange-close-in-blocked.html: Copied from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
- storage/indexeddb/setversion-blocked-by-versionchange-close.html: Renamed from LayoutTests/storage/indexeddb/factory-deletedatabase-interactions.html.
- storage/indexeddb/setversion-blocked-expected.txt: Added.
- storage/indexeddb/setversion-blocked.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
- storage/indexeddb/setversion-blocks-open-expected.txt: Added.
- storage/indexeddb/setversion-blocks-open.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
- storage/indexeddb/setversion-blocks-setversion-expected.txt: Added.
- storage/indexeddb/setversion-blocks-setversion.html: Copied from LayoutTests/storage/indexeddb/open-close-version.html.
- storage/indexeddb/setversion-not-blocked-expected.txt: Added.
- storage/indexeddb/setversion-not-blocked.html: Renamed from LayoutTests/storage/indexeddb/open-close-version.html.
- 3:25 PM Changeset in webkit [129808] by
-
- 4 edits2 adds in trunk
requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
https://bugs.webkit.org/show_bug.cgi?id=95360
Patch by Andrew Lo <anlo@rim.com> on 2012-09-27
Reviewed by Simon Fraser.
Source/WebCore:
DisplayRefreshMonitorManager::ensureMonitorForClient currently only adds the DisplayRefreshMonitorClient
to the appropriate DisplayRefreshMonitor when a new monitor is created.
It should also do so when it finds an existing monitor.
Test: fast/animation/request-animation-frame-iframe2.html
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
LayoutTests:
Add a new test which does requestAnimationFrame in both a sub-frame and
main-frame, and checks that both were executed.
- fast/animation/request-animation-frame-iframe2-expected.txt: Added.
- fast/animation/request-animation-frame-iframe2.html: Added.
- fast/animation/script-tests/request-animation-frame-subframe.html:
Remove element parameter from window.webkitRequestAnimationFrame.
- 3:15 PM Changeset in webkit [129807] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Chromium debug build fix.
Two fixes makes one breakage
http://trac.webkit.org/changeset/129785
http://trac.webkit.org/changeset/129798
- bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
- 3:03 PM Changeset in webkit [129806] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Optimize encodeString/decodeString
https://bugs.webkit.org/show_bug.cgi?id=97794
Reviewed by Tony Chang.
Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
isn't sufficient, but the code used StringBuilder::append() character-by-character
and custom byte-swapping which was slow.
Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
and putting it 20k times and getting it 20k times. On my test box, mean time before the
patch was 8.2s, mean time after the patch was 4.6s.
Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
- 3:01 PM Changeset in webkit [129805] by
-
- 3 edits in trunk/Tools
Add webkit_unit_tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=97814
Patch by Julie Parent <jparent@chromium.org> on 2012-09-27
Reviewed by Dirk Pranke.
webkit_unit_tests run on the same bots as test_shell_tests.
- TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 2:55 PM Changeset in webkit [129804] by
-
- 2 edits in trunk/Tools
[Perftest] PerfTestRunner exception when using nested git checkouts
https://bugs.webkit.org/show_bug.cgi?id=97796
Reviewed by Ryosuke Niwa.
In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
instantiate per-repository SCM objects when collecting revision information.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
- 2:54 PM Changeset in webkit [129803] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix 32-bit build.
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]):
Add back the architecture check that i accidentally.
- 2:50 PM TestExpectations edited by
- remove comments about ORWT and Skipped files (diff)
- 2:44 PM Changeset in webkit [129802] by
-
- 2 edits in trunk/Tools
[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
https://bugs.webkit.org/show_bug.cgi?id=97805
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-27
Reviewed by Alexey Proskuryakov.
Add support for handling a string as modifier argument to keyDown().
This support has already been added to other ports, so implementing
this on Mac too, to be consistent with the other ports.
- DumpRenderTree/mac/EventSendingController.mm:
(modifierFlags):
(buildModifierFlags):
- 2:36 PM Changeset in webkit [129801] by
-
- 4 edits in trunk/Source/WebKit/mac
Remove support for CFM plug-ins in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=97822
Reviewed by Mark Rowe.
I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so,
so it's safe to remove them (especially since they're PPC only).
- Plugins/WebNetscapePluginPackage.h:
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage closeResourceFile:]):
(-[WebNetscapePluginPackage _initWithPath:]):
(-[WebNetscapePluginPackage _tryLoad]):
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
- Plugins/WebPluginDatabase.mm:
(PluginPackageCandidates::PluginPackageCandidates):
(PluginPackageCandidates::update):
(PluginPackageCandidates::bestCandidate):
(PluginPackageCandidates):
- 2:33 PM Changeset in webkit [129800] by
-
- 2 edits in trunk/LayoutTests
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug
and is passing on all the other bots.
- platform/chromium/TestExpectations:
- 2:25 PM Changeset in webkit [129799] by
-
- 6 edits in trunk/Source
[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97817
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore):
(WebCore::ScrollbarThemeChromiumMac::paint):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- src/PlatformSupport.cpp:
(WebCore):
- 2:03 PM Changeset in webkit [129798] by
-
- 3 edits in trunk/Source/WebCore
Fix issue with ClassList which was hitting an assert in debug mode
https://bugs.webkit.org/show_bug.cgi?id=97820
Reviewed by Ojan Vafai.
http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.
No new tests. No change in behavior.
- bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
- html/ClassList.h:
- 1:59 PM Changeset in webkit [129797] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip a couple of passing tests.
- platform/efl/TestExpectations:
- 1:49 PM Changeset in webkit [129796] by
-
- 7 edits2 adds in trunk
Rewrite multithreaded filter job dispatching
https://bugs.webkit.org/show_bug.cgi?id=97500
Reviewed by Dean Jackson.
Source/WebCore:
This patch solves the problem of splitting up images into subregions for multithreaded
filters. This fixes the way we partition the image array into equal-sized chunks.
If we have an array of length N and want to split it into K chunks, we calculate:
int jobSize = N / K; integer division, so this is floored
int jobSizeExtra = N % K; modulus produces the remainder
We then split the array into jobSizeExtra number of jobs with size jobSize + 1
and (K - jobSizeExtra) number of jobs with size jobSize. This pattern
is used in each of the 5 filters in this patch.
This patch primarily fixes an error in FEMorphology::platformApply where
the image array was partitioned into (1 + (N / K)) pieces with the last job
taking the remainder. Unfortunately, this can cause overruns in the 2nd-to-last job.
Consider N = 2373 and K = 64 jobs. Job 0 would take indices 0...38, job 1 would take
38...76, etc. Unfortunately the 62nd job takes 2356...2394 which overruns.
To prevent similar issues elsewhere this patch updates all of the filters
to use the same pattern as FEMorphology.
Test: svg/filters/feMorphology-crash.html
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApply):
Some special care is taken for Gaussian Blur because there is an
extraHeight parameter for sampling outside the image's dimensions.
This means we use the same partitioning algorithm but add
extraHeight padding on the lower and upper bounds.
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
LayoutTests:
Add test that shows the morphology filter no longer crashes.
Note: this is only reliably reproducable when run with libgmalloc.
- svg/filters/feMorphology-crash-expected.txt: Added.
- svg/filters/feMorphology-crash.html: Added.
- 1:26 PM Changeset in webkit [129795] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium expectations update.
Flakey compositing tests and another flakey dom/shadow test.
- platform/chromium/TestExpectations:
- 1:21 PM Changeset in webkit [129794] by
-
- 2 edits in trunk/Tools
efl wk2 bots weren't looking at platform/wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97815
Unreviewed, build fix.
Should clean up this logic later so that we're just using the
implementation in base ...
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):
(EflPort.expectations_files):
- 12:57 PM Changeset in webkit [129793] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium expectations update.
Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey.
- platform/chromium/TestExpectations:
- 12:48 PM Changeset in webkit [129792] by
-
- 8 edits in trunk/Source
[Chromium] Move UNIX-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96516
Reviewed by Adam Barth.
Call WebThemeEngine functions and use WebThemeEngine enums
directly from the new Platform/ directly; remove all
intermediate functions and enums and conversion functions from
PlatformSupport.
Part of a refactoring series; see tracking bug 82948.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
- rendering/RenderThemeChromiumLinux.cpp:
(WebCore::getWebThemeState):
(WebCore):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 12:44 PM Changeset in webkit [129791] by
-
- 2 edits in trunk/Source/WebKit2
[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
https://bugs.webkit.org/show_bug.cgi?id=97745
Patch by Helder Correia <Helder Correia> on 2012-09-27
Reviewed by Martin Robinson.
In LayerTreeCoordinator::adoptImageBackingStore(), there is a
PLATFORM(QT) code path to check for identical images, but nothing is
done for Cairo, which results in the occurrence of avoidable resource
allocations.
The issue happens in e.g. http://www.webkit.org/blog-files/leaves/,
where there are many leaves flying around while they're produced out of
only four bitmaps.
This patch uses pointers to cairo_surface_t's as the key to the hashmap
that caches bitmaps. This can be safely done since we own the references.
We artificially increment the surface references in adoptImageBackingStore()
and decrement them in releaseImageBackingStore().
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
- 12:33 PM Changeset in webkit [129790] by
-
- 4 edits in trunk/Source/WebKit2
Stop using dispatch_get_current_queue
https://bugs.webkit.org/show_bug.cgi?id=97806
<rdar://problem/12379094>
Reviewed by Mark Rowe.
- Platform/mac/WorkQueueMac.cpp:
(WorkQueueAndFunction::WorkQueueAndFunction):
(WorkQueueAndFunction):
(WorkQueue::executeFunction):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
Keep track of the associated work queue so we can get it in WorkQueue::executeFunction.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::setUpTerminationNotificationHandler):
We don't care about which queue the termination notification is delivered on since we only want to call
waitpid on the child pid so we can just use a global queue.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):
Use dispatch_get_main_queue here.
- 12:24 PM Changeset in webkit [129789] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] IconDatabase: Add a way to notify when icon data is available
https://bugs.webkit.org/show_bug.cgi?id=63945
Rubber stamped by Anders Carlsson.
Update version of WKIconDatabaseClient and API traits.
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKIconDatabase.h:
- 12:24 PM Changeset in webkit [129788] by
-
- 17 edits1 move18 deletes in trunk/LayoutTests
merge Skipped file entries into TestExpectations, remove Skipped files
https://bugs.webkit.org/show_bug.cgi?id=97750
Reviewed by Ojan Vafai.
Now that old-run-webkit-tests will skip any tests listed in
TestExpectations files, there is no need to have both Skipped
files and TestExpectations files. This change merges all of the
entries in the Skipped files into the TestExpectations files and
removes the Skipped files.
Subsequent changes will remove support for Skipped files from
both new-run-webkit-tests and old-run-webkit-tests to
complete the project.
- platform/efl/Skipped: Removed.
- platform/efl/TestExpectations:
- platform/mac-lion/Skipped: Removed.
- platform/mac-lion/TestExpectations:
- platform/mac-snowleopard/Skipped: Removed.
- platform/mac-snowleopard/TestExpectations:
- platform/mac-wk2/Skipped: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/Skipped: Removed.
- platform/mac/TestExpectations:
- platform/qt-4.8/Skipped: Removed.
- platform/qt-4.8/TestExpectations:
- platform/qt-5.0-wk1/Skipped: Removed.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/Skipped: Removed.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0/Skipped: Removed.
- platform/qt-5.0/TestExpectations:
- platform/qt-arm/Skipped: Removed.
- platform/qt-arm/TestExpectations:
- platform/qt-linux/Skipped: Removed.
- platform/qt-mac/Skipped: Removed.
- platform/qt-mac/TestExpectations:
- platform/qt-win/Skipped: Removed.
- platform/qt/Skipped: Removed.
- platform/qt/TestExpectations:
- platform/win-wk2/Skipped: Removed.
- platform/win-wk2/TestExpectations:
- platform/win-xp/Skipped: Removed.
- platform/win-xp/TestExpectations:
- platform/win/Skipped: Removed.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations: Renamed from LayoutTests/platform/wincairo/Skipped.
- platform/wk2/Skipped: Removed.
- platform/wk2/TestExpectations:
- 12:23 PM Changeset in webkit [129787] by
-
- 10 edits in trunk/Source/WebCore
[CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside
https://bugs.webkit.org/show_bug.cgi?id=97707
Patch by Bear Travis <betravis@adobe.com> on 2012-09-27
Reviewed by Antti Koivisto.
The exclusions specification has renamed wrap-shape-inside and wrap-shape-outside
to shape-inside and shape-outside. We should rename the getter/setter functions
in RenderStyle, and update the derived variable and function names accordingly.
For more information, see: http://dev.w3.org/csswg/css3-exclusions/#declaring-shapes
Covered by existing tests. No new functionality.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::StyleBuilder::StyleBuilder):
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock):
(WebCore::ExclusionShapeInsideInfo::computeShapeSize):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::exclusionShapeInsideInfo):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
- 12:04 PM Changeset in webkit [129786] by
-
- 2 edits in trunk/Source/WebCore
ApplicationCacheStorage does not optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=97733
Reviewed by Alexey Proskuryakov.
Added 8 bit string paths.
No functional change, therefore no new tests.
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
(WebCore::ApplicationCacheStorage::store):
(WebCore::parseHeader):
(WebCore::parseHeaders):
- 12:03 PM Changeset in webkit [129785] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Chromium debug build fix.
ASSERT contains an inequality of unmatched types. A cast should do the trick.
- bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
- 12:00 PM Changeset in webkit [129784] by
-
- 5 edits in trunk/Tools
webkitpy: make warning about missing BUG identifiers per-port configurable
https://bugs.webkit.org/show_bug.cgi?id=97751
Reviewed by Ojan Vafai.
Prior to this change linting TestExpectations files (checking their style)
would raise warnings if lines were missing a BUG modifier, even
though such a modifier is actually optional in the syntax. As we
migrate the entries over from the Skipped files, these warnings
will generate a lot of noise, and it's not yet clear that we
actually want to require the modifiers on all ports.
So, this change makes this per-port configurable so that they
will generate warnings in the Chromium TestExpectations and not
anywhere else.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_modifiers):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(MiscTests.test_parse_warning):
(SemanticTests.test_missing_bugid):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.warn_if_bug_missing_in_test_expectations):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.warn_if_bug_missing_in_test_expectations):
- 11:47 AM Changeset in webkit [129783] by
-
- 6 edits2 deletes in trunk
[Chromium-Android] Push more fonts for layout tests to match chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=97746
Tools:
Reviewed by Dirk Pranke.
- DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
- Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
(ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
(ChromiumAndroidPort._path_to_md5sum):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
LayoutTests:
Some original rebaselines will be unnecessary after this change.
Checked some rebaselines of chromium-android under fast/text,
but there should be more. Leave them to gardening.
Reviewed by Dirk Pranke.
- platform/chromium-android/TestExpectations: Enabled some skipped tests because now we have the fonts.
- platform/chromium-android/fast/text/complex-text-opacity-expected.txt: Removed. No more need rebaselining.
- platform/chromium-android/fast/text/international/hindi-spacing-expected.txt: Removed. No more need rebaselining.
- 11:41 AM Changeset in webkit [129782] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
https://bugs.webkit.org/show_bug.cgi?id=97561
Reviewed by Noam Rosenthal.
Make sure we always send the very first RenderNextFrame message.
Before r128980 it was working accidentally because in the common
case the web process sent a DeleteCompositingLayer message at some
point before the forced repaint would time out and we was sending
the first RenderNextFrame when reacting to that.
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setActive): Set the LayerTreeRenderer to active
as well. In the QQuickWebView case it is handled by the QtWebPageSGNode.
(QRawWebView::layerTreeRenderer): Added a convenience getter
for the LayerTreeRenderer.
(QRawWebView::paint):
- UIProcess/API/qt/raw/qrawwebview_p.h:
(WebKit):
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(tst_qrawwebview::tst_qrawwebview): Added a call to addQtWebProcessToPath
to make my and the follower users of this test easier.
- 11:35 AM Changeset in webkit [129781] by
-
- 5 edits in trunk/Source/WebCore
Simplify and clarify MutationObserverRegistration interface and usage
https://bugs.webkit.org/show_bug.cgi?id=97742
Reviewed by Ojan Vafai.
Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
remove the declaration of a no-longer-existing method.
No change in behavior.
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.
- dom/MutationObserverRegistration.h:
(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous "inline" keyword.
(WebCore::MutationObserverRegistration::observer): const method.
- dom/Node.cpp:
(WebCore):
(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.
- dom/Node.h:
(Node): Remove old method, replaced by templatized static function.
- 11:30 AM Changeset in webkit [129780] by
-
- 2 edits in trunk/Source/WTF
Clean up HasTrivialConstructor/Destructor
https://bugs.webkit.org/show_bug.cgi?id=97754
Reviewed by Darin Adler.
Cleaned up HasTrivialConstructor and HasTrivialDestructor by defining them in terms of
other type traits we have. Also moved some ifdefs and comments to make things more clear.
- wtf/TypeTraits.h:
- 11:05 AM Changeset in webkit [129779] by
-
- 28 edits in trunk
DOM4: Add support for rest parameters to DOMTokenList
https://bugs.webkit.org/show_bug.cgi?id=97335
Reviewed by Ojan Vafai.
This adds support for rest paramaters to DOMTokenList add and remove.
http://dom.spec.whatwg.org/#domtokenlist
The code generator has been updated to understand variadic methods.
When a method has a rest parameter the remaining arguments are collected
into a WTF::Vector.
DOMTokenList, DOMSettableTokenList and ClassList were restructured a bit to
allow code to be shared better.
Source/WebCore:
Updated existing tests and includes new binding tests.
- bindings/js/JSDOMBinding.h:
(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateArgumentsCountCheck): Updated to treat rest paramaters as optional.
(GenerateParametersCheck): Generate code for rest params.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionParametersCheck): Updated to treat rest paramaters as optional.
(GenerateArgumentsCountCheck): Ditto.
(GenerateParametersCheck): Generate code for rest params.
- bindings/scripts/IDLParser.pm:
(parseOptionalOrRequiredArgument):
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::variadicStringMethod):
(WebDOMTestObj::variadicDoubleMethod):
(WebDOMTestObj::variadicNodeMethod):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj variadicStringMethod:tail:]):
(-[DOMTestObj variadicDoubleMethod:tail:]):
(-[DOMTestObj variadicNodeMethod:tail:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/V8Binding.h:
(WebCore::toNativeArray):
(WebCore):
(WebCore::toNativeArguments): Similar to toNativeArray but extracts the arguments instead.
- html/ClassList.cpp:
(WebCore::ClassList::ClassList):
- html/ClassList.h:
(WebCore):
(ClassList):
- html/DOMSettableTokenList.cpp:
(WebCore::DOMSettableTokenList::containsInternal):
(WebCore::DOMSettableTokenList::add):
(WebCore::DOMSettableTokenList::addInternal):
(WebCore::DOMSettableTokenList::remove):
(WebCore::DOMSettableTokenList::removeInternal):
(WebCore::DOMSettableTokenList::setValue):
- html/DOMSettableTokenList.h:
(DOMSettableTokenList):
- html/DOMTokenList.cpp:
(WebCore::DOMTokenList::validateTokens):
(WebCore):
(WebCore::DOMTokenList::contains): Moved implementation to base class to allow code sharing.
(WebCore::DOMTokenList::add): Ditto.
(WebCore::DOMTokenList::remove): Ditto.
(WebCore::DOMTokenList::toggle): Ditto.
(WebCore::DOMTokenList::addInternal): Ditto.
(WebCore::DOMTokenList::removeInternal): Ditto.
(WebCore::DOMTokenList::addToken): Ditto.
(WebCore::DOMTokenList::addTokens):
(WebCore::DOMTokenList::removeToken): Ditto.
(WebCore::DOMTokenList::removeTokens):
- html/DOMTokenList.h:
(DOMTokenList):
(WebCore::DOMTokenList::toString):
- html/DOMTokenList.idl:
LayoutTests:
- fast/dom/HTMLElement/class-list-expected.txt:
- fast/dom/HTMLElement/class-list-quirks-expected.txt:
- fast/dom/HTMLElement/script-tests/class-list.js:
(element.classList.add):
(createElement):
(shouldBeEqualToString):
(element.classList.remove):
- 10:52 AM Changeset in webkit [129778] by
-
- 1 edit347 adds in trunk/LayoutTests
[Chromium] Rebaseline more test directories for Android.
Unreviewed rebaselining.
Same as previous commits. Most changes are caused by the scrollbar, text selection
color and quality differences in image quality, causing minor (but acceptable)
differences. More information is available in bug 96398.
- platform/chromium-android/svg/: 71 new results.
- platform/chromium-android/tables/: 250 new results.
- platform/chromium-android/transforms/: 5 new results.
- platform/chromium-android/transitions/: 1 new result.
- 10:38 AM Changeset in webkit [129777] by
-
- 13 edits277 adds in trunk/LayoutTests
[Chromium] Rebaseline several test directories for Android/.
Unreviewed rebaselining.
Most of these changes were caused by our different scrollbars and minor
positioning issues, and therefore are safe to rebase. With Xianzhu's
patch in the tree that adds additional fonts, more pass there as well.
Actual failures include more form items. Bugs will be filed.
- platform/chromium-android/animations/: 4 new results.
- platform/chromium-android/compositing/: 72 new results.
- platform/chromium-android/css2.1/: 52 new results.
- platform/chromium-android/css3/: 5 new results.
- platform/chromium-android/editing/: 46 new results.
- platform/chromium-android/fast/: 42 new results.
- platform/chromium-android/fonts/: 12 new results.
- platform/chromium-android/http/: 5 new results.
- platform/chromium-android/ietestcenter/: 4 new results.
- platform/chromium-android/platform/: 13 new results.
- platform/chromium-android/printing/: 2 new results.
- platform/chromium-android/scrollbars/: 2 new results.
- platform/chromium-android/svg/: 4 new results.
- 10:23 AM Changeset in webkit [129776] by
-
- 3 edits in trunk/Source/WebCore
332kB below DocumentEventQueue::create() on Membuster3.
<http://webkit.org/b/97712>
Reviewed by Anders Carlsson.
Give DocumentEventQueue::m_queuedEvents an inline capacity of 16 (the default is 256.)
312kB progression on Membuster3.
- dom/DocumentEventQueue.h:
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::pendingEventTimerFired):
- 10:09 AM Changeset in webkit [129775] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=97783
Reviewed by Pavel Feldman.
BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
- 10:09 AM Changeset in webkit [129774] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix usage of COMPILER() macros
https://bugs.webkit.org/show_bug.cgi?id=97642
Reviewed by Geoffrey Garen.
Add COMPILER(GCC) around compiler specific code and remove it from generic code.
This allows us to implement the DFG code for other compilers to in a next step.
- dfg/DFGOperations.cpp:
- jit/HostCallReturnValue.h:
- 10:04 AM Changeset in webkit [129773] by
-
- 2 edits in trunk/Source/JavaScriptCore
3.20MB below FunctionParameters::create() on Membuster3.
<http://webkit.org/b/97730>
Reviewed by Anders Carlsson.
Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
Reduces memory consumption on Membuster3 by ~1.60 MB.
- parser/Nodes.cpp:
(JSC::FunctionParameters::FunctionParameters):
- 10:01 AM Changeset in webkit [129772] by
-
- 2 edits in trunk/Source/WebKit/chromium
Page overlays are not updated when WebView is resized
https://bugs.webkit.org/show_bug.cgi?id=97789
Reviewed by Vsevolod Vlasov.
Invalidate page overlays when view is resized.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sendResizeEventAndRepaint):
- 9:58 AM Changeset in webkit [129771] by
-
- 2 edits in trunk/Source/WebCore
Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
https://bugs.webkit.org/show_bug.cgi?id=97759
Reviewed by Adam Barth.
InspectorInstrumentation.h includes two '#if USE(JSC)' blocks, which
I've been reliably informed should not appear in WebCore[1]. This patch
drops both blocks, and includes 'ScriptState.h' instead, which should
have the same practical effect.
There's no functional change, so this should be covered by existing tests.
[1]: https://bugs.webkit.org/show_bug.cgi?id=94433#c55
- inspector/InspectorInstrumentation.h:
(WebCore):
- 9:22 AM Changeset in webkit [129770] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-27
- DEPS:
- 9:06 AM Changeset in webkit [129769] by
-
- 2 edits in trunk/Source/WebCore
Remove unused regular expressions from IDLStructure.pm
https://bugs.webkit.org/show_bug.cgi?id=97790
Reviewed by Kentaro Hara.
After http://trac.webkit.org/changeset/129723 these regular expressions are no longer used.
No new tests, run-binding-tests generates the same output.
- bindings/scripts/IDLStructure.pm:
- 8:54 AM Changeset in webkit [129768] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/profiler/apply.html fails with LLInt on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=97791
Unreviewed gardening, skip the new failing test to paint the bots green.
- platform/qt/Skipped:
- 8:42 AM Changeset in webkit [129767] by
-
- 4 edits3 deletes in trunk/LayoutTests
Unreviewed Chromium expectations
Expectations that were lagging at the last rebaseline.
- platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/date: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/date: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed.
- platform/chromium/TestExpectations:
- 8:26 AM Changeset in webkit [129766] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2][WTR] Unskip two jQuery test cases.
https://bugs.webkit.org/show_bug.cgi?id=97787
Unreviewed EFL gardening.
'jquery/data.html' and 'jquery/offset.html' cases seem to be passed consistently now.
For more information, BUG 81606 resolved some jQuery test cases
that need several seconds to finish its running by extending timeout value like WK1.
Seemingly, mentioned two cases took around 5 seconds for each on my laptop
and it would had been flaky in different hardware condition before BUG 81606.
Therefore, this patch unskipped those cases from TestExpections.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-27
- platform/efl-wk2/TestExpectations:
- 8:18 AM EFLWebKit edited by
- Found no evidence that 3.0.4 version of gperf would be really required (diff)
- 8:08 AM Changeset in webkit [129765] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Process touch events using mouse and multi events of Evas.
https://bugs.webkit.org/show_bug.cgi?id=96906
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Provide default behavior for processing touch events in the ewk_view if
application wants to use it.
We can to process touch events using mouse and multi events because the
Evas creates mouse events for first touch and multi events for second and
third touch. It can be modified when Evas starts to support event type
for touch events.
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
(_ewk_view_on_touch_down):
(_ewk_view_on_touch_up):
(_ewk_view_on_touch_move):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
(EWK2UnitTest::EWK2UnitTestBase::mouseMove):
(EWK2UnitTest::EWK2UnitTestBase::multiDown):
(EWK2UnitTest::EWK2UnitTestBase::multiUp):
(EWK2UnitTest::EWK2UnitTestBase::multiMove):
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 7:56 AM Changeset in webkit [129764] by
-
- 9 edits in trunk
MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
https://bugs.webkit.org/show_bug.cgi?id=97559
Reviewed by Adam Barth.
Source/Platform:
Refactored to mimic the new MediaConstraints api.
- chromium/public/WebMediaConstraints.h:
(WebCore):
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebMediaConstraint):
(WebKit):
(WebMediaConstraints):
Source/WebCore:
Instead of just returning the names, return a pair of name and value.
Existing tests cover this patch.
- Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::initialize):
(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue):
- Modules/mediastream/MediaConstraintsImpl.h:
(MediaConstraintsImpl):
- platform/chromium/support/WebMediaConstraints.cpp:
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebKit):
(WebKit::WebMediaConstraints::getMandatoryConstraints):
(WebKit::WebMediaConstraints::getOptionalConstraints):
- platform/mediastream/MediaConstraints.h:
(WebCore::MediaConstraint::MediaConstraint):
(MediaConstraint):
(WebCore):
(MediaConstraints):
Tools:
Refactoring for the new WebMediaConstraints api.
- DumpRenderTree/chromium/MockConstraints.cpp:
(MockConstraints::verify):
- 6:51 AM Changeset in webkit [129763] by
-
- 26 edits23 adds35 deletes in trunk/LayoutTests
Unreviewed Chromium expectations
Cleanup after a night of building. I think some of these failures are
due to premature rebaselining earlier.
- platform/chromium-linux-x86/fast/forms/placeholder-position-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/compositing/webgl-loses-compositor-context-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/date: Added.
- platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
- platform/chromium-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
- platform/chromium-linux/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-linux/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-linux/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
- platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
- platform/chromium-linux/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/date: Added.
- platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/3d-corners-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-permanently-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-twice-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/render-surface-alpha-blending-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win-xp/fast/text/line-breaks-expected.txt:
- platform/chromium-win-xp/platform/chromium/compositing/3d-corners-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/huge-layer-rotated-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/img-layer-grow-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-permanently-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-twice-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/tiny-layer-rotated-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/video-frame-size-change-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/compositing/webgl-loses-compositor-context-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/date: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/date: Added.
- platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/js/eval-cross-window-expected.txt: Replaced.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Replaced.
- platform/chromium/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
- platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Removed.
- platform/chromium/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
- 6:45 AM Changeset in webkit [129762] by
-
- 8 edits in trunk/Source
Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class.
https://bugs.webkit.org/show_bug.cgi?id=97461
Reviewed by Yury Semikhatsky.
These methods and the data collected by them need to be used in the instrumentation code for other components.
As example when we are visiting bitmaps we need to visit platform specific objects.
These objects will be instrumented with help of component's own instrumentation code
but we have to keep the single set of visited objects and the map of counters.
Source/WebCore:
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::collectDomTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::countObjectSize):
(WebCore):
(WebCore::MemoryInstrumentationClientImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):
- inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationClientImpl::MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::selfSize):
(MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::visitedObjects):
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
Source/WebKit/chromium:
- tests/MemoryInstrumentationTest.cpp:
(InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::InstrumentationTestHelper):
(WebCore::InstrumentationTestHelper::addRootObject):
(WebCore::InstrumentationTestHelper::reportedSizeForAllTypes):
(WebCore::InstrumentationTestHelper::visitedObjects):
(WebCore::InstrumentationTestHelper::totalSize):
(WebCore):
(WebCore::TEST):
Source/WTF:
- wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
(WTF::MemoryInstrumentationClient::~MemoryInstrumentationClient):
(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::countObjectSize):
(WTF::MemoryInstrumentation::visited):
- 6:44 AM Changeset in webkit [129761] by
-
- 5 edits in trunk/Tools
MediaStream API: Rename MockConstraints::verify to verifyConstraints
https://bugs.webkit.org/show_bug.cgi?id=97779
Reviewed by Csaba Osztrogonác.
The Mac OS X sdk has a macro called verify :/
- DumpRenderTree/chromium/MockConstraints.cpp:
(MockConstraints::verifyConstraints):
- DumpRenderTree/chromium/MockConstraints.h:
(MockConstraints):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::initialize):
- DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebUserMediaClientMock::requestUserMedia):
- 6:28 AM Changeset in webkit [129760] by
-
- 6 edits1 add in trunk/Source
[Qt] Enable the LLInt on Linux
https://bugs.webkit.org/show_bug.cgi?id=95749
Patch by Csaba Osztrogonác <Csaba Osztrogonác>, Tor Arne Vestbø <vestbo@webkit.org> on 2012-09-27
Reviewed by Simon Hausmann.
Source/JavaScriptCore:
- DerivedSources.pri:
- JavaScriptCore.pro:
- LLIntOffsetsExtractor.pro: Added.
- Target.pri:
Source/WTF:
- wtf/Platform.h:
- 6:26 AM WebKitGTK/1.10.x edited by
- (diff)
- 6:17 AM Changeset in webkit [129759] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] Remove unnecessary header files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=97771
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Kentaro Hara.
Remove the header files which are added in the source file list.
- CMakeLists.txt:
- 6:00 AM Changeset in webkit [129758] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add callback functions for WKPageFindClient
https://bugs.webkit.org/show_bug.cgi?id=97431
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-27
Reviewed by Laszlo Gombos.
Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
The unit test for didFindString() and didFailToFindString() have beend added. The unit test for
didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet.
Additionaly, I changed the 'unsinged int' to 'unsigned' in the parameter type and removed unnecessary
type conversion.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_find):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_find_client.cpp:
(didFindString):
(didFailToFindString):
(didCountStringMatches):
(ewk_view_find_client_attach):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onTextFound):
(TEST_F):
- 5:53 AM Changeset in webkit [129757] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, re-landing r129633 with the proper order of calls.
https://bugs.webkit.org/show_bug.cgi?id=97659
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
- 5:21 AM Changeset in webkit [129756] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing test.
https://bugs.webkit.org/show_bug.cgi?id=71896.
- platform/wk2/Skipped:
- 5:15 AM Changeset in webkit [129755] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r129633.
http://trac.webkit.org/changeset/129633
https://bugs.webkit.org/show_bug.cgi?id=97659
Breaks inspector overlay in non-composited mode
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
- 4:46 AM Changeset in webkit [129754] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
https://bugs.webkit.org/show_bug.cgi?id=97770
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
sync with what is in mediaControlsEfl.css.
We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
fullscreen mode, that is to say, the hiding of some controls.
No new tests, no behavior change for layout tests.
- css/mediaControlsEflFullscreen.css:
- 4:39 AM Changeset in webkit [129753] by
-
- 5 edits in trunk
Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
https://bugs.webkit.org/show_bug.cgi?id=97768
Reviewed by Pavel Feldman.
Source/WebCore:
Open resource dialog now assumes implicit wildcard in the beginning of the query.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering-expected.txt:
- inspector/filtered-item-selection-dialog-filtering.html:
- 4:22 AM Changeset in webkit [129752] by
-
- 2 edits in trunk/Source/WebKit
[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=97769
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Update Default theme files in PlatformEfl.cmake so that
changes to those files are properly picked up by CMake
when building incrementally.
- PlatformEfl.cmake:
- 4:18 AM Changeset in webkit [129751] by
-
- 32 edits in trunk/Source/WebCore
Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks
https://bugs.webkit.org/show_bug.cgi?id=96730
Reviewed by Vsevolod Vlasov.
- Introduced InspectorInstrumentation::console|timeline|runtime|canvasAgentEnabled
- Using it all over the place instead of the hasFrontend (the latter is now only used once to guard hot path)
- Introduced explicit "enabled" state of the console and runtime agents
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
- bindings/js/ScriptCallStackFactory.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallWith):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
- bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForConsole):
- bindings/v8/ScriptCallStackFactory.h:
(WebCore):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::callFunctionWithInstrumentation):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore):
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::clearFrontend):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
(WebCore::InspectorConsoleAgent::enabled):
(InspectorConsoleAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::canvasAgentEnabled):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::runtimeAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::enabled):
(WebCore::InspectorRuntimeAgent::enable):
(WebCore::InspectorRuntimeAgent::disable):
(InspectorRuntimeAgent):
- inspector/PageRuntimeAgent.cpp:
(PageRuntimeAgentState):
(WebCore::PageRuntimeAgent::clearFrontend):
(WebCore::PageRuntimeAgent::restore):
(WebCore):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didClearWindowObject):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype._didLoadCachedResources):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
- 4:12 AM Changeset in webkit [129750] by
-
- 17 edits in trunk/Source
Unify event handling of middle mouse button.
https://bugs.webkit.org/show_bug.cgi?id=97690
Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-09-27
Reviewed by Tony Chang.
Source/WebCore:
Implement a unified version of middle mouse button press that can be shared between
all the ports with X11 support.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handlePasteGlobalSelection):
- page/EventHandler.h:
(EventHandler):
Source/WebKit/chromium:
Remove port specific handling of middle mouse button press.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseUp):
Source/WebKit/gtk:
Remove port specific handling of middle mouse button press.
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::supportsGlobalSelection):
- WebCoreSupport/EditorClientGtk.h:
(EditorClient):
- webkit/webkitwebview.cpp:
(webkit_web_view_button_press_event):
Source/WebKit/qt:
Remove port specific handling of middle mouse button press.
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
- Api/qwebpage_p.h:
(QWebPagePrivate):
Source/WebKit2:
Remove Qt and GTK port specific handling of middle mouse button press.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit):
- WebProcess/WebPage/qt/WebPageQt.cpp:
- 4:07 AM Changeset in webkit [129749] by
-
- 21 edits2 copies in trunk
MediaStream API: Update getUserMedia to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=97540
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebMediaConstraints.h:
(WebMediaConstraints):
Source/WebCore:
http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.
Existing tests expanded to cover the new change.
- Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::create):
(WebCore):
- Modules/mediastream/MediaConstraintsImpl.h:
(MediaConstraintsImpl):
- Modules/mediastream/NavigatorMediaStream.cpp:
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::parseOptions):
(WebCore):
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::audioConstraints):
(WebCore::UserMediaRequest::videoConstraints):
- Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):
- platform/chromium/support/WebMediaConstraints.cpp:
(WebKit::WebMediaConstraints::WebMediaConstraints):
(WebKit):
Source/WebKit/chromium:
http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.
- public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):
Tools:
http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
Navigator.getUserMedia is changed so that the audio and video members can either
be a bool or a constraints object.
- public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::audioConstraints):
(WebKit):
(WebKit::WebUserMediaRequest::videoConstraints):
LayoutTests:
Expanding tests to cover the new getUserMedia behaviour.
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/getusermedia.html:
- 3:37 AM Changeset in webkit [129748] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed inspector front-end closure compilation fix.
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
- 3:05 AM Changeset in webkit [129747] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip a test again after r129712.
- platform/qt/Skipped:
- 2:55 AM Changeset in webkit [129746] by
-
- 3 edits2 adds in trunk
CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=78595
Reviewed by Antti Koivisto.
Source/WebCore:
Do not use the same dynamicPseudo reference when recursively invoking checkSelector() for non-SubSelector selectors.
Test: fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Use new NOPSEUDO dynamic pseudoId values
for each non-SubSelector selector further in the tag history.
LayoutTests:
The original issue mentioned failures on selectors like ".foo.moo > .bar:before", while things worked fine for ".foo > .bar:before".
The test checks 2 and 3 selector levels for all conventional non-SubSelector relations (Child, Descendant, DirectAdjacent, IndirectAdjacent),
each selector in all levels but the last one containing a SubSelector relation.
- fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html: Added.
- fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt: Added.
- 2:44 AM Changeset in webkit [129745] by
-
- 5 edits2 adds1 delete in trunk/Source
[EFL] No way to exit video fullscreen mode once entered
https://bugs.webkit.org/show_bug.cgi?id=97631
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Show fullscreen media control in fullscreen so that
we now have a way to exit fullscreen mode.
No new tests, no behavior change for layout tests.
- css/mediaControlsEflFullscreen.css:
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
Source/WebKit/efl:
Fix default theme so that we have 2 fullscreen buttons, one
to enter fullscreen mode and another to exit it.
New icon by Alexander Shalamov.
- DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Added.
- DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Added.
- DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
- DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Removed.
- 2:40 AM Changeset in webkit [129744] by
-
- 3 edits in trunk/LayoutTests
Unreviewed inspector test unskipped on qt, expectations updated.
- http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
- platform/qt/Skipped:
- 2:32 AM Changeset in webkit [129743] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Injected bundle API implementation should use toWTFString()
https://bugs.webkit.org/show_bug.cgi?id=97766
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Injected bundle API implementation should call toWTFString() rather than convert
WKStringRef and WKURLRef to their impls and then call string() method directly.
The rational for that are both safety (toWTFString checks the given pointer) and
code readability.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostMessage):
(WKBundlePostSynchronousMessage):
(WKBundleOverrideBoolPreferenceForTestRunner):
(WKBundleAddOriginAccessWhitelistEntry):
(WKBundleRemoveOriginAccessWhitelistEntry):
(WKBundleClearApplicationCacheForOrigin):
(WKBundleGetAppCacheUsageForOrigin):
(WKBundleSetApplicationCacheOriginQuota):
(WKBundleResetApplicationCacheOriginQuota):
(WKBundlePageNumberForElementById):
(WKBundleSetUserStyleSheetLocation):
(WKBundleSetWebNotificationPermission):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFramePauseAnimationOnElementWithId):
(WKBundleFramePauseTransitionOnElementWithId):
(WKBundleFrameAllowsFollowingLink):
(WKBundleFrameCopySuggestedFilenameForResourceWithURL):
(WKBundleFrameCopyMIMETypeForResourceWithURL):
(WKBundleFrameSetTextDirection):
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorEvaluateScriptForTest):
- WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp:
(WKBundleIntentCreate):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageExecuteEditingCommand):
(WKBundlePageIsEditingCommandEnabled):
(WKBundlePageHasLocalDataForURL):
(WKBundlePageFindString):
(WKBundlePageSetComposition):
(WKBundlePageConfirmCompositionWithText):
(WKBundlePageCanShowMIMEType):
- 2:28 AM WebKit Team edited by
- Update affiliation of team members (diff)
- 2:24 AM Changeset in webkit [129742] by
-
- 8 edits in trunk/Source/WebKit2
[WK2] IconDatabase: Add a way to notify when icon data is available
https://bugs.webkit.org/show_bug.cgi?id=63945
Reviewed by Anders Carlsson.
Provide new API to notify the API layer when icon data is
available, and use it from the implementation layer when needed,
that is, either when the data has been loaded from the network or
imported from disk.
Added new callback to WKIconDatabaseClient API.
- UIProcess/API/C/WKIconDatabase.h: Added new callback.
- UIProcess/WebIconDatabaseClient.cpp:
(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):
Implementation of the new callback at this level in the UI
process, by using its implementation in the API layer if present.
- UIProcess/WebIconDatabaseClient.h:
(WebIconDatabaseClient): Added new callback.
Implemented WebFrameLoaderClient::dispatchDidReceiveIcon, so we
get notified in the UI process when loading a new icon.
- UIProcess/WebIconDatabase.messages.in: Added new message to
notify the UI process: DidReceiveIconForPageURL.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::notifyIconDataReadyForPageURL): New
private helper function to notify the API layer both that new icon
data is ready and that the icon has changed.
(WebKit::WebIconDatabase::didReceiveIconForPageURL):
Implementation of the new message added, by calling
notifyIconDataReadyForPageURL() to notify the API layer.
(WebKit::WebIconDatabase::didImportIconDataForPageURL): Call
notifyIconDataReadyForPageURL() from here as well.
- UIProcess/WebIconDatabase.h: Added new prototypes.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon): Send a
message to the UI process telling a new icon has been received.
- 1:57 AM Changeset in webkit [129741] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip fast/dom/Geolocation to make LayoutTests faster
https://bugs.webkit.org/show_bug.cgi?id=97765
Unreviewed EFL gardening.
Skip fast/dom/Geolocation for EFL port instead of marking
them with "Failure" expectation. This makes running
LayoutTests much faster.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
- platform/efl/TestExpectations:
- 1:36 AM Changeset in webkit [129740] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip http/tests/security/xss-eval.html again.
Fix was re-landed in r129712.
- platform/efl/TestExpectations:
- 1:22 AM Changeset in webkit [129739] by
-
- 3 edits in trunk/Source/WebCore
[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
https://bugs.webkit.org/show_bug.cgi?id=97756
Reviewed by Kent Tamura.
This patch changes class hierarchy of BaseMultipleFieldsDateAndTimeInputType
to inherit from DateTimeEditElement::EditControlOwner rather than
containing an instance of DateTimeEditElement::EditControlOwner for
saving memory, although one pointer, and one memory fetch on using
HTMLInputElement.
Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.
No new tests. This patch doesn't change behavior.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp: DateTimeEditElement::EditControlOwner::DateTimeformatDateTimeFieldsState was removed. We no longer need to redirection. Each date/time input type classe implements it.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl): Moved from DateTimeEditControlOwnerImpl and removed reference of m_dateTimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Changed to pass BaseMultipleFieldsDateAndTimeInputType instead of DateTimeEditControlOwnerImpl.
- html/BaseMultipleFieldsDateAndTimeInputType.h: Changed base class to have DateTImeEditElement::EditControlOwner.
(BaseMultipleFieldsDateAndTimeInputType): Removed DateTimeEditControlOwnerImpl class and member variable m_dateTimeEditControlOwner.
- 1:17 AM Changeset in webkit [129738] by
-
- 13 edits3 adds in trunk
SuggestionPicker should support rtl
https://bugs.webkit.org/show_bug.cgi?id=97555
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Added tests for Arabic with datalist.
Source/WebCore:
Add support for rtl to SuggestionPicker. We add another parameter
because text direction for the calendar picker should depend on the UI
language but the text direction for suggestion picker should depend on
the input element style.
Test: platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype._layout):
- Resources/pagepopups/pickerCommon.css:
(.rtl): Added so we can change styles when in rtl mode.
- Resources/pagepopups/suggestionPicker.css:
(.suggestion-list-entry .label):
(.rtl .suggestion-list-entry .label): Change float direction to left.
- Resources/pagepopups/suggestionPicker.js:
(SuggestionPicker.prototype._layout):
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): Set isAnchorElementRTL to true if the input element is rtl.
- platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added isAnchorElementRTL.
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.txt: Added.
- platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html: Added.
- 1:13 AM Changeset in webkit [129737] by
-
- 2 edits in trunk/Source/WebCore
Follow-up to r129723 to once more allow parsing of scoped names in IDL files.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-09-27
Reviewed by Kentaro Hara.
This functionality was supported by the old IDL parser but was lost in the rewrite of the parser
in r129723. It is being reinstated to unbreak clients that currently depend on it, but will likely
be removed in the future once those clients have a chance to adopt an approach that more closely
follows the WebIDL syntax.
- bindings/scripts/IDLParser.pm:
(parseDefinition):
(parseInheritance):
(parseImplementsStatement):
(parseExtendedAttribute):
(parseExtendedAttribute2):
(parseExtendedAttributeRest2):
(parseExtendedAttributeRest3):
(parseScopedNameListNoComma):
(parseNonAnyType):
(parseExceptionList):
(parseDefinitionOld):
(parseScopedName):
(parseAbsoluteScopedName):
(parseRelativeScopedName):
(parseScopedNameParts):
(parseScopedNameList):
(parseScopedNames):
- 1:12 AM Changeset in webkit [129736] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Fix build with static JavaScriptCore library
- shell/CMakeLists.txt: Define STATICALLY_LINKED_WITH_JavaScriptCore if
JavaScriptCore_LIBRARY_TYPE is set to STATIC.
- 1:11 AM Changeset in webkit [129735] by
-
- 3 edits in trunk/LayoutTests
[EFL] fast/layers/video-layer.html needs rebaselining after r129687
https://bugs.webkit.org/show_bug.cgi?id=97764
Unreviewed EFL gardening.
Rebaseline fast/layers/video-layer.html due to r129687. The volume
button is no longer shown for that test.
Patch by Christophe Dumez <Christophe Dumez> on 2012-09-27
- platform/efl/fast/layers/video-layer-expected.png:
- platform/efl/fast/layers/video-layer-expected.txt:
- 12:57 AM Changeset in webkit [129734] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: expose debug memory instrumentation debug data through the protocol
https://bugs.webkit.org/show_bug.cgi?id=97683
Reviewed by Pavel Feldman.
Memory.getProcessMemoryDistribution command now returns number of instrumented
objects that were found and the number of the objects that were counted by
the instrumentation but were not actually allocated by the memory allocator.
These numbers are only added to the response if embedder provides access to the
set of all live heap objects. These numbers are intended to be used for testing
memory instrumentation.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::collectDomTreeInfo):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):
- inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
(WebCore::MemoryInstrumentationImpl::totalCountedObjects):
(WebCore::MemoryInstrumentationImpl::totalObjectsNotInAllocatedSet):
(MemoryInstrumentationImpl):
- 12:53 AM Changeset in webkit [129733] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
https://bugs.webkit.org/show_bug.cgi?id=97577
Reviewed by Andreas Kling.
RenderFlowThread methods contentLogicalWidthOfFirstRegion, contentLogicalHeightOfFirstRegion, contentLogicalLeftOfFirstRegion
were using code to get the first valid region associated with the flow. We can use RenderFlowThread::firstRegion() method instead.
No new tests as this is just refactoring of existing code, the change is covered by existing regions tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
- 12:30 AM Changeset in webkit [129732] by
-
- 2 edits in trunk
[WINCE] Enable JIT by default
- Source/cmake/OptionsWinCE.cmake:
- 12:25 AM Changeset in webkit [129731] by
-
- 2 edits in trunk/Source/WebCore
Build fix for !USE(ICU_UNICODE) after r129662.
Convert LChar to UChar so we can call the existing function until the
other TextBreakIterator implemenations provide an overload for LChar.
- platform/text/TextBreakIterator.cpp:
(WebCore):
(WebCore::acquireLineBreakIterator):
- 12:13 AM DOMInJavaScript edited by
- (diff)
- 12:13 AM DOMInJavaScript edited by
- (diff)
- 12:02 AM DOMInJavaScript edited by
- (diff)
- 12:02 AM DOMInJavaScript edited by
- (diff)
- 12:01 AM Changeset in webkit [129730] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] Allow denormal floats in ARM VFP
https://bugs.webkit.org/show_bug.cgi?id=97008
Patch by Cosmin Truta <ctruta@rim.com> on 2012-09-26
Reviewed by Filip Pizlo.
Reviewed internally by Yong Li.
Cleared the Flush-to-Zero flag in the ARM FPSCR register on QNX.
- wtf/ThreadingPthreads.cpp:
(WTF::enableIEEE754Denormal): Added.
(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):
