Timeline



Oct 19, 2012:

11:53 PM Changeset in webkit [131982] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

DFG should have some facility for recognizing redundant CheckArrays and Arrayifies
https://bugs.webkit.org/show_bug.cgi?id=99287

Reviewed by Mark Hahnenberg.

Adds reasoning about indexing type sets (i.e. ArrayModes) to AbstractValue, which
then enables us to fold away CheckArray's and Arrayify's that are redundant.

  • bytecode/ArrayProfile.cpp:

(JSC::arrayModesToString):
(JSC):

  • bytecode/ArrayProfile.h:

(JSC):
(JSC::mergeArrayModes):
(JSC::arrayModesAlreadyChecked):

  • bytecode/StructureSet.h:

(JSC::StructureSet::arrayModesFromStructures):
(StructureSet):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(AbstractValue):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterArrayModes):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
(JSC::DFG::AbstractValue::clobberArrayModes):
(JSC::DFG::AbstractValue::clobberArrayModesSlow):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::modeAlreadyChecked):

  • dfg/DFGArrayMode.h:

(JSC::DFG::arrayModesFor):
(DFG):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::arrayify):

11:29 PM Changeset in webkit [131981] by abarth@webkit.org
  • 34 edits in trunk/Source/WebCore

[V8] V8DOMWrapper should avoid using its document parameter (so we can remove it soon)
https://bugs.webkit.org/show_bug.cgi?id=99876

Reviewed by Kentaro Hara.

We want to remove the document parameter to instantiateV8Object. There
isn't always a Document available, so it doesn't make sense to pass it
as a parameter. We're just waiting for a V8 API change so we can still
construct Node wrappers quickly.

This patch removes a use of the document that snuck in. Rather than
passing the ScriptExecutionContext around, we get it from the
CreationContext of the prototype object (and only when we actually need
it).

  • Modules/notifications/NotificationCenter.cpp:
  • Modules/notifications/NotificationCenter.h:

(NotificationCenter):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateConstructorGetter):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8PerContextData.h:

(WebCore::V8PerContextData::createWrapperFromCache):
(WebCore::V8PerContextData::constructorForType):
(V8PerContextData):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::installPerContextPrototypeProperties):

11:28 PM Changeset in webkit [131980] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Change the title of inspector window when inspected page is changed
https://bugs.webkit.org/show_bug.cgi?id=99684

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Implement platformInspectedURLChanged() to change the title of inspector window
when inspected page is changed.

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged):

11:05 PM Changeset in webkit [131979] by mitz@apple.com
  • 7 edits
    3 adds in trunk

Add bundle API for hit-testing
https://bugs.webkit.org/show_bug.cgi?id=99907

Reviewed by Sam Weinig.

Source/WebKit2:

Test: TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCreateHitTestResult): Added this wrapper.

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::hitTest): Added. Hit tests at the given point, ignoring clipping.

  • WebProcess/WebPage/WebFrame.h:

(WebFrame): Declared hitTest.

Tools:

Added an API test for WKBundleFrameCreateHitTest().

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added InjectedBundleFrameHitTest.cpp,

InjectedBundleFrameHitTest_bundle.cpp, and link-with-title.html.

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Checks that the message contains the
title of the link in link-with-title.html.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Added.

(TestWebKitAPI::InjectedBundleFrameHitTestTest::InjectedBundleFrameHitTestTest):
(TestWebKitAPI::didFinishLoadForFrameCallback): Hit tests at (50, 50) and sends the link title
from the result back to the UI process.
(TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
(TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):

  • TestWebKitAPI/Tests/WebKit2/link-with-title.html: Added.
10:37 PM Changeset in webkit [131978] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Add API unit tests for scaling
https://bugs.webkit.org/show_bug.cgi?id=99451

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Add API unit test for ewk_view_scale_set()/get() APIs.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

10:09 PM Changeset in webkit [131977] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Baseline JIT should not inline array allocations, to make them easier to instrument
https://bugs.webkit.org/show_bug.cgi?id=99905

Reviewed by Mark Hahnenberg.

This will make it easier to instrument array allocations for the purposes of profiling.
It also allows us to kill off a bunch of code. And, this doesn't appear to hurt
performance at all. That's expected because these days any hot allocation will end up
in the DFG JIT, which does inline these allocations.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):

9:52 PM Changeset in webkit [131976] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Modify ewk_view_scale_set to public API
https://bugs.webkit.org/show_bug.cgi?id=99902

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Modify ewk_view_scale_set to public API.

  • UIProcess/API/efl/ewk_view.h:
9:09 PM Changeset in webkit [131975] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

Race condition in WebProcessProxy::handleGetPlugins().
<http://webkit.org/b/99903>
<rdar://problem/12541471>

Reviewed by Anders Carlsson.

Scope the Vector<PluginModuleInfo> so that all the destructors are guaranteed
to have run when sendDidGetPlugins() executes on the main thread.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::handleGetPlugins):

7:51 PM Changeset in webkit [131974] by fmalita@chromium.org
  • 12 edits
    3 adds in trunk

Incorrect pattern scaling
https://bugs.webkit.org/show_bug.cgi?id=99870

Reviewed by Dirk Schulze.

Source/WebCore:

The pattern space transform scale should reflect the tile_size(user space)
to tile_image_size ratio, instead of tile_size to absolute_tile_size.

Test: svg/custom/pattern-scaling.svg

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

LayoutTests:

  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/pattern-scaling-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • svg/custom/pattern-scaling.svg: Added.
7:33 PM Changeset in webkit [131973] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix some of the regression cause by the non-local variable reworking
https://bugs.webkit.org/show_bug.cgi?id=99896

Reviewed by Filip Pizlo.

The non0local variable reworking led to some of the optimisations performed by
the bytecode generator being dropped. This in turn put more pressure on the DFG
optimisations. This exposed a short coming in our double speculation propogation.
Now we try to distinguish between places where we should SpecDoubleReal vs generic
SpecDouble.

  • dfg/DFGPredictionPropagationPhase.cpp:

(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPredictions):
(JSC::DFG::PredictionPropagationPhase::propagate):

6:49 PM Changeset in webkit [131972] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

RenderFlexibleBox::preferredMainAxisContentExtentForChild can return a negative value
https://bugs.webkit.org/show_bug.cgi?id=97827

Reviewed by Ojan Vafai.

I'm pretty sure this isn't possible (logicalHeight and maxPreferredLogicalWidth should always include
border and padding), so just add an assert.

No new tests, the assert is for code clarity.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

6:43 PM Changeset in webkit [131971] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Replace calls to updateLogicalHeight with calls to computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=99883

Reviewed by Ojan Vafai.

In RenderBox and RenderBlock, switch to using computeLogicalHeight instead of
saving the old height, calling update logical height, then restoring the old height.

No new tests, this is just a refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths): Simple replace.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight): Adjust for content height.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Adjust for content height.
(WebCore::RenderBox::availableLogicalHeightUsing): Adjust for content height.

6:16 PM Changeset in webkit [131970] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html
failing on Chromium.

  • platform/chromium/TestExpectations:
6:07 PM Changeset in webkit [131969] by commit-queue@webkit.org
  • 15 edits
    31 adds in trunk

Implement setRangeText() on text controls
https://bugs.webkit.org/show_bug.cgi?id=91907

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-19
Reviewed by Kent Tamura.

Source/WebCore:

setRangeText() replaces a range of text with some other text, and
adjusts the existing selection according to its parameters.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-textarea/input-setrangetext

Tests: fast/forms/color/color-setrangetext.html

fast/forms/date/date-setrangetext.html
fast/forms/datetime/datetime-setrangetext.html
fast/forms/datetimelocal/datetimelocal-setrangetext.html
fast/forms/file/file-setrangetext.html
fast/forms/hidden/hidden-setrangetext.html
fast/forms/image/image-setrangetext.html
fast/forms/month/month-setrangetext.html
fast/forms/number/number-setrangetext.html
fast/forms/range/range-setrangetext.html
fast/forms/search/search-setrangetext.html
fast/forms/setrangetext.html
fast/forms/textarea/textarea-setrangetext.html
fast/forms/time/time-setrangetext.html
fast/forms/week/week-setrangetext.html

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

The GObject generator doesn't support function overloads, so skip the
version of setRangeText() that has only one argument, its behavior
can be emulated with the four-argument version.

  • html/InputType.cpp:

(WebCore::InputType::supportsSelectionAPI):
(WebCore):

  • html/InputType.h:

(InputType):

Add supportsSelectionAPI() which indicates whether the various
selection api functions like setRangeText, setSelectionRange, etc.
are supported by this input element.

  • html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::supportsSelectionAPI):
(WebCore):

  • html/BaseTextInputType.h:

(BaseTextInputType):

Text-based input types support the selection APIs.

  • html/EmailInputType.cpp:

(WebCore::EmailInputType::supportsSelectionAPI):
(WebCore):

  • html/EmailInputType.h:

(EmailInputType):

Email inputs don't support the selection APIs.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setRangeText):

  • html/HTMLInputElement.h:

(HTMLInputElement):

Add a setRangeText override which checks if it should apply to the
input type, and calls the actual implementation on the parent class.

  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setRangeText):

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

setRangeText implementation.

LayoutTests:

  • fast/forms/color/color-setrangetext-expected.txt: Added.
  • fast/forms/color/color-setrangetext.html: Added.
  • fast/forms/date/date-setrangetext-expected.txt: Added.
  • fast/forms/date/date-setrangetext.html: Added.
  • fast/forms/datetime/datetime-setrangetext-expected.txt: Added.
  • fast/forms/datetime/datetime-setrangetext.html: Added.
  • fast/forms/datetimelocal/datetimelocal-setrangetext-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-setrangetext.html: Added.
  • fast/forms/file/file-setrangetext-expected.txt: Added.
  • fast/forms/file/file-setrangetext.html: Added.
  • fast/forms/hidden/hidden-setrangetext-expected.txt: Added.
  • fast/forms/hidden/hidden-setrangetext.html: Added.
  • fast/forms/image/image-setrangetext-expected.txt: Added.
  • fast/forms/image/image-setrangetext.html: Added.
  • fast/forms/month/month-setrangetext-expected.txt: Added.
  • fast/forms/month/month-setrangetext.html: Added.
  • fast/forms/number/number-setrangetext-expected.txt: Added.
  • fast/forms/number/number-setrangetext.html: Added.
  • fast/forms/range/range-setrangetext-expected.txt: Added.
  • fast/forms/range/range-setrangetext.html: Added.
  • fast/forms/resources/common-setrangetext.js: Added.

(runTestsShouldPass):
(runTestsShouldFail):

  • fast/forms/search/search-setrangetext-expected.txt: Added.
  • fast/forms/search/search-setrangetext.html: Added.
  • fast/forms/setrangetext-expected.txt: Added.
  • fast/forms/setrangetext.html: Added.
  • fast/forms/textarea/textarea-setrangetext-expected.txt: Added.
  • fast/forms/textarea/textarea-setrangetext.html: Added.
  • fast/forms/time/time-setrangetext-expected.txt: Added.
  • fast/forms/time/time-setrangetext.html: Added.
  • fast/forms/week/week-setrangetext-expected.txt: Added.
  • fast/forms/week/week-setrangetext.html: Added.
6:02 PM Changeset in webkit [131968] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro in StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=99782

Reviewed by Sam Weinig.

Removes last usage of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro, so that in future there will be no temptation
to use it instead of adding a line to StyleBuilder.
Also removes redundant checks for inital and inherit (HANDLE_INHERIT_AND_INTIAL already returns in those cases).
I don't want to move this code into StyleBuilder until the FIXME that is already there is fixed.

Covered by many existing writing mode tests (eg. fast/html/details-writing-mode.html)

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::applyProperty):

5:55 PM Changeset in webkit [131967] by jsbell@chromium.org
  • 6 edits in trunk

IndexedDB: Hidden indexing events are visible to script via bubbling/capture
https://bugs.webkit.org/show_bug.cgi?id=96566

Reviewed by Tony Chang.

Source/WebCore:

Stop propagation of error events fired at internal indexing requests as a result of
aborting, as they should not be visible to scripts.

Test: storage/indexeddb/index-population.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(WebCore::IDBRequest::preventPropagation):
(IDBRequest):

LayoutTests:

Listen for unexpected events in both capture and bubble phases.

  • storage/indexeddb/resources/index-population.js:

(deleteSuccess):
(doSetVersion1):
(setVersion2):

5:36 PM Changeset in webkit [131966] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove .get() calls in assertions as suggested by Darin Adler.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::appendSublayer):
(PlatformCALayer::insertSublayer):
(PlatformCALayer::replaceSublayer):

5:19 PM Changeset in webkit [131965] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Double-tap defaults to zoom (should only do this on Android)
https://bugs.webkit.org/show_bug.cgi?id=99600

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-10-19
Reviewed by Adam Barth.

Adds a web setting for enabling DoubleTapToZoom on a doubleTap gesture.
This gesture was just needed for mobile, and the patch that implemented it caused regressions on other platforms.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDoubleTapToZoomEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebFrameTest.cpp:
5:15 PM Changeset in webkit [131964] by Simon Fraser
  • 4 edits
    4 adds in trunk

Source/WebCore: Fix a hang when combining tile cache layers with preserve-3d or reflections
https://bugs.webkit.org/show_bug.cgi?id=99890
<rdar://problem/12539560>

Reviewed by Dean Jackson.

The new tile cache code added an updateSublayers() call when switching to/from
tiled layers. This confused later sublayer rebuilding, causing us to attempt to
add a layer as a child of itself, causing a hang in CA.

Fix by removing all the explicit calls to updateFoo when updating the structural
layer and switching to/from tiled layers. Instead, we set dirty flags, and rely
on the fact that these flag-dirtying functions get called before the later functions
that process those dirty flags. This is assured by some reordering of the update
function calls.

A final wrinkle is that ensureStructuralLayer() can change the layer that our
parent GraphicsLayer put in its sublayer list. Rather than diddle with that sublayer
list directly like we used to, just call noteSublayersChanged() on the parent, and have
commitLayerChangesAfterSublayers() check the ChildrenChanged and do a second update
of sublayers if necessary (we clear the flag in commitLayerChangesBeforeSublayers(), so
only do this work if a sublayer requested it).

Tests: compositing/tiling/preserve3d-tiled.html

compositing/tiling/reflected-tiled.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::appendSublayer): Add assertion about adding a layer to itself.
(PlatformCALayer::insertSublayer): Ditto.
(PlatformCALayer::replaceSublayer): Ditto.

LayoutTests: Fix a hang when combining tile cache layers with preserve-3d or reflections
https://bugs.webkit.org/show_bug.cgi?id=99890

Reviewed by Dean Jackson.

Tests that combine tiled layers with preserve-3d and reflections.

  • compositing/tiling/preserve3d-tiled-expected.txt: Added.
  • compositing/tiling/preserve3d-tiled.html: Added.
  • compositing/tiling/reflected-tiled-expected.txt: Added.
  • compositing/tiling/reflected-tiled.html: Added.
5:00 PM Changeset in webkit [131963] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

WebProcess should only connect to the NetworkProcess if NetworkProcess is enabled
https://bugs.webkit.org/show_bug.cgi?id=99885

Reviewed by Alexey Proskuryakov.

WebContext should tell each WebProcess it creates whether NetworkProcess use is enabled.

Add a WebProcess initialization flag for whether or not NetworkProcess use is enabled:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

Include that info in the initialization parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

Store whether or not NetworkProcess use is enabled, and only connect to the NetworkProcess if appropriate:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensureNetworkProcessConnection):

  • WebProcess/WebProcess.h:
4:57 PM Changeset in webkit [131962] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r131944.
http://trac.webkit.org/changeset/131944
https://bugs.webkit.org/show_bug.cgi?id=99891

On second thoughts, not such a great idea (Requested by jamesr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-19

Source/Platform:

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):

Source/WebKit/chromium:

  • public/WebView.h:

(WebKit):
(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createNewWindow):

4:40 PM Changeset in webkit [131961] by eae@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/platform/chromium/virtual/deferred: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium/TestExpectations:
4:37 PM Changeset in webkit [131960] by eae@chromium.org
  • 1 edit
    4 adds
    24 deletes in trunk/LayoutTests

Convert fast/innerHTML from pixel to ref tests
https://bugs.webkit.org/show_bug.cgi?id=99875

Reviewed by Dirk Pranke.

  • fast/innerHTML/001-expected.html: Added.
  • fast/innerHTML/002-expected.html: Added.
  • fast/innerHTML/003-expected.html: Added.
  • fast/innerHTML/006-expected.html: Added.
  • platform/chromium-linux/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium/fast/innerHTML/006-expected.txt: Removed.
  • platform/efl/fast/innerHTML/001-expected.png: Removed.
  • platform/efl/fast/innerHTML/001-expected.txt: Removed.
  • platform/efl/fast/innerHTML/002-expected.png: Removed.
  • platform/efl/fast/innerHTML/002-expected.txt: Removed.
  • platform/efl/fast/innerHTML/003-expected.png: Removed.
  • platform/efl/fast/innerHTML/003-expected.txt: Removed.
  • platform/efl/fast/innerHTML/006-expected.png: Removed.
  • platform/efl/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/001-expected.png: Removed.
  • platform/gtk/fast/innerHTML/001-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/002-expected.png: Removed.
  • platform/gtk/fast/innerHTML/002-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/003-expected.png: Removed.
  • platform/gtk/fast/innerHTML/003-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/006-expected.png: Removed.
  • platform/gtk/fast/innerHTML/006-expected.txt: Removed.
  • platform/mac/fast/innerHTML/001-expected.png: Removed.
  • platform/mac/fast/innerHTML/001-expected.txt: Removed.
  • platform/mac/fast/innerHTML/002-expected.png: Removed.
  • platform/mac/fast/innerHTML/002-expected.txt: Removed.
  • platform/mac/fast/innerHTML/003-expected.png: Removed.
  • platform/mac/fast/innerHTML/003-expected.txt: Removed.
  • platform/mac/fast/innerHTML/006-expected.png: Removed.
  • platform/mac/fast/innerHTML/006-expected.txt: Removed.
  • platform/qt/fast/innerHTML/001-expected.png: Removed.
  • platform/qt/fast/innerHTML/001-expected.txt: Removed.
  • platform/qt/fast/innerHTML/002-expected.png: Removed.
  • platform/qt/fast/innerHTML/002-expected.txt: Removed.
  • platform/qt/fast/innerHTML/003-expected.png: Removed.
  • platform/qt/fast/innerHTML/003-expected.txt: Removed.
  • platform/qt/fast/innerHTML/006-expected.png: Removed.
  • platform/qt/fast/innerHTML/006-expected.txt: Removed.
4:28 PM Changeset in webkit [131959] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch

Merge <rdar://problem/12523419>.

4:26 PM Changeset in webkit [131958] by beidson@apple.com
  • 18 edits
    7 copies
    2 adds in trunk/Source/WebKit2

Add infrastructure for NetworkProcess management
https://bugs.webkit.org/show_bug.cgi?id=99817

Reviewed by Alexey Proskuryakov.

Add support for the WebProcess itself requesting a connection to the default NetworkProcess.

Add proper handling of crashes so any of the Web/Network/UI processes crash the others take appropriate action.

Project file stuff and general messaging changes:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction): Add some new required templates.

WebContext now does much less of this stuff:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

  • UIProcess/WebContext.h:

(WebContext):

UIProcess now has a process manager to handle most of this:

  • UIProcess/Network/NetworkProcessManager.cpp:

(WebKit):
(WebKit::NetworkProcessManager::shared):
(WebKit::NetworkProcessManager::NetworkProcessManager):
(WebKit::NetworkProcessManager::getNetworkProcessConnection):
(WebKit::NetworkProcessManager::ensureNetworkProcess):
(WebKit::NetworkProcessManager::removeNetworkProcessProxy):

  • UIProcess/Network/NetworkProcessManager.h:

(WebKit):
(NetworkProcessManager):

Flesh out the NetworkProcessProxy to handle creating these connections between Network and Web Processes:

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::create):
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
(WebKit):
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:

(WebKit):
(NetworkProcessProxy):

  • UIProcess/Network/NetworkProcessProxy.messages.in:

Add a class representing a connection from a NetworkProcess to a particular WebProcess:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp: Added.

(WebKit):
(WebKit::NetworkConnectionToWebProcess::create):
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveNetworkConnectionToWebProcessMessage):

  • NetworkProcess/NetworkConnectionToWebProcess.h:

(WebKit):
(NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::connection):

  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Add the ability for a NetworkProcess to create a connection for a different process, which is used on behalf of WebProcesses for now:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::removeNetworkConnectionToWebProcess):
(WebKit):
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

  • NetworkProcess/NetworkProcess.h:

(WebKit):
(NetworkProcess):

  • NetworkProcess/NetworkProcess.messages.in:

Forward on the message that a WebProcess wants a connection to a NetworkProcess:

  • UIProcess/WebProcessProxy.cpp:

(WebKit):
(WebKit::WebProcessProxy::getNetworkProcessConnection):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:

Add a class representing the WebProcesses connection to the NetworkProcess:

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit):
(WebKit::NetworkProcessConnection::NetworkProcessConnection):
(WebKit::NetworkProcessConnection::~NetworkProcessConnection):
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::didReceiveInvalidMessage):

  • WebProcess/Network/NetworkProcessConnection.h:

(WebKit):
(NetworkProcessConnection):
(WebKit::NetworkProcessConnection::create):
(WebKit::NetworkProcessConnection::connection):

Have the WebProcess make sure it has a connection to the NetworkProcess, even though it currently does nothing with it:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit):
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::networkProcessConnectionClosed):
(WebKit::WebProcess::networkProcessCrashed):

  • WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

  • WebProcess/WebProcess.messages.in:
4:24 PM Changeset in webkit [131957] by Chris Fleizach
  • 13 edits in trunk

AX: aria-hidden=false does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=98787

Reviewed by Beth Dakin.

Source/WebCore:

ARIA requires that aria-hidden=false override an element's native visibility and include that
node in the AX hierarchy.

To accomplish this we have to allow invisible items to be included, as well as items that
have no renderers associated with them.

Test: accessibility/aria-hidden-negates-no-visibility.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore):

(WebCore::AccessibilityNodeObject::boundingBoxRect):

(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::addChild):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::textUnderElement):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::addChild):
(WebCore::AccessibilityObject::insertChild):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/aria-hidden-negates-no-visibility.html: Added.
  • platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
4:23 PM Changeset in webkit [131956] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identifiers
https://bugs.webkit.org/show_bug.cgi?id=99855

Reviewed by Filip Pizlo.

Added makeIdentifier helpers that will always make an 8 bit Identifier or make an
Identifier that is the same size as the template parameter. Used the first in the fast
path when looking for a JS identifier and the second when scanning regular expressions.

  • parser/Lexer.cpp:

(JSC::::scanRegExp):

  • parser/Lexer.h:

(Lexer):
(JSC::::makeIdentifierSameType):
(JSC::::makeLCharIdentifier):
(JSC::::lexExpectIdentifier):

4:21 PM Changeset in webkit [131955] by msaboff@apple.com
  • 8 edits in trunk/Source

Add String version of visitedLinkHash() to properly handle 8-bit URL Strings.
https://bugs.webkit.org/show_bug.cgi?id=99735

Reviewed by Filip Pizlo.

Added String version of visitedLinkHash(). Made speculative addition of visitedLinkHash()
to chromium platform version of LinkHashChromium.cpp.
Changed calls in the form of visitedLinkHash(string.characters(), string.length()) to use the
new form.

No changes to functionality, so no new tests.

  • WebCore.exp.in:
  • loader/HistoryController.cpp:

(WebCore::addVisitedLink):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addVisitedLink):

  • platform/LinkHash.cpp:

(WebCore::visitedLinkHashInline):
(WebCore::visitedLinkHash):

  • platform/LinkHash.h:
  • platform/chromium/LinkHashChromium.cpp:

(WebCore::visitedLinkHash):

4:19 PM Changeset in webkit [131954] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

String(CFStringRef) should try to converting to an 8 bit string before converting to 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=99794

Reviewed by Filip Pizlo.

Try getting a Latin1 byte string before getting a UTF16 (UChar*) string.

No new test, added 8 bit path.

  • platform/text/cf/StringCF.cpp:

(WTF::String::String):

4:13 PM Changeset in webkit [131953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Page should be removed from the cache right after restore was called.
https://bugs.webkit.org/show_bug.cgi?id=99737

Patch by Dima Gorbik <dgorbik@apple.com> on 2012-10-19
Reviewed by Brady Eidson.

The pageCache was inconsistent after the restoration for a period of time because the cachedFrame is being nulled,
but the page is still in the Cache. Now the page is being removed from the cache right after the restoration.
This issue was spotted in a custom built application using WebKit and unfortunately there is no way to test this
behavior in LayoutTests. All the current tests that exercise the page cache do pass.

No new tests.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

3:54 PM Changeset in webkit [131952] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL] getUniformLocation fails for uniform array name without array brackets
https://bugs.webkit.org/show_bug.cgi?id=99854

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-19
Reviewed by Dean Jackson.

Before this patch, gl.getUniformLocation(program, "array[0]") would return the array
location, but gl.getUniformLocation(program, "array") would not. Now, the latter also
returns the array location.

In the process of adding a check to the following Khronos WebGL conformance test:
conformance/glsl/misc/glsl-long-variable-names.html

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo):

Before, we used to check that the symbol size was greater than one to determine that the
symbol was an array. However, this doesn't identify arrays of length one. Now, we check
if the symbol name ends in "[0]", since ANGLE appends this suffix to array symbol
names.
If the symbol is an array, we strip off the "[0]" and add a symbol with just the base
name. We set the isArray flag on the symbol, so we don't lose the information that it is
an array.
Then, we create symbols for each array element like before. However, instead of
replacing the "0" in array[0]" with each index, we take the base name "array" and
append array brackets containing each index (e.g. "array" + "[7]").

  • platform/graphics/ANGLEWebKitBridge.h:

(ANGLEShaderSymbol):

Add isArray boolean to ANGLEShaderSymbol. Since array symbols don't end in "[0]"
anymore, this is the only way to identify arrays.

3:25 PM Changeset in webkit [131951] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Convert input style to int64_t
https://bugs.webkit.org/show_bug.cgi?id=99848

Reviewed by Yong Li.

PR 227381.

Switch input style mask to int64_t to match the the updated definition.

Reviewed Internally by Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

  • WebKitSupport/InputHandler.h:

(InputHandler):

3:24 PM Changeset in webkit [131950] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] when building a shared library component build, we must not depend on WebCore

Unreviewed build fix.

  • WebKit.gyp:
3:11 PM Changeset in webkit [131949] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix lint error in Qt TestExpectations file.

  • platform/qt-5.0-wk1/TestExpectations: Remove duplicate skip entry.
3:09 PM Changeset in webkit [131948] by eae@chromium.org
  • 1 edit
    31 adds in trunk/LayoutTests

Unreviewed gardening, rebaselining deferred image tests for r131928.

  • platform/chromium-mac-lion/platform/chromium/virtual/deferred: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/animated-gif-with-offsets-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/animated-gif-with-offsets-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/png-with-color-profile-expected.png: Added.
2:59 PM Changeset in webkit [131947] by Csaba Osztrogonác
  • 13 edits
    2 deletes in trunk

Unreviewed, rolling out r131915.
http://trac.webkit.org/changeset/131915
https://bugs.webkit.org/show_bug.cgi?id=98787

It broke the build on platforms with \!HAVE(ACCESSIBILITY)

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::nodeIsTextControl):

  • accessibility/AXObjectCache.h:

(WebCore):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::elementRect):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::textUnderElement):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::textIteratorBehaviorForTextRange):
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/aria-hidden-negates-no-visibility.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Removed.
2:55 PM Changeset in webkit [131946] by tony@chromium.org
  • 21 edits in trunk

Unreviewed, rolling out r131936.
http://trac.webkit.org/changeset/131936
https://bugs.webkit.org/show_bug.cgi?id=99717

Broke the clang build

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::requestAttachWindow):
(WebCore):
(WebCore::InspectorFrontendClientLocal::requestDetachWindow):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestAttachWindow):
(WebCore):
(WebCore::InspectorFrontendHost::requestDetachWindow):
(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DockController.js:

(WebInspector.DockController):
(WebInspector.DockController.prototype.setDocked):
(WebInspector.DockController.prototype._innerSetDocked.set if):
(WebInspector.DockController.prototype._innerSetDocked):
(WebInspector.DockController.prototype._updateUI.get states):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):
(InspectorFrontendAPI.setDockSide):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

  • inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.requestAttachWindow):
(InspectorFrontendHostAPI.prototype.requestDetachWindow):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::requestDockWindow):
(WebKit::WebDevToolsFrontendClient::requestUndockWindow):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestAttachWindow):
(WebKit):
(WebKit::InspectorFrontendClientImpl::requestDetachWindow):
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
2:36 PM Changeset in webkit [131945] by commit-queue@webkit.org
  • 21 edits
    2 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r131931.
http://trac.webkit.org/changeset/131931
https://bugs.webkit.org/show_bug.cgi?id=99871

Broke Safari exensions (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-19

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(MessageEncoder):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::dispatchMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • Platform/CoreIPC/StringReference.cpp: Removed.
  • Platform/CoreIPC/StringReference.h: Removed.
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
2:30 PM Changeset in webkit [131944] by aelias@chromium.org
  • 9 edits in trunk

[chromium] API to pass impl thread via WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=99863

Reviewed by James Robinson.

This adds an API to pass the compositor impl thread via WebView and
WebLayerTreeView. This is currently a no-op change, but in the future
this codepath will supercede WebCompositor. The goal is to avoid statics
in compositor initialization.

Source/Platform:

  • chromium/public/WebCompositorSupport.h:

(WebKit::WebCompositorSupport::createLayerTreeView):
(WebCompositorSupport):

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(WebLayerTreeView):

Source/WebKit/chromium:

  • public/WebView.h:

(WebKit):
(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setCompositorImplThread):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createNewWindow):

2:04 PM Changeset in webkit [131943] by eae@chromium.org
  • 1 edit
    21 adds in trunk/LayoutTests

Unreviewed gardening, rebaselining deferred image tests for r131928.

  • platform/chromium-mac/platform/chromium/virtual/deferred: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/animated-gif-with-offsets-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/favicon-as-image-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/image-map-anchor-children-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
2:02 PM Changeset in webkit [131942] by mrobinson@webkit.org
  • 4 edits in trunk

REGRESSION (r130699): 5 various fast/ tests started failing
https://bugs.webkit.org/show_bug.cgi?id=98729

Reviewed by Xan Lopez.

Source/WebCore:

Do not try to remove the URL fragment for data URLs. This will likely
just corrupt the URL.

No new tests. This unskips some previously failing tests.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::urlStringForSoup): Do nothing for data URLs.

LayoutTests:

Unskip some tests which are now passing.

  • platform/gtk/TestExpectations:
1:47 PM Changeset in webkit [131941] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[Cairo][WTR] Implement the painting of repaint rectangles.
https://bugs.webkit.org/show_bug.cgi?id=99839

Reviewed by Martin Robinson.

Implement the required code to paint the gray overlay with
transparent regions for the repaint rectangles, as other ports
already do and as is already done in most WK1 ports.

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

1:43 PM Changeset in webkit [131940] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Use tile caches in place of CATiledLayer
https://bugs.webkit.org/show_bug.cgi?id=99806
<rdar://problem/6474145>

Reviewed by Tim Horton.

Have GraphicsLayerCA use TileCaches instead of CATiledLayer now for
layers that exceed the 2000px size threshold.

  • platform/graphics/TiledBacking.h:

(TiledBacking): Have normal getter and setter for the visible rect.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): We need
to pass in an old visibleRect to commitLayerChangesBeforeSublayers(). Just use
our current visible rect, which result in no tile area work.
(WebCore::GraphicsLayerCA::computeVisibleRect): Make this const and have it
return the rect, for clarity.
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Keep track of the old
visible rect, and use the change flags mechanism to ensure that we recompute
tile areas later.
When calling commitLayerChangesBeforeSublayers() on the mask layer, just pass
its own visible rect as the old visible rect.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Pass in the
oldVisibleRect so that updateVisibleRect() can use this to see how the
visibleRect is changing.
(WebCore::GraphicsLayerCA::adjustTiledLayerVisibleRect): This member function
compares the old and new visible rects, and extends the tile coverage area
in directions where more content is being exposed. It takes care to avoid
"jitter" in the visible rect deltas causing edge tiles to get created then
destroyed by keeping any extra padding that already exists in a direction
where more content is being exposed.
(WebCore::GraphicsLayerCA::updateVisibleRect): Call adjustTiledLayerVisibleRect()
and use the result to update the TiledBacking's visibleRect.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Create layers of type
LayerTypeTileCacheLayer instead of LayerTypeWebTiledLayer. Because tile
cache layers involve adding an extra layer to the hierarchy (the tile container),
we call updateSublayerList() when changing layer type.

  • platform/graphics/ca/GraphicsLayerCA.h: New m_sizeAtLastVisibleRectUpdate member

that is used to prevent the adjustTiledLayerVisibleRect() logic being confused by
size changes.
(WebCore::GraphicsLayerCA::visibleRect):

  • platform/graphics/ca/mac/TileCache.h: Have normal getter and setter for the visible rect.
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setVisibleRect): Renamed to setVisibleRect().

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges): Avoid doing work
for pages in the page cache, for which the root layer is unattached.
(WebCore::RenderLayerCompositor::frameViewDidScroll): visibleRectChanged() was renamed
to setVisibleRect().

1:33 PM Changeset in webkit [131939] by Beth Dakin
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=99768
We should limit the tile cache coverage when a page can't take
advantage of fast tile scrolling anyway

Reviewed by Simon Fraser.

When sites can't use fast-scrolling, there is no need to inflate the
tile cache. In fact, we get a performance boost by keeping it small
on painting-intensive sites.

Instead of just looking a whether or not the FrameView
canHaveScrollbar(), consult
shouldUpdateScrollLayerPositionOnMainThread().

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Expose shouldUpdateScrollLayerPositionOnMainThread().

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionOnMainThread):
(WebCore):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

Bug fix. Should be bitwise and.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):

1:09 PM Changeset in webkit [131938] by mark.lam@apple.com
  • 53 edits
    2 adds in trunk/Source

Added WTF::StackStats mechanism.
https://bugs.webkit.org/show_bug.cgi?id=99805.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added StackStats checkpoints and probes.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::append):
(JSC::visitChildren):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • parser/Parser.h:

(JSC::Parser::canRecurse):

  • runtime/StringRecursionChecker.h:

(StringRecursionChecker):

Source/WebCore:

Added StackStats probes in layout methods.

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::layout):

  • rendering/RenderDialog.cpp:

(WebCore::RenderDialog::layout):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::layout):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::layout):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::layout):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::layout):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::layout):

  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::layout):

  • rendering/RenderObject.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layout):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):

  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::layout):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutSpecialExcludedChild):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::layout):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::layout):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::layout):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::layout):

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::layout):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::layout):

  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::layout):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::layout):

  • rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::layout):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

Source/WTF:

Disabled by default. Should have no performance and memory cost when
disabled. To enable, #define ENABLE_STACK_STATS 1 in StackStats.h.
The output is currently hardcoded to be dumped in /tmp/stack-stats.log,
and is in the form of stack sample events. By default, it only logs
a sample event when a new high watermark value is encountered.

Also renamed StackBounds::recursiveCheck() to isSafeToRecurse().

  • WTF.xcodeproj/project.pbxproj:
  • wtf/StackBounds.h:

(StackBounds):
(WTF::StackBounds::size):
(WTF::StackBounds::isSafeToRecurse):

  • wtf/StackStats.cpp: Added.

(WTF):
(WTF::StackStats::initialize):
(WTF::StackStats::PerThreadStats::PerThreadStats):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::~LayoutCheckPoint):

  • wtf/StackStats.h: Added.

(WTF):
(StackStats):
(CheckPoint):
(WTF::StackStats::CheckPoint::CheckPoint):
(PerThreadStats):
(WTF::StackStats::PerThreadStats::PerThreadStats):
(LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::initialize):
(WTF::StackStats::probe):

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

  • wtf/WTFThreadData.h:

(WTFThreadData):
(WTF::WTFThreadData::stackStats):

1:09 PM Changeset in webkit [131937] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move all keyboard type calculations into InputHandler.
https://bugs.webkit.org/show_bug.cgi?id=99847

Reviewed by Yong Li.

PR 227381.

Move all keyboard type calculations into webkit and avoid passing type
information to the webview.

Reviewed Internally by Nima Ghanavatian.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputTypeToVKBType):
(WebKit):
(BlackBerry::WebKit::InputHandler::setElementFocused):

1:03 PM Changeset in webkit [131936] by pfeldman@chromium.org
  • 19 edits in trunk/Source

Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Otherwise, it is hard to manage these inter-dependent flags.

  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::requestSetDockSide):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DockController.js:

(WebInspector.DockController):
(WebInspector.DockController.prototype._updateUI.get sides):
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setAttachedWindow):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:
  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::requestSetDockSide):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

12:55 PM Changeset in webkit [131935] by eae@chromium.org
  • 3 edits
    2 adds
    4 deletes in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
12:46 PM Changeset in webkit [131934] by jsbell@chromium.org
  • 3 edits
    3 adds in trunk

[V8] IndexedDB: Crash when lazy-indexing Date keys
https://bugs.webkit.org/show_bug.cgi?id=99860

Reviewed by Adam Barth.

Source/WebCore:

Missing a scope/context needed when digging values out of Date objects
in an indexing callback.

Test: storage/indexeddb/lazy-index-types.html

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):

LayoutTests:

Add test for greedy/lazy indexing all different key types.

  • storage/indexeddb/lazy-index-types-expected.txt: Added.
  • storage/indexeddb/lazy-index-types.html: Added.
  • storage/indexeddb/resources/lazy-index-types.js: Added.

(test.request.onsuccess):
(test):
(onSuccess.request.onsuccess):
(onSuccess):
(onComplete):

12:45 PM Changeset in webkit [131933] by dino@apple.com
  • 15 edits
    4 adds in trunk

Shader translator needs option to clamp uniform array accesses in vertex shaders
https://bugs.webkit.org/show_bug.cgi?id=98977
https://code.google.com/p/angleproject/issues/detail?id=49

Reviewed by Alok Priyadarshi and Ken Russell.

Source/ThirdParty/ANGLE:

WebGL does not allow GLSL code to index a uniform array outside its bounds. Add a
flag to the ANGLE compiler to insert clamp statements around such indexing.
Since it is possible to access vec2/3/4 and mat2/3/4 components by array indexing,
they must be similarly clamped.

Unfortunately, it is currently not possible to always determine that the indexing is
operating on a uniform variable. For example, suppose we have "uniform mat4 a". ANGLE
is currently not able to tell us that the rvalue of "a[0]" is a uniform, just that
it has a size of 4. Therefore, the clamping is done on all indirect array indexing.

This will have a performance impact. Future enhancements may be able to determine
cases where the clamping is not necessary. Currently only direct indexing is skipped
(i.e. looking up a value using a constant index).

The clamp insertion is only performed on the GLSL output. Direct3D already guarantees
that out-of-bounds uniform array access returns a zero value.

  • ANGLE.xcodeproj/project.pbxproj:
  • Target.pri:
  • include/GLSLANG/ShaderLang.h: New compiler option.
  • src/compiler/ArrayBoundsClamper.cpp: Added.

(ArrayBoundsClamper::ArrayBoundsClamper):
(ArrayBoundsClamper::OutputClampingFunctionDefinition): Injects a clamping function for integers into GLSL source.
(ArrayBoundsClamper::MarkIndirectArrayBoundsForClamping): Examines the AST looking for non-direct array indexing.

  • src/compiler/ArrayBoundsClamper.h: Added.

(ArrayBoundsClamper):
(ArrayBoundsClamper::GetArrayBoundsClampDefinitionNeeded):
(ArrayBoundsClamper::SetArrayBoundsClampDefinitionNeeded): Marks the object as needing to output the clamping function.
(ArrayBoundsClamper::Cleanup): Resets the state so that subsequent runs start fresh.

  • src/compiler/Compiler.cpp:

(TCompiler::compile): Run the clamping code if the compile option was set.
(TCompiler::clearResults):
(TCompiler::getArrayBoundsClamper):

  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitBinary): If the expression has been flagged, insert an appropriate "clamp" statement.

  • src/compiler/ShHandle.h:

(TCompiler):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/intermOut.cpp:

(TType::getCompleteString): Add array size to intermediate tree output.

  • src/compiler/intermediate.h:

(TIntermBinary::setAddIndexClamp): New flag for indicating a binary expression needs clamping.
(TIntermBinary::getAddIndexClamp):
(TIntermBinary):

Source/WebCore:

WebGL forbids out-of-bounds array access in shaders. Rewrite any shaders to
ensure that non-direct array indexing is clamped to the bounds of the array.

Test: fast/canvas/webgl/array-bounds-clamping.html

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource): Pass new compiler option SH_CLAMP_INDIRECT_ARRAY_BOUNDS

LayoutTests:

  • fast/canvas/webgl/array-bounds-clamping-expected.txt: Added.
  • fast/canvas/webgl/array-bounds-clamping.html: Added.
  • platform/chromium/TestExpectations: Won't pass on Chromium until this patch is upstreamed.
12:34 PM Changeset in webkit [131932] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r131822): It made 500+ tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=99814

Reviewed by Filip Pizlo.

Call the correct macro in 32bit.

  • llint/LowLevelInterpreter.asm:
12:28 PM Changeset in webkit [131931] by andersca@apple.com
  • 21 edits
    1 copy
    1 add in trunk/Source/WebKit2

Don't use CStrings for message receiver names and message names
https://bugs.webkit.org/show_bug.cgi?id=99853

Reviewed by Andreas Kling.

Introduce StringReference which is similar to DataReference except it holds a pointer to + length of a char *
and can be created from a string literal. Use this in place of CString in MessageEncoder/MessageDecoder and
make MessageReceiverMap use a HashMap from StringReferences to MessageReceivers for global message receivers.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC::MessageDecoder::messageReceiverName):
(CoreIPC::MessageDecoder::messageName):
(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(CoreIPC):
(MessageEncoder):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::dispatchMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • Platform/CoreIPC/StringReference.cpp: Added.

(CoreIPC):
(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):
(CoreIPC::StringReference::Hash::hash):

  • Platform/CoreIPC/StringReference.h: Added.

(CoreIPC):
(StringReference):
(CoreIPC::StringReference::StringReference):
(CoreIPC::StringReference::isEmpty):
(CoreIPC::StringReference::size):
(CoreIPC::StringReference::data):
(CoreIPC::StringReference::operator==):
(Hash):
(CoreIPC::StringReference::Hash::equal):
(WTF):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
12:21 PM Changeset in webkit [131930] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Reduce memory footprint of canvas pattern object with deferred rendering
https://bugs.webkit.org/show_bug.cgi?id=99856

Patch by Justin Novosad <junov@chromium.org> on 2012-10-19
Reviewed by Stephen White.

Marking internal bitmap copy as immutable to prevent it from being
unnecessarily duplicated in skia by SkBitmapHeap.

No new tests: code path already well covered by existing layout tests
fast/canvas/canvas-pattern-*

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

12:18 PM Changeset in webkit [131929] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Maintain a list of active CSS stylesheets
https://bugs.webkit.org/show_bug.cgi?id=99843

Reviewed by Andreas Kling.

Currently we maintain a per-document list of stylesheets that matches what is returned by the StyleSheetList DOM API.
This list contains both CSS and XSLT stylesheets which internally have basically nothing in common. Maintaining
a list of active CSS stylesheets separately simplifies code in number of places.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::collectCSSOMWrappers):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):

  • dom/Document.cpp:

(WebCore::Document::setCompatibilityMode):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::filterEnabledCSSStyleSheets):
(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList):
(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets):

12:06 PM Changeset in webkit [131928] by hclam@chromium.org
  • 21 edits
    13 adds in trunk

[chromium] Implement deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=94240

Reviewed by Stephen White.

Source/WebCore:

Objectives:

To record image decoding operations during painting and to defer
decoding operations until rasterization.

Rationale:

This is a key feature that enables impl-side painting which requires
fast recording of drawing operations. The existing decode-on-draw
restricts that recording has to block on expensive decoding operations.
This change allows recording of image decoding operations during paint
time.

Design:

Image decoding happens when a BitmapImage is drawn into a
GraphicsContext. When per-tile painting is enabled GraphicsContext
is backed by SkCanvas in recording mode. This SkCanvas records drawing
and image decoding operations to minimize recording time.

An image decoding operation is recorded as a SkPixelRef object
implemented by LazyDecodingPixelRef. This object references raw encoded
data, regions to be decoded and scaling information.

When used in conjunction with per-tile painting this feature defers
image decoding until the SkCanvas referencing the image is rasterized.

Both recording and rasterization happen on the main thread.

Performance Impact:

This feature is enabled by WebKit::setDeferredImageDecodingEnabled()
and does not have an impact when disabled.

This feature is disabled by default.

Upcoming Changes:

  1. Implement a full-featured image cache in ImageDecodingStore.
  2. Allow rasterization and decoding on impl thread.

Classes Involved:

BitmapImage

BitmapImage is the entry point for deferred image decoding. When
drawing a BitmapImage into a GraphicsContext it makes a request to
create a NativeImageSkia. We substitute the content in NativeImageSkia
such that it is lazily decoded.

DeferredImageDecoder

This is the platform implementation of a image decoder for Chromium.
This is a bridge layer that either delegates calls to the actual
ImageDecoder or create a lazily-decoded SkBitmap and delegates calls
to ImageDecodingStore.

ImageDecodingStore

This object manages all encoded images. It keeps track of encoded
data and the corresponding ImageDecoder for doing actual decoding. It
is also responsible for generating lazily decoded SkBitmaps. This
SkBitmap contains a LazyDecodingPixelRef object which references to an
image entry in ImageDecodingStore.

ScaledImageFragment

A container for a scaled image fragment. In addition to bitmap pixels
it contains information about the ID of the image, scale and clipping.

ImageFrameGenerator

This object is responsible for generating decoded pixels. It is also
a container for encoded image data and corresponding image decoder.

LazyDecodingPixelRef

This object is embedded in a SkBitmap to enable lazy decoding. When
SkBitmap needs to access pixels LazyDecodingPixelRef is locked. It
contains information to locate an image and scaling info, these
information is submitted to ImageDecodingStore to access actual pixels.

Layout tests. There are about 80 tests in this virtual test suite
running this feature in this directory:

platform/chromium/virtual/deferred/fast/images

Unit tests. Added DeferredImageDecoderTest to verify deferred
image decoding behavior.

  • WebCore.gypi:
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::setData):

  • platform/graphics/ImageSource.h:

(WebCore):
(ImageSource):

  • platform/graphics/chromium/DeferredImageDecoder.cpp: Added.

(WebCore):
(WebCore::DeferredImageDecoder::DeferredImageDecoder):
(WebCore::DeferredImageDecoder::~DeferredImageDecoder):
(WebCore::DeferredImageDecoder::create):
(WebCore::DeferredImageDecoder::createForTesting):
(WebCore::DeferredImageDecoder::filenameExtension):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::setData):
(WebCore::DeferredImageDecoder::isSizeAvailable):
(WebCore::DeferredImageDecoder::size):
(WebCore::DeferredImageDecoder::frameSizeAtIndex):
(WebCore::DeferredImageDecoder::frameCount):
(WebCore::DeferredImageDecoder::repetitionCount):
(WebCore::DeferredImageDecoder::clearFrameBufferCache):
(WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):
(WebCore::DeferredImageDecoder::frameBytesAtIndex):

  • platform/graphics/chromium/DeferredImageDecoder.h: Added.

(WebCore):
(DeferredImageDecoder):

  • platform/graphics/chromium/ImageDecodingStore.cpp: Added.

(WebCore::ImageDecodingStore::ImageDecodingStore):
(WebCore):
(WebCore::ImageDecodingStore::~ImageDecodingStore):
(WebCore::ImageDecodingStore::instanceOnMainThread):
(WebCore::ImageDecodingStore::initializeOnMainThread):
(WebCore::ImageDecodingStore::shutdown):
(WebCore::ImageDecodingStore::isLazyDecoded):
(WebCore::ImageDecodingStore::createLazyDecodedSkBitmap):
(WebCore::ImageDecodingStore::resizeLazyDecodedSkBitmap):
(WebCore::ImageDecodingStore::setData):
(WebCore::ImageDecodingStore::lockPixels):
(WebCore::ImageDecodingStore::unlockPixels):
(WebCore::ImageDecodingStore::frameGeneratorBeingDestroyed):
(WebCore::ImageDecodingStore::calledOnValidThread):
(WebCore::ImageDecodingStore::lookupFrameCache):
(WebCore::ImageDecodingStore::deleteFrameCache):

  • platform/graphics/chromium/ImageDecodingStore.h: Added.

(WebCore):
(ImageDecodingStore):
(WebCore::ImageDecodingStore::create):

  • platform/graphics/chromium/ScaledImageFragment.cpp: Added.

(WebCore):
(WebCore::ScaledImageFragment::~ScaledImageFragment):
(WebCore::ScaledImageFragment::ScaledImageFragment):
(WebCore::ScaledImageFragment::isEqual):

  • platform/graphics/chromium/ScaledImageFragment.h: Added.

(WebCore):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::create):
(WebCore::ScaledImageFragment::bitmap):
(WebCore::ScaledImageFragment::isComplete):

  • platform/graphics/chromium/ImageFrameGenerator.cpp: Added.

(WebCore):
(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::~ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decoder):
(WebCore::ImageFrameGenerator::setData):

  • platform/graphics/chromium/ImageFrameGenerator.h: Added.

(WebCore):
(ImageFrameGenerator):
(WebCore::ImageFrameGenerator::create):
(WebCore::ImageFrameGenerator::size):
(WebCore::ImageFrameGenerator::imageId):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp: Added.

(WebCore):
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::~LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::isScaled):
(WebCore::LazyDecodingPixelRef::isClipped):
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
(WebCore::LazyDecodingPixelRef::onLockPixelsAreWritable):

  • platform/graphics/chromium/LazyDecodingPixelRef.h: Added.

(WebCore):
(LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::frameGenerator):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap):

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):

Source/WebKit/chromium:

Adding new unit tests for deferred image decoding.
These tests are defined in DeferredImageDecoderTest.cpp. They verify
image decoding happens only when SkPicture is rasterized for both
scaled and non-scaled cases.

Tests: DeferredImageDecoderTest.drawIntoSkPicture

DeferredImageDecoderTest.drawScaledIntoSkPicture

  • WebKit.gypi:
  • public/WebSettings.h:
  • src/WebKit.cpp:

(WebKit::shutdown):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • tests/DeferredImageDecoderTest.cpp: Added.

(WebCore):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::TearDown):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h: Added.

(WebCore):
(MockImageDecoder):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::filenameExtension):
(WebCore::MockImageDecoder::frameBufferAtIndex):
(WebCore::MockImageDecoder::frameBufferRequestCount):

Tools:

Add --enable-deferred-image-decoding to DRT.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setDeferredImageDecodingEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

Adding a virtual test suite for Chromium to test deferred image
decoding.

platform/chromium/virtual/deferred/fast/images will be tested with
--force-compositing --enable-per-tile-painting --enable-deferred-image-decoding.

  • platform/chromium/virtual/deferred/fast/images/README.txt: Added.
12:04 PM Changeset in webkit [131927] by hclam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll DEPS

Unreviewed DEPS roll.

  • DEPS:
12:00 PM Changeset in webkit [131926] by eae@chromium.org
  • 1 edit
    25 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-lion/compositing/shadows: Added.
  • platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-lion/css2.1: Added.
  • platform/chromium-mac-lion/css2.1/t0804-c5509-padn-l-03-f-g-expected.png: Added.
  • platform/chromium-mac-lion/css2.1/t090501-c414-flt-03-b-g-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
  • platform/chromium-mac-lion/fast/block/float/032-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-baseline-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/searchfield-heights-expected.png: Added.
  • platform/chromium-mac-lion/fast/inline-block: Added.
  • platform/chromium-mac-lion/fast/inline-block/contenteditable-baseline-expected.png: Added.
  • platform/chromium-mac-lion/platform: Added.
  • platform/chromium-mac-lion/platform/chromium: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug30692-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
11:53 AM Changeset in webkit [131925] by commit-queue@webkit.org
  • 41 edits in trunk

Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
https://bugs.webkit.org/show_bug.cgi?id=99804

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-19
Reviewed by Julien Chaffraix.

CSS3 text related properties will be implemented under this flag,
including text decoration, text-align-last, and text-justify.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new functionality, no new test.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):

  • css/CSSPrimitiveValueMappings.h:

(WebCore):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

(WebCore):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
11:44 AM Changeset in webkit [131924] by eae@chromium.org
  • 3 edits
    6 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
11:08 AM Changeset in webkit [131923] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page viewport aspect ratio not kept on navigating back
https://bugs.webkit.org/show_bug.cgi?id=99760

Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>.
Internally reviewed by Konrad Piascik.

PR: 222437
This is to fix the second issue on PR222437 that the viewport not kept
when navigating back from google after rotation to bloomberg.
We were trying to restore the history contents size and scale of
bloomberg which has virtual viewport. The scale would be recalculated
based on the new screen size. However, we would still use the current
contents size if it was greater than the history contents size in
FrameView::setContentsSize which made the contents seem to be scaled
too much.
Actually when we relayout the contents after rotation change, the
current contents size which is based on the virtual viewport has taken
the screen size into account. Shrinking the contents size will be
expensive. So we can ignore screen size based scale calculation here.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

10:59 AM FeatureFlags edited by pablof@motorola.com
Added CSS3_CONDITIONAL_RULES (diff)
10:53 AM Changeset in webkit [131922] by eae@chromium.org
  • 689 edits
    194 adds
    8 deletes in trunk/LayoutTests

Unreviewed chromium rebaseline for r131503.

  • fast/forms/input-baseline-expected.txt: Added.
  • fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium-linux-x86/fast/inline-block: Added.
  • platform/chromium-linux-x86/fast/inline-block/contenteditable-baseline-expected.txt: Added.
  • platform/chromium-linux-x86/fast/text/international: Added.
  • platform/chromium-linux-x86/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-marker-style-expected.png:
  • platform/chromium-linux/fast/html/details-nested-1-expected.png:
  • platform/chromium-linux/fast/html/details-nested-2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open1-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open3-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/html/details-open5-expected.png:
  • platform/chromium-linux/fast/html/details-open6-expected.png:
  • platform/chromium-linux/fast/html/details-position-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt:
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-linux/fast/inline-block/contenteditable-baseline-expected.txt: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-linux/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac-lion/css3: Added.
  • platform/chromium-mac-lion/css3/flexbox: Added.
  • platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/5240265-expected.png: Added.
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-mac-lion/fast: Added.
  • platform/chromium-mac-lion/fast/block: Added.
  • platform/chromium-mac-lion/fast/block/float: Added.
  • platform/chromium-mac-lion/fast/block/float/float-avoidance-expected.png: Added.
  • platform/chromium-mac-lion/fast/css: Added.
  • platform/chromium-mac-lion/fast/css/continuationCrash-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms: Added.
  • platform/chromium-mac-lion/fast/forms/001-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/007-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/date: Added.
  • platform/chromium-mac-lion/fast/forms/date/date-reset-value-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/file/input-file-re-render-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-value-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-mac-lion/fast/html: Added.
  • platform/chromium-mac-lion/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-marker-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-mac-lion/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac-lion/fast/images: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-mac-lion/fast/overflow: Added.
  • platform/chromium-mac-lion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • platform/chromium-mac-lion/fast/overflow/scrollRevealButton-expected.png: Added.
  • platform/chromium-mac-lion/fast/replaced: Added.
  • platform/chromium-mac-lion/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-mac-lion/fast/speech: Added.
  • platform/chromium-mac-lion/fast/sub-pixel: Added.
  • platform/chromium-mac-lion/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-mac-lion/fast/text: Added.
  • platform/chromium-mac-lion/fast/text/international: Added.
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-mac-lion/fast/writing-mode: Added.
  • platform/chromium-mac-lion/fast/writing-mode/fieldsets-expected.png: Added.
  • platform/chromium-mac-lion/http: Added.
  • platform/chromium-mac-lion/http/tests: Added.
  • platform/chromium-mac-lion/http/tests/navigation: Added.
  • platform/chromium-mac-lion/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-mac-lion/svg: Added.
  • platform/chromium-mac-lion/svg/as-border-image: Added.
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom: Added.
  • platform/chromium-mac-lion/svg/zoom/page: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-mac-lion/tables: Added.
  • platform/chromium-mac-lion/tables/mozilla: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders: Added.
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/dom: Added.
  • platform/chromium-mac-lion/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla/other: Added.
  • platform/chromium-mac-lion/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/007-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-reset-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/chromium-mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-mac/fast/block/float/032-expected.png:
  • platform/chromium-mac/fast/block/float/032-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/007-expected.png:
  • platform/chromium-mac/fast/forms/007-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-reset-value-expected.png: Added.
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-1-expected.png:
  • platform/chromium-mac/fast/html/details-nested-1-expected.txt:
  • platform/chromium-mac/fast/html/details-nested-2-expected.png:
  • platform/chromium-mac/fast/html/details-nested-2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-mac/fast/html/details-open1-expected.png:
  • platform/chromium-mac/fast/html/details-open1-expected.txt:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.txt:
  • platform/chromium-mac/fast/html/details-open3-expected.png:
  • platform/chromium-mac/fast/html/details-open3-expected.txt:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.txt:
  • platform/chromium-mac/fast/html/details-open5-expected.png:
  • platform/chromium-mac/fast/html/details-open5-expected.txt:
  • platform/chromium-mac/fast/html/details-open6-expected.png:
  • platform/chromium-mac/fast/html/details-open6-expected.txt:
  • platform/chromium-mac/fast/html/details-position-expected.png:
  • platform/chromium-mac/fast/html/details-position-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.txt:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png:
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-mac/fast/inline-block/contenteditable-baseline-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win-xp/fast/inline-block/contenteditable-baseline-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
  • platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium-win/fast/forms/007-expected.txt:
  • platform/chromium-win/fast/forms/basic-buttons-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.png:
  • platform/chromium-win/fast/html/details-nested-1-expected.txt:
  • platform/chromium-win/fast/html/details-nested-2-expected.png:
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary1-expected.png:
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.png:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.png:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.png:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.png:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.png:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.png:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.png:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.png:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/chromium-win/fast/inline-block/contenteditable-baseline-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Replaced.
  • platform/chromium/fast/forms/input-baseline-expected.txt: Removed.
  • platform/chromium/fast/forms/placeholder-position-expected.txt: Removed.
  • platform/mac/fast/forms/input-baseline-expected.txt: Removed.
  • platform/mac/fast/forms/placeholder-position-expected.txt: Removed.
10:45 AM Changeset in webkit [131921] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Fixing a lint issue.

  • platform/chromium/TestExpectations:
10:43 AM Changeset in webkit [131920] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Deque can use std::reverse_iterator for its reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=99789

Reviewed by Andreas Kling.

Remove DequeReverseIterator and DequeConstReverseIterator and just use std::reverse_iterator directly.
Also, remove the DequeIteratorBase<T, inlineCapacity> to Base typedef - We can already use DequeIteratorBase since it's
equivalent to the full class template type.

  • wtf/Deque.h:

(WTF::Deque::rbegin):
(WTF::Deque::rend):
(DequeIteratorBase):
(WTF::DequeIteratorBase::assign):
(DequeIterator):
(DequeConstIterator):
(WTF::::checkValidity):
(WTF::::DequeIteratorBase):
(WTF::=):
(WTF::::isEqual):

10:40 AM Changeset in webkit [131919] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Reorder some functions in SubresourceLoader to permit main resources
https://bugs.webkit.org/show_bug.cgi?id=99769

Reviewed by Adam Barth.

Most resource types that go through the memory cache (and therefore
through SubresourceLoader) are not sensitive to the exact ordering of
the callbacks they receive, particularly as it relates to ResourceLoadNotifier
calls. Main resources are not so lenient. For main resources to be cacheable
and maintain the current behavior as precisely as possible, we will need to
rearrange SubresourceLoader's willSendRequest() and didReceiveData().

No new tests, refactor only.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest): There are a series of checks that can result

in the request being canceled, plus calls to CachedResource::willSendRequest() and
ResourceLoader::willSendRequest(). MainResourceLoader (which will be a
CachedResourceClient) has work it expects to do before ResourceLoader::willSendRequest()
is called, but the calls are out of order for that, so swap those.

(WebCore::SubresourceLoader::didReceiveData): We need to populate ResourceLoader::m_resourceData

before notifying CachedResource of new data, but we also want to do CachedResourceClients calls
before calling ResourceLoadNotifier. This means we can't delegate to ResourceLoader.

10:36 AM Changeset in webkit [131918] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add input logs to InputHandler::ensureFocusTextElementVisible.
https://bugs.webkit.org/show_bug.cgi?id=99837

Reviewed by Antonio Gomes.

Add input logs for InputHandler::ensureFocusTextElementVisible.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

10:26 AM Changeset in webkit [131917] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should suspend AnimationController when WebPage becomes invisible.
https://bugs.webkit.org/show_bug.cgi?id=99844

Patch by Andrew Lo <anlo@rim.com> on 2012-10-19
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson & Yong Li.

Suspend animation controller when the tab becomes invisible,
in addition to suspending scripted animations.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setVisible):

10:25 AM Changeset in webkit [131916] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r131686): Crash in NSToolTipManager mouseEnteredToolTip
<rdar://problem/12527528> and https://bugs.webkit.org/show_bug.cgi?id=99792

Patch by Darin Adler, reviewed by Brady Eidson.

We should explicitly remove tooltips when the view moves to a new window.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):

10:16 AM Changeset in webkit [131915] by Chris Fleizach
  • 13 edits
    2 adds in trunk

AX: aria-hidden=false does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=98787

Reviewed by Beth Dakin.

Source/WebCore:

ARIA requires that aria-hidden=false override an element's native visibility and include that
node in the AX hierarchy.

To accomplish this we have to allow invisible items to be included, as well as items that
have no renderers associated with them.

Test: accessibility/aria-hidden-negates-no-visibility.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore):
(WebCore::AccessibilityNodeObject::boundingBoxRect):
(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::addChild):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::textUnderElement):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::addChild):
(WebCore::AccessibilityObject::insertChild):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

LayoutTests:

  • accessibility/aria-hidden-negates-no-visibility.html: Added.
  • platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
10:14 AM Changeset in webkit [131914] by tommyw@google.com
  • 7 edits in trunk/Source/WebCore

MediaStream API: Rename owner to client in MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=99593

Reviewed by Adam Barth.

This patch renames owner to client in MediaStreamDescriptor as discussed in #99080.

No new tests needed, covered by existing tests.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):

  • Modules/mediastream/MediaStream.h:

(MediaStream):

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::endLocalMediaStream):
(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptorClient::~MediaStreamDescriptorClient):
(WebCore::MediaStreamDescriptor::client):
(WebCore::MediaStreamDescriptor::setClient):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
(MediaStreamDescriptor):

10:09 AM Changeset in webkit [131913] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Clean up RegExpKey
https://bugs.webkit.org/show_bug.cgi?id=99798

Reviewed by Darin Adler.

RegExpHash doesn't need to be a class template specialization when the class template is specialized
for JSC::RegExpKey only. Make it a nested class of RegExp instead. Also, make operator== a friend function
so Hash::equal can see it.

  • runtime/RegExpKey.h:

(JSC::RegExpKey::RegExpKey):
(JSC::RegExpKey::operator==):
(RegExpKey):
(JSC::RegExpKey::Hash::hash):
(JSC::RegExpKey::Hash::equal):
(Hash):

10:08 AM Changeset in webkit [131912] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't attempt to auto scroll on input for Fixed Position elements.
https://bugs.webkit.org/show_bug.cgi?id=99833

Reviewed by Antonio Gomes.

PR 195024.

Don't attempt to scroll fixed position elements.

Reviewed Internally by Arvid Nilsson.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
(DOMSupport):

  • WebKitSupport/DOMSupport.h:

(WebCore):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

10:08 AM Changeset in webkit [131911] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] fix the fix

Unreviewed build fix.

Forgot to invert the condition when to set the type to none in the
previous attempt.

  • WebKit.gyp:
9:56 AM Changeset in webkit [131910] by shinyak@chromium.org
  • 4 edits
    6 adds in trunk

Elements assigned to <shadow> should not be reprojected.
https://bugs.webkit.org/show_bug.cgi?id=99680

Reviewed by Dimitri Glazkov.

Source/WebCore:

In the current spec, we don't have shadow reprojection, i.e. elements assigned to <shadow> should not be
reprojected to content. However, we can select them by <shadow>.

Tests: fast/dom/shadow/content-reprojection-complex.html

fast/dom/shadow/content-reprojection-shadow.html
fast/dom/shadow/shadow-reprojection-prohibited.html

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute): When a node is <shadow>, we should not add elements assigned to <shadow>
to POOL. Instead, <shadow> itself should be added to POOL.

  • html/shadow/HTMLContentElement.h:

(WebCore::isHTMLContentElement):
(WebCore):

LayoutTests:

  • fast/dom/shadow/content-reprojection-complex-expected.html: Added.
  • fast/dom/shadow/content-reprojection-complex.html: Added.
  • fast/dom/shadow/content-reprojection-shadow-expected.html: Added.
  • fast/dom/shadow/content-reprojection-shadow.html: Added.
  • fast/dom/shadow/shadow-reprojection-prohibited-expected.html: Added.
  • fast/dom/shadow/shadow-reprojection-prohibited.html: Added.
9:54 AM Changeset in webkit [131909] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix incorrect User Timing test case path in TestExpectations of qt-5.0-wk2 platform.
https://bugs.webkit.org/show_bug.cgi?id=99811.

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-19
Reviewed by Tony Gentilcore.

Path 'http/tests/w3c/webperf/proposal/Intel/user-timing' is replaced by 'http/tests/w3c/webperf/submission/Intel/user-timing' in this patch.

  • platform/qt-5.0-wk2/TestExpectations:
9:50 AM Changeset in webkit [131908] by Chris Fleizach
  • 6 edits
    2 adds in trunk

VO issues with hidden <legend> and last explicitly labelled element within a group <fieldset>
https://bugs.webkit.org/show_bug.cgi?id=96325

Reviewed by Beth Dakin.

Source/WebCore:

When finding a <legend> for accessibility, we need to consider those that are offscreen. This patch
modifies the original findLegend method to take a parameter to determine what should be done.

Test: accessibility/hidden-legend.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::findLegend):

  • rendering/RenderFieldset.h:

LayoutTests:

  • accessibility/hidden-legend-expected.txt: Added.
  • accessibility/hidden-legend.html: Added.
  • platform/chromium/TestExpectations:
9:45 AM Changeset in webkit [131907] by shinyak@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Should have a test case where InsertionPoint has a ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=99822

Reviewed by Dimitri Glazkov.

We didn't have a test case where InsertionPoint has a ShadowRoot. Let's have it not to cause a regression.

  • fast/dom/shadow/shadowroot-of-insertionpoint-expected.html: Added.
  • fast/dom/shadow/shadowroot-of-insertionpoint.html: Added.
9:37 AM Changeset in webkit [131906] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix inside chromium build on Mac

Unreviewed build fix.

Xcode won't create a static library without any sources. So instead of
ommitting the sources, just override the webkit_test_support's type
with 'none'.

  • WebKit.gyp:
9:24 AM Changeset in webkit [131905] by Chris Fleizach
  • 15 edits in trunk

AX: Refactor accessibility name computation so it's more platform independent
https://bugs.webkit.org/show_bug.cgi?id=99502

Reviewed by Beth Dakin.

Source/WebCore:

The current model of determining the accessible text for an object has a lot of Mac biases built in
due to legacy implementation.

This change categorizes and orders accessibility text based on WAI-ARIA text computation rules and then
allows the platform (only Mac right now) to decide how best to apply that text to its own AX API.
http://www.w3.org/TR/wai-aria/roles#textalternativecomputation

This change tried very hard not to change any test behavior, even though it exposed a number of weird
edge cases where we were treating attributes differently based on element type.

Future patches will resolve those discrepancies.

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityText):

  • accessibility/AccessibilityImageMapLink.h:

(AccessibilityImageMapLink):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::accessibilityText):

  • accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeDisplay::isMediaControlLabel):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::accessibilityText):
(WebCore::AccessibilityNodeObject::ariaLabeledByText):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::ariaDescribedByAttribute):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.h:

(AccessibilityText):
(WebCore::AccessibilityText::AccessibilityText):
(WebCore::AccessibilityObject::isMediaControlLabel):
(AccessibilityObject):
(WebCore::AccessibilityObject::accessibilityText):
(WebCore::AccessibilityObject::setAccessibleName):
(WebCore::AccessibilityObject::accessibilityDescription):
(WebCore::AccessibilityObject::title):
(WebCore::AccessibilityObject::helpText):
(WebCore::AccessibilityObject::stringValue):
(WebCore::AccessibilityObject::textUnderElement):
(WebCore::AccessibilityObject::text):
(WebCore::AccessibilityObject::textLength):
(WebCore::AccessibilityObject::setRoleValue):
(WebCore::AccessibilityObject::roleValue):
(WebCore::AccessibilityObject::selection):
(WebCore::AccessibilityObject::hierarchicalLevel):

  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementHelpText):

LayoutTests:

Update a test to reflect change in what shoud be recognized as a title.

  • platform/mac/accessibility/aria-radiobutton-text.html:
8:38 AM Changeset in webkit [131904] by kbalazs@webkit.org
  • 4 edits in trunk

[Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active
https://bugs.webkit.org/show_bug.cgi?id=99831

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

Update the comment about renderToOffscreenBuffer to better describe its role.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setNeedsDisplay):

Tools:

Do not set renderToOffscreenBuffer if we have called setRenderWithoutShowing.
We do not need it in this case and these things are actually conflicting.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::windowShapshotEnabled): Added a comment
describing why this workaround is needed.

8:32 AM Changeset in webkit [131903] by kbalazs@webkit.org
  • 88 edits
    2 copies
    3 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Part 7.
Rebaseline the rest of pixel results. All of these tests producing correct results,
only the expectations were outdated. Most of the differenes was not detectable by
looking at the expected and actual results, only ImageDiff sees the difference.

  • platform/qt/http/tests/misc/acid2-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png:
  • platform/qt/tables/mozilla/bugs/bug101674-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10633-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1067-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug126742-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.png:
  • platform/qt/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1430-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17130-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17130-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22019-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23235-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2886-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2962-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6404-expected.png:
  • platform/qt/tables/mozilla/bugs/bug73321-expected.png:
  • platform/qt/tables/mozilla/bugs/bug86708-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/qt/tables/mozilla/core/one_row-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/qt/tables/mozilla/other/cell_widths-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/qt/transforms/3d/general/matrix-with-zoom-3d-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug1067-2-expected.png.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.png:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/qt/transitions/suspend-transform-transition-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug1067-2-expected.png.
8:22 AM Changeset in webkit [131902] by zandobersek@gmail.com
  • 4 edits in trunk

[WK2][GTK] Fullscreen tests timing out in bots
https://bugs.webkit.org/show_bug.cgi?id=93973

Reviewed by Philippe Normand.

Tools:

Add webcore_cppflags to the CPPFLAGS for WebKitTestRunner and the
injected bundle library. webcore_cppflags contains all the feature
defines' macros so the ENABE(*) compilation guards should now work
properly (i.e. enable the code behind them when the feature is enabled).

  • WebKitTestRunner/GNUmakefile.am:

LayoutTests:

Remove failure expectations for the fullscreen tests. They all pass now,
with a pass expectation needed for one test to aknowledge that.

  • platform/gtk-wk2/TestExpectations:
8:14 AM Changeset in webkit [131901] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
http://webkit.org/b/99818

month-multiple-fields-keyboard-events.html is failing on SnowLeopard too.

  • platform/chromium/TestExpectations:
7:48 AM Changeset in webkit [131900] by kbalazs@webkit.org
  • 114 edits
    2 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Part 6.
Rebaseline pixel results in the svg directory.
All of these tests producing correct results, only the expectations
were outdated. Most of the differenes was not detectable by looking
at the expected and actual results, only ImageDiff sees the difference.

  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-09-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-10-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-18-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-19-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-order-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-fill-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-dom-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-10-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-ws-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-ws-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/qt/svg/animations/animateMotion-additive-2c-expected.png: Added.
  • platform/qt/svg/animations/animateMotion-additive-2d-expected.png: Added.
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/qt/svg/css/text-shadow-multiple-expected.png:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/altglyph-expected.png:
  • platform/qt/svg/custom/focus-ring-expected.png:
  • platform/qt/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/qt/svg/custom/gradient-stroke-width-expected.png:
  • platform/qt/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/qt/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/qt/svg/custom/image-rescale-expected.png:
  • platform/qt/svg/custom/image-small-width-height-expected.png:
  • platform/qt/svg/custom/relative-sized-image-expected.png:
  • platform/qt/svg/custom/text-rotation-expected.png:
  • platform/qt/svg/dom/css-transforms-expected.png:
  • platform/qt/svg/filters/feDropShadow-expected.png:
  • platform/qt/svg/filters/filterRes1-expected.png:
  • platform/qt/svg/filters/filterRes3-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/use/002-expected.png:
  • platform/qt/svg/text/multichar-glyph-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/qt/svg/text/select-x-list-2-expected.png:
  • platform/qt/svg/text/select-x-list-3-expected.png:
  • platform/qt/svg/text/select-x-list-4-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/qt/svg/text/selection-doubleclick-expected.png:
  • platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/qt/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
7:28 AM Changeset in webkit [131899] by kbalazs@webkit.org
  • 113 edits
    7 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Part 5.
Rebaseline pixel results the rest of the fast directory.
All of these tests producing correct results, only the expectations
were outdated. Most of the differenes was not detectable by looking
at the expected and actual results, only ImageDiff sees the difference.

  • platform/qt/fast/dom/Element/class-attribute-whitespace-expected.png:
  • platform/qt/fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png:
  • platform/qt/fast/dom/children-nodes-expected.png:
  • platform/qt/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/qt/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png:
  • platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:
  • platform/qt/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/qt/fast/dynamic/selection-highlight-adjust-expected.png:
  • platform/qt/fast/dynamic/staticY-marking-parents-regression-expected.png:
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/qt/fast/events/pointer-events-2-expected.png:
  • platform/qt/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/qt/fast/forms/select-change-listbox-size-expected.png:
  • platform/qt/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/qt/fast/inline/br-text-decoration-expected.png:
  • platform/qt/fast/inline/continuation-outlines-expected.png:
  • platform/qt/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/qt/fast/inline/inline-box-background-expected.png:
  • platform/qt/fast/inline/inline-box-background-long-image-expected.png:
  • platform/qt/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/qt/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/qt/fast/layers/normal-flow-hit-test-expected.png:
  • platform/qt/fast/layers/opacity-outline-expected.png:
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/qt/fast/line-grid/line-grid-contains-value-expected.png:
  • platform/qt/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/qt/fast/line-grid/line-grid-into-columns-expected.png:
  • platform/qt/fast/lists/003-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/marker-before-empty-inline-expected.png:
  • platform/qt/fast/lists/marker-image-error-expected.png:
  • platform/qt/fast/lists/markers-in-selection-expected.png:
  • platform/qt/fast/lists/ordered-list-with-no-ol-tag-expected.png:
  • platform/qt/fast/lists/scrolled-marker-paint-expected.png:
  • platform/qt/fast/multicol/column-rules-expected.png:
  • platform/qt/fast/multicol/column-rules-stacking-expected.png:
  • platform/qt/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/qt/fast/multicol/float-multicol-expected.png:
  • platform/qt/fast/multicol/nested-columns-expected.png:
  • platform/qt/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/qt/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/qt/fast/overflow/image-selection-highlight-expected.png:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.png:
  • platform/qt/fast/overflow/paged-x-div-expected.png:
  • platform/qt/fast/overflow/paged-x-on-root-expected.png:
  • platform/qt/fast/overflow/paged-y-div-expected.png:
  • platform/qt/fast/overflow/paged-y-on-root-expected.png:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt/fast/reflections/reflection-direction-expected.png:
  • platform/qt/fast/reflections/reflection-with-zoom-expected.png:
  • platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png:
  • platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png:
  • platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png:
  • platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.png:
  • platform/qt/fast/repaint/float-overflow-expected.png:
  • platform/qt/fast/repaint/float-overflow-right-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/qt/fast/replaced/001-expected.png:
  • platform/qt/fast/replaced/002-expected.png:
  • platform/qt/fast/replaced/003-expected.png:
  • platform/qt/fast/replaced/absolute-image-sizing-expected.png:
  • platform/qt/fast/replaced/image-sizing-expected.png:
  • platform/qt/fast/replaced/inline-box-wrapper-handover-expected.png:
  • platform/qt/fast/replaced/selection-rect-in-table-cell-expected.png:
  • platform/qt/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
  • platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
  • platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
  • platform/qt/fast/selectors/166-expected.png:
  • platform/qt/fast/table/border-collapsing/004-expected.png:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/qt/fast/table/edge-offsets-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/qt/fast/table/frame-and-rules-expected.png:
  • platform/qt/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/qt/fast/table/table-row-style-not-updated-expected.png: Added.
  • platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
  • platform/qt/fast/table/table-style-not-updated-expected.png: Added.
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/qt/fast/text/break-word-expected.png:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/qt/fast/text/capitalize-preserve-nbsp-expected.png:
  • platform/qt/fast/text/delete-hard-break-character-expected.png:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.png:
  • platform/qt/fast/text/midword-break-hang-expected.png:
  • platform/qt/fast/text/reset-emptyRun-expected.png:
  • platform/qt/fast/text/selection-hard-linebreak-expected.png:
  • platform/qt/fast/text/stroking-decorations-expected.png:
  • platform/qt/fast/text/text-letter-spacing-expected.png:
  • platform/qt/fast/text/wbr-expected.png:
  • platform/qt/fast/text/whitespace/018-expected.png:
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/qt/fast/transforms/shadows-expected.png:
  • platform/qt/fast/transforms/transformed-caret-expected.png:
  • platform/qt/fast/transforms/transforms-with-zoom-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/english-lr-text-expected.png:
7:20 AM Changeset in webkit [131898] by tkent@chromium.org
  • 14 edits
    3 adds in trunk

Use Localizer::monthFormat to construct input[type=month] UI
https://bugs.webkit.org/show_bug.cgi?id=99818

Reviewed by Kentaro Hara.

Source/WebCore:

Use an LDML format returned by Localizer::monthFormat for
input[type=month] UI.

Because the format may contain symbolic month names and symbolic
stand-alone month names, we need to add:

  • Symbolic/numeric detection in DateTimeEditBuilder
  • Normal/stand-alone detection in DateTimeEditBuilder
  • Symbolic edit field for months

Test: fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html,

fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::setupLayoutParameters):
Use Localizer::monthFormat.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):

  • If the number of continuous field character is greater than 2, use

DateTimeSymbolicMonthFieldElement.

  • Supports stand-alone month field.
  • html/shadow/DateTimeFieldElements.h:

(DateTimeSymbolicMonthFieldElement): Added. A subclass of DateTimeSymbolicFieldElement.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeSymbolicMonthFieldElement::DateTimeSymbolicMonthFieldElement):
Added.
(WebCore::DateTimeSymbolicMonthFieldElement::create): Added.
(WebCore::DateTimeSymbolicMonthFieldElement::populateDateTimeFieldsState):
We need to add 1 because the internal integer representation is 0-based
and DateTimeFieldsState uses 1-based month.
(WebCore::DateTimeSymbolicMonthFieldElement::setValueAsDate):
DateComponents::month is 0-based.
(WebCore::DateTimeSymbolicMonthFieldElement::setValueAsDateTimeFieldsState):
We need to subtract 1 because the internal integer representation is 0-based
and DateTimeFieldsState uses 1-based month.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement::symbolsSize):
Added for DateTimeSymbolicMonthFieldElement::setValueAsDateTimeFieldsState.

LayoutTests:

  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:

Updated because symbolic month fields don't support digit-key input.

  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium/TestExpectations:
7:06 AM Changeset in webkit [131897] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Unreviewed buildfix, use C-style comment instead of C++

  • wtf/Platform.h:
6:58 AM Changeset in webkit [131896] by rakuco@webkit.org
  • 3 edits
    2 moves in trunk/Source/WebKit2

[EFL][WK2] Rename EflViewportHandler to PageViewportControllerClientEfl
https://bugs.webkit.org/show_bug.cgi?id=99101

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-19
Reviewed by Gyuyoung Kim.

Rename EFlViewportHandler to PageViewportControllerClientEfl.
Also, make it inherit from PageViewportControllerClient. The actual implementation
of PageViewportControllerClient for Efl port will come in a separate patch.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • UIProcess/API/efl/EflViewportHandler.cpp: Removed.
  • UIProcess/API/efl/EflViewportHandler.h: Removed.
  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp: Copied from Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp.

(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::~PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::drawingArea):
(WebKit::PageViewportControllerClientEfl::setRendererActive):
(WebKit::PageViewportControllerClientEfl::display):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
(WebKit::PageViewportControllerClientEfl::didChangeViewportAttributes):
(WebKit::PageViewportControllerClientEfl::setController):

  • UIProcess/API/efl/PageViewportControllerClientEfl.h: Copied from Source/WebKit2/UIProcess/API/efl/EflViewportHandler.h.

(WebKit::PageViewportControllerClientEfl::create):
(PageViewportControllerClientEfl):

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_scale_set):

  • UIProcess/PageViewportController.cpp:
  • UIProcess/PageViewportController.h:
6:44 AM Changeset in webkit [131895] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: inspector/styles/styles-history.html is failing Text on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=99519

Reviewed by Alexander Pavlov.

Source/WebCore:

Extracted _styleContentSet callback in a class method to make it sniffable by tests.

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StyleFile.prototype._commitIncrementalEdit):
(WebInspector.StyleFile.prototype._styleContentSet):

LayoutTests:

  • inspector/styles/styles-history.html:
  • platform/chromium/TestExpectations:
6:42 AM Changeset in webkit [131894] by kbalazs@webkit.org
  • 104 edits
    4 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebase.

Part 4.
Rebaseline pixel results in first part of fast (backgrounds, block, borders,
box-shadow, css). All of these tests producing correct results, only the expectations
were outdated. Most of the differenes was not detectable by looking at the expected
and actual results, only ImageDiff sees the difference.

  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/qt/fast/backgrounds/background-position-parsing-expected.png:
  • platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/qt/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/qt/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/truncation-rtl-expected.png:
  • platform/qt/fast/block/float/002-expected.png:
  • platform/qt/fast/block/float/020-expected.png:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/qt/fast/block/float/float-in-float-painting-expected.png:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/qt/fast/block/float/table-relayout-expected.png:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.png:
  • platform/qt/fast/block/margin-collapse/055-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.png:
  • platform/qt/fast/block/positioning/auto/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/qt/fast/borders/border-image-01-expected.png:
  • platform/qt/fast/borders/border-image-border-radius-expected.png:
  • platform/qt/fast/borders/border-image-longhand-expected.png:
  • platform/qt/fast/borders/border-image-massive-scale-expected.png:
  • platform/qt/fast/borders/border-image-outset-expected.png:
  • platform/qt/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/qt/fast/borders/border-image-repeat-expected.png:
  • platform/qt/fast/borders/border-image-rotate-transform-expected.png:
  • platform/qt/fast/borders/border-image-scale-transform-expected.png:
  • platform/qt/fast/borders/border-image-scaled-expected.png:
  • platform/qt/fast/borders/border-image-scrambled-expected.png:
  • platform/qt/fast/borders/border-image-side-reduction-expected.png:
  • platform/qt/fast/borders/border-image-source-expected.png:
  • platform/qt/fast/borders/border-mixed-alpha-expected.png:
  • platform/qt/fast/borders/border-radius-complex-inner-expected.png:
  • platform/qt/fast/borders/border-radius-different-width-001-expected.png:
  • platform/qt/fast/borders/rtl-border-01-expected.png:
  • platform/qt/fast/borders/rtl-border-02-expected.png:
  • platform/qt/fast/borders/rtl-border-03-expected.png:
  • platform/qt/fast/borders/rtl-border-04-expected.png:
  • platform/qt/fast/box-shadow/spread-expected.png:
  • platform/qt/fast/canvas/arc360-expected.png:
  • platform/qt/fast/canvas/canvas-before-css-expected.png:
  • platform/qt/fast/canvas/canvas-composite-expected.png:
  • platform/qt/fast/canvas/canvas-text-alignment-expected.png:
  • platform/qt/fast/canvas/canvas-text-baseline-expected.png:
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.png:
  • platform/qt/fast/canvas/check-stale-putImageData-expected.png: Added.
  • platform/qt/fast/canvas/drawImage-expected.png:
  • platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png:
  • platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.png:
  • platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.png:
  • platform/qt/fast/canvas/fillrect_gradient-expected.png:
  • platform/qt/fast/canvas/image-object-in-canvas-expected.png:
  • platform/qt/fast/canvas/patternfill-repeat-expected.png:
  • platform/qt/fast/canvas/quadraticCurveTo-expected.png:
  • platform/qt/fast/canvas/shadow-offset-1-expected.png:
  • platform/qt/fast/canvas/shadow-offset-2-expected.png:
  • platform/qt/fast/canvas/shadow-offset-3-expected.png:
  • platform/qt/fast/canvas/shadow-offset-4-expected.png:
  • platform/qt/fast/canvas/shadow-offset-5-expected.png:
  • platform/qt/fast/canvas/shadow-offset-6-expected.png:
  • platform/qt/fast/canvas/shadow-offset-7-expected.png:
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.png:
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/qt/fast/css/acid2-expected.png:
  • platform/qt/fast/css/clip-zooming-expected.png:
  • platform/qt/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/qt/fast/css/css2-system-fonts-expected.png:
  • platform/qt/fast/css/empty-pseudo-class-expected.png:
  • platform/qt/fast/css/find-next-layer-expected.png:
  • platform/qt/fast/css/first-child-pseudo-class-expected.png:
  • platform/qt/fast/css/first-letter-capitalized-expected.png:
  • platform/qt/fast/css/first-letter-detach-expected.png:
  • platform/qt/fast/css/first-letter-hover-expected.png:
  • platform/qt/fast/css/first-line-text-decoration-expected.png:
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
  • platform/qt/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/qt/fast/css/focus-ring-multiline-expected.png:
  • platform/qt/fast/css/font-face-opentype-expected.png:
  • platform/qt/fast/css/font-face-synthetic-bold-italic-expected.png:
  • platform/qt/fast/css/font-face-weight-matching-expected.png:
  • platform/qt/fast/css/font-shorthand-weight-only-expected.png:
  • platform/qt/fast/css/hover-subselector-expected.png:
  • platform/qt/fast/css/hsl-color-expected.png:
  • platform/qt/fast/css/last-child-pseudo-class-expected.png:
  • platform/qt/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/qt/fast/css/line-height-font-order-expected.png:
  • platform/qt/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/qt/fast/css/min-width-with-spanned-cell-expected.png: Added.
  • platform/qt/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
  • platform/qt/fast/css/nth-child-dynamic-expected.png:
  • platform/qt/fast/css/only-child-pseudo-class-expected.png:
  • platform/qt/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/qt/fast/css/outline-auto-empty-rects-expected.png:
  • platform/qt/fast/css/outline-auto-location-expected.png:
  • platform/qt/fast/css/percent-top-value-with-relative-position-expected.png:
  • platform/qt/fast/css/text-rendering-expected.png:
  • platform/qt/fast/css/universal-hover-quirk-expected.png:
6:30 AM Changeset in webkit [131893] by kbalazs@webkit.org
  • 289 edits in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed rebaseline.

Part 3.
Rebase pixel results in editing. All of these tests producing correct results,
only the expectations were outdated.

  • platform/qt/editing/deleting/4922367-expected.png:
  • platform/qt/editing/deleting/5099303-expected.png:
  • platform/qt/editing/deleting/5144139-2-expected.png:
  • platform/qt/editing/deleting/5483370-expected.png:
  • platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/qt/editing/deleting/delete-3608462-fix-expected.png:
  • platform/qt/editing/deleting/delete-4083333-fix-expected.png:
  • platform/qt/editing/deleting/delete-and-undo-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/qt/editing/deleting/delete-block-contents-001-expected.png:
  • platform/qt/editing/deleting/delete-block-contents-002-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/qt/editing/deleting/delete-br-001-expected.png:
  • platform/qt/editing/deleting/delete-br-007-expected.png:
  • platform/qt/editing/deleting/delete-br-013-expected.png:
  • platform/qt/editing/deleting/delete-character-001-expected.png:
  • platform/qt/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-first-list-item-expected.png:
  • platform/qt/editing/deleting/delete-image-001-expected.png:
  • platform/qt/editing/deleting/delete-image-003-expected.png:
  • platform/qt/editing/deleting/delete-image-004-expected.png:
  • platform/qt/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-line-015-expected.png:
  • platform/qt/editing/deleting/delete-line-016-expected.png:
  • platform/qt/editing/deleting/delete-line-017-expected.png:
  • platform/qt/editing/deleting/delete-listitem-002-expected.png:
  • platform/qt/editing/deleting/delete-selection-001-expected.png:
  • platform/qt/editing/deleting/delete-to-select-table-expected.png:
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/qt/editing/deleting/list-item-1-expected.png:
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/qt/editing/deleting/merge-no-br-expected.png:
  • platform/qt/editing/deleting/merge-unrendered-space-expected.png:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/qt/editing/deleting/non-smart-delete-expected.png:
  • platform/qt/editing/deleting/smart-delete-001-expected.png:
  • platform/qt/editing/deleting/smart-delete-002-expected.png:
  • platform/qt/editing/deleting/table-cells-expected.png:
  • platform/qt/editing/execCommand/4580583-2-expected.png:
  • platform/qt/editing/execCommand/4641880-1-expected.png:
  • platform/qt/editing/execCommand/4641880-2-expected.png:
  • platform/qt/editing/execCommand/4747450-expected.png:
  • platform/qt/editing/execCommand/4916402-expected.png:
  • platform/qt/editing/execCommand/4916541-expected.png:
  • platform/qt/editing/execCommand/5080333-1-expected.png:
  • platform/qt/editing/execCommand/5080333-2-expected.png:
  • platform/qt/editing/execCommand/5136770-expected.png:
  • platform/qt/editing/execCommand/5138441-expected.png:
  • platform/qt/editing/execCommand/5142012-1-expected.png:
  • platform/qt/editing/execCommand/5142012-2-expected.png:
  • platform/qt/editing/execCommand/5190926-expected.png:
  • platform/qt/editing/execCommand/5481523-expected.png:
  • platform/qt/editing/execCommand/5569741-expected.png:
  • platform/qt/editing/execCommand/create-list-with-hr-expected.png:
  • platform/qt/editing/execCommand/indent-list-item-expected.png:
  • platform/qt/editing/execCommand/indent-selection-expected.png:
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/qt/editing/execCommand/print-expected.png:
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/qt/editing/execCommand/selectAll-expected.png:
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/qt/editing/inserting/12882-expected.png:
  • platform/qt/editing/inserting/4278698-expected.png:
  • platform/qt/editing/inserting/4840662-expected.png:
  • platform/qt/editing/inserting/4960120-2-expected.png:
  • platform/qt/editing/inserting/5002441-expected.png:
  • platform/qt/editing/inserting/5058163-1-expected.png:
  • platform/qt/editing/inserting/5058163-2-expected.png:
  • platform/qt/editing/inserting/5156401-2-expected.png:
  • platform/qt/editing/inserting/5510537-expected.png:
  • platform/qt/editing/inserting/5549929-2-expected.png:
  • platform/qt/editing/inserting/5549929-3-expected.png:
  • platform/qt/editing/inserting/6703873-expected.png:
  • platform/qt/editing/inserting/editing-empty-divs-expected.png:
  • platform/qt/editing/inserting/insert-3775316-fix-expected.png:
  • platform/qt/editing/inserting/insert-after-delete-001-expected.png:
  • platform/qt/editing/inserting/insert-at-end-01-expected.png:
  • platform/qt/editing/inserting/insert-at-end-02-expected.png:
  • platform/qt/editing/inserting/insert-br-001-expected.png:
  • platform/qt/editing/inserting/insert-br-003-expected.png:
  • platform/qt/editing/inserting/insert-br-006-expected.png:
  • platform/qt/editing/inserting/insert-br-007-expected.png:
  • platform/qt/editing/inserting/insert-br-008-expected.png:
  • platform/qt/editing/inserting/insert-br-009-expected.png:
  • platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/qt/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/qt/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/qt/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/qt/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/qt/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/qt/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/qt/editing/inserting/insert-div-022-expected.png:
  • platform/qt/editing/inserting/insert-div-023-expected.png:
  • platform/qt/editing/inserting/insert-div-024-expected.png:
  • platform/qt/editing/inserting/insert-div-026-expected.png:
  • platform/qt/editing/inserting/insert-paragraph-01-expected.png:
  • platform/qt/editing/inserting/insert-paragraph-03-expected.png:
  • platform/qt/editing/inserting/insert-paragraph-04-expected.png:
  • platform/qt/editing/inserting/insert-paragraph-05-expected.png:
  • platform/qt/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/qt/editing/inserting/insert-tab-001-expected.png:
  • platform/qt/editing/inserting/insert-tab-002-expected.png:
  • platform/qt/editing/inserting/insert-tab-004-expected.png:
  • platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/qt/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/qt/editing/inserting/line-break-expected.png:
  • platform/qt/editing/inserting/paragraph-separator-01-expected.png:
  • platform/qt/editing/inserting/paragraph-separator-02-expected.png:
  • platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/qt/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/qt/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/qt/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/qt/editing/inserting/typing-001-expected.png:
  • platform/qt/editing/inserting/typing-002-expected.png:
  • platform/qt/editing/inserting/typing-003-expected.png:
  • platform/qt/editing/inserting/typing-around-br-001-expected.png:
  • platform/qt/editing/inserting/typing-around-image-001-expected.png:
  • platform/qt/editing/pasteboard/3976872-expected.png:
  • platform/qt/editing/pasteboard/4076267-2-expected.png:
  • platform/qt/editing/pasteboard/4076267-3-expected.png:
  • platform/qt/editing/pasteboard/4631972-expected.png:
  • platform/qt/editing/pasteboard/4806874-expected.png:
  • platform/qt/editing/pasteboard/5006779-expected.png:
  • platform/qt/editing/pasteboard/5071074-2-expected.png:
  • platform/qt/editing/pasteboard/5071074-expected.png:
  • platform/qt/editing/pasteboard/5075944-expected.png:
  • platform/qt/editing/pasteboard/5156401-1-expected.png:
  • platform/qt/editing/pasteboard/5247341-expected.png:
  • platform/qt/editing/pasteboard/5387578-expected.png:
  • platform/qt/editing/pasteboard/5478250-expected.png:
  • platform/qt/editing/pasteboard/5601583-1-expected.png:
  • platform/qt/editing/pasteboard/8145-1-expected.png:
  • platform/qt/editing/pasteboard/8145-2-expected.png:
  • platform/qt/editing/pasteboard/8145-3-expected.png:
  • platform/qt/editing/pasteboard/bad-placeholder-expected.png:
  • platform/qt/editing/pasteboard/cut-text-001-expected.png:
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/qt/editing/pasteboard/paste-text-019-expected.png:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/qt/editing/pasteboard/pasting-object-expected.png:
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.png:
  • platform/qt/editing/pasteboard/smart-paste-008-expected.png:
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/qt/editing/pasteboard/unrendered-br-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/4397952-expected.png:
  • platform/qt/editing/selection/4818145-expected.png:
  • platform/qt/editing/selection/4932260-1-expected.png:
  • platform/qt/editing/selection/4932260-2-expected.png:
  • platform/qt/editing/selection/4932260-3-expected.png:
  • platform/qt/editing/selection/5007143-2-expected.png:
  • platform/qt/editing/selection/5007143-expected.png:
  • platform/qt/editing/selection/5057506-2-expected.png:
  • platform/qt/editing/selection/5057506-expected.png:
  • platform/qt/editing/selection/5076323-2-expected.png:
  • platform/qt/editing/selection/5076323-3-expected.png:
  • platform/qt/editing/selection/5131716-1-expected.png:
  • platform/qt/editing/selection/5131716-2-expected.png:
  • platform/qt/editing/selection/5131716-3-expected.png:
  • platform/qt/editing/selection/5131716-4-expected.png:
  • platform/qt/editing/selection/5234383-1-expected.png:
  • platform/qt/editing/selection/5234383-2-expected.png:
  • platform/qt/editing/selection/6476-expected.png:
  • platform/qt/editing/selection/after-line-wrap-expected.png:
  • platform/qt/editing/selection/caret-before-select-expected.png:
  • platform/qt/editing/selection/click-start-of-line-expected.png:
  • platform/qt/editing/selection/editable-non-editable-crash-expected.png:
  • platform/qt/editing/selection/end-of-document-expected.png:
  • platform/qt/editing/selection/extend-by-character-001-expected.png:
  • platform/qt/editing/selection/extend-by-character-006-expected.png:
  • platform/qt/editing/selection/extend-by-sentence-001-expected.png:
  • platform/qt/editing/selection/extend-by-word-001-expected.png:
  • platform/qt/editing/selection/extend-by-word-002-expected.png:
  • platform/qt/editing/selection/extend-selection-bidi-expected.png:
  • platform/qt/editing/selection/iframe-expected.png:
  • platform/qt/editing/selection/image-before-linebreak-expected.png:
  • platform/qt/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/qt/editing/selection/leave-requested-block-expected.png:
  • platform/qt/editing/selection/mixed-editability-6-expected.png:
  • platform/qt/editing/selection/mixed-editability-7-expected.png:
  • platform/qt/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/qt/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/qt/editing/selection/move-by-character-001-expected.png:
  • platform/qt/editing/selection/move-by-line-001-expected.png:
  • platform/qt/editing/selection/move-by-line-002-expected.png:
  • platform/qt/editing/selection/move-by-sentence-001-expected.png:
  • platform/qt/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/qt/editing/selection/move-by-word-001-expected.png:
  • platform/qt/editing/selection/previous-line-position-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-1-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-2-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.png:
  • platform/qt/editing/selection/select-all-001-expected.png:
  • platform/qt/editing/selection/select-all-002-expected.png:
  • platform/qt/editing/selection/table-caret-1-expected.png:
  • platform/qt/editing/selection/table-caret-2-expected.png:
  • platform/qt/editing/selection/unrendered-space-expected.png:
  • platform/qt/editing/style/5017613-1-expected.png:
  • platform/qt/editing/style/5017613-2-expected.png:
  • platform/qt/editing/style/5046875-1-expected.png:
  • platform/qt/editing/style/5046875-2-expected.png:
  • platform/qt/editing/style/5065910-expected.png:
  • platform/qt/editing/style/5228141-expected.png:
  • platform/qt/editing/style/5279521-expected.png:
  • platform/qt/editing/style/block-styles-007-expected.png:
  • platform/qt/editing/style/font-family-with-space-expected.png:
  • platform/qt/editing/style/style-3681552-fix-001-expected.png:
  • platform/qt/editing/style/style-3681552-fix-002-expected.png:
  • platform/qt/editing/style/style-3998892-fix-expected.png:
  • platform/qt/editing/style/style-boundary-001-expected.png:
  • platform/qt/editing/style/style-boundary-002-expected.png:
  • platform/qt/editing/style/style-boundary-003-expected.png:
  • platform/qt/editing/style/style-boundary-004-expected.png:
  • platform/qt/editing/style/typing-style-001-expected.png:
  • platform/qt/editing/style/typing-style-002-expected.png:
  • platform/qt/editing/style/unbold-in-bold-expected.png:
  • platform/qt/editing/undo/4063751-expected.png:
  • platform/qt/editing/undo/5378473-expected.png:
  • platform/qt/editing/undo/redo-typing-001-expected.png:
  • platform/qt/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/qt/editing/undo/undo-combined-delete-expected.png:
  • platform/qt/editing/undo/undo-delete-boundary-expected.png:
  • platform/qt/editing/undo/undo-delete-expected.png:
  • platform/qt/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/qt/editing/undo/undo-forward-delete-expected.png:
  • platform/qt/editing/undo/undo-misspellings-expected.png:
  • platform/qt/editing/undo/undo-typing-001-expected.png:
  • platform/qt/editing/unsupported-content/list-delete-001-expected.png:
  • platform/qt/editing/unsupported-content/list-delete-003-expected.png:
  • platform/qt/editing/unsupported-content/list-type-after-expected.png:
  • platform/qt/editing/unsupported-content/list-type-before-expected.png:
  • platform/qt/editing/unsupported-content/table-delete-001-expected.png:
  • platform/qt/editing/unsupported-content/table-delete-002-expected.png:
  • platform/qt/editing/unsupported-content/table-delete-003-expected.png:
  • platform/qt/editing/unsupported-content/table-type-after-expected.png:
  • platform/qt/editing/unsupported-content/table-type-before-expected.png:
6:13 AM Changeset in webkit [131892] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: add object-src 'none' to the inspector.html
https://bugs.webkit.org/show_bug.cgi?id=99728

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.html:
5:50 AM Changeset in webkit [131891] by kbalazs@webkit.org
  • 59 edits
    2 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed rebaseline.

Part 2.
Rebase pixel results in animations, compositing, css1, css2.1 and css3.

  • platform/qt/animations/cross-fade-border-image-source-expected.png:
  • platform/qt/compositing/direct-image-compositing-expected.png:
  • platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
  • platform/qt/css1/basic/containment-expected.png:
  • platform/qt/css1/basic/inheritance-expected.png:
  • platform/qt/css1/box_properties/border-expected.png:
  • platform/qt/css1/box_properties/border_bottom-expected.png:
  • platform/qt/css1/box_properties/border_left-expected.png:
  • platform/qt/css1/box_properties/border_left_width-expected.png:
  • platform/qt/css1/box_properties/border_right_inline-expected.png:
  • platform/qt/css1/box_properties/border_right_width-expected.png:
  • platform/qt/css1/box_properties/border_style-expected.png:
  • platform/qt/css1/box_properties/border_top-expected.png:
  • platform/qt/css1/box_properties/clear_float-expected.png:
  • platform/qt/css1/box_properties/float_margin-expected.png:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.png:
  • platform/qt/css1/box_properties/margin_inline-expected.png:
  • platform/qt/css1/box_properties/margin_left-expected.png:
  • platform/qt/css1/box_properties/margin_right-expected.png:
  • platform/qt/css1/box_properties/padding_bottom-expected.png:
  • platform/qt/css1/box_properties/padding_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/padding_inline-expected.png:
  • platform/qt/css1/box_properties/padding_left-expected.png:
  • platform/qt/css1/box_properties/padding_right-expected.png:
  • platform/qt/css1/cascade/cascade_order-expected.png:
  • platform/qt/css1/cascade/important-expected.png:
  • platform/qt/css1/classification/display-expected.png:
  • platform/qt/css1/color_and_background/background_position-expected.png:
  • platform/qt/css1/color_and_background/background_repeat-expected.png:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/qt/css1/font_properties/font-expected.png:
  • platform/qt/css1/formatting_model/inline_elements-expected.png:
  • platform/qt/css1/formatting_model/vertical_formatting-expected.png:
  • platform/qt/css1/pseudo/anchor-expected.png:
  • platform/qt/css1/pseudo/firstletter-expected.png:
  • platform/qt/css1/pseudo/firstline-expected.png:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/qt/css1/text_properties/text_decoration-expected.png:
  • platform/qt/css1/text_properties/text_indent-expected.png:
  • platform/qt/css1/text_properties/text_transform-expected.png:
  • platform/qt/css1/units/urls-expected.png:
  • platform/qt/css2.1/20110323/c543-txt-decor-000-expected.png:
  • platform/qt/css2.1/20110323/margin-collapse-clear-016-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/qt/css2.1/t051201-c23-first-line-00-b-expected.png:
  • platform/qt/css2.1/t0602-c13-inh-underlin-00-e-expected.png:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/qt/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-17-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18a-expected.png:
5:30 AM Changeset in webkit [131890] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=99828

Unreviewed EFL gardening.

Adding test expectations for failures caused by
r131836 and r131824.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-19

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
5:22 AM Changeset in webkit [131889] by Simon Hausmann
  • 2 edits in trunk/Source/WTF

REGRESSION(r131822): It made 500+ tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=99814

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-10-19
Reviewed by Simon Hausmann.

  • wtf/Platform.h: Disable LLINT on (PLATFORM(QT) && CPU(X86)) temporarily until proper fix.
5:21 AM Changeset in webkit [131888] by kbalazs@webkit.org
  • 18 edits
    2 copies
    35 adds
    2 deletes in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed rebaseline.

Part I.
Identifying wrong results, and rebasing some expected png's.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/borders/border-image-01-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-border-radius-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-longhand-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-outset-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-repeat-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-scaled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-side-reduction-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-source-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-complex-inner-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-different-width-001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/spread-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/arc360-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/iframe-scroll-repaint-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/selection-after-delete-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/selection-after-remove-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/selection-clear-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/qt-5.0-wk2/fast/replaced/absolute-image-sizing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/image-sizing-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/mask-invalidation-expected.png: Copied from LayoutTests/platform/qt/svg/custom/mask-invalidation-expected.png.
  • platform/qt-5.0-wk2/svg/custom/relative-sized-image-expected.png: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/qt-5.0-wk2/transitions/suspend-transform-transition-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/iframe-scroll-repaint-expected.png.
  • platform/qt/TestExpectations:
  • platform/qt/animations/cross-fade-background-image-expected.png:
  • platform/qt/animations/cross-fade-border-image-source-expected.png:
  • platform/qt/animations/cross-fade-list-style-image-expected.png:
  • platform/qt/animations/cross-fade-webkit-mask-image-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/qt/svg/custom/mask-invalidation-expected.png:
  • platform/qt/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/qt/svg/text/remove-tspan-from-text-expected.png:
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Removed.
  • platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Removed.
4:56 AM Changeset in webkit [131887] by Simon Hausmann
  • 2 edits in trunk/Tools

Unreviewed, rolling out r131734.
http://trac.webkit.org/changeset/131734

Broke ANGLE build where we end up with @echo foo && @echo -n

  • qmake/mkspecs/features/default_post.prf:
3:58 AM Changeset in webkit [131886] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Get rid of isSnippetEvaluation flag on UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=99823

Reviewed by Yury Semikhatsky.

Replaced isSnippetEvaluation flag with a pair of isSnippet and isTemporary set.

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._snippetsNavigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype.addTemporaryUISourceCode):

3:57 AM Changeset in webkit [131885] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaseline pixel expectation that is rendered correctly now.

  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
3:10 AM Changeset in webkit [131884] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

REGRESSION(r131844): It broke the build on !ENABLE(NETSCAPE_PLUGIN_API) platforms
https://bugs.webkit.org/show_bug.cgi?id=99820

Reviewed by Jocelyn Turcotte.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Add missing ENABLE(PLUGIN_PROCESS) guard.

  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: The whole file should be ENABLE(NETSCAPE_PLUGIN_API) guarded as the PluginInfoStore class.

(WebKit::PluginInfoStore::getPluginInfo):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Eliminate the unused webPage variable (build fail with -Werror) if !(PLATFORM(MAC)
ENABLE(NETSCAPE_PLUGIN_API)).
3:09 AM Changeset in webkit [131883] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Invalid Regex in SASSSourceMapping/didRequestContent, breaks Support for Sass experiment
https://bugs.webkit.org/show_bug.cgi?id=99729

Reviewed by Vsevolod Vlasov.

Decode only the first line number digit written in a six-character escaped Unicode format.

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):

3:08 AM Changeset in webkit [131882] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bot greening: Follow up to r131877 to fix the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=99739.

Not reviewed.

3:05 AM Changeset in webkit [131881] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for a new Shadow DOM test
that was introduced in r131758, the new baseline differs from
the original one just by an annoying newline at the end of the
document.

Adding test expectations for list styles test failure caused by
r131836. Adding a test expectation for a new a11y test introduced
in r131871.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/shadow/user-modify-in-datalist-crash-expected.txt: Added.
3:00 AM Changeset in webkit [131880] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unskip a few passing tests.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
2:54 AM Changeset in webkit [131879] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Rebaseline a few pixel expectations now that WK1 also shows the resizer in textareas.

  • platform/efl/fast/forms/basic-textareas-expected.png:
  • platform/efl/fast/forms/basic-textareas-quirks-expected.png:
2:43 AM Changeset in webkit [131878] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Build fix after r131741 for !ENABLE(CSS_SHADERS) platforms.
https://bugs.webkit.org/show_bug.cgi?id=99775

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-19
Reviewed by Csaba Osztrogonác.

A class in WebKit namespace is only used when ENABLE(CSS_SHADERS), so we
must guard "using namespace WebKit" by ENABLE(CSS_SHADERS). Otherwise,
it brokes the Qt --minimal build.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::decode):

2:41 AM Changeset in webkit [131877] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bot greening: Attempt to fix broken Window build after r131836.
https://bugs.webkit.org/show_bug.cgi?id=99739.

Not reviewed.

2:18 AM Changeset in webkit [131876] by Carlos Garcia Campos
  • 4 edits in trunk

REGRESSION (r130640 - r130644): TestCookieManager API test is failing
https://bugs.webkit.org/show_bug.cgi?id=98738

Reviewed by Philippe Normand.

Source/WebKit2:

For some reason the order of the domains in the array has changed,
but it doesn't really matter, what we want to check is that both
cookies have been accepted and the array contains both domains.

  • UIProcess/API/gtk/tests/TestCookieManager.cpp:

(testCookieManagerAcceptPolicy): Check that first and third party
domains are present in the domains array.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitCookieManager/accept-policy.

2:03 AM Changeset in webkit [131875] by tommyw@google.com
  • 4 edits in trunk

MediaStream API: Update the RuntimeEnabledFeatures flags
https://bugs.webkit.org/show_bug.cgi?id=99714

Reviewed by Adam Barth.

Source/WebCore:

Updating the RuntimeEnabledFeatures flags to match reality:
isMediaStreamEnabled and isPeerConnectionEnabled should be true by default and
isDeprecatedPeerConnectionEnabled false.

Patch covered by existing tests.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

Tools:

Enabling the DeprecatedPeerConnection so that all tests still run.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

1:59 AM Changeset in webkit [131874] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed fix after r131868.

On JSVALUE64 platforms, JSValue constants can be Imm64 instead of ImmPtr for JIT compilers.

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

1:24 AM Changeset in webkit [131873] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Simplify GCPrologueVisitor
https://bugs.webkit.org/show_bug.cgi?id=99819

Reviewed by Kentaro Hara.

Previously, GCPrologueVisitor used a complicated traits-based template
design. That's not necessary. We can just implement it directly without
template magic.

The one subtly here is that MessagePort is not actually a subclass of
ActiveDOMObject. The next stage of this cleanup is to make MessagePort
inherit from ActiveDOMObject and remove this special case entirely.

  • bindings/v8/V8GCController.cpp:

(WebCore::EnsureWeakDOMNodeVisitor::visitDOMWrapper):
(WebCore):
(WebCore::ActiveDOMObjectPrologueVisitor::visitDOMWrapper):
(WebCore::NodeVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcPrologue):

1:02 AM Changeset in webkit [131872] by caseq@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: Saving HAR, snapshots and timeline data do not work in remote debugging mode
https://bugs.webkit.org/show_bug.cgi?id=99179

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-19
Reviewed by Yury Semikhatsky.

Added method "close" to InspectorFrontendHost.
Symantically, this method forces to flush all unsaved buffers for
specified file. In native implementation this turns to be no-op.

In stub implementation "close" causes compilation of blob object an
navigating to blob-schema url.

Removed "canAppend", as appending in now suppurted
by all implementations.

Repaced schema "data" with "blob" in InspectorFrontendHostStub "save"
to avoid out-of-memory errors.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::close): Compiles blob object and
navigates to blob-object url.
(WebCore):

  • inspector/InspectorFrontendHost.h: Added "close" method.
  • inspector/InspectorFrontendHost.idl: Ditto.
  • inspector/front-end/FileManager.js:

(WebInspector.FileManager.prototype.close): Proxy to InspectorFrontend.

  • inspector/front-end/FileUtils.js:

(WebInspector.FileOutputStream.prototype.close):
Invoke "close" on FileManager.
(WebInspector.FileOutputStream.prototype._onAppendDone): Ditto.

  • inspector/front-end/HandlerRegistry.js: Added mandatory "close" call.
  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.canSaveToFile): Fixed check.

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):
Added "appendable" behaviour emulation.

  • inspector/front-end/SourceFrame.js: Added mandatory "close" call.
  • inspector/front-end/externs.js: Replaced "canAppend" with "close"
1:01 AM Changeset in webkit [131871] by dmazzoni@google.com
  • 14 edits
    4 adds in trunk

AX: labelForElement is slow when there are a lot of DOM elements
https://bugs.webkit.org/show_bug.cgi?id=97825

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a DocumentOrderedMap to TreeScope that allows accessibility to
quickly map from an id to the label for that id. This speeds up
AccessibilityNode::labelForElement, which was a bottleneck in Chromium
when accessibility was on.

Tests: accessibility/title-ui-element-correctness.html

perf/accessibility-title-ui-element.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::labelForElement):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesLabelForAttribute):
(WebCore):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):

  • dom/DocumentOrderedMap.h:

(DocumentOrderedMap):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateLabel):
(WebCore):
(WebCore::Element::willModifyAttribute):

  • dom/Element.h:

(Element):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::destroyTreeScopeData):
(WebCore::TreeScope::addLabel):
(WebCore):
(WebCore::TreeScope::removeLabel):
(WebCore::TreeScope::labelElementForId):

  • dom/TreeScope.h:

(WebCore):
(TreeScope):
(WebCore::TreeScope::shouldCacheLabelsByForAttribute):

Tools:

Implement titleUIElement in the chromium port of DRT, and
fix getAccessibleElementById so that it ensures the backing store
is up-to-date.

  • DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:

(AccessibilityController::getAccessibleElementById):

  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:

(AccessibilityUIElement::titleUIElementCallback):

LayoutTests:

Adds two new tests for titleUIElement that run on both Mac and
Chromium. One tests correctness, the other tests speed.

Fixes one test so that it passes on Chromium.
Enables other tests that now pass on Chromium.

  • accessibility/secure-textfield-title-ui.html:
  • accessibility/title-ui-element-correctness-expected.txt: Added.
  • accessibility/title-ui-element-correctness.html: Added.
  • perf/accessibility-title-ui-element-expected.txt: Added.
  • perf/accessibility-title-ui-element.html: Added.
  • platform/chromium/TestExpectations:
12:51 AM Changeset in webkit [131870] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Update localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=99701

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-19
Reviewed by Yury Semikhatsky.

Fixed most of missing strings and orphans.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:
12:45 AM Changeset in webkit [131869] by loislo@chromium.org
  • 15 edits in trunk

Web Inspector: NMI provide data for mixing with tcmalloc heap dumps.
https://bugs.webkit.org/show_bug.cgi?id=99457

Reviewed by Yury Semikhatsky.

Source/WebCore:

countObjectSize now accepts ptr as the first argument and saves it into HashMap if the binary was ran with HEAPPROFILE env variable.
getProcessMemoryDistribution does snapshot and calls the downstream code with the map of counted objects.

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::dumpUncountedAllocatedObjects):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::reportJSHeapInfo):
(WebCore::reportRenderTreeInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::countObjectSize):
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationClientImpl):
(WebCore::MemoryInstrumentationClientImpl::countedObjects):

Source/WebKit/chromium:

Embedder's code wraps the map with counted objects info into InstrumentedObjectSizeProvider
and forces downstream code to make tcmalloc heap snapshot.
The default implementation is empty.

  • public/WebDevToolsAgentClient.h:

(InstrumentedObjectSizeProvider):
(WebKit::WebDevToolsAgentClient::InstrumentedObjectSizeProvider::~InstrumentedObjectSizeProvider):
(WebKit::WebDevToolsAgentClient::dumpUncountedAllocatedObjects):
(WebDevToolsAgentClient):

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::dumpUncountedAllocatedObjects):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::getAllocatedObjects):
(WebKit::WebDevToolsAgentImpl::dumpUncountedAllocatedObjects):
(WebKit):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

Source/WTF:

countObjectSize now accepts ptr as the first argument and saves it into HashMap if the binary was ran with HEAPPROFILE env variable.
getProcessMemoryDistribution does snapshot and calls the downstream code with the map of counted objects.

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):
(WTF::MemoryInstrumentation::countObjectSize):
(WTF::MemoryInstrumentation::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF::MemoryInstrumentation::addListHashSet):
(WTF::::process):

Tools:

countObjectSize now requires pointer to object as the first argument.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
12:42 AM WebKitGTK/1.10.x edited by Philippe Normand
(diff)
12:35 AM WebKitGTK/1.10.x edited by Philippe Normand
(diff)
12:24 AM Changeset in webkit [131868] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Baseline array profiling should be less accurate, and DFG OSR exit should update array profiles on CheckArray and CheckStructure failure
https://bugs.webkit.org/show_bug.cgi?id=99261

Reviewed by Oliver Hunt.

This makes array profiling stochastic, like value profiling. The point is to avoid
noticing one-off indexing types that we'll never see again, but instead to:

Notice the big ones: We want the DFG to compile based on the things that happen with
high probability. So, this change makes array profiling do like value profiling and
only notice a random subsampling of indexing types that flowed through an array
access. Prior to this patch array profiles noticed all indexing types and weighted
them identically.

Bias the recent: Often an array access will see awkward indexing types during the
first handful of executions because of artifacts of program startup. So, we want to
bias towards the indexing types that we saw most recently. With this change, array
profiling does like value profiling and usually tells use a random sampling that
is biased to what happened recently.

Have a backup plan: The above two things don't work by themselves because our
randomness is not that random (nor do we care enough to make it more random), and
because some procedures will have a <1/10 probability event that we must handle
without bailing because it dominates a hot loop. So, like value profiling, this
patch makes array profiling use OSR exits to tell us why we are bailing out, so
that we don't make the same mistake again in the future.

This change also makes the way that the 32-bit OSR exit compiler snatches scratch
registers more uniform. We don't need a scratch buffer when we can push and pop.

  • bytecode/DFGExitProfile.h:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitArrayProfilingSite):

  • llint/LowLevelInterpreter.asm:
12:18 AM Changeset in webkit [131867] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

WebPageProxy::canShowMIMEType() should return false for plugins when they are disabled
https://bugs.webkit.org/show_bug.cgi?id=99449

Reviewed by Anders Carlsson.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType): Test that
webkit_web_view_can_show_mime_type() returns FALSE if plugins are
disabled.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType): Return false for
MIME-Type of plugins if they are disabled.

12:07 AM Changeset in webkit [131866] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] DOMObjectVisitor does nothing
https://bugs.webkit.org/show_bug.cgi?id=99812

Reviewed by Kentaro Hara.

This code doesn't do anything, even in Debug! We should just remove it.

  • bindings/v8/V8GCController.cpp:

(WebCore):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

12:05 AM Changeset in webkit [131865] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused typedef from V8GCController.cpp
https://bugs.webkit.org/show_bug.cgi?id=99808

Reviewed by Kentaro Hara.

This typedef is not used.

  • bindings/v8/V8GCController.cpp:

Oct 18, 2012:

11:58 PM Changeset in webkit [131864] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Styles] Property considered overridden if it is non-inherited important property in inherited style
https://bugs.webkit.org/show_bug.cgi?id=99720

Reviewed by Yury Semikhatsky.

Source/WebCore:

Non-inherited properties are now disregarded in inherited styles.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/resources/elements-panel-styles.css:

(#container):
(.foo):

11:40 PM Changeset in webkit [131863] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] GrouperVisitor is secretly two entirely separate objects
https://bugs.webkit.org/show_bug.cgi?id=99810

Reviewed by Kentaro Hara.

We can separate out the two things that GrouperVisitor is trying to do
because they have nothing to do with each other.

  • bindings/v8/V8GCController.cpp:

(ObjectVisitor):
(WebCore::ObjectVisitor::visitDOMWrapper):
(WebCore):
(WebCore::V8GCController::gcPrologue):

11:34 PM Changeset in webkit [131862] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

quirk-orphaned-units.html should be removed from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=99807

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-18
Reviewed by Csaba Osztrogonác.

quirk-orphaned-units.html is no more existed, so it should be removed from TestExpectations.

  • platform/qt-mac/TestExpectations: Remove quirk-orphaned-units.html.
11:34 PM Changeset in webkit [131861] by beidson@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit2

Move ConnectionStack out of WebProcessConnection into its own files.
https://bugs.webkit.org/show_bug.cgi?id=99813

Reviewed by Andreas Kling.

ConnectionStack will need to be used in a few upcoming areas, so it needs to be in its own header and implementation files.

Project file stuff:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:

Move it from here:

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::setGlobalException):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):

Into here:

  • Shared/ConnectionStack.cpp: Added.

(WebKit):
(WebKit::ConnectionStack::shared):

  • Shared/ConnectionStack.h: Added.

(CoreIPC):
(WebKit):
(ConnectionStack):
(WebKit::ConnectionStack::current):
(CurrentConnectionPusher):
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher):
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher):

11:23 PM Changeset in webkit [131860] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r131858): It broke the ARM build
https://bugs.webkit.org/show_bug.cgi?id=99809

Reviewed by Csaba Osztrogonác.

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

10:50 PM Changeset in webkit [131859] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add shortMonthLabels and shortStandAloneMonthLabels to Localizer
https://bugs.webkit.org/show_bug.cgi?id=99787

  • tests/LocaleMacTest.cpp:

(TEST_F): Disable tests depends on OS X versions.

10:46 PM Changeset in webkit [131858] by yuqiang.xian@intel.com
  • 27 edits in trunk/Source/JavaScriptCore

Refactor MacroAssembler interfaces to differentiate the pointer operands from the 64-bit integer operands
https://bugs.webkit.org/show_bug.cgi?id=99154

Reviewed by Gavin Barraclough.

In current JavaScriptCore implementation for JSVALUE64 platform (i.e.,
the X64 platform), we assume that the JSValue size is same to the
pointer size, and thus EncodedJSValue is simply type defined as a
"void*". In the JIT compiler, we also take this assumption and invoke
the same macro assembler interfaces for both JSValue and pointer
operands. We need to differentiate the operations on pointers from the
operations on JSValues, and let them invoking different macro
assembler interfaces. For example, we now use the interface of
"loadPtr" to load either a pointer or a JSValue, and we need to switch
to using "loadPtr" to load a pointer and some new "load64" interface
to load a JSValue. This would help us supporting other JSVALUE64
platforms where pointer size is not necessarily 64-bits, for example
x32 (bug #99153).

The major modification I made is to introduce the "*64" interfaces in
the MacroAssembler for those operations on JSValues, keep the "*Ptr"
interfaces for those operations on real pointers, and go through all
the JIT compiler code to correct the usage.

This is the second part of the work, i.e, to correct the usage of the
new MacroAssembler interfaces in the JIT compilers, which also means
that now EncodedJSValue is defined as a 64-bit integer, and the "*64"
interfaces are used for it.

  • assembler/MacroAssembler.h: JSValue immediates should be in Imm64 instead of ImmPtr.

(MacroAssembler):
(JSC::MacroAssembler::shouldBlind):

  • dfg/DFGAssemblyHelpers.cpp: Correct the JIT compilers usage of the new interfaces.

(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::branchIfNotCell):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGScratchRegisterAllocator.h:

(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImm64):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::branch64):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compileContiguousGetByVal):
(JSC::DFG::SpeculativeJIT::compileArrayStorageGetByVal):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compileArrayStoragePutByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::virtualForThunkGenerator):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JIT):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_div):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

  • jit/JITInlineMethods.h: Have some clean-up work as well.

(JSC):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::emitGetFromCallFrameHeader64):
(JSC::JIT::emitAllocateJSArray):
(JSC::JIT::emitValueProfilingSite):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitPutVirtualRegister):
(JSC::JIT::emitInitRegister):
(JSC::JIT::emitJumpIfJSCell):
(JSC::JIT::emitJumpIfBothJSCells):
(JSC::JIT::emitJumpIfNotJSCell):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitJumpIfImmediateInteger):
(JSC::JIT::emitJumpIfNotImmediateInteger):
(JSC::JIT::emitJumpIfNotImmediateIntegers):
(JSC::JIT::emitFastArithReTagImmediate):
(JSC::JIT::emitFastArithIntToImmNoCheck):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_throw_reference_error):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_lazy_reg):
(JSC::JIT::emitSlow_op_convert_this):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emit_op_get_argument_by_val):
(JSC::JIT::emit_op_put_to_base):
(JSC::JIT::emit_resolve_operations):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jit/JITStubCall.h:

(JITStubCall):
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::addArgument):
(JSC::JITStubCall::call):
(JSC::JITStubCall::callWithValueProfiling):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::emitJumpIfImmediateNumber):
(JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber):
(JSC::JSInterfaceJIT::emitLoadJSCell):
(JSC::JSInterfaceJIT::emitLoadInt32):
(JSC::JSInterfaceJIT::emitLoadDouble):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::tagReturnAsInt32):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h: Define JSVALUE64 EncodedJSValue as int64_t, which is also unified with JSVALUE32_64.

(JSC):

  • runtime/JSValueInlineMethods.h: New implementation of some JSValue methods to make them more conformant

with the new rule that "JSValue is a 64-bit integer rather than a pointer" for JSVALUE64 platforms.
(JSC):
(JSC::JSValue::JSValue):
(JSC::JSValue::operator bool):
(JSC::JSValue::operator==):
(JSC::JSValue::operator!=):
(JSC::reinterpretDoubleToInt64):
(JSC::reinterpretInt64ToDouble):
(JSC::JSValue::asDouble):

10:36 PM Changeset in webkit [131857] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Automatically start plugins created within a user gesture, skipping snapshotting
https://bugs.webkit.org/show_bug.cgi?id=99778

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-18
Reviewed by Alexey Proskuryakov.

If a user gesture is being processed, do not set the display state of
HTMLPluginImageElement to WaitingForSnapshot.

No new tests, since it only affects when plugins switch from snapshot to running
state. Does not affect rendering of other elements.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):

10:32 PM Changeset in webkit [131856] by dpranke@chromium.org
  • 5 edits in trunk/Tools

make move_overwritten_baselines_to work again while rebaselining
https://bugs.webkit.org/show_bug.cgi?id=99793

Reviewed by Ojan Vafai.

We used to have code that would help when rebaselining results
for new ports (e.g., when moving from Lion to Mountain Lion) but
it appears that code bitrotted during all the refactoring since
the last time we needed this. This patch makes things work
again, adds more tests that will hopefully make clearer what
is supposed to work, and renames various parameters to be
consistent.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(move_overwritten_baselines_to):
(builder_path_for_port_name):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest.init):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._rebaseline_commands):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_json_with_move_overwritten_baselines_to):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaselineall):

10:17 PM Changeset in webkit [131855] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove entries for now-passing tests in chroum-mac-mountainlion.

Unreviewed, expectations change.

  • platform/chromium-mac-mountainlion/TestExpectations:
10:08 PM Changeset in webkit [131854] by tkent@chromium.org
  • 13 edits in trunk/Source

Add shortMonthLabels and shortStandAloneMonthLabels to Localizer
https://bugs.webkit.org/show_bug.cgi?id=99787

Reviewed by Kentaro Hara.

Source/WebCore:

This is going to be used for input[type=month] UI. This doesn't affect
any bahevior yet.

Tests: Add some tests to Source/WebKit/chromium/tests/, and will add
layout tests later.

  • platform/text/Localizer.h:

(Localizer): Add shortMonthLabels and shortStandAloneMonthLabels as pure
virtual member functions.

  • platform/text/LocaleICU.h:

(LocaleICU): Declare shortMonthLabels and shortStandAloneMonthLabels.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::shortMonthLabels): Added.
(WebCore::LocaleICU::shortStandAloneMonthLabels): Added.

  • platform/text/LocaleNone.cpp:

(LocaleNone): Declare shortMonthLabels and shortStandAloneMonthLabels.
(WebCore::LocaleNone::shortMonthLabels):
Added. Always returns English labels.
(WebCore::LocaleNone::shortStandAloneMonthLabels):
Addes. Just calls shortMonthLabels.

  • platform/text/LocaleWin.h:

(LocaleWin): Declare shortMonthLabels and shortStandAloneMonthLabels.

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::shortMonthLabels): Added.
(WebCore::LocaleWin::shortStandAloneMonthLabels):
Added. Always returns shortMonthLabels.

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Declare shortMonthLabels and shortStandAloneMonthLabels.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::shortMonthLabels): Added.
(WebCore::LocaleMac::shortStandAloneMonthLabels): Added.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::shortMonthLabel): A helper.
(LocaleMacTest::shortStandAloneMonthLabel): Ditto.
(TEST_F): Added tests for some locales.

  • tests/LocaleWinTest.cpp:

(LocaleWinTest::shortMonthLabel): A helper.
(TEST_F): Added tests for some locales. We don't test
LocaleWin::shortStandAloneMonthLabels because it is identical to
shortMonthLabels.

  • tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::shortMonthLabel): A helper.
(LocalizedDateICUTest::shortStandAloneMonthLabel): Ditto.
(TEST_F): Added tests for some locales.

9:45 PM Changeset in webkit [131853] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Implement value sanitization algorithm for type=datetime
https://bugs.webkit.org/show_bug.cgi?id=76893

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-18
Reviewed by Kent Tamura.

Source/WebCore:

Implement the value sanitization algorithm for type=datetime that adjusts
the value to a valid normalized forced-UTC global date and time string.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#valid-normalized-forced-utc-global-date-and-time-string

Test: fast/forms/datetime/datetime-value-sanitization.html

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::sanitizeValue): Implemented.
(WebCore):

  • html/DateTimeInputType.h:

(DateTimeInputType): Add sanitizeValue.

  • platform/DateComponents.cpp:

(WebCore::DateComponents::addMinute): Fixed a bug that caused wrong adjustment
of timezone offset (e.g. 2012-10-17T01:00+01:00 -> 2012-10-17T01:-60Z).

LayoutTests:

Added a test for the value sanitization algorithm for type=datetime.
Also updated affected tests.

  • fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt:
  • fast/forms/datetime/ValidityState-typeMismatch-datetime.html:

'0001-01-01T00:00+01:00' is an invalid value because that is before
0001-01-01 00:00 UTC. '0001-01-01T00:00-01:00' is a valid value.

  • fast/forms/datetime/datetime-value-sanitization-expected.txt: Added.
  • fast/forms/datetime/datetime-value-sanitization.html: Added.
  • fast/forms/datetime/input-valueasdate-datetime-expected.txt:
  • fast/forms/datetime/input-valueasdate-datetime.html:

Setting valueAsDate should run the algorithm to convert a Date object to a
string, that returns valid normalized forced-UTC global date and time string.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasdate

  • fast/forms/datetime/input-valueasnumber-datetime-expected.txt:
  • fast/forms/datetime/input-valueasnumber-datetime.html:

Setting valueAsNumber should run the algorithm to convert a number to a
string, that returns valid normalized forced-UTC global date and time string.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasnumber

9:35 PM Changeset in webkit [131852] by dpranke@chromium.org
  • 4 edits
    2 copies
    2 adds in trunk/LayoutTests

Unreviewed, expectations and baselines for chromium-mac-mountainlion

  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png.
  • platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt.
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium/TestExpectations:
9:12 PM Changeset in webkit [131851] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Move ewk_{init,shutdown}() to the main() function of EFL API test.
https://bugs.webkit.org/show_bug.cgi?id=99681

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

The ewk_{init,shutdown}() is called whenever processing the each test,
so tests can be failed if EFL libraries APIs are called between
ewk_shutdown() and next ewk_init().
The ewk_{init,shutdown}() should be called once per application.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):
(EWK2UnitTest::EWK2UnitTestBase::TearDown):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:

(main):

9:02 PM Changeset in webkit [131850] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Skip really old flaky failing jscore date test.
There's a bug tracking it here: https://bugs.webkit.org/show_bug.cgi?id=53712.

  • Scripts/run-javascriptcore-tests:
8:49 PM Changeset in webkit [131849] by commit-queue@webkit.org
  • 7 edits in trunk

Fix build warning.
https://bugs.webkit.org/show_bug.cgi?id=99788

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-18
Reviewed by Kentaro Hara.

Source/WebCore:

Use UNUSED_PARAM macro for removing -Wunused-parameter.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentTransform):

Source/WebKit2:

Remove parameter name or use ASSERT_UNUSED macro for removing
-Wunused-parameter.

  • PluginProcess/unix/PluginProcessMainUnix.cpp:

(WebKit::PluginProcessMainUnix):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):

Tools:

Use return value of mktemp() for removing -Wunused-result.

  • MiniBrowser/efl/main.c:

(on_download_request):

8:12 PM Changeset in webkit [131848] by dpranke@chromium.org
  • 86 edits
    85 copies
    4 moves
    16 adds in trunk/LayoutTests

Land first batch of Chromium Mac 10.8-specific baselines.

Unreviewed, gardening.

  • animations/cross-fade-background-image-expected.png: Renamed from LayoutTests/platform/efl/animations/cross-fade-background-image-expected.png.
  • animations/cross-fade-border-image-source-expected.png: Renamed from LayoutTests/platform/efl/animations/cross-fade-border-image-source-expected.png.
  • animations/cross-fade-list-style-image-expected.png: Renamed from LayoutTests/platform/efl/animations/cross-fade-list-style-image-expected.png.
  • animations/cross-fade-webkit-mask-image-expected.png: Renamed from LayoutTests/platform/efl/animations/cross-fade-webkit-mask-image-expected.png.
  • platform/chromium-mac-lion/animations/3d/change-transform-in-end-event-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/3d/change-transform-in-end-event-expected.png.
  • platform/chromium-mac-lion/animations/3d/matrix-transform-type-animation-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
  • platform/chromium-mac-lion/animations/3d/state-at-end-event-transform-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
  • platform/chromium-mac-lion/animations/cross-fade-background-image-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/cross-fade-background-image-expected.png.
  • platform/chromium-mac-lion/animations/cross-fade-border-image-source-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/cross-fade-border-image-source-expected.png.
  • platform/chromium-mac-lion/animations/cross-fade-list-style-image-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/cross-fade-list-style-image-expected.png.
  • platform/chromium-mac-lion/animations/cross-fade-webkit-mask-image-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/cross-fade-webkit-mask-image-expected.png.
  • platform/chromium-mac-lion/animations/state-at-end-event-expected.png: Copied from LayoutTests/platform/chromium-mac/animations/state-at-end-event-expected.png.
  • platform/chromium-mac-lion/compositing/animation/state-at-end-event-transform-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/animation/state-at-end-event-transform-layer-expected.png.
  • platform/chromium-mac-lion/compositing/color-matching/pdf-image-match-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/color-matching/pdf-image-match-expected.png.
  • platform/chromium-mac-lion/compositing/compositing-visible-descendant-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/compositing-visible-descendant-expected.png.
  • platform/chromium-mac-lion/compositing/generated-content-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/generated-content-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/abs-position-inside-opacity-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/abs-position-inside-opacity-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/composited-html-size-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-in-composited-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-in-composited-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-composited-page-scale-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/outline-change-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/outline-change-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/partial-layout-update-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/partial-layout-update-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/root-layer-update-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/root-layer-update-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/video-fixed-scrolling-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png.
  • platform/chromium-mac-lion/compositing/geometry/video-opacity-overlay-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png.
  • platform/chromium-mac-lion/compositing/iframes/composited-iframe-alignment-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png.
  • platform/chromium-mac-lion/compositing/iframes/iframe-copy-on-scroll-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/iframes/iframe-copy-on-scroll-expected.png.
  • platform/chromium-mac-lion/compositing/images/direct-image-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/images/direct-image-background-color-expected.png.
  • platform/chromium-mac-lion/compositing/layers-inside-overflow-scroll-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png.
  • platform/chromium-mac-lion/compositing/masks/direct-image-mask-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/masks/direct-image-mask-expected.png.
  • platform/chromium-mac-lion/compositing/masks/masked-ancestor-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/masks/masked-ancestor-expected.png.
  • platform/chromium-mac-lion/compositing/masks/multiple-masks-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/masks/multiple-masks-expected.png.
  • platform/chromium-mac-lion/compositing/masks/simple-composited-mask-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/ancestor-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/fixed-position-ancestor-clip-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/nested-scrolling-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/overflow-compositing-descendant-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/overflow-positioning-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/overflow-scroll-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/parent-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/parent-overflow-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/remove-overflow-crash2-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/remove-overflow-crash2-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/scrollbar-painting-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/scrollbar-painting-expected.png.
  • platform/chromium-mac-lion/compositing/overflow/theme-affects-visual-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/overflow/theme-affects-visual-overflow-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/animation-inside-reflection-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/compositing-change-inside-reflection-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/compositing-change-inside-reflection-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/deeply-nested-reflections-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/deeply-nested-reflections-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/masked-reflection-on-composited-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/masked-reflection-on-composited-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-animated-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-mask-change-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-mask-change-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-on-overflow-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-opacity-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-opacity-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-size-change-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-size-change-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transformed2-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transition-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/reflection-in-composited-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/reflection-on-composited-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/reflection-on-composited-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/reflection-ordering-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/reflection-ordering-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/reflection-positioning-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/reflection-positioning-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/reflection-positioning2-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/reflection-positioning2-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/simple-composited-reflections-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png.
  • platform/chromium-mac-lion/compositing/reflections/transform-inside-reflection-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/reflections/transform-inside-reflection-expected.png.
  • platform/chromium-mac-lion/compositing/repaint/become-overlay-composited-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/repaint/become-overlay-composited-layer-expected.png.
  • platform/chromium-mac-lion/compositing/repaint/composited-document-element-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/repaint/composited-document-element-expected.png.
  • platform/chromium-mac-lion/compositing/repaint/layer-repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/repaint/layer-repaint-expected.png.
  • platform/chromium-mac-lion/compositing/repaint/layer-repaint-rects-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/repaint/layer-repaint-rects-expected.png.
  • platform/chromium-mac-lion/compositing/repaint/opacity-between-absolute-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/repaint/opacity-between-absolute-expected.png.
  • platform/chromium-mac-lion/compositing/repaint/opacity-between-absolute2-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/repaint/opacity-between-absolute2-expected.png.
  • platform/chromium-mac-lion/compositing/self-painting-layers-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/self-painting-layers-expected.png.
  • platform/chromium-mac-lion/compositing/sibling-positioning-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/sibling-positioning-expected.png.
  • platform/chromium-mac-lion/compositing/text-on-large-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/text-on-large-layer-expected.png.
  • platform/chromium-mac-lion/compositing/transitions/scale-transition-no-start-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/transitions/scale-transition-no-start-expected.png.
  • platform/chromium-mac-lion/compositing/transitions/singular-scale-transition-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/transitions/singular-scale-transition-expected.png.
  • platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png.
  • platform/chromium-mac-lion/compositing/webgl/webgl-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/webgl/webgl-background-color-expected.png.
  • platform/chromium-mac-lion/compositing/webgl/webgl-reflection-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/webgl/webgl-reflection-expected.png.
  • platform/chromium-mac/animations/3d/change-transform-in-end-event-expected.png:
  • platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png:
  • platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
  • platform/chromium-mac/animations/cross-fade-background-image-expected.png:
  • platform/chromium-mac/animations/cross-fade-border-image-source-expected.png:
  • platform/chromium-mac/animations/cross-fade-list-style-image-expected.png:
  • platform/chromium-mac/animations/cross-fade-webkit-mask-image-expected.png:
  • platform/chromium-mac/animations/state-at-end-event-expected.png:
  • platform/chromium-mac/compositing/animation/state-at-end-event-transform-layer-expected.png:
  • platform/chromium-mac/compositing/color-matching/pdf-image-match-expected.png:
  • platform/chromium-mac/compositing/compositing-visible-descendant-expected.png:
  • platform/chromium-mac/compositing/generated-content-expected.png:
  • platform/chromium-mac/compositing/geometry/abs-position-inside-opacity-expected.png:
  • platform/chromium-mac/compositing/geometry/composited-html-size-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac/compositing/geometry/outline-change-expected.png:
  • platform/chromium-mac/compositing/geometry/partial-layout-update-expected.png:
  • platform/chromium-mac/compositing/geometry/root-layer-update-expected.png:
  • platform/chromium-mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png:
  • platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-mac/compositing/images/direct-image-background-color-expected.png:
  • platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.png:
  • platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/overflow/parent-overflow-expected.png:
  • platform/chromium-mac/compositing/overflow/remove-overflow-crash2-expected.png:
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-mac/compositing/overflow/theme-affects-visual-overflow-expected.png:
  • platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/compositing-change-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/masked-reflection-on-composited-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-mask-change-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-opacity-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-size-change-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-ordering-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-positioning-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-positioning2-expected.png:
  • platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/repaint/become-overlay-composited-layer-expected.png:
  • platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:
  • platform/chromium-mac/compositing/repaint/layer-repaint-expected.png:
  • platform/chromium-mac/compositing/repaint/layer-repaint-rects-expected.png:
  • platform/chromium-mac/compositing/repaint/opacity-between-absolute-expected.png:
  • platform/chromium-mac/compositing/repaint/opacity-between-absolute2-expected.png:
  • platform/chromium-mac/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac/compositing/sibling-positioning-expected.png:
  • platform/chromium-mac/compositing/text-on-large-layer-expected.png:
  • platform/chromium-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-mac/compositing/transitions/singular-scale-transition-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/compositing/webgl/webgl-background-color-expected.png:
  • platform/chromium-mac/compositing/webgl/webgl-reflection-expected.png:
8:07 PM Changeset in webkit [131847] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

Attempt to fix the WebKit2/Efl build after r131841.

Unreviewed build fix.

Rename addMessageReceiver to deprecatedAddMessageReceiver.

  • UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):

  • UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):

8:03 PM Changeset in webkit [131846] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Incorrect check performed in Media Source objects test.
https://bugs.webkit.org/show_bug.cgi?id=99390

Patch by Anand Chakravarty <anandc@google.com> on 2012-10-18
Reviewed by Eric Carlson.

Use an expected value of 5 in the buffered attribute.

  • http/tests/media/media-source/video-media-source-objects-expected.txt:
  • http/tests/media/media-source/video-media-source-objects.html:
8:00 PM Changeset in webkit [131845] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Use of uninitialized variable in Media Source API test.
https://bugs.webkit.org/show_bug.cgi?id=99387

Patch by Anand Chakravarty <anandc@google.com> on 2012-10-18
Reviewed by Eric Carlson.

Set value of seekTime to 1 before using it.

  • http/tests/media/media-source/video-media-source-state-changes.html:
7:43 PM Changeset in webkit [131844] by commit-queue@webkit.org
  • 44 edits in trunk

[WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
https://bugs.webkit.org/show_bug.cgi?id=99771

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-18
Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in: The symbol is used by WebCore Test Support, move it

to the general section.

Source/WebKit2:

Add ENABLE(PLUGIN_PROCESS), ENABLE(SHARED_WORKER_PROCESS) and ENABLE(NETSCAPE_PLUGIN_API)
as needed to exclude the code with dependencies on PLUGIN_PROCESS.

  • Platform/CoreIPC/MessageID.h:
  • Shared/SharedWorkerProcessCreationParameters.cpp:
  • Shared/SharedWorkerProcessCreationParameters.h:
  • SharedWorkerProcess/SharedWorkerProcess.cpp:
  • SharedWorkerProcess/SharedWorkerProcess.h:
  • SharedWorkerProcess/SharedWorkerProcess.messages.in:
  • SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetAdditionalPluginsDirectory):
(WKContextGetPluginSiteDataManager):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetTypeID):
(WKPluginSiteDataManagerGetSitesWithData):

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::createProcess):

  • UIProcess/Plugins/PluginInfoStore.cpp:
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:
  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

  • UIProcess/SharedWorkers/SharedWorkerProcessManager.cpp:
  • UIProcess/SharedWorkers/SharedWorkerProcessManager.h:
  • UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
  • UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
  • UIProcess/SharedWorkers/SharedWorkerProcessProxy.messages.in:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):
(WebKit):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

  • UIProcess/WebProcessProxy.cpp:

(WebKit):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:
  • WebKit2Prefix.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::recreatePlugin):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::WebPlatformStrategies):
(WebKit::WebPlatformStrategies::refreshPlugins):
(WebKit::WebPlatformStrategies::getPluginInfo):
(WebKit):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):
(WebKit):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::createPlugin):
(WebKit::canPluginHandleResponse):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit):

  • WebProcess/WebProcess.h:

(WebProcess):

  • WebProcess/WebProcess.messages.in:

Tools:

  • DumpRenderTree/mac/MockWebNotificationProvider.mm: The file was not including config.h,

effectively breaking feature flags.

7:35 PM Changeset in webkit [131843] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Buildfix if Netscape plugin support is disabled
https://bugs.webkit.org/show_bug.cgi?id=99757

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

.:

Set ENABLE_PLUGIN_PROCESS only if ENABLE_NETSCAPE_PLUGIN_API is set.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

Guard PluginProcessMainUnix.cpp with ENABLE(PLUGIN_PROCESS).

  • PluginProcess/unix/PluginProcessMainUnix.cpp:
7:33 PM Changeset in webkit [131842] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

De-dup expectations for chromium mountainlion

Unreviewed, expectations update.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium/TestExpectations:
7:29 PM Changeset in webkit [131841] by andersca@apple.com
  • 17 edits in trunk/Source/WebKit2

Deprecate the current version of MessageReceiverMap::addMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=99797

Reviewed by Andreas Kling.

Rename addMessageReceiver to deprecatedAddMessageReceiver in preparation for adding a new
version that takes a string instead.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::deprecatedAddMessageReceiver):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::deprecatedAddMessageReceiver):
(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::deprecatedAddMessageReceiver):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):

7:19 PM Changeset in webkit [131840] by abarth@webkit.org
  • 4 edits in trunk

[V8] fast/dom/gc-9.html fails for document.styleSheets
https://bugs.webkit.org/show_bug.cgi?id=99786

Reviewed by Kentaro Hara.

Source/WebCore:

V8 needs to know about this IDL attribute as well.

  • css/StyleSheetList.idl:

LayoutTests:

  • platform/chromium/fast/dom/gc-9-expected.txt:
    • Test progression.
7:14 PM Changeset in webkit [131839] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][DRT] Make textareas resizable by default.
https://bugs.webkit.org/show_bug.cgi?id=99719

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

Enable painting the textarea resizer at the corner by default,
just as it already is the case for WK2. This eases the work needed
to get the pixel tests in shape and run by the bots, as both the
WK1 and WK2 ports will have more similar results.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

6:53 PM Changeset in webkit [131838] by abarth@webkit.org
  • 6 edits
    1 add in trunk

[V8] fast/dom/gc-9.html fails for document.implementation
https://bugs.webkit.org/show_bug.cgi?id=99783

Reviewed by Kentaro Hara.

Source/WebCore:

In order to correctly manage the lifetime of document.implementation,
we need to implement GenerateIsReachable=ImplDocument.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateVisitDOMWrapper):

  • bindings/scripts/IDLAttributes.txt:
  • dom/DOMImplementation.idl:

LayoutTests:

  • platform/chromium/TestExpectations:
    • TestExpectations claims that this test is "brain damaged", but it looks like the test has improved since that comment was written and that this test is actually quite valuable.
  • platform/chromium/fast/dom/gc-9-expected.txt: Added.
    • This patch adds a Chromium-specific baseline for this test. Before this patch, we failed the document.implementation subtests.
6:32 PM Changeset in webkit [131837] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Test expectation update.

  • platform/chromium/TestExpectations: Remove entries for passing *-multiple-fieds tests.
  • platform/chromium-mac-mountainlion/TestExpectations: Add them.
6:22 PM Changeset in webkit [131836] by msaboff@apple.com
  • 7 edits in trunk/Source

convertUTF8ToUTF16() Should Check for ASCII Input
ihttps://bugs.webkit.org/show_bug.cgi?id=99739

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Using the updated convertUTF8ToUTF16() , we can determine if is makes more sense to
create a string using the 8 bit source. Added a new OpaqueJSString::create(LChar*, unsigned).
Had to add a cast n JSStringCreateWithCFString to differentiate which create() to call.

  • API/JSStringRef.cpp:

(JSStringCreateWithUTF8CString):

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):

  • API/OpaqueJSString.h:

(OpaqueJSString::create):
(OpaqueJSString):
(OpaqueJSString::OpaqueJSString):

Source/WTF:

Added code to accumulate the "or" of all characters seen during the UTF8 to UTF16 conversion. This is
used to check to see if all characters are ASCII and is returned via a bool*.

  • wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertUTF8ToUTF16):

  • wtf/unicode/UTF8.h:
6:13 PM Changeset in webkit [131835] by jochen@chromium.org
  • 4 edits in trunk

[chromium] Add a webkit_test_support target that WebTestingSupport
https://bugs.webkit.org/show_bug.cgi?id=99772

Reviewed by Adam Barth.

Source/WebKit/chromium:

Before, embedders would need to compile the WebTestingSupport.cpp
themselves, which in turn depends on WebCore headers.

  • WebKit.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
6:06 PM Changeset in webkit [131834] by Chris Fleizach
  • 4 edits in trunk/Source

AX: Crashes in WebProcess at com.apple.WebCore: -[AccessibilityObjectWrapper remoteAccessibilityParentObject] + 78
https://bugs.webkit.org/show_bug.cgi?id=96443

Reviewed by Beth Dakin.

Source/WebCore:

Separate out the chain of calls so that the number of times document() is called is reduced and it will be easier
to determine which line this crash is happening on.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):

Source/WebKit2:

It appears that the crash is due to not checking whether the page object is null.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::accessibilityRemoteObject):

6:04 PM Changeset in webkit [131833] by msaboff@apple.com
  • 3 edits
    1 add in trunk/Source/WTF

Mac WTF build checks dependencies before copying header files
https://bugs.webkit.org/show_bug.cgi?id=99770

Reviewed by Mark Rowe.

Fixed up build rules per Mark Rowe. Made new target an Aggregate and removed "WTF copy".

  • Configurations/CopyWTFHeaders.xcconfig: Added.
  • Configurations/WTF.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
6:03 PM Changeset in webkit [131832] by alecflett@chromium.org
  • 12 edits in trunk/Source

IndexedDB: Refactor IDBDatabaseBackendImpl to use IDBDatabaseMetadata
https://bugs.webkit.org/show_bug.cgi?id=99773

Reviewed by Tony Chang.

Refactor to begin separating out metadata from stateful backend objects,
in preparation for https://bugs.webkit.org/show_bug.cgi?id=99774.

Also includes some #include dependency cleanup so that the backing store
depends less on the stateful backend objects.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(IDBBackingStore):

  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
(WebCore::IDBDatabaseBackendImpl::resetVersion):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::id):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBTransaction.h:

(WebCore):

6:02 PM Changeset in webkit [131831] by pkasting@chromium.org
  • 2 edits in trunk/Source/WebCore

[Skia] Set m_hasAlpha correctly in ImageFrame::copyBitmapData.
https://bugs.webkit.org/show_bug.cgi?id=99781

Reviewed by Adam Barth.

No tests, since the actual effects of this bug are fickle and it's not
clear how to extract and check particular subframes of an animated GIF.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::copyBitmapData):

5:55 PM Changeset in webkit [131830] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unbreak jsc tests.

5:52 PM Changeset in webkit [131829] by commit-queue@webkit.org
  • 12 edits
    13 adds in trunk

Source/WebCore: [Resource Timing]Implementation of resource timing buffer size restriction functionality
https://bugs.webkit.org/show_bug.cgi?id=84885.

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-18
Reviewed by Tony Gentilcore.

http://www.w3.org/TR/2012/CR-resource-timing-20120522/
This patch enable functionality of set buffer size(default is 150 as spec). When buffer is full, resourceTimingBufferFull event will be fired. Incoming entries will be dropped if no more space for them.

Tests: http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_populate_entries.html

http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_shrink_buffer_size.html
http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_size_restriction.html
http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_clear_resource_timing_functionality.html
http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_on_shrink_buffer_size.html
http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_store_and_clear_during_callback.html

  • page/Performance.cpp:

(WebCore):
(WebCore::Performance::Performance):
(WebCore::Performance::webkitSetResourceTimingBufferSize):
(WebCore::Performance::addResourceTiming):
(WebCore::Performance::isResourceTimingBufferFull):

  • page/Performance.h:

(Performance):

LayoutTests: [Resource Timing]Test cases for set buffer size functionality and event when buffer full.
https://bugs.webkit.org/show_bug.cgi?id=84885.

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-18
Reviewed by Tony Gentilcore.

Test cases in this patch validate buffer size restriction functionality, clear resource timing functionality and the fired event when buffer full.

  • http/tests/w3c/webperf/resources/webperftestharnessextension.js:

(PerformanceContext.prototype.getEntriesByName):
(PerformanceContext.prototype.setResourceTimingBufferSize):
(PerformanceContext.prototype.registerResourceTimingBufferFullCallback):
(PerformanceContext.prototype.clearResourceTimings):

  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_populate_entries-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_populate_entries.html: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_shrink_buffer_size-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_shrink_buffer_size.html: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_size_restriction-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_size_restriction.html: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_clear_resource_timing_functionality-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_clear_resource_timing_functionality.html: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_on_shrink_buffer_size-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_on_shrink_buffer_size.html: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_store_and_clear_during_callback-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_store_and_clear_during_callback.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
5:31 PM Changeset in webkit [131828] by jochen@chromium.org
  • 4 edits
    21 moves
    1 add in trunk/Tools

[chromium] move TestRunner files into a src/ sub directory
https://bugs.webkit.org/show_bug.cgi?id=99776

Reviewed by Adam Barth.

This is in preparation of adding a public API to the TestRunner library.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTTestRunner.h:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h.
  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp.
  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppBoundClass.h.
  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppVariant.cpp.
  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/CppVariant.h.
  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp.
  • DumpRenderTree/chromium/TestRunner/src/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/EventSender.h.
  • DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/GamepadController.cpp.
  • DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/GamepadController.h.
  • DumpRenderTree/chromium/TestRunner/src/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/Task.cpp.
  • DumpRenderTree/chromium/TestRunner/src/Task.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/Task.h.
  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestDelegate.h.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h.
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestRunner.cpp.
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TestRunner.h.
  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TextInputController.cpp.
  • DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/TextInputController.h.
5:21 PM Changeset in webkit [131827] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] garden-o-matic should ignore the 10.8 Tests bot
https://bugs.webkit.org/show_bug.cgi?id=99765

Reviewed by Adam Barth.

It's really more of an FYI bot at this point and can be safely
ignored like the Content Shell bots.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

5:00 PM Changeset in webkit [131826] by mrowe@apple.com
  • 33 edits in trunk/Source/WebCore

Build fix. Remove the svn:executable property from a bunch of files that have no business having it set.

4:59 PM Changeset in webkit [131825] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

Add support for float-valued prefernces
https://bugs.webkit.org/show_bug.cgi?id=99419

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-18
Reviewed by Anders Carlsson.

Support float values for preferences in WK2.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
(WebKit):
(WebKit::defaultValueForKey):

  • Shared/WebPreferencesStore.h:

(WebKit):
(WebPreferencesStore):

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::updateFloatValueForKey):
(WebKit):

  • UIProcess/WebPreferences.h:

(WebPreferences):

  • UIProcess/cf/WebPreferencesCF.cpp:

(WebKit::WebPreferences::platformUpdateFloatValueForKey):
(WebKit):

  • UIProcess/efl/WebPreferencesEfl.cpp:

(WebKit::WebPreferences::platformUpdateFloatValueForKey):
(WebKit):

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformUpdateFloatValueForKey):
(WebKit):

  • UIProcess/mac/WebPreferencesMac.mm:

(WebKit::WebPreferences::platformUpdateFloatValueForKey):
(WebKit):

  • UIProcess/qt/WebPreferencesQt.cpp:

(WebKit::WebPreferences::platformUpdateFloatValueForKey):
(WebKit):

4:56 PM Changeset in webkit [131824] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r130411): Copying & pasting the first line of text can move caret to the end of text area
https://bugs.webkit.org/show_bug.cgi?id=99663

Reviewed by Enrica Casucci and Levi Weintraub.

Source/WebCore:

The bug was caused by positionOnlyToBeUpdated's offset not being shifted correctly in
ReplaceSelectionCommand::mergeTextNodesAroundPosition. Suppose we have text nodes t1 and t2 and
positionOnlyToBeUpdated had offset k in t2. When t2 is merged into t1, positionOnlyToBeUpdated should be
moved to (t1, n + k) where n is the ORIGINAL length of t1 before t2 is merged. But we were using
the length after t2 is merged.

Fixed the bug by saving the original length of t1 and using that in the offset adjustment.
Also use the right offset.

Test: editing/pasteboard/copy-paste-first-line-in-textarea.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):

LayoutTests:

Add a regression test for copying and pasting the first line in a textarea with two lines of text.

  • editing/pasteboard/copy-paste-first-line-in-textarea-expected.txt: Added.
  • editing/pasteboard/copy-paste-first-line-in-textarea.html: Added.
4:39 PM Changeset in webkit [131823] by wjmaclean@chromium.org
  • 5 edits in trunk

[chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression.
https://bugs.webkit.org/show_bug.cgi?id=99632

Reviewed by James Robinson.

Re-enable layout tests for gesture highlights. Includes fix for GestureTapCancel test.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html:
  • platform/chromium/TestExpectations:
4:37 PM Changeset in webkit [131822] by oliver@apple.com
  • 49 edits in trunk/Source/JavaScriptCore

Bytecode should not have responsibility for determining how to perform non-local resolves
https://bugs.webkit.org/show_bug.cgi?id=99349

Reviewed by Gavin Barraclough.

This patch removes lexical analysis from the bytecode generation. This allows
us to delay lookup of a non-local variables until the lookup is actually necessary,
and simplifies a lot of the resolve logic in BytecodeGenerator.

Once a lookup is performed we cache the lookup information in a set of out-of-line
buffers in CodeBlock. This allows subsequent lookups to avoid unnecessary hashing,
etc, and allows the respective JITs to recreated optimal lookup code.

This is currently still a performance regression in LLInt, but most of the remaining
regression is caused by a lot of indirection that I'll remove in future work, as well
as some work necessary to allow LLInt to perform in line instruction repatching.
We will also want to improve the behaviour of the baseline JIT for some of the lookup
operations, however this patch was getting quite large already so I'm landing it now
that we've reached the bar of "performance-neutral".

Basic browsing seems to work.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitStructures):
(JSC):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addResolve):
(JSC::CodeBlock::addPutToBase):
(CodeBlock):
(JSC::CodeBlock::resolveOperations):
(JSC::CodeBlock::putToBaseOperation):
(JSC::CodeBlock::numberOfResolveOperations):
(JSC::CodeBlock::numberOfPutToBaseOperations):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::globalObjectConstant):
(JSC::CodeBlock::setGlobalObjectConstant):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):

  • bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::shouldAvoidResolveGlobal):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetLocalVar):
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC::BytecodeGenerator::emitPutToBase):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ResolveResult::registerResolve):
(JSC::ResolveResult::dynamicResolve):
(ResolveResult):
(JSC::ResolveResult::ResolveResult):
(JSC):
(NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::~NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::resolved):
(JSC::NonlocalResolveInfo::put):
(BytecodeGenerator):
(JSC::BytecodeGenerator::getResolveOperations):
(JSC::BytecodeGenerator::getResolveWithThisOperations):
(JSC::BytecodeGenerator::getResolveBaseOperations):
(JSC::BytecodeGenerator::getResolveBaseForPutOperations):
(JSC::BytecodeGenerator::getResolveWithBaseForPutOperations):
(JSC::BytecodeGenerator::getPutToBaseOperation):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(DFG):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineResolveOperations):
(DFG):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(ResolveOperationData):
(DFG):
(PutToBaseOperationData):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveOperationsDataIndex):
(Node):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::resolveOperations):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::putToBaseOperation):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC):
(JSC::JIT::emit_resolve_operations):
(JSC::JIT::emitSlow_link_resolve_operations):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSScope.cpp:

(JSC::LookupResult::base):
(JSC::LookupResult::value):
(JSC::LookupResult::setBase):
(JSC::LookupResult::setValue):
(LookupResult):
(JSC):
(JSC::setPutPropertyAccessOffset):
(JSC::executeResolveOperations):
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolveContainingScope):
(JSC::JSScope::resolve):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):
(JSC::JSScope::resolvePut):
(JSC::JSScope::resolveGlobal):

  • runtime/JSScope.h:

(JSScope):

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSVariableObject):

  • runtime/Structure.h:

(JSC::Structure::propertyAccessesAreCacheable):
(Structure):

4:13 PM Changeset in webkit [131821] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface
https://bugs.webkit.org/show_bug.cgi?id=99766

Reviewed by Adam Barth.

This reverts http://trac.webkit.org/changeset/123240

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::setDelegate):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
(TestInterfaces::accessibilityController):
(TestInterfaces::eventSender):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

4:06 PM Changeset in webkit [131820] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Invalid read from WebKit::DOMObjectCache::clearByFrame
https://bugs.webkit.org/show_bug.cgi?id=82882

Patch by Claudio Saavedra <Claudio Saavedra> on 2012-10-18
Reviewed by Xan Lopez.

Based on a patch by Milan Crha <mcrha@redhat.com>

Prevent an invalid access to a pointer while clearing the DOM
object cache.

  • bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCache::clearByFrame): Prevent an invalid access.

4:06 PM Changeset in webkit [131819] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

Mac WTF build checks dependencies before copying header files
https://bugs.webkit.org/show_bug.cgi?id=99770

Reviewed by Geoffrey Garen.

Added a new build target "Copy WTF HEaders" to copy the header files and made that new target a dependency
for the main WTF build target. Moved the "Copy WTF Headers" phase from WTF target to the new target.

  • WTF.xcodeproj/project.pbxproj:
3:42 PM Changeset in webkit [131818] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Live oversize copied blocks should count toward overall heap fragmentation
https://bugs.webkit.org/show_bug.cgi?id=99548

Reviewed by Filip Pizlo.

The CopiedSpace uses overall heap fragmentation to determine whether or not it should do any copying.
Currently it doesn't include live oversize CopiedBlocks in the calculation, but it should. We should
treat them as 100% utilized, since running a copying phase won't be able to free/compact any of their
memory. We can also free any dead oversize CopiedBlocks while we're iterating over them, rather than
iterating over them again at the end of the copying phase.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::doneCopying): Also removed a branch when iterating over from-space at the end of
copying. Since we eagerly recycle blocks as soon as they're fully evacuated, we should see no
unpinned blocks in from-space at the end of copying.

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::recycleBorrowedBlock):

  • heap/CopyVisitorInlineMethods.h:

(JSC::CopyVisitor::checkIfShouldCopy):

3:41 PM Changeset in webkit [131817] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fix lint errors/conflicts in ML TestExpectations

Unreviewed, expectations change.

  • platform/chromium-mac-mountainlion/TestExpectations:
3:29 PM Changeset in webkit [131816] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page viewport aspect ratio not kept on navigating back
https://bugs.webkit.org/show_bug.cgi?id=99760

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.
Internally reviewed by Konrad Piascik.

PR: 190469
This was added in r127628 which was trying to fix some rendering
defects on maps.google.com and news.qq.com, however it was very harmful
and caused regressions.
zoomToFitScale() depends on the current contents size. During history
navigation and device rotation, if zoomToFitScale() is based on the
final contents size which is expected, there will still be a scale
calculation like this afterwards
screenSize.width()/screenSize.height()*zoomToFitScale() which will
result in a wrong scale. During the history navigation, if
zoomToFitScale() isn't based on the final contents size, then we will
get the wrong scale as well for sure.
This issue will be fixed by removing the wrong calculation.
The original issue of r127628 was fixed by the patch of PR225981.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

3:24 PM Changeset in webkit [131815] by commit-queue@webkit.org
  • 21 edits
    13 deletes in trunk

Unreviewed, rolling out r131810.
http://trac.webkit.org/changeset/131810
https://bugs.webkit.org/show_bug.cgi?id=99762

Broke linux debug webkit_unit_tests (Requested by
danakj|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-18

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::setData):

  • platform/graphics/ImageSource.h:

(WebCore):
(ImageSource):

  • platform/graphics/chromium/DeferredImageDecoder.cpp: Removed.
  • platform/graphics/chromium/DeferredImageDecoder.h: Removed.
  • platform/graphics/chromium/ImageDecodingStore.cpp: Removed.
  • platform/graphics/chromium/ImageDecodingStore.h: Removed.
  • platform/graphics/chromium/ImageFrameGenerator.cpp: Removed.
  • platform/graphics/chromium/ImageFrameGenerator.h: Removed.
  • platform/graphics/chromium/LazyDecodingPixelRef.cpp: Removed.
  • platform/graphics/chromium/LazyDecodingPixelRef.h: Removed.
  • platform/graphics/chromium/ScaledImageFragment.cpp: Removed.
  • platform/graphics/chromium/ScaledImageFragment.h: Removed.
  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap):

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebSettings.h:
  • src/WebKit.cpp:

(WebKit::shutdown):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • tests/DeferredImageDecoderTest.cpp: Removed.
  • tests/MockImageDecoder.h: Removed.

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/chromium/virtual/deferred/fast/images/README.txt: Removed.
3:08 PM Changeset in webkit [131814] by tommyw@google.com
  • 5 edits in trunk/Source

MediaStream API: Do some cleanup in the chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=99713

Reviewed by Adam Barth.

Source/Platform:

Removing the deprecated version of WebMediaStreamDescriptor::initialize and making
the two constructSDP functions in WebMediaStreamCenter optional to override.
This is part of the preparation to remove PeerConnection00.

  • chromium/public/WebMediaStreamCenter.h:

(WebKit::WebMediaStreamCenter::constructSDP):

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

Source/WebCore:

Removing the deprecated version of WebMediaStreamDescriptor::initialize.

No testing needed since only an unused function is removed.

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
3:07 PM Changeset in webkit [131813] by mkwst@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout tests for wildcarded hosts in CSP directives.
https://bugs.webkit.org/show_bug.cgi?id=99693

Reviewed by Adam Barth.

Adds four test cases to ensure that wildcarded hosts in Content Security
Policy source expressions function correctly with and without paths,
and with wildcarded ports.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-09-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-09.html: Added.
2:48 PM Changeset in webkit [131812] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] update ML-specific failures
https://bugs.webkit.org/show_bug.cgi?id=99505

Unreviewed, expectations change.

  • platform/chromium-mac-mountainlion/TestExpectations:
2:47 PM Changeset in webkit [131811] by Lucas Forschler
  • 4 edits in tags/Safari-537.15.1/Source

Versioning.

2:40 PM Changeset in webkit [131810] by hclam@chromium.org
  • 21 edits
    16 adds in trunk

[chromium] Implement deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=94240

Reviewed by Stephen White.

Source/WebCore:

Objectives:

To record image decoding operations during painting and to defer
decoding operations until rasterization.

Rationale:

This is a key feature that enables impl-side painting which requires
fast recording of drawing operations. The existing decode-on-draw
restricts that recording has to block on expensive decoding operations.
This change allows recording of image decoding operations during paint
time.

Design:

Image decoding happens when a BitmapImage is drawn into a
GraphicsContext. When per-tile painting is enabled GraphicsContext
is backed by SkCanvas in recording mode. This SkCanvas records drawing
and image decoding operations to minimize recording time.

An image decoding operation is recorded as a SkPixelRef object
implemented by LazyDecodingPixelRef. This object references raw encoded
data, regions to be decoded and scaling information.

When used in conjunction with per-tile painting this feature defers
image decoding until the SkCanvas referencing the image is rasterized.

Both recording and rasterization happen on the main thread.

Performance Impact:

This feature is enabled by WebKit::setDeferredImageDecodingEnabled()
and does not have an impact when disabled.

This feature is disabled by default.

Upcoming Changes:

  1. Implement a full-featured image cache in ImageDecodingStore.
  2. Allow rasterization and decoding on impl thread.

Classes Involved:

BitmapImage

BitmapImage is the entry point for deferred image decoding. When
drawing a BitmapImage into a GraphicsContext it makes a request to
create a NativeImageSkia. We substitute the content in NativeImageSkia
such that it is lazily decoded.

DeferredImageDecoder

This is the platform implementation of a image decoder for Chromium.
This is a bridge layer that either delegates calls to the actual
ImageDecoder or create a lazily-decoded SkBitmap and delegates calls
to ImageDecodingStore.

ImageDecodingStore

This object manages all encoded images. It keeps track of encoded
data and the corresponding ImageDecoder for doing actual decoding. It
is also responsible for generating lazily decoded SkBitmaps. This
SkBitmap contains a LazyDecodingPixelRef object which references to an
image entry in ImageDecodingStore.

ScaledImageFragment

A container for a scaled image fragment. In addition to bitmap pixels
it contains information about the ID of the image, scale and clipping.

ImageFrameGenerator

This object is responsible for generating decoded pixels. It is also
a container for encoded image data and corresponding image decoder.

LazyDecodingPixelRef

This object is embedded in a SkBitmap to enable lazy decoding. When
SkBitmap needs to access pixels LazyDecodingPixelRef is locked. It
contains information to locate an image and scaling info, these
information is submitted to ImageDecodingStore to access actual pixels.

Layout tests. There are about 80 tests in this virtual test suite
running this feature in this directory:

platform/chromium/virtual/deferred/fast/images

Unit tests. Added DeferredImageDecoderTest to verify deferred
image decoding behavior.

  • WebCore.gypi:
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::setData):

  • platform/graphics/ImageSource.h:

(WebCore):
(ImageSource):

  • platform/graphics/chromium/DeferredImageDecoder.cpp: Added.

(WebCore):
(WebCore::DeferredImageDecoder::DeferredImageDecoder):
(WebCore::DeferredImageDecoder::~DeferredImageDecoder):
(WebCore::DeferredImageDecoder::create):
(WebCore::DeferredImageDecoder::createForTesting):
(WebCore::DeferredImageDecoder::filenameExtension):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::setData):
(WebCore::DeferredImageDecoder::isSizeAvailable):
(WebCore::DeferredImageDecoder::size):
(WebCore::DeferredImageDecoder::frameSizeAtIndex):
(WebCore::DeferredImageDecoder::frameCount):
(WebCore::DeferredImageDecoder::repetitionCount):
(WebCore::DeferredImageDecoder::clearFrameBufferCache):
(WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):
(WebCore::DeferredImageDecoder::frameBytesAtIndex):

  • platform/graphics/chromium/DeferredImageDecoder.h: Added.

(WebCore):
(DeferredImageDecoder):

  • platform/graphics/chromium/ImageDecodingStore.cpp: Added.

(WebCore::ImageDecodingStore::ImageDecodingStore):
(WebCore):
(WebCore::ImageDecodingStore::~ImageDecodingStore):
(WebCore::ImageDecodingStore::instanceOnMainThread):
(WebCore::ImageDecodingStore::initializeOnMainThread):
(WebCore::ImageDecodingStore::shutdown):
(WebCore::ImageDecodingStore::isLazyDecoded):
(WebCore::ImageDecodingStore::createLazyDecodedSkBitmap):
(WebCore::ImageDecodingStore::resizeLazyDecodedSkBitmap):
(WebCore::ImageDecodingStore::setData):
(WebCore::ImageDecodingStore::lockPixels):
(WebCore::ImageDecodingStore::unlockPixels):
(WebCore::ImageDecodingStore::frameGeneratorBeingDestroyed):
(WebCore::ImageDecodingStore::calledOnValidThread):
(WebCore::ImageDecodingStore::lookupFrameCache):
(WebCore::ImageDecodingStore::deleteFrameCache):

  • platform/graphics/chromium/ImageDecodingStore.h: Added.

(WebCore):
(ImageDecodingStore):
(WebCore::ImageDecodingStore::create):

  • platform/graphics/chromium/ScaledImageFragment.cpp: Added.

(WebCore):
(WebCore::ScaledImageFragment::~ScaledImageFragment):
(WebCore::ScaledImageFragment::ScaledImageFragment):
(WebCore::ScaledImageFragment::isEqual):

  • platform/graphics/chromium/ScaledImageFragment.h: Added.

(WebCore):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::create):
(WebCore::ScaledImageFragment::bitmap):
(WebCore::ScaledImageFragment::isComplete):

  • platform/graphics/chromium/ImageFrameGenerator.cpp: Added.

(WebCore):
(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::~ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decoder):
(WebCore::ImageFrameGenerator::setData):

  • platform/graphics/chromium/ImageFrameGenerator.h: Added.

(WebCore):
(ImageFrameGenerator):
(WebCore::ImageFrameGenerator::create):
(WebCore::ImageFrameGenerator::size):
(WebCore::ImageFrameGenerator::imageId):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp: Added.

(WebCore):
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::~LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::isScaled):
(WebCore::LazyDecodingPixelRef::isClipped):
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
(WebCore::LazyDecodingPixelRef::onLockPixelsAreWritable):

  • platform/graphics/chromium/LazyDecodingPixelRef.h: Added.

(WebCore):
(LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::frameGenerator):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::resizedBitmap):

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):

Source/WebKit/chromium:

Adding new unit tests for deferred image decoding.
These tests are defined in DeferredImageDecoderTest.cpp. They verify
image decoding happens only when SkPicture is rasterized for both
scaled and non-scaled cases.

Tests: DeferredImageDecoderTest.drawIntoSkPicture

DeferredImageDecoderTest.drawScaledIntoSkPicture

  • WebKit.gypi:
  • public/WebSettings.h:
  • src/WebKit.cpp:

(WebKit::shutdown):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • tests/DeferredImageDecoderTest.cpp: Added.

(WebCore):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::TearDown):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h: Added.

(WebCore):
(MockImageDecoder):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::filenameExtension):
(WebCore::MockImageDecoder::frameBufferAtIndex):
(WebCore::MockImageDecoder::frameBufferRequestCount):

Tools:

Add --enable-deferred-image-decoding to DRT.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setDeferredImageDecodingEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

LayoutTests:

Adding a virtual test suite for Chromium to test deferred image
decoding.

platform/chromium/virtual/deferred/fast/images will be tested with
--force-compositing --enable-per-tile-painting --enable-deferred-image-decoding.

  • platform/chromium/virtual/deferred/fast/images/README.txt: Added.
2:38 PM Changeset in webkit [131809] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

[CSS Shaders] Validate types of built-in vertex attributes
https://bugs.webkit.org/show_bug.cgi?id=98972

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-18
Reviewed by Dean Jackson.

Source/WebCore:

Reject custom filters in which the author defined built-in attributes with the wrong type.
For example, the GLSL declaration "attribute float a_position" is incorrect because
a_position should be a vec4, not a float.

Test: css3/filters/custom/invalid-custom-filter-attribute-types.html

  • platform/graphics/ANGLEWebKitBridge.h:

(WebCore::ANGLEShaderSymbol::isSampler):

Add const qualifier to isSampler method.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore):
(WebCore::builtInAttributeNameToTypeMap):

New file static function. Returns a map of the CSS Custom Filters built-in attribute
names and their expected types.

(WebCore::validateSymbols):

New file static function. Loop through all of the symbols. Reject the shader if we find
a built-in attribute defined with the wrong type.

(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):

Call the new validateSymbols function. If it returns false, exit the constructor early,
which rejects the program.
Move the loop that checks if any uniform is a sampler into the the validateSymbols
function.

LayoutTests:

invalid-custom-filter-attribute-types.html uses a set of vertex shaders. Each vertex shader
defines a specific attribute with the wrong type. None of the vertex shaders in the test
should execute. If a vertex shader does execute, its associated fragment shader will render
a green div as red.

  • css3/filters/custom/invalid-custom-filter-attribute-types-expected.html: Added.
  • css3/filters/custom/invalid-custom-filter-attribute-types.html: Added.
  • css3/filters/resources/invalid-type-a-mesh-coord.vs: Added.
  • css3/filters/resources/invalid-type-a-position.vs: Added.
  • css3/filters/resources/invalid-type-a-tex-coord.vs: Added.
  • css3/filters/resources/invalid-type-a-triangle-coord.vs: Added.
  • css3/filters/resources/invalid-type-attribute-array.vs: Added.
2:36 PM Changeset in webkit [131808] by Lucas Forschler
  • 12 edits in tags/Safari-537.15.1/Source/WebCore

Merged r131804.

2:33 PM Changeset in webkit [131807] by andersca@apple.com
  • 123 edits in trunk/Source/WebKit2

Replace uses of ArgumentEncoder/ArgumentDecoder with MessageEncoder/MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=99746

Reviewed by Andreas Kling.

Change all occurrences of ArgumentDecoder* to MessageDecoder& and all occurrences of ArgumentEncoder*
to ArgumentEncoder& in all the message receivers. This is the second step towards getting rid of MessageID.

2:32 PM Changeset in webkit [131806] by Lucas Forschler
  • 7 edits in tags/Safari-537.15.1/Source

Merged r131675.

2:28 PM Changeset in webkit [131805] by reed@google.com
  • 2 edits in trunk/Source/WebCore

Handle if we fail to allocate nonPlatformCanvas in ImageBuffer constructor
https://bugs.webkit.org/show_bug.cgi?id=99752

Reviewed by Stephen White.

Current code does not check if we were able to allocate the pixels, but still returns the canvas.
However, the caller explicitly is checking for null on failure, so it will continue (and possibly
crash later on).
This change brings the nonPlatformCanvas behavior inline with createAcceleratedCanvas and
TryCreateBitmapCanvas, both of which are also called by ImageBuffer's constructor.

No new tests. Existing tests exercise ImageBuffer constructor.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):

2:25 PM Changeset in webkit [131804] by Beth Dakin
  • 12 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=99668
REGRESSION: Crash in
WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion
-and corresponding-
<rdar://problem/12491901>

Reviewed by Simon Fraser.

http://trac.webkit.org/changeset/130783 changed the lifetime of the
ScrollingStateTree's rootStateNode. Before that patch, the root state
node was never destroyed. It was just constantly re-used for
different RenderLayerBackings. This crash is just one of a few bugs
that has occurred because of that change. I have fixed the other bugs
individually, but I think that long-term, it is the safest solution
to go back to the original ownership model.

So this patch ensures that the state tree will always have a root
state node. Instead of destroying and re-creating the root node when
it's scroll ID changes, we just update the ID.

attachToStateTree() now takes an additional ID representing the ID of
the parent node.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::attachToStateTree):

Add a way to set the scrolling node ID.

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::setScrollingNodeID):

This code that provided a way to mark all properties as having
changed was added in http://trac.webkit.org/changeset/130989 as a way
to ensure we would re-set ScrollingThread's nodes when we destroyed
and re-created the rootStateNode. Now that we are no longer
destroying and re-creating the rootStateNode, this code is no longer
necessary.

  • page/scrolling/ScrollingStateScrollingNode.cpp:
  • page/scrolling/ScrollingStateScrollingNode.h:

create m_rootStateNode right in the ScrollingStateTree's constructor.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::ScrollingStateTree):

Don't let removeNode() destroy m_rootStateNode.
(WebCore::ScrollingStateTree::removeNode):

Also a part of r130989 that is no longer needed.
(WebCore::ScrollingStateTree::rootLayerDidChange():

  • page/scrolling/ScrollingStateTree.h:

(WebCore::ScrollingStateTree::rootStateNode):
(ScrollingStateTree):
(WebCore::ScrollingStateTree::setRootStateNode):

attachToStateTree() now takes an additional ID representing the ID of
the parent node.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

We no longer need ScrollingStateTree::rootLayerDidChange()

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):

Do not destroy and re-create the state node. Just update its ID. When
we support child nodes soon, we will create them in this function.
(WebCore::ScrollingCoordinatorMac::attachToStateTree):

No need to null-check the rootStateNode.
(WebCore::ScrollingCoordinatorMac::clearStateTree):

Send 0 as the parent node ID to attachToStateTree() to represent the
root node.
(WebCore::ScrollingCoordinatorMac::ensureRootStateNodeForFrameView):

  • rendering/RenderLayerBacking.cpp:

RenderLayerBacking::attachToScrollingCoordinator() now takes a parent
layer.
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

Since this is the root, send 0 to represent the parent layer.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

2:21 PM Changeset in webkit [131803] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update Qt expectations for slider tests.

fast/events/touch/touch-slider.html now has a specific bug number.
media/video-playing-and-pause.html is removed. I added it by accident
causing it to be run. Qt didn't run this test before my change.

  • platform/qt/TestExpectations:
2:20 PM Changeset in webkit [131802] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

PageViewportController::m_rawAttributes.devicePixelRatio is not initialized
https://bugs.webkit.org/show_bug.cgi?id=99751

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-18
Reviewed by Antonio Gomes.

PageViewportController::m_rawAttributes.devicePixelRatio needs to be initialized.
Due to race condition, we could set the viewport attributes before the first layout.
If that happens, PageViewportController::m_rawAttributes.devicePixelRatio
is used without being initialized.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):

2:16 PM Changeset in webkit [131801] by roger_fong@apple.com
  • 6 edits in trunk/Source

Unreviewed. Build fix after r131701 and r131777.

  • WebKit.vcproj/WebKit.sln:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • win/WebKit2.def:
2:16 PM Changeset in webkit [131800] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: fix chromium bot configs in builders.py
https://bugs.webkit.org/show_bug.cgi?id=99638

Reviewed by Ojan Vafai.

Updating after the great bot-renaming and deleting a test case
that is no longer needed.

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):

2:11 PM Changeset in webkit [131799] by dpranke@chromium.org
  • 6 edits in trunk/Tools

[chromium] Add 10.8 bot into fallback path, make work with garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=99748

Reviewed by Ryosuke Niwa.

Subject pretty much says it all ...

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_versions):
(ChromiumMacPortTest.test_baseline_path):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_baseline_directory):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_expectations):

1:58 PM Changeset in webkit [131798] by timothy@apple.com
  • 2 edits in trunk/Tools

Teach prepare-ChangeLog how to handle non-function properties in JavaScript prototypes.

https://bugs.webkit.org/show_bug.cgi?id=99747

Reviewed by Joseph Pecoraro.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript): Clear currentIdentifiers when comma is encountered
so it does not tack those identifiers onto the next changed function.

1:24 PM Changeset in webkit [131797] by Lucas Forschler
  • 5 edits
    3 copies in tags/Safari-537.15.1

Merged r131642.

1:18 PM Changeset in webkit [131796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] GraphicsContext3D::m_renderStyle is not initialized
https://bugs.webkit.org/show_bug.cgi?id=99721

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-18
Reviewed by Antonio Gomes.

Initialize GraphicsContext3D::m_renderStyle.

No new tests, no new functionality.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

1:12 PM Changeset in webkit [131795] by Lucas Forschler
  • 4 edits
    3 copies in tags/Safari-537.15.1

Merged r131501.

12:53 PM Changeset in webkit [131794] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

WebKit Doesn't Recognize Content-Language HTTP Header
https://bugs.webkit.org/show_bug.cgi?id=97929

Patch by Brian White <bcwhite@chromium.org> on 2012-10-18
Reviewed by Alexey Proskuryakov.

The HTTP "Content-Language" header may be present and include the
language of the page contents (as opposed to an embedded meta tag).

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

12:53 PM Changeset in webkit [131793] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Crash in InRegionScrollableArea constructor while loading page
https://bugs.webkit.org/show_bug.cgi?id=99733

Patch by John Griggs <jgriggs@rim.com> on 2012-10-18
Reviewed by Antonio Gomes.

Check scrollLayer and avoid constructing InRegionScrollableArea when it is NULL.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

12:46 PM Changeset in webkit [131792] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
12:44 PM Changeset in webkit [131791] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Race condition between GCThread and main thread during copying phase
https://bugs.webkit.org/show_bug.cgi?id=99641

Reviewed by Filip Pizlo.

When a GCThread returns from copyFromShared(), it then calls doneCopying(), which returns
its borrowed CopiedBlock to the CopiedSpace. This final block allows the CopiedSpace to
continue and finish the cleanup of the copying phase. However, the GCThread can loop back
around, see that m_currentPhase is still "Copy", and try to go through the copying phase again.
This can cause all sorts of issues. To fix this, we should add a cyclic barrier to GCThread::waitForNextPhase().

  • heap/GCThread.cpp:

(JSC::GCThread::waitForNextPhase): All GCThreads will wait when they finish one iteration until the main thread
notifies them to move down to the second while loop, where they wait for the next GCPhase to start. They also
decrement the m_numberOfActiveGCThreads counter as they begin to wait for the next phase and increment it as
they enter the next phase. This allows the main thread to wait in endCurrentPhase() until all the threads have
finished the current phase and are waiting on the next phase to begin. Without the counter, there would be
no way to ensure that every thread was available for each GCPhase.
(JSC::GCThread::gcThreadMain): We now use the m_phaseLock to synchronize with the main thread when we're being created.

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData): As we create each GCThread, we increment the m_numberOfActiveGCThreads
counter. When we are done creating the threads, we wait until they're all waiting for the next GCPhase. This prevents
us from leaving some GCThreads behind during the first GCPhase, which could hurt us on our very short-running
benchmarks (e.g. SunSpider).
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::startNextPhase): We atomically swap the two flags, m_gcThreadsShouldWait and m_currentPhase,
so that if the threads finish very quickly, they will wait until the main thread is ready to end the current phase.
(JSC::GCThreadSharedData::endCurrentPhase): Here atomically we swap the two flags again to allow the threads to
advance to waiting on the next GCPhase. We wait until all of the GCThreads have settled into the second wait loop
before allowing the main thread to continue. This prevents us from leaving one of the GCThreads stuck in the first
wait loop if we were to call startNextPhase() before it had time to wake up and move on to the second wait loop.
(JSC):
(JSC::GCThreadSharedData::didStartMarking): We now use startNextPhase() to properly swap the flags.
(JSC::GCThreadSharedData::didFinishMarking): Ditto for endCurrentPhase().
(JSC::GCThreadSharedData::didStartCopying): Ditto.
(JSC::GCThreadSharedData::didFinishCopying): Ditto.

  • heap/GCThreadSharedData.h:

(GCThreadSharedData):

  • heap/Heap.cpp:

(JSC::Heap::copyBackingStores): No reason to use the extra reference.

12:41 PM Changeset in webkit [131790] by Lucas Forschler
  • 1 copy in tags/Safari-537.15.1

New Tag.

12:12 PM Changeset in webkit [131789] by simonjam@chromium.org
  • 9 edits
    16 moves
    3 adds in trunk

Add a script for exporting http/tests/w3c/webperf/submission to W3C
https://bugs.webkit.org/show_bug.cgi?id=99675

Reviewed by Tony Gentilcore.

Tools:

This does the inverse of Scripts/import-w3c-performance-wg-tests.

  • Scripts/export-w3c-performance-wg-tests: Added.

LayoutTests:

The W3C tests expect a company to contribute them. Move these to the Intel directory.

  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMarks-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMarks.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMeasures-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMeasures-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMeasures.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMeasures.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark_exception-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark_exception-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark_exception.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark_exception.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_associate_with_navigation_timing-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_associate_with_navigation_timing.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_exception-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_exception.html.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_method_exist-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_method_exist-expected.txt.
  • http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_method_exist.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/user-timing/test_user_timing_method_exist.html.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
12:09 PM Changeset in webkit [131788] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

12:08 PM Changeset in webkit [131787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-18

  • DEPS:
12:06 PM Changeset in webkit [131786] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.17

New Tag.

12:03 PM Changeset in webkit [131785] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::Document::webkitExitFullscreen + 618
https://bugs.webkit.org/show_bug.cgi?id=99496

Reviewed by Eric Carlson.

Prospective fix for null-dereference crash in Document::webkitExitFullscreen().

  • dom/Document.cpp:

(WebCore::Document::webkitExitFullscreen): Null check page() before calling page()->chrome.

11:53 AM Changeset in webkit [131784] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Generated messages should have a receiver name and a name
https://bugs.webkit.org/show_bug.cgi?id=99740

Reviewed by Andreas Kling.

As a first step towards getting rid of MessageID, give each generated message a name and receiver name
and pass them along when sending the messages.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(generate_messages_header):

  • Scripts/webkit2/messages_unittest.py:
11:43 AM Changeset in webkit [131783] by commit-queue@webkit.org
  • 34 edits
    2 adds in trunk

Implement css3-conditional's @supports rule
https://bugs.webkit.org/show_bug.cgi?id=86146

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-18
Reviewed by Antti Koivisto.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

Source/WebCore:

The "@supports" rule is a conditional group rule whose condition tests
whether the user agent supports CSS property:value pairs.

http://dev.w3.org/csswg/css3-conditional/#at-supports

Test: css3/supports.html

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore):
(WebCore::CSSParser::detectSupportsToken): Tries to find 'and', 'not' and 'or' tokens.
(WebCore::CSSParser::detectAtToken): Enter SupportsMode if @supports is detected.
(WebCore::CSSParser::realLex): Try to detect supports tokens when in SupportsMode.

  • css/CSSParser.h: Added new SupportsMode parsing mode.

(CSSParser):

Source/WebKit/chromium:

  • features.gypi:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

Add an ENABLE_CSS3_CONDITIONAL_RULES flag.

LayoutTests:

  • css3/supports-expected.txt: Added.
  • css3/supports.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:

Skip the test until the feature is enabled.

11:30 AM Changeset in webkit [131782] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix: CachedResourceLoader::requestSVGDocument was passing an URL as charset
https://bugs.webkit.org/show_bug.cgi?id=99730

Patch by Marja Hölttä <marja@chromium.org> on 2012-10-18
Reviewed by Jochen Eisinger.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestSVGDocument):

11:20 AM Changeset in webkit [131781] by jer.noble@apple.com
  • 6 edits in trunk

Fullscreen movie controls behave incorrectly when clicked (and dragged)
https://bugs.webkit.org/show_bug.cgi?id=99610

Reviewed by Eric Carlson.

Source/WebCore:

Do not reset the relative drag position to 0,0 at the beginning of every drag. Instead,
store the cumulative drag offset and accumulate during each additional drag.

No new tests; modified the fullscreen/video-controls-drag.html test.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag): Reset m_lastDragEventLocation.
(WebCore::MediaControlPanelElement::continueDrag): Accumulate drag distance in m_cumulativeDragOffset.
(WebCore::MediaControlPanelElement::resetPosition): Reset m_cumulativeDragOffset.

  • html/shadow/MediaControlElements.h:

LayoutTests:

Add a second drag operation, testing that the location does not reset at the beginning of
each additional drag.

  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-drag.html:
11:18 AM Changeset in webkit [131780] by commit-queue@webkit.org
  • 20 edits
    2 copies
    3 adds in trunk

Implement OES_element_index_uint / WEBKIT_OES_element_index_uint
https://bugs.webkit.org/show_bug.cgi?id=97400

Patch by Brandon Jones <bajones@google.com> on 2012-10-18
Reviewed by Kenneth Russell.

Source/WebCore:

Implemented OES_element_index_uint WebGL extension

Test: fast/canvas/webgl/oes-element-index-uint.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/OESElementIndexUint.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::OESElementIndexUint::OESElementIndexUint):
(WebCore::OESElementIndexUint::~OESElementIndexUint):
(WebCore::OESElementIndexUint::getName):
(WebCore::OESElementIndexUint::create):

  • html/canvas/OESElementIndexUint.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(OESElementIndexUint):

  • html/canvas/OESElementIndexUint.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • platform/graphics/Extensions3D.h:

(Extensions3D):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Added OES_element_index_uint extension conformance test from KHRONOS

  • fast/canvas/webgl/oes-element-index-uint-expected.txt: Added.
  • fast/canvas/webgl/oes-element-index-uint.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wk2/TestExpectations:
11:12 AM Changeset in webkit [131779] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebCore

Add diagnostic logging to track per-page media engine usage.
https://bugs.webkit.org/show_bug.cgi?id=99615
<rdar://problem/12476473>

Reviewed by Eric Carlson.

Add diagnostic logging triggered only once-per-page and once-per-page-per-engine.

  • html/HTMLMediaElement.cpp:

(WebCore::logMediaLoadRequest): Encapsulate diagnostic logging into single static method.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Call logMediaLoadRequest.
(WebCore::HTMLMediaElement::setReadyState): Ditto.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad): Reset the set of seen media engines.

Add new methods to Page to track per-page media engine diagnostic info, similar to plugin diagnostic info.

  • page/Page.cpp:

(WebCore::Page::hasSeenAnyMediaEngine):
(WebCore::Page::hasSeenMediaEngine):
(WebCore::Page::sawMediaEngine):
(WebCore::Page::resetSeenMediaEngines):

  • page/Page.h:

Add new static logging key definitions:

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):

  • page/DiagnosticLoggingKeys.h:
11:09 AM Changeset in webkit [131778] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

11:07 AM Changeset in webkit [131777] by msaboff@apple.com
  • 4 edits in trunk/Source

Make conversion between JSStringRef and WKStringRef work without character size conversions
https://bugs.webkit.org/show_bug.cgi?id=99727

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Export the string() method for use in WebKit.

  • API/OpaqueJSString.h:

(OpaqueJSString::string):

Source/WebKit2:

Use the wrapped WTFString object to convert between JSStringRef and WKStringRef.

  • Shared/WebString.h:

(WebKit::JSStringCreateWithString):
(WebKit::WebString::create):
(WebKit::WebString::createJSString):

11:03 AM Changeset in webkit [131776] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Add 8-bit path to RenderBlock::handleTrailingSpaces()
https://bugs.webkit.org/show_bug.cgi?id=99731

Reviewed by Dan Bernstein.

Factored out and added findFirstTrailingSpace() templated helper function that is called with the
approriate character pointer type.

No tests needed, change covered by existing tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::findFirstTrailingSpace):
(WebCore::RenderBlock::handleTrailingSpaces):

10:54 AM Changeset in webkit [131775] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark http/tests/xmlhttprequest/request-encoding2.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=99734

  • platform/chromium/TestExpectations:
10:42 AM Changeset in webkit [131774] by inferno@chromium.org
  • 5 edits
    5 deletes in branches/chromium/1271

Revert 131767 - Merge 130777 - Prevent animation when CSS attributeType is invalid.
BUG=143648
Review URL: https://codereview.chromium.org/11184044

TBR=inferno@chromium.org
Review URL: https://codereview.chromium.org/11186052

10:31 AM Changeset in webkit [131773] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 131077 - <rdar://problem/12477191> Combined text reverts to full-width font after a style change
BUG=150067
Review URL: https://codereview.chromium.org/11190053

10:21 AM Changeset in webkit [131772] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed testExpectation change for Chromium.

  • platform/chromium/TestExpectations: Marked svg/hixie/perf/007.xml as [ Pass Slow ]
10:20 AM Changeset in webkit [131771] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/1271

Merge 130266 - AX: Heap-use-after-free when deleting a ContainerNode with an AX object
BUG=129158
Review URL: https://codereview.chromium.org/11196044

10:18 AM Changeset in webkit [131770] by inferno@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/inspector/InspectorDOMAgent.cpp

Merge 130910 - Web Inspector: protect node in the InspectorDOMNode::inspect
BUG=154373
Review URL: https://codereview.chromium.org/11190052

10:18 AM Changeset in webkit [131769] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline a slider test on Mac.
I think I grabbed the baseline at the wrong time or from the wrong bot yesterday.

  • platform/mac/media/video-playing-and-pause-expected.txt:
10:16 AM Changeset in webkit [131768] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[CSS Exclusions] Add ExclusionShape::shapeBoundingBox() method
https://bugs.webkit.org/show_bug.cgi?id=99216

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-18
Reviewed by Dirk Schulze.

Added a FloatRect::extend() method which simplifies writing loops that
accumulate the bounding box for a sequence of FloatPoints. The new method
is used by ExclusionPolygon to initialize the shape's logical and physical
bounding boxes. This a clean-up, not a change in functionality. It's already
covered by the existing fast/exclusions LayoutTests.

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::extend): Extend the FloatRect's bounds to include a FloatPoint.
(WebCore):

  • platform/graphics/FloatRect.h:

(FloatRect): Added extend() method.

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::ExclusionPolygon): Use FloatRect::extend() to compute the polygon's internal bounding box.

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape): Use FloatRect::extend() to compute the polygon's physical bounding box.

  • rendering/ExclusionShape.h:

(WebCore::ExclusionShape::shapeBoundingBox): Return the shape's bounding box in physical coordinates.
(ExclusionShape):

10:10 AM Changeset in webkit [131767] by inferno@chromium.org
  • 5 edits
    5 copies in branches/chromium/1271

Merge 130777 - Prevent animation when CSS attributeType is invalid.
BUG=143648
Review URL: https://codereview.chromium.org/11184044

10:08 AM Changeset in webkit [131766] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[CSS Exclusions] Handle special case "empty" shapes
https://bugs.webkit.org/show_bug.cgi?id=99342

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-18
Reviewed by Dirk Schulze.

Source/WebCore:

Provide expclit coverage of the simple "empty" shape-inside shapes.
Shapes will be considered "empty" in the sense that ExclusionShape::getIncludedIntervals()
and ExclusionShape::getExcludedIntervals() will always return empty lists of intervals.
This patch covers rectangles of zero width or height, circles with 0 radius, ellipses
with 0 radiusX or radiusY, polygons with less than 3 vertices.

Test: fast/exclusions/shape-inside/shape-inside-empty.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::ExclusionPolygon): Initialize the m_empty flag.
(WebCore::ExclusionPolygon::getExcludedIntervals): Added short-circuit return when the polygon is empty.
(WebCore::ExclusionPolygon::getIncludedIntervals): Added short-circuit return when the polygon is empty.

  • rendering/ExclusionPolygon.h: Added the isEmpty() method.
  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals): Added short-circuit return when the rectangle is empty.
(WebCore::ExclusionRectangle::getIncludedIntervals): Added short-circuit return when the rectangle is empty.

  • rendering/ExclusionRectangle.h: Added the isEmpty() method.
  • rendering/ExclusionShape.h: Added a virtual isEmpty() ExclusionShape method.

(ExclusionShape):

LayoutTests:

Verify that "empty" shape-inside shapes do not constrain the text their element contains.

  • fast/exclusions/shape-inside/shape-inside-empty-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-empty.html: Added.
10:02 AM Changeset in webkit [131765] by inferno@chromium.org
  • 1 edit in branches/chromium/1271/Source/WebCore/page/EventHandler.cpp

Merge 130449 - Crash in EventHandler::mouseMoved().
BUG=153793
Review URL: https://codereview.chromium.org/11189063

9:59 AM Changeset in webkit [131764] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 153128 - Source/WebCore: [HarfBuzz] harfbuzz expects log_clusters to have same length as other buffers.
BUG=155474
Review URL: https://codereview.chromium.org/11192060

9:55 AM Changeset in webkit [131763] by inferno@chromium.org
  • 3 edits
    1 copy in branches/chromium/1271

Merge 129962 - REGRESSION(r122215) - CachedImage::likelyToBeUsedSoon crashes on accessing a deleted CachedImageClient
BUG=151424
Review URL: https://codereview.chromium.org/11194057

9:53 AM Changeset in webkit [131762] by inferno@chromium.org
  • 5 edits
    2 copies in branches/chromium/1271

Merge 129796 - Rewrite multithreaded filter job dispatching
BUG=152104
Review URL: https://codereview.chromium.org/11192059

9:19 AM Changeset in webkit [131761] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[BlackBerry] Dump DRT output to stdout if test is passed as command line argument
https://bugs.webkit.org/show_bug.cgi?id=99150

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-18
Reviewed by Rob Buis.

Fixed some code style errors as well.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::runTest):
(BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
(BlackBerry::WebKit::DumpRenderTree::runTests):
(BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
(BlackBerry::WebKit::DumpRenderTree::dump):
(BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

9:08 AM Changeset in webkit [131760] by Carlos Garcia Campos
  • 48 edits in trunk/Source/WebKit2

[GTK] Don't use using namespace WebKit in private headers in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=99724

Reviewed by Xan Lopez.

Move using namespace WebKit from private headers to the cpp file.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp:
  • UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
  • UIProcess/API/gtk/WebKitContextMenu.cpp:
  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:
  • UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
  • UIProcess/API/gtk/WebKitContextMenuPrivate.h:
  • UIProcess/API/gtk/WebKitCookieManager.cpp:
  • UIProcess/API/gtk/WebKitCookieManagerPrivate.h:
  • UIProcess/API/gtk/WebKitDownload.cpp:
  • UIProcess/API/gtk/WebKitDownloadPrivate.h:
  • UIProcess/API/gtk/WebKitFaviconDatabasePrivate.h:
  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
  • UIProcess/API/gtk/WebKitFileChooserRequestPrivate.h:
  • UIProcess/API/gtk/WebKitFindController.cpp:
  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:
  • UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:
  • UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitGeolocationProvider.cpp:
  • UIProcess/API/gtk/WebKitGeolocationProvider.h:
  • UIProcess/API/gtk/WebKitHitTestResult.cpp:
  • UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:
  • UIProcess/API/gtk/WebKitJavascriptResultPrivate.h:
  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
  • UIProcess/API/gtk/WebKitNavigationPolicyDecisionPrivate.h:
  • UIProcess/API/gtk/WebKitPolicyDecision.cpp:
  • UIProcess/API/gtk/WebKitPolicyDecisionPrivate.h:
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
  • UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h:
  • UIProcess/API/gtk/WebKitSettings.cpp:
  • UIProcess/API/gtk/WebKitSettingsPrivate.h:
  • UIProcess/API/gtk/WebKitURIResponse.cpp:
  • UIProcess/API/gtk/WebKitURIResponsePrivate.h:
  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
  • UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:
  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebInspector.cpp:
  • UIProcess/API/gtk/WebKitWebInspectorPrivate.h:
  • UIProcess/API/gtk/WebKitWebResource.cpp:
  • UIProcess/API/gtk/WebKitWebResourcePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/WebKitWindowProperties.cpp:
  • UIProcess/API/gtk/WebKitWindowPropertiesPrivate.h:
9:04 AM Changeset in webkit [131759] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Possible redundant zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState
https://bugs.webkit.org/show_bug.cgi?id=99624

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>
Internally reviewed by Arvid Nilsson

PR: 225981
Several reasons to eliminate the ancient unnecessary
zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState committed:

  • At this point, we have only committed the data we received.
  • For the new load, we haven't started parsing the tokens and building the DOM tree and the first layout will happen after that.
  • For the load restored from cache, the first layout will happen after setLoadState committed which is called by FrameLoader::dispatchDidCommitLoad().
  • zoomToInitialScaleOnLoad() can still be called after the first layout finished.
  • zoomToInitialScaleOnLoad() is expensive and it will boost the load performance after the removal.
  • Removal of this can fix some weird rendering defects on yahoo.com, maps.google.com, news.qq.com and so on during load and rotation mentioned on the PR.
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

9:00 AM Changeset in webkit [131758] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r131464): Null-pointer crash in StyleResolver::styleForElement
https://bugs.webkit.org/show_bug.cgi?id=99587

Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-18
Reviewed by Dimitri Glazkov.

Source/WebCore:

Since contents in datalist are not shown, summary in datalist is not
shown either. So the summary has no render style. On the other hand,
the summary is implemented by shadow DOM and it has some insertion
point. Its child, e.g. title in the below test, is distributed.
To solve the child's user-modify, looking at shadow host(=summary)'s
style causes null-pointer crash.

Test: fast/dom/shadow/user-modify-in-datalist-crash.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
Added a code to check whether the shadow host has any style or not.

LayoutTests:

  • fast/dom/shadow/user-modify-in-datalist-crash-expected.txt: Added.
  • fast/dom/shadow/user-modify-in-datalist-crash.html: Added.
8:55 AM Changeset in webkit [131757] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitFileChooserRequest
https://bugs.webkit.org/show_bug.cgi?id=96774

Reviewed by Xan Lopez.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(_WebKitFileChooserRequestPrivate):
(webkitFileChooserRequestCreate):
(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_mime_types_filter):
(webkit_file_chooser_request_get_select_multiple):
(webkit_file_chooser_request_select_files):
(webkit_file_chooser_request_get_selected_files):
(webkit_file_chooser_request_cancel):

  • UIProcess/API/gtk/WebKitFileChooserRequestPrivate.h:
  • UIProcess/API/gtk/WebKitUIClient.cpp:

(runOpenPanel):

8:49 AM Changeset in webkit [131756] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitFormSubmissionRequest
https://bugs.webkit.org/show_bug.cgi?id=96777

Reviewed by Xan Lopez.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitFormClient.cpp:

(willSubmitForm):

  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:

(_WebKitFormSubmissionRequestPrivate):
(webkitFormSubmissionRequestCreate):
(webkit_form_submission_request_get_text_fields):
(webkit_form_submission_request_submit):

  • UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:
8:27 AM Changeset in webkit [131755] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GTK] AudioBusGtk sometimes fails to load the HRTF database
https://bugs.webkit.org/show_bug.cgi?id=99601

Reviewed by Martin Robinson.

AudioBusGtk now first lookup for the uninstalled resource files,
if the AUDIO_RESOURCES_PATH environment variable is
set. Additionally the audio file reader is now better dealing with
errors, returning an empty AudioBus in such cases and issuing
warnings on the console output. The cleanup of some member
variables was also moved to the destructor.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader): Clear and free
member variables. This was done in createBus before.
(WebCore::AudioFileReader::handleMessage): Issue warnings in case
of error and exit from the main loop so the pipeline is not
forever stuck.
(WebCore::AudioFileReader::createBus): Return an empty bus in case
of error.

  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Load uninstalled
resources first if AUDIO_RESOURCES_PATH is set.

8:21 AM Changeset in webkit [131754] by tkent@chromium.org
  • 13 edits
    1 add in trunk/LayoutTests

[Chromium] Test expectation update mainly for
https://bugs.webkit.org/show_bug.cgi?id=99673

  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
8:20 AM Changeset in webkit [131753] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: provisional change for merging "doced" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99718

Reviewed by Vsevolod Vlasov.

Adds stub method that could be executed from the embedder.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setDockSide):

7:58 AM Changeset in webkit [131752] by schenney@chromium.org
  • 16 edits
    1 add in trunk/LayoutTests

Rebaselining some longstanding Chromium expectations.

Unreviewed test expectations update.

These were marked as expected fail when a Skia roll went in. That was ago.

  • platform/chromium-linux/fast/repaint/list-marker-expected.png:
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/list-marker-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/007-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
  • platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win-xp/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win/fast/repaint/focus-ring-expected.png:
  • platform/chromium-win/fast/repaint/list-marker-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium/TestExpectations:
7:55 AM Changeset in webkit [131751] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add Localizer::monthFormat and implementations
https://bugs.webkit.org/show_bug.cgi?id=99704

  • tests/LocaleMacTest.cpp:

(TEST_F): Remove tests for fr_FR and ru locales for a compatibility reason.

7:49 AM Changeset in webkit [131750] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=96784

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate):
(webkit_settings_class_init):
(webkit_settings_init):
(webkitSettingsAttachSettingsToPage):
(webkit_settings_get_enable_javascript):
(webkit_settings_set_enable_javascript):
(webkit_settings_get_auto_load_images):
(webkit_settings_set_auto_load_images):
(webkit_settings_get_load_icons_ignoring_image_load_setting):
(webkit_settings_set_load_icons_ignoring_image_load_setting):
(webkit_settings_get_enable_offline_web_application_cache):
(webkit_settings_set_enable_offline_web_application_cache):
(webkit_settings_get_enable_html5_local_storage):
(webkit_settings_set_enable_html5_local_storage):
(webkit_settings_get_enable_html5_database):
(webkit_settings_set_enable_html5_database):
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
(webkit_settings_get_enable_frame_flattening):
(webkit_settings_set_enable_frame_flattening):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):
(webkit_settings_get_enable_java):
(webkit_settings_set_enable_java):
(webkit_settings_get_javascript_can_open_windows_automatically):
(webkit_settings_set_javascript_can_open_windows_automatically):
(webkit_settings_get_enable_hyperlink_auditing):
(webkit_settings_set_enable_hyperlink_auditing):
(webkit_settings_set_default_font_family):
(webkit_settings_set_monospace_font_family):
(webkit_settings_set_serif_font_family):
(webkit_settings_set_sans_serif_font_family):
(webkit_settings_set_cursive_font_family):
(webkit_settings_set_fantasy_font_family):
(webkit_settings_set_pictograph_font_family):
(webkit_settings_get_default_font_size):
(webkit_settings_set_default_font_size):
(webkit_settings_get_default_monospace_font_size):
(webkit_settings_set_default_monospace_font_size):
(webkit_settings_get_minimum_font_size):
(webkit_settings_set_minimum_font_size):
(webkit_settings_set_default_charset):
(webkit_settings_get_enable_private_browsing):
(webkit_settings_set_enable_private_browsing):
(webkit_settings_get_enable_developer_extras):
(webkit_settings_set_enable_developer_extras):
(webkit_settings_get_enable_resizable_text_areas):
(webkit_settings_set_enable_resizable_text_areas):
(webkit_settings_get_enable_tabs_to_links):
(webkit_settings_set_enable_tabs_to_links):
(webkit_settings_get_enable_dns_prefetching):
(webkit_settings_set_enable_dns_prefetching):
(webkit_settings_get_enable_caret_browsing):
(webkit_settings_set_enable_caret_browsing):
(webkit_settings_get_enable_fullscreen):
(webkit_settings_set_enable_fullscreen):
(webkit_settings_get_print_backgrounds):
(webkit_settings_set_print_backgrounds):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):
(webkit_settings_get_enable_webgl):
(webkit_settings_set_enable_webgl):
(webkit_settings_get_allow_modal_dialogs):
(webkit_settings_get_zoom_text_only):
(webkit_settings_get_javascript_can_access_clipboard):
(webkit_settings_set_javascript_can_access_clipboard):
(webkit_settings_get_media_playback_requires_user_gesture):
(webkit_settings_set_media_playback_requires_user_gesture):
(webkit_settings_get_media_playback_allows_inline):
(webkit_settings_set_media_playback_allows_inline):
(webkit_settings_get_draw_compositing_indicators):
(webkit_settings_set_draw_compositing_indicators):
(webkit_settings_get_enable_site_specific_quirks):
(webkit_settings_set_enable_site_specific_quirks):
(webkit_settings_get_enable_page_cache):
(webkit_settings_set_enable_page_cache):
(webkit_settings_get_enable_smooth_scrolling):
(webkit_settings_set_enable_smooth_scrolling):

  • UIProcess/API/gtk/WebKitSettingsPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetSettings):

7:32 AM Changeset in webkit [131749] by tkent@chromium.org
  • 13 edits in trunk/Source

Add Localizer::monthFormat and implementations
https://bugs.webkit.org/show_bug.cgi?id=99704

Reviewed by Kentaro Hara.

Source/WebCore:

Localizer::monthFormat will be used for constructing input[type=month] UI.

Tests: Add unit tests to Source/WebKit/chromium/tests/.

  • platform/text/Localizer.h:

(Localizer): Declare pure virtual monthFormat function.

  • platform/text/LocaleNone.cpp:

(LocaleNone): Declare monthFormat.
(WebCore::LocaleNone::monthFormat):
Added. Always reutrns an ISO-8601 format, "yyyy-MM"

  • platform/text/LocaleICU.h:

(LocaleICU): Declare monthFormat.

  • platform/text/LocaleICU.cpp:

(WebCore::getFormatForSkeleton):
A helper to get a format for the specified skeleton.
The overflow-allocalte-try-again pattern is similar to
LocaleICU::decimalSymbol and LocaleICU::decimalTextAttribute.
(WebCore::LocaleICU::monthFormat):
Added. Calls getFormatForSkeleton with "yyyyMMM".

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Declare monthFormat.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::monthFormat):
Added. Calls NSDateFormatter::dateFormatFromTemplate with "yyyyMMM".

  • platform/text/LocaleWin.h:

(LocaleWin): Declare monthFormat.

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::monthFormat):
Get a format by LOCALE_SYEARMONTH, and convert it to an LDML format.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::monthFormat): A helper function.
(TEST_F): Added some tests.

  • tests/LocaleWinTest.cpp:

(LocaleWinTest::monthFormat): A helper function.
(TEST_F): Added some tests.

  • tests/LocalizedDateICUTest.cpp:

(LocalizedDateICUTest::monthFormat): A helper function.
(TEST_F): Added some tests.

7:18 AM Changeset in webkit [131748] by rakuco@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[CMake] Avoid unnecessarily running the LLInt generation commands.
https://bugs.webkit.org/show_bug.cgi?id=99708

Reviewed by Rob Buis.

As described in the comments in the change itself, in some cases
the Ruby generation scripts used when LLInt is on would each be
run twice in every build even if nothing had changed.

Fix that by not setting the OBJECT_DEPENDS property of some source
files to depend on the generated headers; instead, they are now
just part of the final binaries/libraries which use them.

  • CMakeLists.txt:
7:17 AM Changeset in webkit [131747] by antonm@chromium.org
  • 3 edits
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed Chromium rebaselines.

  • platform/chromium-linux/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
  • platform/chromium-win/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
6:50 AM Changeset in webkit [131746] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update pixel expectation for a datalist test.

  • platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
6:43 AM Changeset in webkit [131745] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ debug build.

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(webkitWebResourceCreate):

6:40 AM Changeset in webkit [131744] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: add X-WebKit-CSP header into inspector.html
https://bugs.webkit.org/show_bug.cgi?id=99710

Reviewed by Vsevolod Vlasov.

A simple sanity measure.

  • inspector/front-end/inspector.html:
6:40 AM Changeset in webkit [131743] by rakuco@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

[EFL] Gardening. Remove pixel expectation for a test that's actually a reftest.

  • platform/efl/fast/forms/datalist/update-range-with-datalist-expected.png: Removed.
6:39 AM Changeset in webkit [131742] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitWindowProperties
https://bugs.webkit.org/show_bug.cgi?id=96785

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateNewPage):

  • UIProcess/API/gtk/WebKitWindowProperties.cpp:

(webkitWindowPropertiesUpdateFromWebWindowFeatures):

  • UIProcess/API/gtk/WebKitWindowPropertiesPrivate.h:
6:38 AM Changeset in webkit [131741] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk/Source

[WK2] Add CustomFilterOperation serialization in ArgumentCoder.
https://bugs.webkit.org/show_bug.cgi?id=98733

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-18
Reviewed by Noam Rosenthal.

Source/WebCore:

Change CustomFilterOperation::parameters() to const function, because
this method is a getter and a const instance needs to call this method.

No new tests because there is no change in behavior.

  • platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::parameters):

Source/WebKit2:

Add ArgumentCoders for CustomFilterOperation and all dependent classes.
Coordinated Graphics will use this css shaders serialization when it enables CSS
Shaders.

No new tests, code path is not activated yet.

  • CMakeLists.txt:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: Added.

(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h: Added.

(WebCore):
(CoreIPC):

  • Shared/CoordinatedGraphics/WebCustomFilterProgram.h: Added.

(WebKit):
(WebCustomFilterProgram):

WebCustomFilterProgram is made to serialize the data of a
StyleCustomFilterProgram to the UI process.

(WebKit::WebCustomFilterProgram::create):
(WebKit::WebCustomFilterProgram::WebCustomFilterProgram):

  • Shared/ShareableSurface.cpp:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • Target.pri:
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
  • WebKit2.pri:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
6:37 AM Changeset in webkit [131740] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Rebaseline http/tests/plugins/ after r129972
https://bugs.webkit.org/show_bug.cgi?id=99672

Unreviewed. Plugin feature is enabled on EFL WK2 port after r129972.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-10-18

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
6:22 AM Changeset in webkit [131739] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

treeScopeOfParent doesn't return the TreeScope of the parent
https://bugs.webkit.org/show_bug.cgi?id=98207

Reviewed by Hajime Morita.

A minor clean up. Remove treeScopeOfParent() in Element.cpp.

No tests needed, this is just a clean up.

  • dom/Element.cpp:

(WebCore::Element::removedFrom):

6:20 AM Changeset in webkit [131738] by rakuco@webkit.org
  • 1 edit in trunk/Source/WebCore/UseV8.cmake

Really remove the svn:executable property from Source/WebCore/UseV8.cmake

6:18 AM Changeset in webkit [131737] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip http/tests/security/xss-DENIED-xsl-external-entity.xml.

It seems to be passing consistently now.

  • platform/efl/TestExpectations:
6:18 AM Changeset in webkit [131736] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Styles] Forcibly invoke property names suggestion box for empty prefix
https://bugs.webkit.org/show_bug.cgi?id=99711

Reviewed by Vsevolod Vlasov.

Suggestions should be returned unconditionally for CSS property names, regardless of the prefix.

  • inspector/front-end/CSSCompletions.js:

(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.requestCSSNameCompletions):
(WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):

  • inspector/front-end/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):

5:48 AM Changeset in webkit [131735] by kadam@inf.u-szeged.hu
  • 2 edits
    2 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening

Skipping a test, remove unnecessary expected files.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-18

  • platform/qt-5.0/fast/forms/box-shadow-override-expected.png: Removed.
  • platform/qt-5.0/fast/forms/box-shadow-override-expected.txt: Removed.
  • platform/qt/TestExpectations:
5:42 AM Changeset in webkit [131734] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Improved support for silent builds

Reviewed by Tor Arne Vestbø.

Silence our extra compilers when CONFIG+=silent is set.

  • qmake/mkspecs/features/default_post.prf:
5:35 AM Changeset in webkit [131733] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitWebResource
https://bugs.webkit.org/show_bug.cgi?id=96783

Reviewed by Xan Lopez.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(_WebKitWebResourcePrivate):
(webkitWebResourceCreate):
(webkitWebResourceGetFrame):
(ResourceGetDataAsyncData):
(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):

  • UIProcess/API/gtk/WebKitWebResourcePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(setCertificateToMainResource):
(webkitWebViewResourceLoadStarted):

5:31 AM Changeset in webkit [131732] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitURIResponse
https://bugs.webkit.org/show_bug.cgi?id=96782

Reviewed by Xan Lopez.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkitURIResponseSetCertificateInfo):

  • UIProcess/API/gtk/WebKitURIResponsePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(setCertificateToMainResource):

5:22 AM Changeset in webkit [131731] by Carlos Garcia Campos
  • 12 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in PolicyClient classes
https://bugs.webkit.org/show_bug.cgi?id=96781

Reviewed by Xan Lopez.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:

(webkitNavigationPolicyDecisionCreate):

  • UIProcess/API/gtk/WebKitNavigationPolicyDecisionPrivate.h:
  • UIProcess/API/gtk/WebKitPolicyClient.cpp:

(decidePolicyForNavigationActionCallback):
(decidePolicyForNewWindowActionCallback):
(decidePolicyForResponseCallback):
(attachPolicyClientToView):

  • UIProcess/API/gtk/WebKitPolicyClient.h:
  • UIProcess/API/gtk/WebKitPolicyDecision.cpp:

(_WebKitPolicyDecisionPrivate):
(webkitPolicyDecisionFinalize):
(webkitPolicyDecisionSetListener):
(webkit_policy_decision_use):
(webkit_policy_decision_ignore):
(webkit_policy_decision_download):

  • UIProcess/API/gtk/WebKitPolicyDecisionPrivate.h:
  • UIProcess/API/gtk/WebKitPrivate.cpp:

(wkEventMouseButtonToWebKitMouseButton):

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:

(webkitResponsePolicyDecisionCreate):

  • UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

5:20 AM Changeset in webkit [131730] by rakuco@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed, do not make UseV8.cmake executable.

  • UseV8.cmake: Removed property svn:executable.
5:16 AM Changeset in webkit [131729] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=96779

Reviewed by Xan Lopez.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkitHitTestResultCreate):
(webkitHitTestResultCompare):

  • UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewMouseTargetChanged):
(webkitWebViewPopulateContextMenu):

5:09 AM Changeset in webkit [131728] by Simon Hausmann
  • 3 edits in trunk/Tools

[Qt] Reduce memory pressure at link time with less compromise on speed of linking

Reviewed by Csaba Osztrogonác.

Revert r131718 that made us pass -fno-keep-memory to the linker for any
i386 builds. The downside of passing that option is that it slows down
the process of linking and as Ossy determined, release builds do _not_
take as much memory (2.x GB) for linking but much less (~350MB).

However there is one condition where even release builds do take up too
much memory, and that is when Qt is configured with
-separate-debug-info, because it adds a -g next to -O2. The recent
introduction of loading qt_build_config enabled us to read qmodule.pri,
which adds the -g if Qt is configured with -separate-debug-info. So
instead of playing with -fno-keep-memory (which is a last resort
measure for debug builds) we should tweak our existing mechanism of
dealing with the debug info:

production_build.prf tries to ensure that we use -g only in static
libraries that contain API facing code, so that we get nice backtraces
at least into the API layer. For other static libraries such as WebCore
we skip -g via CONFIG += no_debug_info. One of the conditions for
enabling this tweak is CONFIG(debug, debug|release). This patch adds
contains(QT_CONFIG,separate_debug_info) to the conditions.

The patch also extend the CONFIG += no_debug_info part with the removal
of no_separate_debug_info. There is no point in running an extra
build step to strip out debug info into a separate file if at the same
time we tell the compiler to not generate any debug info altogether.

  • qmake/mkspecs/features/production_build.prf:
  • qmake/mkspecs/features/unix/default_post.prf:
4:28 AM Changeset in webkit [131727] by kbalazs@webkit.org
  • 5 edits in trunk/Tools

[Qt] OpenGL rendering is not possible on bots using Xvfb
https://bugs.webkit.org/show_bug.cgi?id=99463

Reviewed by Jocelyn Turcotte.

Added a workaround to be able to disallow UI side OpenGL rendering
if the environment is not suitable because it can be extremely slow
with a software backend.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.setup_environ_for_server): Let the environment variable
QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS reach the driver. This variable
should be defined on bots that don't have a suitable OpenGL environment.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged): Don't try to create an OpenGL
surface and set the setRenderWithoutShowing flag on the window if the
variable is set.
(WTR::PlatformWebView::windowSnapshotImage):
(WTR::PlatformWebView::windowShapshotEnabled):
(WTR):

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use the old method
of evaluating pixel results if the snapshot is not supported, that is to check
the image we got from the web process. This is necessary for the bots to be able
to run ref tests.

4:26 AM Changeset in webkit [131726] by kbalazs@webkit.org
  • 3 edits in trunk/Tools

Implement pixel snapshot generation in WTR https://bugs.webkit.org/show_bug.cgi?id=95992

Reviewed by Jocelyn Turcotte.

Switch the Qt implementation of the PlatformWebView to use
QQuickWindow::grabWindow to generate the pixel results. This way
we will go through the scenegraph and test the actual rendering backend.
We use QQuickWindowPrivate::setRenderWithoutShowing to avoid the need of
showing the window.

  • WebKitTestRunner/Target.pri: Had to added a bunch

of modules to be able to use QQuickWindowPrivate.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::windowSnapshotImage):

4:26 AM Changeset in webkit [131725] by kbalazs@webkit.org
  • 8 edits in trunk

Do a forced repaint before generating pixel results https://bugs.webkit.org/show_bug.cgi?id=98654

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

Added API to convert a QImage to a WKImage so we can
pass it to cross-platform code.

  • Shared/API/c/qt/WKImageQt.cpp:

(WKImageCreateFromQImage):

  • Shared/API/c/qt/WKImageQt.h:

Tools:

Do a forced repaint before grabbing the pixel snapshot. This extra
synchronisation is necessary with the CoordinatedGraphics rendering
backend because it has a fully asynchronous nature. This patch make
us using the window snapshot for pixel results which is necessary to
capture animations and other dynamic content. The actual grabbing of
the window has not been implemented in this patch. It will come in
a follow-up.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump): Store results in member variables.
Don't close output channels yet.
(WTR::TestInvocation::dumpResults): Added. This is where we dump
the results if no error happened.
(WTR):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::forceRepaintDoneCallback):
(WTR):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

3:41 AM Changeset in webkit [131724] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CMake] Depend on the Python scripts in WebKit2/Scripts/webkit2 when regenerating messages.
https://bugs.webkit.org/show_bug.cgi?id=99702

Reviewed by Gyuyoung Kim.

Be in line with most (or all) the other build systems and
explicitly depend on all the scripts in
${WEBKIT2_DIR}/Scripts/webkit2 for the custom command that
generates messages.

This helps fix the build after the recent change to messages.py,
which did not trigger a regeneration of the required files --
people were just removing their DerivedSources directory
altogether.

  • CMakeLists.txt:
3:38 AM Changeset in webkit [131723] by Simon Hausmann
  • 4 edits in trunk

[Qt] Clean up variables controlling Qt module creation/handling

Reviewed by Tor Arne Vestbø.

We now depend on a Qt 5 version that is new enough to allow us to
clean this up. Qt's default_pre.prf uses MODULE_QMAKE_OUTDIR, but
the other MODULE_BASE_* variables are onl used in qmodule.prf.

.:

  • Source/api.pri:

Tools:

  • qmake/mkspecs/features/default_pre.prf:
3:25 AM Changeset in webkit [131722] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix incorrect test expectations of messages_unittest.py.
https://bugs.webkit.org/show_bug.cgi?id=99699

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

Fix the expected results of messages_unittest.py.

The expected result of messages_unittest.py has bugs, and it makes failure on python test.

  • Scripts/webkit2/messages_unittest.py:
3:23 AM Changeset in webkit [131721] by tommyw@google.com
  • 3 edits in trunk/Source/WebCore

MediaStream API: Add better RTCPeerConnectionHandler creation logic
https://bugs.webkit.org/show_bug.cgi?id=99308

Reviewed by Adam Barth.

This patch makes sure that if the RTCPeerConnectionHandler can't be fully initialized/created
the RTCPeerConnection constructor throws an exception.

Not full testable, existing tests cover the normal case though.

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandler::create):
(WebCore::RTCPeerConnectionHandlerChromium::RTCPeerConnectionHandlerChromium):
(WebCore::RTCPeerConnectionHandlerChromium::createWebHandler):
(WebCore::RTCPeerConnectionHandlerChromium::initialize):
(WebCore::RTCPeerConnectionHandlerChromium::createOffer):
(WebCore::RTCPeerConnectionHandlerChromium::createAnswer):
(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::addStream):
(WebCore::RTCPeerConnectionHandlerChromium::removeStream):
(WebCore::RTCPeerConnectionHandlerChromium::getStats):
(WebCore::RTCPeerConnectionHandlerChromium::openDataChannel):
(WebCore::RTCPeerConnectionHandlerChromium::sendStringData):
(WebCore::RTCPeerConnectionHandlerChromium::sendRawData):
(WebCore::RTCPeerConnectionHandlerChromium::closeDataChannel):
(WebCore::RTCPeerConnectionHandlerChromium::stop):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

2:48 AM Changeset in webkit [131720] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

Temporarily disable use of QCocoaNativeInterface in GraphicsSurfaceMac.
https://bugs.webkit.org/show_bug.cgi?id=99320

The current version of Qt5 deployed on the buildbots does not yet have
an implementation for QCocoaNativeInterface::nativeResourceForContext().
Therefore we disable this code path until Qt5/qtbase has been updated to
a revision above Change-Id: Id00efc88a73d7df04a68c022f19d9d1c4f6d386b.

Once Qt5 has been updated, this patch must be reverted.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

2:44 AM Changeset in webkit [131719] by zeno.albisser@digia.com
  • 6 edits in trunk/Source/WebCore

GraphicsSurface should not modify the current GL context.
https://bugs.webkit.org/show_bug.cgi?id=99320

Instead of reusing the currently bound GL context for drawing
the texture onto the GraphicsSurface, GraphicsSurface should
create a new context that shares the texture names with a context
provided by the caller.
This way the OpenGL states are clearly separated and we do not
risk interfeering with the currently bound GL context.

Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

When creating a GraphicsSurface pass the platform GL context
as a parameter, so it can be used for sharing textures with.

(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

Pass the texture instead of the FBO. A Texture can be drawn
directly or bound to another FBO, where a framebuffer
always needs to be blit onto the surface.

(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):

Pass the platform GL context as a parameter.

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::create):
(WebCore::GraphicsSurface::copyFromTexture):

  • platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

Create a new GL context that shares the textures with the
context provided by the caller.

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::makeCurrent):

Add a convenience function to make the context that
belongs to the surface current.

(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::doneCurrent):

Add a convenience function to make the previously
bound context current again.

(WebCore::GraphicsSurfacePrivate::copyFromTexture):

Move blitting of the texture onto the surface
into a separate function within GraphicsSurfacePrivate.

(WebCore::GraphicsSurface::platformCopyFromTexture):

Rename function platformCopyFromFramebuffer to
platformCopyFromTexture, as we are now passing the texture only.

(WebCore::GraphicsSurface::platformCreate):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::makeCurrent):

Add a convenience function to make the context that
belongs to the surface current.

(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::doneCurrent):

Add a convenience function to make the previously

(WebCore::GraphicsSurfacePrivate::copyFromTexture):

Move blitting of the texture onto the surface
into a separate function within GraphicsSurfacePrivate.

(WebCore::resolveGLMethods):

Resolve additional GL methods necessary for this change.

(WebCore::GraphicsSurface::platformCopyFromTexture):

Rename function platformCopyFromFramebuffer to
platformCopyFromTexture, as we are now passing the texture only.

(WebCore::GraphicsSurface::platformCreate):

1:53 AM Changeset in webkit [131718] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Reduce memory pressure during link time

Reviewed by Tor Arne Vestbø.

If possible always pass -fkeep-memory to the linker on i386. The
library has grown so big that we need this not only for i386 debug
builds but at least also for release.

  • qmake/mkspecs/features/unix/default_post.prf:
1:51 AM Changeset in webkit [131717] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Add PluginProcessProxy::platformInitializeLaunchOptions
https://bugs.webkit.org/show_bug.cgi?id=99583

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-18
Reviewed by Sam Weinig.

Add a platform specific launch options initializer. This enables
fixing bug 99297 "[EFL] Make plugin process debugging easier
(PLUGIN_PROCESS_COMMAND_PREFIX)".

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::PluginProcessProxy):

  • UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
(WebKit):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
(WebKit):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
(WebKit):

1:38 AM Changeset in webkit [131716] by vestbo@webkit.org
  • 6 edits
    1 add
    2 deletes in trunk

[Qt] Modularize documentation for QtWebKit

Running 'make docs' would fail unless 'make qmake_all' was ran first,
but qmake_all involved generating all the derived sources, which seems
overly complex just for building documentation.

We solve this by preventing all subdirs except QtWebKit from having a
docs target. This would normally work fine on its own, but since we
use CONFIG += ordered, there's now a missing doc target for the
immediate dependency of the QtWebKit subdir. We solve this by adding
a dummy-target ourselves.

Finally, we clean up the qdocconf file to match the rest of the Qt
documentation modularization efforts.

Reviewed by Simon Hausmann.

1:25 AM Changeset in webkit [131715] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit

[EFL] Add unit test for ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95984

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

Source/WebKit:

Add test_ewk_frame.cpp for unit test.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add three unit test cases to verify ewk_frame_source_get function.
Additionally, insert code to check if uri exists in order to return error since view itself has blank html.

  • ewk/ewk_frame.cpp:

(ewk_frame_source_get):

  • tests/test_ewk_frame.cpp: Added.

(initBuffer):
(TEST_F):

1:13 AM Changeset in webkit [131714] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Update test expectation for the python message test after r131700
https://bugs.webkit.org/show_bug.cgi?id=99689

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

Need to update test expectations about including headers and forwarding
declarations on derived sources for ipc message. (after r131700 : build fix)

  • Scripts/webkit2/messages_unittest.py:
1:01 AM Changeset in webkit [131713] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r131640
https://bugs.webkit.org/show_bug.cgi?id=99692

Unreviewed gardening.

Failing gamepad/gamepad-out-of-range-crasher.html is skipped for EFL.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-18

  • platform/efl/TestExpectations:
1:01 AM Changeset in webkit [131712] by commit-queue@webkit.org
  • 52 edits in trunk/Source/WebKit2

[EFL][WK2] Remove '_' prefix from private API structure names
https://bugs.webkit.org/show_bug.cgi?id=99575

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

Removed underscore prefix from WK2 EFL internal structure names.

  • UIProcess/API/efl/VibrationProvider.cpp:

(Ewk_Vibration_Client::Ewk_Vibration_Client):

  • UIProcess/API/efl/VibrationProvider.h:
  • UIProcess/API/efl/ewk_back_forward_list.h:
  • UIProcess/API/efl/ewk_back_forward_list_item.h:
  • UIProcess/API/efl/ewk_back_forward_list_item_private.h:

(Ewk_Back_Forward_List_Item::create):
(Ewk_Back_Forward_List_Item::Ewk_Back_Forward_List_Item):

  • UIProcess/API/efl/ewk_back_forward_list_private.h:

(Ewk_Back_Forward_List::create):
(Ewk_Back_Forward_List::Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Url_Scheme_Handler::Ewk_Url_Scheme_Handler):
(Ewk_Context::Ewk_Context):
(ewk_context_url_scheme_request_received):
(ewk_context_url_scheme_register):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_download_client_private.h:
  • UIProcess/API/efl/ewk_context_history_client_private.h:
  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_context_request_manager_client_private.h:
  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(Ewk_Cookie_Manager::Ewk_Cookie_Manager):
(Ewk_Cookie_Manager::~Ewk_Cookie_Manager):

  • UIProcess/API/efl/ewk_cookie_manager.h:
  • UIProcess/API/efl/ewk_cookie_manager_private.h:

(Ewk_Cookie_Manager::create):
(Ewk_Cookie_Manager):

  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_download_job_private.h:

(Ewk_Download_Job::create):
(Ewk_Download_Job::Ewk_Download_Job):

  • UIProcess/API/efl/ewk_error.cpp:

(Ewk_Error::Ewk_Error):

  • UIProcess/API/efl/ewk_error.h:
  • UIProcess/API/efl/ewk_error_private.h:

(Ewk_Error::create):
(Ewk_Error):

  • UIProcess/API/efl/ewk_favicon_database.cpp:

(Ewk_Favicon_Database::Ewk_Favicon_Database):

  • UIProcess/API/efl/ewk_favicon_database.h:
  • UIProcess/API/efl/ewk_favicon_database_private.h:

(Ewk_Favicon_Database::create):
(Ewk_Favicon_Database):

  • UIProcess/API/efl/ewk_form_submission_request.h:
  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(Ewk_Form_Submission_Request::~Ewk_Form_Submission_Request):
(Ewk_Form_Submission_Request::create):
(Ewk_Form_Submission_Request::Ewk_Form_Submission_Request):

  • UIProcess/API/efl/ewk_intent.h:
  • UIProcess/API/efl/ewk_intent_private.h:

(Ewk_Intent::create):
(Ewk_Intent::Ewk_Intent):

  • UIProcess/API/efl/ewk_intent_service.h:
  • UIProcess/API/efl/ewk_intent_service_private.h:

(Ewk_Intent_Service::create):
(Ewk_Intent_Service::Ewk_Intent_Service):

  • UIProcess/API/efl/ewk_navigation_data.h:
  • UIProcess/API/efl/ewk_navigation_data_private.h:

(Ewk_Navigation_Data::create):
(Ewk_Navigation_Data::Ewk_Navigation_Data):

  • UIProcess/API/efl/ewk_navigation_policy_decision.h:
  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(Ewk_Navigation_Policy_Decision::~Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::create):
(Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(Ewk_Popup_Menu_Item::Ewk_Popup_Menu_Item):

  • UIProcess/API/efl/ewk_popup_menu_item.h:
  • UIProcess/API/efl/ewk_popup_menu_item_private.h:

(Ewk_Popup_Menu_Item::create):
(Ewk_Popup_Menu_Item):

  • UIProcess/API/efl/ewk_resource.h:
  • UIProcess/API/efl/ewk_resource_private.h:

(Ewk_Resource::create):
(Ewk_Resource::Ewk_Resource):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/ewk_settings_private.h:

(Ewk_Settings::Ewk_Settings):

  • UIProcess/API/efl/ewk_text_checker_private.h:
  • UIProcess/API/efl/ewk_touch.h:
  • UIProcess/API/efl/ewk_url_request.h:
  • UIProcess/API/efl/ewk_url_request_private.h:

(Ewk_Url_Request::create):
(Ewk_Url_Request::Ewk_Url_Request):

  • UIProcess/API/efl/ewk_url_response.h:
  • UIProcess/API/efl/ewk_url_response_private.h:

(Ewk_Url_Response::create):
(Ewk_Url_Response::Ewk_Url_Response):

  • UIProcess/API/efl/ewk_url_scheme_request.h:
  • UIProcess/API/efl/ewk_url_scheme_request_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data::Ewk_View_Private_Data):
(Ewk_View_Private_Data::~Ewk_View_Private_Data):
(_ewk_view_smart_add):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
12:53 AM Changeset in webkit [131711] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Lion build fix after r131686. Add back if-def around #imports.

  • UIProcess/API/mac/WKView.mm:
12:36 AM Changeset in webkit [131710] by tkent@chromium.org
  • 7 edits in trunk

Set min-width property instead of width property for date/time fields
https://bugs.webkit.org/show_bug.cgi?id=99673

Reviewed by Hajime Morita.

Source/WebCore:

A field can have a text wider than pre-computed width because of
:first-letter property. So, we should set min-width, not width.

Tests: Covered by fast/forms/*-multiple-fields/*-multipe-fields-appearance-style.html

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
Set min-width instead of width.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Ditto.

LayoutTests:

Update affected test results. Non-Mac chromium ports already have lines
for them in TestExpectations.

  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
12:08 AM Changeset in webkit [131709] by morrita@google.com
  • 3 edits
    2 adds in trunk

Assertion failure at TreeScopeAdopter::moveNodeToNewDocument()
https://bugs.webkit.org/show_bug.cgi?id=99510

Reviewed by Kent Tamura.

Source/WebCore:

Shadow DOM notification call didn't have checks for mutation detection.
This change adds such checks.

Test: fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style.html

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):

LayoutTests:

  • fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style-expected.txt: Added.
  • fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style.html: Added.
12:05 AM Changeset in webkit [131708] by zandobersek@gmail.com
  • 5 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Updating baselines for two accessibility tests after r131674.

Updating baseline for media/video-playing-and-pause.html but still
marking the test a flaky as the render tree output can differ from
the new baseline.

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/inline-continuations-expected.txt:
  • platform/gtk/accessibility/media-element-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:

Oct 17, 2012:

10:59 PM Changeset in webkit [131707] by zoltan@webkit.org
  • 5 edits in trunk

Remove the JSHeap memory measurement of the PageLoad performacetests since it creates bogus JSGlobalDatas
https://bugs.webkit.org/show_bug.cgi?id=99609

Reviewed by Ryosuke Niwa.

Remove the implementation since it creates bogus JSGlobalDatas in the layout tests.

Source/JavaScriptCore:

  • heap/HeapStatistics.cpp:

(JSC):

  • heap/HeapStatistics.h:

(HeapStatistics):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):

10:55 PM Changeset in webkit [131706] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

10:42 PM Changeset in webkit [131705] by commit-queue@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

Let's move use-while-animating-crash-expected.txt to common place.
https://bugs.webkit.org/show_bug.cgi?id=99678

Unreviewed, expectations change.

Move expected result to common place to pass svg/animations/use-while-animating-crash.html case.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-17

  • svg/animations/use-while-animating-crash-expected.txt: Renamed from LayoutTests/platform/mac/svg/animations/use-while-animating-crash-expected.txt.
10:09 PM Changeset in webkit [131704] by mkwst@chromium.org
  • 14 edits
    2 adds in trunk/Source

Move mixed content logic out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45638

Reviewed by Eric Seidel.

Source/WebCore:

This change moves checks for mixed content out of FrameLoader, and into
a new MixedContentChecker object. It's a pretty straightforward
refactoring with no change to the overall logic, and only minor changes
to the code to reduce repetition.

The only substantive change is renaming the methods from 'checkIf*' to
'can*' to reflect the value of the boolean they return.

The visible functionality shouldn't change; this change should be
covered by existing tests in http/tests/security/mixedContent.

This patch is mostly a revitalization of Eric Sidel's original
patch: https://bugs.webkit.org/attachment.cgi?id=67432&action=prettypatch

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Hey, look! A new file!

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::mixedContentChecker):
(FrameLoader):

  • loader/MixedContentChecker.cpp: Added.

(WebCore):
(WebCore::MixedContentChecker::MixedContentChecker):
(WebCore::MixedContentChecker::client):
(WebCore::asUTF8):
(WebCore::MixedContentChecker::isMixedContent):
(WebCore::MixedContentChecker::canDisplayInsecureContent):
(WebCore::MixedContentChecker::canRunInsecureContent):
(WebCore::MixedContentChecker::logWarning):

  • loader/MixedContentChecker.h: Added.

(WebCore):
(MixedContentChecker):

Migrate functionality from FrameLoader::checkIf* to
MixedContentChecker::can*.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::pluginIsLoadable):
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::checkInsecureContent):

Use the new method locations.

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::checkIfRunInsecureContent):

Use the new method location.

10:01 PM Changeset in webkit [131703] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

REGRESSION (r95391): ComplexTextController is unnecessarily slow with characters with combining marks when the base character is not covered by any font
https://bugs.webkit.org/show_bug.cgi?id=99654

Reviewed by Adele Peterson.

When the base character of a combining character sequence is not covered by any one of the
available fonts, there is no point looking for a font that covers the entire sequence, nor
to try to use a combination of fallback fonts for the entire sequence.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::systemFallback): Moved ComplexTextController::systemFallbackFontData
here and renamed it.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns): This function used to use
systemFallbackFontData() whenever Font::fontDataForCombiningCharacterSequence returned 0
for a base character with combining marks, regardless of whether the base character was
covered by any font. Changed it to preserve the return value of
fontDataForCombiningCharacterSequence, which is now 0 only if the base charcater is not in
any font, while systemFallbackFontData() is used to indicate that no single font in the
fallback list covers all characters in the sequence, but the base character is in some font.

  • platform/graphics/mac/ComplexTextController.h:

(ComplexTextController): Moved systemFallbackFontData from here to SimpleFontData.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for the above
move.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence): Changed to return
systemFallbackFontData() if no single font in the fallback list covers all characters in the
sequence, while using 0 to signal the base character does not exist in any font.

9:34 PM Changeset in webkit [131702] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build after r131701.

  • WebCore.exp.in:
8:59 PM Changeset in webkit [131701] by hayato@chromium.org
  • 9 edits
    2 adds
    2 deletes in trunk

Content element does not expose distributedNodes property.
https://bugs.webkit.org/show_bug.cgi?id=99232

Reviewed by Dimitri Glazkov.

Add getDistributedNodes() to HTMLContentElement's IDL, which returns a
static NodeList whose node are distributed to the content element.

Source/WebCore:

Test: fast/dom/shadow/content-element-distributed-nodes.html

  • html/shadow/HTMLContentElement.idl:
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::getDistributedNodes):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/content-element-distributed-nodes-expected.txt: Added.
  • fast/dom/shadow/content-element-distributed-nodes.html: Added.
  • fast/dom/shadow/distributed-nodes-expected.txt: Removed.
  • fast/dom/shadow/distributed-nodes.html: Removed.
  • platform/qt/TestExpectations:
7:56 PM Changeset in webkit [131700] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix build break
https://bugs.webkit.org/show_bug.cgi?id=99670

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-17
Reviewed by Anders Carlsson.

Unreviewed build fix.

Include MessageEncoder.h instead of forwarding declaration for
MessageEncoder class.

  • Scripts/webkit2/messages.py:

(forward_declarations_and_headers):

7:24 PM Changeset in webkit [131699] by dpranke@chromium.org
  • 7 edits in trunk/Tools

[chromium] stop falling back to platform/mac for LayoutTest results
https://bugs.webkit.org/show_bug.cgi?id=99666

Reviewed by James Robinson.

Previously the Chromium ports would fall back to results in
platform/mac if a result was not found in platform/chromium-*.
This allowed us to share a lot of results w/ the Apple Mac port,
but often surprised people (especially at Apple ;) when changing
something in that directory would break a Chromium build.

The tests that are deleted in baselineoptimizer were for cases
that are no longer relevant or possible in the current fallback
graph.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_chromium_covers_mac_win_linux):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
7:11 PM Changeset in webkit [131698] by dpranke@chromium.org
  • 1 edit
    575 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [7 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

(long list of expectations files omitted).

7:10 PM Changeset in webkit [131697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Make WebContentLayer include what it uses
https://bugs.webkit.org/show_bug.cgi?id=99664

Patch by Adrienne Walker <enne@chromium.org> on 2012-10-17
Reviewed by James Robinson.

  • chromium/public/WebContentLayer.h:
7:09 PM Changeset in webkit [131696] by dpranke@chromium.org
  • 1 edit
    1136 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [6 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

(long list of expectations files omitted).

7:06 PM Changeset in webkit [131695] by dpranke@chromium.org
  • 1 edit
    1127 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [5 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

(long list of expectations files omitted).

7:00 PM Changeset in webkit [131694] by dpranke@chromium.org
  • 1 edit
    1129 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [4 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

(long list of expectations files omitted).

6:56 PM Changeset in webkit [131693] by commit-queue@webkit.org
  • 14 edits
    25 adds in trunk

Source/WebCore: [User Timing] implement main interface in of User Timing, according to http://www.w3.org/TR/2012/CR-user-timing-20120726/
https://bugs.webkit.org/show_bug.cgi?id=90963

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-17
Reviewed by Tony Gentilcore.

This patch implemented mark(), measure(), clearMarks() and clearMeasures() interface of User Timing. Getters are not exposed by Performance Timeline yet, it will be future patch.

Tests: http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMarks.html

http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMeasures.html
http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark.html
http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark_exception.html
http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure.html
http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_associate_with_navigation_timing.html
http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_exception.html
http/tests/w3c/webperf/submission/user-timing/test_user_timing_method_exist.html

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • page/Performance.cpp:

(WebCore::Performance::webkitGetEntries):
(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):
(WebCore):
(WebCore::Performance::webkitMark):
(WebCore::Performance::webkitClearMarks):
(WebCore::Performance::webkitMeasure):
(WebCore::Performance::webkitClearMeasures):

  • page/Performance.h:

(WebCore):
(Performance):

  • page/Performance.idl:
  • page/PerformanceMark.h: Added.

(WebCore):
(PerformanceMark):
(WebCore::PerformanceMark::create):
(WebCore::PerformanceMark::PerformanceMark):
(WebCore::PerformanceMark::~PerformanceMark):

  • page/PerformanceMark.idl: Added.
  • page/PerformanceMeasure.h: Added.

(WebCore):
(PerformanceMeasure):
(WebCore::PerformanceMeasure::create):
(WebCore::PerformanceMeasure::PerformanceMeasure):
(WebCore::PerformanceMeasure::~PerformanceMeasure):

  • page/PerformanceMeasure.idl: Added.
  • page/PerformanceUserTiming.cpp: Added.

(WebCore):
(WebCore::UserTiming::UserTiming):
(WebCore::insertPerformanceEntry):
(WebCore::clearPeformanceEntries):
(WebCore::UserTiming::mark):
(WebCore::UserTiming::clearMarks):
(WebCore::UserTiming::findExistingMarkStartTime):
(WebCore::UserTiming::measure):
(WebCore::UserTiming::clearMeasures):

  • page/PerformanceUserTiming.h: Added.

(WebCore):
(UserTiming):
(WebCore::UserTiming::create):

LayoutTests: [User Timing] Test Cases of User Timing. According to http://www.w3.org/TR/2012/CR-user-timing-20120726/
https://bugs.webkit.org/show_bug.cgi?id=90963

Patch by Pan Deng <pan.deng@intel.com> on 2012-10-17
Reviewed by Tony Gentilcore.

Test cases in this patch validate functionality of W3C User Timing interface. These test cases use W3C testharness. Since User Timing feature is not enabled in any platform yet, all skipped currenttly.

  • http/tests/w3c/webperf/resources/webperftestharnessextension.js: Added.

(test_method_exists):
(test_noless_than):
(performance_entrylist_checker.entry_check.test_equals):
(performance_entrylist_checker.entry_check):
(performance_entrylist_checker.entrylist_order_check):
(performance_entrylist_checker.entrylist_check):
(PerformanceContext):
(PerformanceContext.prototype.initialMeasures):
(PerformanceContext.prototype.mark):
(PerformanceContext.prototype.measure):
(PerformanceContext.prototype.clearMarks):
(PerformanceContext.prototype.clearMeasures):
(PerformanceContext.prototype.getEntries):
(PerformanceContext.prototype.getEntriesByType):
(PerformanceContext.prototype.getEntriesByName):

  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMarks-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMarks.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMeasures-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_clearMeasures.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark_exception-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_mark_exception.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_associate_with_navigation_timing-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_associate_with_navigation_timing.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_exception-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_measure_exception.html: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_method_exist-expected.txt: Added.
  • http/tests/w3c/webperf/submission/user-timing/test_user_timing_method_exist.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
6:42 PM Changeset in webkit [131692] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed clang compile fix - GraphicsLayerUpdater needs a virtual destructor.

  • platform/graphics/GraphicsLayerUpdater.h:

(GraphicsLayerUpdater):

6:42 PM Changeset in webkit [131691] by dpranke@chromium.org
  • 1 edit
    1126 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [3 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

(long list of expectations files omitted).

6:38 PM Changeset in webkit [131690] by dpranke@chromium.org
  • 1 edit
    1106 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [2 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

(long list of expectations files omitted).

6:33 PM Changeset in webkit [131689] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Bump up the number of iterations of html5-full-render to 5
https://bugs.webkit.org/show_bug.cgi?id=99657

Reviewed by Andreas Kling.

Now that html5-full-render.html runs in less than 15 seconds after r131553,
we can afford to get 5 instead of 2 samples.

  • Parser/html5-full-render.html:
6:32 PM Changeset in webkit [131688] by tkent@chromium.org
  • 101 edits
    8 adds
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline expectations for multiple-fields <input>

  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
6:31 PM Changeset in webkit [131687] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the build after r131680.

Unreviewed build fix.

  • dom/Document.cpp: Guard ACCELERATED_COMPOSITING for RenderLayerCompositor.h
6:27 PM Changeset in webkit [131686] by Darin Adler
  • 8 edits in trunk/Source/WebKit2

Make subclassing of WKView safer by namespacing methods and eliminating its use as an observer and delegate
https://bugs.webkit.org/show_bug.cgi?id=99251

Reviewed by Anders Carlsson.

Apps that subclass WKView should be able to freely choose method names without conflicting with a name
we chose to use internally in WKView's own implementation. Thus, it's a good idea to add a "_wk_" prefix
to any method names that are solely for internal WebKit2 use. Exceptions to this are method names that
are predetermined by AppKit, or names that are part of API or SPI.

Apps that subclass WKView should be able to add observers or use the WKView as a delegate without
conflicting with similar use in the WKView implementations. Thus, changed to use separate block-style
observers for the window notifications and a separate delegate for the tool tip implementation.

The challenging aspect of this patch was to research which method names were determined by AppKit.
There's nothing in the WebKit2 source code that necessarily states this explicitly.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createDrawingAreaProxy): Updated for new method name.
(WebKit::PageClientImpl::scrollView): Ditto.
(WebKit::PageClientImpl::isViewFocused): Ditto.
(WebKit::PageClientImpl::colorSpace): Ditto.
(WebKit::PageClientImpl::processDidCrash): Ditto.
(WebKit::PageClientImpl::pageClosed): Ditto.
(WebKit::PageClientImpl::didRelaunchProcess): Ditto.
(WebKit::PageClientImpl::toolTipChanged): Ditto.
(WebKit::PageClientImpl::setCursor): Ditto.
(WebKit::PageClientImpl::interpretKeyEvent): Ditto.
(WebKit::PageClientImpl::setDragImage): Ditto.
(WebKit::PageClientImpl::setPromisedData): Ditto.
(WebKit::PageClientImpl::updateTextInputState): Ditto.
(WebKit::PageClientImpl::resetTextInputState): Ditto.
(WebKit::PageClientImpl::convertToDeviceSpace): Ditto.
(WebKit::PageClientImpl::convertToUserSpace): Ditto.
(WebKit::PageClientImpl::doneWithKeyEvent): Ditto.
(WebKit::PageClientImpl::setFindIndicator): Ditto.
(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived): Ditto.
(WebKit::PageClientImpl::enterAcceleratedCompositingMode): Ditto.
(WebKit::PageClientImpl::exitAcceleratedCompositingMode): Ditto.
(WebKit::PageClientImpl::updateAcceleratedCompositingMode): Ditto.
(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged): Ditto.
(WebKit::PageClientImpl::setPluginComplexTextInputState): Ditto.
(WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): Ditto.
(WebKit::PageClientImpl::didCommitLoadForMainFrame): Ditto.
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): Ditto.
(WebKit::PageClientImpl::customRepresentationZoomFactor): Ditto.
(WebKit::PageClientImpl::setCustomRepresentationZoomFactor): Ditto.
(WebKit::PageClientImpl::findStringInCustomRepresentation): Ditto.
(WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): Ditto.
(WebKit::PageClientImpl::executeSavedCommandBySelector): Ditto.
(WebKit::PageClientImpl::showDictationAlternativeUI): Ditto.

  • UIProcess/API/mac/WKView.mm: Simplified imports a bit. No need for conditional imports of basic classes

like NSTextAlternatives.h and NSAttributedString.h. No need to put internal headers in a separate paragraph.
Added WKToolTipDelegate class and added _toolTipDelegate and _observers fields to WKViewData.
(-[WKView becomeFirstResponder]): Updated for new method name.
(-[WKView resignFirstResponder]): Ditto.
(-[WKView setFrameSize:]): Ditto.
(-[WKView _wk_updateWindowAndViewFrames]): Ditto.
(-[WKView renewGState]): Ditto.
(-[WKView _wk_setPluginComplexTextInputState:]): Ditto.
(validateCommandCallback): Ditto.
(-[WKView displayIfNeeded]): Fixed a comment typo.
(-[WKView _wk_setMouseDownEvent:]): Updated for new method name.
(-[WKView mouseDown:]): Ditto.
(-[WKView mouseUp:]): Ditto.
(-[WKView acceptsFirstMouse:]): Ditto.
(-[WKView shouldDelayWindowOrderingForEvent:]): Ditto.
(-[WKView _wk_handleStyleKeyEquivalent:]): Ditto.
(-[WKView performKeyEquivalent:]): Ditto.
(-[WKView _wk_disableComplexTextInputIfNecessary]): Ditto.
(-[WKView _wk_handlePluginComplexTextInputKeyDown:]): Ditto.
(-[WKView _wk_tryHandlePluginComplexTextInputKeyDown:]): Ditto.
(-[WKView keyDown:]): Ditto.
(-[WKView _wk_executeSavedKeypressCommands]): Ditto.
(-[WKView _wk_notifyInputContextAboutDiscardedComposition]): Ditto.
(-[WKView selectedRange]): Ditto.
(-[WKView hasMarkedText]): Ditto.
(-[WKView unmarkText]): Ditto.
(-[WKView setMarkedText:selectedRange:replacementRange:]): Ditto.
(-[WKView markedRange]): Ditto.
(-[WKView attributedSubstringForProposedRange:actualRange:]): Ditto.
(-[WKView characterIndexForPoint:]): Ditto.
(-[WKView firstRectForCharacterRange:actualRange:]): Ditto.
(-[WKView _wk_updateWindowVisibility]): Ditto.
(-[WKView _wk_updateWindowObserversForWindow:]): Replaced the two separate methods
addWindowObserversForWindow and removeWindowObservers with this single method, since
the two are only used in tandem. Changed code to use blocks for the observers and to
keep the observers in an array.
(-[WKView viewWillMoveToWindow:]): Updated to use _wk_updateWindowObserversForWindow.
(-[WKView viewDidMoveToWindow]): Updated for new method names.
(-[WKView _wk_windowScreenDidChange]): Ditto.
(-[WKView _wk_windowDidBecomeKey:]): Ditto.
(-[WKView _wk_windowDidChangeScreen:]): Ditto.
(-[WKView _wk_windowDidResignKey:]): Ditto.
(-[WKView _wk_windowDidMiniaturize:]): Ditto.
(-[WKView _wk_windowDidDeminiaturize:]): Ditto.
(-[WKView _wk_windowDidMove:]): Ditto.
(-[WKView _wk_windowDidResize:]): Ditto.
(-[WKView _wk_windowDidOrderOffScreen:]): Ditto.
(-[WKView _wk_windowDidOrderOnScreen:]): Ditto.
(-[WKView _wk_windowDidChangeBackingProperties:]): Ditto.
(-[WKView drawRect:]): Ditto.
(-[WKView _wk_accessibilityRegisterUIProcessTokens]): Ditto.
(-[WKView _wk_updateRemoteAccessibilityRegistration:]): Ditto.
(-[WKView _wk_postFakeMouseMovedEventForFlagsChangedEvent:]): Ditto.
(-[WKView _wk_intrinsicDeviceScaleFactor]): Ditto.
(-[WKView _wk_setDrawingAreaSize:]): Ditto.
(-[WKView _wk_shouldUseTiledDrawingArea]): Ditto.
(-[WKView _wk_createDrawingAreaProxy]): Ditto.
(-[WKView _wk_isFocused]): Ditto.
(-[WKView _wk_processDidCrash]): Ditto.
(-[WKView _wk_pageClosed]): Ditto.
(-[WKView _wk_didRelaunchProcess]): Ditto.
(-[WKView _wk_setCursor:]): Ditto.
(-[WKView _wk_setUserInterfaceItemState:enabled:state:]): Ditto.
(-[WKView _wk_tryPostProcessPluginComplexTextInputKeyDown:]): Ditto.
(-[WKView _wk_doneWithKeyEvent:eventWasHandled:]): Ditto.
(-[WKView _wk_interpretKeyEvent:savingCommandsTo:]): Ditto.
(-[WKView _wk_convertToDeviceSpace:]): Ditto.
(-[WKView _wk_convertToUserSpace:]): Ditto.
(-[WKView _wk_addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Ditto.
(-[WKView _wk_addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Ditto.
(-[WKView _wk_removeTrackingRects:count:]): Ditto.
(-[WKView _wk_sendToolTipMouseExited]): Ditto.
(-[WKView _wk_sendToolTipMouseEntered]): Ditto.
(-[WKView _wk_toolTipChangedFrom:to:]): Changed to use the data object as the tool tip owner so
the delegate method can be there rather than on WKView.
(-[WKView _wk_setFindIndicator:fadeOut:animate:]): Updated for new method names.
(-[WKView _wk_enterAcceleratedCompositingMode:]): Ditto.
(-[WKView _wk_exitAcceleratedCompositingMode]): Ditto.
(-[WKView _wk_updateAcceleratedCompositingMode:]): Ditto.
(-[WKView _wk_setAccessibilityWebProcessToken:]): Ditto.
(-[WKView _wk_pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]): Ditto.
(-[WKView _wk_setPluginComplexTextInputState:pluginComplexTextInputIdentifier:]): Ditto.
(-[WKView _wk_setPageHasCustomRepresentation:]): Ditto.
(-[WKView _wk_didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:]): Ditto.
(-[WKView _wk_customRepresentationZoomFactor]): Ditto.
(-[WKView _wk_setCustomRepresentationZoomFactor:]): Ditto.
(-[WKView _wk_findStringInCustomRepresentation:withFindOptions:maxMatchCount:]): Ditto.
(-[WKView _wk_countStringMatchesInCustomRepresentation:withFindOptions:maxMatchCount:]): Ditto.
(-[WKView _wk_setDragImage:at:linkDrag:]): Ditto.
(-[WKView _wk_setPromisedData:withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:forPasteboard:]): Ditto.
(-[WKView _wk_updateSecureInputState]): Ditto.
(-[WKView _wk_updateTextInputStateIncludingSecureInputState:]): Ditto.
(-[WKView _wk_resetTextInputState]): Ditto.
(-[WKView _wk_didChangeScrollbarsForMainFrame]): Ditto.
(-[WKView _wk_hasFullScreenWindowController]): Ditto.
(-[WKView _wk_fullScreenWindowController]): Ditto.
(-[WKView _wk_closeFullScreenWindowController]): Ditto.
(-[WKView _wk_executeSavedCommandBySelector:]): Ditto.
(-[WKView _wk_cacheWindowBottomCornerRect]): Ditto.
(-[WKView _wk_spellCheckerDocumentTag]): Ditto.
(-[WKView _wk_handleAcceptedAlternativeText:]): Ditto.
(-[WKView _wk_setSuppressVisibilityUpdates:]): Ditto.
(-[WKView _wk_suppressVisibilityUpdates]): Ditto.
(-[WKView _wk_registerDraggedTypes]): Ditto.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Ditto.
(-[WKView wantsUpdateLayer]): Ditto.
(-[WKView enableFrameSizeUpdates]): Ditto.
(-[WKToolTipDelegate initWithPage:]): Added.
(-[WKToolTipDelegate view:stringForToolTip:point:userData:]): Added.

  • UIProcess/API/mac/WKViewInternal.h: Changed all internal method names to have a _wk_ prefix.
  • UIProcess/API/mac/WKViewPrivate.h: Expose the _shouldUseTiledDrawingArea method formally as SPI

since Safari is currently overriding this method.

  • UIProcess/mac/CorrectionPanel.mm:

(WebKit::CorrectionPanel::recordAutocorrectionResponse): Updated for new method names.
(WebKit::CorrectionPanel::handleAcceptedReplacement): Ditto.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]): Updated for new method names.
(-[WKFullScreenWindowController exitFullScreen]): Ditto.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Ditto.
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]): Ditto.

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::invalidate): Updated for new method names.
(WebKit::WebFullScreenManagerProxy::close): Ditto.
(WebKit::WebFullScreenManagerProxy::isFullScreen): Ditto.
(WebKit::WebFullScreenManagerProxy::enterFullScreen): Ditto.
(WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen): Ditto.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen): Ditto.

6:02 PM Changeset in webkit [131685] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

StyleRareNonInheritedData::contentDataEquivalent only looks at the first ContentData
https://bugs.webkit.org/show_bug.cgi?id=99560

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-17
Reviewed by Eric Seidel.

Source/WebCore:

Previously we only compared the first ContentData in the linked
list of ContentData's which meant that if the resolved style
for content had the same prefix we wouldn't update the content.

This patch adds a loop to compare each of the ContentData objects
in the linked list.

Test: fast/css-generated-content/content-property-change.html

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::contentDataEquivalent):

LayoutTests:

Test that when the content CSS property changes we update the displayed content.

  • fast/css-generated-content/content-property-change-expected.html: Added.
  • fast/css-generated-content/content-property-change.html: Added.
5:59 PM Changeset in webkit [131684] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove StyleContentType since it's not used anymore
https://bugs.webkit.org/show_bug.cgi?id=99659

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-17
Reviewed by Eric Seidel.

Remove StyleContentType enum since it's not used anymore and
make the is*() type checking methods on ContentData public.

No new tests needed, this is just deleting dead code.

  • rendering/style/ContentData.h:

(ContentData):

  • rendering/style/RenderStyleConstants.h:
5:59 PM Changeset in webkit [131683] by dpranke@chromium.org
  • 1 edit
    1124 adds in trunk/LayoutTests

2012-10-17 Dirk Pranke <dpranke@chromium.org>

Clone baselines from platform/mac to platform/chromium [1 of 7]
https://bugs.webkit.org/show_bug.cgi?id=99666

Unreviewed, expectations change.

5:54 PM Changeset in webkit [131682] by weinig@apple.com
  • 1 edit
    1 copy in trunk/Source/JavaScriptCore

Attempt to fix the build.

  • bytecode/GlobalResolveInfo.h: Copied from bytecode/GlobalResolveInfo.h.
5:47 PM Changeset in webkit [131681] by commit-queue@webkit.org
  • 5 edits in trunk

Remove redundant sdk_build parameter.
https://bugs.webkit.org/show_bug.cgi?id=99648

Patch by Shashi Shekhar <shashishekhar@google.com> on 2012-10-17
Reviewed by Adam Barth.

sdk_build parameter is no longer needed.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
5:42 PM Changeset in webkit [131680] by Simon Fraser
  • 15 edits
    2 adds in trunk/Source/WebCore

Create a GraphicsLayerUpdater class that will do periodic layer flushes for layer trees containing tile caches
https://bugs.webkit.org/show_bug.cgi?id=99518

Reviewed by Dean Jackson.

When using tile caches in place of tiled layers, we need to recompute their
visible area periodically while animations and scrolling are happening.
Make a new class, GraphicsLayerUpdater, to handle this updating.
Internally, it uses DisplayRefreshMonitor to generate the periodic updates.

GraphicsLayer clients are notified that layers need periodic updates. Clients
are free to make use of GraphicsLayerUpdater to handle this updating, as
RenderLayerCompositor does.

Also do some minor refactoring of methods in RenderLayerCompositor that
get to Page.

  • CMakeLists.txt: Add GraphicsLayerUpdater.cpp to the build.
  • GNUmakefile.list.am: Ditto.
  • PlatformBlackBerry.cmake: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp:

(WebCore::Document::windowScreenDidChange): Tell the compositor that the screen
changed, so it can tell the GraphicsLayerUpdater if it has one.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::notifyFlushBeforeDisplayRefresh): Method called
for layers that need periodic updates, like tile cache layers.

  • platform/graphics/GraphicsLayerUpdater.cpp: Added. Uses DisplayRefreshMonitorManager

to flush layers before the next refresh.
(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::~GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::scheduleUpdate):
(WebCore::GraphicsLayerUpdater::screenDidChange):
(WebCore::GraphicsLayerUpdater::displayRefreshFired):

  • platform/graphics/GraphicsLayerUpdater.h: Added.

(GraphicsLayerUpdaterClient): Clients need to implement flushLayers().
(WebCore::GraphicsLayerUpdaterClient::~GraphicsLayerUpdaterClient):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges): For tile cache layers,
tell the client that this layer should be updated soon to update the visible rect.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyFlushBeforeDisplayRefresh): Pass this message
on to the compositor.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking): Implement notifyFlushBeforeDisplayRefresh.
Add OVERRIDE to all the client overrides.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): Use helper to get to Page.
(WebCore::RenderLayerCompositor::scheduleLayerFlush): Ditto.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): Soon we're going to be asking
about the current state of animations inside the flush (for visible rect computation), so we
need a AnimationUpdateBlock to make sure all the animation times are in sync.
(WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh): Make a GraphicsLayerUpdater
if necessary, and tell it to update soon.
(WebCore::RenderLayerCompositor::flushLayers): The GraphicsLayerUpdater client method.
Just does a flush. For now, considers this Frame as the flush root, which will need fixing for iframes.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame): Use helper to get to Page.
(WebCore::RenderLayerCompositor::deviceScaleFactor): Ditto.
(WebCore::RenderLayerCompositor::pageScaleFactor): Ditto.
(WebCore::RenderLayerCompositor::destroyRootLayer): Ditto.
(WebCore::RenderLayerCompositor::windowScreenDidChange): Tell the updater if we have one.
(WebCore::RenderLayerCompositor::scrollingCoordinator): Use helper to get to Page.
(WebCore::RenderLayerCompositor::graphicsLayerFactory): Use helper to get to Page.
(WebCore::RenderLayerCompositor::page): The helper.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor): Add OVERRIDE to all the client overrides.

5:36 PM Changeset in webkit [131679] by andersca@apple.com
  • 28 edits
    4 copies in trunk/Source/WebKit2

Add MessageEncoder and MessageDecoder subclasses
https://bugs.webkit.org/show_bug.cgi?id=99365

Reviewed by Andreas Kling.

This is the first step towards cleaning up IPC handling in WebKit2. The idea is that MessageEncoder and MessageDecoder
will handle all the IPC specific parts of encoding and decoding (such as attachments), whereas the ArgumentEncoder and ArgumentDecoder
classes are only used for serializing simpler data types.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::create):
(CoreIPC::ArgumentDecoder::initialize):

  • Platform/CoreIPC/ArgumentDecoder.h:

(ArgumentDecoder):

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::create):
(CoreIPC::ArgumentEncoder::ArgumentEncoder):

  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):
(PendingSyncReply):
(CoreIPC::Connection::PendingSyncReply::releaseReplyDecoder):
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::waitForAndDispatchImmediately):
(CoreIPC::Connection::deprecatedSendSync):
(CoreIPC::Connection::deprecatedSend):

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::create):
(CoreIPC::MessageDecoder::~MessageDecoder):
(CoreIPC::MessageDecoder::MessageDecoder):

  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC):
(MessageDecoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC):
(CoreIPC::MessageEncoder::create):
(CoreIPC::MessageEncoder::MessageEncoder):
(CoreIPC::MessageEncoder::~MessageEncoder):

  • Platform/CoreIPC/MessageEncoder.h:

(CoreIPC):
(MessageEncoder):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendMessage):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):
(CoreIPC::Connection::receiveSourceEventHandler):

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::writeEventHandler):
(CoreIPC::Connection::platformCanSendOutgoingMessages):
(CoreIPC::Connection::sendOutgoingMessage):

  • Scripts/webkit2/messages.py:

(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:

(MessageEncoder):

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):

  • Shared/WebConnection.h:

(CoreIPC):

  • Target.pri:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::postMessageToInjectedBundle):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendMessage):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):
(WebKit::WebProcessProxy::deprecatedSend):
(WebKit::WebProcessProxy::send):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::DecoderAdapter):
(WebKit::DecoderAdapter::decodeBytes):
(WebKit::DecoderAdapter::decodeBool):
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit::DecoderAdapter::decodeUInt32):
(WebKit::DecoderAdapter::decodeUInt64):
(WebKit::DecoderAdapter::decodeInt32):
(WebKit::DecoderAdapter::decodeInt64):
(WebKit::DecoderAdapter::decodeFloat):
(WebKit::DecoderAdapter::decodeDouble):
(WebKit::DecoderAdapter::decodeString):

  • WebProcess/WebPage/DecoderAdapter.h:

(DecoderAdapter):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::EncoderAdapter):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::postInjectedBundleMessage):

  • win/WebKit2.vcproj:
5:29 PM WikiStart edited by zoltan@webkit.org
(diff)
5:28 PM Performance Tests created by zoltan@webkit.org
Rename page from: …
5:25 PM WikiStart edited by zoltan@webkit.org
(diff)
5:24 PM Changeset in webkit [131678] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Make dom-query.html slightly faster by removing unnecessary ref-churn in StringTraits
https://bugs.webkit.org/show_bug.cgi?id=99652

Reviewed by Adam Barth.

My testing showed this moved dom-query.html from 465560 runs/s to 479019
which is about 2% if I'm doing my math correctly.

I suspect that's due to avoiding the ref-churn we were incurring by using
return-by-value symantics here.

This is just the tip of the iceburg. :)

  • bindings/v8/V8StringResource.cpp:

(StringTraits):

  • bindings/v8/V8ValueCache.h:

(WebCore::WebCoreStringResource::webcoreString):
(WebCore::WebCoreStringResource::atomicString):

5:18 PM Changeset in webkit [131677] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Move handling of CSSPropertyWebkitLineClamp from StyleResolver into StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=99534

Reviewed by Alexis Menard.

One small step towards removing the giant switch statement in StyleResolver, this patch moves line clamp handling into StyleBuilder.

Covered by fast/overflow/line-clamp.html

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

5:09 PM Changeset in webkit [131676] by oliver@apple.com
  • 49 edits in trunk/Source/JavaScriptCore

Roll out r131645 as it causes random site crashes.

5:08 PM Changeset in webkit [131675] by aestes@apple.com
  • 7 edits in trunk/Source

[WebKit2] Add removeChild: to WKDOMNode and make WKDOMText.data read/write
https://bugs.webkit.org/show_bug.cgi?id=99662

Reviewed by Sam Weinig.

Source/WebCore:

Export needed symbols.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode removeChild:]):

  • WebProcess/InjectedBundle/API/mac/WKDOMText.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMText.mm:

(-[WKDOMText setData:]):

5:07 PM Changeset in webkit [131674] by commit-queue@webkit.org
  • 45 edits in trunk

[GTK] AccessibilityUIElement::role() should be consistent across platforms wherever possible
https://bugs.webkit.org/show_bug.cgi?id=99640

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-10-17
Reviewed by Chris Fleizach.

Tools:

Convert AtkRole instances to the Mac/Safari-style AXRole string.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(roleToString): New method to convert AtkRole instances to the Mac/Safari-style AXRole string
(AccessibilityUIElement::role): Output the Mac/Safair-style AXRole string rather than the AtkRole's name

LayoutTests:

Updated tests and expectations to use the Mac/Safari-style AXRole strings

  • platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
  • platform/gtk/accessibility/aria-combobox-expected.txt:
  • platform/gtk/accessibility/aria-fallback-roles-expected.txt:
  • platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:
  • platform/gtk/accessibility/aria-roles-expected.txt:
  • platform/gtk/accessibility/aria-roles-unignored-expected.txt:
  • platform/gtk/accessibility/aria-roles-unignored.html:
  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt:
  • platform/gtk/accessibility/aria-slider-required-attributes.html:
  • platform/gtk/accessibility/aria-table-hierarchy-expected.txt:
  • platform/gtk/accessibility/aria-table-hierarchy.html:
  • platform/gtk/accessibility/aria-tables-expected.txt:
  • platform/gtk/accessibility/aria-toggle-button-role-expected.txt:
  • platform/gtk/accessibility/aria-toggle-button-role.html:
  • platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt:
  • platform/gtk/accessibility/button-accessible-name-expected.txt:
  • platform/gtk/accessibility/button-accessible-name.html:
  • platform/gtk/accessibility/canvas-description-and-role-expected.txt:
  • platform/gtk/accessibility/caret-browsing-text-focus-expected.txt:
  • platform/gtk/accessibility/caret-browsing-text-focus.html:
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:
  • platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt:
  • platform/gtk/accessibility/entry-and-password-expected.txt:
  • platform/gtk/accessibility/input-slider-expected.txt:
  • platform/gtk/accessibility/input-slider.html:
  • platform/gtk/accessibility/legend-expected.txt:
  • platform/gtk/accessibility/list-items-always-exposed-expected.txt:
  • platform/gtk/accessibility/list-items-always-exposed.html:
  • platform/gtk/accessibility/media-controls-panel-title-expected.txt:
  • platform/gtk/accessibility/media-controls-panel-title.html:
  • platform/gtk/accessibility/name-from-label-expected.txt:
  • platform/gtk/accessibility/name-from-label.html:
  • platform/gtk/accessibility/object-with-title-expected.txt:
  • platform/gtk/accessibility/object-with-title.html:
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
  • platform/gtk/accessibility/spans-expected.txt:
  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html:
  • platform/gtk/accessibility/spans.html:
  • platform/gtk/accessibility/svg-image-expected.txt:
  • platform/gtk/accessibility/table-hierarchy-expected.txt:
  • platform/gtk/accessibility/table-hierarchy.html:
5:03 PM Changeset in webkit [131673] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
https://bugs.webkit.org/show_bug.cgi?id=99653

Reviewed by Eric Seidel.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

5:02 PM Changeset in webkit [131672] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Destroy leveldb directory if unknown schema is detected
https://bugs.webkit.org/show_bug.cgi?id=99636

Reviewed by Tony Chang.

chromium browser test in progress at
https://codereview.chromium.org/11196029

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):
(WebCore::isSchemaKnown):
Return true when the schema key doesn't exist because new databases
won't have one.

(WebCore::setUpMetadata):
(WebCore::IDBLevelDBBackingStore::open):
Piggy-back on existing leveldb::destroy code.

5:00 PM Changeset in webkit [131671] by commit-queue@webkit.org
  • 7 edits
    1 copy
    2 adds in trunk

Incorrect rendering of borders on <col> with span > 1
https://bugs.webkit.org/show_bug.cgi?id=76246

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-10-17
Reviewed by Julien Chaffraix.

Source/WebCore:

The HTML5 rendering specification [10.2.2 - Display Types] states that
"For the purposes of the CSS table model, the col element is expected to
be treated as if it was present as many times as its span attribute
specifies."
We should thus apply a col element's border as if the element is present
as many number of times as its span attribute.

Apart from this, we should also treat the col and its enclosing colgroup
separately while computing the collapsed borders.

Test: fast/table/border-collapsing/collapsed-border-with-col-colgroup-span.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Borders from col and its enclosing colgroup element should be handled
separately, while considering the preceeding col's end border (for start
border computation) and the next col's start border (for end border
computation).

Also, have made changes for handling of col elements with span attribute as
per the specification. We now apply the border (start or end) of the col
element irrespective of whether it has any span specified for it or not.

LayoutTests:

  • fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png:
  • fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
  • fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png:
  • fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:

Existing tests modified. This is because previously, while computing collapsed
start border, we did not take the preceeding col's enclosing colgroup's end border
into consideration. While computing the collapsed start border, only the preceeding
col element's end border was considered.

With this fix, for the above two tests, the last col's width now changes due to
the border being applied to it (the preceeding col's enclosing colgroup's end border)
which causes the table's width to change. Also, we should note that the cell's grow
by half the border's width; which is expected (on account of their being collapsed
borders).

  • fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.txt: Added.
  • fast/table/border-collapsing/collapsed-border-with-col-colgroup-span.html: Added.
  • platform/chromium-linux/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.

Image only test added for verifying the behavior of collapsed borders with
col and colgroup span.
New expected image file added for the chromium-linux port.

4:57 PM Changeset in webkit [131670] by tsepez@chromium.org
  • 4 edits
    2 adds in trunk

Crash in ContainerNode::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=98443

Reviewed by Eric Carlson.

Source/WebCore:

This patch makes the errorEventSender added in WebKit Revision 112190 interact
with the updatedHasPendingLoadEvent() mechanism in the same manner as the other
existing event senders.

Test: http/tests/security/video-poster-cross-origin-crash2.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):

  • loader/ImageLoader.h:

(ImageLoader):

LayoutTests:

  • http/tests/security/video-poster-cross-origin-crash2-expected.txt: Added.
  • http/tests/security/video-poster-cross-origin-crash2.html: Added.
4:54 PM Changeset in webkit [131669] by jsbell@chromium.org
  • 12 edits
    2 copies in branches/chromium/1271

Merge 131658 - IndexedDB: Enforce unsigned long/unsigned long long ranges
https://bugs.webkit.org/show_bug.cgi?id=99637

Reviewed by Tony Chang.

Source/WebCore:

The IndexedDB spec has [EnforceRange] specified on unsigned long and unsigned long long
arguments, which requires the implementation to throw TypeError for negative values or
values that exceed 253-1 (maximum JS number that behaves like an integer) - and 0 is
specifically forbidden by the APIs as well.

A more correct fix in the binding layer is in webkit.org/b/96798 but we can temporarily
address this in the implementation.

Also refactor to prevent IDBFactory.open(name, -1) from triggering an internal code path.

Tests: storage/indexeddb/cursor-advance.html

storage/indexeddb/intversion-bad-parameters.html
storage/indexeddb/intversion-encoding.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance): Validate argument range.

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl: Drop "unsigned" qualifier as the binding code is

not yet doing the correct validation.

  • Modules/indexeddb/IDBFactory.cpp: Refactor to prevent open(name, -1)

(WebCore):
(WebCore::IDBFactory::open): Validate the int version here, then pass to...
(WebCore::IDBFactory::openInternal): ... this method.

  • Modules/indexeddb/IDBFactory.h:

(IDBFactory):

  • Modules/indexeddb/IDBFactory.idl: Drop "unsigned" qualifier; meaningless to binding

code right now, can be re-added once webkit.org/b/96798 lands.

LayoutTests:

Additional edge case tests and updated expectations.

  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/intversion-bad-parameters-expected.txt:
  • storage/indexeddb/intversion-encoding-expected.txt:
  • storage/indexeddb/resources/cursor-advance.js:

(testBadAdvance.advanceBadly):
(testBadAdvance):

  • storage/indexeddb/resources/intversion-bad-parameters.js:

(deleteSuccess):

  • storage/indexeddb/resources/intversion-encoding.js:

TBR=jsbell@chromium.org
Review URL: https://codereview.chromium.org/11184033

4:51 PM Changeset in webkit [131668] by jsbell@chromium.org
  • 6 edits in trunk

IndexedDB: Closing connection in upgradeneeded should result in error event
https://bugs.webkit.org/show_bug.cgi?id=99486

Reviewed by Tony Chang.

Source/WebCore:

The IDB spec requires that "...if connection is closed, return a DOMError of type AbortError".
This was being handled during the "enqueue" phase, which was too early either for synchronously
executing scripts or asynchronous messaging in multiprocess ports (crbug.com/150691). Move the
logic to the "dispatch" phase.

Test: storage/indexeddb/intversion-close-in-oncomplete.html

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onSuccess): Move success to error morphing from here...
(WebCore::IDBOpenDBRequest::dispatchEvent): To here.

  • Modules/indexeddb/IDBOpenDBRequest.h:

(IDBOpenDBRequest):

LayoutTests:

Updated test expectation - error, not success.

  • storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
  • storage/indexeddb/resources/intversion-close-in-oncomplete.js:

(deleteSuccess):
(upgradeNeeded.transaction.oncomplete):
(upgradeNeeded):
(openError):

4:35 PM Changeset in webkit [131667] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Build fix after r131651.

  • fast/harness/perftests/runs-per-second-iterations.html:
  • fast/harness/perftests/runs-per-second-log.html:
4:35 PM Changeset in webkit [131666] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Use virtual dispatch to create ContentData renderers
https://bugs.webkit.org/show_bug.cgi?id=99646

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-17
Reviewed by Eric Seidel.

ContentData are conceptually very similar to Nodes and we can use
the same createRenderer pattern on them to simplify creating
renderers for generated content. Now each ContentData class knows
how to create its own renderer.

Previously we switched over the StyleContentType which required a
case for CONTENT_NONE and made the code look like it could return
null, but this case is actually impossible because no ContentData
class ever has a type of CONTENT_NONE and no null checks are really
needed.

This is the final step in removing dependence on StyleContentType.

No new tests needed, this is just a refactor.

  • rendering/RenderObjectChildList.cpp: Remove createRendererForBeforeAfterContent.

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/style/ContentData.cpp:

(WebCore::ImageContentData::createRenderer):
(WebCore):
(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):

  • rendering/style/ContentData.h: Added a new virtual method createRenderer.

(WebCore):
(ContentData):
(ImageContentData):
(TextContentData):
(CounterContentData):
(QuoteContentData):

4:33 PM Changeset in webkit [131665] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderLayer subtrees without any self-painting layer shouldn't be walked during hit testing
https://bugs.webkit.org/show_bug.cgi?id=89393

Reviewed by Eric Seidel.

Performance optimization, covered by existing tests.

Bug 88888 added an peformance optimization for painting. As hit testing is very similar to
painting, it would benefit from the same optimization.

On http://dglazkov.github.com/performance-tests/biggrid.html, with a 10,000 * 100 tables,
it reduces the time to select some text inside a cell from 1-2 seconds to a usable time
(I didn't measure the exact timing).

Note that as in bug 88888, the multi-column code is not covered by this optimization.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):
This is the entrance to the hit testing code so we check if we can bail out early.

(WebCore::RenderLayer::hitTestList):
If we have no self-painting descendant layers, we can bail out.

(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestLayer):
hitTest should filter the layers that call these functions. Added some ASSERT to
make sure we don't mistakenly call them when could avoid it.

4:21 PM Changeset in webkit [131664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-17

  • DEPS:
4:12 PM Changeset in webkit [131663] by allan.jensen@digia.com
  • 3 edits
    2 adds in trunk

[Qt] Certain SVG content freezes QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=97258

Reviewed by Simon Hausmann.

Source/WebCore:

Ensure dashpattern is well-formed by avoiding divisions by zero.

Test: svg/stroke/zero-width-hang.html

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setLineDash):

LayoutTests:

  • svg/stroke/zero-width-hang-expected.txt: Added.
  • svg/stroke/zero-width-hang.html: Added.
4:09 PM Changeset in webkit [131662] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

REGRESSION (r130826 or r130828): Twitter top bar is dysfunctional
https://bugs.webkit.org/show_bug.cgi?id=99577
<rdar://problem/12518883>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

It turns out that it's a good idea to maintain the invariants of your object model, such as that
elements past publicLength should have the hole value.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/dfg-array-pop-value-clearing-expected.txt: Added.
  • fast/js/dfg-array-pop-value-clearing.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-array-pop-value-clearing.js: Added.

(foo):

3:57 PM Changeset in webkit [131661] by alecflett@chromium.org
  • 24 edits in trunk/Source

IndexedDB: Explicitly send null/undefined/integers to frontend IDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=99619

Reviewed by Adam Barth.

Source/WebCore:

Rather than pass SerializedScriptValue tokens from the backend,
send explicit null, (as onSuccess(static_cast<SerializedScriptValue*>(0)))
undefined, (as onSucess()), and integers (as onSuccess(long long))

This reduces backend dependency on things that might require a JS
interpreter on the backend.

No new tests, this is a refactor and existing tests cover
correctness. Tests that might fail include:

Test: storage/indexeddb/index-count.html
Test: storage/indexeddb/objectstore-count.html
Test: storage/indexeddb/database-basics.html

  • Modules/indexeddb/IDBCallbacks.h:

(IDBCallbacks):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::advanceInternal):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::value):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

  • Modules/indexeddb/IDBIndex.cpp:
  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):

  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValue):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

Source/WebKit/chromium:

Hook up new undefined/integer-based onSuccess handlers.

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccess):
(WebKit):

  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

  • tests/IDBAbortOnCorruptTest.cpp:
  • tests/IDBDatabaseBackendTest.cpp:
3:55 PM Changeset in webkit [131660] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

Move ResourceRequest construction out of SubresourceLoader
https://bugs.webkit.org/show_bug.cgi?id=99627

Reviewed by Adam Barth.

CachedResource::load() fills out a bunch of http headers.
SubresourceLoader::create() adds a bunch more. Merge them.
Note that this merge requires a bit more care in CachedRawResource::canReuse(),
because more headers are set directly on CachedResource::m_resourceRequest, rather
than on a copy of it.

No new tests, no functionality change intended.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/cache/CachedRawResource.cpp:

(WebCore::shouldIgnoreHeaderForCacheReuse):
(WebCore):
(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::failBeforeStarting):
(WebCore):
(WebCore::CachedResource::addAdditionalRequestHeaders):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(CachedResource):

3:51 PM Changeset in webkit [131659] by andersca@apple.com
  • 13 edits in trunk

Clean up Vector.h
https://bugs.webkit.org/show_bug.cgi?id=99622

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Fix fallout from removing std::max and std::min using declarations.

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncIndexOf):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):

Source/WebCore:

Fix fallout from removing std::max and std::min using declarations.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::currentAge):

Source/WTF:

Remove unused member functions from Vector and get rid of the std::max and std::min using declarations
(as per the WebKit coding style guidelines).

  • WTF.xcodeproj/project.pbxproj:

Turns out StreamBuffer.h was never added to the Xcode project; add it. Also go ahead and sort the project file.

  • wtf/Deque.h:

(WTF::::expandCapacity):

  • wtf/StreamBuffer.h:

(WTF::StreamBuffer::append):
Add std:: prefixes to max and min.

  • wtf/Vector.h:

Remove VectorBase::bufferSlot(), VectorReverseProxy and add std:: prefixes where needed.

Tools:

Remove ReversedProxy test.

  • TestWebKitAPI/Tests/WTF/Vector.cpp:
3:48 PM Changeset in webkit [131658] by jsbell@chromium.org
  • 14 edits
    2 adds in trunk

IndexedDB: Enforce unsigned long/unsigned long long ranges
https://bugs.webkit.org/show_bug.cgi?id=99637

Reviewed by Tony Chang.

Source/WebCore:

The IndexedDB spec has [EnforceRange] specified on unsigned long and unsigned long long
arguments, which requires the implementation to throw TypeError for negative values or
values that exceed 253-1 (maximum JS number that behaves like an integer) - and 0 is
specifically forbidden by the APIs as well.

A more correct fix in the binding layer is in webkit.org/b/96798 but we can temporarily
address this in the implementation.

Also refactor to prevent IDBFactory.open(name, -1) from triggering an internal code path.

Tests: storage/indexeddb/cursor-advance.html

storage/indexeddb/intversion-bad-parameters.html
storage/indexeddb/intversion-encoding.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance): Validate argument range.

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl: Drop "unsigned" qualifier as the binding code is

not yet doing the correct validation.

  • Modules/indexeddb/IDBFactory.cpp: Refactor to prevent open(name, -1)

(WebCore):
(WebCore::IDBFactory::open): Validate the int version here, then pass to...
(WebCore::IDBFactory::openInternal): ... this method.

  • Modules/indexeddb/IDBFactory.h:

(IDBFactory):

  • Modules/indexeddb/IDBFactory.idl: Drop "unsigned" qualifier; meaningless to binding

code right now, can be re-added once webkit.org/b/96798 lands.

LayoutTests:

Additional edge case tests and updated expectations.

  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/intversion-bad-parameters-expected.txt:
  • storage/indexeddb/intversion-encoding-expected.txt:
  • storage/indexeddb/resources/cursor-advance.js:

(testBadAdvance.advanceBadly):
(testBadAdvance):

  • storage/indexeddb/resources/intversion-bad-parameters.js:

(deleteSuccess):

  • storage/indexeddb/resources/intversion-encoding.js:
3:33 PM Changeset in webkit [131657] by tony@chromium.org
  • 5 edits in trunk

fast/forms/range/input-appearance-range-rtl.html off by one pixel
https://bugs.webkit.org/show_bug.cgi?id=99625

Reviewed by Ojan Vafai.

Source/WebCore:

Previously, we would assume that a vertical slider in RTL would render identically to
a vertical slider in LTR. Due to differing thumb sizes, there is an off by one.

This worked in deprecated flexbox because it doesn't adjust for RTL when applying
box-align: center.

Tests: fast/forms/range/input-appearance-range-rtl.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout): Force LTR for flexbox layout when vertical. We have to restore the old value
just in case the user switches from vertical to horizontal.

LayoutTests:

Run test on GTK+ and Qt now that it is fixed.

  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
3:17 PM Changeset in webkit [131656] by msaboff@apple.com
  • 4 edits in trunk/Source

Creating a String from an NSString should check for all 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99392

Reviewed by Geoffrey Garen.

Source/WebCore:

Use CFStringGetBytes() to try to get Latin1 data to create an 8 bit string.

No functional change, change covered by existing tests.

  • platform/text/mac/StringMac.mm:

(WTF::String::String):

Source/WTF:

Exported the LChar* version of create().

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::create):

3:16 PM Changeset in webkit [131655] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

StringImpl::findIgnoringCase() and reverseFindIgnoringCase() don't optimally handle a mix of 8 and 16 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99224

Reviewed by Geoffrey Garen.

Added helper templated functions and all four combinations similar to find() and reverseFind().

(WTF::findIgnoringCaseInner):
(WTF::StringImpl::findIgnoringCase):
(WTF::reverseFindIgnoringCaseInner):
(WTF::StringImpl::reverseFindIgnoringCase):

3:14 PM Changeset in webkit [131654] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Memory leak in ewk_download_job_response_set()
https://bugs.webkit.org/show_bug.cgi?id=99621

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

No longer call ewk_url_response_ref() on the response
object in ewk_download_job_response_set() since it will
be ref'd when assigning to the RefPtr member already.

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(didReceiveResponse):

  • UIProcess/API/efl/ewk_download_job.cpp:

(ewk_download_job_response_set):

  • UIProcess/API/efl/ewk_download_job_private.h: Remove several unimplemented functions.
3:08 PM Changeset in webkit [131653] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Compilation warning in Ewk_View when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=99613

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in _ewk_view_smart_calculate() when
the ACCELERATED_COMPOSITING flag is not set.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

3:08 PM Changeset in webkit [131652] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

AtomicString::HashAndUTF8CharactersTranslator::equal() doesn't optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99223

Reviewed by Geoffrey Garen.

Added an 8 bit path.

  • wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::equal):

3:06 PM Changeset in webkit [131651] by rniwa@webkit.org
  • 44 edits in trunk/PerformanceTests

Rename PerfTestRunner.runPerSecond to PerfTestRunner.measureRunsPerSecond for consistency
https://bugs.webkit.org/show_bug.cgi?id=99642

Reviewed by Dirk Pranke.

Renamed the method.

  • Bindings/append-child.html:
  • Bindings/create-element.html:
  • Bindings/event-target-wrapper.html:
  • Bindings/first-child.html:
  • Bindings/get-attribute.html:
  • Bindings/get-element-by-id.html:
  • Bindings/get-elements-by-tag-name.html:
  • Bindings/id-getter.html:
  • Bindings/id-setter.html:
  • Bindings/insert-before.html:
  • Bindings/node-list-access.html:
  • Bindings/scroll-top.html:
  • Bindings/set-attribute.html:
  • Bindings/typed-array-construct-from-array.html:
  • Bindings/typed-array-construct-from-same-type.html:
  • Bindings/typed-array-construct-from-typed.html:
  • Bindings/typed-array-set-from-typed.html:
  • Bindings/undefined-first-child.html:
  • Bindings/undefined-get-element-by-id.html:
  • Bindings/undefined-id-getter.html:
  • CSS/CSSPropertySetterGetter.html:
  • CSS/CSSPropertyUpdateValue.html:
  • CSS/PseudoClassSelectors.html:
  • DOM/textarea-dom.html:
  • DOM/textarea-edit.html:
  • Interactive/resources/window-resize.js:
  • Layout/flexbox-column-nowrap.html:
  • Layout/flexbox-column-wrap.html:
  • Layout/flexbox-row-nowrap.html:
  • Layout/flexbox-row-wrap.html:
  • Layout/line-layout.html:
  • Parser/css-parser-yui.html:
  • Parser/innerHTML-setter.html:
  • Parser/query-selector-deep.html:
  • Parser/query-selector-first.html:
  • Parser/query-selector-last.html:
  • Parser/simple-url.html:
  • Parser/textarea-parsing.html:
  • Parser/tiny-innerHTML.html:
  • Parser/url-parser.html:
  • Parser/xml-parser.html:
  • SVG/SvgNestedUse.html:
  • resources/runner.js:
3:04 PM Changeset in webkit [131650] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use smart pointers inside Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=99611

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Use smart pointers instead of raw ones for several
Ewk_View members to avoid handling memory manually.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_cursor_set):
(ewk_view_color_picker_dismiss):
(ewk_view_color_picker_color_set):

2:57 PM Changeset in webkit [131649] by oliver@apple.com
  • 1 edit
    1 add in trunk/Source/JavaScriptCore

Committing new files is so overrated.

2:54 PM Changeset in webkit [131648] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

StringPrototype::jsSpliceSubstringsWithSeparators() doesn't optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=99230

Reviewed by Geoffrey Garen.

Added code to select characters8() or characters16() on the not all 8 bit path for both the
processing of the source and the separators.

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):

2:49 PM Changeset in webkit [131647] by tony@chromium.org
  • 9 edits
    2 adds
    4 deletes in trunk/LayoutTests

Unreviewed, Qt baselines for shadow DOM changes to RenderSlider.
There are a couple unexplained failures that I'm still investigating.

  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/range/slider-padding-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.txt: Removed.
  • platform/qt/TestExpectations:
  • platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/qt/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/range/input-appearance-range-expected.txt:
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/forms/range/slider-padding-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/qt/fast/repaint/slider-thumb-float-expected.txt: Added.
2:48 PM Changeset in webkit [131646] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array and object allocations via 'new Object' or 'new Array' should be inlined in bytecode to allow allocation site profiling
https://bugs.webkit.org/show_bug.cgi?id=99557

Reviewed by Geoffrey Garen.

Removed an inaccurate and misleading comment as per Geoff's review. (I forgot
to make this change as part of http://trac.webkit.org/changeset/131644).

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):

2:42 PM Changeset in webkit [131645] by oliver@apple.com
  • 49 edits
    1 delete in trunk/Source/JavaScriptCore

Bytecode should not have responsibility for determining how to perform non-local resolves
https://bugs.webkit.org/show_bug.cgi?id=99349

Reviewed by Gavin Barraclough.

This patch removes lexical analysis from the bytecode generation. This allows
us to delay lookup of a non-local variables until the lookup is actually necessary,
and simplifies a lot of the resolve logic in BytecodeGenerator.

Once a lookup is performed we cache the lookup information in a set of out-of-line
buffers in CodeBlock. This allows subsequent lookups to avoid unnecessary hashing,
etc, and allows the respective JITs to recreated optimal lookup code.

This is currently still a performance regression in LLInt, but most of the remaining
regression is caused by a lot of indirection that I'll remove in future work, as well
as some work necessary to allow LLInt to perform in line instruction repatching.
We will also want to improve the behaviour of the baseline JIT for some of the lookup
operations, however this patch was getting quite large already so I'm landing it now
that we've reached the bar of "performance-neutral".

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitStructures):
(JSC):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addResolve):
(JSC::CodeBlock::addPutToBase):
(CodeBlock):
(JSC::CodeBlock::resolveOperations):
(JSC::CodeBlock::putToBaseOperation):
(JSC::CodeBlock::numberOfResolveOperations):
(JSC::CodeBlock::numberOfPutToBaseOperations):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::globalObjectConstant):
(JSC::CodeBlock::setGlobalObjectConstant):

  • bytecode/GlobalResolveInfo.h: Removed.
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):

  • bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

  • bytecode/ResolveOperation.h: Added. The new types and logic we use to perform the cached lookups.

(JSC):
(ResolveOperation):
(JSC::ResolveOperation::getAndReturnScopedVar):
(JSC::ResolveOperation::checkForDynamicEntriesBeforeGlobalScope):
(JSC::ResolveOperation::getAndReturnGlobalVar):
(JSC::ResolveOperation::getAndReturnGlobalProperty):
(JSC::ResolveOperation::resolveFail):
(JSC::ResolveOperation::skipTopScopeNode):
(JSC::ResolveOperation::skipScopes):
(JSC::ResolveOperation::returnGlobalObjectAsBase):
(JSC::ResolveOperation::setBaseToGlobal):
(JSC::ResolveOperation::setBaseToUndefined):
(JSC::ResolveOperation::setBaseToScope):
(JSC::ResolveOperation::returnScopeAsBase):
(JSC::PutToBaseOperation::PutToBaseOperation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::shouldAvoidResolveGlobal):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetLocalVar):
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC::BytecodeGenerator::emitPutToBase):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ResolveResult::registerResolve):
(JSC::ResolveResult::dynamicResolve):
(ResolveResult):
(JSC::ResolveResult::ResolveResult):
(JSC):
(NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::~NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::resolved):
(JSC::NonlocalResolveInfo::put):
(BytecodeGenerator):
(JSC::BytecodeGenerator::getResolveOperations):
(JSC::BytecodeGenerator::getResolveWithThisOperations):
(JSC::BytecodeGenerator::getResolveBaseOperations):
(JSC::BytecodeGenerator::getResolveBaseForPutOperations):
(JSC::BytecodeGenerator::getResolveWithBaseForPutOperations):
(JSC::BytecodeGenerator::getPutToBaseOperation):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(DFG):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileResolveOperations):
(DFG):
(JSC::DFG::canCompilePutToBaseOperation):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(ResolveOperationData):
(DFG):
(PutToBaseOperationData):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveOperationsDataIndex):
(Node):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::resolveOperations):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::putToBaseOperation):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC):
(JSC::JIT::emit_resolve_operations):
(JSC::JIT::emitSlow_link_resolve_operations):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSScope.cpp:

(JSC::LookupResult::base):
(JSC::LookupResult::value):
(JSC::LookupResult::setBase):
(JSC::LookupResult::setValue):
(LookupResult):
(JSC):
(JSC::setPutPropertyAccessOffset):
(JSC::executeResolveOperations):
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolveContainingScope):
(JSC::JSScope::resolve):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):
(JSC::JSScope::resolvePut):
(JSC::JSScope::resolveGlobal):

  • runtime/JSScope.h:

(JSScope):

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSVariableObject):

  • runtime/Structure.h:

(JSC::Structure::propertyAccessesAreCacheable):
(Structure):

2:39 PM Changeset in webkit [131644] by fpizlo@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Array and object allocations via 'new Object' or 'new Array' should be inlined in bytecode to allow allocation site profiling
https://bugs.webkit.org/show_bug.cgi?id=99557

Reviewed by Geoffrey Garen.

This uses the old jneq_ptr trick to allow for the bytecode to "see" that the
operation in question is what we almost certainly know it to be.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/SpecialPointer.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC):
(JSC::BytecodeGenerator::emitExpectedFunctionSnippet):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array_with_size):
(JSC):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):
(JSC):

  • runtime/ArrayConstructor.h:

(JSC):

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC):

2:24 PM Changeset in webkit [131643] by tony@chromium.org
  • 18 edits
    3 adds in trunk/LayoutTests

Unreviewed, Apple Mac baselines for shadow DOM changes to RenderSlider.

  • platform/mac/TestExpectations:
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/mac/fast/forms/range/slider-padding-expected.txt:
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Added.
  • platform/mac/fast/multicol/client-rects-expected.txt:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/mac/fast/repaint/slider-thumb-float-expected.txt: Added.
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt:
2:12 PM Changeset in webkit [131642] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

JIT op_get_by_pname should call cti_get_by_val_generic and not cti_get_by_val
https://bugs.webkit.org/show_bug.cgi?id=99631
<rdar://problem/12483221>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

cti_get_by_val assumes that the return address has patching metadata associated with it, which won't
be true for op_get_by_pname. cti_get_by_val_generic makes no such assumptions.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_pname):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_pname):

LayoutTests:

  • fast/js/get-by-pname-that-looks-like-a-patchable-get-by-val-expected.txt: Added.
  • fast/js/get-by-pname-that-looks-like-a-patchable-get-by-val.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/get-by-pname-that-looks-like-a-patchable-get-by-val.js: Added.

(foo):

2:10 PM Changeset in webkit [131641] by tony@chromium.org
  • 19 edits in trunk/LayoutTests

Unreviewed, second set of GTK+ baselines for shadow DOM changes to RenderSlider.

  • platform/gtk/TestExpectations:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-styling-strict-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
2:09 PM Changeset in webkit [131640] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Integer overflows/underflows in all Gamepad controller api calls.
https://bugs.webkit.org/show_bug.cgi?id=97262

Patch by Scott Graham <scottmg@chromium.org> on 2012-10-17
Reviewed by Abhishek Arya.

Tools:

Range check controller inputs. This code is not exposed to the web,
but makes fuzzers try less hard to break uninteresting code.

  • DumpRenderTree/chromium/TestRunner/GamepadController.cpp:

(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

LayoutTests:

  • gamepad/gamepad-out-of-range-crasher.html: Added.
  • gamepad/gamepad-out-of-range-crasher-expected.txt: Added.
2:01 PM Changeset in webkit [131639] by tony@chromium.org
  • 51 edits
    10 copies
    1 move
    8 adds
    3 deletes in trunk/LayoutTests

Unreviewed, Chromium baselines for shadow DOM changes to RenderSlider.

  • platform/chromium-linux-x86/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-mac-snowleopard/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
  • platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium-mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Added.
  • platform/chromium-mac/fast/forms/range/slider-padding-expected.txt: Added.
  • platform/chromium-mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
  • platform/chromium-mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/fast/multicol/client-rects-expected.txt:
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt.
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-styling-strict-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt.
  • platform/chromium-win-xp/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
  • platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-win-xp/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt.
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
  • platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/mac-lion/media/audio-repaint-expected.txt: Removed.
1:57 PM Changeset in webkit [131638] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

Performance test should support asynchronous tests
https://bugs.webkit.org/show_bug.cgi?id=95668

Reviewed by Dirk Pranke.

Added PerfTestRunner.prepareToMeasureValuesAsync and PerfTestRunner.measureValueAsync,
and deployed it in Animation/balls.

  • Animation/balls.html:
  • resources/runner.js:
1:36 PM Changeset in webkit [131637] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, mark inspector/styles/styles-history.html as flaky on Linux.
https://bugs.webkit.org/show_bug.cgi?id=99519

  • platform/chromium/TestExpectations:
1:25 PM Changeset in webkit [131636] by tony@chromium.org
  • 13 edits
    1 move
    3 adds
    5 deletes in trunk/LayoutTests

Unreviewed, first set of GTK+ baselines for shadow DOM changes to RenderSlider.

  • fast/forms/range/slider-thumb-stylability-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Added.
  • platform/gtk/fast/forms/range/slider-padding-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Removed.
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-float-expected.txt: Added.
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Removed.
1:24 PM Changeset in webkit [131635] by danakj@chromium.org
  • 6 edits
    5 deletes in trunk/LayoutTests

Rebaseline some windows tests now that the bot is providing results in the right place.

Unreviewed gardening.

  • platform/chromium-win-xp/css1/basic/inheritance-expected.png: Removed.
  • platform/chromium-win-xp/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug73321-expected.png: Removed.
  • platform/chromium-win/css1/basic/inheritance-expected.png:
  • platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
1:22 PM Changeset in webkit [131634] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Remove redundant OpenGL library addition from the build system.
https://bugs.webkit.org/show_bug.cgi?id=99629

Reviewed by Rob Buis.

  • PlatformEfl.cmake: Do not add OPENGL_gl_LIBRARY to

WebCore_LIBRARIES, this is already done in CMakeLists.txt these
days.

1:21 PM Changeset in webkit [131633] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] Set WebCore_LIBRARIES earlier.
https://bugs.webkit.org/show_bug.cgi?id=99630

Reviewed by Rob Buis.

  • CMakeLists.txt: Follow the style we use in other CMakeList.txt

files and set the Foo_LIBRARIES variables before we start checking
for optional features, as they might append other libraries to the
list (it already happens with WTF_USE_3D_GRAPHICS, for example).

1:12 PM Changeset in webkit [131632] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.16

New Tag.

1:07 PM Changeset in webkit [131631] by pdr@google.com
  • 3 edits
    2 adds in trunk

Allow lazy initialization of SVG XML animated properties.
https://bugs.webkit.org/show_bug.cgi?id=84657

Reviewed by Tim Horton.

Source/WebCore:

When animating a property in the shadow tree, instance properties and tearoffs are created
but they simply reference the animated element's animating properties.

When starting an animation for the first time (see SVGAnimateElement::resetAnimatedType),
we initialize the root property and instance properties using startAnimValAnimation(...).
If an instance property is added while the root property is animating, this initialization
will not occur and we crash.

This patch updates the resetAnimValToBaseVal codepath to start (and initialize) an animated
property if it is not already animating. After this patch, instance properties can be added
in the middle of animation and they will be properly started/initialized.

Test: svg/animations/use-while-animating-crash.html

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::executeAction):

LayoutTests:

  • platform/mac/svg/animations/use-while-animating-crash-expected.txt: Added.
  • svg/animations/use-while-animating-crash.html: Added.
12:52 PM MathML edited by Dave Barton
(diff)
12:47 PM Changeset in webkit [131630] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Unreviewed watchlist email change.

  • Scripts/webkitpy/common/config/watchlist:
12:47 PM MathML Status edited by Dave Barton
(diff)
12:37 PM MathML edited by Dave Barton
(diff)
12:34 PM Changeset in webkit [131629] by commit-queue@webkit.org
  • 12 edits in trunk

Bind isolatedWorldSecurityOrigin to world
https://bugs.webkit.org/show_bug.cgi?id=99582

Patch by Dan Carney <dcarney@google.com> on 2012-10-17
Reviewed by Adam Barth.

Source/WebCore:

Security origin of isolated worlds was not previously set at the world
level, although it could have been.

No new tests. No change in functionality.

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::deallocate):
(WebCore):
(WebCore::isolatedWorldSecurityOrigins):
(WebCore::DOMWrapperWorld::isolatedWorldSecurityOrigin):
(WebCore::DOMWrapperWorld::setIsolatedWorldSecurityOrigin):
(WebCore::DOMWrapperWorld::clearIsolatedWorldSecurityOrigin):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isIsolatedWorldId):
(WebCore::DOMWrapperWorld::isIsolatedWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

Tools:

Added ability to unset isolatedWorldSecurityOrigin.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::setIsolatedWorldSecurityOrigin):

LayoutTests:

Clean up of isolated worlds added after test completion.

  • http/tests/security/isolatedWorld/cross-origin-xhr.html:
12:02 PM Changeset in webkit [131628] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

[Mac] Uninitialized Members in WebDataSourcePrivate
https://bugs.webkit.org/show_bug.cgi?id=99617

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-10-17
Reviewed by David Kilzer.

Initialize BOOL member variables.

  • WebView/WebDataSource.mm:

(WebDataSourcePrivate::WebDataSourcePrivate):

11:56 AM Changeset in webkit [131627] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Unreviewed watchlist addition.

  • Scripts/webkitpy/common/config/watchlist:
11:20 AM Changeset in webkit [131626] by Simon Fraser
  • 8 edits
    4 adds in trunk

GraphicsLayer visible rect computation needs to use the current animating transform
https://bugs.webkit.org/show_bug.cgi?id=99529

Reviewed by Dean Jackson.

Source/WebCore:

If we're running an accelerated animation of transform
on a GraphicsLayerCA, the current value of the transform won't
be reflected in the GraphicsLayer's m_transform. However,
we need the current value of the transform in order to correctly
compute the visible rect of this layer and descendants.

Add a function to GraphicsLayerClient to retrieve the current
value of the transform from the client.

RenderLayer's currentTransform() used to return a transform
with transform-origin baked in; GraphicsLayerClient needs one
that excludes transform-origin, so enhance RenderLayer::currentTransform()
to be able to produce either.

Tests: compositing/visible-rect/animated-from-none.html

compositing/visible-rect/animated.html

  • platform/graphics/GraphicsLayerClient.h:

(WebCore):
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::getCurrentTransform):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::currentTransform):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::currentTransform):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

LayoutTests:

Tests that exercise visible-rect computation on an animating layer.

  • compositing/visible-rect/animated-expected.txt: Added.
  • compositing/visible-rect/animated-from-none-expected.txt: Added.
  • compositing/visible-rect/animated-from-none.html: Added.
  • compositing/visible-rect/animated.html: Added.
11:18 AM Changeset in webkit [131625] by commit-queue@webkit.org
  • 15 edits in trunk

plugins: Allow a plugin to dictate whether it can receive drag events or not.
https://bugs.webkit.org/show_bug.cgi?id=99355

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-17
Reviewed by Tony Chang.

Source/WebCore:

When doing a drag over a plugin, ask the plugin whether it can accept
drag/drop to decide whether drag/drop is possible or not. At present,
plugins do not receive drag events through WebCore (i.e. various
implementations of PluginView::handleMouseEvent ignores the
drop-events). This change makes it possible for the ports to ask the
plugin first to decide whether it can (or wants to) accept drag events.
The default implementation remains the same, i.e. plugins do not receive
drag events. For chromium, the overridden implementation uses the
WebPlugin interface to check whether the plugin can accept drag events.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::canProcessDrag):
(WebCore):

  • html/HTMLPlugInElement.h:

(WebCore):
(HTMLPlugInElement):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

  • plugins/PluginViewBase.h:

(WebCore):
(WebCore::PluginViewBase::canProcessDrag):

Source/WebKit/chromium:

Introduce WebPlugin::canProcessDrag() and use that to implement PluginViewBase::canProcessDrag.

  • public/WebPlugin.h:

(WebKit::WebPlugin::canProcessDrag):
(WebPlugin):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::canProcessDrag):
(WebKit):
(WebKit::WebPluginContainerImpl::handleMouseEvent):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

Tools:

Update the TestWebPlugin to implement the new |canProcessDrag| interface.

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin::canProcessDrag):

LayoutTests:

Update test to not set contentEditable on the plugin anymore.

  • platform/chromium/plugins/drag-events-expected.txt:
  • platform/chromium/plugins/drag-events.html:
11:09 AM Changeset in webkit [131624] by dmazzoni@google.com
  • 3 edits in trunk/Tools

Unreviewed. Create an accessibility watchlist.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
11:00 AM Changeset in webkit [131623] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Always use fastRealloc when growing or shrinking the Vector buffer
https://bugs.webkit.org/show_bug.cgi?id=99616

Reviewed by Andreas Kling.

Remove the pointless #if PLATFORM(BLACKBERRY) and always try to use fastRealloc to grow or shrink the
vector buffer when possible; realloc should always be at least as fast as free+malloc.

  • wtf/Vector.h:

(WTF::VectorBufferBase::shouldReallocateBuffer):

10:55 AM Changeset in webkit [131622] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent focus zoom on non-userscalable pages.
https://bugs.webkit.org/show_bug.cgi?id=99608

Reviewed by Rob Buis.

PR 222378.

Disable focus zoom when the page is non-user scalable.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

10:50 AM Changeset in webkit [131621] by jianli@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove legacy members from WebDraggableRegion
https://bugs.webkit.org/show_bug.cgi?id=99612

Reviewed by Adam Barth.

Those legacy members to support old syntax are not longer needed after
chromium side changes landed.

  • public/WebDraggableRegion.h:

(WebDraggableRegion):

10:46 AM Changeset in webkit [131620] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink EventTargetData by making firingEventListeners vector optional.
<http://webkit.org/b/99532>
<rdar://problem/12515099>

Reviewed by Anders Carlsson.

The majority of event listeners never actually fire, and EventTargetData::firingEventListeners
is just sitting there taking up space. Make it an OwnPtr instead, shrinking EventTargetData
by 48 bytes and progressing Membuster3 by 395kB.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

  • dom/EventTarget.h:

(WebCore::EventTarget::isFiringEventListeners):

10:30 AM Changeset in webkit [131619] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Block freeing thread should sleep indefinitely when there's no work to do
https://bugs.webkit.org/show_bug.cgi?id=98084

Reviewed by Geoffrey Garen.

r130212 didn't fully fix the problem.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::blockFreeingThreadMain): We would just continue to the next iteration if
we found that we had zero blocks to copy. We should move the indefinite wait up to where that
check is done so that we properly detect the "no more blocks to copy, wait for more" condition.

10:17 AM Changeset in webkit [131618] by commit-queue@webkit.org
  • 4 edits in trunk

xss-DENIED-xsl-document-securityOrigin.xml crashes with icon assertion
https://bugs.webkit.org/show_bug.cgi?id=99571

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Check that the iconURL is not empty in IconController::continueLoadWithDecision()
to avoid hitting assertions later when trying to commit this empty URL to the
database. IconController::url() may indeed return an empty URL but there was
no check for it.

No new tests, already covered by http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml.

  • loader/icon/IconController.cpp:

(WebCore::IconController::continueLoadWithDecision):

LayoutTests:

Unskip http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
for EFL WebKit2 now that it no longer hits an assertion in
IconDatabase.

  • platform/efl-wk2/TestExpectations:
10:15 AM Changeset in webkit [131617] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Fix build warnings : -Wunused-parameter, -Wunused-variable
https://bugs.webkit.org/show_bug.cgi?id=99539

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-17
Reviewed by Kentaro Hara.

Fix build warnings about unused parameter or unused variable when
WTF_USE_TILED_BACKING_STORE option is enabled.

Source/WebCore:

  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::canReuseWith):
(WebCore::TextureMapper::beginPainting):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::delegatedScrollRequested):

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::paintToTextureMapper):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createLayer):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::didReceiveLayerTreeCoordinatorProxyMessage):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::updateAcceleratedCompositingMode):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:

(WebKit::CoordinatedTile::paint):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::scrollNonCompositedContents):
(WebKit::LayerTreeCoordinator::notifyAnimationStarted):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentsRect):
(WebKit::LayerTreeHost::setVisibleContentsRectForLayer):

10:10 AM Changeset in webkit [131616] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB: Delete obsolete public API method
https://bugs.webkit.org/show_bug.cgi?id=99603

Reviewed by Dimitri Glazkov.

Remove a stub that was necessary while the Chromium side of webkit.org/b/99097 was landing.

  • public/WebIDBTransactionCallbacks.h:
10:07 AM Changeset in webkit [131615] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Dynamically added elements do not get re-projected.
https://bugs.webkit.org/show_bug.cgi?id=99227

Reviewed by Dimitri Glazkov.

Source/WebCore:

When distribution happens, we have to invalidate its host shadow's distribution, since the children of the host
is changed.

Test: fast/dom/shadow/content-reprojection-dynamic.html

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

LayoutTests:

  • fast/dom/shadow/content-reprojection-dynamic-expected.html: Added.
  • fast/dom/shadow/content-reprojection-dynamic.html: Added.
9:55 AM Changeset in webkit [131614] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/workers/text-encoding.html is flaky crashing on debug bots
https://bugs.webkit.org/show_bug.cgi?id=99604

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:55 AM Changeset in webkit [131613] by jochen@chromium.org
  • 2 edits in trunk/Tools

[gyp] fix bundle resources for DumpRenderTree on mac
https://bugs.webkit.org/show_bug.cgi?id=99558

Reviewed by Adam Barth.

mac_bundle_resources doesn't propagate to targets that depend on it,
so I'm wrapping it in an all_dependent_settings block.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9:44 AM WebKit Team edited by rniwa@webkit.org
Change rniwa's affiliation from Google to Apple. (diff)
9:38 AM Changeset in webkit [131612] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: no "delete watch expression" context menu item when clicking on the expression value
https://bugs.webkit.org/show_bug.cgi?id=99602

Reviewed by Pavel Feldman.

Add delete items to the watch expression's value's context menu.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
(WebInspector.ObjectPropertyTreeElement.prototype.populateContextMenu):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionTreeElement.prototype.populateContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):

9:32 AM Changeset in webkit [131611] by vsevik@chromium.org
  • 9 edits in trunk/LayoutTests

Unreviewed inspector test fixed and skipped on JSC.

  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
9:27 AM Changeset in webkit [131610] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk/LayoutTests

[CSS Exclusions] Additional simple polygon tests
https://bugs.webkit.org/show_bug.cgi?id=98548

Patch by Hans Muller <hmuller@adobe.com> on 2012-10-17
Reviewed by Dirk Schulze.

Added a pair of CSS Exclusions shape-inside ref-tests for regular polygons
with 8 and 16 sides. Also made some small revisions to the supporting code,
simple-polyon.js, and the existing simple polygon tests, and to localize and
correct the conversion from float to layout coordinates. All of the tests
now round/truncate the left edge of line segment intervals depending on whether
subpixel layout is enabled.

  • fast/exclusions/resources/simple-polygon.js:

(createRegularPolygonVertices):
(polygonXIntercepts):
(simulatePolygonShape):
(generateSimulatedPolygonShapeInsideElement):
(createPolygonShapeInsideTestCase):
(createPolygonShapeInsideTestCaseExpected):

  • fast/exclusions/shape-inside/shape-inside-regular-polygon16-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-regular-polygon16.html: Added.
  • fast/exclusions/shape-inside/shape-inside-regular-polygon8-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-regular-polygon8.html: Added.
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html:
  • fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html:
9:09 AM Changeset in webkit [131609] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add myself to the MediaStream watchlist
https://bugs.webkit.org/show_bug.cgi?id=99589

Patch by Harald Alvestrand <hta@google.com> on 2012-10-17
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
9:00 AM Changeset in webkit [131608] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitDownload
https://bugs.webkit.org/show_bug.cgi?id=96773

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(_WebKitDownloadPrivate):
(webkitDownloadCreate):
(webkit_download_get_request):
(webkit_download_cancel):

  • UIProcess/API/gtk/WebKitDownloadPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_download_uri):
(webkitWebContextGetOrCreateDownload):

8:59 AM FeatureFlags edited by msaboff@apple.com
(diff)
8:56 AM Changeset in webkit [131607] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitCookieManager
https://bugs.webkit.org/show_bug.cgi?id=96772

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(_WebKitCookieManagerPrivate):
(webkitCookieManagerFinalize):
(webkitCookieManagerCreate):
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_set_accept_policy):
(webkit_cookie_manager_get_accept_policy):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_delete_cookies_for_domain):
(webkit_cookie_manager_delete_all_cookies):

  • UIProcess/API/gtk/WebKitCookieManagerPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_cookie_manager):

8:52 AM Changeset in webkit [131606] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitContextMenu
https://bugs.webkit.org/show_bug.cgi?id=96770

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkitContextMenuCreate):

  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(webkitContextMenuItemCreate):

  • UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
  • UIProcess/API/gtk/WebKitContextMenuPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPopulateContextMenu):

8:47 AM Changeset in webkit [131605] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=96769

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp:

(_WebKitBackForwardListPrivate):
(webkitBackForwardListGetOrCreateItem):
(webkitBackForwardListCreateList):
(webkitBackForwardListCreate):
(webkitBackForwardListChanged):
(webkit_back_forward_list_get_current_item):
(webkit_back_forward_list_get_back_item):
(webkit_back_forward_list_get_forward_item):
(webkit_back_forward_list_get_nth_item):
(webkit_back_forward_list_get_length):
(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):

  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(_WebKitBackForwardListItemPrivate):
(webkitBackForwardListItemFinalized):
(webkitBackForwardListItemGetOrCreate):
(webkitBackForwardListItemGetItem):
(webkit_back_forward_list_item_get_uri):
(webkit_back_forward_list_item_get_title):
(webkit_back_forward_list_item_get_original_uri):

  • UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(didChangeBackForwardList):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkit_web_view_go_to_back_forward_list_item):

8:38 AM Changeset in webkit [131604] by vsevik@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: [Regression] Undoing script changes does not restore breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=99598

Reviewed by Pavel Feldman.

Source/WebCore:

workingCopyChanged now dispatches did/willMergeToVM instead of did/willDivergeFromVM
when change returns uiSourceCode to non dirty state.
Added wasDirty parameter to workingCopyChanged event.

Test: inspector/debugger/live-edit-breakpoints.html

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.setWorkingCopy):

LayoutTests:

  • http/tests/inspector/live-edit-test.js:

(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest.InspectorTest.commitSource):
(initialize_LiveEditTest.InspectorTest.undoSourceEditing):
(initialize_LiveEditTest):

  • inspector/debugger/live-edit-breakpoints-expected.txt: Added.
  • inspector/debugger/live-edit-breakpoints.html: Added.
  • inspector/debugger/live-edit.html:
8:37 AM Changeset in webkit [131603] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitURISchemeRequest
https://bugs.webkit.org/show_bug.cgi?id=96787

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(didReceiveURIRequest):

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(_WebKitURISchemeRequestPrivate):
(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):

  • UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
8:36 AM Changeset in webkit [131602] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Make sure the favicon database path is set only once
https://bugs.webkit.org/show_bug.cgi?id=99597

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Make sure the icon database path is set only once by checking
that the database is not already open before settign the path.
This avoids printing error message on stderr.

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_favicon_database_get):

8:35 AM Changeset in webkit [131601] by danakj@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed rebaseline for ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001.htm

  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
8:31 AM Changeset in webkit [131600] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitWebInspector
https://bugs.webkit.org/show_bug.cgi?id=96786

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitWebInspector.cpp:

(_WebKitWebInspectorPrivate):
(webkitWebInspectorFinalize):
(webkitWebInspectorCreate):
(webkit_web_inspector_get_web_view):
(webkit_web_inspector_is_attached):
(webkit_web_inspector_attach):
(webkit_web_inspector_detach):
(webkit_web_inspector_show):
(webkit_web_inspector_close):
(webkit_web_inspector_get_attached_height):

  • UIProcess/API/gtk/WebKitWebInspectorPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_inspector):

8:30 AM Changeset in webkit [131599] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98366

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-10-17
Reviewed by Chris Fleizach.

The failure was due to platform-specific expectations of childrenCount.
The solution was conditionalizing the test.

  • accessibility/ignore-spacer-elements.html: Base expected childrenCount on platform.
  • platform/gtk/TestExpectations: Unskip previously-failing test.
8:24 AM Changeset in webkit [131598] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebKit2

[GTK] Don't use the C API internally in WebKitGeolocation classes
https://bugs.webkit.org/show_bug.cgi?id=96778

Reviewed by Gustavo Noronha Silva.

Using the C++ classes directly instead of the C API wrappers we
avoid a lot of toImpl/toAPI casts, string conversions and
allocations. The code is also a lot simpler and easier to read.

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:

(_WebKitGeolocationPermissionRequestPrivate):
(webkitGeolocationPermissionRequestAllow):
(webkitGeolocationPermissionRequestDeny):
(webkitGeolocationPermissionRequestFinalize):
(webkitGeolocationPermissionRequestCreate):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h:
  • UIProcess/API/gtk/WebKitGeolocationProvider.cpp:

(WebKitGeolocationProvider::create):
(WebKitGeolocationProvider::WebKitGeolocationProvider):
(WebKitGeolocationProvider::notifyPositionChanged):
(WebKitGeolocationProvider::notifyErrorOccurred):

  • UIProcess/API/gtk/WebKitGeolocationProvider.h:

(WebKitGeolocationProvider):

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(decidePolicyForGeolocationPermissionRequest):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):

8:07 AM Changeset in webkit [131597] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=99596

Unskip editing/inserting, editing/selection, editing/spelling and editing/style categories.
Mark missing text expectations for these.

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-10-17

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
8:01 AM Changeset in webkit [131596] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Avoid re-creating CSSGrammar.cpp with each (incremental) build

Reviewed by Tor Arne Vestbø.

The expected output is CSSGrammar.cpp and the input file used to be CSSGrammar.y,
so ${QMAKE_FILE_BASE}.cpp did the correct transformation. Recently the input has
changed to CSSGrammar.y.in, in which case the ${QMAKE_FILE_BASE} is CSSGrammar.y
unfortunately. The resulting target CSSGrammar.y.cpp will never be created and
therefore the target will always run.

  • DerivedSources.pri:
7:43 AM Changeset in webkit [131595] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed fix for ImageSourceCG.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::reportMemoryUsage):

7:36 AM Changeset in webkit [131594] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed fix for compilation on CG bots.

  • platform/graphics/cg/ImageSourceCG.cpp:
7:26 AM Changeset in webkit [131593] by loislo@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: NMI instrument ImageDecoder. It owns a buffer that could be quite big.
https://bugs.webkit.org/show_bug.cgi?id=99540

Reviewed by Yury Semikhatsky.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::reportMemoryUsage):
(WebCore):

  • platform/graphics/ImageSource.h:

(ImageSource):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(ImageDecoder):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):

7:16 AM Changeset in webkit [131592] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build on Mac OSX 10.6 and earlier.
https://bugs.webkit.org/show_bug.cgi?id=99595

Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-17
Reviewed by Simon Hausmann.

  • Target.pri:
6:19 AM EFLWebKit edited by g.czajkowski@samsung.com
(diff)
5:48 AM Changeset in webkit [131591] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: display "disconnected" message when remote debugging terminates
https://bugs.webkit.org/show_bug.cgi?id=99316

Reviewed by Yury Semikhatsky.

Otherwise, it is not clear that the front-end is no longer functional.

  • inspector/front-end/InspectorFrontendHostStub.js:

(WebInspector.RemoteDebuggingTerminatedScreen):

  • inspector/front-end/inspector.js:

(WebInspector.loaded.WebInspector.socket.onclose):
(WebInspector.loaded):

5:23 AM Changeset in webkit [131590] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WTR] InjectedBundlePage::decidePolicyForNavigationAction() should print only filename part of local URLs
https://bugs.webkit.org/show_bug.cgi?id=99581

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Now InjectedBundlePage::decidePolicyForNavigationAction() prints only filename part of local URLs (URLs where scheme
equals to 'file').

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

LayoutTests:

Unskipped fast/loader/reload-policy-delegate.html for WK2.

  • platform/wk2/TestExpectations:
5:06 AM Changeset in webkit [131589] by g.czajkowski@samsung.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

[WK2][EFL] Add unit tests for Spelling
https://bugs.webkit.org/show_bug.cgi?id=95956

Reviewed by Gyuyoung Kim.

Add the unit tests which covers API from ewk_text_checker.h
and text checker settings from ewk_settings.h

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/resources/spelling_test.html: Added.
  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp: Added.

(resetCallbacksExecutionStats):
(onTimeout):
(onSettingChange):
(onSpellDocumentTag):
(onSpellDocumentTagClose):
(onSpellingCheck):
(onWordGuesses):
(onWordLearn):
(onWordIgnore):
(TEST_F):

4:54 AM Changeset in webkit [131588] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] Favicons are incorrectly released before receiving the actual data
https://bugs.webkit.org/show_bug.cgi?id=99492

Reviewed by Carlos Garcia Campos.

Don't release the icon for a page URL in the first stage of the
asynchronous call webkit_favicon_database_get_favicon() but do it
later instead, to avoid a race condition with the initial
synchronization process the first time we request an icon which is
actually in the icon database, but has not made available yet.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(GetFaviconSurfaceAsyncData::~GetFaviconSurfaceAsyncData): Release
here the icon for the page URL if not a valid icon has been found.
(GetFaviconSurfaceAsyncData): Add a new boolean parameter to flag
when a given icon for a page URL should be released.
(getIconSurfaceSynchronously): Don't release the icon, just return 0.
(processPendingIconsForPageURL): If a valid icon is got at this
point, disable the flag shouldReleaseIconForPageURL not to release
the icon later on.
(webkit_favicon_database_get_favicon): Make sure we retain the
icon for a given page URL before trying to retrieve it from the
IconDatabase, and that we flag it to be released in case not a
valid icon has been found yet.

4:50 AM Changeset in webkit [131587] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: delete watch expression button overlaps with the expression value
https://bugs.webkit.org/show_bug.cgi?id=99569

Reviewed by Vsevolod Vlasov.

Delete watch expression button now doesn't overlap with the watch expression.

  • inspector/front-end/inspector.css:

(.properties-tree.watch-expressions > li > .value):

4:30 AM Changeset in webkit [131586] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Move handling of CSSPropertyPointerEvents from StyleResolver into StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=99536

Reviewed by Alexis Menard.

One small step towards removing the giant switch statement in StyleResolver,
this patch moves pointer event property into StyleBuilder.

Covered by fast/events/pointer-events.html and fast/events/pointer-events-2.html.

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

4:28 AM Changeset in webkit [131585] by keishi@webkit.org
  • 13 edits in trunk/Source

Localized date should be based on LDML
https://bugs.webkit.org/show_bug.cgi?id=99570

Reviewed by Kent Tamura.

Source/WebCore:

Localized date should be based on LDML to match the format inside DateTimeEditElement.

No new tests. Covered by LocaleMacTest.formatDate and LocaleWinTest.formatDate.

  • platform/text/LocaleICU.cpp: Removed formatDateTime.
  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocaleNone.cpp: Removed formatDateTime.

(LocaleNone):

  • platform/text/LocaleWin.cpp: Removed formatDateTime and formatDate.

(WebCore):

  • platform/text/LocaleWin.h:

(LocaleWin):

  • platform/text/Localizer.cpp:

(WebCore::DateTimeStringBuilder::visitField): Added support for year/month/day.
(WebCore::Localizer::formatDateTime): Creates the formatted string based on the format from dateFormat().

  • platform/text/Localizer.h:
  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm: Removed formatDateTime.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(TEST_F): Updated expectations.

  • tests/LocaleWinTest.cpp:

(TEST_F): Updated expectations.

4:15 AM Changeset in webkit [131584] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

Implement the Selector argument to RTCPeerConnection.getStats
https://bugs.webkit.org/show_bug.cgi?id=99460

Patch by Harald Alvestrand <hta@google.com> on 2012-10-17
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebRTCStatsRequest.h:

(WebKit):
(WebRTCStatsRequest):

Source/WebCore:

The change adds two new parameters to the RTCStatsRequest object:
stream and component. Together these are enough to identify a
MediaStreamTrack.

Test: fast/mediastream/RTCPeerConnection-statsSelector.html

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::streamDescriptor):
(WebCore):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):

  • Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::create):
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::hasSelector):
(WebCore):
(WebCore::RTCStatsRequestImpl::stream):
(WebCore::RTCStatsRequestImpl::component):

  • Modules/mediastream/RTCStatsRequestImpl.h:

(RTCStatsRequestImpl):

  • platform/chromium/support/WebRTCStatsRequest.cpp:

(WebKit):
(WebKit::WebRTCStatsRequest::hasSelector):
(WebKit::WebRTCStatsRequest::stream):
(WebKit::WebRTCStatsRequest::component):

  • platform/mediastream/RTCStatsRequest.h:

(WebCore):
(RTCStatsRequest):

Tools:

The MockWebRTCPeerConnectionHandler will return one object only
when it gets a selector, and an even number when there is no selector.
This allows to verify that the argument is passed, but not its value.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-statsSelector.html: Added.
4:07 AM Changeset in webkit [131583] by commit-queue@webkit.org
  • 12 edits in trunk

WebKitTestRunner needs layoutTestController.queueReload
https://bugs.webkit.org/show_bug.cgi?id=42672

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added implementation of testRunner.queueReload().

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::queueReload):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueReload):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/WorkQueueManager.cpp:

(WTR::WorkQueueManager::queueReload):
(WTR):

  • WebKitTestRunner/WorkQueueManager.h:

(WorkQueueManager):

LayoutTests:

Unskipped the related test cases for WK2.

  • platform/efl-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
3:46 AM Changeset in webkit [131582] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Qt] Enable use of more AllInOne files
https://bugs.webkit.org/show_bug.cgi?id=99579

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-17
Reviewed by Tor Arne Vestbø.

The AllInOne files reduce pressure during final link time because the object files contain less duplicated
symbols.

  • Target.pri: Add HTMLElementsAllInOne, EditingAllInOne and RenderingAllInOne to the build
  • editing/EditingAllInOne.cpp: Place a #if USE(CF) around the inclusion of SmartReplaceCF.cpp
  • html/HTMLElementsAllInOne.cpp: Move HTMLPlugInElement.cpp to the top to fix builds on X11 based platforms

where the X headers get confused by the "Region" type that's also declared in WebCore.

  • rendering/RenderingAllInOne.cpp: Fix build on case-sensitive file systems (Plugin -> PlugIn) and added a

#if PLATFORM(WIN) around the inclusion of RenderThemeWin.cpp.

3:40 AM Changeset in webkit [131581] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION(r131421): Text baseline becomes incorrect after re-layout of input[type=time]
https://bugs.webkit.org/show_bug.cgi?id=99572

Reviewed by Kentaro Hara.

Source/WebCore:

We use flexible box since r131421, and it seems text baseline becomes
incorrect if there are text nodes in a flex container.

Test: fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html

  • css/html.css:

(input::-webkit-datetime-edit-text): Added.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
Wrap text with an element with ::-webkit-datetime-edit-text.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-static-relayout-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html: Added.
3:34 AM Changeset in webkit [131580] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing expectation for fast/forms/range/input-appearance-range-rtl.html,
it's a reftest so the failure is actually of pixel nature.

Also removing some expectations for tests that now consistently pass.

  • platform/gtk/TestExpectations:
3:30 AM Changeset in webkit [131579] by commit-queue@webkit.org
  • 13 edits
    6 adds in trunk

.: [WK2][EFL] Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com>, Michal Roj <m.roj@sasmung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Define SPELLCHECK macro and enable it for WK2-Efl.
The spellchecking implementation is based on the Enchant library.
It can be used by other WebKit ports.

  • Source/cmake/FindEnchant.cmake: Added.
  • Source/cmake/OptionsEfl.cmake: Enable spellchecking feature for WebKit2-EFL.
  • Source/cmake/WebKitFeatures.cmake: Define the SPELLCHECK macro.
  • Source/cmakeconfig.h.cmake: Add the feature.

Source/WebCore: [WK2][EFL] Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com>, Michal Roj <m.roj@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

  • PlatformEfl.cmake:

Add enchant-related compiler flags: header paths and the library flag.

Source/WebKit2: Implementation of spellchecking feature.
https://bugs.webkit.org/show_bug.cgi?id=91854

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com>, Michal Roj <m.roj@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Add spelling implementation for WebKit2-EFL that is based on Enchant library.

Additionally the patch provides API to overwrite the default WebKit
spellchecker implementation as Enchant library doesn't ensure grammar checking.
Application is able to overwrite it by defining its own implementation and
setting appropriate callback functions.

  • PlatformEfl.cmake:

Add enchant-related compiler flags: header paths and the library flag.

  • UIProcess/API/efl/EWebKit2.h:

Add ewk_text_checker.h to the main WebKit2-EFL's header to be available for applications.

  • UIProcess/API/efl/WebKitTextChecker.cpp: Added.

Implement the callbacks functions of WKTextChecker.

(WebKit):
(WebKit::isContinuousSpellCheckingEnabled):
(WebKit::setContinuousSpellCheckingEnabled):
(WebKit::uniqueSpellDocumentTag):
(WebKit::closeSpellDocumentWithTag):
(WebKit::checkSpellingOfString):
(WebKit::guessesForWord):
(WebKit::learnWord):
(WebKit::ignoreWord):
Those functions are directly given as callback functions for WKTextChecker's client.
They choose between WebKit's spelling implementation and client's ones.

(WebKit::availableSpellCheckingLanguages):
(WebKit::updateSpellCheckingLanguages):
(WebKit::loadedSpellCheckingLanguages):
They are used by ewk_settings.cpp file and allow to do not
expose 'textCheckerEnchant'.

  • UIProcess/API/efl/WebKitTextChecker.h: Added.

Define the functions which choose between WebKit's spelling implementation and
the client's ones.

(WebKit):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context::_Ewk_Context):
Attach the spellchecker feature for the context.

  • UIProcess/API/efl/ewk_text_checker.cpp: Added.

(ewk_text_checker_callbacks_get):
An internal function to get the client's callback functions.

  • UIProcess/API/efl/ewk_text_checker.h: Added.

Define API to set the client's own spelling implementation.

  • UIProcess/API/efl/ewk_text_checker_private.h: Added.

(_Ewk_Text_Checker):
Define the struct with the client's callbacks responisble for spelling.

  • UIProcess/API/efl/ewk_settings.cpp:

(onContinuousSpellCheckingIdler):
The application is notified about the spelling setting change on idler
to do not block WebKit.
The the continuous spell checking may be changed through the context menu option.

(spellCheckingLanguagesSetUpdate):
The dictionaries are requested on 'idler' to do not block WebKit.

(spellCheckingLanguagesSet):
Set the languages.

(ewk_settings_continuous_spell_checking_change_cb_set):
Set the callback function used to notify the client when the spelling
setting was changed by WebKit.

(ewk_settings_continuous_spell_checking_enabled_get):
(ewk_settings_continuous_spell_checking_enabled_set):
API to set/get the continuous spell checking.

(ewk_settings_spell_checking_available_languages_get):
(ewk_settings_spell_checking_languages_set):
(ewk_settings_spell_checking_languages_get):
API to get/set languages to use by WebKit implementation based on Enchant library.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::state):
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString): Remove WebCore namaspace as it's already defined for the whole file.
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
Those call WKTextChecker client's methods.

3:24 AM Changeset in webkit [131578] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Avoid style updates when retrieving the inline stylesheet text
https://bugs.webkit.org/show_bug.cgi?id=99576

Reviewed by Vsevolod Vlasov.

Avoid using innerText() to retrieve inline stylesheet text, which may result in style and layout updates.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

3:20 AM Changeset in webkit [131577] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

Build fix for WinCE after r131365.

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBufferAdvance::width):

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::cursorToX):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawText):

3:08 AM Changeset in webkit [131576] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/efl

[EFL] Add background color to the checkbox theme.
https://bugs.webkit.org/show_bug.cgi?id=98788

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Background color is added to the checkbox theme for identifying
checkbox status easily.

Checkbox theme uses images which has transparent background, and the
theme itself doesn't have the background color.

When the background of checkbox is black, checked/unchecked status
cannot be distinguished because check mark color is black.

And it is hard to identify whether the checkbox is disabled or not,
because there is no background color in the checkbox theme.

Instead of adding background color to the edc script, background
images are added because the shape of the check box can be various.

  • DefaultTheme/widget/check/check.edc:
  • DefaultTheme/widget/check/img_check_bg_enabled.png: Added.
  • DefaultTheme/widget/check/img_check_bg_disabled.png: Added.
3:08 AM Changeset in webkit [131575] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Ewk_Url_Scheme_Request has to be refactored
https://bugs.webkit.org/show_bug.cgi?id=99549

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Ewk_Url_Scheme_Requestis inherited from RefCounted, WKEinaSharedString is used,
removed weird _Ewk_Url_Scheme_Request.

  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_context_request_manager_client.cpp:

(didReceiveURIRequest):

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(ewk_url_scheme_request_ref):
(ewk_url_scheme_request_unref):

  • UIProcess/API/efl/ewk_url_scheme_request.h:
  • UIProcess/API/efl/ewk_url_scheme_request_private.h:

(Ewk_Url_Scheme_Request):
(Ewk_Url_Scheme_Request::create):
(Ewk_Url_Scheme_Request::Ewk_Url_Scheme_Request):

3:02 AM Changeset in webkit [131574] by dominik.rottsches@intel.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskipping 4 cases after regression was fixed in r131229,
moving out a crash and incorrect console loggin on the wk2 bot.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:00 AM Changeset in webkit [131573] by mkwst@chromium.org
  • 11 edits in trunk

V8 should throw a more descriptive exception when blocking 'eval' via CSP.
https://bugs.webkit.org/show_bug.cgi?id=94332

Reviewed by Adam Barth.

Source/WebCore:

Following up on https://bugs.webkit.org/show_bug.cgi?id=94331, this
patch wires up the new error message mechanism to V8, and updates the
Chromium test expectations accordingly.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::disableEval):

Pass 'errorMessage' through to V8.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

Grab the error message from ContentSecurityPolicy, and pass it
through to V8.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::setEvalAllowed):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

Convert 'm_disableEvalPending' to a string to store the current
error message, and use it to set the eval state.

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::disableEval):

Pass 'errorMessage' through to V8.

LayoutTests:

  • platform/chromium/TestExpectations:

Unskipping these tests, as this patch unbreaks them.

  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt:
  • platform/chromium/http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt:

Updating expectations with the new error message.

2:57 AM Changeset in webkit [131572] by morrita@google.com
  • 3 edits
    2 adds in trunk

Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
https://bugs.webkit.org/show_bug.cgi?id=99566

Reviewed by Kent Tamura.

Source/WebCore:

It had a too optimistic assertion. This change removes it.

Test: fast/forms/textarea/textarea-autofocus-removal-while-focusing.html

  • html/HTMLFormControlElement.cpp:

(WebCore::updateFromElementCallback):

LayoutTests:

  • fast/forms/textarea/textarea-autofocus-removal-while-focusing.txt: Added.
  • fast/forms/textarea/textarea-autofocus-removal-while-focusing.html: Added.
2:43 AM Changeset in webkit [131571] by antonm@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed Chromium rebaselines.

  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
2:42 AM Changeset in webkit [131570] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: When dirty uiSourceCode is saved to disk from scripts navigator context menu working copy is not committed.
https://bugs.webkit.org/show_bug.cgi?id=99555

Reviewed by Yury Semikhatsky.

Save As context menu handler now commits working copy for dirty UISourceCodes.

  • inspector/front-end/HandlerRegistry.js:
2:27 AM Changeset in webkit [131569] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] Unneeded GError field in internal structure in WebKitFaviconDatabase.cpp
https://bugs.webkit.org/show_bug.cgi?id=99564

Reviewed by Carlos Garcia Campos.

Removed field 'error' from GetFaviconSurfaceAsyncData and updated
the code accordingly, by using g_simple_async_result_take_error().

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(GetFaviconSurfaceAsyncData): Removed unneeded field.
(processPendingIconsForPageURL): Avoid using g_propagate_error and
use g_simple_async_result_take_error directly instead.
(webkit_favicon_database_get_favicon_finish): Remove unneeded code.

1:52 AM Changeset in webkit [131568] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Stylesheets saved with FileManager are not saved to disk when edited from Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=99554

Reviewed by Yury Semikhatsky.

Moved saving to disk from SourceFrame to UISourceCode.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._commitEditing):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype._commitContent):

1:49 AM Changeset in webkit [131567] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] SASS sources are not saved to disk.
https://bugs.webkit.org/show_bug.cgi?id=99551

Reviewed by Yury Semikhatsky.

Added resource null checks.

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):

1:18 AM Changeset in webkit [131566] by apavlov@chromium.org
  • 1 edit in branches/chromium/1229/Source/WebCore/css/CSSParser.cpp

Merge 130883 - Web Inspector: Semantically incorrect CSS rules result in broken source code data
https://bugs.webkit.org/show_bug.cgi?id=98520

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Pop and throw away rule data from the stack when data have been collected for a semantically invalid CSS rule
(which is not going to be created).

  • css/CSSParser.cpp:

(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11183028

1:18 AM Changeset in webkit [131565] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Clean up ContentData operator overloads
https://bugs.webkit.org/show_bug.cgi?id=99556

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-17
Reviewed by Eric Seidel.

Use virtual dispatch for checking ContentData equality instead
of a switch over the type. This the first step in getting rid
of the StyleContentType enum and all the switch statements over
the type().

No tests needed, this is just a refactor.

  • rendering/style/ContentData.cpp:
  • rendering/style/ContentData.h:

(ContentData):
(WebCore::operator==):
(WebCore):
(WebCore::operator!=):

1:15 AM Changeset in webkit [131564] by mrowe@apple.com
  • 5 edits in trunk

Fix the build with a newer version of clang.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

Some of the methods in WebCoreStatistics appear to have been added by someone not familiar with Objective-C.
While it's technically valid to have empty components in a selector, it's rarely done and is not consistent
with our style guidelines. In this particular case it's also done in such a manner that it's ambiguous and
therefore generates a warning in newer versions of the compiler.

Fixes <rdar://problem/12503709>.

  • Misc/WebCoreStatistics.h: Remove unused methods and rename the two poorly-named methods that remain.
  • Misc/WebCoreStatistics.mm: Ditto.

(-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
(-[WebFrame printToCGContext:pageWidth:pageHeight:]):

Tools:

Update to accommodate the renamed methods in WebCoreStatistics.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createPagedBitmapContext):

1:13 AM Changeset in webkit [131563] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed gardening. Skip failing reftest after r131497.
https://bugs.webkit.org/show_bug.cgi?id=98666

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-10-17

  • platform/qt/TestExpectations: Skip fast/forms/range/input-appearance-range-rtl.html.
1:06 AM Changeset in webkit [131562] by rgabor@webkit.org
  • 2 edits in trunk/Source/WebCore

NEON intrinsics Gauss filter does not work properly
https://bugs.webkit.org/show_bug.cgi?id=98875

Reviewed by Zoltan Herczeg.

Fixing the NEON intrinsics Gauss filter. The stride parameter
was missing from the intrinsics algorithm. Tested with pixel
checks, now it's working properly.

  • platform/graphics/filters/arm/FEGaussianBlurNEON.h:

(WebCore::boxBlurNEON):

1:00 AM Changeset in webkit [131561] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Crash on Frame::inScope() part 2
https://bugs.webkit.org/show_bug.cgi?id=99543

Reviewed by Kent Tamura.

FrameTree::scopedChildCount() can be called even when the one of child frames
is in orphan state. This change added a guard for that case.

No new tests. A hard-to-test timing issue.

  • page/Frame.cpp:

(WebCore::Frame::inScope):

12:54 AM Changeset in webkit [131560] by commit-queue@webkit.org
  • 19 edits
    2 adds in trunk

WebKitTestRunner needs testRunner.queueLoad
https://bugs.webkit.org/show_bug.cgi?id=42674

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added testRunner.queueLoad() and testRunner.queueBackNavigation() implementation to WTR including
Work Queue implementation. Work Queue is managed by WorkQueueManager which belongs to UI process
(as the needed functionality, like loading initiation, has to be invoked from UI process) and
exchanges messages with Injected bundle.

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::shouldProcessWorkQueue):
(WTR):
(WTR::InjectedBundle::processWorkQueue):
(WTR::InjectedBundle::queueBackNavigation):
(WTR::InjectedBundle::queueLoad):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::locationChangeForFrame):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::queueBackNavigation):
(WTR):
(WTR::TestRunner::queueLoad):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/Target.pri:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::workQueueManager):
(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WorkQueueManager.cpp: Added.

(WTR):
(WTR::mainPage):
(WTR::goToItemAtIndex):
(WTR::WorkQueueManager::WorkQueueManager):
(WTR::WorkQueueManager::clearWorkQueue):
(WTR::WorkQueueManager::processWorkQueue):
(WTR::WorkQueueManager::queueLoad):
(WTR::WorkQueueManager::queueBackNavigation):
(WTR::WorkQueueManager::enqueue):

  • WebKitTestRunner/WorkQueueManager.h: Added.

(WTR):
(WorkQueueManager):
(WTR::WorkQueueManager::isWorkQueueEmpty):
(WorkQueueItem):
(WTR::WorkQueueManager::WorkQueueItem::~WorkQueueItem):

  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

LayoutTests:

Unskipped corresponding tests for WK2 and WK2 EFL, put those which still failing to appropriate groups.

  • platform/efl-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
12:42 AM Changeset in webkit [131559] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove shadowAncestorNode() from VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=99544

Reviewed by Hajime Morita.

An effort to replace shadowAncestorNode() with shadowHost(), since shadowAncestorNode() is now deprecated.

No new tests, no change in behavior.

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Since shadowHost() returns 0 if
an element is not in shadowRoot, it's ok to compare shadowAncestor to 0.

12:28 AM Changeset in webkit [131558] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit2

[EFL][WK2] Start using OwnPtr for non-ref counted ewk types
https://bugs.webkit.org/show_bug.cgi?id=99472

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Use OwnPtr internally for non-ref counted Ewk types to avoid
manual memory handling.

Private _new() and _free() functions are removed since they
are not needed now that the classes are defined in the
private headers instead of the cpp files. The constructor
for those classes was made private and factory methods were
added to encourage developers to use smart pointers instead
of raw ones.

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(ewk_back_forward_list_changed):

  • UIProcess/API/efl/ewk_back_forward_list_item_private.h:
  • UIProcess/API/efl/ewk_back_forward_list_private.h:

(_Ewk_Back_Forward_List):
(_Ewk_Back_Forward_List::create):
(_Ewk_Back_Forward_List::_Ewk_Back_Forward_List):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_cookie_manager_get):
(ewk_context_favicon_database_get):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(didFail):

  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::~_Ewk_Cookie_Manager):
(getAcceptPolicyCallback):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_changes_watch):

  • UIProcess/API/efl/ewk_cookie_manager_private.h:

(Cookie_Change_Handler):
(Cookie_Change_Handler::Cookie_Change_Handler):
(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::create):

  • UIProcess/API/efl/ewk_error.cpp:

(_Ewk_Error::_Ewk_Error):
(ewk_error_cancellation_get):

  • UIProcess/API/efl/ewk_error_private.h:

(_Ewk_Error):
(_Ewk_Error::create):

  • UIProcess/API/efl/ewk_favicon_database.cpp:

(_Ewk_Favicon_Database::_Ewk_Favicon_Database):

  • UIProcess/API/efl/ewk_favicon_database_private.h:

(IconChangeCallbackData):
(IconChangeCallbackData::IconChangeCallbackData):
(IconRequestCallbackData):
(IconRequestCallbackData::IconRequestCallbackData):
(_Ewk_Favicon_Database):
(_Ewk_Favicon_Database::create):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(_Ewk_Popup_Menu_Item::_Ewk_Popup_Menu_Item):

  • UIProcess/API/efl/ewk_popup_menu_item_private.h:

(_Ewk_Popup_Menu_Item):
(_Ewk_Popup_Menu_Item::create):

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(_Ewk_Url_Scheme_Request::_Ewk_Url_Scheme_Request):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_back_forward_list_get):
(ewk_view_popup_menu_request):
(ewk_view_popup_menu_close):

  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didFailLoadWithErrorForFrame):
(didFailProvisionalLoadWithErrorForFrame):

  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didFailLoadForResource):

12:16 AM Changeset in webkit [131557] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Content of replaced elements should be trimmed to the content edge curve.
https://bugs.webkit.org/show_bug.cgi?id=63899

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-17
Reviewed by Simon Fraser.

Source/WebCore:

When a border-radius is specified the content of replaced elements needs to be clipped to avoid
being painted over the padding or border in the corners. Previously the clip that was applied
was set to the border-edge curve, this patch contracts the clip by the size of the border and
padding (the content-edge curve) to match the css3 spec.
Spec: http://www.w3.org/TR/css3-background/#corner-clipping

Test: fast/replaced/border-radius-clip-content-edge.html

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

LayoutTests:

  • fast/replaced/border-radius-clip-content-edge-expected.txt: Added.
  • fast/replaced/border-radius-clip-content-edge.html: Added.
  • platform/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
12:10 AM Changeset in webkit [131556] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Use WTF RefCounted and RefPtr for Ewk_Resource and Ewk_Form_Submission_Request
https://bugs.webkit.org/show_bug.cgi?id=99542

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-17
Reviewed by Kenneth Rohde Christiansen.

Use WTF RefCounted and RefPtr for Ewk_Resource and Ewk_Form_Submission_Request
to avoid handling raw pointers internally.

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(ewk_form_submission_request_ref):
(ewk_form_submission_request_unref):
(ewk_form_submission_request_submit):

  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::~_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::create):
(_Ewk_Form_Submission_Request::_Ewk_Form_Submission_Request):

  • UIProcess/API/efl/ewk_resource.cpp:

(ewk_resource_ref):
(ewk_resource_unref):

  • UIProcess/API/efl/ewk_resource_private.h:

(_Ewk_Resource):
(_Ewk_Resource::create):
(_Ewk_Resource::_Ewk_Resource):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(ewk_view_resource_load_initiated):
(ewk_view_resource_load_response):
(ewk_view_resource_load_failed):
(ewk_view_resource_load_finished):
(ewk_view_resource_request_sent):
(ewk_view_load_provisional_started):

  • UIProcess/API/efl/ewk_view_form_client.cpp:

(willSubmitForm):

  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didInitiateLoadForResource):

12:06 AM Changeset in webkit [131555] by commit-queue@webkit.org
  • 5 edits in trunk

The HTML5 formtarget/formaction/formenctyp/formmethod/formnovalidate attributes don't work in button tags with nested elements
https://bugs.webkit.org/show_bug.cgi?id=90539

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-17
Reviewed by Kent Tamura.

Source/WebCore:

Fix a bug where form(action|enctype|method|target) attributes of <button> are not
honored if the target of the click event is an element nested within the button.

Test: fast/forms/formaction-attribute.html

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create): Looks for the attributes for form submission
from the nearest FormControlElement ancestor of the event target.

LayoutTests:

Added a test case to verify that formaction attribute of <button> element is
used when its child <span> is clicked.

  • fast/forms/formaction-attribute-expected.txt:
  • fast/forms/formaction-attribute.html: Removed unused doneAction2 variable.
12:05 AM Changeset in webkit [131554] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/efl

[EFL] Add background color to the radio button theme.
https://bugs.webkit.org/show_bug.cgi?id=98852

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-17
Reviewed by Gyuyoung Kim.

Background color is added to the radio button theme for identifying
radio button status easily.

Radio button theme uses images which has transparent background.

When the background of radio button is black, checked/unchecked status
cannot be distinguished because check mark color is black.

And it is hard to identify whether the radio button is disabled or not,
because there is no background color in the radio button theme.

  • DefaultTheme/widget/radio/img_radio_bg_disabled.png: Added.
  • DefaultTheme/widget/radio/img_radio_bg_enabled.png: Added.
  • DefaultTheme/widget/radio/radio.edc:

Oct 16, 2012:

11:50 PM Changeset in webkit [131553] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests

html5-full-render.html test uses substring but meant substr
https://bugs.webkit.org/show_bug.cgi?id=99495

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-16
Reviewed by Adam Barth.

This test intended to chunk up the HTML5 spec into chunks of 500k chars, but used
substring(to,from) instead of substr(from,length) so it actually loaded 5x more
content than was in the HTML5 spec.

  • Parser/html5-full-render.html:
11:22 PM Changeset in webkit [131552] by Csaba Osztrogonác
  • 52 edits
    1 copy
    1 delete in trunk

Unreviewed, rolling out r131516 and r131550.
http://trac.webkit.org/changeset/131516
http://trac.webkit.org/changeset/131550
https://bugs.webkit.org/show_bug.cgi?id=99349

It caused zillion different problem on different platforms

Source/JavaScriptCore:

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::isGlobalResolve):
(JSC::instructionOffsetForNth):
(JSC::printGlobalResolveInfo):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitStructures):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
(JSC::CodeBlock::globalResolveInfoForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::globalResolveInfo):
(JSC::CodeBlock::numberOfGlobalResolveInfos):
(JSC::CodeBlock::globalResolveInfoCount):

  • bytecode/GlobalResolveInfo.h: Copied from Source/JavaScriptCore/bytecode/ResolveGlobalStatus.cpp.

(JSC):
(JSC::GlobalResolveInfo::GlobalResolveInfo):
(GlobalResolveInfo):
(JSC::getGlobalResolveInfoBytecodeOffset):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC):
(JSC::computeForStructure):
(JSC::computeForLLInt):
(JSC::ResolveGlobalStatus::computeFor):

  • bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

  • bytecode/ResolveOperation.h: Removed.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC::ResolveResult::registerPointer):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::shouldAvoidResolveGlobal):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ResolveResult::registerResolve):
(JSC::ResolveResult::dynamicResolve):
(JSC::ResolveResult::lexicalResolve):
(JSC::ResolveResult::indexedGlobalResolve):
(JSC::ResolveResult::dynamicIndexedGlobalResolve):
(JSC::ResolveResult::globalResolve):
(JSC::ResolveResult::dynamicGlobalResolve):
(JSC::ResolveResult::type):
(JSC::ResolveResult::index):
(JSC::ResolveResult::depth):
(JSC::ResolveResult::globalObject):
(ResolveResult):
(JSC::ResolveResult::isStatic):
(JSC::ResolveResult::isIndexed):
(JSC::ResolveResult::isScoped):
(JSC::ResolveResult::isGlobal):
(JSC::ResolveResult::ResolveResult):
(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(DFG):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:

(JSC):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):
(JSC::JIT::emit_op_get_global_var_watchable):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve):
(JSC):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emit_op_resolve_global_dynamic):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve):
(JSC):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):
(JSC):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_put_global_var_check):
(JSC::JIT::emitSlow_op_put_global_var_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_scoped_var):
(JSC):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_put_global_var_check):
(JSC::JIT::emitSlow_op_put_global_var_check):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSScope.cpp:

(JSC::JSScope::resolve):
(JSC::JSScope::resolveSkip):
(JSC::JSScope::resolveGlobal):
(JSC::JSScope::resolveGlobalDynamic):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):

  • runtime/JSScope.h:

(JSScope):

  • runtime/JSVariableObject.cpp:
  • runtime/JSVariableObject.h:
  • runtime/Structure.h:

LayoutTests:

  • fast/workers/resources/worker-event-listener.js:
10:56 PM Changeset in webkit [131551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[mac] Fix build break - processPath should be initialized.
https://bugs.webkit.org/show_bug.cgi?id=99541

Unreviewed build fix.

Initialize processPath as nil.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-16

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::createProcess):

10:44 PM Changeset in webkit [131550] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[GTK] Fix build break - ResolveOperations.h is not in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=99538

Unreviewed build fix.

There are some files including ResolveOperations.h which is not exist at all.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-16

  • GNUmakefile.list.am: s/ResolveOperations.h/ResolveOperation.h/
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: s/ResolveOperations.h/ResolveOperation.h/
10:39 PM Changeset in webkit [131549] by morrita@google.com
  • 11 edits in trunk/Source

[Shadow DOM][V8] WebCore::V8DOMWindow::installPerContextProperties() is slow when shadowDOMEnabled flag is on.
https://bugs.webkit.org/show_bug.cgi?id=99428

Reviewed by Adam Barth.

Source/WebCore:

A benchmark unveiled that installPerContextProperties() could have made DOMWindow setup slower when

  • Some properties are added per-context basis by turnin the flag on and
  • There are bunch of DOMWindow object in the page (that is, there are many iframes.)

This change eliminates Shadow DOM related per-context properties from DOMWindow for getting rid of that slowness.

  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h: Removed shadowDOMEnabled() method and related enum entry.
  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • dom/make_names.pl: Re-introduced "runtimeConditional" directive.

(defaultTagPropertyHash):
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

7:48 PM Changeset in webkit [131548] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

7:33 PM Changeset in webkit [131547] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.15

New Tag.

7:20 PM Changeset in webkit [131546] by commit-queue@webkit.org
  • 25 edits in trunk/Source/WebKit2

[EFL][WK2] Add factory methods for refcounted Ewk types
https://bugs.webkit.org/show_bug.cgi?id=99479

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-16
Reviewed by Gyuyoung Kim.

Add factory methods to refcounted Ewk types that return
a PassRefPtr for refcounted Ewk types. Their constructors
were made privates as well, in order to promote the use
of smart pointers internally.

Remove _new() functions for refcounted Ewk types as they
are no longer needed now that the classes are defined
in the private headers instead of the cpp files.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(addItemToWrapperCache):

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(ewk_back_forward_list_item_original_url_get):

  • UIProcess/API/efl/ewk_back_forward_list_item_private.h:

(_Ewk_Back_Forward_List_Item):
(_Ewk_Back_Forward_List_Item::create):
(_Ewk_Back_Forward_List_Item::_Ewk_Back_Forward_List_Item):

  • UIProcess/API/efl/ewk_context_download_client.cpp:

(didReceiveResponse):

  • UIProcess/API/efl/ewk_context_history_client.cpp:

(didNavigateWithNavigationData):

  • UIProcess/API/efl/ewk_download_job.cpp:

(ewk_download_job_request_get):
(ewk_download_job_state_set):

  • UIProcess/API/efl/ewk_download_job_private.h:

(_Ewk_Download_Job):
(_Ewk_Download_Job::create):
(_Ewk_Download_Job::_Ewk_Download_Job):

  • UIProcess/API/efl/ewk_intent.cpp:

(ewk_intent_extra_names_get):

  • UIProcess/API/efl/ewk_intent_private.h:

(_Ewk_Intent):
(_Ewk_Intent::create):
(_Ewk_Intent::_Ewk_Intent):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(ewk_intent_service_disposition_get):

  • UIProcess/API/efl/ewk_intent_service_private.h:

(_Ewk_Intent_Service):
(_Ewk_Intent_Service::create):
(_Ewk_Intent_Service::_Ewk_Intent_Service):

  • UIProcess/API/efl/ewk_navigation_data.cpp:

(ewk_navigation_data_url_get):

  • UIProcess/API/efl/ewk_navigation_data_private.h:

(_Ewk_Navigation_Data):
(_Ewk_Navigation_Data::create):
(_Ewk_Navigation_Data::_Ewk_Navigation_Data):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::create):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):

  • UIProcess/API/efl/ewk_url_request.cpp:

(ewk_url_request_http_method_get):

  • UIProcess/API/efl/ewk_url_request_private.h:

(_Ewk_Url_Request):
(_Ewk_Url_Request::create):
(_Ewk_Url_Request::_Ewk_Url_Request):

  • UIProcess/API/efl/ewk_url_response.cpp:

(ewk_url_response_content_length_get):

  • UIProcess/API/efl/ewk_url_response_private.h:

(_Ewk_Url_Response):
(_Ewk_Url_Response::create):
(_Ewk_Url_Response::_Ewk_Url_Response):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_intent_deliver):

  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didReceiveIntentForFrame):
(registerIntentServiceForFrame):

  • UIProcess/API/efl/ewk_view_policy_client.cpp:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):

  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didInitiateLoadForResource):
(didSendRequestForResource):
(didReceiveResponseForResource):

7:15 PM Changeset in webkit [131545] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/12462993> Use a sensible fallback for cache directory

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::createNewWebProcess): Cache directory should be created if it doesn't exist yet, so use createHandleForReadWriteDirectory.
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultDiskCacheDirectory): We don't want caches in home directory, they should go to ~/Library/Caches.
7:00 PM Changeset in webkit [131544] by aestes@apple.com
  • 8 edits in trunk

[WebKit2] Create Objective-C API for adding and removing user scripts
https://bugs.webkit.org/show_bug.cgi?id=99528

Reviewed by Anders Carlsson.

Source/WebKit2:

This patch adds the following API to WKBrowsingContextGroup:

  • (void)addUserScript:(NSString *)source baseURL:(NSURL *)baseURL whitelistedURLPatterns:(NSArray *)whitelist blacklistedURLPatterns:(NSArray *)blacklist injectionTime:(WKUserScriptInjectionTime)injectionTime mainFrameOnly:(BOOL)mainFrameOnly;
  • (void)removeAllUserScripts;
  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupAddUserScript): Define a C SPI equivalent of addUserScript: that calls existing methods in WebPageGroup.
(WKPageGroupRemoveAllUserScripts): Ditto for removeAllUserScripts.

  • UIProcess/API/C/WKPageGroup.h: Declare the above-mentioned functions.
  • UIProcess/API/mac/WKBrowsingContextGroup.h: Declare the Objective-C API
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup addUserScript:baseURL:whitelist:blacklist:injectionTime:mainFrameOnly:]): Call WKPageGroupAddUserScript.
(-[WKBrowsingContextGroup removeAllUserScripts]): Call WKPageGroupRemoveAllUserScripts.

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::removeAllUserScripts): This was calling PageGroup::removeUserStyleSheetsFromWorld() by mistake.

Tools:

Add three new API tests.

  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:

(expectScriptValueIsString):
(expectScriptValueIsBoolean):
(expectScriptValueIsUndefined):

6:42 PM Changeset in webkit [131543] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Url bar should not be covered by the web view
https://bugs.webkit.org/show_bug.cgi?id=99485

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-16
Reviewed by Laszlo Gombos.

When accelerated compositing is enabled, the url bar is covered by the web view.
This was caused by 2 issues:

  • _ewk_view_smart_calculate was called before the first gl surface was created, so an early return caused it to not save the new view position.
  • When painting the view, we need to take into account the position of the view within the window, i.e. the url bar.
  • UIProcess/API/efl/EflViewportHandler.cpp:

(WebKit::EflViewportHandler::display):

  • UIProcess/API/efl/EflViewportHandler.h:

(EflViewportHandler):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):
(ewk_view_display):

6:41 PM Changeset in webkit [131542] by keishi@webkit.org
  • 5 edits in trunk/LayoutTests

Add test that checks if scrolling works inside the suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=99409

Reviewed by Kent Tamura.

We want to test that scrolling, both by scrollbar and mouse wheel, work inside the suggestion picker.

  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations-expected.txt:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html:
6:32 PM Changeset in webkit [131541] by tkent@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Re-add a test which was removed mistakenly in r131538.
https://bugs.webkit.org/show_bug.cgi?id=98103

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onclick-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onclick.html: Added.
6:30 PM Changeset in webkit [131540] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Stub out chromium success handlers for integers and undefined values
https://bugs.webkit.org/show_bug.cgi?id=99527

Reviewed by Adam Barth.

Add onSuccess stubs so that chromium IPC glue can land.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccess):

6:26 PM Changeset in webkit [131539] by jchaffraix@webkit.org
  • 6 edits in trunk/Source/WebCore

Make RenderObject destruction during detach a top-down operation
https://bugs.webkit.org/show_bug.cgi?id=98336

Reviewed by Eric Seidel.

detach() is a DOM-driven operation that destroys the renderers bottom-up.
While this is correct, it causes extra-work to be done (tree cleaning, ...)
as it doesn't know about the render tree's structure.

The render tree on the other side already supports top-down operations
but it was overriden by the DOM side of detach.

This change only makes ContainerNode::detach do a top-down render tree
destruction. This is a required step towards doing smarter destruction.

Refactoring covered by existing tests.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::detach):
Changed the method to do a top-down destruction.

  • dom/Node.cpp:

(WebCore::Node::detach):
Added this ASSERT that ensures that we have properly cleaned up the
whole DOM subtree. The only exception is child content belonging to a
flow-thread as the code will shuffle the renderers under the flow-thread.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
As we don't update the node's renderer on the DOM side, do it here.
The upside is that it ensures that we don't left any stray renderer
in the tree.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::destroyLeftoverChildren):
Removed the calls to setRenderer as they are redundant with what we do
in willBeDestroyed.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setText):
Removed some now unneeded code, replaced by an ASSERT. This is because
destroying m_firstLetter would automatically reset the node's renderer
in destroyLeftoverChildren.

6:19 PM FeatureFlags edited by tkent@chromium.org
WIDGET_REGION -> DRAGGABLE_REGION (diff)
6:18 PM Changeset in webkit [131538] by tkent@chromium.org
  • 5 edits
    18 moves
    6 adds
    2 deletes in trunk/LayoutTests

Move tests for calendar picker to platform/chromium/fast/forms/calendar-picker/
https://bugs.webkit.org/show_bug.cgi?id=98103

Reviewed by Yuta Kitamura.

Move tests for calendar picker to platform/chromium/fast/forms/
calendar-picker/ because

  • Ease of skipping
  • We're going to support non-date types in the calendar picker.
  • Not sure the calendar picker code will be used on other platforms.
  • fast/forms/date/calendar-picker-appearance-expected.txt: Removed.
  • fast/forms/date/calendar-picker-appearance-pre-100-expected.txt: Removed.
  • fast/forms/date/calendar-picker-appearance-pre-100.html: Removed.
  • fast/forms/date/calendar-picker-appearance.html: Removed.
  • fast/forms/date/calendar-picker-common.js: Removed.
  • fast/forms/date/calendar-picker-key-operations-expected.txt: Removed.
  • fast/forms/date/calendar-picker-key-operations.html: Removed.
  • fast/forms/date/calendar-picker-mouse-operations-expected.txt: Removed.
  • fast/forms/date/calendar-picker-mouse-operations.html: Removed.
  • fast/forms/date/calendar-picker-type-change-onclick-expected.txt: Removed.
  • fast/forms/date/calendar-picker-type-change-onclick.html: Removed.
  • fast/forms/date/calendar-picker-with-step-expected.txt: Removed.
  • fast/forms/date/calendar-picker-with-step.html: Removed.
  • platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png.
  • platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png.
  • platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png.
  • platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png.
  • platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-win/fast/forms/date/calendar-picker-key-operations-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/date/calendar-picker-key-operations-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.txt: Copied from LayoutTests/fast/forms/date/calendar-picker-appearance-expected.txt.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html: Copied from LayoutTests/fast/forms/date/calendar-picker-appearance.html.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt: Copied from LayoutTests/fast/forms/date/calendar-picker-key-operations-expected.txt.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html: Copied from LayoutTests/fast/forms/date/calendar-picker-key-operations.html.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt: Copied from LayoutTests/fast/forms/date/calendar-picker-mouse-operations-expected.txt.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Copied from LayoutTests/fast/forms/date/calendar-picker-mouse-operations.html.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year-expected.txt: Copied from LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100-expected.txt.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html: Copied from LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100.html.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt: Copied from LayoutTests/fast/forms/date/calendar-picker-with-step-expected.txt.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html: Copied from LayoutTests/fast/forms/date/calendar-picker-with-step.html.
  • platform/chromium/fast/forms/calendar-picker/resources: Added.
  • platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js: Copied from LayoutTests/fast/forms/date/calendar-picker-common.js.
  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Fix calendar-picker-common.js path.
  • platform/gtk/TestExpectations:
6:09 PM Changeset in webkit [131537] by Lucas Forschler
  • 4 edits
    3 adds in branches/safari-536.26-branch

Merge <rdar://problem/12474784>

5:46 PM Changeset in webkit [131536] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Update Chromium ML expectations

Unreviewed, expectations change.

  • platform/chromium-mac-mountainlion/TestExpectations:
5:34 PM Changeset in webkit [131535] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-16

  • DEPS:
5:24 PM Changeset in webkit [131534] by commit-queue@webkit.org
  • 5 edits in trunk

HTMLSelectElement::optionSelectedByUser confuses listIndex and optionIndex
https://bugs.webkit.org/show_bug.cgi?id=99523

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-10-16
Reviewed by Simon Fraser.

Source/WebCore:

There was a call site where the optionIndex was being passed to a
function that expected the listIndex. Convert appropriately.

Extends Test: platform/mac/fast/objc/dom-html-select-activate.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionSelectedByUser):

LayoutTests:

Extend the dom activate test to test calls on a <select multiple> with
<optgroup>s. This previously untested case was broken.

  • platform/mac/fast/objc/dom-html-select-activate-expected.txt:
  • platform/mac/fast/objc/dom-html-select-activate.html:
5:19 PM Changeset in webkit [131533] by Lucas Forschler
  • 3 edits in branches/safari-536.26-branch/Source/JavaScriptCore

Merged r129577 -> <rdar://problem/12474770>

5:14 PM Changeset in webkit [131532] by jianli@chromium.org
  • 44 edits in trunk

Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION
https://bugs.webkit.org/show_bug.cgi?id=98975

Reviewed by Adam Barth.

Source/JavaScriptCore:

Renaming is needed to better match with the draggable region code.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Renaming is needed to better match with the draggable region code.

No new tests (OOPS!).

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.exp.in:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore):
(WebCore::Document::reportMemoryUsage):

  • dom/Document.h:

(WebCore):
(Document):

  • page/Chrome.cpp:

(WebCore):

  • page/ChromeClient.h:

(ChromeClient):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore):
(WebCore::FrameView::paintContents):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderInline.cpp:

(WebCore):
(WebCore::RenderInline::addAnnotatedRegions):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore):
(WebCore::RenderObject::addAnnotatedRegions):

  • rendering/RenderObject.h:

(WebCore::AnnotatedRegionValue::operator==):
(AnnotatedRegionValue):
(RenderObject):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

Source/WebKit/chromium:

Renaming is needed to better match with the draggable region code.

  • features.gypi:
  • src/ChromeClientImpl.cpp:

(WebKit):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

  • src/WebDocument.cpp:

(WebKit::WebDocument::draggableRegions):

Source/WebKit/mac:

Renaming is needed to better match with the draggable region code.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Renaming is needed to better match with the draggable region code.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Renaming is needed to better match with the draggable region code.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:12 PM Changeset in webkit [131531] by danakj@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed, rebaselines after r131358
https://bugs.webkit.org/show_bug.cgi?id=99441

  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
5:04 PM Changeset in webkit [131530] by simonjam@chromium.org
  • 7 edits
    2 adds in trunk

[Page Visibility API] View-less documents should report as hidden
https://bugs.webkit.org/show_bug.cgi?id=99410

Reviewed by Tony Gentilcore.

Source/WebCore:

Test: fast/events/page-visibility-null-view.html

  • dom/Document.cpp:

(WebCore::Document::visibilityState):

LayoutTests:

  • fast/events/page-visibility-null-view-expected.txt: Added.
  • fast/events/page-visibility-null-view.html: Added.
4:59 PM Changeset in webkit [131529] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebCore

Merged r130855 -> <rdar://problem/12474791>

4:47 PM Changeset in webkit [131528] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, broaden Chromium TestExpectations to match waterfall.

  • platform/chromium/TestExpectations:
4:34 PM Changeset in webkit [131527] by danakj@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Rebaseline mac compositing/geometry/fixed-position-transform-composited-page-scale-down.html
https://bugs.webkit.org/show_bug.cgi?id=89702

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Removed.
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium/TestExpectations:
4:23 PM Changeset in webkit [131526] by msaboff@apple.com
  • 6 edits in trunk/Source

Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN
https://bugs.webkit.org/show_bug.cgi?id=99484

Reviewed by Eric Seidel.

Source/WebCore:

Changed macro name to align with it's purpose, therefore changed USE(8BIT_TEXTRUN) to ENABLE(8BIT_TEXTRUN).

No new tests. Changed macro name, no functional change.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderBlock.h:

(RenderBlock):

Source/WTF:

Changed macro name to align with it's purpose.

  • wtf/Platform.h:
4:11 PM Changeset in webkit [131525] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed, fix TestExpectations for Qt and GTK after RenderSlider change.

  • platform/gtk/TestExpectations:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/qt/TestExpectations:
4:07 PM Changeset in webkit [131524] by msaboff@apple.com
  • 3 edits in trunk/Source/WTF

StringImpl::reverseFind() with a single match character isn't optimal for mixed 8/16 bit cases
https://bugs.webkit.org/show_bug.cgi?id=99363

Reviewed by Benjamin Poulain.

Factored out the 8/16 bitness check of the match character from the subject character bitness
check. Did this for both find() and reverseFind(). Added all UChar/LChar combinations to the
inline reverseFind().

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):

  • wtf/text/StringImpl.h:

(WTF::reverseFind):

4:06 PM Changeset in webkit [131523] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline for css1/basic/inheritance.html

Unreviewed gardening.

  • platform/chromium-mac/css1/basic/inheritance-expected.png:
4:04 PM Changeset in webkit [131522] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: inspector/styles/styles-history.html is failing Text on win7
https://bugs.webkit.org/show_bug.cgi?id=99519

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:58 PM Changeset in webkit [131521] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaselines for r131503
https://bugs.webkit.org/show_bug.cgi?id=99516

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:55 PM Changeset in webkit [131520] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix lint error in chromium-android/TestExpectations.

  • platform/chromium-android/TestExpectations:
3:52 PM Changeset in webkit [131519] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, lint fixes for TestExpectations.

  • platform/chromium/TestExpectations:
3:46 PM Changeset in webkit [131518] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Lint fixes for TestExpectations

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:36 PM Changeset in webkit [131517] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaselines for r131503
https://bugs.webkit.org/show_bug.cgi?id=99516

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:28 PM Changeset in webkit [131516] by oliver@apple.com
  • 51 edits
    1 add
    1 delete in trunk

Bytecode should not have responsibility for determining how to perform non-local resolves
https://bugs.webkit.org/show_bug.cgi?id=99349

Reviewed by Gavin Barraclough.

This patch removes lexical analysis from the bytecode generation. This allows
us to delay lookup of a non-local variables until the lookup is actually necessary,
and simplifies a lot of the resolve logic in BytecodeGenerator.

Once a lookup is performed we cache the lookup information in a set of out-of-line
buffers in CodeBlock. This allows subsequent lookups to avoid unnecessary hashing,
etc, and allows the respective JITs to recreated optimal lookup code.

This is currently still a performance regression in LLInt, but most of the remaining
regression is caused by a lot of indirection that I'll remove in future work, as well
as some work necessary to allow LLInt to perform in line instruction repatching.
We will also want to improve the behaviour of the baseline JIT for some of the lookup
operations, however this patch was getting quite large already so I'm landing it now
that we've reached the bar of "performance-neutral".

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitStructures):
(JSC):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addResolve):
(JSC::CodeBlock::addPutToBase):
(CodeBlock):
(JSC::CodeBlock::resolveOperations):
(JSC::CodeBlock::putToBaseOperation):
(JSC::CodeBlock::numberOfResolveOperations):
(JSC::CodeBlock::numberOfPutToBaseOperations):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::globalObjectConstant):
(JSC::CodeBlock::setGlobalObjectConstant):

  • bytecode/GlobalResolveInfo.h: Removed.
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):

  • bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

  • bytecode/ResolveOperation.h: Added. The new types and logic we use to perform the cached lookups.

(JSC):
(ResolveOperation):
(JSC::ResolveOperation::getAndReturnScopedVar):
(JSC::ResolveOperation::checkForDynamicEntriesBeforeGlobalScope):
(JSC::ResolveOperation::getAndReturnGlobalVar):
(JSC::ResolveOperation::getAndReturnGlobalProperty):
(JSC::ResolveOperation::resolveFail):
(JSC::ResolveOperation::skipTopScopeNode):
(JSC::ResolveOperation::skipScopes):
(JSC::ResolveOperation::returnGlobalObjectAsBase):
(JSC::ResolveOperation::setBaseToGlobal):
(JSC::ResolveOperation::setBaseToUndefined):
(JSC::ResolveOperation::setBaseToScope):
(JSC::ResolveOperation::returnScopeAsBase):
(JSC::PutToBaseOperation::PutToBaseOperation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::shouldAvoidResolveGlobal):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetLocalVar):
(JSC::BytecodeGenerator::emitInitGlobalConst):
(JSC::BytecodeGenerator::emitPutToBase):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ResolveResult::registerResolve):
(JSC::ResolveResult::dynamicResolve):
(ResolveResult):
(JSC::ResolveResult::ResolveResult):
(JSC):
(NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::~NonlocalResolveInfo):
(JSC::NonlocalResolveInfo::resolved):
(JSC::NonlocalResolveInfo::put):
(BytecodeGenerator):
(JSC::BytecodeGenerator::getResolveOperations):
(JSC::BytecodeGenerator::getResolveWithThisOperations):
(JSC::BytecodeGenerator::getResolveBaseOperations):
(JSC::BytecodeGenerator::getResolveBaseForPutOperations):
(JSC::BytecodeGenerator::getResolveWithBaseForPutOperations):
(JSC::BytecodeGenerator::getPutToBaseOperation):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(DFG):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileResolveOperations):
(DFG):
(JSC::DFG::canCompilePutToBaseOperation):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(ResolveOperationData):
(DFG):
(PutToBaseOperationData):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveOperationsDataIndex):
(Node):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::resolveOperations):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::putToBaseOperation):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC):
(JSC::JIT::emit_resolve_operations):
(JSC::JIT::emitSlow_link_resolve_operations):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::emit_op_init_global_const_check):
(JSC::JIT::emitSlow_op_init_global_const_check):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSScope.cpp:

(JSC::LookupResult::base):
(JSC::LookupResult::value):
(JSC::LookupResult::setBase):
(JSC::LookupResult::setValue):
(LookupResult):
(JSC):
(JSC::setPutPropertyAccessOffset):
(JSC::executeResolveOperations):
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolveContainingScope):
(JSC::JSScope::resolve):
(JSC::JSScope::resolveBase):
(JSC::JSScope::resolveWithBase):
(JSC::JSScope::resolveWithThis):
(JSC::JSScope::resolvePut):
(JSC::JSScope::resolveGlobal):

  • runtime/JSScope.h:

(JSScope):

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSVariableObject):

  • runtime/Structure.h:

(JSC::Structure::propertyAccessesAreCacheable):
(Structure):

3:09 PM Changeset in webkit [131515] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r131485): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=99499

Unreviewed build (warning) fix.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgram::getLocation):

3:08 PM Changeset in webkit [131514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix a bug that we are using scaled damage rect for plugins inside an iframe
https://bugs.webkit.org/show_bug.cgi?id=99488

Patch by Min Qin <qinmin@chromium.org> on 2012-10-16
Reviewed by Adam Barth.

There is a bug with a previous webkit patch: https://bugs.webkit.org/show_bug.cgi?id=98468
In that patch, we incorrectly applied the main frame's scale factor to inner iframes.
However, the damageRect is not scaled inside an iFrame. So doing the intersect will retrieve wrong result here.
In WebPluginContainerImpl::calculateGeometry, the windowRect also does not apply main frame's scale factor.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):

3:05 PM Changeset in webkit [131513] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest
https://bugs.webkit.org/show_bug.cgi?id=99497

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-16
Reviewed by Antonio Gomes.

Fix calculateInRegionScrollableAreasForPoint to use a ReadOnly
hit test to improve its performance.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

3:01 PM Changeset in webkit [131512] by danakj@chromium.org
  • 2 edits in trunk/LayoutTests

Some tests need rebaseline after r131497
https://bugs.webkit.org/show_bug.cgi?id=99511

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:00 PM Changeset in webkit [131511] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

Inspector: Don't fire assert when inspecting an empty db
https://bugs.webkit.org/show_bug.cgi?id=99370

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

3:00 PM Changeset in webkit [131510] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[GTK] accessibility/radio-button-title-label.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98374

Unreviewed. Unskipped test, new port-specific baseline.

New baseline for the GTK port. If there is a proper label tag, we
expect the widget to get its name/title from that label. The aria
labelledby property is exposed in addition to the label; not instead
of the label.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-10-16

  • platform/gtk/TestExpectations: Unskipped failing test.
  • platform/gtk/accessibility/radio-button-title-label-expected.txt: Added.
2:59 PM Changeset in webkit [131509] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Accidental switch fall-through in DFG::FixupPhase
https://bugs.webkit.org/show_bug.cgi?id=96956
<rdar://problem/12313242>

Reviewed by Mark Hahnenberg.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

2:58 PM Changeset in webkit [131508] by dpranke@chromium.org
  • 4 edits
    2 adds in trunk

[chromium] add Mountain Lion baselines
https://bugs.webkit.org/show_bug.cgi?id=99505

Reviewed by Ojan Vafai.

This change adds a temporary 10.8/MountainLion-specific
expectations file for Chromium so that the bot can be green
while we are updating all the baselines and triaging failures.

Tools:

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_ml_expectations):

LayoutTests:

  • platform/chromium-mac-mountainlion/TestExpectations: Added.
2:57 PM Changeset in webkit [131507] by tony@chromium.org
  • 4 edits in trunk/Source

Source/WebCore: Unreviewed, try to fix the Apple Win build by forcing a rebuild of RenderingAllInOne.cpp.

  • rendering/RenderingAllInOne.cpp:

Source/WebKit2: Unreviewed, revert previous WebKit2.def change. E