Timeline



Oct 26, 2012:

11:55 PM Changeset in webkit [132723] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, skip new failing tests.

  • platform/qt/TestExpectations:
11:00 PM Changeset in webkit [132722] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Browser prematurely sends wrong credentials
https://bugs.webkit.org/show_bug.cgi?id=100585

Reviewed by Yong Li.

Manually revert the patch for bug 96362, which causes regressions and the right patch has been
submitted with patch for bug 100448. Since the auto-revert fails, we use this patch to manually
revert.

No new tests. The test is coverted by patch for 100448.

  • platform/network/blackberry/CredentialBackingStore.cpp:
  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

10:59 PM Changeset in webkit [132721] by beidson@apple.com
  • 24 edits
    4 copies
    4 adds in trunk/Source

Have NetworkProcess manage resource load scheduling.
https://bugs.webkit.org/show_bug.cgi?id=100479

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Down in WebCore we need to virtualize a handful of ResourceLoadScheduler methods
to be overridden by WebKit's implementation.

No new tests (No change in Core behavior).

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoadScheduler.cpp:

(WebCore::resourceLoadScheduler): Gracefully handle LoaderStrategies wanting to return the default scheduler.
(WebCore::ResourceLoadScheduler::scheduleLoad): Call notifyDidScheduleResourceRequest.
(WebCore::ResourceLoadScheduler::notifyDidScheduleResourceRequest): Moved InspectorInstrumentation call

here so derived classes can do it indirectly.

(WebCore::ResourceLoadScheduler::startResourceLoader): To allow derived classes the ability to call

ResourceLoader::start() which only ResourceLoadScheduler can do.

  • loader/ResourceLoadScheduler.h:

(ResourceLoadScheduler): Virtualize some core public methods so they can be overridden.
(WebCore::ResourceLoadScheduler::setSerialLoadingEnabled): Make virtual.
(WebCore::ResourceLoadScheduler::isSuspendingPendingRequests): Make private as it's internal only.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::setIdentifier): Add this setter so outside clients can manually change the identifier.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::identifier): Change identifier to explicitly be uint64_t.
(WebCore::ResourceLoader::request): Make public.
(ResourceLoader):

Source/WebKit2:

Implement a ResourceLoadScheduler that models the same behavior as WebCore::ResourceLoadScheduler.

The WebProcess scheduler acts as a marshall to the NetworkProcess scheduler via CoreIPC messaging.

Besides MainResourceLoads which are started directly in the WebProcess, all other loads are now
started only when the NetworkProcess tells them to start.

Build-system and messaging related stuff:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • WebKit2.xcodeproj/project.pbxproj:

Add a new Network logging channel.

  • Platform/Logging.cpp:

(WebKit::getChannelFromName):

  • Platform/Logging.h:

Modeled after ResourceLoadScheduler::HostInformation but more specifically geared towards what NetworkProcess needs to track:

  • NetworkProcess/HostRecord.cpp: Added.

(WebKit::HostRecord::HostRecord):
(WebKit::HostRecord::~HostRecord):
(WebKit::HostRecord::schedule):
(WebKit::HostRecord::addLoadInProgress):
(WebKit::HostRecord::remove):
(WebKit::HostRecord::hasRequests):
(WebKit::HostRecord::limitRequests):

  • NetworkProcess/HostRecord.h:

(WebKit::HostRecord::name):
(WebKit::HostRecord::requestsPending):

Gateway messaging from the WebResourceLoadScheduler to the NetworkResourceLoadScheduler:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::registerObserver):
(WebKit::NetworkConnectionToWebProcess::unregisterObserver):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::scheduleNetworkRequest):
(WebKit::NetworkConnectionToWebProcess::addLoadInProgress):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
(WebKit::NetworkConnectionToWebProcess::crossOriginRedirectReceived):
(WebKit::NetworkConnectionToWebProcess::servePendingRequests):
(WebKit::NetworkConnectionToWebProcess::suspendPendingRequests):
(WebKit::NetworkConnectionToWebProcess::resumePendingRequests):
(WebKit::NetworkConnectionToWebProcess::setSerialLoadingEnabled):

  • NetworkProcess/NetworkConnectionToWebProcess.h:

(NetworkConnectionToWebProcessObserver): Add an observer interface so arbitrary objects can be notified if

a Network->WebProcess connection closes.

(WebKit::NetworkConnectionToWebProcessObserver::~NetworkConnectionToWebProcessObserver):
(WebKit::NetworkConnectionToWebProcess::isSerialLoadingEnabled):

  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Represents a request, ResourceLoadIdentifier, and connection that all correspond to the same pending NetworkLoad:

  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::~NetworkRequest):
(WebKit::NetworkRequest::connectionToWebProcessDidClose): Using the NetworkConnectionToWebProcessObserver interface,

if the connection closes then clear out the connection pointer for this request that is now irrelevant.

  • NetworkProcess/NetworkRequest.h:

(WebKit::NetworkRequest::create):
(WebKit::NetworkRequest::identifier):
(WebKit::NetworkRequest::connectionToWebProcess):

Manages connection-per-host scheduling with the same structure as WebCore::ResourceLoadScheduling but also with IPC:

  • NetworkProcess/NetworkResourceLoadScheduler.cpp: Added.

(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::scheduleServePendingRequests):
(WebKit::NetworkResourceLoadScheduler::requestTimerFired):
(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest):
(WebKit::NetworkResourceLoadScheduler::addLoadInProgress):
(WebKit::NetworkResourceLoadScheduler::hostForURL):
(WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
(WebKit::NetworkResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost): Serve as many requests for the host as we should,

skipping the NetworkRequests who have lost their connection to their WebProcess.

(WebKit::NetworkResourceLoadScheduler::suspendPendingRequests):
(WebKit::NetworkResourceLoadScheduler::resumePendingRequests):

  • NetworkProcess/NetworkResourceLoadScheduler.h: Added.
  • NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm: Added.

(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::networkResourceLoadScheduler): Add a scheduler global to the NetworkProcess.

A thin derivation of WebCore::ResourceLoadScheduler, most of what WebResourceLoadScheduler does is handle IPC to the NetworkProcess:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addMainResourceLoad):
(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::WebResourceLoadScheduler::servePendingRequests):
(WebKit::WebResourceLoadScheduler::suspendPendingRequests):
(WebKit::WebResourceLoadScheduler::resumePendingRequests):
(WebKit::WebResourceLoadScheduler::setSerialLoadingEnabled):
(WebKit::WebResourceLoadScheduler::startResourceLoad):

  • WebProcess/Network/WebResourceLoadScheduler.h:

Add the ability for the NetworkProcess to message back to the WebProcess telling it to start a resource load:

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
(WebKit::NetworkProcessConnection::startResourceLoad):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::resourceLoadScheduler): Only return the WebResourceLoadScheduler if NetworkProcess is enabled.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection): Actually keep the NetworkProcessConnection around in a member variable.
(WebKit::WebProcess::networkConnection):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::usesNetworkProcess): Expose this for platform strategies sake.

7:10 PM Changeset in webkit [132720] by crogers@google.com
  • 5 edits
    4 adds in trunk

Implement AudioBufferSourceNode .loopStart and .loopEnd attributes
https://bugs.webkit.org/show_bug.cgi?id=100170

Reviewed by Kenneth Russell.

Source/WebCore:

AudioBufferSourceNode currently only supports looping of an entire AudioBuffer.
Sample-based synthesis is a very common technique which requires "internal" loop-points.
For example, the first part of the sample data might represent the attack portion of
a synthesized instrument, which then enters a loop portion.

Tests: webaudio/audiobuffersource-loop-comprehensive.html

webaudio/audiobuffersource-loop-points.html

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

  • Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::loopStart):
(WebCore::AudioBufferSourceNode::loopEnd):
(WebCore::AudioBufferSourceNode::setLoopStart):
(WebCore::AudioBufferSourceNode::setLoopEnd):

  • Modules/webaudio/AudioBufferSourceNode.idl:

LayoutTests:

  • webaudio/audiobuffersource-loop-comprehensive-expected.txt: Added.
  • webaudio/audiobuffersource-loop-comprehensive.html: Added.
  • webaudio/audiobuffersource-loop-points-expected.wav: Added.
  • webaudio/audiobuffersource-loop-points.html: Added.
7:07 PM Changeset in webkit [132719] by tkent@chromium.org
  • 8 edits in trunk/LayoutTests

[Chromium] Test expectation update.

Rebaseline for recent forms changes.

  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium/TestExpectations:
6:53 PM Changeset in webkit [132718] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Convert Chromium template string to an LDML date format
https://bugs.webkit.org/show_bug.cgi?id=100128

Reviewed by Tony Chang.

  • src/LocalizedStrings.cpp:

(WebCore): Include WebCore/platform/text/DateTimeFormat.h.
(WebCore::weekFormatInLDML):
Replace $1 with yyyy, $2 with ww, and quote other parts.

6:37 PM Changeset in webkit [132717] by eric@webkit.org
  • 1 edit
    1 add in trunk/PerformanceTests

Add a microbenchmark for Hindi (complex-text) line-layout
https://bugs.webkit.org/show_bug.cgi?id=100024

Reviewed by Ryosuke Niwa.

I wrote this to make sure that we don't regress line-breaking performance
for the complex-text codepath. This test has shown me that TOT is
already 5% slower than Safari 6.0.1 here. :(

  • Layout/hindi-line-layout.html: Added.
6:31 PM Changeset in webkit [132716] by dcheng@chromium.org
  • 7 edits
    2 adds in trunk

dragover's default action should prevent drop for file drags
https://bugs.webkit.org/show_bug.cgi?id=79173

Reviewed by Tony Chang.

Source/WebCore:

During a file drag, we need to keep track of whether or not the document has cancelled the
dragover action. We should only send a drop event if the dragover event was cancelled; this
matches the behavior of the spec, as well as IE, Gecko, and Opera. The relevant sections
from the spec are the sections pertaining to dragover and drop events at:
http://www.whatwg.org/specs/web-apps/current-work/#drag-and-drop-processing-model

Test: fast/events/only-valid-drop-targets-receive-file-drop.html

  • page/DragController.cpp:

(WebCore::DragController::performDrag):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):

  • page/DragController.h:

(DragController): Cleanup to repurpose a variable that doesn't need to be a member anymore

and remove the corresponding getter/setter.

LayoutTests:

  • fast/dom/shadow/drop-event-in-shadow.html:

Added dragover handler as required by the HTML specification.

  • fast/events/input-element-display-none-in-dragleave-crash.html:

Added dragover handler as required by the HTML specification.

  • fast/events/only-valid-drop-targets-receive-file-drop-expected.txt: Added.
  • fast/events/only-valid-drop-targets-receive-file-drop.html: Added.
  • http/tests/security/clipboard/clipboard-file-access.html:

Added dragover handler as required by the HTML specification.

6:20 PM Changeset in webkit [132715] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat
https://bugs.webkit.org/show_bug.cgi?id=94756

Reviewed by Dirk Schulze.

The function has an early exit for !simpleDuration.value(), so
!simpleDuration.value() always is 0 when passed as second parameter to
fmod(), which means fmod() always returns NaN, which always evaluates
to true. Simplify the code by removing that explicit check.

No observable behavior change.

Covered by existing svg tests.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

6:01 PM Changeset in webkit [132714] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProces at WebCore::ResourceLoadScheduler::crossOriginRedirectReceived + 78
https://bugs.webkit.org/show_bug.cgi?id=100554

Reviewed by Alexey Proskuryakov.

For now, just have WebPlatformStrategies return the same default resourceLoadScheduler that
WebCore knows about.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::resourceLoadScheduler):

5:17 PM Changeset in webkit [132713] by andersca@apple.com
  • 12 edits
    3 adds in trunk

Source/WebKit2: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569
<rdar://problem/11726426>
<rdar://problem/12352836>

Reviewed by Darin Adler.

Finally bite the bullet and remove the assertion from NetscapePlugin::fromNPP. The WebKit1 equivalent of this
function used to return the plug-in currently being initialized in NPP_New, but we've never done that in WebKit2
and it has never been necessary. The crashes fixed here are not from calls underneath NPP_New so fixing it wouldn't
do us any good anyway.

Also, make the PluginDestructionProtector handle a null plug-in gracefully.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::PluginDestructionProtector::PluginDestructionProtector):
(PluginDestructionProtector):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::fromNPP):

Tools: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569

Reviewed by Darin Adler.

Add new NPRuntimeCallsWithNullNPP plug-in test.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_ReleaseVariantValue):
(PluginTest::netscapeFuncs):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:

(PluginTest):

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp: Added.

(NPRuntimeCallsWithNullNPP):
(NPRuntimeCallsWithNullNPP::NPRuntimeCallsWithNullNPP):
(NPRuntimeCallsWithNullNPP::NPP_New):

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests: Crash when making NPRuntime calls with a null NPP pointer
https://bugs.webkit.org/show_bug.cgi?id=100569

Reviewed by Darin Adler.

Add new tests.

  • plugins/npruntime/npruntime-calls-with-null-npp-expected.txt: Added.
  • plugins/npruntime/npruntime-calls-with-null-npp.html: Added.
4:55 PM Changeset in webkit [132712] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r132695.
http://trac.webkit.org/changeset/132695
https://bugs.webkit.org/show_bug.cgi?id=100581

caused 20+ test crashes on bots (Requested by estes on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::loadNow):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::resourceLoadScheduler):

  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::performPostLoadActions):

4:36 PM Changeset in webkit [132711] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r132689.
http://trac.webkit.org/changeset/132689
https://bugs.webkit.org/show_bug.cgi?id=100574

Broke HashMaps containing RetainPtrs (Requested by andersca on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • wtf/RetainPtr.h:
4:28 PM Changeset in webkit [132710] by scheib@chromium.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r132702.
http://trac.webkit.org/changeset/132702
https://bugs.webkit.org/show_bug.cgi?id=100322

Compile error on Chromium Linux dbg builder (and others)

Source/WebCore:

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

  • svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):

LayoutTests:

  • svg/custom/elementTimeControl-nan-crash-expected.txt: Removed.
  • svg/custom/elementTimeControl-nan-crash.html: Removed.
4:21 PM Changeset in webkit [132709] by Stephanie Lewis
  • 3 edits in trunk/Source/WebKit2

Add pids to WebMemorySampleFiles.
https://bugs.webkit.org/show_bug.cgi?id=100449.

Reviewed by Tim Horton.

Make it easier to associate WebMemorySamples with a process. Add the pid to the filename and header.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::initializeTimers): Update notification.
(WebKit::WebMemorySampler::stop): Update notification.
(WebKit::WebMemorySampler::writeHeaders): dump pid in the header.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidFinishLaunching): append pid to filename.

4:03 PM Changeset in webkit [132708] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Allow embedder to enter/leave force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100458

Patch by James Robinson <jamesr@chromium.org> on 2012-10-26
Reviewed by Adrienne Walker.

This adds API for the embedder to decide when to enter and leave force compositing mode since it's
more efficient to only toggle this setting when the embedder is about to produce a frame.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::enterForceCompositingMode):

  • src/WebFrameImpl.cpp:

(WebKit::WebViewImpl::enterForceCompositingMode):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

3:59 PM Changeset in webkit [132707] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove one more test that consistently passes according to the flakiness dashboard.

  • platform/chromium/TestExpectations:
3:45 PM Changeset in webkit [132706] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Build fix after r132647.
https://bugs.webkit.org/show_bug.cgi?id=100540

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

AC enabled build is broken after the latest refactoring of EFL WK2.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
(EwkViewImpl::evasGl):
(EwkViewImpl::evasGlContext):
(EwkViewImpl::evasGlSurface):
(EwkViewImpl::resetEvasGlSurface):

  • UIProcess/API/efl/ewk_view.cpp:

(mapToWebContent):
(_ewk_view_smart_calculate):

3:42 PM Changeset in webkit [132705] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, remove tests that consistently pass.

  • platform/chromium-mac-mountainlion/TestExpectations: Some tests still need 10.8 baselines. Add them to this file.
  • platform/chromium/TestExpectations:
3:36 PM Changeset in webkit [132704] by Lucas Forschler
  • 8 edits in tags/Safari-537.16/Source/JavaScriptCore

Merged r132701.

3:31 PM Changeset in webkit [132703] by Lucas Forschler
  • 8 edits in tags/Safari-537.16/Source/JavaScriptCore

Rollout r132674.

3:29 PM Changeset in webkit [132702] by pdr@google.com
  • 5 edits
    2 adds in trunk

Prevent NaN offset values in ElementTimeControl.
https://bugs.webkit.org/show_bug.cgi?id=100322

Reviewed by Abhishek Arya.

Source/WebCore:

NaN values can cause ElementTimeControl to go back in time!
If a value of NaN is passed to ElementTimeControl::beginElementAt(offset),
subsequent sorting will cause an assert in SVGSMILElement::findInstanceTime
because NaN values are not properly sorted. NaN SMILTime values
should not be allowed at all, so this patch adds a check for them in
ElementTimeControl's setters.

This patch also adds preventative asserts to catch if SMILTime is ever
initialized with NaN, or if addEndTime/addBeginTime are ever called
with NaN values.

Test: svg/custom/elementTimeControl-nan-crash.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

  • svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):

LayoutTests:

  • svg/custom/elementTimeControl-nan-crash-expected.txt: Added.
  • svg/custom/elementTimeControl-nan-crash.html: Added.
3:18 PM Changeset in webkit [132701] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Forward OSR calculation is wrong in the presence of multiple SetLocals, or a mix of SetLocals and Phantoms
https://bugs.webkit.org/show_bug.cgi?id=100461

Reviewed by Oliver Hunt and Gavin Barraclough.

This does a couple of things. First, it removes the part of the change in r131822 that made the forward
OSR exit calculator capable of handling multiple SetLocals. That change was wrong, because it would
blindly assume that all SetLocals had the same ValueRecovery, and would ignore the possibility that if
there is no value recovery then a ForwardCheckStructure on the first SetLocal would not know how to
recover the state associated with the second SetLocal. Then, it introduces the invariant that any bytecode
op that decomposes into multiple SetLocals must first emit dead SetLocals as hints and then emit a second
set of SetLocals to actually do the setting of the locals. This means that if a ForwardCheckStructure (or
any other hoisted forward speculation) is inserted, it will always be inserted on the second set of
SetLocals (since hoisting only touches the live ones), at which point OSR will already know about the
mov hints implied by the first set of (dead) SetLocals. This gives us the behavior we wanted, namely, that
a ForwardCheckStructure applied to a variant set by a resolve_with_base-like operation can correctly do a
forward exit while also ensuring that prior to exiting we set the appropriate locals.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

2:59 PM Changeset in webkit [132700] by tony@chromium.org
  • 57 edits in trunk

Move non-Settings Inspector methods from internals.settings to internals
https://bugs.webkit.org/show_bug.cgi?id=100392

Reviewed by Adam Barth.

Source/WebCore:

These methods don't have to do with the WebCore Settings object, so move them up to internals.
I moved the reset code from InternalSettings to Internals.

No new tests, this is just a rename. Existing tests should pass.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Remove inspector methods.
(WebCore::InternalSettings::Backup::restoreTo): Remove inspector methods.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): New method for resetting page state. Named after similar
methods in WTR.
(WebCore::Internals::setInspectorResourcesDataSizeLimits): Moved from InspectorSettings.
(WebCore::Internals::setJavaScriptProfilingEnabled): Moved from InspectorSettings.

  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject): Reset state in Internals.

LayoutTests:

Update tests to use internals.setJavaScriptProfilingEnabled instead of internals.settings.setJavaScriptProfilingEnabled.
Update tests to use internals.setInspectorResourcesDataSizeLimits instead of internals.settings.setInspectorResourcesDataSizeLimits.

  • fast/profiler/anonymous-event-handler.html:
  • fast/profiler/anonymous-function-called-from-different-contexts.html:
  • fast/profiler/anonymous-function-calls-built-in-functions.html:
  • fast/profiler/anonymous-function-calls-eval.html:
  • fast/profiler/anonymous-functions-with-display-names.html:
  • fast/profiler/apply.html:
  • fast/profiler/built-in-function-calls-anonymous.html:
  • fast/profiler/built-in-function-calls-user-defined-function.html:
  • fast/profiler/call-register-leak.html:
  • fast/profiler/call.html:
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
  • fast/profiler/compare-multiple-profiles.html:
  • fast/profiler/constructor.html:
  • fast/profiler/dead-time.html:
  • fast/profiler/document-dot-write.html:
  • fast/profiler/event-handler.html:
  • fast/profiler/execution-context-and-eval-on-same-line.html:
  • fast/profiler/inline-event-handler.html:
  • fast/profiler/many-calls-in-the-same-scope.html:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
  • fast/profiler/multiple-and-different-scoped-function-calls.html:
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html:
  • fast/profiler/multiple-frames.html:
  • fast/profiler/named-functions-with-display-names.html:
  • fast/profiler/nested-anonymous-functon.html:
  • fast/profiler/nested-start-and-stop-profiler.html:
  • fast/profiler/no-execution-context.html:
  • fast/profiler/one-execution-context.html:
  • fast/profiler/profile-calls-in-included-file.html:
  • fast/profiler/profile-with-no-title.html:
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
  • fast/profiler/profiling-from-a-nested-location.html:
  • fast/profiler/simple-event-call.html:
  • fast/profiler/simple-no-level-change.html:
  • fast/profiler/start-and-stop-profiler-multiple-times.html:
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html:
  • fast/profiler/start-but-dont-stop-profiling.html:
  • fast/profiler/stop-profiling-after-setTimeout.html:
  • fast/profiler/stop-then-function-call.html:
  • fast/profiler/two-execution-contexts.html:
  • fast/profiler/user-defined-function-calls-built-in-functions.html:
  • fast/profiler/window-dot-eval.html:
  • http/tests/inspector/network-test.js:

(resetInspectorResourcesData):

  • http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • inspector/profiler/cpu-profiler-profiling-without-inspector.html:
2:57 PM Changeset in webkit [132699] by dmazzoni@google.com
  • 27 edits
    6 adds in trunk

AX: Notification should be sent when accessibilityIsIgnored changes
https://bugs.webkit.org/show_bug.cgi?id=99547

Reviewed by Chris Fleizach.

Source/WebCore:

Adds a new flag in AccessibilityObject that keeps track of the most recent
value of accessibilityIsIgnored(). After certain events such as an ARIA
attribute change or content change, checks the new value of
accessibilityIsIgnored() and posts a "children changed" notification on the
parent node if it changed, making sure the parent recomputes its vector of
(unignored) children.

Also moves handling of attribute changes to AXObjectCache, and sends
notifications for some attribute changes that were previously silent. On
Chromium, all changes to an accessibility object's attributes should
result in some notification.

Some tests would have broken because an AccessibilityScrollView was created
and holding a reference to a ScrollView for an iframe after it was deleted,
so this change switches AccessibilityScrollView to hold a weak reference
to ScrollView instead.

Tests: platform/chromium/accessibility/is-ignored-change-sends-notification.html

platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html
platform/chromium/accessibility/text-change-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::textChanged):
(WebCore):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):

  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::insertChild):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::cachedIsIgnoredValue):
(WebCore):
(WebCore::AccessibilityObject::setCachedIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::textChanged):
(AccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::~AccessibilityScrollView):
(WebCore):
(WebCore::AccessibilityScrollView::detach):
(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::scrollView):
(AccessibilityScrollView):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

Source/WebKit/chromium:

Adds new accessibility notifications.

  • public/WebAccessibilityNotification.h:
  • src/AssertMatchingEnums.cpp:

Tools:

Add additional accessibility notifications.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

LayoutTests:

Adds 3 new test to ensure:

  1. A "children changed" notification is fired on the parent object when an object that was previously ignored becomes unignored.
  2. A notification is sent when an element's text (incl. title or label) changes.
  3. A notification is sent when another ARIA attribute changes.

Modifies add-to-menu-list-crashes because it was too brittle; it was

referencing a stale object rather than retrieving its latest handle.

Modifies aria-checkbox-sends-notification to listen on the correct

object on all platforms.

Simplifies notification-listeners so it doesn't generate additional

notifications that are inconsistent between platforms now.

  • accessibility/aria-checkbox-sends-notification.html:
  • accessibility/notification-listeners.html:
  • platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt:
  • platform/chromium/accessibility/add-to-menu-list-crashes.html:
  • platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt: Added.
  • platform/chromium/accessibility/is-ignored-change-sends-notification.html: Added.
  • platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt: Added.
  • platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html: Added.
  • platform/chromium/accessibility/text-change-notification-expected.txt: Added.
  • platform/chromium/accessibility/text-change-notification.html: Added.
2:55 PM Changeset in webkit [132698] by jsbell@chromium.org
  • 9 edits in trunk/Source/WebCore

[WebKitIDL] Optional dictionary types should have default values of empty dictionary
https://bugs.webkit.org/show_bug.cgi?id=100547

Reviewed by Adam Barth.

Per WebIDL, "Optional dictionary type arguments are always considered to have a default
value of an empty dictionary." WebKitIDL already supported this via the extended attribute
[Optional=DefaultIsUndefined] but make this the default for Dictionary.

Binding test expectations updated.

  • Modules/filesystem/DirectoryEntry.h: Remove default parameters.

(DirectoryEntry):

  • Modules/indexeddb/IDBDatabase.h: Remove overloads.

(IDBDatabase):

  • Modules/indexeddb/IDBObjectStore.h: Remove overloads.

(IDBObjectStore):

  • Modules/mediastream/RTCPeerConnection.idl: Remove DefaultIsUndefined annotations.
  • bindings/scripts/CodeGeneratorJS.pm: Special case for Optional Dictionary.

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOptionsObject): Updated expectation - no early call.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::optionsObjectCallback): Ditto.

2:41 PM Changeset in webkit [132697] by Lucas Forschler
  • 8 edits in tags/Safari-537.16/Source/WebCore

Merged r132695. <rdar://problem/12575514>

2:36 PM Changeset in webkit [132696] by scheib@chromium.org
  • 12 edits
    6 adds
    21 deletes in trunk

Generated should not be supported for things with a shadow
https://bugs.webkit.org/show_bug.cgi?id=98836

Unreviewed rollout of rollout of http://trac.webkit.org/changeset/132269.
Initial rollout was speculative and was shown not to be related to crashes.
Change author: Elliott Sprehn <esprehn@chromium.org>

Source/WebCore:

As far as CSS is concerned inputs and things with shadow content inside
shouldn't support pseudo elements like :before, :after or :first-letter.
Neither Gecko or Presto supports it, and we only accidentally supported
it.

Until the spec tells us what to do we should disable support. This is
also neccesary because the new generated content implementation doesn't
support shadows.

Test: fast/forms/pseudo-elements.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderListBox.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Change all pseudos on <input> tests to be ref tests and clean up the tests.
They now make sure we don't support generated content on things with a shadow.
Also added another test for the other form control types to ensure they don't
support pseudos either.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/pseudo-elements-expected.html: Added.
  • fast/forms/pseudo-elements.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
2:30 PM Changeset in webkit [132695] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

Crash in WebProces at WebCore::ResourceLoadScheduler::crossOriginRedirectReceived + 78
<rdar://problem/12575514> and https://bugs.webkit.org/show_bug.cgi?id=100554

Reviewed by Alexey Proskuryakov.

This was fallout from http://trac.webkit.org/changeset/132501 where I missed some of the
spots that call resourceLoadScheduler().

As a result we were creating more than one ResourceLoadScheduler, allowing the host records
to get out of sync.

The fix that also results in less #ifdefs scattered throughout the code is to use a single
choke point for all ResourceLoadScheduler access.

No new tests
(No change of behavior for the default config, not testable at this time in the repro config)

Add a single choke point for accessing the correct ResourceLoadScheduler:

  • loader/ResourceLoadScheduler.cpp:

(WebCore::defaultResourceLoadScheduler): New private function that keeps the singleton default ResourceLoadScheduler.
(WebCore::resourceLoadScheduler): Refactor this function to either ask the LoaderStrategy or call through to

Revert back to using that single choke point everywhere:

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::loadNow):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::performPostLoadActions):

2:25 PM Changeset in webkit [132694] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Remove Chromium specific expectations for video-media-source-add-and-remove-buffers.html
https://bugs.webkit.org/show_bug.cgi?id=100160

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Adam Barth.

The common expectations just reflected a bug in Chromium. The bug has been fixed and the common expectations
have been updated to reflect the correct behavior.

  • http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
  • platform/chromium/http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Removed.
2:20 PM Changeset in webkit [132693] by zoltan@webkit.org
  • 2 edits
    3 moves
    3 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #6
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #6 commit of the whole patch.

  • PageLoad/svg/files/gearflowers.svg: Removed.
  • PageLoad/svg/files/hereGear4.svg: Removed.
  • PageLoad/svg/files/worldcup.svg: Removed.
  • SVG/GearFlowers.html: Added.
  • SVG/HereGear.html: Added.
  • SVG/Worldcup.html: Added.
  • SVG/resources/GearFlowers.svg: Copied from PerformanceTests/PageLoad/svg/files/gearflowers.svg.
  • SVG/resources/HereGear.svg: Copied from PerformanceTests/PageLoad/svg/files/hereGear4.svg.
  • SVG/resources/Worldcup.svg: Copied from PerformanceTests/PageLoad/svg/files/worldcup.svg.
  • Skipped: Rename the files on the skipped list also.
2:16 PM Changeset in webkit [132692] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Try to fix the windows build
https://bugs.webkit.org/show_bug.cgi?id=100556

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Eric Seidel.

Touch files by adding whitespace to try and make the windows
build bot regenerate files.

No new tests, just kick the bot.

  • dom/DOMAllInOne.cpp:
  • html/HTMLElementsAllInOne.cpp:
  • html/shadow/TextControlInnerElements.cpp:
1:59 PM Changeset in webkit [132691] by kareng@chromium.org
  • 1 edit
    3 copies in branches/chromium/1271

Merge 132371 - Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658

Patch by Toni Barzic <tbarzic@chromium.org> on 2012-10-24
Reviewed by Adam Barth.

Source/WebCore:

DOMWindow::console may return NULL, so we should do a NULL check before adding message to it.
This may happen e.g. if a worker throws an exception just as the document is being replaced in the view.
The exception task could be processes after current window in the frame changes, and console in the document window is nulled.

Test: fast/workers/worker-exception-during-navigation.html

  • dom/Document.cpp:

(WebCore::Document::addMessage):

LayoutTests:

The test creates bunch of workers that throw an exception as soon as they are loaded and then tries to change the current document.
The test passes if there is no crash.
Unfortuantely, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).

  • fast/workers/resources/worker-exception.js: Added.
  • fast/workers/worker-exception-during-navigation-expected.txt: Added.
  • fast/workers/worker-exception-during-navigation.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11320014

1:41 PM Changeset in webkit [132690] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Get rid of (<X%) failing output for old-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=100447

Reviewed by Jessie Berlin.

Not a particularly useful piece of information. It's pretty much never above 1%.
new-run-webkit-tests does not output this either.

  • Scripts/old-run-webkit-tests:

(printResults):

1:36 PM Changeset in webkit [132689] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Add an operator& to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100549

Reviewed by Dan Bernstein.

This is useful for APIs that return references using out parameters.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::operator&):

1:12 PM Changeset in webkit [132688] by rwlbuis@webkit.org
  • 4 edits in trunk

[BlackBerry] Platform Abstraction for WebKit Resource/Image Loading
https://bugs.webkit.org/show_bug.cgi?id=100518

PR 231732

Reviewed by Yong Li.

.:

Remove RESOURCE_PATH from webkit, this is now abstracted in our platform layer.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

Use the new resource/image loading abstraction ResourceStore.

  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::Image::loadPlatformResource):

1:02 PM Changeset in webkit [132687] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
https://bugs.webkit.org/show_bug.cgi?id=100421

Reviewed by Yong Li.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 231173
When leaving fullscreen, we need to suspend screen and backing store
updates before setting scroll position and changing transformation and
resume after they are done. In which way, we can get rid of a noticeable
glitch during the transition.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

12:58 PM Changeset in webkit [132686] by commit-queue@webkit.org
  • 3 edits
    1 copy in trunk/Source/Platform

[chromium] Add additional memory management fields to WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=99703

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-10-26
Reviewed by James Robinson.

Add new fields to WebGraphicsMemoryAllocation to allow for specifying
limits for when visible and not, and to allow for specifying priority
cutoffs (e.g, to allow specifying that backgrounded tabs should
retain only their visible textures).

Add sendManagedMemoryStatsCHROMIUM to WebGraphicsContext3D, and
add WebGraphicsManagedMemoryStats structure, to allow the GPU memory
manager to make more informed choices.

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::sendManagedMemoryStatsCHROMIUM):

  • chromium/public/WebGraphicsMemoryAllocation.h:

(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):
(WebKit):
(WebGraphicsManagedMemoryStats):
(WebKit::WebGraphicsManagedMemoryStats::WebGraphicsManagedMemoryStats):

12:57 PM Changeset in webkit [132685] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[CSS Exclusions] Block children have incorrect offset when shape-inside element lays out below other elements
https://bugs.webkit.org/show_bug.cgi?id=98189

Patch by Bear Travis <betravis@adobe.com> on 2012-10-26
Reviewed by Dirk Schulze.

Source/WebCore:

The initial code assumed that each block created a new layout state, such that
LayoutState::layoutOffset would be specific to each block child of a shape-inside.
Typically, however, block children of a shape-inside do not create a new layout state,
and therefore we use the current element's offset instead.

Test: fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified to use only logicalTop
rather than LayoutState::layoutOffset::width/height and logicalTop.

LayoutTests:

Test that block content in subsequent shape-insides lays out correctly. Introducing a script
that can eventually be used to simplify the rectangle cases.

  • fast/exclusions/resources/simple-rectangle.js: Added.

(createRectangleTest): Generate a shape-inside rectangle test using the given parameters.
(createRectangleTestResult): Generate a shape-inside rectangle expected result using
the given parameters.

  • fast/exclusions/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-subsequent-blocks.html: Added.
12:28 PM Changeset in webkit [132684] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Remove setRenderStyle in favor of callbacks on HTMLOptionElement and HTMLOptGroupElement
https://bugs.webkit.org/show_bug.cgi?id=100397

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-26
Reviewed by Ojan Vafai.

Use Node custom callbacks to support the non-renderer style caching for option
and optgroup eliminating the need for setRenderStyle.

setRenderStyle only existed to support HTMLOptionElement and HTMLOptGroupElement
so they could store their RenderStyle even though they have no renderer. This
means all style setting went through the virtual call to setRenderStyle, and it
also hid the if statement protecting against null renderers meaning we end up
checking if the renderer is null repeatedly in recalcStyle. This refactor cleans
up recalcStyle to be more clear about what's going on.

No new tests needed, this is just a refactor.

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):
(WebCore::Element::recalcStyle):

  • dom/Node.cpp:

(WebCore::Node::createRenderer):
(WebCore::Node::setRenderStyle):

Removed this method because it was only here to support HTMLOptionElement
and HTMLOptGroupElement. Instead we can use node custom callbacks.

  • dom/Node.h:

(WebCore::Node::nonRendererStyle): Renamed from nonRendererRenderStyle to match other style methods.

  • dom/NodeRenderStyle.h:

(WebCore::Node::renderStyle):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptGroupElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptGroupElement::nonRendererStyle):
(WebCore::HTMLOptGroupElement::customStyleForRenderer):

  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::attach): Reorder the logic to avoid calling styleForRenderer twice.
(WebCore::HTMLOptionElement::updateNonRenderStyle): Updates the cached non-renderer style.
(WebCore::HTMLOptionElement::nonRendererStyle):
(WebCore::HTMLOptionElement::customStyleForRenderer):
(WebCore::HTMLOptionElement::didRecalcStyle): Requests the repaint of the select like setRenderStyle used to.

  • html/HTMLOptionElement.h:
12:15 PM Changeset in webkit [132683] by danakj@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Add implicit conversions between WebFloatPoint and gfx::PointF
https://bugs.webkit.org/show_bug.cgi?id=100435

Reviewed by James Robinson.

This is similar to other Web geometry types, but the WebFloatPoint is
missing it.

  • chromium/public/WebFloatPoint.h:

(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator gfx::PointF):

12:06 PM Changeset in webkit [132682] by krit@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-clip-path property should just reference clipPath
https://bugs.webkit.org/show_bug.cgi?id=100531

Reviewed by Eric Seidel.

Source/WebCore:

The -webkit-clip-path property should just reference clipPath. Added a check for that.

Test: css3/masking/clip-path-reference-of-fake-clipPath.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Check that anther SVG resource like mask can not be referenced as clipPath.

  • css3/masking/clip-path-reference-of-fake-clipPath-expected.txt: Added.
  • css3/masking/clip-path-reference-of-fake-clipPath.html: Added.
11:51 AM Changeset in webkit [132681] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove the circular reference between TextTrack and TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=100300

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-26
Reviewed by Eric Carlson.

Changed TextTrackCue.m_track to a normal pointer to break the circular
reference that was keeping both objects from ever getting deleted.

No new tests. This simply fixes a memory leak.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::~TextTrack):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::~TextTrackCue):
(WebCore::TextTrackCue::track):
(WebCore::TextTrackCue::setTrack):

  • html/track/TextTrackCue.h:

(TextTrackCue):

11:47 AM Changeset in webkit [132680] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Breakpoints are not managed correctly when editing uiSourceCode that was bound to ScriptFile after JavaScriptSourceFrame creation.
https://bugs.webkit.org/show_bug.cgi?id=100535

Reviewed by Pavel Feldman.

Added SourceMappingChanged event to UISourceCode and made
JavaScriptSourceFrame update ScriptFile events listeners on it.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onSourceMappingChanged):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.setSourceMapping):

11:44 AM Changeset in webkit [132679] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

Build bot gives incorrect link to EWS build failure
https://bugs.webkit.org/show_bug.cgi?id=100436

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.init):
(MockCommitQueue.command_failed): Return incremental failure_status_id
(CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.

11:41 AM Changeset in webkit [132678] by rakuco@webkit.org
  • 10 edits in trunk

webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602

Reviewed by Dirk Pranke.

Tools:

Unify all the different `Listen' directives present in the several
httpd.conf files we have in LayoutTests/http/conf. For one, we
were already passing `Listen 127.0.0.1:8000' via webkitpy before,
and opening the other ports from the conf files.

The configuration files differed mostly in the way they handled
IPV6 ports. Some of them did not listen to IPV6 ports because the
systems which used them sometimes did not have IPV6 support. The
`http_server_supports_ipv6' method has been added to Port to
address that. cygwin, on its turn, still seems to use Apache 1.3,
which does not support IPV6 at all; the newly-added method has a
special case for that. Plus, perform a socket.getaddrinfo() call
the same way Apache itself does so we are sure we only enable IPV6
when setting that up in the httpd server is not going to fail.

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_version_dir):
(Port.to.start_websocket_server):
(Port.to):
(Port.to.http_server_supports_ipv6):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_http_server_supports_ipv6):
(PortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd):
(LayoutTestApacheHttpd.init):

LayoutTests:

  • http/conf/apache2-debian-httpd.conf: Remove the `Listen'

directive and related comments, it is passed to httpd by webkitpy
now.

  • http/conf/apache2-httpd.conf: Ditto.
  • http/conf/cygwin-httpd.conf: Ditto.
  • http/conf/fedora-httpd.conf: Ditto.
11:18 AM Changeset in webkit [132677] by Dave Barton
  • 2 edits in trunk/Tools

Unreviewed. Update my IRC nickname to a registered one.

  • Scripts/webkitpy/common/config/committers.py:
10:52 AM Changeset in webkit [132676] by kareng@chromium.org
  • 1 edit
    2 copies in branches/chromium/1271

Merge 131315 - Calling WebCore::SharedBuffer::append(data, 0) on a shared buffer when
its current position is at a segment boundary (4096) ends up adding an
unitialized segment (with uninitialized memory) to the SharedBuffer.
https://bugs.webkit.org/show_bug.cgi?id=99000

Reviewed by Adam Barth.

Source/WebCore:

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):

LayoutTests:

  • mhtml/shared_buffer_bug-expected.txt: Added.
  • mhtml/shared_buffer_bug.mht: Added.

TBR=jcivelli@chromium.org
Review URL: https://codereview.chromium.org/11316005

10:49 AM WebKit Team edited by Dave Barton
(diff)
10:49 AM Changeset in webkit [132675] by scheib@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r132644.
http://trac.webkit.org/changeset/132644
https://bugs.webkit.org/show_bug.cgi?id=100497

Causes webkit_unit_tests
MemoryInstrumentationTest.ImageObserver to fail.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsage):

  • platform/network/ResourceRequestBase.h:

(ResourceRequestBase):

  • platform/network/chromium/ResourceRequest.cpp:
  • platform/network/chromium/ResourceRequest.h:
10:30 AM Changeset in webkit [132674] by Lucas Forschler
  • 8 edits in tags/Safari-537.16/Source/JavaScriptCore

Merge fix for <rdar://problem/12551946>

10:30 AM Changeset in webkit [132673] by Simon Fraser
  • 12 edits
    8 copies
    2 moves
    2 adds
    2 deletes in trunk/LayoutTests

compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

Reviewed by Dan Bernstein.

In r131009 I fixed layerTreeAsText() to not be flakey with tiled layers, by ensuring that
we flush layer state before dumping the layer tree. That makes these tests non-flakey. I was
also able to remove all the setTimeouts() from these tests.

The 'usingTiledLayer' property is only dumped on Mac, so made cross-platform results without
this flag, and added Mac-specific results with it.

Unskipped some tests on non-Mac platforms that should now pass.

  • compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child.html: Added.
  • compositing/tiling/huge-layer-add-remove-child.html-disabled: Removed.
  • compositing/tiling/huge-layer-expected.txt:
  • compositing/tiling/huge-layer-img-expected.txt:
  • compositing/tiling/huge-layer-img.html: Renamed from LayoutTests/compositing/tiling/huge-layer-img.html-disabled.
  • compositing/tiling/huge-layer-resize-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize.html: Added.
  • compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Removed.
  • compositing/tiling/huge-layer-with-layer-children.html: Renamed from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html-disabled.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Copied from LayoutTests/compositing/tiling/backface-preserve-3d-tiled-expected.txt.
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Copied from LayoutTests/compositing/tiling/crash-reparent-tiled-layer-expected.txt.
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child-expected.txt.
  • platform/mac/compositing/tiling/huge-layer-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-expected.txt.
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.txt.
  • platform/mac/compositing/tiling/huge-layer-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-resize-expected.txt.
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-expected.txt.
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
  • platform/qt-5.0-wk2/TestExpectations:
10:30 AM Changeset in webkit [132672] by thakis@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Enable fast/images/exif-orientation.html
https://bugs.webkit.org/show_bug.cgi?id=100534

Unreviewed, TestExpecations change.

The baselines for this test landed yesterday.

  • platform/chromium/TestExpectations:
10:19 AM Changeset in webkit [132671] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] MiniBrowser segfaults on exit after using WebGL.
https://bugs.webkit.org/show_bug.cgi?id=100523

The display connection must not be closed before
destroying the offscreen window.
Therefore opening the connection is moved to the
getXWindow() function. And closing the connection
is being moved to the destructor of the offscreen window.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::getXWindow):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::display):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):

9:31 AM Changeset in webkit [132670] by zoltan@webkit.org
  • 2 edits
    4 moves
    3 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #5
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #5 commit of the whole patch.

  • PageLoad/svg/files/Harvey_Rayner.svg: Removed.
  • PageLoad/svg/files/Sierpinski_carpet_6.svg: Removed.
  • PageLoad/svg/files/mtsthelens.svg: Removed.
  • PageLoad/svg/files/mtsthelens0.jpg: Removed.
  • SVG/HarveyRayner.html: Added.
  • SVG/MtSaintHelens.html: Added.
  • SVG/SierpinskiCarpet.html: Added.
  • SVG/resources/HarveyRayner.svg: Copied from PerformanceTests/PageLoad/svg/files/Harvey_Rayner.svg.
  • SVG/resources/MtSaintHelens.svg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens.svg.
  • SVG/resources/SierpinskiCarpet.svg: Copied from PerformanceTests/PageLoad/svg/files/Sierpinski_carpet_6.svg.
  • SVG/resources/mtsthelens0.jpg: Copied from PerformanceTests/PageLoad/svg/files/mtsthelens0.jpg.
  • Skipped: Rename the files on the skipped list also.
9:25 AM Changeset in webkit [132669] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100529

Patch by Parth Patel <parpatel@rim.com> on 2012-10-26
Reviewed by Yong Li.

No new tests added as there was no behavioural change.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore):

  • platform/network/blackberry/NetworkManager.h:

(NetworkManager):

9:12 AM Changeset in webkit [132668] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix log-type icon alignment.
https://bugs.webkit.org/show_bug.cgi?id=100520

Reviewed by Yury Semikhatsky.

The icons are just a pixel or two off, and it's driving me nuts.

  • inspector/front-end/inspector.css:

(.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before):
(.console-warning-level::before):

9:09 AM Changeset in webkit [132667] by arv@chromium.org
  • 11 edits in trunk/Source/WebCore

Replaceable attributes should also have readonly
https://bugs.webkit.org/show_bug.cgi?id=91768

Reviewed by Adam Barth.

This updates the code generators for JSC and V8 to handle this case correctly.

  • Modules/intents/DOMWindowIntents.idl:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
8:58 AM Changeset in webkit [132666] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Clear m_orientation in FrameData::clear() for skia
https://bugs.webkit.org/show_bug.cgi?id=100456

Reviewed by Stephen White.

clear() is only called by the FrameData destructor and for multi-image
images in BitmapImage::destroyDecodedData(). Multi-frame images don't
have exif data, so this patch should have no effect in practice. It
makes the skia code match the CG code in BitmapImageCG.cpp though.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::FrameData::clear):

8:57 AM Changeset in webkit [132665] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

Crash on loading SVG filter resource on HTML element
https://bugs.webkit.org/show_bug.cgi?id=100491

Reviewed by Dirk Schulze.

Source/WebCore:

Skip non-filter elements referenced via -webkit-filter.

Test: svg/filters/filter-reference-crash.html

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):

LayoutTests:

  • svg/filters/filter-reference-crash-expected.txt: Added.
  • svg/filters/filter-reference-crash.html: Added.
8:49 AM Changeset in webkit [132664] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Lots of time spent under DNSResolveQueue::platformProxyIsEnabledInSystemPreferences
https://bugs.webkit.org/show_bug.cgi?id=100514

Reviewed by Anders Carlsson.

DNSResolveQueue::platformProxyIsEnabledInSystemPreferences gets called for every link in
the document. The function is relatively slow.

This patch caches the result of the last check for 5 seconds. Based on code comments
prefetching is disabled with proxies due to regressing performance with some configurations.
Proxy status changes rarely and a slight reaction delay shoudn't cause practical problems.

  • platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::DNSResolveQueue):

Add constructor. Also fixes a bug, m_requestsInFlight was not initialized.


(WebCore):
(WebCore::DNSResolveQueue::isUsingProxy):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::fired):

  • platform/network/DNSResolveQueue.h:

(DNSResolveQueue):

8:42 AM Changeset in webkit [132663] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r132662.
http://trac.webkit.org/changeset/132662
https://bugs.webkit.org/show_bug.cgi?id=100528

It is not necessary any more. (Requested by loislo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • platform/qt/MemoryUsageSupportQt.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

8:36 AM Changeset in webkit [132662] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt builders.

  • platform/qt/MemoryUsageSupportQt.cpp:
8:33 AM Changeset in webkit [132661] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r132658.
http://trac.webkit.org/changeset/132658
https://bugs.webkit.org/show_bug.cgi?id=100515

It broke the Qt build

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::addPlatformComponentsInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):

  • platform/MemoryUsageSupport.h:

(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):
(MemoryUsageSupport):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

  • platform/PlatformMemoryInstrumentation.h:

(PlatformMemoryTypes):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):

8:21 AM Changeset in webkit [132660] by Csaba Osztrogonác
  • 37 deletes in trunk/LayoutTests/platform/qt-5.0-wk2

Unreviewed. Remove empty buggy directories.

8:13 AM Changeset in webkit [132659] by vsevik@chromium.org
  • 27 edits in trunk/Source/WebCore

Web Inspector: Some context menu items are duplicated on Resources and Sources panels.
https://bugs.webkit.org/show_bug.cgi?id=100522

Reviewed by Pavel Feldman.

Method appendApplicableItems now receives event as a parameter.
HandlerRegistry now makes sure that it is not called more than once for certain context menu event.

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.Placard.prototype._placardContextMenu):

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextMenu):
(WebInspector.ContextMenu.prototype.show):
(WebInspector.ContextMenu.prototype.appendApplicableItems):
(WebInspector.ContextMenu.Provider.prototype.appendApplicableItems):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._contextMenu):

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._contextMenuInDataTable):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._contextMenu):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):

  • inspector/front-end/HandlerRegistry.js:

(WebInspector.HandlerRegistry.prototype.appendApplicableItems):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._contextMenu):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.handleContextMenu):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

  • inspector/front-end/NetworkPanelDescriptor.js:

(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.appendApplicableItems):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._tabContextMenu):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._contextMenu):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._emptyElementContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):

8:07 AM Changeset in webkit [132658] by loislo@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: instrument chromium GlyphCache. It keeps ~2mb data on gmail.
https://bugs.webkit.org/show_bug.cgi?id=100515

Reviewed by Yury Semikhatsky.

I replaced old version with an abstract number with new one which precisely reports allocated SkGlyphCache objects and their sizes.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::reportMemoryUsage):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

  • platform/PlatformMemoryInstrumentation.h:

(PlatformMemoryTypes):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(reportMemoryUsage):
(WebCore::reportGlyphCache):
(WebCore):
(WebCore::MemoryUsageSupport::reportMemoryUsage):

7:58 AM Changeset in webkit [132657] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Get rid of C'ism in text checker API
https://bugs.webkit.org/show_bug.cgi?id=100513

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Make Ewk_Text_Checker a C++ class and move the
WebKitTextChecker code to this new class. This
gets rid of the C'ism in the text checker code
and make it consistent with other Ewk classes.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):

  • UIProcess/API/efl/ewk_settings.cpp:

(spellCheckingLanguagesSetUpdate):
(ewk_settings_continuous_spell_checking_enabled_set):
(ewk_settings_spell_checking_available_languages_get):
(ewk_settings_spell_checking_languages_get):

  • UIProcess/API/efl/ewk_text_checker.cpp:

(ClientCallbacks):
(textCheckerEnchant):
(clientCallbacks):
(isContinuousSpellCheckingEnabled):
(setContinuousSpellCheckingEnabled):
(uniqueSpellDocumentTag):
(closeSpellDocumentWithTag):
(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):
(Ewk_Text_Checker):
(Ewk_Text_Checker::availableSpellCheckingLanguages):
(Ewk_Text_Checker::updateSpellCheckingLanguages):
(Ewk_Text_Checker::loadedSpellCheckingLanguages):
(Ewk_Text_Checker::initialize):

  • UIProcess/API/efl/ewk_text_checker_private.h:

(Ewk_Text_Checker):

  • UIProcess/efl/WebKitTextChecker.cpp: Removed.
  • UIProcess/efl/WebKitTextChecker.h: Removed.
7:58 AM Changeset in webkit [132656] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Build fix for r132650.
https://bugs.webkit.org/show_bug.cgi?id=100482

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::timeFormat):

7:49 AM Changeset in webkit [132655] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[v8] Memory instrumentation: don't count memory of WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=100517

Reviewed by Alexander Pavlov.

  • bindings/v8/V8PerIsolateData.cpp: when estimating bindings memory size skip

pointers to WrapperTypeInfo objects as they are static fields and belong to
the data segment.
(WTF):

7:43 AM Changeset in webkit [132654] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[WK2] should enable two postredirect tests
https://bugs.webkit.org/show_bug.cgi?id=100508

Unreviewed gardening.

The EFL results for these tests seem to have been wrong from the beginning.
Update expected results, enable tests for WK2 (based on comment in
TestExpectations these were skipped because efl failed).

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-26

  • platform/efl/http/tests/navigation/postredirect-basic-expected.png:
  • platform/efl/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.png:
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/wk2/TestExpectations:
7:30 AM Changeset in webkit [132653] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
https://bugs.webkit.org/show_bug.cgi?id=100504

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-26
Reviewed by Yong Li.

PR #232038 The similar PR # 200724.
Reviewed internally by Petter Wang.

This issue is same as bug 95492, and this patch is same as its patch.
Hold the JSLock for the current thread before we call toRef to avoid
the ASSERT failure.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

7:26 AM Changeset in webkit [132652] by Lucas Forschler
  • 1 copy in tags/Safari-537.16

New Tag.

7:25 AM Changeset in webkit [132651] by Lucas Forschler
  • 1 delete in tags/Safari-537.16

Remove Tag.

7:22 AM Changeset in webkit [132650] by tkent@chromium.org
  • 10 edits in trunk/Source/WebCore

Refactor Localizer-related classes.
https://bugs.webkit.org/show_bug.cgi?id=100482

Reviewed by Kentaro Hara.

  • Localizer has unused code Localizer should have function implementations only if they are used in multiple subclasses.
  • Some Localizer subclasses hide Localizer data members
  • Should use String::isNull to check initialization-or-not

No new tests. This should not change any behavior.

  • platform/text/Localizer.h:

(Localizer):

  • timeFormat, shortTimeFormat, and timeAMPMLabels should be pure virtual.
  • Remove m_localizedDateFormatText, m_localizedShortTimeFormatText, and m_timeAMPMLabels
  • platform/text/Localizer.cpp:

Remove implementations of timeFormat, shortTimeFormat, and timeAMPMLabels.

  • platform/text/LocaleICU.h:

(LocaleICU): Introduce m_timeFormatWithSeconds and m_timeFormatWithoutSeconds.

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat):
Use new data members instead of Localizer data members.
(WebCore::LocaleICU::dateFormat): Use isNull.

  • platform/text/LocaleNone.cpp:

(LocaleNone): Add timeFormat, shortTimeFormat, timeAMPMLabels
implementations, and m_timeAMPMLabels.
(WebCore::LocaleNone::timeFormat): Returns the HTML time format.
(WebCore::LocaleNone::shortTimeFormat): Returns the HTML time format.
(WebCore::LocaleNone::timeAMPMLabels): Returns "AM" and "PM".

  • platform/text/LocaleWin.h:

(LocaleWin): Add m_timeFormatWithSeconds.

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::dateFormat): Use isNull.
(WebCore::LocaleWin::timeFormat): Use m_timeFormatWithSeconds.

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Rename m_localized*TimeFormatText to m_timeFormatWith*Seconds.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::timeFormat): Follow the renaming.
(WebCore::LocaleMac::shortTimeFormat): Ditto.

7:19 AM Changeset in webkit [132649] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip a few tests which produce wrong pixel expectations.

  • platform/efl/TestExpectations:
7:07 AM Changeset in webkit [132648] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Crash in PagePopupController by events after WebPagePopupImpl::closePopup
https://bugs.webkit.org/show_bug.cgi?id=100454

Reviewed by Hajime Morita.

No new tests. The bug is timing-dependent.

  • page/DOMWindowPagePopup.cpp:

(WebCore::DOMWindowPagePopup::~DOMWindowPagePopup):
Calls clearPagePopupClient for the associalated PagePopupController object.

  • page/PagePopupController.cpp:

(WebCore::PagePopupController::setValueAndClosePopup):
Do nothing if m_popupClient is 0.
(WebCore::PagePopupController::localizeNumberString): Ditto.
(WebCore::PagePopupController::clearPagePopupClient): Added.

  • page/PagePopupController.h:

(PagePopupController): Declare clearPagePopupClient.

6:43 AM Changeset in webkit [132647] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Clean up construction/destruction code in Ewk_view
https://bugs.webkit.org/show_bug.cgi?id=100232

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Simplified a lot of initialization and destruction code of Ewk_view and EwkViewImpl
put all the impl stuff to its constructor and destructor, also made EwkViewImpl member
variables private.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(pageViewMap):
(EwkViewImpl::addToPageViewMap):
(EwkViewImpl::removeFromPageViewMap):
(EwkViewImpl::viewFromPageViewMap):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::wkPage):
(EwkViewImpl::title):
(EwkViewImpl::setThemePath):
(EwkViewImpl::customTextEncodingName):
(EwkViewImpl::setCustomTextEncodingName):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informWebProcessCrashed):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::onFaviconChanged):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):
(EwkViewImpl::ewkContext):
(EwkViewImpl::backForwardList):

  • UIProcess/API/efl/ewk_settings.cpp:

(Ewk_Settings::preferences):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(createEwkViewSmartClass):
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_url_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_feed_touch_event):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

6:32 AM Changeset in webkit [132646] by rakuco@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[EFL] Add custom expectation for test added in r131557.

  • platform/efl/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
6:27 AM Changeset in webkit [132645] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Bring device geolocation and orientation emulation from behind the experiment
https://bugs.webkit.org/show_bug.cgi?id=100220

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab):

6:20 AM Changeset in webkit [132644] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497

Reviewed by Alexander Pavlov.

Added memory reporting method to Chromium implementation of ResourceRequest.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsageBase): Renamed reportMemoryUsage
on ResourceRequestBase to reportMemoryUsageBase and made it protected. I'd
rather make ResourceRequestBase::reportMemoryUsage virtual and override it
in the descendant but ResourceRequestBase doesn't have any virtual methods
and shouldn't be used directly (ResourceRequest should be used instead).

  • platform/network/ResourceRequestBase.h:

(ResourceRequestBase):

  • platform/network/chromium/ResourceRequest.cpp:

(WebCore::ResourceRequest::reportMemoryUsage):
(WebCore):

  • platform/network/chromium/ResourceRequest.h:

(ResourceRequest):

6:17 AM Changeset in webkit [132643] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Initialize Ewk_Context class members in initialization list
https://bugs.webkit.org/show_bug.cgi?id=100503

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Move Ewk_Context class members initialization from the
constructor body to the initialization list for
efficiency.

  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):

6:14 AM Changeset in webkit [132642] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove the on-hover highlighting of console messages
https://bugs.webkit.org/show_bug.cgi?id=100511

Reviewed by Pavel Feldman.

This clashes with the hovered element highlight in console messages.

  • inspector/front-end/inspector.css:

(ol.watch-expressions > li.hovered):

6:13 AM Changeset in webkit [132641] by commit-queue@webkit.org
  • 7 edits
    4 deletes in trunk

Unreviewed, rolling out r132612.
http://trac.webkit.org/changeset/132612
https://bugs.webkit.org/show_bug.cgi?id=100512

Crashes fast/events/tabindex-focus-blur-all.html in debug mode
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

Source/WebCore:

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::computePreferredLogicalWidths):

  • rendering/RenderTableCol.h:

(RenderTableCol):

LayoutTests:

  • fast/table/col-span-change-relayout-expected.txt: Removed.
  • fast/table/col-span-change-relayout.html: Removed.
  • fast/table/simplified-layout-table-expected.html: Removed.
  • fast/table/simplified-layout-table.html: Removed.
5:55 AM Changeset in webkit [132640] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebKit2

LayerTreeCoordinator: Make sure that dependent layers are deleted before their directly composited image
https://bugs.webkit.org/show_bug.cgi?id=100495

Reviewed by Kenneth Rohde Christiansen.

Since r128980 layers removals are delayed until we flush the layer tree.
This causes a crash if such a layer had a directly composited image since
the image is now deleted while the layer is still active in the UI process
and tries to access a deleted backing store.

Fix it by delaying the directly composited image removal as well.

Fixes a crash in tst_QQuickWebView::basicRenderingSanity since showWebView is
called first and loads direct-image-compositing.html.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer): Remove unused variable.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

5:55 AM Changeset in webkit [132639] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fast return upon setting the same dock side.
https://bugs.webkit.org/show_bug.cgi?id=100510

Reviewed by Vsevolod Vlasov.

Added fast return.

  • inspector/front-end/DockController.js:
5:54 AM Changeset in webkit [132638] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed Apple Win gardening.

  • platform/win/TestExpectations: Skipping XHR timeout tests.
5:48 AM Changeset in webkit [132637] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

German de.po translation needs update
https://bugs.webkit.org/show_bug.cgi?id=91349

Patch by Christian Kirbach <Christian.Kirbach@gmail.com> on 2012-10-26
Rubber-stamped by Gustavo Noronha.

  • de.po: updated with proof-read version.
5:48 AM Changeset in webkit [132636] by commit-queue@webkit.org
  • 8 edits in trunk

[Qt] Fix the LLInt build on Windows
https://bugs.webkit.org/show_bug.cgi?id=97648

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

The main change for the port on Windows is changing the way offsets are extracted
and the LLIntAssembly.h is generated to accomodate release and debug configurations.

Firstly the LLIntOffsetsExtractor binary is now built as-is (no DESTDIR set) and
placed into debug\LLIntOffsetsExtractor.exe and release\LLIntOffsetsExtractor.exe
on Windows debug_and_release builds. On other patforms it remainds in the regular
out directory.

Secondly the LLIntAssembly.h files must be different for different build types,
so the LLIntAssembly.h generator in DerivedSources.pri operates no on the extractor
binary files as input. Using a simple exists() check we verify the presence of either
a regular, a debug\LLIntOffsetsExtractor and a release\LLIntOffsetsExtractor binary
and process all of them. The resulting assembly files consequently end up in
generated\debug\LLIntAssembly.h and generated\release\LLIntAssembly.h.

In Target.pri we have to also make sure that those directories are in the include
path according to the release or debug configuration.

Lastly a small tweak - swapping WTF.pri and JSC.pri inclusions - in the
LLIntOffsetsExtractor build was needed to make sure that we include
JavaScriptCore/config.h instead of WTF/config.h, required to fix the
build issues originally pasted in bug #97648.

  • DerivedSources.pri:
  • JavaScriptCore.pro:
  • LLIntOffsetsExtractor.pro:
  • Target.pri:

Tools:

Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
executable programs on Windows. Empty otherwise. Also added support for force_build_all
to allow overriding us disabling build_all for TEMPLATE = app.

  • qmake/mkspecs/features/default_pre.prf:
5:40 AM Changeset in webkit [132635] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Removing bogus '#EOF\n' data in the listed PNG file that's
positioned after the IEND PNG chunk.

  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
5:38 AM Changeset in webkit [132634] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Unreviewed trivial build fix: It's glXGetCurrentContext not glxGetCurrentContext :)

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

5:27 AM Changeset in webkit [132633] by kenneth@webkit.org
  • 3 edits
    2 adds in trunk

Printing should use use high resolution images when available
https://bugs.webkit.org/show_bug.cgi?id=100488

Reviewed by Antti Koivisto.

The images loaded using -webkit-device-pixel-ratio depends on
the display type (deviceScaleFactor) and thus affects which
images are being used for printing. Printing should always
use the higher resolution images (aka 'retina' images).

Source/WebCore:

Test: fast/media/mq-pixel-ratio-print.html

  • css/MediaQueryEvaluator.cpp:

(WebCore::device_pixel_ratioMediaFeatureEval):

LayoutTests:

Added a test testing -webkit-device-pixel-ratio media query
in conjuntion with 'print' media type.

  • fast/media/mq-pixel-ratio-print-expected.txt: Added.
  • fast/media/mq-pixel-ratio-print.html: Added.
5:25 AM Changeset in webkit [132632] by loislo@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: NMI instrument InspectorResourceAgent. it caches resources for the front-end.
https://bugs.webkit.org/show_bug.cgi?id=100496

Reviewed by Yury Semikhatsky.

It is plain instrumentation for InspectorResourceAgent and NetworkResourceData which is used by the agent.

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::reportMemoryUsage):
(WebCore):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/NetworkResourcesData.cpp:

(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):

  • inspector/NetworkResourcesData.h:

(XHRReplayData):
(ResourceData):
(NetworkResourcesData):

5:25 AM Changeset in webkit [132631] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] ... And another pixel rebaseline after r131941 and r131991.

  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:
5:24 AM Changeset in webkit [132630] by dominik.rottsches@intel.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r132493.
http://trac.webkit.org/changeset/132493
https://bugs.webkit.org/show_bug.cgi?id=100509

It didn't fix the tests on the bot as we had hoped. (Requested
by drott on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):

5:19 AM Changeset in webkit [132629] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Temporarily disable use of QXcbNativeInterface in GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100493

Once QXcbNativeInterface::nativeResourceForContext() can provide the
GLXContext for an existing QOpenGLContext, this patch shall be reverted.

Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Simon Hausmann.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

5:19 AM Changeset in webkit [132628] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Remove QOpenGL specific code from GraphicsSurfaceGLX.
https://bugs.webkit.org/show_bug.cgi?id=100492

This patch removes most of the QOpenGLContext related code
from GraphicsSurfaceGLX. This allows sharing almost all
GraphicsSurfaceGLX code with EFL, by relying on pure GLX.

Patch by Zeno Albisser <zeno@webkit.org> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):

5:18 AM Changeset in webkit [132627] by Simon Hausmann
  • 13 edits in trunk

[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652

Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.

.:

Use Graphics Surface to enable WebGL for WebKit2 EFL.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.

No new tests. Covered by existing tests.

  • PlatformEfl.cmake:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):

  • platform/graphics/surfaces/efl: Added.
  • platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.

(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.

(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):

Source/WebKit2:

Set WebGLEnabled to true when WebGL is enabled.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize):

5:16 AM Changeset in webkit [132626] by pfeldman@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Not reviewed: chromium baselines for selection-after-remove updated.

  • platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
  • platform/chromium-win/fast/repaint/selection-after-remove-expected.png:
5:05 AM Changeset in webkit [132625] by kbalazs@webkit.org
  • 1 edit
    27 deletes in trunk/LayoutTests

Unreviewed, rolling out r132607.
http://trac.webkit.org/changeset/132607
https://bugs.webkit.org/show_bug.cgi?id=100502

"SOS! More wrong paths." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Removed.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Removed.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Removed.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Removed.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Removed.
4:58 AM Changeset in webkit [132624] by kbalazs@webkit.org
  • 1 edit
    74 deletes in trunk/LayoutTests

Unreviewed, rolling out r132604.
http://trac.webkit.org/changeset/132604
https://bugs.webkit.org/show_bug.cgi?id=100501

"SOS! Wrong paths." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Removed.
  • platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Removed.
  • platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Removed.
  • platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Removed.
4:55 AM Changeset in webkit [132623] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Overrides] Do not persist the User Agent "master switch"
https://bugs.webkit.org/show_bug.cgi?id=100484

Reviewed by Yury Semikhatsky.

The User Agent override state is managed in the front-end, just like for other override-able parameters.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::disable):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement):

  • inspector/front-end/UserAgentSupport.js:

(WebInspector.UserAgentSupport):
(WebInspector.UserAgentSupport.prototype.toggleUserAgentOverride):
(WebInspector.UserAgentSupport.prototype._userAgentChanged):

4:53 AM Changeset in webkit [132622] by rakuco@webkit.org
  • 11 edits
    1 add in trunk/LayoutTests

[EFL] More pixel rebaselines after r131941 and r131991.

  • platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
  • platform/efl/fast/dynamic/containing-block-change-expected.png:
  • platform/efl/fast/forms/listbox-clip-expected.png:
  • platform/efl/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/efl/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
  • platform/efl/fast/layers/inline-dirty-z-order-lists-expected.png:
  • platform/efl/fast/layers/layer-content-visibility-change-expected.png:
  • platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.png:
  • platform/efl/fast/reflections/inline-crash-expected.png:
  • platform/efl/fast/replaced/width100percent-textarea-expected.png:
  • platform/efl/fast/text/font-initial-expected.png:
4:42 AM Changeset in webkit [132621] by tasak@google.com
  • 8 edits
    2 adds in trunk

[Shadow]: removing styles in shadow dom subtree causes crash.
https://bugs.webkit.org/show_bug.cgi?id=100455

Reviewed by Hajime Morita.

Source/WebCore:

To quickly check whether shadow roots or elements have any scoped
styles or not, elements have hasStyleScoped flag. If elements have
any scoped styles, the styles are direct children of the element.
The original code just sees how many chilren are scoped style or not.
However styles in shadow dom subtree are registered with the shadow
root but are not always direct children of shadow roots. So to check
whether shadow roots have any scoped styles, modified to count
number of styles registered with the shadow root.

Test: fast/dom/shadow/remove-styles-in-shadow-crash.html

  • dom/Node.cpp:

(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
Made the above two method virtual. class ShadowRoot overrides these
methods.
(WebCore::Node::numberOfScopedHTMLStyleChildren):
Moved HTMLStyleElement.cpp to Node.cpp, because the above two methods
are moved into Node.cpp.

  • dom/Node.h:

(Node):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::registerScopedHTMLStyleChild):
(WebCore::ShadowRoot::unregisterScopedHTMLStyleChild):
Modify to count how many styles are registered with the shadow root.
The "counting" is done when styles are registered and unregistered
with the shadow root, i.e. style element is inserted into document or
removed from document. When unregister some style, there are no more
styles registered with the shadow root. Set style scoped flag false.

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/HTMLStyleElement.cpp:
  • html/HTMLStyleElement.h:

(WebCore::HTMLStyleElement::isRegisteredAsScoped):
Now isRegisteredAsScoped is used in Node.cpp, so removed inline and
moved .cpp to .h.

LayoutTests:

  • fast/dom/shadow/remove-styles-in-shadow-crash-expected.txt: Added.
  • fast/dom/shadow/remove-styles-in-shadow-crash.html: Added.
4:40 AM Changeset in webkit [132620] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r132589.
http://trac.webkit.org/changeset/132589
https://bugs.webkit.org/show_bug.cgi?id=100498

Breaks font-face layout tests (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

4:39 AM Changeset in webkit [132619] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=100481

Unreviewed EFL gardening.

Skip failing test and also unskip tests that are
consistently passing.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-26

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
4:33 AM Changeset in webkit [132618] by tasak@google.com
  • 15 edits
    2 adds in trunk

[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Reviewed by Hajime Morita.

Source/WebCore:

Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit

Test: fast/dom/shadow/athost-atrules.html

  • css/CSSGrammar.y.in:

Added rules for parsing @host @-rules.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):

  • css/CSSParser.h:

Added a declaration of the above new method: createHostRule.

  • css/CSSPropertySourceData.h:

Added HOST_RULE to enum Type.

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.

  • css/RuleSet.h:

(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):

  • css/StyleRule.h:

(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h:

(WebCore):
(StyleScopeResolver):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

  • fast/dom/shadow/athost-atrules-expected.txt: Added.
  • fast/dom/shadow/athost-atrules.html: Added.
4:32 AM Changeset in webkit [132617] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk/Source/WebKit2

[EFL][WK2] Add Ewk_Color_Picker API
https://bugs.webkit.org/show_bug.cgi?id=100472

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Move the color picker code out of EwkViewImpl and into
a new Ewk_Color_Picker class to avoid cluttering the
view code.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_color_picker.cpp: Added.

(Ewk_Color_Picker::Ewk_Color_Picker):
(Ewk_Color_Picker::setColor):
(Ewk_Color_Picker::color):
(ewk_color_picker_color_set):
(ewk_color_picker_color_get):

  • UIProcess/API/efl/ewk_color_picker.h: Added.
  • UIProcess/API/efl/ewk_color_picker_private.h: Added.

(Ewk_Color_Picker):
(Ewk_Color_Picker::create):

  • UIProcess/API/efl/ewk_view.cpp:
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_color_picker.cpp: Added.

(onColorPickerDone):
(setColorPickerColor):
(showColorPicker):
(hideColorPicker):
(hideColorPickerByRemovingElement):
(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:
  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::showColorPicker):

4:26 AM Changeset in webkit [132616] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix test pixel expectation.

  • platform/efl/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
4:21 AM Changeset in webkit [132615] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.
https://bugs.webkit.org/show_bug.cgi?id=82315

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

This patch implements accelerated-compositing-related functions
to enter accelerated-compositing mode and sync layers
in ChromeClientEfl and ewkView.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
(WebCore::ChromeClientEfl::allowedCompositingTriggers):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_accelerated_compositing_cb):
Sync and render layers.
(_ewk_view_accelerated_compositing_context_create_if_needed):
Create a new AcceleratedCompositingContext.
(ewk_view_accelerated_compositing_object_create):
Create a new evas_image_object act as render target surface.
(ewk_view_accelerated_compositing_context_get):
Return the GraphicsContext3D for accelerated compositing.
(ewk_view_root_graphics_layer_set):
Set the root layer to AcceleratedCompositingContext.
(ewk_view_mark_for_sync):
Mark the evas_image_object for accelerated compositing as dirty to make it update.

  • ewk/ewk_view_private.h:

(WebCore):

4:21 AM Changeset in webkit [132614] by kbalazs@webkit.org
  • 1 edit
    80 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 5 (svg/dynamic-updates).

  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
4:17 AM Changeset in webkit [132613] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMAKE] Add TextAutosizer.cpp in WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100476

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Kentaro Hara.

ENABLE_TEXT_AUTOSIZING option is added in CMAKE,
but the source file for that feature is omitted.

No new tests. Covered by existing tests.

  • CMakeLists.txt:
4:13 AM Changeset in webkit [132612] by jchaffraix@webkit.org
  • 7 edits
    4 adds in trunk

RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861

Reviewed by Ojan Vafai.

Source/WebCore:

RenderTableCol's computePreferredLogicalWidths and layout's only purpose were to clear the preferred logical
widths dirty / layout flag so that we would properly propagate the information to our containing table. This
led to clunky code where the table layout code had to forcefully call RenderTableCol::computePreferredLogicalWidths
or else we would ignore the next layout hint on the <col> or <colgroup>.

Tests: fast/table/col-span-change-relayout.html

fast/table/simplified-layout-table.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
Simplified the code now that we only need to iterate over the sections.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Removed call to computePreferredLogicalWidths.

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
Forward a layout hint to the table so that we properly recompute the cell's logical withs.

(WebCore::RenderTableCol::computePreferredLogicalWidths):
(WebCore::RenderTableCol::layout):
Change our implementations of those 2 methods to be no-ops, while enforcing that they are
never called when it was possible.

(WebCore::RenderTableCol::propagateLayoutCueToTable):
New helper function that forward any layout cue to the containing table, this works around
us not clearing the flags which confuses RenderObject markContainingBlocksForLayout and
invalidateContainerPreferredLogicalWidths.

  • rendering/RenderTableCol.h:

Made the function that we are not expected to be called private.

LayoutTests:

Added 2 tests:

  • 1 to cover the code in RenderTableCol::updateFromElement.
  • 1 to cover simplified layout on a table.
  • fast/table/col-span-change-relayout-expected.txt: Added.
  • fast/table/col-span-change-relayout.html: Added.
  • fast/table/simplified-layout-table-expected.html: Added.
  • fast/table/simplified-layout-table.html: Added.
4:08 AM Changeset in webkit [132611] by kbalazs@webkit.org
  • 1 edit
    100 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 4 (svg/dynamic-updates).

  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
4:07 AM Changeset in webkit [132610] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.

(The following 2 files are missed in previous patch(r132582), adding them
again.)

  • DumpRenderTree/blackberry/build: Added.
  • DumpRenderTree/blackberry/src.pro: Added.

Adds 2 files for building ImageDiff, by Christopher Wells.

4:01 AM FeatureFlags edited by dominik.rottsches@intel.com
(diff)
4:00 AM Changeset in webkit [132609] by kbalazs@webkit.org
  • 1 edit
    101 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 3 (svg/dynamic-updates).

  • platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
4:00 AM AddingFeatures edited by dominik.rottsches@intel.com
(diff)
3:52 AM Changeset in webkit [132608] by Csaba Osztrogonác
  • 14 edits in trunk

Unreviewed, rolling out r132601.
http://trac.webkit.org/changeset/132601
https://bugs.webkit.org/show_bug.cgi?id=100494

It broke the Qt build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

  • PlatformEfl.cmake:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(OffScreenRootWindow):
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit2:

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize):

3:51 AM Changeset in webkit [132607] by kbalazs@webkit.org
  • 1 edit
    53 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 1.

  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/qt-5.0-wk2/fullscreen/fullscreen/full-screen-zIndex-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png/SVGLengthList-appendItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png/SVGLengthList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png/SVGLengthList-getItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png/SVGLengthList-initialize-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png/SVGLengthList-removeItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png/SVGLengthList-replaceItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png/SVGNumberList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png/SVGPathSegList-appendItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png/SVGPathSegList-removeItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png/SVGPointList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png/SVGStringList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png/SVGTransformList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/qt-5.0-wk2/svg/repaint/image-href-change-expected.png/image-href-change-expected.png: Added.
  • platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png/image-with-clip-path-expected.png: Added.
3:50 AM Changeset in webkit [132606] by kkristof@inf.u-szeged.hu
  • 6 edits in trunk/Source

[Qt] Enable JSC's disassembler on x86, x86_64 Linux
https://bugs.webkit.org/show_bug.cgi?id=100386

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-10-26
Reviewed by Simon Hausmann.

It works fine on Linux x86, x86_64 just needs to be enabled in the
QtWebKit build system.

Source/JavaScriptCore:

Source/WTF:

  • wtf/Platform.h:
3:50 AM Changeset in webkit [132605] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Memory instrumentation: do not report memory occupied by v8::String
https://bugs.webkit.org/show_bug.cgi?id=100487

Reviewed by Alexander Pavlov.

Pointers to v8::String are skipped when reporting memory usage of V8 bindings'
string cache.

  • bindings/v8/V8Binding.cpp:

(WTF):

3:45 AM Changeset in webkit [132604] by kbalazs@webkit.org
  • 1 edit
    94 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Added a bunch of pixel expectations for Qt-WebKit2 - part 1.

  • platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
  • platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
  • platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.
3:40 AM Changeset in webkit [132603] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, skip a new failing test.

  • platform/qt-5.0-wk2/TestExpectations:
3:31 AM Changeset in webkit [132602] by mihnea@adobe.com
  • 6 edits
    36 adds in trunk

[CSSRegions] Add support for auto-height regions with region-breaks
https://bugs.webkit.org/show_bug.cgi?id=99952

Reviewed by David Hyatt.

Source/WebCore:

This patch takes region breaks into account when computing the height for auto logical height regions.
When a region break is encountered before/after an element from within a flow thread and we are in the layout
phase in which we lay out the flow threads in regions unconstrained, we use the region break to
compute the region override logical content height if the region break fits inside an auto logical height region.
A region break inside an auto logical height region determines the region override logical content height, taking
min/max height into account.

Tests: fast/regions/autoheight-allregions-nobreaks.html

fast/regions/autoheight-allregions.html
fast/regions/autoheight-breakafteralways-maxheight.html
fast/regions/autoheight-breakbeforealways.html
fast/regions/autoheight-firstregion-breakalways.html
fast/regions/autoheight-lastregion-overflowauto-breaksignored.html
fast/regions/autoheight-lastregion-overflowauto.html
fast/regions/autoheight-middleregion.html
fast/regions/autoheight-secondregion-breakoutside.html
fast/regions/autoheight-secondregion.html
fast/regions/autoheight-singleregion-breakafteralways-maxheight.html
fast/regions/autoheight-singleregion-breakafteralways.html
fast/regions/autoheight-singleregion-breakaftermargin.html
fast/regions/autoheight-singleregion-breakbeforealways-minheight.html
fast/regions/autoheight-singleregion-breakbeforealways.html
fast/regions/autoheight-singleregion-multiplebreaks.html
fast/regions/autoheight-singleregion-overflowauto-breaksignored.html
fast/regions/autoheight-singleregion-overflowauto.html

  • rendering/RenderBlock.cpp: When encounter a region break before/after an element inside a flow thread,

try to use it to determine the override logical content height for auto logical height regions.
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
Simulate a region break at the end of the flow thread content.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::clearOverrideLogicalContentHeightInRegions):
Helper method used to clear the overrideLogicalContentHeight for auto logical height regions.
(WebCore::RenderFlowThread::addForcedRegionBreak):
Extend the method to process region breaks. The method returns true if at least one auto logical height region
has its override logical content height computed.

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp: Make these methods work with auto logical height regions.

(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):

LayoutTests:

Add tests for auto logical height regions with content having region breaks.

  • fast/regions/autoheight-allregions-expected.html: Added.
  • fast/regions/autoheight-allregions-nobreaks-expected.html: Added.
  • fast/regions/autoheight-allregions-nobreaks.html: Added.
  • fast/regions/autoheight-allregions.html: Added.
  • fast/regions/autoheight-breakafteralways-maxheight-expected.html: Added.
  • fast/regions/autoheight-breakafteralways-maxheight.html: Added.
  • fast/regions/autoheight-breakbeforealways-expected.html: Added.
  • fast/regions/autoheight-breakbeforealways.html: Added.
  • fast/regions/autoheight-firstregion-breakalways-expected.html: Added.
  • fast/regions/autoheight-firstregion-breakalways.html: Added.
  • fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html: Added.
  • fast/regions/autoheight-lastregion-overflowauto-breaksignored.html: Added.
  • fast/regions/autoheight-lastregion-overflowauto-expected.html: Added.
  • fast/regions/autoheight-lastregion-overflowauto.html: Added.
  • fast/regions/autoheight-middleregion-expected.html: Added.
  • fast/regions/autoheight-middleregion.html: Added.
  • fast/regions/autoheight-secondregion-breakoutside-expected.html: Added.
  • fast/regions/autoheight-secondregion-breakoutside.html: Added.
  • fast/regions/autoheight-secondregion-expected.html: Added.
  • fast/regions/autoheight-secondregion.html: Added.
  • fast/regions/autoheight-singleregion-breakafteralways-expected.html: Added.
  • fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html: Added.
  • fast/regions/autoheight-singleregion-breakafteralways-maxheight.html: Added.
  • fast/regions/autoheight-singleregion-breakafteralways.html: Added.
  • fast/regions/autoheight-singleregion-breakaftermargin-expected.html: Added.
  • fast/regions/autoheight-singleregion-breakaftermargin.html: Added.
  • fast/regions/autoheight-singleregion-breakbeforealways-expected.html: Added.
  • fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html: Added.
  • fast/regions/autoheight-singleregion-breakbeforealways-minheight.html: Added.
  • fast/regions/autoheight-singleregion-breakbeforealways.html: Added.
  • fast/regions/autoheight-singleregion-multiplebreaks-expected.html: Added.
  • fast/regions/autoheight-singleregion-multiplebreaks.html: Added.
  • fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html: Added.
  • fast/regions/autoheight-singleregion-overflowauto-breaksignored.html: Added.
  • fast/regions/autoheight-singleregion-overflowauto-expected.html: Added.
  • fast/regions/autoheight-singleregion-overflowauto.html: Added.
3:22 AM Changeset in webkit [132601] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652

Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
Reviewed by Gyuyoung Kim.

.:

Use Graphics Surface to enable WebGL for WebKit2 EFL.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
Depends on GLX since Evas doesn't provide the necessary functionality.

No new tests. Covered by existing tests.

  • PlatformEfl.cmake:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):

  • platform/graphics/surfaces/efl: Added.
  • platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.

(WebCore):
(WebCore::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.

(WebCore):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::glxPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::glContext):
(WebCore::resolveGLMethods):

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore):
(WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::makeCurrent):
(WebCore::GraphicsSurfacePrivate::doneCurrent):
(WebCore::GraphicsSurfacePrivate::swapBuffers):

Source/WebKit2:

Set WebGLEnabled to true when WebGL is enabled.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize):

3:20 AM Changeset in webkit [132600] by commit-queue@webkit.org
  • 18 edits in trunk

Add feature flags for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95960

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
3:18 AM Changeset in webkit [132599] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085

Patch by Li Yin <li.yin@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.

Source/WebCore:

From Spec: http://dev.w3.org/html5/spec/single-page.html#dom-input-value-filename
On setting, if the new value is the empty string, it must empty the list of selected
files; otherwise, it must throw an InvalidStateError exception.

Test: fast/forms/file/input-file-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:

LayoutTests:

The test input-file-value.html is split from input-file-write-test.html.
And add correct setting value for files attribute, verify the files attribute
is writable or not.

  • fast/forms/file/input-file-value-expected.txt: Added.
  • fast/forms/file/input-file-value.html: Added.
  • fast/forms/file/input-file-write-files-expected.txt:
  • fast/forms/file/input-file-write-files.html:
3:09 AM Changeset in webkit [132598] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after bug 99824
https://bugs.webkit.org/show_bug.cgi?id=100469

Unreviewed, EFL gardening.

Unskip following 3 test cases after bug 99824 is resolved.

  • fast/lists/w3-css3-list-styles-alphabetic.html
  • fast/lists/w3-css3-list-styles-fallback-style.html
  • fast/lists/w3-list-styles.html

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26

  • platform/efl-wk1/TestExpectations:
3:00 AM Changeset in webkit [132597] by commit-queue@webkit.org
  • 12 edits
    2 deletes in trunk/Tools

Unreviewed, rolling out r132552.
http://trac.webkit.org/changeset/132552
https://bugs.webkit.org/show_bug.cgi?id=100486

Makes typeahead tests crash in debug. (Requested by pfeldman
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTTestRunner.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebKit):
(webkit_support):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

2:56 AM Changeset in webkit [132596] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor calendar picker to remove _x/_y from DaysTable
https://bugs.webkit.org/show_bug.cgi?id=100460

Reviewed by Kent Tamura.

_x/_y properties keep the coordinates for the selection but when we add
week and month picking capabilities, the selection can't be expressed as
a set of coordinates. This change will remove it.

No new tests. Covered by calendar-picker-*.html tests.

  • Resources/pagepopups/calendarPicker.js:

(DaysTable): Removed _x/_y properties.
(DaysTable.prototype._hasSelection): Changed to refer to the DOM to see if we have a selection.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Lookup the selection position.
(DaysTable.prototype.selectDate): Deselect first so we don't have two selections.
(DaysTable.prototype._selectRangeContainingNode): Selects date/week/month containing the given day node.
(DaysTable.prototype._selectRangeAtPosition): Selects date/week/month at the given position.
(DaysTable.prototype._firstNodeInSelectedRange): Returns first selected day node.
(DaysTable.prototype._deselect): Deselects all selections.
(DaysTable.prototype._handleMouseOver): Use _selectRangeContainingNode so we don't have many places handling the selection.
(DaysTable.prototype._handleMouseOut): Use _deselect.
(DaysTable.prototype._handleKey): Lookup the selection position.
(DaysTable.prototype.updateSelection): Use _selectRangeAtPosition.

2:40 AM Changeset in webkit [132595] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip svg/foreignObject/viewport-foreignobject-crash.html
https://bugs.webkit.org/show_bug.cgi?id=100467

Unreviewed, EFL gardening.

Removing a test failure expectations, the test was fixed in r132548.

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26

  • platform/efl-wk2/TestExpectations:
2:40 AM Changeset in webkit [132594] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Move input method code out of EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100468

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Move input method code out of EwkViewImpl and into
a new InputMethodContextEfl class to avoid cluttering
the view code.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::inputMethodContext):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_mouse_up):
(_ewk_view_smart_key_down):

  • UIProcess/efl/InputMethodContextEfl.cpp: Added.

(WebKit):
(WebKit::InputMethodContextEfl::InputMethodContextEfl):
(WebKit::InputMethodContextEfl::~InputMethodContextEfl):
(WebKit::InputMethodContextEfl::onIMFInputSequenceComplete):
(WebKit::InputMethodContextEfl::onIMFPreeditSequenceChanged):
(WebKit::InputMethodContextEfl::createIMFContext):
(WebKit::InputMethodContextEfl::handleMouseUpEvent):
(WebKit::InputMethodContextEfl::handleKeyDownEvent):
(WebKit::InputMethodContextEfl::updateTextInputState):

  • UIProcess/efl/InputMethodContextEfl.h: Added.

(WebKit):
(InputMethodContextEfl):
(WebKit::InputMethodContextEfl::create):

  • UIProcess/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::updateTextInputState):

2:39 AM Changeset in webkit [132593] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html fails every 3 days
https://bugs.webkit.org/show_bug.cgi?id=100480

Reviewed by Pavel Feldman.

Because the date field in the test has step=3, the availability of
[Today] button depends on the current date. We make the test stable by
specifying max attribute.

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
2:37 AM Changeset in webkit [132592] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

FileReader abort case causes Chromium renderer crash
https://bugs.webkit.org/show_bug.cgi?id=99142

Patch by Ningxin Hu <ningxin.hu@intel.com> on 2012-10-26
Reviewed by Kentaro Hara.

Before dispatching load event, FileReader should check if it is
in aborting.

Test: manually launch fast/files/file-reader-abort.html in Chromium
browser and compare the result with
fast/files/file-reader-abort-expected.txt.

  • fileapi/FileReader.cpp:

(WebCore::FileReader::didFinishLoading):

2:34 AM Changeset in webkit [132591] by jchaffraix@webkit.org
  • 5 edits in trunk

Generate less repaint calls during subtree detaching
https://bugs.webkit.org/show_bug.cgi?id=99741

Reviewed by Eric Seidel.

Source/WebCore:

Following bug 98336, detach is now a subtree top-down operation. Because we
track visual overflow from our children during layout for most cases, we can
generate a repaint only on the subtree root.

On http://dglazkov.github.com/performance-tests/redraw.html, this ups the FPS to
26 fps from 22 fps on my MBP (+ 15%). On PerformanceTests/layout/subtree-detach.html,
it decreases the time by 35%. This is due to being the best case and we now generate
only one repaint per detach phase.

Covered by existing pixels tests (including but not limited to repaint ones).

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Changed the function not to be recursive anymore to generate one painting for
our root only. Added a FIXME about using our RenderLayer for repainting to avoid
the cost of computing our absolute repaint rectangle.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
Removed the logic for repainting in the general case. However we still force a repaint
if we have a RenderLayer as we don't track their overflow in some cases (e.g. positioned
objects). This check is conservative and could be narrowed down (e.g overflow RenderLayers
are properly accounted for in our clipppedOverflowRectForRepaint).

LayoutTests:

  • platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:

Rebaselined this test after the change. It is progressing as we still properly repaint
the selection, but repaint less (ie don't repaint the top border which didn't change).

2:33 AM Changeset in webkit [132590] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Make LLInt offsets extractor work on Windows
https://bugs.webkit.org/show_bug.cgi?id=100369

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
it's a text mode file that needs even new line conversions. The binary mode parameter is
ignored on other platforms.

  • offlineasm/offsets.rb:
2:09 AM Changeset in webkit [132589] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

local(Helvetica) in src descriptor prevent fallback
https://bugs.webkit.org/show_bug.cgi?id=100446

Reviewed by Dan Bernstein.

FontCache::getCachedFontData() has a mechanism that aliases a few pairs
of font family names, so that if the family name specified in the font-family
property is not available on the system, but the its alias is available,
it will be used instead. This is appropriate for the font-family property,
but not for font family names specified in the local() function of the src
descriptor in a @font-face rule.

This patch disables the mechanism while checking src descriptor of @font-face.

No new tests. It's difficult to test the change because 'Helvetica' can
be mapped any other font. For example, chromium DRT uses FontConfig to
map Helvetica to Times New Roman. Other ports may map Helvetica to other
fonts. We can't define the expected result.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):
Call fontCache()->getCachedFontData() with checkingAlternateName = true.
This disables aliasing font family names in FontCache.

2:06 AM Changeset in webkit [132588] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Doctype Audits panel code
https://bugs.webkit.org/show_bug.cgi?id=100371

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-26
Reviewed by Alexander Pavlov.

This is a preparation step for ongoing refactoring.
It is much easier to read doctyped code.

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
Replaced "undefined" with "null"

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditCategory.prototype.callbackWrapper):
Removed callback parameter indirection.
(WebInspector.AuditRuleResult.prototype.addFormatted):
Converted private instance function to scoped function.

2:01 AM Changeset in webkit [132587] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=100471

  • platform/chromium/TestExpectations:

We should do rebaseline for time-suggestion-picker-*.html too.

1:39 AM Changeset in webkit [132586] by tkent@chromium.org
  • 4 edits in trunk

Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
https://bugs.webkit.org/show_bug.cgi?id=100457

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

It was enabled accidentally. Week input is not implemented in
Android.

  • features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,

add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.

LayoutTests:

  • platform/chromium/TestExpectations:

Tests in fast/forms/week/ may fail on Android.

1:25 AM Changeset in webkit [132585] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromiuim expectations updated.

  • platform/chromium/TestExpectations:
1:24 AM Changeset in webkit [132584] by kbalazs@webkit.org
  • 4 edits
    301 adds in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Adding new expectations, mark failures.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/bgCompositeCopy-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize01-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize04-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize05-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize06-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize07-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize12-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize13-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize14-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize17-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize19-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/qt-5.0-wk2/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/qt/TestExpectations:
  • platform/qt/animations/state-at-end-event-expected.png: Added.
  • platform/qt/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png: Added.
  • platform/qt/compositing/overflow/nested-scrolling-expected.png: Added.
  • platform/qt/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.png: Added.
  • platform/qt/compositing/overflow/remove-overflow-crash2-expected.png: Added.
  • platform/qt/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.png: Added.
  • platform/qt/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/qt/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/qt/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.png: Added.
  • platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.png: Added.
  • platform/qt/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/qt/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/qt/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/qt/css2.1/t1604-c542-letter-sp-01-b-a-expected.png: Added.
  • platform/qt/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
  • platform/qt/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/qt/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
  • platform/qt/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
  • platform/qt/fast/backgrounds/bgCompositeCopy-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize01-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize03-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize04-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize05-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize06-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize07-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize08-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize09-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize10-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize11-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize12-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize13-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize14-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize17-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize19-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/qt/fast/block/float/009-expected.png: Added.
  • platform/qt/fast/block/float/034-expected.png: Added.
  • platform/qt/fast/block/float/4145535Crash-expected.png: Added.
  • platform/qt/fast/block/float/negative-margin-clear-expected.png: Added.
  • platform/qt/fast/block/float/nowrap-clear-min-width-expected.png: Added.
  • platform/qt/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/qt/fast/borders/border-radius-circle-expected.png: Added.
  • platform/qt/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/qt/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/qt/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/qt/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
  • platform/qt/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/qt/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/qt/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/qt/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/qt/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/qt/fast/borders/outline-offset-min-assert-expected.png: Added.
  • platform/qt/fast/css/006-expected.png: Added.
  • platform/qt/fast/css/background-clip-values-expected.png: Added.
  • platform/qt/fast/css/bogus-color-span-expected.png: Added.
  • platform/qt/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/qt/fast/css/content-dynamic-expected.png: Added.
  • platform/qt/fast/css/contentDiv-expected.png: Added.
  • platform/qt/fast/css/contentDivWithChildren-expected.png: Added.
  • platform/qt/fast/css/contentImage-expected.png: Added.
  • platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/qt/fast/css/replaced-element-implicit-size-expected.png: Added.
  • platform/qt/fast/dom/attr_dead_doc-expected.png: Added.
  • platform/qt/fast/dom/css-cached-import-rule-expected.png: Added.
  • platform/qt/fast/dom/css-insert-import-rule-expected.png: Added.
  • platform/qt/fast/dynamic/001-expected.png: Added.
  • platform/qt/fast/dynamic/005-expected.png: Added.
  • platform/qt/fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
  • platform/qt/fast/dynamic/staticY-expected.png: Added.
  • platform/qt/fast/forms/002-expected.png: Added.
  • platform/qt/fast/forms/003-expected.png: Added.
  • platform/qt/fast/forms/004-expected.png: Added.
  • platform/qt/fast/forms/005-expected.png: Added.
  • platform/qt/fast/forms/006-expected.png: Added.
  • platform/qt/fast/forms/007-expected.png: Added.
  • platform/qt/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/qt/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/qt/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/qt/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/qt/fast/forms/button-submit-expected.png: Added.
  • platform/qt/fast/forms/caret-rtl-expected.png: Added.
  • platform/qt/fast/forms/control-clip-expected.png: Added.
  • platform/qt/fast/forms/fieldset-with-float-expected.png: Added.
  • platform/qt/fast/forms/form-added-to-table-expected.png: Added.
  • platform/qt/fast/forms/form-in-malformed-markup-expected.png: Added.
  • platform/qt/fast/forms/formmove-expected.png: Added.
  • platform/qt/fast/forms/formmove2-expected.png: Added.
  • platform/qt/fast/forms/image-border-expected.png: Added.
  • platform/qt/fast/forms/indeterminate-expected.png: Added.
  • platform/qt/fast/forms/input-align-image-expected.png: Added.
  • platform/qt/fast/forms/input-first-letter-expected.png: Added.
  • platform/qt/fast/forms/input-no-renderer-expected.png: Added.
  • platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
  • platform/qt/fast/forms/menulist-deselect-update-expected.png: Added.
  • platform/qt/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/qt/fast/forms/option-index-expected.png: Added.
  • platform/qt/fast/forms/option-script-expected.png: Added.
  • platform/qt/fast/forms/option-text-clip-expected.png: Added.
  • platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
  • platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.png: Added.
  • platform/qt/fast/forms/select-align-expected.png: Added.
  • platform/qt/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
  • platform/qt/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/qt/fast/forms/select-display-none-style-resolve-expected.png: Added.
  • platform/qt/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/qt/fast/forms/select-selected-expected.png: Added.
  • platform/qt/fast/forms/select-size-expected.png: Added.
  • platform/qt/fast/forms/select-style-expected.png: Added.
  • platform/qt/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/qt/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
  • platform/qt/fast/frames/002-expected.png: Added.
  • platform/qt/fast/frames/calculate-round-expected.png: Added.
  • platform/qt/fast/frames/content-opacity-1-expected.png: Added.
  • platform/qt/fast/frames/content-opacity-2-expected.png: Added.
  • platform/qt/fast/frames/empty-cols-attribute-expected.png: Added.
  • platform/qt/fast/frames/empty-frame-src-expected.png: Added.
  • platform/qt/fast/frames/frame-length-fractional-expected.png: Added.
  • platform/qt/fast/frames/frame-set-whitespace-attributes-expected.png: Added.
  • platform/qt/fast/frames/iframe-text-contents-expected.png: Added.
  • platform/qt/fast/frames/no-frame-borders-expected.png: Added.
  • platform/qt/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/qt/fast/images/embed-image-expected.png: Added.
  • platform/qt/fast/images/favicon-as-image-expected.png: Added.
  • platform/qt/fast/images/image-css3-content-data-expected.png: Added.
  • platform/qt/fast/images/object-image-expected.png: Added.
  • platform/qt/fast/images/pdf-as-image-expected.png: Added.
  • platform/qt/fast/inline-block/004-expected.png: Added.
  • platform/qt/fast/inline-block/005-expected.png: Added.
  • platform/qt/fast/invalid/015-expected.png: Added.
  • platform/qt/fast/invalid/table-residual-style-crash-expected.png: Added.
  • platform/qt/fast/js/exception-linenums-in-html-3-expected.png: Added.
  • platform/qt/fast/js/missing-style-end-tag-js-expected.png: Added.
  • platform/qt/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/qt/fast/layers/opacity-stacking-expected.png: Added.
  • platform/qt/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
  • platform/qt/fast/layers/zindex-ridonkulous-expected.png: Added.
  • platform/qt/fast/media/implicit-media-all-expected.png: Added.
  • platform/qt/fast/media/media-query-invalid-value-expected.png: Added.
  • platform/qt/fast/media/monochrome-expected.png: Added.
  • platform/qt/fast/media/mq-min-pixel-ratio-expected.png: Added.
  • platform/qt/fast/overflow/position-relative-expected.png: Added.
  • platform/qt/fast/overflow/unreachable-content-test-expected.png: Added.
  • platform/qt/fast/parser/comment-in-script-expected.png: Added.
  • platform/qt/fast/parser/style-script-head-test-expected.png: Added.
  • platform/qt/fast/reflections/table-cell-expected.png: Added.
  • platform/qt/fast/repaint/background-generated-expected.png: Added.
  • platform/qt/fast/repaint/background-misaligned-expected.png: Added.
  • platform/qt/fast/repaint/canvas-putImageData-expected.png: Added.
  • platform/qt/fast/repaint/erase-overflow-expected.png: Added.
  • platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
  • platform/qt/fast/repaint/float-new-in-block-expected.png: Added.
  • platform/qt/fast/repaint/inline-block-resize-expected.png: Added.
  • platform/qt/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
  • platform/qt/fast/repaint/intermediate-layout-position-expected.png: Added.
  • platform/qt/fast/repaint/layer-full-repaint-expected.png: Added.
  • platform/qt/fast/repaint/table-col-background-expected.png: Added.
  • platform/qt/fast/repaint/table-outer-border-expected.png: Added.
  • platform/qt/fast/repaint/table-row-expected.png: Added.
  • platform/qt/fast/repaint/table-section-overflow-expected.png: Added.
  • platform/qt/fast/replaced/008-expected.png: Added.
  • platform/qt/fast/replaced/image-tag-expected.png: Added.
  • platform/qt/fast/replaced/selection-rect-expected.png: Added.
  • platform/qt/fast/table/008-expected.png: Added.
  • platform/qt/fast/table/024-expected.png: Added.
  • platform/qt/fast/table/031-expected.png: Added.
  • platform/qt/fast/table/caption-relayout-expected.png: Added.
  • platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Added.
  • platform/qt/fast/table/div-as-col-span-expected.png: Added.
  • platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.png: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.png: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png: Added.
  • platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png: Added.
  • platform/qt/fast/table/fixed-table-with-small-percent-width-expected.png: Added.
  • platform/qt/fast/table/giantRowspan-expected.png: Added.
  • platform/qt/fast/table/growCellForImageQuirk-expected.png: Added.
  • platform/qt/fast/table/percent-widths-stretch-expected.png: Added.
  • platform/qt/fast/table/vertical-align-baseline-readjust-expected.png: Added.
  • platform/qt/fast/text/align-center-rtl-spill-expected.png: Added.
  • platform/qt/fast/text/basic/013-expected.png: Added.
  • platform/qt/fast/text/basic/015-expected.png: Added.
  • platform/qt/fast/text/line-breaks-expected.png: Added.
  • platform/qt/fast/text/soft-hyphen-3-expected.png: Added.
  • platform/qt/fast/text/stripNullFromText-expected.png: Added.
  • platform/qt/fast/text/whitespace/017-expected.png: Added.
  • platform/qt/fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
  • platform/qt/fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
  • platform/qt/fast/tokenizer/script-after-frameset-expected.png: Added.
  • platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
  • platform/qt/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-image-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-relative-image-expected.png: Added.
  • platform/qt/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/qt/svg/css/path-with-shadow-expected.png: Added.
  • platform/qt/svg/css/shadow-and-opacity-expected.png: Added.
  • platform/qt/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/qt/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/qt/svg/custom/animation-currentColor-expected.png: Added.
  • platform/qt/svg/custom/clip-path-id-changes-expected.png: Added.
  • platform/qt/svg/custom/createImageElement-expected.png: Added.
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
  • platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
  • platform/qt/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/qt/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/qt/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/qt/svg/custom/marker-opacity-expected.png: Added.
  • platform/qt/svg/custom/marker-referencePoint-expected.png: Added.
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.png: Added.
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.png: Added.
  • platform/qt/svg/custom/mask-with-default-value-expected.png: Added.
  • platform/qt/svg/custom/outer-svg-unknown-feature-expected.png: Added.
  • platform/qt/svg/custom/pan-direction-expected.png: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
  • platform/qt/svg/custom/repaint-shadow-expected.png: Added.
  • platform/qt/svg/custom/transformedMaskFails-expected.png: Added.
  • platform/qt/svg/custom/use-inherit-style-expected.png: Added.
  • platform/qt/svg/custom/xhtml-no-svg-renderer-expected.png: Added.
  • platform/qt/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/qt/svg/filters/feLighting-crash-expected.png: Added.
  • platform/qt/svg/filters/feMerge-expected.png: Added.
  • platform/qt/svg/filters/feMerge-wrong-input-expected.png: Added.
  • platform/qt/svg/filters/feOffset-expected.png: Added.
  • platform/qt/svg/filters/feTile-expected.png: Added.
  • platform/qt/svg/filters/filter-clip-expected.png: Added.
  • platform/qt/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/qt/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.png: Added.
  • platform/qt/svg/hixie/error/006-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug120107-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug1271-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug12908-2-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug12910-2-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug131020-2-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug13169-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug137388-3-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug1818-3-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug1818-6-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug196870-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug222336-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug222467-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug269566-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug277062-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug28933-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug2954-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug50695-2-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug56201-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug8032-2-expected.png: Added.
  • platform/qt/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Added.
  • platform/qt/transitions/opacity-transition-zindex-expected.png: Added.
  • platform/qt/transitions/transition-end-event-rendering-expected.png: Added.
1:24 AM Changeset in webkit [132583] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt]REGRESSION(r131428): cookies.db created on wrong place
https://bugs.webkit.org/show_bug.cgi?id=99445

Patch by János Badics <János Badics> on 2012-10-26
Reviewed by Simon Hausmann.

Added a slash to the path of cookies.db in CookieJarQt.cpp.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::SharedCookieJarQt):

1:11 AM Changeset in webkit [132582] by commit-queue@webkit.org
  • 9 edits in trunk

[BlackBerry] Support pixel tests for BlackBerry DRT
https://bugs.webkit.org/show_bug.cgi?id=100210

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
Reviewed by Rob Buis.

Source/WebKit:

Adds a step to build ImageDiff from Qt for DRT. Most of the works are
accomplished by Christopher Wells.

  • PlatformBlackBerry.cmake:

Tools:

The implementation is based on the patch from Christopher Wells.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::runTest):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::runTests):
(BlackBerry::WebKit::DumpRenderTree::dump):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

  • DumpRenderTree/blackberry/PNGImageEncoder.cpp:

(BGRAtoRGBA):
(encodeBitmapToPNG):

  • DumpRenderTree/blackberry/PNGImageEncoder.h:

The changes to PNGImageEncoder files are from master_40, patched by Tyler
Abbott and Rob Buis.

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView):
(computeMD5HashStringForBitmapContext):
(printPNG):
(dumpBitmap):

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:

(BitmapContext::createByAdoptingData):
(BitmapContext::~BitmapContext):
(BitmapContext):
(BitmapContext::BitmapContext):

  • DumpRenderTree/blackberry/build: Added.
  • DumpRenderTree/blackberry/src.pro: Added.

Adds 2 files for building ImageDiff, by Christopher Wells.

1:10 AM Changeset in webkit [132581] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. This ASSERT is no longer correct (and fires on many tests.)

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):

12:51 AM Changeset in webkit [132580] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromiuim expectations updated.

  • platform/chromium/TestExpectations:
12:43 AM Changeset in webkit [132579] by tkent@chromium.org
  • 12 edits in trunk

[Chromium-Win] Support shortTimeFormat
https://bugs.webkit.org/show_bug.cgi?id=100471

Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. Covered by fast/forms/time-multiple-fields/ and
WebKit/chromium/tests/LocaleWinTest.

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::shortTimeFormat):
Gets a format by LOCALE_SSHORTTIME. If it fails, remove "<delimiter>ss"
from the format by LOCALE_STIMEFORMAT.

  • platform/text/LocaleWin.h:

(LocaleWin): Declare m_timeFormatWithoutSeconds.

Source/WebKit/chromium:

  • tests/LocaleWinTest.cpp:

(TEST_F): Update test expectations for the behavior change.

LayoutTests:

  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium/TestExpectations:
12:35 AM Changeset in webkit [132578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Implement {get,set}FloatValueForKey
https://bugs.webkit.org/show_bug.cgi?id=100452

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
Reviewed by Anders Carlsson.

Implement missing functions in WebPreferencesStore.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::setFloatValueForKey):
(WebKit):
(WebKit::WebPreferencesStore::getFloatValueForKey):

12:32 AM Changeset in webkit [132577] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip a new failing test introduced in r132554 that fails on 32 bit platforms.
Remove another one that does not exists already.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-26

  • platform/qt/TestExpectations:
12:15 AM Changeset in webkit [132576] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed. Update run-bindings-tests results after recent active DOM
object changes.

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::wrap):

12:07 AM Changeset in webkit [132575] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] REGRESSION(132540) Assertion failure on V8DOMWrapper::setJSWrapperForDOMNode()
https://bugs.webkit.org/show_bug.cgi?id=100462

Patch by MORITA Hajime <morrita@google.com> on 2012-10-26
Reviewed by Adam Barth.

Removed the no longer correct assertion statement.

No new tests. Covered by breaking tests.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):

Oct 25, 2012:

11:39 PM Changeset in webkit [132574] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] WorkerContextExecutionProxy should use ScopedPersistent
https://bugs.webkit.org/show_bug.cgi?id=100443

Reviewed by Eric Seidel.

This class was manually re-implementing the ScopedPersistent pattern.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::dispose):
(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):
(WebCore::WorkerContextExecutionProxy::evaluate):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WebCore::WorkerContextExecutionProxy::context):
(WorkerContextExecutionProxy):

10:41 PM Changeset in webkit [132573] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

A mistake in WebCore::JavaScriptCallFrame::evaluate which will cause assert failed
https://bugs.webkit.org/show_bug.cgi?id=100347

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-25
Reviewed by Mark Lam and Filip Pizlo.

In worker context, calling "JSDOMWindowBase::commonJSGlobalData" will cause assert,
since there is "ASSERT(isMainThread())" in "JSDOMWindowBase::commonJSGlobalData".

No new test case, since no behaviour changed.

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

10:25 PM Changeset in webkit [132572] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skipping these tests again because Bug 96951 isn't actually fixed.

  • platform/chromium/TestExpectations:
10:08 PM Changeset in webkit [132571] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL][WK2][AC] Enable 3D_RENDERING flag
https://bugs.webkit.org/show_bug.cgi?id=99535

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-25
Reviewed by Laszlo Gombos.

Turn on the flag ENABLE_3D_RENDERING when WTF_USE_TILE_BACKING_STORE flag is on.
This flag controls perspective and preserves-3d behavior.

  • Source/cmake/OptionsEfl.cmake:
9:58 PM Changeset in webkit [132570] by abarth@webkit.org
  • 10 edits in trunk/Source/WebCore

[V8] We can merge the wrapper maps for DOM objects and active DOM objects
https://bugs.webkit.org/show_bug.cgi?id=100432

Reviewed by Eric Seidel.

Now that we use the same object to visit both DOM objects and active
DOM objects, there's no reason to keep them in separate hash maps.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetDomMapName):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:

(NodeWrapperVisitor):
(WebCore):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

9:44 PM Changeset in webkit [132569] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] User Challenged again after browser restart for HTTP/FTP sites already successfully authenticated.
https://bugs.webkit.org/show_bug.cgi?id=100448

Reviewed by George Staikos.

Internally reviewed by Joe Mason.

We didn't check the persistent Credential Storage for Credentials when challenged by the server.

Manual Test: login to ftp://localhost on BlackBerry device, and restart the browser to login again.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

9:05 PM Changeset in webkit [132568] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Add histogram statistics for backing store errors
https://bugs.webkit.org/show_bug.cgi?id=98465

Reviewed by Adam Barth.

Define a macro for consistent asserting (during development), logging, and recording
internal backing store errors via histograms. Define specific histogram values to
track issues with opening backing stores to gather stats on corruption.

No new tests - just the stats, ma'am, just the stats.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):
(WebCore::setUpMetadata):
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):

8:33 PM Changeset in webkit [132567] by thakis@chromium.org
  • 1 edit
    5 adds
    1 delete in trunk/LayoutTests

[chromium] Add expectations for fast/images/exif-orientation.html
https://bugs.webkit.org/show_bug.cgi?id=100434

Unreviewed, just baselines.

  • platform/chromium-linux/fast/images/exif-orientation-expected.png: Added.
  • platform/chromium-mac-lion/fast/images/exif-orientation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/exif-orientation-expected.png: Added.
  • platform/chromium-mac/fast/images/exif-orientation-expected.png: Added.
  • platform/chromium-win/fast/images/exif-orientation-expected.png: Added.
  • platform/chromium/fast/images/exif-orientation-expected.png: Removed.
8:28 PM Changeset in webkit [132566] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

SymbolTableIndexHashTraits::needsDestruction should be set to true
https://bugs.webkit.org/show_bug.cgi?id=100437

Reviewed by Mark Hahnenberg.

For correctness, set SymbolTableIndexHashTraits::needsDestruction to true since SymbolTableEntry's do
need to have their destructor called due to the possibility of rare data.

  • runtime/SymbolTable.h:

(SymbolTableIndexHashTraits):

8:23 PM Changeset in webkit [132565] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
https://bugs.webkit.org/show_bug.cgi?id=100406

Patch by Min Qin <qinmin@chromium.org> on 2012-10-25
Reviewed by Adam Barth.

Tools:

Resize the context with an empty rect will cause a gl_error in gles2_cmd_decoder.cc.
Don't paint the plugin if m_rect is empty.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::updateGeometry):

LayoutTests:

Test for adding a webplugin into an iframe and make sure it doesn't crash.

  • platform/chromium/plugins/plugin-inside-iframe-expected.txt: Added.
  • platform/chromium/plugins/plugin-inside-iframe.html: Added.
  • platform/chromium/plugins/resources/plugin-page.html: Added.
8:11 PM Changeset in webkit [132564] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] We can merge ActiveDOMObjectPrologueVisitor with ObjectVisitor
https://bugs.webkit.org/show_bug.cgi?id=100430

Reviewed by Eric Seidel.

There's no reason for these visitors to be separate objects anymore.

  • bindings/v8/V8GCController.cpp:

(WebCore::ObjectVisitor::ObjectVisitor):
(WebCore::ObjectVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCPrologue):

8:09 PM Changeset in webkit [132563] by tsepez@chromium.org
  • 2 edits in trunk/LayoutTests

Test full-block-iframe-no-inherit.php generates an invalid X-XSS-PROTECTION header.
https://bugs.webkit.org/show_bug.cgi?id=100423

Reviewed by Adam Barth.

Changed header syntax from full-block to mode=block.

  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
7:54 PM Changeset in webkit [132562] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused static methods from DOMTimer.h
https://bugs.webkit.org/show_bug.cgi?id=100427

Reviewed by Kenneth Russell.

Since these values got moved into Settings, these methods are no longer called.

No new tests, removing dead code.

  • page/DOMTimer.h:

(DOMTimer): Remove unused getters.

7:38 PM Changeset in webkit [132561] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
https://bugs.webkit.org/show_bug.cgi?id=100330

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-25
Reviewed by Rob Buis.

Reviewed internally by Charles Wei.
PR #231232

Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
visible needs AuthenticationChallengeManager to update its records, deleting
webpage from AuthenticationChallengeManager's map should be done after setting
webpage visibility.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

7:37 PM Changeset in webkit [132560] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Display tooltip in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99322

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Display tooltip in MiniBrowser using elm_object_tooltip_text_set().

  • MiniBrowser/efl/main.c:

(on_tooltip_text_set):
(on_tooltip_text_unset):
(window_create):

7:37 PM Changeset in webkit [132559] by kareng@chromium.org
  • 2 edits in branches/chromium/1307/Source/WebCore

Revert 132288 - Shrink immutable ElementAttributeData and StylePropertySet by one pointer each.
<http://webkit.org/b/100123>

Reviewed by Anders Carlsson.

Remove one pointer of unintentional padding in the immutable versions of these objects.
583kB progression on Membuster3.

  • css/StylePropertySet.cpp:

(WebCore::immutableStylePropertySetSize):

  • dom/ElementAttributeData.cpp:

(WebCore::immutableElementAttributeDataSize):

TBR=kling@webkit.org
Review URL: https://codereview.chromium.org/11293004

7:34 PM Changeset in webkit [132558] by kareng@chromium.org
  • 1 add in branches/chromium/1307/codereview.settings

easy drovering

7:32 PM Changeset in webkit [132557] by kareng@chromium.org
  • 1 copy in branches/chromium/1307

branching for canary 1307

7:20 PM Changeset in webkit [132556] by leoyang@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Infinite redirect loop is not displayed to user
https://bugs.webkit.org/show_bug.cgi?id=100420

Reviewed by George Staikos.

CNN.com is redirecting us infinitely with 302 http code and response body. We catch
it my setting our extended error code as we defined. But we were not trying to notify
error because we have received body. This was wrong. For extended http status code
which is less than 0 we should display our own error page regardless there was data
received from the server or not.

Tested by manually loading CNN.com.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::shouldNotifyClientFailed):

7:18 PM Changeset in webkit [132555] by thakis@chromium.org
  • 7 edits in trunk/Source/WebCore

Flip ImageOrientation coordinate system from lefthanded to righthanded
https://bugs.webkit.org/show_bug.cgi?id=100414

Reviewed by Eric Seidel.

platform/graphics, noteably GraphicsContext uses a right-handed
coordinate system (origin in the top left corner, x growing to the
right, y to the bottom). ImageOrientation was an outlier from
and used a left-handed coordinate system. This patch makes
ImageOrientation match the rest of platform/graphics.

This is a pure refactoring and has no observable effects.

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

  • platform/graphics/ImageOrientation.cpp:

(WebCore::ImageOrientation::transformFromDefault):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

6:57 PM Changeset in webkit [132554] by fpizlo@apple.com
  • 7 edits
    3 adds in trunk

DFG Arrayify elimination should replace it with GetButterfly rather than Phantom
https://bugs.webkit.org/show_bug.cgi?id=100441

Reviewed by Oliver Hunt and Gavin Barraclough.

Source/JavaScriptCore:

Made array profiler's to-string helper behave correctly.

Made Arrayify elimination do the right thing (convert to GetButterfly).

Made CFA's interference analysis track clobbered array modes correctly, mostly by
simplifying the machinery.

  • bytecode/ArrayProfile.cpp:

(JSC::arrayModesToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clobberArrayModes):
(AbstractValue):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

LayoutTests:

  • fast/js/dfg-arrayify-elimination-expected.txt: Added.
  • fast/js/dfg-arrayify-elimination.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arrayify-elimination.js: Added.

(foo):

6:55 PM Changeset in webkit [132553] by keishi@webkit.org
  • 5 edits in trunk

Hide popup while transitioning from the suggestion picker to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=99537

Reviewed by Kent Tamura.

Source/WebCore:

Right now you can see a squished calendar picker while transitioning
from suggestion picker from calendar picker. This change will hide the
popup before opening the calendar picker.

No new tests.

  • Resources/pagepopups/pickerCommon.js: Hiding the window will also trigger a resize event so I created a separate event, didOpenPicker.

(hideWindow): Resize the window to 1x1 because we can't resize to 0x0.

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype.selectEntry): Hide the window first and then open the calendar picker.

LayoutTests:

  • fast/forms/resources/picker-common.js:

(popupOpenCallbackWrapper): Use didOpenPicker event.

6:51 PM Changeset in webkit [132552] by jochen@chromium.org
  • 12 edits
    1 copy
    1 add in trunk/Tools

[chromium] remove remaining usages of webkit_support from the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=100344

Reviewed by Adam Barth.

The most important part is to not rely on calling out to gdk/X11 to
translate keycodes to hardware keycodes, as this is not possible inside
the sandbox.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTTestRunner.h:

(WebKit):
(webkit_support):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::doDragDrop):
(WebTestRunner::EventSender::updateClickCountForButton):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::handleMouseWheel):
(WebTestRunner::EventSender::gestureEvent):
(WebTestRunner::EventSender::gestureFlingCancel):
(WebTestRunner::EventSender::gestureFlingStart):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.

(WebTestRunner):
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::getCurrentTimeInMillisecond):
(WebViewHost::getAbsoluteWebStringFromUTF8Path):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

6:49 PM Changeset in webkit [132551] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):

6:41 PM Changeset in webkit [132550] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove feed and feeds URL scheme workarounds
https://bugs.webkit.org/show_bug.cgi?id=100442

Reviewed by Dan Bernstein.

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):

6:35 PM WebInspector edited by toybabyyou@gmail.com
(diff)
6:20 PM Changeset in webkit [132549] by commit-queue@webkit.org
  • 27 edits
    6 deletes in trunk

Unreviewed, rolling out r132514.
http://trac.webkit.org/changeset/132514
https://bugs.webkit.org/show_bug.cgi?id=100440

"Broke chromium content_browsertests AccessibilityAriaMenu
AccessibilityInputRange AccessibilityListMarkers" (Requested
by scheib on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-25

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::contentChanged):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):

  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::contentChanged):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::contentChanged):
(AccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::contentChanged):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::scrollView):
(AccessibilityScrollView):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

Source/WebKit/chromium:

  • public/WebAccessibilityNotification.h:
  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

LayoutTests:

  • accessibility/aria-checkbox-sends-notification.html:
  • accessibility/notification-listeners.html:
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt:
  • platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt:
  • platform/chromium/accessibility/add-to-menu-list-crashes.html:
  • platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt: Removed.
  • platform/chromium/accessibility/is-ignored-change-sends-notification.html: Removed.
  • platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt: Removed.
  • platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html: Removed.
  • platform/chromium/accessibility/text-change-notification-expected.txt: Removed.
  • platform/chromium/accessibility/text-change-notification.html: Removed.
6:02 PM Changeset in webkit [132548] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Use per destination ID message receivers for DownloadProxy.
https://bugs.webkit.org/show_bug.cgi?id=100342

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-25
Reviewed by Anders Carlsson.

Per destination ID message receivers were proposed in r132386.
IPC messages of DownloadProxy use download ID for destination ID,
so the messages should be handled by the messsage receiver that was
newly proposed.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createDownloadProxy):
(WebKit::WebContext::downloadFinished):
(WebKit::WebContext::addMessageReceiver):
(WebKit):
(WebKit::WebContext::removeMessageReceiver):

  • UIProcess/WebContext.h:

(WebContext):

5:49 PM Changeset in webkit [132547] by scheib@chromium.org
  • 20 edits
    1 add in trunk/LayoutTests

Unreviewed rebaseline of tests failing after 132529 rolled out 132269.

See http://trac.webkit.org/changeset/132529 for details of the rollout.

  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
5:41 PM Changeset in webkit [132546] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

REGRESSION (r131793-r131826): Crash going to wikifonia.org
https://bugs.webkit.org/show_bug.cgi?id=100281

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Restore something that got lost in the resolve refactoring: the ability to give up on life if
we see a resolve of 'arguments'.

  • runtime/JSScope.cpp:

(JSC::JSScope::resolveContainingScopeInternal):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/resolve-arguments-from-scope-expected.txt: Added.
  • fast/js/resolve-arguments-from-scope.html: Added.
  • fast/js/script-tests/resolve-arguments-from-scope.js: Added.

(bar):
(foo):

5:04 PM Changeset in webkit [132545] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/12544626> [cg] RenderBlock::selectionGaps() is extremely slow when there are many floats
https://bugs.webkit.org/show_bug.cgi?id=100413

Reviewed by Anders Carlsson.

RenderBlock::selectionGaps() calls GraphicsContext::clipOut(const IntRect&) for each float.
Sped up the Core Graphics implementation of this function considerably by removing an
unnecessary call to CGContextGetClipBoundingBox.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipOut): Changed to use CGRectInfinite rather than the bounding
box of the current clip.

4:32 PM Changeset in webkit [132544] by zoltan@webkit.org
  • 2 edits
    2 moves
    2 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #4
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #4 commit of the whole patch.

  • PageLoad/svg/files/france.svg: Removed.
  • PageLoad/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
  • SVG/France.html: Added.
  • SVG/FrancoBolloGnomeEzechi.html: Added.
  • SVG/resources/France.svg: Copied from PerformanceTests/PageLoad/svg/files/france.svg.
  • SVG/resources/FrancoBolloGnomeEzechi.svg: Copied from PerformanceTests/PageLoad/svg/files/francobollo_gnome_ezechi_02.svg.
  • Skipped: Rename the files on the skipped list also.
4:26 PM Changeset in webkit [132543] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (132422): Tiles don't move when the Find dialog causes programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=100433
<rdar://problem/12575582>

Reviewed by Simon Fraser.

Actually update GraphicsLayer positions from updateMainFrameScrollPosition if
we're doing a programmatic scroll; otherwise programmatic scrolls while scrolling
on the main thread will short-circuit and end up only updating the GraphicsLayer's
notion of its current position, but never synchronizing that to the layer itself.

No new tests, as this is currently untestable.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

4:13 PM Changeset in webkit [132542] by Simon Fraser
  • 6 edits
    2 adds in trunk

Tiled layers are missing content on zooming
https://bugs.webkit.org/show_bug.cgi?id=100422

Reviewed by Beth Dakin.

Source/WebCore:

Tiled layers using TileCaches were missing content after
zooming. TileCache was confused in the presence of scaling;
it unapplies the scale on the layer above the tiles (so the tiles
live in screen space), and computed the tile coverage rect
in these tile coordinates. This worked for the page tile cache,
because its visibleRect was sent in pre-scaled. However, for
tiled layer TileCaches this was wrong.

Fix by scaling the tile coverage rect by m_scale before
using it to compute which tiles to throw away and bring in.

To fix the problem of the visibleRect being pre-scaled
for the page tile cache, remove the setting of the visibleRect
in RenderLayerCompositor::frameViewDidScroll(), and rely on
GraphicsLayerCA::updateVisibleRect() which computes the
visible rect in the correct, layer coordinates.

Test: compositing/tiling/tile-cache-zoomed.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateVisibleRect): Call setVisibleRect()
for all tile cache layers, not just tiled layer ones, but only do
the visible rect adjustment for those that are not the page tile cache.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::revalidateTiles): Use a coverageRectInTileCoords rect,
which is scaled to be in the same coordinate space as the tile grid.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll): Remove the code
that sets the setVisibleRect() on the TiledBacking.

LayoutTests:

New test for zooming with a tiled layer, and adjust an existing result.

  • compositing/tiling/tile-cache-zoomed-expected.txt: Added.
  • compositing/tiling/tile-cache-zoomed.html: Added.
  • platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
3:59 PM Changeset in webkit [132541] by roger_fong@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Add results for svg/custom/patter-scaling.svg on Windows after r132026.

  • platform/win/svg/custom/pattern-scaling-expected.txt: Added.
3:34 PM Changeset in webkit [132540] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

[V8] ActiveDOMNodes no longer require a separate wrapper map
https://bugs.webkit.org/show_bug.cgi?id=100352

Reviewed by Eric Seidel.

There is no longer any reason to keep a separate DOM wrapper map for
active DOM nodes. We can simply store them in the normal DOM node
wrapper map (which is more efficient because it doesn't use a HashMap).

  • bindings/scripts/CodeGeneratorV8.pm:

(GetDomMapName):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/IntrusiveDOMWrapperMap.h:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::getCachedWrapper):

3:20 PM Changeset in webkit [132539] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, fix the build on Mac.

Putting the getter in the Settings.h caused the global variable to be inlined and needing it to be exported.
Instead, put the implementation in the cpp file.

  • page/Settings.cpp:

(WebCore::Settings::defaultMinDOMTimerInterval):
(WebCore):
(WebCore::Settings::defaultDOMTimerAlignmentInterval):

  • page/Settings.h:

(Settings):

2:49 PM Changeset in webkit [132538] by tony@chromium.org
  • 5 edits in trunk/Source/WebCore

Move default DOM Timer values into Settings
https://bugs.webkit.org/show_bug.cgi?id=100405

Reviewed by Kenneth Russell.

Move the global values for defaultMinDOMTimerInterval and defaultDOMTimerAlignmentInterval into
the Settings object. This is more consistent with other global settings and allows us to remove
the setters on the DOMTimer object.

No new tests, this is a refactor.

  • page/DOMTimer.cpp: Remove globals.
  • page/DOMTimer.h:

(WebCore::DOMTimer::defaultMinTimerInterval): Call through to Settings
(WebCore::DOMTimer::defaultTimerAlignmentInterval): Call through to Settings.
(DOMTimer): Remove setters.

  • page/Settings.cpp:

(WebCore::Settings::setDefaultMinDOMTimerInterval): Use a global in Settings.
(WebCore::Settings::setDefaultDOMTimerAlignmentInterval): Use a global in Settings.

  • page/Settings.h:

(WebCore::Settings::defaultMinDOMTimerInterval): Inline the getter.
(WebCore::Settings::defaultDOMTimerAlignmentInterval): Inline the getter.
(Settings): Add globals.

2:42 PM Changeset in webkit [132537] by Simon Fraser
  • 4 edits
    4 adds in trunk

Report the tile coverage rect in layer coords, and add some tests for tiled backing and zooming
https://bugs.webkit.org/show_bug.cgi?id=100416

Reviewed by Beth Dakin.

Source/WebCore:

The tileCoverageRect is computed in "tile" coordinates, which don't match
the visibleRect coordinates. It's more useful when testing to see the
tile coverage relative to the view bounds, so unapply the scale whem
reporting tile coverage in tests.

Tests: platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled.html

platform/mac/tiled-drawing/tiled-drawing-zoom.html

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):

LayoutTests:

New tests that exercise the page tiled backing under zooming.

  • platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt: Added.
  • platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Added.
  • platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled.html: Added.
  • platform/mac/tiled-drawing/tiled-drawing-zoom.html: Added.
2:36 PM Changeset in webkit [132536] by commit-queue@webkit.org
  • 4 edits
    786 adds in trunk/LayoutTests

[EFL] Add baselines for non problematic tests in editing subcategories: deleting, inserting, selection and style.
https://bugs.webkit.org/show_bug.cgi?id=100126

Unreviewed EFL gardening.

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-10-25

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/deleting/4922367-expected.png: Added.
  • platform/efl/editing/deleting/4922367-expected.txt: Added.
  • platform/efl/editing/deleting/5099303-expected.png: Added.
  • platform/efl/editing/deleting/5099303-expected.txt: Added.
  • platform/efl/editing/deleting/5126166-expected.png: Added.
  • platform/efl/editing/deleting/5126166-expected.txt: Added.
  • platform/efl/editing/deleting/5144139-2-expected.png: Added.
  • platform/efl/editing/deleting/5144139-2-expected.txt: Added.
  • platform/efl/editing/deleting/5206311-1-expected.png: Added.
  • platform/efl/editing/deleting/5206311-1-expected.txt: Added.
  • platform/efl/editing/deleting/5272440-expected.png: Added.
  • platform/efl/editing/deleting/5272440-expected.txt: Added.
  • platform/efl/editing/deleting/5369009-expected.png: Added.
  • platform/efl/editing/deleting/5369009-expected.txt: Added.
  • platform/efl/editing/deleting/5433862-2-expected.png: Added.
  • platform/efl/editing/deleting/5433862-2-expected.txt: Added.
  • platform/efl/editing/deleting/5483370-expected.png: Added.
  • platform/efl/editing/deleting/5483370-expected.txt: Added.
  • platform/efl/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
  • platform/efl/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-3608445-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3608445-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-3608462-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3608462-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-3775172-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3775172-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-3857753-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3857753-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-3865854-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3865854-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3928305-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-4083333-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-4083333-fix-expected.txt: Added.
  • platform/efl/editing/deleting/delete-after-span-ws-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-after-span-ws-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-after-span-ws-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-after-span-ws-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-after-span-ws-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-after-span-ws-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/efl/editing/deleting/delete-and-undo-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-008-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: Added.
  • platform/efl/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/efl/editing/deleting/delete-at-start-or-end-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-contents-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-contents-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-contents-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-004-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-005-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-006-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-007-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-008-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-009-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-011-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-018-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-018-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-019-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-019-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-020-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-020-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-021-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-021-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-022-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-022-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-023-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-023-expected.txt: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-024-expected.png: Added.
  • platform/efl/editing/deleting/delete-block-merge-contents-024-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-004-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-005-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-005-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-006-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-006-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-007-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-007-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-008-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-008-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-009-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-009-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-010-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-010-expected.txt: Added.
  • platform/efl/editing/deleting/delete-br-013-expected.png: Added.
  • platform/efl/editing/deleting/delete-br-013-expected.txt: Added.
  • platform/efl/editing/deleting/delete-character-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-character-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-first-list-item-expected.png: Added.
  • platform/efl/editing/deleting/delete-first-list-item-expected.txt: Added.
  • platform/efl/editing/deleting/delete-hr-expected.png: Added.
  • platform/efl/editing/deleting/delete-hr-expected.txt: Added.
  • platform/efl/editing/deleting/delete-image-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-image-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-image-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-image-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-image-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-image-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-image-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-image-004-expected.txt: Added.
  • platform/efl/editing/deleting/delete-leading-ws-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-leading-ws-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-004-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-005-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-005-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-006-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-006-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-007-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-007-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-008-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-008-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-009-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-009-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-010-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-010-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-011-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-012-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-012-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-013-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-013-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-014-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-014-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-015-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-015-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-016-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-016-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-017-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-017-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-end-ws-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-line-end-ws-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-listitem-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-listitem-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-listitem-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-listitem-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-selection-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-selection-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-tab-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-tab-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-tab-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-tab-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/efl/editing/deleting/delete-to-select-table-expected.txt: Added.
  • platform/efl/editing/deleting/delete-trailing-ws-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-trailing-ws-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-trailing-ws-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-003-expected.png: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-003-expected.txt: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-004-expected.png: Added.
  • platform/efl/editing/deleting/delete-ws-fixup-004-expected.txt: Added.
  • platform/efl/editing/deleting/forward-delete-expected.png: Added.
  • platform/efl/editing/deleting/forward-delete-expected.txt: Added.
  • platform/efl/editing/deleting/list-item-1-expected.png: Added.
  • platform/efl/editing/deleting/list-item-1-expected.txt: Added.
  • platform/efl/editing/deleting/merge-different-styles-expected.png: Added.
  • platform/efl/editing/deleting/merge-different-styles-expected.txt: Added.
  • platform/efl/editing/deleting/merge-endOfParagraph-expected.png: Added.
  • platform/efl/editing/deleting/merge-endOfParagraph-expected.txt: Added.
  • platform/efl/editing/deleting/merge-no-br-expected.png: Added.
  • platform/efl/editing/deleting/merge-no-br-expected.txt: Added.
  • platform/efl/editing/deleting/merge-unrendered-space-expected.png: Added.
  • platform/efl/editing/deleting/merge-unrendered-space-expected.txt: Added.
  • platform/efl/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/efl/editing/deleting/merge-whitespace-pre-expected.txt: Added.
  • platform/efl/editing/deleting/move-nodes-001-expected.png: Added.
  • platform/efl/editing/deleting/move-nodes-001-expected.txt: Added.
  • platform/efl/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/efl/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/efl/editing/deleting/pruning-after-merge-2-expected.png: Added.
  • platform/efl/editing/deleting/pruning-after-merge-2-expected.txt: Added.
  • platform/efl/editing/deleting/smart-delete-001-expected.png: Added.
  • platform/efl/editing/deleting/smart-delete-001-expected.txt: Added.
  • platform/efl/editing/deleting/smart-delete-002-expected.png: Added.
  • platform/efl/editing/deleting/table-cells-expected.png: Added.
  • platform/efl/editing/deleting/table-cells-expected.txt: Added.
  • platform/efl/editing/deleting/transpose-empty-expected.png: Added.
  • platform/efl/editing/deleting/transpose-empty-expected.txt: Added.
  • platform/efl/editing/deleting/type-delete-after-quote-expected.png: Added.
  • platform/efl/editing/deleting/type-delete-after-quote-expected.txt: Added.
  • platform/efl/editing/inserting/12882-expected.png: Added.
  • platform/efl/editing/inserting/12882-expected.txt: Added.
  • platform/efl/editing/inserting/4278698-expected.png: Added.
  • platform/efl/editing/inserting/4278698-expected.txt: Added.
  • platform/efl/editing/inserting/4840662-expected.png: Added.
  • platform/efl/editing/inserting/4840662-expected.txt: Added.
  • platform/efl/editing/inserting/4875189-1-expected.png: Added.
  • platform/efl/editing/inserting/4875189-1-expected.txt: Added.
  • platform/efl/editing/inserting/4875189-2-expected.png: Added.
  • platform/efl/editing/inserting/4875189-2-expected.txt: Added.
  • platform/efl/editing/inserting/4959067-expected.png: Added.
  • platform/efl/editing/inserting/4959067-expected.txt: Added.
  • platform/efl/editing/inserting/4960120-1-expected.png: Added.
  • platform/efl/editing/inserting/4960120-1-expected.txt: Added.
  • platform/efl/editing/inserting/4960120-2-expected.png: Added.
  • platform/efl/editing/inserting/4960120-2-expected.txt: Added.
  • platform/efl/editing/inserting/5002441-expected.png: Added.
  • platform/efl/editing/inserting/5002441-expected.txt: Added.
  • platform/efl/editing/inserting/5058163-1-expected.png: Added.
  • platform/efl/editing/inserting/5058163-1-expected.txt: Added.
  • platform/efl/editing/inserting/5058163-2-expected.png: Added.
  • platform/efl/editing/inserting/5058163-2-expected.txt: Added.
  • platform/efl/editing/inserting/5156401-2-expected.png: Added.
  • platform/efl/editing/inserting/5156401-2-expected.txt: Added.
  • platform/efl/editing/inserting/5418891-expected.png: Added.
  • platform/efl/editing/inserting/5418891-expected.txt: Added.
  • platform/efl/editing/inserting/5510537-expected.png: Added.
  • platform/efl/editing/inserting/5510537-expected.txt: Added.
  • platform/efl/editing/inserting/5549929-2-expected.png: Added.
  • platform/efl/editing/inserting/5549929-2-expected.txt: Added.
  • platform/efl/editing/inserting/5549929-3-expected.png: Added.
  • platform/efl/editing/inserting/5549929-3-expected.txt: Added.
  • platform/efl/editing/inserting/6703873-expected.png: Added.
  • platform/efl/editing/inserting/6703873-expected.txt: Added.
  • platform/efl/editing/inserting/editable-html-element-expected.png: Added.
  • platform/efl/editing/inserting/editable-html-element-expected.txt: Added.
  • platform/efl/editing/inserting/editable-inline-element-expected.png: Added.
  • platform/efl/editing/inserting/editable-inline-element-expected.txt: Added.
  • platform/efl/editing/inserting/edited-whitespace-1-expected.png: Added.
  • platform/efl/editing/inserting/edited-whitespace-1-expected.txt: Added.
  • platform/efl/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/efl/editing/inserting/editing-empty-divs-expected.txt: Added.
  • platform/efl/editing/inserting/insert-3654864-fix-expected.png: Added.
  • platform/efl/editing/inserting/insert-3654864-fix-expected.txt: Added.
  • platform/efl/editing/inserting/insert-3775316-fix-expected.png: Added.
  • platform/efl/editing/inserting/insert-3775316-fix-expected.txt: Added.
  • platform/efl/editing/inserting/insert-3778059-fix-expected.png: Added.
  • platform/efl/editing/inserting/insert-3778059-fix-expected.txt: Added.
  • platform/efl/editing/inserting/insert-3800346-fix-expected.png: Added.
  • platform/efl/editing/inserting/insert-3800346-fix-expected.txt: Added.
  • platform/efl/editing/inserting/insert-3851164-fix-expected.png: Added.
  • platform/efl/editing/inserting/insert-3851164-fix-expected.txt: Added.
  • platform/efl/editing/inserting/insert-after-delete-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-after-delete-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-at-end-01-expected.png: Added.
  • platform/efl/editing/inserting/insert-at-end-01-expected.txt: Added.
  • platform/efl/editing/inserting/insert-at-end-02-expected.png: Added.
  • platform/efl/editing/inserting/insert-at-end-02-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-002-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-002-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-003-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-003-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-004-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-004-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-005-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-005-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-006-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-006-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-007-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-007-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-008-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-008-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-009-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-009-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-at-tabspan-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-at-tabspan-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-at-tabspan-002-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-at-tabspan-002-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-at-tabspan-003-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-at-tabspan-003-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-quoted-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-quoted-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-quoted-002-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-quoted-002-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-quoted-003-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-quoted-003-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-quoted-004-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-quoted-004-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-quoted-005-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-quoted-005-expected.txt: Added.
  • platform/efl/editing/inserting/insert-br-quoted-006-expected.png: Added.
  • platform/efl/editing/inserting/insert-br-quoted-006-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-002-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-002-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-003-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-003-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-004-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-004-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-005-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-005-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-006-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-006-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-007-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-007-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-008-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-008-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-009-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-009-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-010-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-010-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-011-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-011-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-012-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-012-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-013-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-013-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-014-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-014-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-015-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-015-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-016-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-016-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-017-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-017-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-018-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-018-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-019-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-019-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-020-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-020-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-022-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-022-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-023-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-023-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-024-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-024-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-025-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-025-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-026-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-026-expected.txt: Added.
  • platform/efl/editing/inserting/insert-div-027-expected.png: Added.
  • platform/efl/editing/inserting/insert-div-027-expected.txt: Added.
  • platform/efl/editing/inserting/insert-paragraph-01-expected.png: Added.
  • platform/efl/editing/inserting/insert-paragraph-01-expected.txt: Added.
  • platform/efl/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/efl/editing/inserting/insert-paragraph-02-expected.txt: Added.
  • platform/efl/editing/inserting/insert-paragraph-03-expected.png: Added.
  • platform/efl/editing/inserting/insert-paragraph-03-expected.txt: Added.
  • platform/efl/editing/inserting/insert-paragraph-04-expected.png: Added.
  • platform/efl/editing/inserting/insert-paragraph-04-expected.txt: Added.
  • platform/efl/editing/inserting/insert-paragraph-05-expected.png: Added.
  • platform/efl/editing/inserting/insert-paragraph-05-expected.txt: Added.
  • platform/efl/editing/inserting/insert-space-in-empty-doc-expected.png: Added.
  • platform/efl/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
  • platform/efl/editing/inserting/insert-tab-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-tab-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/efl/editing/inserting/insert-tab-002-expected.txt: Added.
  • platform/efl/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/efl/editing/inserting/insert-tab-003-expected.txt: Added.
  • platform/efl/editing/inserting/insert-tab-004-expected.png: Added.
  • platform/efl/editing/inserting/insert-tab-004-expected.txt: Added.
  • platform/efl/editing/inserting/insert-text-at-tabspan-001-expected.png: Added.
  • platform/efl/editing/inserting/insert-text-at-tabspan-001-expected.txt: Added.
  • platform/efl/editing/inserting/insert-text-at-tabspan-002-expected.png: Added.
  • platform/efl/editing/inserting/insert-text-at-tabspan-002-expected.txt: Added.
  • platform/efl/editing/inserting/insert-text-at-tabspan-003-expected.png: Added.
  • platform/efl/editing/inserting/insert-text-at-tabspan-003-expected.txt: Added.
  • platform/efl/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/efl/editing/inserting/insert-text-with-newlines-expected.txt: Added.
  • platform/efl/editing/inserting/line-break-expected.png: Added.
  • platform/efl/editing/inserting/line-break-expected.txt: Added.
  • platform/efl/editing/inserting/multiple-lines-selected-expected.png: Added.
  • platform/efl/editing/inserting/multiple-lines-selected-expected.txt: Added.
  • platform/efl/editing/inserting/paragraph-separator-01-expected.png: Added.
  • platform/efl/editing/inserting/paragraph-separator-01-expected.txt: Added.
  • platform/efl/editing/inserting/paragraph-separator-02-expected.png: Added.
  • platform/efl/editing/inserting/paragraph-separator-02-expected.txt: Added.
  • platform/efl/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/efl/editing/inserting/paragraph-separator-03-expected.txt: Added.
  • platform/efl/editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
  • platform/efl/editing/inserting/paragraph-separator-in-table-1-expected.txt: Added.
  • platform/efl/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
  • platform/efl/editing/inserting/paragraph-separator-in-table-2-expected.txt: Added.
  • platform/efl/editing/inserting/redo-expected.png: Added.
  • platform/efl/editing/inserting/redo-expected.txt: Added.
  • platform/efl/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/efl/editing/inserting/return-key-with-selection-001-expected.txt: Added.
  • platform/efl/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/efl/editing/inserting/return-key-with-selection-002-expected.txt: Added.
  • platform/efl/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/efl/editing/inserting/return-key-with-selection-003-expected.txt: Added.
  • platform/efl/editing/inserting/typing-001-expected.png: Added.
  • platform/efl/editing/inserting/typing-001-expected.txt: Added.
  • platform/efl/editing/inserting/typing-002-expected.png: Added.
  • platform/efl/editing/inserting/typing-002-expected.txt: Added.
  • platform/efl/editing/inserting/typing-003-expected.png: Added.
  • platform/efl/editing/inserting/typing-003-expected.txt: Added.
  • platform/efl/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/efl/editing/inserting/typing-around-br-001-expected.txt: Added.
  • platform/efl/editing/inserting/typing-around-image-001-expected.png: Added.
  • platform/efl/editing/inserting/typing-around-image-001-expected.txt: Added.
  • platform/efl/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/efl/editing/inserting/typing-at-end-of-line-expected.txt: Added.
  • platform/efl/editing/selection/13804-expected.png: Added.
  • platform/efl/editing/selection/13804-expected.txt: Added.
  • platform/efl/editing/selection/14971-expected.png: Added.
  • platform/efl/editing/selection/14971-expected.txt: Added.
  • platform/efl/editing/selection/4402375-expected.png: Added.
  • platform/efl/editing/selection/4402375-expected.txt: Added.
  • platform/efl/editing/selection/4776665-expected.png: Added.
  • platform/efl/editing/selection/4776665-expected.txt: Added.
  • platform/efl/editing/selection/4818145-expected.png: Added.
  • platform/efl/editing/selection/4818145-expected.txt: Added.
  • platform/efl/editing/selection/4866671-expected.png: Added.
  • platform/efl/editing/selection/4866671-expected.txt: Added.
  • platform/efl/editing/selection/4889598-expected.png: Added.
  • platform/efl/editing/selection/4889598-expected.txt: Added.
  • platform/efl/editing/selection/4895428-2-expected.png: Added.
  • platform/efl/editing/selection/4895428-2-expected.txt: Added.
  • platform/efl/editing/selection/4932260-1-expected.png: Added.
  • platform/efl/editing/selection/4932260-1-expected.txt: Added.
  • platform/efl/editing/selection/4932260-2-expected.png: Added.
  • platform/efl/editing/selection/4932260-2-expected.txt: Added.
  • platform/efl/editing/selection/4932260-3-expected.png: Added.
  • platform/efl/editing/selection/4932260-3-expected.txt: Added.
  • platform/efl/editing/selection/4947387-expected.png: Added.
  • platform/efl/editing/selection/4947387-expected.txt: Added.
  • platform/efl/editing/selection/4960116-expected.png: Added.
  • platform/efl/editing/selection/4960116-expected.txt: Added.
  • platform/efl/editing/selection/4960137-expected.png: Added.
  • platform/efl/editing/selection/4960137-expected.txt: Added.
  • platform/efl/editing/selection/4983858-expected.png: Added.
  • platform/efl/editing/selection/4983858-expected.txt: Added.
  • platform/efl/editing/selection/5057506-2-expected.png: Added.
  • platform/efl/editing/selection/5057506-2-expected.txt: Added.
  • platform/efl/editing/selection/5076323-1-expected.png: Added.
  • platform/efl/editing/selection/5076323-1-expected.txt: Added.
  • platform/efl/editing/selection/5076323-2-expected.png: Added.
  • platform/efl/editing/selection/5076323-2-expected.txt: Added.
  • platform/efl/editing/selection/5076323-3-expected.png: Added.
  • platform/efl/editing/selection/5076323-3-expected.txt: Added.
  • platform/efl/editing/selection/5081257-1-expected.png: Added.
  • platform/efl/editing/selection/5081257-1-expected.txt: Added.
  • platform/efl/editing/selection/5081257-2-expected.png: Added.
  • platform/efl/editing/selection/5081257-2-expected.txt: Added.
  • platform/efl/editing/selection/5099303-expected.png: Added.
  • platform/efl/editing/selection/5099303-expected.txt: Added.
  • platform/efl/editing/selection/5131716-1-expected.png: Added.
  • platform/efl/editing/selection/5131716-1-expected.txt: Added.
  • platform/efl/editing/selection/5131716-2-expected.png: Added.
  • platform/efl/editing/selection/5131716-2-expected.txt: Added.
  • platform/efl/editing/selection/5131716-3-expected.png: Added.
  • platform/efl/editing/selection/5131716-3-expected.txt: Added.
  • platform/efl/editing/selection/5131716-4-expected.png: Added.
  • platform/efl/editing/selection/5131716-4-expected.txt: Added.
  • platform/efl/editing/selection/5195166-2-expected.png: Added.
  • platform/efl/editing/selection/5195166-2-expected.txt: Added.
  • platform/efl/editing/selection/5232159-expected.png: Added.
  • platform/efl/editing/selection/5232159-expected.txt: Added.
  • platform/efl/editing/selection/5234383-1-expected.png: Added.
  • platform/efl/editing/selection/5234383-1-expected.txt: Added.
  • platform/efl/editing/selection/5234383-2-expected.png: Added.
  • platform/efl/editing/selection/5234383-2-expected.txt: Added.
  • platform/efl/editing/selection/5240265-expected.png: Added.
  • platform/efl/editing/selection/5240265-expected.txt: Added.
  • platform/efl/editing/selection/5333725-expected.png: Added.
  • platform/efl/editing/selection/5333725-expected.txt: Added.
  • platform/efl/editing/selection/6476-expected.png: Added.
  • platform/efl/editing/selection/6476-expected.txt: Added.
  • platform/efl/editing/selection/7152-1-expected.png: Added.
  • platform/efl/editing/selection/7152-1-expected.txt: Added.
  • platform/efl/editing/selection/addRange-expected.png: Added.
  • platform/efl/editing/selection/addRange-expected.txt: Added.
  • platform/efl/editing/selection/after-line-wrap-expected.png: Added.
  • platform/efl/editing/selection/after-line-wrap-expected.txt: Added.
  • platform/efl/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/efl/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/efl/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/efl/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/efl/editing/selection/caret-ltr-expected.png: Added.
  • platform/efl/editing/selection/caret-ltr-expected.txt: Added.
  • platform/efl/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/efl/editing/selection/caret-rtl-2-expected.txt: Added.
  • platform/efl/editing/selection/caret-rtl-expected.png: Added.
  • platform/efl/editing/selection/caret-rtl-expected.txt: Added.
  • platform/efl/editing/selection/clear-selection-expected.png: Added.
  • platform/efl/editing/selection/clear-selection-expected.txt: Added.
  • platform/efl/editing/selection/click-start-of-line-expected.png: Added.
  • platform/efl/editing/selection/click-start-of-line-expected.txt: Added.
  • platform/efl/editing/selection/contenteditable-click-inside-expected.png: Added.
  • platform/efl/editing/selection/contenteditable-click-inside-expected.txt: Added.
  • platform/efl/editing/selection/display-table-text-expected.png: Added.
  • platform/efl/editing/selection/display-table-text-expected.txt: Added.
  • platform/efl/editing/selection/drag-in-iframe-expected.png: Added.
  • platform/efl/editing/selection/drag-in-iframe-expected.txt: Added.
  • platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
  • platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
  • platform/efl/editing/selection/editable-html-element-expected.png: Added.
  • platform/efl/editing/selection/editable-html-element-expected.txt: Added.
  • platform/efl/editing/selection/editable-links-expected.png: Added.
  • platform/efl/editing/selection/editable-links-expected.txt: Added.
  • platform/efl/editing/selection/editable-non-editable-crash-expected.png: Added.
  • platform/efl/editing/selection/editable-non-editable-crash-expected.txt: Added.
  • platform/efl/editing/selection/end-of-document-expected.png: Added.
  • platform/efl/editing/selection/end-of-document-expected.txt: Added.
  • platform/efl/editing/selection/expanding-selections-expected.png: Added.
  • platform/efl/editing/selection/expanding-selections-expected.txt: Added.
  • platform/efl/editing/selection/expanding-selections2-expected.png: Added.
  • platform/efl/editing/selection/expanding-selections2-expected.txt: Added.
  • platform/efl/editing/selection/extend-by-character-001-expected.png: Added.
  • platform/efl/editing/selection/extend-by-character-001-expected.txt: Added.
  • platform/efl/editing/selection/extend-by-character-004-expected.png: Added.
  • platform/efl/editing/selection/extend-by-character-004-expected.txt: Added.
  • platform/efl/editing/selection/extend-by-character-005-expected.png: Added.
  • platform/efl/editing/selection/extend-by-character-005-expected.txt: Added.
  • platform/efl/editing/selection/extend-by-character-006-expected.png: Added.
  • platform/efl/editing/selection/extend-by-character-006-expected.txt: Added.
  • platform/efl/editing/selection/extend-by-sentence-001-expected.png: Added.
  • platform/efl/editing/selection/extend-by-sentence-001-expected.txt: Added.
  • platform/efl/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/efl/editing/selection/extend-by-word-001-expected.txt: Added.
  • platform/efl/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/efl/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
  • platform/efl/editing/selection/focus-body-expected.png: Added.
  • platform/efl/editing/selection/focus-body-expected.txt: Added.
  • platform/efl/editing/selection/focus_editable_html-expected.png: Added.
  • platform/efl/editing/selection/focus_editable_html-expected.txt: Added.
  • platform/efl/editing/selection/image-before-linebreak-expected.png: Added.
  • platform/efl/editing/selection/image-before-linebreak-expected.txt: Added.
  • platform/efl/editing/selection/inline-closest-leaf-child-expected.png: Added.
  • platform/efl/editing/selection/inline-closest-leaf-child-expected.txt: Added.
  • platform/efl/editing/selection/leave-requested-block-expected.png: Added.
  • platform/efl/editing/selection/leave-requested-block-expected.txt: Added.
  • platform/efl/editing/selection/line-wrap-1-expected.png: Added.
  • platform/efl/editing/selection/line-wrap-1-expected.txt: Added.
  • platform/efl/editing/selection/line-wrap-2-expected.png: Added.
  • platform/efl/editing/selection/line-wrap-2-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-1-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-1-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-2-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-2-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-3-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-3-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-4-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-4-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-5-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-5-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-8-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-8-expected.txt: Added.
  • platform/efl/editing/selection/mixed-editability-9-expected.png: Added.
  • platform/efl/editing/selection/mixed-editability-9-expected.txt: Added.
  • platform/efl/editing/selection/move-3875618-fix-expected.png: Added.
  • platform/efl/editing/selection/move-3875618-fix-expected.txt: Added.
  • platform/efl/editing/selection/move-3875641-fix-expected.png: Added.
  • platform/efl/editing/selection/move-3875641-fix-expected.txt: Added.
  • platform/efl/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/efl/editing/selection/move-backwords-by-word-001-expected.txt: Added.
  • platform/efl/editing/selection/move-between-blocks-no-001-expected.png: Added.
  • platform/efl/editing/selection/move-between-blocks-no-001-expected.txt: Added.
  • platform/efl/editing/selection/move-between-blocks-yes-001-expected.png: Added.
  • platform/efl/editing/selection/move-between-blocks-yes-001-expected.txt: Added.
  • platform/efl/editing/selection/move-by-character-001-expected.png: Added.
  • platform/efl/editing/selection/move-by-character-001-expected.txt: Added.
  • platform/efl/editing/selection/move-by-character-002-expected.png: Added.
  • platform/efl/editing/selection/move-by-character-002-expected.txt: Added.
  • platform/efl/editing/selection/move-by-character-003-expected.png: Added.
  • platform/efl/editing/selection/move-by-character-003-expected.txt: Added.
  • platform/efl/editing/selection/move-by-character-004-expected.png: Added.
  • platform/efl/editing/selection/move-by-character-004-expected.txt: Added.
  • platform/efl/editing/selection/move-by-character-005-expected.png: Added.
  • platform/efl/editing/selection/move-by-character-005-expected.txt: Added.
  • platform/efl/editing/selection/move-by-character-6-expected.png: Added.
  • platform/efl/editing/selection/move-by-character-6-expected.txt: Added.
  • platform/efl/editing/selection/move-by-line-001-expected.png: Added.
  • platform/efl/editing/selection/move-by-line-001-expected.txt: Added.
  • platform/efl/editing/selection/move-by-line-002-expected.png: Added.
  • platform/efl/editing/selection/move-by-line-002-expected.txt: Added.
  • platform/efl/editing/selection/move-by-sentence-001-expected.png: Added.
  • platform/efl/editing/selection/move-by-sentence-001-expected.txt: Added.
  • platform/efl/editing/selection/move-by-sentence-linebreak-expected.png: Added.
  • platform/efl/editing/selection/move-by-sentence-linebreak-expected.txt: Added.
  • platform/efl/editing/selection/move-by-word-001-expected.png: Added.
  • platform/efl/editing/selection/move-by-word-001-expected.txt: Added.
  • platform/efl/editing/selection/move-past-trailing-space-expected.png: Added.
  • platform/efl/editing/selection/move-past-trailing-space-expected.txt: Added.
  • platform/efl/editing/selection/node-removal-1-expected.png: Added.
  • platform/efl/editing/selection/node-removal-1-expected.txt: Added.
  • platform/efl/editing/selection/previous-line-position-expected.png: Added.
  • platform/efl/editing/selection/previous-line-position-expected.txt: Added.
  • platform/efl/editing/selection/replace-selection-1-expected.png: Added.
  • platform/efl/editing/selection/replace-selection-1-expected.txt: Added.
  • platform/efl/editing/selection/replaced-boundaries-1-expected.png: Added.
  • platform/efl/editing/selection/replaced-boundaries-1-expected.txt: Added.
  • platform/efl/editing/selection/replaced-boundaries-2-expected.png: Added.
  • platform/efl/editing/selection/replaced-boundaries-2-expected.txt: Added.
  • platform/efl/editing/selection/select-all-001-expected.png: Added.
  • platform/efl/editing/selection/select-all-001-expected.txt: Added.
  • platform/efl/editing/selection/select-all-iframe-expected.png: Added.
  • platform/efl/editing/selection/select-all-iframe-expected.txt: Added.
  • platform/efl/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
  • platform/efl/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/efl/editing/selection/selectNode-expected.png: Added.
  • platform/efl/editing/selection/selectNode-expected.txt: Added.
  • platform/efl/editing/selection/selectNodeContents-expected.png: Added.
  • platform/efl/editing/selection/selectNodeContents-expected.txt: Added.
  • platform/efl/editing/selection/selection-3748164-fix-expected.png: Added.
  • platform/efl/editing/selection/selection-3748164-fix-expected.txt: Added.
  • platform/efl/editing/selection/table-caret-1-expected.png: Added.
  • platform/efl/editing/selection/table-caret-1-expected.txt: Added.
  • platform/efl/editing/selection/table-caret-2-expected.png: Added.
  • platform/efl/editing/selection/table-caret-2-expected.txt: Added.
  • platform/efl/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/efl/editing/selection/transformed-selection-rects-expected.txt: Added.
  • platform/efl/editing/selection/triple-click-in-pre-expected.png: Added.
  • platform/efl/editing/selection/triple-click-in-pre-expected.txt: Added.
  • platform/efl/editing/selection/unrendered-001-expected.png: Added.
  • platform/efl/editing/selection/unrendered-001-expected.txt: Added.
  • platform/efl/editing/selection/unrendered-002-expected.png: Added.
  • platform/efl/editing/selection/unrendered-002-expected.txt: Added.
  • platform/efl/editing/selection/unrendered-003-expected.png: Added.
  • platform/efl/editing/selection/unrendered-003-expected.txt: Added.
  • platform/efl/editing/selection/unrendered-004-expected.png: Added.
  • platform/efl/editing/selection/unrendered-004-expected.txt: Added.
  • platform/efl/editing/selection/unrendered-005-expected.png: Added.
  • platform/efl/editing/selection/unrendered-005-expected.txt: Added.
  • platform/efl/editing/selection/unrendered-space-expected.png: Added.
  • platform/efl/editing/selection/unrendered-space-expected.txt: Added.
  • platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
  • platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png: Added.
  • platform/efl/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt: Added.
  • platform/efl/editing/selection/word-granularity-expected.png: Added.
  • platform/efl/editing/selection/word-granularity-expected.txt: Added.
  • platform/efl/editing/selection/wrapped-line-caret-1-expected.png: Added.
  • platform/efl/editing/selection/wrapped-line-caret-1-expected.txt: Added.
  • platform/efl/editing/selection/wrapped-line-caret-2-expected.png: Added.
  • platform/efl/editing/selection/wrapped-line-caret-2-expected.txt: Added.
  • platform/efl/editing/style/4916887-expected.png: Added.
  • platform/efl/editing/style/4916887-expected.txt: Added.
  • platform/efl/editing/style/5017613-2-expected.png: Added.
  • platform/efl/editing/style/5017613-2-expected.txt: Added.
  • platform/efl/editing/style/5046875-2-expected.png: Added.
  • platform/efl/editing/style/5046875-2-expected.txt: Added.
  • platform/efl/editing/style/5084241-expected.png: Added.
  • platform/efl/editing/style/5084241-expected.txt: Added.
  • platform/efl/editing/style/apple-style-editable-mix-expected.png: Added.
  • platform/efl/editing/style/apple-style-editable-mix-expected.txt: Added.
  • platform/efl/editing/style/block-style-001-expected.png: Added.
  • platform/efl/editing/style/block-style-001-expected.txt: Added.
  • platform/efl/editing/style/block-style-002-expected.png: Added.
  • platform/efl/editing/style/block-style-002-expected.txt: Added.
  • platform/efl/editing/style/block-style-003-expected.png: Added.
  • platform/efl/editing/style/block-style-003-expected.txt: Added.
  • platform/efl/editing/style/block-styles-007-expected.png: Added.
  • platform/efl/editing/style/block-styles-007-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-001-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-001-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-002-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-003-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-004-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-005-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-005-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-006-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-007-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-007-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-008-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-009-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-010-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-010-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-011-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-012-expected.txt: Added.
  • platform/efl/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/efl/editing/style/create-block-for-style-013-expected.txt: Added.
  • platform/efl/editing/style/designmode-expected.png: Added.
  • platform/efl/editing/style/designmode-expected.txt: Added.
  • platform/efl/editing/style/highlight-expected.png: Added.
  • platform/efl/editing/style/highlight-expected.txt: Added.
  • platform/efl/editing/style/relative-font-size-change-001-expected.png: Added.
  • platform/efl/editing/style/relative-font-size-change-001-expected.txt: Added.
  • platform/efl/editing/style/relative-font-size-change-002-expected.png: Added.
  • platform/efl/editing/style/relative-font-size-change-002-expected.txt: Added.
  • platform/efl/editing/style/relative-font-size-change-003-expected.png: Added.
  • platform/efl/editing/style/relative-font-size-change-003-expected.txt: Added.
  • platform/efl/editing/style/relative-font-size-change-004-expected.png: Added.
  • platform/efl/editing/style/relative-font-size-change-004-expected.txt: Added.
  • platform/efl/editing/style/smoosh-styles-003-expected.png: Added.
  • platform/efl/editing/style/style-3681552-fix-001-expected.png: Added.
  • platform/efl/editing/style/style-3681552-fix-002-expected.png: Added.
  • platform/efl/editing/style/style-3681552-fix-002-expected.txt: Added.
  • platform/efl/editing/style/style-3998892-fix-expected.png: Added.
  • platform/efl/editing/style/style-3998892-fix-expected.txt: Added.
  • platform/efl/editing/style/style-boundary-001-expected.png: Added.
  • platform/efl/editing/style/style-boundary-001-expected.txt: Added.
  • platform/efl/editing/style/style-boundary-002-expected.png: Added.
  • platform/efl/editing/style/style-boundary-003-expected.png: Added.
  • platform/efl/editing/style/style-boundary-004-expected.png: Added.
  • platform/efl/editing/style/style-boundary-004-expected.txt: Added.
  • platform/efl/editing/style/table-selection-expected.png: Added.
  • platform/efl/editing/style/table-selection-expected.txt: Added.
  • platform/efl/editing/style/typing-style-001-expected.png: Added.
  • platform/efl/editing/style/typing-style-002-expected.png: Added.
  • platform/efl/editing/style/unbold-in-bold-expected.png: Added.
  • platform/efl/editing/style/unbold-in-bold-expected.txt: Added.
2:15 PM Changeset in webkit [132535] by commit-queue@webkit.org
  • 9 edits
    1 copy
    3 adds in trunk/Source/WebKit2

[EFL][WK2] Add Ewk_Popup_Menu API
https://bugs.webkit.org/show_bug.cgi?id=100404

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Add new Ewk_Popup_Menu API to complete the existing
Ewk_Popup_Menu_Item one. This way, we can move the
popup menu code out of Ewk_View.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::requestPopupMenu):
(EwkViewImpl::closePopupMenu):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_popup_menu.cpp: Added.

(Ewk_Popup_Menu::Ewk_Popup_Menu):
(Ewk_Popup_Menu::~Ewk_Popup_Menu):
(Ewk_Popup_Menu::close):
(Ewk_Popup_Menu::items):
(Ewk_Popup_Menu::selectedIndex):
(Ewk_Popup_Menu::setSelectedIndex):
(ewk_popup_menu_close):
(ewk_popup_menu_selected_index_set):
(ewk_popup_menu_selected_index_get):
(ewk_popup_menu_items_get):

  • UIProcess/API/efl/ewk_popup_menu.h: Added.
  • UIProcess/API/efl/ewk_popup_menu_private.h: Copied from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp.

(WebKit):
(Ewk_Popup_Menu):
(Ewk_Popup_Menu::create):

  • UIProcess/API/efl/ewk_view.cpp:
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp: Added.

(checkBasicPopupMenuItem):
(selectItemAfterDelayed):
(showPopupMenu):
(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:
  • UIProcess/efl/WebPopupMenuProxyEfl.cpp:

(WebKit::WebPopupMenuProxyEfl::hidePopupMenu):

2:08 PM Changeset in webkit [132534] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Close the IconDatabase before the WebContext gets destroyed
https://bugs.webkit.org/show_bug.cgi?id=100389

Reviewed by Alexis Menard.

The WebContext normally gets destroyed 60 seconds after the last page is
closed and will take down the WebIconDatabase with itself if nothing
holds a reference to it at this moment.
We need to close the IconDatabase explicitely before this happens
to terminate it cleanly and avoid leaking its thread.

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::~QtWebIconDatabaseClient):

2:04 PM Changeset in webkit [132533] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Regression: navigating between composited pages doesn't cause redraw until scrolled
https://bugs.webkit.org/show_bug.cgi?id=100396

Patch by James Robinson <jamesr@chromium.org> on 2012-10-25
Reviewed by Adrienne Walker.

This partially reverts r132173. It's not valid to suppress invalidations in commitDocumentData since for small
or cached pages this could load up the whole document. Also adds and improves some of the tracing.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::commitDocumentData):
(WebKit::WebFrameImpl::createFrameView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scheduleComposite):

2:02 PM Changeset in webkit [132532] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaselining failing expected results for fast/css/image-set-setting.html on Windows after r132388.

  • platform/win/fast/css/image-set-setting-expected.txt:
2:00 PM Changeset in webkit [132531] by zoltan@webkit.org
  • 1 edit
    4 moves
    4 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #3
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #3 commit of the whole patch.

  • PageLoad/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
  • PageLoad/svg/files/44057-drops on a blade.svg: Removed.
  • PageLoad/svg/files/deb9frac1.svg: Removed.
  • PageLoad/svg/files/food_leif_lodahl_01.svg: Removed.
  • SVG/Debian.html: Added.
  • SVG/DropsOnABlade.html: Added.
  • SVG/FlowerFromMyGarden.html: Added.
  • SVG/FoodLeifLodahl.html: Added.
  • SVG/resources/Debian.svg: Copied from PerformanceTests/PageLoad/svg/files/deb9frac1.svg.
  • SVG/resources/DropsOnABlade.svg: Copied from PerformanceTests/PageLoad/svg/files/44057-drops%20on%20a%20blade.svg.
  • SVG/resources/FlowerFromMyGarden.svg: Copied from PerformanceTests/PageLoad/svg/files/42470-flower_from_my_garden_v2.svg.
  • SVG/resources/FoodLeifLodahl.svg: Copied from PerformanceTests/PageLoad/svg/files/food_leif_lodahl_01.svg.
1:51 PM Changeset in webkit [132530] by dpranke@chromium.org
  • 6 edits in trunk/Tools

rwt --lint-test-files doesn't handle the cascade properly
https://bugs.webkit.org/show_bug.cgi?id=100315

Reviewed by Ojan Vafai.

We were only linting the first file in each port's list of
expectations.

This change pushes more of the logic for linting files into
the TestExpectations classes themselves, but it's still a bit of
a hack. A better solution will require splitting out the actual
parsing of the files from the TestExpectations constructor.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):
(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(parse_exp):
(SkippedTests.check):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_all_configurations.FakePort.init):
(LintTest.test_all_configurations):
(LintTest.test_lint_test_fileserrors):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations):

1:50 PM Changeset in webkit [132529] by commit-queue@webkit.org
  • 9 edits
    20 adds
    6 deletes in trunk

Unreviewed, rolling out r132269.
http://trac.webkit.org/changeset/132269
https://bugs.webkit.org/show_bug.cgi?id=100412

"Speculative rollout of r132269 in hopes of fixing a
mysterious recalcStyle crasher" (Requested by eseidel on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-25

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderListBox.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/pseudo-elements-expected.html: Removed.
  • fast/forms/pseudo-elements.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
1:42 PM Changeset in webkit [132528] by senorblanco@chromium.org
  • 6 edits
    3 adds in trunk

Source/WebCore: Change ReferenceFilterOperations to reference (own) the data passed to
them.
https://bugs.webkit.org/show_bug.cgi?id=97715

Reviewed by Nate Chapin.

Covered by css3/filters/reference-filter-update-after-remove.html

  • css/CachedSVGDocumentReference.h: Added.

(CachedSVGDocumentReference):
New class which holds a CachedResourceHandle<CachedSVGDocument>, but
can be placed in ReferenceFilterOperation's Data. It also calls
addClient() / removeClient(), in order to keep the CachedSVGDocument
alive until the FilterEffectRenderer can get it.
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::document):
Accessor for the underlying document.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):
Wrap the CachedSVGDocument handle in a CachedSVGDocumentReference, and
transfer ownership to the ReferenceFilterOperation.
(WebCore::StyleResolver::createFilterOperations):
Same as above.

  • platform/graphics/filters/FilterOperation.h:

(Data):
New base class for generic data which can be deleted polymorphically.
(WebCore::FilterOperation::ReferenceFilterOperation::data):
(WebCore::FilterOperation::ReferenceFilterOperation::setData):
Use the above-mentioned Data class, instead of a void *.
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
Don't initialize data to null; OwnPtr will do that for us.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
Extract the cached SVG document from the reference data.

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):
Extract the cached SVG document from the reference data.

LayoutTests: Add new layout test for reference filters.
https://bugs.webkit.org/show_bug.cgi?id=97715

Reviewed by Nate Chapin.

  • css3/filters/reference-filter-update-after-remove-expected.txt: Added.
  • css3/filters/reference-filter-update-after-remove.html: Added.
1:39 PM Changeset in webkit [132527] by Simon Fraser
  • 4 edits in trunk

Incorrect tile size in the slow scrolling case
https://bugs.webkit.org/show_bug.cgi?id=100411

Reviewed by Beth Dakin.

Source/WebCore:

If we're in slow scrolling mode, we don't want to inflate the
coverage rect based on scrollability. This ensures that the few
big tiles we create have the correct size.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):

LayoutTests:

New result with better tile size.

  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
1:37 PM Changeset in webkit [132526] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping inspector/elements/update-shadowdom.html.
Feature in https://bugs.webkit.org/show_bug.cgi?id=99567 not supported on Windows ports.

  • platform/win/TestExpectations:
1:32 PM Changeset in webkit [132525] by thakis@chromium.org
  • 8 edits in trunk

Source/WebCore: Move ImageOrientation transform back in CG space (lower-left origin), adapt the skia code to work with that, turn on feature for chromium
https://bugs.webkit.org/show_bug.cgi?id=100401

Reviewed by Eric Seidel.

This is an alternative fix for the regression caused by r132384 / bug

  1. The bug exists because different pieces of code didn't agree

which space the transformation returned by ImageOrientation was in.

r132384 moved it from CG coordinates to skia coordinates, but didn't
do it completetely. This CL reverts this part of r132384 so that the
transformation is in CG coordinates again, and adapts the skia code to
work in that space.

Alternatively, https://bugs.webkit.org/show_bug.cgi?id=100319 woudl
make the cg code work with the transform in skia coordinates.

Covered by fast/images/exif-orientation.html

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

  • platform/graphics/ImageOrientation.cpp:

(WebCore::ImageOrientation::transformFromDefault):

  • platform/graphics/ImageOrientation.h:

(WebCore):
(WebCore::ImageOrientation::usesWidthAsHeight):
(WebCore::ImageOrientation::fromEXIFValue):
(ImageOrientation):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

LayoutTests: Move ImageOrientation transform back in CG space (lower-left origin), adapt the skia code to work with that, turn on feature for chromium
https://bugs.webkit.org/show_bug.cgi?id=100319

Reviewed by Eric Seidel.

  • platform/chromium/TestExpectations:
1:16 PM Changeset in webkit [132524] by Simon Fraser
  • 9 edits in trunk

Log the tile cache tile size in test output
https://bugs.webkit.org/show_bug.cgi?id=100409

Reviewed by Beth Dakin.

Source/WebCore:

When dumping tile cache information in tests, also dump the tile size.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/mac/TileCache.h:

LayoutTests:

New results with tile size in the output.

  • platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt:
  • platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt:
1:15 PM Changeset in webkit [132523] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

Skipping the atspi-basic-hierarchy test case in the TestWebKitAccessibility
WebKit2 API test since the test is currently failing.

  • Scripts/run-gtk-tests:

(TestRunner):

1:09 PM Changeset in webkit [132522] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

do not multiply/demultiply colors when alpha is 255
https://bugs.webkit.org/show_bug.cgi?id=89246

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Do not use colorFromPremultipliedARGB in getImageData nor
premultipliedARGBFromColor in putByteArray. Avoiding object creation
and function call make canvas.getImageData about 10% faster and
canvas.putImageData about 30% faster.

Also, we avoid multiplication/demultiplication computation when alpha
is 255. Result is the same, but when there is no transparency,
canvas.getImageData is about 4x faster, and canvas.putImageData is
about 2x faster.

No new tests. No change in behavior.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):

1:05 PM Changeset in webkit [132521] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

CHROMIUM: Add a method to WebLayerTreeView API
https://bugs.webkit.org/show_bug.cgi?id=100291

Patch by Jonathan Backer <backer@chromium.org> on 2012-10-25
Reviewed by James Robinson.

Used to support browser compositor commit locks (crbug.com/136366).

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::setDeferCommits):

1:05 PM Changeset in webkit [132520] by Nate Chapin
  • 11 edits in trunk/Source/WebCore

Add a main resource type to the memory cache
https://bugs.webkit.org/show_bug.cgi?id=99864

Reviewed by Adam Barth.

No new tests, no functionality change.

  • inspector/InspectorPageAgent.cpp:

(WebCore::hasTextContent):
(WebCore::InspectorPageAgent::cachedResourceType):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFail):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::addAdditionalRequestHeaders):
(WebCore):
(WebCore::CachedRawResource::setShouldBufferData):
(WebCore::CachedRawResource::loader):
(WebCore::CachedRawResource::clear):

  • loader/cache/CachedRawResource.h:

(WebCore):
(CachedRawResource):

  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::updateResourceRequest):
(WebCore):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setResourceError):
(WebCore::CachedResource::resourceError):
(CachedResource):
(WebCore::CachedResource::ignoreForRequestCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

  • platform/network/ResourceLoadPriority.h:
  • platform/network/cf/ResourceRequestCFNet.h:

(WebCore::toResourceLoadPriority):
(WebCore::toHTTPPipeliningPriority):

1:03 PM Changeset in webkit [132519] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing three fast/lists test failure expectations, the tests
were fixed in r132507.

  • platform/gtk/TestExpectations:
1:01 PM Changeset in webkit [132518] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Composited/HW content have the red and blue channels inverted in DRT on Chromium Android
https://bugs.webkit.org/show_bug.cgi?id=98647

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-25
Reviewed by James Robinson.

WebLayerTreeView::compositeAndReadback() always gives back data in BGRA
ordering (i.e., the first byte in memory is blue). This matches Skia's
SkBitmap::kARGB_8888_Config ordering on all platforms except Android,
where Skia's native format is RGBA (i.e., red comes first in memory).

This mismatch causes layout test pixel comparison failures. This patch
fixes the problem by reordering the channels right after readback.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

12:58 PM Changeset in webkit [132517] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Add histograms to measure V8 work done during window close and navigation
https://bugs.webkit.org/show_bug.cgi?id=100358

Reviewed by Adam Barth.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearWindowShell):

12:53 PM BadContent edited by zandobersek@gmail.com
Adding another spamming account. (diff)
12:34 PM Changeset in webkit [132516] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Avoid unnecessary style recalcs on id attribute mutation.
https://bugs.webkit.org/show_bug.cgi?id=100395

Reviewed by Andreas Kling.

There is no need to invalidate element style on id attribute change if neither the old nor the new id were
mentioned in any stylesheet. This is similar to the optimization we already have for class attributes.

Recalculating element style is expensive. It seems id attribute mutation is often used in scripts for purposes other than styling.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::hasSelectorForId):
(WebCore):

  • css/StyleResolver.h:
  • dom/Element.cpp:

(WebCore::makeIdForStyleResolution):
(WebCore):
(WebCore::Element::attributeChanged):

12:34 PM Changeset in webkit [132515] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip failing accessibility tests.
accessibility/title-ui-element-correctness.html
accessibility/aria-slider-value.html
accesibility/hidden-legend.html

  • platform/win/TestExpectations:
12:31 PM Changeset in webkit [132514] by dmazzoni@google.com
  • 27 edits
    6 adds in trunk

AX: Notification should be sent when accessibilityIsIgnored changes
https://bugs.webkit.org/show_bug.cgi?id=99547

Reviewed by Chris Fleizach.

Source/WebCore:

Adds a new flag in AccessibilityObject that keeps track of the most recent
value of accessibilityIsIgnored(). After certain events such as an ARIA
attribute change or content change, checks the new value of
accessibilityIsIgnored() and posts a "children changed" notification on the
parent node if it changed, making sure the parent recomputes its vector of
(unignored) children.

Also moves handling of attribute changes to AXObjectCache, and sends
notifications for some attribute changes that were previously silent. On
Chromium, all changes to an accessibility object's attributes should
result in some notification.

Some tests would have broken because an AccessibilityScrollView was created
and holding a reference to a ScrollView for an iframe after it was deleted,
so this change switches AccessibilityScrollView to hold a weak reference
to ScrollView instead.

Tests: platform/chromium/accessibility/is-ignored-change-sends-notification.html

platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html
platform/chromium/accessibility/text-change-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::textChanged):
(WebCore):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):

  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::recomputeIsIgnored):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::insertChild):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::cachedIsIgnoredValue):
(WebCore):
(WebCore::AccessibilityObject::setCachedIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::textChanged):
(AccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::~AccessibilityScrollView):
(WebCore):
(WebCore::AccessibilityScrollView::detach):
(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):
(WebCore::AccessibilityScrollView::updateScrollbars):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::scrollView):
(AccessibilityScrollView):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

Source/WebKit/chromium:

Adds new accessibility notifications.

  • public/WebAccessibilityNotification.h:
  • src/AssertMatchingEnums.cpp:

Tools:

Add additional accessibility notifications.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::postAccessibilityNotification):

LayoutTests:

Adds 3 new test to ensure:

  1. A "children changed" notification is fired on the parent object when an object that was previously ignored becomes unignored.
  2. A notification is sent when an element's text (incl. title or label) changes.
  3. A notification is sent when another ARIA attribute changes.

Modifies add-to-menu-list-crashes because it was too brittle; it was

referencing a stale object rather than retrieving its latest handle.

Modifies aria-checkbox-sends-notification to listen on the correct

object on all platforms.

Simplifies notification-listeners so it doesn't generate additional

notifications that are inconsistent between platforms now.

  • accessibility/aria-checkbox-sends-notification.html:
  • accessibility/notification-listeners.html:
  • platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt:
  • platform/chromium/accessibility/add-to-menu-list-crashes.html:
  • platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt: Added.
  • platform/chromium/accessibility/is-ignored-change-sends-notification.html: Added.
  • platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt: Added.
  • platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html: Added.
  • platform/chromium/accessibility/text-change-notification-expected.txt: Added.
  • platform/chromium/accessibility/text-change-notification.html: Added.
12:26 PM Changeset in webkit [132513] by dominik.rottsches@intel.com
  • 26 edits in trunk

.: Adding feature for XHR_TIMEOUT

Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding feature for XHR_TIMEOUT to disable it on ports that don't have
network backend support for setTimeoutInterval.

  • Source/cmake/OptionsEfl.cmake: Default ON on EFL.
  • Source/cmake/WebKitFeatures.cmake: Default OFF for any CMAKE based port.
  • Source/cmakeconfig.h.cmake: Adding define.
  • configure.ac: Make autogen.sh support the --enable/--disable-xhr-timeout parameter.

Source/JavaScriptCore: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding feature for XHR_TIMEOUT to disable it on ports that don't have
network backend support for setTimeoutInterval.

No new tests, covered by http/tests/xmlhttprequest/timeout/*

  • Configurations/FeatureDefines.xcconfig: Default ON on mac.
  • GNUmakefile.am:
  • GNUmakefile.features.am: Autotools support for the flag.
  • xml/XMLHttpRequest.cpp: #if ENABLE(XHR_TIMEOUT) wrapping

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::didFail):

  • xml/XMLHttpRequest.h: #if ENABLE(XHR_TIMEOUT) wrapping

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl: Conditional properties timeout and ontimeout (event handler).

Source/WebKit/chromium: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support.
Defaults to off on chromium until webkit.org/b/98397 is solved.

  • features.gypi:

Source/WebKit/mac: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support.
Defaults to ON on Mac since the Mac NSUrlConnection based backend has setTimeoutInterval support.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support.
Defaults to ON on Mac since the Mac NSUrlConnection based backend has setTimeoutInterval support.

  • Configurations/FeatureDefines.xcconfig:

Tools: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding XHR_TIMEOUT feature in perl and qmake files.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries: Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356

Reviewed by Adam Barth.

Adding ENABLE_XHR_TIMEOUT feature, which is default off for Apple Win.
See also https://bugs.webkit.org/show_bug.cgi?id=100349 for an attempt
to fix timeout support for CF Network.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
12:11 PM Changeset in webkit [132512] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Only full-page PDFPlugins should purport to handle page scale changes
https://bugs.webkit.org/show_bug.cgi?id=99635

Reviewed by Sam Weinig.

PDFPlugin should only handle page scale factor changes itself if it's in the main frame.
Subframe PDFs will act like images, zooming with the page.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Move implementation of handlesPageScaleFactor() to PDFPlugin.mm.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::pdfDocumentDidLoad): Only copy PDFLayerController's default autoscale magnification to PluginView's
notion of the current scale factor if we're supposed to be handling page scale factor changes.
(WebKit::PDFPlugin::geometryDidChange): Only update PDFLayerController's magnification from the page scale factor
if we're supposed to be handling page scale factor changes.
(WebKit::PDFPlugin::handlesPageScaleFactor): We should only handle page scale factor changes if we're in the main frame.

12:07 PM Changeset in webkit [132511] by tsepez@chromium.org
  • 6 edits in trunk

XSSAuditor must replace form action with about:blank when reflected action detected.
https://bugs.webkit.org/show_bug.cgi?id=100280

Reviewed by Daniel Bates.

Source/WebCore:

Changes empty string form-action replacement to about:blank.
Existing form-action.html test modified to check this case.

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterFormToken):

LayoutTests:

Update tests to log form action attribute.

  • http/tests/security/xssAuditor/form-action-expected.txt:
  • http/tests/security/xssAuditor/form-action.html:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
12:05 PM Changeset in webkit [132510] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Plugin test gardening
https://bugs.webkit.org/show_bug.cgi?id=100359

Unreviewed, EFL gardening.

fast/frames/sandboxed-iframe-plugins.html and userscripts/user-script-
plugin-document.html are passing on WK2 now.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-10-25

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
11:49 AM Changeset in webkit [132509] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Touch adjustment snaps to wrong target at a plugin boundary.
https://bugs.webkit.org/show_bug.cgi?id=99938

Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-25
Reviewed by Antonio Gomes.

Source/WebCore:

Inidcate that an <embed> element can respond to
mouse click events, since mouse events are forwarded
to the plugin. Fixes touch adjustment at a plugin
boundary. Prior to the patch a clickable element
adjacent to the plugin would capture synthetic mouse
events from tap gestures that spanned the plugin
boundary.

Test: touchadjustment/plugin.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::willRespondToMouseClickEvents):
(WebCore):

  • html/HTMLEmbedElement.h:

LayoutTests:

Test for touch adjustment at a plugin boundary.
Prior to the patch, plugins were not considered
candidates for touch adjustment.

  • touchadjustment/plugin-expected.txt: Added.
  • touchadjustment/plugin.html: Added.
11:48 AM Changeset in webkit [132508] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX define from skia_webkit.gyp, as it has been rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=100394

Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-25
Reviewed by Dirk Pranke.

The define has been removed from the Skia code and the Chromium skia.gyp.
The pixel tests affected have already been rebaselined.

  • skia_webkit.gyp:
11:40 AM Changeset in webkit [132507] by msaboff@apple.com
  • 5 edits in trunk/Source

REGRESSION (r131836): failures in list styles tests on EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=99824

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Saved start of string since it is modified by call convertUTF8ToUTF16().

  • API/JSStringRef.cpp:

(JSStringCreateWithUTF8CString):

Source/WTF:

Fixed ASCII check.
Added placeholder argument for new argument added to convertUTF8ToUTF16() in http://trac.webkit.org/changeset/131836.

  • wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertUTF8ToUTF16):

  • wtf/unicode/glib/UnicodeGLib.cpp:

(WTF::Unicode::convertCase):

11:20 AM Changeset in webkit [132506] by zoltan@webkit.org
  • 2 edits
    3 moves
    3 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #2
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #2 commit of the whole patch.

  • PageLoad/svg/files/cacuts_01.svg: Removed.
  • PageLoad/svg/files/cowboy.svg: Removed.
  • PageLoad/svg/files/crawfish2_ganson.svg: Removed.
  • SVG/Cactus.html: Added.
  • SVG/Cowboy.html: Added.
  • SVG/CrawFishGanson.html: Added.
  • SVG/resources/Cactus.svg: Copied from PerformanceTests/PageLoad/svg/files/cacuts_01.svg.
  • SVG/resources/Cowboy.svg: Copied from PerformanceTests/PageLoad/svg/files/cowboy.svg.
  • SVG/resources/CrawFishGanson.svg: Copied from PerformanceTests/PageLoad/svg/files/crawfish2_ganson.svg.
  • Skipped: Remove az-lizard_benji_park_01.svg from the skipped list.
11:16 AM Changeset in webkit [132505] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Get rid of ScriptController::clearForNavigation
https://bugs.webkit.org/show_bug.cgi?id=100390

Reviewed by Adam Barth.

Get rid of clearForNavigation and change resetIsolatedWorlds
to reset so that it can also do the hintForCollectGarbage call.
No new tests. No behavior change.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::reset):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:

(ScriptController):

11:08 AM Changeset in webkit [132504] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

r132427 changed the tiling behavior of tiled layer TileCaches as well as the page tile cache
https://bugs.webkit.org/show_bug.cgi?id=100323

Reviewed by Anders Carlsson.

r132427 assumed that TileCaches were only used for the page, and changed the tile
size behavior of all non-page TileCaches.

Fix by giving TiledBacking a new 'CoverageForSlowScrolling' flag which
affects the tile size behavior.

Consolidated the two places that set TileCoverage into one, and in the process
reduced FrameView's direct communication with TiledBacking.

No new tests because we can't test tile size via tests.

  • page/FrameView.cpp:

(WebCore::FrameView::didMoveOnscreen): Rely on RenderLayerCompositor to
call setIsInWindow() on the main page tile cache.
(WebCore::FrameView::willMoveOffscreen): Ditto.
(WebCore::FrameView::performPostLayoutTasks): Rather than explicitly tell
the TiledBacking that it should do stuff, just tell the compositor that
layout happened.

  • platform/graphics/TiledBacking.h: New CoverageForSlowScrolling flag.
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileSizeForCoverageRect): Only use one big tile
if the CoverageForSlowScrolling flag is set.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking): layer->isRootLayer()
is equivalent to renderer()->isRenderView() and clearer.
(WebCore::RenderLayerBacking::tiledBacking): Call adjustTileCacheCoverage().
It would be nice to move the rest of this TiledBacking code from here somehow.
(WebCore::RenderLayerBacking::adjustTileCacheCoverage): Update the TileCoverage
flags, taking into account horizontal and vertical scrollability independently,
and whether we're in slow scrolling mode.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidLayout): Have the page
tiled backing update it's coverage flags.
(WebCore::RenderLayerCompositor::pageTiledBacking): Utility function.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Moved from FrameView.
(WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

11:00 AM Changeset in webkit [132503] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Everything that sets RenderObject::m_style should go through setStyleInternal
https://bugs.webkit.org/show_bug.cgi?id=100338

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-25
Reviewed by Ojan Vafai.

Whenever we set m_style in RenderObject go through setStyleInternal and make
it inline. This gives a common place to put printfs and makes the code cleaner.

No new tests, just a refactor.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::setStyle):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setStyleInternal):

10:56 AM Changeset in webkit [132502] by commit-queue@webkit.org
  • 2 edits
    12 moves in trunk/Source/WebKit2

[EFL][WK2] Move non-API classes out of UIProcess/API/efl
https://bugs.webkit.org/show_bug.cgi?id=100391

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Move non-API classes from UIProcess/API/efl to
UIProcess/efl for clarity.

  • PlatformEfl.cmake:
  • UIProcess/efl/BatteryProvider.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp.

(toBatteryProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::startUpdating):
(BatteryProvider::stopUpdating):
(BatteryProvider::didChangeBatteryStatus):

  • UIProcess/efl/BatteryProvider.h: Renamed from Source/WebKit2/UIProcess/API/efl/BatteryProvider.h.

(WebKit):
(BatteryProvider):

  • UIProcess/efl/NetworkInfoProvider.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/NetworkInfoProvider.cpp.

(toNetworkInfoProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(getBandwidthCallback):
(isMeteredCallback):
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
(NetworkInfoProvider::bandwidth):
(NetworkInfoProvider::metered):
(NetworkInfoProvider::startUpdating):
(NetworkInfoProvider::stopUpdating):

  • UIProcess/efl/NetworkInfoProvider.h: Renamed from Source/WebKit2/UIProcess/API/efl/NetworkInfoProvider.h.

(WebKit):
(NetworkInfoProvider):

  • UIProcess/efl/PageClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp.

(WebKit):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::~PageClientImpl):
(WebKit::PageClientImpl::viewImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):
(WebKit::PageClientImpl::scrollView):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::pageClosed):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientImpl::didChangeViewportProperties):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):
(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
(WebKit::PageClientImpl::doneWithKeyEvent):
(WebKit::PageClientImpl::doneWithTouchEvent):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::createColorChooserProxy):
(WebKit::PageClientImpl::setFindIndicator):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
(WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientImpl::customRepresentationZoomFactor):
(WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
(WebKit::PageClientImpl::flashBackingStoreUpdates):
(WebKit::PageClientImpl::findStringInCustomRepresentation):
(WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
(WebKit::PageClientImpl::updateTextInputState):
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit::PageClientImpl::pageDidRequestScroll):
(WebKit::PageClientImpl::didChangeContentsSize):
(WebKit::PageClientImpl::didRenderFrame):
(WebKit::PageClientImpl::pageTransitionViewportReady):

  • UIProcess/efl/PageClientImpl.h: Renamed from Source/WebKit2/UIProcess/API/efl/PageClientImpl.h.

(WebKit):
(PageClientImpl):
(WebKit::PageClientImpl::create):
(WebKit::PageClientImpl::setPageViewportController):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/PageViewportControllerClientEfl.cpp.

(WebKit):
(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::~PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::drawingArea):
(WebKit::PageViewportControllerClientEfl::setRendererActive):
(WebKit::PageViewportControllerClientEfl::display):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
(WebKit::PageViewportControllerClientEfl::didChangeViewportAttributes):
(WebKit::PageViewportControllerClientEfl::setController):

  • UIProcess/efl/PageViewportControllerClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/PageViewportControllerClientEfl.h.

(WebKit):
(PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::create):
(WebKit::PageViewportControllerClientEfl::viewSize):
(WebKit::PageViewportControllerClientEfl::scaleFactor):
(WebKit::PageViewportControllerClientEfl::scrollPosition):

  • UIProcess/efl/VibrationProvider.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/VibrationProvider.cpp.

(Ewk_Vibration_Client):
(Ewk_Vibration_Client::Ewk_Vibration_Client):
(toVibrationProvider):
(vibrateCallback):
(cancelVibrationCallback):
(VibrationProvider::create):
(VibrationProvider::VibrationProvider):
(VibrationProvider::~VibrationProvider):
(VibrationProvider::vibrate):
(VibrationProvider::cancelVibration):
(VibrationProvider::setVibrationClientCallbacks):

  • UIProcess/efl/VibrationProvider.h: Renamed from Source/WebKit2/UIProcess/API/efl/VibrationProvider.h.

(WebKit):
(VibrationProvider):

  • UIProcess/efl/WebKitTextChecker.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/WebKitTextChecker.cpp.

(WebKit):
(WebKit::isContinuousSpellCheckingEnabled):
(WebKit::setContinuousSpellCheckingEnabled):
(WebKit::uniqueSpellDocumentTag):
(WebKit::closeSpellDocumentWithTag):
(WebKit::checkSpellingOfString):
(WebKit::guessesForWord):
(WebKit::learnWord):
(WebKit::ignoreWord):
(WebKit::availableSpellCheckingLanguages):
(WebKit::updateSpellCheckingLanguages):
(WebKit::loadedSpellCheckingLanguages):

  • UIProcess/efl/WebKitTextChecker.h: Renamed from Source/WebKit2/UIProcess/API/efl/WebKitTextChecker.h.

(WebKit):

10:16 AM Changeset in webkit [132501] by beidson@apple.com
  • 21 edits
    3 copies in trunk/Source

Allow LoaderStrategy to override the ResourceLoadScheduler
https://bugs.webkit.org/show_bug.cgi?id=100355

Reviewed by Anders Carlsson.

Source/WebCore:

Allow LoaderStrategy to override the implementation of the ResourceLoadScheduler.
Add a default implementation that just returns the current ResourceLoadScheduler.

No new tests (No behavior change).

Project file stuff:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

"Virtualize" ResourceLoadScheduler to expose build issues in preparation for future virtualization:

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::~ResourceLoadScheduler):

  • loader/ResourceLoadScheduler.h:

(ResourceLoadScheduler):

Add the new method plus a default implementation:

  • loader/LoaderStrategy.cpp:

(WebCore::LoaderStrategy::resourceLoadScheduler):

  • loader/LoaderStrategy.h:

When strategies are enabled, use the LoaderStrategy for this:

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::loadNow):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::performPostLoadActions):

Source/WebKit2:

Add a WebKit2 subclass of ResourceLoadScheduler that currently adds no new functionality:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::~WebResourceLoadScheduler):

  • WebProcess/Network/WebResourceLoadScheduler.h:

WebProcess hangs on to the default shared WebResourceLoadScheduler:

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::webResourceLoadScheduler):

If the NetworkProcess is enabled, return the new WebResourceLoadScheduler:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::resourceLoadScheduler):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebKit2.xcodeproj/project.pbxproj:
10:09 AM Changeset in webkit [132500] by kenneth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my contact info.

  • Scripts/webkitpy/common/config/committers.py:
10:09 AM Changeset in webkit [132499] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG NewArrayBuffer node should keep its data in a structure on the side to free up one of the opInfos
https://bugs.webkit.org/show_bug.cgi?id=100328

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNode.h:

(NewArrayBufferData):
(DFG):
(JSC::DFG::Node::newArrayBufferData):
(Node):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):

9:55 AM Changeset in webkit [132498] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[EFL][WK2] Remove some C'ism from EwkView
https://bugs.webkit.org/show_bug.cgi?id=100370

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Remove a lot of C'ism from EwkView:

  • Make more members private and add C++ methods to

EwkViewImpl for the public C API to use

  • Use smart pointers when possible instead of raw

ones

  • Use C++ naming conventions for callback functions

and define them as static methods in EwkViewImpl.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::onIMFInputSequenceComplete):
(EwkViewImpl::onIMFPreeditSequenceChanged):
(EwkViewImpl::createIMFContext):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::setCursor):
(EwkViewImpl::setColorPickerColor):
(EwkViewImpl::isFocused):
(EwkViewImpl::isVisible):
(EwkViewImpl::title):
(EwkViewImpl::inputMethodContext):
(EwkViewImpl::themePath):
(EwkViewImpl::setThemePath):
(EwkViewImpl::customTextEncodingName):
(EwkViewImpl::setCustomTextEncodingName):
(EwkViewImpl::setMouseEventsEnabled):
(EwkViewImpl::setTouchEventsEnabled):
(EwkViewImpl::informIconChange):
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::onMouseDown):
(EwkViewImpl::onMouseUp):
(EwkViewImpl::onMouseMove):
(EwkViewImpl::feedTouchEvents):
(EwkViewImpl::onTouchDown):
(EwkViewImpl::onTouchUp):
(EwkViewImpl::onTouchMove):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebCore):
(EwkViewImpl::ewkContext):
(EwkViewImpl::settings):
(EwkViewImpl):
(EwkViewImpl::url):
(EwkViewImpl::faviconURL):
(EwkViewImpl::mouseEventsEnabled):
(EwkViewImpl::touchEventsEnabled):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/API/efl/ewk_settings_private.h:

(Ewk_Settings::create):
(Ewk_Settings::Ewk_Settings):
(Ewk_Settings):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_mouse_up):
(_ewk_view_smart_key_down):
(_ewk_view_smart_add):
(ewk_view_context_get):
(ewk_view_url_get):
(ewk_view_icon_url_get):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
(ewk_view_color_picker_color_set):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Source/WTF:

Make OwnPtr useable for Ecore_IMF_Context to avoid
using raw pointers in EFL port.

  • wtf/OwnPtrCommon.h:

(WTF):

  • wtf/PlatformEfl.cmake:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):
(WTF):

9:45 AM WebKit Team edited by tdanderson@chromium.org
(diff)
9:45 AM Changeset in webkit [132497] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests to speedup testing.

  • platform/qt/TestExpectations:
9:40 AM Changeset in webkit [132496] by tdanderson@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
9:34 AM Changeset in webkit [132495] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Assertion failure trying to dispatch notification messages
https://bugs.webkit.org/show_bug.cgi?id=100387
<rdar://problem/12573195>

Reviewed by Jessie Berlin.

Pass a zero destination ID when sending WebNotificationManagerProxy messages; they are not
used by the UI process and since the WebNotificationManagerProxy message receiver is global
passing a non-zero destination ID would cause the aforementioned assertion failure.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):

9:30 AM Changeset in webkit [132494] by yurys@chromium.org
  • 4 edits in trunk

Web Inspector: inspector tests failing after r132454
https://bugs.webkit.org/show_bug.cgi?id=100381

Reviewed by Pavel Feldman.

Source/WebCore:

Added implementation for DOMNodeWrapperMap::reportMemoryUsage method,
otherwise no actual pointer is reported which breaks instrumentation.

  • bindings/v8/IntrusiveDOMWrapperMap.h:

LayoutTests:

Enable memory instrumentation tests now that the problem is fixed.

  • platform/chromium/TestExpectations:
9:28 AM Changeset in webkit [132493] by dominik.rottsches@intel.com
  • 2 edits in trunk/Source/WebCore

Init timeout flag in ResourceErrorCF
https://bugs.webkit.org/show_bug.cgi?id=100349

Reviewed by Alexey Proskuryakov.

Initialize the timeout property to true if the network error was a timeout error.
This is a speculative fix for the XHR timeout test cases failing on Apple Win -
I can't verify this on a local machine.

No new tests, covered by
LayoutTests/http/tests/xmlhttprequest/timeout/*

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError): Init m_timeout from error code.

9:09 AM Changeset in webkit [132492] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Update the C++ llint to work with the latest op_resolve... changes.
https://bugs.webkit.org/show_bug.cgi?id=100345.

Reviewed by Oliver Hunt.

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • emit opcode name as label when not using COMPUTED_GOTOs. The new op_resolve opcodes have jumps to these labels.
  • declare all opcode labels as UNUSED_LABEL()s to keep the compiler happy for opcodes that are not referenced by anyone.
  • offlineasm/asm.rb:
  • strip llint_ prefix from opcode names used as labels.
9:01 AM Changeset in webkit [132491] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r131686): Crashes in NSToolTipManager
https://bugs.webkit.org/show_bug.cgi?id=99792

Now that NSToolTip related parts of this change have been rolled out, roll out
the initial crash fix, too. We have no direct evidence that it's to blame, but it
doesn't serve any specific purpose any more.

  • UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]):
8:58 AM Changeset in webkit [132490] by kenneth@webkit.org
  • 5 edits in trunk

'resolution' MQ: Printing should use use high resolution images when available
https://bugs.webkit.org/show_bug.cgi?id=100382

Reviewed by Antti Koivisto.

Special case print to not use the dpi of the screen, but one of 300.

Updated the resolution media query test to cover this.

Source/WebCore:

  • css/MediaQueryEvaluator.cpp:

(WebCore::resolutionMediaFeatureEval): Update compared decimal points
to three, due to 300 / 96 being equal to 3.125.

LayoutTests:

  • fast/media/mq-resolution-expected.txt:
  • fast/media/mq-resolution.html:
8:55 AM Changeset in webkit [132489] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] External FileSystem should use the root path returned by requestFileSystem
https://bugs.webkit.org/show_bug.cgi?id=100372

Reviewed by Kentaro Hara.

External FileSystem should use the root path returned by
requestFileSystem as other type is doing. Current implementation
completely ignore the returned path.

New tests are to be added in chromium (as the type is only available in chromeos and chrome extensions)

  • Modules/filesystem/chromium/DOMFileSystemChromium.cpp:

(WebCore::DOMFileSystemBase::createFileSystemURL):

8:40 AM Changeset in webkit [132488] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Can't easily position the cursor on an empty line in a textarea with touch if touch adjustment is enabled
https://bugs.webkit.org/show_bug.cgi?id=97576

Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-25
Reviewed by Antonio Gomes.

Source/WebCore:

Consolidate touch adjustment candidates that are
editable. Adjustment becomes coarse being based
on the bounds of the outermost editable element.
This fix allows tap positioning of the text caret
on a blank line immediately above or below another
element.

Test: touchadjustment/editable-content.html

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::hybridDistanceFunction):

LayoutTests:

Add test to verify that touch adjustment is coarse for
editable content, being based on the bounds of the
editable content and not its children.

  • touchadjustment/editable-content-expected.txt: Added.
  • touchadjustment/editable-content.html: Added.
8:33 AM Changeset in webkit [132487] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip tests because TestRunner::overridePreference()
does not support the 'WebKitSupportsMultipleWindows' preference on Qt WK1.

  • platform/qt-5.0-wk1/TestExpectations:
8:28 AM Changeset in webkit [132486] by yurys@chromium.org
  • 3 edits
    1 add in trunk/Source

Memory instrumentation: add reportMemoryUsage to ImageObserver interface
https://bugs.webkit.org/show_bug.cgi?id=100091

Reviewed by Pavel Feldman.

Added reportMemoryUsage method to ImageObserver to make sure it is reported as
appropriate descendant(with pointer adjusted due to offsets added by inheritance)
rather than as a standalone memory block.

  • platform/graphics/ImageObserver.h:

(ImageObserver):

8:19 AM Changeset in webkit [132485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Memory leak in _ewk_view_preedit_changed()
https://bugs.webkit.org/show_bug.cgi?id=100380

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-25
Reviewed by Antonio Gomes.

Fix memory leak in _ewk_view_preedit_changed(). The buffer
returned by ecore_imf_context_preedit_string_get() is never
freed.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(_ewk_view_preedit_changed):

7:51 AM Changeset in webkit [132484] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium test expectations updated.

  • platform/chromium/TestExpectations:
7:48 AM Changeset in webkit [132483] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Regression(132392) infinite loop when displaying certain animations.
https://bugs.webkit.org/show_bug.cgi?id=100288

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

When PageClientImpl::setViewNeedsDisplay is called, start a 0 length timer.
That breaks the synchronous loop we were experiencing when ewk_view_display
was called directly.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::redrawRegion):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

7:45 AM Changeset in webkit [132482] by zeno.albisser@digia.com
  • 2 edits in trunk/Tools

[Qt] Adjust library name in webkitdirs.pm after r131300.
https://bugs.webkit.org/show_bug.cgi?id=100376

The library was renamed from QtWebKit to QtWebKitWidgets.
run-launcher was still looking for QtWebKit.

Reviewed by Simon Hausmann.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):

7:17 AM Changeset in webkit [132481] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Overrides] Add latitude and longitude labels for the geolocation fields
https://bugs.webkit.org/show_bug.cgi?id=100375

Reviewed by Yury Semikhatsky.

No new tests, a UI change.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.UserAgentSettingsTab.prototype._createGeolocationOverrideElement):

7:03 AM Changeset in webkit [132480] by commit-queue@webkit.org
  • 14 edits in trunk

Add setMediaTypeOverride to window.internals.settings
https://bugs.webkit.org/show_bug.cgi?id=100249

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

.:

Exported WebCore::Settings::setMediaTypeOverride(WTF::String const&) for GTK port.

  • Source/autotools/symbols.filter:

Source/WebCore:

Added setMediaTypeOverride to window.internals.settings.

Test: fast/media/print-restores-previous-mediatype.html

  • WebCore.exp.in: Exported WebCore::Settings::setMediaTypeOverride(WTF::String const&) for MAC.
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setMediaTypeOverride):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::mediaTypeOverride):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setMediaTypeOverride):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

Exported WebCore::Settings::setMediaTypeOverride(WTF::String const&) for WIN port.

  • win/WebKit2.def:

LayoutTests:

Fixed fast/media/print-restores-previous-mediatype.html to use cross-platform
window.internals.settings.setMediaTypeOverride.
Unskipped fast/media/print-restores-previous-mediatype.html for EFL, the test should also work
on other ports but it needs to be checked first.

  • fast/media/print-restores-previous-mediatype.html:
  • platform/efl/TestExpectations:
6:22 AM Changeset in webkit [132479] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2][EFL] Add ewk_view_pagination_mode_set/get() APIs
https://bugs.webkit.org/show_bug.cgi?id=100213

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-10-25
Reviewed by Gyuyoung Kim.

Add ewk_view_pagination_mode_set/get() APIs for paginated display.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

6:20 AM Changeset in webkit [132478] by mnaganov@chromium.org
  • 15 edits
    9 adds in trunk

[Chromium] Add supportMultipleWindows setting, needed for Android
https://bugs.webkit.org/show_bug.cgi?id=99716

Reviewed by Adam Barth.

Add supportMultipleWindows settings for reusing the same view when
opening popups. This is required for emulating the behavior of
Android WebView. Adding into WebCore, as other ports might want to
use this setting in the future.

Source/WebCore:

Tests: fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html

fast/dom/Window/window-open-no-multiple-windows.html
fast/forms/post-popup-no-multiple-windows.html

  • loader/FrameLoader.cpp:

(WebCore::createWindow):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSupportsMultipleWindows):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::supportsMultipleWindows):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchCreatePage):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setSupportsMultipleWindows):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::overridePreference):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Added.
  • fast/dom/Window/window-open-no-multiple-windows-expected.txt: Added.
  • fast/dom/Window/window-open-no-multiple-windows.html: Added.
  • fast/forms/post-popup-no-multiple-windows-expected.txt: Added.
  • fast/forms/post-popup-no-multiple-windows.html: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-open-no-multiple-windows-expected.txt: Added.
  • platform/chromium/fast/forms/post-popup-no-multiple-windows-expected.txt: Added.
6:05 AM Changeset in webkit [132477] by fmalita@chromium.org
  • 8 edits
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=99874.

  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/chromium-mac-lion/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium/TestExpectations:
5:47 AM Changeset in webkit [132476] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][AC] Fix build break when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=100367

Unreviewed build fix after r132405.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-25

  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):

5:45 AM Changeset in webkit [132475] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, fix Web Inspector frontend compilability

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondragstart):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):

5:11 AM Changeset in webkit [132474] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Drag and drop property value from Inspector is not working as expected
https://bugs.webkit.org/show_bug.cgi?id=100040

Reviewed by Vsevolod Vlasov.

Do not start a custom drag for a tree element if there is a non-collapsed selection in the Inspector.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondragstart):

5:06 AM Changeset in webkit [132473] by kbalazs@webkit.org
  • 5 edits
    23 adds
    1 delete in trunk/LayoutTests

[Qt] Pixel tests need rebaseline
https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel gardening.

Rebase some results for qt-5.0-wk2, mark wrong results as expected fail.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
  • platform/qt-5.0-wk2/compositing/text-on-scaled-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/text-on-scaled-surface-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/qt-5.0-wk2/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/012-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/014-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/hover-style-change-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/compare-content-style-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline-block/overflow-clip-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/qt-5.0-wk2/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/qt/TestExpectations:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png:
5:01 AM Changeset in webkit [132472] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r132394
https://bugs.webkit.org/show_bug.cgi?id=100365

Unreviewed gardening.

Skipping of newly added compositing/tiling/backface-preserve-3d-tiled.html
test fail on EFL port due to missing AC support.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-25

  • platform/efl/TestExpectations:
4:57 AM Changeset in webkit [132471] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] JavaScript popups are not focused when opened
https://bugs.webkit.org/show_bug.cgi?id=100354

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Move focus to the JavaScript popups when opened so that the key events
are forwarded to the popups instead of web view.

  • MiniBrowser/efl/main.c:

(on_javascript_alert):
(on_javascript_confirm):
(on_javascript_prompt):

4:57 AM Changeset in webkit [132470] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][QT] Remove test which is not exist
https://bugs.webkit.org/show_bug.cgi?id=100366

Unreviewed. fast/dom/shadow/athost-atrules.html has been removed after r132403.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-10-25

  • platform/efl-wk1/TestExpectations:
  • platform/qt/TestExpectations:
4:39 AM Changeset in webkit [132469] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Gardening after r132386
https://bugs.webkit.org/show_bug.cgi?id=100362

Unreviewed gardening.

Skipped crashing fast/dom/nested-script-exceptions.html, networkinformation/multiple-frames.html,
networkinformation/basic-all-types-of-events.html, networkinformation/updates.html, networkinformation/add-listener-from-callback.html,
networkinformation/basic-operation.html, svg/foreignObject/viewport-foreignobject-crash.html for EFL WK2.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-25

  • platform/efl-wk2/TestExpectations:
4:27 AM Changeset in webkit [132468] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Add missing namespace.
https://bugs.webkit.org/show_bug.cgi?id=100251

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Add 'WebKit' namespace for BatteryProvider, NetworkInfoProvider and
VibrationProvider.

  • UIProcess/API/efl/BatteryProvider.h:

(WebKit):

  • UIProcess/API/efl/NetworkInfoProvider.cpp:
  • UIProcess/API/efl/NetworkInfoProvider.h:

(WebKit):

  • UIProcess/API/efl/VibrationProvider.cpp:
  • UIProcess/API/efl/VibrationProvider.h:

(WebKit):

  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(Ewk_Context):

4:16 AM Changeset in webkit [132467] by jocelyn.turcotte@digia.com
  • 8 edits in trunk/Source/WebKit2

[Qt] Detach WebContext's clients from QtWebContext
https://bugs.webkit.org/show_bug.cgi?id=100224

Reviewed by Simon Hausmann.

The lifetime of WebContext isn't bound to QtWebContext and we wouldn't
keep a reference to our WebContext and would create a new one if a new
QQuickWebView/QtWebContext was created after we destroyed our QtWebContext.
This would cause a new WebContext and a new web process and somehow the
new WebContext could pick the IPC messages from the old WebProcess
and this would cause the new download client to receive messages about
downloads he doesn't know about and crash.

We assumed in the past that we would need multiple WebContext to allow
multiple web processes but this assumption doesn't hold anymore with
the work on ProcessModelMultipleSecondaryProcesses.
This patch enforces the use of a single WebContext by:

  • Holding a single instance of QtWebIconDatabaseClient and QtDownloadManager

statically in QtWebContext

  • Removing the context ID from QWebIconImageProvider's URLs
  • Using QtWebContext as a temporary wrapper handle on WebContext to

initialize the WebContext's clients and allow us creating the first web page

platformInvalidateContext is used to clean up static global instances
when the WebContext is getting destroyed.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::handleDownloadRequest):

  • UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::iconURLForPageURLInContext):
(QWebIconImageProvider::requestImage):

  • UIProcess/qt/QtWebContext.cpp:

(WebKit):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
(WebKit::QtWebContext::downloadManager):
(WebKit::QtWebContext::iconDatabase):
(WebKit::QtWebContext::invalidateContext):

  • UIProcess/qt/QtWebContext.h:

(QtWebContext):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):

  • UIProcess/qt/QtWebIconDatabaseClient.h:

(WebKit):
(QtWebIconDatabaseClient):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

3:53 AM Changeset in webkit [132466] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: NMI instrument InspectorDebuggerAgent. It uses a lot of memory on heavy js sites because it keeps all the scripts in a map.
https://bugs.webkit.org/show_bug.cgi?id=100340

Reviewed by Yury Semikhatsky.

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/ScriptDebugListener.h:

(Script):

3:50 AM AddingFeatures edited by dominik.rottsches@intel.com
(diff)
3:43 AM Changeset in webkit [132465] by jocelyn.turcotte@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Make the context injected bundle client static
https://bugs.webkit.org/show_bug.cgi?id=100223

Reviewed by Kenneth Rohde Christiansen.

It doesn't need any data from QtWebContext.

  • UIProcess/qt/QtWebContext.cpp:

(WebKit::didReceiveMessageFromInjectedBundle):
(WebKit):
(WebKit::initializeContextInjectedBundleClient):
(WebKit::QtWebContext::defaultContext):

  • UIProcess/qt/QtWebContext.h:

(QtWebContext):

2:47 AM Changeset in webkit [132464] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] We can handle ActiveDOMNodes and DOMNodes in the same GC visitor
https://bugs.webkit.org/show_bug.cgi?id=100351

Reviewed by Eric Seidel.

There is no reason to handle active DOM nodes in a separate pass from
regular DOM nodes anymore.

  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8GCController.cpp:

(WebCore::ActiveDOMObjectPrologueVisitor::visitDOMWrapper):
(WebCore::NodeVisitor::NodeVisitor):
(NodeVisitor):
(WebCore::NodeVisitor::visitNodeWrapper):
(WebCore::V8GCController::majorGCPrologue):

2:32 AM Changeset in webkit [132463] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit2

[EFL][WK2] Get rid of Ewk_View private C API (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=100331

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Convert most of the remaining Ewk_View private C API
into C++ methods in EwkViewImpl class. Only one private
C function remains but it will be taken care of in a
later patch to clean up the view construction code.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::addToPageViewMap):
(EwkViewImpl::removeFromPageViewMap):
(EwkViewImpl::viewFromPageViewMap):
(EwkViewImpl::fromEvasObject):
(EwkViewImpl::informLoadFinished):
(EwkViewImpl::informProvisionalLoadRedirect):
(EwkViewImpl::informProvisionalLoadStarted):
(EwkViewImpl::informWebProcessCrashed):
(EwkViewImpl::informContentsSizeChange):
(EwkViewImpl::requestPopupMenu):
(EwkViewImpl::requestJSAlertPopup):
(EwkViewImpl::requestJSConfirmPopup):
(EwkViewImpl::requestJSPromptPopup):
(EwkViewImpl::informDatabaseQuotaReached):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::createNewPage):
(EwkViewImpl::closePage):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::updateTextInputState):
(WebKit::PageClientImpl::didChangeContentsSize):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_del):
(_ewk_view_initialize):
(ewk_view_url_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_html_string_load):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
(WebKit::ContextHistoryClientEfl::didPerformClientRedirect):
(WebKit::ContextHistoryClientEfl::didPerformServerRedirect):
(WebKit::ContextHistoryClientEfl::didUpdateHistoryTitle):

  • UIProcess/efl/FindClientEfl.cpp:
  • UIProcess/efl/FormClientEfl.cpp:
  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):

  • UIProcess/efl/PageLoadClientEfl.h:
  • UIProcess/efl/PagePolicyClientEfl.cpp:
  • UIProcess/efl/PagePolicyClientEfl.h:
  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::closePage):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::runJavaScriptAlert):
(WebKit::PageUIClientEfl::runJavaScriptConfirm):
(WebKit::PageUIClientEfl::runJavaScriptPrompt):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):

  • UIProcess/efl/PageUIClientEfl.h:
  • UIProcess/efl/ResourceLoadClientEfl.h:
  • UIProcess/efl/WebPopupMenuProxyEfl.cpp:

(WebKit::WebPopupMenuProxyEfl::WebPopupMenuProxyEfl):
(WebKit::WebPopupMenuProxyEfl::showPopupMenu):
(WebKit::WebPopupMenuProxyEfl::hidePopupMenu):

  • UIProcess/efl/WebPopupMenuProxyEfl.h:

(WebKit::WebPopupMenuProxyEfl::create):
(WebPopupMenuProxyEfl):

2:32 AM Changeset in webkit [132462] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Improper out-of-order call on a rule that is being removed from the stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=100357

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::deleteRule):

2:15 AM Changeset in webkit [132461] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/media/w3c/test_media_queries.html is slow on Chromium debug bots after r132352
https://bugs.webkit.org/show_bug.cgi?id=100272

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Test if resolution media query is supported before identifying dpi of the media.

  • fast/media/w3c/test_media_queries.html:
1:48 AM Changeset in webkit [132460] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Unskip tests that are not exist already.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-25

  • platform/qt-5.0-wk2/TestExpectations:
1:38 AM Changeset in webkit [132459] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip a new failing test introduced in r132394.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-25

  • platform/qt-5.0-wk2/TestExpectations:
1:15 AM Changeset in webkit [132458] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] DOMDataStoreHandle serves no purpose and can be removed
https://bugs.webkit.org/show_bug.cgi?id=100333

Reviewed by Eric Seidel.

After https://bugs.webkit.org/show_bug.cgi?id=100316,
DOMDataStoreHandle is just a glorified OwnPtr.

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::domDataStore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:
12:44 AM Changeset in webkit [132457] by joone.hur@intel.com
  • 4 edits in trunk/Source/WebKit2

[EFL][AC] Unreviewed, fix build break when AC is enabled

Fix build break after r132405.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::enterAcceleratedCompositingMode):

  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

12:34 AM Changeset in webkit [132456] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove dead Node::isBlockFlowOrBlockTable
https://bugs.webkit.org/show_bug.cgi?id=100336

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-25
Reviewed by Eric Seidel.

Nothing uses Node::isBlockFlowOrBlockTable anymore so remove it.

No new tests needed, just removing dead code.

  • dom/Node.cpp:
  • dom/Node.h:

(Node):

12:32 AM Changeset in webkit [132455] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
https://bugs.webkit.org/show_bug.cgi?id=100090

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-25
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Fixed localized strings table.

  • English.lproj/localizedStrings.js: Added missing, removed orhans.
  • inspector/front-end/CSSNamedFlowView.js: Removed tailing whitespaces.
  • inspector/front-end/NativeMemorySnapshotView.js:

Removed double localization.

Tools:

Script "check-inspector-strings" seems to be broken.
Fixed it, refined search algorithm.

  • Scripts/check-inspector-strings: Fixed and refined.
12:14 AM Changeset in webkit [132454] by abarth@webkit.org
  • 10 edits
    4 deletes in trunk/Source/WebCore

[V8] We can merge DOMDataStore, ScopedDOMDataStore, and StaticDOMDataStore into one class
https://bugs.webkit.org/show_bug.cgi?id=100316

Reviewed by Eric Seidel.

Prior to this patch, DOMDataStore had two subclasses,
ScopedDOMDataStore and StaticDOMDataStore, which used slighly different
wrapper map base classes and had different lifetimes. This patch
unifies all these classes into DOMDataStore itself. This makes this
code much more straightforward.

  • WebCore.gypi:
  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::current):
(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):
(WebCore::DOMDataStore::domNodeMap):
(WebCore::DOMDataStore::activeDomNodeMap):
(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):

  • bindings/v8/ScopedDOMDataStore.cpp: Removed.
  • bindings/v8/ScopedDOMDataStore.h: Removed.
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • bindings/v8/StaticDOMDataStore.cpp: Removed.
  • bindings/v8/StaticDOMDataStore.h: Removed.
  • bindings/v8/V8DOMMap.cpp:

(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
(WebCore::visitActiveDOMNodes):
(WebCore::visitDOMObjects):
(WebCore::visitActiveDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):

  • bindings/v8/WorkerScriptController.h:

(WorkerScriptController):

Oct 24, 2012:

11:54 PM Changeset in webkit [132453] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/TestExpectations:
11:47 PM Changeset in webkit [132452] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Minimize CSS rulesets for multiple-fields input
https://bugs.webkit.org/show_bug.cgi?id=100198

Reviewed by Kentaro Hara.

  • Unify rulesets for input::-webkit-datetime-edit-*-field. input::-webkit-datetime-edit-*-field had identical ruleset.
  • Move some rulesets near to related rulesets. Move -webkit-datetime-edit-*-field:focus nearby the new unified ruleset. Move input::-webkit-datetime-edit-second-field[readonly] nearby

input::-webkit-datetime-edit-minute-field[readonly].

No new tests. This shouldn't make any behavior change.

  • css/html.css:

(input::-webkit-datetime-edit-year-field):
(input::-webkit-datetime-edit-year-field:focus):
(input::-webkit-datetime-edit-second-field[readonly]):

11:42 PM Changeset in webkit [132451] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r132291): Crash in BaseMultipleFieldsDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=100326

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/forms/time-multiple-fields/time-multiple-fields-change-type.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
We need to disconnect m_spinButtonElement before destructing the UA shadow tree.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type.html: Added.
11:38 PM Changeset in webkit [132450] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updating chromium TestExpectations for the roll.

  • platform/chromium/TestExpectations:
11:32 PM Changeset in webkit [132449] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updating chromium TestExpectations for the roll.

  • platform/chromium/TestExpectations:
11:31 PM Changeset in webkit [132448] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Add textureWidth() and textureHeight() to WebVideoFrame
https://bugs.webkit.org/show_bug.cgi?id=100042

Patch by John Sheu <sheu@google.com> on 2012-10-24
Reviewed by James Robinson.

It might be the case that the visible portion of a video frame isn't the
entire texture size, e.g. for cropping. We'll need accessors in
WebVideoFrame to be able to query both the underlying texture dimensions
and the subrect which is supposed to be visible.

This is presently a no-op change. Once Chromium changes are in, I will
remove the superseded parts of the WebVideoFrame interface.

  • chromium/public/WebVideoFrame.h:

(WebKit::WebVideoFrame::visibleRect);
(WebKit::WebVideoFrame::textureSize);

11:06 PM Changeset in webkit [132447] by abarth@webkit.org
  • 6 edits
    2 deletes in trunk/Source/WebCore

[V8] DOMData is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100313

Reviewed by Eric Seidel.

This class serves no purpose anymore and can be deleted.

  • WebCore.gypi:
  • bindings/v8/DOMData.cpp: Removed.
  • bindings/v8/DOMData.h: Removed.
  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMDataStore.h:

(WebCore):
(DOMDataStore):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap):
(WebCore::getActiveDOMNodeMap):
(WebCore::getDOMObjectMap):
(WebCore::getActiveDOMObjectMap):
(WebCore::removeAllDOMObjects):
(WebCore::visitActiveDOMNodes):
(WebCore::visitDOMObjects):
(WebCore::visitActiveDOMObjects):

11:03 PM Changeset in webkit [132446] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: platform/chromium/TestExpectations lint.

  • platform/chromium/TestExpectations:
10:24 PM Changeset in webkit [132445] by yuqiang.xian@intel.com
  • 5 edits in trunk/Source/JavaScriptCore

Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321

Reviewed by Filip Pizlo.

We have refactored the MacroAssembler and JIT compilers to distinguish
the pointer operations from the 64-bit integer operations (see bug #99154).
Now we want to do the similar work for LLInt, and the goal is same as
the one mentioned in 99154.

This is the first part of the modification: in the offline assembler,
adding the support of the "<foo>q" instructions which will be used for
64-bit integer operations.

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
10:13 PM Changeset in webkit [132444] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Sort an Xcode project file.

  • WebCore.xcodeproj/project.pbxproj: Sorted.
8:41 PM Changeset in webkit [132443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=100214

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-24
Reviewed by Rob Buis.

ViewportSize has been changed before committing root layer, it asserts
that it needs relayout and render if needed before committing if it
Needs One Shot Drawing Synchronization.
This patch calls requestLayoutIfNeeded() when resumeScreenAndBackingStoreUpdates().

Fix a coding style in the BackingStore.cpp as well.

Reviewed internally by Arvid Nilsson.
PR #230253

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

8:07 PM Changeset in webkit [132442] by commit-queue@webkit.org
  • 6 edits
    15 deletes in trunk/LayoutTests

Rebaseline some sputnik unicode failed cases.
https://bugs.webkit.org/show_bug.cgi?id=99976

Unreviewed rebaseline.

According to BUG 93103, seems these four test cases have different results after libicu 4.6 version.
As Ubuntu 12.04 installs 4.8 and mac has same result with windows, expected results on BUG 93103 could replace common result file except chromium-mac-snowleopard.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-24

  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/chromium/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
  • sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
  • sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
  • sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
8:07 PM Changeset in webkit [132441] by abarth@webkit.org
  • 19 edits
    1 add in trunk/Source/WebCore

[V8] AbstractWeakReferenceMap is unnecessarily general and complex
https://bugs.webkit.org/show_bug.cgi?id=100175

Reviewed by Eric Seidel.

Before this patch, AbstractWeakReferenceMap served two masters:

1) DOM wrappers
2) NPV8 function templates

These two uses cases pushed AbstractWeakReferenceMap to be more general
and complex that needed. This patch separates these two uses cases into
two separate classes. V8NPTemplateMap is all of 40 lines of code. It's
not worth complicating the DOM wrapper code path to share that tiny
amount of code.

The other thing this patch does is store a pointer to the DOM wrapper
map as the weak callback context object. That means we no longer need
to search through all the wrapper maps in order to find the map that
contains this particular DOM wrapper.

  • WebCore.gypi:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DOMData.h:

(DOMData):

  • bindings/v8/DOMDataStore.cpp:
    • Delete all these complicated weak callback functions. The weak callback functions are now an order of magnitude simpler and declared as private member functions on the wrapper map.
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domNodeMap):
(WebCore::DOMDataStore::activeDomNodeMap):
(DOMDataStore):

  • We now have a consistent type to use for all these wrapper maps. Both the hash map and the intrusive map derive from DOMWrapperMap (with a single template parameter).
  • bindings/v8/DOMWrapperMap.h: Added.

(WebCore):
(DOMWrapperVisitor):

  • The visitor is no longer an inner class. It's just a top-level class that does the same thing.

(DOMWrapperMap):

  • The abstract interface for DOMWrapperMap has about half as many functions as the old AbstractWeakReferenceMap because the two use cases are disentangled.

(WebCore::DOMWrapperMap::~DOMWrapperMap):
(DOMWrapperHashMap):

  • This is a concrete instance of DOMWrapperMap that uses a hash map.

(WebCore::DOMWrapperHashMap::DOMWrapperHashMap):
(WebCore::DOMWrapperHashMap::remove):
(WebCore::DOMWrapperHashMap::defaultWeakCallback):

  • Notice that the context parameter now points to the hashmap itself rather than to the native object. Now that we don't need to handle the NPAPI case, we can recover the native object from the wrapper using toNative. The assert in set() ensures that this always works.
  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/IntrusiveDOMWrapperMap.h:
    • These classes are now simplified because they need to implement fewer functions.

(WebCore::DOMNodeWrapperMap::weakCallback):

  • For this weak callback, we still use the native object as the context parameter. We could also recover the native object from the wrapper, which means this context parameter is available to do other work.
  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):

  • This code no longer needs to have knowledge of which weak callbacks these objects use.

(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • We need to clear the maps before deleting them because there are still JavaScript objects that have references to the map in their weak callback parameter. Previously, we handled this case because we would search all the wrapper maps and fail to find the wrapper.
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitExternalArrays):

  • bindings/v8/StaticDOMDataStore.cpp:
    • This code no longer needs to have knowledge of which weak callback these maps use.
  • bindings/v8/StaticDOMDataStore.h:

(StaticDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap):
(WebCore::getActiveDOMNodeMap):
(WebCore::removeAllDOMObjects):

  • Rather than using some complicated visitor pattern, we can now just call clear() directly on the maps to remove all the objects.

(WebCore::visitActiveDOMNodes):
(WebCore::visitDOMObjects):
(WebCore::visitActiveDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • Delete the old versions of these classes.

(DOMDataStoreHandle):

  • Style nit: one-argument constructors should be marked explicit.
  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::domWrapperType):

  • I moved this logic into WrapperTypeInfo.h to avoid a circular header dependency.
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

  • bindings/v8/V8GCController.cpp:
    • EnsureWeakDOMNodeVisitor is no longer used (or needed since we no longer clear the weak callbacks in V8GCController).
  • bindings/v8/V8NPObject.cpp:

(V8NPTemplateMap):

  • staticTemplateMap is no longer an instance of WeakReferenceMap. Instead, this patch just implements the functionality we need here directly.

(WebCore::V8NPTemplateMap::get):
(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::V8NPTemplateMap::dispose):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):

  • DOMWrapperMap no longer exposes a "forget" function. Instead, we just use the more basic "remove" and "Dispose" operations to do the same thing. This is possible now because we no longer have "removeIfPossible" to support searching all the wrapper maps for the one that has the right wrapper.

(WebCore::createV8ObjectForNPObject):

  • DOMWrapperMap No longer has a "contains" function. Instead, we use get, which actually makes this code more efficient because we only do one hash map lookup.

(WebCore::forgetV8ObjectForNPObject):

  • The changes here are a combination of the two sorts of changes above.
  • bindings/v8/WrapperTypeInfo.h:

(WebCore::toNative):
(WebCore::toWrapperTypeInfo):

  • The patch moves these functions into this header to avoid a circular header dependency.
7:01 PM Changeset in webkit [132440] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Geolocation is segfaulting
https://bugs.webkit.org/show_bug.cgi?id=100305

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-24
Reviewed by Rob Buis.

We weren't wrapping the Geolocation object in a RefPtr when we call setIsAllowed in
GeolocationClientBlackBerry::onPermission.

This patch also removes all references of the Geolocation object in WebPageClientImpl.
One RefPtr<Geolocation> is used to store the reference of the WebCore object on our port.

We don't need a mapping between origin -> context of Geolocation because in our port,
one WebPage.cpp contains one GeolocationController only.

  • Api/WebPageClient.h:
  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(frameOrigin):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onPermission):

  • WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

6:44 PM Changeset in webkit [132439] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: fix a couple of minor crashing issues under cygwin
https://bugs.webkit.org/show_bug.cgi?id=100309

Reviewed by Ojan Vafai.

Cygwin was crashing on a null object reference and then
an oserror in kill().

  • Scripts/webkitpy/common/system/executive.py:

(Executive.kill_process):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.stop):

6:26 PM Changeset in webkit [132438] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[cairo] unneeded FloatRect object creation in BitmapImage::draw
https://bugs.webkit.org/show_bug.cgi?id=100298

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-24
Reviewed by Martin Robinson.

Do not copy FloatRect arguments src and dst to local variables.
Instead, use src and dst directly.

No new tests. No change in behavior.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

6:02 PM Changeset in webkit [132437] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

5:50 PM Changeset in webkit [132436] by Simon Fraser
  • 1 edit
    4 adds in trunk/LayoutTests

Add two more tiled scrolling tests
https://bugs.webkit.org/show_bug.cgi?id=100314

Reviewed by Beth Dakin.

Two new tests for TileCache tile coverage after scrolling.

  • platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
  • platform/mac/tiled-drawing/tile-coverage-after-scroll.html: Added.
  • platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
  • platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom.html: Added.
5:49 PM Changeset in webkit [132435] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SOUP] Provide logging for SocketStreamHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=100215

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Add logging to SocketStreamHandleSoup to facilitate debugging.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

5:47 PM Changeset in webkit [132434] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Updated results for https://bugs.webkit.org/show_bug.cgi?id=100312
I checked in results that relied on some local changes in WK2.

  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
5:42 PM Changeset in webkit [132433] by thakis@chromium.org
  • 6 edits in trunk/Source/WebCore

Pass on exif orientation from ImageSource when using the open-source image decoders
https://bugs.webkit.org/show_bug.cgi?id=100164

Reviewed by Eric Seidel.

The orientation is honored always for image documents, and optionally
for <img> elements if shouldRespectImageOrientation is set (off by
default). However, the feature needs port-specific modifications to
GraphicsContext (without this, webcore will use the rotated bounds but
draw the image as if it hadn't be rotated, resulting in squished
pixels), and most ports don't implement these yet -- so put
turning this on for image documents behind a port-specific #ifdef.

No observable behavior change. Once it's hooked up, it will be tested
by fast/images/exif-orientation.html.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::orientation):
(WebCore):

  • platform/graphics/chromium/DeferredImageDecoder.h:

(DeferredImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readImageOrientation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

5:36 PM Changeset in webkit [132432] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Skip tiled drawing tests for WK1
https://bugs.webkit.org/show_bug.cgi?id=100312

Reviewed by Beth Dakin.

Skip platform/mac/tiled-drawing tests in the main TestExpections file,
but re-enable it in the WK2 TestExpections file.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
5:33 PM Changeset in webkit [132431] by dpranke@chromium.org
  • 3 edits
    2 copies
    2 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines.

  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Copied from LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png.
  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.txt: Copied from LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt.
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
5:25 PM Changeset in webkit [132430] by Lucas Forschler
  • 1 copy in tags/Safari-537.16

New Tag.

5:24 PM Changeset in webkit [132429] by dpranke@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

Unreviewed, expectations and baseline cleanup.

Remove some old baselines for a test that was converted to a reftest,
and remove entries for tests no longer failing on Chromium Mac ML.

  • platform/chromium-mac-lion/fast/forms/date/date-reset-value-expected.png: Removed.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-reset-value-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date/date-reset-value-expected.png: Removed.
5:24 PM Changeset in webkit [132428] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG compileBlahBlahByVal methods for Contiguous and ArrayStorage have only one caller and should be removed
https://bugs.webkit.org/show_bug.cgi?id=100311

Reviewed by Mark Hahnenberg.

Just trying to simplify things before I make them more complicated again.

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compile):

5:19 PM Changeset in webkit [132427] by Beth Dakin
  • 5 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=100169
We should make TileCache tiles the size of the tile coverage rect
when we can't do fast scrolling
-and-
<rdar://problem/12505021>

Reviewed by Simon Fraser.

Source/WebCore:

Some websites that don't do fast scrolling still scroll slower than
they do with tiled drawing disabled.
https://bugs.webkit.org/show_bug.cgi?id=99768 addressed some of this
performance problem, but there is still more ground to make up. This
patch addresses the remaining issue by making tiles the size of the
window when we can't do fast scrolling.

The constructor and create function no longer take a size parameter.
That's all fully controlled within TileCache now. m_tileSize is no
longer const.

  • platform/graphics/ca/mac/TileCache.h:

Store the current default size as constants so that we can access it
in both the constructor and adjustTileSizeForCoverageRect().

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):

This new function will set m_tileSize to the size of the tile
coverage rect if the tile coverage is limited to the visible area.
Otherwise, the tiles are set to be the default size.
(WebCore::TileCache::adjustTileSizeForCoverageRect):

Call adjustTileSizeForCoverageRect().
(WebCore::TileCache::revalidateTiles):

No need to send in a size anymore.

  • platform/graphics/ca/mac/WebTileCacheLayer.h:

(WebCore):

LayoutTests:

New test.

  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
  • platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html: Added.
4:59 PM Changeset in webkit [132426] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make it a compile error to send a sync message as async (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=100285

Reviewed by Sam Weinig.

Add an "isSync" boolean to each generated message struct and add compile asserts to the message senders.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):

  • Scripts/webkit2/messages_unittest.py:
  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::send):
(WebKit::WebProcessProxy::sendSync):

4:55 PM Changeset in webkit [132425] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Disable auto termination of WebKit2 processes on mac
https://bugs.webkit.org/show_bug.cgi?id=100176

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Disable WebKit2 auto termination by taking corresponding assertion
until UI process is enhanced to determine when it is safe to enable it.

  • NetworkProcess/mac/NetworkProcessMainMac.mm:

(WebKit::NetworkProcessMain):

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:

(WebKit::SharedWorkerProcessMain):

  • WebProcess/mac/WebProcessInitialization.mm:

(WebKit::InitializeWebProcess):

4:49 PM Changeset in webkit [132424] by Dave Barton
  • 4 edits in trunk

MathML tests trigger font cache assertions in debug bots
https://bugs.webkit.org/show_bug.cgi?id=100268

Reviewed by Eric Seidel.

Source/WebCore:

Add a FontCachePurgePreventer to fix this.

Tested by existing tests.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

LayoutTests:

  • platform/chromium/TestExpectations:
4:46 PM Changeset in webkit [132423] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: truncate meter lines properly on windows
https://bugs.webkit.org/show_bug.cgi?id=100062

Reviewed by Tony Chang.

This change adds the code to figure out the terminal width
on windows (it was already there for Unixen) and moves it
to a platform-specific object.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.terminal_width):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.total_bytes_memory):
(MockPlatformInfo):
(MockPlatformInfo.terminal_width):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.init):
(MeteredStream.number_of_columns):
(MeteredStream.flush):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.init):
(Printer._test_status_line):

4:40 PM Changeset in webkit [132422] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Update main frame scroll position immediately for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=98074

Reviewed by Simon Fraser.

Immediately update the main frame scroll position after a programmatic scroll,
so that performing a scrollBy or scrollTo will be instantly reflected in
all of the scroll offset accessors.

No new tests; this will be tested by many scrolling tests once WebKitTestRunner
can use threaded scrolling.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

4:26 PM Changeset in webkit [132421] by mihaip@chromium.org
  • 8 edits in trunk/Source

[Chromium] Allow pushState and related history APIs to be disabled per context
https://bugs.webkit.org/show_bug.cgi?id=99780

Reviewed by Adam Barth.

Source/WebCore:

Chrome Apps do not support the history API (or navigation in general).
Since pushState is generally feature detected, it's cleanest to disable
it via a V8 per-context feature, so that applications can have the
appropriate fallback behavior (other history APIs are re-mapped to throw
exceptions, since history.back() and the link are not feature detected).

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::pushStateEnabled):
(WebCore):

  • dom/ContextFeatures.h:
  • dom/Document.cpp:

(WebCore::Document::enqueuePopstateEvent):

  • page/History.idl:

Source/WebKit/chromium:

Add pushState context feature.

  • public/WebPermissionClient.h:

(WebPermissionClient):
(WebKit::WebPermissionClient::allowPushState):

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

4:24 PM Changeset in webkit [132420] by tommyw@google.com
  • 4 edits
    2 adds in trunk

Source/WebCore: MediaStream API: Make sure all events are dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=100286

Reviewed by Adam Barth.

This is necessary to safeguard against if the UA uses synchronous UA->WebKit calls,
and the web application calls methods on the RTCPeerConnection in the event callbacks.

Test: fast/mediastream/RTCPeerConnection-events.html
Also tested by the chromium webrtc fuzz tests.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::negotiationNeeded):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
(WebCore::RTCPeerConnection::didAddRemoteDataChannel):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::changeIceState):
(WebCore):
(WebCore::RTCPeerConnection::scheduleDispatchEvent):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

LayoutTests: MediaStream API: Make sure all RTCPeerConnection events are dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=100286

Reviewed by Adam Barth.

RTCPeerConnection::close is the only function that dispatches an event directly so only test that.

  • fast/mediastream/RTCPeerConnection-events-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-events.html: Added.
4:19 PM Changeset in webkit [132419] by pilgrim@chromium.org
  • 13 edits
    2 copies in trunk/Source

[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebScreenInfo.h: Added.

(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

  • WebCore.gypi:
  • platform/Widget.h:
  • platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.

(PageClientChromium):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::screenInfo):
(WebKit):

  • src/ChromeClientImpl.h:

(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebPagePopupImpl.cpp:
4:18 PM Changeset in webkit [132418] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Chromium revision 163873 also made
platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint.html slow.

  • platform/chromium/TestExpectations:
4:17 PM Changeset in webkit [132417] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] WorkerContextExecutionProxy doesn't need to track events
https://bugs.webkit.org/show_bug.cgi?id=100295

Reviewed by Eric Seidel.

This code was added when this code was originally upstreamed as part of
the Chromium port. There doesn't appear to be any reason why
WorkerContextExecutionProxy needs to keep a Vector of raw event
pointers. Those points are likely to become dangling, making the rest
of what this code does very sketchy.

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::dispose):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
(WorkerContextExecutionProxy):

4:01 PM Changeset in webkit [132416] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

[CSS Shaders] The mesh should be specified using <column, row> order
https://bugs.webkit.org/show_bug.cgi?id=96285

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-24
Reviewed by Dean Jackson.

Source/WebCore:

Change StyleResolver and CSSComputedStyleDeclaration to handle the mesh parameters in
column, row order.

Test: css3/filters/custom/custom-filter-mesh-column-row-order.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

Append the number of columns before the number of rows in the meshParameters
CSSValueList.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperation):

Store the second mesh parameter in meshRows instead of meshColumns.

LayoutTests:

Add a test verifying that WebKit interprets the CSS mesh values in column, row order.
Update existing tests for u_meshSize and u_tileSize to expect column, row order.

  • css3/filters/custom/custom-filter-mesh-column-row-order-expected.html: Added.
  • css3/filters/custom/custom-filter-mesh-column-row-order.html: Added.
  • css3/filters/resources/checkerboard.vs: Added.
  • css3/filters/resources/u-mesh-size.fs:
  • css3/filters/resources/u-tile-size.fs:
  • css3/filters/resources/varying-mix-color.fs: Added.
4:00 PM Changeset in webkit [132415] by dpranke@chromium.org
  • 2 edits in trunk/Tools

tweak debug logging in webkit-patch optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=100294

Reviewed by Ojan Vafai.

This changes the logging to print out the baselines found
(and their checksums) even when we don't do anything.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer.optimize):

3:49 PM Changeset in webkit [132414] by commit-queue@webkit.org
  • 2 edits in trunk

[BlackBerry] change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags
https://bugs.webkit.org/show_bug.cgi?id=100256

Patch by Michael Carmody <mcarmody@rim.com> on 2012-10-24
Reviewed by Rob Buis.

This allow override of compile flags without having to edit CMake files.

  • Source/cmake/OptionsBlackBerry.cmake:
3:45 PM Changeset in webkit [132413] by tony@chromium.org
  • 2 edits
    1 move
    1 add in trunk/LayoutTests

[chromium] Unreviewed, land pixel results on Win/Mac for a new repaint test.

  • platform/chromium-mac/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
  • platform/chromium-win/css3/flexbox/repaint-during-resize-no-flex-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/repaint-during-resize-no-flex-expected.png.
  • platform/chromium/TestExpectations:
3:40 PM Changeset in webkit [132412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

loaderRunLoop() should use synchronization instead of while loop
https://bugs.webkit.org/show_bug.cgi?id=55402

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Originally, loaderRunLoop() sleeps until a thread has started and set
the loaderRunLoopObject static variable. This patch uses
ThreadCondition to synchronize instead of a while loop.

No new tests (No behavior change).

  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):

  • platform/network/cf/LoaderRunLoopCF.h:

(WebCore):

3:36 PM Changeset in webkit [132411] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Incorrect keycodes for numpad /, -, +, .
https://bugs.webkit.org/show_bug.cgi?id=99188

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-24
Reviewed by Tony Chang.

Source/WebCore:

In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.

Test: platform/mac/fast/events/numpad-keycode-mapping.html

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.

  • src/mac/WebInputEventFactory.mm: Disallow mapping numpad keys by character code.

(WebKit::windowsKeyCodeForKeyEvent):

  • tests/WebInputEventFactoryTestMac.mm: Test to verify that all numpad keys are correctly mapped.

(TEST):

Tools:

Add key mappings for all numpad keys.

  • DumpRenderTree/mac/EventSendingController.mm:

(KeyMappingEntry):
(-[EventSendingController keyDown:withModifiers:withLocation:]): Added all numpad keys.

LayoutTests:

Added test to map numpad keys to windows virtual keycodes. This test is for the Mac port only. DumpRenderTree in the chromium-mac port doesn't use Mac keycodes so this can't be tested on that platform.

  • platform/mac/fast/events/numpad-keycode-mapping-expected.txt: Added.
  • platform/mac/fast/events/numpad-keycode-mapping.html: Added.
3:04 PM Changeset in webkit [132410] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up references to Skipped files
https://bugs.webkit.org/show_bug.cgi?id=100045

Reviewed by Ojan Vafai.

Since they are no longer used or needed ...

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port.expectations_files):
(Port._wk2_port_name):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.test_default_timeout_ms):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(test_expectations_files):
(test_expectations_files.platform_dirs):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.init):

3:01 PM Changeset in webkit [132409] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Null-check the RenderView in ocument::windowScreenDidChange to fix a crash when saving PDFs
https://bugs.webkit.org/show_bug.cgi?id=100141
<rdar://problem/12559147>

Reviewed by Tim Horton.

For PDF documents the RenderView is null, so null-check it to avoid a crash
when saving PDFs.

  • dom/Document.cpp:

(WebCore::Document::windowScreenDidChange):

3:00 PM Changeset in webkit [132408] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking the software compositing version of
compositing/tiling/backface-preserve-3d-tiled.html as failing as well.

  • platform/chromium/TestExpectations:
2:58 PM Changeset in webkit [132407] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.

  • platform/chromium/TestExpectations:
2:54 PM Changeset in webkit [132406] by tdanderson@chromium.org
  • 6 edits
    2 adds in trunk

Handle two-finger tap gestures in the same way as long-press gestures
https://bugs.webkit.org/show_bug.cgi?id=99947

Reviewed by Adam Barth.

Source/WebCore:

Currently a long-press gesture is used to dispatch a context menu (for platforms
defining CONTEXT_MENUS) or to select text (for Android). Additionally, for platforms
defining TOUCH_ADJUSTMENT, gesture target fuzzing is performed on the location and
touch area of the long-press gesture.

This CL will cause two-finger tap gestures to be handled in the same way as long-press
gestures. The location and touch area of a two-finger tap gesture will correspond to
the location and touch area of the first finger down; the location/area of the second
finger will be ignored.

Test: touchadjustment/touch-links-two-finger-tap.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureLongPress):
(WebCore):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore::EventHandler::adjustGesturePosition):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Set the area of a two-finger tap gesture to be the area of the enclosing
rectangle for the first finger down.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

New layout test for dispatching context menus on a two-finger tap
gesture when touch adjustment is enabled.

  • touchadjustment/touch-links-two-finger-tap-expected.txt: Added.
  • touchadjustment/touch-links-two-finger-tap.html: Added.
2:51 PM Changeset in webkit [132405] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebKit2

[EFL][WK2] Get rid of Ewk_View private C API (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=100230

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Remove part of the Ewk_View private C API and replace
it by C++ methods in EwkViewImpl class. Eventually,
all the private C functions will be removed but it
will be done in several patches.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewGetPage):

  • UIProcess/API/efl/EwkViewImpl.cpp:

(_ewk_view_commit):
(_ewk_view_preedit_changed):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::smartData):
(EwkViewImpl::fromEvasObject):
(EwkViewImpl::wkPage):
(EwkViewImpl::setCursor):
(EwkViewImpl::redrawRegion):
(EwkViewImpl::informDownloadJobCancelled):
(EwkViewImpl::informDownloadJobFailed):
(EwkViewImpl::informDownloadJobFinished):
(EwkViewImpl::informDownloadJobRequested):
(EwkViewImpl::informNewFormSubmissionRequest):
(EwkViewImpl::enterFullScreen):
(EwkViewImpl::exitFullScreen):
(EwkViewImpl::setImageData):
(EwkViewImpl::informLoadError):
(EwkViewImpl::informLoadFinished):
(EwkViewImpl::informLoadProgress):
(EwkViewImpl::informProvisionalLoadFailed):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::informProvisionalLoadRedirect):
(EwkViewImpl::informProvisionalLoadStarted):
(EwkViewImpl::informNavigationPolicyDecision):
(EwkViewImpl::informNewWindowPolicyDecision):
(EwkViewImpl::informResourceLoadStarted):
(EwkViewImpl::informResourceLoadResponse):
(EwkViewImpl::informResourceLoadFailed):
(EwkViewImpl::informResourceLoadFinished):
(EwkViewImpl::informResourceRequestSent):
(EwkViewImpl::informTitleChange):
(EwkViewImpl::informTooltipTextChange):
(EwkViewImpl::informTextFound):
(EwkViewImpl::size):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informIntentRequest):
(EwkViewImpl::informIntentServiceRegistration):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
(EwkViewImpl::informBackForwardListChange):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebCore):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewImpl):
(WebKit):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateTextInputState):
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit::PageClientImpl::didChangeContentsSize):

  • UIProcess/API/efl/PageClientImpl.h:

(WebKit::PageClientImpl::create):
(PageClientImpl):

  • UIProcess/API/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::drawingArea):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

  • UIProcess/API/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::create):
(PageViewportControllerClientEfl):

  • UIProcess/API/efl/ewk_download_job.cpp:

(Ewk_Download_Job::Ewk_Download_Job):
(Ewk_Download_Job::viewImpl):

  • UIProcess/API/efl/ewk_download_job_private.h:

(Ewk_Download_Job::create):
(Ewk_Download_Job):

  • UIProcess/API/efl/ewk_view.cpp:

(pageViewMap):
(addToPageViewMap):
(removeFromPageViewMap):
(_ewk_view_on_favicon_changed):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_impl_del):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(_ewk_view_initialize):
(_ewk_view_add_with_smart):
(ewk_view_context_get):
(ewk_view_url_update):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_icon_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_text_input_state_update):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_page_create):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_contents_size_changed):
(ewk_view_popup_menu_request):
(ewk_view_popup_menu_close):
(ewk_view_popup_menu_select):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
(ewk_view_webprocess_crashed):
(ewk_view_color_picker_color_set):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_inspector_show):
(ewk_view_inspector_close):

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownload):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

  • UIProcess/efl/FindClientEfl.cpp:

(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):
(WebKit::FindClientEfl::FindClientEfl):

  • UIProcess/efl/FindClientEfl.h:

(WebKit::FindClientEfl::create):
(FindClientEfl):

  • UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):
(WebKit::FormClientEfl::FormClientEfl):

  • UIProcess/efl/FormClientEfl.h:

(WebKit::FormClientEfl::create):
(FormClientEfl):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
(WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h:

(WebKit::PageLoadClientEfl::create):
(PageLoadClientEfl):
(WebKit::PageLoadClientEfl::viewImpl):

  • UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
(WebKit::PagePolicyClientEfl::PagePolicyClientEfl):

  • UIProcess/efl/PagePolicyClientEfl.h:

(WebKit::PagePolicyClientEfl::create):
(PagePolicyClientEfl):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::closePage):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::runJavaScriptAlert):
(WebKit::PageUIClientEfl::runJavaScriptConfirm):
(WebKit::PageUIClientEfl::runJavaScriptPrompt):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::PageUIClientEfl):

  • UIProcess/efl/PageUIClientEfl.h:

(WebKit::PageUIClientEfl::create):
(PageUIClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):

  • UIProcess/efl/ResourceLoadClientEfl.h:

(WebKit::ResourceLoadClientEfl::create):
(ResourceLoadClientEfl):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

2:48 PM Changeset in webkit [132404] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX:When aria-label is used, the text under an element is still appearing as the AXTitle
https://bugs.webkit.org/show_bug.cgi?id=98167

Reviewed by Beth Dakin.

Source/WebCore:

According to WAI-ARIA text computation, the presence of aria-label and alternative text
should override the visible text within an element.

Test: platform/mac/accessibility/aria-label-overrides-visible-text.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityTitle]):

LayoutTests:

  • platform/mac/accessibility/aria-label-overrides-visible-text-expected.txt: Added.
  • platform/mac/accessibility/aria-label-overrides-visible-text.html: Added.
  • platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
2:41 PM Changeset in webkit [132403] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk

Unreviewed, rolling out r132303 and r132312.
http://trac.webkit.org/changeset/132303
http://trac.webkit.org/changeset/132312
https://bugs.webkit.org/show_bug.cgi?id=100287

Triggering crashes on many popular websites (Requested by
leviw|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-24

Source/WebCore:

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:
  • css/CSSPropertySourceData.h:
  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):

  • css/RuleSet.h:

(RuleData):
(RuleSet):

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::locateSharedStyle):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):

  • css/StyleRule.h:
  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h:

(WebCore):
(StyleScopeResolver):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

  • fast/dom/shadow/athost-atrules-expected.txt: Removed.
  • fast/dom/shadow/athost-atrules.html: Removed.
2:37 PM Changeset in webkit [132402] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix a crash seen during the Inspector tests on the WebKit1 bots.

Reviewed by Filip Pizlo.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::bringToFront): Use the window from the WebView since m_windowController's window
is not the same when the Inspector is docked.

2:36 PM Changeset in webkit [132401] by jsbell@chromium.org
  • 9 edits
    3 adds in trunk

IndexedDB: Cursor property value identities should be preserved
https://bugs.webkit.org/show_bug.cgi?id=100051

Reviewed by Tony Chang.

Source/WebCore:

Some W3C test submissions point out that subsequent accesses to cursor properties should
yield the same value until the cursor advances. We handled this with custom binding code for
IDBCursor.value but not IDBCursor.key or IDBCursor.primaryKey. The custom value code is
being removed in webkit.org/b/100034 in favor of returning ScriptValue and the same fix can
be applied to key/primaryKey.

Test: storage/indexeddb/cursor-properties.html

  • Modules/indexeddb/IDBCursor.cpp: Compute/store/serve up ScriptValues instead of IDBKeys

(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):
(WebCore::IDBCursor::idbPrimaryKey): Expose this for callers that need access to the IDBKey

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBObjectStore.cpp: ... like this one.

(WebCore):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent): Pass along script context, for the conversion.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::idbKeyToScriptValue): New method for explicit conversion.
(WebCore):

  • bindings/v8/IDBBindingUtilities.h:

(WebCore):

LayoutTests:

Add tests to verify identity/read-only/mutability of cursor properties.

  • storage/indexeddb/cursor-properties-expected.txt: Added.
  • storage/indexeddb/cursor-properties.html: Added.
  • storage/indexeddb/resources/cursor-properties.js: Added.

(test.request.onsuccess):
(test):
(onUpgradeNeeded):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):
(checkProperty):

2:34 PM Changeset in webkit [132400] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Updating slow expectations for two tests following a Chromium
change. See https://bugs.webkit.org/show_bug.cgi?id=100287

  • platform/chromium/TestExpectations:
2:08 PM Changeset in webkit [132399] by ericu@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

https://bugs.webkit.org/show_bug.cgi?id=99202
[Chromium] shift-click fails to spawn new window with target=_blank

Reviewed by Adam Barth

No new tests in WebKit-land--see
https://codereview.chromium.org/11235048/ for tests that I'll submit
once this lands.

  • src/ChromeClientImpl.cpp:

Change currentEventShouldCauseBackgroundTab to updatePolicyForEvent; we
were looking up the right policy, then throwing it away if it wasn't
forcing a background tab.
(WebKit::ChromeClientImpl::updatePolicyForEvent):
(WebKit::ChromeClientImpl::getNavigationPolicy):

2:07 PM Changeset in webkit [132398] by fischman@chromium.org
  • 5 edits in trunk/Source/WebCore

call to setNeedsLayout during RenderVideo::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=100265

Reviewed by Eric Carlson.

Removed unnecessary call and added new defensive guards to catch erroneous setNeedsLayout() calls
during paints earlier (so the offending calls are in the emitted stacktrace).

No new tests - new defensive checks are triggered by existing tests.

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents): forbid setNeedsLayout() during painting

  • rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::SetLayoutNeededForbiddenScope):
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::~SetLayoutNeededForbiddenScope):

  • rendering/RenderObject.h:

(RenderObject):
(SetLayoutNeededForbiddenScope): added helper class for forbidding setNeedsLayout() in a scope.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced): drop the offending & unnecessary call to updatePlayer().

2:02 PM Changeset in webkit [132397] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] ActiveDOMObjectEpilogueVisitor is unnecessary and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=100208

Reviewed by Eric Seidel.

Rather than clearing and re-establishing the weak callback for
ActiveDOMObjects during every GC, this patch puts all the
ActiveDOMObjects with pending activity into an object group with a live
object, causing them not to be garbage collected.

In addition to simplifying this code, this patch makes the patch in
https://bugs.webkit.org/show_bug.cgi?id=100175 much easier because
V8GCController no longer needs to know how to configure the weak
callbacks for these objects.

  • bindings/v8/V8GCController.cpp:

(WebCore::ActiveDOMObjectPrologueVisitor::ActiveDOMObjectPrologueVisitor):
(ActiveDOMObjectPrologueVisitor):
(WebCore::ActiveDOMObjectPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::majorGCEpilogue):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::liveRoot):
(V8PerIsolateData):

1:49 PM Changeset in webkit [132396] by beidson@apple.com
  • 26 edits
    1 add in trunk/Source

Add a strategy for loader customization.
https://bugs.webkit.org/show_bug.cgi?id=100278

Reviewed by Alexey Proskuryakov.

Source/WebCore:

It's empty for now and does nothing, just like the goggles.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::loaderStrategy):
(PlatformStrategies):
(WebCore::PlatformStrategies::PlatformStrategies):

Source/WebKit/efl:

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesEfl.h:

(PlatformStrategiesEfl):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesGtk.h:

(PlatformStrategiesGtk):

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::createLoaderStrategy):

Source/WebKit/qt:

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createLoaderStrategy):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::createLoaderStrategy):

  • WebCoreSupport/PlatformStrategiesWinCE.h:

(PlatformStrategiesWinCE):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createLoaderStrategy):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

1:46 PM Changeset in webkit [132395] by tony@chromium.org
  • 4 edits
    3 adds in trunk

Setting width of a flexitem causes the adjacent flex item to be displayed poorly.
https://bugs.webkit.org/show_bug.cgi?id=99925

Reviewed by Ojan Vafai.

Source/WebCore:

Make sure that we always repaint when moving a child. This is similar to what RenderDeprecatedFlexibleBox does.

Test: css3/flexbox/repaint-during-resize-no-flex.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild): Move logic for repaining into the helper method
for setting the location of a child.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Remove code for repaint since it's now in setFlowAwareLocationForChild.
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Remove code for repaint since it's now in setFlowAwareLocationForChild.

LayoutTests:

Add a repaint test. The render tree should be cross platform, but due to
slight color differences in the grey overlay, the png can't be shared.

  • css3/flexbox/repaint-during-resize-no-flex-expected.txt: Added.
  • css3/flexbox/repaint-during-resize-no-flex.html: Added.
  • platform/chromium-linux/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
  • platform/chromium/TestExpectations:
1:36 PM Changeset in webkit [132394] by Simon Fraser
  • 4 edits
    3 adds in trunk

Fix CALayer hiearchy when combining tiling with preserve-3d
https://bugs.webkit.org/show_bug.cgi?id=100205

Reviewed by Dean Jackson.

Source/WebCore:

When an element has "transform-style: preserve-3d", its GraphicsLayerCA has a
m_structuralLayer which is a CATransformLayer. The primary CALayer which contains rendered
content becomes a sublayer of the CATransformLayer. If the element has backface-visibility:hidden,
it is the primary layer that is set to be single-sided.

In r131940 we started to use TileCaches in place of CATiledLayer. TileCaches work via
"customSublayers" returned from the PlatformCALayer, where the custom sublayer is
the tile cache container layer. However, the custom sublayers were being added as
children of the structural (CATransformLayer) layer, not of the primary (CALayer) layer,
thus they were not affected by the doubleSided property.

This change cleans up the confusing code in GraphicsLayerCA::updateSublayerList()
by maintaining two vectors of PlatformCALayers, one for sublayers of the structural
layer, and one for sublayers of the primary layer. It adds custom sublayers to
the latter list, so now the tile cache container layer becomes a sublayer of
the primary layer, so is affected by that layer's doubleSided property.

Test: compositing/tiling/backface-preserve-3d-tiled.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateSublayerList):

LayoutTests:

Pixel test that tests backface-visibility on a tile cache layer. Mark the test as
failing on Chromium.

  • compositing/tiling/backface-preserve-3d-tiled-expected.png: Added.
  • compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
  • compositing/tiling/backface-preserve-3d-tiled.html: Added.
  • platform/chromium/TestExpectations:
1:33 PM Changeset in webkit [132393] by zmo@google.com
  • 6 edits in trunk/Source/WebCore

Update mozilla's CheckedInt.h to the latest version
https://bugs.webkit.org/show_bug.cgi?id=100177

Reviewed by Kenneth Russell.

  • html/canvas/CheckedInt.h: Sync with mozilla's copy with minumum modifications.

(detail):
(IsSupportedPass2):
(IsSupported):
(UnsignedType):
(IsSigned):
(TwiceBiggerType):
(PositionOfSignBit):
(MinValue):
(MaxValue):
(WebCore::detail::HasSignBit):
(WebCore::detail::BinaryComplement):
(WebCore::detail::IsInRange):
(WebCore::detail::IsAddValid):
(WebCore::detail::IsSubValid):
(WebCore::detail::IsMulValid):
(WebCore::detail::IsDivValid):
(WebCore::detail::OppositeIfSignedImpl::run):
(WebCore::detail::OppositeIfSigned):
(WebCore):
(CheckedInt):
(WebCore::CheckedInt::CheckedInt):
(WebCore::CheckedInt::value):
(WebCore::CheckedInt::isValid):
(WebCore::CheckedInt::operator -):
(WebCore::CheckedInt::operator ==):
(WebCore::CheckedInt::operator++):
(WebCore::CheckedInt::operator--):
(CastToCheckedIntImpl):
(WebCore::detail::CastToCheckedIntImpl::run):
(WebCore::castToCheckedInt):
(WebCore::operator ==):

  • html/canvas/DataView.cpp: change valid() to isValid().

(WebCore::DataView::create):

  • html/canvas/WebGLBuffer.cpp: Ditto.

(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):

  • platform/graphics/GraphicsContext3D.cpp: Ditto.

(WebCore::GraphicsContext3D::computeImageSizeInBytes):

1:33 PM Changeset in webkit [132392] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Reviewed by Caio Marcelo de Oliveira Filho.

In some cases there are pending changes in the layers, but no actual changes to the frame.
In that case we should unlock the animations.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

1:31 PM Changeset in webkit [132391] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change [Part II]
https://bugs.webkit.org/show_bug.cgi?id=100259

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 219666
Revert "[BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen"
This rolls out r128772.
The patches relies on the viewport size change of the client side to
resume the screen and backing store updates. However, some client
sides don't need or wish to resize the WebKit viewport at all which
will result in upexpected screen and backing store suspensions.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

1:30 PM Changeset in webkit [132390] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change
https://bugs.webkit.org/show_bug.cgi?id=100259

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 219666
Roll out r130392 and r129909.
The patches rely on the viewport size change of the client side to
update the scale and scroll position of the video. However, some client
sides don't need or wish to resize the WebKit viewport at all.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:20 PM Changeset in webkit [132389] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

[Qt-on-Mac] GraphicsSurfaces should not create a global IOSurface handle
https://bugs.webkit.org/show_bug.cgi?id=89885

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use mach_port instead of global tokens for IOSurfaces.
Global IOSurfaces are accessible from other processes using their handle, while mach_ports
can only be shared directly via IPC.

Tested by existing WebGL tests.

  • platform/graphics/surfaces/GraphicsSurfaceToken.h:

(GraphicsSurfaceToken):

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):

Source/WebKit2:

Use mach_port instead of global tokens for IOSurfaces.
Global IOSurfaces are accessible from other processes, while mach_ports can only be shared
directly via IPC.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

1:18 PM Changeset in webkit [132388] by commit-queue@webkit.org
  • 6 edits in trunk

image-set doesn't round-trip properly with cssText
https://bugs.webkit.org/show_bug.cgi?id=99725

Patch by Rick Byers <rbyers@chromium.org> on 2012-10-24
Reviewed by Beth Dakin.

Source/WebCore:

Fix serialization of -webkit-image-set rules to use the same format as
is used for parsing.

Test: fast/css/image-set-setting.html

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::customCssText):

  • css/CSSValueList.h:

(WebCore::CSSValueList::item): Add const overload

LayoutTests:

Update image-set-setting test to expect the css text to round-trip properly.

  • fast/css/image-set-setting-expected.txt:
  • fast/css/script-tests/image-set-setting.js:

(testComputedStyle):
(testImageSetRule):

1:15 PM Changeset in webkit [132387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

BlackBerry fix for webgl-depth-texture.html
https://bugs.webkit.org/show_bug.cgi?id=100258

Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2012-10-24
Reviewed by Yong Li.

Removed a platform specific define that is unnecessary.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

12:31 PM Changeset in webkit [132386] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Add per destination ID message receivers
https://bugs.webkit.org/show_bug.cgi?id=100276

Reviewed by Andreas Kling.

Extend MessageReceiverMap to handle adding message receivers for a given destinationID/receiver name pair.
Use this to make every WebPage object a message receiver.

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::removeMessageReceiver):
(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):

  • Platform/CoreIPC/MessageReceiverMap.h:

(MessageReceiverMap):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addMessageReceiver):
(WebKit):
(WebKit::WebProcess::removeMessageReceiver):
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):

12:31 PM Changeset in webkit [132385] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/chromium

Create skia_webkit.gyp to improve rebaselining.
https://bugs.webkit.org/show_bug.cgi?id=99759

Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-24
Reviewed by Dirk Pranke.

This allows for code suppressions to be lifted atomically with new baselines.

  • skia_webkit.gyp: Added.
12:30 PM Changeset in webkit [132384] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

Honor image orientation in GraphicsContextSkia
https://bugs.webkit.org/show_bug.cgi?id=100179

Reviewed by Stephen White.

Also fix a bug in ImageOrientation.h: Some of the values were
switched. They now match the description in the exif spec at
http://www.exif.org/Exif2-2.PDF page 18, and the notes at
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/EXIF.html and
the picture at http://www.80sidea.com/archives/2316.

They showed up correctly in Safari because the orientation transform
was done after flipping Y. Let the flipping happen later. I verified
that flipping transformation order and fixing the exif enum cancelled
each other out, so this has no effect on the apple port.

Not hooked up yet, so no observable difference.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageOrientation.h:

(WebCore::ImageOrientation::usesWidthAsHeight):
(WebCore::ImageOrientation::fromEXIFValue):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::paintSkBitmap):
(WebCore::BitmapImage::draw):
(WebCore):

12:17 PM Changeset in webkit [132383] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed Windows path for SharedWorkerStrategy.h - it's in workers/, not platform/.

  • WebCore.vcproj/WebCore.vcproj:
12:10 PM Changeset in webkit [132382] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining two Video Track tests after r132349.

  • platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:
12:02 PM Changeset in webkit [132381] by Chris Fleizach
  • 3 edits
    2 moves
    2 deletes in trunk

AX: WebKit exposes abstract ARIA role range as AXSlider; should be generic AXGroup
https://bugs.webkit.org/show_bug.cgi?id=100204

Reviewed by Beth Dakin.

Source/WebCore:

Remove the "range" role as a valid ARIA role.

Test: platform/mac/accessibility/aria-slider-value.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

LayoutTests:

Remove the aria-range.html test because the same functionality is covered in aria-slider.html
Rename aria-range-value to aria-slider-value and use the non-abstract role slider instead (and
move that to the general accessibility platform).

  • accessibility/aria-slider-value-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-range-value-expected.txt.
  • accessibility/aria-slider-value.html: Copied from LayoutTests/platform/mac/accessibility/aria-range-value.html.
  • platform/mac/accessibility/aria-range-expected.txt: Removed.
  • platform/mac/accessibility/aria-range-value-expected.txt: Removed.
  • platform/mac/accessibility/aria-range-value.html: Removed.
  • platform/mac/accessibility/aria-range.html: Removed.
12:00 PM Changeset in webkit [132380] by timothy@apple.com
  • 4 edits in trunk/Source

Make the Inspector WKView/WebView become the first responder when bringToFront is called.

https://bugs.webkit.org/show_bug.cgi?id=100209

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::bringToFront): Make the Inspector WebView become the first responder.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront): Make the Inspector WKView become the first responder.

11:48 AM Changeset in webkit [132379] by zoltan@webkit.org
  • 1 edit
    2 moves
    3 adds in trunk/PerformanceTests

Turn PageLoad tests into simple performancetests, commit #1
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #1 commit of the whole patch.

  • PageLoad/svg/files/az-lizard_benji_park_01.svg: Removed.
  • PageLoad/svg/files/bamboo_01.svg: Removed.
  • SVG/AzLizardBenjiPark.html: Added.
  • SVG/Bamboo.html: Added.
  • SVG/resources: Added.
  • SVG/resources/AzLizardBenjiPark.svg: Copied from PerformanceTests/PageLoad/svg/files/az-lizard_benji_park_01.svg.
  • SVG/resources/Bamboo.svg: Copied from PerformanceTests/PageLoad/svg/files/bamboo_01.svg.
11:28 AM Changeset in webkit [132378] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/media/w3c/test_media_queries.html as slow on
Chromium debug bots following r132352. It may still timeout...

  • platform/chromium/TestExpectations:
11:13 AM Changeset in webkit [132377] by fmalita@chromium.org
  • 8 edits in trunk

[Chromium] SVG repaint issues
https://bugs.webkit.org/show_bug.cgi?id=99874

Reviewed by Levi Weintraub.

Source/WebCore:

RenderSVGRoot::paintReplaced() converts the container offsets to a relative transform,
but in doing so it ends up accumulating subpixel rounding deltas twice: first for
adjustedPaintOffset and second in localToParentTransform(). If coordinates are on
half-pixel boundaries, the 2x rounding delta yields a full pixel drift and we end up
painting at the wrong location.

This can be avoided by using localToBorderBoxTransform() directly, which (unlike
localToParentTransform()) doesn't perform rounding.

No new tests: existing pixel results cover this change after rebaseline.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

LayoutTests:

  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
  • platform/chromium/TestExpectations:
11:10 AM Changeset in webkit [132376] by danakj@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

Layout tests to verify scaled composited layers have crisp text
https://bugs.webkit.org/show_bug.cgi?id=96940

Reviewed by Adrienne Walker.

Chromium bug: crbug.com/149943

  • compositing/text-on-scaled-layer-expected.html: Added.
  • compositing/text-on-scaled-layer.html: Added.
  • compositing/text-on-scaled-surface-expected.html: Added.
  • compositing/text-on-scaled-surface.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
11:08 AM Changeset in webkit [132375] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Fixing the Chromium build after typo in r132367.

  • WebCore.gypi:
11:02 AM Changeset in webkit [132374] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Respect image orientation in image dragging code
https://bugs.webkit.org/show_bug.cgi?id=100200

Reviewed by Tony Chang.

Based on the corresponding code in DragImageMac.mm. The image
rotation code isn't hooked up yet, so no observable effect for now.

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):

11:00 AM Changeset in webkit [132373] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Code cleanup after r132165
https://bugs.webkit.org/show_bug.cgi?id=100135

Reviewed by Geoffrey Garen.

Fixed up some unneccesary and inefficient constructs in MarkupTokenBase.h.

Code clean up without functional changes, therefore no new tests.

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::beginEndTag): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToCharacter): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToName): Elimintated inline.
(WebCore::MarkupTokenBase::name): Elimintated inline.
(WebCore::MarkupTokenBase::nameString): Elimintated inline.

10:56 AM Changeset in webkit [132372] by leviw@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreveiewed gardening. Fixing linter, marking 2 mathml tests as flaky crashers on debug,
and adding passing Lion expectations for a third mathml test.

  • platform/chromium/TestExpectations:
  • platform/chromium-mac-lion/mathml/presentation/fenced-expected.png: Modified.
10:55 AM Changeset in webkit [132371] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658

Patch by Toni Barzic <tbarzic@chromium.org> on 2012-10-24
Reviewed by Adam Barth.

Source/WebCore:

DOMWindow::console may return NULL, so we should do a NULL check before adding message to it.
This may happen e.g. if a worker throws an exception just as the document is being replaced in the view.
The exception task could be processes after current window in the frame changes, and console in the document window is nulled.

Test: fast/workers/worker-exception-during-navigation.html

  • dom/Document.cpp:

(WebCore::Document::addMessage):

LayoutTests:

The test creates bunch of workers that throw an exception as soon as they are loaded and then tries to change the current document.
The test passes if there is no crash.
Unfortuantely, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).

  • fast/workers/resources/worker-exception.js: Added.
  • fast/workers/worker-exception-during-navigation-expected.txt: Added.
  • fast/workers/worker-exception-during-navigation.html: Added.
10:44 AM Changeset in webkit [132370] by jochen@chromium.org
  • 4 edits in trunk/Tools

[chromium] Use include paths relative to Source/ in the TestRunner's public API
https://bugs.webkit.org/show_bug.cgi?id=100079

Reviewed by Adam Barth.

For a inside-chromium build, we usually don't add the WebKit API paths
as include paths, so including files by name only does not work.

Eventually we might want to move to a model where all includes are
relative to Source/, so we're using that here already now.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
10:36 AM Changeset in webkit [132369] by ojan@chromium.org
  • 4 edits in trunk/Tools

Show an error when there are no completed builds in the past 20 runs
https://bugs.webkit.org/show_bug.cgi?id=100266

Reviewed by Dimitri Glazkov.

Right now we get a cryptic JS error in the console when loading the gtk port. This at least gives an error in
the notification stream. We should probably tweak this UI to make it so we can make
errors in the notification stream stick out (e.g. make the text red).

We should also consider making the number of runs to load dynamic (e.g. if 20 runs don't work,
try 40).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
10:29 AM Changeset in webkit [132368] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Incorrect conditional use of LogFTP
https://bugs.webkit.org/show_bug.cgi?id=100260

Patch by Cosmin Truta <ctruta@rim.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Use LogFTP if !LOG_DISABLED, to allow toggling ASSERTIONS_DISABLED_DEFAULT
without breaking the build.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocument::FTPDirectoryDocument):

10:28 AM Changeset in webkit [132367] by ap@apple.com
  • 28 edits
    1 add in trunk/Source

Add a strategy for shared workers
https://bugs.webkit.org/show_bug.cgi?id=100165

Reviewed by Brady Eidson.

10:22 AM Changeset in webkit [132366] by weinig@apple.com
  • 12 edits in trunk/Source/WebKit2

Move a few more WebProcess sub-objects to be MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=100186

Reviewed by Anders Carlsson.

  • WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::WebBatteryManager):

  • WebProcess/Battery/WebBatteryManager.h:

(WebBatteryManager):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:

(WebIconDatabaseProxy):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.h:

(WebNetworkInfoManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::WebNotificationManager):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::WebSoupRequestManager):

  • WebProcess/soup/WebSoupRequestManager.h:

(WebSoupRequestManager):

10:20 AM Changeset in webkit [132365] by Dave Barton
  • 4 edits in trunk

[MathML] Timeouts on linux after r132264
https://bugs.webkit.org/show_bug.cgi?id=100202

Reviewed by Eric Seidel.

Source/WebCore:

When building a stretched operator, such as a large parenthesis or bracket, we need to
check that the extension glyph's height is > 0, to avoid an infinite loop. The 0 height
can occur if the glyph is missing on the host system.

Tested by existing tests.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

LayoutTests:

The failing tests no longer timeout.

  • platform/chromium/TestExpectations:
10:02 AM Changeset in webkit [132364] by vollick@chromium.org
  • 4 edits in trunk/Tools

[chromium] Explicitly disable accelerated animations in DRT
https://bugs.webkit.org/show_bug.cgi?id=100241

Reviewed by Adrienne Walker.

Disable accelerated animations by default in DRT.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::setAcceleratedAnimationEnabled):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

9:43 AM Changeset in webkit [132363] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Typos in user-visible strings: "coordintate"
https://bugs.webkit.org/show_bug.cgi?id=100252

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

s/coordintate/coordinate

  • webkit/webkithittestresult.cpp:

(webkit_hit_test_result_class_init):

9:39 AM WebKitGTK/1.10.x edited by mrobinson@webkit.org
(diff)
9:23 AM Changeset in webkit [132362] by zoltan@webkit.org
  • 2 edits in trunk/PerformanceTests

REGRESSION(r131982): Skip SVG/SvgNestedUse.html performancetest since it is crashing
https://bugs.webkit.org/show_bug.cgi?id=100262

Unreviewed.

Skip until proper fix.

  • Skipped: Add SVG/SvgNestedUse.html
9:18 AM Changeset in webkit [132361] by andersca@apple.com
  • 128 edits in trunk/Source/WebKit2

encode should take an ArgumentEncoder reference
https://bugs.webkit.org/show_bug.cgi?id=100183

Reviewed by Jessie Berlin.

  • Platform/CoreIPC/ArgumentCoder.h:

(CoreIPC::ArgumentCoder::encode):

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments0::encode):
(CoreIPC::Arguments1::encode):
(CoreIPC::Arguments2::encode):
(CoreIPC::Arguments3::encode):
(CoreIPC::Arguments4::encode):
(CoreIPC::Arguments5::encode):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments10::encode):

  • Platform/CoreIPC/Attachment.cpp:

(CoreIPC::Attachment::encode):

  • Platform/CoreIPC/Attachment.h:

(Attachment):

  • Platform/CoreIPC/DataReference.cpp:

(CoreIPC::DataReference::encode):

  • Platform/CoreIPC/DataReference.h:

(DataReference):

  • Platform/CoreIPC/StringReference.cpp:

(CoreIPC::StringReference::encode):

  • Platform/CoreIPC/StringReference.h:

(StringReference):

  • Platform/CoreIPC/mac/MachPort.h:

(CoreIPC::MachPort::encode):

  • Platform/SharedMemory.h:

(Handle):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::encode):

  • PluginProcess/PluginCreationParameters.h:

(PluginCreationParameters):

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):

  • Shared/DictionaryPopupInfo.h:

(DictionaryPopupInfo):

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):

  • Shared/EditorState.h:

(EditorState):

  • Shared/FontInfo.cpp:

(WebKit::FontInfo::encode):

  • Shared/FontInfo.h:

(FontInfo):

  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):

  • Shared/Network/NetworkProcessCreationParameters.h:

(NetworkProcessCreationParameters):

  • Shared/OriginAndDatabases.cpp:

(WebKit::OriginAndDatabases::encode):

  • Shared/OriginAndDatabases.h:

(OriginAndDatabases):

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::encode):

  • Shared/Plugins/NPIdentifierData.h:

(NPIdentifierData):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::encode):

  • Shared/Plugins/NPVariantData.h:

(NPVariantData):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode):

  • Shared/PrintInfo.h:

(PrintInfo):

  • Shared/SandboxExtension.h:

(Handle):
(HandleArray):

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::encode):

  • Shared/SecurityOriginData.h:

(SecurityOriginData):

  • Shared/SessionState.cpp:

(WebKit::SessionState::encode):

  • Shared/SessionState.h:

(SessionState):

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::encode):

  • Shared/ShareableBitmap.h:

(Handle):

  • Shared/SharedWorkerProcessCreationParameters.cpp:

(WebKit::SharedWorkerProcessCreationParameters::encode):

  • Shared/SharedWorkerProcessCreationParameters.h:

(SharedWorkerProcessCreationParameters):

  • Shared/StatisticsData.cpp:

(WebKit::StatisticsData::encode):

  • Shared/StatisticsData.h:

(StatisticsData):

  • Shared/StringPairVector.h:

(WebKit::StringPairVector::encode):

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):

  • Shared/UpdateInfo.h:

(UpdateInfo):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::encode):

  • Shared/WebContextMenuItemData.h:

(WebContextMenuItemData):

  • Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):

  • Shared/WebEvent.h:

(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::encode):

  • Shared/WebGeolocationPosition.h:

(Data):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::encode):

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::encode):

  • Shared/WebHitTestResult.h:

(Data):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::encode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):

  • Shared/WebNavigationDataStore.h:

(WebKit::WebNavigationDataStore::encode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):

  • Shared/WebPageGroupData.h:

(WebPageGroupData):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::encode):

  • Shared/WebPopupItem.h:
  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::encode):

  • Shared/WebPreferencesStore.h:

(WebPreferencesStore):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::encode):

  • Shared/mac/AttributedString.h:

(AttributedString):

  • Shared/mac/AttributedString.mm:

(WebKit::AttributedString::encode):

  • Shared/mac/ColorSpaceData.h:

(ColorSpaceData):

  • Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::encode):

  • Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::encode):

  • Shared/mac/PlatformCertificateInfo.h:

(PlatformCertificateInfo):

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::encode):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::encode):
(WebKit::SandboxExtension::HandleArray::encode):

  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::encode):

  • Shared/mac/SecItemRequestData.h:
  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::encode):

  • Shared/mac/SecItemResponseData.h:

(SecItemResponseData):

  • Shared/mac/SecKeychainItemRequestData.cpp:

(WebKit::SecKeychainItemRequestData::encode):

  • Shared/mac/SecKeychainItemRequestData.h:
  • Shared/mac/SecKeychainItemResponseData.cpp:

(WebKit::SecKeychainItemResponseData::encode):

  • Shared/mac/SecKeychainItemResponseData.h:

(SecKeychainItemResponseData):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):

  • WebProcess/Plugins/Plugin.h:

(Parameters):

8:30 AM Changeset in webkit [132360] by commit-queue@webkit.org
  • 6 edits
    2 moves in trunk/Source/WebKit

[BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=100250

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-24
Reviewed by Rob Buis.

Source/WebKit:

Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
to prevent confusion.

PR 230196

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
to prevent confusion.
PR 230196

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • Api/WebPage_p.h:

(WebCore):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/GeolocationClientBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp.

(frameOrigin):
(GeolocationClientBlackBerry::GeolocationClientBlackBerry):
(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::stopUpdating):
(GeolocationClientBlackBerry::lastPosition):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onLocationUpdate):
(GeolocationClientBlackBerry::onLocationError):
(GeolocationClientBlackBerry::onPermission):
(GeolocationClientBlackBerry::setEnableHighAccuracy):

  • WebCoreSupport/GeolocationClientBlackBerry.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h.

(WebKit):
(WebCore):
(GeolocationClientBlackBerry):
(WebCore::GeolocationClientBlackBerry::tracker):

8:28 AM Changeset in webkit [132359] by jocelyn.turcotte@digia.com
  • 6 edits in trunk

[Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=100253

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

We'll need to avoid placing data in QQuickWebView to preserve
its binary compatibility once it's public.
Also make the QQuickWebViewExperimental constructor private.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebView::QQuickWebView):
(QQuickWebView::experimental):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

Tools:

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
Use QQuickWebView::experimental rather than creating a new instance.

8:28 AM Changeset in webkit [132358] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100145

Patch by Parth Patel <parpatel@rim.com> on 2012-10-24
Reviewed by Rob Buis.

Extending the singletons to generic singleton and changing
getInstance() in IconDatabaseClientBlackBerry to instance()
to match the generic singleton template.

Reviewed Internally by Yong Li.

Source/WebCore:

Tests are not modified and added as there was no behavioural change.

  • platform/blackberry/SharedTimerBlackBerry.cpp:

(SharedTimerBlackBerry):
(WebCore):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::initializeIconDataBase):

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/IconDatabaseClientBlackBerry.h:

(IconDatabaseClientBlackBerry):

8:08 AM Changeset in webkit [132357] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: NMI add instrumentation for ResourceBuffer. It gives us 10mb on gmail
https://bugs.webkit.org/show_bug.cgi?id=100254

Reviewed by Yury Semikhatsky.

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::reportMemoryUsage):
(WebCore):

  • loader/ResourceBuffer.h:

(ResourceBuffer):

8:04 AM Changeset in webkit [132356] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Unreviewed Build fix.

CGFloat is already a float in a 32-bit build so narrowPrecisionToFloat() is unnecessary

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionFontSizeScale):

7:51 AM Changeset in webkit [132355] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] ./configure output for CSS Shaders is broken
https://bugs.webkit.org/show_bug.cgi?id=100217

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

Reformat CSS Filters / Shaders check to clean configure output.

  • configure.ac:
7:42 AM Changeset in webkit [132354] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Ewk_Settings refactoring
https://bugs.webkit.org/show_bug.cgi?id=100233

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Ewk_Settings private implementation is now C++ class which allows direct internal
access to WebKit::WebPreferences.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/ewk_settings.cpp:

(Ewk_Settings::preferences):
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):

  • UIProcess/API/efl/ewk_settings_private.h:

(WebKit):
(Ewk_Settings):
(Ewk_Settings::Ewk_Settings):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize):

7:41 AM Changeset in webkit [132353] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebKit2

[EFL][AC] Fix build break when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=100245

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Fix build break after r132337.

  • UIProcess/API/efl/EwkViewImpl.h:
  • UIProcess/API/efl/ewk_view.cpp:
7:38 AM Changeset in webkit [132352] by commit-queue@webkit.org
  • 3 edits
    5 copies
    6 adds in trunk/LayoutTests

CSS3 Media Queries - add resolution tests to W3C test suite
https://bugs.webkit.org/show_bug.cgi?id=100231

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Resolution media feature was implemented, therefore,
W3C tests are added back to the test suite.

  • fast/media/w3c/test_media_queries-expected.txt:
  • fast/media/w3c/test_media_queries.html:

Created platform specific expectations for the platforms that have RESOLUTION_MEDIA_QUERY disabled.

  • platform/blackberry/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/chromium/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/gtk/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/mac/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/win/fast/media/w3c/test_media_queries-expected.txt: Added.
7:34 AM Changeset in webkit [132351] by dominik.rottsches@intel.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk1/TestExpectations: Marking shadow-dom failures after r132303
  • platform/efl-wk2/TestExpectations: Marking focus failure after r132342 and drag-select failure between r132333-r132343.
7:33 AM Changeset in webkit [132350] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
https://bugs.webkit.org/show_bug.cgi?id=100243

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

.:

Search for X11 development libraries (and thus Xext), necessary to
disable the X extensions error reporting.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

These errors generate noise on the reports and in some cases, like when
running perf tests, makes the test fail. By using Xext, we can add a
dummy handler to ignore these errors.

  • PlatformEfl.cmake:
  • WebProcess/efl/WebProcessMainEfl.cpp:

(dummyExtensionErrorHandler):
(WebKit::WebProcessMainEfl):

Tools:

These errors generate noise on the reports and in some cases, like when
running perf tests, makes the test fail. By using Xext, we can add a
dummy handler to ignore these errors.

We could have added this handler on the top level EWK API, but that
would be intrusive and could override handlers defined by the user.

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/efl/main.cpp:

(dummyExtensionErrorHandler):
(main):

7:24 AM Changeset in webkit [132349] by eric.carlson@apple.com
  • 25 edits
    3 adds in trunk

Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Reviewed by Maciej Stachowiak.

Source/WebCore:

  • WebCore.exp.in: Export new WebkitSystemInterface functions.
  • WebCore.xcodeproj/project.pbxproj: Add CaptionUserPreferences.h, CaptionUserPreferencesMac.mm,

and CaptionUserPreferencesMac.h.

  • css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,

background, and text independently.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as

un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.

(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from

setClosedCaptionsVisible

  • html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member

variable. Get caption font scale from theme instead of hard coding.

  • html/shadow/MediaControlElements.h:
  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Change attributes from String to AtomicString.
(WebCore::TextTrack::isValidKindKeyword): Ditto.
(WebCore::TextTrack::setKind): Ditto.
(WebCore::TextTrack::setMode): Ditto.
(WebCore::TextTrack::mode): Ditto.

  • html/track/TextTrack.h:

(WebCore::TextTrack::create): Ditto.
(WebCore::TextTrack::kind): Ditto.
(WebCore::TextTrack::label): Ditto.
(WebCore::TextTrack::setLabel): Ditto.
(WebCore::TextTrack::language): Ditto.
(WebCore::TextTrack::setLanguage): Ditto.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the

shadow pseudo id so it can be used elsewhere.

(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):

  • html/track/TextTrackCue.h:
  • page/CaptionUserPreferences.h: Added.
  • page/CaptionUserPreferencesMac.h: Added.
  • page/CaptionUserPreferencesMac.mm: Added.

(WebCore::userCaptionPreferencesChangedNotificationCallback):
(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac):
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac):
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundColor): Return Color with user's caption

background color preference.

(WebCore::CaptionUserPreferencesMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::CaptionUserPreferencesMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::CaptionUserPreferencesMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow

or webkit-text-stroke property.

(WebCore::CaptionUserPreferencesMac::cssColorProperty): Return a String with css to set a property

with a color value.

(WebCore::CaptionUserPreferencesMac::captionsTextEdgeStyle): Return a String with css to style caption

text with the user's preferred text edge stye.

(WebCore::CaptionUserPreferencesMac::captionsDefaultFont): Return a String with css to style caption

text with the user's preferred font.

(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Return a String with css to style captions

with the user's preferred style.

(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences

changes listener.

(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences

changes listener.

(WebCore::CaptionUserPreferencesMac::updateCaptionStyleSheetOveride): New, if theme has a captions style sheet override,

inject it into the current page group, otherwise remove injected sheet.

  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::registerForCaptionPreferencesChangedCallbacks): New, passthrough to platform specific function

of the same name.

(WebCore::PageGroup::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::PageGroup::userPrefersCaptions): Ditto.
(WebCore::PageGroup::userHasCaptionPreferences): Ditto.
(WebCore::PageGroup::captionFontSizeScale): Ditto.

  • page/PageGroup.h:
  • platform/mac/WebCoreSystemInterface.h: Updated.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

WebKitLibraries:

Update WKSI header with SPI for getting the user caption appearance preferences.

  • WebKitSystemInterface.h:

LayoutTests:

  • media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
  • media/track/track-cue-rendering.html:
  • platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
7:19 AM Changeset in webkit [132348] by vsevik@chromium.org
  • 20 edits
    1 add in trunk

Web Inspector: Introduce workspace provider as a content providing backend for project.
https://bugs.webkit.org/show_bug.cgi?id=100244

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced WorkspaceProvider interface as a content providing backend for project.
Added NetworkWorkspaceProvider as a network based (default) implementation.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):

  • inspector/front-end/NetworkWorkspaceProvider.js: Added.

(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.requestFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.setFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.addFile):
(WebInspector.NetworkWorkspaceProvider.prototype.removeFile):
(WebInspector.NetworkWorkspaceProvider.prototype.reset):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/Workspace.js:

(WebInspector.FileDescriptor):
(WebInspector.WorkspaceProvider):
(WebInspector.WorkspaceProvider.prototype.requestFileContent):
(WebInspector.WorkspaceProvider.prototype.searchInFileContent):
(WebInspector.WorkspaceProvider.prototype.addEventListener):
(WebInspector.WorkspaceProvider.prototype.removeEventListener):
(WebInspector.Project):
(WebInspector.Project.prototype.reset):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.project):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/network-uisourcecode-provider.html:
  • inspector/debugger/script-snippet-model.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/uisourcecode-revisions.html:
6:54 AM Changeset in webkit [132347] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Styles pane: Don't select whole value when I select just a part
https://bugs.webkit.org/show_bug.cgi?id=100242

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-10-24
Reviewed by Alexander Pavlov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):

6:44 AM Changeset in webkit [132346] by vsevik@chromium.org
  • 14 edits in trunk

Web Inspector: UiSourceCode should rely on the workspace as a content provider.
https://bugs.webkit.org/show_bug.cgi?id=100216

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace is now passed to UISourceCode to be used as a content provider.
Content providers are now stored in the workspace/project.
Next step would be to move content providers to workspace providers.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.breakpointStorageId):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentType):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project):
(WebInspector.Project.prototype.addUISourceCode):
(WebInspector.Project.prototype.removeUISourceCode):
(WebInspector.Project.prototype.uiSourceCodes):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
(WebInspector.Workspace.prototype.removeTemporaryUISourceCode):
(WebInspector.Workspace.prototype.reset):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/script-formatter-search.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
  • inspector/uisourcecode-revisions.html:
6:41 AM Changeset in webkit [132345] by allan.jensen@digia.com
  • 7 edits in trunk/Source

[Qt] Expose useful WebCore::Settings
https://bugs.webkit.org/show_bug.cgi?id=100239

Reviewed by Kenneth Rohde Christiansen.

Expose the two settings CaretBrowsingEnabled and NotificationsEnabled.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:

Source/WebKit2:

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::caretBrowsingEnabled):
(QWebPreferences::setCaretBrowsingEnabled):
(QWebPreferences::notificationsEnabled):
(QWebPreferences::setNotificationsEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
6:34 AM Changeset in webkit [132344] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix the GTK+ build.

  • TestWebKitAPI/GNUmakefile.am: Add GTK_FLAGS to

libTestWebKitAPIMain and webcore cflags to TestGtk.

6:18 AM Changeset in webkit [132343] by zeno.albisser@digia.com
  • 8 edits
    2 adds in trunk

Implement GraphicsSurface for Windows.
https://bugs.webkit.org/show_bug.cgi?id=98147

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

  • Target.pri:

Include GraphicsSurfaceWin.cpp in SOURCES on Windows.

  • platform/graphics/surfaces/GraphicsSurface.h:

Add typedef for PlatformGraphicsSurface on Windows.

  • platform/graphics/surfaces/GraphicsSurfaceToken.h:

Add typedef for BufferHandle on Windows.

(GraphicsSurfaceToken):

  • platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp: Added.

The GraphicsSurface implementation on Windows relies on the
availability of ANGLE and the EGL_ANGLE_query_surface_pointer extension.
For Qt this requirements are implicitly satisfied, when Qt is built
on Windows and QT_CONFIG contains OpenGLES2.
The GraphicsSurface then renders a given texture onto an offscreen
pixel buffer surface, queries the surface pointer using the
EGL_ANGLE_query_surface_pointer extension, and transmits the received
surface pointer (share handle) over IPC.
On the UIProcess side, the surface pointer can then be resolved
using eglCreatePbufferFromClientBuffer.

(WebCore):
(WebCore::loadShader):

Initialize the shaders needed for drawing onto the GraphicsSurface.

(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

In case of the instance being on the WebProcess side,
create an EGLContext that shares the texture objects with the provided
share context. Also create two pixel buffer surfaces, one as front- and
one as backbuffer.
Query the surface pointers for the pixel buffer surfaces and initialize
the GraphicsSurfaceToken that can be passed over IPC later.

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):

Release all aquired resources and destroy the pixel buffer surfaces.
Also close the EGL-Display connection.

(WebCore::GraphicsSurfacePrivate::copyFromTexture):

Make the belonging context current on the back buffer surface
and use drawTexture() to draw the provided texture onto the GraphicsSurface.

(WebCore::GraphicsSurfacePrivate::makeCurrent):

Save the previously current context, then make the context belonging
to the GraphicsSurface current.

(WebCore::GraphicsSurfacePrivate::doneCurrent):

Restore the context that was current before calling makeCurrent().

(WebCore::GraphicsSurfacePrivate::swapBuffers):

Swap front and back buffer surfaces and handles.

(WebCore::GraphicsSurfacePrivate::token):
(WebCore::GraphicsSurfacePrivate::frontBufferTextureID):

This function is meant to be called from the UIProcess side.
If no front buffer surface has been created before for the current
front buffer handle, one will be created.
Then eglBindTexImage will be used to actually bind the current
front buffer surface to a texture as a source for drawing.

(WebCore::GraphicsSurfacePrivate::initialFrontBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::frontBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::backBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::releaseFrontBufferTexture):

Free the resources related to the front buffer surface.
On the UIProcess side we never actually bind the back buffer.

(WebCore::GraphicsSurfacePrivate::initializeShaderProgram):

Initialize and link the shader programs necessary for drawing
onto the GraphicsSurface.

(WebCore::GraphicsSurfacePrivate::createSurfaceFromShareHandle):

Creates a single pixel buffer surface from a share Handle.
This function will be called on the UIProcess side,
for the front buffer handle, whenever the buffers have been swapped.

(WebCore::GraphicsSurfacePrivate::drawTexture):

The WebProcess uses this function to draw a given
texture onto the GraphicsSurface's back buffer.

(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

Uses TextureMapperGL::drawTexture() to draw the front buffer texture
to the TextureMapper on the UIProcess side.

(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):

Source/WebKit2:

Add encode and decode implementation for GraphicsSurfaceToken on Windows.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Tools:

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

Activate GraphicsSurface on windows in case opengles2 (ANGLE)
is available in QT_CONFIG.

5:38 AM Changeset in webkit [132342] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=100010

Reviewed by Kenneth Rohde Christiansen.

Force the main view to receive focus even if Evas already
considers it to be focused.

It might happen that a different frame is focused by a page and
the focus change notification does not reach Evas. When another
test is run, the main frame is then not considered to be focused
by WebCore, and things such as focus rings are not drawn as
expected.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::focus):

5:31 AM Changeset in webkit [132341] by rakuco@webkit.org
  • 10 edits
    13 adds in trunk/LayoutTests

[EFL] Hopefully finish rebaselining after r131941 and r131991.

  • platform/efl/compositing/clip-change-expected.png: Added.
  • platform/efl/compositing/geometry/foreground-offset-change-expected.png: Added.
  • platform/efl/compositing/iframes/fixed-position-iframe-expected.png: Added.
  • platform/efl/compositing/iframes/iframe-content-flipping-expected.png:
  • platform/efl/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/efl/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/efl/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
  • platform/efl/compositing/overflow/repaint-after-losing-scrollbars-expected.png:
  • platform/efl/compositing/repaint/newly-composited-on-scroll-expected.png:
  • platform/efl/compositing/repaint/newly-composited-repaint-rect-expected.png:
  • platform/efl/compositing/repaint/shrink-layer-expected.png: Added.
  • platform/efl/compositing/repaint/transform-style-change-expected.png: Added.
  • platform/efl/compositing/rtl: Added.
  • platform/efl/compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
  • platform/efl/compositing/video-page-visibility-expected.png:
  • platform/efl/css3/flexbox/repaint-expected.png:
  • platform/efl/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/efl/fast/canvas/canvas-composite-fill-repaint-expected.png:
  • platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
  • platform/efl/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/efl/fast/canvas/canvas-resize-after-paint-without-layout-expected.png:
  • platform/efl/fast/canvas/setWidthResetAfterForcedRender-expected.png:
5:17 AM Changeset in webkit [132340] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding crash expectations for tests that started crashing after r132286.

  • platform/gtk/TestExpectations:
5:16 AM Changeset in webkit [132339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ASSERTION FAILED: edje(): could not paint native HTML part due to missing theme
https://bugs.webkit.org/show_bug.cgi?id=100227

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Browser crashes on loading any page due to missing theme after
the web process has crashed and recovered.

This patch reset the theme when the web process is recovered to
avoid a crash.

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didRelaunchProcess):

5:05 AM Changeset in webkit [132338] by rakuco@webkit.org
  • 9 edits
    1 delete in trunk

Unreviewed, rolling out r132333.
http://trac.webkit.org/changeset/132333
https://bugs.webkit.org/show_bug.cgi?id=100234

Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-24

Source/WebKit2:

  • Target.pri:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::updateTextCheckerState):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformInitializeContext):

LayoutTests:

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/efl/editing/spelling/spelling-expected.txt: Removed.
5:02 AM Changeset in webkit [132337] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Move Ewk_View_Private_Data out of ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=100228

Patch by Christophe Dumez <Christophe Dumez> and Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Gyuyoung Kim.

Move Ewk_View_Private_Data out of ewk_view.cpp and
rename it to EwkViewImpl. This is a first step towards
getting rid of C'ism in Ewk_View.

In a future, we will make EwkViewImpl a proper C++
class and get rid of the private ewk_view C API so
that WebKit code interacts with EwkViewImpl instead
of Evas_Object.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkViewImpl.cpp: Added.

(_ewk_view_commit):
(_ewk_view_preedit_changed):
(_ewk_view_imf_context_destroy):
(_ewk_view_imf_context_create):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):

  • UIProcess/API/efl/EwkViewImpl.h: Added.

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_priv_del):
(_ewk_view_smart_add):

  • UIProcess/API/efl/ewk_view.h:
4:57 AM Changeset in webkit [132336] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Crash when passing NULL instead of ewk_view instance
https://bugs.webkit.org/show_bug.cgi?id=100078

Reviewed by Gyuyoung Kim.

Although applications should pass valid ewk_view to call ewk_view_XXX,
ewk_view_XXX should not be crashed.

  • UIProcess/API/efl/ewk_view.cpp:

Checked null and early exited from EWK_VIEW_TYPE_CHECK if error occured.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Added test case.

(TEST_F):

4:45 AM Changeset in webkit [132335] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fix build break - undefined reference to 'gtk_init'
https://bugs.webkit.org/show_bug.cgi?id=100221

Unreviewed build fix.

GTK_LIBS is needed for TestWTF.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-10-24

  • TestWebKitAPI/GNUmakefile.am:
4:02 AM Changeset in webkit [132334] by commit-queue@webkit.org
  • 3 edits
    4 moves in trunk/Source/WebKit2

[EFL][WK2] Make find and form clients C++ classes
https://bugs.webkit.org/show_bug.cgi?id=100199

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Make form and find client C++ classes to move away
from C'ism in WK2 EFL port. The new classes have been
moved up to UIProcess/efl instead of UIProcess/API/efl
since it is not part of the public API.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_View_Private_Data):
(_ewk_view_initialize):

  • UIProcess/efl/FindClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp.

(WebKit):
(WebKit::toFindClientEfl):
(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):
(WebKit::FindClientEfl::FindClientEfl):

  • UIProcess/efl/FindClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_find_client_private.h.

(WebKit):
(FindClientEfl):
(WebKit::FindClientEfl::create):

  • UIProcess/efl/FormClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_form_client.cpp.

(WebKit):
(WebKit::toFormClientEfl):
(WebKit::FormClientEfl::willSubmitForm):
(WebKit::FormClientEfl::FormClientEfl):

  • UIProcess/efl/FormClientEfl.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_view_form_client_private.h.

(WebKit):
(FormClientEfl):
(WebKit::FormClientEfl::create):

3:58 AM Changeset in webkit [132333] by g.czajkowski@samsung.com
  • 9 edits
    3 adds in trunk

Source/WebKit2: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Hajime Morita.

When WebKitTestRunner turns on the spelling feature with the resetStateToConsistentValues() method,
it happens that the WebProcess is still not launched (although it is already created).
In this case, isValid() method returns false.

This fix sends a message to the WebProcess messages queue, and the message
will be handled once the WebProcess is ready.

  • Target.pri:

Adds missing files to compile spellcheking feature for WebKit2-Qt
to use WebKit C API from WKTextChecker.h.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::updateTextCheckerState):
Uses canSendMessage() method instead of isValid() to check whether the message to
the WebProcess can be sent.

Tools: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Hajime Morita.

WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Enables spelling by WebKit2 C API.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformInitializeContext):
Attaches WKTextChecker's client and sets default language for WebKit2-EFL port.

LayoutTests: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Hajime Morita.

Unskip the spelling tests from efl-wk2/TestExpectations to run them for WebKit2-EFL.
Add new baselines for two spelling tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/efl/editing/spelling/spelling-expected.txt: Added.
3:43 AM WebKitEFLLayoutTest edited by jussi.kukkonen@intel.com
mention PLUGIN_PROCESS_COMMAND_PREFIX (diff)
2:33 AM Changeset in webkit [132332] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium/TestExpectations:
2:16 AM Changeset in webkit [132331] by yurys@chromium.org
  • 14 edits
    1 add in trunk

Web Inspector: provide memory instrumentation for ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=97786

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Switched existing usages of addListHashSet to the generic instrumentation mechanism
as it should work just just fine now that there is a memory instrumentation of
ListHashSet.

  • dom/DocumentEventQueue.cpp:
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

Source/WebKit/chromium:

Added a test for ListHashSet memory instrumentation.

  • tests/MemoryInstrumentationTest.cpp:

(WebCore::TEST):
(WebCore):

Source/WTF:

Added memory instrumentation for ListHashSet.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/HashSet.h:

(WTF):

  • wtf/ListHashSet.h:

(ListHashSet):
(ListHashSetNodeAllocator): changed visibility of inPool method to public
(WTF::ListHashSetNodeAllocator::pool):
(WTF::ListHashSetNodeAllocator::pastPool):
(WTF::::sizeInBytes): added a method that returns size of the set in bytes including
all its internals but not the content elements.
(WTF):

  • wtf/MemoryInstrumentation.h: removed onsolete method. All clients were updated to

use generic addMember instead.
(MemoryInstrumentation):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentationHashSet.h:
  • wtf/MemoryInstrumentationListHashSet.h: Copied from Source/WTF/wtf/MemoryInstrumentationHashSet.h.

(WTF):
(WTF::reportMemoryUsage):

2:09 AM Changeset in webkit [132330] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update

  • platform/chromium/TestExpectations:
    • exif-orientation-css.html is ImageOnlyFailure.
    • Still need rebaseline for calendar-picker-appearance-step.html on Windows?
1:35 AM Changeset in webkit [132329] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Black screen in web inspector window with AC on
https://bugs.webkit.org/show_bug.cgi?id=100168

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

When ACCELERATED_COMPOSITING flag is turned on, and using X11,
pass "opengl_x11" engine name to ecore_evas_new when creating a
web inspector window. It is guaranteed to be available, because
we wouldn't be able to create a main window if it wasn't.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

1:12 AM Changeset in webkit [132328] by mario@webkit.org
  • 4 edits in trunk

[WK2] [GTK] TestWebKitAccessibility is not being run
https://bugs.webkit.org/show_bug.cgi?id=100102

Reviewed by Carlos Garcia Campos.

.:

Moved check for at-spi2 after the definition of enable_webkit2,
since it's only needed for WebKit2GTK API tests.

  • configure.ac: Moved the check for at-spi2 down in the file.

Tools:

Removed wrong early return in _start_accessibility_daemons().

  • Scripts/run-gtk-tests:

(TestRunner._lookup_atspi2_binary): Removed wrong line.

12:55 AM Changeset in webkit [132327] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip tests that depend on disabling accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=99167

Rubber-stamped by Simon Hausmann.

Skip those tests because we don't support the non-accelerated
rendering path.

  • platform/qt-5.0-wk2/TestExpectations:
12:54 AM Changeset in webkit [132326] by commit-queue@webkit.org
  • 4 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[EFL][WK2] Make History client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100104

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Created ContextHistoryClientEfl class to encapsulate history client code for EFL.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.cpp:

(Ewk_Context::Ewk_Context):
(ewk_context_history_callbacks_set):

  • UIProcess/API/efl/ewk_context_history_client.cpp: Removed.
  • UIProcess/API/efl/ewk_context_history_client_private.h: Removed.
  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(Ewk_Context):

  • UIProcess/efl/ContextHistoryClientEfl.cpp: Added.

(WebKit):
(WebKit::toContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
(WebKit::ContextHistoryClientEfl::didPerformClientRedirect):
(WebKit::ContextHistoryClientEfl::didPerformServerRedirect):
(WebKit::ContextHistoryClientEfl::didUpdateHistoryTitle):
(WebKit::ContextHistoryClientEfl::populateVisitedLinks):
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::setCallbacks):

  • UIProcess/efl/ContextHistoryClientEfl.h: Added.

(WebKit):
(ContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::create):

12:52 AM Changeset in webkit [132325] by tkent@chromium.org
  • 97 edits
    12 adds
    4 deletes in trunk/LayoutTests

[Chromium] Rebaseline for r132310.

  • platform/chromium/TestExpectations:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
12:48 AM Changeset in webkit [132324] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skipping a test because of r132303. Now ENABLE(SHADOW_DOM) is disabled on Qt.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-24

  • platform/qt/TestExpectations:
12:40 AM Changeset in webkit [132323] by Carlos Garcia Campos
  • 17 edits in trunk/Source/WebKit2

[GTK] Add API to get the WebKitWebView associated to a WebKitDownload to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=99836

Reviewed by Martin Robinson.

Add webkit_download_get_web_view() to get the WebKitWebView that
initiated the download and webkit_web_view_download_uri() to start
a new download associated to a WebKitWebView.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::handleDownloadRequest): Call
webkitWebViewBaseHandleDownloadRequest().

  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl): Add handleDownloadRequest().

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkitDownloadSetWebView): Set the WebKitWebView associated to
the download.
(webkit_download_get_web_view): Public method to get the
WebKitWebView associated to the download.

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/WebKitDownloadPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_download_uri): Use the new helper
webkitWebContextStartDownload().
(webkitWebContextStartDownload): Helper function to start a new
download that is also used by WebKitWebView.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewHandleDownloadRequest): Call
webkitDownloadSetWebView() to associate the download with the
WebKitWebView.
(webkitWebViewConstructed): Set a download request handler.
(webkit_web_view_download_uri): Public method to start a new
download associated to the web view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetDownloadRequestHandler): Set a function
pointer to be called when a new download is request for the web
view.
(webkitWebViewBaseHandleDownloadRequest): Call the download
request handler if any.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(beforeAll):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

12:39 AM Changeset in webkit [132322] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Credentials not re-used for a redirected request to the same domain
https://bugs.webkit.org/show_bug.cgi?id=100193

Reviewed by George Staikos.

We should store the credentials in the redirection response handler, if the request is challenged.
Because the redirect response suggests the authentication succeeds.

Test: http://browsertest01.rim.net/authbasic

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleRedirect):

12:34 AM Changeset in webkit [132321] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Implement CSS reload upon related SASS resource saving
https://bugs.webkit.org/show_bug.cgi?id=98024

Reviewed by Vsevolod Vlasov.

SASS-generated debug info in CSS is parsed to find out which SASS files contributed to this stylesheet.
Upon SASS file save in the Sources panel, all affected external CSS stylesheets are reloaded to update
the page styles (presuming that SASS is running in the "watch" mode during the development cycle).

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._fileSaveFinished.callback):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(_bindUISourceCode):
(_addCSSURLforSASSURL):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

12:33 AM Changeset in webkit [132320] by noel.gordon@gmail.com
  • 8 edits in trunk

Source/WebKit/chromium: [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings
https://bugs.webkit.org/show_bug.cgi?id=100197

Reviewed by Kent Tamura.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setShouldRespectImageOrientation): set the WebCore page
setting for shouldRespectImageOrientation.
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools: [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings
https://bugs.webkit.org/show_bug.cgi?id=100197

Reviewed by Kent Tamura.

fast/images/exif-orientation.html and fast/images/exif-orientation-css.html require a DRT
WebkitShouldRespectImageOrientation preference. Add the chromium implementation for this
preference and plumb it through to page settings.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::overridePreference): Update the tests WebkitShouldRespectImageOrientation
setting in DRT prefs.

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset): Disable the preference before and after each test.
(WebPreferences::applyTo): Apply the preference to the page settings of each test.

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

12:31 AM Changeset in webkit [132319] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip fast/events/tabindex-focus-blur-all.html.
https://bugs.webkit.org/show_bug.cgi?id=100206

Unreviewed, EFL gardening.

The bug webkit.org/b/100065 is fixed and the test is passing now.

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-24

  • platform/efl-wk1/TestExpectations:
12:21 AM Changeset in webkit [132318] by zandobersek@gmail.com
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Marking fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html
as flaky after r132143.
Adding baselines for tvo SVG Transforms tests required after r132121.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.png: Added.
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
  • platform/gtk/svg/transforms/svg-css-transforms-expected.png: Added.
  • platform/gtk/svg/transforms/svg-css-transforms-expected.txt: Added.

Oct 23, 2012:

11:48 PM WebKit Team edited by kihong.kwon@samsung.com
(diff)
11:44 PM Changeset in webkit [132317] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] TestWebKitAPI/TestWebKit2 and TestWebKitAPI/TestGtk link to the installed libs
https://bugs.webkit.org/show_bug.cgi?id=100134

Reviewed by Martin Robinson.

Do not share the LDADD variable among TestWTF, TestWebKit2 and
TestGtk.

  • TestWebKitAPI/GNUmakefile.am:
11:43 PM Changeset in webkit [132316] by zoltan@webkit.org
  • 2 edits in trunk/PerformanceTests

Store the loaded file locally in measurePageLoadTime
https://bugs.webkit.org/show_bug.cgi?id=100172

Reviewed by Csaba Osztrogonác.

Store the loaded file as a local variable instead of attaching it to the test object.
Handle chunkSize inside test.run.

  • resources/runner.js:

(.):

11:35 PM Changeset in webkit [132315] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Memory instrumentation: don't count agent-specific front-ends separately
https://bugs.webkit.org/show_bug.cgi?id=100087

Reviewed by Alexander Pavlov.

Pointers to domain-specific inspector front-end interfaces are reported as
weak pointers instead of members to avoid double-counting.

Test by comparing set of reported instrumented objects with the set of objects
allocated by tcmalloc.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

11:27 PM Changeset in webkit [132314] by Dave Barton
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Some linux MathML tests are timing out - see webkit.org/b/100202.

  • platform/chromium/TestExpectations:
11:23 PM Changeset in webkit [132313] by kihong.kwon@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
11:16 PM Changeset in webkit [132312] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Regression(r132303) Broke debug build when SHADOW_DOM is enabled but STYLE_SCOPED is disabled
https://bugs.webkit.org/show_bug.cgi?id=100203

Unreviewed Build fix.

Fix compilation error in StyleResolver.h when SHADOW_DOM flag is
set and STYLE_SCOPED is not.

No new tests, no behavior change.

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):

10:27 PM Changeset in webkit [132311] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove specialized hash traits for GlyphPages.
<http://webkit.org/b/100185>

Reviewed by Dan Bernstein.

Now that the default minimum table size has been lowered for all tables, there's no need
for this specialization anymore.

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):

10:22 PM Changeset in webkit [132310] by tkent@chromium.org
  • 5 edits in trunk

Multiple fields input UI: Don't use CSS properties for physical direction
https://bugs.webkit.org/show_bug.cgi?id=100195

Reviewed by Kentaro Hara.

Source/WebCore:

CSS declarations such as "padding: 0 0 0 1px;" "margin-left: 0.2em;" are
not direction-neutral, and makes unexpected appearance in RTL. We should
use -webkit-padding-start or -webkit-margin-start.

No new tests. Covered by date-multiple-fields-appearance-l10n.html and
month-multiple-fields-appearance-l10n.html

  • css/html.css:

(input[type="date"]): Use padding:0 and -webkit-padding-start:1px;
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input[type="week"]::-webkit-inner-spin-button):
Use -webkit-margin-start. Also use an integral pixel size instead of
avoid a fractional relative size to avoid subpixel layout rounding.

LayoutTests:

  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
10:13 PM Changeset in webkit [132309] by mitz@apple.com
  • 7 edits in trunk

Source/WebKit/mac: WebKit/mac part of <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(+[WebView initialize]): Added a local variable to hold the standard user defaults. Added
code to register a value of YES for the WebKitKerningAndLigaturesEnabledByDefault user
default. Changed to refer to that default key by name.

Source/WebKit2: WebKit2 part of <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::registerUserDefaultsIfNeeded): Added. Registers a value of YES for the
WebKitKerningAndLigaturesEnabledByDefault user default if it has not been registered yet.
(WebKit::WebContext::platformInitializeWebProcess): Added a call to
registerUserDefaultsIfNeeded, and changed to refer to the defaults key by name.

Tools: Tools changes for <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
https://bugs.webkit.org/show_bug.cgi?id=100188

Reviewed by Sam Weinig.

Disable kerning and ligatures by default when running the tests.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Set a value of NO for the
WebKitKerningAndLigaturesEnabledByDefault user default.

  • WebKitTestRunner/mac/main.mm:

(main): Register a value of NO for the WebKitKerningAndLigaturesEnabledByDefault user
default.

10:12 PM Changeset in webkit [132308] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

The font cache evicts inactive font data too aggressively when not under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=100194

Reviewed by Sam Weinig.

Increasing the number of inactive font data objects the cache may hold increases the hit
rate, leading to improved page load performance. When memory pressure is detected,
MemoryPressureHandler evicts all inactive objects, regardless of the limits we are
increasing here.

  • platform/graphics/FontCache.cpp:

(WebCore): Increased the maximum number of inactive font data objects in the cache from 50
to 225, and the number of objects to evict once the limit is met from 20 to 25.

10:10 PM Changeset in webkit [132307] by kling@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock: Give m_putToBaseOperations an inline capacity.
<http://webkit.org/b/100190>
<rdar://problem/12562466>

Reviewed by Oliver Hunt.

Since the CodeBlock constructor always inserts a single PutToBaseOperation, but there's no
guarantee that more will follow, give the m_putToBaseOperations vector an inline capacity of 1.
There are 4009 of these Vectors on Membuster3, and only 126 of them have more than a single entry.

This change yields a 1.90MB reduction in memory usage.

  • bytecode/CodeBlock.h:

(CodeBlock):

9:56 PM Changeset in webkit [132306] by tkent@chromium.org
  • 68 edits
    10 adds in trunk/LayoutTests

[Chromium] Rebaseline for r132291
https://bugs.webkit.org/show_bug.cgi?id=100088

  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Added.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
9:50 PM Changeset in webkit [132305] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed nightly gardening, skip new failing tests.

  • platform/qt/TestExpectations:
9:45 PM Changeset in webkit [132304] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove duplicate platform/mac entries
https://bugs.webkit.org/show_bug.cgi?id=100167

Reviewed by Dirk Pranke.

We intentionally don't run platform/mac tests in Chromium. Remove lines
that duplicate the directory WontFix.

  • platform/chromium/TestExpectations:
9:37 PM Changeset in webkit [132303] by tasak@google.com
  • 15 edits
    2 adds in trunk

[Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Reviewed by Hajime Morita.

Source/WebCore:

Implemented @host-@rules according to the shadow dom spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#host-at-rule
The design doc is:
https://docs.google.com/document/d/1P2yorchF8lci2sccr-mVSRf2dtvjKeiuyQWzCB2bEA8/edit

Test: fast/dom/shadow/athost-atrules.html

  • css/CSSGrammar.y.in:

Added rules for parsing @host @-rules.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):
Added a new token "@host".
(WebCore::CSSParser::createHostRule):
Added a new method to create an @host @-rule, which is invoked from
(WebCore):

  • css/CSSParser.h:

Added a declaration of the above new method: createHostRule.

  • css/CSSPropertySourceData.h:

Added HOST_RULE to enum Type.

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):
Modified multiple bool arguments into one argument. Now it
uses combinations of values from enum AddRuleFlags.
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addStyleRule):
Updated according to the RuleData's change.
Modified to Invoke increaseSpecificity if the given rule is @host
@-rule.
(WebCore::RuleSet::addRulesFromSheet):
Invoked addHostRule if the given rule is @host @-rule.

  • css/RuleSet.h:

(RuleData):
(WebCore::RuleData::increaseSpecificity):
Added a new method to increase selector's specificity. This method is
used to make @host @-rules' specificity larger than normal author
rules' specificity.
(RuleSet):

  • css/StyleResolver.cpp:

(WebCore::makeRuleSet):
(WebCore::StyleResolver::addHostRule):
A wrapper method to invoke StyleScopeResolver::addHostRule. The method
is used to make only StyleResolver know an implementation detail about
class StyleScopeResolver.
(WebCore::StyleResolver::appendAuthorStylesheets):
Updated according to the RuleData's change.
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
A new method to find matched host rules when an element is given.
This method invokes
StyleScopeResolver::styleSharingCandidateMatchesHostRules to find
matched host rules.
(WebCore):
(WebCore::StyleResolver::matchHostRules):
A new method to find matched host rules when an element is given.
This method invokes StyleScopeResolver::matchHostRules to find
matched host rules.
(WebCore::StyleResolver::matchScopedAuthorRules):
Modified to invoke matchHostRules.
(WebCore::StyleResolver::locateSharedStyle):
Disable sibling style cache if the given element is a shadow host and
any @host @-rules are applied to the element.

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):
If no scopeResolver is created, create and return the instance.
If created, just return the instance.
(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleHost::StyleRuleHost):
Implemented class StyleRuleHost. The class is almost the same as
StyleRuleBlock except type.
(WebCore):

  • css/StyleRule.h:

(WebCore::StyleRuleBase::isHostRule):
(StyleRuleHost):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::copy):
(WebCore):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::ensureAtHostRuleSetFor):
A new method to create a new RuleSet for the given shadow root.
(WebCore):
(WebCore::StyleScopeResolver::atHostRuleSetFor):
A new private inline method to obtain @host @-rules declared in
the given shadow root.
(WebCore::StyleScopeResolver::addHostRule):
Added a new method to register @host @-rules with shadow roots.
(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
A new method to find whether any @host @-rules are applied to
the given host element.
(WebCore::StyleScopeResolver::matchHostRules):
A new method to find matched rules for the given host element.
(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleScopeResolver.h:

(WebCore):
(StyleScopeResolver):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

  • fast/dom/shadow/athost-atrules-expected.txt: Added.
  • fast/dom/shadow/athost-atrules.html: Added.
9:33 PM Changeset in webkit [132302] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r130643): ASSERTION FAILED: result.iterator != end() below PluginDatabase::add
<http://webkit.org/b/100065>

Reviewed by Anders Carlsson.

Restore the pre-r130643 hash table size for PluginDatabase to prevent these easily reproducible
collisions. This will need a proper fix at some point.

  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:

(PluginPackageHashTraits):

9:31 PM Changeset in webkit [132301] by Csaba Osztrogonác
  • 24 edits
    2 adds in trunk

Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=100159

Patch by Simon Fraser <Simon Fraser> on 2012-10-23
Reviewed by Tim Horton.

Source/WebCore:

Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.

Test: platform/mac/tiled-drawing/use-tiled-drawing.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileCoverageRect):
(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
whose path includes "tiled-drawing". It does this by passing around a WKDictionary
of options, and if the current PlatformWebView doesn't support those options, it will
create a new one.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView): Add a WKDictionaryRef options dictionary argument.
(WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
supports the options in the WKDictionaryRef.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Call createWebViewWithOptions() with
no options in the normal case.
(WTR::TestController::createWebViewWithOptions): Moved code into this fuction
so we can call it in two places.
(WTR::TestController::ensureViewSupportsOptions): If the current view
doesn't support the given options, throw it away and makea new one that does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
(WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
the view supports the given options. No-op for non-Mac platforms.
(WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
a custom value from this method.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

LayoutTests:

A new test that dumps tile cache data for a large page.

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
9:21 PM Changeset in webkit [132300] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

[Texmap][EFL] Add AcceleratedCompositingContextEfl to the build system.
https://bugs.webkit.org/show_bug.cgi?id=88630

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-10-23
Reviewed by Gyuyoung Kim.

Source/WebKit:

  • PlatformEfl.cmake: Add the AcceleratedCompositingContextEfl.cpp file

and INCLUDE paths for TEXTURE_MAPPER_GL.

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Modify the #include file.
9:15 PM Changeset in webkit [132299] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Flush pending GraphicsLayer changes when reattaching compositing layers if necessary
https://bugs.webkit.org/show_bug.cgi?id=100187
<rdar://problem/12546770>

Reviewed by Dan Bernstein.

Fix a regression from r131940. That revision changed RenderLayerCompositor::flushPendingLayerChanges()
to bail if the root layer is unattached, which indicates that we're in the page cache, or in a
background tab. However, that dropped the layer flush on the floor, so that any subsequent changes
to GraphicsLayerCAs would just pile up and never get flushed. This was most evident on pages
that require frequent flushing, such as those running animated GIFs.

Fix by setting a flag in flushPendingLayerChanges() if we're unattached. Consult the flag
when re-attaching the root layer, and if it's set, flush the GraphicsLayers.

Not testable because we can't test detaching and re-adding web views in DRT/WTR.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor): Initialize m_shouldFlushOnReattach to false.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): If the root layer attachment
is RootLayerUnattached, set the m_shouldFlushOnReattach flag before returning.
(WebCore::RenderLayerCompositor::attachRootLayer): If m_shouldFlushOnReattach, flush the layers,
saying that we're the flush root.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor): Add m_shouldFlushOnReattach flag.

9:12 PM Changeset in webkit [132298] by Csaba Osztrogonác
  • 24 edits
    2 deletes in trunk

Unreviewed, rolling out r132276.
http://trac.webkit.org/changeset/132276
https://bugs.webkit.org/show_bug.cgi?id=100189

It broke the Qt-WK2 build intentionally (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-23

Source/WebCore:

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Removed.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Removed.
9:09 PM Changeset in webkit [132297] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

exif-orientation tests should use dumpAsText(true)
https://bugs.webkit.org/show_bug.cgi?id=100076

Reviewed by Eric Seidel.

  • fast/images/exif-orientation-css.html: Use dumpAsText(true).
  • fast/images/exif-orientation.html: ditto.
9:01 PM Changeset in webkit [132296] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Unreviewed build fix, some function names changed between review and landing.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
(CoreIPC::::encode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

8:21 PM Changeset in webkit [132295] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Add extra check for data() in PageSerializer.
https://bugs.webkit.org/show_bug.cgi?id=99102

Reviewed by Eric Seidel.

The image returned from imageForRenderer() does not contain the raw SVG data
so this patch adds a check for image->image()->data() before writing SVG
in PageSerializer::addImageToResources.

Covered by existing test WebPageNewSerializeTest.SVGImageDontCrash.

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::addImageToResources):

7:53 PM Changeset in webkit [132294] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want
https://bugs.webkit.org/show_bug.cgi?id=100180

Reviewed by Anders Carlsson.

NSHomeDirectory() doesn't return the real home directory if the host process
is App Sandboxed, so drop down and use getpwuid_r instead.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::appendReadwriteSandboxDirectory):
There is no reason anymore to try to create the directory.

(WebKit::WebProcess::initializeSandbox):
Switch to getpwuid_r.

7:49 PM Changeset in webkit [132293] by commit-queue@webkit.org
  • 1 edit
    26 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=100125

Added pixel baselines for editing/pasteboard.

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-10-23

  • platform/efl/editing/pasteboard: 26 new pixel baselines.
7:16 PM Changeset in webkit [132292] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
https://bugs.webkit.org/show_bug.cgi?id=100129

Reviewed by Kentaro Hara.

We're going to use appendAsLDMLLiteral in other code, and it is
related to DateTimeFormat class. So we move it to DateTimeFormat
class as quoteAndAppendLiteral.

No new tests because of no behavior change.

  • platform/text/DateTimeFormat.cpp:

(WebCore::DateTimeFormat::quoteAndAppendLiteral):
Moved from LocaleWin.cpp

  • platform/text/DateTimeFormat.h:

Declare StringBuilder by wtf/Forward.h. It also declares String.
(DateTimeFormat): Declare quoteAndAppendLiteral.

  • platform/text/LocaleWin.cpp:

(WebCore): Move appendLDMLLiteral to DateTimeFormat.
(WebCore::convertWindowsDateFormatToLDML):
Follow the moving.

7:12 PM Changeset in webkit [132291] by tkent@chromium.org
  • 10 edits in trunk

REGRESSION(r131421): Text baseline is not aligned in some locales
https://bugs.webkit.org/show_bug.cgi?id=100088

Reviewed by Hajime Morita.

Source/WebCore:

Before this patch, the element with ::-webkit-datetime-edit had
-webkit-align-items:center. It was incorrect at all because it
ignores baselines of each of inner fields. We need to change it to
-webkit-align-items:baseline, or stop using -webkit-flex.

However -webkit-align-items:baseline doesn't work because a spin
button element in the element doesn't have the baseline. If we
specified -webkit-align-items:baseline, the spin button would
shift up.

So, we change the element structure for multiple fields input
elements. Before this patch, the structure was:

input

|

  • ::-webkit-date-and-time-container (flex cotainer) |
::-webkit-datetime-edit (has flexibility in date-and-time-container, also this is a flex container)
|::-webkit-datetime-edit-foo

| | :
| |

|::-webkit-date-time-edit-gap (has flexibility in datetime-edit)

| - ::-webkit-inne-spin-button

  • ::-webkit-calendar-picker-indicator

After the patch, the structure will be:

input

|

  • ::-webkit-date-and-time-container (flexible box) |
::-webkit-datetime-edit (has flexibility in date-and-time-container)
|::-webkit-datetime-edit-foo

| | :
| |
|

::-webkit-inne-spin-button

  • ::-webkit-calendar-picker-indicator

Because the spin button owner is date-and-time-container, we don't
need to make the datetime-edit element a flex container.

Also, we had rounding error by subpixel layout. To avoid it, we
stop using fractional paddings.

In order to implement this, we need to change the SpinButtonOwner
interface provider from DateTimeEditElement to
BaseMultipleFieldsDateAndTimeInputType.

No new tests. Covered by month-multiple-fields-appearance-l10n.html.

  • css/html.css:

(input::-webkit-datetime-edit): Stop making this a flex
container. Inner fields in this use the single baseline.
(input::-webkit-datetime-edit-ampm-field):
Don't use fractional paddings to avoid rounding erros of subpixel
layout. Use integral margin instead to avoid overwrap of focus
ring and background-color of the field.
(input::-webkit-datetime-edit-day-field): Ditto.
(input::-webkit-datetime-edit-hour-field): Ditto.
(input::-webkit-datetime-edit-millisecond-field): Ditto.
(input::-webkit-datetime-edit-minute-field): Ditto.
(input::-webkit-datetime-edit-month-field): Ditto.
(input::-webkit-datetime-edit-second-field): Ditto.
(input::-webkit-datetime-edit-week-field): Ditto.
(input::-webkit-datetime-edit-year-field): Ditto.
(input::-webkit-date-and-time-container): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Overrides
SpinButtonOwner functions, and add m_spinButtonElement.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner):
Just delegate to DateTimeEditElement::focusIfNoFocus.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToMouseEvents):
Moved from DateTimeEditElement::shouldSpinButtonRespondToMouseEvents.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToWheelEvents):
Moved from DateTimeEditElement::shouldSpinButtonRespondToWheelEvents.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::spinButtonStepDown):
Delegate to DateTimeEditElement::stepDown.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp):
Delegate to DateTimeEditElement::stepUp.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
Initialize m_spinButtonElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
Reset SpinButtonOwner for m_spinButtonElement like the old code of ~DateTimeEditElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Put a SpinButtonElement between the DateTimeEditElement and the PickerIndicatorElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent):
Take care of SpinButtonElement.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged):
Release capture of SpinButtonElement. This corresponds to the old
code of DateTimeEditElement::updateUIState.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): Ditto.

  • html/TextFieldInputType.h:

Make SpinButtonElement::SpinButtonOwner protected to allow overriding.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Remove SpniButtonOwner implementation,
m_spinButton, and rename some functions.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):
Remove m_spinButton.
(WebCore::DateTimeEditElement::~DateTimeEditElement): Ditto.
(WebCore::DateTimeEditElement::focusIfNoFocus):
Renamed from focusAndSelectSpinButtonOwner. This is called
BaseMultipleFieldsDateAndTimeInputType::focusAndSelectSpinButtonOwner.
(WebCore::DateTimeEditElement::layout):
Remove creation code for -webkit-datetime-edit-gap and SpinButtonElement.
(WebCore::DateTimeEditElement::defaultEventHandler):
Move the code for m_spinButton to
BaseMultipleFieldsDateAndTimeInputType::forwardEvent.
(WebCore::DateTimeEditElement::hasFocusedField): A helper for
BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToWheelEvents.
(WebCore::DateTimeEditElement::stepDown): A helper for
BaseMultipleFieldsDateAndTimeInputType::spinButtonStepDown.
(WebCore::DateTimeEditElement::stepUp): A helper for
BaseMultipleFieldsDateAndTimeInputType::spinButtonStepUp.
(WebCore::DateTimeEditElement::updateUIState): Move the code to
BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged
and readonlyAttributeChanged.

LayoutTests:

Add a pixel image which has notable changes.
Input elements in other tests have slightly small height and
slightly narrow width.

  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png:
  • platform/chromium/TestExpectations:
6:57 PM Changeset in webkit [132290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web page renders at the wrong zoom level after viewport changes
https://bugs.webkit.org/show_bug.cgi?id=100096

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-10-23
Reviewed by Rob Buis.

Notify the client of the zoom level change before resuming screen updates.
Otherwise, the user interface thread may blit the content at the wrong
zoom level in some cases. This can also prevent potential flickering.

Reviewed internally by Arvid Nilsson.

PR #225741

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):

6:48 PM Changeset in webkit [132289] by mrobinson@webkit.org
  • 4 edits
    1 add
    1 delete in trunk

POTFILES.in/.skip need updates for translators
https://bugs.webkit.org/show_bug.cgi?id=67580

Reviewed by Xan Lopez.

.:

Now process POTFILES.in during configuration.

  • configure.ac:

Source/WebKit/gtk/po:

Move POTFILES to POTFILES.in to satisfy intltools-update and also update
the list of files with translations. Since the way the path is calculated
is different now, we also need to change the gettext invocation in
GNUmakefile.am.

  • GNUmakefile.am:
  • POTFILES: Removed.
  • POTFILES.in: Added.
6:13 PM Changeset in webkit [132288] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink immutable ElementAttributeData and StylePropertySet by one pointer each.
<http://webkit.org/b/100123>

Reviewed by Anders Carlsson.

Remove one pointer of unintentional padding in the immutable versions of these objects.
583kB progression on Membuster3.

  • css/StylePropertySet.cpp:

(WebCore::immutableStylePropertySetSize):

  • dom/ElementAttributeData.cpp:

(WebCore::immutableElementAttributeDataSize):

6:10 PM Changeset in webkit [132287] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::SubresourceLoader::willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=100147

Reviewed by Abhishek Arya.

No new tests. There is a test case that should cover this, but it doesn't
work correctly on many platforms due to its use of testRunner.addURLToRedirect().
See http/tests/loading/cross-origin-XHR-willLoadRequest.html.
Tested manually on http://www.nick.co.uk/shows/spongebob

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

6:08 PM Changeset in webkit [132286] by mrobinson@webkit.org
  • 20 edits
    2 adds
    2 deletes in trunk

[GTK][Soup] Implement the default authentication dialog via WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=99351

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Instead of connecting to the SoupSession::authenticate signal in the API layer
via a SoupSessionFeature, route the message through the typical WebCore authentication
mechanism. This is a step on the path to having full-blown support for authentication
in the API allowing for custom authentication dialogs and behavior in clients.

No new tests. This should not change behavior.

  • GNUmakefile.list.am: Add the new implementation file for the AuthenticationChallenge.
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge): Include GTK+ here as well.

  • platform/gtk/GtkAuthenticationDialog.cpp: Instead of carrying a raw pointer to a SoupAuth

carry a GRefPtr which will allow the dialog to be used even after the AuthenticationChallenge
is destroyed.

  • platform/gtk/GtkAuthenticationDialog.h: ditto.
  • platform/network/ResourceHandle.h: Add a didReceiveAuthenticationChallenge method.
  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal): Remove the getter for the initiating page ID.

  • platform/network/soup/AuthenticationChallenge.h: Added an implementation of AuthenticationChallenge

that takes a bit of data from the handle including SoupMessage, SoupAuth, and SoupSession.

  • platform/network/soup/AuthenticationChallengeSoup.cpp: Added. Ditto.
  • platform/network/soup/ResourceError.h:

(ResourceError): Added a factory for authentication errors.

  • platform/network/soup/ResourceErrorSoup.cpp: Ditto.
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::setSoupRequestInitiaingPageID): Just get the page directly from the NetworkingContext.
(WebCore::createSoupMessageForHandleAndRequest): Always set the "handle" data on the message.
It's always used now.
(WebCore::ResourceHandle::start): Get the initiating page ID directly from the NetworkingContext.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added this method which routes
the authentication challenge to the client.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Added a stub for this method.
(WebCore::ResourceHandle::loadResourceSynchronously): Don't pass the session to the loader.
(WebCore::authenicateCallback): Added.
(WebCore::ResourceHandle::defaultSession): Connect the authenticate callback.

Source/WebKit/gtk:

Instead of using a custom SoupSessionFeature to show the authentication dialog,
show it using the corresponding WebCore message.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Show the dialog when we need to authenticate. Also, so not show the dialog
if we are in DRT mode.

  • webkit/webkitglobals.cpp:

(webkitInit): No longer install our SoupFeature.

Source/WebKit2:

Instead of using a custom SoupSessionFeature to show the authentication
dialog, show it using the corresponding WebCore message.

  • GNUmakefile.list.am: Removed the SoupSessionFeature files.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit): Only use the default dispatchDidReceiveAuthenticationChallenge
for non-GTK+ ports.

  • WebProcess/WebCoreSupport/gtk/WebFrameLoaderClientGtk.cpp: Added.

(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): Added
a GTK+-specific implementation that shows the GtkAuthenticationDialog.

  • WebProcess/gtk/WebAuthDialog.cpp: Removed.
  • WebProcess/gtk/WebAuthDialog.h: Removed.
  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Don't install the custom session feature.

Tools:

We no longer need to turn off the soup authentication dialog soup feature,
because it's not installed.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(setDefaultsToConsistentStateValuesForTesting): Don't turn off the feature any longer.

5:58 PM Changeset in webkit [132285] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Simplify GCEpilogueVisitor along the same lines as GCPrologueVisitor
https://bugs.webkit.org/show_bug.cgi?id=100157

Reviewed by Eric Seidel.

This patch removes the traits template parameter from GCEpilogueVisitor
and makes it mirror GCPrologueVisitor again.

  • bindings/v8/V8GCController.cpp:

(WebCore):
(ActiveDOMObjectEpilogueVisitor):
(WebCore::ActiveDOMObjectEpilogueVisitor::ActiveDOMObjectEpilogueVisitor):
(WebCore::ActiveDOMObjectEpilogueVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCEpilogue):

5:51 PM Changeset in webkit [132284] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove deprecatedSend
https://bugs.webkit.org/show_bug.cgi?id=100127

Reviewed by Andreas Kling.

deprecatedSend is no longer used anywhere, remove it.

  • Platform/CoreIPC/Connection.h:

(Connection):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

5:26 PM Changeset in webkit [132283] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520

Patch by Varun Jain <varunjain@chromium.org> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.

Test: fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):

  • page/EventHandler.h:

(EventHandler):

Source/WebKit/chromium:

Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

LayoutTests:

Send a synthetic mouse down event for context menu-summoning-gesture events so that
textareas can correctly set cursors before receiving the context menu event.

  • fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position.html: Added.
  • platform/chromium/fast/events/touch/gesture/right-click-gestures-set-cursor-at-correct-position-expected.txt: Added.
4:44 PM Changeset in webkit [132282] by aestes@apple.com
  • 12 edits in trunk/Source

[WebKit2 API] Add properties to get textRects from a WKDOMRange or WKDOMNode
https://bugs.webkit.org/show_bug.cgi?id=100162

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in: Exported symbols needed by WebKit2.
  • bindings/objc/DOM.mm:

(-[DOMNode textRects]): Moved some logic into Node::textRects()
(everything but the call to updateLayoutIgnorePendingStylesheets()).

  • dom/Node.cpp:

(WebCore::Node::textRects):

  • dom/Node.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::toNSArray): Added a helper function to convert a Vector of IntRects to an NSArray.

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode textRects]):

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange textRects]):

4:41 PM Changeset in webkit [132281] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused function from DOM wrapper visitor
https://bugs.webkit.org/show_bug.cgi?id=100163

Reviewed by Eric Seidel.

No one overrides these virtual functions. They were added in
http://trac.webkit.org/changeset/73491, but we don't use them in the GC
controller anymore.

  • bindings/v8/V8DOMMap.h:

(WebCore::WeakReferenceMap::visit):

4:15 PM Changeset in webkit [132280] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Clear m_mediaSource reference when the MediaSource is closed
https://bugs.webkit.org/show_bug.cgi?id=100047

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-10-23
Reviewed by Eric Carlson.

The m_mediaSource object shouldn't be accessed after the object
transitions to closed so this change simply clears the reference
when that transition happens.

No new tests because the change isn't visible to JavaScript.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Removed a closed transition that is actually dead code.
(WebCore::HTMLMediaElement::setSourceState): Clear the m_mediaSource reference on closed transition.

4:10 PM Changeset in webkit [132279] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=99649

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-10-23
Reviewed by George Staikos.

Random latency before scroll starts on sites like http://pintrest.com
Internal PR225398

The chief problem here is the all the hit testing that we do for
touch events and simulated mouse events. If the render tree is dirty
hit tests can take a long time in Document::recalcStyle(). Masking
the flags that force style recalculations will make them fast, at the
expense that they might be happening on stale data.

Since we are only using these hit tests to look for event handlers -
we're not actually modifying anything, it is better to skip the
Document::recalcStyle() and save ourselves tons of time.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::resumeDocumentStyleRecalc):
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
(BlackBerry::WebKit::WebPagePrivate::clearCachedHitTestResult):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):

  • WebKitSupport/FatFingers.h:
  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

3:55 PM Rebaseline edited by dpranke@chromium.org
update to new TestExpectations syntax (diff)
3:46 PM Changeset in webkit [132278] by leviw@chromium.org
  • 1 edit
    47 adds in trunk/LayoutTests

The rest of the baselines have landed! Should green the Mac bots for MathML after r132264.

  • platform/chromium-mac-lion/mathml: Added.
  • platform/chromium-mac-lion/mathml/presentation: Added.
  • platform/chromium-mac-lion/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac-lion/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac-lion/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac-lion/mathml/xHeight-expected.png: Added.
  • platform/chromium-mac/mathml: Added.
  • platform/chromium-mac/mathml/presentation: Added.
  • platform/chromium-mac/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac/mathml/xHeight-expected.png: Added.
3:36 PM Changeset in webkit [132277] by leviw@chromium.org
  • 1 edit
    44 adds in trunk/LayoutTests

Unreviewed gardening. Updating expectations after r132264.

  • platform/chromium-mac-snowleopard/mathml: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/attributes-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/attributes-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/over-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/over-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/style-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tokenElements-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/under-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/under-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/underover-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/presentation/underover-expected.txt: Added.
  • platform/chromium-mac-snowleopard/mathml/xHeight-expected.png: Added.
  • platform/chromium-mac-snowleopard/mathml/xHeight-expected.txt: Added.
3:22 PM Changeset in webkit [132276] by Simon Fraser
  • 24 edits
    3 adds in trunk

Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=100159

Reviewed by Tim Horton.

Source/WebCore:

Add a LAYER_TREE_INCLUDES_PAGE_TILE_CACHE flag for layerTreeAsText(), and plumb it
through to GraphicsLayerCA, which dumps the TiledBacking tile coverage rect.

Test: platform/mac/tiled-drawing/use-tiled-drawing.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::tileCoverageRect):
(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::revalidateTiles):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
whose path includes "tiled-drawing". It does this by passing around a WKDictionary
of options, and if the current PlatformWebView doesn't support those options, it will
create a new one.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView): Add a WKDictionaryRef options dictionary argument.
(WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
supports the options in the WKDictionaryRef.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Call createWebViewWithOptions() with
no options in the normal case.
(WTR::TestController::createWebViewWithOptions): Moved code into this fuction
so we can call it in two places.
(WTR::TestController::ensureViewSupportsOptions): If the current view
doesn't support the given options, throw it away and makea new one that does.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
(WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
the view supports the given options. No-op for non-Mac platforms.
(WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
a custom value from this method.
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::PlatformWebView): New constructor parameter.

LayoutTests:

A new test that dumps tile cache data for a large page.

  • platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
  • platform/mac/tiled-drawing/use-tiled-drawing.html: Added.
3:19 PM Changeset in webkit [132275] by noam.rosenthal@nokia.com
  • 20 edits in trunk/Source

Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add enablers to TextureMapper and GraphicsLayerAnimation so that they could be used
across processes with IPC. Added some public accessors to GraphicsLayerAnimation,
and allowed a GraphicsLayerTextureMapper to receive a full list of animations.

Covered by existing animation and compositing tests.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::GraphicsLayerAnimation):

Initialize the animation with the startTime instead of the offset.

(WebCore::GraphicsLayerAnimations::getActiveAnimations):

  • platform/graphics/GraphicsLayerAnimation.h:

(WebCore::GraphicsLayerAnimation::setState):

Allow setting the pause time as well.

(WebCore::GraphicsLayerAnimation::boxSize):
(WebCore::GraphicsLayerAnimation::startTime):
(WebCore::GraphicsLayerAnimation::pauseTime):
(WebCore::GraphicsLayerAnimation::animation):
(WebCore::GraphicsLayerAnimation::keyframes):
(WebCore::GraphicsLayerAnimation::listsMatch):
(WebCore::GraphicsLayerAnimations::size):
(WebCore::GraphicsLayerAnimations::animations):

Add public accessors to GraphicsLayerAnimation properties.

(GraphicsLayerAnimation):
(GraphicsLayerAnimations):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):

Allow replacing the entire list of animations.

(WebCore):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::applyAnimationsRecursively):
(WebCore):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

Source/WebKit2:

Re-enable UI-process animations for Coordinated-Graphics/TextureMapper.

  • Added an argument coder for GraphicsLayerAnimations.
  • Allow LayerTreeCoordinator to manage the animations per layer with the proxy, as opposed to applying the animation values in the web process as before.
  • LayerTreeRenderer now calls updateViewport() after painting when an animation is active.

To overcome the problem we've had in the past with synchronizing UI-side and web-side
animations, we now lock the animations in the UI process when a frame starts rendering,
and unlock it when the frame finishes rendering, or if after the layout there is no visible
changes pending on the screen.

  • Scripts/webkit2/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC):
(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

Added argument coders for GraphicsLayerAnimations.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setLayerAnimations):
(WebKit::LayerTreeCoordinatorProxy::setAnimationsLocked):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:

Added an option to sync the layer's animations, and also to lock/unlock animations.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):

Sync animations if they're not locked, and call updateViewport() if we have animations.

(WebKit::LayerTreeRenderer::flushLayerChanges):
(WebKit::LayerTreeRenderer::setLayerAnimations):
(WebKit::LayerTreeRenderer::setAnimationsLocked):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didChangeAnimations):
(WebCore::CoordinatedGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::removeAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
(WebCore):

Pass the animation info to the UI process instead of applying it in the web process.

(WebCore::CoordinatedGraphicsLayer::hasPendingVisibleChanges):

Compute whether a layer tree might have sync issues or flickers if rendered while
background animations are ongoing.

(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):

Don't allow progressive tiling for layers with animations.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(WebCore):
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::lockAnimations):
(WebKit):
(WebKit::LayerTreeCoordinator::unlockAnimations):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::setLayerAnimations):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

3:11 PM Changeset in webkit [132274] by crogers@google.com
  • 7 edits
    2 moves in trunk

Change setTargetValueAtTime() to setTargetAtTime()
https://bugs.webkit.org/show_bug.cgi?id=100153

Reviewed by Adam Barth.

Source/WebCore:

The AudioParam method name has changed due to Web Audio API spec review.
Keep legacy support for the old name.

Test: webaudio/audioparam-setTargetAtTime.html

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::setTargetAtTime):

  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::setTargetAtTime):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • Modules/webaudio/AudioParamTimeline.h:

(AudioParamTimeline):

LayoutTests:

  • webaudio/audioparam-setTargetAtTime-expected.txt: Renamed from LayoutTests/webaudio/audioparam-setTargetValueAtTime-expected.txt.
  • webaudio/audioparam-setTargetAtTime.html: Renamed from LayoutTests/webaudio/audioparam-setTargetValueAtTime.html.
  • webaudio/resources/audioparam-testing.js:
3:03 PM Changeset in webkit [132273] by zoltan@webkit.org
  • 3 edits in trunk/PerformanceTests

Add measurePageLoadTime function to PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=100029

Reviewed by Ryosuke Niwa.

Adopt chunk based loading logic from html5-full-render.html into measurePageLoadTime function,
this is needed to measure the performance and the memory consumption of the PageLoadTests as
we do it for all other performancetests.

  • Parser/html5-full-render.html: Move the behavior to runner.js.
  • resources/runner.js:

(.): Add measurePageLoadTime function.

3:02 PM Changeset in webkit [132272] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

[Mac] Remove extraneous conversion to String->NSString
https://bugs.webkit.org/show_bug.cgi?id=100044

Reviewed by Darin Adler.

Improve some unfortunate use of String->NSString.

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification): The variable macNotification is ultimately
needed as NSString, and all its value are or can be NSString.
Convert the last 3 char* values to NSString literal and use NSString* all the way.

  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):
We converted the String to NSString to pass to suggestedFilenameWithMIMEType. There is no need
for the string to be a NSSTring there, we can leave it in its original type.

The case checking for a nil MIMEType was dead code because the implicit conversion never returns nil.

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):
Use String's nsStringNilIfEmpty().

  • platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Fix the coding style. Do the conversion to NSString only when needed.

2:49 PM Changeset in webkit [132271] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Popup menus positioning needs to take multiple monitors into account.
https://bugs.webkit.org/show_bug.cgi?id=100158

Reviewed by Timothy Horton.

Add screen.x() to repositioning check to account for position of current monitor.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):

2:45 PM Changeset in webkit [132270] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS Shaders is loaded.
https://bugs.webkit.org/show_bug.cgi?id=99908

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

CSS Shaders can not render anything until the program is loaded. If there is
partial loaded shaders program, whole FilterOperations chain can not render
anything. It occurs a flash. So We have to wait until the program is loaded, to
prevent a flash as RenderLayerBacking::updateImageContents() waits until an
image is fully loaded.

No new tests, CSS Shaders on Accelerated Compositing are not activated yet.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

2:40 PM Changeset in webkit [132269] by commit-queue@webkit.org
  • 9 edits
    6 adds
    20 deletes in trunk

Generated should not be supported for things with a shadow
https://bugs.webkit.org/show_bug.cgi?id=98836

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-10-23
Reviewed by Dimitri Glazkov.

Source/WebCore:

As far as CSS is concerned inputs and things with shadow content inside
shouldn't support pseudo elements like :before, :after or :first-letter.
Neither Gecko or Presto supports it, and we only accidentally supported
it.

Until the spec tells us what to do we should disable support. This is
also neccesary because the new generated content implementation doesn't
support shadows.

Test: fast/forms/pseudo-elements.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderListBox.h: Added missing canHaveGeneratedChildren() that returns false.
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Change all pseudos on <input> tests to be ref tests and clean up the tests.
They now make sure we don't support generated content on things with a shadow.
Also added another test for the other form control types to ensure they don't
support pseudos either.

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/pseudo-elements-expected.html: Added.
  • fast/forms/pseudo-elements.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
2:34 PM Changeset in webkit [132268] by commit-queue@webkit.org
  • 5 edits in trunk

[CSS Shaders] Implement overlay, color-dodge, color-burn, hard-light, soft-light blend modes.
https://bugs.webkit.org/show_bug.cgi?id=98504

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted
directly from the CSS Compositing and Blending spec [1]. WebKit adds these
blending expressions to the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Update the test for the aforementioned blend modes.

  • css3/filters/custom/custom-filter-blend-modes-expected.html:
  • css3/filters/custom/custom-filter-blend-modes.html:
2:31 PM Changeset in webkit [132267] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[CSS Shaders] Implement all composite operators except destination and lighter.
https://bugs.webkit.org/show_bug.cgi?id=97859

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-23
Reviewed by Dean Jackson.

Source/WebCore:

Add expressions for all composite operators except destination and
lighter. The expressions are lifted directly from the CSS Compositing
and Blending spec [1]. WebKit adds these compositing expressions to the
author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#advancedcompositing

Test: css3/filters/custom/custom-filter-composite-operators.html

  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::initializeParameterLocations):

Remove ASSERTION checking if glGetUniformLocation returns negative,
because ASSERTION can fail with clear and copy composite operations.
Clear and copy composite operations do not need "css_u_texture"
representing the DOM element texture. If the driver compiler is
smart, "css_u_texture" is not regarded as an active uniform, so
glGetuniformLocation returns -1. glGetAttribLocation ditto.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::compiledProgram):

Move the above ASSERTION in CustomFilterCompiledProgram to here.
ASSERTION checks if m_samplerLocation is not -1 when the author
shader needs an input texture.

(WebCore::CustomFilterValidatedProgram::needsInputTexture):
(WebCore):
(WebCore::CustomFilterValidatedProgram::compositeFunctionString):

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(CustomFilterValidatedProgram):

LayoutTests:

Add test to check that the DOM element texture composites correctly with the css_MixColor
variable from the author's shader for each composite operator.

  • css3/filters/custom/custom-filter-composite-operators-expected.png: Added.
  • css3/filters/custom/custom-filter-composite-operators-expected.txt: Added.
  • css3/filters/custom/custom-filter-composite-operators.html: Added.
2:24 PM Changeset in webkit [132266] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[CSS Shaders] Changing the blend mode in CSS doesn't update the custom filter rendering
https://bugs.webkit.org/show_bug.cgi?id=99887

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-23
Reviewed by Dirk Schulze.

Source/WebCore:

Before this patch, WebKit would not recompute an element's style when just its custom filter
blend mode changed.

For example, suppose an element initially has the style:
-webkit-filter: custom(none mix(url(shader.fs) multiply source-atop));

Then, we change the blend mode from "multiply" to "normal":
-webkit-filter: custom(none mix(url(shader.fs) normal source-atop));

WebKit now detects this change and recomputes the style.

CustomFilterProgram now has an equals operator that considers the program type and the mix
settings. The mix settings contain the blend mode.

Test: css3/filters/custom/custom-filter-change-blend-mode.html

  • platform/graphics/filters/CustomFilterProgram.cpp:

(WebCore::CustomFilterProgram::operator==):

Previously, the equals operator was pure virtual in CustomFilterProgram. Now,
CustomFilterProgram implements it and compares the program type and mix settings, if
appropriate.

(WebCore):

  • platform/graphics/filters/CustomFilterProgram.h:
  • platform/graphics/filters/CustomFilterProgramInfo.cpp:

(WebCore::CustomFilterProgramInfo::hash):

Refactor a repeated condition into a boolean to improve readability.

(WebCore::CustomFilterProgramInfo::operator==):

Refactor repeated conditions to improve readability. Reorder the conditions so the less
expensive ones occur first.

  • rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::operator==):

Call the base class's equals operator.

LayoutTests:

Add a test that resolves a custom filter's style with the "multiply" blend mode and then
changes the blend mode to "normal". The test makes sure not to change any other parameters
besides the blend mode, since the other parameters can trigger style recalculations on their
own.

  • css3/filters/custom/custom-filter-change-blend-mode-expected.html: Added.
  • css3/filters/custom/custom-filter-change-blend-mode.html: Added.
2:21 PM Changeset in webkit [132265] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGL] conformance/textures/texture-size.html is failing on Apple Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=94041

Reviewed by Dean Jackson.

When binding a texture to GL_TEXTURE_2D when GL_ACTIVE_TEXTURE is 0, we set m_boundTexture0 to the texture unit.
However when we delete the texture, we need to be setting m_boundTexture0 to 0.
Otherwise when we draw to the screen we bind m_boundTexture0 in the prepareTexture() method and since the associated texture
has already been deleted we end up in an error state.

Tested using Khronos WebGL conformance suite:
conformance/textures/texture-size.html

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::deleteTexture):

2:14 PM Changeset in webkit [132264] by Dave Barton
  • 55 edits in trunk

[MathML] Symbol font uses greek letters for roman ones on linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=99921

Reviewed by Eric Seidel.

Source/WebCore:

For parts of stretched parentheses and brackets, mathml.css currently uses the Symbol font,
which on linux and Windows has greek letters at roman code points. To fix this, we switch
to the STIXSizeOneSym font when available. However, this can cause vertical gaps between
glyph parts, because of hard-coded constants in RenderMathMLOperator.cpp. We eliminate all
these constants. We also shift glyphs upward by 1px and truncate them to avoid the gaps.

Tested by existing tests, and one test added to LayoutTests/mathml/presentation/mo.xhtml.

  • css/mathml.css:

(math, mfenced > *):

  • Set font-family for mn, mi, etc.

(mo, mfenced):

  • Set font-family for mo and anonymous operators, including extension glyphs for stretched operators like parentheses and brackets.

(math):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore):

  • Change 0x23d0 to 0x23aa for STIX & Cambria Math fonts.

(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createStackableStyle):

  • Eliminate unused lineHeight and topRelative parameters, and the hard-coded font size of 14.

(WebCore::RenderMathMLOperator::createGlyph):

  • Eliminate unused lineHeight and topRelative parameters.
  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

Tools:

Enable the STIXSizeOneSym font for testing.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

  • mathml/presentation/mo.xhtml:
  • platform/chromium/TestExpectations:
  • platform/chromium/mathml/presentation/attributes-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/attributes-expected.txt:
  • platform/chromium/mathml/presentation/fenced-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fenced-expected.txt:
  • platform/chromium/mathml/presentation/fenced-mi-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fenced-mi-expected.txt:
  • platform/chromium/mathml/presentation/fractions-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fractions-expected.txt:
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/chromium/mathml/presentation/mo-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mo-expected.txt:
  • platform/chromium/mathml/presentation/mo-stretch-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mo-stretch-expected.txt:
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/chromium/mathml/presentation/over-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/over-expected.txt:
  • platform/chromium/mathml/presentation/roots-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/roots-expected.txt:
  • platform/chromium/mathml/presentation/row-alignment-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium/mathml/presentation/row-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/row-expected.txt:
  • platform/chromium/mathml/presentation/style-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/style-expected.txt:
  • platform/chromium/mathml/presentation/sub-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/sub-expected.txt:
  • platform/chromium/mathml/presentation/subsup-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/subsup-expected.txt:
  • platform/chromium/mathml/presentation/sup-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/sup-expected.txt:
  • platform/chromium/mathml/presentation/tables-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/tables-expected.txt:
  • platform/chromium/mathml/presentation/tokenElements-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/tokenElements-expected.txt:
  • platform/chromium/mathml/presentation/under-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/under-expected.txt:
  • platform/chromium/mathml/presentation/underover-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/presentation/underover-expected.txt:
  • platform/chromium/mathml/xHeight-expected.png: Modified property svn:mime-type.
  • platform/chromium/mathml/xHeight-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
2:11 PM Changeset in webkit [132263] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Properly skipping http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout*
tests, as was the author's intention.

  • platform/chromium/TestExpectations:
2:09 PM Changeset in webkit [132262] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by Eric Seidel.

Remove hack for clobbering build when features.gypi changes. Now that
Chromium requires VS2010 or newer, this bug has gone away.

  • Scripts/update-webkit:
2:09 PM Changeset in webkit [132261] by benjamin@webkit.org
  • 5 edits in trunk/Source

WTFURL: Implement KURL::setPort()
https://bugs.webkit.org/show_bug.cgi?id=99898

Reviewed by Adam Barth.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::setPort):

Source/WTF:

Add an efficient implementation for remplacing the port component
in an URL. This will be the base for replacing other components
efficiently.

The testing is covered by fast/dom/HTMLAnchorElement/set-href-attribute-port.html

  • wtf/url/api/ParsedURL.cpp:

(WTF::generateNewSpecWithPort):
(WTF::replacePortWithString):
(WTF::ParsedURL::replacePort):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

2:05 PM Changeset in webkit [132260] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

In the open-source jpeg decoder, read image orientation from the exif data
https://bugs.webkit.org/show_bug.cgi?id=100144

Reviewed by Eric Seidel.

This will be used to implement the shouldRespectImageOrientation
setting (see bug 19688). Currently this isn't hooked up anywhere, so
it has no observable effect for now.

Once it's hooked up, it will be tested by
fast/images/exif-orientation.html

  • platform/graphics/BitmapImage.h:
  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::orientation):
(ImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readUint16):
(WebCore):
(WebCore::readUint32):
(WebCore::checkExifHeader):
(WebCore::readImageOrientation):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(WebCore::JPEGImageDecoder::setOrientation):

2:02 PM Changeset in webkit [132259] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix thread safety issue in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=100154

Reviewed by Kenneth Russell.

Add appropriate locking in AudioParamTimeline::valueForContextTime()

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):

1:25 PM Changeset in webkit [132258] by alecflett@chromium.org
  • 14 edits in trunk/Source

IndexedDB: refactor backend to use IDB*Metadata
https://bugs.webkit.org/show_bug.cgi?id=100055

Reviewed by Tony Chang.

Source/WebCore:

This further encapsulates the static data in
IDBObjectStoreBackendImpl and IDBIndexBackendImp into their
respective IDB*Metadata structs, in preparation for
https://bugs.webkit.org/show_bug.cgi?id=99774.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::metadata):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::id):
(WebCore::IDBIndexBackendImpl::setId):
(WebCore::IDBIndexBackendImpl::hasValidId):
(WebCore::IDBIndexBackendImpl::name):
(WebCore::IDBIndexBackendImpl::keyPath):
(WebCore::IDBIndexBackendImpl::unique):
(WebCore::IDBIndexBackendImpl::multiEntry):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::id):
(WebCore::IDBObjectStoreBackendImpl::setId):
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Update tests to reflect refactoring.

  • tests/IDBDatabaseBackendTest.cpp:
  • tests/IDBFakeBackingStore.h:
1:17 PM Changeset in webkit [132257] by krit@webkit.org
  • 3 edits
    2 adds in trunk

BasicShapePolygon::path takes width instead of height for boundary calculation
https://bugs.webkit.org/show_bug.cgi?id=99919

Reviewed by Darin Adler.

Source/WebCore:

The 'y' parameters of polygon were calculated by the with of the bounding box of the object.
This caused problems on percentage values for point positions.
Changed it to the height of the bounding box.

Test: css3/masking/clip-path-polygon-percentage.html

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path):

LayoutTests:

Test that the correct relation is used for calculating point position of an polygon.

  • css3/masking/clip-path-polygon-percentage-expected.html: Added.
  • css3/masking/clip-path-polygon-percentage.html: Added.
12:44 PM Changeset in webkit [132256] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add CHROMIUM_texture_from_image extension support.
https://bugs.webkit.org/show_bug.cgi?id=99894

Patch by David Reveman <reveman@chromium.org> on 2012-10-23
Reviewed by James Robinson.

Add bindTexImage2DCHROMIUM and releaseTexImage2DCHROMIUM prototypes to
WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::bindTexImage2DCHROMIUM):
(WebKit::WebGraphicsContext3D::releaseTexImage2DCHROMIUM):

12:40 PM Changeset in webkit [132255] by Lucas Forschler
  • 2 edits in tags/Safari-537.15.2/Source/WebKit2

Hand merge fix for:
<rdar://problem/12530687>


  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

12:14 PM Changeset in webkit [132254] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS r163297:163557
https://bugs.webkit.org/show_bug.cgi?id=100146

Reviewed by Adrienne Walker.

12:12 PM Changeset in webkit [132253] by dpranke@chromium.org
  • 1 edit
    33 deletes in trunk/LayoutTests

Remove remaining fast/innerHTML pixel test baselines after r131960.

Unreviewed, expectations change.

  • platform/chromium-linux/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-linux/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/002-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/003-expected.png: Removed.
  • platform/chromium-mac/fast/innerHTML/006-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.png: Removed.
  • platform/chromium-win/fast/innerHTML/001-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/002-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/003-expected.txt: Removed.
  • platform/chromium-win/fast/innerHTML/006-expected.txt: Removed.
  • platform/efl/fast/innerHTML/001-expected.txt: Removed.
  • platform/efl/fast/innerHTML/002-expected.txt: Removed.
  • platform/efl/fast/innerHTML/003-expected.txt: Removed.
  • platform/efl/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/001-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/002-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/003-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/006-expected.txt: Removed.
  • platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
  • platform/mac/fast/innerHTML/001-expected.txt: Removed.
  • platform/mac/fast/innerHTML/002-expected.txt: Removed.
  • platform/mac/fast/innerHTML/003-expected.txt: Removed.
  • platform/mac/fast/innerHTML/006-expected.txt: Removed.
  • platform/qt/fast/innerHTML/001-expected.txt: Removed.
  • platform/qt/fast/innerHTML/002-expected.txt: Removed.
  • platform/qt/fast/innerHTML/003-expected.txt: Removed.
  • platform/qt/fast/innerHTML/006-expected.txt: Removed.
11:49 AM Changeset in webkit [132252] by dominik.rottsches@intel.com
  • 13 edits
    25 adds in trunk

Add timeout support to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=74802

Reviewed by Nate Chapin.

Source/WebCore:

An implementation of XHR2 timeouts by using ResourceRequest's setTimeoutInterval.
This made several changes necessary in CachedResource and SubresourceLoader in order
to distinguish and forward the timeout case from there.

The case of late updates to the timeout property, changing the timeout value after send()
is not supported yet and handled separately in bug 98156.

XHR2 timeout tests were initially written by Mozilla's Alex Vincent's. He granted
permission to reuse them under PD/BSD license
in https://bugzilla.mozilla.org/show_bug.cgi?id=525816#c86 - big thanks!
I adapted them for W3C testharness.js and split them into groups with shorter test running time
so that they can be used as WebKit layout tests.

Tests: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html

http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::notifyFinished): Forward information about timeout case.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFail): Distinguish timeout case when informing client.

  • loader/cache/CachedResource.h: Distinguishing timeout case for errors.

(WebCore::CachedResource::errorOccurred):
(WebCore::CachedResource::loadFailedOrCanceled):
(WebCore::CachedResource::timedOut):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest): Initializing m_timeout value to zero.
(WebCore::XMLHttpRequest::setTimeout): Setter function, possibly raising JS exception.
(WebCore):
(WebCore::XMLHttpRequest::open): Open call may raise exception for synchronous requests when timeout value is set.
(WebCore::XMLHttpRequest::createRequest): Assigning timeout value to ResourceRequest.
(WebCore::XMLHttpRequest::didFail): Handling timeout case separately.
(WebCore::XMLHttpRequest::didTimeout): Timeout case state transisition and event firing as spec'ed.

  • xml/XMLHttpRequest.h: New event listener, member and callback for handling timeout.

(WebCore::XMLHttpRequest::timeout):
(XMLHttpRequest):

  • xml/XMLHttpRequest.idl: New event listener and property added.
  • xml/XMLHttpRequestException.cpp:
  • xml/XMLHttpRequestException.h: Added an exception value for the timeout case.

LayoutTests:

XHR2 timeout tests were initially written by Mozilla's Alex Vincent's. He granted
permission to reuse them under PD/BSD license
in https://bugzilla.mozilla.org/show_bug.cgi?id=525816#c86 - big thanks!
I adapted them for W3C testharness.js and split them into groups with shorter test running time
so that they can be used as WebKit layout tests. Each individual test should
complete in less than 20 seconds.

The case of late updates to the timeout property, changing the timeout value after send()
is not supported yet and handled separately in bug 98156. Tests that are testing this feature
are commented out until this bug is tackled.

The suffix of the html test filename matches the groups in xmlhttprequest-timeout.js which contains
all tests that are run. The result of assertions is reported back to testharness.js.

For example, the "overrides" group is currently not run yet since all tests in that group are cases
of late updates, see above. Once late updates are supported we can add a file
xmlhttprequest-timeout-overrides.html to run them.

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js: Added. Distinguishes which group of tests to run based on filename suffix.

(testResultCallbackHandler.return):
(groupFromLocation):

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js: Added. Contains test cases for all individual test html files.

(message): Wrapper for postMessage in worker and document context case.
(is),
(ok): Assertion functions.
(RequestTracker): Class for variations of the regular timeout case.
(RequestTracker.prototype.startXHR.handleEvent):
(RequestTracker.prototype.startXHR):
(RequestTracker.prototype.getMessage):
(RequestTracker.prototype.handleEvent):
(AbortedRequest): Class for testing timeout event vs. abort events.
(AbortedRequest.prototype.startXHR.handleEvent):
(AbortedRequest.prototype.startXHR.abortReq):
(AbortedRequest.prototype.startXHR.else):
(AbortedRequest.prototype.startXHR):
(AbortedRequest.prototype.noEventsFired):
(AbortedRequest.prototype.getMessage):
(AbortedRequest.prototype.handleEvent):
(SyncRequestSettingTimeoutAfterOpen.startXHR),
(SyncRequestSettingTimeoutBeforeOpen.startXHR): Test classes for synchronous XHR cases.
(TestCounter.testComplete),
(TestCounter.next): Used for cycling through tests.

  • platform/chromium/TestExpectations: Skipping XHR timeout cases since setTimeoutInterval is not supported in Chromium's HTTP stack.
  • platform/gtk/TestExpectations: Marking XHR timeout cases as slow in order to run them with a longer test timeout threshold.
  • platform/qt/TestExpectations: Skipping XHR timeout cases since setTimeoutInterval is not supported in Chromium's HTTP stack.
11:45 AM Changeset in webkit [132251] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. css3/filters/blur-filter-page-scroll-self.html is crashing
now as well as generating incorrect image results :(

  • platform/chromium/TestExpectations:
11:42 AM Changeset in webkit [132250] by Lucas Forschler
  • 5 edits in tags/Safari-537.15.2/Source/JavaScriptCore

Merged r131791.

11:29 AM Changeset in webkit [132249] by Lucas Forschler
  • 4 edits in tags/Safari-537.15.2/Source

Versioning.

11:29 AM Changeset in webkit [132248] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WIN7] Skip fast/media/mq-resolution.html.
https://bugs.webkit.org/show_bug.cgi?id=100143.

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-23
Reviewed by Kenneth Rohde Christiansen.

The feature is not yet implemented.

  • platform/win/TestExpectations:
11:26 AM Changeset in webkit [132247] by Lucas Forschler
  • 1 copy in tags/Safari-537.15.2

New Tag.

11:22 AM Changeset in webkit [132246] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Possible assertion hit in WebCore::HTMLSelectElement::updateListBoxSelection()
https://bugs.webkit.org/show_bug.cgi?id=99967

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Tony Chang.

Source/WebCore:

Fix assertion hit in WebCore::HTMLSelectElement::updateListBoxSelection() when
pressing the left mouse button outside a multiselect and then moving the cursor
over the multiselect element while holding the button down.

The issue is that the HTMLSelectElement handler for the mouse move event does
not check if there is a selection before trying to extend the selection.

Test: fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

LayoutTests:

Added layout test to reproduce an assertion hit in
WebCore::HTMLSelectElement::updateListBoxSelection() when pressing the left
button outside a multiselect and then moving the mouse over the multiselect
element while holding the button down.

  • fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-noAnchorIndex-crash.html: Added.
11:14 AM Changeset in webkit [132245] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

[V8] ScriptWrappable should hold the wrapper handle directly (Dromaeo/dom-modify and dom-traverse get ~2.5% faster)
https://bugs.webkit.org/show_bug.cgi?id=97974

Reviewed by Eric Seidel.

Previously, we stored a pointer to a handle to a wrapper in Node. That
is an extra layer of indirection that slows down finding the wrapper
for the node. A handle is just a pointer, so we might as we just store
the handle in the Node directly. That speeds up dom-modify and
dom-traverse by about 2.5%.

This change also lets us get rid of the ChunkedTable we were using to
store all the wrappers because they're now stored in the Nodes
directly.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

10:58 AM Changeset in webkit [132244] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Regression(r132143): Assertion hit in JSC::Interpreter::StackPolicy::StackPolicy(JSC::Interpreter&, const WTF::StackBounds&)
https://bugs.webkit.org/show_bug.cgi?id=100109

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-23
Reviewed by Oliver Hunt.

Fix possible integer overflow in StackPolicy constructor by
using size_t type instead of int for stack sizes. The value
returned by StackBounds::size() is of type size_t but was
assigned to an int, which may overflow.

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::StackPolicy::StackPolicy):

10:57 AM Changeset in webkit [132243] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace SetGlobalGCPrologueCallback() with AddGCPrologueCallback()
https://bugs.webkit.org/show_bug.cgi?id=100140

Reviewed by Adam Barth.

SetGlobalGCPrologueCallback() and SetGlobalGCEpilogueCallback()
are deprecated (See http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/include/v8.h&exact_package=chromium&q=v8.h&type=cs&l=3149)
Instead we should use AddGCPrologueCallback()
and AddGCEpilogueCallback().

No tests. No change in behavior.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::initializeV8IfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcPrologue):
(WebCore):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::minorGCEpilogue):
(WebCore::V8GCController::majorGCEpilogue):

  • bindings/v8/V8GCController.h:

(V8GCController):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

10:34 AM Changeset in webkit [132242] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

[V8] Enumerate Nodes via the V8 heap rather than via a list in WebCore
https://bugs.webkit.org/show_bug.cgi?id=100033

Reviewed by Eric Seidel.

This patch changes how we enumerate nodes during garbage collection.
After this patch, we use V8's list of open handles to enumerate node
wrappers rather than using a separate list that we maintain in WebCore
for this purpose. A future patch will remove the list in WebCore for a
DOM performance gain.

  • bindings/js/ScriptProfiler.h:

(WebCore):
(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::IntrusiveDOMWrapperMap::set):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::NodeWrapperVisitor::~NodeWrapperVisitor):
(WebCore):
(WebCore::visitAllDOMNodes):

  • bindings/v8/V8DOMMap.h:

(WebCore):
(NodeWrapperVisitor):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode):

  • bindings/v8/V8GCController.cpp:

(WebCore::NodeVisitor::visitNodeWrapper):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

  • inspector/BindingVisitors.h:

(WebCore::WrappedNodeVisitor::~WrappedNodeVisitor):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

10:25 AM Changeset in webkit [132241] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] remove the const qualifier from WebTestDelegate::printMessage
https://bugs.webkit.org/show_bug.cgi?id=100082

Reviewed by Adam Barth.

There's no reason the method should be const, and indeed for
content_shell we want to send an IPC which is a non-const operation.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:

(TestDelegate):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::printMessage):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printMessage):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:12 AM Changeset in webkit [132240] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make selection in search input box not overlap cancel button
https://bugs.webkit.org/show_bug.cgi?id=100130

Reviewed by Antonio Gomes.

This ensures that even when selection is active, the user can still press 'cancel'.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

10:06 AM Changeset in webkit [132239] by caseq@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: paint rectangles are incorrectly shown in case subframes are present
https://bugs.webkit.org/show_bug.cgi?id=99849

Reviewed by Pavel Feldman.

Move GraphicsContext and paint rectangle from willPaint() to didPaint(), so we don't have
to store them as a state of InspectorPageAgent

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCo