Timeline



Nov 26, 2012:

11:53 PM Changeset in webkit [135829] by tkent@chromium.org
  • 20 edits in trunk

:read-only selector should match to date/time input types
https://bugs.webkit.org/show_bug.cgi?id=103350

Reviewed by Kentaro Hara.

Source/WebCore:

We supported :read-only and :read-write only for text form controls;
i.e. <textarea> and text-field <input>. According to [1], we should
support them for date/time types. So, this patch removes
isTextFormControl check in SelectorChecker, and just relies on
shouldMatchRead{Only,Write}Selector virtual functions.

Tests: Update fast/forms/*/*-appearance-pseudo-classes.html.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#input-type-attr-summary

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):
Remove isFormControlElement check and isTextFormControl check.

  • html/HTMLFormControlElement.cpp:

Remove shouldMatchRead{Only,Write}Selector functions. We don't need
common implementations any more.

  • html/HTMLFormControlElement.h: Ditto.
  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Add shouldMatchRead{Only,Write}Selector overrides.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::shouldMatchReadOnlySelector): Added.
(WebCore::HTMLTextAreaElement::shouldMatchReadWriteSelector): Added.

  • html/HTMLInputElement.h:

(HTMLInputElement): Add shouldMatchRead{Only,Write}Selector overrides.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldMatchReadOnlySelector):
Added. This checks InputType::supportsReadOnly and readOnly.
(WebCore::HTMLInputElement::shouldMatchReadWriteSelector): Ditto.

  • html/InputType.h:

(InputType): Add supportsReadOnly.

  • html/InputType.cpp:

(WebCore::InputType::supportsReadOnly): Added. Returns false by default.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Add supportsReadOnly.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::supportsReadOnly): Added. Returns true.

  • html/TextFieldInputType.h:

(TextFieldInputType): Add supportsReadOnly.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::supportsReadOnly): Added. Returns true.

LayoutTests:

The text color becomes yellow as specified for :read-only in
*-appearance-pseudo-classes.html

  • platform/chromium-mac/fast/forms/date/date-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/time/time-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png:
  • platform/chromium/TestExpectations:
11:43 PM FeatureFlags edited by zherczeg@inf.u-szeged.hu
(diff)
11:34 PM Changeset in webkit [135828] by abarth@webkit.org
  • 3 edits in trunk/Source/WTF

[Chromium] fastMalloc has an extra branch on Windows
https://bugs.webkit.org/show_bug.cgi?id=103027

Reviewed by Eric Seidel.

There's no need to override the new/delete operators on non-Mac
platform because:

1) We use the system malloc anyway.
2) We've modified the system malloc to crash in out-of-memory conditions.

This patch removes a branch (and a call) from malloc, which will
hopefully improve performance. I haven't measured the performance
characteristics of this patch, but I will look at the graphs closely
when landing.

  • wtf/FastAllocBase.h:
  • wtf/Platform.h:
11:24 PM Changeset in webkit [135827] by Simon Fraser
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

<rdar://problem/12755408>
Merge r135080

2012-11-18 Simon Fraser <Simon Fraser>

Make convertToLayerCoords iterative, rather than recursive
https://bugs.webkit.org/show_bug.cgi?id=102618

Reviewed by Antti Koivisto.

RenderLayer::convertToLayerCoords() is a hot function on profiles.
Change it to be iterative, rather than recursive, so that the
bulk of the function can be inlined.

Was tested with assertions against the old code during development.

  • rendering/RenderLayer.cpp: (WebCore::accumulateOffsetTowardsAncestor): (WebCore::RenderLayer::convertToLayerCoords):
11:22 PM Changeset in webkit [135826] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r135822.
http://trac.webkit.org/changeset/135822
https://bugs.webkit.org/show_bug.cgi?id=103369

Undo the revert of r135818, since that change does not affect
code used by Chromium (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

Source/WebCore:

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):

11:20 PM Changeset in webkit [135825] by junov@google.com
  • 2 edits in trunk/LayoutTests

[Qt] new fast/backgrounds/background-opaque-images-over-color.html fails since r135629
https://bugs.webkit.org/show_bug.cgi?id=103227

Reviewed by Simon Hausmann.

Unskipping test now that baseline has been fixed.

  • platform/qt/TestExpectations:
11:14 PM WebKitIDL edited by haraken@chromium.org
(diff)
11:09 PM Changeset in webkit [135824] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix build error on GTK due to r135749
https://bugs.webkit.org/show_bug.cgi?id=103365

Patch by Michael Pruett <michael@68k.org> on 2012-11-26
Reviewed by Dean Jackson.

In r135749, many files which were already included
in webcore_built_sources were erroneously added to
webcore_svg_built_sources in GNUmakefile.list.am.

  • GNUmakefile.list.am:
11:02 PM Changeset in webkit [135823] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Disable unnecessary options of elementary module
https://bugs.webkit.org/show_bug.cgi?id=103360

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-26
Reviewed by Gyuyoung Kim.

When jhbuild configures elementary, unnecessary options may be enabled by
user installed modules and it causes build break.

  • efl/jhbuild.modules:

Added --disable-emap --disable-ethumb --disable-eweather to elementary.

10:58 PM Changeset in webkit [135822] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r135818.
http://trac.webkit.org/changeset/135818
https://bugs.webkit.org/show_bug.cgi?id=103368

platform/chromium/virtual/threaded/compositing/visibility
/visibility-simple-webgl-layer.html crash on Mountain Lion
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

Source/WebCore:

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):

10:45 PM Changeset in webkit [135821] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium mac] Layout Test touchadjustment/touch-links-longpress.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103363

Unreviewed test expectations update.

  • platform/chromium/TestExpectations: Add failing expection for Mac.
10:34 PM Changeset in webkit [135820] by apavlov@chromium.org
  • 3 edits in branches/chromium/1312/Source/WebCore/inspector

Merge 135571 - Web Inspector: inspector overlay is always updated when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=103106

Reviewed by Pavel Feldman.

Provide empty size into the InspectorOverlay if the metrics emulation is disabled,
so that it will not get painted in all cases.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::webViewResized): Call InspectorPageAgent::webViewResized() rather than InspectorOverlay::resize().

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::webViewResized): Provide empty size into InspectorOverlay::resize() if device metrics are not emulated.

  • inspector/InspectorPageAgent.h:

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11415147

10:34 PM Changeset in webkit [135819] by mitz@apple.com
  • 10 edits in trunk/Source/WebKit2

<rdar://problem/11931191> Entering Tab View after a bunch of YouTube pages were opened in background tabs makes all of them start playing simultaneously
https://bugs.webkit.org/show_bug.cgi?id=103358

Reviewed by Adele Peterson.

To fix this, this patch adds WKPageSetMayStartMediaWhenInWindow(), which allows the client to
prevent media from starting automatically when the view is put in a window.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode mayStartMediaWhenInWindow.
(WebKit::WebPageCreationParameters::decode): Decode mayStartMediaWhenInWindow.

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters): Added boolean member mayStartMediaWhenInWindow.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetMayStartMediaWhenInWindow): Added. Calls through to WebPageProxy.

  • UIProcess/API/C/WKPagePrivate.h: Declared WKPageSetMayStartMediaWhenInWindow.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Added initializiation of m_mayStartMediaWhenInWindow
to true, the value matching the current behavior.
(WebKit::WebPageProxy::setMayStartMediaWhenInWindow): Added. Updates
m_mayStartMediaWhenInWindow and sends a message to the Web process to do the same.
(WebKit::WebPageProxy::creationParameters): Changed to set mayStartMediaWhenInWindow in the
process creation parameters.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Declared setMayStartMediaWhenInWindow() and added member variable
m_mayStartMediaWhenInWindow.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialized m_mayStartMediaWhenInWindow from the creation
parameters.
(WebKit::WebPage::setIsInWindow): Made starting of media upon being added to a window
conditional on m_mayStartMediaWhenInWindow.
(WebKit::WebPage::setMayStartMediaWhenInWindow): Added. Sets m_mayStartMediaWhenInWindow. If
already in a window when changing from false to true, starts m_setCanStartMediaTimer.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Declared setMayStartMediaWhenInWindow() and added member variable m_mayStartMediaWhenInWindow.

  • WebProcess/WebPage/WebPage.messages.in: Added SetMayStartMediaWhenInWindow.
10:15 PM Changeset in webkit [135818] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Coordinated Graphics: Set visibility to a mask layer in GraphicsLayer::setContentsVisible().
https://bugs.webkit.org/show_bug.cgi?id=103297

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-26
Reviewed by Noam Rosenthal.

GraphicsLayerTextureMapper and CoordinatedGraphicsLayer set the visibility of a
mask layer in setContentsVisible() and setMaskLayer() like setting a size.
This patch is needed because RenderLayerBacking does not set the visibility to a
mask layer like the size.

This patch does not change user experience because an invisible layer is not
rendered although the mask layer is rendered. In that sense, it is an
optimization patch.

Source/WebCore:

No new tests. It is an optimization patch.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):

9:33 PM Changeset in webkit [135817] by haraken@chromium.org
  • 30 edits in trunk/Source/WebCore

[V8] Rename EXCEPTION_BLOCK() macros
https://bugs.webkit.org/show_bug.cgi?id=103352

Reviewed by Adam Barth.

Since V8Parameter was renamed to V8StringResource,
we rename macros that use V8Parameter.

EXCEPTION_BLOCK() => V8TRYCATCH()
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() => V8TRYCATCH_FOR_V8STRINGRESOURCE()
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() => V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID()

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(ConvertToV8StringResource):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::classMethodWithOptionalCallback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/V8Binding.h:

(WebCore::toV8Sequence):

  • bindings/v8/V8BindingMacros.h:
  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getExtensionCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):

9:13 PM Changeset in webkit [135816] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Node: Move AreSVGAttributesValidFlag to ElementAttributeData.
<http://webkit.org/b/103349>

Reviewed by Anders Carlsson.

Moved AreSVGAttributesValidFlag to ElementAttributeData and change it to use "dirty" semantics.
This frees up a bit on Node, and we will always have ElementAttributeData if the animated
attributes are dirty anyway.

  • dom/Element.cpp:

(WebCore::Element::getAttribute):

  • dom/Element.h:

(WebCore::Element::updateInvalidAttributes):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ElementAttributeData):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::ElementAttributeData):
(ElementAttributeData):

  • dom/Node.h:

(Node):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::updateAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

9:06 PM Changeset in webkit [135815] by haraken@chromium.org
  • 17 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r135798.
http://trac.webkit.org/changeset/135798
https://bugs.webkit.org/show_bug.cgi?id=103354

Broke the chrome mac build (Requested by noel_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

Source/WebCore:

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::~DeferredImageDecoder):
(WebCore::DeferredImageDecoder::createResizedLazyDecodingBitmap):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::createLazyDecodingBitmap):

  • platform/graphics/chromium/DeferredImageDecoder.h:

(DeferredImageDecoder):

  • platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::instanceOnMainThread):
(WebCore::ImageDecodingStore::initializeOnMainThread):
(WebCore::ImageDecodingStore::shutdown):
(WebCore::ImageDecodingStore::calledOnValidThread):
(WebCore::ImageDecodingStore::lookupFrameCache):
(WebCore::ImageDecodingStore::deleteFrameCache):

  • platform/graphics/chromium/ImageDecodingStore.h:

(WebCore):
(ImageDecodingStore):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::~ImageFrameGenerator):
(WebCore::ImageFrameGenerator::setData):
(WebCore::ImageFrameGenerator::decodeAndScale):

  • platform/graphics/chromium/ImageFrameGenerator.h:

(WebCore):
(WebCore::ImageFrameGenerator::create):
(ImageFrameGenerator):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(WebCore):
(LazyDecodingPixelRef):

  • platform/graphics/chromium/ScaledImageFragment.cpp:

(WebCore::ScaledImageFragment::ScaledImageFragment):
(WebCore::ScaledImageFragment::isEqual):
(WebCore):

  • platform/graphics/chromium/ScaledImageFragment.h:

(WebCore):
(WebCore::ScaledImageFragment::create):
(ScaledImageFragment):

  • platform/graphics/chromium/SkSizeHash.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):

  • tests/DeferredImageDecoderTest.cpp:

(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):

  • tests/ImageFrameGeneratorTest.cpp: Removed.
  • tests/MockImageDecoder.h:

(MockImageDecoderClient):
(WebCore::MockImageDecoder::frameBufferAtIndex):

8:41 PM Changeset in webkit [135814] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] GraphicsLayerTextureMapper::setSize() sets the size of a mask layer.
https://bugs.webkit.org/show_bug.cgi?id=103297

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-26
Reviewed by Noam Rosenthal.

Currently, CoordinatedGraphicsLayer sets the size of a mask layer in setSize()
and setMaksLayer(). GraphicsLayerTextureMapper follows the behavior. If so we
don't have to check the size of the mask layer in TextureMapperLayer::flushCompositingState().

No new tests. Covered by existing tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setSize):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingState):

8:37 PM Changeset in webkit [135813] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL] CMake shows ENABLE_3D_RENDERING and ENABLE_WEBGL is still OFF when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=100829

Patch by Halton Huo <halton.huo@intel.com> on 2012-11-26
Reviewed by Gyuyoung Kim.

In WebKitFeatures.cmake, only use ${_name} for condition to print
a option as ON will prevent the overridden ones in OptionsXXX.cmake,
should use ${_WEBKIT_AVAILABLE_OPTIONS_INITALVALUE_${_name}} instead.

  • Source/cmake/OptionsEfl.cmake: Turn on ENABLE_3D_RENDERING and

ENABLE_WEBGL

  • Source/cmake/WebKitFeatures.cmake: Use

${_WEBKIT_AVAILABLE_OPTIONS_INITALVALUE_${_name}} to as value of
a feature is enabled. Adjust options in lexicographical order.

8:30 PM Changeset in webkit [135812] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove V8Parameter::object()
https://bugs.webkit.org/show_bug.cgi?id=103340

Reviewed by Adam Barth.

V8Parameter can use m_v8Object directly.

No tests. No change in behavior.

  • bindings/v8/V8StringResource.h:

(WebCore::::prepare):

8:28 PM Changeset in webkit [135811] by haraken@chromium.org
  • 20 edits in trunk/Source/WebCore

[V8] Rename V8Parameter to V8StringResource
https://bugs.webkit.org/show_bug.cgi?id=103341

Reviewed by Adam Barth.

We can rename V8Parameter to V8StringResource. In a follow-up patch,
I will rename macros around V8Parameter.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(GetNativeTypeFromSignature):
(GetNativeType):
(ConvertToV8StringResource):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor4Callback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/V8StringResource.h:

(WebCore::V8StringResource::V8StringResource):
(WebCore::::prepare):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getExtensionCallback):

8:13 PM Changeset in webkit [135810] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

HTMLOptionElement: Remove two unused members.
<http://webkit.org/b/103337>

Reviewed by Kent Tamura.

Remove two unused members from HTMLOptionElement, m_value and m_label.
40kB progression on Membuster3.

  • html/HTMLOptionElement.h:

(HTMLOptionElement):

8:09 PM Changeset in webkit [135809] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Shared graphics context should only pushGroupMarker() once
https://bugs.webkit.org/show_bug.cgi?id=103082

Reviewed by James Robinson.

GraphicsContext3D's pushGroupMarkerEXT() is being called every time
an ImageBuffer is created, leading to unlimited memory growth, since
they share a common GraphicsContext3D. It should be called only once,
on context creation.

Tested by manually checking the memory usage in Chrome's TaskManager.
(Sorry, I can't think of a way to test this automatically.)

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

8:08 PM Changeset in webkit [135808] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Touchscreen fling handling
https://bugs.webkit.org/show_bug.cgi?id=103278

Reviewed by James Robinson.

The fling logic for touchpad can fall through to bad
performance in several ways. This patch introduces an alternate
path for touchscreen fling that simplifies it as follows:

  • Stop generating wheel events, to prevent unnecessary scrollBegin hit

tests and to avoid falling back to slow path if a wheel handler is
registered.

  • Drop the event on ScrollStatusIgnored. There's no real reason to

send the event to the WebKit thread here.

  • Don't call transferActiveWheelFlingAnimation. This type of

transition shouldn't be needed with touchscreen flings.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:
8:03 PM Changeset in webkit [135807] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

Update Chromium test expectation for test LayoutTests/fast/js/string-replacement-outofmemory.html
See <https://bugs.webkit.org/show_bug.cgi?id=103348> for more details.

  • platform/chromium/TestExpectations:
7:57 PM Changeset in webkit [135806] by haraken@chromium.org
  • 16 edits
    2 deletes in trunk/Source

[V8] Remove WorkerContextExecutionProxy.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=103325

Reviewed by Adam Barth.

Now WorkerContextExecutionProxy.{h,cpp} are empty.

No tests. No change in behavior.

Source/WebCore:

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/ScheduledAction.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:

(WebCore):

  • bindings/v8/WorkerContextExecutionProxy.cpp: Removed.
  • bindings/v8/WorkerContextExecutionProxy.h: Removed.
  • bindings/v8/WorkerScriptController.cpp:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
  • bindings/v8/custom/V8MessageChannelCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

Source/WebKit/chromium:

  • src/WebKit.cpp:
  • src/WebWorkerClientImpl.cpp:
7:51 PM Changeset in webkit [135805] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Grapheme cluster functions can be simplified for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=102996

Reviewed by Alexey Proskuryakov.

For 8 bit strings, check for the uncommon CR-LF by looking for any CR. If there aren't any CR characters,
the number of Extended Grapheme Clusters is equal to the string length. If we need to handle Tailored
Graheme Clusters, then this will need to change.

No new tests. No change in functionality.

  • platform/text/TextBreakIterator.cpp:

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

7:40 PM Changeset in webkit [135804] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Check for empty perContextData while creating NP V8 Object.
https://bugs.webkit.org/show_bug.cgi?id=98448

Patch by Istiaque Ahmed <lazyboy@chromium.org> on 2012-11-26
Reviewed by Adam Barth.

Fixes crash in npCreateV8ScriptObject(), if NP Invoke is called from a document
that is no longer displayed in frame (isCurrentlyDisplayedInFrame() ==
false), we have empty perContextData and this results in invalid memory access.

Source/WebCore:

Test: platform/chromium/plugins/empty-per-context-data.html

  • bindings/v8/NPV8Object.cpp:

(WebCore::npCreateV8ScriptObject):

LayoutTests:

  • platform/chromium/plugins/empty-per-context-data-expected.txt: Added.
  • platform/chromium/plugins/empty-per-context-data.html: Added.
  • platform/chromium/plugins/resources/script-container.html: Added.
7:04 PM Changeset in webkit [135803] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2] Expose Accelerated2dCanvas flag set and get in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=103008

Patch by Kyungjin Kim <gen.kim@samsung.com> on 2012-11-26
Reviewed by Gyuyoung Kim.

Add setting APIs for accelerated 2d canvas in WebKit2.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAccelerated2dCanvasEnabled):
(WKPreferencesGetAccelerated2dCanvasEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

6:59 PM Changeset in webkit [135802] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

HTML/XML parser helper unconsumeCharacters() can push back 8 bit text as 16 bit text
https://bugs.webkit.org/show_bug.cgi?id=103317

Reviewed by Oliver Hunt.

Changed to use the String directly from the StringBuilder instead of creating our own.
Used toStringPreserveCapacity() in case the caller may want to add to the StringBuilder
even though current callers don't.

No new tests. No change in functionality.

  • xml/parser/CharacterReferenceParserInlines.h:

(WebCore::unconsumeCharacters):

6:25 PM Changeset in webkit [135801] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Remove deprecated and unused WebGraphicsContext3D compositor binding calls
https://bugs.webkit.org/show_bug.cgi?id=103322

Patch by James Robinson <jamesr@chromium.org> on 2012-11-26
Reviewed by Adam Barth.

Source/Platform:

These have been uncalled for a while.

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

6:22 PM Changeset in webkit [135800] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Substitute "allSeparators8Bit" for "allSeperators8Bit" in JSC::jsSpliceSubstringsWithSeparators()
<https://bugs.webkit.org/show_bug.cgi?id=103303>

Reviewed by Simon Fraser.

Fix misspelled word, "Seperators" [sic], in a local variable name in JSC::jsSpliceSubstringsWithSeparators().

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):

6:10 PM Changeset in webkit [135799] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

PNG decode performance: avoid using frame buffer.setRGBA(x,y)
https://bugs.webkit.org/show_bug.cgi?id=103216

Reviewed by Brent Fulgham.

Writing decoded row pixels to the frame buffer with buffer.setRGBA(x,y) is slow compared
to writing direct to the frame buffer address. Use buffer.getAddr() to obtain the output
pixel row address, write the decoded row pixels to that address.

No new tests. Covered by many existing tests.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::setRGBA): Make routine setRGBA(PixelData* dest, ...) public. Test
m_premultiplyAlpha once to minimize code branching in this routine.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable): Write decoded row pixels to the frame buffer
using the pixel address form: buffer.setRGBA(address++, ...).

6:06 PM Changeset in webkit [135798] by hclam@chromium.org
  • 17 edits
    2 adds in trunk/Source

[chromium] Implement full-featured image cache
https://bugs.webkit.org/show_bug.cgi?id=99784

Reviewed by James Robinson.

Source/WebCore:

Implement a thread-safe image cache to be used with deferred image
decoding. Image cache can now be accessed on any thread.

The patch implements the following logic:

  1. Mutex to protect all cache operations.
  2. Cache indexing using key (ImageFrameGenerator*, SkISize scaledSize)
  3. Cache lookup.
  4. Cache insertion.
  5. Generation of cache entry by scaling full size image.
  6. Generation of cache entries by decoding and scaling.

Classes involved:

ImageDecodingStore

Responsible for owning cache entries and indexing. Pruning and memory
management will be added later.

ImageFrameGenerator

Responsible for generating new cache enties and insert them into
ImageDecodingStore.

LazyDecodingPixelRef

Responsible for cache lookup and lazy generation of cache entries
using ImageFrameGenerator. There is a mutex to protect concurrent
lock operations.

These items are not implemented in this patch:

  1. Cache pruning.
  2. Setting cache memory limit.
  3. Cache deletion.
  4. Caching incomplete images and ImageDecoder.

Unit tests added in ImageFrameGeneratorTest.cpp.
Layout tests are under platform/chromium/virtual/fast/images.

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::~DeferredImageDecoder):
(WebCore::DeferredImageDecoder::createResizedLazyDecodingBitmap):
(WebCore::DeferredImageDecoder::setEnabled):
(WebCore):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::createLazyDecodingBitmap):

  • platform/graphics/chromium/DeferredImageDecoder.h:

(DeferredImageDecoder):

  • platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::instance):
(WebCore::ImageDecodingStore::initializeOnce):
(WebCore::ImageDecodingStore::shutdown):
(WebCore::ImageDecodingStore::lockCompleteCache):
Lookup complete cache entry using hash key, increment use count.
(WebCore::ImageDecodingStore::lockIncompleteCache): TODO.
(WebCore::ImageDecodingStore::unlockCache):
Lookup cache entry using hash key, decrement use count.
(WebCore):
(WebCore::ImageDecodingStore::insertAndLockCache):
Insert new cache entry and increment use count.
(WebCore::ImageDecodingStore::prune): TODO.

  • platform/graphics/chromium/ImageDecodingStore.h:

(WebCore):
(ImageDecodingStore):
(WebCore::ImageDecodingStore::CacheEntry::create):
(WebCore::ImageDecodingStore::CacheEntry::createAndUse):
(CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::~CacheEntry):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::setData):
(WebCore::ImageFrameGenerator::decodeAndScale):
Method for creating new cache entries. This is protected by a mutex
to prevent concurrent operations. Which means only one thread can
generate new cache entries for a set of encoded data.
(WebCore):
(WebCore::ImageFrameGenerator::tryToLockCache):
Tries to lookup a cache entry.
(WebCore::ImageFrameGenerator::tryToScale):
Tries to lookup a full size cache entry and generate a scaled version.
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
Tries to decode and scale.

  • platform/graphics/chromium/ImageFrameGenerator.h:

(WebCore):
(ImageDecoderFactory):
(WebCore::ImageFrameGenerator::create):
(ImageFrameGenerator):
(WebCore::ImageFrameGenerator::setImageDecoderFactoryForTesting):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(WebCore):
(LazyDecodingPixelRef):

  • platform/graphics/chromium/ScaledImageFragment.cpp:

(WebCore::ScaledImageFragment::ScaledImageFragment):

  • platform/graphics/chromium/ScaledImageFragment.h:

(WebCore):
(WebCore::ScaledImageFragment::create):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::scaledSize):

  • platform/graphics/chromium/SkSizeHash.h: Added.

(WTF):

Source/WebKit/chromium:

Added ImageFrameGeneratorTest to test cache logic and generation
of new cache entries.

ImageFrameGeneratorTest.cacheHit
Test that a complete cached entry is reused.

ImageFrameGeneratorTest.cacheMissWithScale
Cache miss for a scaled image but cache hit on a full size image.
Scaled image is created from cached full size image.

ImageFrameGeneratorTest.cacheMissWithDecodeAndScale
Cache miss for both scaled image and full size image.

ImageFrameGeneratorTest.cacheMissWithIncompleteDecode
Test the logic for handling incomplete cache objects.

  • WebKit.gypi:
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):

  • tests/DeferredImageDecoderTest.cpp:

(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):
(WebCore::DeferredImageDecoderTest::frameBufferRequested):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::frameStatus):

  • tests/ImageFrameGeneratorTest.cpp: Added.

(WebCore):
(WebCore::fullSize):
(WebCore::scaledSize):
(MockImageDecoderFactory):
(WebCore::MockImageDecoderFactory::create):
(WebCore::MockImageDecoderFactory::MockImageDecoderFactory):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::TearDown):
(WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed):
(WebCore::ImageFrameGeneratorTest::frameBufferRequested):
(WebCore::ImageFrameGeneratorTest::frameStatus):
(WebCore::ImageFrameGeneratorTest::createCompleteImage):
(WebCore::ImageFrameGeneratorTest::setFrameStatus):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h:

(MockImageDecoderClient):
(WebCore::MockImageDecoder::frameBufferAtIndex):

6:01 PM Changeset in webkit [135797] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Ensure that plugins are initialized before using handleEditingCommand/isEditingCommandEnabled/shouldAllowScripting
https://bugs.webkit.org/show_bug.cgi?id=103288

Reviewed by Dan Bernstein.

Other PluginView methods that use m_plugin null-check m_plugin and check
that the plugin has finished initializing before using it. These three
should do the same thing.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEditingCommand):
(WebKit::PluginView::isEditingCommandEnabled):
(WebKit::PluginView::shouldAllowScripting):

6:01 PM Changeset in webkit [135796] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Subframe PDF context menus are in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=103284
<rdar://problem/12727972>

Reviewed by Dan Bernstein.

Event position is in window coordinates, not content coordinates.
Since we have no windowToScreen(), use windowToContents and contentsToScreen
to get to screen coordinate space, which WKPopupContextMenu wants.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::handleContextMenuEvent):

6:00 PM Changeset in webkit [135795] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Ctrl-click opens a link in a PDF in addition to context menu
https://bugs.webkit.org/show_bug.cgi?id=103282
<rdar://problem/12710892>

Reviewed by Dan Bernstein.

Don't send standard mouse events to PDFKit if a click will also show/hide the context menu.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::handleMouseEvent):

6:00 PM Changeset in webkit [135794] by dbates@webkit.org
  • 3 edits
    3 adds in trunk

JavaScript fails to handle String.replace() with large replacement string
https://bugs.webkit.org/show_bug.cgi?id=102956
<rdar://problem/12738012>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fix an issue where we didn't check for overflow when computing the length
of the result of String.replace() with a large replacement string.

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstringsWithSeparators):

LayoutTests:

Add test to ensure that we handle string replacement with a large replacement string.

  • fast/js/script-tests/string-replacement-outofmemory.js: Added.

(createStringWithRepeatedChar):

  • fast/js/string-replacement-outofmemory-expected.txt: Added.
  • fast/js/string-replacement-outofmemory.html: Added.
5:52 PM Changeset in webkit [135793] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Node: Remove IsSynchronizingSVGAttributesFlag.
<http://webkit.org/b/103328>

Reviewed by Antti Koivisto.

Animated SVG attributes used to be synchronized by using DOM API which could use unwanted re-entrancy
via callbacks below Element::attributeChanged(). The "is synchronizing SVG attributes" flag was used
to protect against such re-entrancy.

These days, lazy attributes are synchronized using Element::setSynchronizedLazyAttribute() to avoid
issues like this. The flag does nothing, so we can just remove it.

  • dom/Node.h:

(WebCore):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::updateAnimatedSVGAttribute):

5:50 PM Changeset in webkit [135792] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Refactor WorkerScriptController
https://bugs.webkit.org/show_bug.cgi?id=103330

Reviewed by Adam Barth.

r135703 just moved methods from WorkerContextExecutionProxy
to WorkerScriptController. We should refactor the methods as a follow-up.

No tests. No change in behavior.

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::disposeContext):
(WebCore::WorkerScriptController::initializeContextIfNeeded):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::disableEval):

  • bindings/v8/WorkerScriptController.h:

(WorkerScriptController):

5:35 PM Changeset in webkit [135791] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL] Unreviewed build fix after r135767 without Tiled Backing Store
https://bugs.webkit.org/show_bug.cgi?id=103320

Unreviewed build fix.

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-26

  • WebProcess/Plugins/Plugin.cpp:
  • WebProcess/Plugins/Plugin.h:

(WebCore):

5:09 PM Changeset in webkit [135790] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

DataLog to a file should work if there are multiple processes using WTF
https://bugs.webkit.org/show_bug.cgi?id=103323

Reviewed by Mark Hahnenberg.

Whereas before DataLog would open a file with the name you specified, now it'll open a file with the
name plus the PID appended to it. So if you are dealing with multiple processes running with DataLog
to a file enabled, you'll get multiple separate log files.

  • wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):

4:56 PM Changeset in webkit [135789] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

LongPress and LongTap gestures should start drag/drop and open context menu respectively.
https://bugs.webkit.org/show_bug.cgi?id=101545

Patch by Varun Jain <varunjain@chromium.org> on 2012-11-26
Reviewed by Antonio Gomes.

For LongPress, we simulate drag by sending a mouse down and mouse drag
events. If a drag is not started (because maybe there is no draggable
element), then we show context menu instead (which is the current
behavior for LongPress). For LongTap, we use the existing functions that
LongPress uses to summon the context menu. LongPress initiated drag and
drop can be enabled/disabled by the platform using the Setting
touchDragDropEnabled which is disabled by default.

Source/WebCore:

Tests: fast/events/touch/gesture/context-menu-on-long-tap.html

fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):
(WebCore::EventHandler::handleGestureLongTap):
(WebCore):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::adjustGesturePosition):
(WebCore::EventHandler::handleDrag):

  • page/EventHandler.h:

(EventHandler):

  • page/Settings.in:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setTouchDragDropEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureLongTap):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setTouchDragDropEnabled):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

LayoutTests:

  • fast/events/touch/gesture/context-menu-on-long-tap.html: Added.
  • fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html: Added.
  • platform/chromium/fast/events/touch/gesture/context-menu-on-long-tap-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag-expected.txt: Added.
  • touchadjustment/touch-links-longpress-expected.txt:
  • touchadjustment/touch-links-longpress.html:
4:41 PM Changeset in webkit [135788] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

RenderStyle: Move 'list-style-image' to rare inherited data.
<http://webkit.org/b/103300>

Reviewed by Antti Koivisto.

list-style-image is not nearly common enough to merit a spot in StyleInheritedData.
Move it to StyleRareInheritedData.

134kB progression on Membuster3.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::listStyleImage):
(WebCore::RenderStyle::setListStyleImage):

  • rendering/style/StyleInheritedData.cpp:

(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):

  • rendering/style/StyleInheritedData.h:

(StyleInheritedData):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareInheritedData.cpp:

(SameSizeAsStyleRareInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

4:39 PM Changeset in webkit [135787] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Add hasTouchEventhandlersAt to WebView API
https://bugs.webkit.org/show_bug.cgi?id=102541

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-11-26
Reviewed by James Robinson.

Adds hasTouchEventHandlersAt to WebWidget API to check for touch event handlers at a
given point. This will be used to distinguish between events not processed by
touch event handlers and event not hitting any touch event handlers. Both are
returning the same ACK message currently. Default implementation returns true to
continue the same behavior as we currently have.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::hasTouchEventHandlersAt):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

4:17 PM Changeset in webkit [135786] by simonjam@chromium.org
  • 40 edits
    1 add in trunk/Source

Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151

Reviewed by Adam Barth.

Source/WebCore:

There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
the refactoring done with CachedResourceRequest and CachedResourceLoader.

No new tests. No change in functionality.

  • WebCore.exp.in:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
(WebCore::FrameLoadRequest::lockHistory): Ditto.
(FrameLoadRequest):
(WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::substituteData): Ditto.
(WebCore::FrameLoadRequest::setSubstituteData): Ditto.
(WebCore::FrameLoadRequest::hasSubstituteData): Ditto.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.

  • loader/FrameLoader.h:

(FrameLoader):

  • page/DragController.cpp:

(WebCore::DragController::performDrag):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

  • Plugins/WebPluginController.mm:
  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAlternateHtml):
(qt_dump_set_accepts_editing):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

  • WebView.cpp:

(WebView::load):

Source/WebKit/wx:

  • WebFrame.cpp:

(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):

3:57 PM Changeset in webkit [135785] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Merged r134327. <rdar://problem/12696109>

3:57 PM Changeset in webkit [135784] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Stop sending touch events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=103188

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-24
Reviewed by Rob Buis.

Reviewed internally by Jeff Rogers and Mike Lattanzio.
No tests required.
PR #248605

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleTouchEvent):
(WebCore::PluginView::handleMouseEvent):

3:53 PM Changeset in webkit [135783] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping some compositing/tiling tests on Windows because tiled backing is not supported.
Tests skipped:
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/rotated-tiled-clamped.html

  • platform/win/TestExpectations:
3:49 PM Changeset in webkit [135782] by Lucas Forschler
  • 22 edits
    7 copies in branches/safari-536.28-branch

Merged r133834. <rdar://problem/12660677>

3:45 PM Changeset in webkit [135781] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: css3/filters/custom/custom-filter-transforms-animation.html
times out intermittently.
https://bugs.webkit.org/show_bug.cgi?id=103308

  • platform/chromium/TestExpectations:
3:38 PM Changeset in webkit [135780] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: failure in fast/text/atsui-small-caps-punctuation-size.html
https://bugs.webkit.org/show_bug.cgi?id=103148

  • platform/chromium/TestExpectations:
3:27 PM Changeset in webkit [135779] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=103164

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-11-26
Reviewed by Simon Fraser.

Removing some of classes marked as friend of RenderObject. This patch solves this issue
for 2 classes: RenderSVGContainer (that is derived from RenderObject) and LayoutRepainter
(that accesses one const member function in RenderObject that is now made public).

No new tests, no changes in functionality.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::outlineBoundsForRepaint):

3:18 PM Changeset in webkit [135778] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: failure in http/tests/media/pdf-served-as-pdf.html
https://bugs.webkit.org/show_bug.cgi?id=103093

  • platform/chromium/TestExpectations:
3:12 PM Changeset in webkit [135777] by Simon Fraser
  • 4 edits in branches/safari-536.28-branch/Source/WebCore

<rdar://problem/12751360>
Merge r135746

2012-11-26 Simon Fraser <Simon Fraser>

Optimize layer updates after scrolling
https://bugs.webkit.org/show_bug.cgi?id=102635

Reviewed by Sam Weinig.

updateLayerPositionsAfterScroll() previously unconditionally cleared clip
rects, and recomputed repaint rects too often. Recomputing both of these
can be very expensive, as they involve tree walks up to the root.

We can optimize layer updates after document scrolling by only clearing clip
rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position
element. For overflow scroll, we have to clear clip rects and recompute repaint rects.

  • page/FrameView.cpp: (WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll().
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because updateLayerPosition() no longer does. (WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll() that is for document scrolls. It has no need to push layers to the geometry map. (WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map, and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag. (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag if our location changed, and use that as a hint to clear cached rects. Be more conservative than before about when to clear cached clip rects. (WebCore::RenderLayer::updateLayerPosition): Move responsibility for calling clearClipRects() ouf of this function and into callers. (The one caller outside RenderLayer will be removed via bug 102624). Return a bool indicating whether our position changed. (WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterOverflowScroll(). (WebCore::RenderLayer::updateClipRects): Added some #ifdeffed out code that is useful to verify that cached clips are correct; it's too slow to leave enabled in debug builds.
  • rendering/RenderLayer.h: (WebCore::RenderLayer::setLocation): Change to take a LayoutPoint, rather than separate x and y.
3:12 PM Changeset in webkit [135776] by Simon Fraser
  • 12 edits in branches/safari-536.28-branch/Source/WebCore

<rdar://problem/12753059>
Merge r135025

2012-11-12 Simon Fraser <Simon Fraser>

Eliminate ancestor tree walk computing outlineBoundsForRepaint() when updating layer positions
https://bugs.webkit.org/show_bug.cgi?id=101874

Reviewed by Dave Hyatt.

RenderLayer::updateLayerPositions() and updateLayerPositionsAfterScroll() spend a
lot of time in computeRepaintRects(), which does two ancestor tree walks, once
for clippedOverflowRectForRepaint(), and one for outlineBoundsForRepaint().

Eliminate the ancestor tree walk in outlineBoundsForRepaint() by maintaining
a RenderGeometryMap as we traverse the layer tree, and then using it to map
the outline bounds to the repaint container. Replace the hokey cached offsetFromRoot
now that the RenderGeometryMap can do a better job.

The clipped overflow rect cannot be mapped simply, so cannot yet make use of
the geometry map.

Modify the RenderGeometryMap to support mapping to some repaintContainer ancestor.
Add a RenderObject walk that is necessary to detect flipped writing mode blocks.

Pass the RenderGeometryMap as an optional parameter to outlineBoundsForRepaint.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Make a RenderGeometryMap and pass it down to updateLayerPositions(). For partial layouts, we have to push layers between the root and the enclosing layer of the layout subtree. The geometry map used for repainting does not use SnapOffsetForTransforms, so initialize it explicitly with just the UseTransforms flag. (WebCore::FrameView::repaintFixedElementsAfterScrolling): Make a RenderGeometryMap to pass along to updateLayerPositionsAfterScroll().
  • rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint): Replace the optional cachedOffsetToRepaintContainer parameter with an optional RenderGeometryMap, and it use to map the compute rect to repaintContainer coordinates.
  • rendering/RenderBox.h:
  • rendering/RenderGeometryMap.cpp: (WebCore::RenderGeometryMap::RenderGeometryMap): This now has to store the mapping flags to use, so that its behavior can match that of mapLocalToContainer(). The pertinent flag is the confusingly named SnapOffsetForTransforms. (WebCore::RenderGeometryMap::absolutePoint): Call the new mapToContainer() with a null container. (WebCore::RenderGeometryMap::absoluteRect): Ditto. (WebCore::RenderGeometryMap::mapToContainer): Map to the supplied container, asserting that we found it. Add point- and rect-based mapping methods akin to the old absoluteRect/absolutePoint. (WebCore::canMapViaLayer): We need to test for isRenderFlowThread() here too. (WebCore::RenderGeometryMap::pushMappingsToAncestor): When mapping via layers, ensure that the RenderView is pushed as the first step.
  • rendering/RenderGeometryMap.h: (RenderGeometryMap):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositionsAfterLayout): New wrapper for updateLayerPositions() that makes the geometry map. (WebCore::RenderLayer::updateLayerPositionsAfterScroll): New wrapper for updateLayerPositionsAfterScroll that makes the geometry map. (WebCore::RenderLayer::updateLayerPositions): Now takes an optional RenderGeometryMap. Remove the old offsetFromRoot code. Push and pop layers to/from the geometry map. Use the geometry map to get the offsetFromRoot as needed by overflow controls. Pass it to computeRepaintRects(). (WebCore::RenderLayer::computeRepaintRects): Pass the geometry map to outlineBoundsForRepaint(). (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Push and pop to/from the geometry map, and pass it to computeRepaintRects(). (WebCore::RenderLayer::removeOnlyThisLayer): Remove the offsetFromRootBeforeMove computation; this could use a geometry map in future if it is shown to be a bottleneck.
  • rendering/RenderLayer.h: (WebCore::RenderLayer::canUseConvertToLayerCoords): It was thought that the isComposited() was there because the older cached offsetFromRoot logic was sensitive to compositing, but convertToLayerCoords() is not affected by compositing so this check is not needed, and actually harmful.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::OverlapMap::OverlapMap): The geometry map used for overlap testing should not use SnapOffsetForTransforms, so initialize it explicitly with just the UseTransforms flag.
  • rendering/RenderObject.h: (WebCore::RenderObject::outlineBoundsForRepaint):
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
  • rendering/svg/RenderSVGModelObject.h: (RenderSVGModelObject):
3:07 PM Changeset in webkit [135775] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Form controls don't show pressed state.
https://bugs.webkit.org/show_bug.cgi?id=103292

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-26
Reviewed by Rob Buis.

Reviewed internally by Eli Fidler and Mike Lattanzio.
We weren't sending touch events to webpages unless they
had JS touch event listeners which form controls don't have.
Now send them always and do a little cleanup.
PR #249791

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::needTouchEvents):

3:02 PM Changeset in webkit [135774] by tony@chromium.org
  • 4 edits in branches/chromium/1312/Source

Merge 135316 - When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
https://bugs.webkit.org/show_bug.cgi?id=102835

Reviewed by Ojan Vafai.

After r135082, Chromium browser_tests were triggering the ASSERT in
StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
trigger earlier and make it clear in the Chromium code that we're always
inserting user level styles.

Source/WebCore:

No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
in Chromium browser_tests.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::addUserSheet):

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/11412177

3:01 PM Changeset in webkit [135773] by tony@chromium.org
  • 10 edits
    2 copies in branches/chromium/1312

Merge 135082 - REGRESSION(r129644): User StyleSheet not applying
https://bugs.webkit.org/show_bug.cgi?id=102110

Reviewed by Andreas Kling.

Source/WebCore:

Injected stylesheets added as UserStyleAuthorLevel fail to apply. r129644 implicitly assumed that
such things don't exists but on Chromium addUserStyleSheet() confusingly uses them.

The patch adds injected author stylesheets to DocumentStyleSheetCollection::activeStyleSheets().
It also generally cleans up the code around injected and user stylesheets.

Tests: userscripts/user-script-and-stylesheet.html

userscripts/user-stylesheet-invalidate.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/Document.cpp:

(WebCore::Document::setCompatibilityMode):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets):
(WebCore):
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets):
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):
(DocumentStyleSheetCollection):

  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):
(WebCore::PageGroup::invalidatedInjectedStyleSheetCacheInAllFrames):

  • page/PageGroup.h:

(PageGroup):

LayoutTests:

  • inspector/timeline/timeline-script-tag-1-expected.txt:

Update the test result. The style invalidation log is slightly different.

  • userscripts/user-stylesheet-invalidate-expected.txt: Added.
  • userscripts/user-stylesheet-invalidate.html: Added.

TBR=Antti Koivisto
Review URL: https://codereview.chromium.org/11412176

3:01 PM Changeset in webkit [135772] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: updated TextExpecations for failing
fast/dom/shadow/shadow-dom-event-dispatching.html
https://bugs.webkit.org/show_bug.cgi?id=103299

  • platform/chromium/TestExpectations:
2:52 PM Changeset in webkit [135771] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip fast/dom/Window/open-window-min-size.html on Windows.
DRT doesn't support showModalDialog https://bugs.webkit.org/show_bug.cgi?id=53675

  • platform/win/TestExpectations:
2:45 PM Changeset in webkit [135770] by zeno.albisser@digia.com
  • 6 edits in trunk/Source

[Qt] Fix the LLInt build on Mac
https://bugs.webkit.org/show_bug.cgi?id=97587

Reviewed by Simon Hausmann.

Source/JavaScriptCore:

Source/WTF:

  • wtf/InlineASM.h:

Use OS(DARWIN) instead of PLATFORM(MAC),
in order to allow Qt to use the same code.

  • wtf/Platform.h:
2:43 PM Changeset in webkit [135769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

  • DEPS:
2:37 PM Changeset in webkit [135768] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r131975. <rdar://problem/12589198>

2:36 PM Changeset in webkit [135767] by jonlee@apple.com
  • 15 edits in trunk/Source

Pass clicks through to the restarted plugin
https://bugs.webkit.org/show_bug.cgi?id=102150
<rdar://problem/12695575>

Reviewed by Simon Fraser.

Source/WebCore:

Add a new state to the machine for plugin snapshotting, called PlayingWithPendingMouseClick.
This represents the state where the plugin is playing, but before the pending mouse click
has been fired. Once the click is sent, the plugin state transitions to Playing. For
situations where the plugin just runs normally without a simulated click, the plugin state
jumps from DisplayingSnapshot straight to Playing, as before.

  • html/HTMLPlugInElement.h: Add new display state to represent when the plugin is running,

but a pending mouse click is about to be sent to the plugin.
(WebCore::HTMLPlugInElement::dispatchPendingMouseClick): Called by the plugin when it is
ok for the element to send the pending mouse click.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Update the handler to pass the event
to the renderer to handle if the state is before PlayingWithPendingMouseClick.

  • html/HTMLPlugInImageElement.h:
  • html/HTMLPlugInImageElement.cpp: Add a click timer to delay the mouse click so that the

plugin has some time to initialize.
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialize the mouse timer.
(WebCore::HTMLPlugInImageElement::setPendingClickEvent): Keep track of the click event
the user made to restart the plugin.
(WebCore::HTMLPlugInImageElement::dispatchPendingMouseClick): Start the timer.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): When the timer fires,
dispatch the simulated click, with mouse over, mouse down, and mouse up events. Transition
to the Playing state, and we no longer need the click event.

  • rendering/RenderSnapshottedPlugIn.cpp: Change the threshold state to PlayingWithPendingMouseClick

instead of Playing, since that is the earliest state where the plugin is playing.
(WebCore::RenderSnapshottedPlugIn::paint):
(WebCore::RenderSnapshottedPlugIn::paintReplaced):
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): If the user clicked on the button, jump to
Playing, and don't send a simulated click. Otherwise, transition to PlayingWithPendingMouseClick,
and keep track of that mouse event.

  • WebCore.exp.in: Export MouseRelatedEvent::offsetX() and offsetY().

Source/WebKit2:

Expose convertToRootView() as a public function for all plugins. It converts the click point
from local plugin coordinates to root view coordinates. When the events are sent to the
plugin, the coordinate gets converted back to the local reference frame.

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::convertToRootView): Default implementation should not be reached.

  • WebProcess/Plugins/Plugin.h: Promote convertToRootView() from NetscapePlugin.h.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: An implementation already existed. Make the

method virtual.

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::convertToRootView): Apply the transform to the provided point to return
a point in root view coordinates.

Change the threshold state to PlayingWithPendingMouseClick instead of Playing, since that is
the earliest state where the plugin is playing.

  • WebProcess/Plugins/PluginView.cpp: Give the snapshot a little more time to generate.

(WebKit::PluginView::didInitializePlugin): When the plugin has initialized, tell the plugin
element to dispatch the pending mouse click.
(WebKit::PluginView::paint):
(WebKit::PluginView::createWebEvent): Helper function to convert a WebCore mouse event to a
WebMouseEvent.
(WebKit::PluginView::handleEvent): If the event is simulated, there is no source event from
the UI process. So we fabricate one based on the simulated event.
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::isAcceleratedCompositingEnabled):

  • WebProcess/Plugins/PluginView.h:
2:34 PM Changeset in webkit [135766] by roger_fong@apple.com
  • 4 edits in trunk

Unreviewed. ENABLE_ACCELERATED_OVERFLOW_SCROLLING not enabled on Windows.
Add a feature flag and skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=103294

Tests skipped:
compositing/overflow/scrolling-without-painting.html
compositing/overflow/updating-scrolling-content.html

  • win/tools/vsprops/FeatureDefines.vsprops:
  • platform/win/TestExpectations:
2:24 PM Changeset in webkit [135765] by commit-queue@webkit.org
  • 7 edits in trunk

Refactor V8 bindings to allow content scripts to access subframes
https://bugs.webkit.org/show_bug.cgi?id=93646

Patch by Dan Carney <dcarney@google.com> on 2012-11-26
Reviewed by Adam Barth.

Source/WebCore:

Isolated window shells are now initialized on the fly
as needed.

No new tests. Existing test modified.

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::ensureIsolatedWorld):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::createdFromUnitializedWorld):
(DOMWrapperWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::currentWorldContext):

LayoutTests:

Test modified to check isolated world access across frames.

  • http/tests/security/isolatedWorld/world-reuse-expected.txt:
  • http/tests/security/isolatedWorld/world-reuse.html:
2:15 PM Changeset in webkit [135764] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-536.28-branch

Merged r132924. <rdar://problem/12603373>

2:11 PM Changeset in webkit [135763] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

clipboardwin compile error for win64
https://bugs.webkit.org/show_bug.cgi?id=94124

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-11-26
Reviewed by Brent Fulgham.

The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter.
This causes a problem when compiling for 64-bit Windows because the two types are not the same size.
To resolve this issue, we specify the template type as the type the return value is being cast into

Fixed a few compile errors for Windows x64 by specifying template parameters.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::setFileDescriptorData): Specify the types for the std::min macro to avoid compiler errors
under 64-bit builds.

2:01 PM Changeset in webkit [135762] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] GtkSocket is leaked until webview is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=102564

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-11-26
Reviewed by Martin Robinson.

Remove GtkSocket from its parent when pluginview is destroyed. Then,
the GtkSocket and it's possible child widgets are realeased when it is
no more needed.

No new tests, already covered by existing tests.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::platformDestroy):

2:00 PM Changeset in webkit [135761] by mrobinson@webkit.org
  • 4 edits in trunk

[GTK] Explicitly link against librt
https://bugs.webkit.org/show_bug.cgi?id=103194

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-11-26
Reviewed by Martin Robinson.

Fixes broken build with undefined references to shm_open / shm_unlink
symbols. SharedMemoryUnix.cpp uses these so we need to link with -lrt.

.:

  • configure.ac:

Source/WebKit2:

  • GNUmakefile.am:
1:44 PM Changeset in webkit [135760] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place.
https://bugs.webkit.org/show_bug.cgi?id=102446

Reviewed by Tony Chang.

!m_parentNode
!value->isInheritedValue() is equivalent to !isInherit (by De Morgan's law).

No new tests / code is provably equivalent.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

1:41 PM Changeset in webkit [135759] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit build fix. Move the method decalration outside of the X86_64 only section.

1:38 PM Changeset in webkit [135758] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Null check calls associated with retrieving the caret rect.
https://bugs.webkit.org/show_bug.cgi?id=103281

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-26
Reviewed by Rob Buis.

Some of these calls can return null, which could lead to a crash.

Internally reviewed by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

1:20 PM Changeset in webkit [135757] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't blind all the things.
https://bugs.webkit.org/show_bug.cgi?id=102572

Reviewed by Gavin Barraclough.

No longer blind all the constants in the instruction stream. We use a
simple non-deterministic filter to avoid blinding everything. Also modified
the basic integer blinding logic to avoid blinding small negative values.

  • assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::shouldConsiderBlinding):
(JSC::MacroAssembler::shouldBlind):

1:00 PM Changeset in webkit [135756] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSObject::copyButterfly doesn't handle undecided indexing types correctly
https://bugs.webkit.org/show_bug.cgi?id=102573

Reviewed by Filip Pizlo.

We don't do any copying into the newly allocated vector and we don't zero-initialize CopiedBlocks
during the copying phase, so we end up with uninitialized memory in arrays which have undecided indexing
types. We should just do the actual memcpy from the old block to the new one.

  • runtime/JSObject.cpp:

(JSC::JSObject::copyButterfly): Just do the same thing that we do for other contiguous indexing types.

12:49 PM Changeset in webkit [135755] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=102706

Reviewed by Brent Fulgham.

No new tests because the flag isn't enabled. Also the functionality should be covered by
existing tests.

  • loader/ResourceBuffer.cpp:

(WebCore):
(WebCore::ResourceBuffer::append):

  • loader/ResourceBuffer.h:

(ResourceBuffer):

  • loader/mac/ResourceLoaderMac.mm:
12:37 PM Changeset in webkit [135754] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r135743.
http://trac.webkit.org/changeset/135743
https://bugs.webkit.org/show_bug.cgi?id=103280

Caused compile failure 'SK_DISABLE_DITHER_32BIT_GRADIENT'
macro redefined (Requested by rjkroege on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

  • skia_webkit.gyp:
12:27 PM Changeset in webkit [135753] by tony@chromium.org
  • 9 edits in trunk

Move more functions from internals.settings to internals
https://bugs.webkit.org/show_bug.cgi?id=102976

Reviewed by Adam Barth.

Source/WebCore:

Move functions that don't have to do with Settings off of internals.settings.
setPagination and configurationForViewport were defined on internals, so we
can inline the functions (no test change).

setEnableMockPagePopup is moved to Internals.

No new tests, this is a refactor.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::reset): Move reset code into Internals.

  • testing/InternalSettings.h:

(InternalSettings): Remove code for setPagination, configurationForViewport and setEnableMockPagePopup.

  • testing/InternalSettings.idl: Remove setPagination and setEnableMockPagePopup.
  • testing/Internals.cpp:

(WebCore): Use a static to keep track of the MockPagePopupDriver.
(WebCore::Internals::resetToConsistentState): Code from InternalSettings::reset
(WebCore::Internals::setEnableMockPagePopup): Code copied from InternalSettings.
(WebCore::Internals::pagePopupController): Code copied from InternalSettings.
(WebCore::Internals::setPagination): Code copied from InternalSettings.
(WebCore::Internals::configurationForViewport): Code copied from InternalSettings.

  • testing/Internals.h:

(Internals): Add setEnableMockPagePopup.

  • testing/Internals.idl: Add setEnableMockPagePopup.

LayoutTests:

Move internals.settings.setEnableMockPagePopup to internals.setEnableMockPagePopup.

  • fast/forms/resources/picker-common.js:
12:17 PM Changeset in webkit [135752] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
https://bugs.webkit.org/show_bug.cgi?id=103224

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-26
Reviewed by Laszlo Gombos.

Source/WebKit2:

Add API to ewk_settings to enable / disable the HTML5
local storage functionality. The functionality is
enabled by default.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F): Add API test for ewk_settings_local_storage_enabled_get / set.

Tools:

Add --local-storage command line argument to MiniBrowser to
explicitely disable HTML5 local storage functionality. This
is useful for testing purposes.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

12:02 PM Changeset in webkit [135751] by Lucas Forschler
  • 12 edits
    3 copies in branches/safari-536.28-branch

Merged r132713. <rdar://problem/12589195>

12:00 PM Changeset in webkit [135750] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
https://bugs.webkit.org/show_bug.cgi?id=101332

Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-26
Reviewed by David Hyatt.

Source/WebCore:

Currently the pagination information for lines is spread between the RootInlineBox and InlineFlowBox classes, consuming memory even though
the boxes were not the result of an pagination layout. To overcome this, a new struct (LineFragmentationData) is created that wraps all the data,
including two new members, the containing Region for the line and a boolean that states if the line was laid out in a Region or not.
The flag is necessary because the sanitize function on LineFragmentationData resets the containing Region to 0 if the Region was removed from
chain (so a value of 0 for the containing Region means two things). The sanitize function should prevent access to an invalid address.
The containing Region is used to detect if a line changed the Region where it resides. This will be helpful especially when implementing region
styling for layout properties (e.g. the font-size property https://bugs.webkit.org/show_bug.cgi?id=95559 ).
A line can change the region when it is shifted inside the containing block or if the entire block moves. This means it's better to delegate
the task of updating the containing Region to the block.

Tests: fast/regions/line-containing-region-crash.html

  • rendering/InlineFlowBox.cpp:

(SameSizeAsInlineFlowBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(InlineFlowBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore):
(WebCore::RootInlineBox::LineFragmentationData::sanitize): This is an O(1) function that checks if the containig Region is still valid pointer.

  • rendering/RootInlineBox.h:

(WebCore):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
(WebCore::RootInlineBox::isFirstAfterPageBreak):
(WebCore::RootInlineBox::setIsFirstAfterPageBreak):
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
(RootInlineBox):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::hasContainingRegion): Use this to determine if the line has a region or not.
(WebCore::RootInlineBox::ensureLineFragmentationData):
(LineFragmentationData):
(WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData):

LayoutTests:

The test checks if there is a crash when doing a line layout if:

  • the flow has no region
  • the flow has a region but the lines have no containing region
  • the flow has no region but the lines have a containing region
  • fast/regions/line-containing-region-crash-expected.txt: Added.
  • fast/regions/line-containing-region-crash.html: Added.
11:57 AM Changeset in webkit [135749] by Michelangelo De Simone
  • 19 edits
    5 adds in trunk

[CSS Shaders] Add IDL file and bindings for mix function
https://bugs.webkit.org/show_bug.cgi?id=93011

Reviewed by Dean Jackson.

Source/WebCore:

JavaScript bindings have been added for the Custom Filter mix()
function (WebKitCSSMixFunctionValue). As of now, this is only a
placeholder that extends CSSValueList without adding any new
property.

Test: css3/filters/custom/custom-filter-mix-bindings.html

  • CMakeLists.txt: mix() IDL has been added to the Generator;

DerivedSources have been included.

  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS): return a JSC DOM wrapper for WebKitCSSMixFunctionValue.

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::V8CSSValue::dispatchWrapCustom): Ditto, for V8.

  • css/WebKitCSSMixFunctionValue.idl: Added.

LayoutTests:

Test for the Custom Filter mix() function JS bindings.

  • css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added.
  • css3/filters/custom/custom-filter-mix-bindings.html: Added.
  • css3/filters/script-tests/custom-filter-mix-bindings.js: Added.

(jsWrapperClass):
(shouldBeType):

  • platform/chromium/css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added.
  • platform/efl/fast/js/global-constructors-expected.txt: Updated with the new WebKitCSSMixFunctionValueConstructor.
  • platform/gtk/fast/js/global-constructors-expected.txt: Ditto.
  • platform/mac/fast/js/global-constructors-expected.txt: Ditto.
  • platform/qt-5.0/fast/js/global-constructors-expected.txt: Ditto.
  • platform/qt/fast/js/global-constructors-expected.txt: Ditto.
  • platform/win/fast/js/global-constructors-expected.txt: Ditto.
11:45 AM Changeset in webkit [135748] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Access to LayerTreeRenderer::m_renderQueue should be thread safe
https://bugs.webkit.org/show_bug.cgi?id=101341

Reviewed by Noam Rosenthal.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::syncRemoteContent): The previous swap already clears the
vector on m_renderQueue. It is also done in a thread-safe way, so clearing it afterward
can be harmful as we've already released the lock.

11:42 AM Changeset in webkit [135747] by kareng@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/dom/Document.cpp

Merge 135709 - Circular reference between Document and MediaQueryMatcher.
https://bugs.webkit.org/show_bug.cgi?id=103242

Patch by Marja Hölttä <marja@chromium.org> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

It's not enough to clean up listeners in MediaQueryMatcher in ~Document,
since MediaQueryListListener keeps the Document alive. This caused
www.crbug.com/113983.

No new tests: No visible change in behavior (except that it doesn't leak memory).

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11415134

11:37 AM Changeset in webkit [135746] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Optimize layer updates after scrolling
https://bugs.webkit.org/show_bug.cgi?id=102635

Reviewed by Sam Weinig.

updateLayerPositionsAfterScroll() previously unconditionally cleared clip
rects, and recomputed repaint rects too often. Recomputing both of these
can be very expensive, as they involve tree walks up to the root.

We can optimize layer updates after document scrolling by only clearing clip
rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position
element. For overflow scroll, we have to clear clip rects and recompute repaint rects.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll().

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because
updateLayerPosition() no longer does.
(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll()
that is for document scrolls. It has no need to push layers to the geometry map.
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map,
and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag.
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag
if our location changed, and use that as a hint to clear cached rects. Be more conservative
than before about when to clear cached clip rects.
(WebCore::RenderLayer::updateLayerPosition): Move responsibility for calling
clearClipRects() ouf of this function and into callers.
(The one caller outside RenderLayer will be removed via bug 102624).
Return a bool indicating whether our position changed.
(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterOverflowScroll().
(WebCore::RenderLayer::updateClipRects): Added some #ifdeffed out code that is useful
to verify that cached clips are correct; it's too slow to leave enabled in debug builds.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::setLocation): Change to take a LayoutPoint, rather than separate
x and y.

11:37 AM Changeset in webkit [135745] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] JavaScriptCore JIT build is broken since r135330
Add missing implementation for sh4 arch.
https://bugs.webkit.org/show_bug.cgi?id=103145

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-26
Reviewed by Oliver Hunt.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerSH4::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerSH4::revertJumpReplacementToPatchableBranchPtrWithPatch):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::revertJump):
(SH4Assembler):
(JSC::SH4Assembler::printInstr):

11:31 AM Changeset in webkit [135744] by zandobersek@gmail.com
  • 51 edits in trunk/Tools

Remove use of deprecated logging from most of webkitpy.tool
https://bugs.webkit.org/show_bug.cgi?id=103180

Reviewed by Dirk Pranke.

Remove calls to log and error methods of the deprecated_logging module, replacing them
by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
except the QueueEngine.

Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.run_command):
(MockCommitQueue.command_passed):
(MockCommitQueue.command_failed):
(MockCommitQueue.report_flaky_tests):
(MockCommitQueue.archive_last_test_results):
(CommitQueueTaskTest._run_through_task):
(CommitQueueTaskTest.test_success_case):
(test_fast_success_case):
(test_clean_failure):
(test_update_failure):
(test_apply_failure):
(test_validate_changelog_failure):
(test_build_failure):
(test_red_build_failure):
(test_flaky_test_failure):
(test_failed_archive):
(test_double_flaky_test_failure):
(test_test_failure):
(test_red_test_failure):
(test_very_red_tree_retry):
(test_red_tree_patch_rejection):
(test_land_failure):

  • Scripts/webkitpy/tool/bot/feeders.py:

(CommitQueueFeeder._update_work_items):
(EWSFeeder.feed):

  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader.archive):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(test_archive_last_layout_test_results):

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand.execute):

  • Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

  • Scripts/webkitpy/tool/commands/download.py:

(AbstractPatchProcessingCommand._process_patch.execute):
(ProcessBugsMixin._fetch_list_of_patches_to_process):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
(AbstractRolloutPrepCommand._commit_info):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(AbstractRolloutPrepCommandTest.test_commit_info):
(DownloadCommandsTest.test_build):
(DownloadCommandsTest.test_build_and_test):
(test_apply_attachment):
(test_apply_from_bug):
(test_apply_watch_list):
(test_land):
(test_land_red_builders):
(test_check_style):
(test_build_attachment):
(test_land_attachment):
(test_land_from_bug):
(test_land_from_url):
(test_prepare_rollout):
(test_create_rollout):
(test_create_rollout_resolved):
(test_rollout):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.handle_script_error.does):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._default_expected_stderr):
(EarlyWarningSytemTest._default_expected_logs):
(EarlyWarningSytemTest._test_testing_ews):

  • Scripts/webkitpy/tool/commands/openbugs.py:

(OpenBugs.execute):

  • Scripts/webkitpy/tool/commands/openbugs_unittest.py:

(OpenBugsTest.test_args_parsing):

  • Scripts/webkitpy/tool/commands/perfalizer.py:

(Perfalizer.handle_unexpected_error):

  • Scripts/webkitpy/tool/commands/queries.py:

(PatchesInCommitQueue.execute):
(PatchesToCommitQueue._needs_commit_queue):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(QueryCommandsTest.test_bugs_to_commit):
(QueryCommandsTest.test_patches_in_commit_queue):
(QueryCommandsTest.test_patches_to_commit_queue):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue._cc_watchers):
(AbstractQueue.begin_work_queue):
(FeederQueue.handle_unexpected_error):
(CommitQueue.handle_script_error):
(AbstractReviewQueue.handle_unexpected_error):
(AbstractReviewQueue.handle_script_error):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(test_auto_retry):

  • Scripts/webkitpy/tool/commands/queuestest.py:

(QueuesTest.assert_outputs):
(QueuesTest._default_begin_work_queue_stderr):
(QueuesTest):
(QueuesTest._default_begin_work_queue_logs):
(QueuesTest.assert_queue_outputs):

  • Scripts/webkitpy/tool/commands/roll_unittest.py:

(RollCommandsTest.test_update_chromium_deps):
(test_update_chromium_deps_older_revision):

  • Scripts/webkitpy/tool/commands/sheriffbot.py:

(SheriffBot.handle_unexpected_error):

  • Scripts/webkitpy/tool/commands/stepsequence.py:

(StepSequence.run_and_handle_errors):

  • Scripts/webkitpy/tool/commands/upload.py:

(AssignToCommitter._assign_bug_to_last_patch_attacher):
(AbstractPatchUploadingCommand._prepare_state):
(PostCommits.execute):
(MarkBugFixed._determine_bug_id_and_svn_revision):
(MarkBugFixed.execute):
(CreateBug.create_bug_from_commit):
(CreateBug.execute):

  • Scripts/webkitpy/tool/commands/upload_unittest.py:

(test_obsolete_attachments):
(test_land_safely):
(test_mark_bug_fixed):

  • Scripts/webkitpy/tool/multicommandtool.py:

(Command.check_arguments_and_execute):
(MultiCommandTool.main):

  • Scripts/webkitpy/tool/multicommandtool_unittest.py:

(CommandTest.test_required_arguments):

  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:

(AddSvnMimetypeForPng.run):

  • Scripts/webkitpy/tool/steps/applypatch.py:

(ApplyPatch.run):

  • Scripts/webkitpy/tool/steps/build.py:

(Build.run):

  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/closebug.py:

(CloseBug.run):

  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:

(CloseBugForLandDiff.run):

  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest.test_empty_state):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit.run):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations):

  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:

(EnsureLocalCommitIfNeeded.run):

  • Scripts/webkitpy/tool/steps/obsoletepatches.py:

(ObsoletePatches.run):

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.run):

  • Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:

(ReopenBugAfterRollout.run):

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_update_step):
(StepsTest.test_runtests_args):

  • Scripts/webkitpy/tool/steps/update.py:

(Update.run):

  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:

(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):

  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:

(UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
(UpdateChangeLogsWithReviewer.run):

  • Scripts/webkitpy/tool/steps/updatechromiumdeps.py:

(UpdateChromiumDEPS._validate_revisions):
(UpdateChromiumDEPS.run):

  • Scripts/webkitpy/tool/steps/validatechangelogs.py:

(ValidateChangeLogs._check_changelog_diff):
(ValidateChangeLogs.run):

  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:

(ValidateChangeLogsTest._assert_start_line_produces_output):

  • Scripts/webkitpy/tool/steps/validatereviewer.py:

(ValidateReviewer.run):

11:27 AM Changeset in webkit [135743] by reed@google.com
  • 2 edits in trunk/Source/WebKit/chromium

add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
https://bugs.webkit.org/show_bug.cgi?id=103272

Reviewed by NOBODY. Unreviewed.

No behavior change, as this define already exists on the chrome side in SkUserConfig.h

  • skia_webkit.gyp:
11:12 AM Changeset in webkit [135742] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Cairo] Surface should not be destroyed before its usage
https://bugs.webkit.org/show_bug.cgi?id=103273

Reviewed by Brent Fulgham.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawRepaintCounter): There's some calls to get
the bits and stride from surface right after its destructions. It should
be postponed to avoid annoying bugs.

11:07 AM Changeset in webkit [135741] by jchaffraix@webkit.org
  • 3 edits
    4 adds in trunk

RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent
https://bugs.webkit.org/show_bug.cgi?id=103075

Reviewed by Ojan Vafai.

Source/WebCore:

Using the containing block's content logical block was working for most renderers but 2 renderers
were special and were broken in orthogonal writing modes:

  • captions as they override containingBlockLogicalWidthForContent to return the table's logical width.
  • multi-column renderers as they override availableLogicalWidth to constrain the child to the column logical width.

By switching to containingBlockLogicalWidthForContent, we got those 2 cases covered.

Tests: fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html

fast/table/caption-orthogonal-writing-mode-sizing.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Updated the function to track which renderer's containing block we use and call
containingBlockLogicalWidthForContent on it.

LayoutTests:

  • fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt: Added.
  • fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html: Added.
  • fast/table/caption-orthogonal-writing-mode-sizing-expected.txt: Added.
  • fast/table/caption-orthogonal-writing-mode-sizing.html: Added.
10:58 AM Changeset in webkit [135740] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in Frame::dispatchVisibilityStateChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=102053

Reviewed by Adam Barth.

Source/WebCore:

Child frame can go away inside webkitvisibilitychange
event handler. Store it in a ref counted vector.

Test: fast/frames/page-visibility-crash.html

  • page/Frame.cpp:

(WebCore::Frame::dispatchVisibilityStateChangeEvent):

LayoutTests:

  • fast/frames/page-visibility-crash-expected.txt: Added.
  • fast/frames/page-visibility-crash.html: Added.
10:56 AM Changeset in webkit [135739] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Coverage testing in webkitpy should omit some paths
https://bugs.webkit.org/show_bug.cgi?id=103267

Reviewed by Dirk Pranke.

Omit testing coverage of any file under /usr directory and any file
that is of third party origin and was autoinstalled.

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

10:54 AM Changeset in webkit [135738] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Use load64 instead of loadPtr to load a JSValue on JSVALUE64 platforms
https://bugs.webkit.org/show_bug.cgi?id=100909

Reviewed by Brent Fulgham.

This is a (trivial) fix after r132701.

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

10:49 AM Changeset in webkit [135737] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] fillRectWithColor with Color::transparent doesn't perform anything
https://bugs.webkit.org/show_bug.cgi?id=101911

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

fillRectWithColor with Color::transparent doesn't perform anything
because fillRectWithColor does early-return if the alpha value of
color is zero. But we expect that fill the rect with transparent color
in case the cairo_operator is CAIRO_OPERATOR_SOURCE.

Covered by existing tests.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::fillRectWithColor):Add condition to prevent early-return if
cairo_operator is not CAIRO_OPERATOR_OVER

10:47 AM Changeset in webkit [135736] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r135735.
http://trac.webkit.org/changeset/135735
https://bugs.webkit.org/show_bug.cgi?id=103270

Caused breakage across the Chromium tree. (Requested by
rjkroege_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

  • skia_webkit.gyp:
9:43 AM Changeset in webkit [135735] by reed@google.com
  • 2 edits in trunk/Source/WebKit/chromium

add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
https://bugs.webkit.org/show_bug.cgi?id=103269

Reviewed by NOBODY. Unreviewed.

No behavior change, as this define already exists on the chrome side in SkUserConfig.h

  • skia_webkit.gyp:
9:33 AM Changeset in webkit [135734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove redundant assignment in TextureMapperLayer::flushCompositingStateSelf
https://bugs.webkit.org/show_bug.cgi?id=103233

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-11-26
Reviewed by Noam Rosenthal.

This patch removes redundant assignment in TextureMapperLayer::flushCompositingStateSelf.

No new tests, because no change in bahavior.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingStateSelf):

9:18 AM Changeset in webkit [135733] by commit-queue@webkit.org
  • 8 edits
    7 adds in trunk/Source/WebCore

OpenCL version of SourceAlpha, SourceGraphics and FETurbulence filter effects
https://bugs.webkit.org/show_bug.cgi?id=99829

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2012-11-26
Reviewed by Zoltan Herczeg.

This patch contains the OpenCL implementation of SourceAlpha, SourceGraphic, FETurbulence and a simple OpenCL environment.
At the moment only the Qt build system is supported
~3x speed-up (depending on hardware configuration)

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/filters/FETurbulence.h: Added platformApplyOpenCL() virtual function.

(FETurbulence):

  • platform/graphics/filters/FilterEffect.cpp: Added platform specific apply.

(WebCore::FilterEffect::apply):
(WebCore):
(WebCore::FilterEffect::platformApplyOpenCL): A function to use software computing if a filter is not implemented on OpenCL. It will be deleted after all of the filters are implemented.
(WebCore::FilterEffect::clearResult):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::openCLImageToImageBuffer): Gets the result of the filter from the OpenCL device and converts it to ImageBuffer type.
(WebCore::FilterEffect::createOpenCLImageResult): Allocates memory on OpenCL device and if it gets an image as a parameter, it uploads the image to the OpenCL device.
(WebCore::FilterEffect::transformResultColorSpace):

  • platform/graphics/filters/FilterEffect.h:

(FilterEffect):
(WebCore::FilterEffect::openCLImage):
(WebCore::FilterEffect::setOpenCLImage):
(WebCore::FilterEffect::hasResult):

  • platform/graphics/filters/SourceAlpha.h:

(SourceAlpha):

  • platform/graphics/filters/SourceGraphic.h:

(SourceGraphic):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.cpp: Added.

(WebCore):
(WebCore::FilterContextOpenCL::context): Configures the OpenCL environment.
(WebCore::FilterContextOpenCL::createOpenCLImage): Allocates memory on OpenCL device.
(WebCore::FilterContextOpenCL::openCLTransformColorSpace): OpenCL implementation of transformColorSpace.
(WebCore::FilterContextOpenCL::compileProgram):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h: Added.

(WebCore):
(FilterContextOpenCL):
(WebCore::FilterContextOpenCL::deviceId):
(WebCore::FilterContextOpenCL::deviceContext):
(WebCore::FilterContextOpenCL::commandQueue):
(RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::addArgument):
(WebCore::FilterContextOpenCL::RunKernel::run):
(WebCore::FilterContextOpenCL::kernelByName): Returns the reference of a function in the OpenCL program.

  • platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp: Added.

(WebCore):
(WebCore::SourceAlpha::platformApplyOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp: Added.

(WebCore):
(WebCore::SourceGraphic::platformApplyOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp: Added.

(WebCore):
(WebCore::FilterContextOpenCL::compileFETurbulence):
(WebCore::FilterContextOpenCL::applyFETurbulence):
(WebCore::FETurbulence::platformApplyOpenCL):

  • platform/graphics/gpu/opencl/OpenCLHandle.h: Added.

(WebCore):
(OpenCLHandle):
(WebCore::OpenCLHandle::OpenCLHandle):
(WebCore::OpenCLHandle::operator cl_mem):
(WebCore::OpenCLHandle::operator=):
(WebCore::OpenCLHandle::operator UnspecifiedBoolType):
(WebCore::OpenCLHandle::handleAddress):
(WebCore::OpenCLHandle::clear):

8:50 AM Changeset in webkit [135732] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: follow up for r135720, fixing node highlight.

  • inspector/InspectorOverlayPage.html:
8:40 AM Changeset in webkit [135731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Crashes in compositing layout tests with AC on.
https://bugs.webkit.org/show_bug.cgi?id=103144

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-26
Reviewed by Noam Rosenthal.

Application could leave texture packing parameters in non-zero state before
texture mapper drawing/texture uploading. To avoid crash texture upload should
specify packing parameters before each texture upload if packing is supported.

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContentsNoSwizzle):

8:37 AM Changeset in webkit [135730] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk/LayoutTests

Import more CSS Device Adaptation layout tests
https://bugs.webkit.org/show_bug.cgi?id=95967

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

And these are the remaining test from the Opera's CSS
Device Adaptation test suite.

  • css3/device-adapt/opera/constrain-021-expected.txt: Added.
  • css3/device-adapt/opera/constrain-021.xhtml: Added.
  • css3/device-adapt/opera/constrain-022-expected.txt: Added.
  • css3/device-adapt/opera/constrain-022.xhtml: Added.
  • css3/device-adapt/opera/orientation-001-expected.txt: Added.
  • css3/device-adapt/opera/orientation-001.xhtml: Added.
  • css3/device-adapt/opera/orientation-002-expected.txt: Added.
  • css3/device-adapt/opera/orientation-002.xhtml: Added.
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
8:32 AM Changeset in webkit [135729] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes
https://bugs.webkit.org/show_bug.cgi?id=103199

Reviewed by Yong Li.

This is the first big step to unforking this code. It's very close to
where it needs to be now, but the first step is to get rid of the
crashes by deleting code that isn't needed and makes bad assumptions
about object lifetime. Crashes were found by automation without
test case or reproduction steps.

  • loader/blackberry/CookieJarBlackBerry.cpp:

(WebCore::cookies): delete most code
(WebCore::setCookies): delete most code

8:22 AM Changeset in webkit [135728] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

Viewport CSS rules should not clamp values like Viewport META
https://bugs.webkit.org/show_bug.cgi?id=103068

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

CSS Device Adaption does not clamp the length and zoom values the
same way as the Viewport META. In fact, they are not clamped at all,
but instead, we just make sure that length values are at least 1px.

Tests: css3/device-adapt/opera/constrain-018.xhtml

css3/device-adapt/opera/constrain-019.xhtml
css3/device-adapt/opera/constrain-023.xhtml
css3/device-adapt/opera/constrain-024.xhtml

  • dom/ViewportArguments.cpp:

(WebCore::ViewportArguments::resolve):

LayoutTests:

Imported Opera tests that makes sure we are doing the clamping right.

  • css3/device-adapt/opera/constrain-018-expected.txt: Added.
  • css3/device-adapt/opera/constrain-018.xhtml: Added.
  • css3/device-adapt/opera/constrain-019-expected.txt: Added.
  • css3/device-adapt/opera/constrain-019.xhtml: Added.
  • css3/device-adapt/opera/constrain-023-expected.txt: Added.
  • css3/device-adapt/opera/constrain-023.xhtml: Added.
  • css3/device-adapt/opera/constrain-024-expected.txt: Added.
  • css3/device-adapt/opera/constrain-024.xhtml: Added.
8:12 AM Changeset in webkit [135727] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: added TestExpecations failures for
media/remove-from-document.html
https://bugs.webkit.org/show_bug.cgi?id=103093

  • platform/chromium/TestExpectations:
8:02 AM Changeset in webkit [135726] by junov@google.com
  • 4 edits
    2 adds in trunk/LayoutTests

New baselines for test fast/backgrounds/background-opaque-images-over-color.html
https://bugs.webkit.org/show_bug.cgi?id=102557

Unreviewed

  • fast/backgrounds/background-opaque-images-over-color-expected.txt:
  • platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
7:51 AM Changeset in webkit [135725] by junov@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

New baselines for test fast/backgrounds/gradient-background-leakage-2.html
https://bugs.webkit.org/show_bug.cgi?id=103089

Unreviewed

  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium/TestExpectations:
7:47 AM Changeset in webkit [135724] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Build fix for WinCE after r135640.

  • wtf/DataLog.cpp:
7:46 AM Changeset in webkit [135723] by mkwst@chromium.org
  • 3 edits
    3 adds in trunk

Web Inspector: URLs containing '' are improperly linked in console messages.
https://bugs.webkit.org/show_bug.cgi?id=103248

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch adds '' to WebInspector's regex of acceptable characters for
URLs that it knows how to display.

Test: http/tests/inspector/network/script-as-text-loading-with-caret.html

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

LayoutTests:

  • http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt: Added.
  • http/tests/inspector/network/script-as-text-loading-with-caret.html: Added.
  • platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt:

JSC vs V8. :(

7:42 AM Changeset in webkit [135722] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewd Gardening: updated TestExpecations for additional failures in
media/video-preload.html
https://bugs.webkit.org/show_bug.cgi?id=103093

  • platform/chromium/TestExpectations:
7:23 AM Changeset in webkit [135721] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Qt minimal compilation after r135713.

  • inspector/InspectorController.h: hid file content behind ENABLE(INSPECTOR)
7:17 AM Changeset in webkit [135720] by pfeldman@chromium.org
  • 15 edits
    1 delete in trunk

Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • Added node class name and id into the preview
  • Now keeps track of properties separately from array indexes.
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/InspectorOverlayPage.html:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api-inspect-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
  • platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed.
  • platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
7:03 AM Changeset in webkit [135719] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

RenderSVGResourceContainer does not clear cached data on removal
https://bugs.webkit.org/show_bug.cgi?id=102620

Reviewed by Dirk Schulze.

Source/WebCore:

RenderSVGResourceContainer::removeClient needs to also remove the client from specialized
caches, otherwise we can end up with stale references.

Test: svg/custom/stale-resource-data-crash.svg

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::removeClient):

LayoutTests:

  • svg/custom/stale-resource-data-crash-expected.txt: Added.
  • svg/custom/stale-resource-data-crash.svg: Added.
7:01 AM Changeset in webkit [135718] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk/Source/WebKit/chromium

[chromium] Make use_default_render_theme compile the right set of files
https://bugs.webkit.org/show_bug.cgi?id=102952

Patch by Scott Violet <sky@chromium.org> on 2012-11-26
Reviewed by Kent Tamura.

  • WebKit.gyp: Adds WebRenderTheme.* and updates rules as to when to compile them.
  • features.gypi: Removes use_default_render_theme default values as common.gypi sets them.
  • public/default: Added.
  • public/default/WebRenderTheme.h: Copy of linux/WebRenderTheme.h
  • src/default: Added.
  • src/default/WebRenderTheme.cpp: Copy of linux/WebRenderTheme.cpp
6:47 AM Changeset in webkit [135717] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=98857

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-26
Reviewed by Zoltan Herczeg.

Implement a new version of patchableBranch32 to fix crashing JSC
tests.

  • assembler/MacroAssembler.h:

(MacroAssembler):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::patchableBranch32):
(MacroAssemblerARM):

6:46 AM Changeset in webkit [135716] by pfeldman@chromium.org
  • 15 edits
    1 copy in trunk

Not reviewed: rolling out r135714 and r135712 for breaking debug tests.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/InspectorOverlayPage.html:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api-inspect-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
  • platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt.
  • platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
6:36 AM Changeset in webkit [135715] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Win] buildfix after r135706.
https://bugs.webkit.org/show_bug.cgi?id=103249

The Windows implementation of GraphicsSurface cannot use
m_size anymore, as this member has been removed.
Further it needs to implement a platformSize() function.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:

(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformSize):
(WebCore):

6:10 AM Changeset in webkit [135714] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: rolling out accidental TestExpectations change.

  • platform/chromium/TestExpectations:
6:06 AM Changeset in webkit [135713] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: unify agents handling in Page and Worker inspector controllers
https://bugs.webkit.org/show_bug.cgi?id=103238

Reviewed by Alexander Pavlov.

Introduced a class that represents a collection of inspector agents and allows
to call methods declared on InspectorAgentBaseInterface for all registered agents.
InspectorController and WorkerInspectorController switched to this class.

  • inspector/InspectorBaseAgent.cpp:

(WebCore::InspectorAgentRegistry::append):
(WebCore):
(WebCore::InspectorAgentRegistry::setFrontend):
(WebCore::InspectorAgentRegistry::clearFrontend):
(WebCore::InspectorAgentRegistry::restore):
(WebCore::InspectorAgentRegistry::registerInDispatcher):
(WebCore::InspectorAgentRegistry::discardAgents):

  • inspector/InspectorBaseAgent.h:

(InspectorAgentRegistry):
(WebCore):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::reconnectFrontend):

  • inspector/InspectorController.h:

(InspectorController):

6:01 AM Changeset in webkit [135712] by pfeldman@chromium.org
  • 16 edits
    1 delete in trunk

Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • Added node class name and id into the preview
  • Now keeps track of properties separately from array indexes.
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/InspectorOverlayPage.html:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
5:55 AM Changeset in webkit [135711] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Save WebGL extensions and restore on replay
https://bugs.webkit.org/show_bug.cgi?id=103141

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-26
Reviewed by Yury Semikhatsky.

Save WebGL extensions that were enabled by the application, and restore it before the replay.
Drive-by: remove redundant if- checks in WebGL custom function wrappers (similar to 2D canvas).

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

5:54 AM Changeset in webkit [135710] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

HitTestResult should not be a HitTestLocation
https://bugs.webkit.org/show_bug.cgi?id=101590

Reviewed by Sam Weinig.

Change HitTestResult from being a HitTestLocation to having a HitTestLocation.
A result of a test should not be a special case of the location of the test.

No change in functionality. No new tests.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::isSelected):
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::replacedString):

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::isRectBasedTest):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(WebCore::HitTestResult::hitTestLocation):
(HitTestResult):

5:41 AM Changeset in webkit [135709] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Circular reference between Document and MediaQueryMatcher.
https://bugs.webkit.org/show_bug.cgi?id=103242

Patch by Marja Hölttä <marja@chromium.org> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

It's not enough to clean up listeners in MediaQueryMatcher in ~Document,
since MediaQueryListListener keeps the Document alive. This caused
www.crbug.com/113983.

No new tests: No visible change in behavior (except that it doesn't leak memory).

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::detach):

5:37 AM Changeset in webkit [135708] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
https://bugs.webkit.org/show_bug.cgi?id=103240

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-11-26
Reviewed by Yury Semikhatsky.

Source/WebCore:

Cleanup: remove redundant dependency.

  • inspector/front-end/HeapSnapshotDataGrids.js: Do not store view ref.
  • inspector/front-end/HeapSnapshotGridNodes.js:

Removed unused assignments.

  • inspector/front-end/HeapSnapshotView.js:

Do not pass self to data-grids.

LayoutTests:

Directly access current view instead of getting if from the data grid.

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

4:40 AM Changeset in webkit [135707] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Gardening: update test expectations
https://bugs.webkit.org/show_bug.cgi?id=103119

Unreviewed gardening. timeline-timer-fired-from-eval-call-site-expected.html
is passing now, other changes are just marking tests as flaky based on
the flakiness dashboard.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-26

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:32 AM Changeset in webkit [135706] by zeno.albisser@digia.com
  • 6 edits in trunk/Source/WebCore

GraphicsSurface should only store its size in a single place.
https://bugs.webkit.org/show_bug.cgi?id=103143

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

Cosmetics only.

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::size):

Return the size as received from the platform abstraction.

(WebCore):
(WebCore::GraphicsSurface::GraphicsSurface):

  • platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

Remove data member m_size.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

Always take the size of the GraphicsSurface as an argument.

(WebCore::GraphicsSurfacePrivate::size):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

Retrieve the size from GraphicsSurfacePrivate where necessary.

(WebCore::GraphicsSurface::platformSize):
(WebCore):
(WebCore::GraphicsSurface::platformImport):

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

Add a constructor that takes a window id as an argument
for the receiving side of the GraphcisSurface.
The GraphicsSurface can then determine its dimensions
from the provided XWindow.

(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::size):

Query the size of the GraphicsSurface backing from X.

(WebCore::GraphicsSurface::platformPaintToTextureMapper):

Retrieve the size from GraphicsSurfacePrivate where necessary.

(WebCore::GraphicsSurface::platformSize):
(WebCore):
(WebCore::GraphicsSurface::platformImport):

4:10 AM Changeset in webkit [135705] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GStreamer] Floating reference handling fix
https://bugs.webkit.org/show_bug.cgi?id=101349

Patch by Thiago Santos <thiago.sousa.santos@collabora.com> on 2012-11-26
Reviewed by Philippe Normand.

GStreamer 0.10 and 1.0 differ when creating GstGhostPad from pad
templates, the 1.0 doesn't take ownership on the passed
GstPadTemplate, while 0.10 does. So this patch adds a
GStreamerVersioning function to handle this different approach
transparently in Webkit gstreamer elements.

Existing media tests cover this change.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(webkitGstGhostPadFromStaticTemplate):

  • platform/graphics/gstreamer/GStreamerVersioning.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):

3:44 AM Changeset in webkit [135704] by keishi@webkit.org
  • 3 edits in trunk/LayoutTests

Layout Test platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103225

Unreviewed.

  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: Remove current month check because it was flaky.
3:20 AM Changeset in webkit [135703] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

[V8] Remove WorkerContextExecutionProxy
https://bugs.webkit.org/show_bug.cgi?id=103210

Reviewed by Adam Barth.

This patch moves all methods in WorkerContextExecutionProxy
to WorkerScriptController.

Due to the dependency between WorkerContextExecutionProxy's methods,
it is a bit difficult to split this patch into pieces.
This patch simply moves methods without changing their logic.
Also this patch doesn't remove empty WorkerContextExecutionProxy.{h,cpp}
to keep the diff sane. I will address these issues in a follow-up patch.

Tests: fast/worker/*

  • bindings/v8/ScriptState.cpp:

(WebCore::scriptStateFromWorkerContext):

  • bindings/v8/V8Binding.cpp:

(WebCore::toV8Context):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::handleEvent):

  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::dispose):
(WebCore):
(WebCore::WorkerScriptController::initializeIfNeeded):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setEvalAllowed):
(WebCore::WorkerScriptController::disableEval):

  • bindings/v8/WorkerScriptController.h:

(WebCore):
(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
(WorkerContextExecutionState):
(WorkerScriptController):
(WebCore::WorkerScriptController::context):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):
(WebCore::toV8):

3:16 AM Changeset in webkit [135702] by commit-queue@webkit.org
  • 7 edits in trunk

Text Autosizing: Add Text Autosizing APIs for WK2
https://bugs.webkit.org/show_bug.cgi?id=100633

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-26
Reviewed by Sam Weinig.

Source/WebKit2:

Implement basic Text Autosizing APIs for WK2.
Text Autosizing is a useful feature for mobile browsers. It adjusts the font size
of text in wide columns, and makes text more legible.
This patch adds setting APIs for Text Autosizing in WK2.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTextAutosizingEnabled):
(WKPreferencesGetTextAutosizingEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Add test cases for Text Autosizing in WKPreferences.

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

3:06 AM Changeset in webkit [135701] by Simon Hausmann
  • 8 edits in trunk

[Qt] REGRESSION(r135575): It made all tests assert
https://bugs.webkit.org/show_bug.cgi?id=103169

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2012-11-26
Reviewed by Simon Hausmann.

This fixes another regression introduced in r135515:
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
since it can be called from WebKit2 to initialize QStyle for testing.
This would then lead to things such as PlatformStrategies being
initialized twice.

Source/WebKit/qt:

  • Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit::initializeWebKitQt):
(WebCore::initializeWebCoreQt):

  • WebCoreSupport/InitWebCoreQt.h:

(WebCore):

Source/WebKit2:

  • qt/MainQt.cpp: No need to initialize anything if we're not using QStyle.

(WebKit):
(main):

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.

(WebCore::DumpRenderTree::DumpRenderTree):

3:00 AM Changeset in webkit [135700] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103142

When creating the TextureMapperGL for WK1 we have to make sure
that the GL context provided by the QGLWidget is current.
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
the wrong pointer by calling QOpenGLContext::currentContext().

Reviewed by Simon Hausmann.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

2:53 AM Changeset in webkit [135699] by Jonathan Dong
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
https://bugs.webkit.org/show_bug.cgi?id=103104

Reviewed by Rob Buis.

RIM PR: 245334
Added the oldPassword detection back into the password input
detection logic, which was removed for simplicity when imported
those pieces of codes from Chromium. And we won't do autofill
when there're more than one password field detected.

Internally reviewed by Rob Buis.

  • WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore::CredentialTransformData::findPasswordFormFields):

  • WebCoreSupport/CredentialTransformData.h:

(CredentialTransformData):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

2:46 AM Changeset in webkit [135698] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r135629. Skipped a newly added but failing test.
https://bugs.webkit.org/show_bug.cgi?id=103227

Patch by János Badics <János Badics> on 2012-11-26
Reviewed by Csaba Osztrogonác.

  • platform/qt/TestExpectations:
2:41 AM Changeset in webkit [135697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(134142): ASSERT(!m_size.isZero()) hits in CoordinatedBackingStore::paintToTextureMapper().
https://bugs.webkit.org/show_bug.cgi?id=103217

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-26
Reviewed by Noam Rosenthal.

It is possible for CoordinatedBackingStore of directed composited image to not
have tiles, because CoordinatedImageBacking does not create tiles when the image
is invisible.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::paintToTextureMapper):

2:35 AM Changeset in webkit [135696] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] QStyleFacadeImp build break with latest Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103198

Reviewed by Simon Hausmann.

Original patch by J-P Nurmi <jpnurmi@digia.com>.

Fixes QtWebKit build by replacing qobject_cast to
QMacStyle with calls to QObject::inherits. Also
replaces Q_WS_MAC preprocesser directives with Q_OS_MAC
for Qt 5 compatibility.

  • WebCoreSupport/QStyleFacadeImp.cpp:

(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintScrollBar):

2:21 AM Changeset in webkit [135695] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

[Refactoring] Some Node::isDescendant calls can be replaced with Node::contains()
https://bugs.webkit.org/show_bug.cgi?id=103211

Reviewed by Daniel Bates.

A couple of call sites of isDescendant() does same as Node::contains().
This change replaces these locations with Node::contains().

No new tests, no behavior change.

  • dom/Node.cpp:

(WebCore::checkAcceptChild):

  • dom/Range.cpp:

(WebCore::Range::surroundContents):

2:11 AM Changeset in webkit [135694] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Enable input type datetime-local
https://bugs.webkit.org/show_bug.cgi?id=103213

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-26
Reviewed by Kent Tamura.

This patch enables <input type=datetime-local> for Chromium.

No new tests. Covered by existing tests.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore): Changed RuntimeEnabledFeatures::isInputTypeDateTimeLocalEnabled to true
if INPUT_TYPE_DATETIMELOCAL is enabled.

1:38 AM Changeset in webkit [135693] by morrita@google.com
  • 6 edits
    2 adds in trunk

[Shadow DOM] Implement Element::createShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=102911

Reviewed by Kentaro Hara.

Source/WebCore:

Added an API implementation and exposed it.

This is basically an alias of the ShadowRoot constructor, which
will be removed as bug 102913.

Test: fast/dom/shadow/shadow-aware-create-shdow-root.html

  • bindings/gobject/GNUmakefile.am:
  • dom/Element.cpp:

(WebCore::Element::createShadowRoot):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/Element.idl:

LayoutTests:

The coverage might not seem comprehensive at a glance. However,
this is just an alias of ShadowRoot constructor and there are
bunch of test cases which cover it.

As bug 102913 will convert such callsites to use createShadowRoot(),
the API will get be covered well then.

  • fast/dom/shadow/shadow-aware-create-shdow-root-expected.txt: Added.
  • fast/dom/shadow/shadow-aware-create-shdow-root.html: Added. Further ShadowAware API will come here.
1:27 AM Changeset in webkit [135692] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html as flaky (date-dependent).

  • platform/chromium/TestExpectations:
1:18 AM Changeset in webkit [135691] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding timeout expectation for the new a11y test added in r135680.

  • platform/gtk/TestExpectations:
1:14 AM BuildingQtOnWindows edited by Simon Hausmann
(diff)
1:11 AM Changeset in webkit [135690] by jonlee@apple.com
  • 18 edits
    1 add in trunk/Source/WebCore

Extend EventDispatcher::dispatchSimulatedClick to allow sending a mouseover event
https://bugs.webkit.org/show_bug.cgi?id=102610
<rdar://problem/12725663>

Reviewed by Darin Adler.

Update the dispatchSimulatedClick() to take option enums for dispatching events.

  • dom/SimulatedClickOptions.h: Added. Define two options enums. One tracks which mouse

events to send. The other determines whether to force the element to repaint.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick): Refactor to use the option enums.

  • dom/EventDispatcher.h:

(EventDispatcher): Update function signature.

  • dom/Node.cpp: Refactor parameters to use the options enums rather than booleans.

(WebCore::Node::dispatchSimulatedClick):

  • dom/Node.h:

Refactor. Remove redundant comments.

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::accessKeyAction):

  • html/BaseClickableWithKeyInputType.cpp:

(WebCore::BaseClickableWithKeyInputType::accessKeyAction):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::accessKeyAction):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::accessKeyAction):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::click):
(WebCore::HTMLElement::accessKeyAction):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::accessKeyAction):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::accessKeyAction):

Add SimulatedClickOptions.h.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
1:07 AM Changeset in webkit [135689] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

[Shadow] Attaching children of a shadow host takes O(N2) where N is the number of host children
https://bugs.webkit.org/show_bug.cgi?id=103017

Reviewed by Hajime Morita.

Since ContentDistribution was just a Vector, ContentDistribution::find() took O(N). Each child of shadow host calls it.
As a result, attaching children of shadow host takes O(N2) at all.

In this patch, we make ContentDistribution::find() O(1) amortizedly. We introduce HashMap from a Node to Vector index,
and use it for ContentDistribution::find().

No new tests, covered by existing tests.

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistribution::swap):
(WebCore):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistributor::distributeSelectionsTo):

  • html/shadow/ContentDistributor.h:

(ContentDistribution): ContentDistribution now contains Vector and a reverse map.
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::at):
(WebCore::ContentDistribution::size):
(WebCore::ContentDistribution::isEmpty):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::contains):
(WebCore::ContentDistribution::nodes):

12:31 AM Changeset in webkit [135688] by commit-queue@webkit.org
  • 4 edits in trunk

[CMake] Allow user specified compiler flags to take precedence
https://bugs.webkit.org/show_bug.cgi?id=103101

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-26
Reviewed by Brent Fulgham.

Make sure that compiler and linker flags specified by the build system
are always prepended to the variables that can be specified by the
environment and the user as well.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsWindows.cmake:
  • Source/cmake/WebKitHelpers.cmake:
12:10 AM Changeset in webkit [135687] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[V8] Give isolated shells a lifecycle like that of main shells
https://bugs.webkit.org/show_bug.cgi?id=96522

Patch by Dan Carney <dcarney@google.com> on 2012-11-26
Reviewed by Adam Barth.

Refactored the isolated shells in ScriptController
to be cleaned up the same way the main shell is.

No new tests. No change in functionality.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearForOutOfMemory):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::clearForClose):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

Nov 25, 2012:

11:54 PM Changeset in webkit [135686] by ryuan.choi@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Unskip the fixed regressions from r135662

  • platform/efl-wk1/TestExpectations:
11:50 PM Changeset in webkit [135685] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r135656.
http://trac.webkit.org/changeset/135656
https://bugs.webkit.org/show_bug.cgi?id=103218

Made a few SVG tests crash on all platforms (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-25

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

11:45 PM Changeset in webkit [135684] by tasak@google.com
  • 3 edits
    2 adds in trunk

WebCore::RenderBlock::determineStartPosition crash
https://bugs.webkit.org/show_bug.cgi?id=98993

Reviewed by Brent Fulgham.

Source/WebCore:

If we move some node and the node has some text,
InlineFlowBox::removeChild() is invoked. The method invokes
RootInlineBox::childRemoved(). childRemoved() checks whether the
removed inlinebox has the renderer of its parent's line break object.
If so, use setLineBreakInfo to make the parent's line break info to
be 0. However in RenderBlock::determineStartPosition(), the code
assume that all line break info is solved, i.e.
prevRootBox->lineBreakObj()->isText(). Since lineBreakObj() returns 0
because of removeChild(), determineStartPosition crash occurs.

Test: fast/inline/inline-box-append-child-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
Checks whether lineBreakObj() is 0 or not before using lineBreakObj().

LayoutTests:

  • fast/inline/inline-box-append-child-crash-expected.txt: Added.
  • fast/inline/inline-box-append-child-crash.html: Added.
10:35 PM Changeset in webkit [135683] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: use native Element.prototype.normalize instead of custom defined Element.prototype.pruneEmptyTextNodes
https://bugs.webkit.org/show_bug.cgi?id=103205

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.

  • inspector/front-end/DOMExtension.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):

10:33 PM Changeset in webkit [135682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: remove unused DOM methods
https://bugs.webkit.org/show_bug.cgi?id=103204

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.

  • inspector/front-end/DOMExtension.js:
10:15 PM Changeset in webkit [135681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unused Array.convert method
https://bugs.webkit.org/show_bug.cgi?id=103202

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Daniel Bates.

  • inspector/front-end/utilities.js:
10:07 PM Changeset in webkit [135680] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: file upload input cannot be activated with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=100343

Reviewed by Sam Weinig.

Source/WebCore:

Simulated events were not allowed to be processed in the file input type in the DOMActivate handler.
This was a problem for accessibility clients which rely on simulated events.

The solution is to mark the UserGestureIndicator as definitely processing an event.

Test: accessibility/file-upload-button-with-axpress.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):

LayoutTests:

  • accessibility/file-upload-button-with-axpress-expected.txt: Added.
  • accessibility/file-upload-button-with-axpress.html: Added.
9:58 PM Changeset in webkit [135679] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: dispatch an event upon heap snapshot filter change
https://bugs.webkit.org/show_bug.cgi?id=103201

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.

Dispatch heapSnapshotFilterChanged event so it can be received by third parties.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._changeFilter):

  • inspector/front-end/UserMetrics.js:
9:12 PM Changeset in webkit [135678] by Kaustubh Atrawalkar
  • 3 edits in trunk/Source/WebKit/gtk

Remove deprecated load-done signal
https://bugs.webkit.org/show_bug.cgi?id=72712

Reviewed by Brent Fulgham.

Remove deprecated load-done signal and migrate to load-status.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):
(WebKit::FrameLoaderClient::dispatchDidFinishLoad):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

5:54 PM Changeset in webkit [135677] by tkent@chromium.org
  • 19 edits in trunk/LayoutTests

2012-11-25 Kent Tamura <tkent@chromium.org>

[Chromium] Fix svn:mime-type for images

  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png: Added property svn:mime-type.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/fast/text/international/001-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/fast/text/international/002-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/fast/text/international/wrap-CJK-001-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Modified property svn:mime-type.
5:00 PM Changeset in webkit [135676] by commit-queue@webkit.org
  • 2 edits
    40 adds in trunk/LayoutTests

[Chromium] Add tests for datetime/datetime-local suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102888

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-25
Reviewed by Kent Tamura.

Adding tests for <input type=datetime> and <input type=datetime-local> with datalist.

  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute.html: Added.
4:38 PM Changeset in webkit [135675] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

Refactoring: Move the content of HTMLInputElement::subtreeHasChanged to TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=103195

Reviewed by Kentaro Hara.

HTMLInputElement::subtreeHasChanged is called only if the input is
a text field. The code should be moved to TextFieldInputType.

No new tests. This should not change any behavior.

  • html/HTMLInputElement.cpp:
  • Remove unnecessary NumberInputType.h inclusion.
  • Remove convertFromVisibleValue. It was used only by subtreeHasChanged.

(WebCore::HTMLInputElement::subtreeHasChanged):
Move the code to TextFieldInputType::subtreeHasChanged except
calculateAndAdjustDirectionality, which is a protected member of
HTMLElement.

  • html/HTMLInputElement.h:

(HTMLInputElement): Remove convertFromVisibleValue.

  • html/InputType.cpp:

Move convertFromVisibleValue to TextFieldInputType.
(WebCore::InputType::subtreeHasChanged):
Add ASSERT_NOT_REACHED.

  • html/InputType.h:

(InputType): Remove convertFromVisibleValue.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::convertFromVisibleValue):
Moved from InputType.
(WebCore::TextFieldInputType::subtreeHasChanged):
Moved from HTMLInputElement. A latter part is moved to
didSetValueByUserEdit to be hooked by SearchInputType.
(WebCore::TextFieldInputType::didSetValueByUserEdit):
Moved from HTMLInputElement::subtreeHasChanged, and clean up the code.

  • html/TextFieldInputType.h:

(TextFieldInputType):

  • Move convertFromVisibleValue from InputType.
  • Add didSetValueByUserEdit and subtreeHasChanged.
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::didSetValueByUserEdit):
Renamed from subtreeHasChanged, and calls TextFieldInputType::didSetValueByUserEdit.

  • html/SearchInputType.h:

(SearchInputType): Rename subtreeHasChanged to didSetValueByUserEdit.

4:21 PM Changeset in webkit [135674] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=103061

Reviewed by Adam Barth.

This is an incremental step to remove WorkerExecutionContextProxy.
This patch moves WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer.
This patch also renames methods so that the names become consistent
between the main thread and workers.

No tests. No change in behavior.

  • bindings/v8/V8Initializer.cpp:

(WebCore::reportFatalErrorInMainThread):
(WebCore::messageHandlerInMainThread):
(WebCore::failedAccessCheckCallbackInMainThread):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::reportFatalErrorInWorker):
(WebCore):
(WebCore::messageHandlerInWorker):
(WebCore::V8Initializer::initializeWorkerIfNeeded):

  • bindings/v8/V8Initializer.h:

(V8Initializer):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

11:19 AM Changeset in webkit [135673] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
https://bugs.webkit.org/show_bug.cgi?id=103189

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-25
Reviewed by Kenneth Rohde Christiansen.

Check if the entry size and type changed in
RenderThemeEfl::ThemePartCacheEntry::reuse() to avoid
useless processing if one of them did not change.

Remove useless call to cairo_surface_finish() since
we are using a smart pointer for the surface.

Resize the edge object *after* loading its content
from the theme file as it seems more logical this
way.

No new tests, no behavior change for layout tests.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):

  • platform/efl/RenderThemeEfl.h:

(ThemePartCacheEntry):

11:06 AM Changeset in webkit [135672] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Get rid of resetBitmapZoomScale()
https://bugs.webkit.org/show_bug.cgi?id=103200

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Gen Mak.

PR: 235707
Right now, resetBitmapZoomScale() takes an unused paramter and
dispatches a message to end the bitmap zooming. However, the
interaction has its own state machine to start bitmap zooming when it
is active and end bitmap zooming when it is inactive. This is
expecially for pinch zoom and scroll. From WebKit side, block zoom
which will call zoomBlock when the bitmap zoom finished doesn't even
need to dispatch the useless ending message to ZoomHandler.
resetBitmapZoomScale() is basically a noop for block zoom. And likewise
that is useless for zoomToInitialScaleOnLoad(). It can also potentially
cause problem if it is used somewhere else in the future and
incidentally breaks the interaction's own state machine. So just remove
this completely.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):

  • Api/WebPageClient.h:
10:51 AM Changeset in webkit [135671] by rniwa@webkit.org
  • 34 edits
    2 moves in trunk/Source/WebCore

Rename DynamicNodeList to LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=103197

Reviewed by Ojan Vafai.

Rename DynamicNodeList to LiveNodeList to match the terminology used in DOM4 working draft:
http://www.w3.org/TR/2012/WD-dom-20120405/#concept-collection-live
"A collection (either NodeList or HTMLCollection) can be either live or static".

Also rename DynamicNodeListCacheBase to LiveNodeListBase, and merge DynamicSubtreeNodeList
into LiveNodeList (old DynamicNodeList) now that the only difference between those two classes
is the former calling registerNodeListCache and unregisterNodeListCache on Document.

This patch completes the series of simplification of NodeList/HTMLCollection classes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::nodeMatches):

  • dom/ChildNodeList.h:
  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

  • dom/ClassNodeList.h:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):
(WebCore):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/DynamicNodeList.cpp: Removed.
  • dom/DynamicNodeList.h: Removed.
  • dom/LiveNodeList.cpp: Copied from Source/WebCore/dom/DynamicNodeList.cpp.

(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeListBase::invalidateIdNameCacheMaps):
(WebCore::LiveNodeListBase::reportMemoryUsage):
(WebCore::LiveNodeList::namedItem):

  • dom/LiveNodeList.h: Copied from Source/WebCore/dom/DynamicNodeList.h.

(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):
(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(LiveNodeList):

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::MicroDataItemList):

  • dom/MicroDataItemList.h:
  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):

  • dom/NameNodeList.h:
  • dom/Node.cpp:

(WebCore::shouldInvalidateNodeListCachesForAttr):
(WebCore::Document::invalidateNodeListCaches):

  • dom/Node.h:

(WebCore):

  • dom/NodeList.h:

(WebCore::NodeList::isLiveNodeList):

  • dom/NodeRareData.h:

(NodeListsNodeData):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):

  • dom/PropertyNodeList.cpp:

(WebCore::PropertyNodeList::PropertyNodeList):

  • dom/PropertyNodeList.h:
  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):

  • dom/TagNodeList.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::LiveNodeListBase::iterateForNextNode):
(WebCore::LiveNodeListBase::itemBeforeOrAfter):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::itemAfter):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setItemCache):
(WebCore::LiveNodeListBase::length):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):

  • html/HTMLCollection.h:
  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

  • html/RadioNodeList.h:
10:35 AM Changeset in webkit [135670] by robert@webkit.org
  • 4 edits
    2 adds in trunk

Changing position:relative to position:static results in mis-positioned div
https://bugs.webkit.org/show_bug.cgi?id=26397

Reviewed by Ojan Vafai.

Source/WebCore:

When a block changes position from relative to static it is no longer the containing block for any
positioned objects it may have. If any of those positioned objects actually have a position specified
they are going to need a layout as their new containing block will likely have a different location they
need to offset from. Positioned objects without a specified position always get a layout anyway
in layoutPositionedObjects() so no need to worry about them in this situation.

Test: fast/block/abspos-child-container-changes-from-relative-to-static-expected.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::removePositionedObjects):

  • rendering/RenderBlock.h:

(RenderBlock):

LayoutTests:

  • fast/block/abspos-child-container-changes-from-relative-to-static-expected.html: Added
  • fast/block/abspos-child-container-changes-from-relative-to-static.html: Added
10:30 AM Changeset in webkit [135669] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

[WK2] TiledBackingStore: page contents is scaled wrongly
https://bugs.webkit.org/show_bug.cgi?id=103090

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Before this change the page contents scaling in PageViewportController was
defined all the times by m_rawAttributes.initialScale. If initial scale had not
been specified in the viewport meta tag it was set to m_minimumScaleToFit inside
PageViewportController::didChangeViewportAttributes().

The problem was that m_minimumScaleToFit could have wrong value as contents size
might have not be updated by the time PageViewportController::didChangeViewportAttributes()
was invoked.

The solution is to use m_minimumScaleToFit for contents scaling if initial scale
is not specified in the viewport meta tag, as it is updated all the time.
Also a flag m_initiallyFitToViewport is added to PageViewportController to detect
whether m_minimumScaleToFit should be used for scaling.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeViewportAttributes):

  • UIProcess/PageViewportController.h:

(PageViewportController):

LayoutTests:

Added new layout test to verify that viewport 'width' descriptor does not
affect contents width of next loaded page.

  • css3/device-adapt/resources/check-contents-width.html: Added.
  • css3/device-adapt/viewport-width-not-affecting-next-page-expected.txt: Added.
  • css3/device-adapt/viewport-width-not-affecting-next-page.html: Added.
8:53 AM Changeset in webkit [135668] by Antti Koivisto
  • 13 edits in trunk/Source/WebCore

Make renderer construction less generic
https://bugs.webkit.org/show_bug.cgi?id=103175

Reviewed by Ojan Vafai.

The renderer construction code currently operates on Nodes and is very generic. In reality
only Element and Text nodes can have renderers and the Text case is much simpler.

This patch separates the Text and Element renderer construction paths and makes it statically
known that other Node types can't have renderers. Less generic code is less branchy and enables
further optimizations.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore):
(WebCore::CharacterData::rendererIsNeeded):
(WebCore::CharacterData::createRenderer):

Only Text subclass of CharacterData can have renderers.

  • dom/CharacterData.h:

(CharacterData):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::childShouldCreateRenderer):

Move childShouldCreateRenderer from Node to ContainerNode.

(ContainerNode):

  • dom/Element.cpp:

(WebCore::Element::rendererIsNeeded):
(WebCore):
(WebCore::Element::attach):
(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:


Move rendererIsNeeded and createRenderer from Node to Element.

(Element):

  • dom/Node.cpp:

(WebCore::Node::attach):
(WebCore):

  • dom/Node.h:

(Node):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):

Separate the Element and Text renderer creation paths. Both are less branchy.
The Text path is much simpler and avoids a bunch of virtual calls.

(WebCore):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • dom/Text.cpp:

(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::createTextRendererIfNeeded):
(WebCore):
(WebCore::Text::createTextRenderer):
(WebCore::Text::attach):
(WebCore::Text::updateTextRenderer):

  • dom/Text.h:


Add non-virtual Text specific functions.

(WebCore):
(Text):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

12:01 AM Changeset in webkit [135667] by rniwa@webkit.org
  • 15 edits in trunk/Source/WebCore

REGRESSION(r135493): HTMLCollection and DynamicNodeList have two vtable pointers
https://bugs.webkit.org/show_bug.cgi?id=103096

Reviewed by Sam Weinig.

Co-authored by Ilya Tikhonovsky.

Made DynamicNodeListCacheBase inherit from NodeList. While HTMLCollection doesn't inherit
from NodeList in IDL, it makes a lot of sense for the C++ implementation to do so via
DynamicNodeListCacheBase since HTMLCollection and live NodeList share a lot of code in
DynamicNodeListCacheBase.

This lets remove proxies for item() and length() in DynamicNodeList and HTMLCollection
and directly implement them in DynamicNodeListCacheBase which used to provide itemCommon()
and lengthCommon().

Also renamed NodeList::itemWithName() to NodeList::namedItem() to match HTMLCollection's
naming convention.

Finally, removed reportMemoryUsage in DynamicNodeList::reportMemoryUsage since DynamicNodeList
now uses single inheritance.

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName): Calls namedItem, which has been renamed from
itemWithName.
(WebCore::JSNodeList::nameGetter): Ditto.

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter): Ditto.

  • bindings/v8/custom/V8NamedNodesCollection.cpp:

(WebCore::V8NamedNodesCollection::namedItem): Renamed from itemWithName.

  • bindings/v8/custom/V8NamedNodesCollection.h:
  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::nodeMatches): Updated comment.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeList::namedItem): Renamed from itemWithName.

  • dom/DynamicNodeList.h:

(DynamicNodeListCacheBase): Inhertis from NodeList and renamed lengthCommon and itemCommon
to virtual length and item respectively.
(DynamicNodeList): Now inherits from just DynamicNodeListCacheBase instead of NodeList
and DynamicNodeListCacheBase since the former now inhertis from NodeList. Also removed
length() and item() since they're implemented in DynamicNodeListCacheBase now and renamed
itemWithName() to namedItem() to match HTMLCollection's naming convention.

  • dom/NodeList.h:

(NodeList::namedItem): Renamed from itemWithName. Note that this member function is not
exposed via IDL. It's merely used in the binding code.

  • dom/StaticHashSetNodeList.cpp:

(WebCore::StaticHashSetNodeList::namedItem): Ditto.

  • dom/StaticHashSetNodeList.h:

(StaticHashSetNodeList::namedItem): Ditto.

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::namedItem): Ditto.

  • dom/StaticNodeList.h:

(StaticNodeList::namedItem): Ditto.

  • html/HTMLCollection.cpp:

(WebCore::DynamicNodeListCacheBase::length): Renamed from lengthCommon.
(WebCore::DynamicNodeListCacheBase::item): Renamed from itemCommon.

  • html/HTMLCollection.h:

(HTMLCollection): Inherits from DynamicNodeListCacheBase since DynamicNodeListCacheBase
is already RefCount'ed and NodeList, from which DynamicNodeListCacheBase inherits,
inherits from ScriptWrappable.

Nov 24, 2012:

11:25 PM Changeset in webkit [135666] by abarth@webkit.org
  • 3 edits in trunk/Source/WTF

Chromium should use TCMalloc on Mac to go fast
https://bugs.webkit.org/show_bug.cgi?id=102866

Reviewed by Eric Seidel.

This patch enables TCMalloc for some WebKit objects. It improves
dom-modify on Mac by 5-10%.

On non-Mac platforms, Chromium already uses TCMalloc throughout the
project. Unfortunately, we haven't yet figured out how to turn TCMalloc
on globally on Mac because the approach we use for other platforms makes
some OS X APIs sad.

The next best thing would be to enable TCMalloc for WebKit by
overriding the global new and delete operator, as is done on apple-mac
and other platforms. Unfortunately, we cannot use that approach either
because the Chromium WebKit API is not memory tight.

Fortunately, WebKit has a mechanism for selectively enabling TCMalloc
for a selection of objects by overriding the new and delete operators
on those objects. This patch opts chromium-mac into that scheme by
setting the appropriate preprocessor macros.

  • WTF.gyp/WTF.gyp:
  • wtf/Platform.h:
8:49 PM Changeset in webkit [135665] by dbates@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Substitute "use" for "user" in sentence about naming convention for
enum members so that it reads well.

  • coding/coding-style.html:
8:13 PM Changeset in webkit [135664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Find-on-page keeps stale pointer
https://bugs.webkit.org/show_bug.cgi?id=103190

Patch by Andy Chen <andchen@rim.com> on 2012-11-24
Reviewed by Rob Buis.

Find on page: pendingScopingEffort stores stale pointer when frames unload,
we need to cancel those scoping efforts.
PR 250807.

Internally reviewed by Yongxin Dai and Mike Fenton.

  • WebKitSupport/InPageSearchManager.cpp:

(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):

6:52 PM Changeset in webkit [135663] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Refactor RenderThemeEfl::paintThemePart()
https://bugs.webkit.org/show_bug.cgi?id=103192

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Refactor RenderThemeEfl::paintThemePart() so that:

  • Some C'ism is removed
  • RTL related code is moved to applyEdjeRTLState()
  • evas_render() is called instead of evas_render_updates() to avoid creating uselessly update rects.

No new tests, no behavior change for layout tests.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::applyEdjeRTLState):
(WebCore):
(WebCore::RenderThemeEfl::paintThemePart):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

6:38 PM Changeset in webkit [135662] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Layout test comes to crash on WK1
https://bugs.webkit.org/show_bug.cgi?id=103170

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Switch off accelerated compositing for WK1 because GraphicsContext3D is
missing direct rendering implementation that is required for EFL WK1.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

6:22 PM Changeset in webkit [135661] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove traces of MediaControlRootElement
https://bugs.webkit.org/show_bug.cgi?id=103174

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-11-24
Reviewed by Adam Barth.

Now that nothing is using MediaControlRootElement any more,
we can remove the FIXME and MediaControlRootElement enum left
over from bug 88871.

  • public/WebContextMenuData.h:
6:18 PM Changeset in webkit [135660] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
https://bugs.webkit.org/show_bug.cgi?id=103187

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Now the client should pass to DECLARE_EWK_VIEW_CALLBACK macro exacly the
same arg type s/he wants to have in the Ewk_View callback.

  • UIProcess/API/efl/EwkViewCallbacks.h:

(EvasObjectHolder):
(EwkViewCallbacks::EvasObjectHolder::EvasObjectHolder):
(EwkViewCallbacks):

3:05 PM Changeset in webkit [135659] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Avoid access violation when frame is NULL.
https://bugs.webkit.org/show_bug.cgi?id=68753

BitmapImage::drawFrameMatchingSourceSize causes an access violation
if BitmapImage::frameAtIndex returns NULL. (Found by David Delaune).

Reviewed by Simon Fraser.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::drawFrameMatchingSourceSize): Check for null
cairo_surface_t pointer and avoid dereferencing.

2:25 PM Changeset in webkit [135658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Refactor RenderThemeEfl::getThemePartFromCache()
https://bugs.webkit.org/show_bug.cgi?id=103186

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Refactor getThemePartFromCache() so that a list is used
for the cache instead of a vector. The function moves
items to the head of the container which is much more
efficient with a list than a vector.

The list ordering is also slightly altered so that the
cached parts that were used last come first. Previously,
they were sorted by creation time which may cause an
item to be removed from the cache because it is older
even if is was used recently.

This patch also gets rid of some code duplication at the
end of the function.

No new tests, no behavior change.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::ThemePartCacheEntry::create): Return
a smart pointer instead of a raw pointer.
(WebCore::RenderThemeEfl::getThemePartFromCache):
(WebCore::RenderThemeEfl::clearThemePartCache): Rename
flushThemePartCache to clearThemePartCache for clarity.
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::~RenderThemeEfl):

  • platform/efl/RenderThemeEfl.h:

(ThemePartCacheEntry):
(RenderThemeEfl):

12:34 PM Changeset in webkit [135657] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
https://bugs.webkit.org/show_bug.cgi?id=103185
RIM PR 250114

Patch by Liam Quinn <lquinn@rim.com> on 2012-11-24
Reviewed by George Staikos.

Make our MediaPlayer implementation indicate that it supports RTSP. That way, DOMImplementation::createDocument will create the same MediaDocument as is used for HTTP videos.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::supportsType):

12:31 PM Changeset in webkit [135656] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Put computed style 'font-family' values in the CSSValuePool.
<http://webkit.org/b/103184>

Reviewed by Ojan Vafai.

Use CSSValuePool::createFontFamilyValue() when handing out 'font-family' values from CSSComputedStyleDeclaration.
This avoids creating extra CSSPrimitiveValue objects since we already have these in the pool from parsing.
Also added a max capacity to the font-family cache (using random eviction.)

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

11:35 AM Changeset in webkit [135655] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Text not selected when input field focused.
https://bugs.webkit.org/show_bug.cgi?id=103182

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-24
Reviewed by George Staikos.

Reviewed Internally by: Mike Fenton, Eli Fidler
PR #250163

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectObject):

11:24 AM Changeset in webkit [135654] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: updated expectations for failures in:

  • http/tests/local/drag-over-remote-content.html

https://bugs.webkit.org/show_bug.cgi?id=103181

  • media/video-seek-past-end-playing.html

https://bugs.webkit.org/show_bug.cgi?id=103183

  • platform/chromium/TestExpectations:
9:15 AM Changeset in webkit [135653] by zandobersek@gmail.com
  • 11 edits in trunk/Tools

Add the --order option to NRWT
https://bugs.webkit.org/show_bug.cgi?id=102229

Reviewed by Dirk Pranke.

The --order option controls in what order the gathered tests will be run.
There are 3 options:

  • natural, the tests are sorted in natural order,
  • random, the tests are sorted in random order,
  • none, the tests are kept in the order in which they were specified through

arguments or the test list.

The natural option is the default one and maintains the current behavior.

The none option is primarily intended to be used with the --test-list option,
with the test list file expected to list specific test names.
When a directory is specified as one of the paths from under which tests should
be gathered and the none option is used, that path will expand to all the tests
under it, with these tests sorted in the natural order.

Using --order=random duplicated the behavior of the --randomize-order option, so
the latter is removed.

This patch also incorporates the change with which makes it is possible to specify
a test via arguments or the test list multiple tests and then have the test run
that many times.

  • Scripts/webkitpy/common/find_files.py:

(find): Accept an optional sorting key that is used to sort files found in the directories
that the given paths specify.
(_normalized_find): Both paths that are then searched for the tests and the tests that
were found are now kept in lists. This makes it possible to run a test multiple times
by specifying it multiple times through arguments or the test list file.
(_normalized_find.sort_by_directory_key):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
(LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.init): The Sharder class no longer needs a test path separator.
(Sharder.init): Ditto.
(Sharder._resize_shards):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(SharderTests.get_shards): Modify the Shader initializing as required.
(SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
are now moved to the base Port unit tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
the new --order option.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.tests): This method should now return a list of all the tests found in the specified
paths.
(Port._real_tests): A list is required, so no conversion to a set is made.
(Port):
(Port.test_key): Place this method here for now, but it should really move into a separate
module.
(Port._natural_sort_key): Ditto.
(Port._natural_sort_key.tryint):
(Port._virtual_tests): A list is required, so the function now operates on that rather than
on a set.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
list rather than an empty set.
(PortTest.test_dont_require_http_server):
(NaturalCompareTest): The natural sorting unit tests are placed here for now.
(NaturalCompareTest.assert_cmp):
(NaturalCompareTest.test_natural_compare):
(KeyCompareTest): The test name key unit tests are placed here for now.
(KeyCompareTest.assert_cmp):
(KeyCompareTest.test_test_key):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
by using --order=random.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering

various aspects of this change.
(MainTest.test_natural_order):
(MainTest):
(MainTest.test_natural_order_test_specified_multiple_times):
(MainTest.test_random_order):
(MainTest.test_random_order_test_specified_multiple_times):
(MainTest.test_no_order):
(MainTest.test_no_order_test_specified_multiple_times):
(MainTest.test_no_order_with_directory_entries_in_natural_order):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.execute): Operate on a set of tests when printing out expectations.

8:46 AM Changeset in webkit [135652] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Check errors in EwkView callbacks usage at compile time
https://bugs.webkit.org/show_bug.cgi?id=103177

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Errors in EwkView callbacks usage are now checked at compile time.

  • UIProcess/API/efl/EwkViewCallbacks.h:

(CallBack):
(EwkViewCallbacks::CallBack::CallBack):
(EwkViewCallbacks::CallBack::call):

7:32 AM Changeset in webkit [135651] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r135648 and r135649.
http://trac.webkit.org/changeset/135648
http://trac.webkit.org/changeset/135649
https://bugs.webkit.org/show_bug.cgi?id=103176

This change cannot be built with a qt-minimal configuration.
(Requested by zalbisser on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-24

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

7:11 AM Changeset in webkit [135650] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

It's confusing that return values of 'bool Node::dispatchEvent(...)' and 'bool Node::dispatchMouseEvent(..)' have the opposite meanings.
https://bugs.webkit.org/show_bug.cgi?id=103058

Reviewed by Ojan Vafai.

Refactor MouseEventDispatchMediator::dispatchEvent() and
EventHandler::dispatchMouseEvent() so that they return bool
which has the same meaning of the return value of
Node::dispatchEvent().

No tests. No change in behavior.

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):

7:11 AM Changeset in webkit [135649] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed Qt build fix:

Make sure QGLWidget definition is available.

  • WebCoreSupport/PageClientQt.cpp:
6:41 AM Changeset in webkit [135648] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103142

When creating the TextureMapperGL for WK1 we have to make sure
that the GL context provided by the QGLWidget is current.
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
the wrong pointer by calling QOpenGLContext::currentContext().

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

3:28 AM Changeset in webkit [135647] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
2:50 AM Changeset in webkit [135646] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r135600.
http://trac.webkit.org/changeset/135600
https://bugs.webkit.org/show_bug.cgi?id=103173

It made EFL API test is failed (Requested by gyuyoung_mbp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-24

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/efl/PlatformUtilities.cpp:

(TestWebKitAPI::Util::sleep):

  • TestWebKitAPI/efl/PlatformWebView.cpp:
2:05 AM Changeset in webkit [135645] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Too many tests come to crashe after build 7830 on
EFL Linux 64-bit Release bot.

  • platform/efl-wk1/TestExpectations:
12:51 AM Changeset in webkit [135644] by kov@webkit.org
  • 11 edits in releases/WebKitGTK/webkit-1.10

[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435

Reviewed by Martin Robinson.

More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.

.:

  • GNUmakefile.am: add variable that will hold the list of source files

for libWebCorePlatform .

Source/WebCore:

  • GNUmakefile.am: add new libWebCorePlatform convenience library.
  • GNUmakefile.list.am: move list of platform/* files to its own variable.

Source/WebKit/gtk:

  • GNUmakefile.am: link libWebCorePlatform into libwebkitgtk

Source/WebKit2:

  • GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk

Tools:

  • GNUmakefile.am: link libWebCorePlatform into DRT

Conflicts:

Source/WebCore/GNUmakefile.am
Source/WebCore/GNUmakefile.list.am

Nov 23, 2012:

10:40 PM Changeset in webkit [135643] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=103167

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-23
Reviewed by Gyuyoung Kim.

Remove compile warning messages by omitting parameter name and using UNUSED_PARAM.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(webkitAccessibleHyperlinkIsSelectedLink):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextAfterOffset):
(webkitAccessibleTextGetTextAtOffset):
(webkitAccessibleTextGetTextBeforeOffset):
(webkitAccessibleTextGetOffsetAtPoint):

10:13 PM Changeset in webkit [135642] by Csaba Osztrogonác
  • 5 edits in trunk/Source

Unreviewed, rolling out r135575.
http://trac.webkit.org/changeset/135575
https://bugs.webkit.org/show_bug.cgi?id=103169

It made all tests assert (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-23

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit::initializeWebKitQt):

Source/WebKit2:

  • qt/MainQt.cpp:

(WebKit):
(main):

9:18 PM Changeset in webkit [135641] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

listMarkerText() should create 8 bit strings when possible
https://bugs.webkit.org/show_bug.cgi?id=103011

Reviewed by Filip Pizlo.

Made processing of marker text items use 8 bit strings where possible in order to reduce 16 bit strings.

Changes covered by existing tests.

  • rendering/RenderListMarker.cpp:

(WebCore::toRoman): Changed character constants and buffer to build string to LChar's
(WebCore::toAlphabeticOrNumeric): Made a template based on character type.
(WebCore::toSymbolic): Made a template based on character type.
(WebCore::toAlphabetic): Made a template based on character type.
(WebCore::toNumeric): Added character type template parameter.
(WebCore::listMarkerText): Changed character constants to LChar where possible.

7:16 PM Changeset in webkit [135640] by fpizlo@apple.com
  • 21 edits
    4 adds in trunk/Source

Any function that can log things should be able to easily log them to a memory buffer as well
https://bugs.webkit.org/show_bug.cgi?id=103000

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Change all users of WTF::dataFile() to expect a PrintStream& rather than a FILE*.

  • bytecode/Operands.h:

(JSC::OperandValueTraits::dump):
(JSC::dumpOperands):
(JSC):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::dump):

  • dfg/DFGCommon.h:

(JSC::DFG::NodeIndexTraits::dump):

  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):

  • dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpFillInfo):
(JSC::DFG::VariableEvent::dumpSpillInfo):

  • dfg/DFGVariableEvent.h:

(VariableEvent):

  • disassembler/Disassembler.h:

(JSC):
(JSC::tryToDisassemble):

  • disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassemble):

Source/WTF:

We have a number of places where we pass around a FILE* as a target to which to print
some logging information. But the purpose of passing FILE* instead of always assuming
that we should dump to stderr is that it may be sometimes useful to send the logging
information elsewhere. Unfortunately, FILE* isn't quite powerful enough: it's combersome
to use it to send logging to a string, for example.

We could get around this by using <iostream> and <sstream>, but so far this aspect of
C++ has not been part of the WebKit coding conventions. Personally I find <iostream>
awkward due to its abuse of operator overloading.

So this patch introduces the PrintStream abstract class, which offers printf-like
functionality while completely abstracting the destination and mechanism of the printing
output. It would be trivial to implement a StringPrintStream, for example. This will feed
into work on https://bugs.webkit.org/show_bug.cgi?id=102999.

This also sets us up for creating templatized print() and println() methods that will
allow us to say things like out.print("count = ", count, "\n"), but that is the topic
of https://bugs.webkit.org/show_bug.cgi?id=103009.

This patch also changes dataLog() to use FilePrintStream internally, and WTF::dataFile()
now returns a FilePrintStream&. Any previous users of WTF::dataFile() have been changed
to expect a PrintStream&.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/DataLog.cpp:

(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLogString):

  • wtf/DataLog.h:

(WTF):

  • wtf/FilePrintStream.cpp: Added.

(WTF):
(WTF::FilePrintStream::FilePrintStream):
(WTF::FilePrintStream::~FilePrintStream):
(WTF::FilePrintStream::vprintf):
(WTF::FilePrintStream::flush):

  • wtf/FilePrintStream.h: Added.

(WTF):
(FilePrintStream):
(WTF::FilePrintStream::file):

  • wtf/PrintStream.cpp: Added.

(WTF):
(WTF::PrintStream::PrintStream):
(WTF::PrintStream::~PrintStream):
(WTF::PrintStream::printf):
(WTF::PrintStream::print):
(WTF::PrintStream::println):
(WTF::PrintStream::flush):
(WTF::print):

  • wtf/PrintStream.h: Added.

(WTF):
(PrintStream):
(WTF::print):
(WTF::println):

5:30 PM Changeset in webkit [135639] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Define platform limitations in platform layer
https://bugs.webkit.org/show_bug.cgi?id=103160

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-23
Reviewed by Rob Buis.

Taking length as const unsigned in checkSpellingOfStringAsync.
This value is unchanging and should never be less than 0, even
in an error case.

Internally reviewed by Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

4:42 PM Changeset in webkit [135638] by rjkroege@chromium.org
  • 12 edits in trunk/Source

Remove unused ScrollByPixelVelocity
https://bugs.webkit.org/show_bug.cgi?id=102840

Reviewed by Sam Weinig.

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=80311 wrongly introduced a new
kind of scroll: "ScrollByPixelVelocity". This code is not used on any platform
and will not be of use in the future so this patch removes it.

No new tests: code removal/cleanup.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformWheelEvent.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollTypes.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll):

Source/WebKit/chromium:

Removed test for deleted code.

  • tests/ScrollAnimatorNoneTest.cpp:

Source/WTF:

The GESTURE_ANIMATION feature turns on code in WebCore is unused.
Remove it.

No new tests: code removal/cleanup.

  • wtf/Platform.h:
3:20 PM Changeset in webkit [135637] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: updated test expectations for failure in

  • svg/batik/text/textPosition2.svg

https://bugs.webkit.org/show_bug.cgi?id=103148

  • platform/chromium/TestExpectations:
3:02 PM Changeset in webkit [135636] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: text failures in:

  • inspector/console/command-line-api-inspect.html
  • inspector/runtime/runtime-localStorage-getProperties.html

https://bugs.webkit.org/show_bug.cgi?id=103161

  • platform/chromium/TestExpectations:
2:39 PM Changeset in webkit [135635] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: update test expectations for
svg/hixie/perf/007.xml

  • platform/chromium/TestExpectations:
2:24 PM Changeset in webkit [135634] by rjkroege@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104

Patch by Alexis Menard <alexis@webkit.org> on 2012-11-23
Reviewed by Julien Chaffraix.

Add new tests to cover the new parsing for the background position
property. For now the computed style checks are commented out because
the rendering part of the feature is not yet implemented (i.e.
FillLayer does not contain yet the feature and this is what
CSSComputedStyleDeclaration is using).

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:04 PM Changeset in webkit [135633] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Removing unnecessary RenderBox friend access in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=103159

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-11-23
Reviewed by Eric Seidel.

RenderObject has several classes marked as friend, between them,
there is RenderBox which is derived from it indirectly and is not accessing
its forefather private data making unnecessary the 'friend' access level.

No new tests, no changes in functionality.

  • rendering/RenderObject.h:

(RenderObject):

1:24 PM Changeset in webkit [135632] by alexis@webkit.org
  • 34 edits in trunk

[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104

Reviewed by Julien Chaffraix.

.:

Protect the new feature behind a feature flag.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

Protect the new feature behind a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Implement the parsing of the CSS3 background-position property which
allows to specify up to four values to position the background. It is
documented here :
http://www.w3.org/TR/css3-background/#the-background-position . I
decided to split up the patch is two pieces, the parsing and later I
will do the rendering. I kept the old code as much as possible (i.e.
the two values parsing) as it is used not only by background-position
but by few other properties. The new four values support is only valid
on the property itself but does not work on the shorthand.

Opera has already implemented this feature.

I extended backgrounds/background-position-parsing-2.html to cover the
new possible values as well as buggy values.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillPositionComponent): Modify this function
to allow creation of CSS primitive values with not only percentage or
length but with keywords also as the new <position> type allows to
specify keywords, for example top 30px right 20px.
(WebCore):
(WebCore::isValueConflictingWithCurrentEdge):
(WebCore::isBackgroundPositionKeyword):
(WebCore::CSSParser::parse3ValuesBackgroundPosition):
(WebCore::CSSParser::parse4ValuesBackgroundPosition):
(WebCore::CSSParser::parseFillBackgroundPosition): This function counts
the number of words for the property value and call dedicated parsing
functions for each case. Note that in case of two values we just call the old CSS 2.1
method.
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty): Only call the new parsing
function if the feature is activated otherwise fallback to the old code
path.

  • css/CSSParser.h:

Source/WebKit/chromium:

Protect the new feature behind a feature flag.

  • features.gypi:

Source/WebKit/mac:

Protect the new feature behind a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Protect the new feature behind a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Protect the new feature behind a feature flag.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Protect the new feature behind a feature flag.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add new tests to cover the new parsing for the background position
property. For now the computed style checks are commented out because
the rendering part of the feature is not yet implemented (i.e.
FillLayer does not contain yet the feature and this is what
CSSComputedStyleDeclaration is using).

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:32 AM Changeset in webkit [135631] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Adding failure expectation for fast/dom/shadow/host-wrapper-reclaimed.html.

  • platform/gtk/TestExpectations:
11:17 AM Changeset in webkit [135630] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: updated test expecations -- additional failures in

  • fast/text/large-text-composed-char.html
  • fast/text/text-letter-spacing.html
  • http/tests/inspector/indexeddb/database-data.html

and new failures:

  • fast/frames/frame-unload-crash2.html
  • platform/chromium/TestExpectations:
10:43 AM Changeset in webkit [135629] by junov@google.com
  • 26 edits
    2 adds in trunk

Adding occlusion detection to reduce overdraw in RenderBox background rendering
https://bugs.webkit.org/show_bug.cgi?id=102557

Reviewed by Stephen White.

Source/WebCore:

Adding hasAlpha method to all classes dervived from CSSImageValue and
StyleImage, in order to support occlusion testing.
This allows the FillLayer recursion to stop early when an opaque layer
is encountered while applying a CSS background style. This also allows
the elimination of background color application when the background is
completely covered by an image. The optimization also skips the
clearing of the page's root element when the page background is
entirely covered by an image (e.g a tiled bitmap or a gradient)

Test: fast/backgrounds/background-opaque-images-over-color.html

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageHasAlpha):
(WebCore):
(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::hasAlpha):

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::hasAlpha):
(WebCore):

  • css/CSSGradientValue.h:

(CSSGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::hasAlpha):
(WebCore):

  • css/CSSImageGeneratorValue.h:

(CSSImageGeneratorValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::hasAlpha):
(WebCore):

  • css/CSSImageValue.h:

(WebCore):
(CSSImageValue):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::currentFrameHasAlpha):
Test whether a cached image has alpha, with side effect of ensuring
the image is in cache. (new method)
(WebCore):

  • loader/cache/CachedImage.h:

(CachedImage):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):
Added layer recursion early exit when an opaque layer is encountered.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Eliminated background color fill when the layer contains an opaque
image that covers the entire RenderBox.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):
Returns true if the layer's image is known to be fully opaque.
(WebCore):
(WebCore::FillLayer::hasRepeatXY):

  • rendering/style/FillLayer.h:

(FillLayer):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::hasAlpha):
(WebCore):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::hasAlpha):
(WebCore):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::hasAlpha):
(WebCore):

  • rendering/style/StyleGeneratedImage.h:

(StyleGeneratedImage):

  • rendering/style/StyleImage.h:

(StyleImage):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::hasAlpha):

LayoutTests:

New test exercises different CSS background style use cases that
are candidates for optimization by occlusion culling.

  • fast/backgrounds/background-opaque-images-over-color-expected.txt: Added.
  • fast/backgrounds/background-opaque-images-over-color.html: Added.
  • platform/chromium/TestExpectations:
10:39 AM Changeset in webkit [135628] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Gardening: updated expectations (pass/timeout) for
week-multiple-fields-preserve-value-after-history-back.html
https://bugs.webkit.org/show_bug.cgi?id=103152

  • platform/chromium/TestExpectations:
10:17 AM Changeset in webkit [135627] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Adapt accessibility feature to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=100757

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-11-23
Reviewed by Laszlo Gombos.

Skipping Accessibility tests for wk1/wk2.
Some of the implementation is still missing.

  • platform/efl/TestExpectations:
9:15 AM Changeset in webkit [135626] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my e-mail address.

  • Scripts/webkitpy/common/config/committers.py:
9:13 AM Changeset in webkit [135625] by junov@google.com
  • 4 edits
    2 adds in trunk

Page background color bleeds through inner edge of div border with rounded edges
https://bugs.webkit.org/show_bug.cgi?id=103089

Reviewed by Stephen White.

Source/WebCore:

Test that verifies whether a RenderBoxEdge is more than 2 pixels wide
was applying the content scale factor backwards, so the
obscuresBackgroundEdge was falsely passing for downsized boxes.

Test: fast/backgrounds/gradient-background-leakage-2.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::obscuresBackgroundEdge):

LayoutTests:

New layout test to verify that there is no color bleeding between
a div element's border and background when there are rounded corners
an a scale that reduces a thick border down to a width of less than
two pixels.

  • fast/backgrounds/gradient-background-leakage-2-expected.txt: Added.
  • fast/backgrounds/gradient-background-leakage-2.html: Added.
  • platform/chromium/TestExpectations:
9:10 AM Changeset in webkit [135624] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Match the behavior of selfOrAncestorHaveNonAffineTransforms() to its name.
https://bugs.webkit.org/show_bug.cgi?id=103097

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms() does
not check its ancestor. This patch makes this method check its ancestor
to match its name.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):

9:06 AM Changeset in webkit [135623] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Gardening: update expectations for fast/events/stopPropagation-submit.html flaky
https://bugs.webkit.org/show_bug.cgi?id=103149

  • platform/chromium/TestExpectations:
8:57 AM Changeset in webkit [135622] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: LayerTreeRenderer::removeTile() does not remove tiles actually.
https://bugs.webkit.org/show_bug.cgi?id=103030

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

LayerTreeRenderer::removeTile() must add a backing store into
m_backingStoresWithPendingBuffers. Otherwise, tiles are not removed.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeTile):

8:54 AM Changeset in webkit [135621] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Add support for winflexbison distribution
https://bugs.webkit.org/show_bug.cgi?id=102551

Reviewed by Laszlo Gombos.

Since GnuWin32 does not provide recent versions of bision and flex supporting
the alternative winflexbison distribution is the prefered option.

  • Source/cmake/WebKitMacros.cmake:
8:51 AM Changeset in webkit [135620] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[TexMap] Remove dependency of TextureMapperLayer on GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103046

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

Source/WebCore:

It is a preparation patch for Threaded Coordinated Graphics on WK1.

We want to make TextureMapperLayer into an actor model. After making an actor
model, GraphicsLayerTextureMapper and LayerTreeRenderer will communicate with
TextureMapperLayer using message passing. In the first step, we want to hide
GraphicsLayerTextureMapper from TextureMapperLayer.

There are 2 kinds of dependencies of TextureMapperLayer in GraphicsLayerTextureMapper.

  1. To query layer states
  2. To paint layer contents

In this patch, we removed the second dependency. Currently, TextureMapperLayer
requests painting contents to GraphicsLayerTextureMapper in WK1 while
Coordinated Graphics prepares the contents in LayerTreeRenderer. This patch
makes WK1 prepare the contents in GraphicsLayerTextureMapper like
LayerTreeRenderer.

We will remove the first dependency in a follow-up patch.

Covered by existing layout tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::didFlushCompositingState):
(WebCore::GraphicsLayerTextureMapper::didFlushCompositingStateRecursive):
(WebCore::GraphicsLayerTextureMapper::updateBackingStore):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStore):
(WebCore::GraphicsLayerTextureMapper::shouldHaveBackingStore):
(WebCore::GraphicsLayerTextureMapper::drawRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::setDebugBorder):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setHasOwnBackingStore):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::textureMapper):
(WebCore):
(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(State):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit2:

This patch makes GraphicsLayerTextureMapper create its own backing
store. However, LayerTreeRenderer also creates its own backing store. So
when LayerTreeRenderer uses GraphicsLayerTextureMapper,
LayerTreeRenderer needs GraphicsLayerTextureMapper to not create its own
backing store.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::getBackingStore):

8:47 AM Changeset in webkit [135619] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=100757

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-23
Reviewed by Laszlo Gombos.

Tools:

Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
Updating CMake files due to changes from Bug 99011.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::AccessibilityController):
(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:

(AccessibilityController):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
  • WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.

LayoutTests:

Unskipping EFL Accessiblity tests for wk2.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
8:40 AM Changeset in webkit [135618] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

[ENCHANT] Infinite loop when end word position is not found
https://bugs.webkit.org/show_bug.cgi?id=103139

Reviewed by Martin Robinson.

Covered by existing tests in editing/spelling.

  • editing/visible_units.cpp:

(WebCore::isLogicalStartOfWord): Make it private again.
(WebCore::islogicalEndOfWord): Ditto.

  • editing/visible_units.h:
  • platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::checkSpellingOfWord): Helper funtion
to check a word inside a string using the loaded dictionaries.
(WebCore::TextCheckerEnchant::checkSpellingOfString): Optimize and
simply the code by using the word iterator to iterate the
words.

  • platform/text/enchant/TextCheckerEnchant.h:

(TextCheckerEnchant):

8:38 AM Changeset in webkit [135617] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: test expectations failures.
https://bugs.webkit.org/show_bug.cgi?id=103148

  • platform/chromium/TestExpectations:
8:37 AM Changeset in webkit [135616] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r135486): ASSERT(isMainThread()) hit in LayerTreeRenderer::setActive(bool)
https://bugs.webkit.org/show_bug.cgi?id=103077

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.

Currently, the painting thread uses purgeGLResources() and setActive().
QQuickWebPage::updatePaintNode() indirectly calls both methods after
locking the main thread.

This patch changes two points.

  1. Remove ASSERT(isMainThread()) in methods that the painting thread can

call.

  1. Make purgeGLResources() and setActive() call methods of

LayerTreeCoordinatorProxy via dispatchOnMainThread().

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit):
(WebKit::LayerTreeRenderer::purgeBackingStores):
(WebKit::LayerTreeRenderer::setActive):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

8:27 AM Changeset in webkit [135615] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Meta viewport can't be changed dynamically
https://bugs.webkit.org/show_bug.cgi?id=103098

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

PR: 237072
Reset m_userPerformedManualZoom and enable
m_shouldZoomToInitialScaleAfterLoadFinished so that we can relayout the
page and zoom it to fit the screen when we dynamically change the meta
viewport after the load is finished.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

8:15 AM Changeset in webkit [135614] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: update expectations for now crashing test
visibility-simple-canvas2d-layer.html
https://bugs.webkit.org/show_bug.cgi?id=98086

  • platform/chromium/TestExpectations:
8:11 AM Changeset in webkit [135613] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Drop Synchronous Mouse Events
https://bugs.webkit.org/show_bug.cgi?id=102980

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-23
Reviewed by Rob Buis.

Reviewed Internally by George Staikos and Mike Lattanzio.
Don't send actual Touch Events to fullscreen plugins unless
its a Touch Cancel, DoubleTap or TouchHold.
Instead send mouse events as long as its a single finger.
PR #242781

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):

7:36 AM Changeset in webkit [135612] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Define WTF_PLATFORM_EFL in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=101482

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

.:

Remove the definition of WTF_PLATFORM_EFL from the build system to
make the EFL port consistent with other ports.

  • Source/cmake/OptionsEfl.cmake:

Source/WTF:

Define WTF_PLATFORM_EFL in Platform.h to be consistent with
other ports.

  • wtf/Platform.h:
7:34 AM Changeset in webkit [135611] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] GraphicsContext3DQt makes wrong surface current.
https://bugs.webkit.org/show_bug.cgi?id=103136

blitMultisampleFramebufferAndRestoreContext restores
the wrong surface in case the currentContext is the same
as m_platformContext.
In this case we would reset the bound surface to NULL.
Instead we should just leave the context unchanged.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):

7:32 AM Changeset in webkit [135610] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Fix the ARM traditional build after r135330
https://bugs.webkit.org/show_bug.cgi?id=102871

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-23
Reviewed by Zoltan Herczeg.

Added missing functionality to traditional ARM architecture.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::revertJump):
(ARMAssembler):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerARM::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):

7:15 AM Changeset in webkit [135609] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] EwkViewImpl::transformToScreen() does not retrieve the Ecore_X_Window properly
https://bugs.webkit.org/show_bug.cgi?id=103133

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

If accelerated compositing is enabled, EwkViewImpl::transformToScreen() should
attempt to retrieve the Ecore_X_Window using ecore_evas_gl_x11_window_get() first
and only fall back to ecore_evas_software_x11_window_get().

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::transformToScreen):

7:13 AM Changeset in webkit [135608] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: remove total item from NMI snapshot grid
https://bugs.webkit.org/show_bug.cgi?id=101926

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-23
Reviewed by Yury Semikhatsky.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotDataGrid):

7:11 AM Changeset in webkit [135607] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] GraphicsContext3DQt should not overwrite glClearColor of sharing context.
https://bugs.webkit.org/show_bug.cgi?id=103135

In case we use GraphicsContext3DQt to render into or
read from an existing context, we should not reset
the glClearColor on construction.
Otherwise we might overwrite an existing definition from
the sharing context.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

7:01 AM Changeset in webkit [135606] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: damaging last chunk does not remove its garbage from DOM
https://bugs.webkit.org/show_bug.cgi?id=103132

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Removing everything between undamaged chunks, not registered chunk rows.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.firstElement):
(WebInspector.TextEditorMainChunk.prototype.lastElement):

LayoutTests:

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests.InspectorTest.dumpEditorModel):
(initialize_EditorTests.InspectorTest.dumpEditorDOM):
(initialize_EditorTests):

  • inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Added.
  • inspector/editor/text-editor-remove-chunks-from-dom.html: Added.
  • inspector/editor/text-editor-selection-expected.txt:
  • inspector/editor/text-editor-selection.html:
6:55 AM Changeset in webkit [135605] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderLayer minor clean-up: replace raw pointers with OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=103134

Reviewed by Eric Seidel.

I found that RenderLayer still uses raw pointers to the objects which it owns.
Looks like these pointers could be replaced with OwnPtrs.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::collectLayers):
(WebCore::RenderLayer::styleChanged):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::marquee):
(WebCore::RenderLayer::posZOrderList):
(WebCore::RenderLayer::negZOrderList):
(WebCore::RenderLayer::normalFlowList):
(RenderLayer):
(WebCore::RenderLayer::clearZOrderLists):

6:31 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Add rules to not use the C API (diff)
6:24 AM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos
Document WEBKIT_DEFINE_ macros (diff)
6:22 AM Changeset in webkit [135604] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][AC] Mouse cursor is not updated when accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=103131

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Make sure we try to get the Ecore_X_Window using ecore_evas_gl_x11_window_get()
in applyFallbackCursor() if accelerated compositing is enabled instead of
using ecore_evas_software_x11_window_get(). This fixes mouse cursor update
when accelerated compositing is enabled.

No new tests, no behavior change for layout tests.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::applyFallbackCursor):

6:08 AM Changeset in webkit [135603] by yurys@chromium.org
  • 18 edits
    2 adds in trunk

Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
https://bugs.webkit.org/show_bug.cgi?id=102510

Reviewed by Pavel Feldman.

Source/JavaScriptCore:

Added new symbols for the methods that have moved into .../wtf/MemoryInstrumentation.cpp

Source/WebCore:

Added necessary includes where MemoryObjectInfo declaration is required.

  • platform/audio/FFTFrame.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:

Source/WTF:

Moved MemoryObjectInfo into separate header. Moved definition of MemoryInstrumentation
methods that depend on MemoryObjectInfo declaration into MemoryInstrumentation.cpp to
make MemoryInstrumentation require only forward declaration of MemoryObjectInfo.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • wtf/CMakeLists.txt:
  • wtf/MemoryInstrumentation.cpp: Added.

(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(WTF::MemoryInstrumentation::~MemoryInstrumentation):
(WTF::MemoryInstrumentation::getObjectType): this method allows to get object type without
pulling in MemoryObjectInfo.h and all its dependencies.
(WTF::MemoryInstrumentation::callReportObjectInfo):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::InstrumentedPointerBase):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::process):
(WTF::MemoryClassInfo::init):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addRootObject):
(InstrumentedPointerBase):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(InstrumentedPointer):
(WTF::MemoryInstrumentation::addObject): we now pass owner's MemoryObjectInfo in all places
where we report objects pointed by the owner.
(WTF::MemoryInstrumentation::OwningTraits::addObject):
(WTF::MemoryClassInfo::MemoryClassInfo):
(WTF::MemoryClassInfo::addMember):
(MemoryClassInfo):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF::::InstrumentedPointer):
(WTF::::callReportMemoryUsage):

  • wtf/MemoryObjectInfo.h: Added.

(WTF):
(MemoryObjectInfo):
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::objectType):
(WTF::MemoryObjectInfo::objectSize):
(WTF::MemoryObjectInfo::reportedPointer):
(WTF::MemoryObjectInfo::memoryInstrumentation):
(WTF::MemoryObjectInfo::reportObjectInfo):

Tools:

Added missing includes.

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
6:05 AM Changeset in webkit [135602] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit/qt

tst_qwebpage fails after QMimeDatabase patch
https://bugs.webkit.org/show_bug.cgi?id=103125

Reviewed by Simon Hausmann.

Replace the static extension->mimetype table with a QMimeDatabase lookup

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::findText):
(tst_QWebPage::supportedContentType):

5:44 AM Changeset in webkit [135601] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-23
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/V8PerContextData.h:
  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

5:38 AM Changeset in webkit [135600] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=103123

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
WebKit2 API test ResponsivenessTimerDoesntFireEarly.

  • TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly

test.

  • TestWebKitAPI/efl/PlatformUtilities.cpp:

(TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
test case is passing 0.5 seconds to sleep.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
(TestWebKitAPI):

5:25 AM Changeset in webkit [135599] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Refine JsDoc in ProfilesPanel.js
https://bugs.webkit.org/show_bug.cgi?id=103042

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-23
Reviewed by Yury Semikhatsky.

I'm going to make profiler output typed.

This will require some amount of refactoring.

Before refactoring I would like to make things
unambiguous by adding JsDoc where they are missing.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._onToggleProfiling):
Added to eliminate parameter type ambiguity.

5:11 AM Changeset in webkit [135598] by tkent@chromium.org
  • 12 edits in trunk

Correct input[type=number] value sanitization for user-input
https://bugs.webkit.org/show_bug.cgi?id=103018

Reviewed by Kentaro Hara.

Source/WebCore:

If a number field has non-number string, HTMLInputElement::value is not
updated and returns the past valid value. It doesn't match to the value
sanitization algorithm defined by the HTML standard [1], and Opera's
behavior. We should sanitize non-number strings to "".

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#number-state-(type=number)

The value sanitization algorithm is as follows: If the value of the
element is not a valid floating-point number, then set it to the empty
string instead.

No new tests. Update existing tests;
fast/forms/number/number-commit-valid-only.html and
fast/forms/number/number-unacceptable-style.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged):
Remove isAcceptableValue check.

  • html/HTMLInputElement.h:

(HTMLInputElement): isAcceptableValue is no longer needed.

  • html/InputType.cpp: Remove isAcceptableValue.
  • html/InputType.h: Ditto.
  • html/NumberInputType.cpp: Ditto.

(WebCore::NumberInputType::hasUnacceptableValue):
Fold the isAcceptableValue content into this.

  • html/NumberInputType.h:

(NumberInputType): Remove isAcceptableValue.

LayoutTests:

  • fast/forms/number/number-commit-valid-only-expected.txt:
  • fast/forms/number/number-commit-valid-only.html:

Update the expected HTMLInputElement::value results.

  • fast/forms/number/number-unacceptable-style-expected.txt:
  • fast/forms/number/number-unacceptable-style.html:

Add some checks for HTMLInputElement::value.

5:11 AM Changeset in webkit [135597] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] JavaScriptCore JIT build is broken since r130839
Add missing implementation for sh4 arch.
https://bugs.webkit.org/show_bug.cgi?id=101479

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-23
Reviewed by Filip Pizlo.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8Signed):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Signed):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::store16):
(JSC::MacroAssemblerSH4::moveDoubleToInts):
(JSC::MacroAssemblerSH4::moveIntsToDouble):
(JSC::MacroAssemblerSH4::loadFloat):
(JSC::MacroAssemblerSH4::loadDouble):
(JSC::MacroAssemblerSH4::storeFloat):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::addDouble):
(JSC::MacroAssemblerSH4::convertFloatToDouble):
(JSC::MacroAssemblerSH4::convertDoubleToFloat):
(JSC::MacroAssemblerSH4::urshift32):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::sublRegReg):
(JSC::SH4Assembler::subvlRegReg):
(JSC::SH4Assembler::floatfpulfrn):
(JSC::SH4Assembler::fldsfpul):
(JSC::SH4Assembler::fstsfpul):
(JSC::SH4Assembler::dcnvsd):
(SH4Assembler):
(JSC::SH4Assembler::movbRegMem):
(JSC::SH4Assembler::sizeOfConstantPool):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::printInstr):
(JSC::SH4Assembler::printBlockInstr):

4:57 AM Changeset in webkit [135596] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r135592.
http://trac.webkit.org/changeset/135592
https://bugs.webkit.org/show_bug.cgi?id=103126

broke Chromium Mac compilation (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-23

  • WebCore.gypi:
4:55 AM Changeset in webkit [135595] by commit-queue@webkit.org
  • 14 edits in trunk

[WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
https://bugs.webkit.org/show_bug.cgi?id=86881

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

InjectedBundle API extended to retrieve contextMenu entries names.
WebContextMenu exteded with function to retrieve menu items.
This API is required by layout tests.
Common code in WebContextMenu.cpp moved to separate method menuItemsWithUserData().
Behaviour of dependend methods is unchanged.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetContextMenuEntriesNames):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::items):
(WebKit):

  • WebProcess/WebPage/WebContextMenu.h:

(WebContextMenu):

Tools:

eventSender object extended with contextClick() method in WebKitTestRunner.
contextClick() method returns an array of menu items objects with field 'title' containing title of single
context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
delivered in this patch.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::contextClick):
(WTR):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

LayoutTests:

Added expected results for two tests for EFL platform. Test expectations changed
for EFL WK1/WK2 and GTK platforms

  • platform/efl/TestExpectations:
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/gkt-wk2/TestExpectations:
  • platform/gtk/editing/selection/5354455-2-expected.txt:
  • platform/efl/editing/selection/5354455-2-expected.txt: Added.
  • platform/efl/fast/events/context-no-deselect-expected.txt: Added.
4:54 AM Changeset in webkit [135594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
https://bugs.webkit.org/show_bug.cgi?id=103091

Patch by Andrew Lo <anlo@rim.com> on 2012-11-23
Reviewed by Yong Li.

Internally reviewed by Mike Fenton.
Internal PR249523
Incorrectly used y coordinate as x coordinate in
InputHandler::ensureFocusTextElementVisible.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

4:48 AM Changeset in webkit [135593] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Fix Chromium Win compilation after r135580.
https://bugs.webkit.org/show_bug.cgi?id=101772

  • tests/WebFrameTest.cpp:
4:38 AM Changeset in webkit [135592] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove references to non-chromium entries from WebCore.gypi (part 2)
https://bugs.webkit.org/show_bug.cgi?id=103124

Reviewed by Pavel Feldman.

  • WebCore.gypi: removed references to gtk, cocoa, posix, ios, cf, win and mac
4:20 AM Changeset in webkit [135591] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: [Canvas] add startCapturing and stopCapturing methods to protocol
https://bugs.webkit.org/show_bug.cgi?id=103053

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-23
Reviewed by Pavel Feldman.

Add startCapturing and stopCapturing methods to the protocol to instrument several canvas frames in a row.
Drive-by: support start offset index in retrieving trace logs in the backend as well as "alive" flag.

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptCanvasModule::startCapturing):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::stopCapturing):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):

4:15 AM Changeset in webkit [135590] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Newly added tests in r135436 and r135456 are failng
https://bugs.webkit.org/show_bug.cgi?id=103112

Unreviewed EFL gardening.

Skip new failing tests introduced in r135436 and r135456.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-23

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:09 AM Changeset in webkit [135589] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening, skip failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
4:08 AM Changeset in webkit [135588] by caseq@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: dispatch events upon certain user actions on inspector's notification services
https://bugs.webkit.org/show_bug.cgi?id=103114

Reviewed by Pavel Feldman.

Add a bunch of WebInspector.UserMetrics.UserAction, so platform-specific code can wire to user actions
without breaking too often.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView.prototype._tabSelected.set WebInspector):
(WebInspector.NetworkItemView.prototype._tabSelected):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkDataGridNode.prototype.select):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

  • inspector/front-end/UserMetrics.js:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.js:

(WebInspector._requestZoom.set var):
(WebInspector._requestZoom):

3:52 AM Changeset in webkit [135587] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

WebSocket's MessageEvent.origin attribute is an empty string
https://bugs.webkit.org/show_bug.cgi?id=102889

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kentaro Hara.

Source/WebCore:

Fix WebSocket implementation so that the message event's origin
attribute is properly set to the Unicode serialization of the
origin of the URL that was passed to the WebSocket object's
constructor, instead of an empty string.

The new behavior is according to the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#feedback-from-the-protocol

It also matches the behavior of Firefox.

Tests: http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html

http/tests/websocket/tests/hybi/send-onmessage-origin.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(MessageEvent):

LayoutTests:

Add layout tests to check that the message event's origin attribute
is set to the Unicode serialization of the origin of the URL that
was passed to the WebSocket object's constructor, as per the
WebSocket specification.

  • http/tests/websocket/tests/hybi/send-blob-onmessage-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html: Added.
  • http/tests/websocket/tests/hybi/send-onmessage-origin-expected.txt: Added.
  • http/tests/websocket/tests/hybi/send-onmessage-origin.html: Added.
3:31 AM Changeset in webkit [135586] by caseq@chromium.org
  • 5 edits in trunk

Web Inspector: No "Save Heap Snapshot" option after canceling save to file dialog.
https://bugs.webkit.org/show_bug.cgi?id=100916

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-22
Reviewed by Yury Semikhatsky.

Source/WebCore:

Fixed order of operations - now receiver is assigned only when save
dialog responds.

  • inspector/front-end/HeapSnapshotView.js: Fixed order of operations.

LayoutTests:

Extracted "injectMockProfile" method and reused it in new test.

  • inspector/profiler/heap-snapshot-loader-expected.txt: Added test case.
  • inspector/profiler/heap-snapshot-loader.html:

Refactored and added new test case.

3:29 AM Changeset in webkit [135585] by Simon Hausmann
  • 5 edits in trunk

[Qt] Compiling against QtWebkit API requires QT_DLL to be defined
https://bugs.webkit.org/show_bug.cgi?id=102942

Reviewed by Tor Arne Vestbø.

Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
to follow the same rules as other Qt 5 modules, with the exception that instead of
QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
in other cross-platform header files to determine the correct meaning of export
macros.

Source/WebKit/qt:

  • Api/qwebkitglobal.h:

Tools:

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/win32/default_post.prf:
3:27 AM Changeset in webkit [135584] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] REGRESSION(r135507): It made 13 tests fail
https://bugs.webkit.org/show_bug.cgi?id=103069

Reviewed by Simon Hausmann.

Source/WebCore:

The subframe loading logic depends on that script extensions are not recognized,
so avoid recognizing them in getMIMETypeForExtension which is used for pre-load
mimetype detection.

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):

LayoutTests:

Unskip the last of test regressions now passing.

  • platform/qt/TestExpectations:
3:22 AM Changeset in webkit [135583] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r135455): Compilation without SVG enabled broken
https://bugs.webkit.org/show_bug.cgi?id=103108

Reviewed by Yury Semikhatsky.

Move SVG-only code behind #if ENABLE(SVG) that was accidentially moved
outside of the #if block during the refactoring.

  • platform/graphics/filters/FilterOperation.h:

(ReferenceFilterOperation):

3:17 AM Changeset in webkit [135582] by Simon Hausmann
  • 10 edits in trunk

[Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103111

Reviewed by Kenneth Rohde Christiansen.

This function was added as a slot during Qt 4.x times because adding
virtual functions breaks binary compatibility. This constraint is gone
with the initial release of WebKit with Qt 5, and therefore we can
make it virtual now.

The change is fully source compatible as existing "re-implementations"
as slots will now be called through it being a virtual function. They
become unused slots.

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::shouldInterruptJavaScript):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::shouldInterruptJavaScript):

  • WebCoreSupport/QWebPageAdapter.h:

(QWebPageAdapter):

  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage):

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(WebCore::WebPage::shouldInterruptJavaScript):
(WebPage):

  • QtTestBrowser/webpage.h:

(WebPage):

3:17 AM Changeset in webkit [135581] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations.

  • platform/chromium/TestExpectations:
3:15 AM Changeset in webkit [135580] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Remove WebScreenInfo.{horizontal,vertical}DPI
https://bugs.webkit.org/show_bug.cgi?id=101772

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-23
Reviewed by Adam Barth.

Now that nothing is using WebScreenInfo.{horizontal,vertical}DPI we can simply
remove them.

Source/Platform:

  • chromium/public/WebScreenInfo.h:

(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebKit/chromium:

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/win/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

  • src/x11/WebScreenInfoFactory.cpp:

(WebKit::WebScreenInfoFactory::screenInfo):

3:10 AM Changeset in webkit [135579] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/events/mouseover-button.html never releases a mouse button
https://bugs.webkit.org/show_bug.cgi?id=103041

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

mouseover-button.html released the wrong mouse button so subsequent
tests would fail: This includes at least svg/text/select-*.svg .

  • fast/events/mouseover-button.html:
2:59 AM Changeset in webkit [135578] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r128633): td changes size during re-layout of table although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802

Patch by Julian Pastarmov <pastarmovj@chromium.org> on 2012-11-23
Reviewed by Ojan Vafai.

Source/WebCore:

The bug was caused by incorrectly rewriting a nested condition which caused the else
clause to trigger in wrong cases.

Test: fast/table/nested-tables-with-div-offset.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Reverted wrong combination of nested if statements.

LayoutTests:

This test checks that table layout of some nested tables in quirks mode is computed correctly.

  • fast/table/nested-tables-with-div-offset-expected.txt: Added.
  • fast/table/nested-tables-with-div-offset.html: Added.
2:30 AM Changeset in webkit [135577] by allan.jensen@digia.com
  • 4 edits
    1 add in trunk

[Qt] REGRESSION(r135507): It made 13 tests fail
https://bugs.webkit.org/show_bug.cgi?id=103069

Reviewed by Simon Hausmann.

Source/WebCore:

Fix regression in recognizing MHTML on some platforms.

  • platform/qt/MIMETypeRegistryQt.cpp:

(ExtensionMap):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):

LayoutTests:

Unskip fixed test and update one benign change.

  • platform/qt/TestExpectations:
  • platform/qt/fast/preloader/script-expected.txt: Added.
2:18 AM Changeset in webkit [135576] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] REGRESSION(r135515): 3 appcache tests still failing
https://bugs.webkit.org/show_bug.cgi?id=103073

Rubber-stamped by Simon Hausmann.

Source/WebKit/qt:

Another sneaky typo.

  • Api/qwebpage.cpp:

(QWebPagePrivate::applicationCacheQuotaExceeded):

LayoutTests:

  • platform/qt/TestExpectations: Unskipped the affected tests.
2:17 AM Changeset in webkit [135575] by pierre.rossi@gmail.com
  • 5 edits in trunk/Source

[Qt] Avoid initializing PlatformStrategies twice.

Rubber-stamped by Simon Hausmann.

This fixes another regression introduced in r135515:
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
since it can be called from WebKit2 to initialize QStyle for testing.
This would then lead to things such as PlatformStrategies being
initialized twice.

Source/WebKit/qt:

  • Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit::initializeWebKitQt):

Source/WebKit2:

  • qt/MainQt.cpp: No need to initialize anything if we're not using QStyle.

(WebKit):
(main):

2:14 AM Changeset in webkit [135574] by pfeldman@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: ctrl+end in editor does not select the last symbol.
https://bugs.webkit.org/show_bug.cgi?id=103078

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/editor/text-editor-selection.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._handleScrollChanged):
(WebInspector.DefaultTextEditor.prototype.overrideViewportForTest):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._scrollTop):
(WebInspector.TextEditorChunkedPanel.prototype._clientHeight):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):

LayoutTests:

  • inspector/editor/editor-test.js: Added.

(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests):

  • inspector/editor/text-editor-selection-expected.txt: Added.
  • inspector/editor/text-editor-selection.html: Added.
1:57 AM Changeset in webkit [135573] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove references to non-chromium entries from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=103103

Reviewed by Pavel Feldman.

  • WebCore.gypi: Removed references to files specific for wince, cairo, qt, wx and efl.
1:55 AM Changeset in webkit [135572] by yurys@chromium.org
  • 4 edits
    2 moves
    6 adds in trunk/LayoutTests

Unreviewed. Updated test expectations.

  • platform/chromium-linux/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/text-orientation-basic-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/pdf-as-image-landscape-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk1/fast/transforms/transformed-focused-text-input-expected.png: Renamed from LayoutTests/platform/efl/fast/transforms/transformed-focused-text-input-expected.png.
  • platform/efl-wk1/fast/writing-mode/text-orientation-basic-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/text-orientation-basic-expected.png.
1:45 AM Changeset in webkit [135571] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: inspector overlay is always updated when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=103106

Reviewed by Pavel Feldman.

Provide empty size into the InspectorOverlay if the metrics emulation is disabled,
so that it will not get painted in all cases.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::webViewResized): Call InspectorPageAgent::webViewResized() rather than InspectorOverlay::resize().

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::webViewResized): Provide empty size into InspectorOverlay::resize() if device metrics are not emulated.

  • inspector/InspectorPageAgent.h:
1:29 AM Changeset in webkit [135570] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r135532. It made 3 tests fail.
https://bugs.webkit.org/show_bug.cgi?id=103073

Patch by János Badics <János Badics> on 2012-11-23

  • platform/qt/TestExpectations:
1:22 AM Changeset in webkit [135569] by commit-queue@webkit.org
  • 8 edits
    1 add
    1 delete in trunk

[EFL] Platform support for Accessibility feature.
https://bugs.webkit.org/show_bug.cgi?id=100848

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-11-23
Reviewed by Gyuyoung Kim.

.:

Add support for ATK library.

  • Source/cmake/FindATK.cmake: Added.
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add EFL platform's definitions to enable proper accessibility routines.

No new tests. Covered by existing layout tests.

  • PlatformEfl.cmake: Add accessibility/atk content to compilation.
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/efl/AccessibilityObjectEfl.cpp: Removed. No needed platform specific implementation. ATK shared implementation will be used.

Source/WTF:

Enable HAVE(ACCESSIBILITY) ifdefs so that EFL port can use it.

  • wtf/Platform.h:
1:13 AM Changeset in webkit [135568] by yurys@chromium.org
  • 11 edits
    3 moves
    1 add in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium-mac-lion/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-mac/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-mac/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
  • platform/efl-wk1/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
  • platform/efl-wk1/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png.
  • platform/efl-wk1/svg/batik/text/xmlSpace-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.png.
1:12 AM Changeset in webkit [135567] by Simon Hausmann
  • 5 edits in trunk/Source/WebKit/qt

Unreviewed trivial Qt/Win build fix:

Include FormState.h/HTMLFormElement.h in the FrameLoaderClient
declaration because MSVC needs it. Also fix Q_DECL_EXPORT declarations
for functions that are supposed to be exported.

  • Api/qwebelement.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InitWebCoreQt.h:

(WebKit):

  • WebCoreSupport/InitWebKitQt.h:

(WebKit):

1:10 AM EFLWebKit edited by k.czech@samsung.com
(diff)
1:00 AM Changeset in webkit [135566] by yurys@chromium.org
  • 1 edit
    2 moves
    8 adds in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium-mac-lion/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/font-weight-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac/fast/css/font-weight-1-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/pdf-as-image-expected.png: Added.
  • platform/chromium-win/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/chromium/fast/css/font-weight-1-expected.png.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/pdf-as-image-expected.png: Added.
  • platform/efl-wk1/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
12:30 AM Changeset in webkit [135565] by Carlos Garcia Campos
  • 31 edits in trunk/Source/WebKit2

[GTK] Use custom private macros to define GObjects
https://bugs.webkit.org/show_bug.cgi?id=99705

Reviewed by Martin Robinson.

Add WEBKIT_DEFINE_TYPE macros, similar and compatible with
G_DEFINE_TYPE macros, to define GObject types. These macros also
define the init and finalize functions reducing the GObject
boilerplate and hiding the placement new syntax that causes some
confusion. The patch replaces the use of G_DEFINE_TYPE macros by
WEBKIT_DEFINE_TYPE ones and removes the init and finalize
implementations, moving custom code when needed to the private
struct constructor/destructor or constructed/dispose virtual
methods when appropriate.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp:
  • UIProcess/API/gtk/WebKitBackForwardListItem.cpp:

(webkit_back_forward_list_item_class_init):

  • UIProcess/API/gtk/WebKitContextMenu.cpp:

(webkitContextMenuDispose):
(webkit_context_menu_class_init):

  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(_WebKitContextMenuItemPrivate::~_WebKitContextMenuItemPrivate):
(_WebKitContextMenuItemPrivate):
(webkit_context_menu_item_class_init):

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(_WebKitCookieManagerPrivate):

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_class_init):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(webkit_favicon_database_class_init):

  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkitFileChooserRequestDispose):
(webkit_file_chooser_request_class_init):

  • UIProcess/API/gtk/WebKitFindController.cpp:

(webkit_find_controller_class_init):

  • UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:

(webkitFormSubmissionRequestDispose):
(webkit_form_submission_request_class_init):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:

(webkitGeolocationPermissionRequestDispose):
(webkit_geolocation_permission_request_class_init):

  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkit_hit_test_result_class_init):

  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:

(webkit_navigation_policy_decision_class_init):

  • UIProcess/API/gtk/WebKitPlugin.cpp:

(_WebKitPluginPrivate::~_WebKitPluginPrivate):
(_WebKitPluginPrivate):
(webkit_plugin_class_init):

  • UIProcess/API/gtk/WebKitPolicyDecision.cpp:

(webkitPolicyDecisionDispose):
(webkit_policy_decision_class_init):
(webkit_policy_decision_use):
(webkit_policy_decision_ignore):
(webkit_policy_decision_download):

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):
(_WebKitPrintOperationPrivate):
(webkit_print_operation_class_init):

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:

(webkit_response_policy_decision_class_init):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(webkit_security_manager_class_init):

  • UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate::_WebKitSettingsPrivate):
(_WebKitSettingsPrivate):
(webkit_settings_class_init):

  • UIProcess/API/gtk/WebKitURIRequest.cpp:

(webkit_uri_request_class_init):

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkit_uri_response_class_init):

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_class_init):

  • UIProcess/API/gtk/WebKitWebContext.cpp:
  • UIProcess/API/gtk/WebKitWebInspector.cpp:

(_WebKitWebInspectorPrivate::~_WebKitWebInspectorPrivate):
(_WebKitWebInspectorPrivate):
(webkit_web_inspector_class_init):

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(webkit_web_resource_class_init):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate::~_WebKitWebViewPrivate):
(_WebKitWebViewPrivate):
(webkitWebViewConstructed):
(webkitWebViewDispose):
(webkit_web_view_class_init):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate):
(_WebKitWebViewBasePrivate):
(_WebKitWebViewBasePrivate::~_WebKitWebViewBasePrivate):
(webkitWebViewBaseDispose):
(webkitWebViewBaseConstructed):
(webkit_web_view_base_class_init):

  • UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp:

(webkit_web_view_base_accessible_class_init):

  • UIProcess/API/gtk/WebKitWindowProperties.cpp:

(webkit_window_properties_class_init):

12:06 AM Changeset in webkit [135564] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

Expose DOM interface for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95966

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added V8 and JSC bindings for CSS Device Adapation.

Test: css3/device-adapt/opera/cssom-001.xhtml

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::wrap):

  • css/CSSRule.idl:
  • css/WebKitCSSViewportRule.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Imported a test submitted by Opera that tests the exposed interface.

  • css3/device-adapt/opera/cssom-001-expected.txt: Added.
  • css3/device-adapt/opera/cssom-001.xhtml: Added.
  • platform/efl/fast/js/global-constructors-expected.txt:

Nov 22, 2012:

11:54 PM Changeset in webkit [135563] by yurys@chromium.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r135549.
http://trac.webkit.org/changeset/135549
https://bugs.webkit.org/show_bug.cgi?id=103102

Multiple layout test crashes (Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-22

Source/WebCore:

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:

(RenderTable):

LayoutTests:

  • fast/table/css-table-max-height-expected.txt: Removed.
  • fast/table/css-table-max-height.html: Removed.
11:44 PM Changeset in webkit [135562] by commit-queue@webkit.org
  • 8 edits in trunk

window is missing Touch and TouchList - touch event conformance test failure
https://bugs.webkit.org/show_bug.cgi?id=96295

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-22
Reviewed by Adam Barth.

Source/WebCore:

Add Touch and TouchList constructors to window for ENABLE(TOUCH_EVENTS).

Tests: fast/js/global-constructors.html

fast/events/touch/document-create-touch-list.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/touch/document-create-touch-list-expected.txt:
  • fast/events/touch/script-tests/document-create-touch-list.js: Add instanceof checks
  • platform/efl/fast/js/global-constructors-expected.txt: Add new expected constructors
  • platform/qt-5.0/fast/js/global-constructors-expected.txt: Add new expected constructors
  • platform/qt/fast/js/global-constructors-expected.txt: Add new expected constructors
11:35 PM Changeset in webkit [135561] by yurys@chromium.org
  • 45 edits
    3 copies
    24 moves
    77 adds
    2 deletes in trunk/LayoutTests

Unreviewed. Test expectations update after Skia changes.

  • fast/repaint/line-flow-with-floats-in-regions-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png.
  • platform/chromium-linux-x86/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux/fast/css/color-correction-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-background-image-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-backgrounds-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-text-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-linux/fast/css/color-correction-untagged-images-expected.png: Added.
  • platform/chromium-linux/fast/css/font-smoothing-expected.png: Added.
  • platform/chromium-linux/fast/history/visited-link-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/history/visited-link-background-color-expected.png.
  • platform/chromium-linux/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux/fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-rtl-override-selection-expected.png: Added.
  • platform/chromium-linux/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-2-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/chromium-mac-lion/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac-lion/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win-xp/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-win/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/history/visited-link-background-color-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/history/visited-link-background-color-expected.png.
  • platform/chromium/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
  • platform/chromium/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/efl-wk1/fast/css/font-smoothing-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-smoothing-expected.png.
  • platform/efl-wk1/fast/history/visited-link-background-color-expected.png: Renamed from LayoutTests/platform/efl/fast/history/visited-link-background-color-expected.png.
  • platform/efl-wk1/fast/images/imagemap-circle-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-circle-focus-ring-expected.png.
  • platform/efl-wk1/fast/images/imagemap-focus-ring-outline-color-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png.
  • platform/efl-wk1/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png.
  • platform/efl-wk1/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png.
  • platform/efl-wk1/fast/images/imagemap-polygon-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png.
  • platform/efl-wk1/fast/text/atsui-pointtooffset-calls-cg-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png.
  • platform/efl-wk1/fast/text/atsui-rtl-override-selection-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-rtl-override-selection-expected.png.
  • platform/efl-wk1/fast/text/line-initial-and-final-swashes-expected.png: Renamed from LayoutTests/platform/efl/fast/text/line-initial-and-final-swashes-expected.png.
  • platform/efl-wk1/fast/text/line-initial-and-final-swashes-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/line-initial-and-final-swashes-expected.txt.
  • platform/efl-wk1/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/efl-wk1/svg/batik/filters/filterRegions-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/filters/filterRegions-expected.png.
  • platform/efl-wk1/svg/batik/text/smallFonts-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/smallFonts-expected.png.
  • platform/efl-wk1/svg/batik/text/textDecoration-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration-expected.png.
  • platform/efl-wk1/svg/batik/text/textEffect-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect-expected.png.
  • platform/efl-wk1/svg/batik/text/textEffect2-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect2-expected.png.
  • platform/efl-wk1/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textFeatures-expected.png.
  • platform/efl-wk1/svg/batik/text/textLayout-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout-expected.png.
  • platform/efl-wk1/svg/batik/text/textLayout2-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout2-expected.png.
  • platform/efl-wk1/svg/batik/text/textProperties2-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties2-expected.png.
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
11:32 PM Changeset in webkit [135560] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Make worker context prototype chain match other browsers
https://bugs.webkit.org/show_bug.cgi?id=103057

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Adam Barth.

The following should be defined in a worker:
Object.getOwnPropertyDescriptor(this.proto, "postMessage")
It is currently undefined in chrome only. This patch fixes that.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

11:08 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update target versions after release (diff)
10:39 PM Changeset in webkit [135559] by commit-queue@webkit.org
  • 7 edits
    4 adds
    2 deletes in trunk/Source/WebKit

[BlackBerry] Update Web Notifications Implementation
https://bugs.webkit.org/show_bug.cgi?id=102621

Patch by Jeff Rogers <jrogers@rim.com> on 2012-11-22
Reviewed by George Staikos.

Source/WebKit:

Reviewed internally by George Staikos and Joe Mason.
Internal PR 172120
Add new Notification files and remove obsolete ones.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Reviewed internally by George Staikos and Joe Mason
Internal PR 172120
Add new notifications implementation for the BlackBerry port. Rename
existing class to match Client naming. Adds NotificationManager
implementation for managing notifications and permissions, and logic
for passing the notifications to the platform provider.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::updateNotificationPermission):
(WebKit):
(BlackBerry::WebKit::WebPage::notificationClicked):
(BlackBerry::WebKit::WebPage::notificationClosed):
(BlackBerry::WebKit::WebPage::notificationError):
(BlackBerry::WebKit::WebPage::notificationShown):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::notificationManager):

  • WebCoreSupport/NotificationClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::NotificationClientBlackBerry::NotificationClientBlackBerry):
(WebCore::NotificationClientBlackBerry::show):
(WebCore::NotificationClientBlackBerry::cancel):
(WebCore::NotificationClientBlackBerry::clearNotifications):
(WebCore::NotificationClientBlackBerry::notificationObjectDestroyed):
(WebCore::NotificationClientBlackBerry::notificationControllerDestroyed):
(WebCore::NotificationClientBlackBerry::requestPermission):
(WebCore::NotificationClientBlackBerry::cancelRequestsForPermission):
(WebCore::NotificationClientBlackBerry::checkPermission):

  • WebCoreSupport/NotificationClientBlackBerry.h: Added.

(WebKit):
(WebCore):
(NotificationClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp: Removed.
  • WebCoreSupport/NotificationPresenterImpl.h: Removed.
  • WebKitSupport/NotificationManager.cpp: Added.

(WebKit):
(BlackBerry::WebKit::NotificationManager::NotificationManager):
(BlackBerry::WebKit::NotificationManager::~NotificationManager):
(BlackBerry::WebKit::NotificationManager::show):
(BlackBerry::WebKit::NotificationManager::cancel):
(BlackBerry::WebKit::NotificationManager::clearNotifications):
(BlackBerry::WebKit::NotificationManager::notificationObjectDestroyed):
(BlackBerry::WebKit::NotificationManager::requestPermission):
(BlackBerry::WebKit::NotificationManager::cancelRequestsForPermission):
(BlackBerry::WebKit::NotificationManager::checkPermission):
(BlackBerry::WebKit::NotificationManager::updatePermission):
(BlackBerry::WebKit::NotificationManager::notificationClicked):
(BlackBerry::WebKit::NotificationManager::notificationClosed):
(BlackBerry::WebKit::NotificationManager::notificationError):
(BlackBerry::WebKit::NotificationManager::notificationShown):
(BlackBerry::WebKit::NotificationManager::removeNotificationFromContextMap):

  • WebKitSupport/NotificationManager.h: Added.

(WebKit):
(NotificationManager):

10:07 PM Changeset in webkit [135558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-22

  • DEPS:
9:36 PM Changeset in webkit [135557] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Remove PLATFORM(HAIKU) leftovers code
https://bugs.webkit.org/show_bug.cgi?id=103086

Reviewed by Antti Koivisto.

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

9:08 PM Changeset in webkit [135556] by krit@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-mask shorthand switches -webkit-mask-clip and -webkit-mask-origin values
https://bugs.webkit.org/show_bug.cgi?id=103083

Reviewed by Antti Koivisto.

Source/WebCore:

The order of CSSPropertyWebkitMaskOrigin and CSSPropertyWebkitMaskClip was not correct
for property value. Just changed the order in the property array to match behavior of
background and CSS Masking spec.

Test: fast/masking/parsing-mask.html

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitMaskShorthand):

LayoutTests:

Add parser tests for -webkit-mask property.

  • fast/masking/parsing-mask-expected.txt: Added.
  • fast/masking/parsing-mask.html: Added.
8:54 PM Changeset in webkit [135555] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix the MIPS build after r135330
https://bugs.webkit.org/show_bug.cgi?id=102872

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-11-22
Reviewed by Gavin Barraclough.

Revert/replace functions added to MIPS port.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::revertJumpToMove):
(MIPSAssembler):
(JSC::MIPSAssembler::replaceWithJump):

  • assembler/MacroAssemblerMIPS.h:

(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerMIPS::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerMIPS::startOfPatchableBranchPtrWithPatchOnAddress):

7:31 PM Changeset in webkit [135554] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Guard against a lost focusedNode that input handler isn't yet informed of.
https://bugs.webkit.org/show_bug.cgi?id=103071

Reviewed by Rob Buis.

Fix potential for a crash if input mode is active but
we can't get a focusedNode.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

6:54 PM Changeset in webkit [135553] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Text Autosizing: Improve handling of nested comments on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=102409

Patch by John Mellor <johnme@chromium.org> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No longer consider overflow != visible as requiring an independent
cluster. Some sites (e.g. reddit.com) wrap ordinary blocks (such as
comments) in overflow:hidden or overflow:auto, for various reasons
(like allowing it to be scrollable, or clipping an element that sticks
out). These reasons are not sufficient justification for a new cluster.

On reddit.com this means that comments will all get the same multiplier,
rather than being independently assigned a variety of multipliers based
on how much text each comment contains (etc), which significantly
improves the look.

Test: fast/text-autosizing/cluster-narrow-in-wide-ohidden.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isAutosizingCluster):

LayoutTests:

Added test to confirm that overflow:hidden no longer triggers a cluster.

  • fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html: Added.
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden.html: Added.
6:38 PM Changeset in webkit [135552] by peter@chromium.org
  • 4 edits in trunk/Tools

[Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
https://bugs.webkit.org/show_bug.cgi?id=103065

Reviewed by Dirk Pranke.

This addresses two further reliability issues in the Android test running
scripts. Firstly, the run_tests.py script needs to have the --exit_code
argument passed in order to return non-zero codes, which we need for the
build master to distinguish failures from successful runs.

Secondly, it modifies the layout test runner to briefly wait (through
the wait-for-device command) after requesting a device to switch to root
mode. Without this waiting period, commands might get lost and thereby
unexpectedly fail.

  • Scripts/run-api-tests:
  • Scripts/run-chromium-webkit-unit-tests:
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._restart_adb_as_root):

5:53 PM Changeset in webkit [135551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Buildfix when ENABLE_NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=103044

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-22
Reviewed by Kentaro Hara.

enum ProcessType has PluginProcess only if ENABLE(PLUGIN_PROCESS) is enabled.
So, guard PluginProcess with ENABLE(PLUGIN_PROCESS).

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

4:46 PM Changeset in webkit [135550] by schenney@chromium.org
  • 11 edits
    101 adds
    23 deletes in trunk/LayoutTests

Test expectations update after enabling Skia changes.

Unreviewed expectations update.

Final rebaselines. These tests did not get correctly rebased the first time through.

  • fast/replaced/border-radius-clip-expected.png: Added.
  • fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/chromium-linux-x86/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/chromium-linux/transforms/3d/hit-testing/backface-hit-test-expected.png:
  • platform/chromium-linux/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png:
  • platform/chromium-mac-lion/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/font-smoothing-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac-lion/fast/images/object-image-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/body-background-image-expected.txt: Added.
  • platform/chromium-mac-lion/fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/font-initial-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-smoothing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/body-background-image-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/font-initial-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-background-image-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-text-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.txt: Added.
  • platform/chromium-mac/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-smoothing-expected.txt: Added.
  • platform/chromium-mac/fast/history/visited-link-background-color-expected.png: Added.
  • platform/chromium-mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac/fast/images/object-image-expected.png: Added.
  • platform/chromium-mac/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-mac/fast/repaint/body-background-image-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • platform/chromium-mac/fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • platform/chromium-mac/fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • platform/chromium-mac/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac/fast/text/font-initial-expected.txt: Added.
  • platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/chromium-mac/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Added.
  • platform/chromium-win-xp/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-win/fast/css/color-correction-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-background-image-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-backgrounds-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-text-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-win/fast/css/color-correction-untagged-images-expected.png: Added.
  • platform/chromium-win/fast/css/font-smoothing-expected.png:
  • platform/chromium-win/fast/history/visited-link-background-color-expected.png: Added.
  • platform/chromium-win/fast/images/object-image-expected.png: Added.
  • platform/chromium-win/fast/repaint/body-background-image-expected.png: Added.
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.txt:
  • platform/chromium-win/fast/text/atsui-pointtooffset-calls-cg-expected.png:
  • platform/chromium-win/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/chromium-win/fast/text/font-initial-expected.png: Added.
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/object-image-expected.png: Added.
  • platform/chromium/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
  • platform/chromium/fast/css/color-correction-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-background-image-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-backgrounds-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/chromium/fast/css/color-correction-untagged-images-expected.png: Removed.
  • platform/chromium/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-circle-focus-ring-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-focus-ring-outline-color-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Removed.
  • platform/chromium/fast/images/imagemap-polygon-focus-ring-expected.png: Removed.
  • platform/chromium/fast/images/object-image-expected.png: Removed.
  • platform/chromium/fast/repaint/body-background-image-expected.png: Removed.
  • platform/chromium/fast/replaced/border-radius-clip-expected.png: Removed.
  • platform/chromium/fast/text/font-initial-expected.png: Removed.
  • platform/chromium/fast/text/line-initial-and-final-swashes-expected.png: Removed.
  • platform/chromium/fast/text/line-initial-and-final-swashes-expected.txt: Removed.
  • platform/chromium/fast/text/midword-break-before-surrogate-pair-2-expected.png: Removed.
  • platform/mac/fast/replaced/border-radius-clip-expected.png: Removed.
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.txt: Removed.
3:56 PM Changeset in webkit [135549] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

max-height property not respected in case of tables
https://bugs.webkit.org/show_bug.cgi?id=98633

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-11-22
Reviewed by Julien Chaffraix.

Source/WebCore:

The max-height property determines the maximum computed height an element can have. In case of tables
the computed height was not being limited by the max-height property. The current patch fixes the same.

Test: fast/table/css-table-max-height.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

Helper function to compute height from the given style height.
This function handles style height of type fixed, percent and viewport percent.
As height of type 'calculated' gets internally resolved to either fixed or percent
there is no special handling required for the same.

(WebCore):
(WebCore::RenderTable::layout):

Logic to compute the logical height of an element such that it does not exceed the max-height value given that
min-width < Content height < max-height, when min-height < max-height.
However max-height value is not respected if either min-height > max-height or Content height > max-height.

  • rendering/RenderTable.h:

(RenderTable):

Function definition for the newly add function convertStyleLogicalHeightToComputedHeight().

LayoutTests:

  • fast/table/css-table-max-height-expected.txt: Added.
  • fast/table/css-table-max-height.html: Added.
3:47 PM Changeset in webkit [135548] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening: Updated test expectations for MountainLion crash in
media/video-preload.html.
https://bugs.webkit.org/show_bug.cgi?id=103093

  • platform/chromium/TestExpectations:
3:12 PM Changeset in webkit [135547] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove 'module' from IDL parser
https://bugs.webkit.org/show_bug.cgi?id=102670

Reviewed by Adam Barth.

The Web IDL spec no longer supports 'module'. We already removed
'module's from WebKit IDL files. So this patch removes 'module'
from the IDL parser.

No tests. No change in behavior.

  • bindings/scripts/IDLParser.pm:

(Parse):
(parseDefinitionOld):

3:02 PM Changeset in webkit [135546] by rjkroege@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviwed gardening. Updated test expectations for failure
in complex-joining-using-gpos.html
https://bugs.webkit.org/show_bug.cgi?id=101377

  • platform/chromium/TestExpectations:
2:55 PM Changeset in webkit [135545] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] fix DOMWrapperWorld destructor
https://bugs.webkit.org/show_bug.cgi?id=103066

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Jochen Eisinger.

DOMWrapperWorld had a workaround in place during deletion.
This patch brings it in line with WebKit standards.

No new tests: refactor.

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::ensureIsolatedWorld):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolatedWorldDOMDataStore):

2:45 PM Changeset in webkit [135544] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Remove SVGShadowText class
https://bugs.webkit.org/show_bug.cgi?id=103088

Reviewed by Ryosuke Niwa.

Remove SVGShadowText class and merge the little functionality it has to Text.

  • dom/Text.cpp:

(WebCore):
(WebCore::isSVGShadowText):

Figure out if we are a SVGShadowText from the context.

(WebCore::isSVGText):
(WebCore::Text::createRenderer):
(WebCore::Text::recalcTextStyle):

Factor SVG special case testing to functions.

  • dom/Text.h:

(Text):

Get rid of the now unnecessary willRecalcTextStyle mechanism.

  • svg/SVGTRefElement.cpp:

(WebCore):
(WebCore::SVGTRefElement::updateReferencedText):

2:38 PM Changeset in webkit [135543] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Remove a now-passing test from TestExpectations.

  • platform/chromium/TestExpectations:
2:31 PM Changeset in webkit [135542] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Style sharing: Remove O(n2) presentation attribute checks that never found anything anyway.
<http://webkit.org/b/103019>

Reviewed by Ojan Vafai.

Rely on the global presentation attribute cache and remove the slow-path code that compares
the full StylePropertySets for attribute-derived style.
There are virtually no cases of logically equivalent presentation attribute styles that don't
already share the same memory address. (Zero hits on Apple and Chromium PLT content.)

  • css/StyleResolver.cpp:

(WebCore::haveIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):

2:30 PM Changeset in webkit [135541] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: evaluate on hover regressed with the editor change
https://bugs.webkit.org/show_bug.cgi?id=103063

Reviewed by Vsevolod Vlasov.

We are no longer mutating the editor's dom from outside.

  • inspector/front-end/DOMExtension.js:

(Element.prototype.remove):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.highlightRangesWithStyleClass):
(WebInspector.DefaultTextEditor.prototype.highlightExpression):
(WebInspector.DefaultTextEditor.prototype.hideHighlightedExpression):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):

2:14 PM Changeset in webkit [135540] by schenney@chromium.org
  • 2931 edits
    33 adds
    25 deletes in trunk/LayoutTests

Test expectations update after enabling Skia changes.

Unreviewed expectations update.

All the SVG tests. We should now be done.

  • To many files to list.
1:35 PM Changeset in webkit [135539] by senorblanco@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. New baselines for test effect-reference-ordering-hw.

  • platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.txt: Added.
1:07 PM Changeset in webkit [135538] by kov@webkit.org
  • 9 edits in trunk

[GTK] Split SVG from WebCore to work-around make limitation
https://bugs.webkit.org/show_bug.cgi?id=97735

Reviewed by Carlos Garcia Campos.

Add a new libtool convenience library, libWebCoreSVG.la, to work-around
make limitation when linking libWebCore.

.:

  • GNUmakefile.am: variables for the new library.

Source/WebCore:

  • GNUmakefile.am: new libWebCoreSVG.la library.
  • GNUmakefile.list.am: move SVG-related files to be part of the new library.

Source/WebKit/gtk:

  • GNUmakefile.am: link libWebCoreSVG.la into libwebkitgtk.

Source/WebKit2:

  • GNUmakefile.am: link libWebCoreSVG.la into libwebkit2gtk.
12:31 PM Changeset in webkit [135537] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Inspector]Code Style changes in TimelinePresentationModel.js.
https://bugs.webkit.org/show_bug.cgi?id=102885.

Patch by Pan Deng <pan.deng@intel.com> on 2012-11-22
Reviewed by Pavel Feldman.

This patch changes "switch" code style for TimelinePresentationModel.js, no functionality update.

No new tests.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):

12:18 PM Changeset in webkit [135536] by schenney@chromium.org
  • 529 edits
    4 adds
    23 deletes in trunk/LayoutTests

Test expectations update after enabling Skia changes.

Unreviewed expectations update.

Partial update, covering all but eh SVG tests.

  • To many files to list.
12:14 PM Changeset in webkit [135535] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix attempt.

  • html/HTMLCollection.h:

(HTMLCollection):

12:06 PM Changeset in webkit [135534] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Get rid of HTMLCollectionCacheBase
https://bugs.webkit.org/show_bug.cgi?id=103085

Reviewed by Sam Weinig.

Merged HTMLCollectionCacheBase into HTMLCollection now that DynamicNodeList and HTMLCollection
share one implementation.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::rootNode): Merged ownerNodeHasItemRefAttribute since this was
the only caller of this function, and the function name didn't match what it was checking.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

  • dom/DynamicNodeList.h:

(WebCore):
(WebCore::DynamicNodeListCacheBase::cachedItemOffset):
(DynamicNodeListCacheBase):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::DynamicNodeListCacheBase::setItemCache):
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfterCachedItem): Merged cachedElementsArrayOffset()
now that this is the only caller.
(WebCore::HTMLCollection::append):

  • html/HTMLCollection.h:

(HTMLCollection):
(WebCore::HTMLCollection::idCache): Moved from HTMLCollectionCacheBase.
(WebCore::HTMLCollection::nameCache): Ditto.
(WebCore::HTMLCollection::appendIdCache): Ditto.
(WebCore::HTMLCollection::appendNameCache): Ditto.

11:30 AM Changeset in webkit [135533] by schenney@chromium.org
  • 1881 edits
    59 adds
    84 deletes in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, covering all fast tests. Many more to come.

  • To many files to list. Most of the pixel results in fast for Chromium.
10:37 AM Changeset in webkit [135532] by pierre.rossi@gmail.com
  • 5 edits in trunk

[Qt] REGRESSION(r135515): It made 3-3 tests fail and crash
https://bugs.webkit.org/show_bug.cgi?id=103073

Rubber-stamped by Simon Hausmann.

Source/WebKit/qt:

Removing the QNetworkAccessManager member in FrameNetworkingContextQt
was right, but we need to be careful as to how we fetch it back.
Since the WebCore Page is not always valid, get the QNAM instance
straight from the frame adapter through its page adapter instead.

  • WebCoreSupport/ChromeClientQt.cpp: [Style nit] Remove stray emit.
  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::networkAccessManager):

LayoutTests:

Unskip the tests that had regressed.

  • platform/qt/TestExpectations:
10:18 AM Changeset in webkit [135531] by schenney@chromium.org
  • 1223 edits
    1 add in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, covering all editing tests. Many more to come.

  • platform/chromium-mac-lion/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-lion/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac-lion/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-lion/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/print-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-lion/editing/inserting/12882-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-lion/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-lion/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-lion/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-lion/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/redo-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/13804-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png:
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png:
  • platform/chromium-mac-lion/editing/selection/4402375-expected.png:
  • platform/chromium-mac-lion/editing/selection/4818145-expected.png:
  • platform/chromium-mac-lion/editing/selection/4866671-expected.png:
  • platform/chromium-mac-lion/editing/selection/4889598-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4947387-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5099303-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5240265-expected.png:
  • platform/chromium-mac-lion/editing/selection/6476-expected.png:
  • platform/chromium-mac-lion/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-lion/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-lion/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-lion/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-mac-lion/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-lion/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-lion/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac-lion/editing/selection/iframe-expected.png:
  • platform/chromium-mac-lion/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-lion/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-lion/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-box-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac-lion/editing/selection/selectNode-expected.png:
  • platform/chromium-mac-lion/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac-lion/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac-lion/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-lion/editing/style/4916887-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5065910-expected.png:
  • platform/chromium-mac-lion/editing/style/5084241-expected.png:
  • platform/chromium-mac-lion/editing/style/5228141-expected.png:
  • platform/chromium-mac-lion/editing/style/5279521-expected.png:
  • platform/chromium-mac-lion/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac-lion/editing/style/highlight-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac-lion/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac-lion/editing/undo/4063751-expected.png:
  • platform/chromium-mac-lion/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/redo-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4402375-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4818145-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4866671-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4889598-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4947387-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/6476-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-box-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selectNode-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/4916887-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5065910-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5084241-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5228141-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5279521-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/highlight-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/undo/4063751-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5099303-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac/editing/inserting/12882-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4402375-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/5240265-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/selectNode-expected.png:
  • platform/chromium-mac/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/5046875-2-expected.png:
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-win/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-win/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-win/editing/deleting/list-item-1-expected.png:
  • platform/chromium-win/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-win/editing/execCommand/4747450-expected.png:
  • platform/chromium-win/editing/execCommand/4916402-expected.png:
  • platform/chromium-win/editing/execCommand/5136770-expected.png:
  • platform/chromium-win/editing/execCommand/5142012-2-expected.png:
  • platform/chromium-win/editing/execCommand/5569741-expected.png:
  • platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-win/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-win/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-win/editing/inserting/4875189-1-expected.png:
  • platform/chromium-win/editing/inserting/4959067-expected.png:
  • platform/chromium-win/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-win/editing/selection/4402375-expected.png:
  • platform/chromium-win/editing/selection/4895428-2-expected.png:
  • platform/chromium-win/editing/selection/drag-to-contenteditable-iframe-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/chromium-win/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-win/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-win/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-win/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-win/editing/selection/select-all-iframe-expected.png:
  • platform/chromium-win/editing/selection/selectNode-expected.png:
  • platform/chromium-win/editing/selection/selectNodeContents-expected.png:
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
  • platform/chromium-win/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-win/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-win/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-win/editing/unsupported-content/list-type-before-expected.png:
9:38 AM Changeset in webkit [135530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add GL_CHROMIUM_pixel_transfer_buffer_object extension support.
https://bugs.webkit.org/show_bug.cgi?id=102528

Patch by David Reveman <reveman@chromium.org> on 2012-11-22
Reviewed by James Robinson.

Add mapBufferCHROMIUM and unmapBufferCHROMIUM prototypes to WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::mapBufferCHROMIUM):
(WebKit::WebGraphicsContext3D::unmapBufferCHROMIUM):

9:34 AM Changeset in webkit [135529] by Antti Koivisto
  • 22 edits
    2 deletes in trunk/Source/WebCore

Merge EditingText into Text
https://bugs.webkit.org/show_bug.cgi?id=103060

Reviewed by Ryosuke Niwa.

Remove the EditingText class. Its only function beyond the regular Text is that it always creates a renderer.
It can be replaced with a bit.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CDATASection.cpp:

(WebCore::CDATASection::CDATASection):

  • dom/Document.cpp:

(WebCore::Document::createEditingTextNode):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/EditingText.cpp: Removed.
  • dom/EditingText.h: Removed.
  • dom/Node.h:

(WebCore::Node::hasName):
(WebCore::Node::isEditingText):
(WebCore::Node::setHasName):

Use the same bit as hasName() which is Element specific.

  • dom/Text.cpp:

(WebCore::Text::create):
(WebCore):
(WebCore::Text::createEditingText):
(WebCore::Text::rendererIsNeeded):

  • dom/Text.h:

(Text):
(WebCore::Text::Text):

  • editing/Editor.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/htmlediting.cpp:
  • editing/mac/EditorMac.mm:
  • page/Frame.cpp:
9:30 AM Changeset in webkit [135528] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add OS!="ios" to guard for gcc_version in WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=103007

Reviewed by Adam Barth.

This matches the guards used in chromium's chrome/chrome_browser.gypi.

  • WebKit.gyp:
9:03 AM Changeset in webkit [135527] by schenney@chromium.org
  • 377 edits
    6 deletes in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, covering all css tests. Many more to come.

  • platform/chromium-mac-lion/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac-lion/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac-lion/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac-lion/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac-lion/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac-lion/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac-lion/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-mac-lion/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-mac-lion/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac-lion/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac-lion/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-mac-lion/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-mac-lion/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-lion/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac-snowleopard/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac-snowleopard/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac-snowleopard/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac-snowleopard/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac-snowleopard/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac-snowleopard/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/css1/box_properties/border_left-expected.png:
  • platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-mac/css1/box_properties/border_top-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_left-expected.png:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_left-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png:
  • platform/chromium-mac/css1/classification/list_style_image-expected.png:
  • platform/chromium-mac/css1/classification/list_style_position-expected.png:
  • platform/chromium-mac/css1/classification/list_style_type-expected.png:
  • platform/chromium-mac/css1/pseudo/anchor-expected.png:
  • platform/chromium-mac/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-mac/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-mac/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-mac/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
  • platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png:
  • platform/chromium-mac/css3/filters/filter-with-transform-expected.png:
  • platform/chromium-mac/css3/filters/nested-filter-expected.png:
  • platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-circle-overflow-hidden-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-polygon-evenodd-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-polygon-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-polygon-nonzero-expected.png:
  • platform/chromium-mac/css3/masking/clip-path-rectangle-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-win-xp/css1/cascade: Removed.
  • platform/chromium-win-xp/css1/classification: Removed.
  • platform/chromium-win-xp/css1/pseudo: Removed.
  • platform/chromium-win-xp/css3/selectors3/html: Removed.
  • platform/chromium-win-xp/css3/selectors3/html/css3-modsel-161-expected.png: Removed.
  • platform/chromium-win-xp/css3/selectors3/xhtml: Removed.
  • platform/chromium-win-xp/css3/selectors3/xhtml/css3-modsel-161-expected.png: Removed.
  • platform/chromium-win-xp/css3/selectors3/xml: Removed.
  • platform/chromium-win-xp/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
  • platform/chromium-win/css1/box_properties/border_left-expected.png:
  • platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-win/css1/box_properties/border_top-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/margin_left-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_left-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/css1/cascade/cascade_order-expected.png:
  • platform/chromium-win/css1/classification/list_style_image-expected.png:
  • platform/chromium-win/css1/classification/list_style_position-expected.png:
  • platform/chromium-win/css1/classification/list_style_type-expected.png:
  • platform/chromium-win/css1/pseudo/anchor-expected.png:
  • platform/chromium-win/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/chromium-win/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/chromium-win/css2.1/t0509-c15-ids-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/chromium-win/css2.1/t1205-c563-list-type-00-b-expected.png:
  • platform/chromium-win/css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-child-layers-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
  • platform/chromium-win/css3/filters/filter-repaint-composited-fallback-expected.png:
  • platform/chromium-win/css3/filters/filter-with-transform-expected.png:
  • platform/chromium-win/css3/filters/nested-filter-expected.png:
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png:
  • platform/chromium-win/css3/masking/clip-path-circle-overflow-hidden-expected.png:
  • platform/chromium-win/css3/masking/clip-path-ellipse-expected.png:
  • platform/chromium-win/css3/masking/clip-path-polygon-evenodd-expected.png:
  • platform/chromium-win/css3/masking/clip-path-polygon-expected.png:
  • platform/chromium-win/css3/masking/clip-path-polygon-nonzero-expected.png:
  • platform/chromium-win/css3/masking/clip-path-rectangle-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-74b-expected.png:
8:26 AM Changeset in webkit [135526] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests to paint the bots green.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
8:21 AM Changeset in webkit [135525] by schenney@chromium.org
  • 50 edits
    2 deletes in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Partial update, many more to come.

  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac-lion/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac-lion/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-lion/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac-lion/css1/basic/containment-expected.png:
  • platform/chromium-mac-lion/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac-lion/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac-lion/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/containment-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac-snowleopard/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac-snowleopard/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/css1/basic/class_as_selector-expected.png:
  • platform/chromium-mac/css1/basic/containment-expected.png:
  • platform/chromium-mac/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-mac/css1/basic/id_as_selector-expected.png:
  • platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-win-xp/compositing/reflections: Removed.
  • platform/chromium-win-xp/css1/basic: Removed.
  • platform/chromium-win/compositing/culling/filter-occlusion-alpha-large-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-win/css1/basic/class_as_selector-expected.png:
  • platform/chromium-win/css1/basic/containment-expected.png:
  • platform/chromium-win/css1/basic/contextual_selectors-expected.png:
  • platform/chromium-win/css1/basic/id_as_selector-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom-expected.png:
8:02 AM Changeset in webkit [135524] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Remove Qt-specific results for test concat-large-strings-crash.html
since they are identical to the platform-independent expected results
as of changeset 135523, <http://trac.webkit.org/changeset/135523>.

  • platform/qt/fast/js/concat-large-strings-crash-expected.txt: Removed.
7:50 AM Changeset in webkit [135523] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Update test result.

  • fast/js/concat-large-strings-crash-expected.txt:
7:32 AM Changeset in webkit [135522] by schenney@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Chromium expectations fix.

Unreviewed removal of bad expectations.

  • platform/chromium/svg/animations/animate-text-nested-transforms-expected.txt: Removed.
  • platform/chromium/svg/custom/getscreenctm-in-mixed-content2-expected.txt: Removed.
  • platform/chromium/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
7:28 AM Changeset in webkit [135521] by schenney@chromium.org
  • 341 edits in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Update of remaining platform-specific expectations for linux. Other platforms to come.

Too many files to list.

7:15 AM Changeset in webkit [135520] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed MSVC Windows build fix: Include header files referenced in RefPtr
instances.

  • Api/qwebelement.cpp:
6:46 AM Changeset in webkit [135519] by schenney@chromium.org
  • 1037 edits
    25 adds in trunk/LayoutTests

[Chromium] Test expectations update after enabling Skia changes.

Unreviewed Chromium expectations update.

Update of svg results.

Too many files to list. All Chromium platform results for svg tests.

6:30 AM Changeset in webkit [135518] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Timeline: Disclosure arrows rendered underneath frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=101053

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-22
Reviewed by Yury Semikhatsky.

In Timeline, when in "frames" mode, event disclosure arrows are rendered
below the dividing lines for the frame (div.timeline-frame-divider).
When this happens, the frame divider can capture mouse clicks and make
it difficult to open the disclosure arrow.

  • inspector/front-end/timelinePanel.css:

(#timeline-grid-header): Render dividers under timeline bars.

6:22 AM Changeset in webkit [135517] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] Reduce public methods of TextureMapperTiledBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=103032

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-22
Reviewed by Noam Rosenthal.

This patch makes two methods private and removes one method.

No new tests, refactoring only.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(WebCore::TextureMapperTiledBackingStore::create):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):

6:06 AM Changeset in webkit [135516] by schenney@chromium.org
  • 1062 edits in trunk

Source/WebKit/chromium: [Chromium]: Removing gyp flags controlling Skia features.

Unreviewed, pre-tested rendering changes that have been waiting for a chance to rebaseline tests.

Enabled fixes for test rendering, and fast patsh for anti-aliased primitives.

  • skia_webkit.gyp:

LayoutTests: [Chromium] Test expectations update.

Unreviewed changes due to Skia changes.

Too many files to list (over 1000). All Chromium platform expectations.

5:57 AM Changeset in webkit [135515] by Simon Hausmann
  • 81 edits
    8 copies
    12 adds in trunk

[Qt] Separate QWidget dependant code into separate WebKitWidgets static library
https://bugs.webkit.org/show_bug.cgi?id=102800

Patch by Simon Hausmann <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com> on 2012-11-22
Reviewed by Tor Arne Vestbø.

This patch separates code that needs to use QWidget related APIs in
WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
static library. WebKit1 is compiled without QT += widgets and therefore
any widget related dependency has been moved "up" and out of WebKit1 into
the WebKitWidgets library.

Between the code in WebKit.a and WebKitWidgets.a new adapters and
interfaces have been introduced, such as QWebPageAdapter and
QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
call out into the API layer, implemented by QWebPage (QWebPagePrivate).
The other way around if QWebPage wants to access WebCore or
WebCoreSupport related functionality, it will go through
QWebPageAdapater (as base class). The separation in the direction up
into the API layer is complete with this patch, no code in WebKit1
depends on QtWidgets. The separation the other way around, code in the
API layer not using any WebCore types, is not complete yet.

Some classes such as QWebSettings, QWebElement or
DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
they do not depend on widget related Qt APIs and they make much more
use of WebCore internal APIs and therefore are easier to keep in
WebKit1.

In the future we plan to place a real shared library boundary between
WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
part of the QtWebKit shared library and by turning the WebKitWidgets
static library into a shared one.

.:

  • Source/api.pri:
  • WebKit.pro:

Source/WebCore:

  • platform/qt/QWebPageClient.h:

(QWebPageClient):

Source/WebKit:

  • WebKit1.pri:
  • WebKit1.pro:
  • WebKitWidgets.pri: Copied from Source/WebKit/WebKit1.pri.
  • WebKitWidgets.pro: Added.

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::pageClient):
(QGraphicsWebViewPrivate::detachCurrentPage):
(QGraphicsWebView::setPage):

  • Api/qwebelement.cpp:

(QWebElement::webFrame):

  • Api/qwebframe.cpp:

(QWebFramePrivate::setPage):
(QWebFramePrivate::didStartProvisionalLoad):
(QWebFramePrivate::handleProgressFinished):
(QWebFramePrivate::emitInitialLayoutCompleted):
(QWebFramePrivate::emitIconChanged):
(QWebFramePrivate::emitLoadStarted):
(QWebFramePrivate::emitLoadFinished):
(QWebFramePrivate::createChildFrame):
(QWebFramePrivate::apiHandle):
(QWebFramePrivate::handle):
(QWebFramePrivate::contentsSizeDidChange):
(QWebFramePrivate::scrollBarPolicy):
(QWebFrame::QWebFrame):
(QWebFrame::~QWebFrame):
(QWebFrame::setUrl):
(QWebFrame::load):
(QWebFrame::scrollPosition):
(QWebFrame::geometry):
(QWebFramePrivate::kit):
(QWebFrame::handle):

  • Api/qwebframe.h:
  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):

  • Api/qwebhistory.cpp:

(QWebHistoryPrivate::page):

  • Api/qwebhistory_p.h:

(QWebHistoryPrivate):

  • Api/qwebinspector.cpp:

(QWebInspectorPrivate::setFrontend):

  • Api/qwebinspector_p.h:

(QWebInspectorPrivate):

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPagePrivate::core):
(QWebPagePrivate::show):
(QWebPagePrivate::setFocus):
(QWebPagePrivate::unfocus):
(QWebPagePrivate::setWindowRect):
(QWebPagePrivate::viewportSize):
(QWebPagePrivate::createWindow):
(QWebPagePrivate::javaScriptConsoleMessage):
(QWebPagePrivate::javaScriptAlert):
(QWebPagePrivate::javaScriptConfirm):
(QWebPagePrivate::javaScriptPrompt):
(QWebPagePrivate::printRequested):
(QWebPagePrivate::databaseQuotaExceeded):
(QWebPagePrivate::applicationCacheQuotaExceeded):
(QWebPagePrivate::setToolTip):
(QWebPagePrivate::createFullScreenVideoHandler):
(QWebPagePrivate::mainFrameAdapter):
(QWebPagePrivate::chooseFiles):
(QWebPagePrivate::acceptNavigationRequest):
(QWebPagePrivate::emitRestoreFrameStateRequested):
(QWebPagePrivate::emitSaveFrameStateRequested):
(QWebPagePrivate::emitDownloadRequested):
(QWebPagePrivate::emitFrameCreated):
(QWebPagePrivate::errorPageExtension):
(QWebPagePrivate::createPlugin):
(QWebPagePrivate::adapterForWidget):
(QWebPagePrivate::createMainFrame):
(QWebPagePrivate::createContextMenu):
(QWebPagePrivate::inspectorHandle):
(QWebPagePrivate::setInspectorFrontend):
(QWebPagePrivate::setInspectorWindowTitle):
(QWebPagePrivate::createWebInspector):
(iterateContextMenu):
(QWebPagePrivate::menuActionsAsText):
(QWebPagePrivate::emitViewportChangeRequested):
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::gestureEvent):
(QWebPage::setView):
(QWebPage::javaScriptConsoleMessage):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::shouldInterruptJavaScript):
(QWebPage::setFeaturePermission):
(QWebPagePrivate::colorSelectionRequested):
(QWebPagePrivate::createSelectPopup):
(QWebPagePrivate::viewRectRelativeToWindow):
(QWebPagePrivate::geolocationPermissionRequested):
(QWebPagePrivate::geolocationPermissionRequestCancelled):
(QWebPagePrivate::notificationsPermissionRequested):
(QWebPagePrivate::notificationsPermissionRequestCancelled):
(QWebPagePrivate::respondToChangedContents):
(QWebPagePrivate::respondToChangedSelection):
(QWebPagePrivate::microFocusChanged):
(QWebPagePrivate::triggerCopyAction):
(QWebPagePrivate::triggerActionForKeyEvent):
(QWebPagePrivate::clearUndoStack):
(QWebPagePrivate::canUndo):
(QWebPagePrivate::canRedo):
(QWebPagePrivate::undo):
(QWebPagePrivate::redo):
(QWebPagePrivate::createUndoStep):
(QWebPagePrivate::editorCommandForKeyEvent):
(QWebPage::viewportSize):
(QWebPage::setViewportSize):
(QWebPage::viewportAttributesForSize):
(QWebPage::event):
(QWebPage::extension):
(QWebPage::handle):
(QWebPage::chooseFile):
(QWebPage::setNetworkAccessManager):
(QWebPage::networkAccessManager):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:

(WebCore):
(QWebPagePrivate):

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • Api/qwebview.cpp:

(QWebViewPrivate::detachCurrentPage):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::setWindowRect):
(WebCore::ChromeClientQt::focus):
(WebCore::ChromeClientQt::unfocus):
(WebCore::ChromeClientQt::createWindow):
(WebCore::ChromeClientQt::show):
(WebCore::ChromeClientQt::setToolbarsVisible):
(WebCore::ChromeClientQt::setStatusbarVisible):
(WebCore::ChromeClientQt::setMenubarVisible):
(WebCore::ChromeClientQt::addMessageToConsole):
(WebCore::ChromeClientQt::closeWindowSoon):
(WebCore::ChromeClientQt::runJavaScriptAlert):
(WebCore::ChromeClientQt::runJavaScriptConfirm):
(WebCore::ChromeClientQt::runJavaScriptPrompt):
(WebCore::ChromeClientQt::setStatusbarText):
(WebCore::ChromeClientQt::shouldInterruptJavaScript):
(WebCore::ChromeClientQt::keyboardUIMode):
(WebCore::ChromeClientQt::windowResizerRect):

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

  • WebCoreSupport/ContextMenuClientQt.cpp:
  • WebCoreSupport/ContextMenuClientQt.h:

(ContextMenuClientQt):

  • WebCoreSupport/DefaultFullScreenVideoHandler.cpp: Added.

(DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
(DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler):
(DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback):
(DefaultFullScreenVideoHandler::enterFullScreen):
(DefaultFullScreenVideoHandler::exitFullScreen):

  • WebCoreSupport/DefaultFullScreenVideoHandler.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(WebKit):
(DefaultFullScreenVideoHandler):

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

  • WebCoreSupport/DragClientQt.h:

(WebCore):
(WebCore::DragClientQt::DragClientQt):
(DragClientQt):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(toGeolocationClientMock):
(toDeviceOrientationClientMock):
(DumpRenderTreeSupportQt::initialize):
(DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled):
(DumpRenderTreeSupportQt::setFrameFlatteningEnabled):
(DumpRenderTreeSupportQt::webPageSetGroupName):
(DumpRenderTreeSupportQt::webPageGroupName):
(DumpRenderTreeSupportQt::webInspectorExecuteScript):
(DumpRenderTreeSupportQt::webInspectorShow):
(DumpRenderTreeSupportQt::webInspectorClose):
(DumpRenderTreeSupportQt::hasDocumentElement):
(DumpRenderTreeSupportQt::pauseAnimation):
(DumpRenderTreeSupportQt::pauseTransitionOfProperty):
(DumpRenderTreeSupportQt::numberOfActiveAnimations):
(DumpRenderTreeSupportQt::clearFrameName):
(DumpRenderTreeSupportQt::setCaretBrowsingEnabled):
(DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportQt::executeCoreCommandByName):
(DumpRenderTreeSupportQt::isCommandEnabled):
(DumpRenderTreeSupportQt::findString):
(DumpRenderTreeSupportQt::selectedRange):
(DumpRenderTreeSupportQt::firstRectForCharacterRange):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportQt::setWindowsBehaviorAsEditingBehavior):
(DumpRenderTreeSupportQt::viewportAsText):
(DumpRenderTreeSupportQt::scalePageBy):
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupportQt::shouldClose):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::addUserStyleSheet):
(DumpRenderTreeSupportQt::removeUserStyleSheets):
(DumpRenderTreeSupportQt::setDefersLoading):
(DumpRenderTreeSupportQt::goBack):
(DumpRenderTreeSupportQt::responseMimeType):
(DumpRenderTreeSupportQt::clearOpener):
(DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportQt::contextMenu):
(DumpRenderTreeSupportQt::setMinimumTimerInterval):
(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
(DumpRenderTreeSupportQt::setAlternateHtml):
(DumpRenderTreeSupportQt::confirmComposition):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
(DumpRenderTreeSupportQt::paintPagesWithBoundaries):
(DumpRenderTreeSupportQt::setTrackRepaintRects):
(DumpRenderTreeSupportQt::trackRepaintRects):
(DumpRenderTreeSupportQt::getTrackedRepaintRects):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp:

(dumpRange):
(WebCore::EditorClientQt::shouldShowDeleteInterface):
(WebCore::EditorClientQt::shouldInsertText):
(WebCore::EditorClientQt::shouldChangeSelectedRange):
(WebCore::EditorClientQt::shouldApplyStyle):
(WebCore::EditorClientQt::respondToChangedContents):
(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::registerUndoStep):
(WebCore::EditorClientQt::clearUndoRedoOperations):
(WebCore::EditorClientQt::canUndo):
(WebCore::EditorClientQt::canRedo):
(WebCore::EditorClientQt::undo):
(WebCore::EditorClientQt::redo):
(WebCore::EditorClientQt::shouldInsertNode):
(WebCore::EditorClientQt::smartInsertDeleteEnabled):
(WebCore::EditorClientQt::toggleSmartInsertDelete):
(WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientQt::handleKeyboardEvent):
(WebCore::EditorClientQt::EditorClientQt):
(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):
(WebCore::EditorClientQt::setSmartInsertDeleteEnabled):
(WebCore::EditorClientQt::setSelectTrailingWhitespaceEnabled):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(drtDescriptionSuitableForTestResult):
(WebCore::FrameLoaderClientQt::setFrame):
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
(WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientQt::dispatchDidLayout):
(WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
(WebCore::FrameLoaderClientQt::restoreViewState):
(WebCore::FrameLoaderClientQt::userAgent):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientQt::frameLoaderDestroyed):
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientQt::didPerformFirstNavigation):
(WebCore::FrameLoaderClientQt::onIconLoadedForPageURL):
(WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
(WebCore::FrameLoaderClientQt::saveViewStateToItem):
(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::download):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchCreatePage):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):
(WebCore::FrameLoaderClientQt::createFrame):
(WebCore::FrameLoaderClientQt::createPlugin):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
(WebCore::FrameLoaderClientQt::chooseFile):
(WebCore::FrameLoaderClientQt::createNetworkingContext):
(WebCore):
(WebCore::FrameLoaderClientQt::webFrame):
(WebCore::FrameLoaderClientQt::emitLoadStarted):
(WebCore::FrameLoaderClientQt::emitLoadFinished):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::networkAccessManager):

  • WebCoreSupport/FrameNetworkingContextQt.h:

(FrameNetworkingContextQt):

  • WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):

  • WebCoreSupport/FullScreenVideoQt.h:

(WebCore):

  • WebCoreSupport/FullScreenVideoWidget.cpp:
  • WebCoreSupport/FullScreenVideoWidget.h:
  • WebCoreSupport/GeolocationClientQt.cpp:

(WebCore::GeolocationClientQt::GeolocationClientQt):
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):
(WebCore::GeolocationClientQt::requestPermission):
(WebCore::GeolocationClientQt::cancelPermissionRequest):

  • WebCoreSupport/GeolocationClientQt.h:

(GeolocationClientQt):

  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
(WebCore::GeolocationPermissionClientQt::setPermission):

  • WebCoreSupport/GeolocationPermissionClientQt.h:

(GeolocationPermissionClientQt):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit):
(WebKit::setWebKitWidgetsInitCallback):
(WebKit::initializeWebKitQt):
(WebKit::setImagePlatformResource):
(WebCore::initializeWebCoreQt):

  • WebCoreSupport/InitWebCoreQt.h:

(WebCore):
(WebKit):

  • WebCoreSupport/InitWebKitQt.cpp: Added.

(WebKit):
(WebKit::initializeWebKitWidgets):

  • WebCoreSupport/InitWebKitQt.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(WebKit):

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore):
(WebCore::InspectorClientQt::InspectorClientQt):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
(WebCore::InspectorClientQt::detachRemoteFrontend):
(WebCore::InspectorClientQt::hideHighlight):
(WebCore::InspectorClientQt::sendMessageToFrontend):
(WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
(WebCore::InspectorFrontendClientQt::updateWindowTitle):
(WebCore::InspectorFrontendClientQt::destroyInspectorView):

  • WebCoreSupport/InspectorClientQt.h:

(InspectorClientQt):
(InspectorFrontendClientQt):

  • WebCoreSupport/InspectorClientWebPage.cpp: Added.

(InspectorClientWebPage::InspectorClientWebPage):
(InspectorClientWebPage::createWindow):
(InspectorClientWebPage::javaScriptWindowObjectCleared):

  • WebCoreSupport/InspectorClientWebPage.h: Copied from Source/WebKit/qt/WebCoreSupport/WebSystemInterface.h.

(WebKit):
(InspectorClientWebPage):

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

  • WebCoreSupport/InspectorServerQt.h:

(InspectorServerQt):
(InspectorServerRequestHandlerQt):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
(WebCore::NotificationPresenterClientQt::dumpShowText):
(WebCore::NotificationPresenterClientQt::toPage):
(WebCore::NotificationPresenterClientQt::toFrame):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationWrapper::~NotificationWrapper):
(NotificationWrapper):
(NotificationPresenterClientQt):
(WebCore::NotificationPresenterClientQt::hasSystemTrayIcon):
(WebCore::NotificationPresenterClientQt::setSystemTrayIcon):
(CallbacksInfo):
(WebCore):

  • WebCoreSupport/PageClientQt.cpp:

(createPlatformGraphicsContext3DFromWidget):
(QWebPageClient::ownerWindow):
(WebCore::PageClientQWidget::ownerWidget):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::ownerWidget):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):

  • WebCoreSupport/PageClientQt.h:

(PageClientQWidget):
(WebCore::QGraphicsItemOverlay::QGraphicsItemOverlay):
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
(PageClientQGraphicsWidget):

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

  • WebCoreSupport/PopupMenuQt.cpp:

(SelectData::SelectData):

  • WebCoreSupport/QGraphicsWidgetPluginImpl.cpp: Added.

(QGraphicsWidgetPluginImpl::~QGraphicsWidgetPluginImpl):
(QGraphicsWidgetPluginImpl::update):
(QGraphicsWidgetPluginImpl::setGeometryAndClip):
(QGraphicsWidgetPluginImpl::setVisible):
(QGraphicsWidgetPluginImpl::setWidgetParent):
(QGraphicsWidgetPluginImpl::handle):

  • WebCoreSupport/QGraphicsWidgetPluginImpl.h: Added.

(QGraphicsWidgetPluginImpl):
(QGraphicsWidgetPluginImpl::QGraphicsWidgetPluginImpl):

  • WebCoreSupport/QWebFrameAdapter.cpp: Added.

(cacheLoadControlToCachePolicy):
(QWebFrameData::QWebFrameData):
(QWebFrameAdapter::QWebFrameAdapter):
(QWebFrameAdapter::~QWebFrameAdapter):
(QWebFrameAdapter::load):
(QWebFrameAdapter::handleGestureEvent):
(QWebFrameAdapter::scrollPosition):
(QWebFrameAdapter::frameRect):
(QWebFrameAdapter::init):
(QWebFrameAdapter::kit):
(QWebFrameAdapter::ensureAbsoluteUrl):

  • WebCoreSupport/QWebFrameAdapter.h: Added.

(WebCore):
(QWebFrameData):
(QWebFrameAdapter):
(QWebFrameAdapter::hasView):

  • WebCoreSupport/QWebPageAdapter.cpp: Added.

(QWebPageAdapter::QWebPageAdapter):
(QWebPageAdapter::~QWebPageAdapter):
(QWebPageAdapter::init):
(QWebPageAdapter::deletePage):
(QWebPageAdapter::kit):
(QWebPageAdapter::viewportArguments):
(QWebPageAdapter::registerUndoStep):
(QWebPageAdapter::setNetworkAccessManager):
(QWebPageAdapter::networkAccessManager):

  • WebCoreSupport/QWebPageAdapter.h: Added.

(WebCore):
(QWebPageAdapter):
(ErrorPageOption):
(ErrorPageReturn):

  • WebCoreSupport/QWebUndoCommand.cpp: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QWebUndoCommand::QWebUndoCommand):
(QWebUndoCommand::undo):
(QWebUndoCommand::redo):

  • WebCoreSupport/QWebUndoCommand.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QWebUndoCommand):

  • WebCoreSupport/QWidgetPluginImpl.cpp: Added.

(QWidgetPluginImpl::~QWidgetPluginImpl):
(QWidgetPluginImpl::update):
(QWidgetPluginImpl::setGeometryAndClip):
(QWidgetPluginImpl::setVisible):
(QWidgetPluginImpl::setStyleSheet):
(QWidgetPluginImpl::setWidgetParent):
(QWidgetPluginImpl::handle):

  • WebCoreSupport/QWidgetPluginImpl.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QWidgetPluginImpl):
(QWidgetPluginImpl::QWidgetPluginImpl):

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
(WebCore::QtFallbackWebPopup::show):
(WebCore::QtFallbackWebPopup::pageClient):

  • WebCoreSupport/QtFallbackWebPopup.h:

(QtFallbackWebPopup):

  • WebCoreSupport/QtPluginWidgetAdapter.h: Copied from Source/WebKit/qt/WebCoreSupport/QtWebComboBox.h.

(QtPluginWidgetAdapter):

  • WebCoreSupport/QtWebComboBox.cpp:

(WebCore::QtWebComboBox::showPopupAtCursorPosition):

  • WebCoreSupport/QtWebComboBox.h:
  • WebCoreSupport/SearchPopupMenuQt.h:

(SearchPopupMenuQt):

  • WebCoreSupport/UndoStepQt.cpp:

(UndoStepQt::UndoStepQt):
(UndoStepQt::text):

  • WebCoreSupport/UndoStepQt.h:

(UndoStepQt):

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
(WebKitPlatformWheelEvent):
(WebCore::WebKitPlatformWheelEvent::applyDelta):
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
(WebKitPlatformGestureEvent):
(WebCore::toPlatformEventType):
(WebCore::WebKitPlatformGestureEvent::WebKitPlatformGestureEvent):
(WebCore):
(WebCore::convertWheelEvent):
(WebCore::convertGesture):

  • WebCoreSupport/WebEventConversion.h:

(QGestureEventFacade):
(WebCore):

  • WebCoreSupport/WebSystemInterface.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadHtml5Video):
(tst_QWebPage::multiplePageGroupsAndLocalStorage):
(tst_QWebPage::thirdPartyCookiePolicy):

Source/WebKit2:

  • qt/MainQt.cpp:

(WebKit):
(main):

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):
(WebCore::WebPage::createWindow):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::initJSObjects):
(WebCore::DumpRenderTree::dumpFrameScrollPosition):
(WebCore::DumpRenderTree::dumpFramesAsText):
(WebCore::DumpRenderTree::dump):
(WebCore::DumpRenderTree::createWindow):
(WebCore::DumpRenderTree::pageAdapter):
(WebCore):
(WebCore::DumpRenderTree::mainFrameAdapter):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::contextClick):
(EventSender::scalePageBy):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):
(TestRunner::display):
(TestRunner::closeWebInspector):
(TestRunner::showWebInspector):
(TestRunner::evaluateInWebInspector):
(TestRunner::setFrameFlatteningEnabled):
(TestRunner::goBack):
(TestRunner::setDefersLoading):
(TestRunner::pauseAnimationAtTimeOnElementWithId):
(TestRunner::pauseTransitionAtTimeOnElementWithId):
(TestRunner::numberOfActiveAnimations):
(TestRunner::setCaretBrowsingEnabled):
(TestRunner::setAuthorAndUserStylesEnabled):
(TestRunner::callShouldCloseOnWebView):
(TestRunner::setSmartInsertDeleteEnabled):
(TestRunner::setSelectTrailingWhitespaceEnabled):
(TestRunner::execCommand):
(TestRunner::isCommandEnabled):
(TestRunner::findString):
(TestRunner::elementDoesAutoCompleteForElementWithId):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setGeolocationPermission):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setMockGeolocationPosition):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):
(TestRunner::setMinimumTimerInterval):

  • DumpRenderTree/qt/TextInputControllerQt.cpp:

(TextInputController::selectedRange):
(TextInputController::firstRectForCharacterRange):
(TextInputController::unmarkText):

  • DumpRenderTree/qt/WorkQueueItemQt.cpp:

(LoadAlternateHTMLStringItem::invoke):

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/production_build.prf:
  • qmake/mkspecs/features/webkit_modules.prf:
  • qmake/mkspecs/modules/webkitwidgets.prf: Added.
5:52 AM Changeset in webkit [135514] by kenneth@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2][EFL] No need to remove surface before replacing
https://bugs.webkit.org/show_bug.cgi?id=103055

Rubberstamped by Simon Hausmann.

The surface is stored in a OwnPtr which automatically
frees the existing surface after replacing it with a new
one. For some reason, this also fixes resizing issues on
my Nvidia driver.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::createGLSurface):

  • UIProcess/API/efl/EwkViewImpl.h:
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

5:52 AM Changeset in webkit [135513] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

5:51 AM Changeset in webkit [135512] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark LayoutTests/fast/canvas/canvas-stroke*-gradient-shadow.html as crashing after latest Skia roll.
https://bugs.webkit.org/show_bug.cgi?id=103062

  • platform/chromium/TestExpectations:
5:50 AM Changeset in webkit [135511] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

[Qt] Correct extensions on preferredFilename
https://bugs.webkit.org/show_bug.cgi?id=103054

Reviewed by Simon Hausmann.

When guessing a filename we will now ensure it has an extension that is valid for its mimetype.
To do this the two missing methods getExtensionsForMIMEType and getPreferredExtensionForMIMEType
have been added to the Qt implementation of MIMETypeRegistry.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getExtensionsForMIMEType):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

5:45 AM Changeset in webkit [135510] by tkent@chromium.org
  • 8 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Refactoring: Do not call updateInnerTextValue if only read-only sub-fields have values
https://bugs.webkit.org/show_bug.cgi?id=103033

Reviewed by Kentaro Hara.

Source/WebCore:

input[type=time] can have read-only sub fields. If only read-only fields
have values, we don't need to call updateInnerTextValue when
HTMLInputElement::value is set to "".

Tests: this patch doesn't change any visible behavior, but we add test cases to
fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
just in case.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare anyEditableFieldsHaveValues.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::anyEditableFieldsHaveValues):
Added. This function checks value existence against only editable sub-fields.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
Call DateTimeEditElement::anyEditableFieldsHaveValues() instead of
DateTimeFieldsState::hasAnyValue().

  • html/DateTimeFieldsState.h: Remove hasAnyValue.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html:
5:31 AM Changeset in webkit [135509] by keishi@webkit.org
  • 2 edits
    20 adds in trunk/LayoutTests

Add week-multiple-fields tests
https://bugs.webkit.org/show_bug.cgi?id=102045

Reviewed by Kent Tamura.

Adding test cases for multiple field week input.

  • fast/forms/resources/multiple-fields-blur-and-focus-events.js:

(startTestFor.beginTestCase):
(startTestFor):

  • fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-wheel-event-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.html: Added.
5:23 AM Changeset in webkit [135508] by commit-queue@webkit.org
  • 13 edits in trunk

WebKitTestRunner needs layoutTestController.setCacheModel
https://bugs.webkit.org/show_bug.cgi?id=42684

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add Bundle C API for WebKitTestRunner to set the
cache model.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetCacheModel):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setCacheModel):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/WebProcess.h:

(WebProcess):

Tools:

Add support for testRunner.setCacheModel to WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCacheModel):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskip fast/dom/HTMLScriptElement/nested-execution.html for
WK2 now that WebKitTestRunner implements
testRunner.setCacheModel.

  • platform/wk2/TestExpectations:
5:23 AM Changeset in webkit [135507] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt] Lookup mimetypes using QMimeDatabase
https://bugs.webkit.org/show_bug.cgi?id=102667

Reviewed by Simon Hausmann.

The Qt backend of MIMETypeRegistry now looks up using QMimeDatabase.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

Also map the preferred freedesktop mimetype for MIME archives to MIME archive constructor.

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

5:16 AM Changeset in webkit [135506] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941

Patch by Dan Carney <dcarney@google.com> on 2012-11-22
Reviewed by Jochen Eisinger.

Added v8 context to IDBRequestTest tests.

  • tests/IDBRequestTest.cpp:

(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):

4:39 AM Changeset in webkit [135505] by schenney@chromium.org
  • 5 edits
    1 add
    2 deletes in trunk/LayoutTests

Fixing some Chromium test expectations.

Unreviewed expectations update

  • platform/chromium-mac/fast/css/font-smoothing-expected.png:
  • platform/chromium-mac/fast/css/text-rendering-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/chromium-win/fast/css/font-smoothing-expected.png: Added.
  • platform/chromium/fast/css/font-smoothing-expected.png: Removed.
  • platform/chromium/fast/css/text-rendering-expected.png: Removed.
4:14 AM Changeset in webkit [135504] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r135399): Wrong assertion causing an assertion failure: m_rawAttributes.initialScale > 0
https://bugs.webkit.org/show_bug.cgi?id=102971

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

m_rawAttributes.initialScale has to be initialized even if m_minimumScaleToFit hasn't changed
it's value.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeViewportAttributes):

3:59 AM Changeset in webkit [135503] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Move URL-checking code into Frame
https://bugs.webkit.org/show_bug.cgi?id=103014

Patch by Cosmin Truta <ctruta@rim.com> on 2012-11-22
Reviewed by Ojan Vafai.

Move the common URL checking logic from HTMLFrameElementBase::isURLAllowed
and HTMLPlugInImageElement::allowedToLoadFrameURL into Frame::isURLAllowed.

No new tests. Refactoring.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed): Call Frame::isURLAllowed.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL): Call Frame::isURLAllowed.

  • page/Frame.cpp:

(WebCore::Frame::isURLAllowed): Added.

  • page/Frame.h:

(Frame): Added isURLAllowed.

3:31 AM Changeset in webkit [135502] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Rename toWebCoreStringWithNullOrUndefinedCheck() with toWebCoreStringWithUndefinedOrNullCheck()
https://bugs.webkit.org/show_bug.cgi?id=103013

Reviewed by Adam Barth.

IDL attributes and other V8 and JSC files use "UndefinedOrNull" instead of "NullOrUndefined".

No tests. No change in behavior.

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::compileScript):
(WebCore::ScriptDebugServer::runScript):

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):

  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreStringWithUndefinedOrNullCheck):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateCallback):

3:12 AM Changeset in webkit [135501] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

Chromium gardening. Rebaseline compositing tests
https://bugs.webkit.org/show_bug.cgi?id=103039

Reviewed by Pavel Feldman.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png:
2:59 AM Changeset in webkit [135500] by commit-queue@webkit.org
  • 7 edits in trunk

Name enumerator function for GetStats RTCStatsElement
https://bugs.webkit.org/show_bug.cgi?id=102933

Patch by Harald Alvestrand <hta@google.com> on 2012-11-22
Reviewed by Adam Barth.

Source/WebCore:

Tested by extensions to the RTCPeerConnection-stats test.

  • Modules/mediastream/RTCStatsElement.cpp:

(WebCore::RTCStatsElement::names):
(WebCore):

  • Modules/mediastream/RTCStatsElement.h:

(RTCStatsElement):

  • Modules/mediastream/RTCStatsElement.idl:

LayoutTests:

  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
2:12 AM Changeset in webkit [135499] by kkristof@inf.u-szeged.hu
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening

Add platform specific exception.

  • platform/qt/fast/js/concat-large-strings-crash-expected.txt: Added.
1:58 AM Changeset in webkit [135498] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Rename the "eden" bit to something more descriptive
https://bugs.webkit.org/show_bug.cgi?id=102985

Reviewed by Adam Barth.

InEdenFlag is not descriptive. Per the discussion in IRC,
we rename InEdenFlag to V8CollectableDuringMinorGCFlag.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::minorGCPrologue):

  • dom/Node.h:

(WebCore::Node::isV8CollectableDuringMinorGC):
(WebCore::Node::setV8CollectableDuringMinorGC):

1:47 AM Changeset in webkit [135497] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Move AddMessageListener() from WorkerContextExecutionProxy::initializeIfNeeded() to WorkerContextExecutionProxy::initIsolate()
https://bugs.webkit.org/show_bug.cgi?id=102998

Reviewed by Adam Barth.

This is an incremental step for moving initializeIfNeeded()
to V8Initializer.h. Given that AddMessageListener() needs to
be called once per Isolate, we can move AddMessageListener()
from initializeIfNeeded() to initIsolate().

No tests. No change in behavior.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):
(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):

1:44 AM Changeset in webkit [135496] by kbalazs@webkit.org
  • 8 edits in trunk/Tools

[Qt][WTR] TestController::platformRunUntil should not do busy waiting
https://bugs.webkit.org/show_bug.cgi?id=101327

Reviewed by Simon Hausmann.

Avoid busy waiting for events in platformRunUntil while making
sure we don't change the behavior of modal event loops.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::~TestController):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::platformDestroy):
(WTR):

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformDestroy):
(WTR):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformDestroy):
(WTR):

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(TestController::RunLoop): Helper class to handle
the event loop logic
(WTR):
(WTR::TestController::RunLoop::RunLoop):
(WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
the run loop. This is the appropriate API to push the WaitForMoreEvents
flag to QCoreApplication::processEvents and also being able to exit the
loop if we have timed out.
(WTR::TestController::RunLoop::notifyDone):
(WTR::TestController::RunLoop::timerFired):
(WTR::TestController::RunLoop::runModal):
(WTR::TestController::notifyDone):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):
(WTR::TestController::platformRunUntil):
(WTR::TestController::runModal):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformDestroy):
(WTR):

1:37 AM Changeset in webkit [135495] by msaboff@apple.com
  • 4 edits in trunk/Source

HTML integer parsing functions don't natively handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=102997

Reviewed by Filip Pizlo.

Source/WebCore:

In order to avoid unnecessary up convering of 8 bit strings to 16 bits, added 8 bit paths to
parseHTMLInteger() and parseHTMLNonNegativeInteger() by breaking out the core logic into
templated helper functions. These methods are primarily used to process attribute values.

No new tests needed, functionnality covered by existing tests.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLIntegerInternal):
(WebCore::parseHTMLInteger):
(WebCore::parseHTMLNonNegativeIntegerInternal):
(WebCore::parseHTMLNonNegativeInteger):

Source/WTF:

Added exports to the LChar* versions of charactersToIntStrict() and charactersToUIntStrict()
to support the changes made to parseHTMLInteger() and parseHTMLNonNegativeInteger().

  • wtf/text/WTFString.h:

(WTF::charactersToIntStrict): Added export
(WTF::charactersToUIntStrict): Added export

1:28 AM Changeset in webkit [135494] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] WebCoreStringResourceBase should be located in V8StringResource.h
https://bugs.webkit.org/show_bug.cgi?id=103002

Reviewed by Adam Barth.

Currently WebCoreStringResourceBase is mis-located in V8ValueCache.h.
It should be in V8StringResource.h.

No tests. No change in behavior.

  • bindings/v8/V8StringResource.cpp:

(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(WebCore):
(WebCore::WebCoreStringResourceBase::visitStrings):

  • bindings/v8/V8StringResource.h:

(WebCore):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::webcoreString):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCore::WebCoreStringResourceBase::memoryConsumption):
(WebCoreStringResource16):
(WebCore::WebCoreStringResource16::WebCoreStringResource16):
(WebCoreStringResource8):
(WebCore::WebCoreStringResource8::WebCoreStringResource8):

  • bindings/v8/V8ValueCache.cpp:
  • bindings/v8/V8ValueCache.h:

(WebCore):

1:24 AM Changeset in webkit [135493] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: NMI add instrumentation to DynamicNodeList classes hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=103025

Reviewed by Yury Semikhatsky.

RNiwa changed pointer type in NodeRareData::NodeListAtomicNameCacheMap from the topmost
DynamicSubtreeNodeList to the base DynamicNodeListCacheBase at r135429.
As a result we got non zero count of pointers that don't match with tcmalloc data,
because DynamicNodeList uses multiple inheritance.
It could be fixed with help of explicit native memory instrumentation for DynamicNodeList class hierarchy.

No change in behavior, so no new tests.

  • dom/Document.cpp: drive by fix.

(WebCore::Document::reportMemoryUsage):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::reportMemoryUsage):
(WebCore):
(WebCore::DynamicNodeList::reportMemoryUsage):
(WebCore::DynamicSubtreeNodeList::reportMemoryUsage):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::~DynamicNodeListCacheBase):
(DynamicNodeListCacheBase):
(DynamicNodeList):
(DynamicSubtreeNodeList):

12:56 AM Changeset in webkit [135492] by yurys@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Rebaselined new tests added in r135454.

  • platform/chromium/fast/js/concat-large-strings-crash-expected.txt: Added.
  • platform/chromium/fast/js/concat-large-strings-crash2-expected.txt: Added.
12:40 AM Changeset in webkit [135491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Correct the parameters of WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=102865

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Set the screen position as a third parameter and contents position as
a fourth parameter of WebPlatformTouchPoint().

  • Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

12:36 AM Changeset in webkit [135490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102894

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

CoordinatedGraphicsLayer does not need to have a backing store

if (!drawsContent()
!contentsAreVisible() m_size.isEmpty()).
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

12:30 AM Changeset in webkit [135489] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
https://bugs.webkit.org/show_bug.cgi?id=102926

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-22
Reviewed by Kenneth Rohde Christiansen.

Add missing bits needed by WKPreferences and AboutBlankLoad API
tests in the test harness and enable these tests on EFL port.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/efl/PlatformUtilities.cpp:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
(Util):

12:13 AM Changeset in webkit [135488] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r135482.
http://trac.webkit.org/changeset/135482
https://bugs.webkit.org/show_bug.cgi?id=103002

It broke Chrome/Linux Debug build

  • bindings/v8/V8StringResource.cpp:
  • bindings/v8/V8StringResource.h:
  • bindings/v8/V8ValueCache.cpp:

(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(WebCore):
(WebCore::WebCoreStringResourceBase::visitStrings):

  • bindings/v8/V8ValueCache.h:

(WebCore):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::webcoreString):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCore::WebCoreStringResourceBase::memoryConsumption):
(WebCoreStringResource16):
(WebCore::WebCoreStringResource16::WebCoreStringResource16):
(WebCoreStringResource8):
(WebCore::WebCoreStringResource8::WebCoreStringResource8):

12:09 AM Changeset in webkit [135487] by commit-queue@webkit.org
  • 21 edits
    1 copy in trunk/Source/WebCore

Unreviewed, rolling out r134927 and r134944.
http://trac.webkit.org/changeset/134927
http://trac.webkit.org/changeset/134944
https://bugs.webkit.org/show_bug.cgi?id=103028

Reverting the reverts after merging. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-22

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AdvancedSearchController.js:
  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerShortcuts):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/GoToLineDialog.js:

(WebInspector.GoToLineDialog.install):

  • inspector/front-end/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut._keyName):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.registerShortcuts):
(WebInspector.PanelDescriptor.prototype.panel):
(WebInspector.PanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):

  • inspector/front-end/ScriptsPanelDescriptor.js:

(WebInspector.ScriptsPanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen):
(WebInspector.ShortcutsSection):
(WebInspector.ShortcutsSection.prototype._renderKey):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):

  • inspector/front-end/TimelinePanelDescriptor.js: Copied from Source/WebCore/inspector/front-end/ScriptsPanelDescriptor.js.

(WebInspector.TimelinePanelDescriptor):
(WebInspector.TimelinePanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):
(WebInspector._registerShortcuts):

12:06 AM Changeset in webkit [135486] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Coordinated Graphics: refactor LayerTreeRenderer.
https://bugs.webkit.org/show_bug.cgi?id=103004

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-22
Reviewed by Noam Rosenthal.

This patch changes two subjects.

  1. Add ASSERT(isMainThread()) in all methods that are called in the main thread.

In addition, make dispatchOnMainThread() use callOnMainThread(const Function<void()>&
function) instead of its own implementation.

  1. Remove setAccelerationMode() because we don't use m_accelerationMode member

except for the setter.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::createGLSurface):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit):
(WebKit::LayerTreeRenderer::dispatchOnMainThread):
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::updateViewport):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit::LayerTreeRenderer::detach):
(WebKit::LayerTreeRenderer::setActive):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::createDrawingAreaProxy):

Note: See TracTimeline for information about the timeline view.