Timeline



Jan 14, 2013:

11:55 PM Changeset in webkit [139721] by tkent@chromium.org
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139038

REGRESSION(r137406): Text inside an empty optgroup prevents subsequent options from appearing
​https://bugs.webkit.org/show_bug.cgi?id=106298

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/forms/select/select-empty-optgroup.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):
Traverse to the first element within the 'current' only if it exists.

LayoutTests:

  • fast/forms/select/select-empty-optgroup-expected.html: Added.
  • fast/forms/select/select-empty-optgroup.html: Added.

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/11881046

11:47 PM Changeset in webkit [139720] by tkent@chromium.org
  • 4 edits in branches/chromium/1364

Merge 139151

REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value=""
​https://bugs.webkit.org/show_bug.cgi?id=106284

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. Updates fast/forms/number/number/validity-badinput.html.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValue):
If the new sanitized value is empty and innerTextValue is a bad input
(it means !valueChanged && !innerTextValue().isEmpty() because the new
sanitized value is empty), we need to update innerTextValue with the
empty string.

  • html/NumberInputType.h:

(NumberInputType): Declare setValue.

LayoutTests:

  • fast/forms/number/number-validity-badinput.html:

Add a test case.

  • fast/forms/number/number-validity-badinput-expected.txt:

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/11884049

11:20 PM Changeset in webkit [139719] by dominicc@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening.

Roll Chromium to r176801.

  • DEPS: Rollin' on the river.
10:53 PM Changeset in webkit [139718] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add XP image expectations for this test; see
<​https://bugs.webkit.org/show_bug.cgi?id=106875>:

svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

  • platform/chromium/TestExpectations:
10:15 PM Changeset in webkit [139717] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Remove nonexistent file in ANGLE Xcode project

  • ANGLE.xcodeproj/project.pbxproj: Remove references to

ossource_nspr.cpp which was removed in r139665.

9:29 PM Changeset in webkit [139716] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add Lion Debug crash expectations for this test; see
<​https://bugs.webkit.org/show_bug.cgi?id=106869>:

fast/mediastream/RTCPeerConnection-events.html

  • platform/chromium/TestExpectations:
9:25 PM Changeset in webkit [139715] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: stub out show_results_html for mock ports
​https://bugs.webkit.org/show_bug.cgi?id=106848

Reviewed by Ojan Vafai.

We were accidentally using the underlying ports'
show_results_html_file() implementation, which would, unsurprisingly,
fail in many cases (e.g., running mock-efl on the mac).

No test added since we don't generally add tests for the mock
implementation.

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.show_results_html_file):

9:22 PM Changeset in webkit [139714] by commit-queue@webkit.org
  • 6 edits in trunk

Implement ID selector matching for the WebVTT ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=105481

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-14
Reviewed by Eric Carlson.

Source/WebCore:

Implemented matching cue WebVTT elements by an identifier. Identifiers of all WebVTT nodes in the rendering tree for
a given cue are set to match the cue identifier.

Existing tests were modified to cover this case.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes):

LayoutTests:

  • media/track/captions-webvtt/styling.vtt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching.html:
9:17 PM Changeset in webkit [139713] by pilgrim@chromium.org
  • 1 edit
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove unused public/platform/WebColorName.h
​https://bugs.webkit.org/show_bug.cgi?id=106865

Reviewed by Adam Barth.

This file is no longer referenced anywhere in WebKit or Chromium.

  • public/platform/WebColorName.h: Removed.
9:16 PM Changeset in webkit [139712] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

Changing clean_working_directory/clean_local_commits and related
functions to have consistent naming.

​https://bugs.webkit.org/show_bug.cgi?id=104198

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-14
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
9:15 PM Changeset in webkit [139711] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Use explicit WebKit prefixes in BlobRegistryProxy
​https://bugs.webkit.org/show_bug.cgi?id=106859

Reviewed by Adam Barth.

As requested in ​https://bugs.webkit.org/show_bug.cgi?id=106831#c2

  • platform/network/chromium/BlobRegistryProxy.cpp:

(WebCore::BlobRegistryProxy::registerBlobURL):

9:06 PM Changeset in webkit [139710] by mvujovic@adobe.com
  • 2 edits in trunk/Source/WebCore

[ANGLE] Update ANGLE in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106274

Unreviewed build fix for GTK after ​http://trac.webkit.org/changeset/139702

  • GNUmakefile.am:
7:49 PM Changeset in webkit [139709] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Update test expectations for these tests:

fast/images/zoomed-offset-size.html
media/track/track-css-cue-lifetime.html
svg/custom/foreign-object-skew.svg
svg/custom/foreign-object-skew.svg

  • platform/chromium/TestExpectations:
7:46 PM Changeset in webkit [139708] by dominicc@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline these tests:

scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.html

after r139686. Note in TestExpectations image failure for
non-fast-scrollable-region-transformed-iframe.html on SnowLeopard
Debug; see <​https://bugs.webkit.org/show_bug.cgi?id=106858>

  • platform/chromium-mac-lion/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
  • platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • platform/chromium/TestExpectations:
7:40 PM Changeset in webkit [139707] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Yet another unreviewed attempted QT build fix, this time because
it's falling over on Filters.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):

7:12 PM Changeset in webkit [139706] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix.

  • CMakeLists.txt:
7:02 PM Changeset in webkit [139705] by dino@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed QT build fix.

  • ANGLE.pri:
7:00 PM Changeset in webkit [139704] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Tools

Fix EWS GCE build scripts to detect which zone is available
​https://bugs.webkit.org/show_bug.cgi?id=106524

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-14
Reviewed by Adam Barth.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/GoogleComputeEngine/findzone.sh: Added.
6:49 PM Changeset in webkit [139703] by rafaelw@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

fast/dom/HTMLTemplateElement/inertContents.html is flaky on Debug Chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=106810

Reviewed by Levi Weintraub.

This patch reverts the test for inertContents back to a non-flaky version which did not
attempt to assert that images are prevented from loaded.

  • fast/dom/HTMLTemplateElement/inertContents-expected.txt:
  • fast/dom/HTMLTemplateElement/inertContents.html:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Removed.
6:45 PM Changeset in webkit [139702] by dino@apple.com
  • 7 edits in trunk/Source

[ANGLE] Update ANGLE in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106274

Unreviewed attempted build fix.

Source/ThirdParty/ANGLE:

Remove the copy files stage. Make khrplatform.h a public header.

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLSLANG/ShaderLang.h:

Source/WebKit:

The khrplatform.h file is now a public header without a directory
prefix. Update the include path to look in the right place.

  • PlatformEfl.cmake:

Source/WebKit2:

The khrplatform.h file is now a public header without a directory
prefix. Update the include path to look in the right place.

  • PlatformEfl.cmake:
6:44 PM Changeset in webkit [139701] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Blur the label background of a snapshotted plugin
​https://bugs.webkit.org/show_bug.cgi?id=106630

Reviewed by Simon Fraser.

When we are showing a label indicating the plugin has been snapshotted,
slightly blur the snapshot behind the label so that it is more clear. I expect
that if/when other ports pick up this code, we'll need to separate the
UI treatment somewhat, but this is ok for a first step.

  • rendering/RenderSnapshottedPlugIn.cpp:

(RenderSnapshottedPlugInBlurFilter): Private class to use FEGaussianBlur to blur an image.
(WebCore::RenderSnapshottedPlugInBlurFilter::create):
(WebCore::RenderSnapshottedPlugInBlurFilter::setSourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::sourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::filterRegion):
(WebCore::RenderSnapshottedPlugInBlurFilter::output):
(WebCore::RenderSnapshottedPlugInBlurFilter::RenderSnapshottedPlugInBlurFilter):
(WebCore::RenderSnapshottedPlugInBlurFilter::apply):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New member variable to hold a cached version of a preblurred snapshot.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Remember to remove the preblurred image from the cache.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Zero the preblurred version if it exists.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Either paint snapshot or blurred snapshot with label.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): New method to paint a full sized snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::snapshottedPluginImageForLabelDisplay): Static function to produce the blurred snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel): Calls paintSnapshot with the blurred snapshot on Mac.

  • rendering/RenderSnapshottedPlugIn.h:
6:08 PM Changeset in webkit [139700] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Adding an error string to AmbiguousCommitError.
​https://bugs.webkit.org/show_bug.cgi?id=106846

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-14
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(AmbiguousCommitError.init):

6:06 PM Changeset in webkit [139699] by leviw@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening. Adding mac expectatons after r139686.

  • platform/chromium-mac/scrollingcoordinator: Added.
  • platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
5:58 PM Changeset in webkit [139698] by pilgrim@chromium.org
  • 4 edits
    2 moves in trunk/Source

[Chromium] Move BlobRegistryProxy into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106831

Reviewed by Adam Barth.

Part of a larger refactoring series to remove layering violations
in Chromium. See tracking bug 106829.

Source/WebCore:

  • WebCore.gypi:
  • platform/network/chromium/BlobRegistryProxy.cpp: Added.

(WebCore):
(WebCore::blobRegistry):
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
(WebCore::BlobRegistryProxy::registerBlobURL):
(WebCore::BlobRegistryProxy::unregisterBlobURL):

  • platform/network/chromium/BlobRegistryProxy.h: Added.

(WebCore):
(BlobRegistryProxy):
(WebCore::BlobRegistryProxy::loadResourceSynchronously):
(WebCore::BlobRegistryProxy::~BlobRegistryProxy):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/BlobRegistryProxy.cpp: Removed.
  • src/BlobRegistryProxy.h: Removed.
5:40 PM Changeset in webkit [139697] by dpranke@chromium.org
  • 3 edits in trunk/Tools

kill whole lighttpd process tree for chromium win
​https://bugs.webkit.org/show_bug.cgi?id=106838

Reviewed by Tony Chang.

Land a speculative fix for lighttpd.exe hanging on some chromium bots;
I think a test is causing a httpd server child process to wedge and
killing the parent httpd server process isn't sufficient to ensure
that the children are also killed.

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd._check_and_kill):

  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:

(TestHttpServer.test_start_cmd):
(TestHttpServer):
(TestHttpServer.test_win32_start_and_stop):
(TestHttpServer.test_win32_start_and_stop.wait_for_action):
(TestHttpServer.test_win32_start_and_stop.mock_returns):
(TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):

5:36 PM Changeset in webkit [139696] by leviw@chromium.org
  • 8 edits in trunk

Source/WebCore: Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:

LayoutTests: Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
5:31 PM Changeset in webkit [139695] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

5:22 PM Changeset in webkit [139694] by leviw@chromium.org
  • 22 edits
    3 deletes in trunk

Source/WebCore: Rolling out r139683. It broke a bunch of webkit_unit_tests.

Source/WebKit/win: Rolling out r139683. It broke a bunch of webkit_unit_tests.

5:19 PM Changeset in webkit [139693] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderListItem does not need to override computePreferredLogicalWidth
​https://bugs.webkit.org/show_bug.cgi?id=106839

Reviewed by Levi Weintraub.

Apparently there was a time when the list marker was considered part of
the list item's preferred width, but that is no longer the case.
This code was added in r3421. The code around preferred widths has change
a lot since then.

  • rendering/RenderListItem.cpp:
  • rendering/RenderListItem.h:
5:17 PM Changeset in webkit [139692] by commit-queue@webkit.org
  • 9 edits in trunk

Implement element type selectors for the WebVTT ::cue pseudo class
​https://bugs.webkit.org/show_bug.cgi?id=105480

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-14
Reviewed by Antti Koivisto.

Source/WebCore:

Implemented tag matching for the WebVTT specific tags "c" and "v". All common html tags like "b" and "i" are
handled without any changes to the code. Creating a rendering tree and DOM tree now use different code paths.
They both are made by cloning and modifying the tree produced by the parser. Voice tags now use spans for both
rendering and DOM trees to conform to specs. Since this changes a lot of code little refactoring has been
done. Removed m_hasInnerTimestamps since it is no longer needed, it doesn't affect anything. m_documentFragment
was renamed to m_webVTTNodeTree.

Existing tests were modified to cover this case.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::setText): rename m_documentFragment to m_webVTTNodeTree
(WebCore::TextTrackCue::createWebVTTNodeTree): parse the cue if it hasn't been parsed before.
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): clone and prepare a node for using in the DOM tree according to specs.
(WebCore::TextTrackCue::getCueAsHTML): get a DOM tree for the cue.
(WebCore::TextTrackCue::createCueRenderingTree): create a rendering tree (main tree is just being cloned for now).
(WebCore::TextTrackCue::markFutureAndPastNodes): tightening the argument type.
(WebCore::TextTrackCue::updateDisplayTree):
(WebCore::TextTrackCue::getDisplayTree): code cleanup, removed m_hasInnerTimeStamps.

  • html/track/TextTrackCue.h:

(WebCore::TextTrackCue::voiceElementTagName):
(TextTrackCue):
(WebCore::TextTrackCue::classElementTagName):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken): type of the newly created elements was changed to Element to avoid hitting
an assertion when cloning because a cloned element will not have HTMLElement type for elements with "v" and "c" tag.

LayoutTests:

  • media/track/captions-webvtt/styling.vtt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching.html:
  • media/track/track-webvtt-tc026-voice.html: voice elements should be spans according to specs.
5:13 PM Changeset in webkit [139691] by wangxianzhu@chromium.org
  • 6 edits
    2 adds in trunk

Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
​https://bugs.webkit.org/show_bug.cgi?id=106271

Reviewed by Simon Fraser.

Source/WebCore:

  1. If a layer has no out-of-flow descendant, m_hasOutOfFlowPositionedDescendant won't change and won't trigger updateNeedsCompositedScrolling in updateDescendantDependentFlags. Set m_hasOutOfFlowPositionedDescendantDirty to true and call updateNeedsCompositedScrolling when the dirty flag becomes false from true.
  2. When the content size changes causing change of scrollable status, updateNeedsCompositedScrolling should also be called.

Test: compositing/overflow/dynamic-composited-scrolling-status.html

  • page/FrameView.cpp:

(WebCore::FrameView::addScrollableArea): Returns whether the scrollable area has just been newly added.
(WebCore::FrameView::removeScrollableArea): Returns whether the scrollable area has just been removed.

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Changed the initial value of m_hasOutOfFlowPositionedDescendantDirty to true to make sure m_hasOutOfFlowPositionedDescendant will be updated initially.
(WebCore::RenderLayer::updateDescendantDependentFlags): Call updateNeedsCompositedScrolling when m_hasOutOfFlowPositionedDescendantDirty is true.
(RenderLayer::updateScrollableAreaSet): Calls updateNeedsCompositedScrolling() when scrollable status changes.

  • rendering/RenderLayer.h:

(RenderLayer):

LayoutTests:

  • compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
  • compositing/overflow/dynamic-composited-scrolling-status.html: Added.
5:02 PM Changeset in webkit [139690] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL build fix after r139681.

  • dom/NodeRareData.h:

(WebCore::NodeMicroDataTokenLists::NodeMicroDataTokenLists):

5:00 PM Changeset in webkit [139689] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] Enable update-webkit --chromium --ninja on windows
​https://bugs.webkit.org/show_bug.cgi?id=106836

Reviewed by Eric Seidel.

After running this, build-webkit --chromium will use ninja to build.
Apparently there are some minor issues with that still, so it's
not quite ready for use yet.

  • Scripts/webkitdirs.pm:

(determineIsChromiumNinja):
(buildChromium):

4:56 PM Changeset in webkit [139688] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should not forget that it had proved something to be a constant during a merge just because it's merging against the empty value
​https://bugs.webkit.org/show_bug.cgi?id=106727

Reviewed by Oliver Hunt.

The problem was this statement:

if (m_value != other.m_value)

m_value = JSValue();


This is well-intentioned, in the sense that if we want our abstract value (i.e. this) to become the superset of the other
abstract value, and the two abstract values have proven different constants, then our abstract value should rescind its
claim that it has been proven to be constant. But this misses the special case that if the other abstract value is
completely clear (meaning that it wishes to contribute zero information and so the superset operation shouldn't change
this), it will have a clear m_value. So, the code prior to this patch would rescind the constant proof even though it
didn't have to.

This comes up rarely and I don't believe it will be a performance win, but it is good to have the CFA been consistently
precise as often as possible.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::merge):

4:53 PM Changeset in webkit [139687] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

Python implementation reports "MemoryError" instead of doing things
​https://bugs.webkit.org/show_bug.cgi?id=106690

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The bug was that the CFA was assuming that a variable is dead at the end of a basic block and hence doesn't need to
be merged to the next block if the last mention of the variable was dead. This is almost correct, except that it
doesn't work if the last mention is a GetLocal - the GetLocal itself may be dead, but that doesn't mean that the
variable is dead - it may still be live. The appropriate thing to do is to look at the GetLocal's Phi. If the
variable is used in the next block then the next block will have a reference to the last mention in our block unless
that last mention is a GetLocal, in which case it will link to the Phi. Doing it this way captures everything that
the CFA wants: if the last use is a live GetLocal then the CFA needs to consider the GetLocal itself for possible
refinements to the proof of the value in the variable, but if the GetLocal is dead, then this must mean that the
variable is not mentioned in the block but may still be "passed through" it, which is what the Phi will tell us.
Note that it is not possible for the GetLocal to refer to anything other than a Phi, and it is also not possible
for the last mention of a variable to be a dead GetLocal while there are other mentions that aren't dead - if
there had been SetLocals or GetLocals prior to the dead one then the dead one wouldn't have been emitted by the
parser.

This also fixes a similar bug in the handling of captured variables. If a variable is captured, then it doesn't
matter if the last mention is dead, or not. Either way, we already know that a captured variable will be live in
the next block, so we must merge it no matter what.

Finally, this change makes the output of Operands dumping a bit more verbose: it now prints the variable name next
to each variable's dump. I've often found the lack of this information confusing particularly for operand dumps
that involve a lot of variables.

  • bytecode/Operands.h:

(JSC::dumpOperands):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::mergeStateAtTail):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt: Added.
  • fast/js/dfg-cfa-merge-with-dead-use-at-tail.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js: Added.

(foo):

4:51 PM Changeset in webkit [139686] by commit-queue@webkit.org
  • 3 edits
    14 adds in trunk

Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms
​https://bugs.webkit.org/show_bug.cgi?id=105075

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

As mentioned by the FIXME comment, we need to ask the renderer for the
absolute bounding box of a frame for correct transformation.
This fixes the bug that iframe cannot be scrolled properly when it is
transformed.

Source/WebCore:

Tests: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html

scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaBoundingBox):

LayoutTests:

  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html: Added.
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html: Added.
  • scrollingcoordinator/resources/non-fast-scrollable-region-testing.js: Added.

(runNonFastScrollableRegionTest):

4:45 PM Changeset in webkit [139685] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12524710> Update sandbox rules after r128003
​https://bugs.webkit.org/show_bug.cgi?id=106840

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb.in:
4:12 PM Changeset in webkit [139684] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.

  • platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
4:10 PM Changeset in webkit [139683] by Nate Chapin
  • 24 edits
    3 adds in trunk

.: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

  • Source/autotools/symbols.filter: Expose MemoryCache::resourceForURL().

Source/WebCore: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

Test: http/tests/cache/cached-main-resource.html

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute.

  • dom/Document.h:

(Document):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since

MainResourceLoader will take care of it.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also,

ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader.

(WebCore::MainResourceLoader::identifier):

  • loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader

to better describe when it is used.

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary.
(WebCore::CachedRawResource::willSendRequest): Note the redirects we received.
(WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store".

  • loader/cache/CachedRawResource.h:

(CachedRawResource):
(RedirectPair):
(WebCore::CachedRawResource::RedirectPair::RedirectPair):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet):: Don't return cached data for a main resource synchronously

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::canReuse):
(CachedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources.

  • testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/win: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

  • WebKit.vcproj/WebKitExports.def.in: Expose some MemoryCache symbols for use in Internals.

LayoutTests: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667.

Reviewed by Antti Koivisto.

  • http/tests/cache/cached-main-resource-expected.txt: Added.
  • http/tests/cache/cached-main-resource.html: Added.
  • http/tests/cache/resources/cacheable-iframe.php: Added.
  • http/tests/inspector/resource-har-pages-expected.txt:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
  • http/tests/misc/link-rel-icon-beforeload-expected.txt:
4:09 PM Changeset in webkit [139682] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix vcproj file. Missing file tag after ​http://trac.webkit.org/changeset/139541.

3:57 PM Changeset in webkit [139681] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Move functions from NodeRareData to ElementRareData and other classes
​https://bugs.webkit.org/show_bug.cgi?id=106679

Reviewed by Benjamin Poulain.

Moved tab index related functions from NodeRareData to ElementRareData since only
HTMLElement uses them, and moved related functions on Node to Element accordingly.

Also replaced transientMutationObserverRegistry and ensureTransientMutationObserverRegistry
by ensureMutationObserverData, and moved micro-data related member functions into
NodeMicroDataTokenLists, and moved NodeMutationObserverData and NodeMicroDataTokenLists
out of NodeRareData as they're used outside of NodeRareData now.

The intention is to move more code into NodeMutationObserverData and NodeMicroDataTokenLists
in the follow up patches so that they can detect the removability of NodeRareData.

No new tests are added since there should be no behavior changes.

  • dom/Element.cpp:

(WebCore::Element::clearTabIndexExplicitlyIfNeeded):
(WebCore::Element::setTabIndexExplicitly):
(WebCore::Element::tabIndex):
(WebCore::Element::supportsFocus):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::tabIndex):
(WebCore::ElementRareData::setTabIndexExplicitly):
(WebCore::ElementRareData::tabIndexSetExplicitly):
(WebCore::ElementRareData::clearTabIndexExplicitly):

  • dom/Node.cpp:

(WebCore::Node::tabIndex):
(WebCore::Node::supportsFocus):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeMutationObserverData):
(WebCore::NodeMutationObserverData::create):
(NodeMicroDataTokenLists):
(WebCore::NodeMicroDataTokenLists::create):
(WebCore::NodeMicroDataTokenLists::itemProp):
(WebCore::NodeMicroDataTokenLists::itemRef):
(WebCore::NodeMicroDataTokenLists::itemType):
(NodeRareData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::ensureMicroDataTokenLists):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):

3:53 PM Changeset in webkit [139680] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
​https://bugs.webkit.org/show_bug.cgi?id=106832

Reviewed by Levi Weintraub.

These are both called from locations that either set these bits themselves
or clearly don't need these bits set (e.g. computePreferredLogicalWidths).

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

3:50 PM Changeset in webkit [139679] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: use the same search path for baselines and TestExpectations on apple mac
​https://bugs.webkit.org/show_bug.cgi?id=105599

Reviewed by Ryosuke Niwa.

Bug 105583 revealed some confusion due to the fact that the Apple
Mac port used a different list of directories to search for baselines
and TestExpectations files (actually, pretty much every port does).

It seems like a good idea to use the same list for both by default, but
making this happen will affect every port in slightly different ways, so
we'll try this on the Apple Mac port first.

Note that the effective changes for this are that:
1) The apple mac port will look in platform/wk2 for baselines where
it didn't before (it will look after looking in mac-wk2 but before
the non-wk2 dirs)
2) The apple mac-snowleopard port will use the expectations in
mac-lion as well as the expectations in mac-snowleopard, although
I'm not even sure if mac-snowleopard is still supported ...

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_baseline_search_path):
(MacPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_baseline_search_path):

3:49 PM Changeset in webkit [139678] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Switch AudioDestinationChromium over to new createAudioDevice() method
​https://bugs.webkit.org/show_bug.cgi?id=106816

Reviewed by James Robinson.

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

3:49 PM Changeset in webkit [139677] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.

  • platform/chromium/TestExpectations:
3:44 PM Changeset in webkit [139676] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
Likely Stephen Schenney's skia changes are to blame.

  • platform/chromium/TestExpectations:
3:13 PM Changeset in webkit [139675] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.
​https://bugs.webkit.org/show_bug.cgi?id=106512

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-14
Reviewed by Kenneth Rohde Christiansen.

PageViewportController handles only pageScaleFactor after r139189. So
PageViewportControllerClientEFL calls EwkView::setScaleFactor() with
pageScaleFactor instead of pageScaleFactor * deviceScaleFactor.

This patch makes EwkView handle pageScaleFactor.

  1. EwkView uses pageScaleFactor * deviceScaleFactor when drawing in

the device unit.

  1. EwkView uses pageScaleFactor when notifying the scale to

PageViewportController.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::deviceScaleFactor):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::displayTimerFired):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):
(EwkViewImpl::setPageScaleFactor):
(EwkViewImpl::pageScaleFactor):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didRenderFrame):

  • UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::updateViewportSize):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
(WebKit::PageViewportControllerClientEfl::didResumeContent):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(PageViewportControllerClientEfl):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::setPageScaleFactor):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

3:11 PM Changeset in webkit [139674] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[TexMap] Use a premuliplied color in TextureMapperGL.
​https://bugs.webkit.org/show_bug.cgi?id=105786

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-14
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperGL always uses a premultiplied color, so we must convert
an unmultiplied color to a premultiplied color before setting the uniform value of
colorLocation.

Test: compositing/background-color/background-color-alpha-with-opacity.html

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::prepareFilterProgram):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::blendWithOpacity):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):

TextureMapperLayer must not convert solidColor to premultiplied
color, because TextureMapperImageBuffer expects unmultiplied color.

LayoutTests:

Created new tests for composited background colors with fractional
number opacity. This test is similar to background-color-alpha.html

  • compositing/background-color/background-color-alpha-with-opacity-expected.html: Added.
  • compositing/background-color/background-color-alpha-with-opacity.html: Added.
3:02 PM Changeset in webkit [139673] by arko@motorola.com
  • 3 edits
    2 adds in trunk

Microdata: REGRESSION(r138725): Causes crash in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=106828

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should hold PropertyNodeList in RefPtr<PropertyNodeList>.

Test: fast/dom/MicroData/propertiescollection-crash.html

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

LayoutTests:

  • fast/dom/MicroData/propertiescollection-crash-expected.txt: Added.
  • fast/dom/MicroData/propertiescollection-crash.html: Added.
2:57 PM Changeset in webkit [139672] by Lucas Forschler
  • 3 edits in tags/Safari-537.26/Source/WebKit2

Merged r139655.

2:48 PM Changeset in webkit [139671] by schenney@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline after Skia changes

Unreviewed expectatiosn update for two remaining tests.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/chromium/fast/borders/outline-alpha-inline-expected.png: Removed.
2:46 PM Changeset in webkit [139670] by cevans@google.com
  • 3 edits in branches/chromium/1364/Source/WebCore/platform/image-encoders/skia

Merge 138170
BUG=162551
Review URL: ​https://codereview.chromium.org/11876030

2:44 PM Changeset in webkit [139669] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Positioned children of an overflow:visible container should ignore scroll offset when updating layer position
​https://bugs.webkit.org/show_bug.cgi?id=106814

Source/WebCore:

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes ​http://crbug.com/167985

Test: fast/overflow/overflow-visible-should-ignore-scroll.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes ​http://crbug.com/167985

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

  • fast/overflow/overflow-visible-should-ignore-scroll-expected.html: Added.
  • fast/overflow/overflow-visible-should-ignore-scroll.html: Added.
2:41 PM Changeset in webkit [139668] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r139659.

  • platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
2:41 PM Changeset in webkit [139667] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FCC appears when switching search engine providers
​https://bugs.webkit.org/show_bug.cgi?id=106824

Magnifying glass appears when switching search engine providers

PR 279178

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-01-14
Reviewed by Rob Buis.
Internal Reviewed by Mike Fenton.

We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
to show the FCC.

This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
when the user touches an element that is not a textfield and changes the caret in the inputbar..

Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
search engine providers.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

2:40 PM Changeset in webkit [139666] by alecflett@chromium.org
  • 44 edits
    12 deletes in trunk/Source

IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
​https://bugs.webkit.org/show_bug.cgi?id=106605

Source/WebCore:

Remove all uses of IDBObjectStoreBackendInterface and IDBIndexBackend*,
as they are no longer used after recent refactoring.

Reviewed by Darin Fisher.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBCallbacks.h:

(WebCore):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore):
(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBIndex.cpp:
  • Modules/indexeddb/IDBIndexBackendInterface.h: Removed.
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):

  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::makeIndexWriters):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::IndexWriter::IndexWriter):
(IndexWriter):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h: Removed.
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBTransactionCoordinator.cpp:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
as they no longer exist in WebCore.

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h:

(WebKit):

  • public/WebIDBDatabase.h:

(WebKit):
(WebKit::WebIDBDatabase::metadata):

  • public/WebIDBFactory.h:

(WebIDBFactory):

  • public/WebIDBIndex.h: Removed.
  • public/WebIDBObjectStore.h: Removed.
  • public/WebIDBTransaction.h:
  • src/IDBCallbacksProxy.cpp:
  • src/IDBDatabaseBackendProxy.cpp:
  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/IDBIndexBackendProxy.cpp: Removed.
  • src/IDBIndexBackendProxy.h: Removed.
  • src/IDBObjectStoreBackendProxy.cpp: Removed.
  • src/IDBObjectStoreBackendProxy.h: Removed.
  • src/IDBTransactionBackendProxy.cpp:
  • src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::put):
(WebKit::WebIDBDatabaseImpl::setIndexKeys):

  • src/WebIDBDatabaseImpl.h:

(WebKit):
(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • src/WebIDBIndexImpl.cpp: Removed.
  • src/WebIDBIndexImpl.h: Removed.
  • src/WebIDBObjectStoreImpl.cpp: Removed.
  • src/WebIDBObjectStoreImpl.h: Removed.
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::TEST):

  • tests/IDBDatabaseBackendTest.cpp:
2:34 PM Changeset in webkit [139665] by mvujovic@adobe.com
  • 52 edits
    33 adds
    74 deletes in trunk/Source

[ANGLE] Update ANGLE in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106274

Reviewed by Dean Jackson.

Update ANGLE to r1641.

Source/ThirdParty/ANGLE:

ANGLE parsers were generated with Bison 2.3.

Additionally, perform the following changes to WebKit's ANGLE build system. Note that these
changes only apply to WebKit's copy of ANGLE, and do not need to be upstreamed to ANGLE.
(a) Remove all files in the libEGL and libGLESv2 directories because nobody is using them.

Add a README in each directory to explain why their contents are not copied over from
ANGLE. This simplifies updating ANGLE in the future.

(b) Remove the build_angle.xcodeproj file that no-one is using. It appears it was copied

over from a gyp build of ANGLE. The Mac build uses ANGLE.xcodeproj.

(c) Remove duplicate file entries in ANGLE.xcodeproj. Change its Xcode group structure to

match ANGLE's directory structure.

(d) Add a Copy Files task to ANGLE.xcodeproj to put the khrplatform.h header in the right

place so ShaderLang.h can find it. ShaderLang.h is copied to
<BuildDir>/usr/local/include/ANGLE/ShaderLang.h during the Copy Headers task, and it
includes "KHR/khrplatform.h". Thus, we need to copy khrplatform.h to
<BuildDir>/usr/local/include/ANGLE/KHR/khrplatform.h.

Additionally, make one build fix in ANGLE source that should be upstreamed to ANGLE:
(1) Before this patch in ExpressionParser.y, we toggled the "-Wpragmas" flag so compilers

could ignore the pragmas that they didn't understand instead of generating an error.
However, clang does not understand "-Wpragmas" itself. Instead, tt understands
"-Wunknown-pragmas". Now, instead of trying to temporarily ignore pragmas, we apply the
right flags to the right compiler versions. The new code in ExpressionParser.y looks
like:

"""
Turn off uninitialized variable warnings triggered by the auto-generated pplval variable.
 On gcc 4.7+, The flag is called "-Wmaybe-uninitialized".
On clang and gcc < 4.7, the flag is called "-Wuninitialized".

#if !defined(clang) && ((GNUC == 4 && GNU_C_MINOR >= 7)
GNUC >= 5)

#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#else
#pragma GCC diagnostic ignored "-Wuninitialized"
#endif
"""

  • ANGLE.plist:
  • ANGLE.pri:
  • ANGLE.xcodeproj/project.pbxproj:
  • DerivedSources.pri:
  • Target.pri:
  • include/GLSLANG/ShaderLang.h:
  • src/build_angle.xcodeproj/project.pbxproj: Removed.
  • src/common/angleutils.h:
  • src/common/debug.cpp:

(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):

  • src/common/debug.h:
  • src/common/version.h:
  • src/compiler/Compiler.cpp:

(TCompiler::Init):
(TCompiler::compile):
(TCompiler::clearResults):
(TCompiler::collectAttribsUniforms):
(TCompiler::enforcePackingRestrictions):

  • src/compiler/Diagnostics.cpp:

(TDiagnostics::TDiagnostics):
(TDiagnostics::writeInfo):
(TDiagnostics::print):

  • src/compiler/Diagnostics.h:

(TDiagnostics::numErrors):
(TDiagnostics::numWarnings):
(TDiagnostics):

  • src/compiler/DirectiveHandler.h:
  • src/compiler/HashNames.h: Added.
  • src/compiler/Intermediate.cpp:

(TIntermTraverser::hash):

  • src/compiler/OutputESSL.cpp:

(TOutputESSL::TOutputESSL):

  • src/compiler/OutputESSL.h:

(TOutputESSL):

  • src/compiler/OutputGLSL.cpp:

(TOutputGLSL::TOutputGLSL):

  • src/compiler/OutputGLSL.h:

(TOutputGLSL):

  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::TOutputGLSLBase):
(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeFunctionParameters):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitSymbol):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::getTypeName):
(TOutputGLSLBase::hashName):
(TOutputGLSLBase::hashVariableName):
(TOutputGLSLBase::hashFunctionName):

  • src/compiler/OutputGLSLBase.h:

(TOutputGLSLBase):

  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):

  • src/compiler/OutputHLSL.h:

(OutputHLSL):

  • src/compiler/ParseHelper.cpp:

(TParseContext::error):
(TParseContext::nonInitConstErrorCheck):
(PaParseStrings):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):
(TParseContext):
(TParseContext::numErrors):

  • src/compiler/RenameFunction.h:

(RenameFunction::visitAggregate):

  • src/compiler/ShHandle.h:

(TCompiler::getHashFunction):
(TCompiler::getNameMap):
(TCompiler::getSymbolTable):
(TCompiler):

  • src/compiler/ShaderLang.cpp:

(ShInitBuiltInResources):
(ShGetInfo):
(ShGetNameHashingEntry):

  • src/compiler/SymbolTable.cpp:

(TType::TType):
(TType::isStructureContainingArrays):

  • src/compiler/SymbolTable.h:

(TSymbolTable::findBuiltIn):
(TSymbolTable):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/Types.h:

(TType):
(TPublicType):
(TPublicType::setBasic):
(TPublicType::setAggregate):
(TPublicType::setArray):
(TPublicType::isStructureContainingArrays):

  • src/compiler/UnfoldShortCircuit.cpp:

(sh::UnfoldShortCircuit::visitBinary):

  • src/compiler/VariableInfo.cpp:

(getVariableInfo):
(getUserDefinedVariableInfo):
(TVariableInfo::TVariableInfo):
(CollectAttribsUniforms::CollectAttribsUniforms):
(CollectAttribsUniforms::visitAggregate):

  • src/compiler/VariableInfo.h:

(TVariableInfo):
(CollectAttribsUniforms):

  • src/compiler/VariablePacker.cpp: Added.

(VariablePacker::GetNumComponentsPerRow):
(VariablePacker::GetNumRows):
(TVariableInfoComparer::operator()):
(VariablePacker::makeColumnFlags):
(VariablePacker::fillColumns):
(VariablePacker::searchColumn):
(VariablePacker::CheckVariablesWithinPackingLimits):

  • src/compiler/VariablePacker.h: Added.

(VariablePacker):

  • src/compiler/VersionGLSL.cpp:

(TVersionGLSL::visitAggregate):

  • src/compiler/VersionGLSL.h:

(TVersionGLSL):

  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(string_input):
(glslang_finalize):
(glslang_scan):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/intermediate.h:

(TIntermTraverser):

  • src/compiler/osinclude.h:

(OS_GetTLSValue):

  • src/compiler/ossource_nspr.cpp:
  • src/compiler/preprocessor/DiagnosticsBase.cpp: Added.

(pp):
(pp::Diagnostics::~Diagnostics):
(pp::Diagnostics::report):
(pp::Diagnostics::severity):
(pp::Diagnostics::message):

  • src/compiler/preprocessor/DiagnosticsBase.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Diagnostics.h.

(pp):
(Diagnostics):

  • src/compiler/preprocessor/DirectiveHandlerBase.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveHandlerBase.cpp.

(pp):
(pp::DirectiveHandler::~DirectiveHandler):

  • src/compiler/preprocessor/DirectiveHandlerBase.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveHandler.h.

(pp):
(DirectiveHandler):

  • src/compiler/preprocessor/DirectiveParser.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveParser.cpp.

(getDirective):
(isConditionalDirective):
(isEOD):
(skipUntilEOD):
(isMacroNameReserved):
(isMacroPredefined):
(pp):
(DefinedParser):
(pp::DefinedParser::DefinedParser):
(pp::DefinedParser::lex):
(pp::DirectiveParser::DirectiveParser):
(pp::DirectiveParser::lex):
(pp::DirectiveParser::parseDirective):
(pp::DirectiveParser::parseDefine):
(pp::DirectiveParser::parseUndef):
(pp::DirectiveParser::parseIf):
(pp::DirectiveParser::parseIfdef):
(pp::DirectiveParser::parseIfndef):
(pp::DirectiveParser::parseElse):
(pp::DirectiveParser::parseElif):
(pp::DirectiveParser::parseEndif):
(pp::DirectiveParser::parseError):
(pp::DirectiveParser::parsePragma):
(pp::DirectiveParser::parseExtension):
(pp::DirectiveParser::parseVersion):
(pp::DirectiveParser::parseLine):
(pp::DirectiveParser::skipping):
(pp::DirectiveParser::parseConditionalIf):
(pp::DirectiveParser::parseExpressionIf):
(pp::DirectiveParser::parseExpressionIfdef):

  • src/compiler/preprocessor/DirectiveParser.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveParser.h.

(pp):
(DirectiveParser):
(ConditionalBlock):
(pp::DirectiveParser::ConditionalBlock::ConditionalBlock):

  • src/compiler/preprocessor/ExpressionParser.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.cpp.

(yysyntax_error):
(yylex):
(yyerror):
(pp):
(pp::ExpressionParser::ExpressionParser):
(pp::ExpressionParser::parse):

  • src/compiler/preprocessor/ExpressionParser.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.h.

(pp):
(ExpressionParser):

  • src/compiler/preprocessor/ExpressionParser.y: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.y.
  • src/compiler/preprocessor/Input.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Input.cpp.

(pp):
(pp::Input::Input):
(pp::Input::read):

  • src/compiler/preprocessor/Input.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Input.h.

(pp):
(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):
(pp::Input::Location::Location):
(pp::Input::readLoc):

  • src/compiler/preprocessor/Lexer.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Lexer.cpp.

(pp):
(pp::Lexer::~Lexer):

  • src/compiler/preprocessor/Lexer.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Lexer.h.

(pp):
(Lexer):

  • src/compiler/preprocessor/Macro.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Macro.cpp.

(pp):
(pp::Macro::equals):

  • src/compiler/preprocessor/Macro.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Macro.h.

(pp):
(pp::Macro::Macro):
(Macro):

  • src/compiler/preprocessor/MacroExpander.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp.

(pp):
(TokenLexer):
(pp::TokenLexer::TokenLexer):
(pp::TokenLexer::lex):
(pp::MacroExpander::MacroExpander):
(pp::MacroExpander::~MacroExpander):
(pp::MacroExpander::lex):
(pp::MacroExpander::getToken):
(pp::MacroExpander::ungetToken):
(pp::MacroExpander::isNextTokenLeftParen):
(pp::MacroExpander::pushMacro):
(pp::MacroExpander::popMacro):
(pp::MacroExpander::expandMacro):
(pp::MacroExpander::collectMacroArgs):
(pp::MacroExpander::replaceMacroParams):

  • src/compiler/preprocessor/MacroExpander.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.h.

(pp):
(MacroExpander):
(MacroContext):
(pp::MacroExpander::MacroContext::MacroContext):
(pp::MacroExpander::MacroContext::empty):
(pp::MacroExpander::MacroContext::get):
(pp::MacroExpander::MacroContext::unget):

  • src/compiler/preprocessor/Preprocessor.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Preprocessor.cpp.

(pp):
(PreprocessorImpl):
(pp::PreprocessorImpl::PreprocessorImpl):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::predefineMacro):
(pp::Preprocessor::lex):

  • src/compiler/preprocessor/Preprocessor.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Preprocessor.h.

(pp):
(Preprocessor):

  • src/compiler/preprocessor/SourceLocation.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/SourceLocation.h.

(pp):
(pp::SourceLocation::SourceLocation):
(SourceLocation):
(pp::SourceLocation::equals):
(pp::operator==):
(pp::operator!=):

  • src/compiler/preprocessor/Token.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Token.cpp.

(pp):
(pp::Token::reset):
(pp::Token::equals):
(pp::Token::setAtStartOfLine):
(pp::Token::setHasLeadingSpace):
(pp::Token::setExpansionDisabled):
(pp::Token::iValue):
(pp::Token::uValue):
(pp::Token::fValue):
(pp::operator<<):

  • src/compiler/preprocessor/Token.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Token.h.

(pp):
(pp::Token::Token):
(Token):
(pp::Token::atStartOfLine):
(pp::Token::hasLeadingSpace):
(pp::Token::expansionDisabled):
(pp::operator==):
(pp::operator!=):

  • src/compiler/preprocessor/Tokenizer.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Tokenizer.cpp.

(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(pp):
(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::~Tokenizer):
(pp::Tokenizer::init):
(pp::Tokenizer::setFileNumber):
(pp::Tokenizer::setLineNumber):
(pp::Tokenizer::lex):
(pp::Tokenizer::initScanner):
(pp::Tokenizer::destroyScanner):

  • src/compiler/preprocessor/Tokenizer.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Tokenizer.h.

(pp):
(Tokenizer):
(Context):

  • src/compiler/preprocessor/Tokenizer.l: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Tokenizer.l.
  • src/compiler/preprocessor/atom.c: Removed.
  • src/compiler/preprocessor/atom.h: Removed.
  • src/compiler/preprocessor/compile.h: Removed.
  • src/compiler/preprocessor/cpp.c: Removed.
  • src/compiler/preprocessor/cpp.h: Removed.
  • src/compiler/preprocessor/cppstruct.c: Removed.
  • src/compiler/preprocessor/generate_parser.sh: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/generate_parser.sh.
  • src/compiler/preprocessor/memory.c: Removed.
  • src/compiler/preprocessor/memory.h: Removed.
  • src/compiler/preprocessor/new/DiagnosticsBase.cpp: Removed.
  • src/compiler/preprocessor/new/new_file.cpp: Removed.
  • src/compiler/preprocessor/new/new_file2.cpp: Removed.
  • src/compiler/preprocessor/new/preprocessor.vcproj: Removed.
  • src/compiler/preprocessor/numeric_lex.h: Added.

(pp):
(pp::numeric_base_int):
(pp::numeric_lex_int):
(pp::numeric_lex_float):

  • src/compiler/preprocessor/parser.h: Removed.
  • src/compiler/preprocessor/pp_utils.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/pp_utils.h.
  • src/compiler/preprocessor/preprocess.h: Removed.
  • src/compiler/preprocessor/scanner.c: Removed.
  • src/compiler/preprocessor/scanner.h: Removed.
  • src/compiler/preprocessor/slglobals.h: Removed.
  • src/compiler/preprocessor/symbols.c: Removed.
  • src/compiler/preprocessor/symbols.h: Removed.
  • src/compiler/preprocessor/tokens.c: Removed.
  • src/compiler/preprocessor/tokens.h: Removed.
  • src/libEGL/Config.cpp: Removed.
  • src/libEGL/Config.h: Removed.
  • src/libEGL/Display.cpp: Removed.
  • src/libEGL/Display.h: Removed.
  • src/libEGL/README: Added.
  • src/libEGL/Surface.cpp: Removed.
  • src/libEGL/Surface.h: Removed.
  • src/libEGL/libEGL.cpp: Removed.
  • src/libEGL/libEGL.def: Removed.
  • src/libEGL/libEGL.rc: Removed.
  • src/libEGL/libEGL.vcproj: Removed.
  • src/libEGL/main.cpp: Removed.
  • src/libEGL/main.h: Removed.
  • src/libEGL/resource.h: Removed.
  • src/libGLESv2/Blit.cpp: Removed.
  • src/libGLESv2/Blit.h: Removed.
  • src/libGLESv2/Buffer.cpp: Removed.
  • src/libGLESv2/Buffer.h: Removed.
  • src/libGLESv2/Context.cpp: Removed.
  • src/libGLESv2/Context.h: Removed.
  • src/libGLESv2/Fence.cpp: Removed.
  • src/libGLESv2/Fence.h: Removed.
  • src/libGLESv2/Framebuffer.cpp: Removed.
  • src/libGLESv2/Framebuffer.h: Removed.
  • src/libGLESv2/HandleAllocator.cpp: Removed.
  • src/libGLESv2/HandleAllocator.h: Removed.
  • src/libGLESv2/IndexDataManager.cpp: Removed.
  • src/libGLESv2/IndexDataManager.h: Removed.
  • src/libGLESv2/Program.cpp: Removed.
  • src/libGLESv2/Program.h: Removed.
  • src/libGLESv2/ProgramBinary.cpp: Removed.
  • src/libGLESv2/ProgramBinary.h: Removed.
  • src/libGLESv2/Query.cpp: Removed.
  • src/libGLESv2/Query.h: Removed.
  • src/libGLESv2/README: Added.
  • src/libGLESv2/Renderbuffer.cpp: Removed.
  • src/libGLESv2/Renderbuffer.h: Removed.
  • src/libGLESv2/ResourceManager.cpp: Removed.
  • src/libGLESv2/ResourceManager.h: Removed.
  • src/libGLESv2/Shader.cpp: Removed.
  • src/libGLESv2/Shader.h: Removed.
  • src/libGLESv2/Texture.cpp: Removed.
  • src/libGLESv2/Texture.h: Removed.
  • src/libGLESv2/VertexDataManager.cpp: Removed.
  • src/libGLESv2/VertexDataManager.h: Removed.
  • src/libGLESv2/libGLESv2.cpp: Removed.
  • src/libGLESv2/libGLESv2.def: Removed.
  • src/libGLESv2/libGLESv2.rc: Removed.
  • src/libGLESv2/libGLESv2.vcproj: Removed.
  • src/libGLESv2/main.cpp: Removed.
  • src/libGLESv2/main.h: Removed.
  • src/libGLESv2/mathutil.h: Removed.
  • src/libGLESv2/resource.h: Removed.
  • src/libGLESv2/utilities.cpp: Removed.
  • src/libGLESv2/utilities.h: Removed.
  • src/libGLESv2/vertexconversion.h: Removed.

Source/WebCore:

Update the files used in the EFL and GTK builds.

No new tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:

Source/WebKit:

  • PlatformEfl.cmake: Add ANGLE/include to the include directories list because ShaderLang.h

now includes "KHR/khrplatform.h", which is located in ANGLE/include/KHR/khrplatform.h.

Source/WebKit2:

  • PlatformEfl.cmake: Add ANGLE/include to the include directories list because ShaderLang.h

now includes "KHR/khrplatform.h", which is located in ANGLE/include/KHR/khrplatform.h.

2:23 PM Changeset in webkit [139664] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
​https://bugs.webkit.org/show_bug.cgi?id=105861

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/overhanging-float-detach-repaint.html

The issue comes from overhanging float not contributing to their containing block's
overflow. This meant that repaint() would ignore them leading to an under-repaint.
The fix is simple: force all the overhanging floats to repaint themselves.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

  • fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
  • fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
  • fast/repaint/overhanging-float-detach-repaint.html: Added.
2:21 PM Changeset in webkit [139663] by dmazzoni@google.com
  • 14 edits
    3 adds in trunk

AX: Need to implement ColorWellRole
​https://bugs.webkit.org/show_bug.cgi?id=106756

Reviewed by Chris Fleizach.

Source/WebCore:

Maps input type=color to the accessible role ColorWellRole.
Adds a new accessor to AccessibilityObject to get the color
value in a cross-platform way that doesn't require parsing.

Test: accessibility/color-well.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isColorWell):
(AccessibilityObject):
(WebCore::AccessibilityObject::colorValue):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLInputElement.cpp:

(WebCore):
(WebCore::HTMLInputElement::isColorControl):

  • html/HTMLInputElement.h:

(HTMLInputElement):

Source/WebKit/chromium:

Adds an accessibility interface to access the value of a
color control.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::colorValue):
(WebKit):

Tools:

Returns a string representation of the value of a color
when the role is Color Well, to make it easy to write layout
tests for color controls.

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Adds a test of accessibility attributes for input type=color.

  • accessibility/color-well.html: Added.
  • platform/chromium/accessibility/color-well-expected.txt: Added.
  • platform/mac/accessibility/color-well-expected.txt: Added.
2:14 PM Changeset in webkit [139662] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139345
BUG=169006
Review URL: ​https://codereview.chromium.org/11884035

2:11 PM Changeset in webkit [139661] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139457
BUG=168969
Review URL: ​https://codereview.chromium.org/11879026

1:45 PM Changeset in webkit [139660] by schenney@chromium.org
  • 5 edits
    6 adds
    7 deletes in trunk/LayoutTests

Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Unreviewed expectations clean-up.

These files apparently need new baselines after the dashing optimization was removed.
It's a little odd, so maybe the expectations for that bug were hiding these failures.
Finally, hindi-spacing may be a flakey test.

  • platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-image-01-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-longhand-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-repeat-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-slices-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-source-expected.png: Added.
  • platform/chromium-linux/fast/css/continuationCrash-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-01-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-longhand-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-repeat-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-slices-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-source-expected.png: Removed.
1:40 PM Changeset in webkit [139659] by eae@chromium.org
  • 5 edits
    2 adds in trunk

offsetWidth/height incorrect for images when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=106624

Source/WebCore:

Reviewed by Levi Weintraub.

offsetWidth and height are incorrect for images at certain zoom
levels due to flooring the values ones adjusted for zoom.
By rounding the value instead we avoid the problem and return
the right size.

Test: fast/images/zoomed-offset-size.html

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
Change to round (as opposed to floor) the zoom adjusted value.

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):
Add LayoutUnit version of adjustForAbsoluteZoom to avoid float
conversion.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for offsetWidth/Height for zoomed image.

  • fast/images/zoomed-offset-size-expected.txt: Added.
  • fast/images/zoomed-offset-size.html: Added.
1:38 PM Changeset in webkit [139658] by dmazzoni@google.com
  • 4 edits in trunk

Chromium: Error in AccessibilityUIElement::intValueGetterCallback
​https://bugs.webkit.org/show_bug.cgi?id=106682

Reviewed by Chris Fleizach.

Tools:

Modify Chromium's DRT implementation of intValue to return a
different value depending on the role.

There are actually platform-specific differences in what should
be returned in the "value" of an object, so Chromium normally keeps
these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
but this is a fine simplification to make cross-platform tests easier.

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::intValueGetterCallback):

LayoutTests:

Unskip accessibility/heading-level.html now that the bug is fixed.

  • platform/chromium/TestExpectations:
1:37 PM Changeset in webkit [139657] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139100
BUG=167780
Review URL: ​https://codereview.chromium.org/11879024

1:31 PM Changeset in webkit [139656] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139444
BUG=161240
Review URL: ​https://codereview.chromium.org/11886026

1:31 PM Changeset in webkit [139655] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

NetworkProcess scheduler never resumes resource loads that were postponed
due to connection limit
​https://bugs.webkit.org/show_bug.cgi?id=106821

Reviewed by Brady Eidson.

  • NetworkProcess/NetworkResourceLoadScheduler.cpp: (WebKit::NetworkResourceLoadScheduler::servePendingRequests):
  • NetworkProcess/NetworkResourceLoadScheduler.h: Remove an uninitialized variable that could prevent loading.
1:31 PM Changeset in webkit [139654] by schenney@chromium.org
  • 391 edits
    2 deletes in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

SVG failures of W3C tests. This should be the last.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
1:22 PM Changeset in webkit [139653] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138988
BUG=138988
Review URL: ​https://codereview.chromium.org/11876028

1:21 PM Changeset in webkit [139652] by pilgrim@chromium.org
  • 4 edits
    2 moves in trunk/Source

[Chromium] Move AudioDestinationChromium into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106803

Reviewed by Adam Barth.

This doesn't really belong in WebKit/chromium/src since it defines
things directly in the WebCore namespace.

Source/WebCore:

  • WebCore.gypi:
  • platform/audio/chromium/AudioDestinationChromium.cpp: Added.

(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationChromium::render):
(WebCore::AudioDestinationChromium::provideInput):

  • platform/audio/chromium/AudioDestinationChromium.h: Added.

(WebCore):
(AudioDestinationChromium):
(WebCore::AudioDestinationChromium::isPlaying):
(WebCore::AudioDestinationChromium::sampleRate):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/AudioDestinationChromium.cpp: Removed.
  • src/AudioDestinationChromium.h: Removed.
1:16 PM Changeset in webkit [139651] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h

Merge 139213
BUG=156096
Review URL: ​https://codereview.chromium.org/11886025

1:14 PM Changeset in webkit [139650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix indentation for GStreamer supported MIME types list
​https://bugs.webkit.org/show_bug.cgi?id=106812

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-01-14
Reviewed by Philippe Normand.

No tests. No change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1:11 PM Changeset in webkit [139649] by schenney@chromium.org
  • 301 edits
    12 adds
    9 deletes in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

SVG failures all but W3C tests.

  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Removed.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/batik/text/textStyles-expected.png:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-linux/svg/custom/circular-marker-reference-2-expected.png:
  • platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-linux/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-linux/svg/custom/fill-fallback-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-linux/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/invalid-css-expected.png:
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-linux/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-linux/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-linux/svg/custom/non-scaling-stroke-expected.png: Added.
  • platform/chromium-linux/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/chromium-linux/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-linux/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.png:
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-linux/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-linux/svg/custom/use-detach-expected.png:
  • platform/chromium-linux/svg/custom/use-on-text-expected.png:
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-lion/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-lion/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac-lion/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-lion/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-lion/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac-lion/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-mac-lion/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-mac-lion/svg/custom/fill-fallback-expected.png:
  • platform/chromium-mac-lion/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-lion/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-mac-lion/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-mac-lion/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-lion/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-lion/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac-lion/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac-lion/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac-lion/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-mac-lion/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-mac-lion/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac-lion/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-mac-lion/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac-lion/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-mac-lion/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac-lion/svg/custom/use-detach-expected.png:
  • platform/chromium-mac-lion/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/fill-fallback-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac/svg/as-background-image/background-image-tiled-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png:
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/chromium-mac/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-mac/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-mac/svg/custom/deep-dynamic-updates-expected.png:
  • platform/chromium-mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-mac/svg/custom/fill-fallback-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/gradient-add-stops-expected.png:
  • platform/chromium-mac/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-mac/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stop-style-change-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-mac/svg/custom/js-update-gradient-expected.png:
  • platform/chromium-mac/svg/custom/js-update-stop-expected.png:
  • platform/chromium-mac/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac/svg/custom/large-bounding-box-percents-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-mac/svg/custom/radialGradient-focal-radius-expected.png:
  • platform/chromium-mac/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-mac/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac/svg/custom/resource-client-removal-expected.png:
  • platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-mac/svg/custom/stroke-opacity-update-expected.png:
  • platform/chromium-mac/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/uri-reference-handling-expected.png: Added.
  • platform/chromium-mac/svg/custom/use-detach-expected.png:
  • platform/chromium-mac/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-mac/svg/custom/xlink-custom-namespace-expected.png: Added.
  • platform/chromium-win-xp/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win-xp/svg/custom/image-small-width-height-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/carto.net/combobox-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-win/svg/custom/circular-marker-reference-2-expected.png:
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-win/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-win/svg/custom/deep-dynamic-updates-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-win/svg/custom/fill-fallback-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/gradient-add-stops-expected.png: Added.
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-win/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-win/svg/custom/gradient-stop-style-change-expected.png: Added.
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/chromium-win/svg/custom/group-opacity-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/invalid-css-expected.png:
  • platform/chromium-win/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-win/svg/custom/js-update-gradient-expected.png:
  • platform/chromium-win/svg/custom/js-update-stop-expected.png:
  • platform/chromium-win/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-win/svg/custom/large-bounding-box-percents-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/radialGradient-focal-radius-expected.png:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-win/svg/custom/resource-client-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-win/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-win/svg/custom/stroke-opacity-update-expected.png:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium-win/svg/custom/uri-reference-handling-expected.png: Added.
  • platform/chromium-win/svg/custom/use-detach-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-win/svg/custom/xlink-custom-namespace-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/svg/custom/gradient-add-stops-expected.png: Removed.
  • platform/chromium/svg/custom/gradient-stop-style-change-expected.png: Removed.
  • platform/chromium/svg/custom/resource-client-removal-expected.png: Removed.
  • platform/chromium/svg/custom/uri-reference-handling-expected.png: Removed.
  • platform/chromium/svg/custom/xlink-custom-namespace-expected.png: Removed.
  • platform/efl/svg/custom/gradient-deep-referencing-expected.png: Removed.
  • platform/gtk/svg/custom/gradient-deep-referencing-expected.png: Removed.
  • svg/custom/gradient-deep-referencing-expected.png: Added.
1:11 PM Changeset in webkit [139648] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/page/FrameView.cpp

Merge 139365
BUG=153184
Review URL: ​https://codereview.chromium.org/11885028

1:08 PM Changeset in webkit [139647] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebCore/page/FrameView.cpp

Merge 139365
BUG=153184
Review URL: ​https://codereview.chromium.org/11889016

1:04 PM Changeset in webkit [139646] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/dom/Document.cpp

Merge 139470
BUG=146145
Review URL: ​https://codereview.chromium.org/11891002

1:03 PM Changeset in webkit [139645] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebCore/dom/Document.cpp

Merge 139470
BUG=146145
Review URL: ​https://codereview.chromium.org/11889015

12:49 PM Changeset in webkit [139644] by schenney@chromium.org
  • 286 edits
    1 add
    3 deletes in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

SVG failures in directories after dynamic-updates now fixed.

  • platform/chromium-linux-x86/svg/dynamic-updates: Removed.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png:
  • platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-linux/svg/hixie/error/017-expected.png:
  • platform/chromium-linux/svg/hixie/perf/005-expected.png:
  • platform/chromium-linux/svg/hixie/perf/006-expected.png:
  • platform/chromium-linux/svg/text/selection-background-color-expected.png:
  • platform/chromium-linux/svg/text/selection-styles-expected.png:
  • platform/chromium-linux/svg/text/small-fonts-3-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-mac-lion/svg/hixie/error/017-expected.png:
  • platform/chromium-mac-lion/svg/hixie/perf/005-expected.png:
  • platform/chromium-mac-lion/svg/hixie/perf/006-expected.png:
  • platform/chromium-mac-lion/svg/hixie/perf/007-expected.png:
  • platform/chromium-mac-lion/svg/text/selection-background-color-expected.png:
  • platform/chromium-mac-lion/svg/text/selection-styles-expected.png:
  • platform/chromium-mac-lion/svg/text/small-fonts-3-expected.png:
  • platform/chromium-mac-lion/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-lion/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac-lion/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-lion/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-lion/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-mac/svg/filters/feTile-expected.png:
  • platform/chromium-mac/svg/hixie/error/017-expected.png:
  • platform/chromium-mac/svg/hixie/perf/005-expected.png:
  • platform/chromium-mac/svg/hixie/perf/006-expected.png:
  • platform/chromium-mac/svg/hixie/perf/007-expected.png:
  • platform/chromium-mac/svg/repaint/inner-svg-change-viewBox-expected.png:
  • platform/chromium-mac/svg/text/selection-background-color-expected.png:
  • platform/chromium-mac/svg/text/selection-styles-expected.png:
  • platform/chromium-mac/svg/text/small-fonts-3-expected.png:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-image-tiled-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-expected.png:
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/hixie/error/017-expected.png:
  • platform/chromium-win/svg/hixie/perf/005-expected.png:
  • platform/chromium-win/svg/hixie/perf/006-expected.png:
  • platform/chromium-win/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium-win/svg/text/small-fonts-3-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-win/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/svg/repaint/inner-svg-change-viewBox-expected.png: Removed.
12:42 PM Changeset in webkit [139643] by commit-queue@webkit.org
  • 2 edits in trunk

Do not hardcode -ldl in OPENGL_LIBS
​https://bugs.webkit.org/show_bug.cgi?id=96602

Patch by Alexandre Rostovtsev <​tetromino@gentoo.org> on 2013-01-14
Reviewed by Philippe Normand.

Some non-Linux systems, e.g. FreeBSD, have dlopen() as part of their
libc, and do not use a separate libdl.

  • configure.ac:
12:35 PM Changeset in webkit [139642] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use correct size for DrawingBuffer readback
​https://bugs.webkit.org/show_bug.cgi?id=106744

Patch by John Bauman <​jbauman@chromium.org> on 2013-01-14
Reviewed by Kenneth Russell.

The value getInternalFramebufferSize is bogus if there's a
DrawingBuffer, so use size() instead.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

12:25 PM Changeset in webkit [139641] by jsbell@chromium.org
  • 11 edits in trunk/Source/WebCore

Bindings: Remove special cases for DOMString[]
​https://bugs.webkit.org/show_bug.cgi?id=106506

Remove special in binding code generators that map DOMString[] to DOMStringList.
Array (T[]) and sequence (sequence<T>) are supported enough now that to be used
for Internals, which is the only IDL that needed updating.

Reviewed by Adam Barth.

Tests: fast/forms/file/selected-files-from-history-state.html

fast/forms/state-restore-broken-state.html
fast/forms/state-restore-skip-stateless.html

Bindings test results updated for JS/V8.

  • bindings/scripts/CodeGenerator.pm: Remove redundant IsArrayType (use GetArrayType instead)

(IsRefPtrType): Array and Sequence types are not RefPtr types.

  • bindings/scripts/CodeGeneratorJS.pm:

(IndexGetterReturnsStrings): Remove special case for DOMString[].
(AddIncludesForType): Skip Array types, just like Sequence types. (Should probably recurse
for the base type, but not needed for now.)
(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
(GetNativeType): Remove special case for DOMString[].
(GetNativeTypeForCallbacks): Ditto.
(JSValueToNative): Ditto.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
(GetNativeType): Remove special case for DOMString[].
(JSValueToNative): Ditto.
(GetV8HeaderName): Ditto.
(IsWrapperType):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/TestObj.idl: Added explicit new cases for DOMStringList
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • testing/Internals.cpp:

(WebCore::Internals::formControlStateOfPreviousHistoryItem):
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
(WebCore::Internals::iconURLs):
(WebCore::Internals::getReferencedFilePaths):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl: Produce DOMString[], consume sequence<DOMString> to match tests.
12:23 PM Changeset in webkit [139640] by kbr@google.com
  • 3 edits in branches/chromium/1364

Merge 139459

[Chromium] WebGL typed array constructor crashes on exception
​https://bugs.webkit.org/show_bug.cgi?id=106308

Reviewed by Kentaro Hara.

Source/WebCore:

Check for empty handles (indicating exception thrown) after calls
into V8 VM.

Added new case from Khronos typed array conformance tests to
fast/canvas/webgl/array-unit-tests.html.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

Check for empty handles after calls into V8 VM.

LayoutTests:

Updated typed array tests to latest version from Khronos repository.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

TBR=​kbr@google.com
Review URL: ​https://codereview.chromium.org/11889014

12:17 PM Changeset in webkit [139639] by esprehn@chromium.org
  • 9 edits in trunk/Source/WebCore

Clean up WebVTTNodeType code
​https://bugs.webkit.org/show_bug.cgi?id=106714

Reviewed by Tony Chang.

There's no reason for so many methods just to compare some enums.
The existing code can also be simplified quite a bit.

No new tests, just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):

  • dom/Element.cpp:

(WebCore::Element::webVTTNodeType):
(WebCore::Element::setWebVTTNodeType):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::setWebVTTNodeType):
(WebCore::ElementRareData::webVTTNodeType):
(ElementRareData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

  • html/track/TextTrack.h:
  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes):

12:16 PM Changeset in webkit [139638] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r139218): Flaky assertion in WebCore::StorageTask::StorageTask releasing memory
​https://bugs.webkit.org/show_bug.cgi?id=106718

Reviewed by Andreas Kling.

Type assertion was missing a new type.

  • storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):

11:55 AM Changeset in webkit [139637] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
in Chromium test expectations. Tony fixed the issue in r139636.

  • platform/chromium/TestExpectations:
11:53 AM Changeset in webkit [139636] by tony@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
​https://bugs.webkit.org/show_bug.cgi?id=106806

Reviewed by Levi Weintraub.

This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
functions in js-test-pre.js for waitUntilDone/notifyDone.

  • editing/spelling/spellcheck-sequencenum-expected.txt:
  • editing/spelling/spellcheck-sequencenum.html:
  • platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
11:45 AM Changeset in webkit [139635] by simonjam@chromium.org
  • 5 edits
    3 copies in branches/chromium/1364

Merge 139509

Restore old semantics to webkitRequestAnimationFrame callbacks
​https://bugs.webkit.org/show_bug.cgi?id=106697

Reviewed by James Robinson.

Source/WebCore:

Sites that use GWT <= 2.4 are buggy and rely on Date.now()-like callback values.
We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
requestAnimationFrame will continue to follow the spec.

Test: fast/animation/request-animation-frame-prefix.html

  • dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::requestAnimationFrame):
(WebCore):
(WebCore::DOMWindow::webkitRequestAnimationFrame):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/animation/request-animation-frame-prefix-expected.txt: Added.
  • fast/animation/request-animation-frame-prefix.html: Added.
  • fast/animation/script-tests/request-animation-frame-prefix.js: Added.

(busyWait):
(window.webkitRequestAnimationFrame):

TBR=​simonjam@chromium.org
Review URL: ​https://codereview.chromium.org/11876026

11:43 AM Changeset in webkit [139634] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
​https://bugs.webkit.org/show_bug.cgi?id=106807

Reviewed by Pavel Feldman.

Open dedicated worker inspector 600x600 by default and remember its size
after resizing.

  • inspector/front-end/Settings.js:
  • inspector/front-end/WorkerManager.js:
11:24 AM Changeset in webkit [139633] by wangxianzhu@chromium.org
  • 3 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 139028

[Chromium] Expose compositedScrollingForFramesEnabled setting in WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=106262

Reviewed by James Robinson.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setCompositedScrollingForFramesEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/11882024

11:23 AM Changeset in webkit [139632] by wangxianzhu@chromium.org
  • 5 edits
    2 copies in branches/chromium/1364

Merge 139024

Add a setting to enable composited scrolling for frames
​https://bugs.webkit.org/show_bug.cgi?id=104950

Reviewed by James Robinson.

Source/WebCore:

Test: compositing/iframes/iframe-composited-scrolling.html

  • page/FrameView.cpp:

(WebCore::FrameView::usesCompositedScrolling): Returns true if compositedScrollingForFramesEnabled and the frame is in forced compositing mode (which is set when forced compositing mode and compositing for scrollable frames are enabled), so that ScrollingCoordinator won't include the region of the frame in the nonFastScrollableRegion.
(WebCore):

  • page/FrameView.h:

(FrameView):

  • page/Settings.in: Add compositedScrollingForFramesEnabled setting.
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated): Changed the comment about which ScrollableAreas are non-fast-scrollable.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll): Let ScrollongCoordinator know when the scrolling changes for a frame with composited scrolling enabled.

LayoutTests:

Test case to ensure iframes are not added into nonFastScrollableRegion when acceleratedCompositingForScrollableFramesEnabled and compositedScrollingForFramesEnabled.

  • compositing/iframes/iframe-composited-scrolling-expected.txt: Added.
  • compositing/iframes/iframe-composited-scrolling.html: Added.

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/11880030

11:21 AM Changeset in webkit [139631] by wangxianzhu@chromium.org
  • 9 edits in branches/chromium/1364/Source

Merge 138991

Add window.internals.nonFastScrollableRects for testing scrollable areas in fast/slow paths
​https://bugs.webkit.org/show_bug.cgi?id=105546

Reviewed by James Robinson.

.:

Export the new symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

No new tests. Added test API for new tests of other bugs.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):
(WebCore):

  • page/Page.h:

(WebCore):
(Page):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Change to public to allow Page::nonFastScrollableRects to access.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects):
(WebCore):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Export the new symbol.

  • win/WebKit2.def.in:

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/11875020

11:11 AM Changeset in webkit [139630] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

11:09 AM Changeset in webkit [139629] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Zoom is still possible when user-scalable=no
​https://bugs.webkit.org/show_bug.cgi?id=106809

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by George Staikos.

PR: 274566
On wordpress.com, the contents were rendered at the width 343 which was
1 css pixel larger than the expected device-width 342 so that we didn't
respect the viewport.
There was a RenderBlock on the page which contained "\n" and an
inline-block. "\n" took 0.78 width and the inline-block took 342 width
and they were unfortunately placed in the same InlineBox which caused
the contents width 1 css pixels larger than the device-width.
Allow the contents width to be 1 css pixel larger and still respect the
viewport in such a special case.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::respectViewport):

11:04 AM Changeset in webkit [139628] by Lucas Forschler
  • 1 copy in tags/Safari-537.26

New Tag.

11:04 AM Changeset in webkit [139627] by jochen@chromium.org
  • 10 edits in trunk/Tools

[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106785

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):
(WebTestRunner::WebTestProxy::setStatusText):
(WebTestRunner::WebTestProxy::didStopLoading):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::TestRunner::dumpWindowStatusChanges):
(WebTestRunner::TestRunner::dumpProgressFinishedCallback):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didStopLoading):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didStopLoading):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:57 AM Changeset in webkit [139626] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
as flaky on Chromium Debug bots.

  • platform/chromium/TestExpectations:
10:51 AM Changeset in webkit [139625] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html
​https://bugs.webkit.org/show_bug.cgi?id=106805

Patch by Michael Pruett <​michael@68k.org> on 2013-01-14
Reviewed by Tony Chang.

V8 prepends "Uncaught " to uncaught exceptions, while JSC does not.
Either form of the error message should be acceptable.

  • storage/indexeddb/transaction-complete-workers.html:
10:28 AM Changeset in webkit [139624] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
as flaky on Chromium Win Debug bots.

  • platform/chromium/TestExpectations:
10:08 AM Changeset in webkit [139623] by schenney@chromium.org
  • 4 edits in trunk

Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Source/WebKit/chromium:

Unreviewed build fix.

It turns out that the change behind this flag causes crashes and image errors.

  • skia_webkit.gyp:

LayoutTests:

Unreviewed expectations clean-up.

Removing the expectations associated with the flag.

  • platform/chromium/TestExpectations:
9:43 AM Changeset in webkit [139622] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()
​https://bugs.webkit.org/show_bug.cgi?id=106784

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

9:40 AM Changeset in webkit [139621] by haraken@chromium.org
  • 4 edits in trunk/Source

[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
​https://bugs.webkit.org/show_bug.cgi?id=106779

Reviewed by Adam Barth.

This is one of steps to make an Isolate parameter mandatory.

No tests. No change in behavior.

Source/WebCore:

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::interruptAndDispatch):

9:40 AM Changeset in webkit [139620] by leviw@chromium.org
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139479

RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
​https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

  • fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
  • fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/11880024

9:30 AM Changeset in webkit [139619] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in wrap()
​https://bugs.webkit.org/show_bug.cgi?id=106783

Reviewed by Adam Barth.

Now it's safe to make an Isolate parameter in wrap().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::wrap):

9:28 AM Changeset in webkit [139618] by tommyw@google.com
  • 8 edits in trunk

MediaStream API: Update MediaStreamTrack::readyState to match specification
​https://bugs.webkit.org/show_bug.cgi?id=106781

Reviewed by Adam Barth.

Source/WebCore:

MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.

Existing tests expanded to cover patch.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):

  • Modules/mediastream/MediaStreamTrack.h:

(MediaStreamTrack):

  • Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
9:25 AM Changeset in webkit [139617] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

Web Inspector: add text editor formatter test
​https://bugs.webkit.org/show_bug.cgi?id=106705

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Adds a test checking text editor formatting.
The test creates a new text editor and fills it in with some
code by the means of simulated key and textInput events.

  • inspector/editor/text-editor-formatter-expected.txt: Added.
  • inspector/editor/text-editor-formatter.html: Added.
8:46 AM Changeset in webkit [139616] by vsevik@chromium.org
  • 4 edits
    1 move
    4 adds in trunk

Web Inspector: Audit Tool's False Positive on Set-Cookie header
​https://bugs.webkit.org/show_bug.cgi?id=106794

Reviewed by Pavel Feldman.

Source/WebCore:

Header value is now returned as undefined if there is no such header as it was before regression.

Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype._headerValue):

LayoutTests:

  • http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
  • http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
  • http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
8:33 AM Changeset in webkit [139615] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Do not pass nil when initializing legible output
​https://bugs.webkit.org/show_bug.cgi?id=106799

Reviewed by Jessie Berlin.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]

wants an empty NSArray rather than nil.

7:37 AM Changeset in webkit [139614] by aandrey@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [Canvas] UI: add control buttons for doing the replay steps
​https://bugs.webkit.org/show_bug.cgi?id=106788

Reviewed by Pavel Feldman.

Adding UI control buttons for doing the Canvas replay steps.
Drive-by: fixed a bug in DataGrid (found by the JSCompiler).

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._createControlButton):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayFirstStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):

  • inspector/front-end/DOMExtension.js:

(Element.prototype.enableStyleClass):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGridNode):

  • inspector/front-end/canvasProfiler.css:

(.canvas-replay-image):
(.canvas-replay-image.wait):
(.canvas-replay-controls):
(.canvas-replay-log):
(.canvas-control-button):
(.canvas-control-button:active):
(.canvas-control-button:disabled):
(.canvas-control-button img):
(.canvas-replay-first-step img):
(.canvas-replay-next-step img):
(.canvas-replay-prev-step img):
(.canvas-replay-last-step img):

7:24 AM Changeset in webkit [139613] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Web Inspector: devtools front-end doesn't have focus in TestShell
​https://bugs.webkit.org/show_bug.cgi?id=106778

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Focus devTools window after loadURL method.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

6:11 AM EFLWebKit/SubpixelRebaseline edited by dominik.rottsches@intel.com
pixel tests (diff)
6:11 AM EFLWebKit edited by thiago.santos@intel.com
(diff)
6:06 AM EFLWebKit/SubpixelRebaseline created by dominik.rottsches@intel.com
Subpixel Rebaseline initial proposal
5:52 AM Changeset in webkit [139612] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
​https://bugs.webkit.org/show_bug.cgi?id=106573

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-01-14
Reviewed by Philippe Normand.

Similarly to what's been described in bug 106569, we're building
from release tarballs, so there's no reason to regenerate the
autoconf-related stuff with autogen.sh, especially since we might
run into trouble with automake 1.13 and deprecated macros.

  • efl/jhbuild.modules:
5:31 AM Changeset in webkit [139611] by tommyw@google.com
  • 22 edits
    3 deletes in trunk

MediaStream API: Update the track accessors on MediaStream to match the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=106660

Reviewed by Adam Barth.

Source/WebCore:

The spec has significantly changed how tracks are accessed from a MediaStream:
​http://dev.w3.org/2011/webrtc/editor/getusermedia.html

In short: the attributes audioTrack/videoTrack that returned special MediaStreamTrackLists have been
replaced by the functions getAudioTracks()/getVideoTracks that return standard sequences of
MediaStreamTracks.

Existing tests updated and expanded to cover patch.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::readyState):
(WebCore):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::scheduleDispatchEvent):
(WebCore::MediaStream::scheduledEventTimerFired):

  • Modules/mediastream/MediaStream.h:

(MediaStream):
(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrackList.cpp: Removed.
  • Modules/mediastream/MediaStreamTrackList.h: Removed.
  • Modules/mediastream/MediaStreamTrackList.idl: Removed.
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

  • WebCore.gypi:
  • dom/EventTargetFactory.in:
  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::addAudioComponent):
(WebCore::MediaStreamDescriptor::removeAudioComponent):
(WebCore::MediaStreamDescriptor::addVideoComponent):
(WebCore::MediaStreamDescriptor::removeVideoComponent):

LayoutTests:

Updating and expanding tests for the new getAudioTracks()/getVideoTracks().

  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
  • fast/mediastream/MediaStreamTrack.html:
  • fast/mediastream/MediaStreamTrackList-expected.txt:
  • fast/mediastream/MediaStreamTrackList.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
  • webaudio/mediastreamaudiosourcenode-expected.txt:
  • webaudio/mediastreamaudiosourcenode.html:
5:08 AM Changeset in webkit [139610] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[V8] Add m_isolate to ScriptController, WorkerScriptController and V8DOMWindowShell
​https://bugs.webkit.org/show_bug.cgi?id=106771

Reviewed by Adam Barth.

This is one of the steps to pass an Isolate everywhere.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::windowShell):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::create):
(WebCore::V8DOMWindowShell::V8DOMWindowShell):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/V8Initializer.cpp:

(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::V8Initializer::initializeWorker):

  • bindings/v8/V8Initializer.h:

(V8Initializer):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::initializeContextIfNeeded):

5:01 AM Changeset in webkit [139609] by jocelyn.turcotte@digia.com
  • 2 edits
    4 deletes in trunk/Tools

[Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
​https://bugs.webkit.org/show_bug.cgi?id=104909

Reviewed by Simon Hausmann.

To be able to build redistribuable binary packages, Qt's configure switches
-qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
dynamically link to optional system libraries.
QtWebKit is doing its own configure checks for those libraries, thus adding a
runtime dependency that might not be fulfilled if the packager's machine had
those libraries while the user's machine won't.

Since in most cases where WebKit will want to use those system libraries, Qt will
also be using them, remove these configure tests from WebKit.

  • qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
  • qmake/config.tests/libjpeg/libjpeg.pro: Removed.
  • qmake/config.tests/libpng/libpng.cpp: Removed.
  • qmake/config.tests/libpng/libpng.pro: Removed.
  • qmake/mkspecs/features/features.prf:
4:54 AM Changeset in webkit [139608] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
​https://bugs.webkit.org/show_bug.cgi?id=106574

Reviewed by Laszlo Gombos.

Rely on a more recent stable release, which includes support for
Lua 5.2 in Edje and other assorted minor fixes.

While here, also use the "configure" script to build the libraries
instead of relying on autogen.sh, which is not really needed with
a release tarball and may have problems with automake 1.13.

  • efl/jhbuild.modules:
4:36 AM Changeset in webkit [139607] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Styles] Color names parsed inside "background-image" values
​https://bugs.webkit.org/show_bug.cgi?id=106770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/url-color-swatch.html

Spaces were not allowed in url(...) CSS property values.

  • inspector/front-end/StylesSidebarPane.js:

LayoutTests:

  • inspector/styles/url-color-swatch-expected.txt: Added.
  • inspector/styles/url-color-swatch.html: Added.
4:10 AM Changeset in webkit [139606] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Web Inspector: fix DRT to deliver simulated events to devtools front-end
​https://bugs.webkit.org/show_bug.cgi?id=106650

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Add separated m_devToolsTestInterfaces object to testShell which is
bind to devTools webview.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::showDevTools):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
(TestShell::createNewWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

4:05 AM Changeset in webkit [139605] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Web Inspector: InspectorTest.createTestEditor should not set any text in editor
​https://bugs.webkit.org/show_bug.cgi?id=106772

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Add InspectorTest.fillEditorWithText helper method and remove this
functionality from InspectorTest.createTestEditor method.

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
(initialize_EditorTests.InspectorTest.fillEditorWithText): Added.

  • inspector/editor/text-editor-remove-chunks-from-dom.html:
  • inspector/editor/text-editor-selection.html:
  • inspector/editor/text-editor-type-over-decoration.html:
4:03 AM Changeset in webkit [139604] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new asserting test to paint the bots green.

  • platform/qt/TestExpectations:
3:57 AM Changeset in webkit [139603] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css

Merge 139413

Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
​https://bugs.webkit.org/show_bug.cgi?id=106560

Reviewed by Vsevolod Vlasov.

  • src/js/devTools.css:

(body.dock-to-bottom.platform-mac #toolbar):

TBR=​pfeldman@chromium.org
BUG=169438
Review URL: ​https://codereview.chromium.org/11878018

3:53 AM Changeset in webkit [139602] by pfeldman@chromium.org
  • 4 edits
    2 copies in branches/chromium/1364

Merge 139416

Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
​https://bugs.webkit.org/show_bug.cgi?id=106555

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Wrong ::enable was made virtual in the InspectorDebuggerAgent.

Test: inspector/debugger/debugger-scripts-reload.html

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/debugger-scripts-reload-expected.txt: Added.
  • inspector/debugger/debugger-scripts-reload.html: Added.

TBR=​pfeldman@chromium.org
BUG=169437
Review URL: ​https://codereview.chromium.org/11876015

3:10 AM Changeset in webkit [139601] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Pass an Isolate to associateObjectWithWrapper()
​https://bugs.webkit.org/show_bug.cgi?id=106773

Reviewed by Adam Barth.

In preparation for making an Isolate parameter mandatory
in associateObjectWithWrapper(), this patch passes an
Isolate to associateObjectWithWrapper().

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

3:02 AM Changeset in webkit [139600] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] plugin tests assert in debug
​https://bugs.webkit.org/show_bug.cgi?id=106659

Reviewed by Benjamin Poulain.

Fixed the misuse of String::split.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::truncateToSingleLine):
Add an assert to make sure this function works well. I just walked there
while debugging the bug, and although it was innocent, adding this assertion
is logical.

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::scanPlugin):
The ASSERT was wrong. We have three lines, each ends in a newline, so split
with allowEmptyEntries=true will devide it to 4 substrings.

2:44 AM Changeset in webkit [139599] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Call Isolate::GetCurrent() in a callback from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106766

Reviewed by Adam Barth.

The objective is to pass an Isolate everywhere.
Given that a callback from WebCore is an entry point to V8,
we can call Isolate::GetCurrent() at the head of the callback
and pass it to other places. (In practice, handleEvent() is
the only callback used in the current WebKit.)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithNoParam):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

2:15 AM Changeset in webkit [139598] by tommyw@google.com
  • 9 edits in trunk

MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.
​https://bugs.webkit.org/show_bug.cgi?id=106568

Reviewed by Adam Barth.

Source/WebCore:

See specification: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html

Existings tests updated to cover patch.

  • Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::stop):

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::ended):
(WebCore::MediaStream::streamEnded):

  • Modules/mediastream/MediaStream.h:

(MediaStream):
(WebCore::MediaStream::isLocal):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrackList.cpp:

(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):

LayoutTests:

  • fast/mediastream/LocalMediaStream-onended-expected.txt:
  • fast/mediastream/LocalMediaStream-onended.html:
2:13 AM Changeset in webkit [139597] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when "Color format" feature used
​https://bugs.webkit.org/show_bug.cgi?id=106767

Reviewed by Vsevolod Vlasov.

We used to render named colors as names regardless of the selected color format option.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

1:55 AM Changeset in webkit [139596] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash caused by incomplete cleanup of regions information for anonymous block
​https://bugs.webkit.org/show_bug.cgi?id=106191

Patch by Andrei Bucur <​abucur@adobe.com> on 2013-01-14
Reviewed by Abhishek Arya.

Source/WebCore:

When an anonymous block is no longer required it is removed from the render tree and deleted. For example, this can happen when an anonymous block children change
from inlines to blocks. The patch updates the removeLeftoverAnonymousBlock function to delete the flow thread information attached to the obsolete anonymous block.
The removeFromRenderFlowThread() function is recursive and it needs to be called after the anonymous block children were reparented and the child list cleared.
I've also placed the children reset operation before clearing the parent because the latter also deletes the inRenderFlowThread flag from the object and it makes
flow thread ownership detection impossible.

Tests: fast/regions/remove-leftover-anon-block-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeLeftoverAnonymousBlock):

LayoutTests:

  • fast/regions/remove-leftover-anon-block-crash-expected.txt: Added.
  • fast/regions/remove-leftover-anon-block-crash.html: Added.
1:52 AM Changeset in webkit [139595] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in v8DateOrNull()
​https://bugs.webkit.org/show_bug.cgi?id=106765

Reviewed by Adam Barth.

This is one of the efforts to kill all optional Isolate parameters.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::v8DateOrNull):

1:49 AM Changeset in webkit [139594] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Allow nesting of at-rules
​https://bugs.webkit.org/show_bug.cgi?id=106696

Patch by Pablo Flouret <​pablof@motorola.com> on 2013-01-14
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

​http://dev.w3.org/csswg/css3-conditional/ introduces the
concept of grouping rules, and allows for them to be nested. In
particular, this change affects @media (and is needed for @supports as
well).

Test: fast/css/nested-at-rules.html

  • css/CSSGrammar.y.in:

Move media to the block_valid_rule list.

  • css/RuleSet.cpp:

(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):

  • css/RuleSet.h:

Rip out the rule-adding loop into a new method, for added
cleanliness and recursing.

LayoutTests:

  • fast/css/nested-at-rules-expected.txt: Added.
  • fast/css/nested-at-rules.html: Added.
1:44 AM Changeset in webkit [139593] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Add domain column
​https://bugs.webkit.org/show_bug.cgi?id=106757

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Adding new column will ease domain tracking / sorting.

  • inspector/front-end/NetworkPanel.js: Added column.
  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.get domain): Added getter.

1:30 AM Changeset in webkit [139592] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Sheriffbot command aliases need test cases
​https://bugs.webkit.org/show_bug.cgi?id=106754

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-14
Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

(SheriffBotTest.test_command_aliases):

1:23 AM Changeset in webkit [139591] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a typo error in the comments in PlatformContextSkia.h
​https://bugs.webkit.org/show_bug.cgi?id=105612

Patch by Qiankun Miao <​qiankun.miao@intel.com> on 2013-01-14
Reviewed by Stephen White.

"If false we're rendering to a GraphicsContext for a web page, if false
we're not (as is the case when rendering to a canvas object)." is
self-contradictory. The second "flase" in the comments should be
"true". If true, we're rendering to an ImageBuffer which has a canvas
object.

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

1:12 AM Changeset in webkit [139590] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 3/3
​https://bugs.webkit.org/show_bug.cgi?id=106764

Reviewed by Vsevolod Vlasov.

Last three classes with not instrumented members were fixed.

  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::reportMemoryUsage):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

12:21 AM Changeset in webkit [139589] by loislo@chromium.org
  • 20 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
​https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were added into reportMemoryUsage methods.

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

Jan 13, 2013:

11:18 PM Changeset in webkit [139588] by noel.gordon@gmail.com
  • 6 edits
    2 deletes in trunk/LayoutTests

[chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg everywhere

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/chromium/TestExpectations:
11:01 PM Changeset in webkit [139587] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark accessibility/render-counter-text.html as flaky
on EFL port since it sometimes crashes.

  • platform/efl/TestExpectations:
10:58 PM Changeset in webkit [139586] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG phases that store per-node information should store it in Node itself rather than using a secondary vector
​https://bugs.webkit.org/show_bug.cgi?id=106753

Reviewed by Geoffrey Garen.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::performSubstitution):
(JSC::DFG::CSEPhase::setReplacement):
(CSEPhase):

  • dfg/DFGNode.h:

(Node):

10:33 PM Changeset in webkit [139585] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Allow users to misspell the "sheriffs" command in sheriffbot
​https://bugs.webkit.org/show_bug.cgi?id=106628

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Steve Block.

  • Scripts/webkitpy/tool/bot/irc_command.py:
10:28 PM Changeset in webkit [139584] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking media/track/track-css-cue-lifetime.html as a flaky timeout on Debug
Chromium bots.

  • platform/chromium/TestExpectations:
10:05 PM Changeset in webkit [139583] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
​https://bugs.webkit.org/show_bug.cgi?id=106755

Reviewed by Alexander Pavlov.

  • src/js/Tests.js:

(.TestSuite.prototype.nonAnonymousUISourceCodes_.filterOutService):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):

8:42 PM Changeset in webkit [139582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add a public function WebPage::isLoading()
​https://bugs.webkit.org/show_bug.cgi?id=106751

PR 274392

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-01-13
Reviewed by George Staikos.

Need to get the load state in WebPageClient when resolving PR 274392.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::isLoading):
(WebKit):

  • Api/WebPage.h:
8:23 PM Changeset in webkit [139581] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Unreviewed build fix after r139541
​https://bugs.webkit.org/show_bug.cgi?id=106749

undefined reference to `JSC::JSCell::methodTable() const'

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-13

  • ewk/ewk_js.cpp:
  • ewk/ewk_view.cpp:
7:32 PM Changeset in webkit [139580] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make "gardeners" an alias for "sheriffs" in sherrifbot
​https://bugs.webkit.org/show_bug.cgi?id=106627

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/bot/irc_command.py:
6:22 PM Changeset in webkit [139579] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] webkitpy-test: executive.py stringify_args error on the release test bot
​https://bugs.webkit.org/show_bug.cgi?id=105380

Reviewed by Eric Seidel.

Fix a regression introduced in r137692 where we were double-encoding
the arguments to popen(); this was only an issue on windows, where
we would try to encode something to mbcs, then try to encode it
to unicode as if the input as ascii.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_command):

6:18 PM Changeset in webkit [139578] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

State who told sheriffbot to roll the Chromium deps and to what revision
​https://bugs.webkit.org/show_bug.cgi?id=106626

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS._expand_irc_nickname):
(RollChromiumDEPS.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_roll_chromium_deps):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_chromium_deps_roll):

  • Scripts/webkitpy/tool/commands/roll.py:

(RollChromiumDEPS._prepare_state):
(PostChromiumDEPSRoll):
(PostChromiumDEPSRoll._prepare_state):

  • Scripts/webkitpy/tool/commands/roll_unittest.py:

(PostRollCommandsTest.test_prepare_state):

  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:

(PrepareChangeLogForDEPSRoll.run):

4:57 PM Changeset in webkit [139577] by kerz@chromium.org
  • 6 edits
    1 copy in branches/chromium/1364

Merge 139282

Make caret repainting container-aware
​https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

  • editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • editing/FrameSelection.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

  • rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

  • fast/repaint/caret-with-transformation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11886010

4:52 PM Changeset in webkit [139576] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138902

MediaControls::show() should make controls opaque
​https://bugs.webkit.org/show_bug.cgi?id=106034

Patch by Min Qin <​qinmin@chromium.org> on 2013-01-05
Reviewed by Eric Carlson.

Source/WebCore:

When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
However, show() actually displays nothing as the control is transparent.
The user had to move his mouse outside the video rect and move it back in order to show the controls.
Simply clicking/moving the mouse inside the video rect will not make the control opaque.
Test: media/video-controls-visible-exiting-fullscreen.html

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::show):

LayoutTests:

Add tests to check that video controls are shown when exiting from fullscreen.

  • media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
  • media/video-controls-visible-exiting-fullscreen.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11875012

4:29 PM Changeset in webkit [139575] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Alan Cutter as contributor
​https://bugs.webkit.org/show_bug.cgi?id=106747

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
4:16 PM Changeset in webkit [139574] by noel.gordon@gmail.com
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests

[chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux and win

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
1:48 PM Changeset in webkit [139573] by leviw@chromium.org
  • 7 edits
    2 deletes in trunk

Source/WebCore: Unreviewed gardening. Rolling out r139537. It broke platforms without sub-pixel layout.

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

LayoutTests: Unreviewed gardening. Rolling out 139537. It broke platforms not using sub-
pixel layout.

  • fast/images/zoomed-offset-size.html: Removed.
  • fast/images/zoomed-offset-size-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/qt/TestExpectations
1:00 PM Changeset in webkit [139572] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

12:54 PM Changeset in webkit [139571] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.9

New Tag.

9:18 AM Changeset in webkit [139570] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Fix CONFIG missing link_pkgconfig on Windows
​https://bugs.webkit.org/show_bug.cgi?id=106647

Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
properly on Windows because they are added to PKGCONFIG but
CONFIG does not contain link_pkgconfig.

This is because link_pkgconfig is added in unix/default_pre.prf
which is only used for UNIX platforms. To fix this, move it to
the general default_pre.prf.

Patch by Jonathan Liu <​net147@gmail.com> on 2013-01-13
Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
7:24 AM Changeset in webkit [139569] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux

Unreviewed w/end gardening.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium/TestExpectations:
6:39 AM Changeset in webkit [139568] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline svg/W3C-SVG-1.1/animate-elem-80-t.svg on win

Unreviewed w/end gardening.

  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
5:13 AM Changeset in webkit [139567] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 tests as failing on EFL port due to a regression in
r139537. Those tests started failing on GTK and Qt as well.

  • platform/efl/TestExpectations:
4:56 AM Changeset in webkit [139566] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark accessibility/heading-level.html as failing on EFL port.
This test was added in r139534.

  • platform/efl-wk2/TestExpectations:
4:49 AM Changeset in webkit [139565] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform-specific baseline for fast/dom/HTMLTemplateElement/inertContents.html.
Our port and WKTR do not display the failing URL if it is null.

  • platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Added.
4:39 AM Changeset in webkit [139564] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark inspector/debugger/debugger-script-preprocessor.html as
flakey on EFL port since it gives a different output for
every run. This test was added in r139405.

  • platform/efl/TestExpectations:
4:27 AM Changeset in webkit [139563] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark media/video-controls-captions.html as failing on EFL port
due to additional checks added in r139547.

  • platform/efl/TestExpectations:
4:25 AM Changeset in webkit [139562] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Styling disappears from the cue that's being styled by ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=106723

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-13
Reviewed by Antti Koivisto.

Source/WebCore:

Fixes a regression caused by r138966. Setting a pseudoId in TextTrackCue::updateDisplayTree for m_allDocumentNodes
was triggering recalculating styles the next run loop. Now when this was removed we append the WebVTT tree after its children have
been marked by markFutureAndPastNodes so that correct styles are set within this append call.

Test: media/track/track-css-cue-lifetime.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes): changing the type of the first argument because DocumentFragment is not a subclass
of Element.
(WebCore::TextTrackCue::updateDisplayTree): appending the WebVTT rendering tree after its children have been marked properly.

  • html/track/TextTrackCue.h:

(TextTrackCue):

LayoutTests:

  • media/track/captions-webvtt/styling-lifetime.vtt: Added.
  • media/track/track-css-cue-lifetime-expected.txt: Added.
  • media/track/track-css-cue-lifetime.html: Added.
1:46 AM Changeset in webkit [139561] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip new failing tests to paint the bots green.

  • platform/qt/TestExpectations:

Jan 12, 2013:

11:59 PM Changeset in webkit [139560] by thakis@chromium.org
  • 5 edits in trunk/Tools

nrwt/chromium: Don't prefer chromium over webkit build directories
​https://bugs.webkit.org/show_bug.cgi?id=105597

Reviewed by Dirk Pranke.

Rely on the new timestamp logic instead. Requested by dpranke in
​https://bugs.webkit.org/show_bug.cgi?id=105498

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

8:30 PM Changeset in webkit [139559] by thakis@chromium.org
  • 3 edits in trunk/Tools

Use ninja by default on Linux for build-webkit --chromium, bot edition
​https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Eric Seidel.

r139557 changed update-webkit to pick ninja by default on linux, but
the bots run update-webkit-chromium directly so they didn't see this.
Move the default for ninja into update-webkit-chromium so that it's
picked up by the bots, and let update-webkit forward non-default
options to there.

This way, the default is in one place only and both developers (who
usually use update-webkit which then shells out to
updat-webkit-chromium) and bots (which use update-webkit-chromium
directly) see the same behavior.

  • Scripts/update-webkit:
  • Scripts/update-webkit-chromium:
6:43 PM Changeset in webkit [139558] by timothy_horton@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

  • API/JSBlockAdaptor.mm:
  • API/JSContext.mm:
  • API/JSValue.mm:
6:08 PM Changeset in webkit [139557] by thakis@chromium.org
  • 2 edits in trunk/Tools

Make ninja the default build system on Linux for build-webkit --chromium
​https://bugs.webkit.org/show_bug.cgi?id=104434

Reviewed by Eric Seidel.

  • Scripts/update-webkit:
5:44 PM Changeset in webkit [139556] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Provide LevelDB with IDBEnv instead of Env::Default
​https://bugs.webkit.org/show_bug.cgi?id=106135

Reviewed by Tony Chang.

IDBEnv only changes the name of the histogram where errors are logged.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

5:19 PM Changeset in webkit [139555] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Roll chromium DEPS to 176595.
​https://bugs.webkit.org/show_bug.cgi?id=106730

  • DEPS:
1:20 PM Changeset in webkit [139554] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/images/zoomed-offset-size.html as slow on Debug Chromium bots.

  • platform/chromium/TestExpectations:
12:23 PM Changeset in webkit [139553] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Use sync_add_and_fetch instead of gnu_cxx::exchange_and_add
​https://bugs.webkit.org/show_bug.cgi?id=106729

After r139514 we need atomicIncrement(int64_t volatile*) for all platform. Now the
GCC implementation of atomicIncrement() is based on gnu_cxx::exchange_and_add,
which doesn't support int64_t type, but sync_add_and_fetch does.

Reviewed by Benjamin Poulain.

  • wtf/Atomics.h:

(WTF::atomicIncrement):
(WTF::atomicDecrement):

12:16 PM Changeset in webkit [139552] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Tools

Migrate the remaining bots in EC2 to Google Compute Engine
​https://bugs.webkit.org/show_bug.cgi?id=106005

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-12
Reviewed by Eric Seidel.

Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.

  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
  • EWSTools/boot.sh:
  • EWSTools/build-repo.sh:
  • EWSTools/start-queue.sh:
10:05 AM Changeset in webkit [139551] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Regression(r119759): Heap-use-after-free in webkit_glue::WebURLLoaderImpl::Context::OnReceivedResponse
​https://bugs.webkit.org/show_bug.cgi?id=103563

A subresource could receive a body on a 404 if its call to CachedResource::error() resulted in a nested message loop.
That caused a crash when data was received, as the Subresource was in the Finished state already. Now when receiving
data we ignore these bodies, avoiding the crash.

Reviewed by Nate Chapin.

No new tests in WebKit, since it required a nested message loop which isn't present in chromium DumpRender tree.
There's a Chrome side browser test, see ​https://codereview.chromium.org/11778083/

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):

6:53 AM Changeset in webkit [139550] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.11.4

Tagging the WebKitGTK+ 1.11.4 release

5:57 AM Changeset in webkit [139549] by jochen@chromium.org
  • 8 edits in trunk/Tools

[chromium] move inspector related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106654

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::showDevTools):
(WebTestRunner::WebTestDelegate::closeDevTools):
(WebTestRunner::WebTestDelegate::evaluateInWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::showWebInspector):
(WebTestRunner):
(WebTestRunner::TestRunner::closeWebInspector):
(WebTestRunner::TestRunner::evaluateInWebInspector):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::showDevTools):
(WebViewHost::closeDevTools):
(WebViewHost::evaluateInWebInspector):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

4:59 AM Changeset in webkit [139548] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Available height should respect min and max height
​https://bugs.webkit.org/show_bug.cgi?id=106479

Source/WebCore:

Reviewed by Ojan Vafai.

When calculating a relative positioned block's offset as a percentage of its container, respect the min
and max height set on the container

Tests: fast/block/percent-top-respects-max-height.html

fast/block/percent-top-respects-min-height.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeight):

LayoutTests:

Reviewed by Ojan Vafai.

  • fast/block/percent-top-respects-max-height-expected.txt: Added.
  • fast/block/percent-top-respects-max-height.html: Added.
  • fast/block/percent-top-respects-min-height-expected.txt: Added.
  • fast/block/percent-top-respects-min-height.html: Added.
4:04 AM Changeset in webkit [139547] by victor@rosedu.org
  • 6 edits in trunk

CC Button doesn't always show up
​https://bugs.webkit.org/show_bug.cgi?id=106653

Reviewed by Eric Carlson.

Source/WebCore:

Added extra checks to existing test.

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::closedCaptionTracksChanged):
Enforced visibility of captions button whenever the track list changes.
(WebCore):

  • html/shadow/MediaControls.h:

(MediaControls):

LayoutTests:

  • media/video-controls-captions-expected.txt: Updated.
  • media/video-controls-captions.html: Added extra checks that fail

without the code changes.

1:33 AM Changeset in webkit [139546] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed 64 bit buildfix after r139496.

  • dfg/DFGOperations.cpp:

Jan 11, 2013:

11:03 PM Changeset in webkit [139545] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
​https://bugs.webkit.org/show_bug.cgi?id=106610

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-11
Reviewed by Darin Fisher.

Source/WebCore:

No new tests (none needed).

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::finishRequestAutocomplete): Removed handling of AutocompleteResultError.

  • html/HTMLFormElement.h: Removed HTMLFormElement::AutocompleteResultError in favor of more specific errors.

Source/WebKit/chromium:

  • public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
  • src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
9:20 PM Changeset in webkit [139544] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, speculative build fix.

  • API/JSWrapperMap.mm:
9:15 PM Changeset in webkit [139543] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Update platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling.html on win

Unreviewed w/end gardening.

  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
8:54 PM Changeset in webkit [139542] by fpizlo@apple.com
  • 4 edits in trunk/Source

Fix changelogs that got messed up in revision 139541

8:47 PM Changeset in webkit [139541] by fpizlo@apple.com
  • 187 edits
    1 add in trunk/Source

The JITThunks class should be in its own file, and doing so should not break the build
​https://bugs.webkit.org/show_bug.cgi?id=105696

Source/JavaScriptCore:

Rubber stamped by Sam Weinig and Geoffrey Garen.

This patch was supposed to just move JITThunks into its own file. But then I
realized that there is a horrible circular dependency chain between JSCell,
JSGlobalData, CallFrame, and Weak, which only works because of magical include
order in JITStubs.h, and the fact that JSGlobalData.h includes JITStubs.h
before it includes JSCell or JSValue.

I first tried to just get JITThunks.h to just magically do the same pointless
includes that JITStubs.h had, but then I decided to actually fix the underflying
problem, which was that JSCell needed CallFrame, CallFrame needed JSGlobalData,
JSGlobalData needed JITThunks, JITThunks needed Weak, and Weak needed JSCell.
Now, all of JSCell's outgoing dependencies are placed in JSCellInlines.h. This
also gave me an opportunity to move JSValue inline methods from JSCell.h into
JSValueInlines.h. But to make this really work, I needed to remove includes of
*Inlines.h from other headers (CodeBlock.h for example included JSValueInlines.h,
which defeats the whole entire purpose of having an Inlines.h file), and I needed
to add includes of *Inlines.h into a bunch of .cpp files. I did this mostly by
having .cpp files include Operations.h. In future, if you're adding a .cpp file
to JSC, you'll almost certainly have to include Operations.h unless you enjoy
link errors.

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSScriptRef.cpp:
  • API/JSWeakObjectMapRefPrivate.cpp:
  • JSCTypedArrayStubs.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/ArrayAllocationProfile.cpp:
  • bytecode/CodeBlock.cpp:
  • bytecode/GetByIdStatus.cpp:
  • bytecode/LazyOperandValueProfile.cpp:
  • bytecode/ResolveGlobalStatus.cpp:
  • bytecode/SpeculatedType.cpp:
  • bytecode/UnlinkedCodeBlock.cpp:
  • bytecompiler/BytecodeGenerator.cpp:
  • debugger/Debugger.cpp:
  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerCallFrame.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGArrayMode.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGConstantFoldingPhase.cpp:
  • dfg/DFGDriver.cpp:
  • dfg/DFGFixupPhase.cpp:
  • dfg/DFGGraph.cpp:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGOSREntry.cpp:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(DFG):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGStructureCheckHoistingPhase.cpp:
  • dfg/DFGVariableEventStream.cpp:
  • heap/CopiedBlock.h:
  • heap/CopiedSpace.cpp:
  • heap/HandleSet.cpp:
  • heap/Heap.cpp:
  • heap/HeapStatistics.cpp:
  • heap/SlotVisitor.cpp:
  • heap/WeakBlock.cpp:
  • interpreter/CallFrame.cpp:
  • interpreter/CallFrame.h:
  • jit/ClosureCallStubRoutine.cpp:
  • jit/GCAwareJITStubRoutine.cpp:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITCode.h:
  • jit/JITExceptions.cpp:
  • jit/JITStubs.h:
  • jit/JITThunks.h:
  • jsc.cpp:
  • llint/LLIntExceptions.cpp:
  • profiler/LegacyProfiler.cpp:
  • profiler/ProfileGenerator.cpp:
  • profiler/ProfilerBytecode.cpp:
  • profiler/ProfilerBytecodeSequence.cpp:
  • profiler/ProfilerBytecodes.cpp:
  • profiler/ProfilerCompilation.cpp:
  • profiler/ProfilerCompiledBytecode.cpp:
  • profiler/ProfilerDatabase.cpp:
  • profiler/ProfilerOSRExit.cpp:
  • profiler/ProfilerOSRExitSite.cpp:
  • profiler/ProfilerOrigin.cpp:
  • profiler/ProfilerOriginStack.cpp:
  • profiler/ProfilerProfiledBytecodes.cpp:
  • runtime/ArgList.cpp:
  • runtime/Arguments.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/CallData.cpp:
  • runtime/CodeCache.cpp:
  • runtime/Completion.cpp:
  • runtime/ConstructData.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/Error.cpp:
  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorPrototype.cpp:
  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/Identifier.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSBoundFunction.cpp:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC):

  • runtime/JSCellInlines.h: Added.

(JSC):
(JSC::JSCell::JSCell):
(JSC::JSCell::finishCreation):
(JSC::JSCell::structure):
(JSC::JSCell::visitChildren):
(JSC::allocateCell):
(JSC::isZapped):
(JSC::JSCell::isObject):
(JSC::JSCell::isString):
(JSC::JSCell::isGetterSetter):
(JSC::JSCell::isProxy):
(JSC::JSCell::isAPIValueWrapper):
(JSC::JSCell::setStructure):
(JSC::JSCell::methodTable):
(JSC::JSCell::inherits):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSCell::toBoolean):

  • runtime/JSDateMath.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:

(JSC):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSLock.cpp:
  • runtime/JSNameScope.cpp:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.h:

(JSC):

  • runtime/JSProxy.cpp:
  • runtime/JSScope.cpp:
  • runtime/JSSegmentedVariableObject.cpp:
  • runtime/JSString.h:

(JSC):

  • runtime/JSStringJoiner.cpp:
  • runtime/JSSymbolTableObject.cpp:
  • runtime/JSValue.cpp:
  • runtime/JSValueInlines.h:

(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):
(JSC):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):
(JSC::JSValue::asNumber):
(JSC::jsNaN):
(JSC::JSValue::JSValue):
(JSC::JSValue::encode):
(JSC::JSValue::decode):
(JSC::JSValue::operator bool):
(JSC::JSValue::operator==):
(JSC::JSValue::operator!=):
(JSC::JSValue::isEmpty):
(JSC::JSValue::isUndefined):
(JSC::JSValue::isNull):
(JSC::JSValue::isUndefinedOrNull):
(JSC::JSValue::isCell):
(JSC::JSValue::isInt32):
(JSC::JSValue::isDouble):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::tag):
(JSC::JSValue::payload):
(JSC::JSValue::asInt32):
(JSC::JSValue::asDouble):
(JSC::JSValue::asCell):
(JSC::JSValue::isNumber):
(JSC::JSValue::isBoolean):
(JSC::JSValue::asBoolean):
(JSC::reinterpretDoubleToInt64):
(JSC::reinterpretInt64ToDouble):
(JSC::JSValue::isString):
(JSC::JSValue::isPrimitive):
(JSC::JSValue::isGetterSetter):
(JSC::JSValue::isObject):
(JSC::JSValue::getString):
(JSC::::getString):
(JSC::JSValue::getObject):
(JSC::JSValue::getUInt32):
(JSC::JSValue::toPrimitive):
(JSC::JSValue::getPrimitiveNumber):
(JSC::JSValue::toNumber):
(JSC::JSValue::toObject):
(JSC::JSValue::isFunction):
(JSC::JSValue::inherits):
(JSC::JSValue::toThisObject):
(JSC::JSValue::get):
(JSC::JSValue::put):
(JSC::JSValue::putByIndex):
(JSC::JSValue::structureOrUndefined):
(JSC::JSValue::equal):
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):

  • runtime/JSVariableObject.cpp:
  • runtime/JSWithScope.cpp:
  • runtime/JSWrapperObject.cpp:
  • runtime/LiteralParser.cpp:
  • runtime/Lookup.cpp:
  • runtime/NameConstructor.cpp:
  • runtime/NameInstance.cpp:
  • runtime/NamePrototype.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorPrototype.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberObject.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/Operations.h:

(JSC):

  • runtime/PropertySlot.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpCache.cpp:
  • runtime/RegExpCachedResult.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/SmallStrings.cpp:
  • runtime/SparseArrayValueMap.cpp:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StringConstructor.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringRecursionChecker.cpp:
  • runtime/Structure.h:

(JSC):

  • runtime/StructureChain.cpp:
  • runtime/TimeoutChecker.cpp:
  • testRegExp.cpp:

Source/WebCore:

Rubber stamped by Sam Weinig.

All .cpp files that use the JSC internal API must now transitively include
Operations.h, and none of the major JSC headers do it for you to avoid
circularity. WebCore doesn't have to worry about circularity with JSC, so
this changes all of the major WebCore JSC base headers to include
Operations.h.

  • bindings/js/BindingState.h:
  • bindings/js/JSArrayBufferViewHelper.h:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDictionary.h:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/ScriptValue.h:
  • bindings/js/ScriptWrappable.h:
  • bindings/js/SerializedScriptValue.cpp:
  • bridge/c/c_utility.h:
  • bridge/jsc/BridgeJSC.h:
  • dom/Node.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLImageLoader.cpp:
  • plugins/efl/PluginViewEfl.cpp:
  • xml/XMLHttpRequest.cpp:
8:22 PM Changeset in webkit [139540] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If you use Phantom to force something to be live across an OSR exit, you should put it after the OSR exit
​https://bugs.webkit.org/show_bug.cgi?id=106724

Reviewed by Oliver Hunt.

In cases where we were getting it wrong, I think it was benign because we would either already have an
OSR exit prior to there, or the operand would be a constant. But still, it's good to get this right.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

7:49 PM Changeset in webkit [139539] by noel.gordon@gmail.com
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] fast/repaint/4776765.html passes on the chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=103955

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/fast/repaint/4776765-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/4776765-expected.png: Removed.
  • platform/chromium/TestExpectations:
7:39 PM Changeset in webkit [139538] by noel.gordon@gmail.com
  • 2 edits
    2 deletes in trunk/LayoutTests

[chromium] fast/repaint/4774354.html passes on the chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=103955

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/fast/repaint/4774354-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/4774354-expected.png: Removed.
  • platform/chromium/TestExpectations:
6:37 PM Changeset in webkit [139537] by eae@chromium.org
  • 5 edits
    2 adds in trunk

offsetWidth/height incorrect for images when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=106624

Source/WebCore:

Reviewed by Levi Weintraub.

offsetWidth and height are incorrect for images at certain zoom
levels due to flooring the values ones adjusted for zoom.
By rounding the value instead we avoid the problem and return
the right size.

Test: fast/images/zoomed-offset-size.html

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
Change to round (as opposed to floor) the zoom adjusted value.

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):
Add LayoutUnit version of adjustForAbsoluteZoom to avoid float
conversion.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for offsetWidth/Height for zoomed image.

  • fast/images/zoomed-offset-size-expected.txt: Added.
  • fast/images/zoomed-offset-size.html: Added.
6:29 PM Changeset in webkit [139536] by ojan@chromium.org
  • 8 edits
    2 adds in trunk

Fixed width overrides intrinsic min-width/max-width for text inputs and listboxes
​https://bugs.webkit.org/show_bug.cgi?id=106675

Reviewed by Emil A Eklund.

Source/WebCore:

Implement computeIntrinsicLogicalWidths so that RenderBox::computeLogicalWidthInRegionUsing
can get the correct intrinsic sizes instead of the preferred sizes.

Test: fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/RenderTextControl.h:

(RenderTextControl):

LayoutTests:

  • fast/forms/file/intrinsic-min-width-overrides-width-expected.html:
  • fast/forms/file/intrinsic-min-width-overrides-width.html:
  • fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width-expected.html: Added.
  • fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html: Added.
6:21 PM Changeset in webkit [139535] by ojan@chromium.org
  • 11 edits
    6 adds in trunk

Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses
​https://bugs.webkit.org/show_bug.cgi?id=106617

Reviewed by Tony Chang.

Source/WebCore:

Override computeIntrinsicLogicalWidths for all RenderFlexibleBox and RenderDeprecatedFlexibleBox
classes that override computePreferredLogicalWidths so that RenderBox can use
computeIntrinsicLogicalWidths in order to get the correct intrinsic values.

Tests: css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html

fast/flexbox/intrinsic-min-width-applies-with-fixed-width.html
fast/forms/select/intrinsic-min-width-applies-with-fixed-width.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
fit-content needs to use the intrinsic sizes not the preferred sizes
since a fixed width overrides the preferred size.
As best I can tell, the sizesLogicalWidthToFitContent codepath can keep
using preferred widths, which are considerably faster, since that's only used
computing width values. Added a clause to that if-statement to make this more
explicit.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderDeprecatedFlexibleBox.h:

(RenderDeprecatedFlexibleBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderMenuList.h:

(RenderMenuList):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderSlider.h:

(RenderSlider):
No logic changes in any of these computeIntrinsic methods. Just moving
the code over from the computePreferred methods.

LayoutTests:

  • css3/flexbox/intrinsic-min-width-applies-with-fixed-width-expected.txt: Added.
  • css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html: Added.
  • fast/flexbox/intrinsic-min-width-applies-with-fixed-width-expected.txt: Added.
  • fast/flexbox/intrinsic-min-width-applies-with-fixed-width.html: Added.
  • fast/forms/select/intrinsic-min-width-applies-with-fixed-width-expected.html: Added.
  • fast/forms/select/intrinsic-min-width-applies-with-fixed-width.html: Added.
6:07 PM Changeset in webkit [139534] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Need new accessibility layout test to verify levels of headings
​https://bugs.webkit.org/show_bug.cgi?id=106243

Patch by James Craig <​james@cookiecrook.com> on 2013-01-11
Reviewed by Chris Fleizach.

New layout test to verify accessibility API heading levels on implicit h1-h6 and explicit @aria-level.

  • accessibility/heading-level-expected.txt: Added.
  • accessibility/heading-level.html: Added.
  • platform/chromium/TestExpectations: Skip for Chromium due to webkit.org/b/106682
6:05 PM Changeset in webkit [139533] by tonyg@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Move HTMLTokenTypes to its own file
​https://bugs.webkit.org/show_bug.cgi?id=106722

Reviewed by Levi Weintraub.

Also mark AtomicHTMLToken ctor as explicit.

No new tests because no new functionality.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTokenTypes.h: Added.

(WebCore):
(HTMLTokenTypes):
(DoctypeData):
(WebCore::HTMLTokenTypes::DoctypeData::DoctypeData):

6:02 PM Changeset in webkit [139532] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
​https://bugs.webkit.org/show_bug.cgi?id=104427

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-11
Reviewed by Adam Barth.

When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
We added an extra status for didHandleGestureEvent(), so we can distinguish
the case whether the event is actually delivered to the web page or cancelled.

  • public/WebViewClient.h:
  • public/WebWidgetClient.h:

(WebKit):
(WebWidgetClient):
(WebKit::WebWidgetClient::didHandleGestureEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebViewTest.cpp:
5:58 PM Changeset in webkit [139531] by commit-queue@webkit.org
  • 7 edits
    2 copies in trunk/Source/WebKit/chromium

[chromium] Add ContinuousPainter to call setNeedsDisplay on all layers recursively in continuous painting mode
​https://bugs.webkit.org/show_bug.cgi?id=105458

Patch by Eberhard Graether <​egraether@google.com> on 2013-01-11
Reviewed by James Robinson.

In continuous painting mode all layers are constantly repainted to allow for life measurements of page paint time,
while changing HTML and CSS using the WebInspector. This change adds the ContinuousPainter helper object, which
calls setNeedsDisplay() on all GraphicsLayers recursively in order to force all layers to repaint. PageOverlay
layers get excluded from being repainted, because their extra paint time is altering the page paint time metric.

  • WebKit.gyp:
  • src/PageOverlay.h:

(WebKit::PageOverlay::graphicsLayer):
(PageOverlay):

  • src/PageOverlayList.cpp:

(WebKit::PageOverlayList::findGraphicsLayer):
(WebKit):

  • src/PageOverlayList.h:

(WebCore):
(PageOverlayList):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::didBeginFrame):

  • src/WebViewImpl.h:
  • src/painting/ContinuousPainter.cpp: Copied from Source/WebKit/chromium/src/PageOverlay.h.

(WebKit):
(WebKit::ContinuousPainter::setNeedsDisplayRecursive):

  • src/painting/ContinuousPainter.h: Copied from Source/WebKit/chromium/src/PageOverlay.h.

(WebCore):
(WebKit):
(ContinuousPainter):

5:49 PM Changeset in webkit [139530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
​https://bugs.webkit.org/show_bug.cgi?id=106719

Patch by Andrew Lo <​anlo@rim.com> on 2013-01-11
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.

Internal PR 278687

Always ensureFocusTextElementVisible if an element is focused when
the device has a physical keyboard.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementFocused):

5:48 PM Changeset in webkit [139529] by esprehn@chromium.org
  • 2 edits in trunk/Source/WebCore

No need to initialize RefPtrs to 0 in ElementRareData
​https://bugs.webkit.org/show_bug.cgi?id=106717

Reviewed by Ryosuke Niwa.

RefPtrs initialize themself to null, so there's no reason
to do it manually. This was code leftover from when
PseudoElements were stored in bare ptrs instead of in
RefPtrs.

No new tests, just refactoring.

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):

5:43 PM Changeset in webkit [139528] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Phantom(GetLocal) should be treated as relevant to OSR
​https://bugs.webkit.org/show_bug.cgi?id=106715

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performBlockCSE):

LayoutTests:

  • fast/js/dfg-phantom-get-local-expected.txt: Added.
  • fast/js/dfg-phantom-get-local.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-phantom-get-local.js: Added.

(foo):

5:40 PM Changeset in webkit [139527] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html
as slow on all Chromium platforms.

  • platform/chromium/TestExpectations:
5:35 PM Changeset in webkit [139526] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[TexMap] Rename current[Transform|Opacity|Filters] in TextureMapperLayer.
​https://bugs.webkit.org/show_bug.cgi?id=105760

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-11
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperLayer has two transform members: an original value and a
changeable value. The changeable value would be changed by animations.
This patch puts 'current' prefix on the changeable value to clarify
its purpose. Opacity and filters ditto.

No new tests. Refactoring only.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit/qt:

TextureMapperLayerClientQt uses setTransform() and setOpacity() in
GraphicsLayer instead of TextureMapperLayer like LayerTreeRenderer.
This removes unnecessary public API for TextureMapperLayer.

  • WebCoreSupport/TextureMapperLayerClientQt.cpp:

(TextureMapperLayerClientQt::renderCompositedLayers):

5:32 PM Changeset in webkit [139525] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove the dependency of WebCoordinatedSurface::Handle from Coordinated Graphics.
​https://bugs.webkit.org/show_bug.cgi?id=104347

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-11
Reviewed by Noam Rosenthal.

It is a preparation patch for Threaded Coordinated Graphics on WK1.

Currently, UpdateAtlas and CoordinatedImageBacking use
WebCoordinatedSurface::Handle, but WebCoordinatedSurface::Handle can be
used only IPC-based Coordinated Graphics. So this patch removes the
dependency of WebCoordinatedSurface::Handle from UpdateAtlas and
CoordinatedImageBacking. Now CoordinatedLayerTreeHost converts the
handle to a WebCoordinatedSurface.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:

(WebKit::CoordinatedImageBacking::update):
(WebKit::CoordinatedImageBacking::releaseSurfaceIfNeeded):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:

(Coordinator):
(CoordinatedImageBacking):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(WebKit):
(CoordinatedLayerTreeHost):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

(UpdateAtlasClient):
(UpdateAtlas):

5:28 PM Changeset in webkit [139524] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing the linux layout tests

Unreviewed test expectations update.

Some tests were apparently not rebaselined for linux.

  • platform/chromium/TestExpectations:
5:28 PM Changeset in webkit [139523] by tonyg@chromium.org
  • 6 edits in trunk/Source/WebCore

Move constructTreeFromHTMLToken into HTMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=106694

Reviewed by Adam Barth.

This way it will sit parallel to a new constructTreeFromCompactHTMLToken method.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLTreeBuilder.cpp:
  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

4:41 PM Changeset in webkit [139522] by jparent@chromium.org
  • 3 edits in trunk/Tools

Builder should not be a valid parameter for stats dashboard
​https://bugs.webkit.org/show_bug.cgi?id=106698

Reviewed by Dirk Pranke.

Since builder is a dashboard specific parameter, dashboard_base
should not be handling it in handleValidHashParameterWrapper, rather,
each specific dashboard should in its handleValidHashParameter function.

Note that the FIXME in dashboard_base about this was actually wrong -
we don't want to move it to g_crossDashboardState, because it isn't
actually cross dashboard state.

In fact, flakiness and treemap have the code in
handleValidHashParameter, but it is currently dead code because
dashboard_base gets to it first.

Added the proper handling to timeline_explorer, since builder is
valid there.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
4:30 PM Changeset in webkit [139521] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing the 10.8 layout tests

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
4:19 PM Changeset in webkit [139520] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Explicitly set msvs_cygwin_shell to true for actions in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106706

Patch by Robert Iannucci <​iannucci@chromium.org> on 2013-01-11
Reviewed by Tony Chang.

Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.

Since this change will have no semantic effect, no new tests are
required.

  • WebCore.gyp/WebCore.gyp:
4:14 PM Changeset in webkit [139519] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Modifying the databaseQuota call to WebPageClient
​https://bugs.webkit.org/show_bug.cgi?id=106703

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-01-11
Reviewed by Yong Li.

The databaseQuota call in WebPageClientImpl is modified to take in
BP:Strings directly. Also, we want to use the origin URL from the security origin.
Not the database identifier.

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

4:12 PM Changeset in webkit [139518] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: IDBTransaction should manage lifetime of IDBRequests
​https://bugs.webkit.org/show_bug.cgi?id=106678

Reviewed by Tony Chang.

Ensure reference count of IDBRequests don't bounce off zero if there are no script
references are while the events are arriving.

No new tests - no detectable behavior changes.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::create): Register with transaction (which now takes a ref) here to...
(WebCore::IDBRequest::IDBRequest): ...avoid having to relax adoption requirements here.

  • Modules/indexeddb/IDBTransaction.cpp: Keep RefPtr<>s to outstanding requests.

(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):

  • Modules/indexeddb/IDBTransaction.h:
4:10 PM Changeset in webkit [139517] by schenney@chromium.org
  • 94 edits
    63 adds in trunk/LayoutTests

[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
​https://bugs.webkit.org/show_bug.cgi?id=106409

Patch by James Simonsen <​simonjam@chromium.org> on 2013-01-11
Reviewed by Nate Chapin.

  • http/tests/w3c/webperf/resources/all_resource_types.htm:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html:
4:08 PM Changeset in webkit [139516] by ap@apple.com
  • 12 edits in trunk/Source/WebKit2

[WK2] Network process unblocks all waiting threads when any sync reply arrives
​https://bugs.webkit.org/show_bug.cgi?id=106713

Reviewed by Brady Eidson.

Switch to sending sync CoreIPC messages, which is now possible.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose): We no longer have response maps.
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::willSendRequest): Just send a sync message. (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto. (WebKit::NetworkResourceLoader::didReceiveDataArray): Added an unrelated assertion.
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkResourceLoader.messages.in: Removed no longer used reply messages and their handlers.
  • Shared/BlockingResponseMap.h: Removed a bool version, which was not perfectly safe, and only used in NetworkProcess. (BlockingResponseMap::didReceiveResponse): Updated a still valid FIXME to not refer to network process. (BlockingResponseMap::cancel): Ditto.
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.cpp: (WebKit::NetworkProcessConnection::didReceiveSyncMessage): Plumbing to handle sync messages.
  • WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::willSendRequest): (WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in: Updated (simplified) sync messages and their handlers.
4:04 PM Changeset in webkit [139515] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Make it possible to send sync messages from secondary threads
​https://bugs.webkit.org/show_bug.cgi?id=106708

Apply another review comment (overlooked a "ditto").

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
4:01 PM Changeset in webkit [139514] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Make it possible to send sync messages from secondary threads
​https://bugs.webkit.org/show_bug.cgi?id=106708

Reviewed by Anders Carlsson.

It is hugely beneficial to implement sync messages at Connection level, because
ad hoc code that blocks a thread and wakes it up when a reply arrives on main
thread can't be made equally performant. A CoreOPC MessageDecoder can be moved across
threads, which can't be done with a decoded argument passed by reference to client code.

Sync messages from secondary threads are tracked in much simpler data structure
than client thread ones, because we don't need to be concerned with incoming messages.

  • Platform/CoreIPC/Connection.cpp: (Connection::SecondaryThreadPendingSyncReply): (CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply): (CoreIPC::Connection::createSyncMessageEncoder): (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::sendSyncMessageFromSecondaryThread): (CoreIPC::Connection::processIncomingSyncReply): (CoreIPC::Connection::connectionDidClose):
  • Platform/CoreIPC/Connection.h: Also corrected a misleading comment.
3:54 PM Changeset in webkit [139513] by simonjam@chromium.org
  • 10 edits in trunk

[Resource Timing] XMLHttpRequests should have initiator type 'xmlhttprequest'
​https://bugs.webkit.org/show_bug.cgi?id=106409

Reviewed by Nate Chapin.

Source/WebCore:

The initiator is passed through ThreadableLoaderOptions to the CachedResourceRequest. This is
optional, so other users of ThreadableLoader will have the default initiator of 'request'. Note
that synchronous XHRs don't show up in the Resource Timing buffer yet.

Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/ThreadableLoader.h:

(ThreadableLoaderOptions):

  • loader/cache/CachedResourceRequestInitiators.cpp:

(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):

  • loader/cache/CachedResourceRequestInitiators.h:

(CachedResourceRequestInitiators):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

  • http/tests/w3c/webperf/resources/all_resource_types.htm:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt:
  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html:
3:42 PM Changeset in webkit [139512] by schenney@chromium.org
  • 248 edits
    273 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

New results for fast tests.

  • platform/chromium-linux-x86/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/basic: Added.
  • platform/chromium-linux-x86/fast/block/basic/011-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/margin-collapse: Added.
  • platform/chromium-linux-x86/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/positioning/inline-block-relposition-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-linux-x86/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-linux-x86/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-linux-x86/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/square-button-appearance-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/text-transform-select-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTableColElement: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTextAreaElement: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/001-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/003-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/004-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label06-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/HTMLOptionElement_label07-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/basic-inputs-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-align-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-generated-content-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-inner-block-reuse-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-positioned-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/button-white-space-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file: Added.
  • platform/chromium-linux-x86/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/file/input-file-re-render-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmove-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmove2-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select: Added.
  • platform/chromium-linux-x86/fast/forms/select-size-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select-writing-direction-natural-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/background-clipped-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux-x86/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/radial-centered-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux-x86/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-linux-x86/fast/hidpi: Added.
  • platform/chromium-linux-x86/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-linux-x86/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-linux-x86/fast/html: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/keygen-expected.png: Added.
  • platform/chromium-linux-x86/fast/invalid: Added.
  • platform/chromium-linux-x86/fast/invalid/014-expected.png: Added.
  • platform/chromium-linux-x86/fast/parser/bad-xml-slash-expected.png: Added.
  • platform/chromium-linux-x86/fast/parser/document-write-option-expected.png: Added.
  • platform/chromium-linux-x86/fast/reflections: Added.
  • platform/chromium-linux-x86/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/replaced-breaking-mixture-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/three-selects-break-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/width100percent-menulist-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-linux-x86/fast/selectors/064-expected.png: Added.
  • platform/chromium-linux-x86/fast/table: Added.
  • platform/chromium-linux-x86/fast/table/append-cells2-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/remove-td-display-none-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/international/bidi-menulist-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/stroking-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-linux-x86/fast/text/whitespace: Added.
  • platform/chromium-linux-x86/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-linux/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-linux/fast/borders/border-image-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/chromium-linux/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-linux/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-linux/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-linux/fast/canvas/arc360-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-linux/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-linux/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.png:
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png:
  • platform/chromium-linux/fast/css/square-button-appearance-expected.png:
  • platform/chromium-linux/fast/css/text-transform-select-expected.png:
  • platform/chromium-linux/fast/css/transformed-mask-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-linux/fast/forms/001-expected.png:
  • platform/chromium-linux/fast/forms/003-expected.png:
  • platform/chromium-linux/fast/forms/004-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/button-align-expected.png:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-linux/fast/forms/button-positioned-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-style-color-expected.png:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.png:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.png:
  • platform/chromium-linux/fast/forms/button-white-space-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/formmove3-expected.png:
  • platform/chromium-linux/fast/forms/select-size-expected.png:
  • platform/chromium-linux/fast/forms/select-style-expected.png:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-linux/fast/forms/select-writing-direction-natural-expected.png:
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
  • platform/chromium-linux/fast/forms/selectlist-minsize-expected.png:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.png:
  • platform/chromium-linux/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-linux/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.png:
  • platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-linux/fast/html/details-replace-text-expected.png:
  • platform/chromium-linux/fast/html/keygen-expected.png:
  • platform/chromium-linux/fast/invalid/014-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/parser/document-write-option-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-linux/fast/repaint/4774354-expected.png:
  • platform/chromium-linux/fast/repaint/4776765-expected.png:
  • platform/chromium-linux/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-menulist-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-linux/fast/selectors/064-expected.png:
  • platform/chromium-linux/fast/table/append-cells2-expected.png:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.png:
  • platform/chromium-linux/fast/text/stroking-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-mac-lion/fast/canvas/arc360-expected.png:
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac-lion/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac-lion/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac-lion/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-lion/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac-lion/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac-lion/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac-lion/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac-lion/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac-lion/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac-lion/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-mac-lion/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-mac-lion/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-lion/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac-lion/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/4774354-expected.png:
  • platform/chromium-mac-lion/fast/repaint/4776765-expected.png:
  • platform/chromium-mac-lion/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
  • platform/chromium-mac-lion/fast/text/stroking-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/stroking-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-hidpi-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-mac/fast/borders/border-image-outset-expected.png:
  • platform/chromium-mac/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/chromium-mac/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-mac/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-mac/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-mac/fast/canvas/arc360-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-mac/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/transformed-mask-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-mac/fast/gradients/background-clipped-expected.png:
  • platform/chromium-mac/fast/gradients/border-image-gradient-expected.png:
  • platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-mac/fast/gradients/css3-color-stops-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients2-expected.png:
  • platform/chromium-mac/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-mac/fast/gradients/radial-centered-expected.png:
  • platform/chromium-mac/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/repaint/4774354-expected.png:
  • platform/chromium-mac/fast/repaint/4776765-expected.png:
  • platform/chromium-mac/fast/repaint/background-generated-expected.png:
  • platform/chromium-mac/fast/text/stroking-decorations-expected.png:
  • platform/chromium-mac/fast/text/stroking-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-win-xp/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-win-xp/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-win-xp/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/background-clipped-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/generated-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/simple-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-win-xp/fast/hidpi: Added.
  • platform/chromium-win-xp/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-win-xp/fast/reflections: Added.
  • platform/chromium-win-xp/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/4774354-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/4776765-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/background-generated-expected.png: Added.
  • platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win-xp/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-win/fast/borders/border-image-outset-expected.png:
  • platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.png:
  • platform/chromium-win/fast/borders/border-image-outset-split-inline-expected.png: Added.
  • platform/chromium-win/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png:
  • platform/chromium-win/fast/borders/border-image-slice-constrained-expected.png:
  • platform/chromium-win/fast/borders/border-image-trumps-radius-expected.png: Added.
  • platform/chromium-win/fast/canvas/arc360-expected.png:
  • platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-win/fast/css/linear-gradient-currentcolor-expected.png: Added.
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/css/transformed-mask-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/gradients/background-clipped-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients2-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.png:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.png:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-win/fast/gradients/zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png:
  • platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
  • platform/chromium-win/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-win/fast/repaint/4774354-expected.png:
  • platform/chromium-win/fast/repaint/4776765-expected.png:
  • platform/chromium-win/fast/repaint/background-generated-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium/TestExpectations:
3:34 PM Changeset in webkit [139511] by tony@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

Unreviewed, revert r139157 to fix the chromium build.
These files were deleted in a follow up and since r139044 was reverted, we need to
add back these files.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added.

(WebKit):
(WebKit::distanceToRect):
(WebKit::DragScrollTimer::DragScrollTimer):
(WebKit::DragScrollTimer::~DragScrollTimer):
(WebKit::DragScrollTimer::stop):
(WebKit::DragScrollTimer::scroll):
(WebKit::DragScrollTimer::update):
(WebKit::DragScrollTimer::triggerScroll):
(WebKit::DragScrollTimer::scrollDistanceFor):

  • src/DragScrollTimer.h: Added.

(WebKit):
(DragScrollTimer):
(WebKit::DragScrollTimer::fired):
(WebKit::DragScrollTimer::shouldScroll):

3:32 PM Changeset in webkit [139510] by psolanki@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix function name typo ProgramExecutable::initalizeGlobalProperties()
​https://bugs.webkit.org/show_bug.cgi?id=106701

Reviewed by Geoffrey Garen.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • runtime/Executable.h:
3:18 PM Changeset in webkit [139509] by simonjam@chromium.org
  • 7 edits
    3 adds in trunk

Restore old semantics to webkitRequestAnimationFrame callbacks
​https://bugs.webkit.org/show_bug.cgi?id=106697

Reviewed by James Robinson.

Source/WebCore:

Sites that use GWT <= 2.4 are buggy and rely on Date.now()-like callback values.
We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
requestAnimationFrame will continue to follow the spec.

Test: fast/animation/request-animation-frame-prefix.html

  • dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::requestAnimationFrame):
(WebCore):
(WebCore::DOMWindow::webkitRequestAnimationFrame):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/animation/request-animation-frame-prefix-expected.txt: Added.
  • fast/animation/request-animation-frame-prefix.html: Added.
  • fast/animation/script-tests/request-animation-frame-prefix.js: Added.

(busyWait):
(window.webkitRequestAnimationFrame):

3:09 PM Changeset in webkit [139508] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

testapi is failing with a block-related error in the Objc API
​https://bugs.webkit.org/show_bug.cgi?id=106055

Reviewed by Filip Pizlo.

Same bug as in testapi.mm. We need to actually call the static block, rather than casting the block to a bool.

  • API/ObjCCallbackFunction.mm:

(blockSignatureContainsClass):

3:08 PM Changeset in webkit [139507] by rniwa@webkit.org
  • 1 copy in branches/safari-536.28-branch/Tools/BuildSlaveSupport/delete-stale-build-files

Copy delete-stable-build-files into this branch as needed.

3:04 PM Changeset in webkit [139506] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a run-time option to print bytecode at DFG compile time
​https://bugs.webkit.org/show_bug.cgi?id=106704

Reviewed by Mark Hahnenberg.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • runtime/Options.h:

(JSC):

2:57 PM Changeset in webkit [139505] by rniwa@webkit.org
  • 3 edits in trunk/Tools

REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
​https://bugs.webkit.org/show_bug.cgi?id=106688

Reviewed by Eric Seidel.

Update the regular expression used to strip the garbage at the beginning.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.nrwt_log_message_regexp):

2:56 PM Changeset in webkit [139504] by kbr@google.com
  • 4 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=106606

Reviewed by Dimitri Glazkov.

Reduced number of iterations of test, and marked as slow. Changed
test's output and expectations so number of iterations can be
adjusted without rebaselining.

  • fast/canvas/webgl/context-release-upon-reload-expected.txt:
  • fast/canvas/webgl/context-release-upon-reload.html:
  • platform/chromium/TestExpectations:
2:52 PM Changeset in webkit [139503] by commit-queue@webkit.org
  • 16 edits
    2 deletes in trunk

Unreviewed, rolling out r139044.
​http://trac.webkit.org/changeset/139044
​https://bugs.webkit.org/show_bug.cgi?id=106702

Caused various scrolling anomolies on Mac with drag and drop
(Requested by smfr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-11

Source/WebCore:

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::AutoscrollController):
(WebCore::AutoscrollController::autoscrollTimerFired):

  • page/AutoscrollController.h:

(WebCore):
(AutoscrollController):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop):

  • rendering/RenderBox.cpp:

(WebCore):
(WebCore::RenderBox::autoscroll):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::autoscroll):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autoscroll):

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::dragSourceEndedAt):
(WebKit::WebViewImpl::dragSourceMovedTo):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):

  • src/WebViewImpl.h:

(WebKit):

LayoutTests:

  • fast/events/drag-and-drop-autoscroll-expected.txt: Removed.
  • fast/events/drag-and-drop-autoscroll.html: Removed.
2:45 PM Changeset in webkit [139502] by rafaelw@chromium.org
  • 6 edits in trunk

Prevent HTMLPreloadScanner from fetching resources inside <template>
​https://bugs.webkit.org/show_bug.cgi?id=106687

Reviewed by Adam Barth.

Source/WebCore:

This patch adds a simple counter to the preload scanner which increments on template start
tag and decrements on template element. It only fetchs resources when the counter is at zero
(i.e. for elements not contained by a template element).

Test re-enabled within fast/dom/HTMLTemplateElement/inertContents.html

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLPreloadScanner.h:

(HTMLPreloadScanner):

LayoutTests:

  • fast/dom/HTMLTemplateElement/inertContents-expected.txt:
  • fast/dom/HTMLTemplateElement/inertContents.html:
2:42 PM Changeset in webkit [139501] by schenney@chromium.org
  • 72 edits
    45 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

CSS and editing results for all outstanding platforms.

  • platform/chromium-linux-x86/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-linux-x86/css3/images: Added.
  • platform/chromium-linux-x86/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-161-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-19b-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-25-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-64-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-70-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-25-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-64-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-70-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-25-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-64-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-70-expected.png: Added.
  • platform/chromium-linux-x86/editing/pasteboard/4641033-expected.png: Added.
  • platform/chromium-linux-x86/editing/pasteboard/4944770-1-expected.png: Added.
  • platform/chromium-linux-x86/editing/pasteboard/4944770-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/4397952-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/5240265-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/caret-before-select-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/select-box-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/select-element-paragraph-boundary-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-linux-x86/editing/spelling: Added.
  • platform/chromium-linux-x86/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/4397952-expected.png:
  • platform/chromium-linux/editing/selection/5240265-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-linux/editing/selection/select-box-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/editing/selection/selection-button-text-expected.png:
  • platform/chromium-linux/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac-lion/css3/images: Added.
  • platform/chromium-mac-lion/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-lion/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690703-expected.png:
  • platform/chromium-mac-lion/editing/selection/3690719-expected.png:
  • platform/chromium-mac-lion/editing/selection/4397952-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-box-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-box-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/caret-before-select-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-mac/editing/selection/select-box-expected.png:
  • platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium-win-xp/css3/images: Added.
  • platform/chromium-win-xp/css3/images/cross-fade-overflow-position-expected.png: Added.
  • platform/chromium-win-xp/editing/spelling: Added.
  • platform/chromium-win-xp/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
  • platform/chromium-win/editing/spelling/grammar-markers-hidpi-expected.png:
  • platform/chromium/TestExpectations:
2:34 PM UsingGitHub edited by abarth@webkit.org
(diff)
2:34 PM Changeset in webkit [139500] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Exclude unused resources.

Reviewed by Darin Adler.

  • Configurations/WebKit2.xcconfig: Defined EXCLUDED_SOURCE_FILE_NAMES.
2:30 PM Changeset in webkit [139499] by schenney@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mac 10.6 and 10.7 results that are the last to be failing on those bots.

  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
2:26 PM Changeset in webkit [139498] by schenney@chromium.org
  • 427 edits in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mac 10.8 results that were not ready when the other mac results were updated.

  • platform/chromium-mac-lion/editing/selection/iframe-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/deleting/4922367-expected.png:
  • platform/chromium-mac/editing/deleting/5099303-expected.png:
  • platform/chromium-mac/editing/deleting/5126166-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac/editing/deleting/5272440-expected.png:
  • platform/chromium-mac/editing/deleting/5369009-expected.png:
  • platform/chromium-mac/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac/editing/deleting/5483370-expected.png:
  • platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac/editing/execCommand/print-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac/editing/inserting/12882-expected.png:
  • platform/chromium-mac/editing/inserting/4278698-expected.png:
  • platform/chromium-mac/editing/inserting/4840662-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac/editing/inserting/4959067-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac/editing/inserting/5002441-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac/editing/inserting/5418891-expected.png:
  • platform/chromium-mac/editing/inserting/5510537-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac/editing/inserting/6703873-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac/editing/inserting/line-break-expected.png:
  • platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac/editing/inserting/redo-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac/editing/selection/13804-expected.png:
  • platform/chromium-mac/editing/selection/4818145-expected.png:
  • platform/chromium-mac/editing/selection/4866671-expected.png:
  • platform/chromium-mac/editing/selection/4889598-expected.png:
  • platform/chromium-mac/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac/editing/selection/4947387-expected.png:
  • platform/chromium-mac/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac/editing/selection/5007143-expected.png:
  • platform/chromium-mac/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac/editing/selection/5057506-expected.png:
  • platform/chromium-mac/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac/editing/selection/5099303-expected.png:
  • platform/chromium-mac/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac/editing/selection/6476-expected.png:
  • platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac/editing/selection/iframe-expected.png:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac/editing/spelling/spelling-expected.png:
  • platform/chromium-mac/editing/style/4916887-expected.png:
  • platform/chromium-mac/editing/style/5017613-1-expected.png:
  • platform/chromium-mac/editing/style/5017613-2-expected.png:
  • platform/chromium-mac/editing/style/5046875-1-expected.png:
  • platform/chromium-mac/editing/style/5046875-2-expected.png:
  • platform/chromium-mac/editing/style/5065910-expected.png:
  • platform/chromium-mac/editing/style/5084241-expected.png:
  • platform/chromium-mac/editing/style/5228141-expected.png:
  • platform/chromium-mac/editing/style/5279521-expected.png:
  • platform/chromium-mac/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac/editing/style/highlight-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac/editing/undo/4063751-expected.png:
  • platform/chromium-mac/editing/undo/5378473-expected.png:
  • platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
  • platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
2:20 PM Changeset in webkit [139497] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

We should be able to checkpoint and restore the HTMLTokenizer across threads
​https://bugs.webkit.org/show_bug.cgi?id=106597

Based on patch by Adam Barth.

This has the ability to create a checkpoint any time the parser is blocked on a script.
We clear m_appropriateEndTagName after each end tag is flushed so that the ASSERT in
canCreateCheckpoint() will pass.

Reviewed by Adam Barth.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.h:

(WebCore):
(HTMLDocumentParser):

  • html/parser/HTMLTokenizer.cpp:

(WebCore):
(WebCore::HTMLTokenizer::canCreateCheckpoint):
(WebCore::HTMLTokenizer::createCheckpoint):
(WebCore::HTMLTokenizer::restoreFromCheckpoint):

  • html/parser/HTMLTokenizer.h:

(HTMLTokenizer):
(Checkpoint):
(WebCore::HTMLTokenizer::Checkpoint::Checkpoint):

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::skipNextNewLine):
(InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::reset):

2:18 PM Changeset in webkit [139496] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

It should be possible to enable verbose printing of each OSR exit at run-time (rather than compile-time) and it should print register state
​https://bugs.webkit.org/show_bug.cgi?id=106700

Reviewed by Mark Hahnenberg.

  • dfg/DFGAssemblyHelpers.h:

(DFG):
(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGCommon.h:
  • dfg/DFGOSRExit.h:

(DFG):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • runtime/Options.h:

(JSC):

2:15 PM Changeset in webkit [139495] by dmazzoni@google.com
  • 1 edit
    162 deletes in trunk/LayoutTests

[Chromium] unnecessary expectations in platform/chromium/accessibility
​https://bugs.webkit.org/show_bug.cgi?id=106676

These files were copied from platform/mac/accessibility, but
all of the corresponding tests are either mac-specific, or
currently skipped on Chromium. There's no purpose to having
these expectations in platform/chromium/accessibility.

Reviewed by Chris Fleizach.

  • platform/chromium/accessibility/accesskey-expected.txt: Removed.
  • platform/chromium/accessibility/area-with-aria-label-expected.txt: Removed.
  • platform/chromium/accessibility/aria-alerts-expected.txt: Removed.
  • platform/chromium/accessibility/aria-checkbox-text-expected.txt: Removed.
  • platform/chromium/accessibility/aria-combobox-expected.txt: Removed.
  • platform/chromium/accessibility/aria-directory-expected.txt: Removed.
  • platform/chromium/accessibility/aria-divs-not-ignored-expected.txt: Removed.
  • platform/chromium/accessibility/aria-drag-drop-expected.txt: Removed.
  • platform/chromium/accessibility/aria-expanded-notifications-expected.txt: Removed.
  • platform/chromium/accessibility/aria-expanded-standard-items-expected.txt: Removed.
  • platform/chromium/accessibility/aria-flowto-expected.txt: Removed.
  • platform/chromium/accessibility/aria-grid-with-strange-hierarchy-expected.txt: Removed.
  • platform/chromium/accessibility/aria-grouping-roles-expected.txt: Removed.
  • platform/chromium/accessibility/aria-hidden-changes-for-non-ignored-elements-expected.txt: Removed.
  • platform/chromium/accessibility/aria-listbox-selectedchildren-change-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregion-marquee-default-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregion-on-image-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-addedelement-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-attributes-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-changedalt-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-changedtext-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-notifications-always-sent-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-notifications-expected.txt: Removed.
  • platform/chromium/accessibility/aria-liveregions-removedelement-expected.txt: Removed.
  • platform/chromium/accessibility/aria-menu-role-descriptions-expected.txt: Removed.
  • platform/chromium/accessibility/aria-menubar-expected.txt: Removed.
  • platform/chromium/accessibility/aria-multiline-expected.txt: Removed.
  • platform/chromium/accessibility/aria-multiselectable-expected.txt: Removed.
  • platform/chromium/accessibility/aria-owns-expected.txt: Removed.
  • platform/chromium/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Removed.
  • platform/chromium/accessibility/aria-radiobutton-text-expected.txt: Removed.
  • platform/chromium/accessibility/aria-radiogroup-expected.txt: Removed.
  • platform/chromium/accessibility/aria-range-expected.txt: Removed.
  • platform/chromium/accessibility/aria-range-value-expected.txt: Removed.
  • platform/chromium/accessibility/aria-required-expected.txt: Removed.
  • platform/chromium/accessibility/aria-slider-expected.txt: Removed.
  • platform/chromium/accessibility/aria-slider-value-change-expected.txt: Removed.
  • platform/chromium/accessibility/aria-sort-expected.txt: Removed.
  • platform/chromium/accessibility/aria-spinbutton-expected.txt: Removed.
  • platform/chromium/accessibility/aria-table-with-colspan-cells-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tables-expected.txt: Removed.
  • platform/chromium/accessibility/aria-toolbar-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tree-activedescendant-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tree-expected.txt: Removed.
  • platform/chromium/accessibility/aria-tree-index-of-items-expected.txt: Removed.
  • platform/chromium/accessibility/aria-treegrid-expected.txt: Removed.
  • platform/chromium/accessibility/aria-valuetext-expected.txt: Removed.
  • platform/chromium/accessibility/attributed-string-includes-highlighting-expected.txt: Removed.
  • platform/chromium/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt: Removed.
  • platform/chromium/accessibility/bounds-for-range-expected.txt: Removed.
  • platform/chromium/accessibility/button-shouldnot-have-axvalue-expected.txt: Removed.
  • platform/chromium/accessibility/canvas-expected.txt: Removed.
  • platform/chromium/accessibility/change-notification-on-scroll-expected.txt: Removed.
  • platform/chromium/accessibility/clipped-text-under-element-expected.txt: Removed.
  • platform/chromium/accessibility/content-editable-expected.txt: Removed.
  • platform/chromium/accessibility/content-editable-range-properties-expected.txt: Removed.
  • platform/chromium/accessibility/crash-in-element-for-text-marker-expected.txt: Removed.
  • platform/chromium/accessibility/crash-invalid-text-marker-node-expected.txt: Removed.
  • platform/chromium/accessibility/css-content-attribute-expected.txt: Removed.
  • platform/chromium/accessibility/css-speech-speak-expected.txt: Removed.
  • platform/chromium/accessibility/definition-list-term-expected.txt: Removed.
  • platform/chromium/accessibility/deleting-iframe-destroys-axcache-expected.txt: Removed.
  • platform/chromium/accessibility/div-containing-div-with-aria-expected.txt: Removed.
  • platform/chromium/accessibility/document-attributes-expected.txt: Removed.
  • platform/chromium/accessibility/document-links-expected.txt: Removed.
  • platform/chromium/accessibility/document-title-used-for-description-expected.txt: Removed.
  • platform/chromium/accessibility/double-title-expected.txt: Removed.
  • platform/chromium/accessibility/element-focus-expected.txt: Removed.
  • platform/chromium/accessibility/element-for-text-marker-expected.txt: Removed.
  • platform/chromium/accessibility/element-haspopup-expected.txt: Removed.
  • platform/chromium/accessibility/element-is-ignored-expected.txt: Removed.
  • platform/chromium/accessibility/element-level-expected.txt: Removed.
  • platform/chromium/accessibility/estimated-progress-expected.txt: Removed.
  • platform/chromium/accessibility/footer-expected.txt: Removed.
  • platform/chromium/accessibility/footer-roledescription-expected.txt: Removed.
  • platform/chromium/accessibility/form-control-value-settable-expected.txt: Removed.
  • platform/chromium/accessibility/frame-with-title-expected.txt: Removed.
  • platform/chromium/accessibility/header-expected.txt: Removed.
  • platform/chromium/accessibility/heading-clickpoint-expected.txt: Removed.
  • platform/chromium/accessibility/html-section-elements-expected.txt: Removed.
  • platform/chromium/accessibility/html-slider-indicator-expected.txt: Removed.
  • platform/chromium/accessibility/html-with-aria-label-expected.txt: Removed.
  • platform/chromium/accessibility/html5-input-number-expected.txt: Removed.
  • platform/chromium/accessibility/html5-required-attribute-expected.txt: Removed.
  • platform/chromium/accessibility/iframe-aria-hidden-expected.txt: Removed.
  • platform/chromium/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Removed.
  • platform/chromium/accessibility/image-map2-expected.txt: Removed.
  • platform/chromium/accessibility/imagemap-hittest-expected.txt: Removed.
  • platform/chromium/accessibility/inherited-presentational-lists-expected.txt: Removed.
  • platform/chromium/accessibility/input-image-url-expected.txt: Removed.
  • platform/chromium/accessibility/input-slider-expected.txt: Removed.
  • platform/chromium/accessibility/internal-link-anchors-expected.txt: Removed.
  • platform/chromium/accessibility/internal-link-anchors2-expected.txt: Removed.
  • platform/chromium/accessibility/internal-link-when-document-has-fragment-expected.txt: Removed.
  • platform/chromium/accessibility/label-element-with-hidden-control-expected.txt: Removed.
  • platform/chromium/accessibility/list-items-ignored-expected.txt: Removed.
  • platform/chromium/accessibility/listbox-hit-test-expected.txt: Removed.
  • platform/chromium/accessibility/lists-expected.txt: Removed.
  • platform/chromium/accessibility/live-region-on-span-expected.txt: Removed.
  • platform/chromium/accessibility/math-alttext-expected.txt: Removed.
  • platform/chromium/accessibility/media-element-expected.txt: Removed.
  • platform/chromium/accessibility/misspelled-attributed-string-expected.txt: Removed.
  • platform/chromium/accessibility/mixed-checkbox-expected.txt: Removed.
  • platform/chromium/accessibility/native-vs-nonnative-checkboxes-expected.txt: Removed.
  • platform/chromium/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Removed.
  • platform/chromium/accessibility/option-with-arialabel-expected.txt: Removed.
  • platform/chromium/accessibility/option-with-lang-expected.txt: Removed.
  • platform/chromium/accessibility/parent-of-table-row-is-table-expected.txt: Removed.
  • platform/chromium/accessibility/plugin-expected.txt: Removed.
  • platform/chromium/accessibility/popup-button-title-expected.txt: Removed.
  • platform/chromium/accessibility/progressbar-expected.txt: Removed.
  • platform/chromium/accessibility/radio-button-group-members-expected.txt: Removed.
  • platform/chromium/accessibility/range-alter-by-step-expected.txt: Removed.
  • platform/chromium/accessibility/range-for-line-textarea-expected.txt: Removed.
  • platform/chromium/accessibility/range-for-position-expected.txt: Removed.
  • platform/chromium/accessibility/removing-textarea-after-edit-crash-expected.txt: Removed.
  • platform/chromium/accessibility/scrollbars-expected.txt: Removed.
  • platform/chromium/accessibility/search-predicate-expected.txt: Removed.
  • platform/chromium/accessibility/search-subrole-expected.txt: Removed.
  • platform/chromium/accessibility/search-when-element-starts-in-table-expected.txt: Removed.
  • platform/chromium/accessibility/search-with-frames-expected.txt: Removed.
  • platform/chromium/accessibility/select-element-selection-with-optgroups-expected.txt: Removed.
  • platform/chromium/accessibility/selected-rows-table-expected.txt: Removed.
  • platform/chromium/accessibility/selected-tab-crash-expected.txt: Removed.
  • platform/chromium/accessibility/selected-text-range-for-empty-textarea-expected.txt: Removed.
  • platform/chromium/accessibility/selection-value-changes-for-aria-textbox-expected.txt: Removed.
  • platform/chromium/accessibility/slider-allows-title-ui-element-expected.txt: Removed.
  • platform/chromium/accessibility/slider-supports-actions-expected.txt: Removed.
  • platform/chromium/accessibility/stale-table-rows-expected.txt: Removed.
  • platform/chromium/accessibility/static-text-role-uses-text-under-element-expected.txt: Removed.
  • platform/chromium/accessibility/static-text-with-aria-label-expected.txt: Removed.
  • platform/chromium/accessibility/string-range-contains-listmarker-expected.txt: Removed.
  • platform/chromium/accessibility/submit-button-default-value-expected.txt: Removed.
  • platform/chromium/accessibility/supports-focus-setting-expected.txt: Removed.
  • platform/chromium/accessibility/table-attributes-expected.txt: Removed.
  • platform/chromium/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/chromium/accessibility/table-cells-expected.txt: Removed.
  • platform/chromium/accessibility/table-detection-expected.txt: Removed.
  • platform/chromium/accessibility/table-multi-bodies-expected.txt: Removed.
  • platform/chromium/accessibility/table-one-cell-expected.txt: Removed.
  • platform/chromium/accessibility/table-sections-expected.txt: Removed.
  • platform/chromium/accessibility/table-updating-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-aria-role-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-row-col-of-headers-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-rules-expected.txt: Removed.
  • platform/chromium/accessibility/table-with-zebra-rows-expected.txt: Removed.
  • platform/chromium/accessibility/text-marker-length-expected.txt: Removed.
  • platform/chromium/accessibility/textbox-role-reports-line-number-expected.txt: Removed.
  • platform/chromium/accessibility/textbox-role-reports-notifications-expected.txt: Removed.
  • platform/chromium/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Removed.
  • platform/chromium/accessibility/textmarker-routines-expected.txt: Removed.
  • platform/chromium/accessibility/title-attribute-not-used-as-axtitle-expected.txt: Removed.
  • platform/chromium/accessibility/title-attribute-used-as-last-resort-expected.txt: Removed.
  • platform/chromium/accessibility/unexpected-help-text-expected.txt: Removed.
  • platform/chromium/accessibility/unsupported-attribute-does-not-crash-expected.txt: Removed.
  • platform/chromium/accessibility/update-children-when-aria-role-changes-expected.txt: Removed.
  • platform/chromium/accessibility/updating-attribute-in-table-row-crash-expected.txt: Removed.
  • platform/chromium/accessibility/visible-position-crash-for-text-node-expected.txt: Removed.
  • platform/chromium/accessibility/webarea-can-set-focus-expected.txt: Removed.
  • platform/chromium/accessibility/webarea-size-equals-content-size-expected.txt: Removed.
  • platform/chromium/accessibility/webkit-scrollarea-expected.txt: Removed.
  • platform/chromium/accessibility/webkit-scrollarea-position-expected.txt: Removed.
2:08 PM Changeset in webkit [139494] by tony@chromium.org
  • 4 edits
    1 add in trunk/Source

[chromium] Don't regenerate all bindings when any idl file changes
​https://bugs.webkit.org/show_bug.cgi?id=106604

Reviewed by Kentaro Hara.

Source/WebCore:

Currently, every idl file is a dependency of generating the supplemental dependency map
and generating bindings is a dependency of the map. This means that touching any idl file
causes us to regenerate all the bindings.

Change it so that generating bindings only depends on the idl files that have Supplemental= in them.
We only have 24 idl files with Supplemental (3.7% of the 638 idl files in WebCore) so modifying
any of those will cause all bindings to be regenerated.

If you add or remove a new idl file, you have to rerun gyp which will fix up any dependencies.
If you edit an existing file and add Supplemental= to it, you will now need to rerun gyp_{webkit,chromium}.
I think that's a reasonable tradeoff since it seems highly unlikely that you would adding Supplemental=
to an existing file without renaming it. The bots will always be fine because they always run
gyp after updating.

No new tests, this is a build only change.

  • WebCore.gyp/WebCore.gyp: Remove <(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp, which was causing

the full rebuild. The step to generate this file is still a hard dependency so it will still be generated and
used by generate-bindings.pl. Also remove <@(webcore_test_support_idl_files). This was saying we should regenerate
all bindings if a test idl file changed. That doesn't make sense.

  • WebCore.gyp/scripts/supplemental_idl_files.py: Added.

(DoMain):

Source/WebKit/chromium:

  • gyp_webkit: Add Source/WebCore/WebCore.gyp/scripts to the python import search path

so we can generate idl dependencies at gyp time.

2:05 PM Changeset in webkit [139493] by Alexandru Chiculita
  • 8 edits
    1 move
    7 adds
    1 delete in trunk

Element is displayed behind a composited layer when clipping is used on a previous element
​https://bugs.webkit.org/show_bug.cgi?id=104981

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayerCompositor::computeCompositingRequirements uses the local bounding box of the layers to optimize the number of composited
layers that are created. That's needed in order to make sure that composited layers that are displayed behind non-composited
layers are correctly promoting the layers in front to be composited. Otherwise the non-composited layers are rendered
in the parent composited layer, displaying behind the other composited layers. That might be wrong as the correct paint order might not be
preserved.

In order to make animations work, there's a flag that will disable that optimization. That's because the animations run in the platform
layer and the platform layer doesn't know about the layers that are not promoted to composited layers. When the overlapping of the layers
is computed it just uses the start or the stop state, but no intermediate states. For that reason, all the 'top' layers in front of animated
elements will become composited.

When an animation has a clipping rectangle, then we know for sure that the animation is going to be contained inside the clip area, so WebKit
uses the bounding box of the clipping area to detect the overlapping layers, so there's no need to disable the optimization in that case.

However, if there is a different animation displaying behind the clipping container, we cannot safely disable that optimization anymore. That's
because we still don't know what are the intermediate states of that particular animated layer. The bug was that the optimization was re-enabled
anyway, even in this particular case.

In order to fix it, I changed the logic, so that instead of re-enabling the optimization after a clipping container, it will just avoid to propagate
the internal state to the following layers when there's no need to so.

Note that 3D transforms behave like animations for now and disable the optimization. Because of that some of the existing tests ended up
creating more layers than needed. That's because the tests had an overflow area that recreated the issue that this patch fixes, but with
3D transforms instead of animations. 3D transforms will be treated in a separate patch.

Tests: compositing/layer-creation/overlap-animation-clipping.html

compositing/layer-creation/overlap-animation-container.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

Updated existing test results and added two new tests to check that animations respect the correct paint order,
even though they are painted with composited layers.

Note that there are side effects of this patch that will be corrected in a following bug. 3D layers are treated like animations, so they
disable the overlapping optimizations. Because of that, some of the test results were updated to include the layers that, previously,
were not created as a result of being in front of a "clipping container".

  • compositing/geometry/foreground-layer-expected.txt:
  • compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • compositing/layer-creation/overlap-animation-clipping.html: Added. Checking that the animation inside a clipping container is not

affecting how we compute the animations outside the clipping container.

  • compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • compositing/layer-creation/overlap-animation-container.html: Added. Checking that we don't create unnecessary composited layers for layers inside

composited containers that draw in front of animated layers.

  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/clip-descendents.html: Removed the text from the output, so that platforms can share the same expected result.
  • platform/chromium-win/compositing/overflow/clip-descendents-expected.txt: Removed. Not needed anymore, all Chromium platforms can share the same results now.
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt: Added.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
  • platform/chromium/compositing/overflow/clip-descendents-expected.txt: Renamed from LayoutTests/platform/chromium-mac/compositing/overflow/clip-descendents-expected.txt.
  • platform/qt/compositing/overflow/clip-descendents-expected.txt:
1:45 PM Changeset in webkit [139492] by schenney@chromium.org
  • 51 edits
    49 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

Mozilla test cases for linux. Also re-adding hixie/perf/006.xml, which is failing

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug137388-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Added.
  • platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/core: Added.
  • platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/dom: Added.
  • platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/other: Added.
  • platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win-xp/tables/mozilla/bugs/bug137388-2-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium/TestExpectations:
1:33 PM Changeset in webkit [139491] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Removed getDirectLocation and offsetForLocation and all their uses
​https://bugs.webkit.org/show_bug.cgi?id=106692

Reviewed by Filip Pizlo.

getDirectLocation() and its associated offsetForLocation() relied on
detailed knowledge of the rules of PropertyOffset, JSObject, and
Structure, which is a hard thing to reverse-engineer reliably. Luckily,
it wasn't needed, and all clients either wanted a true value or a
PropertyOffset. So, I refactored accordingly.

  • dfg/DFGOperations.cpp: Renamed putDirectOffset to putDirect, to clarify

that we are not putting an offset.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot): Get a value instead of a value
pointer, since we never wanted a pointer to begin with.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::resetInheritorID):
(JSC::JSObject::inheritorID):
(JSC::JSObject::removeDirect):
(JSC::JSObject::fillGetterPropertySlot):
(JSC::JSObject::getOwnPropertyDescriptor): Renamed getDirectOffset and
putDirectOffset, as explaind above. We want to use the name "getDirectOffset"
for when the thing you're getting is the offset.

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset): Changed getDirectLocation to getDirectOffset,
since clients really wants PropertyOffsets and not locations.

(JSObject::offsetForLocation): Removed this function because it was hard
to get right.

(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectUndefined):
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/JSScope.cpp:

(JSC::executeResolveOperations):
(JSC::JSScope::resolvePut):

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive): Updated for renames.

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot): Use a PropertyOffset instead of a pointer,
so we don't have to reverse-engineer the offset from the pointer.

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure): Updated for renames.

1:30 PM Changeset in webkit [139490] by schenney@chromium.org
  • 115 edits
    73 adds in trunk/LayoutTests

Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

Patch by Levi Weintraub <​leviw@chromium.org> on 2013-01-11

  • platform/chromium/TestExpectations:
1:20 PM Changeset in webkit [139489] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. r139445 triggered assertions in Skia on debug Chromium bots.
Marking them as crashing in TestExpectations.

  • platform/chromium/TestExpectations:
1:09 PM Changeset in webkit [139488] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed an unused version of getDirectLocation
​https://bugs.webkit.org/show_bug.cgi?id=106691

Reviewed by Gavin Barraclough.

getDirectLocation is a weird operation. Removing the unused version is
the easy part.

  • runtime/JSObject.h:

(JSObject):

1:08 PM Changeset in webkit [139487] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Add WTF_EXPORT_PRIVATE to printInternal() methods of PrintStream.h

Rubber stamped by Mark Hahnenberg.

This will make it easier to use dataLog() from WebCore.

  • wtf/PrintStream.h:

(WTF):

12:56 PM Changeset in webkit [139486] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Objective-C objects that are passed to JavaScript leak (until the JSContext is destroyed)
​https://bugs.webkit.org/show_bug.cgi?id=106056

Reviewed by Darin Adler.

  • API/APIJSValue.h:
  • API/JSValue.mm: Make the reference to the JSContext strong.

(-[JSValue context]):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):

  • API/JSWrapperMap.mm: Make the reference back from wrappers to Obj-C objects weak instead of strong.

Also add an explicit WeakGCMap in the JSWrapperMap rather than using Obj-C associated object API which
was causing memory leaks.
(wrapperClass):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):
(-[JSWrapperMap wrapperForObject:]):

12:31 PM Changeset in webkit [139485] by schenney@chromium.org
  • 43 edits
    35 adds in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

These are a few files that had some platforms already failing, hence
requiring special care and attention.

  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-linux-x86/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-linux-x86/fast/speech: Added.
  • platform/chromium-linux-x86/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-linux-x86/fast/transforms: Added.
  • platform/chromium-linux-x86/fast/transforms/transformed-focused-text-input-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/batik/filters: Added.
  • platform/chromium-linux-x86/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-lion/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-mac-lion/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-lion/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-mac-lion/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac-lion/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients: Added.
  • platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-win-xp/fast/speech: Added.
  • platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/filters: Added.
  • platform/chromium-win-xp/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-creation-expected.png: Added.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
  • platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium/TestExpectations:
12:23 PM Changeset in webkit [139484] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Skip CachedImage::CreateImage if we don't have image data
​https://bugs.webkit.org/show_bug.cgi?id=106156

Reviewed by Nate Chapin.

This patch skips image creation if we do not have image data. This can occur during
cache revalidation when the revalidation request (304 not modified) comes back without
any content. In this revalidation case, the http spec requires that a mimetype not be set
on the response to prevent a cached resource from having a different mimetype
from the revalidated resource. Because revalidation requests do not have a mimetype,
CachedImage::CreateImage() will fail on SVG images. This patch prevents
CachedImage::CreateImage() from being called during revalidation.

No new tests as there are no observable changes from this patch.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::data):

12:21 PM Changeset in webkit [139483] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

12:20 PM Changeset in webkit [139482] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixed some bogus PropertyOffset ASSERTs
​https://bugs.webkit.org/show_bug.cgi?id=106686

Reviewed by Gavin Barraclough.

The ASSERTs were passing a JSType instead of an inlineCapacity, due to
an incomplete refactoring.

The compiler didn't catch this because both types are int underneath.

  • runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructure): Validate against
our inline capacity, as we intended.

12:13 PM Changeset in webkit [139481] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rename propertyOffsetFor => offsetForPropertyNumber
​https://bugs.webkit.org/show_bug.cgi?id=106685

Reviewed by Gavin Barraclough.

Since the argument is just a typedef and not an object, I wanted to clarify the meaning.

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::nextOffset): Updated for rename.

  • runtime/PropertyOffset.h:

(JSC::offsetForPropertyNumber): Renamed. Also changed some PropertyOffset variables
to plain ints, because they're not actually on the PropertyOffsets number line.

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

  • runtime/Structure.h:

(JSC::Structure::lastValidOffset): Updated for rename.

12:06 PM Changeset in webkit [139480] by schenney@chromium.org
  • 131 edits
    28 adds in trunk/LayoutTests

RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
​https://bugs.webkit.org/show_bug.cgi?id=106047

Patch by Levi Weintraub <​leviw@chromium.org> on 2013-01-11
Reviewed by Simon Fraser.

  • fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
  • fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
11:59 AM Changeset in webkit [139479] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
​https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

  • fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
  • fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
11:58 AM Changeset in webkit [139478] by psolanki@apple.com
  • 2 edits in trunk/Tools

TestRunner leaks when running tests
​https://bugs.webkit.org/show_bug.cgi?id=106683

Reviewed by Simon Fraser.

Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
tests.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::makeWindowObject):

11:50 AM Changeset in webkit [139477] by andersca@apple.com
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merge r139464.

2013-01-11 Anders Carlsson <​andersca@apple.com>


Incoming synchronous messages can sometimes arrive out of order
​https://bugs.webkit.org/show_bug.cgi?id=106677
<rdar://problem/12889499>

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the "dispatch all incoming synchronous messages" phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

  • Platform/CoreIPC/Connection.cpp: (Connection::SyncMessageState): (CoreIPC::Connection::SyncMessageState::SyncMessageState): (CoreIPC::Connection::SyncMessageState::processIncomingMessage): (CoreIPC::Connection::SyncMessageState::dispatchMessages): (CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection): (CoreIPC::Connection::waitForSyncReply):
11:49 AM Changeset in webkit [139476] by kerz@chromium.org
  • 4 edits
    10 copies in branches/chromium/1364

Merge 138162

Text Autosizing: Work out what to do about form controls
​https://bugs.webkit.org/show_bug.cgi?id=102560

Patch by Tim Volodine <​timvolodine@chromium.org> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Disallow autosizing of form input controls like buttons, text input fields, selection controls, radio buttons
and check boxes. This is a short term solution to avoid inconsistent autosizing of form controls (which is
worse than not autosizing at all).

Tests: fast/text-autosizing/form-controls-autosizing-button-input-elements.html

fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html
fast/text-autosizing/form-controls-autosizing-radio-input-element.html
fast/text-autosizing/form-controls-autosizing-select-element.html
fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html

  • rendering/TextAutosizer.cpp:

(WebCore):
(WebCore::formInputTags):
(WebCore::TextAutosizer::isAutosizingContainer):
(WebCore::TextAutosizer::contentHeightIsConstrained):
(WebCore::TextAutosizer::containerShouldBeAutosized):
(WebCore::TextAutosizer::containerContainsOneOfTags):

  • rendering/TextAutosizer.h:

LayoutTests:

Tests for form input elements autosizing. Added tests to check that various kinds of form elements
don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus.

  • fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added.
  • fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added.
  • fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added.
  • fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-select-element.html: Added.
  • fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html: Added.
  • fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11858022

11:46 AM Changeset in webkit [139475] by schenney@chromium.org
  • 575 edits
    111 adds in trunk/LayoutTests

[Chromium] Mac editing test rebaseline

Unreviewed expectations update.

For whatever reason Mac 10.6 and 10.7 use Skia for drawing edit boxes.
They all needed rebaselining.

  • platform/chromium-mac-lion/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-lion/editing/deleting/non-smart-delete-expected.png:
  • platform/chromium-mac-lion/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-lion/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/print-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-lion/editing/execCommand/selectAll-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-lion/editing/inserting/12882-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-lion/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-lion/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-lion/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3778059-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-after-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-div-026-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-space-in-empty-doc-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-mac-lion/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-lion/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-lion/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-lion/editing/inserting/redo-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-002-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-003-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-mac-lion/editing/inserting/typing-around-image-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-4038267-fix-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-004-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-005-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-009-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-line-endings-010-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-match-style-002-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-007-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-lion/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-lion/editing/selection/13804-expected.png:
  • platform/chromium-mac-lion/editing/selection/4818145-expected.png:
  • platform/chromium-mac-lion/editing/selection/4866671-expected.png:
  • platform/chromium-mac-lion/editing/selection/4889598-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/4947387-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5007143-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5057506-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5099303-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/6476-expected.png:
  • platform/chromium-mac-lion/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-lion/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-lion/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-lion/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-lion/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-lion/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-lion/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-lion/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-character-006-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-lion/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-lion/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-lion/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-character-6-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-line-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-lion/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac-lion/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-lion/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-lion/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-lion/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-lion/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-lion/editing/style/4916887-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-lion/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-lion/editing/style/5065910-expected.png:
  • platform/chromium-mac-lion/editing/style/5084241-expected.png:
  • platform/chromium-mac-lion/editing/style/5228141-expected.png:
  • platform/chromium-mac-lion/editing/style/5279521-expected.png:
  • platform/chromium-mac-lion/editing/style/block-styles-007-expected.png:
  • platform/chromium-mac-lion/editing/style/highlight-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-001-expected.png:
  • platform/chromium-mac-lion/editing/style/smoosh-styles-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3681552-fix-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-3998892-fix-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-001-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-002-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-003-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-004-expected.png:
  • platform/chromium-mac-lion/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-001-expected.png:
  • platform/chromium-mac-lion/editing/style/typing-style-002-expected.png:
  • platform/chromium-mac-lion/editing/style/unbold-in-bold-expected.png:
  • platform/chromium-mac-lion/editing/undo/4063751-expected.png:
  • platform/chromium-mac-lion/editing/undo/5378473-expected.png: Added.
  • platform/chromium-mac-lion/editing/undo/redo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-combined-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-boundary-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-forward-delete-expected.png:
  • platform/chromium-mac-lion/editing/undo/undo-misspellings-expected.png: Added.
  • platform/chromium-mac-lion/editing/undo/undo-typing-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-lion/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-different-styles-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-no-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/type-delete-after-quote-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5481523-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-empty-root-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/indent-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/insertImage-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-indent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/print-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/remove-list-item-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/execCommand/selectAll-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4278698-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4840662-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4875189-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4959067-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/4960120-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5002441-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5058163-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5156401-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5510537-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/5549929-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/6703873-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/edited-whitespace-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3775316-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3778059-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-3800346-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-after-delete-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-at-end-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-at-tabspan-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-br-quoted-006-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-div-026-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-04-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-05-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/insert-space-in-empty-doc-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-at-tabspan-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/line-break-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/multiple-lines-selected-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/redo-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-around-image-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/3976872-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4076267-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4631972-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4947130-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5006779-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5032095-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5071074-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5075944-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5134759-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5156401-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5387578-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5478250-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/8145-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/bad-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-generic-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/displaced-placeholder-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-borders-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/merge-start-list-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-4035648-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-4038267-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-line-endings-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-match-style-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-match-style-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-at-tabspan-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-object-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/quirks-mode-br-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-drag-drop-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/styled-element-markup-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/unrendered-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4818145-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4866671-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4889598-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4932260-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4947387-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5007143-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5057506-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5076323-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5131716-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5195166-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/6476-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/after-line-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contains-boundaries-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/contenteditable-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/editable-non-editable-crash-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/end-of-document-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-character-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/image-before-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-6-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-7-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-8-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/mixed-editability-9-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-between-blocks-no-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-character-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-line-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-past-trailing-space-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/previous-line-position-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replace-selection-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-all-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-missing-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/selection-3748164-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-004-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/unrendered-space-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/4916887-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5017613-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5065910-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5084241-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5228141-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/5279521-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/highlight-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/smoosh-styles-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/smoosh-styles-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-3681552-fix-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-3681552-fix-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-3998892-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/style-boundary-005-expected.png:
  • platform/chromium-mac-snowleopard/editing/style/typing-style-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/typing-style-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/unbold-in-bold-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/4063751-expected.png:
  • platform/chromium-mac-snowleopard/editing/undo/5378473-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/redo-typing-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-combined-delete-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-combined-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-delete-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-forward-delete-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-forward-delete-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-misspellings-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/undo/undo-typing-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/list-type-before-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png:
  • platform/chromium-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png:
  • platform/chromium/TestExpectations:
11:45 AM Changeset in webkit [139474] by kerz@chromium.org
  • 11 edits in branches/chromium/1364

Merge 139435

Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
​https://bugs.webkit.org/show_bug.cgi?id=105188

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-01-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Some blocks of text might be narrower than their parent clusters and should be autosized separately.
This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
the main content being positioned atop this margin (or vice versa).

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isContainerAutosizingCluster):

Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
ancestor of all the text nodes.

LayoutTests:

Checked that a narrow autosizing container becomes an autosizing cluster.
Fixed other tests that used narrow descendant blocks.

  • fast/text-autosizing/cluster-narrow-in-wide-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
  • fast/text-autosizing/cluster-narrow-in-wide.html:
  • fast/text-autosizing/cluster-with-wide-lca-expected.html:
  • fast/text-autosizing/cluster-with-wide-lca.html:
  • fast/text-autosizing/narrow-child-expected.html:
  • fast/text-autosizing/narrow-child.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11864024

11:43 AM Changeset in webkit [139473] by kerz@chromium.org
  • 10 edits in branches/chromium/1364

Merge 138111

Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
​https://bugs.webkit.org/show_bug.cgi?id=103627

Patch by Anton Vayvod <​avayvod@chromium.org> on 2012-12-18
Reviewed by Julien Chaffraix.

Source/WebCore:

Some blocks of texts might be wider than their parent clusters and need to be autosized separately.

isAutosizingCluster() now checks for the width of the container being greater than the width of the lowest
common ancestor of the text nodes of the enclosing cluster. This block containing all text is passed to all
tree traversal methods.
An overloaded version is added for cases when we don't have the lowest common ancestor yet.

The change fixes several cases covered by existing tests.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Calls processCluster with a new number of arguments.

(WebCore::TextAutosizer::processCluster):

Passes block containing all text nodes into processContainer. Assertion removed since it can no longer be
checked without passing an additional parameter (the parent block containing all text) to the function
for the sake of this assertion only.

(WebCore::TextAutosizer::processContainer):

|parentBlockContainingAllText| parameter passed into isAutosizingCluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderBlock*, const RenderBlock*)):

The overloaded method that is used when the render block checked is already known to be an autosizing
container and there's full information necessary to determine if it's a cluster like the parent block
containing all text within the enclosing cluster.
Considers a block a cluster if it is wider than its parent block containing all text within enclosing
cluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderObject*)):

The overloaded method that checks for the given object to be an autosizing container first (for
convenience of the caller) and doesn't require information about the parent cluster. Used when such
information is not available, for example, in the process of retrieving the information for the parent
cluster or when looking for the root cluster in the tree.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

Passes new parameter to measureDescendantTextWidth.

(WebCore::TextAutosizer::measureDescendantTextWidth):

Uses blockContainingAllText parameter to pass to isAutosizingCluster.

(WebCore::TextAutosizer::findDeepestBlockContainingAllText):

Assertion removed since it can no longer be checked without passing an additional parameter (the
parent block containing all text) to the function for the sake of this assertion only.

(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):

Uses shorter isAutosizingCluster call.

LayoutTests:

Modified existing tests to reflect the new autosizing approach to handling of the elements that are
wider than the lowest common ancestor of the text nodes of the enclosing autosizing cluster.

  • fast/text-autosizing/cluster-wide-in-narrow-expected.html:
  • fast/text-autosizing/cluster-wide-in-narrow.html:
  • fast/text-autosizing/wide-child-expected.html:
  • fast/text-autosizing/wide-child.html:
  • fast/text-autosizing/wide-in-narrow-overflow-scroll-expected.html:
  • fast/text-autosizing/wide-in-narrow-overflow-scroll.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11859014

11:41 AM Changeset in webkit [139472] by kerz@chromium.org
  • 8 edits in branches/chromium/1364/Source

Merge 139356

Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
​https://bugs.webkit.org/show_bug.cgi?id=106460

Patch by John Mellor <​johnme@chromium.org> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

screen.width, window.outerWidth and @media device-width should be in
density independent (UI) pixels, not physical screen pixels.

This already works on most ports (including iOS). However Chrome for
Android currently internally sizes its windows in physical screen pixels
instead of density independent pixels, and this leaks through in the
sizes provided to WebCore.

This patch scales these sizes appropriately before they reach JavaScript,
on platforms where the applyPageScaleFactorInCompositor setting is false
(i.e. just Chrome for Android). Once Chrome for Android switches over to
the same coordinate space, the applyPageScaleFactorInCompositor setting
will be removed, along with any code (such as this) that depends on it.

The effect of this patch on Chrome for Android when viewing a page with
a width=device-width viewport on a Galaxy Nexus (720x1280 @ dPR 2) is:

@media device-width changes from 720 to 360
screen.width changes from 720 to 360
screen.availWidth changes from 720 to 360
window.outerWidth changes from 720 to 360
window.innerWidth remains 360 (at overview zoom)
@media width remains 360
document.documentElement.clientWidth remains 360
document.documentElement.offsetWidth remains 360
document.documentElement.scrollWidth remains 360
document.body.clientWidth remains 360
document.body.offsetWidth remains 360
document.body.scrollWidth remains 360

And similarly for heights (though they are slightly less than 640, since
toolbars etc. get subtracted from the available height).

No new tests, as applyDeviceScaleFactorInCompositor appears to always be
true in DumpRenderTree, so this situation cannot occur there.

  • page/Settings.in:

Added applyDeviceScaleFactorInCompositor setting, which allows
detecting whether we need to normalize the scale.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toUserSpace):

Static function for normalizing screen rect scale.

(WebCore::screenRect):

Uses toUserSpace.

(WebCore::screenAvailableRect):

Uses toUserSpace.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Use applyDeviceScaleFactorInCompositor instead of
applyPageScaleFactorInCompositor, to scale the window rect correctly
on platforms other than Chrome for Android.

Source/WebKit/chromium:

  1. Exposes the existing applyDeviceScaleFactorInCompositor from

WebSettings on Settings (and stores the value there instead), so it can
be accessed from WebCore.

  1. Changes ChromeClientImpl::windowRect to return values in density

independent (UI) pixels pixels instead of physical screen pixels (see
explanation in Source/WebCore/ChangeLog).

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

Normalizes window rect scale.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11862015

11:39 AM Changeset in webkit [139471] by jparent@chromium.org
  • 4 edits in trunk/Tools

Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
​https://bugs.webkit.org/show_bug.cgi?id=106247

Old code nulled out the loader instance when it completed loading and
then later used the fact that it was null to determine if it had loaded
or not. This is not only unintuitive, but it also prevents using the
loader object later on.

Added new method, used it, added unit test for it.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(resourceLoadingComplete):
(handleLocationChange):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
11:35 AM Changeset in webkit [139470] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::RenderText::computePreferredLogicalWidths
​https://bugs.webkit.org/show_bug.cgi?id=95901

Reviewed by Simon Fraser.

Prevent re-entrancy of view layout. Loading of SVG document during font load
causes it to re-enter layout and blowing the style away from underneath.

Test: Go to ​http://www.speckproducts.com and make sure crash does not happen.

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

11:27 AM Changeset in webkit [139469] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Do not create a local handle for a cached v8 string that is returned to V8 immediately
​https://bugs.webkit.org/show_bug.cgi?id=106557

Reviewed by Adam Barth.

Currently we are always creating a local handle for a cached
V8 string returned to V8:

Handle<Value> v8String(StringImpl* impl, Isolate* isolate) {

...;
return Local<String>::New(isolate, m_cachedString);

}

However, we don't need to create a local handle in a case
where it is guaranteed that no V8 object allocation is conducted
before a control flow returns back to V8. In particular, in a case
where a cached V8 string is immediately returned to V8, we don't
need to create a local handle:

Handle<Value> xxxxAttrGetter() {

...;
return v8String(imp->xxxx(), isolate); This can return a persistent handle safely.

}

This patch improves performance of div.id by 9.2%.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

  • bindings/v8/V8Binding.h:

(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

  • bindings/v8/V8ValueCache.h:

(WebCore::StringCache::v8ExternalString):
(StringCache):

11:21 AM Changeset in webkit [139468] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking platform/chromium/virtual/gpu/fast/hidpi/image-set-background-dynamic.html
as slow on Debug builds.

  • platform/chromium/TestExpectations:
11:20 AM Changeset in webkit [139467] by schenney@chromium.org
  • 94 edits
    62 adds in trunk/LayoutTests

[ Chromium ] New Mac rebaselines (some)

Unreviewed expectatiosn update after skia changes.

These are some of the Mac fixes, but mostly it addresses the issues
with TestExpectations, so hopefully we'll get green builds.

  • platform/chromium-mac-lion/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-lion/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-lion/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-3608462-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-4083333-fix-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-006-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-007-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-character-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-003-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-image-004-expected.png: Added.
  • platform/chromium-mac-lion/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-listitem-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-selection-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-001-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-mac-lion/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/4922367-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5126166-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5144139-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5206311-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5272440-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5369009-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5433862-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/5483370-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3608445-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-3608462-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-4083333-fix-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-br-013-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-character-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-first-list-item-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-hr-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-image-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-leading-ws-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-015-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-016-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-017-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-mac-snowleopard/editing/deleting/delete-listitem-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-listitem-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-selection-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-win-xp/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium/TestExpectations:
11:14 AM Changeset in webkit [139466] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.4 release

.:

  • configure.ac: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.11.4.
11:11 AM Changeset in webkit [139465] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header files.
11:08 AM Changeset in webkit [139464] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Incoming synchronous messages can sometimes arrive out of order
​https://bugs.webkit.org/show_bug.cgi?id=106677
<rdar://problem/12889499>

Reviewed by Andreas Kling.

In cases where synchronous messages come in more than one connection at the same time, we can sometimes deliver
the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering.

Fix this by separating the "dispatch all incoming synchronous messages" phase out into multiple phases, so we'll
schedule one call per connection instead of one call for all connections.

  • Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::SyncMessageState::dispatchMessageAndResetDidScheduleDispatchMessagesForConnection):
(CoreIPC::Connection::waitForSyncReply):

11:07 AM Changeset in webkit [139463] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skipping accessibility/corresponding-control-deleted-crash.html on Mac since
it fails without Shadow DOM enabled.

  • platform/mac/TestExpectations:
10:59 AM Changeset in webkit [139462] by leviw@chromium.org
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139346

ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
​https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore:

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests:

  • platform/chromium/fast/events/touch/resources: Added.
  • platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/11865013

10:57 AM Changeset in webkit [139461] by wangxianzhu@chromium.org
  • 10 edits
    4 adds in trunk

RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers
​https://bugs.webkit.org/show_bug.cgi?id=105652

Reviewed by Simon Fraser.

Source/WebCore:

Let ScrollingCoordinator know the change of ViewportConstrainedNotCompositedReason in time.
By the way moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to RenderLayer::ViewportConstrainedNotCompositedReason.

Tests: compositing/layer-creation/fixed-position-in-view-dynamic.html

compositing/layer-creation/fixed-position-out-of-view-dynamic.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasonsAsText):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintViewportConstrainedObjects):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::logThreadedScrollingMode):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayer.h:

(RenderLayer): Moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to here and renamed it to ViewportConstrainedNotCompositedReason.
(WebCore::RenderLayer::setViewportConstrainedNotCompositedReason):
(WebCore::RenderLayer::viewportConstrainedNotCompositedReason):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBacking): Now updates ViewportConstrainedNotCompositedReason here instead of in computeCompositingRequirements before so that the reason is updated in time.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::reasonForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::reportMemoryUsage):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

LayoutTests:

Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree.

  • compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
  • compositing/layer-creation/fixed-position-in-view-dynamic.html: Added.
  • compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added.
  • compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added.
10:39 AM Changeset in webkit [139460] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Try CRLF to LF change in r139407 again.

  • BuildSlaveSupport/delete-stale-build-files:

(main):
(webkitBuildDirectory):

  • BuildSlaveSupport/kill-old-processes:

(main):

10:39 AM Changeset in webkit [139459] by kbr@google.com
  • 5 edits in trunk

[Chromium] WebGL typed array constructor crashes on exception
​https://bugs.webkit.org/show_bug.cgi?id=106308

Reviewed by Kentaro Hara.

Source/WebCore:

Check for empty handles (indicating exception thrown) after calls
into V8 VM.

Added new case from Khronos typed array conformance tests to
fast/canvas/webgl/array-unit-tests.html.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

Check for empty handles after calls into V8 VM.

LayoutTests:

Updated typed array tests to latest version from Khronos repository.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
10:37 AM Changeset in webkit [139458] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Slightly optimize getWrapperFast()
​https://bugs.webkit.org/show_bug.cgi?id=106667

Reviewed by Adam Barth.

This patch improves an if condition in getWrapperFast(),
as commented in DOMDataStore.h.

This patch improves performance of div.firstChild from
15.1 ns to 14.0 ns (+7.8%), although I couldn't observe
performance improvement in Dromaeo/dom-traverse.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperFast):

10:10 AM Changeset in webkit [139457] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

[SVG] Suppress resource rebuilding for unattached and shadow elements
​https://bugs.webkit.org/show_bug.cgi?id=106664

Reviewed by Dirk Schulze.

Source/WebCore:

SVGStyledElement::buildPendingResourcesIfNeeded() can be called while cloning a subtree
(as nodes are inserted into the clone, while still detached) or when elements are inserted
into the shadow tree. Both of these cases are problematic for SVGUseElement and can trigger
indirect recursion in SVGUseElement::buildPendingResource.

Since shadow and !inDocument() nodes are of no interest to ID dependents (they cannot be
found by ID in the document), the patch short-circuits buildPendingResource() for these
cases.

Test: svg/custom/use-rebuild-resources-crash.svg

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):

LayoutTests:

  • svg/custom/use-rebuild-resources-crash-expected.txt: Added.
  • svg/custom/use-rebuild-resources-crash.svg: Added.
10:06 AM Changeset in webkit [139456] by dmazzoni@google.com
  • 9 edits in trunk

AX: Computed hierarchical level is not consistent with aria-level
​https://bugs.webkit.org/show_bug.cgi?id=106638

Reviewed by Chris Fleizach.

Source/WebCore:

Make hierarchicalLevel computation 1-based to match the aria-level spec.

Extends an existing test: platform/mac/accessibility/aria-tree.html.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::hierarchicalLevel):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Extend aria-tree.html to check the hierarchicalLevel automatically
computed when aria-level is not provided. Make sure they're consistent.
Now, the mac disclosureLevel will be one less than the web aria-level.

  • platform/mac/accessibility/aria-tree-expected.txt:
  • platform/mac/accessibility/aria-tree.html:
  • platform/mac/accessibility/aria-treegrid-expected.txt:
  • platform/mac/accessibility/aria-treegrid.html:
9:48 AM Changeset in webkit [139455] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

These are still failing, not sure why as some of them are already in expectations.
Test lint passes.

  • platform/chromium/TestExpectations:
9:31 AM Changeset in webkit [139454] by vsevik@chromium.org
  • 41 edits
    1 add in trunk

Web Inspector: Workspace should support several projects and should not have temporary UISourceCodes.
​https://bugs.webkit.org/show_bug.cgi?id=105856

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace now supports several projects with the networkProject being a main one.
Replaced temporary UISourceCodes with specific projects (debugger and liveedit).
The concept of workspace reset on navigation is now replaced with project reset concept instead.
Introduced snippets project (that is not reset on navigation).
Script mappings are now reset on GlobalObjectCleared event.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._innerSetBreakpoint):
(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.toggleAllBreakpoints):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._inspectedURLChanged):
(WebInspector.CSSStyleModel.prototype._resetSourceMappings):
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResourceURL):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype._debuggerReset):

  • inspector/front-end/DebuggerScriptMapping.js:
  • inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DefaultScriptMapping.prototype._debuggerReset):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetPageResources):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.show):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditSupport.prototype._debuggerReset):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._mainFrameNavigated):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptMapping.prototype._debuggerReset):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._projectWillReset):

  • inspector/front-end/SASSSourceMapping.js:

(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.reset):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._removeUISourceCodes):
(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
(WebInspector.ScriptsPanel.prototype._debuggerReset):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.project):

  • inspector/front-end/Workspace.js:

(WebInspector.WorkspaceController):
(WebInspector.WorkspaceController.prototype._inspectedURLChanged):
(WebInspector.Project):
(WebInspector.Project.prototype.name):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Project.prototype._reset):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.project):
(WebInspector.Workspace.prototype.projects):
(WebInspector.Workspace.prototype.uiSourceCodes):
(WebInspector.Workspace.prototype.projectForUISourceCode):
(WebInspector.Workspace.prototype.requestFileContent):
(WebInspector.Workspace.prototype.setFileContent):
(WebInspector.Workspace.prototype.searchInFileContent):

  • inspector/front-end/inspector.js:
  • inspector/front-end/utilities.js:

LayoutTests:

  • http/tests/inspector-enabled/dynamic-scripts.html:
  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-scripts.html:
  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/debugger/resource-script-mapping-expected.txt:
  • inspector/debugger/resource-script-mapping.html:
  • inspector/debugger/resources/edit-me-breakpoints.js: Added.

(f):

  • inspector/debugger/script-snippet-model-expected.txt:
  • inspector/debugger/script-snippet-model.html:
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/watch-expressions-preserve-expansion-expected.txt:
  • inspector/debugger/watch-expressions-preserve-expansion.html:
  • inspector/uisourcecode-revisions.html:
9:28 AM Changeset in webkit [139453] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Disable the unit tests timeout when running from make check
​https://bugs.webkit.org/show_bug.cgi?id=106670

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-01-11
Reviewed by Philippe Normand.

  • GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
9:09 AM Changeset in webkit [139452] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Resources] Make grid columns set configurable.
​https://bugs.webkit.org/show_bug.cgi?id=105739

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-11
Reviewed by Pavel Feldman.

Added context menu on grid header to hide/show grid columns.
Hidden columns set is persisted.

  • inspector/front-end/DataGrid.js:

Fixed show/hide behavior, introduced weight control.

  • inspector/front-end/NetworkPanel.js:

Added member to track visibility of columns in detailerd mode. Added
context menu for grid header.

9:08 AM Changeset in webkit [139451] by sudarsana.nagineni@linux.intel.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening.

Remove unnecessary platform expectations for now-passing test.

  • platform/efl/media/video-controls-captions-expected.txt: Removed.
8:56 AM Changeset in webkit [139450] by fmalita@chromium.org
  • 41 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after ​http://trac.webkit.org/changeset/139238.

  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-wide-border-05-expected.png:
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-win/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-win/fast/borders/border-radius-wide-border-05-expected.png:
  • platform/chromium-win/fast/borders/border-styles-split-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium/TestExpectations:
8:49 AM Changeset in webkit [139449] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Yet another unreviewed fix after r139431.

  • Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in

the correct order.

8:39 AM Changeset in webkit [139448] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test Expectations update after Skia flag changes.

Unreviewed test expectations update.

Apparently, we use Skia to draw some forms on Mac and Win, causing
failures not seen on Linux.

  • platform/chromium/TestExpectations:
8:34 AM Changeset in webkit [139447] by rjkroege@chromium.org
  • 1 edit
    2 deletes in branches/chromium/1364

Merge 139339

Manually revert ​http://trac.webkit.org/changeset/136012
​https://bugs.webkit.org/show_bug.cgi?id=106580

Reviewed by Dimitri Glazkov.

Source/WebCore:

136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
to work around conflicts.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

  • fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.

TBR=​rjkroege@chromium.org

7:55 AM Changeset in webkit [139446] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the build if libxslt is not available but libxml2 is
​https://bugs.webkit.org/show_bug.cgi?id=106661

Reviewed by Simon Hausmann.

On Linux building the xml parser sources fails if the needed libxslt
dependencies are not installed but libxml2 is.

  • WebCore.pri: add libxml2 to pkg-config if not on mac.
7:41 AM Changeset in webkit [139445] by schenney@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: Removing Skia flags that have been disabling oprtimizations and other improvements.

Unreviewed build fix.

These changes have been extensively tested by the Skia team, and
WebKit test result changes will be monitored.

  • skia_webkit.gyp:

LayoutTests: Unreviewed test expectations update.

All of the tests will be rebaselined by end of day.

  • platform/chromium/TestExpectations: Mark tests affected by Skia flag changes as expected to fail.
7:35 AM Changeset in webkit [139444] by schenney@chromium.org
  • 3 edits
    2 adds in trunk

Objects can be re-added to the AXObjectCache during removal
​https://bugs.webkit.org/show_bug.cgi?id=104171

Source/WebCore:

The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.

The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.

Reviewed by Simon Fraser.

Test: accessibility/corresponding-control-deleted-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.

LayoutTests:

Reviewed by Simon Fraser.

New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.

  • accessibility/corresponding-control-deleted-crash-expected.txt: Added.
  • accessibility/corresponding-control-deleted-crash.html: Added.
7:33 AM Changeset in webkit [139443] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

[chromium] move some whitespace and resize related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106655

Patch by Dan Carney <​dcarney@google.com> on 2013-01-11
Reviewed by Jochen Eisinger.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::setClientWindowRect):
(WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
(WebTestRunner::TestRunner::enableAutoResizeMode):
(WebTestRunner::TestRunner::disableAutoResizeMode):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setClientWindowRect):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

7:33 AM Changeset in webkit [139442] by vsevik@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebCore/inspector/front-end

Merge 138481

Unreviewed, rolling out r137905.
​http://trac.webkit.org/changeset/137905
​https://bugs.webkit.org/show_bug.cgi?id=105765

Popover does not disappear when hovering another identifier in
sources panel. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-12-26

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

  • inspector/front-end/popover.css:

(.popover):

TBR=​commit-queue@webkit.org
BUG=167597
Review URL: ​https://codereview.chromium.org/11860010

7:31 AM Changeset in webkit [139441] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my e-mail addresses.

  • Scripts/webkitpy/common/config/committers.py:
7:03 AM Changeset in webkit [139440] by dominicc@chromium.org
  • 1 edit
    3 copies in branches/chromium/1364

Merge 139256

border-radius with box-shadow is not rendered correctly
​https://bugs.webkit.org/show_bug.cgi?id=106404

Reviewed by Hajime Morita.

Source/WebCore:

RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
is invoked for renderable RoundedRects.

Test: fast/borders/border-radius-with-box-shadow.html

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::isRenderable):
Have to compare topLeft's height plus bottomLeft's height with
rect's height and to compare topRight's height plus bottomRight's
height with rect's height.

LayoutTests:

  • fast/borders/border-radius-with-box-shadow-expected.txt: Added.
  • fast/borders/border-radius-with-box-shadow.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.

TBR=​tasak@google.com

6:43 AM Changeset in webkit [139439] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip new failing tests introduced in r139330 since
ENABLE_CSS_FILTERS flag is not enabled on EFL port.

  • platform/efl/TestExpectations:
6:40 AM Changeset in webkit [139438] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Another unreviewed fix after r139431.

In a way, this is also a generic bug fix, since previously isEfl()
would fail when called from run-efl-tests and we thus did not use
jhbuild to run our tests. This now resulted in us calling
"jhbuild-wrapper run" without specifying a platform.

  • Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()

to work.

6:37 AM Changeset in webkit [139437] by allan.jensen@digia.com
  • 13 edits in trunk

[Qt][WK1] Web Audio support
​https://bugs.webkit.org/show_bug.cgi?id=106651

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Convert JavaScript Uint8Array to QByteArray. This conversion is necessary to support testRunner.setAudioData().

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::isJSUint8Array):
(Bindings):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

Source/WebKit/qt:

Expose setting to enable WebAudio at runtime.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:

Tools:

Implements support for dumping audio data in DumpRenderTree.

Adds WebAudio to toggleable features in QtTestBrowser.

Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):
(TestRunner::overridePreference):
(TestRunner::setAudioData):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner::shouldDumpAsAudio):
(TestRunner::audioData):
(TestRunner):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::applyPrefs):
(LauncherWindow::createChrome):
(LauncherWindow::toggleWebAudio):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/features.pri:
6:34 AM Changeset in webkit [139436] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Build fix for the GTK debug builds of WebKit2 after r139415.

  • WebProcess/gtk/WebGtkExtensionManager.cpp:
5:56 AM Changeset in webkit [139435] by commit-queue@webkit.org
  • 11 edits in trunk

Text Autosizing - elements much narrower than its parent autosizing clusters should be autosized separately.
​https://bugs.webkit.org/show_bug.cgi?id=105188

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-01-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Some blocks of text might be narrower than their parent clusters and should be autosized separately.
This helps with autosizing for the pages implementing the sidebars as a narrow blocks of text with wide margins and
the main content being positioned atop this margin (or vice versa).

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isContainerAutosizingCluster):

Returns true if the container is more than 200 pixels narrower than its parent cluster's lowest common
ancestor of all the text nodes.

LayoutTests:

Checked that a narrow autosizing container becomes an autosizing cluster.
Fixed other tests that used narrow descendant blocks.

  • fast/text-autosizing/cluster-narrow-in-wide-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden-expected.html:
  • fast/text-autosizing/cluster-narrow-in-wide-ohidden.html:
  • fast/text-autosizing/cluster-narrow-in-wide.html:
  • fast/text-autosizing/cluster-with-wide-lca-expected.html:
  • fast/text-autosizing/cluster-with-wide-lca.html:
  • fast/text-autosizing/narrow-child-expected.html:
  • fast/text-autosizing/narrow-child.html:
5:28 AM Changeset in webkit [139434] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed jhbuild-related fix after r139431.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init): Pass a string to set_option_default(), since
shlex.split() will be called on it later.

5:18 AM Changeset in webkit [139433] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed typo fixes after r139431.

  • Scripts/run-javascriptcore-tests:
4:58 AM Changeset in webkit [139432] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused CSSSelector(QualifiedName) constructor.
<​http://webkit.org/b/106652>

Reviewed by Antti Koivisto.

  • css/CSSSelector.h:

(CSSSelector):

4:50 AM Changeset in webkit [139431] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk/Tools

[jhbuild] Remove the "run-with-jhbuild" scripts.
​https://bugs.webkit.org/show_bug.cgi?id=106572

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-01-11
Reviewed by Martin Robinson.

Both ports which use jhbuild were mostly duplicating the
`run-with-jhbuild' script in their own directories for no clear reason.

The script itself was just a thin wrapper around the `jhbuild-wrapper',
so just start using that directly and get rid of a useless middle man.

Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
instead.

  • Scripts/run-javascriptcore-tests:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(buildAutotoolsProject):
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • Scripts/webkitpy/common/multiprocessing_bootstrap.py:

(run):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.init):
(EflPort._image_diff_command):

  • efl/run-with-jhbuild: Removed.
  • gtk/run-with-jhbuild: Removed.
4:43 AM Changeset in webkit [139430] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Disable the ENABLE_LEGACY_WEB_AUDIO feature define in release builds
​https://bugs.webkit.org/show_bug.cgi?id=106577

Reviewed by Philippe Normand.

The Web Audio feature is not enabled in the release builds, so there's
no need to enable the legacy Web Audio API either.

No new tests - no new functionality.

  • GNUmakefile.features.am.in:
4:28 AM Changeset in webkit [139429] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Web Inspector: Option+Click on Node Expander Doesn't Work the First Time
​https://bugs.webkit.org/show_bug.cgi?id=66868

Source/WebCore:

Up to now, the TreeElement.prototype.expandRecursively() method would correctly
expand children recursively based on the provided depth, but would not wait to
perform this task until all child nodes had been populated, which means that this
would only work incrementally with one additional level of child nodes being shown
expanded in the DOM tree upon alt+clicking a given node with a deep hierarchy.

In order to fix this, this patch adds a new optional argument to the DOMAgent's
requestChildNodes() methods to provide the depth at which we want to retrieve children
of a given node. The DOMAgent provides a new .getSubtree() method that calls
requestChildNodes() with the provided depth.

Then in ElementsTreeOutline, we subclass .expandRecursively() to first call DOMAgent's
new .getSubtree() method and then call the default implementation when all nodes
have been retrieved from the backend.

Patch by Antoine Quint <Antoine Quint> on 2013-01-11
Reviewed by Pavel Feldman.

Tests: inspector-protocol/dom-request-child-nodes-depth.html

inspector/elements/expand-recursively.html

  • inspector/Inspector.json: Add the new depth parameter to DOM.requestChildNodes().
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushChildNodesToFrontend): Add a new optional depth parameter
which defaults to 1.
(WebCore::InspectorDOMAgent::requestChildNodes): Add a new optional depth parameter
which defaults to 1 and allows -1 as an unbound value.

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.):
(WebInspector.DOMNode.prototype.getSubtree): New method allowing to specify at what depth
we want to retrieve children of a given node from the backend.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.expandRecursively): Override default implementation
to first obtain the deepest subtree for the current node so that deep expansion happens as expected.

LayoutTests:

Adding a new protocol test that covers the new depth parameter for the
requestChildNodes method and a new front-end method that tests correct
behavior of the expandRecursively() method.

Patch by Antoine Quint <Antoine Quint> on 2013-01-11
Reviewed by Pavel Feldman.

  • inspector-protocol/dom-request-child-nodes-depth-expected.txt: Added.
  • inspector-protocol/dom-request-child-nodes-depth.html: Added.
  • inspector/elements/expand-recursively-expected.txt: Added.
  • inspector/elements/expand-recursively.html: Added.
4:26 AM Changeset in webkit [139428] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Remove support for global extensions in WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=106646

Reviewed by Xan Lopez.

We have now API to set the web extensions directory. A global web
estensions directory doesn't make sense anymore.

  • WebProcess/gtk/WebGtkExtensionManager.cpp:

(WebKit::WebGtkExtensionManager::scanModules): Only scan the given
directory for modules.
(WebKit::WebGtkExtensionManager::initialize): Load modules found
in the given directory only.

  • WebProcess/gtk/WebGtkExtensionManager.h:

(WebGtkExtensionManager): Remove appendModuleDirectories().

4:15 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
web extensions done (diff)
4:09 AM Changeset in webkit [139427] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Elements] Search in the DOM tree does not scroll horizontally
​https://bugs.webkit.org/show_bug.cgi?id=106648

Reviewed by Vsevolod Vlasov.

Scroll into view the first match in every tree element, if needed.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):

3:59 AM Changeset in webkit [139426] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] a minor follow-up to r137262
​https://bugs.webkit.org/show_bug.cgi?id=106644

Reviewed by Pavel Feldman.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

3:44 AM Changeset in webkit [139425] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Add ImageOnlyFailure for fast/css/font-face-unicode-range.html on win
​https://bugs.webkit.org/show_bug.cgi?id=100806

Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:24 AM Changeset in webkit [139424] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

BaseDateAndTimeInputType should not inherit from TextFieldInputType
​https://bugs.webkit.org/show_bug.cgi?id=106306

Reviewed by Hajime Morita.

Date/time input types don't need text-field features at all.

No new tests. This should not make any behavior changes except reduction
of memory usage.

  • html/BaseDateAndTimeInputType.h:

Inherit InputType instead of TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
(BaseDateAndTimeInputType): Update function declarations.

  • html/BaseDateAndTimeInputType.cpp:

Remove handleKeydownEvent and convertFromVisibleValue, which are for
TextFieldInputType.
(WebCore::BaseDateAndTimeInputType::shouldRespectListAttribute):
Added. This is necessary for <datalist> support. TextFieldInputType has
the same code.
(WebCore::BaseDateAndTimeInputType::valueMissing):
Added. This is necessary for validity.valueMissing. TextFieldInputType
has the same code.

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

Remove unnecessary functions which cancel TextFieldInputType behavior.

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(BaseChooserOnlyDateAndTimeInputType): Remove declarations for them.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

Remove unnecessary functions which cancel TextFieldInputType behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Add SpinButtonOwner interface. We didn't need it because
TextFieldInputType implements it.

3:12 AM Changeset in webkit [139423] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Enable concatenating headers with same field name
​https://bugs.webkit.org/show_bug.cgi?id=106625

Reviewed by Rob Buis.

RFC 2616 specifies that headers could concatenate with comma if they have
same field name. We should enable this if the header allows multiple values.

RIM PR# 275508, internally reviewed by Joe Mason

(WebCore):
(WebCore::isAppendableHeader):
(WebCore::NetworkJob::handleNotifyHeaderReceived):

2:31 AM Changeset in webkit [139422] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_view_page_contents_get() API
​https://bugs.webkit.org/show_bug.cgi?id=106440

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-11
Reviewed by Gyuyoung Kim.

Add ewk_view_page_contents_get() API for getting contents of the current page.
Currently, it supports only MHTML type.

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_Page_Contents_Context):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(PageContentsCallback):
(TEST_F):

2:30 AM Changeset in webkit [139421] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
​https://bugs.webkit.org/show_bug.cgi?id=106447

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-01-11
Reviewed by Andreas Kling.

Files do not have HAVE(ACCESSIBILITY) guards.
This is source of potential build breakes, when macro is not enabled.

  • WebProcess/WebPage/atk/WebPageAccessibilityObject.h:
  • WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
2:11 AM Changeset in webkit [139420] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
​https://bugs.webkit.org/show_bug.cgi?id=106636

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-11
Reviewed by Adam Barth.

This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/screen-config:
  • EWSTools/start-queue.sh:
2:07 AM Changeset in webkit [139419] by jochen@chromium.org
  • 4 edits
    2 adds in trunk

Connect UserGestureIndicator for mousedown and mouseup events
​https://bugs.webkit.org/show_bug.cgi?id=105138

Reviewed by Adam Barth.

Source/WebCore:

Ports that consume user gestures to prevent certain types of pop-ups
need to be able to connect mousedown and mouseup events, otherwise, a
single mouse click will allow for opening multiple pop-ups.

Note that a mousedown is not always followed by a mouseup and vice
versa, e.g. when the mousedown results in a context menu being shown, or
something is dragged into the page.

Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/EventHandler.h:

LayoutTests:

  • platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added.
  • platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added.
2:06 AM Changeset in webkit [139418] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: [Resources] "Delete" cookie deletes all cookies with matching name.
​https://bugs.webkit.org/show_bug.cgi?id=105633

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-11
Reviewed by Pavel Feldman.

Source/WebCore:

"Delete" cookie deletes all cookies with matching name,
ignoring domain and path.

  • inspector/Inspector.json: Change argument "domain" to "url"
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::deleteCookie): Use url to delte cookies.

  • inspector/InspectorPageAgent.h: Adopt new signature.
  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype._deleteCookie): Ditto.

LayoutTests:

Adopt new signatures.

  • http/tests/inspector/resource-main-cookies.php:
1:53 AM Changeset in webkit [139417] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[EFL] Fix unused parameter build error
​https://bugs.webkit.org/show_bug.cgi?id=106639

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-11
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix build error.

Source/WebCore:

No new tests, no behavior change.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::isUsingEcoreX):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::supportsDataListUI):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::intentMessagePorts):

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_destroy):
(ewk_context_menu_item_select):

  • ewk/ewk_file_chooser.cpp:

(ewk_file_chooser_capture_get):

  • ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event):

  • ewk/ewk_intent.cpp:

(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • ewk/ewk_intent_request.cpp:

(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):

  • ewk/ewk_settings.cpp:

(ewk_settings_shadow_dom_enable_set):

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):

Source/WebKit2:

  • UIProcess/API/efl/ewk_color_picker.cpp:

(ewk_color_picker_color_set):
(ewk_color_picker_color_get):

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_additional_plugin_path_set):

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_intent_deliver):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_fullscreen_exit):

1:45 AM Changeset in webkit [139416] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
​https://bugs.webkit.org/show_bug.cgi?id=106555

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Wrong ::enable was made virtual in the InspectorDebuggerAgent.

Test: inspector/debugger/debugger-scripts-reload.html

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/debugger-scripts-reload-expected.txt: Added.
  • inspector/debugger/debugger-scripts-reload.html: Added.
1:44 AM WK2-EFLTextCheckerApiTutorial edited by g.czajkowski@samsung.com
(diff)
1:39 AM WK2-EFLTextCheckerApiTutorial edited by g.czajkowski@samsung.com
apply Michal's Roj comments (diff)
12:42 AM Changeset in webkit [139415] by Carlos Garcia Campos
  • 10 edits in trunk

[GTK] Add API to set the web extensions directory to WebKit2 GTK+
​https://bugs.webkit.org/show_bug.cgi?id=106462

Reviewed by Xan Lopez.

.:

  • Source/autotools/symbols.filter: Update

WebGtkExtensionManager::initialize symbol.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_web_extensions_directory): Set
the given directory as injected bundle initialization user data.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(beforeAll): Update the test to use
webkit_web_context_set_web_extensions_directory()
instead of setting the WEBKIT_WEB_EXTENSIONS_PATH env var.

  • WebProcess/gtk/WebGtkExtensionManager.cpp:

(WebKit::WebGtkExtensionManager::scanModules): Append the given
additional web extensions directory to the list of directories to
scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Get the additional
web extensions directory from initialization user data and pass it
to scanModules().

  • WebProcess/gtk/WebGtkExtensionManager.h:

(WebGtkExtensionManager): Add userData parameter.

  • WebProcess/gtk/WebGtkInjectedBundleMain.cpp:

(WKBundleInitialize): Pass initialization user data to
WebGtkExtensionManager.

12:37 AM Changeset in webkit [139414] by vsevik@chromium.org
  • 15 edits
    1 move in trunk

Web Inspector: Refactoring, move NetworkWorkspaceProvider to NetworkUISourceCodeProvider.js and rename its parent to SimpleWorkspaceProvider.
​https://bugs.webkit.org/show_bug.cgi?id=106635

Reviewed by Pavel Feldman.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

  • inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DebuggerWorkspaceProvider):
(WebInspector.DebuggerWorkspaceProvider.prototype.addDebuggerFile):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditWorkspaceProvider):
(WebInspector.LiveEditWorkspaceProvider.prototype.addLiveEditFile):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.addNetworkFile):

  • inspector/front-end/SimpleWorkspaceProvider.js: Renamed from Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js.

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.requestFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.setFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.uniqueURI):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/resource-script-mapping.html:
  • inspector/debugger/scripts-panel.html:
12:33 AM Changeset in webkit [139413] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
​https://bugs.webkit.org/show_bug.cgi?id=106560

Reviewed by Vsevolod Vlasov.

  • src/js/devTools.css:

(body.dock-to-bottom.platform-mac #toolbar):

Jan 10, 2013:

11:54 PM Changeset in webkit [139412] by g.czajkowski@samsung.com
  • 9 edits in trunk

On Linux, should be able to get spelling suggestions without selecting the misspelled word
​https://bugs.webkit.org/show_bug.cgi?id=103520

Reviewed by Ryosuke Niwa.

Source/WebCore:

Allow to get/insert spelling suggestions without selecting the misspelled word for
Linux WebKit ports. WebCore assumes that the misspelled word has to be selected
to get its suggestions.

In compliance with native application behaviour a new editing policy is introduced,
to do not highlight the misspelled word to just get its guesses.

No new tests, covered by context-menu-suggestions.html.

  • WebCore.exp.in:

Remove _ZN7WebCore6Editor21isSelectionMisspelledEv symbol as Mac port doesn't
need it any longer.

  • editing/EditingBehavior.h:

(EditingBehavior):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
Add a new behavior for Linux, to allow spelling suggestions without selecting
the misspelled word.

  • editing/Editor.cpp:

(WebCore::Editor::isContinuousSpellCheckingEnabled):
Add missing const modifier, to use this method in 'misspelledWordAtCaretOrRange() const'.

(WebCore::Editor::misspelledWordAtCaretOrRange):
Allow to check spelling under the caret or selected word.
Does nothing for selection made on the multiple words.

(WebCore::Editor::misspelledSelectionString):
Return the misspelled selection.

(WebCore::Editor::guessesForMisspelledWord):
Remove 'Selection' from method name as it may return guesses without selection.

(WebCore::Editor::guessesForMisspelledOrUngrammatical):
Ditto.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
Select the word under caret to meet the conditions from misspelledWordAtCaretOrRange.

(WebCore::ContextMenuController::populate):
Update guessesForMisspelledOrUngrammatical call.

LayoutTests:

  • platform/efl/TestExpectations:

Unskip context-menu-suggestions.html for WebKit-EFL as it passes now.

  • platform/gtk/TestExpectations:

Update failing reason.

11:44 PM Changeset in webkit [139411] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Disable PNG and ICO image webkit-unit-tests after r139347
​https://bugs.webkit.org/show_bug.cgi?id=106631

Reviewed by Eric Seidel.

  • tests/WebImageTest.cpp:

(WebKit::TEST): Disable ICOImage and PNGImage tests on WIN and MAC to
green their respective webkit-unit-test bots. The tests still pass on
LINUX so keep test coverage there for now.

11:39 PM Changeset in webkit [139410] by morrita@google.com
  • 11 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=106283
[Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW_DOM

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

This change moves <content> and <shadow> behind
ENABLE(SHADOW_DOM). Note that empty stub definitions are remaining
even after this change. They are for minimizing #if/#endif usage
and won't hurt code size.

  • WebCore.exp.in:
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

  • html/shadow/HTMLContentElement.cpp:

(WebCore):
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):

  • html/shadow/HTMLContentElement.h:

(WebCore):
(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(WebCore):
(WebCore::isHTMLShadowElement):
(WebCore::toHTMLShadowElement):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):

  • testing/Internals.cpp:

(WebCore::Internals::createContentElement):
(WebCore::Internals::isValidContentSelect):

11:08 PM Changeset in webkit [139409] by tasak@google.com
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Implement CSSGroupingRule for @host @-rules and @supports.
​https://bugs.webkit.org/show_bug.cgi?id=106418

Reviewed by Antti Koivisto.

CSSGroupingRule is to share code between CSSMediaRule, CSSSupportsRule
and CSSHostRule. @supports and @host @-rules are dervied from
CSSGroupingRule:
​http://www.w3.org/TR/2012/WD-css3-conditional/#the-cssgroupingrule-interface
​https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#css-host-rule-interface
Since @media is also derived from CSSGroupingRule and @region has the
same interface as CSSGroupingRule, modify to use CSSGroupingRule:
​http://dev.w3.org/csswg/css3-regions/#the-at-region-style-rule

No new tests, because no new feature is implemented.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added CSSGroupingRule.h and CSSGroupingRule.cpp.

  • css/CSSAllInOne.cpp:

Modified to include CSSGroupingRule.cpp.

  • css/CSSGroupingRule.cpp: Added.

(WebCore):
(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::~CSSGroupingRule):
(WebCore::CSSGroupingRule::insertRule):
(WebCore::CSSGroupingRule::deleteRule):
(WebCore::CSSGroupingRule::appendCssTextForItems):
(WebCore::CSSGroupingRule::length):
(WebCore::CSSGroupingRule::item):
(WebCore::CSSGroupingRule::cssRules):
(WebCore::CSSGroupingRule::reattach):
(WebCore::CSSGroupingRule::reportMemoryUsage):
These codes are moved from CSSMediaRule and WebKitCSSRegionRule.

  • css/CSSGroupingRule.h:

(WebCore):
(CSSGroupingRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
Make CSSMediaRule inherit CSSGroupingRule.
(WebCore::CSSMediaRule::media):
(WebCore::CSSMediaRule::reattach):
Keep the code for updating media queries' CSSOMWrapper.
(WebCore::CSSMediaRule::reportMemoryUsage):
We need to report media queries' CSSOMWrapper memory usage.
(WebCore::CSSMediaRule::mediaQueries):
(WebCore::CSSMediaRule::cssText):

  • css/CSSMediaRule.h:
  • css/WebKitCSSRegionRule.cpp:

Make WebKitCSSRegionRule inherit CSSGroupingRule.
(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):

  • css/WebKitCSSRegionRule.h:
  • css/StyleRule.h:

Added inlined accessor to obtain StyleRuleMedia* and StyleRuleRegion*
from StyleRuleBlock*.

10:57 PM Changeset in webkit [139408] by aandrey@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas
​https://bugs.webkit.org/show_bug.cgi?id=105822

Reviewed by Pavel Feldman.

Show in the front-end an option to reload the page if there is an uninstrumented canvas.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.decorationElement):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
(WebInspector.CanvasProfileType.prototype._onReloadPageButtonClick):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.addProfileType):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.decorationElement):

10:22 PM Changeset in webkit [139407] by rniwa@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes and delete-stale-build-files use CRLF linebreaks
​https://bugs.webkit.org/show_bug.cgi?id=106622

Reviewed by Simon Fraser.

Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
Also escape clang\+\+ correctly in kill-old-processes.

  • BuildSlaveSupport/delete-stale-build-files:
  • BuildSlaveSupport/kill-old-processes:
10:18 PM Changeset in webkit [139406] by Dimitri Glazkov
  • 7 edits in trunk/Source/WebCore

The word "selector" is somewhat redundant redundantly used in SelectorChecker.
​https://bugs.webkit.org/show_bug.cgi?id=106413

In ​https://bugs.webkit.org/show_bug.cgi?id=105864, Antti suggested reducing some of the redundant uses of the word
"selector" in SelectorChecker. Here's a start.

Reviewed by Antti Koivisto.

Simple renames, no change in behavior.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Renamed.
(WebCore):
(WebCore::SelectorChecker::fastCheck): Ditto,
(WebCore::SelectorChecker::checkOne): Ditto.

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use new name.
(WebCore::StyleResolver::ruleMatches): Renamed from checkSelector to better match argument and return value.
(WebCore::StyleResolver::checkRegionSelector): Changed to use new names.

  • css/StyleResolver.h:

(StyleResolver):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::matches): Ditto.
(WebCore::SelectorDataList::execute): Ditto.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::checkContentSelector): Ditto.

10:17 PM Changeset in webkit [139405] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Web Inspector: Pass the script url to the script-preprocessor script
​https://bugs.webkit.org/show_bug.cgi?id=104384

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Add url argument to the script-preprocessor script in PageAgent.reload()

Test: inspector/debugger/debugger-script-preprocessor.html

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode):
(WebCore::ScriptDebugServer::handleV8DebugEvent):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

LayoutTests:

Tests for Bug 80922 by Pavel Feldman <​pfeldman@chromium.org> that did not land somehow,
with additional test for Bug 104384

  • inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
  • inspector/debugger/debugger-script-preprocessor.html: Added.
  • platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
9:49 PM Changeset in webkit [139404] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: DataGrid refactoring: make cell editing more generic.
​https://bugs.webkit.org/show_bug.cgi?id=105849

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Editing feature has been added to DataGrid to edit localStorage.
Column numbers (0 and 1) are hardcoded.

This patch makes column editing feature more generic: remove hardcoded
colums, take "editable" column property into account.

This patch is a prerequisite for cookie editing.

  • inspector/front-end/DOMStorageItemsView.js:

Use meaningful column names.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick): Check column editability.
(WebInspector.DataGrid.prototype._contextMenuInDataTable): Ditto.
(WebInspector.DataGridNode.prototype.createCell):
Supply cell element with column id.
(WebInspector.DataGrid.prototype.columnIdentifierFromNode):
Added utility method.
(WebInspector.DataGrid.prototype._nextEditableColumn): Ditto.
(WebInspector.DataGrid.prototype._keyDown): Calculate editable column.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
Refined parameter type / name.
(WebInspector.DataGrid.prototype._resizerDragging):
Fix resizer index property names.
(WebInspector.DataGrid.prototype._startResizerDragging): Ditto.
(WebInspector.DataGrid.prototype._positionResizers): Ditto.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded): Ditto.

LayoutTests:

  • inspector/storage-panel-dom-storage-update.html: Fix column names.
  • inspector/storage-panel-dom-storage.html: Ditto.
9:33 PM Changeset in webkit [139403] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r139357. It was missing a comma.

  • QueueStatusServer/model/queues.py:

(Queue):

8:46 PM Changeset in webkit [139402] by falken@chromium.org
  • 3 edits
    4 adds in trunk

Elements must be reattached when inserted/removed from top layer
​https://bugs.webkit.org/show_bug.cgi?id=105489

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html

fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

  • dom/Element.cpp:

(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.

This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).

  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.

This tests that top layer ordering is correct after removing and readding an element to the top layer.

8:44 PM Changeset in webkit [139401] by shinyak@chromium.org
  • 4 edits
    2 adds in trunk

When a selected node in nested ShadowDOM is deleted, selection have wrong range.
​https://bugs.webkit.org/show_bug.cgi?id=106526

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since FrameSelection and htmlediting did not consider nested Shadow DOM, the FrameSelection still selects
removed elements if selected nodes in nested Shadow DOM are removed.

We have to use containsIncludingShadowDOM to handle with nested Shadow DOM correctly.

Test: fast/dom/shadow/selection-in-nested-shadow.html

  • editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):

  • editing/htmlediting.cpp:

(WebCore::updatePositionForNodeRemoval):

LayoutTests:

  • fast/dom/shadow/selection-in-nested-shadow-expected.txt: Added.
  • fast/dom/shadow/selection-in-nested-shadow.html: Added.
8:00 PM Changeset in webkit [139400] by morrita@google.com
  • 10 edits in trunk/Source/WebCore

[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
​https://bugs.webkit.org/show_bug.cgi?id=106614

Reviewed by Dimitri Glazkov.

This change simplifies InsertionPoint overrides and give some flexibility to it.

The change

  • Removes InsertionPoint::isSelectValid(). now ContentSelectorQuery parses given selector anyway. Invalid select attribute is handled by newly introduced matchTypeFor() method.
  • Introduces InsertionPoint::matchTypeFor() to give a chance each InsertionPoint to decide whether it accepts the given node as its distribution. Then it lets DetailsSummaryElement adopt it.
  • Pulls some HTMLShadowElement overrides up to InsertionPoint so that other upcoming InsertionPoint subclasses don't need to override them.

No new tests. Refactoring.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::DetailsSummaryElement):

  • Implemented matchTypeFor() to get rid of HTMLContentElement machinery which is compiled out in the upcoming change.

(DetailsSummaryElement):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::matchTypeFor): Added.
(WebCore):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::isHTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::emptySelectorList): Moved from HTMLShadowElement.
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::matchTypeFor): Added.
(WebCore::InsertionPoint::selectorList): Moved from HTMLShadowElement.
(InsertionPoint):

  • testing/Internals.cpp:

(WebCore::Internals::isValidContentSelect):

7:18 PM Changeset in webkit [139399] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Fixing AuthenticationError when running test-webkitpy as a non-committer.
​https://bugs.webkit.org/show_bug.cgi?id=106420

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.push_local_commits_to_server):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVNRepository):
(SVNRepository.has_authorization_for_realm):

7:00 PM Changeset in webkit [139398] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 138850
BUG=162622
Review URL: ​https://codereview.chromium.org/11856005

6:36 PM Changeset in webkit [139397] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/platform/graphics/FontCache.cpp

Merge 138812
BUG=167443
Review URL: ​https://codereview.chromium.org/11854003

6:30 PM Changeset in webkit [139396] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138908
BUG=166324
Review URL: ​https://codereview.chromium.org/11853004

6:28 PM Changeset in webkit [139395] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138908
BUG=166324
Review URL: ​https://codereview.chromium.org/11853003

6:19 PM Changeset in webkit [139394] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore/editing

Merge 138657
BUG=167827
Review URL: ​https://codereview.chromium.org/11851002

6:17 PM Changeset in webkit [139393] by cevans@google.com
  • 2 edits in branches/chromium/1312/Source/WebCore/editing

Merge 138657
BUG=167827
Review URL: ​https://codereview.chromium.org/11850002

6:01 PM Changeset in webkit [139392] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Plugin snapshot label should take device resolution and inset into account
​https://bugs.webkit.org/show_bug.cgi?id=106619

Reviewed by Simon Fraser.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintLabel): Take into account the inset in the label image.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Look at the page's device scale, and adjust the label image accordingly.

5:54 PM Changeset in webkit [139391] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139029
BUG=167868
Review URL: ​https://codereview.chromium.org/11840004

5:42 PM Changeset in webkit [139390] by cevans@google.com
  • 1 edit
    2 deletes in branches/chromium/1364

Merge 138974
BUG=166336
Review URL: ​https://codereview.chromium.org/11847002

5:30 PM Changeset in webkit [139389] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source

Merge 138173
BUG=166627
Review URL: ​https://codereview.chromium.org/11828063

5:27 PM Changeset in webkit [139388] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138131
BUG=166513
Review URL: ​https://codereview.chromium.org/11846002

5:21 PM Changeset in webkit [139387] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138316
BUG=161420
Review URL: ​https://codereview.chromium.org/11845002

5:13 PM Changeset in webkit [139386] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138460
BUG=167498
Review URL: ​https://codereview.chromium.org/11841005

4:07 PM Changeset in webkit [139385] by jamesr@google.com
  • 4 edits in trunk

[chromium] Store scrollable layer's contents size for coordinated scrollable layers
​https://bugs.webkit.org/show_bug.cgi?id=106518

Reviewed by Adrienne Walker.

Source/WebCore:

This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):

LayoutTests:

  • platform/chromium/TestExpectations:
4:01 PM Changeset in webkit [139384] by commit-queue@webkit.org
  • 4 edits
    3 copies
    1 add in trunk/LayoutTests

IndexedDB: Update expected results for IndexedDB layout tests
​https://bugs.webkit.org/show_bug.cgi?id=106411

Patch by Michael Pruett <​michael@68k.org> on 2013-01-10
Reviewed by Tony Chang.

For IndexedDB layout tests whose output differs between V8 and
JSC, move V8 test output to platform/chromium and set expected
results to JSC test output.

  • platform/chromium/storage/indexeddb/exception-in-event-aborts-expected.txt: Copied from LayoutTests/storage/indexeddb/exception-in-event-aborts-expected.txt.
  • platform/chromium/storage/indexeddb/transaction-error-expected.txt: Copied from LayoutTests/storage/indexeddb/transaction-error-expected.txt.
  • platform/chromium/storage/indexeddb/version-change-abort-expected.txt: Copied from LayoutTests/storage/indexeddb/version-change-abort-expected.txt.
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt:
  • storage/indexeddb/version-change-abort-expected.txt:
3:43 PM Changeset in webkit [139383] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=106612

  • platform/chromium/TestExpectations: Marked as flake.
3:41 PM Changeset in webkit [139382] by cevans@google.com
  • 4 edits in branches/chromium/1364/Source/WebCore

Merge 138863
BUG=156906
Review URL: ​https://codereview.chromium.org/11830062

3:40 PM Changeset in webkit [139381] by cevans@google.com
  • 4 edits in branches/chromium/1312/Source/WebCore

Merge 138863
BUG=156906
Review URL: ​https://codereview.chromium.org/11833048

3:35 PM Changeset in webkit [139380] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
​https://bugs.webkit.org/show_bug.cgi?id=106537

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Rename 3 methods to match the terms of ViewportAttributes.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::viewport):
(QWebKitTest::contentsScale):

  • UIProcess/PageViewportController.h:

(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

3:28 PM Changeset in webkit [139379] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/public/WebInputEvent.h

Merge 138684
BUG=165836
Review URL: ​https://codereview.chromium.org/11817055

3:19 PM Changeset in webkit [139378] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138918
BUG=167147
Review URL: ​https://codereview.chromium.org/11827065

3:18 PM Changeset in webkit [139377] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138918
BUG=167147
Review URL: ​https://codereview.chromium.org/11786012

3:14 PM Changeset in webkit [139376] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=106609

  • platform/chromium/TestExpectations: Marked as failing.
3:11 PM Changeset in webkit [139375] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Adjust ref-test expectation to actual work.

  • platform/chromium/TestExpectations: Adjusted.
2:45 PM Changeset in webkit [139374] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline. Apple Windows port.

  • platform/win/fast/ruby/base-shorter-than-text-expected.txt:
2:42 PM Changeset in webkit [139373] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=106606

  • platform/chromium/TestExpectations: Added.
2:40 PM Changeset in webkit [139372] by commit-queue@webkit.org
  • 20 edits
    5 adds in trunk

Implement AutocompleteErrorEvent#reason
​https://bugs.webkit.org/show_bug.cgi?id=105568

Source/WebCore:

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Test: fast/events/constructors/autocomplete-error-event-constructor.html

  • WebCore.gypi: Added AutocompleteErrorEvent.idl and AutocompleteErrorEvent.h for chromium port's build.
  • dom/AutocompleteErrorEvent.h: Added.

(WebCore): Added new type of error named AutocompleteErrorEvent.
(AutocompleteErrorEventInit): Added init params for AutocompleteErrorEvents (so initEvent() can be used).
(AutocompleteErrorEvent): Added a new error event that inherits from Event but also has a reason for failure.
(WebCore::AutocompleteErrorEvent::create): Factory function to create AutocompleteErrorEvents.
(WebCore::AutocompleteErrorEvent::reason): The reason why a requestAutocomplete() invocation failed. Can be

"disabled", "cancel", or "invalid".

(WebCore::AutocompleteErrorEvent::interfaceName): The name of the event's interface (for event.toString()).
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent): Various ways of constructing the error event.

  • dom/AutocompleteErrorEvent.idl: Added.
  • dom/EventNames.in: Added AutocompleteError to this list, based on REQUEST_AUTOCOMPLETE conditional.
  • html/HTMLFormElement.cpp: Updated form elements to dispatch AutocompleteErrorEvents on errors and to give

more details (event.reason) when the request fails.

(WebCore::HTMLFormElement::requestAutocomplete): Changed to newly added failure type "disabled".
(WebCore::HTMLFormElement::finishRequestAutocomplete): Changed

  • html/HTMLFormElement.h: Added new results (ErrorDisabled, ErrorCancel, ErrorInvalid).
  • page/DOMWindow.idl: Added global event constructor for new AutocompleteErrorEvent() style event creation.

Source/WebKit/chromium:

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

  • public/WebFormElement.h: Added matching enum values for public chromium WebKit API.
  • src/AssertMatchingEnums.cpp: Updated compile assert that WebKit and WebCore enums match.

LayoutTests:

Added tests to verify event creation and global event constructor existence of AutocompleteErrorEvent
and updated the existing tests to make sure errors received are of the right type and have the right reason.

Patch by Dan Beam <​dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

  • fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • fast/events/constructors/autocomplete-error-event-constructor.html: Added.
  • fast/events/event-creation.html: Added new AutocompleteErrorEvent() test case.
  • fast/forms/form-request-autocomplete.html: Updated 'autocompleteerror' listeners to check event.reason.
  • fast/js/constructor-length.html: Added AutocompleteErrorEvent to list.
  • fast/js/script-tests/global-constructors.js: Added AutocompleteErrorEvent to list.
  • platform/blackberry/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/chromium/fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Updated passing expectations.
  • platform/chromium/fast/js/constructor-length-expected.txt: Added expected 0 length result.
  • platform/gtk/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/mac/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/qt/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
2:31 PM Changeset in webkit [139371] by yoli@rim.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::resume() should schedule a load rather than load immediately
​https://bugs.webkit.org/show_bug.cgi?id=106587

Reviewed by Eric Carlson.

It is not always safe to start the jobs at the time resume() is called. That is why the jobs are
suspended. It can also be suspended again right after being resumed.

No new tests as there is no visible functional change, also it is a theoretically good-to-have change
that doesn't fix any known cross-platform issue.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::resume): Replace load() with scheduleLoad().

2:31 PM Changeset in webkit [139370] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed rebaselines. Apple Windows port.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/window-load-crash-expected.txt: Added.
2:25 PM Changeset in webkit [139369] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, rolling out r139226.
​http://trac.webkit.org/changeset/139226
​https://bugs.webkit.org/show_bug.cgi?id=106602

re
baselines were premature (Requested by rfong on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-10

  • platform/win/accessibility/canvas-fallback-content-2-expected.txt:
  • platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
  • platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Removed.
2:09 PM Changeset in webkit [139368] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Update WebkitSystemInterface lib for Windows port.
This hasn't been done in a while and the current one is out of date.
In addition I believe it will fix:
<rdar://problem/12990844>

Rubberstamped by Timothy Horton.

  • win/lib/WebKitSystemInterface.lib:
2:06 PM Changeset in webkit [139367] by abarth@webkit.org
  • 4 edits in trunk/Source

Add an ENABLE macro and a WebCore::Setting for the threaded parser
​https://bugs.webkit.org/show_bug.cgi?id=106595

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch adds both a WebCore::Setting and an ENABLE macro for the
threaded parser. We plan to keep the ENABLE macro off by default for a
while. The runtime setting will let us more easily conduct A/B
experiments when the time arises.

  • page/Settings.in:

Source/WebKit/chromium:

Explicitly disable THREADED_HTML_PARSER for Chromium so that we can
more easily enable it locally.

  • features.gypi:
1:58 PM Changeset in webkit [139366] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test svg/dom/SVGScriptElement/script-onerror-bubbling.svg is a flaky timeout on all platforms.
​https://bugs.webkit.org/show_bug.cgi?id=106598

  • platform/chromium/TestExpectations: Expectatized.
1:52 PM Changeset in webkit [139365] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/WebCore

Regression(r129944): Heap-use-after-free in WebCore::computeNonFastScrollableRegion
​https://bugs.webkit.org/show_bug.cgi?id=99515

Reviewed by Simon Fraser.

The object used-after-freed is a destructed FrameView that is still in the m_scrollableAreas set of the parent FrameView. Actually it has been removed from m_scrollableAreas when setParent(0), but then is added back in updateScrollableAreaSet() because its frameViewParent() is still not 0 (though parent() is already 0).

No new tests. The heap-use-after-free doesn't always cause crash so it can't be stably tested with a test case. Memory analysis tools like asan discovered the heap-use-after-free and verified that the patch can fix the issue.

  • page/FrameView.cpp:

(WebCore::FrameView::parentFrameView): Checks if the FrameView has been removed from the parent.

1:49 PM Changeset in webkit [139364] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Set IndexedDB database path in WK2
​https://bugs.webkit.org/show_bug.cgi?id=106257

Patch by Michael Pruett <​michael@68k.org> on 2013-01-10
Reviewed by Benjamin Poulain.

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::initialize):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:

(WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::indexedDBDatabaseDirectory):

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy):

1:47 PM Changeset in webkit [139363] by cevans@google.com
  • 6 edits
    15 copies
    4 deletes in branches/chromium/1364

Merge 138654
BUG=139321
Review URL: ​https://codereview.chromium.org/11823064

1:44 PM Changeset in webkit [139362] by cevans@google.com
  • 6 edits
    15 copies
    4 deletes in branches/chromium/1312

Merge 138654
BUG=139321
Review URL: ​https://codereview.chromium.org/11820059

1:44 PM Changeset in webkit [139361] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding the timeout expectation for fast/css/user-drag-none.html, the test
times out on both debug and release builds.

  • platform/gtk/TestExpectations:
1:43 PM Changeset in webkit [139360] by Christophe Dumez
  • 2 edits in trunk/Tools

[EFL][jhbuild] Use tarballs for gstreamer instead of git
​https://bugs.webkit.org/show_bug.cgi?id=106552

Reviewed by Laszlo Gombos.

Use tarballs for gstreamer instead of git in EFL's jhbuild
to work around intermittent network issues on our build
bots. Tarballs are fully cached and require no network
operation if their checksum matches.

  • efl/jhbuild.modules:
1:37 PM Changeset in webkit [139359] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 138926
BUG=129890
Review URL: ​https://codereview.chromium.org/11819066

1:35 PM Changeset in webkit [139358] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1312

Merge 138926
BUG=129890
Review URL: ​https://codereview.chromium.org/11819065

1:27 PM Changeset in webkit [139357] by rniwa@webkit.org
  • 5 edits in trunk/Tools

Add Mac WK2 EWS bots
​https://bugs.webkit.org/show_bug.cgi?id=106590

Reviewed by Adam Barth.

Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
Also add a deprecated MacWK2Port class.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):
(MacWK2EWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(_test_ewses):

1:10 PM Changeset in webkit [139356] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
​https://bugs.webkit.org/show_bug.cgi?id=106460

Patch by John Mellor <​johnme@chromium.org> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

screen.width, window.outerWidth and @media device-width should be in
density independent (UI) pixels, not physical screen pixels.

This already works on most ports (including iOS). However Chrome for
Android currently internally sizes its windows in physical screen pixels
instead of density independent pixels, and this leaks through in the
sizes provided to WebCore.

This patch scales these sizes appropriately before they reach JavaScript,
on platforms where the applyPageScaleFactorInCompositor setting is false
(i.e. just Chrome for Android). Once Chrome for Android switches over to
the same coordinate space, the applyPageScaleFactorInCompositor setting
will be removed, along with any code (such as this) that depends on it.

The effect of this patch on Chrome for Android when viewing a page with
a width=device-width viewport on a Galaxy Nexus (720x1280 @ dPR 2) is:

@media device-width changes from 720 to 360
screen.width changes from 720 to 360
screen.availWidth changes from 720 to 360
window.outerWidth changes from 720 to 360
window.innerWidth remains 360 (at overview zoom)
@media width remains 360
document.documentElement.clientWidth remains 360
document.documentElement.offsetWidth remains 360
document.documentElement.scrollWidth remains 360
document.body.clientWidth remains 360
document.body.offsetWidth remains 360
document.body.scrollWidth remains 360

And similarly for heights (though they are slightly less than 640, since
toolbars etc. get subtracted from the available height).

No new tests, as applyDeviceScaleFactorInCompositor appears to always be
true in DumpRenderTree, so this situation cannot occur there.

  • page/Settings.in:

Added applyDeviceScaleFactorInCompositor setting, which allows
detecting whether we need to normalize the scale.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toUserSpace):

Static function for normalizing screen rect scale.

(WebCore::screenRect):

Uses toUserSpace.

(WebCore::screenAvailableRect):

Uses toUserSpace.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Use applyDeviceScaleFactorInCompositor instead of
applyPageScaleFactorInCompositor, to scale the window rect correctly
on platforms other than Chrome for Android.

Source/WebKit/chromium:

  1. Exposes the existing applyDeviceScaleFactorInCompositor from

WebSettings on Settings (and stores the value there instead), so it can
be accessed from WebCore.

  1. Changes ChromeClientImpl::windowRect to return values in density

independent (UI) pixels pixels instead of physical screen pixels (see
explanation in Source/WebCore/ChangeLog).

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

Normalizes window rect scale.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

1:02 PM Changeset in webkit [139355] by commit-queue@webkit.org
  • 12 edits
    2 moves in trunk/Tools

[chromium] move webpermissionclient related methods to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106548

Patch by Dan Carney <​dcarney@google.com> on 2013-01-10
Reviewed by Jochen Eisinger.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner::WebTestRunner::webPermissions):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setDelegate):
(WebTestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::webPermissions):
(WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
(WebTestRunner::TestRunner::setImagesAllowed):
(WebTestRunner::TestRunner::setScriptsAllowed):
(WebTestRunner::TestRunner::setStorageAllowed):
(WebTestRunner::TestRunner::setPluginsAllowed):
(WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
(WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.

(WebTestRunner):
(WebTestRunner::WebPermissions::WebPermissions):
(WebTestRunner::WebPermissions::~WebPermissions):
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
(WebTestRunner::WebPermissions::allowStorage):
(WebTestRunner::WebPermissions::allowPlugins):
(WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
(WebTestRunner::WebPermissions::allowRunningInsecureContent):
(WebTestRunner::WebPermissions::setImagesAllowed):
(WebTestRunner::WebPermissions::setScriptsAllowed):
(WebTestRunner::WebPermissions::setStorageAllowed):
(WebTestRunner::WebPermissions::setPluginsAllowed):
(WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
(WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
(WebTestRunner::WebPermissions::setDelegate):
(WebTestRunner::WebPermissions::setDumpCallbacks):
(WebTestRunner::WebPermissions::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.

(WebTestRunner):
(WebPermissions):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::createNewWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:01 PM Changeset in webkit [139354] by commit-queue@webkit.org
  • 3 edits
    2 copies
    1 move in trunk/Tools

Split EWS tool cold-boot.sh into modular components
​https://bugs.webkit.org/show_bug.cgi?id=106527

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
Updated GCE bot build scripts to match.
Unable to test scripts directly as they depend on being in the repository to work!

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
  • EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
  • EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
12:51 PM Changeset in webkit [139353] by fmalita@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename GraphicsContext::addRoundedRectClip
​https://bugs.webkit.org/show_bug.cgi?id=106581

Reviewed by Simon Fraser.

This patch renames GraphicsContext::addRoundedRectClip to clipRoundedRect for consistency
with the other GC clipping methods.

No new tests: no functional changes.

  • WebCore.order:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):

  • rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintMenuListButtonGradients):
(WebCore::RenderThemeMacShared::paintSliderTrack):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):

12:44 PM Changeset in webkit [139352] by tommyw@google.com
  • 13 edits in trunk/Source

MediaStream API: Adding the new id attribute to MediaStream and MediaStreamTrack
​https://bugs.webkit.org/show_bug.cgi?id=106564

Reviewed by Adam Barth.

Specification: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html
MediaStream looses its label attribute and instead gets an id attribute.
MediaStreamTrack gets an id attribute.

Source/Platform:

  • chromium/public/WebMediaStreamComponent.h:

(WebMediaStreamComponent):

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

Source/WebCore:

Not testable yet, will add tests in a followup patch.

  • Modules/mediastream/MediaStream.h:

(WebCore::MediaStream::label):
(MediaStream):
(WebCore::MediaStream::id):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::id):
(WebCore):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • platform/chromium/support/WebMediaStreamComponent.cpp:

(WebKit::WebMediaStreamComponent::initialize):
(WebKit):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::id):
(WebKit::WebMediaStreamComponent::source):

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::label):
(WebKit):
(WebKit::WebMediaStreamDescriptor::id):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::id):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(MediaStreamComponent):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::id):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
(MediaStreamDescriptor):

12:32 PM Changeset in webkit [139351] by ojan@chromium.org
  • 9 edits
    2 adds in trunk

Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items
​https://bugs.webkit.org/show_bug.cgi?id=106591

Reviewed by Levi Weintraub.

Source/WebCore:

The scrollbar width should only be added if the width of the flex item
is not fixed.

Test: fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Use shared helper method. This also happens to fix the vertical
writing-mode case.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::instrinsicScrollbarLogicalWidth):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add a method for determining the scrollbar's contribution to the boxes
intrinsic width.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Use shared code for determining the scrollbar width and only add the
width when computing the intrinsic widths.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):\
Just adding a FIXME to account for scrollbar width.

LayoutTests:

  • fast/css/fixed-width-intrinsic-width-excludes-scrollbars-expected.txt: Added.
  • fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html: Added.
  • fast/css/positioned-overflow-scroll.html:
12:21 PM Changeset in webkit [139350] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Replace unnecessary null-checks with an assert in MainResourceLoader::continueAfterNavigationPolicy.
​https://bugs.webkit.org/show_bug.cgi?id=106476

Reviewed by Alexey Proskuryakov.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy): Null-checks for resourceLoader were

added in an abundance of caution in r139150. Given that we know the load hasn't been cancelled,
resourceLoader can only be null if continueAfterNavigationPolicy() has already been called
before when m_substituteData is valid. continueAfterNavigationPolicy() is only called for redirects,
and SubstituteData doesn't support redirects, so it is correct to assert that resourceLoader is non-null.

12:14 PM Changeset in webkit [139349] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a few crash expectations for tests that haven't crashed
for a long time. Hopefully the crash causes have been fixed.
Adding a flaky failure expectation for a CSS Regions reftest.

  • platform/gtk/TestExpectations:
11:52 AM Changeset in webkit [139348] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard Cleanup: Do not generate the page if we are about to reload.
​https://bugs.webkit.org/show_bug.cgi?id=106584

Reviewed by Dirk Pranke.

Move the logic to determine if we should generate the page into
parseParameters() since that is where we have the knowledge to
determine it, and return that value to handleLocationChange,
rather than passing the changed parameters back to handleLocationChange
and having it make the decision.

This is logically equivalent, save one case: when we are about to do
a reload, we know that there is no reason to generate the page. Old
code was causing an extra page generation in this case.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):
(handleLocationChange):

11:47 AM Changeset in webkit [139347] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-10

  • DEPS:
11:33 AM Changeset in webkit [139346] by leviw@chromium.org
  • 3 edits
    4 adds in trunk

ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
​https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore:

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests:

  • platform/chromium/fast/events/touch/resources: Added.
  • platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.
11:29 AM Changeset in webkit [139345] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
​https://bugs.webkit.org/show_bug.cgi?id=106454

Reviewed by James Robinson.

Source/WebCore:

Correctly removing child Documents from their parent's tracked touch handler maps when detaching and
when their last touch event handler is removed.

Test: fast/events/touch/nested-document-with-touch-handler-detached-crash.html

  • dom/Document.cpp:

(WebCore::Document::detach):
(WebCore::Document::didRemoveEventTargetNode):

LayoutTests:

  • fast/events/touch/nested-document-with-touch-handler-detached-crash.html: Added.
  • fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt: Added.
11:22 AM Changeset in webkit [139344] by ojan@chromium.org
  • 3 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert fast/css/positioned-overflow-scroll.html to a check-layout.js test
​https://bugs.webkit.org/show_bug.cgi?id=106585

Reviewed by Tony Chang.

This is in preparation for adding more cases to this test.

  • fast/css/positioned-overflow-scroll-expected.txt: Added.
  • fast/css/positioned-overflow-scroll.html:
  • platform/chromium-android/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-android/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/chromium-linux/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac-lion/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-win/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/efl/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/efl/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/gtk/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/gtk/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • resources/check-layout.js:
11:22 AM Changeset in webkit [139343] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=106137

Reviewed by Brady Eidson.

Tested manually by comparing before and after leaks output for WK1-mac.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError): Call dispatchDidFailLoading() if

a SubstituteData load fails or is cancelled. Without this call, load counts
are not balanced on WebDocumentLoaderMac and it is retained forever.

(WebCore::MainResourceLoader::didFinishLoading):

11:11 AM Changeset in webkit [139342] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Use the "configure" script to build glib
​https://bugs.webkit.org/show_bug.cgi?id=106569

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-01-10
Reviewed by Martin Robinson.

So far both EFL and GTK have been using autogen.sh to build glib.
While that does work most of the time, it's not really needed since
we are downloading and building stable releases from tarballs.
Additionally, autogen.sh fails to work with automake 1.13 due to the
usage of some macros that have been removed (this has already been
fixed in glib master).

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
10:44 AM Changeset in webkit [139341] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Ensure that WebPageProxy's notion of pageScaleFactor is reset on didCommitLoad
​https://bugs.webkit.org/show_bug.cgi?id=103290
<rdar://problem/12752467>

Reviewed by Darin Adler.

When a standard main frame load is committed, we reset the WebPage's
pageScaleFactor, if it's not the default. However, if the previous
page had a full-main-frame plugin that was handling page scaling itself,
WebPageProxy can have a cached pageScaleFactor != 1, while WebPage
now (since the plugin that was overriding (set)pageScaleFactor is gone)
has a pageScaleFactor of 1, causing us to skip the call to reset the
WebPage's pageScaleFactor.

Therefore, when WebPageProxy is notified that a standard main-frame load
is committed, reset its cached notion of the pageScaleFactor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame): Add a parameter which corresponds to FrameLoadType, so we can
determine whether a frame load is of FrameLoadTypeStandard (which matches the check to reset page scale in
WebFrameLoaderClient::didCommitLoad), so we can reset m_pageScaleFactor.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add frameLoadType parameter to didCommitLoadForFrame.

  • UIProcess/WebPageProxy.messages.in: Add frameLoadType parameter to didCommitLoadForFrame.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Pass frameLoadType parameter to didCommitLoadForFrame.

10:42 AM Changeset in webkit [139340] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebKit2

PDFPlugin: Cmd-/+ should affect PDF page scale
​https://bugs.webkit.org/show_bug.cgi?id=103285
<rdar://problem/12710469>

Reviewed by Darin Adler.

Plugins which support handling page scale themselves should also handle
page zoom, as it is a very similar concept.

This patch disables text zoom in the case of a main-frame plugin which supports
page scale factor changes, as it is not needed in the PDFPlugin case
(we can't do text-only scale for PDF), but it could be added later if needed.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::pageZoomFactorDidChange):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:

Add WebPageProxy::pageZoomFactorDidChange, to notify WebPageProxy of
out-of-band page zoom factor changes (in this case, from PluginView).

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setPageScaleFactor):
Update WebPageProxy's notion of the current page zoom whenever PluginView
is notified of a page scale factor change.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTextZoomFactor): We don't support text zoom in plugins, but
we also don't want it to silently act on the Frame if we have a plugin that
purports to handle page scale itself. Return early if this is the case.
(WebKit::WebPage::pageZoomFactor): For plugins that support page scale factor,
we equate page scale and page zoom. Return the PluginView's page scale factor
in place of the Frame's page zoom factor.
(WebKit::WebPage::setPageZoomFactor): Make page zoom changes in the aforementioned
case affect the PluginView's page scale.
(WebKit::WebPage::setPageAndTextZoomFactors): Ditto.

10:41 AM Changeset in webkit [139339] by rjkroege@chromium.org
  • 3 edits
    2 deletes in trunk

Manually revert ​http://trac.webkit.org/changeset/136012
​https://bugs.webkit.org/show_bug.cgi?id=106580

Reviewed by Dimitri Glazkov.

Source/WebCore:

136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
to work around conflicts.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

  • fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.
10:41 AM Changeset in webkit [139338] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Changing tests to be consistent and use self.scm rather then recreating the scm object.
(Missed a couple)
​https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
10:39 AM Changeset in webkit [139337] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for internal floated elements
​https://bugs.webkit.org/show_bug.cgi?id=106374

Reviewed by David Hyatt.

Source/WebCore:

r136397 treated any self-collapsing block that had a clearance delta as though it was clearing a float, but
blocks that avoid floats can get a clearance delta too. So just ensure there is clearance on the block when deciding
whether we need to add the margin back in before placing the float.

Test: fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html: Added.
10:39 AM Changeset in webkit [139336] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Header cleanup
​https://bugs.webkit.org/show_bug.cgi?id=106540

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PDF/PDFPlugin.mm: Remove some unneeded headers.
10:28 AM Changeset in webkit [139335] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Update expectations for fast/regions/selecting-text-through-different-region-flows.html.

  • platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
10:27 AM Changeset in webkit [139334] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Color picker in Styles pane shows wrong initial color
​https://bugs.webkit.org/show_bug.cgi?id=106567

Reviewed by Pavel Feldman.

The RGB's G value for "crimson" was wrong.

  • inspector/front-end/Color.js:
10:27 AM Changeset in webkit [139333] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark more inspector/geolocation* tests as flaky on Win.
​https://bugs.webkit.org/show_bug.cgi?id=106426

  • platform/chromium/TestExpectations: Marked.
10:25 AM Changeset in webkit [139332] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Refactor InspectorTest to create output interface
​https://bugs.webkit.org/show_bug.cgi?id=106231

Patch by John J. Barton <​johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Refactor InspectorTest to extract InspectorTest.Output, the API
used between InspectorTest and the test output reciever (the
test-script page by default).

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.Output.testComplete):
(initialize_InspectorTest.InspectorTest.Output.addResult):
(initialize_InspectorTest.InspectorTest.Output.clearResults):
(initialize_InspectorTest.InspectorTest.completeTest):
(initialize_InspectorTest.InspectorTest.addResult):

10:25 AM Changeset in webkit [139331] by tony@chromium.org
  • 14 edits in trunk

Speed up supplemental dependency computation
​https://bugs.webkit.org/show_bug.cgi?id=106503

Reviewed by Adam Barth.

.:

  • Source/cmake/WebKitMacros.cmake: Add --idlAttributesFile to the binding generation step in cmake.

Source/WebCore:

On my machine, generating supplemental IDL dependencies was taking about 18s
because it has to run the C preprocessor on each IDL file. Avoid this by using
a regular expression to find the Supplemental= value in each IDL file rather than
doing a full parse. Now generating supplemental IDL dependencies is less than a
second.

preprocess-idls.pl used to also check IDL attributes against IDLAttributes.txt.
Move this code to run in generate-bindings.pl. This change revealed that
TestRunner.idl uses PassContext so add that to IDLAttributes.txt.

No new tests, this is a build refactor. EWS bots should be green.

  • DerivedSources.make: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • DerivedSources.pri: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • GNUmakefile.am: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • UseJSC.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • UseV8.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • WebCore.gyp/WebCore.gyp: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • bindings/scripts/IDLAttributes.txt: Add PassContext needed by TestRunner.idl.
  • bindings/scripts/generate-bindings.pl:

(loadIDLAttributes): Moved from preprocess-idls.pl.
(checkIDLAttributes): Moved from preprocess-idls.pl.
(checkIfIDLAttributesExists): Moved from preprocess-idls.pl.

  • bindings/scripts/preprocess-idls.pl:

(getSupplementalFromIDLFile): Helper method to get Supplemental=* quickly.

Tools:

Pass the IDL attributes file for generating the bindings in WebKitTestRunner.

  • WebKitTestRunner/CMakeLists.txt:
10:16 AM Changeset in webkit [139330] by mvujovic@adobe.com
  • 4 edits
    11 adds in trunk

[CSS Filters] RenderLayerCompositor::addToOverlapMap should take into account the filters outsets (ie. blur and drop-shadow)
​https://bugs.webkit.org/show_bug.cgi?id=94022

Reviewed by Simon Fraser.

Source/WebCore:

When a layer has a filter that moves pixels, we need to add its entire bounds, including its
outsets and children, to the overlap map. The filter can move the children's pixels
anywhere in the layer, so we can't rely on the children's bounds.

Eventually, we should avoid adding children to the overlap map if the parent's bounds used
for overlap testing already include the children. I've added a FIXME for this optimization.

Tests: compositing/filters/sw-layer-overlaps-hw-shadow.html

compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html
compositing/filters/sw-shadow-overlaps-hw-layer.html
compositing/filters/sw-shadow-overlaps-hw-shadow.html

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::overlapBounds):

If necessary, return the calculated layer bounds, including the children. Otherwise,
return the localBoundingBox.

(RenderLayer):
(WebCore::RenderLayer::overlapBoundsIncludeChildren):

If the layer has a filter that moves pixels, return true.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

Add the overlapBounds instead of the localBoundingBox to the overlap map.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Use the overlapBounds instead of the localBoundingBox for overlap testing.

LayoutTests:

Add tests to check several combinations of software layer and composited layer overlap when
filter outsets are involved.

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • compositing/filters/sw-layer-overlaps-hw-shadow.html: Added.
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html: Added.
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
  • compositing/filters/sw-shadow-overlaps-hw-layer.html: Added.
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
  • compositing/filters/sw-shadow-overlaps-hw-shadow.html: Added.
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
10:08 AM Changeset in webkit [139329] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

intrinsic min-widths don't override width for file upload controls
​https://bugs.webkit.org/show_bug.cgi?id=106517

Reviewed by Tony Chang.

Source/WebCore:

Separate out computing intrinsic width from perferred width so that
we can use the intrinsic width correctly when applying min-width/max-width.
The preferred width is the width used in its container's computation
of its intrinsic width.

This is the first in a series of patches making this work across
the render tree.

Test: fast/forms/file/intrinsic-min-width-overrides-width.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::minIntrinsicLogicalWidth):
(WebCore):
(WebCore::RenderBox::maxIntrinsicLogicalWidth):
(WebCore::RenderBox::computeIntrinsicLogicalWidths):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.h:

(RenderFileUploadControl):

LayoutTests:

  • fast/forms/file/intrinsic-min-width-overrides-width-expected.html: Added.
  • fast/forms/file/intrinsic-min-width-overrides-width.html: Added.
9:56 AM Changeset in webkit [139328] by fmalita@chromium.org
  • 102 edits
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after ​http://trac.webkit.org/changeset/138250.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-position-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-changes-id-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-id-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-property-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-style-change-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [139327] by zandobersek@gmail.com
  • 2 edits in trunk

[Autotools] Add the AM_WEBKIT_FEATURE_CONDITIONAL macro
​https://bugs.webkit.org/show_bug.cgi?id=106576

Reviewed by Martin Robinson.

Replace the AC_CHECK_WEBKIT_FEATURE_ENABLED with the new macro.
The former was executing actions based on the passed-in feature being
enabled in the (possibly overridden) GNUmakefile.features.am, the actions
usually affecting the Automake conditional value that was set up afterwards.
The new macro does this directly, setting up an Automake conditional of the
same name as the feature that was checked.

  • Source/autotools/webkitfeature.m4:
9:45 AM Changeset in webkit [139326] by victor@rosedu.org
  • 5 edits in trunk

media/video-controls-captions.html fails after fixing ​https://bugs.webkit.org/show_bug.cgi?id=105536
​https://bugs.webkit.org/show_bug.cgi?id=106230

Reviewed by Eric Carlson.

Source/WebCore:

Until Chromium has proper controls for lists of text tracks, the caption button
needs to preserve its functionality.

Updated TestExpectations to reactivate test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Added explicit call to updateTextTrackDisplay.
This enables hiding the tracks immediately.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added extra check before rendering
that captions should actually be displayed.

LayoutTests:

  • platform/chromium/TestExpectations: Reactivated test.
9:44 AM Changeset in webkit [139325] by morrita@google.com
  • 18 edits
    2 adds in trunk/Source/WebCore

ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
​https://bugs.webkit.org/show_bug.cgi?id=106505

Reviewed by Dimitri Glazkov.

This change hides ComposedShadowTreeWalker from non-ShadowDOM classes by

  • introducing thin wrapper functions on NodeRenderingTraversal and relacing CSTW callsites with it,
  • replacing ComposedShadowTreeWalker usage with AncestorChainWalker if possible and
  • moving AncestorChainWalker to its own file and including it on files which needs only AncestorChainWalker. This eliminates ComposedShadowTreeWalker.h inclusions.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AncestorChainWalker.cpp: Added. Extracted from ComposedShadowTreeWalker.cpp

(WebCore):
(WebCore::AncestorChainWalker::AncestorChainWalker):
(WebCore::AncestorChainWalker::parent):

  • dom/AncestorChainWalker.h: Added. Extracted from ComposedShadowTreeWalker.h

(WebCore):
(AncestorChainWalker):
(WebCore::AncestorChainWalker::get):
(WebCore::AncestorChainWalker::crossingInsertionPoint):

  • dom/ComposedShadowTreeWalker.cpp:
  • dom/ComposedShadowTreeWalker.h:
  • dom/DOMAllInOne.cpp:
  • dom/ElementShadow.h:

(WebCore::shadowOfParent):
(WebCore):

  • dom/EventDispatcher.cpp:
  • dom/Node.cpp:
  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::nextInScope):
(NodeRenderingTraversal):
(WebCore::NodeRenderingTraversal::previousInScope): Added.
(WebCore::NodeRenderingTraversal::parentInScope): Added.
(WebCore::NodeRenderingTraversal::lastChildInScope): Added.

  • dom/NodeRenderingTraversal.h:

(NodeRenderingTraversal):

  • dom/TreeScope.cpp:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • page/EventHandler.cpp:
  • page/FocusController.cpp: Replacing CSTW with NRT

(WebCore):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

9:29 AM Changeset in webkit [139324] by zandobersek@gmail.com
  • 17 edits in trunk

Remove the ENABLE_ANIMATION_API feature define occurences
​https://bugs.webkit.org/show_bug.cgi?id=106544

Reviewed by Simon Fraser.

The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
feature define handling still lingers in various build systems and configurations
but is of no use, so it should be removed.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests - no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.features.am.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
9:27 AM Changeset in webkit [139323] by Dimitri Glazkov
  • 149 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r139227.
​http://trac.webkit.org/changeset/139227
​https://bugs.webkit.org/show_bug.cgi?id=106227

Broke Win component build.

  • public/WebAccessibilityObject.h:
  • public/WebAccessibilityRole.h:
  • public/WebActiveWheelFlingParameters.h:
  • public/WebAnimationController.h:
  • public/WebApplicationCacheHost.h:
  • public/WebApplicationCacheHostClient.h:
  • public/WebArrayBuffer.h:
  • public/WebAudioSourceProvider.h:
  • public/WebBatteryStatus.h:
  • public/WebBindings.h:
  • public/WebBlob.h:
  • public/WebCache.h:
  • public/WebCachedURLRequest.h:
  • public/WebColorChooser.h:
  • public/WebColorChooserClient.h:
  • public/WebColorName.h:
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebCompositorInputHandler.h:
  • public/WebConsoleMessage.h:
  • public/WebContentDetectionResult.h:
  • public/WebContextMenuData.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebCursorInfo.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMStringList.h:
  • public/WebDataSource.h:
  • public/WebDatabase.h:
  • public/WebDateTimeChooserCompletion.h:
  • public/WebDateTimeChooserParams.h:
  • public/WebDeliveredIntentClient.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClient.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDraggableRegion.h:
  • public/WebExternalPopupMenuClient.h:
  • public/WebFileChooserCompletion.h:
  • public/WebFileChooserParams.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFileSystemEntry.h:
  • public/WebFileWriter.h:
  • public/WebFileWriterClient.h:
  • public/WebFindOptions.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFontDescription.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHelperPlugin.h:
  • public/WebHistoryItem.h:
  • public/WebHitTestResult.h:
  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseCallbacks.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBIndex.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebIDBMetadata.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • public/WebIDBTransactionCallbacks.h:
  • public/WebIconURL.h:
  • public/WebImageDecoder.h:
  • public/WebInputEvent.h:
  • public/WebIntent.h:
  • public/WebIntentRequest.h:
  • public/WebIntentServiceInfo.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMenuItemInfo.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebNotificationPresenter.h:
  • public/WebOptionElement.h:
  • public/WebPageOverlay.h:
  • public/WebPagePopup.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPlugin.h:
  • public/WebPluginContainer.h:
  • public/WebPluginParams.h:
  • public/WebPopupMenu.h:
  • public/WebPopupMenuInfo.h:
  • public/WebPrerendererClient.h:
  • public/WebPrintParams.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScopedMicrotaskSuppression.h:
  • public/WebScopedUserGesture.h:
  • public/WebScriptController.h:
  • public/WebScriptSource.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSettings.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerRepository.h:
  • public/WebSpeechGrammar.h:
  • public/WebSpeechInputController.h:
  • public/WebSpeechInputResult.h:
  • public/WebSpeechRecognitionHandle.h:
  • public/WebSpeechRecognitionParams.h:
  • public/WebSpeechRecognitionResult.h:
  • public/WebSpeechRecognizer.h:
  • public/WebSpeechRecognizerClient.h:
  • public/WebSpellCheckClient.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebSurroundingText.h:
  • public/WebTestingSupport.h:
  • public/WebTextCheckingCompletion.h:
  • public/WebTextCheckingResult.h:
  • public/WebTextFieldDecoratorClient.h:
  • public/WebTextInputInfo.h:
  • public/WebTextRun.h:
  • public/WebTimeRange.h:
  • public/WebTouchPoint.h:
  • public/WebUserMediaRequest.h:
  • public/WebView.h:
  • public/WebViewBenchmarkSupport.h:
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/WebWindowFeatures.h:
  • public/WebWorkerInfo.h:
8:48 AM Changeset in webkit [139322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Serialization of Gradients fails when PlatformContextSkia is not bitmap backed
​https://bugs.webkit.org/show_bug.cgi?id=106559

Patch by Robert Phillips <​robertphillips@chromium.org> on 2013-01-10
Reviewed by Stephen White.

This patch switches over from having platform/Skia improperly
crack open the device to find the bitmap configuration to just
specifying it directly.

No new tests. This bug is Chromium specific and only occurs in a
debugging tool (when serializing to a Skia-specific file format).

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::createCompatibleDevice):

8:27 AM Changeset in webkit [139321] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

The "outline-offset" property is not found in the computed style property list
​https://bugs.webkit.org/show_bug.cgi?id=106561

Reviewed by Alexis Menard.

Source/WebCore:

Listed CSSPropertyOutlineOffset in the CSSComputedStyleDeclaration's computedProperties[].

Test: fast/css/getComputedStyle/getComputedStyle-outline-offset.html

  • css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-outline-offset.html: Added.
8:20 AM WebKit Team edited by nghanavatian@rim.com
adding myself to committers list (diff)
7:53 AM Changeset in webkit [139320] by Lucas Forschler
  • 4 edits in tags/Safari-537.25.1/Source

Versioning.

7:51 AM Changeset in webkit [139319] by Lucas Forschler
  • 1 copy in tags/Safari-537.25.1

New Tag.

7:31 AM Changeset in webkit [139318] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile
​https://bugs.webkit.org/show_bug.cgi?id=106463

Patch by David Faure <​faure@kde.org> on 2013-01-10
Reviewed by Simon Hausmann.

No new tests, this code path will be tested by bug 106140.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::freeLibraryTimerFired): skip unloading if loaded again meanwhile.

7:13 AM Changeset in webkit [139317] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

CSSParser does not allow the absence of whitespace between "and" and "expression"
​https://bugs.webkit.org/show_bug.cgi?id=106458

Patch by Alexander Pavlov <​apavlov@chromium.org> on 2013-01-10
Reviewed by Antti Koivisto.

  • fast/css/media-rule-no-whitespace-expected.txt: Added.
  • fast/css/media-rule-no-whitespace.html: Added.
6:40 AM Changeset in webkit [139316] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

CSSParser does not allow the absence of whitespace between "and" and "expression"
​https://bugs.webkit.org/show_bug.cgi?id=106458

Reviewed by Antti Koivisto.

Source/WebCore:

The issue was that a construct similar to "and(max-width: 480px)" looks like a function call (token type FUNCTION), even though
it is actually a MEDIA_AND followed by a parenthesized expression.

Test: fast/css/media-rule-no-whitespace.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken): Return if the detection has been successful.
(WebCore::CSSParser::realLex): Test for media query tokens if function type detection has failed.

  • css/CSSParser.h:

LayoutTests:

  • fast/css/media-rule-no-whitespace-expected.txt: Added.
  • fast/css/media-rule-no-whitespace.html: Added.
6:23 AM Changeset in webkit [139315] by fmalita@chromium.org
  • 162 edits
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after ​http://trac.webkit.org/changeset/139191.

  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-lion/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-lion/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac-lion/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-lion/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-lion/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac-lion/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/controls-after-reload-expected.png:
  • platform/chromium-mac-lion/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-lion/media/controls-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-without-preload-expected.png:
  • platform/chromium-mac-lion/media/media-controls-clone-expected.png:
  • platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/video-display-toggle-expected.png:
  • platform/chromium-mac-lion/media/video-empty-source-expected.png:
  • platform/chromium-mac-lion/media/video-no-audio-expected.png:
  • platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-lion/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac/fast/box-shadow/spread-expected.png:
  • platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk2/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-controls-expected.png.
6:01 AM Changeset in webkit [139314] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css

Merge 138166

Web Inspector: default font on mac is Monaco (should do be Menlo)
​https://bugs.webkit.org/show_bug.cgi?id=105435

Reviewed by Alexander Pavlov.

Regressed when I introduced mountain lion modifier in the inspector.css.

  • inspector/front-end/inspector.css:

(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):

TBR=​pfeldman@chromium.org
Review URL: ​https://codereview.chromium.org/11823053

5:46 AM Changeset in webkit [139313] by alexis@webkit.org
  • 4 edits
    2 adds in trunk

ASSERT_NOT_REACHED in StylePropertySet::fontValue when accessing font style property through JS after setting style font size.
​https://bugs.webkit.org/show_bug.cgi?id=88866

Reviewed by Alexander Pavlov.

Source/WebCore:

StylePropertySet::fontValue always assumed that it was called using
style.font after a subsequent call which set the shorthand font. The
ASSERT_NOT_REACHED assumed that all longhands of the font shorthand not
set by the shorthand itself were set to initial. While it's true when
we set the font shorthand (i.e all longhands are set to implicit initial)
it is not true when you set the longhands individually. For example setting
font-size will not set other font properties to initial. It is the behavior of all
other shorthands in WebKit. When reconstructing the shorthand other
properties tests whether the value of each longhands is initial or not
(if not then we omit the value, as we should always construct the
shortest shorthand possible) or if the value is set or not (if set then
we include it in the shorthand if not then we omit it). The comment
removed was also talking about invalid font property potentially built
by fontValue(). So far appendFontLonghandValueIfExplicit will always
construct a valid value as it takes care of adding ' ' or '/' when
needed, so the return value is parsable and correct.

Test: fast/css/font-shorthand-from-longhands.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):

  • css/StylePropertySet.h:

LayoutTests:

Add tests to cover the bug.

  • fast/css/font-shorthand-from-longhands-expected.txt: Added.
  • fast/css/font-shorthand-from-longhands.html: Added.
5:37 AM Changeset in webkit [139312] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Contents gets blurry when page is scrolled down
​https://bugs.webkit.org/show_bug.cgi?id=106545

Reviewed by Kenneth Rohde Christiansen.

The bound values for scrolling also should be pixel aligned, otherwise
it leads to page contents blurriness when the page is scrolled down.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pageDidRequestScroll):

4:28 AM Changeset in webkit [139311] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking one more flaky crasher due to gstreamer.

  • platform/efl/TestExpectations:
4:28 AM Changeset in webkit [139310] by loislo@chromium.org
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out r139306.
​http://trac.webkit.org/changeset/139306
​https://bugs.webkit.org/show_bug.cgi?id=106550

it broke inspector-protocol/nmi-webaudio-leak-test.html
(Requested by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-01-10

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

4:25 AM Changeset in webkit [139309] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking three media tests as flaky crashers.

  • platform/efl/TestExpectations:
4:07 AM Changeset in webkit [139308] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed gardening, paint the bots green.

  • platform/qt/TestExpectations: Skip http/tests/security/isolatedWorld/* tests instead of marking them as failures. (r138817)
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Added after r139197.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added after r139197.
3:49 AM Changeset in webkit [139307] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm expectation lines

Unreviewed gardening.

  • platform/chromium/TestExpectations: Two bugs and expectation lines refer to this test, and one

expectation line overrides the other: assign to the earlier bug and ditch the redundant line.

3:31 AM Changeset in webkit [139306] by loislo@chromium.org
  • 21 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
​https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were instrumented in reportMemoryUsage methods.

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

3:27 AM Changeset in webkit [139305] by commit-queue@webkit.org
  • 19 edits
    4 copies
    12 adds in trunk

[GTK] Add support for loading web process extensions
​https://bugs.webkit.org/show_bug.cgi?id=105631

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-01-10
Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Add webkit2_web_extension_h_api.
  • Source/autotools/symbols.filter: Export WebGtkExtensionManager

symbols required by the injected bundle lib.

Source/WebKit2:

  • GNUmakefile.am: Link to libWebCoreDOM.la and build injected

bundle lib.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Helper funtion to get the injected
bundle directory.
(injectedBundleFilename): Helper funtion to get the injected undle
library full path.
(createDefaultWebContext): Create the WebContext with an injected
bundle path.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_page_id): Return the identifier of the web
page associated to the web view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for

web extensions.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/tests/TestMain.cpp:

(main):

  • UIProcess/API/gtk/tests/TestWebExtensions.cpp: Added.

(testWebExtension):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp: Added.

(methodCallCallback):
(webkit_web_extension_initialize):

  • UIProcess/API/gtk/tests/WebKitTestBus.cpp: Added.

(WebKitTestBus::WebKitTestBus):
(WebKitTestBus::run):
(WebKitTestBus::~WebKitTestBus):
(WebKitTestBus::connection):
(onNameAppeared):
(WebKitTestBus::createProxy):

  • UIProcess/API/gtk/tests/WebKitTestBus.h: Added.

(WebKitTestBus):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp: Added.

(_WebKitWebExtensionPrivate):
(webkitWebExtensionPageCreated): Create a WebKitWebPage for the
newly crated page and emit WebKitWebExtension::page-created
signals.
(webkitWebExtensionPageDestroy): Remove the page from the map.
(didCreatePage): Call webkitWebExtensionPageCreated().
(willDestroyPage): Call webkitWebExtensionPageDestroy().
(webkitWebExtensionCreate): Create a new WebKitWebExtension and
initialize the injected bundle client.
(webkit_web_extension_get_page): Return the WebKitWebPage for the
given page identifier.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h: Added.

(_WebKitWebExtension):
(_WebKitWebExtensionClass):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Added.

(_WebKitWebPagePrivate):
(webkit_web_page_class_init):
(webkitWebPageCreate): Create a new WebKitWebPage.
(webkit_web_page_get_dom_document): Return the WebKitDOMDocument
loaded in the WebKitWebPage.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Added.

(_WebKitWebPage):
(_WebKitWebPageClass):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Added.
  • WebProcess/gtk/WebGtkExtensionManager.cpp: Added.

(WebKit::WebGtkExtensionManager::shared): Return the global shared
instance.
(WebKit::WebGtkExtensionManager::WebGtkExtensionManager):
(WebKit::WebGtkExtensionManager::appendModuleDirectories): Add
directories to scan for modules.
(WebKit::WebGtkExtensionManager::scanModules): Scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Load and initialize
the modules found.

  • WebProcess/gtk/WebGtkExtensionManager.h: Added.
  • WebProcess/gtk/WebGtkInjectedBundleMain.cpp: Added.

(WKBundleInitialize): Initialize WebGtkExtensionManager.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c:

(main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
bundle lib from build dir.

  • Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API

located in WebProcess/InjectedBundle/API/gtk.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Scan also files in
WebProcess/InjectedBundle/API/gtk to generate API docs.
(get_webkit2_options.injected_bundle_src_path): Helper function to
build paths in WebProcess/InjectedBundle/API/gtk.

3:14 AM Changeset in webkit [139304] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove lost-compositor-context layout tests
​https://bugs.webkit.org/show_bug.cgi?id=106089

Unreviewed gardening.

  • platform/chromium/TestExpectations: Remove all references to the

lost-compositor-context test expectations after r138814.

3:04 AM Changeset in webkit [139303] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Tools

[EFL][WK2] Writing immediately to created windows (open) fails
​https://bugs.webkit.org/show_bug.cgi?id=105276

Reviewed by Kenneth Rohde Christiansen.

Do not reset 'about:blank' url for the new pages in mini browser.

  • MiniBrowser/efl/main.c:

(window_create):

2:52 AM Changeset in webkit [139302] by noel.gordon@gmail.com
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Optimize expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Removed.
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
2:47 AM EFLWebKit edited by Christophe Dumez
Remove gstreamer from dependencies since it is in jhbuild now and add … (diff)
2:42 AM Changeset in webkit [139301] by noel.gordon@gmail.com
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Optimize expectaions for fast/forms/button-generated-content.html

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Removed.
  • platform/chromium-win/fast/forms/button-generated-content-expected.png:
1:59 AM Changeset in webkit [139300] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r139189): pixel alignment must be performed in device units.
​https://bugs.webkit.org/show_bug.cgi?id=106504

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is
fractional number, adjusted scroll position can blur non-composited layer.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pixelAlignedFloatPoint):

1:58 AM Changeset in webkit [139299] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Changing tests to be consistent and use self.scm rather then recreating the scm object.
​https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1:35 AM Changeset in webkit [139298] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking a missing expectation for fast/repaint/caret-with-transformation.html

  • platform/efl/TestExpectations:
1:21 AM Changeset in webkit [139297] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a few failure expectations that are no longer needed.
The tests the expectations were covering now pass.

  • platform/gtk/TestExpectations:
1:17 AM Changeset in webkit [139296] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for a CSS Regions test.
Adding a missing expectation for the fast/repaint/caret-with-transformation.html layout test.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
1:15 AM Changeset in webkit [139295] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Handle the case that start/end position is out of unclipped selection region
​https://bugs.webkit.org/show_bug.cgi?id=106486

Patch by Yongxin Dai <​yodai@rim.com> on 2013-01-10
Reviewed by Rob Buis.

PR #270624
Unclipped selection region should cover start/end position of the selection.
Since we exclude hidden text when calculating unclipped selection region, the
start/end position can be out of unclipped selection region if it is for hidden
text. If that is the case, start/end handle will be invisible. To avoid invisible
handle, we take unclipped selection region as reference rectangle in the case.

Internally reviewed by Genevieve Mak, Mike Fenton

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::referencePoint):

1:06 AM Changeset in webkit [139294] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Converting to unittest2 so we can use assertItemsEqual, making tests
not dependent on order of items.
​https://bugs.webkit.org/show_bug.cgi?id=106532

Before:
Ran 1733 tests in 38.385s
FAILED (failures=1, errors=22)

After:
Ran 1733 tests in 32.298s
FAILED (failures=0, errors=22)

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_unittest2):

12:59 AM Changeset in webkit [139293] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] [Gtk] web inspector is not visible.
​https://bugs.webkit.org/show_bug.cgi?id=106050

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-01-10
Reviewed by Carlos Garcia Campos.

Use webkitWebViewBaseAddWebInspector when adding web inspector to
webview in order to make webview aware of its existence.

Use gtk_container_add when adding web inspector wiew to its own window
because m_inspectorWindow is not a WebKitWebViewBase.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformAttach):

12:45 AM Changeset in webkit [139292] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform expectation for new test added in r139197.

  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
12:42 AM Changeset in webkit [139291] by Christophe Dumez
  • 14 edits
    1 delete in trunk

[EFL] Add gstreamer 1.0.5 to jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=106178

Reviewed by Laszlo Gombos.

.:

Update EFL CMake configuration to require gstreamer
1.0.5.

  • Source/cmake/FindGStreamer.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake:

Source/WebKit:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Fix compilation error when using gstreamer 1.0.

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp:
  • WebCoreSupport/FullscreenVideoControllerEfl.h:

Tools:

Add gstreamer 1.0.5 to EFL's jhbuild configuration.

  • efl/jhbuild.modules:

LayoutTests:

Skip several media tests that are crashing with gstreamer 1.0.

  • platform/efl/TestExpectations:
  • platform/efl/media/sources-fallback-codecs-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.