Timeline
Jan 30, 2013:
- 11:24 PM Changeset in webkit [141380] by
-
- 2 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed, rebaselining expectations.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
- platform/chromium/TestExpectations:
- 10:05 PM Changeset in webkit [141379] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking video-error-does-not-exist.html as a fail.
- platform/chromium/TestExpectations:
- 10:00 PM Changeset in webkit [141378] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port DragImageWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=108329
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/DragImageWin.cpp:
(WebCore::dragLabelFont):
- platform/wince/DragImageWinCE.cpp: Removed.
- 9:27 PM Changeset in webkit [141377] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after http://trac.webkit.org/changeset/141372.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
- 9:22 PM Changeset in webkit [141376] by
-
- 4 edits in trunk/Source/WebKit2
Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer
https://bugs.webkit.org/show_bug.cgi?id=108164
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-30
Reviewed by Benjamin Poulain.
This is a preparation patch for Threaded Coordinated Graphics.
LayerTreeRenderer should not depend on CoordinatedLayerTreeHostProxy so that it
can be moved to WebCore. This patch introduces LayerTreeRendererClient which
is implemented in CoordinatedLayerTreeHostProxy. LayerTreeRenderer uses this
client, instead of using CoordinatedLayerTreeHostProxy directly.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::updateViewport):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeBackingStores):
(WebKit::LayerTreeRenderer::detach):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit):
(LayerTreeRendererClient):
(LayerTreeRenderer):
- 9:15 PM Changeset in webkit [141375] by
-
- 4 edits in trunk/Source
Versioning.
- 9:11 PM Changeset in webkit [141374] by
-
- 1 copy in tags/Safari-537.29
New Tag.
- 9:03 PM Changeset in webkit [141373] by
-
- 4 edits in trunk/Source/WebCore
Split CSSOMWrapper data and functions out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107779
Reviewed by Dimitri Glazkov.
Factored CSSOMWrapper logic and data out from StyleResolver into a
InspectorCSSOMWrappers class. Since InspectorCSSOMWrappers
depends on static variables defined in StyleResolver.cpp, this
patch does not extract a new class into a new file, which makes a
review easier since it produces readable diffs.
After we factor static variables related to default style sheets
in a following patch (bug 107780), I'll move
InspectorCSSOMWrappers into a its own file.
No new tests, refactoring only.
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets): Renamed from ensureFullCSSOMWrapperForInspector().
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(InspectorCSSOMWrappers):
(WebCore):
(StyleResolver):
(WebCore::StyleResolver::inspectorCSSOMWrappers):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::buildObjectForRule):
- 9:02 PM Changeset in webkit [141372] by
-
- 11 edits in trunk/Source/WebKit2
PDFPlugin: Should respond to three-finger tap for dictionary definitions
https://bugs.webkit.org/show_bug.cgi?id=108418
<rdar://problem/13121409>
Reviewed by Simon Fraser.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add default implementation of performDictionaryLookupAtLocation.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add getSelectionForWordAtPoint and searchInDictionaryWithSelection.
- WebProcess/Plugins/PDF/PDFPlugin.h: Add performDictionaryLookupAtLocation.
- WebProcess/Plugins/PDF/PDFPlugin.mm: Grab a PDFSelection representing the word encompassing the given point, and
throw up a dictionary popover.
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add default implementation of performDictionaryLookupAtLocation.
- WebProcess/Plugins/Plugin.h: Add performDictionaryLookupAtLocation.
- WebProcess/Plugins/PluginProxy.h: Add default implementation of performDictionaryLookupAtLocation.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performDictionaryLookupAtLocation): Forward performDictionaryLookupAtLocation to the plugin.
- WebProcess/Plugins/PluginView.h: Add performDictionaryLookupAtLocation.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Intercept performDictionaryLookupAtLocation, and give
the main-frame plugin (if it exists) a chance to handle it.
- 8:57 PM Changeset in webkit [141371] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r141358.
http://trac.webkit.org/changeset/141358
https://bugs.webkit.org/show_bug.cgi?id=108421
breaks android builder (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-30
Source/WebCore:
- bindings/v8/custom/V8IntentCustom.cpp:
Source/WebKit/chromium:
- WebKit.gyp:
- features.gypi:
- src/WebFrameImpl.cpp:
- 8:46 PM Changeset in webkit [141370] by
-
- 4 edits in trunk/Source
Versioning.
- 8:42 PM Changeset in webkit [141369] by
-
- 3 edits in trunk/Tools
Unreviewed test failure fix for r141341.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 8:32 PM Changeset in webkit [141368] by
-
- 2 edits in trunk/Source/WebCore
[V8] Use state->isolate() when state is not 0
https://bugs.webkit.org/show_bug.cgi?id=107674
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
- 8:07 PM Changeset in webkit [141367] by
-
- 90 edits2 adds in trunk/LayoutTests
[Chromium] Rebaline for form-related tests
https://bugs.webkit.org/show_bug.cgi?id=105574
https://bugs.webkit.org/show_bug.cgi?id=108069
- platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium/TestExpectations:
- 7:57 PM Changeset in webkit [141366] by
-
- 14 edits in trunk/Source/WebKit2
[WK2] Cleanup MessageID parameter after r141332
https://bugs.webkit.org/show_bug.cgi?id=108419
Unreviewed to fix build breaks.
r141332 didn't remove MessageID parameter on some features.
(battery, vibration, coordinate graphics, network info and so on)
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didReceiveCoordinatedLayerTreeHostProxyMessage):
- UIProcess/WebBatteryManagerProxy.h:
(WebBatteryManagerProxy):
- UIProcess/WebNetworkInfoManagerProxy.h:
(WebNetworkInfoManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
- UIProcess/WebVibrationProxy.h:
(WebVibrationProxy):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- WebProcess/Battery/WebBatteryManager.h:
(WebBatteryManager):
- WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebNetworkInfoManager):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveCoordinatedLayerTreeHostMessage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- WebProcess/soup/WebSoupRequestManager.h:
(WebSoupRequestManager):
- 7:38 PM Changeset in webkit [141365] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Re-enabling fast/workers/storage tests after fix(r141320).
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 7:14 PM Changeset in webkit [141364] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG bytecode parser should have more assertions about the status of local accesses
https://bugs.webkit.org/show_bug.cgi?id=108417
Reviewed by Mark Hahnenberg.
Assert some things that we already know to be true, just to reassure ourselves that they are true.
This is meant as a prerequisite for https://bugs.webkit.org/show_bug.cgi?id=108414, which will
make these rules even stricter.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
- 6:40 PM Changeset in webkit [141363] by
-
- 14 edits4 adds in trunk
The background HTML parser should be able to parse speculatively
https://bugs.webkit.org/show_bug.cgi?id=107753
Reviewed by Eric Seidel.
Source/WebCore:
This patch adds the ability for the foreground HTML parser to
invalidate speculative parsing done by the background HTML parser.
Currently, we're a bit overly agressive an invalidate all speculations
on document.write. We plan to refine that in the future.
Test: fast/parser/document-write-partial-script.html
- WebCore.gypi:
- html/parser/BackgroundHTMLInputStream.cpp: Added.
(WebCore):
(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::append):
(WebCore::BackgroundHTMLInputStream::close):
(WebCore::BackgroundHTMLInputStream::createCheckpoint):
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLInputStream.h: Added.
(WebCore):
(BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::current):
(WebCore::BackgroundHTMLInputStream::Checkpoint::Checkpoint):
(Checkpoint):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::append):
(WebCore):
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::markEndOfFile):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
(WebCore::BackgroundHTMLParser::resumeFromPartial):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(ParsedChunk):
(HTMLDocumentParser):
LayoutTests:
- fast/parser/document-write-partial-script-expected.txt: Added.
- fast/parser/document-write-partial-script.html: Added.
- 6:38 PM Changeset in webkit [141362] by
-
- 4 edits70 moves4 adds in trunk/LayoutTests
[Mac Lion] [WK2] tiled-drawing tests are being run when they shouldn't be
https://bugs.webkit.org/show_bug.cgi?id=106187
Reviewed by Ryosuke Niwa.
Since the feature is mac-wk2 only, move the tests from platform mac to platform mac-wk2 and just
skip the tests on Lion entirely.
- platform/mac-lion/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-background-no-image.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-positioned.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-html-background.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-fixed.html.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html.
- platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-in-overflow.html.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars-zoomed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars-zoomed.html.
- platform/mac-wk2/tiled-drawing/fixed/four-bars.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars.html.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset-in-view.html.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset.html.
- platform/mac-wk2/tiled-drawing/fixed/nested-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/nested-fixed.html.
- platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/percentage-inside-fixed.html.
- platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt.
- platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-after-scroll.html.
- platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt.
- platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html.
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/negative-scroll-offset-expected.txt.
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/negative-scroll-offset.html.
- platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-horizontal-expected.txt.
- platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-horizontal.html.
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-vertical-expected.txt.
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-vertical.html.
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt.
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-after-scroll.html.
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt.
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom.html.
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt.
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled.html.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom.html.
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/use-tiled-drawing-expected.txt.
- platform/mac-wk2/tiled-drawing/use-tiled-drawing.html: Renamed from LayoutTests/platform/mac/tiled-drawing/use-tiled-drawing.html.
- platform/mac/TestExpectations:
- 6:30 PM Changeset in webkit [141361] by
-
- 97 edits in trunk/Source/WebKit2
Remove MessageID from MessageSender
https://bugs.webkit.org/show_bug.cgi?id=108413
Reviewed by Andreas Kling.
This is another step towards eliminating MessageID.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcess):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):
- Platform/CoreIPC/Connection.h:
(QueueClient):
(CoreIPC::Connection::waitForAndDispatchImmediately):
- Platform/CoreIPC/MessageReceiver.h:
(MessageReceiver):
(CoreIPC::MessageReceiver::didReceiveSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.h:
(MessageReceiverMap):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didReceiveMessage):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
- Scripts/webkit2/messages.py:
(forward_declarations_and_headers):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveMessage):
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
(WebKit::ChildProcessProxy::send):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::didReceiveMessage):
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/Plugins/NPRemoteObjectMap.h:
(NPRemoteObjectMap):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::didReceiveMessage):
- Shared/WebConnection.h:
(WebConnection):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::didReceiveMessage):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didReceiveCoordinatedLayerTreeHostProxyMessage):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didReceiveCoordinatedLayerTreeHostProxyMessage):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
(WebKit::CustomProtocolManagerProxy::didReceiveMessage):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
- UIProcess/Network/NetworkProcessProxy.h:
(NetworkProcessProxy):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveMessage):
- UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didReceiveMessage):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
(SharedWorkerProcessProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::dispatchMessage):
(WebKit::WebContext::dispatchSyncMessage):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didReceiveMessage):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::didReceiveMessage):
(WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage):
- UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::didReceiveMessage):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::didReceiveMessage):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::didReceiveMessage):
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didReceiveMessage):
- WebProcess/FullScreen/WebFullScreenManager.h:
(WebFullScreenManager):
- WebProcess/Geolocation/WebGeolocationManager.h:
(WebGeolocationManager):
- WebProcess/IconDatabase/WebIconDatabaseProxy.h:
(WebIconDatabaseProxy):
- WebProcess/MediaCache/WebMediaCacheManager.h:
(WebMediaCacheManager):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/NetworkProcessConnection.h:
(NetworkProcessConnection):
- WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
(PluginProcessConnection):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
- WebProcess/Storage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::didReceiveMessage):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveCoordinatedLayerTreeHostMessage):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebPageGroupProxy):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.h:
(WebProcess):
- 6:21 PM Changeset in webkit [141360] by
-
- 8 edits in trunk/Source/WebCore
[V8] Add IDL 'enum' support to CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=106553
Patch by Nils Barth <nbarth@google.com> on 2013-01-30
Reviewed by Kentaro Hara.
Add partial support for Web IDL enumerations in V8 bindings
Binding generators currently cannot handle IDL enumerations.
(An enumeration is an DOMString with a limited set of values, thus
treated internally as DOMString, with validation code added in
bindings.)
This adds support for enumerations in V8, adding validation checking
to setters.
It does not add validation checking to operations (no test case), and
does not add support in JSC.
Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
- bindings/scripts/IDLParser.pm:
- Parser assumes all IDL definitions are interfaces; add support for other definitions
- Parser parses but discards enum definitions; instead, record parsed data
(Parse): Sort definitions into interfaces and enums.
Remove "@definitions eq (someIdlDocument)" test, as this never
happens (fossil code) -- parseDefinitions returns list of definitions,
never a one-item list consisting of a document (no nested documents).
(unquoteString): new utility function to unquote StringToken (token
itself still quoted)
(parseEnum):
(parseEnumValueList):
(parseEnumValues):
(parseEnumOld):
- bindings/scripts/CodeGenerator.pm:
- Expose parsed enum data to backends (detect enums, list valid values)
- Enums treated as DOMString type in internal function
(ProcessDocument):
(IsEnumType):
(ValidEnumValues):
(IsRefPtrType):
- bindings/scripts/CodeGeneratorV8.pm:
- Enums treated as DOMString type in internal functions
- Add validation to setter
(GenerateNormalAttrSetter):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):
(ConvertToV8StringResource):
- bindings/scripts/test/TestObj.idl:
- New enum type and enum variable test for IDL enumeration support
- bindings/scripts/test/V8/V8TestObj.cpp:
- Generated code, desired behavior
(WebCore::TestObjV8Internal::enumAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enumAttrAttrSetter):
(WebCore):
- bindings/scripts/test/JS/JSTestObj.cpp:
- Generated code, currently incorrect
(WebCore):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
- bindings/scripts/test/JS/JSTestObj.h:
- Generated code, currently incorrect
(WebCore):
- 6:19 PM Changeset in webkit [141359] by
-
- 4 edits in trunk/Source/WebKit2
PDFPlugin: Update scrollbars if PDFLayerController's display mode changes
https://bugs.webkit.org/show_bug.cgi?id=108412
<rdar://problem/13002261>
Reviewed by Simon Fraser.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add pdfLayerController:didChangeDisplayMode:
- WebProcess/Plugins/PDF/PDFPlugin.h: Add notifyDisplayModeChanged().
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeDisplayMode:]): Forward didChangeDisplayMode to notifyDisplayModeChanged.
(WebKit::PDFPlugin::notifyDisplayModeChanged): Update content size and scrollbar size when display mode changes.
- 6:17 PM Changeset in webkit [141358] by
-
- 6 edits in trunk/Source
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408
Reviewed by Kentaro Hara.
I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.
Source/WebCore:
- bindings/v8/custom/V8IntentCustom.cpp:
Source/WebKit/chromium:
- WebKit.gyp:
- features.gypi:
- src/WebFrameImpl.cpp:
- 6:15 PM Changeset in webkit [141357] by
-
- 5 edits2 adds in trunk
[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381
Reviewed by James Robinson.
Source/WebKit/chromium:
WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):
Tools:
- DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
LayoutTests:
- platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
- platform/chromium/plugins/re-request-touch-events-crash.html: Added.
- 6:13 PM Changeset in webkit [141356] by
-
- 4 edits in trunk/Source
Start sending scrollType as NonBubblingGesture for flings
https://bugs.webkit.org/show_bug.cgi?id=108372
Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-01-30
Reviewed by James Robinson.
Source/Platform:
Using the newly defined scrollType layerTreeHostImpl will stop bubbling flings to
parent layers. It will only bubble if the child layer is at the end of its scroll
range
- chromium/public/WebInputHandlerClient.h:
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- 6:11 PM Changeset in webkit [141355] by
-
- 6 edits in trunk/Tools
Add a concept of dashboard parameters that invalidate others
https://bugs.webkit.org/show_bug.cgi?id=108362
Reviewed by Dirk Pranke.
There are certain parameters to the dashboards, that when selected,
invalidate others, such as selecting the test type invalidates the
builder group. Add this concept to dashboard_base and allow specifc
dashboard to add their own invalidating parameters.
The result is that when the user takes a specific action, like changing
the test type, the builder would get reset to the default for the new
test type, rather than erroring or not matching the query param, as is
the current behavior.
Also deletes some unused code (selectBuilder).
- TestResultServer/static-dashboards/dashboard_base.js:
(invalidateQueryParameters):
(setQueryParameter):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- 6:07 PM Changeset in webkit [141354] by
-
- 9 edits24 adds in trunk/LayoutTests
Tests for spellcheck behavior
https://bugs.webkit.org/show_bug.cgi?id=108405
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-30
Reviewed by Tony Chang.
- editing/spelling/resources/util.js: Added. Boilerplate for spellcheck tests.
- editing/spelling/spelling-double-clicked-word.html: Added. Spelling should work for double-clicked misspellings.
- editing/spelling/spelling-double-clicked-word-with-underscores.html: Added. Underscores should be treated as whitespace: spelling should ignore them.
- editing/spelling/spelling-exactly-selected-multiple-words.html: Added. Spelling should work when the user selects a multi-word misspelling exactly.
- editing/spelling/spelling-exactly-selected-word.html: Added. Spelling should work when the user selects the misspelled word exactly.
- editing/spelling/spelling-multiword-selection.html: Added. Spelling should be disabled when user selects multiple words that are not a single misspelling.
- editing/spelling/spelling-should-select-multiple-words.html: Added. Spellcheck should select multi-word misspellings on context click.
- editing/spelling/spelling-should-select-single-word.html: Added. Spellcheck should select the misspelled word on context click.
- editing/spelling/spelling-subword-selection.html: Added. Spelling should be disabled when user selects a part of misspelling.
- editing/spelling/spelling-with-punctuation-selection.html: Added. Punctuation marks should be treated as whitespace: spelling should ignore them.
- editing/spelling/spelling-with-underscore-selection.html: Added. Underscores should be treated as whitespace: spelling should ignore them.
- editing/spelling/spelling-with-whitespace-selection.html: Added. Spelling should ignore whitespace.
- editing/spelling/spelling-double-clicked-word-expected.txt: Added.
- editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Added.
- editing/spelling/spelling-exactly-selected-multiple-words-expected.txt: Added.
- editing/spelling/spelling-exactly-selected-word-expected.txt: Added.
- editing/spelling/spelling-multiword-selection-expected.txt: Added.
- editing/spelling/spelling-should-select-multiple-words-expected.txt: Added.
- editing/spelling/spelling-should-select-single-word-expected.txt: Added.
- editing/spelling/spelling-subword-selection-expected.txt: Added.
- editing/spelling/spelling-with-punctuation-selection-expected.txt: Added.
- editing/spelling/spelling-with-underscore-selection-expected.txt: Added.
- editing/spelling/spelling-with-whitespace-selection-expected.txt: Added.
- platform/chromium/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/efl/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/gtk/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/mac/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/qt/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/wincairo/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/win/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/wk2/TestExpectations: Skip the tests until the platform implements the behavior.
- 6:07 PM Changeset in webkit [141353] by
-
- 2 edits in trunk/Tools
Disable process suppression of DumpRenderTree on Mac
https://bugs.webkit.org/show_bug.cgi?id=108400
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-30
Reviewed by Jessie Berlin.
- DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment): Take assertion to prevent
process suppression.
- 5:39 PM Changeset in webkit [141352] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Add WebFrame::visibleContentRect()
https://bugs.webkit.org/show_bug.cgi?id=108311
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-30
Reviewed by James Robinson.
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visibleContentRect):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 5:31 PM Changeset in webkit [141351] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed
https://bugs.webkit.org/show_bug.cgi?id=108131
Reviewed by Tony Chang.
A patch was landed in r140027 to prevent a null pointer crash in
IDBRequest::dispatchEvent and confirm the source of the crash (which
we couldn't repro locally). Following confirmation from user reports,
the root cause was tracked down to a race condition in MessageQueue,
and was fixed in r140483. This patch is no longer needed, and there's
always been an ASSERT in place to catch regressions while debugging.
No new tests - no behavior change.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent): Remove extraneous test.
- 5:26 PM Changeset in webkit [141350] by
-
- 6 edits in trunk/Source/WebCore
[BlackBerry] Store both proxy and host credentials simultaneously for NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=108388
Patch by Joe Mason <jmason@rim.com> on 2013-01-30
Reviewed by Yong Li.
The platform NetworkRequest interface has been updated again, to store both a proxy and host
credential for each request (to prevent an infinite loop when a request authenticates against a
proxy but fails the host authentication, and then the followup contains the host credential but not
the proxy credential so it fails proxy authentication, so the next followup contains the proxy
credential but not the host credential...)
Complying with the new interface requires the host and proxy challenge to be stored separately in
webkit so they can both be added to the same NetworkRequest.
Internal PR: 281172
Internal Reviewer: Leo Yang
- platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal):
- platform/network/blackberry/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::hasCredentials):
(AuthenticationChallenge):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleRedirect):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::storeCredentials):
(WebCore):
(WebCore::NetworkJob::purgeCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
(WebCore::NetworkJob::updateCurrentWebChallenge):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::setAuthCredentials):
(WebCore):
(WebCore::NetworkManager::startJob):
- 5:22 PM Changeset in webkit [141349] by
-
- 2 edits in trunk/Tools
Enable tests for Windows EWS!
https://bugs.webkit.org/show_bug.cgi?id=107968.
Patch by Lucas Forschler.
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 5:08 PM Changeset in webkit [141348] by
-
- 2 edits in trunk/Source/WebCore
Make JSEventListener more robust in the event of the compiled handler being released.
https://bugs.webkit.org/show_bug.cgi?id=108390
Reviewed by Michael Saboff.
It shouldn't be possible for a handler to be collected for any object that
might still trigger an event. Nonetheless it does still happen, and the
only point of failure that currently exists is compiling the handler.
This patch is mostly just assertions, but also removes a bunch of field
clearing that was previously being performed. Given we do seem to periodically
end up needing to recompile a handler this appears to be necessary. That
said there does not appear to be a memory hit from this as the event handlers
that make us use JSLazyEventListener are not frequently compiled, and the bulk
of the functions that are compiled end up causing us to keep the strings around
anyway.
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
- 5:05 PM Changeset in webkit [141347] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, update expectations on Mac for textarea change.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- 4:56 PM Changeset in webkit [141346] by
-
- 17 edits2 adds in trunk
Implement KeyboardEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=108320
Reviewed by Adam Barth.
Source/WebCore:
This patch implements KeyboardEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
This significantly simplifies a code to construct a KeyboardEvent.
Before:
e = document.createEvent("KeyboardEvent");
e.initKeyboardEvent("keypress", true, true, null, false, false, false, false, 0, 0);
After:
e = new KeyboardEvent("keypress");
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
- 'char' and 'code' are not yet supported due to lack of WebCore implementation.
- 'altGraphKey' is not supported because it's an extended attribute in WebKit
and is not speced.
- Renamed keyboard event constant variables to avoid style errors.
Test: fast/events/constructors/keyboard-event-constructor.html
- dom/KeyboardEvent.cpp:
(WebCore::keyLocationCode):
(WebCore::KeyboardEventInit::KeyboardEventInit):
(WebCore):
(WebCore::KeyboardEvent::KeyboardEvent):
- dom/KeyboardEvent.h:
(WebCore):
(WebCore::KeypressCommand::KeypressCommand):
(KeypressCommand):
(KeyboardEventInit):
(KeyboardEvent):
(WebCore::KeyboardEvent::create):
(WebCore::KeyboardEvent::keyIdentifier):
(WebCore::KeyboardEvent::keyLocation):
(WebCore::KeyboardEvent::altGraphKey):
(WebCore::KeyboardEvent::keyEvent):
(WebCore::KeyboardEvent::keypressCommands):
- dom/KeyboardEvent.idl:
Source/WebKit/chromium:
Renamed keyboard event constant variables to avoid style errors.
- src/WebInputEventConversion.cpp:
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
- tests/WebInputEventConversionTest.cpp:
- tests/WebInputEventFactoryTestGtk.cpp:
LayoutTests:
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
This patch implements KeyboardEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/events/constructors/keyboard-event-constructor-expected.txt: Added.
- fast/events/constructors/keyboard-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 4:55 PM Changeset in webkit [141345] by
-
- 4 edits in branches/safari-536.28-branch/Source
Versioning.
- 4:54 PM Changeset in webkit [141344] by
-
- 1 edit2 deletes in trunk/LayoutTests
[chromium] Unreviewed, update expectations Linux 32 textarea tests.
- platform/chromium-linux-x86/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
- platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.png: Removed.
- 4:53 PM Changeset in webkit [141343] by
-
- 1 copy in tags/Safari-536.28.10
New Tag.
- 4:50 PM Changeset in webkit [141342] by
-
- 5 edits in trunk
Add a StringTypeAdapter for ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=108338
Reviewed by Benjamin Poulain.
Source/WTF:
Add StringTypeAdapter for ASCIILiteral type so that concatenation of an
ASCIILiteral and a String using + operator is efficiently handled.
- wtf/text/StringConcatenate.h:
- wtf/text/StringOperators.h:
(WTF::operator+): Inline some of the operator+ functions that were not
yet.
(WTF):
Tools:
Add API tests for operator+() taking an ASCIILiteral.
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
(TestWebKitAPI::TEST):
- 4:49 PM Changeset in webkit [141341] by
-
- 2 edits in trunk/Tools
Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
Rubberstamped by Timothy Horton.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 4:32 PM Changeset in webkit [141340] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed, update expectations for Win/Mac
Rebaseline one more textarea test on Linux.
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium/TestExpectations:
- 4:28 PM Changeset in webkit [141339] by
-
- 2 edits in trunk/LayoutTests
Mark tests as failing after r141303.
These tests were rebaselined before the bots had correct results. This change
marks these tests as [ ImageOnlyFailure Pass ] again while the bots catch up.
Unreviewed test expectations update.
- platform/chromium/TestExpectations:
- 4:25 PM Changeset in webkit [141338] by
-
- 5 edits in trunk/Source/WebCore
IndexedDB: IDBKeyRange::isOnlyKey() does pointer equality comparison
https://bugs.webkit.org/show_bug.cgi?id=107582
Reviewed by Tony Chang.
Per the bug title, IDBKeyRange::isOnlyKey() was testing the upper/lower pointers to
determine if this was a "trivial" range, which can be used to fast-path lookups. This
is insufficient in multi-process ports where range values may be thrown across the wire.
This is addressed by using the existing key equality tests.
In addition, the bounds type check incorrectly checked m_lowerType == LowerBoundOpen, which
meant the function could never return true (since upper == lower implies closed bounds).
Therefore, the fast-path case wasn't used even in single-process ports (e.g. DRT). The
slow-path case contructed a backing store cursor over the range, and exited early if the
cursor yielded nothing. The fast-path case doesn't need to create a cursor, so needs to
deal with lookup misses. This revealed two similar (but trivial) lurking bugs in the
fast-path.
No new behavior; covered by tests such as: storage/indexeddb/get-keyrange.html
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getRecord): Handle backing store read miss case.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::GetOperation::perform): Handle backing store read miss case.
- Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::isOnlyKey): Compare keys by value, not pointer, correct
type checks, add assertions.
- Modules/indexeddb/IDBKeyRange.h:
(IDBKeyRange): Move implementation to CPP file.
- 4:05 PM Changeset in webkit [141337] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r141205.
http://trac.webkit.org/changeset/141205
https://bugs.webkit.org/show_bug.cgi?id=108353
Command for running tests on windows needs to be investigated.
(Requested by lforschler on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-30
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:03 PM Changeset in webkit [141336] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Never store empty credentials in NetworkJob::storeCredentials
https://bugs.webkit.org/show_bug.cgi?id=108387
Patch by Joe Mason <jmason@rim.com> on 2013-01-30
Reviewed by Yong Li.
There is a code path that can cause NetworkJob::storeCredentials to be called with empty
credentials, causing the existing credentials to be overwritten even though authentication
succeeded. PR 287791 has been filed to investigate why this happens; in the meantime, ignore empty
credentials.
Internal PR: 281172
Internally Reviewed By: Leo Yang
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::storeCredentials):
- 3:52 PM Changeset in webkit [141335] by
-
- 4 edits1 add in trunk/Source/WebKit2
<rdar://problem/12695827> PPT: Make loading file URLs work with a sandboxed NetworkProcess
Reviewed by Sam Weinig.
- DerivedSources.make: Preprocess a .sb.in file to build the profile.
- NetworkProcess/mac/NetworkProcessMac.mm: Don't prevent entering the sandbox. Override sandbox path, because service gets a differnt one by default.
- WebKit2.xcodeproj/project.pbxproj:
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Added.
- 3:45 PM Changeset in webkit [141334] by
-
- 4 edits in trunk/Source/WebCore
ContentFilter should be a ref-counted class
https://bugs.webkit.org/show_bug.cgi?id=108392
Reviewed by David Kilzer.
- loader/MainResourceLoader.h:
(MainResourceLoader): Store a RefPtr to m_contentFilter.
- platform/ContentFilter.h: Inherit from RefCounted<ContentFilter>.
- platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::create): Return a PassRefPtr.
- 3:34 PM Changeset in webkit [141333] by
-
- 3 edits in trunk/Source/WebCore
[mac] ImageBuffer should create accelerated buffers for small canvases, but we shouldn't force them to create compositing layers
https://bugs.webkit.org/show_bug.cgi?id=107804
<rdar://problem/11752381>
Reviewed by Simon Fraser.
Make all canvases IOSurface-backed if requested, instead of having a size threshold
under which we won't use accelerated canvas.
Make requiresCompositingForCanvas take the size of the canvas into account, using
the threshold which was previously in ImageBuffer to determine whether or not a
canvas should be forced into a compositing layer.
This improves canvas performance on some benchmarks
(http://www.mikechambers.com/html5/javascript/QuadTree/examples/collision.html, for example)
significantly, in cases where canvases which fall below the size limit
(and thus are unaccelerated) are being drawn rapidly into either accelerated
tiles or another accelerated canvas, by preventing excessive copying to/from the GPU.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore):
(WebCore::ImageBuffer::ImageBuffer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
- 3:30 PM Changeset in webkit [141332] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: clean up scheduleTask return type
https://bugs.webkit.org/show_bug.cgi?id=108361
Reviewed by Tony Chang.
This is just a code simplification now that the
synchronous consumers of scheduleTask are gone.
No new tests: pure refactor.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
- 3:27 PM Changeset in webkit [141331] by
-
- 37 edits in trunk
[Chromium] Enable textarea resize corner for tests
https://bugs.webkit.org/show_bug.cgi?id=108385
Reviewed by Ojan Vafai.
Tools:
We should test what we ship. Also, this makes us pass more tests in content_shell.
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset): Turn on resize corner.
LayoutTests:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html:
This ref test would overlay 2 textarea on top of each other. Turn off the resize corner on one of them.
- fast/dom/shadow/shadowdom-for-textarea-without-shadow.html: Turn off the resize corner since the reference
file doesn't use a textarea.
- fast/repaint/textarea-set-disabled-expected.png:
- platform/chromium-linux/editing/inserting/4960120-1-expected.png:
- platform/chromium-linux/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png:
- platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-linux/fast/forms/basic-textareas-expected.png:
- platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
- platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/chromium-linux/fast/forms/negativeLineHeight-expected.png:
- platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
- platform/chromium-linux/fast/forms/textarea-align-expected.png:
- platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-linux/fast/forms/textarea-scroll-height-expected.png:
- platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-linux/fast/forms/textarea-setinnerhtml-expected.png:
- platform/chromium-linux/fast/forms/textarea-width-expected.png:
- platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-linux/fast/parser/entity-comment-in-textarea-expected.png:
- platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-linux/fast/table/003-expected.png:
- platform/chromium-linux/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug194024-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium/TestExpectations: Mark image failures for Mac and Win.
- 3:22 PM Changeset in webkit [141330] by
-
- 12 edits in trunk
Elements that dynamically become fixed sometimes jump to the top left on scrolling
https://bugs.webkit.org/show_bug.cgi?id=108389
Source/WebCore:
Reviewed by Beth Dakin.
When an element became position:fixed and gained a compositing layer
as a result, we would compute its viewport constraints (including the
last GraphicsLayer position) before we had actually updated the GraphicsLayer
geometry for the first time. This would cause a jump to 0,0 on scrolling.
Fix by removing the call to updateViewportConstraintStatus() just after
creating the backing. Instead, hook in to registerScrollingLayers(),
which is called on every geometry update, to update the viewport
constraints for this layer.
Tested via existing tests, which now show correct positions at last
layout.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::registerScrollingLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
LayoutTests:
Reviewed by Beth Dakin.
Update test results; these results now correctly reflect the last layout
positions.
- platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt:
- platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt:
- platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt:
- platform/mac/tiled-drawing/fixed/four-bars-expected.txt:
- platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt:
- platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt:
- platform/mac/tiled-drawing/sticky/sticky-horizontal-expected.txt:
- platform/mac/tiled-drawing/sticky/sticky-vertical-expected.txt:
- 3:19 PM Changeset in webkit [141329] by
-
- 2 edits in trunk/LayoutTests
Revert r138912, the right fix for https://bugs.webkit.org/show_bug.cgi?id=106187 is in
r141323.
- platform/mac-wk2/TestExpectations:
- 3:16 PM Changeset in webkit [141328] by
-
- 5 edits in trunk/Source/WebCore
HTMLDocumentParser::insert should be aware of threaded parsing
https://bugs.webkit.org/show_bug.cgi?id=107764
Reviewed by Eric Seidel.
This patch is an incremental step towards recovering from
document.write invalidating our speculative parsing buffer. The
approach I've taken is to make it possible to transfer the
HTMLDocumentParser's HTMLTokenizer and HTMLToken to the background
thread. To make that possible, I've taught the HTMLDocumentParser how
to operate without a tokenizer or a token.
Not having a tokenizer or a token while parsing in the background also
helps us avoid accidentially feeding input to the main thread's
tokenizer when we're supposed to feed it to the background thread.
This patch shouldn't have any behavior change (other than possibly
fixing a crash in fast/parser when threading parsing is enabled).
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::TextDocumentParser):
- 3:11 PM Changeset in webkit [141327] by
-
- 6 edits in trunk
[HTMLTemplateElement] prevent the parser from removing nodes from the content when the foster agency is processing formatting elements
https://bugs.webkit.org/show_bug.cgi?id=108377
Reviewed by Adam Barth.
Source/WebCore:
callTheAdoptionAgency now appends to the template's content when it previously would have appended to the template element itself.
New test added to html5lib.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
LayoutTests:
Note that dump-as-markup.js is modified here to put both template content and its direct children. This was an oversight and fixing it will make it
easier to spot parse errors like ones that arise from this bug, where nodes are appended directly to the template element.
- html5lib/resources/template.dat:
- resources/dump-as-markup.js:
(Markup._get):
- 3:06 PM Changeset in webkit [141326] by
-
- 5 edits4 deletes in trunk/LayoutTests
Update fast/backgrounds/size/contain-and-cover-zoomed test expectations.
Unreviewed update of test expectations.
- platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium/TestExpectations:
- 3:00 PM Changeset in webkit [141325] by
-
- 5 edits in trunk/Source/WebKit2
Coordinated Graphics: LayerTreeRenderer manages the surface of UpdateAtlas.
https://bugs.webkit.org/show_bug.cgi?id=107224
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Benjamin Poulain.
Currently, CoordinatedLayerTreeHostProxy manages the surface of UpdateAtlas, but
all other resources are managed by LayerTreeRenderer. This patch matches the
surface of UpdateAtlas to other resources.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::updateTileForLayer):
(WebKit::CoordinatedLayerTreeHostProxy::createUpdateAtlas):
(WebKit::CoordinatedLayerTreeHostProxy::removeUpdateAtlas):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::createUpdateAtlas):
(WebKit):
(WebKit::LayerTreeRenderer::removeUpdateAtlas):
(WebKit::LayerTreeRenderer::purgeGLResources):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):
(LayerTreeRenderer):
- 2:58 PM Changeset in webkit [141324] by
-
- 4 edits in trunk/LayoutTests
Update chromium-mac svg/zoom test expectations after r141303
Unreviewed update of test expectations.
- platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- 2:49 PM Changeset in webkit [141323] by
-
- 2 edits in trunk/LayoutTests
Don't run the tiled-drawing tests on Lion WK2.
- platform/mac-wk2/TestExpectations:
Even though the platform/mac/tiled-drawing tests were skipped in the Lion TestExpectations
file, the Pass value in the mac-wk2 TestExpectations file was causing them to be run on
Lion WK2. Explicity skip the tests on Lion here as well.
- 2:48 PM Changeset in webkit [141322] by
-
- 75 edits in trunk/Source/WebKit2
Remove MessageID parameter from generated message receivers
https://bugs.webkit.org/show_bug.cgi?id=108379
Reviewed by Beth Dakin.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcess):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveMessage):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- PluginProcess/PluginControllerProxy.h:
(PluginControllerProxy):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didReceiveMessage):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
- Scripts/webkit2/messages.py:
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveMessage):
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::didReceiveMessage):
- Shared/Plugins/NPObjectMessageReceiver.h:
(NPObjectMessageReceiver):
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::didReceiveMessage):
- Shared/WebConnection.h:
(WebConnection):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::didReceiveMessage):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
(WebKit::CustomProtocolManagerProxy::didReceiveMessage):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
- UIProcess/Network/NetworkProcessProxy.h:
(NetworkProcessProxy):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveMessage):
- UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didReceiveMessage):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
(SharedWorkerProcessProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didReceiveMessage):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::didReceiveMessage):
(WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage):
- UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::didReceiveMessage):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::didReceiveMessage):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::didReceiveMessage):
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didReceiveMessage):
- WebProcess/FullScreen/WebFullScreenManager.h:
(WebFullScreenManager):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/WebResourceLoader.h:
(WebResourceLoader):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
(PluginProcessConnection):
- WebProcess/Plugins/PluginProxy.h:
(PluginProxy):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::didReceiveMessage):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebPage/WebInspector.h:
(WebInspector):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.h:
(WebProcess):
- 2:46 PM Changeset in webkit [141321] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSContext's dealloc causes ASSERT due to ordering of releases
https://bugs.webkit.org/show_bug.cgi?id=107978
Reviewed by Filip Pizlo.
We need to add the Identifier table save/restore in JSContextGroupRelease so that we
have the correct table if we end up destroying the JSGlobalData/Heap.
- API/JSContextRef.cpp:
(JSContextGroupRelease):
- 2:45 PM Changeset in webkit [141320] by
-
- 2 edits in trunk/Source/WebCore
DatabaseContext should implement ThreadSafeRefCounted.
https://bugs.webkit.org/show_bug.cgi?id=108285.
Reviewed by Alexey Proskuryakov.
DatabaseManager::interruptAllDatabasesForContext() can ref a
DatabaseContext from another thread. Hence, the DatabaseContext needs
to be a ThreadSafeRefCounted instead of a RefCounted.
No new tests.
- Modules/webdatabase/DatabaseContext.h:
- 2:44 PM Changeset in webkit [141319] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][UNIX] g_spawn_sync() generates warning in PluginProcessProxy::scanPlugin()
https://bugs.webkit.org/show_bug.cgi?id=108371
Patch by Christophe Dumez <dchris@gmail.com> on 2013-01-30
Reviewed by Martin Robinson.
g_spawn_sync() was sometimes displaying a warning about the SIGCHLD
signal disposition not being set to SIG_DFL, despite the fix in r133755.
The reason was that the code was only setting the disposition to SIG_DFL
if the previous disposition was SIG_IGN.
In this patch, we set the SIGCHLD signal disposition to SIG_DFL, no
matter what its previous disposition was. Also, the signal disposition
is now restored to its previous state after the call to g_spawn_sync()
to avoid side effects. Finally, we now use SIGCHLD instead of SIDCLD
since this is the more compatible POSIX name.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::spawnProcessSync):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):
- 2:43 PM Changeset in webkit [141318] by
-
- 15 edits2 adds in trunk
Implement WheelEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=108303
Reviewed by Adam Barth.
Source/WebCore:
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
This patch implements UIEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
Test: fast/events/constructors/wheel-event-constructor.html
- dom/WheelEvent.cpp:
(WebCore::WheelEventInit::WheelEventInit):
(WebCore):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
- dom/WheelEvent.h:
(WheelEventInit):
(WebCore):
(WheelEvent):
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::wheelDelta):
(WebCore::WheelEvent::wheelDeltaX):
(WebCore::WheelEvent::wheelDeltaY):
(WebCore::WheelEvent::rawDeltaX):
(WebCore::WheelEvent::rawDeltaY):
(WebCore::WheelEvent::granularity):
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice):
(WebCore::WheelEvent::isHorizontal):
- dom/WheelEvent.idl:
Source/WebKit/chromium:
This patch just renames an enum value to avoid style check error.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
LayoutTests:
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
This patch implements UIEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
Test: fast/events/constructors/wheel-event-constructor.html
- fast/events/constructors/wheel-event-constructor-expected.txt: Added.
- fast/events/constructors/wheel-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 2:41 PM Changeset in webkit [141317] by
-
- 3 edits4 adds in trunk
[CSS Grid Layout] Support 'auto' sized grid items
https://bugs.webkit.org/show_bug.cgi?id=103332
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-grid-layout/auto-content-resolution-columns.html
fast/css-grid-layout/auto-content-resolution-rows.html
The specification interprets 'auto' as minmax(min-content, max-content).
Because we stored the grid definitions as an 'auto' length, we wouldn't
handle it properly during layout.
This change makes us do the translation when we query the information for
layout.
- rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
Translate 'auto' to minmax(min-content, max-content). This works as getComputedStyle
still sees the GridTrackSize as a single length and thus query length() instead of the
individual component of minmax().
LayoutTests:
- fast/css-grid-layout/auto-content-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/auto-content-resolution-columns.html: Added.
- fast/css-grid-layout/auto-content-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/auto-content-resolution-rows.html: Added.
- 2:39 PM Changeset in webkit [141316] by
-
- 4 edits3 adds in trunk
IndexedDB: Avoid crashing when deleting indexes
https://bugs.webkit.org/show_bug.cgi?id=108356
Reviewed by Tony Chang.
Source/WebCore:
It is reasonable that the backend aborts a transaction before
the frontend is aware, depending on the timing of events. This
allows the transactionId to be invalid rather than asserting.
Test: storage/indexeddb/createIndex-after-failure.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::IDBDatabaseBackendImpl::openCursor):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::IDBDatabaseBackendImpl::deleteRange):
(WebCore::IDBDatabaseBackendImpl::clear):
LayoutTests:
This test works on an edge case around the asynchronous
creation/deletion of indexes that used to crash. It doesn't fail/crash even
without this patch but was the test condition that uncovered the overall problem
before https://bugs.webkit.org/show_bug.cgi?id=107311 changed the timing of
some of the events.
- storage/indexeddb/createIndex-after-failure.html: Added.
- storage/indexeddb/resources/createIndex-after-failure.js: Added.
(sleep):
(prepareDatabase):
(deleteIndexAfterGet):
- storage/indexeddb/resources/shared.js:
(.requests.forEach):
(waitForRequests):
- storage/indexeddb/createIndex-after-failure.html: Added.
- storage/indexeddb/resources/createIndex-after-failure.js: Added.
(prepareDatabase):
(deleteIndexAfterGet):
- storage/indexeddb/resources/shared.js:
(.requests.forEach):
(waitForRequests):
- 2:36 PM Changeset in webkit [141315] by
-
- 5 edits in trunk/Source/WebCore
isSameAsCurrentState() should take SerializedScriptValue* instead of PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=107904
Reviewed by Darin Adler.
Applied Darin's comment: https://bugs.webkit.org/show_bug.cgi?id=107904#c5
No tests. No change in behavior.
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- page/History.cpp:
(WebCore::History::isSameAsCurrentState):
- page/History.h:
(History):
- 2:32 PM Changeset in webkit [141314] by
-
- 7 edits in trunk/Source/WebCore
Remove unnecessary setAnimating() method
https://bugs.webkit.org/show_bug.cgi?id=107495
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-01-30
Reviewed by Dean Jackson.
The corresponding accessor and uses were removed in r39211.
No new tests: no change in behaviour.
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
- page/animation/AnimationBase.h:
(AnimationBase):
- page/animation/CompositeAnimation.cpp:
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- 2:30 PM Changeset in webkit [141313] by
-
- 4 edits in trunk/Source/WebCore
Clean up interface to ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=108300
Reviewed by Dimitri Glazkov.
Lots of general clean up to ShadowRoot removing unused headers and forward
declarations, moving short inline methods into the class definition so it's
easier to understand what methods do what, and replacing macros with methods
with inline methods.
No new tests, just refactoring.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::setInnerHTML): Use isOrphan instead of macro.
(WebCore::ShadowRoot::setApplyAuthorStyles): Use isOrphan instead of macro.
(WebCore::ShadowRoot::setResetStyleInheritance): Use isOrphan instead of macro.
(WebCore::ShadowRoot::childrenChanged): Use isOrphan instead of macro.
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::setHost): Removed.
(WebCore::ShadowRoot::host):
(WebCore::ShadowRoot::owner):
(ShadowRoot):
(WebCore::ShadowRoot::isOrphan): Replacement of GuardOrphanShadowRoot macro.
- 2:30 PM Changeset in webkit [141312] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Remove useless comment from Base.xcconfig
Rubber-stamped by Mark Rowe.
- Configurations/Base.xcconfig: Remove comment.
- 2:29 PM Changeset in webkit [141311] by
-
- 7 edits in trunk/LayoutTests
Update svg/zoom test expectations after r141303
Unreviewed update of test expectations.
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- 2:27 PM Changeset in webkit [141310] by
-
- 16 edits in trunk/Source/WebKit2
[EFL][Qt][WK2] We should consider a page scale factor in WebCore instead of our own scale factor.
https://bugs.webkit.org/show_bug.cgi?id=105978
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Simon Fraser.
Currently, PageViewportController sends a page scale factor to Coordinated
Graphics System regardless of the page scale factor in WebCore. This patch makes
Coordinated Graphics System use the page scale factor in WebCore to match other
ports.
When it is needed to change a page scale, PageViewportController sends the scale
to Page in Web Process via WebPageProxy::scalePage. When the page scale in
WebCore is changed, CoordinatedGraphicsLayer gets notified via
deviceOrPageScaleFactorChanged callback. CoordinatedGraphicsLayer uses the page
scale factor like previous our own scale factor.
We set true to applyDeviceScaleFactorInCompositor and
ApplyPageScaleFactorInCompositor in Settings like chromium, because
TiledBackingStore that is a backing store of each GraphicsLayer applies the
scale to our raster graphics engines instead of applying the scale to the local
transform of each render object.
Thank Kenneth Rohde Christiansen for implementing the base patch of this patch.
No new tests. Covered by existing tests.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setSize):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
Does not receive a pageScaleFactor argument because
PageViewportController sends a page scale factor to Page.
However, this method still receives a scroll position because we
enable delegates scrolling.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::deviceOrPageScaleFactorChanged):
(WebCore::CoordinatedGraphicsLayer::effectiveContentsScale):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::deviceScaleFactor):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::pageScaleFactor):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 2:27 PM Changeset in webkit [141309] by
-
- 12 edits in branches/safari-536.28-branch
Merged r138606. <rdar://problem/13117769>
- 2:24 PM Changeset in webkit [141308] by
-
- 6 edits1 add in trunk/Source/WTF
Upstream iOS build file changes for WTF
<http://webkit.org/b/108221>
Reviewed by Mark Rowe.
- Configurations/Base.xcconfig:
- Import iOS.xcconfig.
- Remove VALID_ARCHS. Modern Xcodes define these correctly.
- Make HEADER_SEARCH_PATHS work with iOS Simulator builds.
- Add SUPPORTED_PLATFORMS so both Mac and iOS SDKs appear in schemes.
- Define INSTALL_PATH when building for macosx SDK.
- Configurations/CopyWTFHeaders.xcconfig:
- Make PRIVATE_HEADERS_FOLDER_PATH work with iOS Simulator builds.
- Configurations/DebugRelease.xcconfig:
- Simplify ARCHS. This works correctly on 32-bit-only SDKs.
- Configurations/WTF.xcconfig:
- Fix installation directory for iOS Simulator builds by defining INSTALL_PATH_ACTUAL.
- Configurations/iOS.xcconfig: Add.
- WTF.xcodeproj/project.pbxproj:
- Add iOS.xcconfig to the project.
- 2:20 PM Changeset in webkit [141307] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Temporarily change expectations for tests affected by tiling shaders
https://bugs.webkit.org/show_bug.cgi?id=108367
Patch by Brian Anderson <brianderson@chromium.org> on 2013-01-30
Reviewed by Adrienne Walker.
- platform/chromium/TestExpectations:
- 2:17 PM Changeset in webkit [141306] by
-
- 2 edits in trunk/Source/WebCore
Apple's internal PLT test suite doesn't finish after r141136
https://bugs.webkit.org/show_bug.cgi?id=108380
Reviewed by Alexey Proskuryakov.
Temporarily disable the feature to see if that fixes it.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- 2:16 PM Changeset in webkit [141305] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: exceptionHandler needs to be released in JSContext dealloc
https://bugs.webkit.org/show_bug.cgi?id=108378
Reviewed by Filip Pizlo.
JSContext has a (copy) exceptionHandler property that it doesn't release in dealloc.
That sounds like the potential for a leak. It should be released.
- API/JSContext.mm:
(-[JSContext dealloc]):
- 1:55 PM Changeset in webkit [141304] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed gardening.
Attempted Mac build fix after http://trac.webkit.org/changeset/141291.
- platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp:
(WebCore::harfBuzzCoreTextGetFontFuncs):
- 1:09 PM Changeset in webkit [141303] by
-
- 8 edits in trunk
Track scale and zoom together when drawing SVG images
https://bugs.webkit.org/show_bug.cgi?id=108108
Reviewed by Tim Horton.
Source/WebCore:
This patch refactors SVGImage::drawSVGToImageBuffer to take a single zoomAndScale parameter
and removes two messy calls to setPageZoomFactor. This patch makes progress towards an
SVG image cache keyed on just container size and scale.
This refactoring is covered by existing tests.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
This complex logic has been refactored out of CachedImage and into SVGImageCache.
In addition to the code move, we no longer divide by the zoom factor because the
container size is stored without zoom.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
This method signature has changed to take a FloatSize for the container size and
a combined zoom and scale parameter (zoomAndScale). A FloatSize is needed for the
container size because we now store the container size unzoomed, and in this process
we do not want to lose precision.
The messy setPageZoomFactor calls have also been removed which cleans this function up.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):
This function now stores the container size unzoomed. The container size was changed
to a FloatSize so that precision is not lost.
(WebCore::SVGImageCache::imageSizeForRenderer):
Note that the ImageBuffer size will stay the same. We now store the size as:
containerSize (without zoom) * zoom * scale
Previously this was:
containerSize (with zoom) * scale
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
- svg/graphics/SVGImageCache.h:
(WebCore::SVGImageCache::SizeAndScales::SizeAndScales):
(SizeAndScales):
(SVGImageCache):
LayoutTests:
- platform/chromium/TestExpectations:
- 1:03 PM Changeset in webkit [141302] by
-
- 7 edits in trunk/Source
[chromium] Add recordRenderingStats to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=108358
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setRecordRenderingStats):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::recordRenderingStats):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 1:02 PM Changeset in webkit [141301] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(140504): pure CSE no longer matches things, 10% regression on Kraken
https://bugs.webkit.org/show_bug.cgi?id=108366
Reviewed by Geoffrey Garen and Mark Hahnenberg.
This was a longstanding bug that was revealed by http://trac.webkit.org/changeset/140504.
Pure CSE requires that the Node::flags() that may affect the behavior of a node match,
when comparing a possibly redundant node to its possible replacement. It was doing this
by comparing Node::arithNodeFlags(), which as the name might appear to suggest, returns
just those flag bits that correspond to actual node behavior and not auxiliary things.
Unfortunately, Node::arithNodeFlags() wasn't actually masking off the irrelevant bits.
This worked prior to r140504 because CSE itself didn't mutate the flags, so there was a
very high probability that matching nodes would also have completely identical flag bits
(even the ones that aren't relevant to arithmetic behavior, like NodeDoesNotExit). But
r140504 moved one of CSE's side-tables (m_relevantToOSR) into a flag bit for quicker
access. These bits would be mutated as the CSE ran over a basic block, in such a way that
there was a very high probability that the possible replacement would already have the
bit set, while the redundant node did not have the bit set. Since Node::arithNodeFlags()
returned all of the bits, this would cause CSEPhase::pureCSE() to reject the match
almost every time.
The solution is to make Node::arithNodeFlags() do as its name suggests: only return those
flags that are relevant to arithmetic behavior. This patch introduces a new mask that
represents those bits, and includes NodeBehaviorMask and NodeBackPropMask, which are both
used for queries on Node::arithNodeFlags(), and both affect arithmetic code gen. None of
the other flags are relevant to Node::arithNodeFlags() since they either correspond to
information already conveyed by the opcode (like NodeResultMask, NodeMustGenerate,
NodeHasVarArgs, NodeClobbersWorld, NodeMightClobber) or information that doesn't affect
the result that the node will produce or any of the queries performed on the result of
Node::arithNodeFlags (NodeDoesNotExit and of course NodeRelevantToOSR).
This is a 10% speed-up on Kraken, undoing the regression from r140504.
- dfg/DFGNode.h:
(JSC::DFG::Node::arithNodeFlags):
- dfg/DFGNodeFlags.h:
(DFG):
- 12:51 PM Changeset in webkit [141300] by
-
- 5 edits in trunk/Source/WebCore
Do not convert to String->AtomicString for NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=108289
Reviewed by Kentaro Hara.
NamedNodeMap's API was taking a WTF::String. Internally, attribute
names are AtomicString.
The conversions String->AtomicString was causing an additional ref-deref
for the JS/V8 bindings. And could cause an additional memory allocation for the Objective-C
bindings.
This patch changes the API to use AtomicString, and update the custom bindings accordingly.
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::namedPropertyGetter):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
- dom/NamedNodeMap.h:
(NamedNodeMap):
- 12:47 PM Changeset in webkit [141299] by
-
- 4 edits in trunk
[GTK] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108100
Reviewed by Tony Gentilcore.
Source/WebCore:
Similarly to the changes to V8 bindings in r140882, wrap the PerformanceEntry
as a PerformanceMark or PerformanceMeasure if possible.
No new tests - the relevant test now passes.
- bindings/js/JSPerformanceEntryCustom.cpp:
(WebCore::toJS):
LayoutTests:
- platform/gtk/TestExpectations: Remove the failure expectation.
- 12:46 PM Changeset in webkit [141298] by
-
- 9 edits in trunk/Tools
[chromium] move custom policy delegate to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108328
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::decidePolicyForNavigation):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::policyDelegateIsPermissive):
(WebTestRunner::TestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::TestRunner::setCustomPolicyDelegate):
(WebTestRunner::TestRunner::waitForPolicyDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::decidePolicyForNavigation):
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 12:42 PM Changeset in webkit [141297] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix compile error in WebFrameTest
https://bugs.webkit.org/show_bug.cgi?id=108360
Unreviewed build fix.
Fixes compile error:
../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
- tests/WebFrameTest.cpp:
- 12:22 PM Changeset in webkit [141296] by
-
- 15 edits2 adds2 deletes in trunk/Source/WebCore
[JSC] MutationObservers should not create circular, leaky references
https://bugs.webkit.org/show_bug.cgi?id=93661
Reviewed by Adam Barth.
This patch makes JSMutationCallback an entirely-custom class that
holds a weak reference to the function it wraps. To keep that function
alive, it also adds a PrivateName between the JSMutationObserver
wrapper and the function when the MutationObserver is constructed.
Unlike the generated JSC callbacks, JSMutationCallback doesn't hold a
reference to the JSDOMGlobalObject, instead holding the
DOMWrapperWorld it was created in. As an ActiveDOMCallback, it also
holds a weak pointer to ScriptExecutionContext (via ContextDestructionObserver).
It's not clear to me how to write a test for this. There's an existing
manual test in ManualTests/leak-cycle-observer-wrapper.html which may
be of use but which doesn't seem to currently give meaningful output.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSMutationCallback.cpp: Added.
(WebCore):
(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::~JSMutationCallback):
(WebCore::JSMutationCallback::handleEvent):
- bindings/js/JSMutationCallback.h: Added.
(WebCore):
(JSMutationCallback): Instead of a JSCallbackData, hold a weak ref to the callback and a RefPtr to the DOMWrapperWorld.
(WebCore::JSMutationCallback::create):
- bindings/js/JSMutationCallbackCustom.cpp: Removed.
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
When constructing the JSMutationObserver, add a reference via PrivateName from the MutationObserver to the callback function.
- dom/MutationCallback.idl: Removed. Neither JSC nor V8 use an IDL file to generate this class any more.
- 12:05 PM Changeset in webkit [141295] by
-
- 5 edits in trunk/Source
Structure::m_outOfLineCapacity is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=108206
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We can calculate our out of line capacity by using the outOfLineSize and our knowledge about our resize policy.
According to GDB, this knocks Structures down from 136 bytes to 128 bytes (I'm guessing the extra bytes are from
better alignment of object fields), which puts Structures in a smaller size class. Woohoo! Looks neutral on our
benchmarks.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC):
(JSC::Structure::suggestedNewOutOfLineStorageCapacity):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
- runtime/Structure.h:
(Structure):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::totalStorageCapacity):
Source/WTF:
We're adding a new function that gives us the ability to round a value up to the next power of a certain base.
- wtf/MathExtras.h:
(WTF::roundUpToPowerOf):
- 12:03 PM Changeset in webkit [141294] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening: Add expectations for flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=108359
Unreviewed gardening: add a bunch of flaky results.
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-30
- platform/efl-wk2/TestExpectations:
- 12:01 PM Changeset in webkit [141293] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for a couple of fullscreen tests, probably
regressed with r141265.
Adding a crash expectation for an HTTP test that regressed with r141136.
- platform/gtk/TestExpectations:
- 11:41 AM Changeset in webkit [141292] by
-
- 10 edits in trunk/Source/WebCore
Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=108248
Reviewed by Dimitri Glazkov.
The only reason willAddAuthorShadowRoot exists is so that a handful of
other elements can create the user agent shadow root right before the
author shadow root is created. Instead of providing this generic hook
just expose a virtual method on Element that requests this behavior.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::createShadowRoot):
- dom/Element.h:
(Element):
(WebCore::Element::alwaysCreateUserAgentShadowRoot): Added.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Remove willAddAuthorShadowRoot notification.
- html/HTMLButtonElement.cpp:
- html/HTMLButtonElement.h:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- 11:39 AM Changeset in webkit [141291] by
-
- 12 edits7 moves in trunk/Source/WebCore
[HarfBuzz] Naming fixes after removing old HarfBuzz code
https://bugs.webkit.org/show_bug.cgi?id=108170
Reviewed by Tony Chang.
Since the old harfbuzz code is gone in r141241, it makes sense to get rid
of the now unnecessray NG suffix in a number of places. While at it,
I am also fixing some naming inconsistencies.
Renamed all occurences of HarfBuzzNG* to HarfBuzz*,
renamed lowercase variants of harfbuzz* in variable and function names to camel-case harfBuzz*,
moved files in platform/graphics/harfbuzz/ng/* one level up and removed ng folder.
Updated corresponding entries in Chromium, GTK and EFL build system files.
No new tests, no change in behavior.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/graphics/FontPlatformData.cpp:
- platform/graphics/FontPlatformData.h:
(WebCore):
(FontPlatformData):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::harfBuzzFace):
- platform/graphics/freetype/FontPlatformData.h:
(FontPlatformData):
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::harfBuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::harfBuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(WebCore):
(FontPlatformData):
- platform/graphics/harfbuzz/HarfBuzzFace.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp.
(WebCore):
(FaceCacheEntry):
(WebCore::FaceCacheEntry::create):
(WebCore::FaceCacheEntry::~FaceCacheEntry):
(WebCore::FaceCacheEntry::face):
(WebCore::FaceCacheEntry::glyphCache):
(WebCore::FaceCacheEntry::FaceCacheEntry):
(WebCore::harfBuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):
(WebCore::findScriptForVerticalGlyphSubstitution):
(WebCore::HarfBuzzFace::setScriptForVerticalGlyphSubstitution):
- platform/graphics/harfbuzz/HarfBuzzFace.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h.
(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):
- platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp.
(WebCore):
(CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::lock):
(WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):
(WebCore::floatToHarfBuzzPosition):
(WebCore::doubleToHarfBuzzPosition):
(WebCore::CairoGetGlyphWidthAndExtents):
(WebCore::harfBuzzGetGlyph):
(WebCore::harfBuzzGetGlyphHorizontalAdvance):
(WebCore::harfBuzzGetGlyphHorizontalOrigin):
(WebCore::harfBuzzGetGlyphExtents):
(WebCore::harfBuzzCairoTextGetFontFuncs):
(WebCore::harfBuzzCairoGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfBuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp.
(WebCore):
(WebCore::HarfBuzzFontData::HarfBuzzFontData):
(HarfBuzzFontData):
(WebCore::SkiaScalarToHarfBuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfBuzzGetGlyph):
(WebCore::harfBuzzGetGlyphHorizontalAdvance):
(WebCore::harfBuzzGetGlyphHorizontalOrigin):
(WebCore::harfBuzzGetGlyphExtents):
(WebCore::harfBuzzSkiaGetFontFuncs):
(WebCore::harfBuzzSkiaGetTable): Also fixed style checker whitespace complaint / indentation.
(WebCore::destroyHarfBuzzFontData):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp.
(WebCore):
(HarfBuzzScopedPtr):
(WebCore::HarfBuzzScopedPtr::HarfBuzzScopedPtr):
(WebCore::HarfBuzzScopedPtr::~HarfBuzzScopedPtr):
(WebCore::HarfBuzzScopedPtr::get):
(WebCore::harfBuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setDrawRange):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::adjustStartPoint):
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun):
(WebCore::HarfBuzzShaper::fillGlyphBuffer):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):
- platform/graphics/harfbuzz/HarfBuzzShaper.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h.
(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::fontData):
(WebCore::HarfBuzzShaper::HarfBuzzRun::startIndex):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::advances):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets):
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
- 11:21 AM Changeset in webkit [141290] by
-
- 3 edits2 adds in trunk
REGRESSION(r136324): Flexbox should relayout flex children when width changes
https://bugs.webkit.org/show_bug.cgi?id=108231
Reviewed by Ojan Vafai.
Source/WebCore:
If the width of a block changes, we need to set relayoutChildren = true
to relayout the children. This broke when we optimized the layout calls
in layoutAndPlaceChildren.
Test: css3/flexbox/width-change-and-relayout-children.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Also reorder the code to match RenderBlock.
The bug fix is to use updateLogicalWidthAndColumnWidth() and its return value to set
relayoutChildren = true.
LayoutTests:
- css3/flexbox/width-change-and-relayout-children-expected.txt: Added.
- css3/flexbox/width-change-and-relayout-children.html: Added.
- 11:19 AM Changeset in webkit [141289] by
-
- 6 edits in tags/Safari-537.26.5
Merged r141045. <rdar://problem/12960662>
- 11:18 AM Changeset in webkit [141288] by
-
- 4 edits in trunk/Source/WebCore
GraphicsContext3DCG needs to copy image data in paintToCanvas
https://bugs.webkit.org/show_bug.cgi?id=108310
Reviewed by Simon Fraser.
Make the CG implementation of GraphicsContext3D::paintToCanvas copy image data
before drawing if we're drawing into an accelerated context, matching the fix made
in http://trac.webkit.org/changeset/106095 for 2D canvas.
No new tests, depends on acceleration and would be flaky at best.
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D): Make CG's paintToCanvas take a GraphicsContext instead of a CGContextRef.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::releaseImageData): Added.
(WebCore::GraphicsContext3D::paintToCanvas): Copy image data if the destination is
an accelerated context. Also, use GraphicsContext API instead of CGContext.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- 11:12 AM Changeset in webkit [141287] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix Win build after r141177
https://bugs.webkit.org/show_bug.cgi?id=108325
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-30
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::sendOutgoingMessage):
- 11:02 AM Changeset in webkit [141286] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
inspector/editor/text-editor-ctrl-movements.html is timing out after r141245.
- platform/chromium/TestExpectations:
- 10:54 AM Changeset in webkit [141285] by
-
- 4 edits in trunk/WebKitLibraries
Update WebKitSystemInterface for <rdar://problem/13111288>.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- WebKitSystemInterface.h: Removed WKEnterPluginSandbox, which has been unused now.
- 10:52 AM Changeset in webkit [141284] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Screenshot is clipped when content is smaller than the desintation size
https://bugs.webkit.org/show_bug.cgi?id=107735
Patch by Ed Baker <edbaker@rim.com> on 2013-01-30
Reviewed by Rob Buis.
Internal PR #284662
Don't scale the transformed content rect when the content is smaller than the destination
size. Scale the graphics context when it has a scale factor that isn't 1.0.
Internally reviewed by Andrew Lo
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
- 10:52 AM Changeset in webkit [141283] by
-
- 4 edits in tags/Safari-537.26.5/Source
Versioning.
- 10:40 AM Changeset in webkit [141282] by
-
- 1 copy in tags/Safari-537.26.5
New Tag.
- 10:20 AM Changeset in webkit [141281] by
-
- 2 edits in trunk/Source/WebCore
MediaPlayerPrivateQTKit claims it supports application/x-diskcopy, breaking downloads.
https://bugs.webkit.org/show_bug.cgi?id=108237
Reviewed by Eric Carlson.
Disclaim any non-'video/' or 'audio/' types which QTKit purports to support.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::addFileTypesToCache):
- 9:55 AM Changeset in webkit [141280] by
-
- 2 edits in trunk/Source/WebCore
Do not restart the matched properties cache timer if active
https://bugs.webkit.org/show_bug.cgi?id=108345
Reviewed by Andreas Kling.
StyleResolver::addToMatchedPropertiesCache() keeps resetting the timer as more than
matchedDeclarationCacheAdditionsBetweenSweeps entries are added. When armed, we should let
the timer expire at its scheduled time - otherwise it may never get a chance to fire if
entries keep getting added.
No new tests. This is a long lived timer (1min) which makes testing impractical.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::addToMatchedPropertiesCache):
- 9:55 AM Changeset in webkit [141279] by
-
- 5 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 141252
BUG=163887
[Chromium] Fix find in page rects for overflowing content.
https://bugs.webkit.org/show_bug.cgi?id=104924
Reviewed by Julien Chaffraix.
If a div has overflowing content, we should only normalise its
coordinates against the renderview or the containing scrollable block.
TEST=WebFrameTest.FindInPageMatchRects
- src/FindInPageCoordinates.cpp:
(WebKit::enclosingScrollableAncestor):
Helper function to find the enclosing containing block with an overflow clip.
(WebKit::toNormalizedRect):
Pass in the container as an argument.
(WebKit::findInPageRectFromAbsoluteRect):
Compute the container for toNormalizedRect using enclosingScrollableAncestor.
- tests/WebFrameTest.cpp:
Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
- tests/data/find.html:
Add test case for <select> element.
- tests/data/find_in_page_frame.html:
Add test cases:
- Result 15, 16 tests that containing <div> with style float:left and height:0px does not impact coordinate normalization.
- Result 17, 18 tests that matches with absolute positioning are normalized containing relative positioned block, even if there is a closer parent block with overflow clip.
- Result 19 adds a test case for <select> element.
TBR=jknotten@chromium.org
Review URL: https://codereview.chromium.org/12092069
- 9:39 AM Changeset in webkit [141278] by
-
- 2 edits in trunk/Source/WebCore
Temporarily disable assertions related to clip rect computation in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=108265
Reviewed by Dean Jackson.
These assertions are killing the test bots, so disable them temporarily
until we figure out the underlying bug (tracked by https://bugs.webkit.org/show_bug.cgi?id=103432).
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
- 9:15 AM Changeset in webkit [141277] by
-
- 7 edits in trunk/Source/WebCore
Element::areAuthorShadowsAllowed should be private
https://bugs.webkit.org/show_bug.cgi?id=108298
Reviewed by Darin Adler.
There's no reason for areAuthorShadowsAllowed to be exposed publically
on Element since it just controls the behavior of createShadowRoot. Make
it private and fix all places where it wasn't in subclasses.
No new tests, just refactoring.
- dom/Element.h:
(WebCore::Element::areAuthorShadowsAllowed): Made private.
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- svg/SVGElement.h:
(SVGElement):
- 9:12 AM Changeset in webkit [141276] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Webpage was cut off after rotating to landscape and then rotating back to portrait on specific website
https://bugs.webkit.org/show_bug.cgi?id=108281
PR 284985
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-01-30
Reviewed by Rob Buis.
Internally reviewed by Jacky Jiang.
Return correct fixedLayoutSize when overflow exceeds contents size.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 8:58 AM Changeset in webkit [141275] by
-
- 11 edits in trunk
REGRESSION (r141051): Broke plugin support on non-Mac WebKit2 Ports
https://bugs.webkit.org/show_bug.cgi?id=108182
Reviewed by Sam Weinig.
Source/WebKit2:
Send the plugin path to the PluginProcess as a parameter.
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
LayoutTests:
Unskip failing tests.
- platform/efl-wk2/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- 8:52 AM Changeset in webkit [141274] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_window_features
https://bugs.webkit.org/show_bug.cgi?id=107924
Reviewed by Sam Weinig.
Use C API inside ewk_window_features instead of accessing
internal C++ classes directly, to avoid violating API
layering.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::createNewPage):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/ewk_window_features.cpp:
(EwkWindowFeatures::EwkWindowFeatures):
(getWindowFeatureValue):
(EwkWindowFeatures::getWindowFeatureBoolValue):
(EwkWindowFeatures::getWindowFeatureDoubleValue):
(ewk_window_features_geometry_get):
- UIProcess/API/efl/ewk_window_features_private.h:
(EwkWindowFeatures::create):
(EwkWindowFeatures::geometry):
(EwkWindowFeatures::setGeometry):
(EwkWindowFeatures):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::createNewPage):
- 8:15 AM Changeset in webkit [141273] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Script Profiler: Make profiler output typed.
https://bugs.webkit.org/show_bug.cgi?id=102792
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-30
Reviewed by Yury Semikhatsky.
Currently fields "head" and "bottomUpHead" of Profile object
returned by Profiler.getCPUProfile is untyped (type = object).
That's not good both for client side (protocol users may
only guess on output content) and backend side (field names
are hardcoded in source code).
This patch defines "head" and "bottomUpHead" to be of new
"CPUProfileNode" type and updates serialization code to use
builders to create output.
- bindings/js/ScriptProfile.cpp: Used buiders for serialization.
- bindings/js/ScriptProfile.h: Ditto.
- bindings/v8/ScriptProfile.cpp: Ditto.
- bindings/v8/ScriptProfile.h: Ditto.
- inspector/Inspector.json: Added and used new ProfileNode type.
- 8:12 AM Changeset in webkit [141272] by
-
- 7 edits1 delete in trunk/Source/WebCore
Web Inspector: remove NativeHeapGraph.js
https://bugs.webkit.org/show_bug.cgi?id=108342
Reviewed by Pavel Feldman.
NativeHeapGraph.js was removed as NativeHeapSnapshot.js provides more
features and shares its implementation with JSHeapSnapshot.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/NativeHeapGraph.js: Removed.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileHeader.prototype.startSnapshotTransfer):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/WebKit.qrc:
- 8:11 AM QtWebKitBuildBots edited by
- (diff)
- 7:33 AM Changeset in webkit [141271] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=108341
Add a few failing results for EFL.
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-30
- platform/efl/TestExpectations:
- 7:12 AM Changeset in webkit [141270] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Sidebar splitter is invisible in Elements and Sources panels
https://bugs.webkit.org/show_bug.cgi?id=108331
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
This was a regression caused by https://bugs.webkit.org/show_bug.cgi?id=108181.
The splitter element did not get the correct class at the initialization.
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarPosition):
- 7:10 AM Changeset in webkit [141269] by
-
- 10 edits3 adds in trunk
Web Inspector: Filters on Console panel
https://bugs.webkit.org/show_bug.cgi?id=107813
Source/WebCore:
The problem is that third-party libraries may spam javascript console with internal
messages. Now there's filter context-menu option, which allows to hide/show messages
sent from specific scripts or urls.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.appendUndefined):
(WebInspector.ConsoleMessageImpl.prototype._printArray):
(WebInspector.ConsoleMessageImpl.prototype._highlightSearchResultsInElement):
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get var):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.set get contextMenu):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenuItem.prototype.isEnabled):
(WebInspector.ContextMenuItem.prototype.setEnabled):
- inspector/front-end/Settings.js:
LayoutTests:
The problem is that third-party libraries may spam javascript console
with internal messages. Now there's filter context-menu option, which
allows to hide/show messages sent from specific scripts or urls.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
- http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithStyles):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
(initialize_ConsoleTest.InspectorTest.expandConsoleMessages):
(initialize_ConsoleTest.InspectorTest.checkConsoleMessagesDontHaveParameters):
(initialize_ConsoleTest):
- http/tests/inspector/stacktraces/resources/stacktrace-test.js:
(test.addMessage):
(test):
- inspector/console/console-filter-test-expected.txt: Added.
- inspector/console/console-filter-test.html: Added.
- inspector/console/resources/log-source.js: Added.
(log2):
- 7:07 AM Changeset in webkit [141268] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix minimal build after r141259.
Unreviewed build fix.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearNotificationPermissions):
- 7:06 AM Changeset in webkit [141267] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 141160
REGRESSION (r135628-135632): Double box shadow failure to render
https://bugs.webkit.org/show_bug.cgi?id=107833
Reviewed by Simon Fraser.
Source/WebCore:
Regression caused by http://trac.webkit.org/changeset/135629
The regression was due to faulty occlusion logic that was assuming
that drawing the background color of a render box background layer
could be skipped when the same layer also has an opaque image attached.
In the case where the background color is drawn for the purpose of
rendering a box shadow, the shadow is typically not
completely occluded by the background image because of the shadow
blur and/or offset. This patch fixes the problem by not culling a
background draw if it is used to draw a box shadow.
Test: fast/backgrounds/gradient-background-shadow.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Changing occlusion culling test to never cull background color
draw if it is used to draw a box shadow. This is because box shadows
can draw outside the border fill region.
LayoutTests:
New ref test verifies that box shadow is drawn when
background is an opaque image. Test uses an blue gradient
as background image. Reference uses blue background color.
- fast/backgrounds/gradient-background-shadow-expected.html: Added.
- fast/backgrounds/gradient-background-shadow.html: Added.
TBR=junov@google.com
Review URL: https://codereview.chromium.org/12089070
- 7:00 AM Changeset in webkit [141266] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=108340.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-01-30
- platform/qt/TestExpectations:
- 6:55 AM Changeset in webkit [141265] by
-
- 18 edits2 adds in trunk/Source
[GStreamer] USE(NATIVE_FULLSCREEN_VIDEO) support
https://bugs.webkit.org/show_bug.cgi?id=106760
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Initial support for NATIVE_FULLSCREEN_VIDEO in the GStreamer media
player. A new FullscreenVideoControllerGStreamer class is
introduced, ports interested to implement native fullscreen video
support should inherit from it (see FullscreenVideoControllerGtk)
and hook it in the MediaPlayerPrivateGStreamer backend.
The GStreamerGWorld port to GStreamer 1.x is partly based on a
patch by Sebastian Dröge <sebastian.droge@collabora.com>.
- GNUmakefile.am: Enable NATIVE_FULLSCREEN_VIDEO support.
- GNUmakefile.list.am: New
FullscreenVideoController{GStreamer,Gtk} modules.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp: Added.
(WebCore):
(WebCore::playerVolumeChangedCallback): Playbin notify::volume
signal callback.
(WebCore::playerMuteChangedCallback): Playbin notify::mute signal callback.
(WebCore::FullscreenVideoControllerGStreamer::FullscreenVideoControllerGStreamer):
(WebCore::FullscreenVideoControllerGStreamer::~FullscreenVideoControllerGStreamer):
(WebCore::FullscreenVideoControllerGStreamer::enterFullscreen):
Switch GStreamerGWorld to full screen, hook in to playbin's
notify::volume and mute signals and initialize the full screen window.
(WebCore::FullscreenVideoControllerGStreamer::exitFullscreen):
Destroy the full screen window, disconnect from playbin signals
and switch GStreamerGWorld out of full screen.
(WebCore::FullscreenVideoControllerGStreamer::exitOnUserRequest):
Trigger exit from full screen mode. This method is meant to be
called when the user explicitely requests to exit from full screen
by pressing a key or something similar.
(WebCore::FullscreenVideoControllerGStreamer::togglePlay): Switch
between play and pause states. Useful for child classes.
(WebCore::FullscreenVideoControllerGStreamer::increaseVolume):
Useful for child classes as well.
(WebCore::FullscreenVideoControllerGStreamer::decreaseVolume): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::setVolume): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::timeToString): Ditto.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h: Added.
(WebCore):
(FullscreenVideoControllerGStreamer):
(WebCore::FullscreenVideoControllerGStreamer::playStateChanged):
To be implemented by child class to reflect the player's state changed.
(WebCore::FullscreenVideoControllerGStreamer::volumeChanged): To
be implemented by child class as well.
(WebCore::FullscreenVideoControllerGStreamer::muteChanged): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::initializeWindow): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::destroyWindow): Ditto.
- platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::gstGWorldSyncMessageCallback): Adapt for GStreamer video
overlay API changes.
(WebCore::GStreamerGWorld::GStreamerGWorld):
gst_bus_set_sync_handler takes one more argument in GStreamer 1.x.
(WebCore::GStreamerGWorld::enterFullscreen): ffmpegcolorspace was
renamed to videoconvert in GStreamer 1.x and the tee src pad
template was renamed to src_%u. There is no need to send a new
segment query either.
(WebCore):
(WebCore::gstGWorldPadProbeCallback): Remove the platform video
sink branch once the tee source pad starting it has been blocked.
(WebCore::GStreamerGWorld::exitFullscreen): Refactor to use an
asynchronous pad probe.
(WebCore::GStreamerGWorld::removePlatformVideoSink): Refactored
from exitFullscreen.
(WebCore::GStreamerGWorld::setWindowOverlay): Adapt for GStreamer video
overlay API changes.
- platform/graphics/gstreamer/GStreamerGWorld.h:
(GStreamerGWorld):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Hook NATIVE_FULLSCREEN_VIDEO support.
(WebCore::MediaPlayerPrivateGStreamer::volume): Playbin volume
query used by the FullscreenVideoController.
(WebCore):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore):
(MediaPlayerPrivateGStreamer): volume(), muted() and MediaPlayer
accessor methods added. NATIVE_FULLSCREEN_VIDEO methods added as well.
(WebCore::MediaPlayerPrivateGStreamer::canEnterFullscreen):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayer):
- platform/graphics/gstreamer/PlatformVideoWindow.h: Re-enable
module if NATIVE_FULLSCREEN_VIDEO is turned on.
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Ditto.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Re-enable
GStreamerGWorld support.
(_WebKitVideoSinkPrivate):
(webkitVideoSinkRender):
- platform/graphics/gstreamer/VideoSinkGStreamer.h: Ditto.
Source/WebKit/qt:
Build fixes for GStreamer NATIVE_FULLSCREEN_VIDEO support. Some
more changes will be needed to use the new
FullscreenVideoController though.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
- WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):
- WebCoreSupport/FullScreenVideoQt.h:
(WebCore):
(FullScreenVideoQt):
- 6:49 AM Changeset in webkit [141264] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=108340.
- platform/qt/TestExpectations:
- 6:48 AM Changeset in webkit [141263] by
-
- 4 edits in trunk/Source
[Qt] Fix Qt/Mac build after r141024 and r141037
https://bugs.webkit.org/show_bug.cgi?id=108318
Reviewed by Kentaro Hara.
Source/WebKit2:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInvalidate):
Replace nullptr with 0 to allow compiling without C++11 support.
Source/WTF:
- wtf/Functional.h:
Make sure Block.h is included and its functionality
is enabled for Qt on Mac.
- 6:36 AM Changeset in webkit [141262] by
-
- 6 edits in branches/chromium/1364/Source
Promote composited scrolling render layers to stacking containers.
https://bugs.webkit.org/show_bug.cgi?id=106142
https://code.google.com/p/chromium/issues/detail?id=167201
- 6:31 AM Changeset in webkit [141261] by
-
- 12 edits6 adds in trunk/LayoutTests
[Chromium] Unreviewed gaedening.
Updated results after http://trac.webkit.org/changeset/141243.
- platform/chromium-linux/fast/repaint/4774354-expected.png:
- platform/chromium-linux/fast/repaint/4776765-expected.png:
- platform/chromium-linux/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/4774354-expected.png:
- platform/chromium-mac-lion/fast/repaint/4776765-expected.png:
- platform/chromium-mac-lion/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png:
- platform/chromium-mac/fast/repaint/4774354-expected.png:
- platform/chromium-mac/fast/repaint/4776765-expected.png:
- platform/chromium-mac/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-mac/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/chromium-win/fast/repaint/4774354-expected.png:
- platform/chromium-win/fast/repaint/4776765-expected.png:
- platform/chromium-win/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-win/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/chromium/TestExpectations:
- 6:03 AM Changeset in webkit [141260] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: beautify file selector dialog to render as two rows
https://bugs.webkit.org/show_bug.cgi?id=108335
Reviewed by Vsevolod Vlasov.
Go-to-file is now rendered in two rows.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.renderAsTwoRows):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.OpenResourceDialog.show):
- inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl):
(WebInspector.ViewportControl.prototype.refresh):
- inspector/front-end/filteredItemSelectionDialog.css:
(.filtered-item-list-dialog > input):
(.filtered-item-list-dialog > div.progress):
(.filtered-item-list-dialog > div.container):
(.filtered-item-list-dialog-item):
(.filtered-item-list-dialog-subtitle):
(.filtered-item-list-dialog-item.one-row .filtered-item-list-dialog-subtitle):
(.filtered-item-list-dialog-item.two-rows):
(.filtered-item-list-dialog-item.selected):
(.filtered-item-list-dialog-item span.highlight):
- 5:59 AM Changeset in webkit [141259] by
-
- 17 edits in trunk
[Qt][WK1] Support better testing of Web Notifications
https://bugs.webkit.org/show_bug.cgi?id=107696
Reviewed by Jocelyn Turcotte.
Source/WebKit/qt:
Implement support for the DRT to clear notification permissions.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearNotificationPermissions):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::clearCachedPermissions):
(WebCore):
- WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationPresenterClientQt):
Tools:
Do not dump notification output to the console by default, instead allow the
tests that need this feature to enable it.
Implement denyWebNotificationPermission and removeAllWebNotificationPermissions.
Remove unused m_desktopNotificationAllowedOrigins variable.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::TestRunner):
(TestRunner::reset):
(TestRunner::dumpNotifications):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
LayoutTests:
Unskip the now working tests in http/tests/notifications.
Skip four tests that still fail on WebKit1.
Update tests that need notifications dumped.
- fast/notifications/notifications-click-event.html:
- fast/notifications/notifications-display-close-events.html:
- fast/notifications/notifications-no-icon.html:
- fast/notifications/notifications-replace.html:
- fast/notifications/notifications-rtl.html:
- fast/notifications/notifications-with-permission.html:
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 4:47 AM Changeset in webkit [141258] by
-
- 9 edits1 add in trunk/Source/WebCore
Web Inspector: migrate file selection dialog to the viewport.
https://bugs.webkit.org/show_bug.cgi?id=108313
Reviewed by Vsevolod Vlasov.
Otherwise it takes too long to render.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype._itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown.updateSelection):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemCount):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
- inspector/front-end/ViewportControl.js: Added.
(WebInspector.ViewportControl):
(WebInspector.ViewportControl.Provider):
(WebInspector.ViewportControl.Provider.prototype.itemCount):
(WebInspector.ViewportControl.Provider.prototype.itemElement):
(WebInspector.ViewportControl.prototype.contentElement):
(WebInspector.ViewportControl.prototype.refresh):
(WebInspector.ViewportControl.prototype._onScroll):
(WebInspector.ViewportControl.prototype.rowsPerViewport):
(WebInspector.ViewportControl.prototype.firstVisibleIndex):
(WebInspector.ViewportControl.prototype.lastVisibleIndex):
(WebInspector.ViewportControl.prototype.renderedElementAt):
(WebInspector.ViewportControl.prototype.scrollItemIntoView):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/filteredItemSelectionDialog.css:
(.js-outline-dialog .container div.item.selected):
(.js-outline-dialog .container div.item span.highlight):
- inspector/front-end/inspector.html:
- 4:43 AM Changeset in webkit [141257] by
-
- 4 edits2 adds2 deletes in trunk
Web Inspector: implement highlight range API
https://bugs.webkit.org/show_bug.cgi?id=108317
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/editor/text-editor-highlight-api.html
Introduce RangeHighlightDescriptor class and implement Highlight Range
api.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.removeHighlight):
(WebInspector.DefaultTextEditor.prototype.highlightRange):
(WebInspector.TextEditorMainPanel.prototype.removeHighlight):
(WebInspector.TextEditorMainPanel.prototype.highlightRange):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.affectsLine):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.cssClass):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._removeHighlight):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.highlightRange):
(WebInspector.TextEditor.prototype.removeHighlight):
LayoutTests:
Added test cases to the existed test to cover highlight range
functionality.
- inspector/editor/text-editor-highlight-api-expected.txt: Added.
- inspector/editor/text-editor-highlight-api.html: Added.
- inspector/editor/text-editor-highlight-regexp-expected.txt: Removed.
- inspector/editor/text-editor-highlight-regexp.html: Removed.
- 4:39 AM Changeset in webkit [141256] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/accessibility/aria-combobox-expected.txt: Rebaselining after r141186.
- 4:27 AM Changeset in webkit [141255] by
-
- 12 edits3 deletes in trunk/Source
[Qt] Remove QT4_UNICODE related code paths
https://bugs.webkit.org/show_bug.cgi?id=108316
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Get rid of QT4_UNICODE and any related code paths. The Qt port
requires Qt5 and ICU these days. This also allows for the removal
of TextCodecQt.
- Target.pri:
- platform/KURL.cpp:
(WebCore::appendEncodedHostname):
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):
- platform/text/qt/TextCodecQt.cpp: Removed.
- platform/text/qt/TextCodecQt.h: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in: The feature macro has been removed.
Source/WTF:
Get rid of QT4_UNICODE and any related code paths. The Qt port
requires Qt5 and ICU these days.
- WTF.gypi:
- WTF.pro:
- wtf/unicode/Unicode.h:
- wtf/unicode/qt4/UnicodeQt4.h: Removed.
- 4:21 AM Changeset in webkit [141254] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Make WebCorePrefix.h build on iOS
<http://webkit.org/b/108224>
Reviewed by Sam Weinig.
- WebCorePrefix.h:
- Include <wtf/Platform.h>.
- Do not include <CoreServices/CoreServices.h> on iOS.
- Include <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h> on iOS.
- 4:20 AM Changeset in webkit [141253] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r141156.
- PlatformWinCE.cmake:
- 4:13 AM Changeset in webkit [141252] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Fix find in page rects for overflowing content.
https://bugs.webkit.org/show_bug.cgi?id=104924
Reviewed by Julien Chaffraix.
If a div has overflowing content, we should only normalise its
coordinates against the renderview or the containing scrollable block.
TEST=WebFrameTest.FindInPageMatchRects
- src/FindInPageCoordinates.cpp:
(WebKit::enclosingScrollableAncestor):
Helper function to find the enclosing containing block with an overflow clip.
(WebKit::toNormalizedRect):
Pass in the container as an argument.
(WebKit::findInPageRectFromAbsoluteRect):
Compute the container for toNormalizedRect using enclosingScrollableAncestor.
- tests/WebFrameTest.cpp:
Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
- tests/data/find.html:
Add test case for <select> element.
- tests/data/find_in_page_frame.html:
Add test cases:
- Result 15, 16 tests that containing <div> with style float:left and height:0px does not impact coordinate normalization.
- Result 17, 18 tests that matches with absolute positioning are normalized containing relative positioned block, even if there is a closer parent block with overflow clip.
- Result 19 adds a test case for <select> element.
- 4:07 AM Changeset in webkit [141251] by
-
- 7 edits3 moves2 adds in trunk/LayoutTests
Web Inspector: move heap profiler protocol tests into heap-profiler subfolder
https://bugs.webkit.org/show_bug.cgi?id=108324
Reviewed by Vsevolod Vlasov.
Moved heap profiler protocol tests into LayoutTests/inspector-protocol/heap-profiler
- inspector-protocol/heap-profiler/resources/page-with-function.html: Renamed from LayoutTests/inspector-protocol/resources/page-with-function.html.
- inspector-protocol/heap-profiler/take-heap-snapshot-expected.txt: Renamed from LayoutTests/inspector-protocol/take-heap-snapshot-expected.txt.
- inspector-protocol/heap-profiler/take-heap-snapshot.html: Renamed from LayoutTests/inspector-protocol/take-heap-snapshot.html.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 4:01 AM Changeset in webkit [141250] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Canvas] support instrumenting canvases in iframes (frontend side)
https://bugs.webkit.org/show_bug.cgi?id=108319
Reviewed by Pavel Feldman.
Add a frame selector to choose between frames with canvases. Show this selector in the status
bar only if there are 2 or more frames with canvses. Otherwise, assume silently the only
frame with canvases (most common use case).
- English.lproj/localizedStrings.js:
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get statusBarItems):
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._frameAdded):
(WebInspector.CanvasProfileType.prototype._addFrame):
(WebInspector.CanvasProfileType.prototype._frameRemoved):
(WebInspector.CanvasProfileType.prototype._contextCreated):
(WebInspector.CanvasProfileType.prototype._selectedFrameId):
(WebInspector.CanvasProfileType.prototype._dispatchViewUpdatedEvent):
(WebInspector.CanvasDispatcher):
(WebInspector.CanvasDispatcher.prototype.contextCreated):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
(WebInspector.ProfilesPanel.prototype._updateProfileTypeSpecificUI):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarComboBox.prototype.size):
- 3:59 AM Changeset in webkit [141249] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: Change the Elements panel sidebar layout based on its aspect ratio.
https://bugs.webkit.org/show_bug.cgi?id=108181
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Sidebar aspect ratio proved to be a better trigger for the sidebar layout change that the docking mode.
Moved the sidebar layout handling completely into WebInspector.SidebarView which now only accepts
two positions: Start (corresponding to Left or Top) and End (corresponding to Right or Bottom).
No new tests.
- inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView):
- inspector/front-end/DockController.js:
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.onResize):
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
- inspector/front-end/MemoryStatistics.js:
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.createSidebarView):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype.setAutoOrientation):
(WebInspector.SidebarView.prototype._updateSidebarPosition):
(WebInspector.SidebarView.prototype.onResize):
- 3:58 AM Changeset in webkit [141248] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port SharedTimerWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=103724
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around some parts of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/SharedTimerWin.cpp:
(WebCore):
(WebCore::TimerWindowWndProc):
(WebCore::initializeOffScreenTimerWindow):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- platform/wince/SharedTimerWinCE.cpp: Removed.
- 3:56 AM Changeset in webkit [141247] by
-
- 4 edits2 adds in trunk
[EFL][Qt][WebGL] Avoid deleting an uncreated canvas.
https://bugs.webkit.org/show_bug.cgi?id=106878
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-30
Reviewed by Benjamin Poulain.
Source/WebKit2:
setContentsToCanvas is responsible for marking canvas for creation or deletion.
The issue here is that the canvas is marked for deletion even though it has not
been created. This causes an assert in LayerTreeRenderer::destroyCanvas.
This patch adds a seperate check to ensure that CoordinatedGraphicsLayer
tries to issue a request for canvas deletion only after request for canvas
creation has been handled.
New test: fast/canvas/webgl/canvas-resize-crash.html
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::fixedToViewport):
LayoutTests:
- fast/canvas/webgl/canvas-resize-crash-expected.txt: Added.
- fast/canvas/webgl/canvas-resize-crash.html: Added.
- 3:55 AM Changeset in webkit [141246] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp: Include GraphicsLayerTextureMapper.h
as a forwarding header from WebCore.
- 3:53 AM Changeset in webkit [141245] by
-
- 7 edits2 adds in trunk
Source/WebCore: ctrl-arrows, ctrl-shift-arrow, ctrl-backspace
Web Inspector: implmenet Ctrl-Arrow/Ctrl-Backspace in DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=107944
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Add ctrl-arrows/ctrl-shift-arrow/ctrl-backspace shortcuts to jump over
and delete words.
New test: inspector/editor/text-editor-ctrl-movements.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):
(WebInspector.DefaultTextEditor.prototype.selection):
(WebInspector.DefaultTextEditor.WordMovementController): Added.
(WebInspector.DefaultTextEditor.WordMovementController.prototype._registerShortcuts):
(WebInspector.DefaultTextEditor.WordMovementController.prototype.):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._rangeForCtrlArrowMove):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlArrow):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlShiftArrow):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlBackspace):
LayoutTests: Web Inspector: implmenet Ctrl-Arrow/Ctrl-Backspace in DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=107944
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Add new test to verify ctrl-arrow/ctrl-backspace behavior. Exclude
this test on the platforms that do not currently support eventSender.
- inspector/editor/text-editor-ctrl-movements-expected.txt: Added.
- inspector/editor/text-editor-ctrl-movements.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 3:49 AM Changeset in webkit [141244] by
-
- 5 edits in trunk
Web Inspector: do not repaint all lines in highlight regex API in DTE
https://bugs.webkit.org/show_bug.cgi?id=108081
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Source/WebCore:
Implement repaintLineRowsAffectedByHighlightDescriptor method that
will go through the visible lineRows and repaint only those of them
which were outdated by highlight change.
Improved test: inspector/editor/text-editor-highlight-regexp.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._repaintLineRowsAffectedByHighlightDescriptor):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineRows):
LayoutTests:
Modify layout test to add a verification that highlight does not
repaint more DefaultTextEditor line rows than it needs to.
- inspector/editor/text-editor-highlight-regexp-expected.txt:
- inspector/editor/text-editor-highlight-regexp.html:
- 3:20 AM Changeset in webkit [141243] by
-
- 5 edits in trunk
REGRESSION (r139282): Caret repainting is broken for text-align: center'd <input>
https://bugs.webkit.org/show_bug.cgi?id=108283
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-30
Reviewed by Tim Horton.
Occasionally carets won't be fully erased when blinking.
There used to be 1-pixel padding but removed since r139282.
This patch adds back the same workaround.
Source/WebCore:
Need to rebaseline test expectations.
- editing/FrameSelection.cpp:
(WebCore::repaintCaretForLocalRect):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 2:52 AM Changeset in webkit [141242] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
More plugin test cases skipped, failing after r141051,
plugins/document-open.html is not crashing, but currently timing out.
- platform/efl-wk2/TestExpectations:
- 2:45 AM Changeset in webkit [141241] by
-
- 15 edits4 deletes in trunk
[HarfBuzz] Remove the HarfBuzz-old code
https://bugs.webkit.org/show_bug.cgi?id=108077
Reviewed by Benjamin Poulain.
.:
Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
won't be a distinction between ng and non-ng HarfBuzz after
removing the old code.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Removing unused old variant of the HarfBuzz code.
No new tests, no change in functionality.
- GNUmakefile.am: Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ
- WebCore.gypi: Removing ComplexTextControllerHarfBuzz* and HarfBuzzSkia* files,
- platform/graphics/SimpleFontData.h:
(SimpleFontData): USE(HARFBUZZ_NG) renamed to USE(HARFBUZZ).
- platform/graphics/freetype/FontPlatformData.h:
(FontPlatformData): Removing USE(HARFBUZZ_NG) ifdefs.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp: USE(HARFBUZZ_NG) renamed to USE(HARFBUZZ).
(WebCore):
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Removed.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h: Removed.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore):
(FontPlatformData):
- platform/graphics/harfbuzz/HarfBuzzSkia.cpp: Removed.
- platform/graphics/harfbuzz/HarfBuzzSkia.h: Removed.
- platform/graphics/skia/SimpleFontDataSkia.cpp: USE(HARFBUZZ_NG) renamed to USE(HARFBUZZ).
(WebCore):
Source/WebKit/chromium:
Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
won't be a distinction between ng and non-ng HarfBuzz after
removing the old code.
- features.gypi:
- 2:34 AM Changeset in webkit [141240] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Major performance improvement in Qt's PluginDatabase implementation
https://bugs.webkit.org/show_bug.cgi?id=106140
Patch by David Faure <faure@kde.org> on 2013-01-30
Reviewed by Simon Hausmann.
No new tests, only a performance improvement.
- plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo): Don't do a full-fledged load(), load the module directly.
Keep the refcounting as it was before (broken, but otherwise flash crashes).
(WebCore::PluginPackage::load): Use existing module if fetchInfo created it.
- 2:31 AM Changeset in webkit [141239] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
More plugin test cases skipped, failing after r141051,
- 2:20 AM Changeset in webkit [141238] by
-
- 11 edits in trunk/Source
[TexMap] Remove GraphicsLayer in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=107073
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Noam Rosenthal.
Source/WebCore:
Remove the dependency of TextureMapperLayer on GraphicsLayer. It is needed to
remove GraphicsLayerTextureMapper in LayerTreeRenderer.
This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).
Covered by existing tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::toTextureMapperLayer):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
Set BackgroundColorChange to m_changeMask instead of ContentChange.
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToSolidColor):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::setShowDebugBorder):
(WebCore::GraphicsLayerTextureMapper::setShowRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::setDebugBorder):
(WebCore::toTextureMapperLayerVector):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
Flush pending changes into TextureMapperLayer.
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):
(WebCore::GraphicsLayerTextureMapper::setFilters):
(WebCore::GraphicsLayerTextureMapper::setBackingStore):
(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::setRepaintCount):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
(WebCore):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setChildren):
(WebCore::TextureMapperLayer::setMaskLayer):
(WebCore):
(WebCore::TextureMapperLayer::setReplicaLayer):
(WebCore::TextureMapperLayer::setPosition):
(WebCore::TextureMapperLayer::setSize):
(WebCore::TextureMapperLayer::setAnchorPoint):
(WebCore::TextureMapperLayer::setPreserves3D):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::setChildrenTransform):
(WebCore::TextureMapperLayer::setContentsRect):
(WebCore::TextureMapperLayer::setMasksToBounds):
(WebCore::TextureMapperLayer::setDrawsContent):
(WebCore::TextureMapperLayer::setContentsVisible):
(WebCore::TextureMapperLayer::setContentsOpaque):
(WebCore::TextureMapperLayer::setBackfaceVisibility):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setSolidColor):
(WebCore::TextureMapperLayer::setFilters):
(WebCore::TextureMapperLayer::setDebugVisuals):
(WebCore::TextureMapperLayer::setRepaintCount):
(WebCore::TextureMapperLayer::setContentsLayer):
(WebCore::TextureMapperLayer::setAnimations):
(WebCore::TextureMapperLayer::setFixedToViewport):
(WebCore::TextureMapperLayer::setBackingStore):
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
Source/WebKit/efl:
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
- WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
Source/WebKit/gtk:
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Source/WebKit/qt:
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
- WebCoreSupport/TextureMapperLayerClientQt.cpp:
- 2:13 AM Changeset in webkit [141237] by
-
- 10 edits in trunk/Tools
[chromium] move methods from WebTestDelegate to WebTestRunner
https://bugs.webkit.org/show_bug.cgi?id=108309
Reviewed by Adam Barth.
By moving more logic to the TestRunner library, we can share more
code with content shell.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createView):
(WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled):
(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::createView):
(WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
(WebViewHost::didStartLoading):
(WebViewHost::didStopLoading):
(WebViewHost::isSmartInsertDeleteEnabled):
(WebViewHost::isSelectTrailingWhitespaceEnabled):
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 1:50 AM Changeset in webkit [141236] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Jae Hyun Park to contributor list.
- Scripts/webkitpy/common/config/committers.py:
- 1:41 AM Changeset in webkit [141235] by
-
- 2 edits in trunk/Source/WebCore
getDecorationRootAndDecoratedRoot should add new user agent shadow roots
https://bugs.webkit.org/show_bug.cgi?id=108301
Reviewed by Hajime Morita.
getDecorationRootAndDecoratedRoot intended to add a second UserAgentShadowRoot
to the input, not just reuse the existing one so it could insert icons into
the inputs. Add back in this behavior for now so we can sort out the right thing
to do.
This behavior is wrong in the current architecture since it means if you had an
input type=submit, add an author shadow root, and then change the type to text
and then the browser decorates it your shadow magically becomes inaccessible since
input.shadowRoot is no longer available. This feature is currently only used for
decorating type=password fields in Chromium with an icon for password generation.
No new tests, there's no way to test this because it's only used in Chromium
by way of the ChromeClient.
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::getDecorationRootAndDecoratedRoot):
- 1:37 AM Changeset in webkit [141234] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
https://bugs.webkit.org/show_bug.cgi?id=108004
http://code.google.com/p/chromium/issues/detail?id=172416
console.debug triggers a NOTREACHED() assertation in Chromium. This
is because WebCore::MessageLevel contains 5 levels, including debug,
where WebConsoleMessage::Level is missing a "debug" level. Add a
WebConsoleMessage::LevelDebug so that it can get passed up to the
renderer even if it doesn't make use of that now.
Requires another patch to chromium itself to fix chromium bug 172416
but this is a prerequisite.
Also add an enum compile time check to AssertMatchingEnums.cpp,
Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
Reviewed by Jochen Eisinger.
- public/WebConsoleMessage.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
- 1:28 AM Changeset in webkit [141233] by
-
- 6 edits in trunk/Source/WebKit/qt
[Qt][WK1] Remember denied permission for notifications
https://bugs.webkit.org/show_bug.cgi?id=107694
Reviewed by Jocelyn Turcotte.
Store denied permissions. According to the specification, we should
ask the user again if he has already granted or denied permission.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::setNotificationsAllowedForFrame):
- WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationPresenterClientQt):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::setNotificationsAllowedForFrame):
- WebCoreSupport/QWebPageAdapter.h:
- WidgetApi/qwebpage.cpp:
(QWebPage::setFeaturePermission):
- 12:22 AM Changeset in webkit [141232] by
-
- 8 edits in trunk/Source
Coordinated Graphics: Remove m_pendingSyncBackingStores in LayerTreeRenderer.
https://bugs.webkit.org/show_bug.cgi?id=107099
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Noam Rosenthal.
Source/WebCore:
Add GraphicsLayerTextureMapper::setBackingStore() so that
LayerTreeRenderer sets a backing store to GraphicsLayerTextureMapper.
Remove three methods of TextureMapperLayer related to a backing store
because they are no longer used.
Covered by existing compositing tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::setBackingStore):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
Source/WebKit2:
Instead of queuing the setting of backing stores in LayerTreeRenderer,
and then setting them directly to TextureMapperLayer, we allow
GraphicsLayerTextureMapper's existing queuing mechanism to handle that.
Instead of a m_pendingSyncBackingStores queue, we have a m_backingStores
queue which can be applied much more easily to the layer tree.
In addition, LayerTreeRenderer::purgeGLResources() does not call
TextureMapperLayer::clearBackingStoresRecursive() because
TextureMapperLayer will be destructed soon.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::createBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::resetBackingStoreSizeToLayerSize):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::commitPendingBackingStoreOperations):
(WebKit::LayerTreeRenderer::purgeGLResources):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
- 12:22 AM Changeset in webkit [141231] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Correct zoom for focused node when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107599
Reviewed by Adam Barth.
When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
Reapply r141153. Added font-size in html to ensure same caret size across platforms.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
(WebKit):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
- tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
- 12:05 AM Changeset in webkit [141230] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: DTE adds additional space to the end of line.
https://bugs.webkit.org/show_bug.cgi?id=108192
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Append overlay highlight spans before decorations elements and skip
them in _collectLinesFromDom method.
No new tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):
Jan 29, 2013:
- 11:48 PM Changeset in webkit [141229] by
-
- 2 edits in trunk
Unreviewed GTK build fix after r141175.
- Source/autotools/symbols.filter: Export the WebCore::Element::createShadowRoot symbol.
- 11:28 PM Changeset in webkit [141228] by
-
- 3 edits2 adds in trunk
Renderer is recreated unexpectedly after detach in HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=108150
Reviewed by Kent Tamura.
Source/WebCore:
After r140659, destoryShadowSubtree() may update style in removeChild(). It causes
attaching HTMLInputElement before creating shadowsubtree in HTMLInputElement::updateType().
For safe, destroyShadowSubtree() should be done before detach().
Test: fast/forms/number/number-change-type-on-focus-2.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2-expected.txt: Added.
- 10:31 PM Changeset in webkit [141227] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL Gradening.
fast/events/constructors/composition-event-constructor.html isn't exist anymore.
- platform/efl/TestExpectations:
- 10:30 PM Changeset in webkit [141226] by
-
- 2 edits in trunk/Source/WebCore
Scrollbar and scroll corner composited layers positioned incorrectly
https://bugs.webkit.org/show_bug.cgi?id=108255
Patch by James Robinson <jamesr@chromium.org> on 2013-01-29
Reviewed by Simon Fraser.
ScrollView::updateScrollbars() needs to update the overflow controls composited layers if scrollbars are added
or removed. It was doing this by recording on entry to the function if it had horizontal or vertical scrollbars
and then comparing that to m_horizontal/verticalScrollbar on exit. Unfortunately updateScrollbars is recursive
and exits without running the postamble code when nested on the callstack. As a result, scrollbars may be
added or removed several times during the recursion, possibly leaving the overflow control layers in an
inconsistent state, while ending up with the same set of scrollbars.
This changes the "has anything changed" logic to only compare local state (hasXXXScrollbar vs
newHasXXXScrollbar) so changes in recursive calls are not considered.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 10:14 PM Changeset in webkit [141225] by
-
- 2 edits in trunk/Source/WebCore
Convert deprecatedShadowAncestorNode() to shadowHost() in Editor.cpp
https://bugs.webkit.org/show_bug.cgi?id=108287
Reviewed by Hajime Morita.
This is the effort to convert deprecatedShadowAncestorNode() to shadowHost().
Since all the caller object of deprecatedShadowAncestorNode() is in a shadow tree, calling deprecatedShadowAncestorNode()
is equiavalent to calling shadowHost(). Also, for all the occurence of deprecatedShadowAncestorNode(), we don't need to
worry about nested ShadowDOM issues. So directly converting deprecatedShadowAncestorNode() to shadowHost() should be safe.
No new tests, simple refactoring.
- editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
- 10:07 PM Changeset in webkit [141224] by
-
- 3 edits in trunk/Source/WebKit2
Update the expected generated message results
https://bugs.webkit.org/show_bug.cgi?id=108293
Reviewed by Beth Dakin.
- Scripts/webkit2/messages.py:
(generate_messages_header):
- Scripts/webkit2/messages_unittest.py:
- 10:02 PM Changeset in webkit [141223] by
-
- 4 edits2 adds in trunk/Tools
Need a cr-linux debug EWS bot
https://bugs.webkit.org/show_bug.cgi?id=98957
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Eric Seidel.
Added cr-linux-debug-ews bot to webkit-patch, QueueStatusServer and GCE build scripts.
- EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Added.
- QueueStatusServer/app.yaml:
- QueueStatusServer/config/queues.py: Added.
- QueueStatusServer/model/queues.py:
(Queue.init):
(Queue.queue_with_name):
(Queue.all):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumLinuxDebugEWS):
- 9:43 PM Changeset in webkit [141222] by
-
- 3 edits in trunk/Source/JavaScriptCore
Be a little more conservative about emitting table-based switches
https://bugs.webkit.org/show_bug.cgi?id=108292
Reviewed by Filip Pizlo.
Profiling shows we're using op_switch in cases where it's a regression.
- bytecompiler/NodesCodegen.cpp:
(JSC):
(JSC::length):
(JSC::CaseBlockNode::tryTableSwitch):
(JSC::CaseBlockNode::emitBytecodeForBlock):
- parser/Nodes.h:
(CaseBlockNode):
- 9:37 PM Changeset in webkit [141221] by
-
- 3 edits in trunk/Source/WebCore
Rubberband scrolling on news.google.com causes text to blink repeatedly
https://bugs.webkit.org/show_bug.cgi?id=107326
Reviewed by Beth Dakin.
When in the middle of layout, RenderBlock::updateScrollInfoAfterLayout()
could cause us to re-evaluate reasons for compositing, via the call
to updateLayerCompositingState() in RenderLayer::updateScrollInfoAfterLayout().
At this time, when layout is still happening, it's bad to look at render
geometry to decide when to do compositing (e.g. for fixed position); we might
incorrectly conclude that the layer is outside the viewport.
Fix by having RenderLayerCompositing store in a member whether it's safe
to look at layout information. requiresCompositingForPosition() then consults
this bit, and, if it needs to make decisions based on layout but layout is not
complete, it doesn't change the compositing state of the layer.
Not testable, since dumping the layer tree will update layout and mask the bug.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 9:36 PM Changeset in webkit [141220] by
-
- 2 edits in trunk/LayoutTests
Add a failing Mac Lion test expectation per bug 108291.
- platform/mac/TestExpectations:
- 9:17 PM Changeset in webkit [141219] by
-
- 9 edits2 adds in trunk/Source
Introducing WTF::TypeSafeEnum and DatabaseError.
https://bugs.webkit.org/show_bug.cgi?id=108279.
Reviewed by Geoffrey Garen.
Source/WebCore:
DatabaseError will be used later in the webdatabase refactoring effort.
It is currently unused.
No new tests.
- GNUmakefile.list.am:
- Modules/webdatabase/DatabaseError.h: Added.
(WebCore):
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/TypeSafeEnum.h: Added.
(WTF):
(TypeSafeEnum):
(WTF::TypeSafeEnum::TypeSafeEnum):
(WTF::TypeSafeEnum::value):
(WTF::TypeSafeEnum::operator==):
(WTF::TypeSafeEnum::operator!=):
(WTF::TypeSafeEnum::operator<):
(WTF::TypeSafeEnum::operator<=):
(WTF::TypeSafeEnum::operator>):
(WTF::TypeSafeEnum::operator>=):
- 8:55 PM Changeset in webkit [141218] by
-
- 6 edits in trunk/Source/WebCore
Move ShadowRoot creation into ElementShadow
https://bugs.webkit.org/show_bug.cgi?id=108267
Reviewed by Hajime Morita.
Instead of the ShadowRoot::create method doing crazy factory things and
then needing to assert about the state of the ShadowRoot in addShadowRoot,
just create ShadowRoots from inside ElementShadow.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::createShadowRoot): Use addShadowRoot().
(WebCore::Element::ensureUserAgentShadowRoot): Use addShadowRoot().
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Now returns the new ShadowRoot.
- dom/ElementShadow.h:
(ElementShadow):
- dom/ShadowRoot.cpp:
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::create): No longer does the association.
(WebCore::ShadowRoot::setHost): Sets parent tree scope automatically.
- 8:33 PM Changeset in webkit [141217] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking fixed-position-composited-page-scale-down tests as failing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 8:05 PM Changeset in webkit [141216] by
-
- 12 edits2 moves in trunk/Source/WebCore
Rename DBBackend::Server to DatabaseServer.
https://bugs.webkit.org/show_bug.cgi?id=108278.
Rubber stamped by Geoffrey Garen.
This is only a renaming operation as part of the webdatabase refactoring
effort. There is no semantic change.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/DBBackendServer.cpp: Removed.
- Modules/webdatabase/DBBackendServer.h: Removed.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.cpp.
(WebCore::DatabaseServer::initialize):
(WebCore::DatabaseServer::setClient):
(WebCore::DatabaseServer::databaseDirectoryPath):
(WebCore::DatabaseServer::setDatabaseDirectoryPath):
(WebCore::DatabaseServer::fullPathForDatabase):
(WebCore::DatabaseServer::hasEntryForOrigin):
(WebCore::DatabaseServer::origins):
(WebCore::DatabaseServer::databaseNamesForOrigin):
(WebCore::DatabaseServer::detailsForNameAndOrigin):
(WebCore::DatabaseServer::usageForOrigin):
(WebCore::DatabaseServer::quotaForOrigin):
(WebCore::DatabaseServer::setQuota):
(WebCore::DatabaseServer::deleteAllDatabases):
(WebCore::DatabaseServer::deleteOrigin):
(WebCore::DatabaseServer::deleteDatabase):
(WebCore::DatabaseServer::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseServer::databaseChanged):
(WebCore::DatabaseServer::closeDatabasesImmediately):
(WebCore::DatabaseServer::interruptAllDatabasesForContext):
(WebCore::DatabaseServer::canEstablishDatabase):
(WebCore::DatabaseServer::addOpenDatabase):
(WebCore::DatabaseServer::removeOpenDatabase):
(WebCore::DatabaseServer::setDatabaseDetails):
(WebCore::DatabaseServer::getMaxSizeForDatabase):
(WebCore):
- Modules/webdatabase/DatabaseServer.h: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.h.
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::getDatabaseServer):
- 8:02 PM Changeset in webkit [141215] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking terminate-during-sync-operation.html as crashing after r141166.
Unreviwed. Gardening.
- platform/chromium/TestExpectations:
- 7:57 PM Changeset in webkit [141214] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaselining probably after r141136.
Unreviwed. Gardening.
- platform/chromium-win/http/tests/loading/redirect-methods-expected.txt: Added.
- 7:49 PM Changeset in webkit [141213] by
-
- 3 adds in branches/chromium/1364/Source/WebCore/Resources/pagepopups/chromium
Add leftover files for r141211
- 7:41 PM Changeset in webkit [141212] by
-
- 3 edits2 adds in trunk
AX: VoiceOver not reading bullets correctly in the text of notes
https://bugs.webkit.org/show_bug.cgi?id=107980
Reviewed by Ryosuke Niwa.
Source/WebCore:
Accessibility code should not assume that all list markers end with the same "." suffix.
We need to use the actual suffix.
Test: platform/mac/accessibility/listmarker-suffix.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
LayoutTests:
- platform/mac/accessibility/listmarker-suffix-expected.txt: Added.
- platform/mac/accessibility/listmarker-suffix.html: Added.
- 7:36 PM Changeset in webkit [141211] by
-
- 19 edits1 delete in branches/chromium/1364
Merge 140778
Adjust design of the Calendar Picker
https://bugs.webkit.org/show_bug.cgi?id=107507
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Use pickerCommonChromium.css and calendarPickerChromium.css.
Source/WebCore:
Covered by existing calendar picker appearance tests.
- Resources/pagepopups/calendarPicker.css:
(body): Use bigger font.
(.calendar-picker):
(.month-selector):
(.month-selector svg):
(.month-selector-popup-contents):
(.year-month-button-left .year-month-button):
(.year-month-button-right .year-month-button):
(.days-area-container):
(.days-area):
(.day-label):
(.day):
(.available):
(.month-mode .day):
(.today-clear-area .today-button):
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Calculate the width of today-clear-area too.
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo): Use svg icons inside buttons.
(YearMonthController.prototype._attachRightButtonsTo): Use svg icons inside buttons.
(YearMonthController.prototype.setMonth):
(YearMonthController.prototype._handleButtonClick):
- Resources/pagepopups/calendarPickerMac.css: Removed.
- Resources/pagepopups/chromium/calendarPickerChromium.css: Added.
(.year-month-button):
(.days-area-container:focus):
- Resources/pagepopups/chromium/pickerCommonChromium.css: Added. Use Chrome-style buttons.
(button):
(:enabled:hover:-webkit-any(button, input[type='button'])):
(:enabled:active:-webkit-any(button, input[type='button'])):
(:disabled:-webkit-any(button, input[type='button'])):
(:enabled:focus:-webkit-any(button, input[type='button'])):
- WebCore.gyp/WebCore.gyp: Include pickerCommonChromium.css and calendarPickerChromium.css.
- rendering/RenderTheme.cpp: Remove extraCalendarPickerStyleSheet
- rendering/RenderTheme.h: Ditto.
- rendering/RenderThemeChromiumMac.h: Ditto.
- rendering/RenderThemeChromiumMac.mm: Ditto.
(WebCore):
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Include pickerCommonChromium.css and calendarPickerChromium.css.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium/TestExpectations: Marking calendar picker appearance tests as needing rebaseline.
TBR=keishi@webkit.org
BUG=crbug.com/172514
Review URL: https://codereview.chromium.org/12082066
- 7:34 PM Changeset in webkit [141210] by
-
- 2 edits in trunk/LayoutTests
[Chromium] fast/workers/storage crashing after r141166
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 7:29 PM Changeset in webkit [141209] by
-
- 21 edits in trunk/Source/WebKit2
Replace unnecessary ArgumentDecoder member functions with decode overloads
https://bugs.webkit.org/show_bug.cgi?id=102013
Reviewed by Anders Carlsson.
- Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::decode):
- Platform/CoreIPC/ArgumentCoders.h:
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeVariableLengthByteArray):
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/ArgumentDecoder.h:
(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeEnum):
(CoreIPC):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::decode):
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::decode):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::decode):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphDecoder::baseDecode):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::HandleArray::decode):
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::decode):
- Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::decode):
- Shared/qt/ArgumentCodersQt.cpp:
(CoreIPC::::decode):
- Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::decode):
- WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeBool):
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit::DecoderAdapter::decodeUInt32):
(WebKit::DecoderAdapter::decodeUInt64):
(WebKit::DecoderAdapter::decodeInt32):
(WebKit::DecoderAdapter::decodeInt64):
(WebKit::DecoderAdapter::decodeFloat):
(WebKit::DecoderAdapter::decodeDouble):
- 7:21 PM Changeset in webkit [141208] by
-
- 18 edits in trunk/LayoutTests
[Chromium] Rebaselining after r141195
Unreviewed. Gardening.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- 7:20 PM Changeset in webkit [141207] by
-
- 32 edits2 moves in trunk/Source
Rename AbstractDatabase to DatabaseBackend.
https://bugs.webkit.org/show_bug.cgi?id=108275.
Reviewed by Sam Weinig.
This is a pure rename operation as part of the webdatabase refactoring
effort. There is no semantic change in this patch.
Source/WebCore:
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabase.cpp: Removed.
- Modules/webdatabase/AbstractDatabase.h: Removed.
- Modules/webdatabase/AbstractDatabaseServer.h:
(WebCore):
(AbstractDatabaseServer):
- Modules/webdatabase/DBBackendServer.cpp:
(WebCore::DBBackend::Server::databaseChanged):
(WebCore::DBBackend::Server::addOpenDatabase):
(WebCore::DBBackend::Server::removeOpenDatabase):
(WebCore::DBBackend::Server::getMaxSizeForDatabase):
- Modules/webdatabase/DBBackendServer.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::version):
(WebCore::Database::performOpenAndVerify):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabase.cpp.
(WebCore):
(WebCore::DatabaseBackend::databaseInfoTableName):
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::~DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(WebCore::DatabaseBackend::version):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::scriptExecutionContext):
(WebCore::DatabaseBackend::securityOrigin):
(WebCore::DatabaseBackend::stringIdentifier):
(WebCore::DatabaseBackend::displayName):
(WebCore::DatabaseBackend::estimatedSize):
(WebCore::DatabaseBackend::fileName):
(WebCore::DatabaseBackend::details):
(WebCore::DatabaseBackend::getVersionFromDatabase):
(WebCore::DatabaseBackend::setVersionInDatabase):
(WebCore::DatabaseBackend::setExpectedVersion):
(WebCore::DatabaseBackend::getCachedVersion):
(WebCore::DatabaseBackend::setCachedVersion):
(WebCore::DatabaseBackend::getActualVersionForTransaction):
(WebCore::DatabaseBackend::disableAuthorizer):
(WebCore::DatabaseBackend::enableAuthorizer):
(WebCore::DatabaseBackend::setAuthorizerReadOnly):
(WebCore::DatabaseBackend::setAuthorizerPermissions):
(WebCore::DatabaseBackend::lastActionChangedDatabase):
(WebCore::DatabaseBackend::lastActionWasInsert):
(WebCore::DatabaseBackend::resetDeletes):
(WebCore::DatabaseBackend::hadDeletes):
(WebCore::DatabaseBackend::resetAuthorizer):
(WebCore::DatabaseBackend::maximumSize):
(WebCore::DatabaseBackend::incrementalVacuumIfNeeded):
(WebCore::DatabaseBackend::interrupt):
(WebCore::DatabaseBackend::isInterrupted):
(WebCore::DatabaseBackend::logErrorMessage):
(WebCore::DatabaseBackend::reportOpenDatabaseResult):
(WebCore::DatabaseBackend::reportChangeVersionResult):
(WebCore::DatabaseBackend::reportStartTransactionResult):
(WebCore::DatabaseBackend::reportCommitTransactionResult):
(WebCore::DatabaseBackend::reportExecuteStatementResult):
(WebCore::DatabaseBackend::reportVacuumDatabaseResult):
- Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabase.h.
(DatabaseBackend):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::databaseChanged):
(WebCore::DatabaseManager::addOpenDatabase):
(WebCore::DatabaseManager::removeOpenDatabase):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::DatabaseSync):
- Modules/webdatabase/DatabaseSync.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- Modules/webdatabase/DatabaseTracker.h:
(WebCore):
(DatabaseTracker):
- Modules/webdatabase/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::markDatabase):
- Modules/webdatabase/OriginQuotaManager.h:
(WebCore):
(OriginQuotaManager):
- Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
- Modules/webdatabase/SQLTransactionClient.h:
(WebCore):
(SQLTransactionClient):
- Modules/webdatabase/chromium/DatabaseObserver.h:
(WebCore):
(DatabaseObserver):
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):
- Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
(WebCore::NotifyDatabaseChangedTask::create):
(WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask):
(NotifyDatabaseChangedTask):
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
- public/WebDatabase.h:
(WebDatabase):
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):
- src/WebDatabase.cpp:
(WebKit::WebDatabase::WebDatabase):
- 7:00 PM Changeset in webkit [141206] by
-
- 3 edits5 deletes in trunk/Tools
Tidy up Sheriffbot's Sheriffs command's unit tests
https://bugs.webkit.org/show_bug.cgi?id=108262
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Eric Seidel.
Added the use of MockWeb instead of the filesystem to test the sheriffs command.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Sheriffs._retrieve_webkit_sheriffs):
(Sheriffs.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_sheriffs):
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Removed.
- 6:43 PM Changeset in webkit [141205] by
-
- 2 edits in trunk/Tools
Enable tests for Windows EWS!
https://bugs.webkit.org/show_bug.cgi?id=107968
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 6:37 PM Changeset in webkit [141204] by
-
- 5 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r141153.
http://trac.webkit.org/changeset/141153
https://bugs.webkit.org/show_bug.cgi?id=108280
Caused WebFrameTest.DivScrollIntoEditableTest to fail on Mac.
(Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/get_scale_for_zoom_into_editable_test.html:
- 6:32 PM Changeset in webkit [141203] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Adjust missing MessageID removals to fix build breaks
https://bugs.webkit.org/show_bug.cgi?id=108276
Unreviewed to fix build breaks.
Some MessageID removals wasn't adjusted into ConnectionUnix.cpp and coordinated graphics.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyIsOutOfLine):
(CoreIPC::MessageInfo::isMessageBodyIsOutOfLine):
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
- UIProcess/WebProcessProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- 6:30 PM Changeset in webkit [141202] by
-
- 24 edits in trunk
Unreviewed, rolling out r140983.
http://trac.webkit.org/changeset/140983
https://bugs.webkit.org/show_bug.cgi?id=108277
Unfortunately, this API has one last client (Requested by
abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore):
(WebCore::Notification::create):
- Modules/notifications/Notification.h:
(Notification):
(WebCore::Notification::isHTML):
(WebCore::Notification::setHTML):
(WebCore::Notification::url):
(WebCore::Notification::setURL):
- Modules/notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createHTMLNotification):
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
- page/FeatureObserver.h:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
- src/WebNotification.cpp:
(WebKit::WebNotification::isHTML):
(WebKit::WebNotification::url):
(WebKit::WebNotification::iconURL):
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- fast/notifications/notifications-with-permission-expected.txt:
- fast/notifications/notifications-with-permission.html:
- 6:22 PM Changeset in webkit [141201] by
-
- 10 edits1 copy in branches/chromium/1364
Merge 140803
INPUT_MULTIPLE_FIELDS_UI: Inconsistent value of aria-valuetext attribute
https://bugs.webkit.org/show_bug.cgi?id=107897
Reviewed by Kentaro Hara.
Source/WebCore:
aria-valuetext and aria-valuenow attributes had inconsistent values in
a case of initial empty state and a case that a user clears a field.
- aria-valuetext attribute should have "blank" message in the initial empty state.
- aria-valuenow attribute should be removed in the cleared empty state.
Also, we have a bug that aira-valuenow had a symbolic value such as "AM"
"January". It should always have a numeric value according to the
specification.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow
No new tests. Updates fast/forms/*-multiple-fields/*-multiple-fields-ax-aria-attributes.html.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::DateTimeFieldElement):
Set "blank" message to aria-valuetext attribute.
(WebCore::DateTimeFieldElement::updateVisibleValue):
aria-valuenow attribute should be a numeric value. Apply String::number
to the return value of valueForARIAValueNow.
Remove aria-valuenow attribute if nothing is selected.
(WebCore::DateTimeFieldElement::valueForARIAValueNow):
Added.
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Declare valueForARIAValueNow.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::valueForARIAValueNow):
Added. Returns 1 + internal selection index.
For example, the function returns 1 for January.
- html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Declare valueForARIAValueNow.
LayoutTests:
Fix existing tests to show aria-valuenow attribute values.
- fast/forms/resources/multiple-fields-ax-aria-attributes.js: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
Add tests for initial empty-value state.
- fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt:
- fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
- fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
TBR=tkent@chromium.org
BUG=crbug.com/172199
Review URL: https://codereview.chromium.org/12086056
- 6:19 PM Changeset in webkit [141200] by
-
- 6 edits in branches/chromium/1364/Source/WebCore/html/shadow
Merge 140791
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=107918
Reviewed by Kentaro Hara.
DateTimeSymbolicFieldElement::minimum() and maximum() are very
confusing. They don't return minimum/maximum value of 0-based symbol
index though valueAsInteger is 0-based. These functions are used only
for ARIA attributes in DateTimeFieldElement::initialize().
- Remove DateTimeFieldElement::minimum() and maximum(), and pass
minimum/maximum values for ARIA attributes as function arguments.
- DateTimeNumericFieldElement::maximum() is now non-virtual. It is called by subclasses.
No new tests. This should not change any behavior.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
Add axMimimum/axMaximum arguments. Don't use minimum() and maximum().
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Ditto.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::initialize):
Pass m_range.minimum and maximum to DateTimeFieldElement::initialize().
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
- Add initialize()
- Make maximum() non-virtual
- Remove minimum().
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::initialize):
Pass m_minimumIndex + 1 and m_maximumIndex + 1 to
DateTimeFieldElement::initialize().
- html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement):
Add initialize() and remove minimum() and maximum().
TBR=tkent@chromium.org
BUG=crbug.com/172199
Review URL: https://codereview.chromium.org/12079062
- 6:17 PM Changeset in webkit [141199] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSObjCClassInfo creates reference cycle with JSContext
https://bugs.webkit.org/show_bug.cgi?id=107839
Reviewed by Geoffrey Garen.
Fixing several ASSERTs that were incorrect along with some of the reallocation of m_prototype and
m_constructor that they were based on.
- API/JSWrapperMap.mm:
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We now only allocate those
fields that are null (i.e. have been collected or have never been allocated to begin with).
(-[JSObjCClassInfo reallocateConstructorAndOrPrototype]): Renamed to better indicate that we're
reallocating one or both of the prototype/constructor combo.
(-[JSObjCClassInfo wrapperForObject:]): Call new reallocate function.
(-[JSObjCClassInfo constructor]): Ditto.
- 6:17 PM Changeset in webkit [141198] by
-
- 4 edits2 adds in trunk
parserAppendChild and parserInsertBefore should ensure that child nodes are in the same document
https://bugs.webkit.org/show_bug.cgi?id=108260
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/parser/xml-error-adopted.xml
The check and adoption if the documents don't match is now moved into ContainerNode::parser* from HTMLConstructionSite.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::fosterParent):
LayoutTests:
- fast/parser/xml-error-adopted-expected.txt: Added.
- fast/parser/xml-error-adopted.xml: Added.
- 6:11 PM Changeset in webkit [141197] by
-
- 4 edits in branches/chromium/1364/Source/WebCore/html/shadow
Merge 140788
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove unused DateTimeHourFieldElement::valueAsInteger
https://bugs.webkit.org/show_bug.cgi?id=107915
Reviewed by Kentaro Hara.
DateTimeHourFieldElement::valueAsInteger is never called. Remove it and
make valueAsInteger non-public.
No new tests. This shouldn't change any behavior.
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Make valueAsInteger protected.
- html/shadow/DateTimeFieldElements.cpp:
Remove DateTimeHourFieldElement::valueAsInteger.
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState):
Remove unnecessary DateTimeNumericFieldElement:: prefix.
- html/shadow/DateTimeFieldElements.h:
(DateTimeHourFieldElement): Remove valueAsInteger.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
Make valueAsInteger FINAL.
BUG=crbug.com/172199
TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/12090060
- 6:08 PM Changeset in webkit [141196] by
-
- 13 edits2 adds in trunk
[Chromium] Cannot copy text when selecting readonly (or disabled) input elements
https://bugs.webkit.org/show_bug.cgi?id=106287
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
a document element. However, the inner element and document element have a different tree scope, the selection range
cannot be gotten correctly.
We should use ShadowRoot instead of document so that we can stay in the same tree scope.
- WebCore.exp.in:
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::rootEditableElementOrTreeScopeRootNode): Added. Returns ShadowRoot so that we can
stay in the same tree scope.
(WebCore):
- editing/FrameSelection.h:
(FrameSelection):
- editing/TextIterator.cpp:
(WebCore::TextIterator::getLocationAndLengthFromRange):
- editing/TextIterator.h:
(TextIterator):
Source/WebKit/chromium:
When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
a document element. However, the inner element and document element have a different tree scope, selection range
cannot be gotten correctly.
We should use ShadowRoot instead of document so that we can stay in the same tree scope.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::caretOrSelectionRange):
- tests/WebViewTest.cpp:
- tests/data/selection_disabled.html: Added.
- tests/data/selection_readonly.html: Added.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 6:05 PM Changeset in webkit [141195] by
-
- 16 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary
https://bugs.webkit.org/show_bug.cgi?id=108069
Reviewed by Hajime Morita.
Source/WebCore:
To avoid the overflow, we do:
A) Specify overflow:hidden to <input>.
However, we need to make sub-fields and buttons workable even if the
width is smaller than the intrinsic size. So, we do:
B) Make DateTimeEditElement shrinkable, and
C) Make the sub-fields scrollable horizontally like input[type=text].
To achieve B, we need to remove -webkit-date-and-time-container (D)
because width property for <input> can shrink only the direct child
elements.
Tests: fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
and new test cases in fast/forms/date/date-appearance-basic.html.
- css/html.css:
(input[type="date"]):
Change -webkit-align-items value. (D)
Specify overflow:hidden. (A)
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-datetime-edit):
Add min-width:0 (B), and overflow:hidden. (C)
Remove unnecessary white-space:pre because of white-space:nowrap below.
(input::-webkit-datetime-edit-fields-wrapper):
Added. This is the child of -webkit-datetime-edit, and contains
sub-fields. (C)
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Remove -webkit-date-and-time-container, and append DateTimeEditElement,
spin button, and picker indicator element to the ShadowRoot. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldApplyLocaleDirection):
<input> for multiple fields UI should have the direction of the browser
locale. This is a replacement of the code for dir attribute in
updateInnerTextValue below. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
Remove the code to set dir= to -webkit-date-and-time-container.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Declare shouldApplyLocaleDirection. (D)
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
Calls setHasCustomCallbacks for customStyleForRenderer. (D)
(WebCore::HTMLInputElement::customStyleForRenderer):
Set direction to RenderStyle if shouldApplyLocaleDirection is true. This
is a replacement of the dir setting code in
BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue. (D)
- html/HTMLInputElement.h:
(HTMLInputElement): Declare customStyleForRenderer. (D)
- html/InputType.cpp:
(WebCore::InputType::shouldApplyLocaleDirection):
Add default implmentation of shouldApplyLocaleDirection. (D)
- html/InputType.h:
(InputType): Declare shouldApplyLocaleDirection. (D)
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::fieldsWrapperElement):
A helper to get -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::addField):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::customStyleForRenderer):
- Iterate over children of -webkit-datetime-edit-fields-wrapper element. (C)
- Set width property instead of min-width. (B)
(WebCore::DateTimeEditElement::layout):
- Prepare -webkit-datetime-edit-fields-wrapper element. (C)
- Handle children of -webkit-datetime-edit-fields-wrapper element. (C)
- Need to do style recalc because child structure is changed. (C)
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare fieldsWrapperElement. (C)
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
Add test cases for small width and small height.
- fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html:
Update the code because of shadow tree structure change.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:
Added.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt:
Added.
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- date-appearance-basic.html: New test cases are added.
- *-appearance-pseudo-element.html: :before :after position is slightly changed because of the -webkit-align-items change.
- suggestion-picker/*.html: RTL behavior is changed. The direction of suggestion pickers matches to the direction of the input content (browser locale).
- 5:51 PM Changeset in webkit [141194] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. More Windows7 gardening.
- platform/win/TestExpectations:
- 5:48 PM Changeset in webkit [141193] by
-
- 4 edits in trunk/Source
[v8] Enable binding integrity on linux
https://bugs.webkit.org/show_bug.cgi?id=108242
Reviewed by Adam Barth.
Source/WebCore:
Patch is correct if existing tests pass.
- html/TextMetrics.idl:
Suppress check to allow link on linux.
Source/WebKit/chromium:
- features.gypi:
- 5:44 PM Changeset in webkit [141192] by
-
- 5 edits in trunk/Source/JavaScriptCore
Make precise size classes more precise
https://bugs.webkit.org/show_bug.cgi?id=108270
Reviewed by Mark Hahnenberg.
Size inference makes this profitable.
I chose 8 byte increments because JSString is 24 bytes. Otherwise, 16
byte increments might be better.
- heap/Heap.h:
(Heap): Removed firstAllocatorWithoutDestructors because it's unused now.
- heap/MarkedBlock.h:
(MarkedBlock): Updated constants.
- heap/MarkedSpace.h:
(MarkedSpace):
(JSC): Also reduced the maximum precise size class because my testing
has shown that the smaller size classes are much more common. This
offsets some of the size class explosion caused by reducing the precise
increment.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): No need for this ASSERT anymore
because we don't rely on firstAllocatorWithoutDestructors anymore, since
we pick size classes dynamically now.
- 5:38 PM Changeset in webkit [141191] by
-
- 8 edits in trunk/Source/WebKit2
Remove MessageID parameter from Connection::sendMessage
https://bugs.webkit.org/show_bug.cgi?id=108269
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
- Platform/CoreIPC/Connection.h:
(Connection):
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendMessage):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- 5:31 PM Changeset in webkit [141190] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add some hardening to methodTable()
https://bugs.webkit.org/show_bug.cgi?id=108253
Reviewed by Mark Hahnenberg.
When accessing methodTable() we now always make sure that our
structure _could_ be valid. Added a separate method to get a
classes methodTable during destruction as it's not possible to
validate the structure at that point. This separation might
also make it possible to improve the performance of methodTable
access more generally in future.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
- runtime/JSCell.h:
(JSCell):
- runtime/JSCellInlines.h:
(JSC::JSCell::methodTableForDestruction):
(JSC):
(JSC::JSCell::methodTable):
- 5:18 PM Changeset in webkit [141189] by
-
- 2 edits in trunk/Source/JavaScriptCore
offlineasm BaseIndex handling is broken on ARM due to MIPS changes
https://bugs.webkit.org/show_bug.cgi?id=108261
Reviewed by Oliver Hunt.
Backends shouldn't override each other's methods. That's not cool.
- offlineasm/mips.rb:
- 5:14 PM Changeset in webkit [141188] by
-
- 2 edits in trunk/LayoutTests
[chromium] Disable layout tests impacted by page scale change
https://bugs.webkit.org/show_bug.cgi?id=108232
Unreviewed, gardening.
After https://codereview.chromium.org/12045002/, these
tests are expected to fail. Disabling and creating bugs for follow-up.
- platform/chromium/TestExpectations:
- 5:10 PM Changeset in webkit [141187] by
-
- 2 edits in trunk/Source/WebCore
Don't updateTileCoverageMap() from setScrollingModeIndication if we don't need to.
Reviewed by Simon Fraser.
Only do the work if the tiled scrolling indicator/map is enabled.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setScrollingModeIndication):
- 4:59 PM Changeset in webkit [141186] by
-
- 4 edits2 adds in trunk
AX: Add support for aria-autocomplete="list" on ARIA combobox
https://bugs.webkit.org/show_bug.cgi?id=108228
Reviewed by Ryosuke Niwa.
Source/WebCore:
Comboboxes behave much like textfields, and so they need
to respond like text controls.
Test: platform/mac/accessibility/combox-box-value.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isTextControl):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
LayoutTests:
- platform/mac/accessibility/combox-box-value-expected.txt: Added.
- platform/mac/accessibility/combox-box-value.html: Added.
- 4:59 PM Changeset in webkit [141185] by
-
- 4 edits in trunk/Source/JavaScriptCore
cloop.rb shouldn't use a method called 'dump' for code generation
https://bugs.webkit.org/show_bug.cgi?id=108251
Reviewed by Mark Hahnenberg.
Revert http://trac.webkit.org/changeset/141178 and rename 'dump' to 'clDump'.
Also made trivial build fixes for !ENABLE(JIT).
- offlineasm/cloop.rb:
- runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::intrinsicFor):
- runtime/JSGlobalData.h:
- 4:57 PM Changeset in webkit [141184] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Do not mark translation-unit-local functions as extern "C"
https://bugs.webkit.org/show_bug.cgi?id=108218
Reviewed by Adam Barth.
Requested by darin in https://bugs.webkit.org/show_bug.cgi?id=107845
This also allows enabling -Wreturn-type-c-linkage again, but I'd like to
wait for the next clang roll (which tweaks this warning) before undoing
r140800 (which removed that warning).
No behavior change.
- bindings/v8/npruntime.cpp:
- 4:57 PM Changeset in webkit [141183] by
-
- 8 edits in trunk/Source/WebKit2
Stop generating the message kind enum
https://bugs.webkit.org/show_bug.cgi?id=108258
Reviewed by Beth Dakin.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::waitForAndDispatchImmediately):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Scripts/webkit2/messages.py:
(surround_in_condition):
(message_to_struct_declaration):
(generate_messages_header):
- Scripts/webkit2/messages_unittest.py:
- Scripts/webkit2/model.py:
(Message.init):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- 4:56 PM Changeset in webkit [141182] by
-
- 3 edits in trunk/Tools
MockWeb should be able to serve mock web content
https://bugs.webkit.org/show_bug.cgi?id=108240
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Dirk Pranke.
Added the ability to have MockWeb serve mock web data.
- Scripts/webkitpy/common/host_mock.py:
(MockHost.init):
- Scripts/webkitpy/common/net/web_mock.py:
(MockWeb.init):
(MockWeb.get_binary):
- 4:50 PM Changeset in webkit [141181] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip a bunch of tests on Win7 in preparation of turning on EWS testers.
https://bugs.webkit.org/show_bug.cgi?id=108249
- platform/win/TestExpectations:
- 4:43 PM Changeset in webkit [141180] by
-
- 2 edits in trunk/Source/WebKit2
Fix erroneous semicolon causing build failure: if statement has empty body [-Werror,-Wempty-body]
https://bugs.webkit.org/show_bug.cgi?id=108241
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-29
Reviewed by Anders Carlsson.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addExistingWebPage): Remove erroneous
semicolon following the if condition.
- 4:36 PM Changeset in webkit [141179] by
-
- 18 edits2 deletes in trunk/Source
Removed GGC because it has been disabled for a long time
https://bugs.webkit.org/show_bug.cgi?id=108245
Reviewed by Filip Pizlo.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::writeBarrier):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- heap/CardSet.h: Removed.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::collect):
- heap/Heap.h:
(Heap):
(JSC::Heap::shouldCollect):
(JSC::Heap::isWriteBarrierEnabled):
(JSC):
(JSC::Heap::writeBarrier):
- heap/MarkedBlock.h:
(MarkedBlock):
(JSC):
- heap/MarkedSpace.cpp:
(JSC):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
../WebCore:
- ForwardingHeaders/heap/CardSet.h: Removed.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 4:30 PM Changeset in webkit [141178] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove redundant AST dump method from cloop.rb, since they are already defined in ast.rb
https://bugs.webkit.org/show_bug.cgi?id=108247
Reviewed by Oliver Hunt.
Makes offlineasm dumping easier to read and less likely to cause assertion failures.
Also fixes the strange situation where cloop.rb and ast.rb both defined dump methods,
but cloop.rb was winning.
- offlineasm/cloop.rb:
- 4:22 PM Changeset in webkit [141177] by
-
- 3 edits in trunk/Source/WebKit2
Remove almost everything from MessageID
https://bugs.webkit.org/show_bug.cgi?id=108244
Reviewed by Beth Dakin.
- Platform/CoreIPC/MessageID.h:
(CoreIPC::MessageID::MessageID):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC):
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):
(CoreIPC::Connection::receiveSourceEventHandler):
- 4:07 PM Changeset in webkit [141176] by
-
- 4 edits in trunk/Source/JavaScriptCore
Objective-C API: JSObjCClassInfo creates reference cycle with JSContext
https://bugs.webkit.org/show_bug.cgi?id=107839
Reviewed by Oliver Hunt.
JSContext has a JSWrapperMap, which has an NSMutableDictionary m_classMap, which has values that
are JSObjCClassInfo objects, which have strong references to two JSValue *'s, m_prototype and
m_constructor, which in turn have strong references to the JSContext, creating a reference cycle.
We should make m_prototype and m_constructor Weak<JSObject>. This gets rid of the strong reference
to the JSContext and also prevents clients from accidentally creating reference cycles by assigning
to the prototype of the constructor. If Weak<JSObject> fields are ever garbage collected, we will
reallocate them.
- API/JSContext.mm:
(-[JSContext wrapperMap]):
- API/JSContextInternal.h:
- API/JSWrapperMap.mm:
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSObjCClassInfo dealloc]):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(-[JSObjCClassInfo allocateConstructorAndPrototype]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSObjCClassInfo constructor]):
- 4:02 PM Changeset in webkit [141175] by
-
- 12 edits in trunk/Source
Refactor ShadowRoot exception handling
https://bugs.webkit.org/show_bug.cgi?id=108209
Reviewed by Dimitri Glazkov.
Source/WebCore:
Many of the exception cases for ShadowRoot are actually impossible and
should be asserts instead. We can also move the one case of exception logic,
for elements that don't allow author shadows into Element::createShadowRoot
instead of having it all over the ShadowRoot and ElementShadow classes. This
is the first step in centralizing all ShadowRoot creation inside ElementShadow.
No new tests, covered by existing tests.
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::createShadowRoot): Be explicit about what kind of ShadowRoot you're creating.
(WebCore::Element::ensureUserAgentShadowRoot): No more exceptions.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): This never actually throws exceptions, remove ExceptionCode.
- dom/ElementShadow.h:
(ElementShadow):
- dom/ShadowRoot.cpp:
(WebCore::determineUsageType): Merge with Element::createShadowRoot.
(WebCore):
(WebCore::ShadowRoot::ShadowRoot): Moved Histogram logic here since it's actually about the constructor anyway.
(WebCore::ShadowRoot::create): Removed overload that made the code less obvious.
- dom/ShadowRoot.h:
(ShadowRoot):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::getDecorationRootAndDecoratedRoot):
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::createShadowRoot):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: Swap ShadowRoot::create export with Element::createShadowRoot.
- 4:00 PM Changeset in webkit [141174] by
-
- 15 edits in trunk/Source/WebKit2
Get rid of MessageID::is()
https://bugs.webkit.org/show_bug.cgi?id=108234
Reviewed by Beth Dakin.
Add explicit message receiver name equality checks instead of using MessageID::is.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- Platform/CoreIPC/MessageID.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- 3:54 PM Changeset in webkit [141173] by
-
- 9 edits in trunk/Source
Allow clients to ask for the WebView/WKView placeholder view when in full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=103558
<rdar://problem/12763112>
Reviewed by Benjamin Poulain.
Source/WebKit/mac:
Clients may want to behave differently when their WebView/WKView has been swapped out by a placeholder
view when in full screen mode. Add a simple accessor for the existing placeholder view to
WebFullScreenController and WebView.
- WebView/WebFullScreenController.h:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController webViewPlaceholder]): Added simple accessor.
- WebView/WebView.mm:
(-[WebView fullScreenPlaceholderView]): Added simple accessor.
Source/WebKit2:
Clients may want to behave differently when their WebView/WKView has been swapped out by a placeholder
view when in full screen mode. Add a simple accessor for the existing placeholder view to
WKFullScreenWindowController and WKView.
- UIProcess/API/mac/WKView.mm:
(-[WKView fullScreenPlaceholderView]): Added simple accessor.
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController webViewPlaceholder]): Added simple accessor.
- 3:35 PM Changeset in webkit [141172] by
-
- 2 edits in trunk/Tools
run-api-tests should have an option to specify root
https://bugs.webkit.org/show_bug.cgi?id=108210
Reviewed by Ryosuke Niwa.
- Scripts/run-api-tests:
Add the option and use it to set the configuration product directory. Since it is supposed
to point to the built products, do not build the products if root is specified (this mimics
the behavior of run-javascriptcore-tests).
- 3:24 PM Changeset in webkit [141171] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Call LayerTreeHost::deviceOrPageScaleFactorChanged() when a device or page scale factor is changed.
https://bugs.webkit.org/show_bug.cgi?id=107802
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-29
Reviewed by Simon Fraser.
Currently, LayerTreeHostMac and *GTK call deviceOrPageScaleFactorChanged()
of the non compositing GraphicsLayer when a device scale factor is changed.
There are two problems.
- We don't notify LayerTreeHost when a page scale factor is changed.
- When using TiledCoreAnimationDrawingAreaProxy, LayerTreeHostMac does
not receive the device scale factor changed callback.
So this patch changes three points.
- Rename from deviceScaleFactorDidChange() to deviceOrPageScaleFactorChanged()
in LayerTreeHost.
- WebPage::setDeviceScaleFactor() calls LayerTreeHost::deviceScaleFactorDidChange()
because of dealing with TiledCoreAnimationDrawingAreaProxy.
- WebPage::pageScaleFactor() calls LayerTreeHost::deviceScaleFactorDidChange()
to call deviceOrPageScaleFactorChanged() of the non compositing GraphicsLayer.
Unfortunately, I couldn't think of a way to test this in an automated fashion.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):
Don't call LayerTreeHost::deviceScaleFactorDidChange() because this
method calls WebPage::setDeviceScaleFactor() and then
LayerTreeHost::deviceScaleFactorDidChange() is called.
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scalePage):
(WebKit::WebPage::setDeviceScaleFactor):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::deviceOrPageScaleFactorChanged):
- 3:15 PM Changeset in webkit [141170] by
-
- 4 edits in trunk/Source/WebKit2
Get rid of MessageID::get()
https://bugs.webkit.org/show_bug.cgi?id=108235
Reviewed by Beth Dakin.
Just check for the message receiver name and message name explicitly instead.
- Platform/CoreIPC/MessageID.h:
(CoreIPC::MessageID::is):
- Shared/CoreIPCSupport/WebContextMessageKinds.h:
(WebContextLegacyMessage::messageReceiverName):
(WebContextLegacyMessage):
(WebContextLegacyMessage::postMessageMessageName):
(WebContextLegacyMessage::postSynchronousMessageMessageName):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- 3:00 PM Changeset in webkit [141169] by
-
- 4 edits in branches/chromium/1364/Source
Merge 140483
Prevent race condition during Worker shutdown
https://bugs.webkit.org/show_bug.cgi?id=107577
Reviewed by Dmitry Titov.
Source/WebCore:
During worker shutdown, from the main thread a cleanup task is posted followed by
terminating the message queue, which prevents further tasks from being processed. It was
possible for another task be posted by another thread between the main thread calls
to postTask and terminate(), which would cause that task to run after cleanup. Expose
a new WTF::MessageQueue::appendAndKill() method which keeps a mutex around the two steps,
and use that during worker shutdown.
No reliable tests for the race - problem identified by inspection of user crash stacks.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTaskAndTerminate): New method, uses MessageQueue::appendAndKill()
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop): Uses postTaskAndTerminate() to avoid race.
Source/WTF:
Add MessageQueue::appendAndKill() which wraps those two steps with a mutex so other
threads can't sneak a message in between.
- wtf/MessageQueue.h: Added appendAndKill() method.
TBR=jsbell@chromium.org
Review URL: https://codereview.chromium.org/12096050
- 2:52 PM Changeset in webkit [141168] by
-
- 5 edits in trunk
REGRESSION (r140594): RELEASE_ASSERT_NOT_REACHED in JSC::Interpreter::execute
https://bugs.webkit.org/show_bug.cgi?id=108097
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
LiteralParser was accepting a bogus 'var a.b = c' statement
- runtime/LiteralParser.cpp:
(JSC::::tryJSONPParse):
LayoutTests:
Add parser test for invalid var a.b syntax
- fast/js/parser-syntax-check-expected.txt:
- fast/js/script-tests/parser-syntax-check.js:
- 2:52 PM Changeset in webkit [141167] by
-
- 29 edits in trunk/Source/WebKit2
Add support for enabling process suppression in WebProcesses with no visible pages
https://bugs.webkit.org/show_bug.cgi?id=108054
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-29
Reviewed by Anders Carlsson.
Provide a preference to enable process suppression in WebProcesses with
no visible pages even if the application is not completely occluded.
This provides more opportunities for process suppression to take effect.
Replace the messaging of application occlusion status from UI process to
ChildProcesses with messages that indicate the current required process
suppression state. WebProcessProxy should determine if the process is
eligible for process suppression based on both application occlusion
and page visibility. When either of these parameters changes,
the proxy should message the child process of the updated process
suppression state.
- NetworkProcess/NetworkProcess.messages.in: Rename
SetApplicationIsOccluded to SetProcessSuppressionEnabled.
- PluginProcess/PluginProcess.messages.in: Ditto.
- Shared/ChildProcess.h:
(WebKit::ChildProcess::processSuppressionEnabled): Rename
applicationIsOccluded.
- Shared/WebPreferencesStore.h: Add a new preference
pageVisibilityBasedProcessSuppressionEnabled, to enabled/disable
process suppression of WebProcesses when all pages are hidden.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): Rename
setApplicationIsOccluded.
(WebKit::ChildProcess::platformInitialize): Replace call to
setApplicationIsOccluded with setProcessSuppressionEnabled.
- SharedWorkerProcess/SharedWorkerProcess.messages.in: Rename
SetApplicationIsOccluded to SetProcessSuppressionEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPageVisibilityBasedProcessSuppressionEnabled):
(WKPreferencesGetPageVisibilityBasedProcessSuppressionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Use setter
to update process suppression state instead of messaging directly.
Use WebContext::canEnableProcessSuppressionForNetworkProcess() helper
method to determine if process suppression should be enabled.
- UIProcess/Network/NetworkProcessProxy.h: Rename
setApplicationIsOccluded to setProcessSuppresionEnabled.
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::NetworkProcessProxy::setProcessSuppressionEnabled): Ditto.
- UIProcess/Plugins/PluginProcessManager.h: Ditto.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Use setter
to update process suppression state instead of messaging directly.
Use WebContext::canEnableProcessSuppressionForGlobalChildProcesses()
helper method to determine if process suppression should be enabled.
- UIProcess/Plugins/PluginProcessProxy.h: Rename
setApplicationIsOccluded to setProcessSuppresionEnabled.
- UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::setProcessSuppressionEnabled): Ditto.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setProcessSuppressionEnabled): Ditto.
- UIProcess/SharedWorkers/SharedWorkerProcessManager.h: Ditto.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Use setter
to update process suppression state instead of messaging directly.
Use WebContext::canEnableProcessSuppressionForGlobalChildProcesses()
helper method to determine if process suppression should be enabled.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h: Rename
setApplicationIsOccluded to setProcessSuppresionEnabled.
- UIProcess/SharedWorkers/mac/SharedWorkerProcessManagerMac.mm:
(WebKit::SharedWorkerProcessManager::setProcessSuppressionEnabled):
Ditto.
- UIProcess/SharedWorkers/mac/SharedWorkerProcessProxyMac.mm:
(WebKit::SharedWorkerProcessProxy::setProcessSuppressionEnabled): Ditto.
- UIProcess/WebContext.h: Replace applicationIsOccluded() getter with
helper methods to determine if a child process can have process
suppression enabled.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange): Notify WebProcessProxy of
page visibility change.
(WebKit::WebPageProxy::preferencesDidChange): Notify WebProcessProxy of
change in preferences.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy): Initialize member variable
tracking process suppression state to false.
(WebKit::WebProcessProxy::createWebPage): Update set of pages which can
be process suppressed and the resulting process suppression state for
the child process.
(WebKit::WebProcessProxy::addExistingWebPage): Ditto.
(WebKit::WebProcessProxy::removeWebPage): Ditto.
(WebKit::WebProcessProxy::pageVisibilityChanged): Ditto.
(WebKit::WebProcessProxy::pagePreferencesChanged): Ditto.
(WebKit::WebProcessProxy::didFinishLaunching): Call
updateProcessSuppressionState().
- UIProcess/WebProcessProxy.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::updateProcessSuppressionStateOfGlobalChildProcesses): Use new
helper method canEnableProcessSuppressionForGlobalChildProcesses() to
determine if process suppression should be enabled.
(WebKit::applicationOcclusionStateChanged): Update renamed methods
and variables.
(WebKit::enableOcclusionNotifications): Move OmitProcessSuppression
user default check into canEnableProcessSuppression methods.
(WebKit::omitProcessSuppression):
(WebKit::WebContext::updateProcessSuppressionStateOfChildProcesses):
Use new helper method canEnableProcessSuppressionForNetworkProcess() to
determine if process suppression should be enabled for NetworkProcess.
Let WebProcess update process suppression state based on application
occlusion state and page visibility.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess):
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess):
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses):
(WebKit::WebContext::processSuppressionEnabledChanged): Reevaluate if
process suppression is enabled for all contexts and update process
suppression state of global child processes.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::pageIsProcessSuppressible):
(WebKit::WebProcessProxy::allPagesAreProcessSuppressible):
(WebKit::WebProcessProxy::updateProcessSuppressionState):
- WebProcess/WebProcess.messages.in:
- 2:51 PM Changeset in webkit [141166] by
-
- 14 edits in trunk/Source/WebCore
Change DatabaseContext lookup to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=107784.
Reviewed by Geoffrey Garen.
DatabaseContext will no longer be a Supplement of ScriptExecutionContext.
Instead we will maintain a mutex guarded contextMap in the DatabaseManager
which maps ScriptExecutionContexts to DatabaseContexts.
Also cleaned up the shutdown mechanism of the DatabaseContext,
DatabaseThread, and Databases when their owner ScriptExecutionContext
destructs.
No new tests.
- Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::AbstractDatabase):
- Modules/webdatabase/AbstractDatabase.h:
(WebCore::AbstractDatabase::databaseContext):
(AbstractDatabase):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
- Modules/webdatabase/Database.h:
(WebCore):
(Database):
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore):
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::~DatabaseContext):
(WebCore::DatabaseContext::contextDestroyed):
(WebCore::DatabaseContext::stop):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::stopDatabases):
- Modules/webdatabase/DatabaseContext.h:
(DatabaseContext):
(WebCore::DatabaseContext::scriptExecutionContext):
(WebCore::DatabaseContext::hasOpenDatabases):
(WebCore::DatabaseContext::stopDatabases):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::manager):
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::getExistingDatabaseContext):
(WebCore):
(WebCore::DatabaseManager::getDatabaseContext):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::notifyDatabaseContextConstructed):
(WebCore::DatabaseManager::notifyDatabaseContextDestructed):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::hasOpenDatabases):
(WebCore::DatabaseManager::stopDatabases):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
- Modules/webdatabase/DatabaseManager.h:
(WebCore):
(DatabaseManager):
(WebCore::DatabaseManager::notifyDatabaseContextConstructed):
(WebCore::DatabaseManager::notifyDatabaseContextDestructed):
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::DatabaseSync):
- Modules/webdatabase/DatabaseSync.h:
(WebCore):
(DatabaseSync):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::~DatabaseThread):
(WebCore::DatabaseThread::requestTermination):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::~ActiveDOMObject):
- 2:24 PM Changeset in webkit [141165] by
-
- 9 edits1 copy in trunk/Source/WebKit2
Start using the message flag in MessageEncoder/MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=108227
Reviewed by Beth Dakin.
Stop using the flags in MessageID and store the flags directly in the message instead.
This is another step towards eliminating MessageID.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
(CoreIPC::MessageDecoder::isSyncMessage):
(CoreIPC):
(CoreIPC::MessageDecoder::shouldDispatchMessageWhenWaitingForSyncReply):
- Platform/CoreIPC/MessageDecoder.h:
(MessageDecoder):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC):
(CoreIPC::MessageEncoder::MessageEncoder):
(CoreIPC::MessageEncoder::~MessageEncoder):
(CoreIPC::MessageEncoder::setIsSyncMessage):
(CoreIPC::MessageEncoder::setShouldDispatchMessageWhenWaitingForSyncReply):
- Platform/CoreIPC/MessageEncoder.h:
(MessageEncoder):
- Platform/CoreIPC/MessageFlags.h: Copied from Source/WebKit2/Platform/CoreIPC/MessageEncoder.h.
(CoreIPC):
- Platform/CoreIPC/MessageID.h:
- WebKit2.xcodeproj/project.pbxproj:
- 2:14 PM Changeset in webkit [141164] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Temporarily disable inspector tests.
They are all timing out due to some configuration problem on the bots.
- platform/win/TestExpectations:
- 2:11 PM Changeset in webkit [141163] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] Make resolveContentBasedTrackSizingFunctionsForItems reuse distributeSpaceToTracks
https://bugs.webkit.org/show_bug.cgi?id=108110
Reviewed by Tony Chang.
This change makes us match more closely the specification by reusing distributeSpaceToTracks inside
resolveContentBasedTrackSizingFunctionsForItems. This also removes some existing code duplication.
Refactoring covered by existing tests.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Updated after distributeSpaceToTracks new arguments. Copying the tracks to a Vector<GridTrack*> is
now done here.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Removed code duplication and switched to using distributeSpaceToTracks.
(WebCore::RenderGrid::distributeSpaceToTracks):
Refactored distributeSpaceToTracks to implement the distribution of any extra space above max breadth
as it was required to pass the tests (required to properly handling min-content > max). Also changed
the arguments of the function to better match the intent of the function.
- rendering/RenderGrid.h: Updated distributeSpaceToTracks's arguments.
- 1:51 PM Changeset in webkit [141162] by
-
- 3 edits in trunk/Source/WebCore
Remove all ShadowRoots during ElementShadow destruction
https://bugs.webkit.org/show_bug.cgi?id=108207
Reviewed by Dimitri Glazkov.
There's no reason to expose removeAllShadowRoots since the only legitimate
place to call it is right as we're destroying the ElementShadow.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::~Element): Remove call to removeAllShadowRoots()
- dom/ElementShadow.h:
(WebCore::ElementShadow::~ElementShadow): Call removeAllShadowRoots().
(ElementShadow): Make removeAllShadowRoots() private.
- 1:49 PM Changeset in webkit [141161] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 140834
BUG=164581
Review URL: https://codereview.chromium.org/12087064
- 1:32 PM Changeset in webkit [141160] by
-
- 4 edits2 adds in trunk
REGRESSION (r135628-135632): Double box shadow failure to render
https://bugs.webkit.org/show_bug.cgi?id=107833
Reviewed by Simon Fraser.
Source/WebCore:
Regression caused by http://trac.webkit.org/changeset/135629
The regression was due to faulty occlusion logic that was assuming
that drawing the background color of a render box background layer
could be skipped when the same layer also has an opaque image attached.
In the case where the background color is drawn for the purpose of
rendering a box shadow, the shadow is typically not
completely occluded by the background image because of the shadow
blur and/or offset. This patch fixes the problem by not culling a
background draw if it is used to draw a box shadow.
Test: fast/backgrounds/gradient-background-shadow.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Changing occlusion culling test to never cull background color
draw if it is used to draw a box shadow. This is because box shadows
can draw outside the border fill region.
LayoutTests:
New ref test verifies that box shadow is drawn when
background is an opaque image. Test uses an blue gradient
as background image. Reference uses blue background color.
- fast/backgrounds/gradient-background-shadow-expected.html: Added.
- fast/backgrounds/gradient-background-shadow.html: Added.
- 1:22 PM Changeset in webkit [141159] by
-
- 2 edits in trunk/Source/WebCore
Add RenderLayer::enclosingStackingContainer
https://bugs.webkit.org/show_bug.cgi?id=108211
Reviewed by Simon Fraser.
No new tests, no change in functionality.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::enclosingStackingContainer):
This function is similar to RenderLayer::stackingContainer, but may return the
layer itself if it's a stacking container.
- 1:19 PM Changeset in webkit [141158] by
-
- 7 edits4 deletes in branches/chromium/1364
Revert 141139
Merge 140202
Fix scrollRectToVisible in the presence of transforms
https://bugs.webkit.org/show_bug.cgi?id=105574
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-18
Reviewed by Simon Fraser.
Source/WebCore:
When scrolling to reveal an overflow layer, the required scroll was
being calculated in absolute coordinates. To properly account for
transforms, this calculation should be done in the local coordinates
of the renderBox.
Tests: editing/input/reveal-selection-transformed-overflow-parent.html
editing/input/reveal-selection-transformed-textarea.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
When scrolling to reveal an overflow layer, calculate the required
scroll in the local coordinates of the RenderBox.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteToLocalQuad):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
Add function to convert an absolute quad to a local quad.
LayoutTests:
- editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added.
- editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
Test that when scrolling an overflow layer to reveal a rect, the rect
passed to the parent to scroll is calculated properly.
- editing/input/reveal-caret-of-transformed-multiline-input.html: Added.
- editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.
Test that scrolling to reveal a rect works properly on a transformed
overflow layer.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12084049
TBR=kerz@chromium.org
Review URL: https://codereview.chromium.org/12087062
- 1:18 PM Changeset in webkit [141157] by
-
- 2 edits in trunk
[CMake] Add minimum version information for tool dependencies
https://bugs.webkit.org/show_bug.cgi?id=97592
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-29
Reviewed by Kenneth Rohde Christiansen.
Capture the minimum version information for the tools that are required
to build WebKit for all CMake based build systems.
- CMakeLists.txt:
- 1:14 PM Changeset in webkit [141156] by
-
- 1 edit1 move1 add in trunk/Source/WebCore
Rename TextBreakIteratorWinCE to TextBreakIteratorWchar
https://bugs.webkit.org/show_bug.cgi?id=108094
Reviewed by Ryosuke Niwa.
TextBreakIteratorWinCE does not contain any Windows CE specific code.
Rename it to TextBreakIteratorWchar to match the name in wtf/unicode.
- platform/text/wchar/TextBreakIteratorWchar.cpp: Renamed from Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp.
- 1:13 PM Changeset in webkit [141155] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/Modules/webdatabase/AbstractDatabase.cpp
Merge 141057
BUG=171951
Review URL: https://codereview.chromium.org/12094043
- 1:11 PM Changeset in webkit [141154] by
-
- 8 edits in trunk/Source/JavaScriptCore
Force debug builds to do bounds checks on contiguous property storage
https://bugs.webkit.org/show_bug.cgi?id=108212
Reviewed by Mark Hahnenberg.
Add a ContiguousData type that we use to represent contiguous property
storage. In release builds it is simply a pointer to the correct type,
but in debug builds it also carries the data length and performs bounds
checks. This means we don't have to add as many manual bounds assertions
when performing operations over contiguous data.
- dfg/DFGOperations.cpp:
- runtime/ArrayStorage.h:
(ArrayStorage):
(JSC::ArrayStorage::vector):
- runtime/Butterfly.h:
(JSC::ContiguousData::ContiguousData):
(ContiguousData):
(JSC::ContiguousData::operator[]):
(JSC::ContiguousData::data):
(JSC::ContiguousData::length):
(JSC):
(JSC::Butterfly::contiguousInt32):
(Butterfly):
(JSC::Butterfly::contiguousDouble):
(JSC::Butterfly::contiguous):
- runtime/JSArray.cpp:
(JSC::JSArray::sortNumericVector):
(ContiguousTypeAccessor):
(JSC::ContiguousTypeAccessor::getAsValue):
(JSC::ContiguousTypeAccessor::setWithValue):
(JSC::ContiguousTypeAccessor::replaceDataReference):
(JSC):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
- runtime/JSArray.h:
(JSArray):
- runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::visitButterfly):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::rageConvertDoubleToContiguous):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::rageEnsureContiguousSlow):
(JSC::JSObject::ensureLengthSlow):
- runtime/JSObject.h:
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::rageEnsureContiguous):
(JSObject):
(JSC::JSObject::indexingData):
(JSC::JSObject::currentIndexingData):
- 1:08 PM Changeset in webkit [141153] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Correct zoom for focused node when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107599
Reviewed by Adam Barth.
When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
(WebKit):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
- tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
- 1:04 PM Changeset in webkit [141152] by
-
- 2 edits in trunk/Tools
[EFL] Add Toggle fullscreen (F11) to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108122
Reviewed by Antonio Gomes.
Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
- MiniBrowser/efl/main.c:
(on_key_down): Add 'F11' key handler.
- 1:04 PM WinCE edited by
- (diff)
- 12:59 PM Changeset in webkit [141151] by
-
- 10 edits in trunk/Source
MediaStream API: A MediaStreamComponent should be able to return the MediaStreamDescriptor it belongs to
https://bugs.webkit.org/show_bug.cgi?id=108173
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebMediaStreamComponent.h:
(WebKit):
(WebMediaStreamComponent):
Source/WebCore:
To be able to return the MediaStreamDescriptor a MediaStreamComponent belongs to the "ownership"
of the MediaStreamDescriptor needed to move from a MediaStreamTrack to the MediaStreamComponent.
This is also better from an architectonic view as well.
Patch covered by existing tests.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::addRemoteTrack):
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
- Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
- platform/chromium/support/WebMediaStreamComponent.cpp:
(WebKit::WebMediaStreamComponent::stream):
(WebKit):
- platform/mediastream/MediaStreamComponent.h:
(WebCore):
(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::stream):
(WebCore::MediaStreamComponent::setStream):
(WebCore::MediaStreamComponent::MediaStreamComponent):
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
- 12:56 PM Changeset in webkit [141150] by
-
- 11 edits in trunk/Source/WebKit2
Encode/decode message send flags in the message
https://bugs.webkit.org/show_bug.cgi?id=108208
Reviewed by Beth Dakin.
This is another step towards getting rid of MessageID.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeUInt8):
(CoreIPC):
- Platform/CoreIPC/ArgumentDecoder.h:
(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decode):
(CoreIPC):
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC):
- Platform/CoreIPC/ArgumentEncoder.h:
(ArgumentEncoder):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/CoreIPC/MessageDecoder.h:
(CoreIPC::MessageDecoder::messageSendFlags):
(MessageDecoder):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC):
(CoreIPC::MessageEncoder::MessageEncoder):
(CoreIPC::MessageEncoder::~MessageEncoder):
(CoreIPC::MessageEncoder::setMessageSendFlags):
- Platform/CoreIPC/MessageEncoder.h:
(MessageEncoder):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(CoreIPC):
- 12:56 PM Changeset in webkit [141149] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows, WinCairo] Unreviewed build fix after r141050
- JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Update symbols
to match JavaScriptCore.vcproj version.
- 12:55 PM Changeset in webkit [141148] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 140520
BUG=170188
Review URL: https://codereview.chromium.org/12084050
- 12:54 PM Changeset in webkit [141147] by
-
- 2 edits in trunk/LayoutTests
Current error reporting method used by check-layout.js should not affect subsequent sub-tests using checking data-offset-y.
https://bugs.webkit.org/show_bug.cgi?id=105407
Patch by Pravin D <pravind.2k4@gmail.com> on 2013-01-29
Reviewed by Tony Chang.
When a testcase is processed by check-layout.js, the result is written just after the node being processed. This causes
offsetTop of subsequent sub-testcases to altered. If however if we process the nodes in the reverse order in which they
appear in the DOM tree, the result of node being processed will not affect the offsetTop of susequent nodes.
- resources/check-layout.js:
- 12:51 PM Changeset in webkit [141146] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 139806
BUG=168489
Review URL: https://codereview.chromium.org/12087060
- 12:48 PM Changeset in webkit [141145] by
-
- 8 edits in branches/chromium/1364/Source/WebCore/inspector
Merge 140127
BUG=170237
Review URL: https://codereview.chromium.org/12077053
- 12:40 PM Changeset in webkit [141144] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/html/parser/HTMLConstructionSite.cpp
Merge 140537
BUG=170381
Review URL: https://codereview.chromium.org/12091046
- 12:37 PM Changeset in webkit [141143] by
-
- 1 edit4 copies in branches/chromium/1364
Merge 140101
BUG=170381
Review URL: https://codereview.chromium.org/12088052
- 12:32 PM Changeset in webkit [141142] by
-
- 13 edits in trunk/Source
IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
https://bugs.webkit.org/show_bug.cgi?id=103920
Reviewed by Dimitri Glazkov.
Source/WebCore:
Update IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded to
pass through a metadata parameter. While there, remove the unused
IDBTransactionBackendInterface parameter to onUpgradeNeeded.
As this is another step in the IDB refactor, I've simplified future cleanup
work by making the WebKit API code still use the old API. This
will make it possible to outright remove code on the chromium side rather
than another three-step checkin.
No new tests, as this is more refactoring.
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onUpgradeNeeded): new method signature.
(WebCore::IDBCallbacks::onSuccess): new method signature.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): use passed-in metadata.
(WebCore::IDBOpenDBRequest::onSuccess): use passed-in metadata.
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
Source/WebKit/chromium:
Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
while maintaining chromium compatibility by shimming in the old API
in the WebKit side. Future code will clean this up so that it is just a
pass-through as it was before.
- public/WebIDBCallbacks.h:
(WebKit):
(WebKit::WebIDBCallbacks::onSuccess): new method signature.
(WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
(WebKit):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
(WebKit):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp: new method signature.
(WebCore::MockIDBCallbacks::onSuccess):
- tests/IDBDatabaseBackendTest.cpp: new method signature.
- 12:26 PM Changeset in webkit [141141] by
-
- 6 edits3 adds in trunk
Canvas support for isPointInStroke
https://bugs.webkit.org/show_bug.cgi?id=108185
Reviewed by Dean Jackson.
Source/WebCore:
isPointInStroke(x,y) returns true if a point hits the stroke
with applied stroke styles like dashArray, lineCap, lineJoin, lineWidth.
The syntax is similar to isPointInPath, which returns true if a point hits
the fill area of a path.
Firefox implemented isPointInStroke originally and unprefixed it recently:
https://bugzilla.mozilla.org/show_bug.cgi?id=803124
Test: fast/canvas/canvas-isPointInStroke.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasStrokeStyleApplier::strokeStyle): Take dashArray and lineDashOffset into account.
(WebCore):
(WebCore::CanvasRenderingContext2D::isPointInStroke): The implementation of the function.
- html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
- html/canvas/CanvasRenderingContext2D.idl: Added operation to interface.
LayoutTests:
Test the implementation of isPointOfStroke with all stroke style
properties in Canvas.
- fast/canvas/canvas-isPointInStroke-expected.txt: Added.
- fast/canvas/canvas-isPointInStroke.html: Added.
- fast/canvas/script-tests/canvas-isPointInStroke.js: Added.
- fast/canvas/canvas-isPointInStroke-expected.txt: Added.
- fast/canvas/canvas-isPointInStroke.html: Added.
- fast/canvas/script-tests/canvas-isPointInStroke.js: Added.
- inspector/profiler/canvas2d/canvas2d-api-changes.html: Added property for isPointInStroke.
- 12:19 PM Changeset in webkit [141140] by
-
- 4 edits4 moves in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r141122.
Removing a few duplicate test expectations.
- platform/gtk/TestExpectations:
- platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.txt:
- platform/gtk/fonts/complex-text-shadows-expected.txt: Replaced with LayoutTests/platform/gtk/platform/gtk/fonts/complex-text-shadows-expected.txt.
- platform/gtk/fonts/font-face-with-complex-text-expected.txt: Replaced with LayoutTests/platform/gtk/platform/gtk/fonts/font-face-with-complex-text-expected.txt.
- platform/gtk/fonts/non-bmp-characters-expected.png: Copied from LayoutTests/platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.png.
- platform/gtk/fonts/non-bmp-characters-expected.txt: Copied from LayoutTests/platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.txt.
- platform/gtk/platform/gtk/fonts/complex-text-shadows-expected.txt: Removed.
- platform/gtk/platform/gtk/fonts/font-face-with-complex-text-expected.txt: Removed.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.png: Removed.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.txt: Removed.
- platform/gtk/svg/text/non-bmp-positioning-lists-expected.txt:
- 12:12 PM Changeset in webkit [141139] by
-
- 7 edits4 copies in branches/chromium/1364
Merge 140202
Fix scrollRectToVisible in the presence of transforms
https://bugs.webkit.org/show_bug.cgi?id=105574
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-18
Reviewed by Simon Fraser.
Source/WebCore:
When scrolling to reveal an overflow layer, the required scroll was
being calculated in absolute coordinates. To properly account for
transforms, this calculation should be done in the local coordinates
of the renderBox.
Tests: editing/input/reveal-selection-transformed-overflow-parent.html
editing/input/reveal-selection-transformed-textarea.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
When scrolling to reveal an overflow layer, calculate the required
scroll in the local coordinates of the RenderBox.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteToLocalQuad):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
Add function to convert an absolute quad to a local quad.
LayoutTests:
- editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added.
- editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
Test that when scrolling an overflow layer to reveal a rect, the rect
passed to the parent to scroll is calculated properly.
- editing/input/reveal-caret-of-transformed-multiline-input.html: Added.
- editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.
Test that scrolling to reveal a rect works properly on a transformed
overflow layer.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12084049
- 12:10 PM Changeset in webkit [141138] by
-
- 6 edits2 copies in branches/chromium/1364
Merge 140748
BUG=171907
Review URL: https://codereview.chromium.org/12092048
- 12:07 PM Changeset in webkit [141137] by
-
- 2 edits in trunk/Tools
[CMake] Use offical Windows CE support
https://bugs.webkit.org/show_bug.cgi?id=108061
Reviewed by Laszlo Gombos.
Recent version of CMake has added Windows CE support, but uses a
slightly different interface than the patched version used before.
Change the command line parameters to use the offical CMake binaries.
- Scripts/webkitdirs.pm:
(cmakeBasedPortArguments):
- 12:06 PM Changeset in webkit [141136] by
-
- 25 edits3 adds in trunk
.: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Adam Barth.
- Source/autotools/symbols.filter: Expose MemoryCache::resourceForURL().
Source/WebCore: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Adam Barth.
Test: http/tests/cache/cached-main-resource.html
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute.
(WebCore):
- dom/Document.h:
(Document):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since
MainResourceLoader will take care of it.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also,
ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader.
(WebCore::MainResourceLoader::identifier):
- loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader
to better describe when it is used.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary.
(WebCore::CachedRawResource::willSendRequest): Note the redirects we received.
(WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store".
- loader/cache/CachedRawResource.h:
(CachedRawResource):
(RedirectPair):
(WebCore::CachedRawResource::RedirectPair::RedirectPair):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addClientToSet): Don't return cached data for a main resource synchronously
- loader/cache/CachedResource.h:
(WebCore::CachedResource::canReuse):
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource): Leave cahce reuse of main resources off for chromium for now.
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources.
- testing/Internals.cpp:
(WebCore::Internals::isPreloaded):
(WebCore):
(WebCore::Internals::isLoadingFromMemoryCache):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/win: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Adam Barth.
- WebKit.vcproj/WebKitExports.def.in: Expose some MemoryCache symbols for use in Internals.
LayoutTests: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667.
Reviewed by Adam Barth.
- http/tests/cache/cached-main-resource-expected.txt: Added.
- http/tests/cache/cached-main-resource.html: Added.
- http/tests/cache/resources/cacheable-iframe.php: Added.
- http/tests/inspector/resource-har-pages-expected.txt:
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
- http/tests/misc/link-rel-icon-beforeload-expected.txt:
- platform/chromium/TestExpectations:
- 11:09 AM Changeset in webkit [141135] by
-
- 2 edits in trunk/Source/WebCore
Fix a problem that deferred image decoding is enabled for multiframe images
https://bugs.webkit.org/show_bug.cgi?id=108152
Patch by Min Qin <qinmin@chromium.org> on 2013-01-29
Reviewed by Stephen White.
Deferred image decoding should only work for single frame images now.
However, using ImageDecoder::repetitionCount() does not capture all the cases.
Enforce the rule using ImageDecoder::frameCount()==1.
Fixing a failing layout test: platform/chromium/virtual/deferred/fast/images/icon-0colors.html
- platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
- 11:01 AM Changeset in webkit [141134] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix contents size calculation for page scale initialization
https://bugs.webkit.org/show_bug.cgi?id=108204
Reviewed by enne.
My previous patch http://webk.it/107424 had a few issues that are
blocking WebKit roll.
- We still need the layout in resize() given that
http://webk.it/107922 was reverted.
- I deleted code used only for the old page-scale mode in
contentsSize(), but this needs to wait until WebKit roll since it's
making bots fail in this short term.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::contentsSize):
- 10:47 AM WebKitIDL edited by
- Typos. (diff)
- 10:30 AM WebKitIDL edited by
- (diff)
- 10:22 AM Changeset in webkit [141133] by
-
- 2 edits in trunk/LayoutTests
Add back test expectations that got erroneously removed in r140981.
- platform/mac/TestExpectations:
- 10:22 AM Changeset in webkit [141132] by
-
- 3 edits in trunk/Source/WebCore
Move ElementShadow creation to ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=108195
Reviewed by Dimitri Glazkov.
Move the creation of ElementShadow to ElementRareData
for better encapsulation, and get rid of ElementRareData::setShadow.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::~Element): Use clearShadow() instead of setShadow which is removed.
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow): Use ElementRareData::ensureShadow().
- dom/ElementRareData.h:
(WebCore::ElementRareData::clearShadow): Added.
(WebCore::ElementRareData::ensureShadow): Added.
- 10:16 AM Changeset in webkit [141131] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Unreviewed build fix.
Revert my revert at 141033 which can cause deadlock.
- platform/graphics/chromium/DiscardablePixelRef.cpp:
(WebCore::DiscardablePixelRefAllocator::allocPixelRef):
(WebCore::DiscardablePixelRef::DiscardablePixelRef):
- platform/graphics/chromium/DiscardablePixelRef.h:
(DiscardablePixelRef):
- 10:09 AM Changeset in webkit [141130] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed DEPS roll.
Roll Chromium DEPS to 179332.
- DEPS:
- 10:07 AM Changeset in webkit [141129] by
-
- 8 edits1 copy3 adds in trunk/Tools
QueueStatusServer needs pages to display historical queue data
https://bugs.webkit.org/show_bug.cgi?id=107659
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Eric Seidel.
Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
- QueueStatusServer/app.yaml:
- QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
(get_time_unit):
- QueueStatusServer/filters/webkit_extras.py:
(webkit_linkify):
(webkit_bug_id):
(webkit_attachment_id):
(results_link):
(queue_status_link):
(queue_charts_link):
- QueueStatusServer/handlers/queuecharts.py: Added.
(QueueCharts):
(QueueCharts.get):
(QueueCharts._get_min_med_max):
(QueueCharts._get_patch_data):
(QueueCharts._get_patch_logs):
(QueueCharts._get_queue_data):
(QueueCharts._get_queue_logs):
(QueueCharts._get_time_unit):
(QueueCharts._get_timestamp):
(QueueCharts._get_view_range):
- QueueStatusServer/handlers/queuestatus.py:
(QueueStatus.get):
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/queuelog.py:
(QueueLog):
(QueueLog.create_key):
(QueueLog.get_at):
(QueueLog.get_current):
(QueueLog.get_or_create):
(QueueLog._get_or_create_txn):
- QueueStatusServer/stylesheets/charts.css: Added.
(.chart):
(.choices):
- QueueStatusServer/templates/queuecharts.html: Added.
- QueueStatusServer/templates/queuestatus.html:
- 9:58 AM Changeset in webkit [141128] by
-
- 13 edits in trunk/Source
[Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
https://bugs.webkit.org/show_bug.cgi?id=107851
Reviewed by Tony Chang.
Source/WebCore:
Internal to the back-end, callers are able to abort transactions and specify a reason
as an IDBDatabaseError, e.g. ConstraintError. Expose this to the WebKit/chromium/public
API so that intermediate layers can specify reasons as well, e.g. QuotaExceededError.
Test will land in Chromium as fix for crbug.com/113118
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::abort): Added overload that takes error.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Ditto.
- Modules/indexeddb/IDBDatabaseBackendInterface.h: Ditto.
Source/WebKit/chromium:
Let Chromium call abort() on a transaction and specify a reason, specifically for
QuotaExceededError.
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::abort): New overload for abort() that takes an error.
- public/WebIDBDatabaseError.h:
(WebKit::WebIDBDatabaseError::WebIDBDatabaseError): Overloaded constructor/assign that takes error.
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::abort): New overload for abort() that takes an error.
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy): Ditto.
- src/WebIDBDatabaseError.cpp: Implementation of overload ctor/assign.
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::abort): New overload for abort() that takes an error.
- src/WebIDBDatabaseImpl.h: Ditto.
- tests/IDBDatabaseBackendTest.cpp: Overload stubs for Mock class.
- 9:52 AM Changeset in webkit [141127] by
-
- 4 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderTextTrackCue::layout
https://bugs.webkit.org/show_bug.cgi?id=108197
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-rendering-tree-is-removed-properly.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ensure the display tree
is removed when the cue is removed from the list of cues.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::~TextTrackCue): Enfore display tree removal.
LayoutTests:
Added test that triggers the crash. Verified proper removal of the tree.
- media/track/track-cue-rendering-tree-is-removed-properly-expected.txt: Added.
- media/track/track-cue-rendering-tree-is-removed-properly.html: Added.
- 9:50 AM Changeset in webkit [141126] by
-
- 9 edits in trunk
[GTK] Missing build flags when building with Harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=108174
Reviewed by Martin Robinson.
Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
parameter will be added to linking lines when needed.
Source/WebKit/gtk:
- GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
Source/WebKit2:
- GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
- UIProcess/API/gtk/tests/GNUmakefile.am: Ditto.
Tools:
- GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
- MiniBrowser/gtk/GNUmakefile.am: Ditto.
- TestWebKitAPI/GNUmakefile.am: Ditto.
- 9:44 AM Changeset in webkit [141125] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
- tests/WebFrameTest.cpp:
- 9:32 AM Changeset in webkit [141124] by
-
- 2 edits2 adds in trunk
On HarfbuzzNG ports, Arabic TATWEEL is not joined.
https://bugs.webkit.org/show_bug.cgi?id=108037
Reviewed by Tony Chang.
The tatweel (U+0640) is being split into a separate run, because its script is USCRIPT_COMMON.
It has script extensions for USCRIPT_ARABIC, so I think it shouldn't trigger a new run.
Test: fast/text/international/arabic-tatweel-join.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
- 9:29 AM Changeset in webkit [141123] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a failing ref html test.
- platform/qt/TestExpectations:
- 9:25 AM Changeset in webkit [141122] by
-
- 6 edits4 adds in trunk
[Freetype] Cannot use characters outside the BMP
https://bugs.webkit.org/show_bug.cgi?id=108102
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-29
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Test: platform/gtk/fonts/non-bmp-characters.html
Instead of never handling surrogate pairs when dealing with UChar arrays,
abstract way the logic for this into UTF16UChar32Iterator and use it
everywhere in Freetype. This allows the Freetype backend to render
non-BMP characters which are always represented as surrogate pairs in
UTF-16.
- GNUmakefile.list.am: Added UTF16UChar32Iterator to the source list.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters): Use the new iterator.
(WebCore::FontCache::getFontDataForCharacters): Ditto.
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill): Ditto. Remove the early return when dealing
with non-BMP data.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters): Use the new iterator.
- platform/graphics/freetype/UTF16UChar32Iterator.h: Added. An iterator that
extracts UChar32 from UTF-16 UChar arrays.
- GNUmakefile.list.am:
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters):
(WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters):
- platform/graphics/freetype/UTF16UChar32Iterator.h: Added.
(WebCore):
(UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::end):
(WebCore::UTF16UChar32Iterator::next):
- GNUmakefile.list.am:
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters):
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters):
- platform/graphics/freetype/UTF16UChar32Iterator.h: Added.
(WebCore):
(UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::end):
(WebCore::UTF16UChar32Iterator::next):
LayoutTests:
Added a pixel test for rendering non-BMP characters.
- platform/gtk/fonts/non-bmp-characters.html: Added.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.png: Added.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.txt: Added.
- 9:04 AM Changeset in webkit [141121] by
-
- 4 edits in trunk/Source/WebCore
Don't overlap test for composited scroll DIVs after scroll
https://bugs.webkit.org/show_bug.cgi?id=107471
Patch by Glenn Hartmann <hartmanng@chromium.org> on 2013-01-29
Reviewed by Simon Fraser.
We don't need to test for overlap after scroll when both
usesCompositedScrolling and !hasOutOfFlowPositionedDescendant
because:
a) Since we're using composited-scrolling, the composited region
presented by the composited-scrolling element to other non-descendant
layers doesn't change during composited scrolling (it's always the
entire scroll layer), and
b) Since we have no out of flow positioned descendants, the scrolling
descendants all move together, so their overlap with respect to each
other cannot change.
So no descendants nor any non-descendants can have their overlap
affected, so it's safe to skip testing.
No new tests (no change in behaviour).
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
- rendering/RenderLayerCompositor.h:
- 8:55 AM Changeset in webkit [141120] by
-
- 13 edits in branches/chromium/1397/Source/WebCore/bindings/v8
Revert 140611
[V8] Reduce usage of deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=107674
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
- bindings/v8/NPV8Object.cpp:
(_NPN_Enumerate):
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::bindToWindowObject):
(WebCore::ScriptController::disableEval):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::compileScript):
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12087054
- 8:55 AM Changeset in webkit [141119] by
-
- 17 edits2 adds in trunk
Implement pseudoElement attribute on transition DOM events.
https://bugs.webkit.org/show_bug.cgi?id=107986
Reviewed by Julien Chaffraix.
Source/WebCore:
Implement the pseudoElement attribute documented here :
http://dev.w3.org/csswg/css3-transitions/#transition-events.
This add a new attribute to the transition DOM event useful when
animating pseudo elements. As they are not accessible in JS, it's
very useful to get on which pseudo element the transition just ended.
This patch adds the new attribute on the IDLs of DOM transition events as well
as adding it to the C++ classes representing them. The event
dispatching code have been patched to change the target of the event
(we can't send the current target as it is the actual DOM
representation of the pseudo element).
Test: fast/css-generated-content/pseudo-transition-event.html
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingTargetRules): Change the target of the
event in the case of a pseudo element. We can't expose them through the
public interface so the target is the node they belong to.
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventTarget.cpp:
(WebCore::createMatchingPrefixedEvent):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::pseudoElementNameForEvents):
(WebCore):
- dom/PseudoElement.h:
- dom/TransitionEvent.cpp:
(WebCore::TransitionEventInit::TransitionEventInit):
(WebCore::TransitionEvent::TransitionEvent):
(WebCore::TransitionEvent::pseudoElement):
(WebCore):
- dom/TransitionEvent.h:
(TransitionEventInit):
(WebCore::TransitionEvent::create):
(TransitionEvent):
- dom/TransitionEvent.idl:
- dom/WebKitTransitionEvent.cpp:
(WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit):
(WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::pseudoElement):
(WebCore):
- dom/WebKitTransitionEvent.h:
(WebKitTransitionEventInit):
(WebCore::WebKitTransitionEvent::create):
(WebKitTransitionEvent):
- dom/WebKitTransitionEvent.idl:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Pass
the pseudo element name when creating the Event objects. If the element
is not a pseudo element then the name will be empty which is what the
spec is telling to do. If the element is a pseudo element then the name
will be the pseudo element's name with "::" as a prefix.
LayoutTests:
Add new tests to cover the feature.
- fast/css-generated-content/pseudo-transition-event-expected.txt: Added.
- fast/css-generated-content/pseudo-transition-event.html: Added.
- fast/events/constructors/transition-event-constructor-expected.txt:
- fast/events/constructors/transition-event-constructor.html:
- fast/events/constructors/webkit-transition-event-constructor-expected.txt:
- fast/events/constructors/webkit-transition-event-constructor.html:
- 8:54 AM Changeset in webkit [141118] by
-
- 14 edits in branches/chromium/1397/Source/WebCore
Revert 138962
ResourceHandle::willLoadFromCache is evil
https://bugs.webkit.org/show_bug.cgi?id=106147
Reviewed by Brady Eidson.
For back/forward navigations to a page that's a result of form submission, we may
never silently re-submit the form. So, we show a warning dialog when about to re-submit,
but try to load from cache if possible.
This patch changes the logic so that we always try to fetch from cache, without
any preflighting. If cache load fails, we restart the load as a known re-submit.
No behavior change expected, so no tests.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): Added a FIXME.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Amended a FIXME with some information about why this call may still be needed.
- loader/FrameLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Pass an explicit argument for unchanged caching behavior. (WebCore::FrameLoader::reloadWithOverrideEncoding): Added a FIXME. This function can silently re-submit a form. (WebCore::FrameLoader::addExtraFieldsToMainResourceRequest): Added a FIXME about an incorrect use of current load type. (WebCore::FrameLoader::addExtraFieldsToRequest): Make sure that a correct caching policy is used for subresources even if main resource was loaded from cache. We didn't need that before because initial request had wrong extra fields due to a use of m_loadType when it was first called. Removed code to change caching policy for b/f navigations. This function does not have enough context to decide what the policy should be. (WebCore::FrameLoader::loadDifferentDocumentItem): Added an argument telling the function whether it should attempt loading from cache. It should do that on first attempt to navigate to a form submission result, but not if that failed. Pass a correct loadType - m_loadType is one for _previous_ load. Removed a special case for https - we've long stopped prohibiting caching of https resources, and using a resource that's already cached should definitely be allowed. (WebCore::FrameLoader::loadItem): Pass an explicit argument for unchanged caching behavior. (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad): Added.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::notifyFinished): Removed a check for m_resource being null, because we were immediately dereferencing it anyway. Call retryAfterFailedCacheOnlyMainResourceLoad() to let FrameLoader restart the navigation.
- platform/network/ResourceHandle.h:
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/chromium/ResourceHandle.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/qt/ResourceHandleQt.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/win/ResourceHandleWin.cpp: Removed willLoadFromCache() - the new logic is cross-platform.
TBR=ap@apple.com
Review URL: https://codereview.chromium.org/12090050
- 8:51 AM Changeset in webkit [141117] by
-
- 1 add in branches/chromium/1397/codereview.settings
for drovering
- 8:50 AM Changeset in webkit [141116] by
-
- 1 copy in branches/chromium/1397
branching to do dev
- 8:49 AM Changeset in webkit [141115] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Reclassified one IDB failure as a flaky crasher.
Added a test expectation for a flaky crasher that's failnig
due to probably malfunctioning accessibility code.
- platform/gtk/TestExpectations:
- 8:45 AM Changeset in webkit [141114] by
-
- 6 edits in trunk/Source
[Qt] Implement GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=103998
Reviewed by Simon Hausmann.
Source/JavaScriptCore:
Implements the activity triggered garbage collector.
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
- runtime/GCActivityCallback.h:
(GCActivityCallback):
(DefaultGCActivityCallback):
Source/WebCore:
Implements the activity triggered garbage collector,
and disables the timer based fallback.
- bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
- bindings/js/GCController.h:
(GCController):
- 8:09 AM Changeset in webkit [141113] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix bottom span in token highlight in DTE
https://bugs.webkit.org/show_bug.cgi?id=108194
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-29
Reviewed by Pavel Feldman.
Change css style for token highlight from "border" to "outline" to
avoid border included in box dimensions.
No new tests: no change in behaviour.
- inspector/front-end/textEditor.css:
(.text-editor-token-highlight):
- 8:02 AM Changeset in webkit [141112] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after r140927.
https://bugs.webkit.org/show_bug.cgi?id=108190.
- platform/qt/TestExpectations:
- 7:52 AM Changeset in webkit [141111] by
-
- 5 edits in trunk
Web Inspector: introduce HighlightDescriptor interface in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108161
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-29
Reviewed by Pavel Feldman.
Source/WebCore:
Introduce new HighlightDescriptor interface and its
RegexHighlightDescriptor implementation and use it in DTE to
support overlay highlight.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.highlightRegex):
(WebInspector.DefaultTextEditor.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
(WebInspector.TextEditorMainPanel.HighlightDescriptor): Added.
(WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.affectsLine):
(WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.rangesForLine):
(WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.cssClass):
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor): Added.
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.affectsLine):
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.rangesForLine):
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.cssClass):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._highlight):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._removeHighlight):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.removeRegexHighlight):
LayoutTests:
Correct layout test according to refactoring changes.
- inspector/editor/text-editor-highlight-regexp.html:
- 7:29 AM Changeset in webkit [141110] by
-
- 10 edits in trunk
[EFL] Unified text checker implementation.
https://bugs.webkit.org/show_bug.cgi?id=107682
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests, covered by editing/spelling tests.
- platform/text/TextChecking.h:
(WebCore):
Enabling unified text checker feature for WebKit-EFL.
Source/WebKit/efl:
Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):
Source/WebKit2:
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit):
(WebKit::TextChecker::checkTextOfParagraph):
Allow to check spelling for multiple words,
their misspelling location and length are saved to the vector.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
(WebKit::WebEditorClient::checkTextOfParagraph):
(WebKit):
As spelling implementation is exposed to UIProcess,
send a meesage to UIProcess to call TextChecker::checkTextOfParagraph.
LayoutTests:
- platform/efl-wk2/TestExpectations:
Skip context-menu-suggestions.html until
https://bugs.webkit.org/show_bug.cgi?id=107684 lands.
- 7:01 AM Changeset in webkit [141109] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Wrong indent in Styles sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=108186
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-29
Reviewed by Alexander Pavlov.
Added an extra selector to prevent a conflict with a rule in elementsPanel.css.
No new tests.
- inspector/front-end/inspector.css:
(.pane.expanded .section .properties, .event-bar .event-properties):
- 6:53 AM Changeset in webkit [141108] by
-
- 4 edits in trunk
Enable Workers for WinCE
https://bugs.webkit.org/show_bug.cgi?id=108099
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-29
Reviewed by Gyuyoung Kim.
WORKERS are enabled for all CMake based ports except WinCE.
Turn on WORKERS for all CMake based ports.
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- 6:48 AM Changeset in webkit [141107] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][WK1] Fix QObject Bridge tests expected output.
https://bugs.webkit.org/show_bug.cgi?id=107827
Reviewed by Simon Hausmann.
The "not a function" TypeError now includes the call that caused the error.
Correct expected values accordingly.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):
- 6:37 AM Changeset in webkit [141106] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-29
- platform/qt-5.0-wk2/TestExpectations: Skip broken plugin tests after r141051.
- 6:19 AM Changeset in webkit [141105] by
-
- 14 edits in trunk/Source/WebCore
[Chromium] Unreviewed gardening.
Update bindings-tests results after http://trac.webkit.org/changeset/141034.
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8Float64Array::createWrapper):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestActiveDOMObject::createWrapper):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestCustomNamedGetter::createWrapper):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestEventConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestEventTarget::createWrapper):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestException::createWrapper):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestInterface::createWrapper):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestMediaQueryListListener::createWrapper):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestNamedConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestNode::createWrapper):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestObj::createWrapper):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestOverloadedConstructors::createWrapper):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
- 6:14 AM Changeset in webkit [141104] by
-
- 2 edits3 deletes in trunk/LayoutTests
Unreviewed gardening. Update generic expected file after r141031.
Remove Chromium, GTK and Qt specific expected files, because they are the same as the generic expected file.
- 6:07 AM FeatureFlags edited by
- Remove SPEECH_INPUT - see 141092 (diff)
- 5:49 AM Changeset in webkit [141103] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Skipping tests broken by r141051.
- platform/efl-wk2/TestExpectations:
- 5:22 AM Changeset in webkit [141102] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add API to prefetch DNS of a given hostname to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99695
Reviewed by Anders Carlsson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_prefetch_dns): Public method to resolve the
domain name in advance for the given hostname.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_web_context_prefetch_dns.
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage): Parse PrefetchDNS message
and call WebCore::prefetchDNS() with the given hostname.
(didReceiveMessage): Call webkitWebExtensionDidReceiveMessage().
(webkitWebExtensionCreate): Add implementation for
didReceiveMessage callback.
- 4:59 AM Changeset in webkit [141101] by
-
- 2 edits3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip failing tests. https://bugs.webkit.org/show_bug.cgi?id=108175.
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added after r140999.
- platform/qt/fast/js/regress/integer-modulo-expected.txt: Added after r141031.
- 4:57 AM Changeset in webkit [141100] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: in inspector-protocol tests do not swallow errors
https://bugs.webkit.org/show_bug.cgi?id=108087
Patch by Peter Rybin <peter.rybin@gmail.com> on 2013-01-29
Reviewed by Pavel Feldman.
Additional checks are added. Debuggee is more aggressive at
when to kill the test.
- http/tests/inspector-protocol/resources/InspectorTest.js:
- http/tests/inspector-protocol/resources/protocol-test.js:
(runTest):
- 4:54 AM Changeset in webkit [141099] by
-
- 2 edits in trunk/Source/JavaScriptCore
Compilation warning in JSC
https://bugs.webkit.org/show_bug.cgi?id=108178
Reviewed by Kentaro Hara.
Fixed 'comparison between signed and unsigned integer' warning in JSC::Structure constructor.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- 4:43 AM Changeset in webkit [141098] by
-
- 8 edits in trunk
Web Inspector: [Canvas] support instrumenting canvases in iframes (backend side)
https://bugs.webkit.org/show_bug.cgi?id=107951
Reviewed by Pavel Feldman.
Source/WebCore:
Accept optional FrameId argument for captureFrame and startCapturing commands.
Add event to the protocol to inform about instrumented canvas context creation.
- inspector/Inspector.json:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::getResourceInfo):
(WebCore::InspectorCanvasAgent::getResourceState):
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::frameDetached):
- inspector/InspectorCanvasAgent.h:
(WebCore):
(WebCore::InspectorCanvasAgent::create):
(InspectorCanvasAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
LayoutTests:
Stub Canvas dispatcher for now to silence alerts in tests.
- inspector/profiler/canvas-profiler-test.js:
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent.InspectorBackend.registerCanvasDispatcher):
- 4:34 AM Changeset in webkit [141097] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Fix the JSC build on Mac
Unreviewed, build fix.
- heap/HeapTimer.h:
Qt on Mac has USE(CF) true, and should use the CF HeapTimer in that case.
- 4:01 AM Changeset in webkit [141096] by
-
- 10 edits2 adds in trunk
[GTK] Implement resources API using injected bundle
https://bugs.webkit.org/show_bug.cgi?id=107457
Reviewed by Sam Weinig.
Source/WebKit2:
The ResourceLoaderClient was removed from the UI process in
r140285, and most of the GTK+ API depends on resources. This patch
implements the same API using the ResourceLoaderClient from
injected bundle. It fixes the resources unit tests, as well as
other 14 unit tests that are timing out because they depend on
resource API.
- GNUmakefile.list.am: Add new files to compilation.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode): Add support for encoding
WebURLResponse and WebError objects in user messages.
(WebKit::UserMessageDecoder::baseDecode): Add support for decoding
WebURLResponse and WebError objects from user messages.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp: Added.
(didReceiveWebViewMessageFromInjectedBundle): Handle messages sent
to the WebView. For now it hanldes all the sresource loader client
messages.
(didReceiveMessageFromInjectedBundle): Handle messages received
from injected bundle.
(attachInjectedBundleClientToContext): Initialize the injected
bundle client.
- UIProcess/API/gtk/WebKitInjectedBundleClient.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Add a HashMap to map page IDs to
WebKitWebViews.
(createDefaultWebContext): Call
attachInjectedBundleClientToContext() to intialize the injected
bundle client.
(webkitWebContextCreatePageForWebView): Use
webkitWebViewBaseCreateWebPage() to create and initialize a new
WebPageProxy and map the newly created page with the given
WebKitWebView.
(webkitWebContextWebViewDestroyed): Called when the given
WebKitWebView is being destroyed to remove it from the views map.
(webkitWebContextGetWebViewForPage): Returns the WebKitWebView
associated to the given page ID.
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Use
webkitWebContextCreatePageForWebView() instead of
webkitWebViewBaseCreateWebPage() directly.
(webkitWebViewDispose): Call webkitWebContextWebViewDestroyed() to
notify the context.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didInitiateLoadForResource): Send a message to the UI process
with the callback parameters encoded.
(willSendRequestForFrame): Ditto.
(didReceiveResponseForResource): Ditto.
(didReceiveContentLengthForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.
(webkitWebPageCreate): Initialize the
WKBundlePageResourceLoadClient.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unksip resources unit tests.
- 3:58 AM Changeset in webkit [141095] by
-
- 2 edits in trunk/Tools
Unreviewed, updated my email information.
- Scripts/webkitpy/common/config/committers.py:
- 3:55 AM Changeset in webkit [141094] by
-
- 3 edits2 adds in trunk
Web Inspector: [CPU Profile] Taking profile crashes renderer.
https://bugs.webkit.org/show_bug.cgi?id=108072
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-29
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/profiler/cpu-profiler-agent-crash-on-start.html
Fixed null-pointer access.
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start): Fixed null-pointer access.
(WebCore::ScriptProfiler::stop): Ditto.
LayoutTests:
Added test to check that ProfilerAgent start/stop doesn't crash.
- inspector/profiler/cpu-profiler-agent-crash-on-start-expected.txt: Added.
- inspector/profiler/cpu-profiler-agent-crash-on-start.html: Added.
- 3:36 AM Changeset in webkit [141093] by
-
- 5 edits4 adds in trunk
REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style
https://bugs.webkit.org/show_bug.cgi?id=105672
Reviewed by Andreas Kling.
Source/WebCore:
Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits
were not set due to sharing of styles between cousin elements.
This patch fixes the issue by not sharing styles from children with parents who prevent sharing.
Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html
fast/selectors/cousin-stylesharing-last-child-selector.html
- css/StyleResolver.cpp:
(WebCore::parentElementPreventsSharing):
(WebCore::StyleResolver::locateCousinList):
- dom/Element.cpp:
(WebCore::Element::hasFlagsSetDuringStylingOfChildren):
- dom/Element.h:
(Element):
LayoutTests:
Two test cases by Philippe Wittenbergh that triggers the issue.
- fast/selectors/cousin-stylesharing-adjacent-selector-expected.html: Added.
- fast/selectors/cousin-stylesharing-adjacent-selector.html: Added.
- fast/selectors/cousin-stylesharing-last-child-selector-expected.html: Added.
- fast/selectors/cousin-stylesharing-last-child-selector.html: Added.
- 3:32 AM Changeset in webkit [141092] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Remove misspelled ENABLE(SPEECH_INPUT) guard
https://bugs.webkit.org/show_bug.cgi?id=105683
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-29
Reviewed by Simon Hausmann.
The ENABLE(SPEECH_INPUT) guard is only used in one location
in the source tree and as such it is always 0.
I believe that this guard is a left over and is not needed any more
as the code guarded is not guarded anywhere else.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- 3:08 AM Changeset in webkit [141091] by
-
- 3 edits2 adds in trunk
Web Inspector: [Regression] Search across all sources is broken.
https://bugs.webkit.org/show_bug.cgi?id=108157
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/search/scripts-search-scope.html
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
LayoutTests:
- http/tests/inspector/search/scripts-search-scope-expected.txt: Added.
- http/tests/inspector/search/scripts-search-scope.html: Added.
- 3:06 AM Changeset in webkit [141090] by
-
- 5 edits in trunk/Source/WebCore
IDBFactory::webkitGetDatabaseNames should raise DOMExceptions.
https://bugs.webkit.org/show_bug.cgi?id=108154
Reviewed by Jochen Eisinger.
In order to properly support blocking third-party IndexedDB usage,
open(), getDatabaseNames(), and deleteDatabase() should all throw
SECURITY_ERR when used in a blocked third-party context. That's possible
now for open() and deleteDatabase(), but getDatabaseNames() can't
currently raise exceptions.
This patch adjusts the IDL file and implementation. No exceptions are
currently thrown, but that will change as soon as wkbug.com/94171 lands.
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
- Modules/indexeddb/IDBFactory.h:
(IDBFactory):
- Modules/indexeddb/IDBFactory.idl:
Add "raises (DOMException)" to getDatabaseNames, and adjust the
implementation to match.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
Pass in an ExceptionCode when calling getDatabaseNames, and handle
possible exceptions.
- 2:51 AM Changeset in webkit [141089] by
-
- 5 edits in trunk/Source/JavaScriptCore
[Qt] Implement IncrementalSweeper and HeapTimer
https://bugs.webkit.org/show_bug.cgi?id=103996
Reviewed by Simon Hausmann.
Implements the incremental sweeping garbage collection for the Qt platform.
- heap/HeapTimer.cpp:
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::timerEvent):
(JSC::HeapTimer::synchronize):
(JSC::HeapTimer::invalidate):
(JSC::HeapTimer::didStartVMShutdown):
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::scheduleTimer):
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- 2:15 AM Changeset in webkit [141088] by
-
- 2 edits in trunk/Source/WebCore
Revert an accidentally changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650.
https://bugs.webkit.org/show_bug.cgi?id=108165
Reviewed by Hajime Morita.
No new tests.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
- 2:01 AM Changeset in webkit [141087] by
-
- 1 edit78 deletes in trunk/LayoutTests
Unreviewed, rolling out r140959 and r140977.
http://trac.webkit.org/changeset/140959
http://trac.webkit.org/changeset/140977
https://bugs.webkit.org/show_bug.cgi?id=108171
Reverting rebaseline because after r141067 the expected
results should be the old values. (Requested by kadam on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
- platform/qt-5.0-wk1/compositing/absolute-inside-out-of-view-fixed-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/bounds-in-flipped-writing-mode-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/clip-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/clip-inside-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/become-composited-nested-iframes-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/iframe-resize-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-nested-iframes-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/animation-overlap-with-children-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-clipping-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-container-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/masks/mask-layer-size-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/repaint/resize-repaint-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/tiled-layer-resize-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Removed.
- platform/qt-5.0-wk1/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
- platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.png: Removed.
- platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
- 2:01 AM Changeset in webkit [141086] by
-
- 32 edits in trunk/Source/WebCore
FeatureObserver: Input types are counted unexpectedly in a page with Modernizr
https://bugs.webkit.org/show_bug.cgi?id=108141
Reviewed by Kentaro Hara.
We don't want to record input type instantiation by Modernizr. Modernizr
creates input elements with these types, append it to document.body, and
render it with visibility:hidden. So, we record input types only when
they are attached without visibility:hidden.
No new tests. FeatureObserver is not testable by layout test.
- html/InputType.cpp:
(WebCore::InputType::create): Remove FeatureObserver::observe
callsites. They are moved to TextInputType::attach.
(WebCore::InputType::observeFeatureIfVisible):
Added. A helper for attach().
- html/InputType.h:
(InputType): Add observeFeatureIfVisible.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::create):
Remove a FeatureObserver::observe callsite.
(WebCore::ColorInputType::attach):
Calls FetureObserver through InputType::observeFeatureIfVisible.
- html/ColorInputType.h:
(ColorInputType): Declare attach.
- html/DateInputType.cpp: Ditto.
- html/DateInputType.h: Ditto.
- html/DateTimeInputType.cpp: Ditto.
- html/DateTimeInputType.h: Ditto.
- html/DateTimeLocalInputType.cpp: Ditto.
- html/DateTimeLocalInputType.h: Ditto.
- html/MonthInputType.cpp: Ditto.
- html/MonthInputType.h: Ditto.
- html/RangeInputType.cpp: Ditt
- html/RangeInputType.h: Ditto.
- html/TimeInputType.cpp: Ditto.
- html/TimeInputType.h: Ditto.
- html/WeekInputType.cpp: Ditto.
- html/WeekInputType.h: Ditto.
- html/TextFieldInputType.h:
(TextFieldInputType):
Make attach protected in order that sub classes can call it.
- html/EmailInputType.cpp:
(WebCore::EmailInputType::create):
Remove a FeatureObserver::observe callsite.
(WebCore::EmailInputType::attach): Calls FetureObserver through
InputType::observeFeatureIfVisible after TextFieldInptuType::attach.
- html/EmailInputType.h:
(EmailInputType):Declare attach.
- html/NumberInputType.cpp: Ditto.
- html/NumberInputType.h: Ditto.
- html/SearchInputType.cpp: Ditto.
- html/SearchInputType.h: Ditto.
- html/TelephoneInputType.cpp: Ditto.
- html/TelephoneInputType.h: Ditto.
- html/URLInputType.cpp: Ditto.
- html/URLInputType.h: Ditto.
- html/TextInputType.cpp:
(WebCore::TextInputType::attach):
Move the code for type fallback from InputType::create.
- html/TextInputType.h:
(TextInputType): Declare attach.
- 1:41 AM Changeset in webkit [141085] by
-
- 2 edits in trunk/Source/WebCore
[Qt][WK1] Reflect recursion limit and loop checks also for list conversions.
https://bugs.webkit.org/show_bug.cgi?id=107950
Reviewed by Allan Sandfeld Jensen.
No new tests, bugfix, no behavioral change.
Make conversions from Javascript values to QLists take the maximum
recursion depth into consideration and check for objects that were
already visited. Otherwise, the conversion may recurse until the
stack is full and then cause a segmentation fault.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertToList):
(JSC::Bindings::convertValueToQVariant):
- 1:37 AM Changeset in webkit [141084] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Added failure/flaky crash expectations for two layout tests.
- platform/gtk/fast/js/regress: Added.
- platform/gtk/fast/js/regress/integer-modulo-expected.txt: Added the baseline after r141031.
- 1:35 AM Changeset in webkit [141083] by
-
- 4 edits in trunk/Source/WebCore
Clean up interface to ElementShadow
https://bugs.webkit.org/show_bug.cgi?id=108158
Reviewed by Hajime Morita.
Lots of general clean up to ElementShadow removing unused headers,
adding a create() method that returns a PassOwnPtr, adding missing const,
and moving short inline methods into the class definition so it's easier
to understand what methods do what.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::ensureShadow):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
- dom/ElementShadow.h:
(WebCore::ElementShadow::create):
(ElementShadow):
(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::youngestShadowRoot):
(WebCore::ElementShadow::oldestShadowRoot):
(WebCore::ElementShadow::distributor):
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::containingShadow):
- 1:30 AM Changeset in webkit [141082] by
-
- 10 edits2 deletes in trunk/Tools
[chromium] delete DRTTestRunner
https://bugs.webkit.org/show_bug.cgi?id=108082
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
- DumpRenderTree/chromium/DRTTestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::testFinished):
(WebTestRunner::WebTestDelegate::testTimedOut):
(WebTestRunner::WebTestDelegate::isBeingDebugged):
(WebTestRunner::WebTestDelegate::layoutTestTimeout):
(WebTestRunner::WebTestDelegate::closeRemainingWindows):
(WebTestRunner::WebTestDelegate::navigationEntryCount):
(WebTestRunner::WebTestDelegate::windowCount):
(WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
(WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
(WebTestRunner::WebTestDelegate::goToOffset):
(WebTestRunner::WebTestDelegate::reload):
(WebTestRunner::WebTestDelegate::loadURLForFrame):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
(WebTestRunner):
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::shouldInterceptPostMessage):
(WebTestRunner::TestRunner::waitUntilDone):
(WebTestRunner::TestRunner::notifyDone):
(WebTestRunner::TestRunner::completeNotifyDone):
(WorkItemBackForward):
(WebTestRunner::WorkItemBackForward::WorkItemBackForward):
(WebTestRunner::WorkItemBackForward::run):
(WebTestRunner::TestRunner::queueBackNavigation):
(WebTestRunner::TestRunner::queueForwardNavigation):
(WorkItemReload):
(WebTestRunner::WorkItemReload::run):
(WebTestRunner::TestRunner::queueReload):
(WorkItemLoadingScript):
(WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
(WebTestRunner::WorkItemLoadingScript::run):
(WorkItemNonLoadingScript):
(WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
(WebTestRunner::WorkItemNonLoadingScript::run):
(WebTestRunner::TestRunner::queueLoadingScript):
(WebTestRunner::TestRunner::queueNonLoadingScript):
(WorkItemLoad):
(WebTestRunner::WorkItemLoad::WorkItemLoad):
(WebTestRunner::WorkItemLoad::run):
(WebTestRunner::TestRunner::queueLoad):
(WorkItemLoadHTMLString):
(WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WebTestRunner::WorkItemLoadHTMLString::run):
(WebTestRunner::TestRunner::queueLoadHTMLString):
(WebTestRunner::TestRunner::locationChangeDone):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
(WebTestRunner::TestRunner::setCustomPolicyDelegate):
(WebTestRunner::TestRunner::waitForPolicyDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
(WorkItem):
(WebTestRunner::TestRunner::WorkItem::~WorkItem):
(WorkQueue):
(WebTestRunner::TestRunner::WorkQueue::WorkQueue):
(WebTestRunner::TestRunner::WorkQueue::setFrozen):
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(WebTestRunner::TestRunner::WorkQueue::taskList):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::runFileTest):
(TestShell::loadURL):
(TestShell::createNewWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::testRunner):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::testFinished):
(WebViewHost::testTimedOut):
(WebViewHost::isBeingDebugged):
(WebViewHost::layoutTestTimeout):
(WebViewHost::closeRemainingWindows):
(WebViewHost::navigationEntryCount):
(WebViewHost::windowCount):
(WebViewHost::setCustomPolicyDelegate):
(WebViewHost::waitForPolicyDelegate):
(WebViewHost::goToOffset):
(WebViewHost::reload):
(WebViewHost::loadURLForFrame):
(WebViewHost::shutdown):
(WebViewHost::testRunner):
- DumpRenderTree/chromium/WebViewHost.h:
(WebTestRunner):
(WebViewHost):
- 1:21 AM Changeset in webkit [141081] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
Unreviewed. Gardening.
- tests/WebFrameTest.cpp:
- 1:16 AM Changeset in webkit [141080] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r141064.
http://trac.webkit.org/changeset/141064
https://bugs.webkit.org/show_bug.cgi?id=108166
[Chromium] WebFrameTest.DivScrollIntoEditableTest is failing
on WinXP. (Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
- tests/WebFrameTest.cpp:
- tests/data/get_scale_for_zoom_into_editable_test.html:
- 12:58 AM Changeset in webkit [141079] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix after r141024.
Adding new files to the build.
- GNUmakefile.am:
- GNUmakefile.list.am:
- 12:55 AM Changeset in webkit [141078] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Fix unused parameter build warning
https://bugs.webkit.org/show_bug.cgi?id=108156
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-01-29
Reviewed by Kentaro Hara.
Comment out the unused parameters to fix the build warnings.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PluginProxy.h:
- 12:51 AM Changeset in webkit [141077] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking icon-0colors.html as crashing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 12:39 AM Changeset in webkit [141076] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 140928
[chromium] add missing plumbing for Notification.requestPermission
https://bugs.webkit.org/show_bug.cgi?id=108012
Reviewed by Adam Barth.
Source/WebKit/chromium:
- src/NotificationPresenterImpl.cpp:
(WebKit):
(WebKit::VoidCallbackClient::VoidCallbackClient):
(NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
(WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
(WebKit::NotificationPresenterImpl::requestPermission):
- src/NotificationPresenterImpl.h:
(NotificationPresenterImpl):
LayoutTests:
- fast/notifications/notifications-constructor-request-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-request-permission.html: Added.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12086041
- 12:33 AM Changeset in webkit [141075] by
-
- 3 edits in trunk/Source/WebCore
Store ShadowRootType inside the bitfield
https://bugs.webkit.org/show_bug.cgi?id=108147
Reviewed by Dimitri Glazkov.
We can simplify the interface to ShadowRoot by storing the enum value of
ShadowRootType inside the bitfield like we do in the rest of WebCore.
No new tests, just refactoring.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::type):
(ShadowRoot):
- 12:31 AM Changeset in webkit [141074] by
-
- 2 edits1 delete in branches/chromium/1364
Merge 139616
Web Inspector: Audit Tool's False Positive on Set-Cookie header
https://bugs.webkit.org/show_bug.cgi?id=106794
Reviewed by Pavel Feldman.
Source/WebCore:
Header value is now returned as undefined if there is no such header as it was before regression.
Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype._headerValue):
LayoutTests:
- http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
- http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
- http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
TBR=vsevik@chromium.org
BUG=169771
Review URL: https://codereview.chromium.org/12089042
- 12:30 AM Changeset in webkit [141073] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disabling WebFrameTest.DisambiguationPopup because it is failing.
Unreviewed. Gardening.
- tests/WebFrameTest.cpp:
- 12:25 AM Changeset in webkit [141072] by
-
- 1 edit4 copies in branches/chromium/1364
Merge 140927
Check notification permissions in the show() method
https://bugs.webkit.org/show_bug.cgi?id=108009
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/notifications/notifications-constructor-with-permission.html
fast/notifications/notifications-constructor-without-permission.html
- Modules/notifications/Notification.cpp:
(WebCore::Notification::show):
(WebCore::Notification::taskTimerFired):
LayoutTests:
- fast/notifications/notifications-constructor-with-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-with-permission.html: Added.
- fast/notifications/notifications-constructor-without-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-without-permission.html: Added.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12087048
- 12:18 AM Changeset in webkit [141071] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r141070): Broke debug build
https://bugs.webkit.org/show_bug.cgi?id=108159
Unreviewed build fix.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
- 12:01 AM Changeset in webkit [141070] by
-
- 7 edits in trunk/Source/WebCore
HTMLDocumentParser should hold the HTMLToken using an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=107762
Reviewed by Eric Seidel.
Using an OwnPtr will let us detach the HTMLToken from the
HTMLDocumentParser and send it to the BackgroundHTMLParser for further
processing.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/CompactHTMLToken.h:
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- 12:01 AM Changeset in webkit [141069] by
-
- 63 edits9 adds in trunk/Source/JavaScriptCore
DFG should not use a graph that is a vector, Nodes shouldn't move after allocation, and we should always refer to nodes by Node*
https://bugs.webkit.org/show_bug.cgi?id=106868
Reviewed by Oliver Hunt.
This adds a pool allocator for Nodes, and uses that instead of a Vector. Changes all
uses of Node& and NodeIndex to be simply Node*. Nodes no longer have an index except
for debugging (Node::index(), which is not guaranteed to be O(1)).
1% speed-up on SunSpider, presumably because this improves compile times.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/DataFormat.h:
(JSC::dataFormatToString):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::booleanResult):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
(JSC::DFG::AbstractState::dump):
- dfg/DFGAbstractState.h:
(DFG):
(JSC::DFG::AbstractState::forNode):
(AbstractState):
(JSC::DFG::AbstractState::speculateInt32Unary):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):
(JSC::DFG::AbstractState::trySetConstant):
- dfg/DFGAbstractValue.h:
(AbstractValue):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::initialize):
- dfg/DFGAllocator.h: Added.
(DFG):
(Allocator):
(JSC::DFG::Allocator::Region::size):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::Allocator::Region::regionFor):
(Region):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::originalArrayStructure):
(JSC::DFG::ArrayMode::alreadyChecked):
- dfg/DFGArrayMode.h:
(ArrayMode):
- dfg/DFGArrayifySlowPathGenerator.h:
(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::node):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):
(BasicBlock):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setPair):
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::getCallee):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::isInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfJSConstant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::constantUndefined):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::constantNaN):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::ConstantRecord::ConstantRecord):
(ConstantRecord):
(JSC::DFG::ByteCodeParser::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::setIntrinsicResult):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::dump):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::recordNewTarget):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::constantCSE):
(JSC::DFG::CSEPhase::weakConstantCSE):
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkExecutableElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performSubstitution):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):
- dfg/DFGCommon.cpp: Added.
(DFG):
(JSC::DFG::NodePointerTraits::dump):
- dfg/DFGCommon.h:
(DFG):
(JSC::DFG::NodePointerTraits::defaultValue):
(NodePointerTraits):
(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::shouldDumpGraphAtEachPhase):
(JSC::DFG::validationEnabled):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::createDumpList):
(JSC::DFG::Disassembler::dumpDisassembly):
- dfg/DFGDisassembler.h:
(JSC::DFG::Disassembler::setForNode):
(Disassembler):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGEdge.cpp: Added.
(DFG):
(JSC::DFG::Edge::dump):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::node):
(JSC::DFG::Edge::operator*):
(JSC::DFG::Edge::operator->):
(Edge):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKind):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::isSet):
(JSC::DFG::Edge::shift):
(JSC::DFG::Edge::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(FixupPhase):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::GenerationInfo):
(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(GenerationInfo):
(JSC::DFG::GenerationInfo::node):
(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(DFG):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::amountOfNodeWhiteSpace):
(JSC::DFG::Graph::printNodeWhiteSpace):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):
(JSC::DFG::Graph::predictArgumentTypes):
(JSC::DFG::Graph::collectGarbage):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetExitStates):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::changeChild):
(JSC::DFG::Graph::compareAndSwap):
(JSC::DFG::Graph::clearAndDerefChild):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::getJSConstantSpeculation):
(JSC::DFG::Graph::addSpeculationMode):
(JSC::DFG::Graph::valueAddSpeculationMode):
(JSC::DFG::Graph::arithAddSpeculationMode):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::mulShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isCellConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::isInternalFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::numSuccessors):
(JSC::DFG::Graph::successor):
(JSC::DFG::Graph::successorForCondition):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
(JSC::DFG::Graph::varArgNumChildren):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::varArgChild):
(JSC::DFG::Graph::child):
(JSC::DFG::Graph::voteNode):
(JSC::DFG::Graph::voteChildren):
(JSC::DFG::Graph::substitute):
(JSC::DFG::Graph::substituteGetLocal):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):
- dfg/DFGInsertionSet.h:
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::element):
(Insertion):
(JSC::DFG::InsertionSet::insert):
(InsertionSet):
- dfg/DFGJITCompiler.cpp:
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::setForNode):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGLongLivedState.cpp: Added.
(DFG):
(JSC::DFG::LongLivedState::LongLivedState):
(JSC::DFG::LongLivedState::~LongLivedState):
(JSC::DFG::LongLivedState::shrinkToFit):
- dfg/DFGLongLivedState.h: Added.
(DFG):
(LongLivedState):
- dfg/DFGMinifiedID.h:
(JSC::DFG::MinifiedID::MinifiedID):
(JSC::DFG::MinifiedID::node):
- dfg/DFGMinifiedNode.cpp:
(JSC::DFG::MinifiedNode::fromNode):
- dfg/DFGMinifiedNode.h:
(MinifiedNode):
- dfg/DFGNode.cpp: Added.
(DFG):
(JSC::DFG::Node::index):
(WTF):
(WTF::printInternal):
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateIntegerForArithmetic):
(JSC::DFG::Node::shouldSpeculateIntegerExpectingDefined):
(JSC::DFG::Node::shouldSpeculateDoubleForArithmetic):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::dumpChildren):
(WTF):
- dfg/DFGNodeAllocator.h: Added.
(DFG):
(operator new ):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(OSRExit):
(SpeculationFailureDebugInfo):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPhase.cpp:
(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
- dfg/DFGPhase.h:
(Phase):
(JSC::DFG::runAndLog):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::setPrediction):
(JSC::DFG::PredictionPropagationPhase::mergePrediction):
(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::useIfHasResult):
(ScoreBoard):
- dfg/DFGSilentRegisterSavePlan.h:
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::node):
(SilentRegisterSavePlan):
- dfg/DFGSlowPathGenerator.h:
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(SlowPathGenerator):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::noticeOSRBirth):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstantAsInt32):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImm64):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
(JSC::DFG::SpeculativeJIT::setNodeForOperand):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::node):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::node):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::node):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::use):
(JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::node):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::node):
(JSC::DFG::SpeculateIntegerOperand::gpr):
(JSC::DFG::SpeculateIntegerOperand::use):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateStrictInt32Operand::node):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::use):
(SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::node):
(JSC::DFG::SpeculateDoubleOperand::fpr):
(JSC::DFG::SpeculateDoubleOperand::use):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::node):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
(SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::node):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):
(SpeculateBooleanOperand):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.h:
(StructureAbstractValue):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- dfg/DFGValidate.cpp:
(DFG):
(Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::reportValidationContext):
- dfg/DFGValidate.h:
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::ValueSource):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- runtime/FunctionExecutableDump.cpp: Added.
(JSC):
(JSC::FunctionExecutableDump::dump):
- runtime/FunctionExecutableDump.h: Added.
(JSC):
(FunctionExecutableDump):
(JSC::FunctionExecutableDump::FunctionExecutableDump):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSC):
(DFG):
(JSGlobalData):
- runtime/Options.h:
(JSC):
Jan 28, 2013:
- 11:57 PM Changeset in webkit [141068] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Build fix
https://bugs.webkit.org/show_bug.cgi?id=108142
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-28
Reviewed by Gyuyoung Kim.
Build fix. Though StorageManager was added to WK2 in r141024,
it is not added to Target.pri for qt port.
- Target.pri:
- 11:48 PM Changeset in webkit [141067] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Refactor code related to debug border and repaint count.
https://bugs.webkit.org/show_bug.cgi?id=105787
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-28
Reviewed by Noam Rosenthal.
It is a follow-up patch not to change layout test results.
The previous patch sets GraphicsLayer::m_usingTiledLayer to true when using a
backing store. When the variable is true, dumpLayer() adds (usingTiledLayer 1),
but most of ports don't set m_usingTiledLayer to true. So we don't use
m_usingTiledLayer to match the test results of other ports.
After this patch, Texture Mapper draws debug visuals for a tiled backing
with different color from safari.
No new tests. Debug feature, not covered in tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCountIfNeeded):
- 11:47 PM Changeset in webkit [141066] by
-
- 23 edits in trunk/Source/WebCore
Handle createShadowSubtree inside of ensureUserAgentShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=108116
Reviewed by Dimitri Glazkov.
Instead of making everyone create the UserAgentShadowRoot manually all
over, centralize it in ensureUserAgentShadowRoot() and add a notification
Element::didAddUserAgentShadowRoot that lets elements fill in the subtree.
This lets us get rid of lots of code duplication.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::ensureUserAgentShadowRoot):
- dom/Element.h:
(WebCore::Element::didAddUserAgentShadowRoot):
(Element):
- html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::create):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
- html/HTMLDetailsElement.h:
(HTMLDetailsElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::create):
(WebCore::HTMLInputElement::didAddUserAgentShadowRoot):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::willAddAuthorShadowRoot):
(WebCore::HTMLMediaElement::createMediaControls):
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):
- html/HTMLMeterElement.h:
(HTMLMeterElement):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::create):
(WebCore::HTMLProgressElement::didAddUserAgentShadowRoot):
- html/HTMLProgressElement.h:
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::didAddUserAgentShadowRoot):
- html/HTMLSummaryElement.h:
(HTMLSummaryElement):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::create):
(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot):
- html/HTMLTextAreaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlOverlayPlayButtonElement::create):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlPanelVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlFullscreenPlayButtonElement::create):
(WebCore::MediaControlFullscreenFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenTimelineElement::create):
(WebCore::MediaControlAudioMuteButtonElement::create):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::create):
- svg/SVGTRefElement.h:
(SVGTRefElement):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::create):
- svg/SVGUseElement.h:
(SVGUseElement):
- 11:44 PM Changeset in webkit [141065] by
-
- 13 edits in trunk/Source/WebKit2
Coordinated Graphics: Refactor code related to debug border and repaint count.
https://bugs.webkit.org/show_bug.cgi?id=107910
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-28
Reviewed by Noam Rosenthal.
There are two big changes:
- CoordinatedGraphicsLayer sends debugging visuals to UI Process.
- When updating a backing store, increment a repaint count.
In addition, we don't use QT_WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS
environment. EFL, GTK and QT will use WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS
after http://webkit.org/b/107198.
- Shared/CoordinatedGraphics/CoordinatedLayerInfo.h:
(WebKit::CoordinatedLayerInfo::CoordinatedLayerInfo):
(CoordinatedLayerInfo):
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::removeAllTiles):
(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintTilesToTextureMapper):
(WebKit::CoordinatedBackingStore::adjustedTransformForRect):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit):
(WebKit::CoordinatedBackingStore::drawBorder):
Override TextureMapperPlatformLayer::drawBorder() to draw the border
for each tile.
(WebKit::CoordinatedBackingStore::drawRepaintCounter):
(WebKit::CoordinatedBackingStore::commitTileOperations):
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(WebKit::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile):
(CoordinatedBackingStoreTile):
(CoordinatedBackingStore):
(WebKit::CoordinatedBackingStore::rect):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::setLayerRepaintCount):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setLayerRepaintCount):
(WebKit):
(WebKit::LayerTreeRenderer::setLayerState):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setShowDebugBorder):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::setDebugBorder):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::setLayerRepaintCount):
(WebKit):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 11:40 PM Changeset in webkit [141064] by
-
- 3 edits in trunk/Source/WebKit/chromium
Re-enable WebFrameTest.DivScrollIntoEditableTest
https://bugs.webkit.org/show_bug.cgi?id=98558
Reviewed by Adam Barth.
- tests/WebFrameTest.cpp: Fixed several issues (onload script, the maximum scale factor, etc.) of WebFrameTest.DivScrollIntoEditableTest and enable it.
- tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
- 11:31 PM Changeset in webkit [141063] by
-
- 15 edits2 deletes in trunk
HTMLOutputElement::htmlFor should be readonly
https://bugs.webkit.org/show_bug.cgi?id=101898
Reviewed by Kentaro Hara.
Source/WebCore:
The spec says htmlFor should be readonly, but WebKit implements it as no-readonly.
Spec: http://dev.w3.org/html5/spec-preview/the-output-element.html
No new tests. Modified existing test fast/dom/HTMLOutputElement/dom-settable-token-list.html
to work as expected.
- GNUmakefile.list.am: Removed JSHTMLOutputElementCustom.cpp
- Target.pri: Ditto
- UseJSC.cmake: Ditto
- UseV8.cmake: Removed V8HTMLOutputElementCustom.cpp
- WebCore.gypi: Removed V8HTMLOutputElementCustom.cpp
- WebCore.vcproj/WebCore.vcproj: Removed JSHTMLOutputElementCustom.cpp
- WebCore.vcxproj/WebCore.vcxproj: Ditto
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
- WebCore.xcodeproj/project.pbxproj: Ditto
- bindings/js/JSBindingsAllInOne.cpp: Ditto
- bindings/js/JSHTMLOutputElementCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLOutputElementCustom.cpp: Removed.
- html/HTMLOutputElement.idl: Made htmlFor attribute readonly.
LayoutTests:
The spec says htmlFor should be readonly, but WebKit implements it as no-readonly.
Spec: http://dev.w3.org/html5/spec-preview/the-output-element.html
Modified tests according to new behavior.
- fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
- fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js: Test for attribute htmlFor is readonly.
- 11:29 PM Changeset in webkit [141062] by
-
- 6 edits1 add in trunk/Source
Fix disambiguation popup for new-style page scale
https://bugs.webkit.org/show_bug.cgi?id=107391
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
This patch corrects various coordinate conversion for disambiguation
popup for the new-style page scale mode.
Source/WebCore:
New unit test: WebFrameTest.DisambiguationPopupPageScale
- page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
- page/TouchDisambiguation.h:
(WebCore):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::handleInputEvent):
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_page_scale.html: Added.
- 11:14 PM Changeset in webkit [141061] by
-
- 2 edits in trunk/Source/WebKit2
Remove support from ArgumentEncoder for deprecated encode functions
https://bugs.webkit.org/show_bug.cgi?id=108155
Reviewed by Dan Bernstein.
- Platform/CoreIPC/ArgumentEncoder.h:
(CoreIPC::ArgumentEncoder::encode):
- 11:05 PM Changeset in webkit [141060] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Reverting change to chromium/TestExpectation in r141056.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 10:59 PM Changeset in webkit [141059] by
-
- 2 edits in trunk/Source/JavaScriptCore
Collapse testing for a list of PLATFORM() into OS() and USE() tests
https://bugs.webkit.org/show_bug.cgi?id=108018
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-28
Reviewed by Eric Seidel.
No functional change as "OS(DARWIN) && USE(CF)" equals to the
following platforms: MAC, WX, QT and CHROMIUM. CHROMIUM
is not using JavaScriptCore.
- runtime/DatePrototype.cpp:
(JSC):
- 10:55 PM Changeset in webkit [141058] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r141049.
http://trac.webkit.org/changeset/141049
https://bugs.webkit.org/show_bug.cgi?id=108151
Caused some indexed tests to crash. (Requested by keishi on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28
Source/WebCore:
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onUpgradeNeeded):
(WebCore::IDBCallbacks::onSuccess):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
Source/WebKit/chromium:
- public/WebIDBCallbacks.h:
(WebKit):
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp:
(WebCore::MockIDBCallbacks::onSuccess):
- tests/IDBDatabaseBackendTest.cpp:
- 10:52 PM Changeset in webkit [141057] by
-
- 4 edits in trunk
Layout Test http/tests/workers/terminate-during-sync-operation.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=79013
Reviewed by David Levin.
Source/WebCore:
We need to use an isolated copy because we're going to use it on a
different thread.
- Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::AbstractDatabase):
LayoutTests:
This test shouldn't be flaky anymore.
- platform/chromium/TestExpectations:
- 10:50 PM Changeset in webkit [141056] by
-
- 5 edits6 copies11 adds in trunk/LayoutTests
[Chromium] Rebaselining after 141039.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
- platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Added.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Added.
- platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/compositing/overflow/resize-painting-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt: Copied from LayoutTests/platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt: Copied from LayoutTests/platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt: Copied from LayoutTests/platform/chromium/compositing/overflow/resize-painting-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt: Copied from LayoutTests/platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt: Copied from LayoutTests/platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt: Copied from LayoutTests/platform/chromium/compositing/overflow/resize-painting-expected.txt.
- 10:35 PM Changeset in webkit [141055] by
-
- 3 edits in trunk/Source/WebKit/chromium
Expose isRadioButton and isCheckbox API in chromium-webkit glue layer.
https://bugs.webkit.org/show_bug.cgi?id=108031
Patch by Raman Kumar <ramankk@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
In chromium, to know if an InputElement is radiobutton or a checkbox,
we are checking for formControlType (a string comparision), which is
very slow. Exposing these API to chromium will make them faster.
- public/WebInputElement.h:
(WebInputElement):
- src/WebInputElement.cpp:
(WebKit::WebInputElement::isRadioButton):
(WebKit):
(WebKit::WebInputElement::isCheckbox):
- 10:22 PM Changeset in webkit [141054] by
-
- 3 edits2 adds in trunk
[Shadow] Gesture event is not fired in ShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=107797
Reviewed by Dimitri Glazkov.
Source/WebCore:
Gesture event (e.g. touchstart) is not fired in ShadowDOM.
We have to run event retargetting algorithm to retarget touchTarget, however it is not implemented yet (Bug 107800).
Until it's implemented, we use the shadow ancestor node of touchTarget in Document treescope as touchTarget
for backward compatibility. If a touch event is fired in nested ShadowDOM, touchTarget will be always element in
document tree, so an event listener in ShadowDOM will get a wrong touchTarget. However we prioritized
the correctness of document tree.
Test: fast/dom/shadow/touch-event.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Allows us to take elements in ShadowDOM.
LayoutTests:
- fast/dom/shadow/touch-event-expected.txt: Added.
- fast/dom/shadow/touch-event.html: Added.
- 10:19 PM Changeset in webkit [141053] by
-
- 15 edits in trunk/Source
Make page scale shrink FrameView in applyPageScaleInCompositor mode
https://bugs.webkit.org/show_bug.cgi?id=107424
Reviewed by Levi Weintraub.
If applyPageScaleFactorInCompositor is enabled (Chromium-only setting),
instead of the entire document expanding as the user pinch zooms, the
viewport shrinks instead. This patch applies the pageScaleFactor to
visibleContentRect to get this behavior, and simplifies Chromium's
resize logic to stop hiding the true viewport size from WebCore.
I verified that the scaling makes sense for all the callers of
visibleContentRect. The exceptions are clip-layer size,
layout size in non-fixed-layout mode, and text autosizing, which need
the original unscaled size. Therefore I added a new method
unscaledVisibleContentSize() to ScrollView/FrameView.
This patch also modifies Page::setPageScaleFactor to perform no
invalidates or layout when applyPageScaleFactorInCompositor is true,
and also writes pageScaleFactor into HistoryItems instead of using
frameScaleFactor.
Since all behavior changes are tied to applyPageScaleFactorInCompositor,
this patch should be a no-op for non-Chromium ports.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::adjustEventPointForPinchZoom):
Source/WebCore:
New unit tests in WebFrameTest.cpp.
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
Use pageScaleFactor here because frameScaleFactor always returns 1
with our setting.
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentScaleFactor):
(WebCore):
- page/FrameView.h:
(FrameView):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor): Make setPageScaleFactor stop
invalidating/layouting as this is handled by our compositor.
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSize): This new method
just returns the original visible rect without pageScaleFactor being
applied.
(WebCore):
(WebCore::ScrollView::visibleContentRect): This now is divided by
pageScaleFactor if our setting is active.
(WebCore::ScrollView::layoutSize):
- platform/ScrollView.h:
(WebCore::ScrollView::visibleContentScaleFactor): Returns
pageScaleFactor if the visible rect is scaled, 1 normally.
(ScrollView):
(WebCore::ScrollView::layoutWidth):
(WebCore::ScrollView::layoutHeight):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Clip layer
should use unscaled size, because it's above the root scroll layer
on the layer tree (i.e. page scale isn't applied on it).
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree): Text autosizer should use
unscaled size, because it cares about physical screen size.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scaledSize): Returns the post page-scale size
similar to what visibleContentRect() now returns, except that it may
be at a different scale than the current one.
(WebKit::WebViewImpl::size): Back to returning density-independent
size without any tricks, not the "layoutSize()" fake viewport.
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::handleInputEvent): No need to apply
implTransform anymore as WebKit knows the true scroll offset; just
divide event coords by pageScaleFactor.
(WebKit::WebViewImpl::clampOffsetAtScale): Make this method support
applyPageScaleFactorInCompositor. This is used to pre-clamp scroll
offsets at a given viewport size.
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset): Make
this method support applyPageScaleFactorInCompositor (don't scale
scroll offsets as they are now scale-independent).
(WebKit::WebViewImpl::setPageScaleFactor): Make this method always use
clampOffsetAtScale instead of bypassing it, since it's now supported.
Also notify the compositor to update its state.
(WebKit::WebViewImpl::contentsSize): Convenience method, removed
difference between scaled and unscaled.
(WebKit::WebViewImpl::layoutSize): This method returned the "fake"
size we used to give FrameView. Now no longer used for much.
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::didChangeContentsSize): Remove unnecessary
resize() now that we can give the true size to FrameView.
(WebKit::WebViewImpl::updateLayerTreeViewport): Use layoutSize()
directly now that FrameView no longer uses it.
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- 10:05 PM Changeset in webkit [141052] by
-
- 2 edits in trunk/Source/WebKit2
Disable default use of the Plug-in XPCService until we can
figure out how to deal with the 32-bit one.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
- 9:58 PM Changeset in webkit [141051] by
-
- 27 edits2 adds in trunk/Source/WebKit2
Plug-ins should initialize their sandbox at creation time
https://bugs.webkit.org/show_bug.cgi?id=108098
Reviewed by Anders Carlsson.
Add the ability to add string key/value pairs to process creation parameters
to allow the plugin process to get passed the plugin path which in turn allows
the plugin to initialize its sandbox at the correct time.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(NetworkServiceInitializer):
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::getExtraData):
(PluginProcessMainDelegate):
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit):
(PluginServiceInitializerDelegate):
(WebKit::PluginServiceInitializerDelegate::PluginServiceInitializerDelegate):
(WebKit::PluginServiceInitializerDelegate::getExtraData):
(PluginServiceInitializer):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::initializePluginProcess):
(WebKit::PluginProcess::initializeProcessName):
(WebKit::PluginProcess::initializeSandbox):
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializePluginProcess):
(WebKit::PluginProcess::platformInitializeProcess):
(WebKit::PluginProcess::initializeProcessName):
(WebKit::PluginProcess::initializeSandbox):
- Shared/ChildProcess.h:
(ChildProcessInitializationParameters):
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h:
(ChildProcessMainDelegate):
(WebKit::ChildProcessMain):
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm:
(WebKit::ChildProcessMainDelegate::getExtraData):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:
(WebKit::XPCServiceEventHandler):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h:
(WebKit::XPCServiceEventHandler):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h: Added.
(XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm: Added.
(WebKit::XPCServiceInitializerDelegate::~XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializerDelegate::getConnectionIdentifier):
(WebKit::XPCServiceInitializerDelegate::getClientIdentifier):
(WebKit::XPCServiceInitializerDelegate::getClientProcessName):
(WebKit::XPCServiceInitializerDelegate::getExtraData):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
- UIProcess/Launcher/ProcessLauncher.h:
(LaunchOptions):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::connectToReExecService):
(WebKit::createService):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
- 9:48 PM Changeset in webkit [141050] by
-
- 67 edits4 adds in trunk/Source
Static size inference for JavaScript objects
https://bugs.webkit.org/show_bug.cgi?id=108093
Reviewed by Phil Pizlo.
- API/JSObjectRef.cpp:
- JavaScriptCore.order:
- JavaScriptCore.xcodeproj/project.pbxproj: Pay the tax man.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode): op_new_object and op_create_this now
have an extra inferredInlineCapacity argument. This is the statically
inferred inline capacity, just from analyzing source text. op_new_object
also gets a pointer to an allocation profile. (For op_create_this, the
profile is in the construtor function.)
(JSC::CodeBlock::CodeBlock): Link op_new_object.
(JSC::CodeBlock::stronglyVisitStrongReferences): Mark our profiles.
- bytecode/CodeBlock.h:
(CodeBlock): Removed some dead code. Added object allocation profiles.
- bytecode/Instruction.h:
(JSC): New union type, since an instruction operand may point to an
object allocation profile now.
- bytecode/ObjectAllocationProfile.h: Added.
(JSC):
(ObjectAllocationProfile):
(JSC::ObjectAllocationProfile::offsetOfAllocator):
(JSC::ObjectAllocationProfile::offsetOfStructure):
(JSC::ObjectAllocationProfile::ObjectAllocationProfile):
(JSC::ObjectAllocationProfile::isNull):
(JSC::ObjectAllocationProfile::initialize):
(JSC::ObjectAllocationProfile::structure):
(JSC::ObjectAllocationProfile::inlineCapacity):
(JSC::ObjectAllocationProfile::clear):
(JSC::ObjectAllocationProfile::visitAggregate):
(JSC::ObjectAllocationProfile::possibleDefaultPropertyCount): New class
for tracking a prediction about object allocation: structure, inline
capacity, allocator to use.
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName): Updated instruction sizes.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC):
(JSC::UnlinkedCodeBlock::addObjectAllocationProfile):
(JSC::UnlinkedCodeBlock::numberOfObjectAllocationProfiles):
(UnlinkedCodeBlock): Unlinked support for allocation profiles.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate): Kill all remaining analyses at the
end of codegen, since this is our last opportunity.
(JSC::BytecodeGenerator::BytecodeGenerator): Added a static property
analyzer to bytecode generation. It tracks initializing assignments and
makes a guess about how many will happen.
(JSC::BytecodeGenerator::newObjectAllocationProfile):
(JSC):
(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitPutGetterSetter):
(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::emitGetByVal): Added hooks to the static property
analyzer, so it can observe allocations and stores.
(JSC::BytecodeGenerator::emitCreateThis): Factored this into a helper
function because it was a significant amount of logic, and I wanted to
add to it.
(JSC::BytecodeGenerator::emitNewObject):
(JSC::BytecodeGenerator::emitExpectedFunctionSnippet):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct): Added a hook to profiled opcodes
to track their stores, in case a store kills a profiled allocation. Since
profiled opcodes are basically the only interesting stores we do, this
is a convenient place to notice any store that might kill an allocation.
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator): As above.
- bytecompiler/StaticPropertyAnalysis.h: Added.
(JSC):
(StaticPropertyAnalysis):
(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::addPropertyIndex):
(JSC::StaticPropertyAnalysis::record):
(JSC::StaticPropertyAnalysis::propertyIndexCount):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis): Simple helper
class for tracking allocations and stores.
- bytecompiler/StaticPropertyAnalyzer.h: Added.
(StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::createThis):
(JSC::StaticPropertyAnalyzer::newObject):
(JSC::StaticPropertyAnalyzer::putById):
(JSC::StaticPropertyAnalyzer::mov):
(JSC::StaticPropertyAnalyzer::kill): Helper class for observing allocations
and stores and making an inline capacity guess. The heuristics here are
intentionally minimal because we don't want this one class to try to
re-create something like a DFG or a runtime analysis. If we discover that
we need those kinds of analyses, we should just replace this class with
something else.
This class tracks multiple registers that alias the same object -- that
happens a lot, when moving locals into temporary registers -- but it
doesn't track control flow or multiple objects that alias the same register.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute): Updated for rename.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): Updated for inline capacity and
allocation profile.
- dfg/DFGNode.h:
(JSC::DFG::Node::hasInlineCapacity):
(Node):
(JSC::DFG::Node::inlineCapacity):
(JSC::DFG::Node::hasFunction): Give the graph a good way to represent
inline capacity for an allocation.
- dfg/DFGNodeType.h:
(DFG): Updated for rename.
- dfg/DFGOperations.cpp: Updated for interface change.
- dfg/DFGOperations.h: We pass the inline capacity to the slow case as
an argument. This is the simplest way, since it's stored as a bytecode operand.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate): Updated for rename.
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID): Fixed a horrible off-by-one-half bug that only
appears when doing an inline cached load for property number 64 on a 32-bit
system. In JSVALUE32_64 land, "offsetRelativeToPatchedStorage" is the
offset of the 64bit JSValue -- but we'll actually issue two loads, one for
the payload at that offset, and one for the tag at that offset + 4. We need
to ensure that both loads have a compact representation, or we'll corrupt
the instruction stream.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Lots of refactoring to support
passing an allocator to our allocation function, and/or passing a Structure
as a register instead of an immediate.
- heap/MarkedAllocator.h:
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::offsetOfFreeListHead): Added an accessor to simplify
JIT code generation of allocation from an arbitrary allocator.
- jit/JIT.h:
(JSC):
- jit/JITInlines.h:
(JSC):
(JSC::JIT::emitAllocateJSObject):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this): Same refactoring as done for the DFG.
- jit/JITStubs.cpp:
(JSC::tryCacheGetByID): Fixed the same bug mentioned above.
(JSC::DEFINE_STUB_FUNCTION): Updated for interface changes.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Updated for interface changes.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm: Same refactoring as for the JITs.
- profiler/ProfilerBytecode.cpp:
- profiler/ProfilerBytecodes.cpp:
- profiler/ProfilerCompilation.cpp:
- profiler/ProfilerCompiledBytecode.cpp:
- profiler/ProfilerDatabase.cpp:
- profiler/ProfilerOSRExit.cpp:
- profiler/ProfilerOrigin.cpp:
- profiler/ProfilerProfiledBytecodes.cpp: Include ObjectConstructor.h
because that's where createEmptyObject() lives now.
- runtime/Executable.h:
(JSC::JSFunction::JSFunction): Updated for rename.
- runtime/JSCellInlines.h:
(JSC::allocateCell): Updated to match the allocator selection code in
the JIT, so it's clearer that both are correct.
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::createAllocationProfile):
(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::getConstructData):
- runtime/JSFunction.h:
(JSC::JSFunction::offsetOfScopeChain):
(JSC::JSFunction::offsetOfExecutable):
(JSC::JSFunction::offsetOfAllocationProfile):
(JSC::JSFunction::allocationProfile):
(JSFunction):
(JSC::JSFunction::tryGetAllocationProfile):
(JSC::JSFunction::addAllocationProfileWatchpoint): Changed inheritorID
data member to be an ObjectAllocationProfile, which includes a pointer
to the desired allocator. This simplifies JIT code, since we don't have
to compute the allocator on the fly. I verified by code inspection that
JSFunction is still only 64 bytes.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::dateStructure): No direct pointer to the empty
object structure anymore, because now clients need to specify how much
inline capacity they want.
- runtime/JSONObject.cpp:
- runtime/JSObject.h:
(JSC):
(JSFinalObject):
(JSC::JSFinalObject::defaultInlineCapacity):
(JSC::JSFinalObject::maxInlineCapacity):
(JSC::JSFinalObject::createStructure): A little refactoring to try to
clarify where some of these constants derive from.
(JSC::maxOffsetRelativeToPatchedStorage): Used for bug fix, above.
- runtime/JSProxy.cpp:
(JSC::JSProxy::setTarget): Ugly, but effective.
- runtime/LiteralParser.cpp:
- runtime/ObjectConstructor.cpp:
(JSC::constructObject):
(JSC::constructWithObjectConstructor):
(JSC::callObjectConstructor):
(JSC::objectConstructorCreate): Updated for interface changes.
- runtime/ObjectConstructor.h:
(JSC::constructEmptyObject): Clarified your options for how to allocate
an empty object, to emphasize what things can actually vary.
- runtime/PropertyOffset.h: These constants have moved because they're
really higher level concepts to do with the layout of objects and the
collector. PropertyOffset is just an abstract number line, independent
of those things.
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyObjectStructureForPrototype):
(JSC::PrototypeMap::clearEmptyObjectStructureForPrototype):
- runtime/PrototypeMap.h:
(PrototypeMap): The map key is now a pair of prototype and inline capacity,
since Structure encodes inline capacity.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTableForPinning):
- runtime/Structure.h:
(Structure):
(JSC::Structure::totalStorageSize):
(JSC::Structure::transitionCount):
(JSC::Structure::create): Fixed a nasty refactoring bug that only shows
up after enabling variable-sized inline capacities: we were passing our
type info where our inline capacity was expected. The compiler didn't
notice because both have type int :(.
../WebCore:
- ForwardingHeaders/runtime/ObjectConstructor.h: Added.
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/JSSQLResultSetRowListCustom.cpp: Include ObjectConstructor.h because
that's where createEmptyObject() is located now.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserialize): Updated for interface change.
- 9:40 PM Changeset in webkit [141049] by
-
- 13 edits in trunk/Source
IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
https://bugs.webkit.org/show_bug.cgi?id=103920
Reviewed by Dimitri Glazkov.
Source/WebCore:
Update IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded to
pass through a metadata parameter. While there, remove the unused
IDBTransactionBackendInterface parameter to onUpgradeNeeded.
As this is another step in the IDB refactor, I've simplified future cleanup
work by making the WebKit API code still use the old API. This
will make it possible to outright remove code on the chromium side rather
than another three-step checkin.
No new tests, as this is more refactoring.
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onUpgradeNeeded): new method signature.
(WebCore::IDBCallbacks::onSuccess): new method signature.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): use passed-in metadata.
(WebCore::IDBOpenDBRequest::onSuccess): use passed-in metadata.
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
Source/WebKit/chromium:
Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
while maintaining chromium compatibility by shimming in the old API
in the WebKit side. Future code will clean this up so that it is just a
pass-through as it was before.
- public/WebIDBCallbacks.h:
(WebKit):
(WebKit::WebIDBCallbacks::onSuccess): new method signature.
(WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
(WebKit):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
(WebKit):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp: new method signature.
(WebCore::MockIDBCallbacks::onSuccess):
- tests/IDBDatabaseBackendTest.cpp: new method signature.
- 9:23 PM Changeset in webkit [141048] by
-
- 2 edits in tags/Safari-537.28.2/Source/WebKit2
Merged r141027. <rdar://problem/13098777>
- 9:17 PM Changeset in webkit [141047] by
-
- 4 edits in tags/Safari-537.28.2/Source
Versioning.
- 9:14 PM Changeset in webkit [141046] by
-
- 1 copy in tags/Safari-537.28.2
New Tag.
- 9:11 PM Changeset in webkit [141045] by
-
- 6 edits in trunk
Add window occlusion criteria to determine page visibility on Mac
https://bugs.webkit.org/show_bug.cgi?id=107494
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-28
Reviewed by Simon Fraser.
Source/WebKit2:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible): Add window occlusion check.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]): Remove self from the all views vector.
(-[WKView addWindowObserversForWindow:]): Register observer for
NSWindowWillOrderOffScreenNotification.
(-[WKView removeWindowObservers]): Unregister observer for
NSWindowWillOrderOffScreenNotification.
(-[WKView viewWillMoveToWindow:]): Disable occlusion notifications.
(-[WKView viewDidMoveToWindow]): Enable occlusion notifications.
(-[WKView _windowWillOrderOffScreen:]): Disable occlusion notifications.
(-[WKView _windowDidOrderOnScreen:]): Enable occlusion notifications.
This notification ensures that occlusion notifications are registered
correctly even if the NSWindow object is assigned a window number after
the viewDidMoveToWindow notification has been received. This occurs
for instance during application launch.
(-[WKView _setIsWindowOccluded:]):
(-[WKView _enableWindowOcclusionNotifications]):
(-[WKView _disableWindowOcclusionNotifications]):
(windowBecameVisible):
(windowBecameOccluded):
(+[WKView _registerWindowOcclusionNotificationHandlers]):
(+[WKView _unregisterWindowOcclusionNotificationHandlers]):
(+[WKView _allViews]):
(-[WKView _isWindowOccluded]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add
self to the all views vector.
- UIProcess/API/mac/WKViewInternal.h:
WebKitLibraries:
Add enum constants to specify window occlusion notification type to
notification registration/unregistration methods. Add typedef for
window ID data passed to the window occlusion notification handler.
Add method to enable occlusion notifications for a particular window.
- WebKitSystemInterface.h: Add
WKOcclusionNotificationTypeWindowBecameVisible,
WKOcclusionNotificationTypeWindowBecameOccluded,
WKWindowID,
WKEnableWindowOcclusionNotifications().
- 8:47 PM Changeset in webkit [141044] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Rebaselining integer-modulo after r141031.
Unreviewed. Gardening.
- platform/chromium/fast/js/regress/integer-modulo-expected.txt: Added.
- 8:41 PM Changeset in webkit [141043] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Small animated zoom level adjustments are unnecessary
https://bugs.webkit.org/show_bug.cgi?id=108104
Patch by Andrew Lo <anlo@rim.com> on 2013-01-28
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Internal PR 285861.
If the difference between the target scale and current scale is
less than a given threshold, don't perform a zoom animation.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 8:38 PM Changeset in webkit [141042] by
-
- 3 edits in trunk/LayoutTests
fix multi-touch-inside-iframes Layout test
https://bugs.webkit.org/show_bug.cgi?id=108113
Patch by Min Qin <qinmin@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
The ordering of OnLoad() of the 2 child iframes is racy.
Fixed by assigning title from the parent frame.
- fast/events/touch/multi-touch-inside-iframes.html:
- fast/events/touch/resources/multi-touch-inside-iframes2.html:
- 8:37 PM Changeset in webkit [141041] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Reduce the region that is spellchecked on keystroke
https://bugs.webkit.org/show_bug.cgi?id=108115
Reviewed by Rob Buis.
PR288217
Instead of blindly checking text until endOfDocument, we should be honoring the boundaries of
the VisibleSelection that is passed into SpellingHandler. Though this results in the same behavior
on focus, this dramatically reduces the region that is rechecked when a key is hit.
Internally reviewed by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- WebKitSupport/SpellingHandler.h:
(SpellingHandler):
- 8:32 PM Changeset in webkit [141040] by
-
- 10 edits in trunk/Source
[TexMap] Enable debug borders and repaint counter via Settings.
https://bugs.webkit.org/show_bug.cgi?id=107198
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-28
Reviewed by Benjamin Poulain.
Source/WebKit/efl:
If WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1, set
showDebugBorders and showRepaintCounter in Settings to true.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit/gtk:
If WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1, set
showDebugBorders and showRepaintCounter in Settings to true.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
Source/WebKit/qt:
If WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1, set
showDebugBorders and showRepaintCounter in Settings to true.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
Source/WebKit2:
Currently, if the environment variable WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS
is set to 1, only CoordinatedBacking shows debug borders and repaint counter.
This patch makes the environment variable change Settings.
In addition, Qt uses WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS instead of
QT_WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS from now.
After Bug 105787, all backing stores and platform layers in TextureMapper can
show debug borders and repaint counter.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
- 8:16 PM Changeset in webkit [141039] by
-
- 13 edits1 copy1 add in trunk
position:fixed that doesn't render any content should not force compositing
https://bugs.webkit.org/show_bug.cgi?id=108112
Source/WebCore:
Reviewed by Beth Dakin.
It's not uncommon for pages to have position:fixed elements with no content.
When these are behind other elements, they can cause those other elements
to become composited, using lots of backing store memory.
Optimize for the case where the position:fixed element has no rendered
content and no children by not making it composited in that case.
Test: compositing/layer-creation/fixed-position-no-content.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasNonEmptyChildRenderers): Moved from RenderLayerBacking.cpp.
(WebCore::hasBoxDecorations): Ditto.
(WebCore::RenderLayer::hasBoxDecorationsOrBackground): Ditto.
(WebCore::RenderLayer::hasVisibleBoxDecorations): Check for visibility:visible, box decorations and
overflow controls.
(WebCore::RenderLayer::isVisuallyNonEmpty): Returns true if this layer has some visible
representation.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Need to call updateDescendantDependentFlags()
to ensure that the visibility flags are up to date.
(WebCore::RenderLayerBacking::updateDrawsContent): Call RenderLayer::hasBoxDecorationsOrBackground() now.
(WebCore::RenderLayerBacking::paintsBoxDecorations): Call RenderLayer::hasVisibleBoxDecorations() now.
(WebCore::RenderLayerBacking::paintsChildren): Call RenderLayer::hasNonEmptyChildRenderers().
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Whitespace.
(WebCore::RenderLayerBacking::containsPaintedContent): Call RenderLayer::hasBoxDecorationsOrBackground().
(WebCore::RenderLayerBacking::isDirectlyCompositedImage): Ditto.
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): If the layer has no content to paint,
or visible descendant layers, then don't make it composited.
LayoutTests:
Reviewed by Beth Dakin.
Change tests to put a background color on position:fixed elements that need to be composited.
New test with an empty fixed position element.
- compositing/layer-creation/fixed-position-change-out-of-view-in-view.html:
- compositing/layer-creation/fixed-position-no-content-expected.txt: Added.
- compositing/layer-creation/fixed-position-no-content.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view.html.
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
- compositing/layer-creation/fixed-position-out-of-view-scaled.html:
- compositing/layer-creation/fixed-position-out-of-view.html:
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html:
- platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html:
- 7:51 PM Changeset in webkit [141038] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Skipping mathml tests because MATHML was disasbled.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 7:47 PM Changeset in webkit [141037] by
-
- 5 edits in trunk/Source/WebKit2
Move Mach port handling from WorkQueue to Connection
https://bugs.webkit.org/show_bug.cgi?id=108140
Reviewed by Sam Weinig.
Instead of having WorkQueue know about Mach port sources, just fold that
functionality directly into Connection. This lets us get rid of the generic source
handling from WorkQueue.
- Platform/CoreIPC/Connection.h:
(Connection):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::createDataAvailableSource):
(CoreIPC):
(CoreIPC::Connection::open):
(CoreIPC::Connection::initializeDeadNameSource):
- Platform/WorkQueue.h:
(WorkQueue::dispatchQueue):
(WorkQueue):
- Platform/mac/WorkQueueMac.cpp:
(WorkQueue::platformInvalidate):
- 7:42 PM Changeset in webkit [141036] by
-
- 3 edits in trunk/Source/WebCore
Avoid doing work at 60fps for tiled layers when not necessary
https://bugs.webkit.org/show_bug.cgi?id=108135
Reviewed by Dean Jackson.
When there were any tiled layers on the page, we would run a CVDisplayLink
to cause GraphicsLayerCA to flush, in order to update tiled layer visible rects.
This is overkill; we should only do this if the tiled layer is affected by
an accelerated animation.
Fix by tracking whether an ancestor has a running animation when committing
GraphicsLayerCAs.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::flushCompositingState): Start with an empty CommitState.
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Push CommitState for
each layer, which tracks whether an ancestor has a running transform animation.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): updateLayerAnimations() renamed.
(WebCore::GraphicsLayerCA::updateAnimations): Renamed from updateLayerAnimations().
(WebCore::GraphicsLayerCA::isRunningTransformAnimation): Look in the map of running
animations for one affecting transform. This list is normally small (one item).
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::CommitState::CommitState):
- 7:42 PM Changeset in webkit [141035] by
-
- 2 edits in trunk/Source/WebCore
compositing/reflections/become-simple-composited-reflection.html pixel result shows bug
https://bugs.webkit.org/show_bug.cgi?id=107174
Reviewed by Dean Jackson.
When we have a content layer for solid color, we need to update reflection
clones when that color changes.
Tested by the pixel test for compositing/reflections/become-simple-composited-reflection.html.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsColorLayer):
- 6:37 PM Changeset in webkit [141034] by
-
- 163 edits in trunk/Source
[v8] Security feature: JavaScript Bindings hardening
https://bugs.webkit.org/show_bug.cgi?id=106608
Source/WebCore:
The patch adds a check at wrapper creation time to enuse that the
object being wrapped is not already free, to the extent that we know
the information about the type of the object as provided in the IDL.
Patch by Tom Sepez <tsepez@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
Patch is correct if existing tests pass without new crashes.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
(GenerateToV8Converters):
(GetNativeTypeForConversions):
(GetGnuVTableRefForInterface):
(GetGnuVTableNameForInterface):
(GetGnuMangledNameForInterface):
(GetGnuVTableOffsetForType):
(GetWinVTableRefForInterface):
(GetWinVTableNameForInterface):
(GetWinMangledNameForInterface):
(GetNamespaceForInterface):
(GetImplementationLacksVTableForInterface):
(GetV8SkipVTableValidationForInterface):
Update code generation to add object validity tests under the control
of the ENABLE_BINDING_INTEGRITY option.
- Modules/filesystem/DirectoryReader.idl:
- Modules/filesystem/DirectoryReaderSync.idl:
- Modules/filesystem/EntryArray.idl:
- Modules/filesystem/EntryArraySync.idl:
- Modules/filesystem/Metadata.idl:
- Modules/gamepad/Gamepad.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/geolocation/Geoposition.idl:
- Modules/geolocation/PositionError.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/mediastream/RTCStatsElement.idl:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/quota/StorageInfo.idl:
- Modules/speech/SpeechGrammar.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognitionAlternative.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/AudioSourceNode.idl:
- Modules/webaudio/WaveTable.idl:
- Modules/webdatabase/SQLError.idl:
- Modules/webdatabase/SQLException.idl:
- Modules/webdatabase/SQLResultSet.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/webdatabase/SQLTransaction.idl:
- Modules/webdatabase/SQLTransactionSync.idl:
- bindings/scripts/IDLAttributes.txt:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/CSSValueList.idl:
- css/Counter.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/RGBColor.idl:
- css/Rect.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSFilterValue.idl:
- css/WebKitCSSMixFunctionValue.idl:
- css/WebKitCSSTransformValue.idl:
- dom/ClientRect.idl:
- dom/ClientRectList.idl:
- dom/Clipboard.idl:
- dom/DOMCoreException.idl:
- dom/DOMError.idl:
- dom/DOMImplementation.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringList.idl:
- dom/DOMStringMap.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DocumentFragment.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/MessageChannel.idl:
- dom/MouseEvent.idl:
- dom/MutationObserver.idl:
- dom/MutationRecord.idl:
- dom/NamedNodeMap.idl:
- dom/NodeFilter.idl:
- dom/NodeIterator.idl:
- dom/NodeList.idl:
- dom/Range.idl:
- dom/RangeException.idl:
- dom/Touch.idl:
- dom/TouchList.idl:
- dom/TreeWalker.idl:
- fileapi/FileError.idl:
- fileapi/FileException.idl:
- fileapi/FileList.idl:
- html/DOMFormData.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLAllCollection.idl:
- html/HTMLCollection.idl:
- html/HTMLDialogElement.idl:
- html/HTMLDivElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLSpanElement.idl:
- html/HTMLUnknownElement.idl:
- html/ImageData.idl:
- html/MediaError.idl:
- html/MediaKeyError.idl:
- html/TimeRanges.idl:
- html/ValidityState.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/ArrayBufferView.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasPattern.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- html/canvas/WebGLActiveInfo.idl:
- html/canvas/WebGLShaderPrecisionFormat.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorFrontendHost.idl:
- inspector/JavaScriptCallFrame.idl:
- page/Coordinates.idl:
- page/Crypto.idl:
- page/MemoryInfo.idl:
- page/PagePopupController.idl:
- page/PerformanceEntryList.idl:
- page/SpeechInputResult.idl:
- page/SpeechInputResultList.idl:
- page/WebKitPoint.idl:
- svg/SVGAnimatedAngle.idl:
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.idl:
- svg/SVGAnimatedLength.idl:
- svg/SVGAnimatedLengthList.idl:
- svg/SVGAnimatedNumber.idl:
- svg/SVGAnimatedNumberList.idl:
- svg/SVGAnimatedPreserveAspectRatio.idl:
- svg/SVGAnimatedRect.idl:
- svg/SVGAnimatedString.idl:
- svg/SVGAnimatedTransformList.idl:
- svg/SVGColor.idl:
- svg/SVGException.idl:
- svg/SVGPaint.idl:
- svg/SVGPathSeg.idl:
- svg/SVGRenderingIntent.idl:
- svg/SVGUnitTypes.idl:
- svg/SVGZoomAndPan.idl:
- testing/MallocStatistics.idl:
- testing/TypeConversions.idl:
- workers/WorkerLocation.idl:
- xml/DOMParser.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathException.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- xml/XSLTProcessor.idl:
Add exceptions to binding integrity checks to IDL.
Source/WebKit/chromium:
Patch by Tom Sepez <tsepez@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
- features.gypi:
Added ENABLE_BINDING_INTEGRITY option.
- 6:28 PM Changeset in webkit [141033] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Build fix.
Unreviewed build fix. Remove the use of SkMutex from DiscardablePixelRef.
- platform/graphics/chromium/DiscardablePixelRef.cpp:
(WebCore::DiscardablePixelRefAllocator::allocPixelRef):
(WebCore::DiscardablePixelRef::DiscardablePixelRef):
- platform/graphics/chromium/DiscardablePixelRef.h:
(DiscardablePixelRef):
- 6:03 PM Changeset in webkit [141032] by
-
- 3 edits in trunk/Source/WebKit2
Add StorageManager class to cmake ports
Unreviewed build fix. Though StorageManager was added to WK2 in r141024,
it is not added to cmake ports(EFL).
- CMakeLists.txt:
- PlatformEfl.cmake:
- 5:42 PM Changeset in webkit [141031] by
-
- 2 edits in trunk/LayoutTests
Make integer-modulo.js a try JS-Regress test
https://bugs.webkit.org/show_bug.cgi?id=108130
Reviewed by Filip Pizlo.
Eliminated the LayoutTest calls. Sum the values and throw an expection if it doesn't
match up.
- fast/js/regress/script-tests/integer-modulo.js:
- 5:29 PM Changeset in webkit [141030] by
-
- 4 edits in trunk/Source
String constructed from Literals should be non-empty
https://bugs.webkit.org/show_bug.cgi?id=108103
Reviewed by Eric Carlson.
Source/WebCore:
Strings from literal should not be constructed from empty strings. Use emptyString()
instead.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
Source/WTF:
For efficiency, the construction from literal only works with valid non-empty strings.
One of the constructor was changed to fix an error from HTMLMediaElement.
This patch replaces the branch with an assertions.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
- 5:22 PM Changeset in webkit [141029] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add more assertions to the property storage use in arrays
https://bugs.webkit.org/show_bug.cgi?id=107728
Reviewed by Filip Pizlo.
Add a bunch of assertions to array and object butterfly
usage. This should make debugging somewhat easier.
I also converted a couple of assertions to release asserts
as they were so low cost it seemed a sensible thing to do.
- runtime/JSArray.cpp:
(JSC::JSArray::sortVector):
(JSC::JSArray::compactForSorting):
- runtime/JSObject.h:
(JSC::JSObject::getHolyIndexQuickly):
- 5:01 PM Changeset in webkit [141028] by
-
- 11 edits in trunk
Implement CompositionEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=107919
Reviewed by Sam Weinig.
This patch implements a CompositionEvent constructor under
a DOM4_EVENTS_CONSTRUCTOR flag.
Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
Source/WebCore:
Test: fast/events/constructors/composition-event-constructor.html
- dom/CompositionEvent.cpp:
(WebCore::CompositionEventInit::CompositionEventInit):
(WebCore):
(WebCore::CompositionEvent::CompositionEvent):
- dom/CompositionEvent.h:
(CompositionEventInit):
(WebCore):
(CompositionEvent):
(WebCore::CompositionEvent::create):
(WebCore::CompositionEvent::data):
- dom/CompositionEvent.idl:
LayoutTests:
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/events/constructors/composition-event-constructor-expected.txt: Added.
- fast/events/constructors/composition-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- fast/dom/constructed-objects-prototypes-expected.txt:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 5:01 PM Changeset in webkit [141027] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13098777>
Add (allow mach-lookup (global-name "com.apple.tccd.system"))
Reviewed by Maciej Stachowiak.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:41 PM Changeset in webkit [141026] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2 should notify the client if the NetworkProcess crashes.
<rdar://problem/13090513> and https://bugs.webkit.org/show_bug.cgi?id=108126
Reviewed by Sam Weinig.
Add new client callback to the ContextClient:
- UIProcess/API/C/WKContext.h:
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::networkProcessDidCrash):
- UIProcess/WebContextClient.h:
Call out to the client when the NetworkProcess crashes:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::networkProcessCrashed):
- UIProcess/WebContext.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
- 4:18 PM Changeset in webkit [141025] by
-
- 7 edits in trunk/Source
PLATFORM(IOS) should come before MAC_OS_X_VERSION_MIN_REQUIRED
https://bugs.webkit.org/show_bug.cgi?id=108101
Reviewed by Benjamin Poulain.
Since iOS does not define MAC_OS_X_VERSION_MIN_REQUIRED, any usage of
MAC_OS_X_VERSION_MIN_REQUIRED should be after a PLATFORM(IOS) check.
Source/WebCore:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 4:08 PM Changeset in webkit [141024] by
-
- 3 edits3 adds in trunk/Source/WebKit2
Add StorageManager class
https://bugs.webkit.org/show_bug.cgi?id=108127
Reviewed by Sam Weinig.
The StorageManager will be in charge of handling access to local and session storage
in the UI process.
- UIProcess/Storage/StorageManager.cpp: Added.
- UIProcess/Storage/StorageManager.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 4:02 PM Changeset in webkit [141023] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Pass ICU cppflags to libWebCoreSVG.la build
https://bugs.webkit.org/show_bug.cgi?id=108032
Patch by Kalev Lember <kalevlember@gmail.com> on 2013-01-28
Reviewed by Martin Robinson.
Fixes a linking error with new libicu 50 on Fedora rawhide.
- GNUmakefile.am:
- 3:53 PM Changeset in webkit [141022] by
-
- 7 edits in trunk/Tools
Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
https://bugs.webkit.org/show_bug.cgi?id=107903
Patch by Timothy Loh <timloh@chromium.com> on 2013-01-28
Reviewed by Eric Seidel.
To make ChangeLog and PrepareChangeLog easier to test, we can use
FileSystem objects instead of just passing around paths.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.init):
(ChangeLog.parse_latest_entry_from_file):
(ChangeLog.parse_entries_from_file):
(ChangeLog.latest_entry):
(ChangeLog.update_with_unreviewed_message):
(ChangeLog.set_reviewer):
(ChangeLog.set_short_description_and_bug_url):
(ChangeLog.delete_entries):
(ChangeLog.prepend_text):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(ChangeLogTest):
(test_parse_log_entries_from_changelog):
(test_latest_entry_parse_single_entry):
(test_set_reviewer):
(test_set_short_description_and_bug_url):
(test_delete_entries):
(test_prepend_text):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(ReadableTextFileObject.init):
- Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog._ensure_bug_url):
(PrepareChangeLog._resolve_existing_entry):
(PrepareChangeLog.run):
- Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(test_ensure_bug_url):
- Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(_assert_message_for_revert_output):
- 3:48 PM Changeset in webkit [141021] by
-
- 4 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r141006.
http://trac.webkit.org/changeset/141006
https://bugs.webkit.org/show_bug.cgi?id=108123
Broke chromium build (Requested by arv on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28
- public/WebConsoleMessage.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
- 3:40 PM Changeset in webkit [141020] by
-
- 11 edits3 adds in trunk/Source
adding support for DiscardablePixelRef for caching lazily decoded images
https://bugs.webkit.org/show_bug.cgi?id=106842
Patch by Min Qin <qinmin@chromium.org> on 2013-01-28
Reviewed by Stephen White.
Source/WebCore:
This change allows using discardable memory in the deferred image decoding path.
Fully decoded images are unpinned and stored in ImageDecodingStore.
Partially decoded images are pinned and stored in ImageDecodingStore.
Discardable memory allocation could fail. Fall back to heap allocation in that case.
There is a separate size limit for heap entries and no limit on discardable entries.
New tests are added to ImageDecodingStoreTests
- WebCore.gypi:
- platform/graphics/chromium/DiscardablePixelRef.cpp: Added. Added implementation of the DiscardablePixelRef object that is backed by discardable memory. Memory allocated to the DiscardablePixelRef can be purged when it is unlocked.
(WebCore::DiscardablePixelRefAllocator::allocPixelRef):
(WebCore):
(WebCore::DiscardablePixelRef::DiscardablePixelRef):
(WebCore::DiscardablePixelRef::~DiscardablePixelRef):
(WebCore::DiscardablePixelRef::allocAndLockDiscardableMemory):
(WebCore::DiscardablePixelRef::onLockPixels):
(WebCore::DiscardablePixelRef::onUnlockPixels):
(WebCore::DiscardablePixelRef::isDiscardable):
- platform/graphics/chromium/DiscardablePixelRef.h: Added. Added class definition of the DiscardablePixelRef.
(WebCore):
(DiscardablePixelRefAllocator):
(DiscardablePixelRef):
- platform/graphics/chromium/ImageDecodingStore.cpp: Added new cache replacement strategy for DiscardablePixelRef.
(WebCore::ImageDecodingStore::lockCache):
(WebCore::ImageDecodingStore::overwriteAndLockCache):
(WebCore::ImageDecodingStore::prune):
(WebCore::ImageDecodingStore::insertCacheInternal):
(WebCore::ImageDecodingStore::removeFromCacheInternal):
- platform/graphics/chromium/ImageDecodingStore.h: Added isDiscardable() calls to check if a cache entry is discardable.
(WebCore::ImageDecodingStore::CacheEntry::CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::overwriteCachedImage):
(WebCore::ImageDecodingStore::CacheEntry::isDiscardable):
(CacheEntry):
- platform/graphics/chromium/ImageFrameGenerator.cpp: Added some code to pass DiscardableMemoryAllocator to the image decoder.
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::decode):
- platform/graphics/chromium/ImageFrameGenerator.h: Added a new member variable of type DiscardableMemoryAllocator.
(ImageFrameGenerator):
- platform/image-decoders/ImageDecoder.h: Added methods to pass Allocator to ImageFrame.
(ImageFrame):
(WebCore::ImageFrame::setMemoryAllocator):
(WebCore::ImageFrame::allocator):
(ImageDecoder):
(WebCore::ImageDecoder::setMemoryAllocator):
- platform/image-decoders/skia/ImageDecoderSkia.cpp: Added code to allocate pixel memory using the allocator passed from the caller.
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::setSize):
Source/WebKit/chromium:
Adding new tests for ImageDecodingStore
- WebKit.gypi:
- tests/ImageDecodingStoreTest.cpp:
(WebCore::ImageDecodingStoreTest::createCompleteImage):
(WebCore::ImageDecodingStoreTest::createIncompleteImage):
(WebCore::TEST_F):
(WebCore):
- tests/MockDiscardablePixelRef.h: Added.
(WebCore):
(MockDiscardablePixelRef):
(WebCore::MockDiscardablePixelRef::MockDiscardablePixelRef):
(WebCore::MockDiscardablePixelRef::~MockDiscardablePixelRef):
(WebCore::MockDiscardablePixelRef::discard):
(WebCore::MockDiscardablePixelRef::onLockPixels):
(WebCore::MockDiscardablePixelRef::onUnlockPixels):
- 3:38 PM Changeset in webkit [141019] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
[Chromium, Mobile] Do not show disambiguation pop up in mobile sites
https://bugs.webkit.org/show_bug.cgi?id=107607
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
Add a check before showing the disambiguation popup to prevent it from appearing
on mobile sites. Makes a similar test to the current disambiguation popup test
that expects the popup to never appear.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::WebViewImpl::isLikelyMobileSite):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_mobile_site.html: Added.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_mobile_site.html: Added.
- 3:32 PM Changeset in webkit [141018] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix the build.
Unreviewed build fix.
- src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
- 3:20 PM Changeset in webkit [141017] by
-
- 8 edits in trunk/Source/WebKit2
More work on UI side local storage
https://bugs.webkit.org/show_bug.cgi?id=108119
Reviewed by Beth Dakin.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
Rename create to createSessionStorageNamespace and make it take a WebPage.
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):
Add WebPage parameter.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
Add an #ifdef for enabling UI side storage.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::page):
Call new WebPage::fromCorePage helper.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::fromCorePage):
Add new function for getting a WebPage from a WebCore::Page.
- 3:15 PM Changeset in webkit [141016] by
-
- 2 edits in trunk/Tools
Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=107992
Reviewed by kbr@google.com.
- Scripts/webkitpy/common/config/committers.py:
- 3:07 PM Changeset in webkit [141015] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r140869.
http://trac.webkit.org/changeset/140869
https://bugs.webkit.org/show_bug.cgi?id=108120
"Crashes on http://en.wikipedia.org/wiki/Wikipedia" (Requested
by tonyg-cr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentsResized):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::setUseFixedLayout):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
- tests/WebFrameTest.cpp:
- 3:05 PM Changeset in webkit [141014] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening, removing Crash expectations from storage/indexeddb tests.
https://bugs.webkit.org/show_bug.cgi?id=108048
Unreviewed.
- platform/chromium/TestExpectations:
- 2:47 PM Changeset in webkit [141013] by
-
- 60 edits3 adds6 deletes in trunk
Unreviewed, rolling out r140934, r140935, and r140937.
http://trac.webkit.org/changeset/140934
http://trac.webkit.org/changeset/140935
http://trac.webkit.org/changeset/140937
https://bugs.webkit.org/show_bug.cgi?id=108117
Re-land some speculative rollouts - see wkbug.com/108048 for
context (Requested by jsbell on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBCallbacks.h:
(IDBCallbacks):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::onVersionChange):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::OpenCursorOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBFactory.h:
(WebCore):
(IDBFactory):
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::dispatchEvent):
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
(WebCore::IDBRequest::taskType):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Removed.
- Modules/indexeddb/IDBUpgradeNeededEvent.h: Removed.
- Modules/indexeddb/IDBUpgradeNeededEvent.idl: Removed.
- Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
- Modules/indexeddb/IDBVersionChangeEvent.h:
(IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::oldVersion):
(WebCore::IDBVersionChangeEvent::newVersion):
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/indexeddb/IDBVersionChangeRequest.cpp: Removed.
- Modules/indexeddb/IDBVersionChangeRequest.h: Removed.
- Modules/indexeddb/IDBVersionChangeRequest.idl: Removed.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.in:
- dom/EventTarget.h:
(WebCore):
- dom/EventTargetFactory.in:
Source/WebKit/chromium:
- public/WebIDBCallbacks.h:
(WebIDBCallbacks):
- src/AssertMatchingEnums.cpp:
- src/IDBCallbacksProxy.cpp:
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp:
- tests/IDBDatabaseBackendTest.cpp:
LayoutTests:
- storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
- storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-blocked-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-not-blocked-expected.txt:
- storage/indexeddb/events-expected.txt: Added.
- storage/indexeddb/events.html: Added.
- storage/indexeddb/intversion-gated-on-delete-expected.txt:
- storage/indexeddb/intversion-long-queue-expected.txt:
- storage/indexeddb/intversion-upgrades-expected.txt:
- storage/indexeddb/removed-expected.txt:
- storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
(versionChangeCallback):
- storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:
(versionChangeCallback):
- storage/indexeddb/resources/deletedatabase-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
- storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(prepareDatabase.h.onversionchange):
- storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js:
(h1OpenSuccess.h1.onversionchange.h1OnVersionChange.h1.onversionchange):
(h1OpenSuccess.h1.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.h2.onversionchange):
- storage/indexeddb/resources/deletedatabase-not-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
- storage/indexeddb/resources/events.js: Added.
(test):
- storage/indexeddb/resources/intversion-gated-on-delete.js:
(firstSuccessCallback):
(connection1VersionChangeCallback):
- storage/indexeddb/resources/intversion-long-queue.js:
(connection1VersionChangeCallback):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2VersionChangeEvent):
- storage/indexeddb/resources/removed.js:
(test):
- 2:42 PM Changeset in webkit [141012] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Mac build fix. Add an export for a function that may be
accessed outside of WebCore (RenderLayer::needsCompositedScrolling).
- WebCore.exp.in:
- 2:38 PM Changeset in webkit [141011] by
-
- 9 edits2 adds in trunk
[Mac] Update PageVisibilityState when WebView is hidden / visible
https://bugs.webkit.org/show_bug.cgi?id=107509
Source/WebKit/mac:
Reviewed by NOBODY (OOPS!).
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Set the initial visibility of the page.
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _isViewVisible]):
(-[WebView _updateVisibilityState]):
(-[WebView viewDidMoveToWindow]):
(-[WebView _windowVisibilityChanged:]):
Update visibility state in the same ways WK2 does. This involves
listening for some new NSWindow delegates.
Tools:
Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
automatically changes between hidden and visible as the view is added
and removed from window, or when it is in a window that changes
visibility, for instance by minimizing / deminimizing.
Reviewed by NOBODY (OOPS!).
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
(-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
(runJavaScriptAlert):
(PageVisibilityStateWithWindowChanges):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::deinitializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
(TestWebKitAPI::TEST_F):
Test visibility state of a page in a WebView/WKView with different window states.
- TestWebKitAPI/mac/WebKitAgnosticTest.h:
- TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::deinitializeView):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
Add a WK1 and WK2 deinitializeView to balance initializeView.
- 2:38 PM Changeset in webkit [141010] by
-
- 28 edits2 adds in trunk
Improve PageVisibility API with enums
https://bugs.webkit.org/show_bug.cgi?id=107364
Reviewed by Sam Weinig.
Source/WebKit/mac:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
(corePageVisibilityState):
(-[WebView _setVisibilityState:isInitialState:]):
Switch the private API form int to a WebPageVisibilityState enum.
Source/WebKit2:
- Shared/API/c/WKPageVisibilityTypes.h: Added.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
Create an enum for page visibility APIs and a conversion function
for the WK2 values to WebCore values.
- Target.pri:
- GNUmakefile.list.am:
- WebKit2.xcodeproj/project.pbxproj:
Add WKPageVisibilityTypes.h to the build as a private export.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetVisibilityState):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setVisibilityState):
UIProcess API to set visibility state. WebPageProxy already
had m_visibilityState, so update that when setter is used.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
Remove the old SPI for WebKitTestRunner. Tests now use the C API.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setVisibilityState):
- WebProcess/WebPage/WebPage.messages.in:
Update the existing WebPage API to use uint32_t, which matches
other enum message types.
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
Update the WK1 test code to use the new WK1 enums.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::setVisibilityState):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
(WTR::TestRunner::resetPageVisibility):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::setVisibilityState):
- WebKitTestRunner/TestController.h:
(TestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
Update the WK2 test code to use the new WK2 API and enums.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
(TestWebKitAPI::assertSerializedScriptValueIsStringValue):
(TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
(TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
(TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
(TestWebKitAPI::didRunStep4InStatePreview):
(TestWebKitAPI::TEST):
Test the new WK2 API with all enum types.
- 2:28 PM Changeset in webkit [141009] by
-
- 2 edits in trunk/Source/WebCore
Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
https://bugs.webkit.org/show_bug.cgi?id=108084
Reviewed by Dean Jackson.
This is a blind fix based on the code and Chromium's stack-traces.
Unfortunately no new test as I couldn't get a local reproduction.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
Added a missing NULL-check: the previous 'while' finish if |lineBox|
is NULL and we don't want to crash in this case.
- 2:24 PM BuildingGtk edited by
- Added "librsvg2-dev" base dependency, which is required to build … (diff)
- 2:22 PM Changeset in webkit [141008] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_download_job
https://bugs.webkit.org/show_bug.cgi?id=107810
Reviewed by Anders Carlsson.
Use C API inside ewk_download_job instead of accessing internal C++
classes directly, to avoid violating API layering.
- UIProcess/API/C/WKDownload.cpp:
(WKDownloadGetID): Add C API to get the download ID as we need it to
support our public API and it seems like a useful addition.
- UIProcess/API/C/WKDownload.h:
- UIProcess/API/efl/ewk_download_job.cpp:
(EwkDownloadJob::EwkDownloadJob):
(EwkDownloadJob::id):
(EwkDownloadJob::request):
(EwkDownloadJob::cancel):
- UIProcess/API/efl/ewk_download_job_private.h:
(EwkDownloadJob::create):
(EwkDownloadJob):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didReceiveResponse):
(WebKit::DownloadManagerEfl::didCreateDestination):
(WebKit::DownloadManagerEfl::didReceiveData):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownloadJob): Rename
registerDownload() to registerDownloadJob() for consistency with
unregisterDownloadJob().
(WebKit::DownloadManagerEfl::ewkDownloadJob): Rename downloadJob() to
ewkDownloadJob() for clarity since it returns a EwkDownload object.
Also take a WKDownloadRef in argument instead of an identifier since
all the callers have a WKDownloadRef and it makes their code simpler.
Finally, make the getter non-const since it returns a non-const pointer.
(WebKit::DownloadManagerEfl::unregisterDownloadJob): Take a
WKDownloadRef in argument instead of an identifier since all the
callers have a WKDownloadRef and it makes their code simpler.
- UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):
- UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::handleDownloadRequest):
- 2:06 PM Changeset in webkit [141007] by
-
- 2 edits in trunk/Source/WebCore
"clang: warning: not using the clang compiler for C++ inputs" due to hard-coding of /usr/bin/clang in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=108089
Reviewed by Ojan Vafai.
Use gcc since older versions of clang (with Xcode 3.2) warn that they are going to use gcc anyway.
These warnings are showing up on the main Chromium waterfall too:
http://build.chromium.org/p/chromium/builders/Mac/builds/19113/steps/compile/logs/stdio
No new tests, this is a build change.
- WebCore.gyp/WebCore.gyp:
- 1:47 PM Changeset in webkit [141006] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
https://bugs.webkit.org/show_bug.cgi?id=108004
http://code.google.com/p/chromium/issues/detail?id=172416
console.debug triggers a NOTREACHED() assertation in Chromium. This
is because WebCore::MessageLevel contains 5 levels, including debug,
where WebConsoleMessage::Level is missing a "debug" level. Add a
WebConsoleMessage::LevelDebug so that it can get passed up to the
renderer even if it doesn't make use of that now.
Requires another patch to chromium itself to fix chromium bug 172416
but this is a prerequisite.
Also add an enum compile time check to AssertMatchingEnums.cpp,
Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
Reviewed by Jochen Eisinger.
- public/WebConsoleMessage.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
- 1:45 PM Changeset in webkit [141005] by
-
- 8 edits in trunk/Source/WebCore
Move hasAuthorShadowRoot to Element
https://bugs.webkit.org/show_bug.cgi?id=108071
Reviewed by Dimitri Glazkov.
Move hasAuthorShadowRoot to Element and get rid of unneccesary booleans
in HTMLProgressElement and HTMLMeterElement. Also get rid of
ShadowRoot::isAccessible since it obfuscates what's actually happening
inside of Element::shadowRoot().
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::shadowRoot):
(WebCore::Element::hasAuthorShadowRoot):
- dom/Element.h:
(Element):
- dom/ShadowRoot.h:
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
- html/HTMLMeterElement.h:
(HTMLMeterElement):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
- html/HTMLProgressElement.h:
(HTMLProgressElement):
- 1:42 PM Changeset in webkit [141004] by
-
- 9 edits in trunk/Source/WebKit2
PDFPlugin: getMainResourceDataOfFrame should return PDFPlugin's data so that Save... works
https://bugs.webkit.org/show_bug.cgi?id=108060
<rdar://problem/13075454>
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Implement getResourceData.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm: Implement getResourceData, returning the accumulated
data if it exists and has finished loading.
(WebKit::SimplePDFPlugin::getResourceData):
- WebProcess/Plugins/Plugin.h: Add getResourceData, which hands out a raw pointer/size pair
to the plugin's "main resource" data.
- WebProcess/Plugins/PluginProxy.h: Implement getResourceData.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::getResourceData): Forward getResourceData through to the plugin.
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getMainResourceDataOfFrame): If the requested frame is backed by a PluginDocument,
attempt to ask the PluginView for its resource data.
- 1:37 PM BuildingGtk edited by
- Removed duplicate deps that I just added :-\ (diff)
- 1:36 PM BuildingGtk edited by
- Added base dependencies gtk-doc-tools and gnome-common that are … (diff)
- 1:36 PM Changeset in webkit [141003] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] WKView's intrinsicContentSize should only report a flexible width if the content width is less than the minimum width
https://bugs.webkit.org/show_bug.cgi?id=108056
Reviewed by Simon Fraser.
We're currently reporting a flexible width if the intrinsic
content size is less than *or equal* to the minimum layout
width. This is wrong and causes ping-ponging between flexible
and inflexible width in cases where autolayout fits our
view to exactly the intrinsic content size. It should be strictly
less than instead.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setIntrinsicContentSize:]):
- 1:36 PM Changeset in webkit [141002] by
-
- 5 edits in trunk/Source/WebCore
Move ensureUserAgentShadowRoot to Element
https://bugs.webkit.org/show_bug.cgi?id=108070
Reviewed by Dimitri Glazkov.
Move ensureUserAgentShadowRoot to Element where the other
methods related to shadow roots are and get rid of the
unnecessarily specific cast to HTMLElement.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::ensureUserAgentShadowRoot): Moved from FormAssociatedElement.
- dom/Element.h:
(Element):
- html/FormAssociatedElement.cpp:
- html/FormAssociatedElement.h:
(FormAssociatedElement):
- 1:24 PM Changeset in webkit [141001] by
-
- 1 edit in branches/chromium/1364/Source/WebKit/chromium/features.gypi
Merge 141000
BUG=163593
Review URL: https://codereview.chromium.org/12095019
- 1:20 PM Changeset in webkit [141000] by
-
- 1 edit in trunk/Source/WebKit/chromium/features.gypi
Revert 130950
BUG=163593
- 1:18 PM Changeset in webkit [140999] by
-
- 5 edits3 adds in trunk
Promote composited-scrolling layers to stacking containers.
https://bugs.webkit.org/show_bug.cgi?id=106142
Reviewed by Simon Fraser.
With this patch, RenderLayers that use composited scrolling are
treated as stacking contexts. Since isStackingContainer now depends on
the value of m_needsCompositedScrolling, special care needed to be
taken to ensure that the value of isStackingContainer is not used when
updating m_needsCompositedScrolling. In particular, the code for
rebuilding the layer lists needed to be generalized so that we could
build the layer lists using the value of isStackingContext rather than
isStackingContainer when building the layer lists used to determine if
the descendants are contiguous in stacking order. Also, updating
m_needsCompositedScrolling can now affect stacking container status
and can therefore dirty layer lists.
Source/WebCore:
Test: compositing/overflow/composited-scrolling-creates-a-stacking-container.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
Modified to use layer lists built based on isStackingContext rather
than isStackingContainer.
(WebCore::RenderLayer::updateNeedsCompositedScrolling):
This function can now affect stacking container status and layer
lists.
(WebCore::RenderLayer::rebuildZOrderLists):
Refactored to generalize layer list building.
(WebCore::RenderLayer::collectLayers):
This function can now stop at either stacking containers or
contexts.
(WebCore::RenderLayer::updateLayerListsIfNeeded):
Layer lists may need to be built a 2nd time if we opt into
composited scrolling.
- rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::isStackingContainer):
Returns true if we use composited scrolling.
LayoutTests:
- compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.
- compositing/overflow/composited-scrolling-creates-a-stacking-container.html: Added.
- platform/chromium/TestExpectations:
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.
- 1:15 PM Changeset in webkit [140998] by
-
- 1 edit in trunk/Source/WebKit/chromium/features.gypi
Revert 140996
Revert 130950
BUG=163593
- 1:14 PM Changeset in webkit [140997] by
-
- 26 edits2 copies9 adds in trunk
[CSS Shaders] Parse @-webkit-filter
https://bugs.webkit.org/show_bug.cgi?id=106837
Reviewed by Dean Jackson.
Source/WebCore:
The new CSS Custom Filters syntax includes an @filter rule:
@filter IDENT { <custom-filter-description> }
IDENT is the filter name. For example:
@filter my-filter { ... }
<custom-filter-description> is a set of CSS properties, which are still under discussion in
the CSSWG.
This patch adds parsing and JS bindings for the prefixed at-rule. It does not add parsing
for any of the at-rule's internal properties.
Spec: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#the-atfilter-rule
Tests: css3/filters/custom/custom-filter-parsing-at-rule-invalid.html
css3/filters/custom/custom-filter-parsing-at-rule-valid.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::createFilterRule):
(WebCore::CSSParser::detectAtToken):
- css/CSSParser.h:
- css/CSSPropertySourceData.h:
- css/CSSRule.h:
- css/CSSRule.idl:
Only contains a CSSStyleDeclaration "style" property, like the other at-rules that are
supposed to contain properties (e.g. CSSStyleRule, CSSFontFaceRule, CSSPageRule).
Eventually, when it's specified, we should expose the filter name as well.
Other at-rules IDL Spec: http://www.w3.org/TR/DOM-Level-2-Style/idl-definitions.html
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::~StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):
(WebCore::StyleRuleFilter::setProperties):
(WebCore::StyleRuleFilter::reportDescendantMemoryUsage):
- css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::isFilterRule):
(StyleRuleFilter):
(WebCore::StyleRuleFilter::create):
(WebCore::StyleRuleFilter::filterName):
(WebCore::StyleRuleFilter::properties):
(WebCore::StyleRuleFilter::copy):
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- css/WebKitCSSFilterRule.cpp: Added.
WebKitCSSFilterRule is implemented similar to CSSFontFaceRule.
(WebCore::WebKitCSSFilterRule::WebKitCSSFilterRule):
(WebCore::WebKitCSSFilterRule::~WebKitCSSFilterRule):
(WebCore::WebKitCSSFilterRule::style):
(WebCore::WebKitCSSFilterRule::cssText):
The CSS text implementation for WebKitCSSFilterRule is almost the same as
CSSFontFaceRule. WebKitCSSFilterRule additionally needs to output the filter name in its
syntax (e.g. @-webkit-filter my-filter { }).
(WebCore::WebKitCSSFilterRule::reattach):
(WebCore::WebKitCSSFilterRule::reportMemoryUsage):
- css/WebKitCSSFilterRule.h: Added.
(WebKitCSSFilterRule):
(WebCore::WebKitCSSFilterRule::create):
- css/WebKitCSSFilterRule.idl: Added.
LayoutTests:
Add positive and negative tests for parsing the @-webkit-filter rule.
Factored out common helper functions between the existing CSS Custom Filters parsing tests
and the new tests into custom-filter-parsing-common.js.
- css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.txt: Added.
- css3/filters/custom/custom-filter-parsing-at-rule-invalid.html: Added.
- css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Added.
- css3/filters/custom/custom-filter-parsing-at-rule-valid.html: Added.
- css3/filters/custom/custom-filter-property-parsing-invalid.html:
- css3/filters/custom/custom-filter-property-parsing.html:
- css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js: Added.
(testInvalidFilterAtRule):
- css3/filters/script-tests/custom-filter-parsing-at-rule-valid.js: Added.
(testFilterAtRule):
Tests @-webkit-filter rule parsing and its ability to hold CSS properties.
(testNestedRules):
Tests nesting between at-rules, involving @-webkit-filter rules.
(checkRule):
Factor out common rule checking functionality into its own helper function, so it can be
reused.
- css3/filters/script-tests/custom-filter-parsing-common.js: Added.
(jsWrapperClass):
Moved.
(shouldBeType):
Moved.
- css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
- css3/filters/script-tests/custom-filter-property-parsing.js:
- platform/chromium/css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt:
V8 represents WebKitCSSFilterRule a little differently.
- 1:13 PM Changeset in webkit [140996] by
-
- 1 edit in trunk/Source/WebKit/chromium/features.gypi
Revert 130950
BUG=163593
- 1:10 PM Changeset in webkit [140995] by
-
- 6 edits in trunk/Source
Add StorageStrategy member functions to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108105
Reviewed by Tim Horton.
Source/WebCore:
StorageStrategy::sessionStorageNamespace should be virtual, not static...
- WebCore.exp.in:
- storage/StorageStrategy.h:
(StorageStrategy):
Source/WebKit2:
Add default implementations that just chain up to the base class for now.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::localStorageNamespace):
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- 1:08 PM Changeset in webkit [140994] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Correct auto-zoom when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107592
Reviewed by Adam Barth.
- The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
- Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
- tests/WebFrameTest.cpp: Updated tests DivAutoZoomParamsTest, DivAutoZoomMultipleDivsTest, DivAutoZoomScaleBoundsTest and DivAutoZoomScaleFontScaleFactorTest, to make two versions of them (WebKitScaling and CompositorScaling).
- 12:44 PM BuildingGtk edited by
- Added "inttool" base dependency, which is required to build … (diff)
- 12:43 PM Changeset in webkit [140993] by
-
- 3 edits2 adds in trunk
getComputedStyle returns "left" instead of "none" for "float" on abspos elements
https://bugs.webkit.org/show_bug.cgi?id=105836
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-01-28
Reviewed by Tony Chang.
If 'position' has the value absolute, page or fixed, and the value of float is
left or right, the box is absolutely positioned and the computed value of float is none.
http://www.w3.org/TR/css3-positioning/#dis-pos-flo
This matches behavior of Firefox 18, Opera 12 and IE9.
Source/WebCore:
Test: fast/css/position-absolute-float.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
- fast/css/position-absolute-float-expected.txt: Added.
- fast/css/position-absolute-float.html: Added.
- 12:36 PM Changeset in webkit [140992] by
-
- 2 edits in trunk/Source/WebCore
Don't use threaded HTML parser for data: URLs
https://bugs.webkit.org/show_bug.cgi?id=108096
Reviewed by Eric Seidel.
data: URLs are currently loaded synchronously. Using the main thread parser for them preserves this behavior.
This fixes fast/dom/HTMLDocument/document-open-return-value.html and probably others.
No new tests because covered by existing tests.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- 12:26 PM Changeset in webkit [140991] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a failure expectation for a User Timing test added in r140882.
- platform/gtk/TestExpectations:
- 12:19 PM Changeset in webkit [140990] by
-
- 4 edits in trunk
[EFL] Quit debug build without -DSHARED_CORE=ON
https://bugs.webkit.org/show_bug.cgi?id=104773
Patch by Halton Huo <halton.huo@intel.com> on 2013-01-28
Reviewed by Laszlo Gombos.
Debug build without -DSHARED_CORE=ON will fail because libwebcore_efl.a
is too big (>4G) to archive. The solution is simply to abort cmake in
this condition and notify developer.
- CMakeLists.txt:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsCommon.cmake:
- 12:13 PM Changeset in webkit [140989] by
-
- 2 edits in trunk/Source/WebKit/chromium
Collapse OS(UNIX) OS(ANDROID) to OS(UNIX) https://bugs.webkit.org/show_bug.cgi?id=108091
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-28
Reviewed by Adam Barth.
OS(UNIX) is defined when OS(ANDROID) is defined.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown):
- 11:56 AM Changeset in webkit [140988] by
-
- 2 edits in trunk/Source/WTF
BUILD FIX: Platform.h:1212:22: error: 'MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
This fixes the following build error introduced in r140366 for
Bug 107098:
Platform.h:1212:22: error: 'MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if PLATFORM(MAC) && MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 && !PLATFORM(IOS)
1 error generated.
- wtf/Platform.h: Check !PLATFORM(IOS) first so that iOS builds
do not try to evaluate MAC_OS_X_VERSION_MIN_REQUIRED.
- 11:38 AM Changeset in webkit [140987] by
-
- 1 edit3 adds6 deletes in trunk/LayoutTests
Mac rebaselines after r140192.
- fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
- fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
- fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
- platform/chromium-mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
- platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
- platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Removed.
- platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
- platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
- platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Removed.
- 11:35 AM Changeset in webkit [140986] by
-
- 2 edits in trunk/Source/WebCore
Don't use the threaded HTML parser for javascript: URLs
https://bugs.webkit.org/show_bug.cgi?id=107975
Reviewed by Adam Barth.
Several layout tests depend on javascript: URL iframes loading synchronously including fast/loader/javascript-url-encoding.html.
This patch avoids using the threaded parser for those URLs so they will continue to be synchronous.
No new tests because covered by existing tests.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- 11:28 AM Changeset in webkit [140985] by
-
- 6 edits in trunk/Source/WebCore
SVGPathStringSource should not up-convert 8-bit strings to UTF-16
https://bugs.webkit.org/show_bug.cgi?id=108050
Reviewed by Anders Carlsson.
Should save around ~400k on Membuster3.
- svg/SVGParserUtilities.cpp:
(WebCore::parseNumber):
(WebCore::genericParseArcFlag):
(WebCore::parseArcFlag):
- svg/SVGParserUtilities.h:
Add LChar variants of parseNumber and parseArcFlag.
- svg/SVGPathSource.h:
(WebCore):
Move forward declaration of FloatPoint here, where it belongs.
- svg/SVGPathStringSource.cpp:
(WebCore::parseFloatPoint):
(WebCore::parseFloatPoint2):
(WebCore::parseFloatPoint3):
Add helpers for parsing float points.
(WebCore::SVGPathStringSource::SVGPathStringSource):
(WebCore::SVGPathStringSource::hasMoreData):
(WebCore::SVGPathStringSource::moveToNextToken):
(WebCore::parseSVGSegmentTypeHelper):
(WebCore::SVGPathStringSource::parseSVGSegmentType):
(WebCore::nextCommandHelper):
(WebCore::SVGPathStringSource::nextCommand):
(WebCore::SVGPathStringSource::parseMoveToSegment):
(WebCore::SVGPathStringSource::parseLineToSegment):
(WebCore::SVGPathStringSource::parseLineToHorizontalSegment):
(WebCore::SVGPathStringSource::parseLineToVerticalSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment):
(WebCore::parseArcToSegmentHelper):
(WebCore::SVGPathStringSource::parseArcToSegment):
- svg/SVGPathStringSource.h:
(SVGPathStringSource):
Make 8-bit aware.
- 11:24 AM Changeset in webkit [140984] by
-
- 2 edits in trunk/Source/WebCore
Repaint issues in background tabs after r138858
https://bugs.webkit.org/show_bug.cgi?id=108092
<rdar://problem/13076430>
Reviewed by Tim Horton.
In r138858, we unparented all tiles in the tile caches of background tabs.
That broke repaints in background tabs; when bringing that tab back to the
foreground, we would call -setNeedsDisplayInRect:, and then reparent the tiles
on a zero-delay timer. Those repaints would then be flipped (possibly because
CA can't look up the layer tree to check for flipped geometry).
Fix by revalidating tiles (which reparents the tiles) at the time we're told
we're moving into the window, which happens before repaints are flushed.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setIsInWindow):
- 11:23 AM Changeset in webkit [140983] by
-
- 22 edits in trunk
Remove webkitNotifications.createHTMLNotification
https://bugs.webkit.org/show_bug.cgi?id=107598
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
As discussed in http://lists.webkit.org/pipermail/webkit-dev/2012-February/019354.html,
we've been slowly deprecating HTML notificiations for about a year.
FeatureObserver says that HTML notifications are used by 0.0008% of web
pages, which means we should be able to remove them without causing too
much trouble.
- Configurations/FeatureDefines.xcconfig:
- Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/NotificationCenter.h:
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
We can remove these stubs once we've removed the Chromium-side code
that depends on them.
- src/WebNotification.cpp:
(WebKit::WebNotification::isHTML):
(WebKit::WebNotification::url):
(WebKit::WebNotification::iconURL):
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
- 11:21 AM Changeset in webkit [140982] by
-
- 2 edits in trunk/Source/WebKit2
Fix non-fat builds by excluding PluginService.32 as a target dependency for WebKit2.
- WebKit2.xcodeproj/project.pbxproj:
- 11:19 AM Changeset in webkit [140981] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r139145): A couple of fast/workers tests fail
https://bugs.webkit.org/show_bug.cgi?id=106415
These tests are stable now.
- platform/mac/TestExpectations:
- 11:15 AM Changeset in webkit [140980] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
https://bugs.webkit.org/show_bug.cgi?id=108085
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-28
Reviewed by Rob Buis.
Fix a merge error that duplicated a function declaration in InputHandler.h.
- WebKitSupport/InputHandler.h:
- 11:09 AM Changeset in webkit [140979] by
-
- 2 edits in trunk/Tools
[chromium] remove temporary define used for updating TestRunner API
Unreviewed. Clean-up change.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- 10:36 AM Changeset in webkit [140978] by
-
- 15 edits2 adds in trunk/Source/WebCore
[CSS Exclusions] Refactor ExclusionShapeInsideInfo to more general ExclusionShapeInfo
https://bugs.webkit.org/show_bug.cgi?id=100766
Patch by Bear Travis <betravis@adobe.com> on 2013-01-28
Reviewed by Dirk Schulze.
Refactoring, covered by existing tests.
Factoring out code common to ExclusionShapeInsideInfo and ExclusionShapeOutsideInfo
into common classes in ExclusionShapeInfo.h. Since the ExclusionShapeInsideInfo and
ExclusionShapeOutsideInfo share almost all of their code, save the RenderObject type
they work with and the specific shapeInside/Outside methods they call on RenderStyle
and ExclusionShape, the code has been templated. The code responsible for maintaining
global maps has also been factored out into a MappedInfo class.
- CMakeLists.txt: Adding ExclusionShapeInfo files.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/ExclusionShapeInfo.cpp: Added.
(WebCore::::computedShape): Determine the shape based on the current logical
dimensions. Call this method rather than accessing m_shape directly.
- rendering/ExclusionShapeInfo.h: Added.
(MappedInfo): Helper class that maintains a global info map.
(WebCore::MappedInfo::ensureInfo): Look up the info for a key and add it if not present.
(WebCore::MappedInfo::removeInfo): Remove the info associated with a key.
(WebCore::MappedInfo::info): Look up the info associated with a key.
(WebCore::MappedInfo::infoMap): The map used to store key/info pairs.
(ExclusionShapeInfo): A common parent class for ExclusionShapeInside/OutsideInfos.
The methods were factored out of the code common to ExclusionShapeInside/OutsideInfo.
(WebCore::ExclusionShapeInfo::~ExclusionShapeInfo): Destructor.
(WebCore::ExclusionShapeInfo::setShapeSize): Sets the shape's logical size.
(WebCore::ExclusionShapeInfo::shapeLogicalTop/Bottom/Left/Right/Width/Height):
Returns the shape's logical dimensions.
(WebCore::ExclusionShapeInfo::dirtyShapeSize): Mark the shape for recomputation.
(WebCore::ExclusionShapeInfo::owner): The renderer to which this info belongs.
(WebCore::ExclusionShapeInfo::ExclusionShapeInfo): Constructor.
(WebCore::ExclusionShapeInfo::floatLogicalTopToLayoutUnit/floatLogicalBottomToLayoutUnit):
Helper methods that round float units from ExclusionShapes to LayoutUnits for layout.
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Modified to use
computedShape() rather than m_shape.
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::createInfo): Renamed to match MappedInfo.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Renamed to match shorter naming.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Modified to use
computedShape().
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Renamed to match shorter naming.
- rendering/ExclusionShapeOutsideInfo.h:
(WebCore::ExclusionShapeOutsideInfo::createInfo): Renamed to match MappedInfo.
(WebCore::ExclusionShapeOutsideInfo::ExclusionShapeOutsideInfo): Constructor.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Use shortened MappedInfo names for looking
up infos.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Ditto.
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Ditto.
(WebCore::RenderBlock::computeExclusionShapeSize): Ditto.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): Ditto.
(WebCore::RenderBox::updateExclusionShapeOutsideInfoAfterStyleChange): Ditto.
- rendering/RenderBox.h:
(WebCore):
(WebCore::RenderBox::exclusionShapeOutsideInfo): Ditto.
- 10:33 AM Changeset in webkit [140977] by
-
- 6 edits5 copies73 moves14 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
Correcting rebaseline done in r140959.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-28
- platform/qt-5.0-wk1/compositing/absolute-inside-out-of-view-fixed-expected.txt: Renamed from LayoutTests/platform/qt/compositing/absolute-inside-out-of-view-fixed-expected.txt.
- platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt.
- platform/qt-5.0-wk1/compositing/bounds-in-flipped-writing-mode-expected.txt: Renamed from LayoutTests/platform/qt/compositing/bounds-in-flipped-writing-mode-expected.txt.
- platform/qt-5.0-wk1/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Renamed from LayoutTests/platform/qt/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
- platform/qt-5.0-wk1/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt.
- platform/qt-5.0-wk1/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt.
- platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt.
- platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Renamed from LayoutTests/platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.png.
- platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/clip-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/clip-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/clip-inside-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/clip-inside-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/composited-in-columns-expected.png.
- platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/composited-in-columns-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/flipped-writing-mode-expected.png.
- platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/flipped-writing-mode-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.png: Renamed from LayoutTests/platform/qt/compositing/geometry/foreground-layer-expected.png.
- platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/geometry/foreground-layer-expected.txt.
- platform/qt-5.0-wk1/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/platform/qt/compositing/geometry/preserve-3d-switching-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/become-composited-nested-iframes-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/become-composited-nested-iframes-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/become-overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/become-overlapped-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/composited-parent-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/composited-parent-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe-delayed-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe2-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe2-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe3-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/connect-compositing-iframe3-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/enter-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/enter-compositing-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/iframe-resize-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/iframe-resize-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/overlapped-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/overlapped-iframe-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-nested-iframes-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/overlapped-nested-iframes-expected.txt.
- platform/qt-5.0-wk1/compositing/iframes/scrolling-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/iframes/scrolling-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/images/clip-on-directly-composited-image-expected.txt: Renamed from LayoutTests/platform/qt/compositing/images/clip-on-directly-composited-image-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/animation-overlap-with-children-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/animation-overlap-with-children-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-out-of-view-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.png: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.png.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overflow-scroll-overlap-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-clipping-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-animation-clipping-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-container-expected.txt: Copied from LayoutTests/platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.png: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-child-layer-expected.png.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-child-layer-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.png: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.png.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/rotate3d-overlap-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/rotate3d-overlap-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/stacking-context-overlap-expected.txt.
- platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Renamed from LayoutTests/platform/qt/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
- platform/qt-5.0-wk1/compositing/masks/mask-layer-size-expected.txt: Renamed from LayoutTests/platform/qt/compositing/masks/mask-layer-size-expected.txt.
- platform/qt-5.0-wk1/compositing/repaint/resize-repaint-expected.txt: Renamed from LayoutTests/platform/qt/compositing/repaint/resize-repaint-expected.txt.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.png: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-absolute-expected.png.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.txt: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-absolute-expected.txt.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.png: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-fixed-expected.png.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.txt: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-fixed-expected.txt.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.png: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-relative-expected.png.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.txt: Renamed from LayoutTests/platform/qt/compositing/rtl/rtl-iframe-relative-expected.txt.
- platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.png.
- platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.txt.
- platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/huge-layer-img-expected.png.
- platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/huge-layer-img-expected.txt.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-clamped-expected.png.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-clamped-expected.txt.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt.
- platform/qt-5.0-wk1/compositing/tiling/tiled-layer-resize-expected.txt: Renamed from LayoutTests/platform/qt/compositing/tiling/tiled-layer-resize-expected.txt.
- platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.png: Renamed from LayoutTests/platform/qt/compositing/visibility/layer-visible-content-expected.png.
- platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.txt: Renamed from LayoutTests/platform/qt/compositing/visibility/layer-visible-content-expected.txt.
- platform/qt-5.0-wk1/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- platform/qt-5.0-wk1/css3/filters/composited-during-transition-layertree-expected.txt: Copied from LayoutTests/platform/qt/css3/filters/composited-during-transition-layertree-expected.txt.
- platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.png: Renamed from LayoutTests/platform/qt/css3/filters/filtered-compositing-descendant-expected.png.
- platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/qt/css3/filters/filtered-compositing-descendant-expected.txt.
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png:
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
- 10:27 AM Changeset in webkit [140976] by
-
- 2 edits in trunk/Source/JavaScriptCore
Cleanup ARM version of debugName() in DFGFPRInfo.h
https://bugs.webkit.org/show_bug.cgi?id=108090
Reviewed by David Kilzer.
Fixed debugName() so it will compile by adding static_cast<int> and missing commas.
- dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::debugName):
- 9:45 AM Changeset in webkit [140975] by
-
- 9 edits2 adds in trunk
SVGViewSpec fails when corresponding element has been removed
https://bugs.webkit.org/show_bug.cgi?id=106957
Reviewed by Dirk Schulze.
Source/WebCore:
When JS holds an SVGViewSpec object while deleting the object that
defines the spec (an SVGSVGElement, or one of a few others) the
pointer to the target is cleared in the SVGViewSpec but the methods
that serve JS queries do not check and try to access the now null
target. This patch fixes the prooblem, returning null when the
corresponding object has been deleted.
Also removing SVGViewSpec::setPreserveAspectRatioString, which is no
longer used by any callers.
Test: svg/dom/SVGViewSpec-invalid-ref-crash.html
- svg/SVGViewSpec.cpp:
(WebCore):
(WebCore::SVGViewSpec::viewTarget): Check for null target and return null.
(WebCore::SVGViewSpec::transform): Check for null target and return null..
(WebCore::SVGViewSpec::viewBoxAnimated): Check for null target and return null.
(WebCore::SVGViewSpec::preserveAspectRatioAnimated): Check for null target and return null.
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper): ASSERT non-null target.
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper): ASSERT non-null target.
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper): ASSERT non-null target.
- svg/SVGViewSpec.h:
(SVGViewSpec): Move some methods out of the header and into the implementation file.
- svg/SVGViewSpec.cpp:
(WebCore):
(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
- svg/SVGViewSpec.h:
(SVGViewSpec):
LayoutTests:
Test for the situation in which the target of an SVGViewSpec is
removed while the view spec lives on in JS. The test is expected to
fail on all JSC based platforms because the element that must be
deleted to trigger the results is not deleted upon GC.
- svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Added.
- svg/dom/SVGViewSpec-invalid-ref-crash.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Added.
- svg/dom/SVGViewSpec-invalid-ref-crash.html: Added.
- 9:05 AM Changeset in webkit [140974] by
-
- 27 edits1 delete in trunk
HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
https://bugs.webkit.org/show_bug.cgi?id=107650
Source/WebCore:
Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.
Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
Test: platform/mac/accessibility/definition-list-term.html:
Test: accessibility/lists.html
- English.lproj/Localizable.strings:
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isDescriptionList):
- accessibility/AccessibilityList.h:
(AccessibilityList):
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- platform/LocalizedStrings.cpp:
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListTermText):
(WebCore):
(WebCore::AXDescriptionListDetailText):
- platform/LocalizedStrings.h:
(WebCore):
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListDetailText):
(WebCore):
(WebCore::AXDescriptionListTermText):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListTermText):
(WebCore):
(WebCore::AXDescriptionListDetailText):
Source/WebKit/chromium:
Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.
Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
- public/WebAccessibilityRole.h:
- src/AssertMatchingEnums.cpp:
- src/LocalizedStrings.cpp:
(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):
Tools:
Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.
Updating accessibility strings and accessors for DL/DT/DD.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
(createDescriptionList):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
LayoutTests:
Patch by James Craig <james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.
Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
Removed gtk expectation as the expectation has changed: platform/gtk/accessibility/lists-expected.txt
- accessibility/lists.html:
- platform/gtk/accessibility/lists-expected.txt: Removed.
- platform/mac/accessibility/definition-list-term-expected.txt:
- platform/mac/accessibility/definition-list-term.html:
- platform/mac/accessibility/lists-expected.txt:
- 8:59 AM Changeset in webkit [140973] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] SpellingHandler parses and creates spellcheck requests regardless of the system spell check status
https://bugs.webkit.org/show_bug.cgi?id=108085
PR 286165
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-28
Reviewed by Rob Buis.
Internally reviewed by Nima Ghanavatian.
Adding a check for the system spell check status in InputHandler::shouldSpellCheckElement so
we won't bother sending a spellcheck request if system spell check is turned off.
However, on a fresh browser start up and on the first setElementFocus, the spellcheck value isn't defined yet.
The first spell check request is therefore necessary to connect to imf to determine whether spell check is turned on.
If spell check is turned off, we will turn spellinghandler off.
Tested the patch using a test site that contains editable text in text-areas and content-editable divs. Also tested on
an extreme test case where we try to edit a content-editable div with 30000 characters. Confirmed spell-check requests are
being canceled if system spell check is off.
In theory, this patch should also fix PR 284229 . However, because of issues with getting the system spell check values from IMF,
additional work needs to be done for that PR.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
(WebKit):
(BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- WebKitSupport/InputHandler.h:
(InputHandler):
(BlackBerry::WebKit::InputHandler::setSystemSpellCheckStatus):
- 8:58 AM Changeset in webkit [140972] by
-
- 11 edits10 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added platform specific expectations after r140728.
- platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- platform/qt/svg/custom/glyph-setting-d-attribute-expected.png:
- platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
- platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/002-expected.png:
- platform/qt/svg/hixie/viewbox/002-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/003-expected.png:
- platform/qt/svg/hixie/viewbox/003-expected.txt: Added.
- platform/qt/svg/text/text-viewbox-rescale-expected.png:
- platform/qt/svg/text/text-viewbox-rescale-expected.txt: Added.
- 8:54 AM Changeset in webkit [140971] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
https://bugs.webkit.org/show_bug.cgi?id=108086
Disabling SVG exposed a missing include in AssertMatchingEnums. This
patch adds it in.
- src/AssertMatchingEnums.cpp:
Include 'ResourceLoadPriority.h'.
- 8:44 AM Changeset in webkit [140970] by
-
- 4 edits in trunk
Tools: [GTK][WTR] Update layoutTestController.pathToLocalResource
https://bugs.webkit.org/show_bug.cgi?id=107538
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-01-28
Reviewed by Martin Robinson.
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::pathToLocalResource): Update implementation based on
DRT code.
LayoutTests: [GTK] [WTR] layoutTestController.pathToLocalResource needs to be updated
https://bugs.webkit.org/show_bug.cgi?id=107538
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-01-28
Reviewed by Martin Robinson.
- platform/gtk-wk2/TestExpectations: Remove tests that pass now:
http/tests/security/local-user-CSS-from-remote.html,
fast/loader/local-CSS-from-local.html,
fast/loader/local-JavaScript-from-local.html,
fast/loader/local-image-from-local.html and
fast/dom/frame-loading-via-document-write.html.
- 8:28 AM Changeset in webkit [140969] by
-
- 3 edits2 adds in trunk/Tools
[GTK][WTR] Move getTopLevelPath() to utilities file
https://bugs.webkit.org/show_bug.cgi?id=107541
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-01-28
Reviewed by Martin Robinson.
- WebKitTestRunner/GNUmakefile.am: Add new files.
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
- WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
(WTR):
(WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
- WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
(WTR): Add new method header and documentation.
- 8:14 AM Changeset in webkit [140968] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Inherit SidebarPane from View.
https://bugs.webkit.org/show_bug.cgi?id=108075
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-28
Reviewed by Pavel Feldman.
Inherited WebInspector.SidebarPane from WebInspector.View to streamlines the code and
simplify further enhancements to sidebar panes. Got rid of obsolete onattach calls.
No new tests.
- inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.willHide):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.wasShown):
- inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane.prototype._refreshExpressionsIfNeeded):
- 7:34 AM Changeset in webkit [140967] by
-
- 14 edits2 adds in trunk
[Freetype] Synthetic bold not applied to fallback fonts properly
https://bugs.webkit.org/show_bug.cgi?id=107733
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-28
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
No new tests. This is covered by existing pixel tests.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): When we detect a situation in which
we are a bold font, but the Fontconfig pattern does not describe the font as
bold, we should activate synthetic bolding.
LayoutTests:
- platform/gtk/fast/css/font-face-multiple-faces-expected.png:
- platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
- platform/gtk/fast/dom/34176-expected.png: Added.
- platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
- platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.png:
- platform/gtk/fast/text/cg-fallback-bolding-expected.png:
- platform/gtk/fast/text/fallback-traits-fixup-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/gtk/fast/text/international/bold-bengali-expected.png:
- platform/gtk/fast/text/international/khmer-selection-expected.png:
- platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- 4:47 AM Changeset in webkit [140966] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Regression] Search all sources should not search across service projects.
https://bugs.webkit.org/show_bug.cgi?id=108068
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
- 4:45 AM Changeset in webkit [140965] by
-
- 8 edits in trunk
Web Inspector: SourceURL and SourceMappingURL together in evalled code
https://bugs.webkit.org/show_bug.cgi?id=107939
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Resolve map's sources URLs wrt script URL in case sourceMap is defined as data:.
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
- inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL.completeURL):
- inspector/front-end/SourceMap.js:
(WebInspector.SourceMap.prototype._parseMap):
LayoutTests:
- http/tests/inspector/compiler-script-mapping-expected.txt:
- http/tests/inspector/compiler-script-mapping.html:
- 4:22 AM Changeset in webkit [140964] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][Win][WK2] Build fix after r140957.
Rubber-stamped by Csaba Osztrogonác.
<sys/wait.h> is only needed and available on linux therefore it's moved into an ifdef block.
- WebProcess/qt/WebProcessMainQt.cpp:
- 4:01 AM Changeset in webkit [140963] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Canvas] refactoring in CanvasAgent to reduce code dups
https://bugs.webkit.org/show_bug.cgi?id=108064
Reviewed by Pavel Feldman.
Introduce private methods injectedScriptCanvasModule() in InspectorCanvasAgent to reduce much of code duplication.
Drive-by: in InspectorPageAgent.assertFrame convert "String" argument to "const String&".
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::getResourceInfo):
(WebCore::InspectorCanvasAgent::getResourceState):
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModule):
(WebCore):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- 2:31 AM Changeset in webkit [140962] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_url_response
https://bugs.webkit.org/show_bug.cgi?id=107826
Reviewed by Andreas Kling.
- Shared/API/c/WKURLResponse.cpp:
(WKURLResponseGetExpectedContentsLength):
- Shared/API/c/WKURLResponse.h:
Add new WK2 C API to get the expected contents length.
- UIProcess/API/efl/ewk_url_response.cpp:
(EwkUrlResponse::EwkUrlResponse):
(EwkUrlResponse::httpStatusCode):
(EwkUrlResponse::contentLength):
- UIProcess/API/efl/ewk_url_response_private.h:
(EwkUrlResponse::create):
(EwkUrlResponse):
Change the methods to not call WebCore methods.
- 2:27 AM Changeset in webkit [140961] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][EFL] Remove unneeded private methods
https://bugs.webkit.org/show_bug.cgi?id=107693
Reviewed by Andreas Kling.
Care has been taken to verify that the wrappers can
never be null when called.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- 2:25 AM Changeset in webkit [140960] by
-
- 3 edits in trunk/Source/WebCore
Replace the type of Proximity's supplementName for char*
https://bugs.webkit.org/show_bug.cgi?id=108049
Reviewed by Benjamin Poulain.
There are some changes for supplementName by Bug 107535.
It makes build break when PROXIMITY_EVENT feature is enabled.
Therefore ProximityController need to change the type of supplementName for char* also.
No new tests. Functionality is not changed.
- Modules/proximity/DeviceProximityController.cpp:
(WebCore::DeviceProximityController::supplementName):
- Modules/proximity/DeviceProximityController.h:
(DeviceProximityController):
- 2:25 AM Changeset in webkit [140959] by
-
- 6 edits7 copies70 adds in trunk/LayoutTests
[Qt] Unreviewed rebaseline after r140821.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-28
- platform/qt/compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
- platform/qt/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
- platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
- platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
- platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.png: Added.
- platform/qt/compositing/geometry/bounds-clipped-composited-child-expected.txt: Added.
- platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Added.
- platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png:
- platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
- platform/qt/compositing/geometry/bounds-ignores-hidden-expected.txt: Added.
- platform/qt/compositing/geometry/clip-expected.txt: Added.
- platform/qt/compositing/geometry/clip-inside-expected.txt: Added.
- platform/qt/compositing/geometry/composited-in-columns-expected.png: Added.
- platform/qt/compositing/geometry/composited-in-columns-expected.txt: Added.
- platform/qt/compositing/geometry/flipped-writing-mode-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/compositing/geometry/flipped-writing-mode-expected.txt: Added.
- platform/qt/compositing/geometry/foreground-layer-expected.png: Added.
- platform/qt/compositing/geometry/foreground-layer-expected.txt: Added.
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
- platform/qt/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
- platform/qt/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/qt/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/qt/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/qt/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/qt/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/qt/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/qt/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/qt/compositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/qt/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
- platform/qt/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
- platform/qt/compositing/iframes/scrolling-iframe-expected.txt: Added.
- platform/qt/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
- platform/qt/compositing/layer-creation/animation-overlap-with-children-expected.txt: Added.
- platform/qt/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
- platform/qt/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Added.
- platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
- platform/qt/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
- platform/qt/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Added.
- platform/qt/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
- platform/qt/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/qt/compositing/layer-creation/overlap-child-layer-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
- platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
- platform/qt/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Added.
- platform/qt/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
- platform/qt/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
- platform/qt/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
- platform/qt/compositing/masks/mask-layer-size-expected.txt: Added.
- platform/qt/compositing/repaint/resize-repaint-expected.txt: Added.
- platform/qt/compositing/rtl/rtl-iframe-absolute-expected.png: Added.
- platform/qt/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
- platform/qt/compositing/rtl/rtl-iframe-fixed-expected.png: Added.
- platform/qt/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
- platform/qt/compositing/rtl/rtl-iframe-relative-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
- platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.png: Added.
- platform/qt/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
- platform/qt/compositing/tiling/huge-layer-img-expected.png: Added.
- platform/qt/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/qt/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/qt/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
- platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/qt/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
- platform/qt/compositing/tiling/tiled-layer-resize-expected.txt: Added.
- platform/qt/compositing/visibility/layer-visible-content-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/compositing/visibility/layer-visible-content-expected.txt: Added.
- platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
- platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/qt/css3/filters/filtered-compositing-descendant-expected.png: Copied from LayoutTests/platform/qt/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png.
- platform/qt/css3/filters/filtered-compositing-descendant-expected.txt: Added.
- 2:00 AM Changeset in webkit [140958] by
-
- 2 edits in trunk/Tools
[EFL] Include Ecore_Getopt.h in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=108067
Reviewed by Kenneth Rohde Christiansen.
Be explicit and include Ecore_Getopt.h since we use it for parsing
command line options. It is safer than relying on other headers
including it for us.
- MiniBrowser/efl/main.c:
- 1:54 AM Changeset in webkit [140957] by
-
- 9 edits1 copy3 adds in trunk
[WK2] Putting QtWebProcess into a chrooted sandbox
https://bugs.webkit.org/show_bug.cgi?id=90005
.:
Reviewed by Anders Carlsson and Zoltan Herczeg.
Make it possible to build WebKit2 with SandboxProcess.
- Source/QtWebKit.pro:
Source/WebKit2:
Reviewed by Anders Carlsson and Zoltan Herczeg.
This new feature makes possible to run WebProcess inside a chroot. In this case UIProcess calls the
internal SandboxProcess binary what makes up an environment for WebProcess inside the sandbox and runs the WebProcess.
SandboxProcess first creates two needed device files (random and urandom), mounts filesystems (proc and shared memory),
then links run-time dependencies of WebProcess. After this, SandboxProcess moves to a new pid namespace (cloning with
CLONE_NEWPID flag). Then after an other cloning (with CLONE_FS flag) we share our filesystem with our children. This is
needed because we want to call chroot() function from here and jail our child (WebProcess) too. This will be performed
when WebProcess sends a request for it via an socketpair. If sandboxing is done, SandboxProcess exits.
Since chroot() system call needs sudoer rights SandboxProcess binary should have set its suid flag. However we can reduce
its capabilites. First we restrict the capabilities of the process and the number of its possible resources. Furthermore
we fallback to the nobody or the real user.
- Configurations/FeatureDefines.xcconfig:
- SandboxProcess.pro: Added.
- Shared/linux/SandboxProcess/SandboxEnvironmentLinux.cpp: Added.
(launchChangeRootHelper):
(setEnvironmentVariablesForChangeRootHelper):
(prepareAndStartChangeRootHelper):
(setCapabilities):
(dropPrivileges):
(fileExists):
(directoryPermissions):
(createDirectory):
(createDirectoryPath):
(createDeviceFiles):
(mountFileSystems):
(linkFile):
(linkDirectory):
(collectRunTimeDependencies):
(setupXauthorityForNobodyUser):
(initSandbox):
(restrictCapabilities):
(moveToNewPidNamespace):
(run):
(main):
- Shared/linux/SandboxProcess/SandboxEnvironmentLinux.h: Added.
- Shared/linux/SandboxProcess/StringOperations.cpp: Added.
(stringCopy):
(stringConcat):
(stringAppend):
- Shared/linux/SandboxProcess/StringOperations.h: Added.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
- WebKit2.pri:
- WebProcess.pro:
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit):
(WebKit::chrootMe):
(WebKit::WebProcessMainQt):
Tools:
Reviewed by Anders Carlsson and Zoltan Herczeg.
Add feature flag for suid sandbox in linux.
- Scripts/webkitperl/FeatureList.pm:
- 1:49 AM Changeset in webkit [140956] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking bug2479-5.html as crashing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 1:39 AM Changeset in webkit [140955] by
-
- 3 edits in trunk/Source/WebCore
[REGRESSION] Calendar Picker focus ring is gone
https://bugs.webkit.org/show_bug.cgi?id=108055
Reviewed by Kent Tamura.
The focus ring wasn't visible because -webkit-focus-ring-color value
only works for outline property in strict mode. Using fixed color
instead.
No new tests. Can't reproduce in layout test because mock popup writes a
script tag in front of the doctype.
- Resources/pagepopups/chromium/calendarPickerChromium.css:
(.days-area-container:focus):
- Resources/pagepopups/chromium/pickerCommonChromium.css:
(:enabled:focus:-webkit-any(button, input[type='button'])):
- 1:39 AM Changeset in webkit [140954] by
-
- 3 edits in trunk/LayoutTests
Change test expectation to ensure that seamless iframes do not inherit editability.
https://bugs.webkit.org/show_bug.cgi?id=108063
Reviewed by Eric Seidel.
Seamlessly rendered documents should not inherit editability from their
parent IFrame. Currently, the test expectations don't match this
behavior. This patch trivially adjusts the expectation to ensure that
editability is _not_ inherited.
- fast/frames/seamless/seamless-inherited-document-style-expected.txt:
- fast/frames/seamless/seamless-inherited-document-style.html:
- 1:21 AM Changeset in webkit [140953] by
-
- 8 edits in trunk
Web Inspector: remove unused isElement and similar methods from HeapProfiler
https://bugs.webkit.org/show_bug.cgi?id=107940
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- Removed some unused methods.
- Moved JS specific edge filters to JSHeapSnapshot.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createEdgesProviderForTest):
(WebInspector.HeapSnapshot.prototype.retainingEdgesFilter):
(WebInspector.HeapSnapshot.prototype.containmentEdgesFilter):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshot.prototype.classNodesFilter):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):
- inspector/front-end/JSHeapSnapshot.js:
(WebInspector.JSHeapSnapshot.prototype.classNodesFilter):
(WebInspector.JSHeapSnapshot.prototype._markDetachedDOMTreeNodes):
- inspector/front-end/NativeHeapSnapshot.js:
LayoutTests:
- inspector/profiler/heap-snapshot.html:
- 1:02 AM Changeset in webkit [140952] by
-
- 3 edits3 adds in trunk/Source/WebKit2
[EFL][WK2] Rely more on C API in ewk_favicon_database
https://bugs.webkit.org/show_bug.cgi?id=108035
Reviewed by Benjamin Poulain.
Rely less on internal C++ API in ewk_favicon_database and use C API
instead of avoid breaking API layering.
- PlatformEfl.cmake:
- UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp: Added.
(WKIconDatabaseTryGetCairoSurfaceForURL): Add C API for getting the
favicon for a given page URL as a cairo_surface_t*.
- UIProcess/API/C/cairo/WKIconDatabaseCairo.h: Added.
- UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::didChangeIconForPageURL):
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::iconDataReadyForPageURL):
- 12:53 AM Changeset in webkit [140951] by
-
- 5 edits1 add in trunk/Source/WebKit/chromium
Add an API for retrieving native memory information without going through the remote inspecting protocol
https://bugs.webkit.org/show_bug.cgi?id=107651
Patch by Marja Hölttä <marja@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
- WebKit.gyp:
- public/WebDevToolsAgent.h:
(WebKit):
(WebDevToolsAgent):
- public/WebMemoryUsageInfo.h: Added.
(WebKit):
(WebKit::WebMemoryUsageInfo::WebMemoryUsageInfo):
(WebMemoryUsageInfo):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::processMemoryDistribution):
(WebKit):
- src/WebDevToolsAgentImpl.h:
(WebKit):
(WebDevToolsAgentImpl):
- 12:24 AM Changeset in webkit [140950] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r140554.
http://trac.webkit.org/changeset/140554
https://bugs.webkit.org/show_bug.cgi?id=108057
Caused tables/table-section-overflow-clip-crash.html and
bug2479-5.html to crash. (Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-28
- rendering/RenderBox.cpp:
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
- 12:05 AM Changeset in webkit [140949] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: each node in a detached DOM tree is shown in its own "detached DOM tree" entry in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=107819
Reviewed by Adam Barth.
Provide single RetainedDOMInfo for each group of DOM Node wrappers reported to GC.
Otherwise we have unequal RetainedDOMInfo groups for each wrapped node.
- bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::retainedObjectInfo):
(ImplicitConnection):
(WebCore::WrapperGrouper::addObjectToGroup):
(WrapperGrouper):
(WebCore::WrapperGrouper::addNodeToGroup):
(WebCore::WrapperGrouper::apply):
(WebCore::V8GCController::opaqueRootForGC):
- bindings/v8/V8GCController.h:
(V8GCController):
Jan 27, 2013:
- 11:24 PM Changeset in webkit [140948] by
-
- 8 edits in trunk/Source/WebCore
[CSSRegions] RenderFlowThread should keep a count of auto height regions
https://bugs.webkit.org/show_bug.cgi?id=105185
Reviewed by Julien Chaffraix.
Keep the count of auto height regions on the flow thread instead of flow thread controller.
This way, we can streamline the operations associated with the two-pass layout only to those
flow threads that have auto height regions associated.
The flow thread controller will keep a count of flow thread with auto height regions instead.
This is a performance refactoring without an expected change in behavior, therefore no new tests were added.
- rendering/FlowThreadController.cpp: Keep a count of flow threads with auto logical height regions.
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads): Check the count of auto height regions for all the flow threads.
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
Make sure that we call these methods only when we have auto logical height regions.
(WebCore::FlowThreadController::resetRegionsOverrideLogicalContentHeight):
(WebCore::FlowThreadController::markAutoLogicalHeightRegionsForLayout):
- rendering/FlowThreadController.h:
(WebCore::FlowThreadController::hasFlowThreadsWithAutoLogicalHeightRegions):
(WebCore::FlowThreadController::incrementFlowThreadsWithAutoLogicalHeightRegions):
(WebCore::FlowThreadController::decrementFlowThreadsWithAutoLogicalHeightRegions):
- rendering/RenderFlowThread.cpp: Keep a count of auto logical height regions.
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight): Iterate the region chain only if the region chain has auto height regions.
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight): Ditto.
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout): Ditto.
(WebCore::RenderFlowThread::incrementAutoLogicalHeightRegions):
(WebCore::RenderFlowThread::decrementAutoLogicalHeightRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp: Add increment/decrementAutoLogicalHeightCount to increase/decrease
the counter inside the flow thread and use them throughout the code as needed.
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
- rendering/RenderRegion.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions): Use the count of flow threads with auto height regions
instead of the count of auto height regions when deciding whether we should attempt the 2 pass layout for auto height regions.
- 10:46 PM Changeset in webkit [140947] by
-
- 5 edits in trunk/Source/JavaScriptCore
JSC: FunctionParameters are memory hungry.
<http://webkit.org/b/108033>
<rdar://problem/13094803>
Reviewed by Sam Weinig.
Instead of inheriting from Vector<Identifier>, make FunctionParameters a simple fixed-size array
with a custom-allocating create() function. Removes one step of indirection and cuts memory usage
roughly in half.
2.73 MB progression on Membuster3.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(FunctionParameters):
(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):
- 10:38 PM Changeset in webkit [140946] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking two fast/forms tests as slow on debug mac.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 10:34 PM Changeset in webkit [140945] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSC: SourceProviderCache is memory hungry.
<http://webkit.org/b/108029>
<rdar://problem/13094806>
Reviewed by Sam Weinig.
Use fixed-size arrays for SourceProviderCacheItem's lists of captured variables.
Since the lists never change after the object is created, there's no need to keep them in Vectors
and we can instead create the whole cache item in a single allocation.
13.37 MB progression on Membuster3.
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- parser/Parser.h:
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):
- parser/SourceProviderCacheItem.h:
(SourceProviderCacheItemCreationParameters):
(SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::~SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::create):
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
- 10:15 PM Changeset in webkit [140944] by
-
- 3 edits2 adds in trunk
[Shadow DOM] Selecting a node to another node in ShadowDOM fires 'click' event unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=107233
Reviewed by Dimitri Glazkov.
Source/WebCore:
When selecting from a node to another node in ShadowDOM, 'click' event is unexpectedly fired.
The root cause of the bug is using shadow ancestor nodes for checking the node mouse is pressed on
and the node mouse is released on is the same. This was introduced to fire a click event for a slider
in <input> or etc.
However, we don't need to check shadow ancestor if we're in Author ShadowDOM.
Test: fast/dom/shadow/selecting-anchor.html
- page/EventHandler.cpp:
(WebCore::mouseIsReleasedOnPressedElement):
(WebCore):
(WebCore::EventHandler::handleMouseReleaseEvent):
LayoutTests:
- fast/dom/shadow/select-in-shadowdom-expected.txt: Added.
- fast/dom/shadow/select-in-shadowdom.html: Added.
- 9:24 PM Changeset in webkit [140943] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking storage/indexeddb tests as crashing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 9:15 PM Changeset in webkit [140942] by
-
- 2 edits in trunk/Source/WTF
[ANDROID] Fix a typo
https://bugs.webkit.org/show_bug.cgi?id=108046
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-27
Reviewed by Adam Barth.
HAVE_NMAP -> HAVE_MMAP.
- wtf/Platform.h:
- 9:10 PM Changeset in webkit [140941] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking media/track tests as crashing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 9:02 PM Changeset in webkit [140940] by
-
- 2 edits in trunk/Source/WebKit2
Fix location of sandbox profiles in built products
https://bugs.webkit.org/show_bug.cgi?id=108026
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj: Sandbox profiles go into WebKit2 framework resources.
- 8:22 PM Changeset in webkit [140939] by
-
- 8 edits in trunk
REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
https://bugs.webkit.org/show_bug.cgi?id=108028
Patch by David Farler <dfarler@apple.com> on 2013-01-27
Reviewed by Dan Bernstein.
.:
- Makefile: Reverted.
- Makefile.shared: Reverted.
- Source/Makefile: Reverted.
Tools:
- DumpRenderTree/Makefile: Reverted.
- Makefile: Reverted.
- Scripts/webkitdirs.pm: Reverted.
- 8:06 PM Changeset in webkit [140938] by
-
- 7 edits in trunk/Source/WebCore
An [ActiveDOMObject] IDL attribute should be inherited
https://bugs.webkit.org/show_bug.cgi?id=107877
Reviewed by Adam Barth.
Now we support IDL attribute inheritance. We can remove
[ActiveDOMObject] from subclasses.
No tests. No change in behavior.
- Modules/indexeddb/IDBOpenDBRequest.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- workers/SharedWorker.idl:
- workers/Worker.idl:
- 7:08 PM Changeset in webkit [140937] by
-
- 28 edits3 copies in trunk
Unreviewed, rolling out r140602.
http://trac.webkit.org/changeset/140602
https://bugs.webkit.org/show_bug.cgi?id=108045
Caused 8 indexed tests to crash. (Requested by keishi on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-27
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onBlocked):
- Modules/indexeddb/IDBDatabase.cpp:
- Modules/indexeddb/IDBDatabase.h:
(WebCore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBFactory.h:
(WebCore):
(IDBFactory):
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::dispatchEvent):
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
- Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
(WebCore):
(WebCore::IDBVersionChangeRequest::create):
(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest):
(WebCore::IDBVersionChangeRequest::interfaceName):
(WebCore::IDBVersionChangeRequest::onBlocked):
- Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl.
(WebCore):
(IDBVersionChangeRequest):
- Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/Modules/indexeddb/IDBFactory.idl.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventTarget.h:
(WebCore):
- dom/EventTargetFactory.in:
Source/WebKit/chromium:
- public/WebIDBCallbacks.h:
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onBlocked):
(WebKit):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onBlocked):
(WebKit):
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp:
(WebCore::MockIDBCallbacks::onBlocked):
- tests/IDBDatabaseBackendTest.cpp:
LayoutTests:
- storage/indexeddb/intversion-long-queue-expected.txt:
- storage/indexeddb/intversion-upgrades-expected.txt:
- 6:47 PM Changeset in webkit [140936] by
-
- 3 edits2 adds in trunk
Disabled input/textarea doesn't trigger selection change
https://bugs.webkit.org/show_bug.cgi?id=85244
Reviewed by Ryosuke Niwa.
Source/WebCore:
Only rootEditableNode is there in <input> or <textarea>, 'select' event is fired.
Since readonly or disabled input/textarea element does not have editable element,
'select' event was not fired.
We don't need the check.
Test: fast/forms/input-readonly-select.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::notifyRendererOfSelectionChange):
LayoutTests:
- fast/forms/input-readonly-select-expected.txt: Added.
- fast/forms/input-readonly-select.html: Added.
- 6:32 PM Changeset in webkit [140935] by
-
- 14 edits in trunk/Source
Unreviewed, rolling out r140850.
http://trac.webkit.org/changeset/140850
https://bugs.webkit.org/show_bug.cgi?id=107960
r14602 caused 8 indexed tests to crash.
Source/WebCore:
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::OpenCursorOperation::perform):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
(WebCore::IDBRequest::taskType):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
- Modules/indexeddb/IDBTransactionBackendInterface.h:
(IDBTransactionBackendInterface):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- 6:20 PM Changeset in webkit [140934] by
-
- 31 edits3 copies3 deletes in trunk
Unreviewed, rolling out r140741.
http://trac.webkit.org/changeset/140741
https://bugs.webkit.org/show_bug.cgi?id=108044
Caused 8 indexed tests to fail on Mac and Win. (Requested by
keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-27
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::onVersionChange):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/IDBUpgradeNeededEvent.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp.
(WebCore):
(WebCore::IDBUpgradeNeededEvent::create):
(WebCore::IDBUpgradeNeededEvent::IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::~IDBUpgradeNeededEvent):
(WebCore::IDBUpgradeNeededEvent::oldVersion):
(WebCore::IDBUpgradeNeededEvent::newVersion):
(WebCore::IDBUpgradeNeededEvent::interfaceName):
- Modules/indexeddb/IDBUpgradeNeededEvent.h: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h.
(WebCore):
(IDBUpgradeNeededEvent):
- Modules/indexeddb/IDBUpgradeNeededEvent.idl: Copied from Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl.
- Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
(WebCore::IDBVersionChangeEvent::version):
(WebCore):
- Modules/indexeddb/IDBVersionChangeEvent.h:
(WebCore):
(IDBVersionChangeEvent):
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- WebCore.gypi:
- dom/EventNames.in:
LayoutTests:
- storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
- storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-blocked-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:
- storage/indexeddb/deletedatabase-delayed-by-versionchange-expected.txt:
- storage/indexeddb/deletedatabase-not-blocked-expected.txt:
- storage/indexeddb/events-expected.txt: Removed.
- storage/indexeddb/events.html: Removed.
- storage/indexeddb/intversion-gated-on-delete-expected.txt:
- storage/indexeddb/intversion-long-queue-expected.txt:
- storage/indexeddb/removed-expected.txt:
- storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
(versionChangeCallback):
- storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js:
(versionChangeCallback):
- storage/indexeddb/resources/deletedatabase-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
- storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(prepareDatabase.h.onversionchange):
- storage/indexeddb/resources/deletedatabase-delayed-by-versionchange.js:
(h1OpenSuccess.h1.onversionchange):
(h1OpenSuccess.request.onsuccess.h2OpenSuccess.h2.onversionchange):
- storage/indexeddb/resources/deletedatabase-not-blocked.js:
(test.request.onsuccess.openOnSuccess.h.onversionchange):
- storage/indexeddb/resources/events.js: Removed.
- storage/indexeddb/resources/intversion-gated-on-delete.js:
(firstSuccessCallback):
(connection1VersionChangeCallback):
- storage/indexeddb/resources/intversion-long-queue.js:
(connection1VersionChangeCallback):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2VersionChangeEvent):
- storage/indexeddb/resources/removed.js:
(test):
- 6:08 PM Changeset in webkit [140933] by
-
- 9 edits2 moves in trunk/LayoutTests
[Chromium] Rebaselining overflow-size-change* tests.
Unreviewed. Gardening.
- platform/chromium-mac-lion/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
- platform/chromium-mac-lion/fast/regions/overflow-size-change-with-stacking-context-expected.png:
- platform/chromium-mac-snowleopard/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
- platform/chromium-mac-snowleopard/fast/regions/overflow-size-change-with-stacking-context-expected.png:
- platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
- platform/chromium-mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Renamed from LayoutTests/platform/chromium/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt.
- platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.png:
- platform/chromium-mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium/fast/regions/overflow-size-change-with-stacking-context-expected.txt.
- platform/chromium-win/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
- platform/chromium-win/fast/regions/overflow-size-change-with-stacking-context-expected.png:
- 6:00 PM Changeset in webkit [140932] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Attempt to fix expectation entry.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 5:55 PM Changeset in webkit [140931] by
-
- 3 edits4 adds in trunk
Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489
Relanding r139402 as the apparent perf regression has been explained as not real (bug 106726).
Reviewed by Julien Chaffraix.
Source/WebCore:
Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.
We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.
Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html
fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html
- dom/Element.cpp:
(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.
LayoutTests:
- fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
- fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.
This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).
- fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
- fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.
This tests that top layer ordering is correct after removing and readding an element to the top layer.
- 4:26 PM Changeset in webkit [140930] by
-
- 15 edits in trunk
Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
https://bugs.webkit.org/show_bug.cgi?id=106740
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-27
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- config.h:
Source/WebCore:
- WebCorePrefix.h:
- config.h:
Source/WebKit/win:
- WebKitPrefix.h:
Source/WebKit2:
- config.h:
Source/WTF:
Adding int64_t type atomicIncrement and atomicDecrement implementations for Windows
into Atomics.h required by WebKit2 after r139514. Separating WinCE implementation
that does not support WebKit2 and has no support for 64 bit interlocked methods.
Increasing WINVER and _WIN32_WINNT to XP SP2, because the 64 bit type interlocked methods
are not supported on previous versions on 32 bit target.
- config.h:
- wtf/Atomics.h:
(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):
Tools:
- DumpRenderTree/config.h:
- WinLauncher/stdafx.h:
- 1:53 PM Changeset in webkit [140929] by
-
- 4 edits8 copies6 adds in trunk/Source/WebKit2
Add support for launching WebKit2 plugins using XPC
https://bugs.webkit.org/show_bug.cgi?id=108040
Reviewed by Dan Bernstein.
- Configurations/PluginService.32.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
- Configurations/PluginService.64.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
- Configurations/PluginService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
Add configurations.
- PluginProcess/EntryPoint/mac/XPCService: Added.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Added.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Added.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development: Added.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist: Added.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Added.
(main):
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm.
(initializePluginService):
Add entry points.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
Add plugin process service names and move into correct #ifdef.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
Opt into xpc using the same rules as the WebProcess.
- WebKit2.xcodeproj/project.pbxproj:
Add files.
- 1:04 PM Changeset in webkit [140928] by
-
- 4 edits2 adds in trunk
[chromium] add missing plumbing for Notification.requestPermission
https://bugs.webkit.org/show_bug.cgi?id=108012
Reviewed by Adam Barth.
Source/WebKit/chromium:
- src/NotificationPresenterImpl.cpp:
(WebKit):
(WebKit::VoidCallbackClient::VoidCallbackClient):
(NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
(WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
(WebKit::NotificationPresenterImpl::requestPermission):
- src/NotificationPresenterImpl.h:
(NotificationPresenterImpl):
LayoutTests:
- fast/notifications/notifications-constructor-request-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-request-permission.html: Added.
- 6:12 AM EFLWebKit edited by
- (diff)
- 6:08 AM EFLWebKit edited by
- (diff)
- 5:53 AM EFLWebKit edited by
- (diff)
- 5:30 AM EFLWebKit edited by
- Add g++ to dependencies (diff)
- 2:58 AM Changeset in webkit [140927] by
-
- 3 edits4 adds in trunk
Check notification permissions in the show() method
https://bugs.webkit.org/show_bug.cgi?id=108009
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/notifications/notifications-constructor-with-permission.html
fast/notifications/notifications-constructor-without-permission.html
- Modules/notifications/Notification.cpp:
(WebCore::Notification::show):
(WebCore::Notification::taskTimerFired):
LayoutTests:
- fast/notifications/notifications-constructor-with-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-with-permission.html: Added.
- fast/notifications/notifications-constructor-without-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-without-permission.html: Added.
Jan 26, 2013:
- 11:02 PM Changeset in webkit [140926] by
-
- 6 edits2 deletes in trunk/Source/WebKit2
Use shared ChildProcess code to enter plug-in sandbox.
Reviewed by Sam Weinig.
There is one known behavior change from this refactoring: getpwuid_r is used
instead of NSHomeDirectory for home directory, mathcing other client processes.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::enterSandbox):
- PluginProcess/PluginProcess.h: PluginProcess prevents ChildProcess attempt to enter the sandbox immediately on launch for now, because we don't have a sandbox profile directory path yet. It now keeps a copy of ChildProcessInitializationParameters, so that ChildProcess::initializeSandbox() could be called later.
- PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitializeProcess): Store a copy of ChildProcessInitializationParameters for later. (WebKit::loadSandboxProfile): Build a sandbox profile from a common prefix and a plugin-specific part. (WebKit::PluginProcess::platformInitializePluginProcess): We can enter the sandbox now. (WebKit::PluginProcess::enterSandbox): Prepare SandboxInitializationParameters, and call ChildProcess::initializeSandbox().
- Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Actually handle system directory suffix from parameters.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h: Removed.
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Removed.
- 10:39 PM Changeset in webkit [140925] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Don't use goma to preprocess bindings idl files
https://bugs.webkit.org/show_bug.cgi?id=107984
Reviewed by Adam Barth.
On Linux and Mac, use a local gcc or clang to preprocess the bindings idl files.
On my machine, this drops the bindings generation from 137s to 24s when
using goma and -j400.
No new tests, this is a build change.
- WebCore.gyp/WebCore.gyp: Force the use of the local gcc or clang for preprocessing.
- 9:32 PM Changeset in webkit [140924] by
-
- 7 edits7 copies3 adds in trunk/Source/WebKit2
Add support for running the networking process as an XPCService
https://bugs.webkit.org/show_bug.cgi?id=108025
Reviewed by Dan Bernstein.
- Configurations/NetworkService.Development.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.Development.xcconfig.
- Configurations/NetworkService.xcconfig: Copied from Source/WebKit2/Configurations/WebContentService.xcconfig.
Add configurations.
- NetworkProcess/EntryPoint/mac/XPCService: Added.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService: Added.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development: Added.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm.
(initializeNetworkService):
Add entry points.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
(WebKit::connectToServiceForDevelopment):
(WebKit::createServiceForDevelopment):
(WebKit::createService):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):
Rework service creation to work for arbitrary services.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Opt into xpc using the same rules as the WebProcess.
- WebKit2.xcodeproj/project.pbxproj:
Update files.
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(initializeWebContentService):
Fix the comment to refer to the shim correctly.
- 8:30 PM Changeset in webkit [140923] by
-
- 31 edits3 deletes in trunk
Unreviewed, rolling out r140880.
http://trac.webkit.org/changeset/140880
https://bugs.webkit.org/show_bug.cgi?id=108023
Caused mathml/presentation and tests to crash and fail
(Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-26
Source/WebCore:
- mathml/MathMLTextElement.cpp:
- mathml/MathMLTextElement.h:
(MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):
- rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
- rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore):
(WebCore::RenderMathMLRoot::layout):
- rendering/mathml/RenderMathMLRoot.h:
(RenderMathMLRoot):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):
- rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
LayoutTests:
- mathml/differentiable-manifold.html: Removed.
- platform/chromium-linux/mathml/differentiable-manifold-expected.png: Removed.
- platform/chromium-linux/mathml/differentiable-manifold-expected.txt: Removed.
- platform/chromium-linux/mathml/presentation/fenced-expected.txt:
- platform/chromium-linux/mathml/presentation/fenced-mi-expected.png:
- platform/chromium-linux/mathml/presentation/fenced-mi-expected.txt:
- platform/chromium-linux/mathml/presentation/mo-expected.txt:
- platform/chromium-linux/mathml/presentation/mo-stretch-expected.png:
- platform/chromium-linux/mathml/presentation/mo-stretch-expected.txt:
- platform/chromium-linux/mathml/presentation/over-expected.txt:
- platform/chromium-linux/mathml/presentation/row-alignment-expected.txt:
- platform/chromium-linux/mathml/presentation/row-expected.png:
- platform/chromium-linux/mathml/presentation/row-expected.txt:
- platform/chromium-linux/mathml/presentation/sub-expected.png:
- platform/chromium-linux/mathml/presentation/sub-expected.txt:
- platform/chromium-linux/mathml/presentation/subsup-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 5:36 PM Changeset in webkit [140922] by
-
- 2 edits in trunk/Source/WebKit2
Simplify environment creation in XPC service re-exec
https://bugs.webkit.org/show_bug.cgi?id=108017
Reviewed by Dan Bernstein.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:
(WebKit::XPCServiceEventHandler):
There is no need to copy these strings.
- 5:01 PM Changeset in webkit [140921] by
-
- 24 edits1 delete in trunk/Source
Remove code for handling NetworkProcess authentication challenges in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=108003
Reviewed by Sam Weinig.
- 4:53 PM Changeset in webkit [140920] by
-
- 2 edits in trunk/Source/WebKit2
Fix the development build.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:
(WebKit::XPCServiceEventHandler):
Use the right stringizer.
- 4:40 PM Changeset in webkit [140919] by
-
- 4 edits1 move2 adds1 delete in trunk/Source/WebKit2
Refactor XPCService initialization to make it easier to add more services
https://bugs.webkit.org/show_bug.cgi?id=108015
Reviewed by Dan Bernstein.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Added.
(WebKit::XPCServiceEventHandler):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Added.
(WebKit::XPCServiceEventHandler):
Move bootstrapping to Shared (like we have for the legacy process). For now, we use
a macro to define the actual initialization point function to use, in the future, we
could consider alternatives, such as getting the function name from the bundle.
- WebKit2.xcodeproj/project.pbxproj:
Update files.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:
Simplify to use the new XPCServiceBootstrapper.
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessServiceEntryPoints.mm.
(initializeWebContentService):
- WebProcess/mac/WebProcessServiceEntryPoints.h: Removed.
- WebProcess/mac/WebProcessServiceEntryPoints.mm: Removed.
Move the entry point to where it belongs and extract the bootstrapping parts.
- 4:09 PM Changeset in webkit [140918] by
-
- 2 edits in trunk/Source/WebCore
Fix the test for CHANNEL_MESSAGING in idl files
https://bugs.webkit.org/show_bug.cgi?id=108006
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-01-26
Reviewed by Alexey Proskuryakov.
No new tests, this is a build fix.
- workers/WorkerContext.idl: Make sure ENABLE_CHANNEL_MESSAGING is
defined before using it to be consitent with other guards inside idl
files.
- 2:55 PM Changeset in webkit [140917] by
-
- 2 edits in trunk/Source/WTF
Unreviewed fix after r140451 to make GIT-SVN repositories happy.
- WTF.vcproj/WTF.sln:
- 2:24 PM Changeset in webkit [140916] by
-
- 2 edits in trunk/Source/WebKit2
[Qt]Qt build fix
https://bugs.webkit.org/show_bug.cgi?id=108013
Changes on process initialization classes broke webkit building with Qt5. This
patch fix it.
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-01-26
Reviewed by Sam Weinig.
- PluginProcess/qt/PluginProcessMainQt.cpp:
- 12:15 PM Changeset in webkit [140915] by
-
- 6 edits in trunk/Source/WebKit2
Hoist command line parsing into ChildProcessMain
https://bugs.webkit.org/show_bug.cgi?id=108010
Reviewed by Dan Bernstein.
- NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:
(NetworkProcessMain):
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(PluginProcessMain):
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h:
(WebKit::ChildProcessMain):
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:
(SharedWorkerProcessMain):
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebContentProcessMain):
- 11:44 AM Changeset in webkit [140914] by
-
- 6 edits10 moves18 adds6 deletes in trunk/Source/WebKit2
Move LegacyProcess entry points into new EntryPoint directories
https://bugs.webkit.org/show_bug.cgi?id=108008
Reviewed by Anders Carlsson.
Also refactors to remove the need for the overly general WebKitMain, by putting the
framework lazy loading into a helper function each legacy process can call (in ChildProcessMainBootstrapper.h)
- Configurations/NetworkProcess.xcconfig:
- Configurations/PluginProcess.xcconfig:
- Configurations/SharedWorkerProcess.xcconfig:
- Configurations/WebProcess.xcconfig:
- NetworkProcess/EntryPoint: Added.
- NetworkProcess/EntryPoint/mac: Added.
- NetworkProcess/EntryPoint/mac/LegacyProcess: Added.
- NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/NetworkProcess/Info.plist.
- NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm: Copied from Source/WebKit2/NetworkProcess/mac/NetworkProcessMainMac.mm.
(NetworkProcessMain):
- NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Added.
(main):
- NetworkProcess/Info.plist: Removed.
- NetworkProcess/NetworkProcessMain.h: Removed.
- NetworkProcess/mac/NetworkProcessMainMac.mm: Removed.
- PluginProcess/EntryPoint: Added.
- PluginProcess/EntryPoint/mac: Added.
- PluginProcess/EntryPoint/mac/LegacyProcess: Added.
- PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/PluginProcess/Info.plist.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm: Copied from Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm.
(PluginProcessMain):
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Added.
(main):
- PluginProcess/Info.plist: Removed.
- PluginProcess/PluginProcessMain.h: Removed.
- PluginProcess/mac/PluginProcessMainMac.mm: Removed.
- Shared/EntryPointUtilities: Added.
- Shared/EntryPointUtilities/mac: Added.
- Shared/EntryPointUtilities/mac/LegacyProcess: Added.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Copied from Source/WebKit2/Shared/mac/ChildProcessMain.h.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Copied from Source/WebKit2/Shared/mac/ChildProcessMain.mm.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Added.
(closeUnusedFileDescriptors):
(getBootstrapMainFunction):
- Shared/EntryPointUtilities/mac/XPCService: Added.
- Shared/mac/ChildProcessMain.h: Removed.
- Shared/mac/ChildProcessMain.mm: Removed.
- SharedWorkerProcess/EntryPoint: Added.
- SharedWorkerProcess/EntryPoint/mac: Added.
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess: Added.
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/SharedWorkerProcess/Info.plist.
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm: Copied from Source/WebKit2/SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm.
(SharedWorkerProcessMain):
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Added.
(main):
- SharedWorkerProcess/Info.plist: Removed.
- SharedWorkerProcess/SharedWorkerProcessMain.h: Removed.
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm.
(WebKit::WebContentProcessMainDelegate::WebContentProcessMainDelegate):
(WebKit):
(WebContentProcessMain):
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Added.
(main):
- WebProcess/Info.plist: Removed.
- WebProcess/WebKitMain.cpp: Removed.
- WebProcess/WebProcessMain.h: Removed.
- WebProcess/mac/WebProcessMainMac.mm: Removed.
- mac/MainMacProcess.cpp: Removed.
- 11:29 AM Changeset in webkit [140913] by
-
- 2 edits in trunk/Source/WebCore
Text Autosizing: simplify and clean-up preOrderTraversal skipping containers
https://bugs.webkit.org/show_bug.cgi?id=107446
Patch by Tim Volodine <timvolodine@chromium.org> on 2013-01-26
Reviewed by Julien Chaffraix.
Simplify nextInPreOrderSkippingDescendantsOfContainers implementation
using RenderObject tree traversal methods.
No new tests because functionality is unchanged.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::nextInPreOrderSkippingDescendantsOfContainers):
- 8:34 AM Changeset in webkit [140912] by
-
- 8 edits in trunk
.: Allow building with arbitrary SDK and ARCHS with make + Xcode
https://bugs.webkit.org/show_bug.cgi?id=107863
Patch by David Farler <dfarler@apple.com> on 2013-01-26
Reviewed by David Kilzer.
- Makefile:
Removed references to legacy Xcode configurations.
- Makefile.shared:
Added default ARCHS + SDK settings and parameterized xcodebuild calls.
- Source/Makefile:
iOS does not build WebKit2.
Tools: Makefiles should work for arbitrary SDKs and architectures on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=107863
Patch by David Farler <dfarler@apple.com> on 2013-01-26
Reviewed by David Kilzer.
- Makefile:
Added temporary filters for projects not yet building on iOS.
- DumpRenderTree/Makefile:
Building with iOS SDKs -> -target All-iOS
- Scripts/webkitdirs.pm:
(determineConfiguration):
Added --configuration switch detection.
(determineArchitecture):
Added --architecture and ARCH=(.*) switch detection.
(argumentsForConfiguration):
(determineXcodeSDK):
Look for --device, --simulator, and --sdk switches.
(xcodeSDK):
Added.
(XcodeOptions):
Determine Xcode SDK and generate -arch switches.
- 8:08 AM Changeset in webkit [140911] by
-
- 2 edits in trunk/Source/WebCore
[v8] prepare SerializedScriptValue for transition to Latin-1
https://bugs.webkit.org/show_bug.cgi?id=107655
Patch by Dan Carney <dcarney@google.com> on 2013-01-26
Reviewed by Kentaro Hara.
No new tests. Covered by existing tests.
- bindings/v8/SerializedScriptValue.cpp:
- 2:01 AM Changeset in webkit [140910] by
-
- 4 edits in trunk/Source
[CHROMIUM] Suppress more c4267 build warnings for Win64 targets
https://bugs.webkit.org/show_bug.cgi?id=107993
Source/WebCore:
No new tests. No behavior change.
Reviewed by Abhishek Arya.
- WebCore.gyp/WebCore.gyp:
Source/WTF:
Reviewed by Abhishek Arya.
- WTF.gyp/WTF.gyp:
- 1:51 AM Changeset in webkit [140909] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r139078.
- WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):
- 1:51 AM Changeset in webkit [140908] by
-
- 2 edits in trunk/Source/WebCore
Build fix for USE(JSC) && !ENABLE(WORKERS) after r136686.
- bindings/js/DOMRequestState.h:
(WebCore::DOMRequestState::DOMRequestState):
- 1:36 AM Changeset in webkit [140907] by
-
- 3 edits4 adds in trunk
REGRESSION(r120616): Cell's logical height wrongly computed with vertical-align: baseline and rowspan
https://bugs.webkit.org/show_bug.cgi?id=106571
Reviewed by Julien Chaffraix.
Source/WebCore:
When a cell spans multiple rows, its baseline is set on the first row it spans. r120616 contained a
couple of errors in its attempt to ensure the row height calculated in such cases was correct. When it
calculated the baseline on the first row in the span, it didn't ensure that the row height was increased
if necessary. It also suffered from allowing the baseline descent calculated on a rowspan to affect the
height of the other cells in the first row of the span.
Fix both of these errors in calcRowLogicalHeight() and refactor the calculation of the baseline and baseline
descent so that it is freestanding (rather than depending on the height of the section so far).
Tests: fast/css/vertical-align-baseline-rowspan-010.html
fast/css/vertical-align-baseline-rowspan-011.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
- fast/css/vertical-align-baseline-rowspan-010-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-010.html: Added.
- fast/css/vertical-align-baseline-rowspan-011-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-011.html: Added.
- 12:13 AM Changeset in webkit [140906] by
-
- 6 edits in trunk/Source
[chromium] Export ResourceRequest's priority through WebURLRequest
https://bugs.webkit.org/show_bug.cgi?id=107985
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebURLRequest.h:
(WebURLRequest):
Source/WebCore:
No new tests.
- platform/chromium/support/WebURLRequest.cpp:
(WebKit::WebURLRequest::priority):
(WebKit):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
