Timeline



Feb 13, 2013:

11:51 PM Changeset in webkit [142855] by hayato@chromium.org
  • 21 edits
    22 adds in trunk

[Shadow DOM] Implements a '::distributed()' pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=82169

Reviewed by Dimitri Glazkov.

Source/WebCore:

Implements a '::distributed()' pseudo element.
See the Shadow DOM specification and the filed bug for the detail.

For example, suppose we are given the following DOM tree and shadow tree:

  • <A>
    • <B>
      • <C>

[A's ShadowRoot]

<D>

  • <style>

E content::distributed(B C) { color: green; }

  • <E>
    • <content> (Node B is distributed to this insertion point.)

In this case, the style rule defined in the shadow tree matches node 'C'.

A '::distributed()' pseudo element can not be a pseudo class since
an intersection between matched_elements(some_selector) and
matched_elements(some_selector::distributed(...)) is always an
empty set. A '::distributed()' pseudo element is the first-ever
*functional* pseudo element which takes a parameter, which can be
a selector.

This rule crosses the shadow boundary from a shadow tree to the
tree of its shadow host. That means a rule which includes
'::distributed()' pseudo element is defined in shadow tree, but
the node which is matched in the rule, the subject of the
selector, is outside of the shadow tree. Therefore, we cannot
predict where the subject of the selector will be beforehand.
Current CSS implementation assumes the subject of the selector
must exist in the current scope.

To overcome this issue, DocumentRuleSets now has a instance of
ShadowDistributedRules class. A style rule will be stored in this
instance if the rule includes a '::distributed()' pseudo element.
This class also keeps track of each RuleSet by mapping it with a
scope where the rule was originally defined. In the example, the
scope is A's ShadowRoot. The scope is used to check whether the
left-most matched element (in the example, it's a node 'E') exists
in the scope.

Internally, a '::distributed' pseudo element is represented by a
newly introduced 'ShadowDistributed' relation. That makes an
implementation of SelectorChecker::checkSelector() much simpler.
A transformation from a distributed pseudo element to a
ShadowDistributed is done in parsing stage of CSS.

Since '::distributed()' is an experimental feature, it's actually
prefixed with '-webkit-' and guarded by SHADOW_DOM flag.

Tests: fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html

fast/dom/shadow/distributed-pseudo-element-match-all.html
fast/dom/shadow/distributed-pseudo-element-match-descendant.html
fast/dom/shadow/distributed-pseudo-element-nested.html
fast/dom/shadow/distributed-pseudo-element-no-match.html
fast/dom/shadow/distributed-pseudo-element-reprojection.html
fast/dom/shadow/distributed-pseudo-element-scoped.html
fast/dom/shadow/distributed-pseudo-element-support-selector.html
fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html
fast/dom/shadow/distributed-pseudo-element-with-any.html
fast/dom/shadow/distributed-pseudo-element.html

  • css/CSSGrammar.y.in:

CSS Grammar was updated to support '::distrbuted(selector)'.
This pseudo element is the first pseudo element which can take a selector as a parameter.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Here we are converting a '::distributed' pseudo element into a
ShadowDistributed relation internally. To support the conversion,
these rewriteSpecifiersXXX functions (formally called
updateSpecifiersXXX) now return the specifiers which may be
converted.
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParser.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):

  • css/CSSParserValues.h:

(CSSParserSelector):
(WebCore::CSSParserSelector::functionArgumentSelector):
To hold an intermediate selector which appears at the position of an argument in
functional pseudo element when parsing CSS.
(WebCore::CSSParserSelector::setFunctionArgumentSelector):
(WebCore::CSSParserSelector::isDistributedPseudoElement):

  • css/CSSSelector.cpp:

Add new pseudo element, PseudoDistributed, and its internal representation, ShadowDistributed relation.
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(CSSSelector):
(WebCore):
(WebCore::CSSSelector::isDistributedPseudoElement):
(WebCore::CSSSelector::isShadowDistributed):

  • css/CSSSelectorList.cpp:

(WebCore):
(SelectorHasShadowDistributed):
(WebCore::SelectorHasShadowDistributed::operator()):
(WebCore::CSSSelectorList::hasShadowDistributedAt):

  • css/CSSSelectorList.h:

(CSSSelectorList):

  • css/DocumentRuleSets.cpp:

(WebCore):
(WebCore::ShadowDistributedRules::addRule):
Every CSS rule which includes '::distributed(...)' should be managed by calling this function.
(WebCore::ShadowDistributedRules::collectMatchRequests):
(WebCore::DocumentRuleSets::resetAuthorStyle):

  • css/DocumentRuleSets.h:

(WebCore):
(ShadowDistributedRules):
(WebCore::ShadowDistributedRules::clear):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::shadowDistributedRules)
DocumentRuleSets owns an instance of ShadowDistributedRules.

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):
Updated to check whether the rule contains '::distributed()' or not.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
Support ShadowDistributed relation. Check all possible insertion points where a node is distributed.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
Adds enum of BehaviorAtBoundary. '::distributed()' is the only
rule which uses 'CrossedBoundary' since it is the only rule which
crosses shadow boundaries.
(SelectorCheckingContext):

  • css/SelectorFilter.cpp:

(WebCore::SelectorFilter::collectIdentifierHashes):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::ruleMatches):

  • css/StyleResolver.h:

(MatchRequest):
(WebCore::MatchRequest::MatchRequest): Add behaviorAtBoundary field.
(WebCore):
(StyleResolver):

  • html/shadow/InsertionPoint.cpp:

(WebCore::collectInsertionPointsWhereNodeIsDistributed):
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore):

LayoutTests:

  • fast/dom/shadow/distributed-pseudo-element-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-for-shadow-element-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-all-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-all.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-descendant-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-descendant.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-nested-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-nested.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-no-match-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-no-match.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-reprojection-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-reprojection.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-scoped-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-scoped.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-support-selector-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-support-selector.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-used-in-selector-list-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-with-any-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-with-any.html: Added.
  • fast/dom/shadow/distributed-pseudo-element.html: Added.
11:41 PM Changeset in webkit [142854] by gman@chromium.org
  • 1 edit
    126 adds in trunk/LayoutTests

Add WebGL Conformance Tests more folder.
https://bugs.webkit.org/show_bug.cgi?id=109118

Reviewed by Kenneth Russell.

  • webgl/conformance/more/conformance/constants-expected.txt: Added.
  • webgl/conformance/more/conformance/constants.html: Added.
  • webgl/conformance/more/conformance/getContext-expected.txt: Added.
  • webgl/conformance/more/conformance/getContext.html: Added.
  • webgl/conformance/more/conformance/methods-expected.txt: Added.
  • webgl/conformance/more/conformance/methods.html: Added.
  • webgl/conformance/more/conformance/webGLArrays-expected.txt: Added.
  • webgl/conformance/more/conformance/webGLArrays.html: Added.
  • webgl/conformance/more/functions/bindBuffer-expected.txt: Added.
  • webgl/conformance/more/functions/bindBuffer.html: Added.
  • webgl/conformance/more/functions/bindBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bindBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/bindFramebufferLeaveNonZero-expected.txt: Added.
  • webgl/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
  • webgl/conformance/more/functions/bufferData-expected.txt: Added.
  • webgl/conformance/more/functions/bufferData.html: Added.
  • webgl/conformance/more/functions/bufferSubData-expected.txt: Added.
  • webgl/conformance/more/functions/bufferSubData.html: Added.
  • webgl/conformance/more/functions/bufferSubDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferSubDataBadArgs.html: Added.
  • webgl/conformance/more/functions/isTests-expected.txt: Added.
  • webgl/conformance/more/functions/isTests.html: Added.
  • webgl/conformance/more/functions/isTestsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/isTestsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixels-expected.txt: Added.
  • webgl/conformance/more/functions/readPixels.html: Added.
  • webgl/conformance/more/functions/texImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2D.html: Added.
  • webgl/conformance/more/functions/texImage2DHTMLBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2D.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTMLBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformMatrix-expected.txt: Added.
  • webgl/conformance/more/functions/uniformMatrix.html: Added.
  • webgl/conformance/more/functions/uniformMatrixBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformMatrixBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformf-expected.txt: Added.
  • webgl/conformance/more/functions/uniformf.html: Added.
  • webgl/conformance/more/functions/uniformfArrayLen1-expected.txt: Added.
  • webgl/conformance/more/functions/uniformfArrayLen1.html: Added.
  • webgl/conformance/more/functions/uniformfBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformfBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformi-expected.txt: Added.
  • webgl/conformance/more/functions/uniformi.html: Added.
  • webgl/conformance/more/functions/uniformiBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformiBadArgs.html: Added.
  • webgl/conformance/more/functions/vertexAttrib-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttrib.html: Added.
  • webgl/conformance/more/functions/vertexAttribBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribBadArgs.html: Added.
  • webgl/conformance/more/functions/vertexAttribPointer-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribPointer.html: Added.
  • webgl/conformance/more/functions/vertexAttribPointerBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
  • webgl/conformance/more/glsl/arrayOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/glsl/arrayOutOfBounds.html: Added.
  • webgl/conformance/more/glsl/uniformOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/glsl/uniformOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/more/README.md: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests_linkonly.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests_sequential.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-A.js: Added.

(ArgGenerators.activeTexture.generate):
(ArgGenerators.activeTexture.checkArgValidity):
(ArgGenerators.activeTexture.teardown):
(ArgGenerators.attachShader.generate):
(ArgGenerators.attachShader.checkArgValidity):
(ArgGenerators.attachShader.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B1.js: Added.

(ArgGenerators.bindAttribLocation.generate):
(ArgGenerators.bindAttribLocation.checkArgValidity):
(ArgGenerators.bindAttribLocation.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B2.js: Added.

(ArgGenerators.bindBuffer.generate):
(ArgGenerators.bindBuffer.checkArgValidity):
(ArgGenerators.bindBuffer.cleanup):
(ArgGenerators.bindFramebuffer.generate):
(ArgGenerators.bindFramebuffer.checkArgValidity):
(ArgGenerators.bindFramebuffer.cleanup):
(ArgGenerators.bindRenderbuffer.generate):
(ArgGenerators.bindRenderbuffer.checkArgValidity):
(ArgGenerators.bindRenderbuffer.cleanup):
(ArgGenerators.bindTexture.generate):
(ArgGenerators.bindTexture.checkArgValidity):
(ArgGenerators.bindTexture.cleanup):
(ArgGenerators.blendColor.generate):
(ArgGenerators.blendColor.teardown):
(ArgGenerators.blendEquation.generate):
(ArgGenerators.blendEquation.checkArgValidity):
(ArgGenerators.blendEquation.teardown):
(ArgGenerators.blendEquationSeparate.generate):
(ArgGenerators.blendEquationSeparate.checkArgValidity):
(ArgGenerators.blendEquationSeparate.teardown):
(ArgGenerators.blendFunc.generate):
(ArgGenerators.blendFunc.checkArgValidity):
(ArgGenerators.blendFunc.teardown):
(ArgGenerators.blendFuncSeparate.generate):
(ArgGenerators.blendFuncSeparate.checkArgValidity):
(ArgGenerators.blendFuncSeparate.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B3.js: Added.

(ArgGenerators.bufferData.setup):
(ArgGenerators.bufferData.generate):
(ArgGenerators.bufferData.checkArgValidity):
(ArgGenerators.bufferData.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B4.js: Added.

(ArgGenerators.bufferSubData.setup):
(ArgGenerators.bufferSubData.generate):
(ArgGenerators.bufferSubData.checkArgValidity):
(ArgGenerators.bufferSubData.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-C.js: Added.

(ArgGenerators.checkFramebufferStatus.generate):
(ArgGenerators.checkFramebufferStatus.checkArgValidity):
(ArgGenerators.checkFramebufferStatus.cleanup):
(ArgGenerators.clear.generate):
(ArgGenerators.clear.checkArgValidity):
(ArgGenerators.clearColor.generate):
(ArgGenerators.clearColor.teardown):
(ArgGenerators.clearDepth.generate):
(ArgGenerators.clearDepth.teardown):
(ArgGenerators.clearStencil.generate):
(ArgGenerators.clearStencil.teardown):
(ArgGenerators.colorMask.generate):
(ArgGenerators.colorMask.teardown):
(ArgGenerators.createBuffer.generate):
(ArgGenerators.createBuffer.returnValueCleanup):
(ArgGenerators.createFramebuffer.generate):
(ArgGenerators.createFramebuffer.returnValueCleanup):
(ArgGenerators.createProgram.generate):
(ArgGenerators.createProgram.returnValueCleanup):
(ArgGenerators.createRenderbuffer.generate):
(ArgGenerators.createRenderbuffer.returnValueCleanup):
(ArgGenerators.createShader.generate):
(ArgGenerators.createShader.checkArgValidity):
(ArgGenerators.createShader.returnValueCleanup):
(ArgGenerators.createTexture.generate):
(ArgGenerators.createTexture.returnValueCleanup):
(ArgGenerators.cullFace.generate):
(ArgGenerators.cullFace.checkArgValidity):
(ArgGenerators.cullFace.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-D_G.js: Added.

(ArgGenerators.deleteBuffer.generate):
(ArgGenerators.deleteBuffer.checkArgValidity):
(ArgGenerators.deleteBuffer.cleanup):
(ArgGenerators.deleteFramebuffer.generate):
(ArgGenerators.deleteFramebuffer.checkArgValidity):
(ArgGenerators.deleteFramebuffer.cleanup):
(ArgGenerators.deleteProgram.generate):
(ArgGenerators.deleteProgram.checkArgValidity):
(ArgGenerators.deleteProgram.cleanup):
(ArgGenerators.deleteRenderbuffer.generate):
(ArgGenerators.deleteRenderbuffer.checkArgValidity):
(ArgGenerators.deleteRenderbuffer.cleanup):
(ArgGenerators.deleteShader.generate):
(ArgGenerators.deleteShader.checkArgValidity):
(ArgGenerators.deleteShader.cleanup):
(ArgGenerators.deleteTexture.generate):
(ArgGenerators.deleteTexture.checkArgValidity):
(ArgGenerators.deleteTexture.cleanup):
(ArgGenerators.depthFunc.generate):
(ArgGenerators.depthFunc.checkArgValidity):
(ArgGenerators.depthFunc.teardown):
(ArgGenerators.depthMask.generate):
(ArgGenerators.depthMask.teardown):
(ArgGenerators.depthRange.generate):
(ArgGenerators.depthRange.teardown):
(ArgGenerators.detachShader.generate):
(ArgGenerators.detachShader.checkArgValidity):
(ArgGenerators.detachShader.cleanup):
(ArgGenerators.disable.generate):
(ArgGenerators.disable.checkArgValidity):
(ArgGenerators.disable.cleanup):
(ArgGenerators.disableVertexAttribArray.generate):
(ArgGenerators.disableVertexAttribArray.checkArgValidity):
(ArgGenerators.enable.generate):
(ArgGenerators.enable.checkArgValidity):
(ArgGenerators.enable.cleanup):
(ArgGenerators.enableVertexAttribArray.generate):
(ArgGenerators.enableVertexAttribArray.checkArgValidity):
(ArgGenerators.enableVertexAttribArray.cleanup):
(ArgGenerators.finish.generate):
(ArgGenerators.flush.generate):
(ArgGenerators.frontFace.generate):
(ArgGenerators.frontFace.checkArgValidity):
(ArgGenerators.frontFace.cleanup):
(ArgGenerators.generateMipmap.setup):
(ArgGenerators.generateMipmap.generate):
(ArgGenerators.generateMipmap.checkArgValidity):
(ArgGenerators.generateMipmap.teardown):
(ArgGenerators.getAttachedShaders.setup):
(ArgGenerators.getAttachedShaders.generate):
(ArgGenerators.getAttachedShaders.checkArgValidity):
(ArgGenerators.getAttachedShaders.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-G_I.js: Added.

(ArgGenerators.getAttribLocation.generate):
(ArgGenerators.getAttribLocation.checkArgValidity):
(ArgGenerators.getAttribLocation.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-L_S.js: Added.

(ArgGenerators.lineWidth.generate):
(ArgGenerators.lineWidth.teardown):
(ArgGenerators.pixelStorei.generate):
(ArgGenerators.pixelStorei.checkArgValidity):
(ArgGenerators.pixelStorei.teardown):
(ArgGenerators.polygonOffset.generate):
(ArgGenerators.polygonOffset.teardown):
(ArgGenerators.sampleCoverage.generate):
(ArgGenerators.sampleCoverage.teardown):
(ArgGenerators.scissor.generate):
(ArgGenerators.scissor.checkArgValidity):
(ArgGenerators.scissor.teardown):
(ArgGenerators.stencilFunc.generate):
(ArgGenerators.stencilFunc.checkArgValidity):
(ArgGenerators.stencilFunc.teardown):
(ArgGenerators.stencilFuncSeparate.generate):
(ArgGenerators.stencilFuncSeparate.checkArgValidity):
(ArgGenerators.stencilFuncSeparate.teardown):
(ArgGenerators.stencilMask.generate):
(ArgGenerators.stencilMask.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-S_V.js: Added.

(ArgGenerators.stencilMaskSeparate.generate):
(ArgGenerators.stencilMaskSeparate.checkArgValidity):
(ArgGenerators.stencilMaskSeparate.teardown):
(ArgGenerators.stencilOp.generate):
(ArgGenerators.stencilOp.checkArgValidity):
(ArgGenerators.stencilOp.teardown):
(ArgGenerators.stencilOpSeparate.generate):
(ArgGenerators.stencilOpSeparate.checkArgValidity):
(ArgGenerators.stencilOpSeparate.teardown):
(ArgGenerators.texImage2D.setup):
(ArgGenerators.texImage2D.generate):
(ArgGenerators.texImage2D.checkArgValidity):
(ArgGenerators.texImage2D.teardown):
(ArgGenerators.texParameterf.generate):
(ArgGenerators.texParameterf.checkArgValidity):
(ArgGenerators.texParameteri.generate):
(ArgGenerators.texParameteri.checkArgValidity):
(ArgGenerators.viewport.generate):
(ArgGenerators.viewport.checkArgValidity):
(ArgGenerators.viewport.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/badArgsArityLessThanArgc.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/constants.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/fuzzTheAPI.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/getContext.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/methods.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI.js: Added.

(Array.from):
(Array.prototype.has):
(Array.prototype.random):
(castToInt):
(constCheck.a.has):
(constCheck):
(isBufferData):
(isVertexAttribute):
(isValidName):
(randomWebGLArray):
(randomArrayBuffer):
(randomBufferData):
(randomSmallWebGLArray):
(randomBufferSubData):
(randomColor):
(randomName):
(randomVertexAttribute):
(randomBool):
(randomStencil):
(randomLineWidth):
(randomImage):
(mutateArgs):
(argGeneratorTestRunner):

  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPIBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/webGLArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/demos/opengl_web.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/demos/video.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindBuffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferData.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferSubData.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferSubDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/isTests.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/isTestsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixels.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrix.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrixBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformf.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformfArrayLen1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformfBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformi.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformiBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointer.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/arrayOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/longLoops.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/uniformOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/unusedAttribsUniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/index.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/CPUvsGPU.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/bandwidth.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsGCPause.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsMatrixMult.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsToGLOverhead.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/unit.css: Added.

(.ok):
(.fail):
(canvas):
(#test-status):
(#test-log):
(#test-log > div):
(#test-log h2):
(#test-log h3):
(#test-log p):

  • webgl/resources/webgl_test_files/conformance/more/unit.js: Added.

(.window.console.log):
(.window.console.error):
(Tests.startUnit):
(Tests.setup):
(Tests.teardown):
(Tests.endUnit):
(.):
(Object.toSource):

  • webgl/resources/webgl_test_files/conformance/more/util.js: Added.

(loadTexture):
(getShader):
(loadShaderArray):
(loadShader):
(getGLErrorAsString):
(checkError):
(throwError):
(Math.cot):
(Matrix.newIdentity):
(Matrix.newIdentity3x3):
(Matrix.copyMatrix):
(Matrix.to3x3):
(Matrix.inverseON):
(Matrix.inverseTo3x3):
(Matrix.inverseTo3x3InPlace):
(Matrix.inverse3x3):
(Matrix.inverse3x3InPlace):
(Matrix.frustum):
(Matrix.perspective):
(Matrix.mul4x4):
(Matrix.mul4x4InPlace):
(Matrix.mulv4):
(Matrix.rotate):
(Matrix.rotateInPlace):
(Matrix.scale):
(Matrix.scale3):
(Matrix.scale1):
(Matrix.scale3InPlace):
(Matrix.scale1InPlace):
(Matrix.scaleInPlace):
(Matrix.translate3):
(Matrix.translate):
(Matrix.translate3InPlace):
(Matrix.translateInPlace):
(Matrix.lookAt):
(Matrix.transpose4x4):
(Matrix.transpose4x4InPlace):
(Matrix.transpose3x3):
(Matrix.transpose3x3InPlace):
(Vec3.make):
(Vec3.copy):
(Vec3.add):
(Vec3.sub):
(Vec3.negate):
(Vec3.direction):
(Vec3.normalizeInPlace):
(Vec3.normalize):
(Vec3.scale):
(Vec3.dot):
(Vec3.inner):
(Vec3.cross):
(Shader):
(Shader.prototype.destroy):
(Shader.prototype.compile):
(Shader.prototype.use):
(Shader.prototype.uniform1fv):
(Shader.prototype.uniform2fv):
(Shader.prototype.uniform3fv):
(Shader.prototype.uniform4fv):
(Shader.prototype.uniform1f):
(Shader.prototype.uniform2f):
(Shader.prototype.uniform3f):
(Shader.prototype.uniform4f):
(Shader.prototype.uniform1iv):
(Shader.prototype.uniform2iv):
(Shader.prototype.uniform3iv):
(Shader.prototype.uniform4iv):
(Shader.prototype.uniform1i):
(Shader.prototype.uniform2i):
(Shader.prototype.uniform3i):
(Shader.prototype.uniform4i):
(Shader.prototype.uniformMatrix4fv):
(Shader.prototype.uniformMatrix3fv):
(Shader.prototype.uniformMatrix2fv):
(Shader.prototype.attrib):
(Shader.prototype.uniform):
(Filter):
(Filter.prototype.apply):
(VBO):
(VBO.prototype.setData):
(VBO.prototype.destroy):
(VBO.prototype.init):
(VBO.prototype.use):
(VBO.prototype.draw):
(FBO):
(FBO.prototype.destroy):
(FBO.prototype.init):
(FBO.prototype.getTempCanvas):
(FBO.prototype.use):
(GLError):
(makeGLErrorWrapper):
(wrapGLContext.wrap.getError):
(getGLContext):
(assertSomeGLError):
(assertThrowNoGLError):
(Quad.makeVBO):
(.gl):
(Quad.getCachedVBO):
(deleteShader):
(Cube.create):
(Cube.makeVBO):
(Cube.getCachedVBO):
(Sphere.create.vert):
(Sphere.create):
(initGL_CONTEXT_ID):

11:36 PM Changeset in webkit [142853] by gman@chromium.org
  • 1 edit
    45 adds in trunk/LayoutTests

Add the WebGL Conformance Tests extensions folder.
https://bugs.webkit.org/show_bug.cgi?id=109117

Reviewed by Kenneth Russell.

  • webgl/conformance/extensions/ext-texture-filter-anisotropic-expected.txt: Added.
  • webgl/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
  • webgl/conformance/extensions/get-extension-expected.txt: Added.
  • webgl/conformance/extensions/get-extension.html: Added.
  • webgl/conformance/extensions/oes-element-index-uint-expected.txt: Added.
  • webgl/conformance/extensions/oes-element-index-uint.html: Added.
  • webgl/conformance/extensions/oes-standard-derivatives-expected.txt: Added.
  • webgl/conformance/extensions/oes-standard-derivatives.html: Added.
  • webgl/conformance/extensions/oes-texture-float-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-canvas-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-canvas.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-data-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-data.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-video-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-video.html: Added.
  • webgl/conformance/extensions/oes-texture-float.html: Added.
  • webgl/conformance/extensions/oes-vertex-array-object-expected.txt: Added.
  • webgl/conformance/extensions/oes-vertex-array-object.html: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
  • webgl/conformance/extensions/webgl-debug-renderer-info-expected.txt: Added.
  • webgl/conformance/extensions/webgl-debug-renderer-info.html: Added.
  • webgl/conformance/extensions/webgl-debug-shaders-expected.txt: Added.
  • webgl/conformance/extensions/webgl-debug-shaders.html: Added.
  • webgl/conformance/extensions/webgl-depth-texture-expected.txt: Added.
  • webgl/conformance/extensions/webgl-depth-texture.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/get-extension.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-standard-derivatives.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-vertex-array-object.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-renderer-info.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-shaders.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html: Added.
11:31 PM Changeset in webkit [142852] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark new WebGL conformance tests added in r142847 as failing for
EFL WK2.

  • platform/efl-wk2/TestExpectations:
11:10 PM Changeset in webkit [142851] by gman@chromium.org
  • 1 edit
    454 adds in trunk/LayoutTests

Add the WebGL Conformance Tests ogles folder.
https://bugs.webkit.org/show_bug.cgi?id=109116

Reviewed by Kenneth Russell.

  • webgl/conformance/ogles/GL/abs/abs_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/all/all_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/all/all_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/any/any_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/any/any_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/array/array_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/array/array_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/ceil/ceil_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/clamp/clamp_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
  • webgl/conformance/ogles/GL/cos/cos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/cross/cross_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/default/default_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/default/default_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/degrees/degrees_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/discard/discard_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/distance/distance_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/dot/dot_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/equal/equal_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/equal/equal_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/exp/exp_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/exp/exp_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/floor/floor_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/fract/fract_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_057_to_064-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_065_to_072-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_073_to_080-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_081_to_088-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_089_to_096-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_097_to_104-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_105_to_112-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_113_to_120-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_121_to_126-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
  • webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt: Added.
  • webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
  • webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/length/length_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/length/length_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_041_to_046-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
  • webgl/conformance/ogles/GL/mat3/mat3_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/max/max_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/max/max_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/min/min_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/min/min_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/mix/mix_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/mod/mod_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/normalize/normalize_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/not/not_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/not/not_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_025_to_026-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/radians/radians_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/reflect/reflect_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/refract/refract_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sign/sign_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sin/sin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/step/step_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/step/step_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
  • webgl/conformance/ogles/GL/tan/tan_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_017_to_018-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
  • webgl/conformance/ogles/GL/vec3/vec3_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/array_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/README.md: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/mustpass.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/process-ogles2-tests.py: Added.

(Log):
(TransposeMatrix):
(GetValidTypeName):
(WriteOpen):
(TxtWriter):
(TxtWriter.init):
(TxtWriter.Write):
(TxtWriter.Close):
(ReadFileAsLines):
(ReadFile):
(Chunkify):
(GetText):
(GetElementText):
(GetBoolElement):
(GetModel):
(RelativizePaths):
(CopyFile):
(CopyShader):
(IsOneOf):
(CheckForUnknownTags):
(IsFileWeWant):
(TestReader):
(TestReader.to):
(TestReader.init):
(TestReader.Print):
(TestReader.MakeOutPath):
(TestReader.ReadTests):
(TestReader.ReadTest):
(TestReader.ProcessTest):
(TestReader.WriteTests):
(CopyShaders):
(Process_compare):
(Process_shaderload):
(Process_extension):
(Process_createtests):
(Process_GL2Test):
(Process_uniformquery):
(Process_egl_image_external):
(Process_dismount):
(Process_build):
(Process_coverage):
(Process_attributes):
(Process_fixed):
(main):

10:56 PM Changeset in webkit [142850] by gman@chromium.org
  • 1 edit
    592 adds in trunk/LayoutTests

Add WebGL Conformance Tests glsl folder.
https://bugs.webkit.org/show_bug.cgi?id=109115

Reviewed by Kenneth Russell.

  • webgl/conformance/glsl/functions/glsl-function-abs-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-abs.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-acos-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-acos.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-asin-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-asin.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-xy-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-ceil-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-ceil.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-cos-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-cos.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-cross-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-cross.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-distance-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-distance.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-dot-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-dot.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-faceforward-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-faceforward.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-floor-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-floor.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-fract-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-fract.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-length-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-length.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-normalize-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-normalize.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-reflect-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-reflect.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-sign-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-sign.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-sin-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-sin.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function.html: Added.
  • webgl/conformance/glsl/implicit/add_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_int_to_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/construct_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/construct_struct.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/greater_than.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/greater_than.vert.html: Added.
  • webgl/conformance/glsl/implicit/greater_than_equal.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
  • webgl/conformance/glsl/implicit/less_than.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/less_than.vert.html: Added.
  • webgl/conformance/glsl/implicit/less_than_equal.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/less_than_equal.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/matrices/glsl-mat4-to-mat3-expected.txt: Added.
  • webgl/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
  • webgl/conformance/glsl/misc/attrib-location-length-limits-expected.txt: Added.
  • webgl/conformance/glsl/misc/attrib-location-length-limits.html: Added.
  • webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden-expected.txt: Added.
  • webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
  • webgl/conformance/glsl/misc/glsl-function-nodes-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-function-nodes.html: Added.
  • webgl/conformance/glsl/misc/glsl-long-variable-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-long-variable-names.html: Added.
  • webgl/conformance/glsl/misc/glsl-vertex-branch-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-vertex-branch.html: Added.
  • webgl/conformance/glsl/misc/large-loop-compile-expected.txt: Added.
  • webgl/conformance/glsl/misc/large-loop-compile.html: Added.
  • webgl/conformance/glsl/misc/non-ascii-comments.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
  • webgl/conformance/glsl/misc/non-ascii.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/non-ascii.vert.html: Added.
  • webgl/conformance/glsl/misc/re-compile-re-link-expected.txt: Added.
  • webgl/conformance/glsl/misc/re-compile-re-link.html: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-define-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-define.html: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-define-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-define.html: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-array.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-clipvertex.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-assignment-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-do-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-do-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-with-error-directive-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-error-directive.html: Added.
  • webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-float-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-for-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-for-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-with-for-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-for-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-frag-depth.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-function-recursion.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-function-scoped-struct-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
  • webgl/conformance/glsl/misc/shader-with-functional-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-glcolor.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-1.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-symbol.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
  • webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-include.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-include.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-int-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-limited-indexing.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-long-line-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-long-line.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-quoted-error.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-too-many-uniforms-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
  • webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-120.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-130.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-while-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-while-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-without-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-without-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-missing-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
  • webgl/conformance/glsl/misc/shared-expected.txt: Added.
  • webgl/conformance/glsl/misc/shared.html: Added.
  • webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum-expected.txt: Added.
  • webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
  • webgl/conformance/glsl/misc/struct-nesting-under-maximum-expected.txt: Added.
  • webgl/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
  • webgl/conformance/glsl/misc/uniform-location-length-limits-expected.txt: Added.
  • webgl/conformance/glsl/misc/uniform-location-length-limits.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_field.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_field.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_function.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_function.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_variable.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_field.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_field.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_function.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_function.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_preprocessor_reserved-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
  • webgl/conformance/glsl/reserved/webgl_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_struct.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_variable.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_variable.vert.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2d-bias-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dlod-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dproj-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
  • webgl/conformance/glsl/variables/gl-fragcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-fragcoord.html: Added.
  • webgl/conformance/glsl/variables/gl-frontfacing-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-frontfacing.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-abs.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-acos.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-asin.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-ceil.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cos.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cross.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-distance.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-dot.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-faceforward.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-floor.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-fract.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-length.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-lessThan.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-normalize.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-reflect.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-refract.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sign.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sin.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/construct_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than_equal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/matrices/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/attrib-location-length-limits.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/foo: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-2types-of-textures-on-same-unit.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-function-nodes.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-long-variable-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-vertex-branch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/include.vs: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/large-loop-compile.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/re-compile-re-link.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-define.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-define.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-do-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-error-directive.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-include.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-long-line.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-while-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-without-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shared.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/uniform-location-length-limits.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_field.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_function.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_field.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_function.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_variable.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-fragcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-frontfacing.html: Added.
10:17 PM Changeset in webkit [142849] by haraken@chromium.org
  • 45 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom methods
https://bugs.webkit.org/show_bug.cgi?id=109678

Reviewed by Adam Barth.

Currently V8 directly calls back custom methods written
in custom binding files. This makes it impossible for code
generators to hook custom methods (e.g. Code generators cannot
insert a code for FeatureObservation into custom methods).
To solve the problem, we should generate wrapper methods for
custom methods.

No tests. No change in behavior.

  • page/DOMWindow.idl: Removed overloaded methods. The fact that methods in an IDL

file are overloaded but they are not overloaded in custom bindings confuses code
generators. (For some reason, this problem hasn't appeared before this change.)

  • xml/XMLHttpRequest.idl: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateEventListenerCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod3Callback):
(TestInterfaceV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customMethodWithArgsCallback):
(WebCore::TestObjV8Internal::classMethod2Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallbackCustom):
(WebCore::V8Clipboard::setDragImageCallbackCustom):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::traceCallbackCustom):
(WebCore::V8Console::assertCallbackCustom):
(WebCore::V8Console::profileCallbackCustom):
(WebCore::V8Console::profileEndCallbackCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallbackCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallbackCustom):
(WebCore::V8DOMWindow::removeEventListenerCallbackCustom):
(WebCore::V8DOMWindow::postMessageCallbackCustom):
(WebCore::V8DOMWindow::toStringCallbackCustom):
(WebCore::V8DOMWindow::releaseEventsCallbackCustom):
(WebCore::V8DOMWindow::captureEventsCallbackCustom):
(WebCore::V8DOMWindow::showModalDialogCallbackCustom):
(WebCore::V8DOMWindow::openCallbackCustom):
(WebCore::V8DOMWindow::setTimeoutCallbackCustom):
(WebCore::V8DOMWindow::setIntervalCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8CallbackCustom):
(WebCore::V8DataView::getUint8CallbackCustom):
(WebCore::V8DataView::setInt8CallbackCustom):
(WebCore::V8DataView::setUint8CallbackCustom):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageCallbackCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallbackCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallbackCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallbackCustom):
(WebCore::V8Document::createTouchListCallbackCustom):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::V8Geolocation::getCurrentPositionCallbackCustom):
(WebCore::V8Geolocation::watchPositionCallbackCustom):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::itemCallbackCustom):
(WebCore::V8HTMLAllCollection::namedItemCallbackCustom):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallbackCustom):
(WebCore::V8HTMLCanvasElement::toDataURLCallbackCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::writeCallbackCustom):
(WebCore::V8HTMLDocument::writelnCallbackCustom):
(WebCore::V8HTMLDocument::openCallbackCustom):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::V8HTMLFormControlsCollection::namedItemCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallbackCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::setSelectionRangeCallbackCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::namedItemCallbackCustom):
(WebCore::V8HTMLOptionsCollection::removeCallbackCustom):
(WebCore::V8HTMLOptionsCollection::addCallbackCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::removeCallbackCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallbackCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameCallbackCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallbackCustom):
(WebCore::V8InjectedScriptHost::typeCallbackCustom):
(WebCore::V8InjectedScriptHost::functionDetailsCallbackCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesCallbackCustom):
(WebCore::V8InjectedScriptHost::getEventListenersCallbackCustom):
(WebCore::V8InjectedScriptHost::inspectCallbackCustom):
(WebCore::V8InjectedScriptHost::databaseIdCallbackCustom):
(WebCore::V8InjectedScriptHost::storageIdCallbackCustom):
(WebCore::V8InjectedScriptHost::evaluateCallbackCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallbackCustom):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallbackCustom):
(WebCore::V8InspectorFrontendHost::portCallbackCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallbackCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateCallbackCustom):
(WebCore::V8JavaScriptCallFrame::restartCallbackCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueCallbackCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeCallbackCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::reloadCallbackCustom):
(WebCore::V8Location::replaceCallbackCustom):
(WebCore::V8Location::assignCallbackCustom):
(WebCore::V8Location::valueOfCallbackCustom):
(WebCore::V8Location::toStringCallbackCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallbackCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventCallbackCustom):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::V8MessagePort::postMessageCallbackCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallbackCustom):
(WebCore::V8Node::replaceChildCallbackCustom):
(WebCore::V8Node::removeChildCallbackCustom):
(WebCore::V8Node::appendChildCallbackCustom):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallbackCustom):

  • bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionCallbackCustom):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallbackCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsCallbackCustom):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallbackCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getExtensionCallbackCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallbackCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getUniformCallbackCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvCallbackCustom):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallbackCustom):
(WebCore::V8WorkerContext::setTimeoutCallbackCustom):
(WebCore::V8WorkerContext::setIntervalCallbackCustom):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::postMessageCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallbackCustom):
(WebCore::V8XMLHttpRequest::sendCallbackCustom):

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::setParameterCallbackCustom):
(WebCore::V8XSLTProcessor::getParameterCallbackCustom):
(WebCore::V8XSLTProcessor::removeParameterCallbackCustom):

10:04 PM Changeset in webkit [142848] by commit-queue@webkit.org
  • 8 edits in trunk

JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
https://bugs.webkit.org/show_bug.cgi?id=109542

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

Source/WebCore:

"JSGenerateToJSObject" should be included in IDL files
of ChannelSplitterNode and ChannelMergerNode in WebAudio.
This ensures html files to access corresponding objects.

  • Modules/webaudio/ChannelMergerNode.idl:
  • Modules/webaudio/ChannelSplitterNode.idl:

LayoutTests:

Test cases updated to check validity of ChannelSplitterNode
and ChannelMergerNode Objects.

  • webaudio/audiochannelmerger-basic-expected.txt:
  • webaudio/audiochannelmerger-basic.html:
  • webaudio/audiochannelsplitter-expected.txt:
  • webaudio/audiochannelsplitter.html:
9:49 PM Changeset in webkit [142847] by gman@chromium.org
  • 3 edits
    249 adds in trunk/LayoutTests

Adds failing WebGL Conformance Tests.
https://bugs.webkit.org/show_bug.cgi?id=109075

Reviewed by Kenneth Russell.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/conformance/canvas/buffer-preserve-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • webgl/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/conformance/canvas/to-data-url-test-expected.txt: Added.
  • webgl/conformance/canvas/to-data-url-test.html: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/conformance/context/context-creation-and-destruction-expected.txt: Added.
  • webgl/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Added.
  • webgl/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/drawArrays-expected.txt: Added.
  • webgl/conformance/more/functions/drawArrays.html: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/conformance/more/functions/drawElements-expected.txt: Added.
  • webgl/conformance/more/functions/drawElements.html: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/conformance/programs/program-test-expected.txt: Added.
  • webgl/conformance/programs/program-test.html: Added.
  • webgl/conformance/reading/read-pixels-test-expected.txt: Added.
  • webgl/conformance/reading/read-pixels-test.html: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/conformance/rendering/gl-scissor-test-expected.txt: Added.
  • webgl/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/conformance/rendering/more-than-65536-indices-expected.txt: Added.
  • webgl/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/conformance/rendering/multisample-corruption-expected.txt: Added.
  • webgl/conformance/rendering/multisample-corruption.html: Added.
  • webgl/conformance/rendering/point-size-expected.txt: Added.
  • webgl/conformance/rendering/point-size.html: Added.
  • webgl/conformance/state/gl-object-get-calls-expected.txt: Added.
  • webgl/conformance/state/gl-object-get-calls.html: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/conformance/textures/gl-pixelstorei-expected.txt: Added.
  • webgl/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/conformance/textures/origin-clean-conformance-expected.txt: Added.
  • webgl/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/conformance/textures/texture-active-bind-2-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/conformance/textures/texture-active-bind-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind.html: Added.
  • webgl/conformance/textures/texture-mips-expected.txt: Added.
  • webgl/conformance/textures/texture-mips.html: Added.
  • webgl/conformance/textures/texture-npot-video-expected.txt: Added.
  • webgl/conformance/textures/texture-npot-video.html: Added.
  • webgl/conformance/textures/texture-size-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit.html: Added.
  • webgl/conformance/textures/texture-size.html: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/conformance/uniforms/uniform-default-values-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/conformance/uniforms/uniform-location-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-location.html: Added.
  • webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-samplers-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/program-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Added.
8:17 PM Changeset in webkit [142846] by Vineet
  • 4 edits in trunk/Source/WebCore

[Regression] After r142831 collection-null-like-arguments.html layout test failing
https://bugs.webkit.org/show_bug.cgi?id=109780

Reviewed by Kentaro Hara.

No new tests. LayoutTests/fast/dom/collection-null-like-arguments.html
Should pass now.

  • bindings/js/JSHTMLAllCollectionCustom.cpp: Return null for namedItem() only.

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):
(WebCore::JSHTMLFormControlsCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):
(WebCore::JSHTMLOptionsCollection::namedItem):

7:45 PM Changeset in webkit [142845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix indentation error in MediaPlayerPrivateGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=109768

Patch by Soo-Hyun Choi <sh9.choi@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

No new tests as this patch just changes indentation style.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::hasVideo):
(WebCore::MediaPlayerPrivateGStreamer::hasAudio):
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):

7:44 PM Changeset in webkit [142844] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=109779

Rebaseline http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html
on Linux after r142683.

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13

  • platform/chromium-linux/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
7:31 PM Changeset in webkit [142843] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

TokenPreloadScanner should be (mostly!) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109760

Reviewed by Eric Seidel.

This patch makes the bulk of TokenPreloadScanner thread-safe. The one
remaining wart is processPossibleBaseTag because it wants to grub
around in the base tag's attributes. I have a plan for that, but it's
going to need to wait for the next patch.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(WebCore):

6:36 PM Changeset in webkit [142842] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/Tools

Unreviewed. Add separate DumpRenderTree VS2010 solution file.

  • DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
6:30 PM Changeset in webkit [142841] by jamesr@google.com
  • 6 edits in trunk

[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebUnitTestSupport.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

6:16 PM Changeset in webkit [142840] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

StartTagScanner should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109750

Reviewed by Eric Seidel.

This patch weens the StartTagScanner off AtomicString using two
techniques:

1) This patch creates an enum to represent the four tag names that the

StartTagScanner needs to understand. Using an enum is better than
using an AtomicString because we can use the enum on both the main
thread and on the background thread.

2) For attributes, this patch uses threadSafeMatch. We're not able to

use threadSafeMatch everywhere due to performance, but using it for
attributes appears to be ok becaues we only call threadSafeMatch on
the attributes of "interesting" tags.

I tested the performance of this patch using
PerformanceTests/Parser/html-parser.html and did not see any slowdown.
(There actually appeared to be a <1% speedup, but I'm attributing that
to noise.)

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::identifierFor):
(WebCore):
(WebCore::inititatorFor):
(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(StartTagScanner):
(WebCore::StartTagScanner::createPreloadRequest):
(WebCore::StartTagScanner::processAttribute):
(WebCore::StartTagScanner::charset):
(WebCore::StartTagScanner::resourceType):
(WebCore::StartTagScanner::shouldPreload):
(WebCore::HTMLPreloadScanner::processToken):

6:11 PM Changeset in webkit [142839] by andersca@apple.com
  • 5 edits
    1 delete in trunk/Source/WebKit2

Remove StringPairVector
https://bugs.webkit.org/show_bug.cgi?id=109778

Reviewed by Ryosuke Niwa.

Our message generation scripts can handle nested template parameter types now,
so we no longer need to use StringPairVector.

  • Shared/StringPairVector.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

5:58 PM Changeset in webkit [142838] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Better build fix.

  • API/tests/testapi.c:

(assertEqualsAsNumber):
(main):

5:57 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
5:56 PM Changeset in webkit [142837] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Coordinated Graphics: a long page is scaled vertically while loading.
https://bugs.webkit.org/show_bug.cgi?id=109645

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-13
Reviewed by Noam Rosenthal.

When loading http://www.w3.org/TR/xpath-datamodel/, Coordinated Graphics draws
vertically scaled contents. It is because there is the difference between the
size of a layer and the size of CoordinatedBackingStore.

Currently, CoordinatedGraphicsScene notifies the size to CoordinatedBackingStore
at the moment of creating, updating and removing a tile. However, it is not
necessary to send tile-related messages when the size of layer is changed.
So this patch resets the size of CoordinatedBackingStore when receiving the
message that is created when the size is changed: SyncLayerState.

There is no current way to reliably test flicker issues.

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Add m_pendingSize to set m_size at the moment of flushing. After http://webkit.org/b/108294, m_pendingSize will be removed because the bug makes CoordinatedGraphicsScene execute all messages at the moment of flushing.

(WebCore::CoordinatedBackingStore::setSize):
(WebCore::CoordinatedBackingStore::commitTileOperations):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTile):
(WebCore::CoordinatedGraphicsScene::removeTile):
(WebCore::CoordinatedGraphicsScene::updateTile):

5:50 PM Changeset in webkit [142836] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

PlugIn Autostart should expire in 30 days, not half a day
https://bugs.webkit.org/show_bug.cgi?id=109767

Reviewed by Brian Weinstein.

We forgot to multiply by 60 seconds in a minute.

  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:
5:49 PM Changeset in webkit [142835] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Message generation should handle nested templates
https://bugs.webkit.org/show_bug.cgi?id=109771

Reviewed by Ryosuke Niwa.

Make it possible to have nested class template types as message parameters and
correctly gather all the needed headers and argument coder headers.

  • Scripts/webkit2/messages.py:

(class_template_headers):
Recursively figure out the types and template headers needed for a given type.

(argument_coder_headers_for_type):
(headers_for_type):
Call class_template_headers.

  • Scripts/webkit2/messages_unittest.py:

(CoreIPC):

  • Scripts/webkit2/parser.py:

(split_parameters_string):
(parse_parameters_string):

5:48 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
5:43 PM Changeset in webkit [142834] by haraken@chromium.org
  • 35 edits in trunk/Source/WebCore

[V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(),
and XXXAccessorSetter() to XXXAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=109679

Reviewed by Adam Barth.

For naming consistency and clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateHeaderCustomCall):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(WebCore::TestObjV8Internal::customAttrAttrSetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BiquadFilterNodeCustom.cpp:

(WebCore::V8BiquadFilterNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrSetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrSetterCustom):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAttrGetterCustom):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAttrGetterCustom):
(WebCore::V8Coordinates::altitudeAccuracyAttrGetterCustom):
(WebCore::V8Coordinates::headingAttrGetterCustom):
(WebCore::V8Coordinates::speedAttrGetterCustom):

  • bindings/v8/custom/V8CustomEventCustom.cpp:

(WebCore::V8CustomEvent::detailAttrGetterCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::locationAttrSetterCustom):
(WebCore::V8DOMWindow::openerAttrSetterCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::rotationRateAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::intervalAttrGetterCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::betaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::gammaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::absoluteAttrGetterCustom):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAttrGetterCustom):
(WebCore::V8Document::locationAttrSetterCustom):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAttrGetterCustom):
(WebCore::V8Event::clipboardDataAttrGetterCustom):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAttrGetterCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::allAttrSetterCustom):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAttrGetterCustom):
(WebCore::V8HTMLElement::itemValueAttrSetterCustom):

  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:

(WebCore::V8HTMLFrameElement::locationAttrSetterCustom):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionStartAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrSetterCustom):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAttrGetterCustom):
(WebCore::V8HTMLLinkElement::sizesAttrSetterCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAttrSetterCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAttrGetterCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::scopeChainAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::thisObjectAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::typeAttrGetterCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::hashAttrSetterCustom):
(WebCore::V8Location::hostAttrSetterCustom):
(WebCore::V8Location::hostnameAttrSetterCustom):
(WebCore::V8Location::hrefAttrSetterCustom):
(WebCore::V8Location::pathnameAttrSetterCustom):
(WebCore::V8Location::portAttrSetterCustom):
(WebCore::V8Location::protocolAttrSetterCustom):
(WebCore::V8Location::searchAttrSetterCustom):
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):
(WebCore::V8MessageEvent::portsAttrGetterCustom):

  • bindings/v8/custom/V8OscillatorNodeCustom.cpp:

(WebCore::V8OscillatorNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8PannerNodeCustom.cpp:

(WebCore::V8PannerNode::panningModelAttrSetterCustom):
(WebCore::V8PannerNode::distanceModelAttrSetterCustom):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAttrGetterCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAttrGetterCustom):
(WebCore::V8SVGLength::valueAttrSetterCustom):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAttrGetterCustom):

  • bindings/v8/custom/V8WebKitAnimationCustom.cpp:

(WebCore::V8WebKitAnimation::iterationCountAttrGetterCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAttrGetterCustom):
(WebCore::V8XMLHttpRequest::responseAttrGetterCustom):

5:35 PM Changeset in webkit [142833] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666

Reviewed by Adam Barth.

Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). To solve the problem,
we should generate wrapper methods for custom getters/setters.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):

5:32 PM Changeset in webkit [142832] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix.

  • API/tests/testapi.c:

(assertEqualsAsNumber):
(main):

5:31 PM Changeset in webkit [142831] by Vineet
  • 10 edits
    2 adds in trunk

HTMLCollections namedItem() methods should return null than undefined for empty collections.
https://bugs.webkit.org/show_bug.cgi?id=104096

Reviewed by Kentaro Hara.

As per specification namedItem() should return null if collection is empty.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection

Source/WebCore:

Test: fast/dom/htmlcollection-namedItem.html

  • bindings/js/JSHTMLAllCollectionCustom.cpp: Returning null.

(WebCore::getNamedItems):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLAllCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLFormControlsCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLOptionsCollection::namedItemCallback):

LayoutTests:

  • fast/dom/HTMLFormElement/move-option-between-documents-expected.txt:
  • fast/dom/HTMLFormElement/move-option-between-documents.html:
  • fast/dom/htmlcollection-namedItem-expected.txt: Added.
  • fast/dom/htmlcollection-namedItem.html: Added.
5:31 PM Changeset in webkit [142830] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Make WebKit2 Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109763

Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.

  • WebKit2.xcodeproj/project.pbxproj: Pass SDKROOT=${SDKROOT} to DerivedSources.make
5:25 PM Changeset in webkit [142829] by tonyg@chromium.org
  • 7 edits in trunk

Fix svg/in-html/script-write.html with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109495

Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the background parser's simulateTreeBuilder() more realistic.

  1. The HTMLTreeBuilder does not call the updateStateFor() setState()s when in foreign content mode so we shouldn't do it when simulating the tree builder.
  2. HTMLTreeBuilder::processTokenInForeignContent has a list of tags which exit foreign content mode. We need to respect those.
  3. Support the <foreignObject> tag which enters and leaves foreign content mode.
  4. The tree builder sets state to DataState upon a </script> tag when not in foreign content mode. We need to do the same.

This involved creating a namespace stack where we push upon entering each namespace and pop upon leaving.
We are in foreign content if the topmost namespace is SVG or MathML.

This fixes svg/in-html/script-write.html and likely others.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::getAttributeItem): Returns the attribute of the given name. Necessary to test for <font> attributes in simulateTreeBuilder.
(WebCore):

  • html/parser/CompactHTMLToken.h:

(WebCore):
(CompactHTMLToken):

LayoutTests:

Added 3 new test cases:

  1. Test the behavior of a plaintext tag inside an svg foreignObject. It applies to the remainder of the document. This behavior seems a little wonky, but it matches our current behavior and Firefox's behavior.
  2. Test that we don't blindly go into HTML mode after </foreignObject>.
  3. Test that unmatched </foreignObject>s are ignored.
  • html5lib/resources/webkit02.dat:
5:17 PM Changeset in webkit [142828] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
https://bugs.webkit.org/show_bug.cgi?id=109766

Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • Don't search Mac OS X header search paths when building on iOS
5:11 PM Changeset in webkit [142827] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
<http://webkit.org/b/109756>

Reviewed by Antti Koivisto.

Remove this to prevent callers from accidentally causing elements to convert to UniqueElementData.
There are two call sites (Attr and HTMLSelectElement) that legitimately need to mutate Attribute
objects in-place, they now use Element::ensureUniqueElementData()->getAttributeItem() directly instead.

Small progression on Membuster3, mostly for peace of mind.

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/Element.h:

(Element):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

5:07 PM Changeset in webkit [142826] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Stronger ElementData pointer typing.
<http://webkit.org/b/109752>

Reviewed by Antti Koivisto.

Use ShareableElementData/UniqueElementData pointers instead of generic ElementData pointers
where possible. Moved some methods from base class into leaf classes that don't make sense
for both classes.

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/DocumentSharedObjectPool.h:

(DocumentSharedObjectPool):

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::ShareableElementData::createWithAttributes):
(WebCore::UniqueElementData::create):
(WebCore::ElementData::makeUniqueCopy):
(WebCore::UniqueElementData::makeShareableCopy):

  • dom/Element.h:

(ElementData):
(ShareableElementData):
(UniqueElementData):
(Element):
(WebCore::Element::ensureUniqueElementData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

5:03 PM Changeset in webkit [142825] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765

Reviewed by Andreas Kling and Anders Carlsson.

Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.

  • platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::sharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

5:02 PM Changeset in webkit [142824] by eae@chromium.org
  • 6 edits
    2 adds in trunk

getComputedStyle returns truncated value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=109759

Source/WebCore:

Reviewed by Tony Chang.

Due to an unfortunate cast in CSSComputedStyleDeclaration::
getPropertyCSSValue getComputedStyle returns truncated styles
for margin-right in cases where it isn't set to a specific pixel
value.

Test: fast/sub-pixel/computedstylemargin.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Change type of temporary value variable to float to prevent loss of precision.

LayoutTests:

Reviewed by Tony Chang.

Add test for getComputedStyle with fractional margin values.

  • fast/sub-pixel/computedstylemargin-expected.txt: Added.
  • fast/sub-pixel/computedstylemargin.html: Added.
4:59 PM Changeset in webkit [142823] by mvujovic@adobe.com
  • 14 edits
    1 add in trunk/Source

[CSS Filters] Refactor filter outsets into a class
https://bugs.webkit.org/show_bug.cgi?id=109330

Source/WebCore:

Reviewed by Dean Jackson.

In filters related code, we're often operating on 4 ints representing the top, right,
bottom, and left filter outsets. These outsets come from a filter like blur or drop-shadow.
This patch packages those ints and their related operations into a class called
IntRectExtent.

Here are some signs that we should make a class to hold those 4 ints:
1) In RenderLayer.cpp, we have a expandRectForFilterOutsets function, which looks like

feature envy.

2) RenderStyle and other classes have methods like getFilterOutsets which set the 4 ints by

reference. The calling code has to define 4 ints, which looks bloated.

3) To fix bug 109098, we will need to check if filter outsets changed, which sounds like a

nice job for an inequality operator. (https://bugs.webkit.org/show_bug.cgi?id=109098)

No new tests. No change in behavior. Just refactoring.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntRectExtent.h: Added.

(WebCore):
(IntRectExtent):
(WebCore::IntRectExtent::IntRectExtent):
(WebCore::IntRectExtent::top):
(WebCore::IntRectExtent::setTop):
(WebCore::IntRectExtent::right):
(WebCore::IntRectExtent::setRight):
(WebCore::IntRectExtent::bottom):
(WebCore::IntRectExtent::setBottom):
(WebCore::IntRectExtent::left):
(WebCore::IntRectExtent::setLeft):
(WebCore::IntRectExtent::expandRect):
(WebCore::IntRectExtent::isZero):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::operator+=):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::outsets):

  • platform/graphics/filters/FilterOperations.h:

(FilterOperations):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::intermediateSurfaceRect):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/style/RenderStyle.h:

Source/WebKit/chromium:

Update FilterOperations unit tests to use new interface for getting filter outsets.

Reviewed by Dean Jackson.

  • tests/FilterOperationsTest.cpp:

(WebKit::TEST):

4:56 PM Changeset in webkit [142822] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Factor HTMLTokenScanner out of HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109754

Reviewed by Eric Seidel.

This patch is just a mechanical separation of the per-token "scanning"
logic from HTMLPreloadScanner into a separate class.
HTMLPreloadScanner's job is now to keep track of the input stream and
to pump the tokenizer.

This factorization class will let us use HTMLTokenScanner on the
background thread (once we finish making it thread-safe). In a follow
up patch, I'll move HTMLTokenScanner to its own file.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLTokenScanner::HTMLTokenScanner):
(WebCore::HTMLTokenScanner::~HTMLTokenScanner):
(WebCore::HTMLTokenScanner::processPossibleTemplateTag):
(WebCore::HTMLTokenScanner::processPossibleStyleTag):
(WebCore::HTMLTokenScanner::processPossibleBaseTag):
(WebCore::HTMLTokenScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore):
(WebCore::HTMLPreloadScanner::~HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::appendToEnd):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(HTMLTokenScanner):
(WebCore::HTMLTokenScanner::setPredictedBaseElementURL):
(HTMLPreloadScanner):
(WebCore):

4:37 PM Changeset in webkit [142821] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r125794) - inline-children-root-linebox-crash asserts in Chromium debug
https://bugs.webkit.org/show_bug.cgi?id=94256

Unreviewed test expectations update. Re-enabling inline-children-root-linebox-crash
as it was fixed by r139479.

  • platform/chromium/TestExpectations:
4:12 PM Changeset in webkit [142820] by esprehn@chromium.org
  • 7 edits
    2 adds in trunk

ASSERT(!renderer()->needsLayout()) when calling Element::focus() with generated content
https://bugs.webkit.org/show_bug.cgi?id=109616

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/quote-layout-focus-crash.html

In some cases RenderQuote may mark itself and containing blocks as needing layout
during a layout, but then one of it's containing blocks will mark itself as having
finished layout so the RenderQuote and potentially some of it's ancestor renderers
needLayout(), but the ancestors above those do not.

Until we have proper pre-layout tasks we should just walk the list of quotes
right before layout and mark all their ancestors as needing layout if the quote
needs layout.

  • dom/Document.cpp:

(WebCore::Document::updateLayout): Call markQuoteContainingBlocksForLayoutIfNeeded.
(WebCore::Document::implicitClose): Call markQuoteContainingBlocksForLayoutIfNeeded.

  • rendering/RenderQuote.h:

(WebCore::RenderQuote::next): Added.

  • rendering/RenderView.cpp:

(WebCore::RenderView::markQuoteContainingBlocksForLayoutIfNeeded): Added.

  • rendering/RenderView.h:

(RenderView):

LayoutTests:

  • fast/block/float/float-not-removed-from-pre-block-expected.txt: Changed output.
  • fast/css-generated-content/quote-layout-focus-crash-expected.txt: Added.
  • fast/css-generated-content/quote-layout-focus-crash.html: Added.
4:02 PM Changeset in webkit [142819] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

EME: MediaPlayer::keyNeede() should return a bool indicating whether an event listener was triggered.
https://bugs.webkit.org/show_bug.cgi?id=109701

Reviewed by Eric Carlson.

Clients of MediaPlayer may need to do cleanup if calling keyNeeded()
results in no event listener being triggered. Return a bool (like the
v1 equivalent keyNeeded method) to indicate this.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyNeeded):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):

3:57 PM Changeset in webkit [142818] by mrobinson@webkit.org
  • 3 edits in trunk

Try once again to fix the build after r142756

  • Source/autotools/PrintBuildConfiguration.m4: Do not try to print the GStreamer version

in the build output.

  • Source/autotools/SetupAutoconfHeader.m4: Remove the last reference to have_gstreamer.
3:53 PM Changeset in webkit [142817] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more buildfix for !ENABLE(PLUGIN_PROCESS) platforms.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

3:44 PM Changeset in webkit [142816] by inferno@chromium.org
  • 4 edits
    2 adds in trunk
ASSERTION FAILED: !object
object->isBox(), Bad cast in RenderBox::computeLogicalHeight

https://bugs.webkit.org/show_bug.cgi?id=107748

Reviewed by Levi Weintraub.

Source/WebCore:

Make sure that body renderer is not an inline-block display
when determining that it stretches to viewport or when paginated
content needs base height.

Test: fast/block/body-inline-block-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

LayoutTests:

  • fast/block/body-inline-block-crash-expected.txt: Added.
  • fast/block/body-inline-block-crash.html: Added.
3:43 PM Changeset in webkit [142815] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix debug assertion being triggered because we may access dirty normalFlowList.
https://bugs.webkit.org/show_bug.cgi?id=109740

A debug assertion in RenderLayer.h is being hit when trying to
access the normalFlowList when it is dirty. This is caused by a
new recursion that I added in RenderLayerBacking::hasVisibleNonCompositingDescendant(),
but I overlooked the need to call updateLayerListsIfNeeded()
recursively as well.

Reviewed by Simon Fraser.

No test, because there's no reliable way to test this (same as bug 85512).

  • rendering/RenderLayerBacking.cpp:

(WebCore::hasVisibleNonCompositingDescendant):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):

3:37 PM Changeset in webkit [142814] by roger_fong@apple.com
  • 3 adds in trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj

Unreviewed. Add some missing property sheets for TestWebKitAPI.

  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Added.
3:37 PM Changeset in webkit [142813] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Yet another build fix

3:34 PM Changeset in webkit [142812] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt-Mac and Qt-Win buildfix after r142768.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13

  • WebProcess/WebProcess.h:

(WebKit):

3:09 PM Changeset in webkit [142811] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Don't restart shared timer if both the current and the new fire time are in the past
https://bugs.webkit.org/show_bug.cgi?id=109731

Reviewed by Andreas Kling.

In 40-50% of cases we reschedule the shared timer both the old and the new fire time have already passed. This can happen at least when rescheduling
a zero duration timer and when stopping a timer that was ready to fire.

We can skip rescheduling in this case, the shared timer will fire immediately anyway.

Scheduling timers calls into platform layer and can be slow. This about halves the time under setSharedTimerFireInterval in PLT3
for ~0.1% total CPU time reduction.

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::setSharedTimer):
(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/ThreadTimers.h:

(ThreadTimers):

3:01 PM Changeset in webkit [142810] by zandobersek@gmail.com
  • 79 edits in trunk

The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
https://bugs.webkit.org/show_bug.cgi?id=109325

Reviewed by Anders Carlsson.

Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
two methods as they're provided by the C++ standard library being used.

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueMakeNumber):

  • JSCTypedArrayStubs.h:

(JSC):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::constantNaN):

  • offlineasm/cloop.rb:
  • runtime/DateConstructor.cpp:

(JSC::dateUTC): Also include an opportunistic style fix.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toInteger):

  • runtime/JSDateMath.cpp:

(JSC::getUTCOffset):
(JSC::parseDateFromNullTerminatedCharacters):
(JSC::parseDate):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):

  • runtime/PropertyDescriptor.cpp:

(JSC::sameValue):

Source/WebCore:

No new tests as there's no change in functionality.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::setValue):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::isValidNumber):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::fixNANs):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::setTimeout):
(WebCore::setMaximumAge):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::setLength):

  • bindings/js/JSWebKitPointCustom.cpp:

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getByIndex):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::classMethodWithClampCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::toInt32):
(WebCore::toUInt32):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::createPositionOptions):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::translate):
(WebCore::WebKitCSSMatrix::scale):
(WebCore::WebKitCSSMatrix::rotate):
(WebCore::WebKitCSSMatrix::rotateAxisAngle):
(WebCore::WebKitCSSMatrix::skewX):
(WebCore::WebKitCSSMatrix::skewY):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::endedPlayback):

  • html/MediaController.cpp:

(MediaController::duration):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::clearColor):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::addCue):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setStartTime):
(WebCore::TextTrackCue::setEndTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::floatFeature): Also include an opportunistic style fix.

  • platform/CalculationValue.cpp:

(WebCore::CalculationValue::evaluate):

  • platform/Decimal.cpp:

(WebCore::Decimal::fromDouble):

  • platform/Length.cpp:

(WebCore::Length::nonNanCalculatedValue):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::setRate):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/Reverb.cpp:

(WebCore::calculateNormalizationScale):

  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::isLiveStream):

  • platform/graphics/gpu/LoopBlinnMathUtils.cpp:

(LoopBlinnMathUtils):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenTypeVerticalData::getVerticalTranslationsForGlyphs):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider):
(WebCore::paintMediaVolumeSlider):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentTime):

  • svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSubstring::evaluate):
(WebCore::XPath::FunRound::round):

  • xml/XPathValue.cpp:

(WebCore::XPath::Value::toBoolean): Also include an opportunistic style fix.
(WebCore::XPath::Value::toString):

Source/WebKit/chromium:

  • tests/DecimalTest.cpp:

(TEST_F):

Source/WebKit/mac:

  • tests/DecimalTest.cpp:

(TEST_F):

Source/WTF:

  • wtf/Compiler.h: Remove the global isinf/isnan compiler quirk definitions. They're not required anymore.
  • wtf/DateMath.cpp: Move the workaround for isinf on Solaris into the std namespace. Ditto for isinf and isnan

when using MSVC. Stop bringing the isinf and isnan methods into the global scope when using other configurations.
(WTF::parseDateFromNullTerminatedCharacters):

  • wtf/IntegralTypedArrayBase.h:

(WTF::IntegralTypedArrayBase::set):

  • wtf/MathExtras.h:

(std):
(std::isinf):
(wtf_fmod):
(wtf_pow):
(doubleToInteger):

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

  • wtf/Uint8ClampedArray.h:

(WTF::Uint8ClampedArray::set):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(setAppCacheMaximumSizeCallback):
(setApplicationCacheOriginQuotaCallback):
(setDatabaseQuotaCallback):

2:57 PM Changeset in webkit [142809] by eric.carlson@apple.com
  • 16 edits
    1 add in trunk

[Mac] Caption menu should have only one item selected
https://bugs.webkit.org/show_bug.cgi?id=109730

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, media/track/track-user-preferences.html was modified to test the changes.

  • CMakeLists.txt: Add CaptionUserPreferences.cpp.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_processingPreferenceChange.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Only end up with one selected track when

called because of a preferences change.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Call setClosedCaptionsVisible instead

of calling markCaptionAndSubtitleTracksAsUnconfigured directly.

(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Process all tracks,

not just track elements.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp: Added so the functionality can be tested in DRT.

(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::setUserPrefersCaptions):
(WebCore::CaptionUserPreferences::captionPreferencesChanged):
(WebCore::CaptionUserPreferences::preferredLanguages):
(WebCore::CaptionUserPreferences::setPreferredLanguage):
(WebCore::CaptionUserPreferences::displayNameForTrack):

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Moved some logic

to base class.

(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Ditto.

LayoutTests:

  • media/track/track-user-preferences-expected.txt:
  • media/track/track-user-preferences.html: Update test to check for reactions to preferences.
2:54 PM Changeset in webkit [142808] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix scaling in WebViewImpl::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My last patch broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

2:54 PM Changeset in webkit [142807] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove bogus ASSERT in WebFrameProxy::didStartProvisionalLoad
https://bugs.webkit.org/show_bug.cgi?id=109733

Reviewed by Sam Weinig.

After http://trac.webkit.org/changeset/142555, this ASSERT is
triggering on these tests:

fast/dom/window-load-crash.html
fast/frames/seamless/seamless-hyperlink-named.html
fast/frames/seamless/seamless-hyperlink.html

The ASSERT appears to be bogus. This patch removes it.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

2:46 PM Changeset in webkit [142806] by weinig@apple.com
  • 17 edits
    1 copy
    4 moves
    2 adds
    14 deletes in trunk/Source/WebKit2

Consolidate main functions in WebKit2 now that they are all identical
https://bugs.webkit.org/show_bug.cgi?id=109748

Reviewed by Anders Carlsson.

  • Consolidates all the LegacyProcess main functions into ChildProcessMain.mm
  • Consolidates all the XPCService main functions into XPCServiceMain.mm and XPCServiceMain.Development.mm
  • Rename existing ChildProcessMain.h/mm to ChildProcessEntryPoint.h/mm to match the XPCService ones.
  • Switch LegacyProcess to use the "entry point in the plist" idiom, instead of hard coding each one, again matching the XPCService.
  • Configurations/BaseLegacyProcess.xcconfig: Add base configuration to hold common legacy process options.
  • Configurations/BaseXPCService.xcconfig:
  • Configurations/NetworkProcess.xcconfig:
  • Configurations/OfflineStorageProcess.xcconfig:
  • Configurations/PluginProcess.xcconfig:
  • Configurations/SharedWorkerProcess.xcconfig:
  • Configurations/WebContentProcess.xcconfig: Renamed form WebProcess.xcconfig.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Removed.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Removed.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Removed.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm:
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Removed.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Removed.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Removed.
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Removed.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Removed.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Replaced.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Removed.
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
2:43 PM Changeset in webkit [142805] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Exclusions] ExclusionPolygon reflex vertices should constrain the first fit location.
https://bugs.webkit.org/show_bug.cgi?id=107568

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-13
Reviewed by Dirk Schulze.

Source/WebCore:

The ExclusionPolygon::firstIncludedIntervalLogicalTop() method now includes offset edges
for each of the polygon's reflex vertices. The motivation for this change is explained
here: http://hansmuller-webkit.blogspot.com/2013/01/getting-to-point-reflex-vertices.html.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::isReflexVertex): Given three vertices that represent a pair of connected polygon edges, return true if the second vertex is a reflex vertex.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This method now includes offset edges for reflex vertices.

  • rendering/ExclusionPolygon.h:

(WebCore::OffsetPolygonEdge::OffsetPolygonEdge): Added a constructor for creating an OffsetPolygonEdge given a reflex vertex.
(WebCore::OffsetPolygonEdge::edgeIndex): Changed this property from unsigned to int. Now using -1 to indicate that the offset edge doesn't correspond to a single polygon edge.

LayoutTests:

In this carefully contrived test case, the Y coordinate of the origin of the line
of text is only computed correctly if the constraints implied by the polygon's
reflex vertices are considered.

  • fast/exclusions/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html: Added.
2:40 PM Changeset in webkit [142804] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Change another use of (SpecCell & ~SpecString) to SpecObject.

Reviewed by Mark Hahnenberg.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

2:40 PM Changeset in webkit [142803] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

CSSPreloadScanner should not depend on HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=109742

Reviewed by Eric Seidel.

There's no need for the CSSPreloadScanner to depend on HTMLToken. On
the background thread, we'll likely want to use a CompactHTMLToken for
preload scanning, so this dependency is problematic. This patch also
teaches the CSSPreloadScanner how to scan LChars.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::~CSSPreloadScanner):
(WebCore):
(WebCore::CSSPreloadScanner::scan):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::processToken):

2:39 PM Changeset in webkit [142802] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

cr-linux debug should use clang and maybe be a components build
https://bugs.webkit.org/show_bug.cgi?id=108512

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13
Reviewed by Adam Barth.

Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
Build bots will update clang with each bot cycle.
Updated GCE image paths to suit gcutil 1.6.1.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
  • EWSTools/start-queue.sh:
2:39 PM Changeset in webkit [142801] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix !ENABLE(BLOB) build.

Reviewed by NOBODY (OOPS!).

  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::getCachedOrigin):
  • page/SecurityOrigin.cpp: (WebCore::getCachedOrigin):
2:36 PM Changeset in webkit [142800] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726

Reviewed by Mark Hahnenberg.

If you add it to the list of relevant node types, you also need to make sure
it's listed as either hasChild or one of the other kinds. Otherwise you get
an assertion. This is causing test failures in run-javascriptcore-tests.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::MinifiedNode::hasChild):

2:31 PM Changeset in webkit [142799] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking a few tests as slow on the debug builds. This shall prevent them timing out unnecessarily.

  • platform/gtk/TestExpectations:
2:17 PM Changeset in webkit [142798] by jchaffraix@webkit.org
  • 14 edits
    4 adds in trunk

[CSS Grid Layout] Adding or removing grid items doesn't properly recompute the track sizes
https://bugs.webkit.org/show_bug.cgi?id=109100

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-removal-track-breadth-update.html

The test uncovered several bugs in our implementation that is fixed as part
of this change. They will be detailed below.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
Added this function to share the code between minContentForChild and maxContentForChild.
Also forced a relayout in this case to avoid getting a wrong answer (e.g. the logical height
constrained by the previous layout's grid breadth).

(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Updated to use logicalContentHeightForChild.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated to match the specification and set max breadth to current breadth per the specification.
This made us over-grow some cases in the test.

(WebCore::RenderGrid::distributeSpaceToTracks):
Updated to match the specification and use an extra variable to do the intermediate spreading. Also removed
a now unneeded max. This fixes the case of multiple grid items in the same grid area that was completely broken.

(WebCore::RenderGrid::layoutGridItems):
Added a FIXME about always relaying out content sized tracks' children.

  • rendering/RenderGrid.h:

Added logicalContentHeightForChild.

LayoutTests:

  • fast/css-grid-layout/grid-item-addition-track-breadth-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-addition-track-breadth-update.html: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html: Added.

New tests.

  • fast/css-grid-layout/resources/grid.css:

(.constrainedContainer):
(.unconstrainedContainer):
Added these class to share them with other tests.

  • fast/css-grid-layout/auto-content-resolution-columns.html:
  • fast/css-grid-layout/auto-content-resolution-rows.html:
  • fast/css-grid-layout/implicit-columns-auto-resolution.html:
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/implicit-rows-auto-resolution.html:
  • fast/css-grid-layout/minmax-max-content-resolution-columns.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:

Removed constrainedContainer definition as it was moved to grid.css.

2:12 PM Changeset in webkit [142797] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Rebasline after r142765

Unreviewed test expectations update.

The change caused sub-pixel changing in SVG-as-image positions.

  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
2:03 PM Changeset in webkit [142796] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Clean up some style nits in HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109738

Reviewed by Tony Gentilcore.

This patch just fixes a few style nits I noticed when reading through
the code.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::StartTagScanner):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::isSafeToSendToAnotherThread):

  • html/parser/HTMLResourcePreloader.h:

(PreloadRequest):
(WebCore::PreloadRequest::PreloadRequest):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):

2:02 PM Changeset in webkit [142795] by alecflett@chromium.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r142747.
http://trac.webkit.org/changeset/142747
https://bugs.webkit.org/show_bug.cgi?id=109746

broke component build (Requested by alecf_gardening on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(WebCore):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1:56 PM Changeset in webkit [142794] by Christophe Dumez
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using WebString in ewk_cookie_manager, ewk_form_submission_request and ewk_text_checker
https://bugs.webkit.org/show_bug.cgi?id=108794

Reviewed by Alexey Proskuryakov.

Stop using WebString in ewk_cookie_manager, ewk_form_submission_request
and ewk_text_checker as it is internal C++ API. WKString and
WKEinaSharedString are used instead.

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::leakString): Add leakString() method to
WKEinaSharedString so that we can conveniently convert a WKString to a
Eina shared string and take ownership of it.

  • UIProcess/API/cpp/efl/WKEinaSharedString.h:
  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(EwkFormSubmissionRequest::copyFieldValue):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):

  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(EwkFormSubmissionRequest):

  • UIProcess/API/efl/ewk_text_checker.cpp:

(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):

  • UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:

(TEST_F): Add API test for new WKEinaSharedString::leakString() method.

1:55 PM Changeset in webkit [142793] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137

Reviewed by Eric Seidel.

Source/WebCore:

First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.

Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html

  • rendering/InlineIterator.h:

(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.

LayoutTests:

  • fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
  • fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
1:49 PM Changeset in webkit [142792] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109744

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(Connection):

1:48 PM Changeset in webkit [142791] by akling@apple.com
  • 16 edits in trunk/Source/WebCore

Better names for ElementAttributeData & subclasses.
<http://webkit.org/b/109529>

Reviewed by Antti Koivisto.

  • ElementAttributeData => ElementData

Because ElementAttributeData won't be a good name once we move some non-attribute related
things to this structure.

  • ImmutableElementAttributeData => ShareableElementData

These objects can be shared with other Elements that have the same attribute name/value pairs.

  • MutableElementAttributeData => UniqueElementData

These objects contain data that is unique to a specific Element, and cannot be shared with
other Elements. This is what's important about it, not that its underlying storage is mutable.

  • attributeData() -> elementData()
  • updatedAttributeData() -> elementDataWithSynchronizedAttributes()
  • ensureUpdatedAttributeData() -> ensureElementDataWithSynchronizedAttributes()
  • mutableAttributeData() -> ensureUniqueElementData()

Ride-along renames. Much less vague than previous names IMO.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::ShareableElementDataCacheKey::ShareableElementDataCacheKey):
(WebCore::ShareableElementDataCacheKey::operator!=):
(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/DocumentSharedObjectPool.h:

(DocumentSharedObjectPool):

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::Element::reportMemoryUsage):
(WebCore::ElementData::deref):
(WebCore::ElementData::ElementData):
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ElementData::createShareableWithAttributes):
(WebCore::ElementData::createUnique):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
(WebCore::ElementData::makeMutableCopy):
(WebCore::ElementData::makeImmutableCopy):
(WebCore::ElementData::setPresentationAttributeStyle):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::ElementData::getAttributeItemIndexSlowCase):

  • dom/Element.h:

(ElementData):
(WebCore::ElementData::isUnique):
(ShareableElementData):
(UniqueElementData):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::elementData):
(Element):
(WebCore::Element::elementDataWithSynchronizedAttributes):
(WebCore::Element::ensureElementDataWithSynchronizedAttributes):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::classNames):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::updateInvalidAttributes):
(WebCore::Element::hasID):
(WebCore::Element::hasClass):
(WebCore::Element::ensureUniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::attributeItem):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::compareDocumentPosition):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
(WebCore::StyledElement::setInlineStyleFromString):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):

  • html/ClassList.cpp:

(WebCore::ClassList::classNames):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::updateAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

1:47 PM Changeset in webkit [142790] by jochen@chromium.org
  • 9 edits in trunk/Tools

[chromium] fix TestRunner build with enable_webrtc=0
https://bugs.webkit.org/show_bug.cgi?id=109700

Reviewed by Tony Chang.

We can't use ENABLE() macros in the TestRunner library, however,
ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::userMediaClient):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1:40 PM Changeset in webkit [142789] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

Rearranged the code somewhat to reduce the number of
DFG related ifdefs.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

1:36 PM Changeset in webkit [142788] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when encountering <object style="resize:both;">
https://bugs.webkit.org/show_bug.cgi?id=109728

Source/WebCore:

See also https://code.google.com/p/chromium/issues/detail?id=175535
This bug can be reproduced on
http://dramalink.net/tudou.y/?xink=162601060

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

Test: fast/css/resize-object-crash.html

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):
Only call paintResizer() if we have a layer and canResize() is true

LayoutTests:

See also https://code.google.com/p/chromium/issues/detail?id=175535

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

  • fast/css/resize-object-crash-expected.txt: Added.
  • fast/css/resize-object-crash.html: Added.
1:33 PM Changeset in webkit [142787] by arko@motorola.com
  • 3 edits in trunk/Source/WebCore

[Microdata] HTMLPropertiesCollection code cleanup
https://bugs.webkit.org/show_bug.cgi?id=109721

Reviewed by Ryosuke Niwa.

Removed forward declaration of DOMStringList class.
Removed unused findRefElements() method declaration.
Also Removed unused parameter Element* from updatePropertyCache() method.

No new test since no change in behavior.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateNameCache):

  • html/HTMLPropertiesCollection.h:

(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

1:30 PM Changeset in webkit [142786] by commit-queue@webkit.org
  • 9 edits in trunk

[WebGL][EFL][GTK][Qt]Add support for OES_vertex_array_object.
https://bugs.webkit.org/show_bug.cgi?id=109382

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-13
Reviewed by Kenneth Russell.

Source/WebCore:

Covered by fast/canvas/webgl/oes-vertex-array-object.html

This patch adds support for using Vertex Array Object with OpenGl.
The patch adds support for loading necessary opengl functions
and support for checking GL_ARB_vertex_array_object. The support
for OES_vertex_array_object is advertised if GL_ARB_vertex_array_object is
supported.

  • platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h:

(_OpenGLFunctionTable):
Added support for loading the necessary functions.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):

(WebCore):
(WebCore::Extensions3DOpenGL::isVertexArrayObjectSupported):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

LayoutTests:

Enable oes-vertex-array-object for EFL port.

  • fast/canvas/webgl/oes-vertex-array-object-expected.txt:
  • fast/canvas/webgl/oes-vertex-array-object.html:
  • platform/efl/TestExpectations:
1:29 PM Changeset in webkit [142785] by roger_fong@apple.com
  • 4 edits
    3 copies
    11 adds in trunk

TestWebKitAPI, record-memory and gtest-md projects and property sheets for VS2010.
https://bugs.webkit.org/show_bug.cgi?id=107034

Reviewed by Brent Fulgham.

  • TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
  • win/record-memory: Added.
  • win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
  • win/record-memory/record-memory.vcxproj: Added.
  • win/record-memory/record-memory.vcxproj.filters: Added.
  • win/record-memory/record-memoryCommon.props: Added.
  • win/record-memory/record-memoryDebug.props: Added.
  • win/record-memory/record-memoryRelease.props: Added.
  • gtest/msvc/gtest-md.vcxproj: Added.
  • gtest/msvc/gtest-md.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKit.sln:
1:29 PM Changeset in webkit [142784] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Lion build.

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

1:27 PM Changeset in webkit [142783] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove support for the DispatchOnConnectionQueue message attribute
https://bugs.webkit.org/show_bug.cgi?id=109743

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):

  • Scripts/webkit2/messages.py:

(handler_function):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
1:22 PM Changeset in webkit [142782] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk/Source

chromium: remove CompositorHUDFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=109328

Patch by Eberhard Graether <egraether@google.com> on 2013-02-13
Reviewed by James Robinson.

After switching the HudLayer to use skia's font rendering the
CompositorHUDFontAtlas has become obsolete. This change removes
this class and the related WebLayerTreeView API.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

No new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Removed.
  • platform/graphics/chromium/CompositorHUDFontAtlas.h: Removed.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
1:17 PM Changeset in webkit [142781] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

StorageManager should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109741

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
(WebKit::StorageManager::processWillCloseConnection):
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
1:15 PM Changeset in webkit [142780] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726

Reviewed by Gavin Barraclough.

This is asymptomatic because ForwardInt32ToDouble is only used in SetLocals, in
which case the value is already stored to the stack. Still, we should fix this.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):

1:00 PM Changeset in webkit [142779] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG LogicalNot/Branch peephole removal and inversion ignores the possibility of things exiting
https://bugs.webkit.org/show_bug.cgi?id=109489

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

If things can exit between the LogicalNot and the Branch then don't peephole.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-branch-logical-not-peephole-around-osr-exit-expected.txt: Added.
  • fast/js/dfg-branch-logical-not-peephole-around-osr-exit.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-branch-logical-not-peephole-around-osr-exit.js: Added.

(foo):

12:58 PM Changeset in webkit [142778] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

EventDispatcher should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109736

Reviewed by Andreas Kling.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::create):
(WebKit):
(WebKit::EventDispatcher::EventDispatcher):
(WebKit::EventDispatcher::initializeConnection):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebPage/EventDispatcher.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:

(WebKit):
(WebKit::WebProcess::eventDispatcher):
(WebProcess):

12:52 PM Changeset in webkit [142777] by mrobinson@webkit.org
  • 2 edits in trunk

Try to fix the build after r142756

  • Source/autotools/SetupAutomake.m4: Instead of using the (now gone) have_gstreamer

variable, activate GStreamer if either web audio or web video is enabled.

12:51 PM Changeset in webkit [142776] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r142768.

r142768 broke the EFL WK2 build due to wrong member initialization
order in the WebProcess constructor initialization list.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

12:34 PM Changeset in webkit [142775] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Small update to speech bubble for captions menu [Mac]
https://bugs.webkit.org/show_bug.cgi?id=109641

Reviewed by Eric Carlson

Small adjustment to the embedded SVG that draws a speech bubble
for the captions button. Remove a polygon that was so small
it looked like a rendering error.

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button):

12:34 PM Changeset in webkit [142774] by dino@apple.com
  • 9 edits in trunk

Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648

Reviewed by Eric Carlson.

Source/WebCore:

Add a virtual override to the platform-specific
defaultEventHandler to intercept any click in the controls,
and hide the captions menu if it is showing.

Test: media/video-controls-captions-trackmenu-hide-on-click.html

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::defaultEventHandler): Override from MediaControls. Hide

captions menu if a click event comes in.

  • html/shadow/MediaControlsApple.h:

LayoutTests:

New test for captions menu. Skip it everywhere but Mac.

  • media/video-controls-captions-trackmenu-hide-on-click.html: Added.
  • platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
12:32 PM Changeset in webkit [142773] by tommyw@google.com
  • 10 edits in trunk

MediaStream API: Use the source id when creating new tracks
https://bugs.webkit.org/show_bug.cgi?id=109688

Reviewed by Adam Barth.

Source/Platform:

Added id to initialize and renamed audio/videoSources to audio/videoTracks.

  • chromium/public/WebMediaStream.h:

(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):

  • chromium/public/WebMediaStreamTrack.h:

(WebMediaStreamTrack):

Source/WebCore:

This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.

Covered by existing tests.

  • platform/chromium/support/WebMediaStream.cpp:

(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):

  • platform/chromium/support/WebMediaStreamTrack.cpp:

(WebKit::WebMediaStreamTrack::initialize):
(WebKit):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Tools:

Switching mock to new API.

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:

(WebTestRunner::WebUserMediaClientMock::requestUserMedia):

12:23 PM Changeset in webkit [142772] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Use fancy new Vector-based String constructors in the WebVTT parser
https://bugs.webkit.org/show_bug.cgi?id=109619

Reviewed by Benjamin Poulain.

No change in behavior. Added some FIXMEs for future perf optimization.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

12:14 PM Changeset in webkit [142771] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

[Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
to include paths, to match VS2005 build behavior.

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
12:11 PM Changeset in webkit [142770] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

WebKit ignores column-rules wider than column-gap
https://bugs.webkit.org/show_bug.cgi?id=15553

Paint column rules even if they are wider than the gap.
Rules wider than the gap should just overlap with column contents.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-13
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/rule-thicker-than-gap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):

LayoutTests:

  • fast/multicol/rule-thicker-than-gap-expected.html: Added.
  • fast/multicol/rule-thicker-than-gap.html: Added.
12:08 PM Changeset in webkit [142769] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Remove unnecessary indirection to non-local variable access operations
https://bugs.webkit.org/show_bug.cgi?id=109724

Reviewed by Filip Pizlo.

Linked bytecode now stores a direct pointer to the resolve operation
vectors, so the interpreter no longer needs a bunch of indirection to
to perform non-local lookup.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/Instruction.h:
  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(ResolveOperationData):
(PutToBaseOperationData):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_put_to_base):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
12:08 PM Changeset in webkit [142768] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make PluginProcessConnectionManager a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109727

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::create):
(WebKit):
(WebKit::PluginProcessConnectionManager::PluginProcessConnectionManager):
(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::pluginProcessConnectionManager):

  • WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

12:05 PM Changeset in webkit [142767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r182150. Requested by
jamesr_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • DEPS:
11:56 AM Changeset in webkit [142766] by eric@webkit.org
  • 3 edits in trunk/Source/WTF

Don't copy Vector<UChar> when passing to new String methods from bug 109617
https://bugs.webkit.org/show_bug.cgi?id=109708

Reviewed by Tony Gentilcore.

Thanks for the catch Darin.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::create8BitIfPossible):

11:44 AM Changeset in webkit [142765] by pdr@google.com
  • 14 edits
    6 adds in trunk

Replace SVG bitmap cache with directly-rendered SVG
https://bugs.webkit.org/show_bug.cgi?id=106159

Reviewed by Tim Horton.

Source/WebCore:

This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
http://ie.microsoft.com/testdrive/Performance/Chalkboard/

On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(http://philbit.com/SvgImagePerformance/viewport.html):

without patch: ~20FPS
with patch: ~55FPS

The bitmap SVG image cache had several shortcomings:

  • The bitmap cache prevented viewport rendering. (WK104693)
  • Bitmap memory usage was high. (WK106484)
  • Caching animating images was expensive.

This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

Tests: svg/as-image/svg-image-scaled.html

svg/as-image/svg-image-viewbox.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):

SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):

drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:

the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed

SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.

(WebCore::SVGImage::drawPatternForContainer):

For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.

(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):

  • svg/graphics/SVGImage.h:

(WebCore):
(SVGImage):

  • svg/graphics/SVGImageCache.cpp:

Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.

To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.

Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.

(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):

Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.

(WebCore::SVGImageCache::imageForRenderer):

A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

  • svg/graphics/SVGImageForContainer.cpp: Added.

(WebCore):

SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.

(WebCore::SVGImageForContainer::size):

This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.

(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h: Added.

(WebCore):
(SVGImageForContainer):

In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

LayoutTests:

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

  • platform/chromium/TestExpectations:
  • svg/as-image/svg-image-scaled-expected.html: Added.
  • svg/as-image/svg-image-scaled.html: Added.
  • svg/as-image/svg-image-viewbox-expected.html: Added.
  • svg/as-image/svg-image-viewbox.html: Added.
11:30 AM Changeset in webkit [142764] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Avoid updating timer heap when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=109630

Reviewed by Andreas Kling.

When the fire time of a Timer is changed we remove it from the timer heap and reinsert it. This is pretty slow.
Turns out that in ~80% of cases we are already in the heap and the insertion position is the same as the
original position. We can check if anything is actually going to change before doing this work.

This makes starting a timer ~30% faster in average, ~0.1% progression in PLT3.

  • platform/Timer.cpp:

(TimerHeapLessThanFunction):
(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::parentHeapPropertyHolds):
(WebCore):
(WebCore::childHeapPropertyHolds):
(WebCore::TimerBase::hasValidHeapPosition):

The code here assumes that STL heap is a normal binary heap. If there is a different implementation
somewhere the assertions will catch it.

(WebCore::TimerBase::updateHeapIfNeeded):

Skip updating the heap if it is already valid.

(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(TimerBase):

11:18 AM Changeset in webkit [142763] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make SecItemShimProxy be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109719

Reviewed by Sam Weinig.

This adds a WantsConnection message attribute to be used for messages whose handlers
should take the connection the message was delivered to.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • Scripts/webkit2/messages.py:

(async_message_statement):
(generate_message_handler):
Handle the WantsMessage attribute.

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::shared):
Use dispatch_once and adoptRef.

(WebKit::SecItemShimProxy::SecItemShimProxy):
Initialize the queue.

(WebKit::SecItemShimProxy::initializeConnection):
Add the proxy as a work queue message receiver.

(WebKit::SecItemShimProxy::secItemRequest):
This no longer needs to call out to a dispatch queue, it's already on a queue.

  • UIProcess/mac/SecItemShimProxy.messages.in:

This doesn't need to be a legacy receiver. Also, add the WantsConnection message.

10:51 AM Changeset in webkit [142762] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716

Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

10:49 AM Changeset in webkit [142761] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[GTK] Remove remaining dead code from the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109707

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.

Source/WebCore:

  • platform/KURL.cpp:

(WebCore::appendEncodedHostname):

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

Source/WTF:

  • wtf/unicode/Unicode.h:
10:37 AM Changeset in webkit [142760] by wangxianzhu@chromium.org
  • 4 edits
    1 add in trunk

.: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects.
https://bugs.webkit.org/show_bug.cgi?id=108695

Add a manual test. Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.

Reviewed by Abhishek Arya.

  • ManualTests/scrolling-coordinator-viewport-constrained-crash.html: Added.

Source/WebCore: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects
https://bugs.webkit.org/show_bug.cgi?id=108695

See comments of RenderLayerModelObject::willBeDestroyed() below for details.

Reviewed by Abhishek Arya.

Test: ManulTests/scrolling-coordinator-viewport-constrained-crash.html
Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed): Moved removeViewportConstrainedObject() call into RenderLayerModelObject::willBeDestroyed() because only RenderLayerModelObjects can be added as viewportConstrainedObjects.

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::willBeDestroyed): Changed this->view() (then view->frameView()) to this->frame() (then frame->view()) because when willBeDestroyed() is called, the document has set its renderView to 0 thus this->view() will return 0, causing removeViewportConstrainedObject() not called and a deleted RenderLayerModelObject in FrameView's viewportConstrainedObjects.

9:49 AM Changeset in webkit [142759] by fmalita@chromium.org
  • 17 edits in trunk

[SVG] OOB access in SVGListProperty::replaceItemValues()
https://bugs.webkit.org/show_bug.cgi?id=109293

Source/WebCore:

Replacing a list property item with itself should be a no-op. This patch updates the related
APIs and logic to detect the self-replace case and prevent removal of the item from the list.

To avoid scanning the list multiple times, removeItemFromList() is updated to operate on
indices and a findItem() method is added to resolve an item to an index.

Reviewed by Dirk Schulze.

No new tests: updated existing tests cover the change.

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::findItem):
(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::findItem):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
Add a findItem() delegating method, and update removeItemFromList() to use the new
index-based API.

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(SVGListProperty):
Updated to handle the no-op case for insertItemBefore() & replaceItem().

  • svg/properties/SVGListPropertyTearOff.h:

(WebCore::SVGListPropertyTearOff::findItem):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
Index-based API updates.

(WebCore::SVGListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGListPropertyTearOff::processIncomingListItemWrapper):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue):
Detect the self-replace case and return without removing the item from the list.

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::findItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

  • svg/properties/SVGStaticListPropertyTearOff.h:

(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemWrapper):
Index-based API updates.

LayoutTests:

Updated tests to cover the crash and new behavior.

Reviewed by Dirk Schulze.

  • svg/dom/SVGLengthList-basics-expected.txt:
  • svg/dom/SVGLengthList-basics.xhtml:
  • svg/dom/SVGNumberList-basics-expected.txt:
  • svg/dom/SVGNumberList-basics.xhtml:
  • svg/dom/SVGPointList-basics-expected.txt:
  • svg/dom/SVGPointList-basics.xhtml:
  • svg/dom/SVGTransformList-basics-expected.txt:
  • svg/dom/SVGTransformList-basics.xhtml:
9:46 AM Changeset in webkit [142758] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL] Cleanup of graphics related code in EwkView
https://bugs.webkit.org/show_bug.cgi?id=109377

Reviewed by Anders Carlsson.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

Initialize the evasGL dependencies here and
set m_isAccelerated to false if this fails.

Set the coordinated graphics scene as active
when using fixed layout.

(EwkView::setSize):

Add a method to set the size and user-viewport
transform from the outside. The idea is moving
this to our pure WK C API in the future.

(EwkView::transformFromScene):
(EwkView::transformToScene):

Update the transform methods to use the user-
viewport transform.

(EwkView::paintToCurrentGLContext):
(EwkView::paintToCairoSurface):

Add methods to paint to either the current GL context
or to a given cairo_surface_t (for software fallback
cases).

(EwkView::displayTimerFired):

Clean up and use the two above methods.

(EwkView::scheduleUpdateDisplay):

Use the new size() methods instead of using the
smart-object data directly.

(EwkView::createGLSurface):

Make this method use size() to query the surface size
and avoid creating the context (done in ctor now).
Also avoid using the smart-object data directly.

(EwkView::enterAcceleratedCompositingMode):
(EwkView::exitAcceleratedCompositingMode):

Turn on/off the use of the coord. graphics scene.

(EwkView::handleEvasObjectCalculate):

Use the new setSize and setUserViewportTransform.

(EwkView::takeSnapshot):

  • UIProcess/API/efl/EwkView.h:

(WebCore):
(EwkView):
(EwkView::size):
(EwkView::setUserViewportTransform):
(EwkView::userViewportTransform):

Add the new method definitions and rename isHardwareAccelerated
to isAccelerated which fits better with the naming in WebCore.

9:26 AM Changeset in webkit [142757] by tasak@google.com
  • 6 edits in trunk

Source/WebCore: [Refactoring] StyleResolver::State should have methods to access its member variables.
https://bugs.webkit.org/show_bug.cgi?id=108563

Reviewed by Antti Koivisto.

Made all member variables private and added methods to access the
variables, because most of the member variables are read-only.
We don't need to update those read-only variables while resolving
styles.

No new tests, because just refactoring.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::initElement):
Modified to invoke m_state.initElement if a given element is
different from current m_state's element.
(WebCore::StyleResolver::State::initForStyleResolve):
Moved from StyleResolver.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
Changed ASSERT in the first line. ASSERT(m_state.parentStyle) would be
wrong, because it depends on previous resolving. However,
initForStyleResolve will also update m_state.parentStyle. No code in
pseudoStyleForElement depends on previous resolving state.
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
Added one more parameter, dynamicPseudo, because dynamicPseudo in
State class is just used for returning matched pseudo style from
this ruleMatches to collectMatchingRulesForList. No need to keep
dynamicPseudo while resolving styles.
(WebCore::StyleResolver::checkRegionSelector):
Removed m_pseudoStyle = NOPSEUDO, because this method uses just
SelectorChecker::matched. SelectorChecker doesn't see StyleResolver's
m_pseudoStyle directly. Need to use SelectorCheckerContext. So no
need to set m_pseudoStyle to be NOPSEUDO.
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):

  • css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::clear):
Modified to use clear at the end of styleForElement.
(WebCore::StyleResolver::State::document):
(WebCore::StyleResolver::State::element):
(WebCore::StyleResolver::State::styledElement):
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::State::style):
(WebCore::StyleResolver::State::takeStyle):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::parentNode):
(WebCore::StyleResolver::State::setParentStyle):
(WebCore::StyleResolver::State::parentStyle):
(WebCore::StyleResolver::State::rootElementStyle):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyle):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::distributedToInsertionPoint):
(WebCore::StyleResolver::State::setElementAffectedByClassRules):
(WebCore::StyleResolver::State::elementAffectedByClassRules):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::applyPropertyToRegularStyle):
(WebCore::StyleResolver::State::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::pendingImageProperties):
(WebCore::StyleResolver::State::pendingSVGDocuments):
(WebCore::StyleResolver::State::setHasPendingShaders):
(WebCore::StyleResolver::State::hasPendingShaders):
(WebCore::StyleResolver::State::setLineHeightValue):
(WebCore::StyleResolver::State::lineHeightValue):
(WebCore::StyleResolver::State::setFontDirty):
(WebCore::StyleResolver::State::fontDirty):
(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::State::hasUAAppearance):
(WebCore::StyleResolver::State::borderData):
(WebCore::StyleResolver::State::backgroundData):
(WebCore::StyleResolver::State::backgroundColor):
(WebCore::StyleResolver::State::fontDescription):
(WebCore::StyleResolver::State::parentFontDescription):
(WebCore::StyleResolver::State::setFontDescription):
(WebCore::StyleResolver::State::setZoom):
(WebCore::StyleResolver::State::setEffectiveZoom):
(WebCore::StyleResolver::State::setTextSizeAdjust):
(WebCore::StyleResolver::State::setWritingMode):
(WebCore::StyleResolver::State::setTextOrientation):
fontDescription, ... and setTextOrientation were moved from
StyleResolver.
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
Moved from StyleResolver.
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
These fontDescription, ..., setTextOrientation are wrappers to
invoke State's methods. StyleBuilder still depends on StyleResolver
and invokes these methods. So we need these wrappers.

LayoutTests: [Refactoring] StyleResolver::State should have methods to access its me
https://bugs.webkit.org/show_bug.cgi?id=108563

Reviewed by Antti Koivisto.

  • inspector/styles/region-style-crash-expected.txt:

Rebaseline. Since inspector hasn't supported CSS region styles yet,
region-style-crash.html has no CSS region styles as its result.

9:24 AM Changeset in webkit [142756] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] Remove support for compiling with GStreamer 0.10
https://bugs.webkit.org/show_bug.cgi?id=109593

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.

Remove support for building WebKitGTK+ with GStreamer 0.10. We
can simplify things greatly because we don't have to worry any
longer about selecting one GStreamer API set.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/autotools/Versions.m4:
9:21 AM Changeset in webkit [142755] by allan.jensen@digia.com
  • 8 edits in trunk/Source

[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

9:01 AM Changeset in webkit [142754] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

The 2D Canvas functions fillText()/strokeText() should display nothing when maxWidth is less then or equal to zero
https://bugs.webkit.org/show_bug.cgi?id=102656

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-13
Reviewed by Dirk Schulze.

The functions fillText()/strokeText() should not display anything when
maxWidth is less than or equal to zero, according to spec :
http://www.w3.org/TR/2dcontext/#text-preparation-algorithm

Source/WebCore:

Test: fast/canvas/canvas-fillText-maxWidth-zero.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

  • fast/canvas/canvas-fillText-invalid-maxWidth-expected.txt: Added.
  • fast/canvas/canvas-fillText-invalid-maxWidth.html: Added.
  • fast/canvas/canvas-strokeText-invalid-maxWidth-expected.txt: Added.
  • fast/canvas/canvas-strokeText-invalid-maxWidth.html: Added.
  • fast/canvas/script-tests/canvas-fillText-invalid-maxWidth.js: Added.
  • fast/canvas/script-tests/canvas-strokeText-invalid-maxWidth.js: Added.
8:47 AM Changeset in webkit [142753] by sergio@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Provide the same custom expectations as all the other
platforms. This likely means that there is a bug in the code or
that the expected result is incorrect.

  • platform/gtk/TestExpectations:
  • platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.
8:25 AM Changeset in webkit [142752] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
https://bugs.webkit.org/show_bug.cgi?id=109611

The deltas in mousewheel events generated by track can be accelerated (e.g. when
scrolling repeatedly). Keep track of the ratio of the acceleration since that is
useful for some tasks (e.g. overflow navigation gesture).

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2013-02-13
Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebMouseWheelEvent):

8:23 AM Changeset in webkit [142751] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

replaceWithJump should not decrease the offset by 1 on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109689

Reviewed by Zoltan Herczeg.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::replaceWithJump):

8:16 AM Changeset in webkit [142750] by Christophe Dumez
  • 13 edits
    4 copies in trunk/Source/WebKit2

[EFL][WK2] Introduce WKViewClient C API
https://bugs.webkit.org/show_bug.cgi?id=109559

Reviewed by Anders Carlsson.

This patch introduces the WKViewClient C API for EFL's WKView. The purpose of
this new C API is to eventually remove the interdependency between EFL's
PageClient and EwkView. When completed, PageClient should only interact with
WebView and not be aware of EwkView so that we have a clean separation between
internal WebKit2 classes and our EFL Ewk API implementation.

This patch is only a first step towards this goal as there is a lot of work
to do to achieve complete separation between EwkView and PageClient. The purpose
of this patch is to introduce the needed architecture which will later be
extended by introducing new WKViewClient callbacks.

  • PlatformEfl.cmake: Add new ViewClientEfl.cpp and WebViewClient.cpp to EFL's CMake

configuration.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetViewClient):

  • UIProcess/API/C/efl/WKView.h: Introduce new WKViewClient C API.
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView): Initialize ViewClientEfl.

  • UIProcess/API/efl/EwkView.h: Add new ViewClientEfl member.

(WebKit):
(EwkView):

  • UIProcess/API/efl/EwkViewCallbacks.h: Update ContentsSizeChanged smart callback to

accept a WKSize in parameter instead of an IntRect.

  • UIProcess/efl/PageClientBase.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientBase::view):
(WebKit::PageClientBase::setViewNeedsDisplay):

  • UIProcess/efl/PageClientBase.h:

(WebKit):
(PageClientBase):

  • UIProcess/efl/PageClientDefaultImpl.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientDefaultImpl::didChangeContentsSize):

  • UIProcess/efl/PageClientLegacyImpl.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientLegacyImpl::didChangeContentsSize):

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit):
(WebKit::ViewClientEfl::toEwkView):
(WebKit::ViewClientEfl::viewNeedsDisplay):
(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):

  • UIProcess/efl/ViewClientEfl.h: Introduce new ViewClientEfl which handles WKViewClient callbacks

and interacts with EwkView.
(WebKit):
(ViewClientEfl):
(WebKit::ViewClientEfl::create):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::initializeClient):
(WebKit):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::didChangeContentsSize):

  • UIProcess/efl/WebView.h: Add new WebViewClient member and corresponding methods to interact

with it.
(WebView):

  • UIProcess/efl/WebViewClient.cpp:

(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):

  • UIProcess/efl/WebViewClient.h: Add new WebViewClient APIClient for WKViewClient.

(WebCore):
(WebKit):

8:15 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
8:12 AM Changeset in webkit [142749] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GTK][AC] Implement basic transform animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109363

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-13
Reviewed by Gustavo Noronha Silva.

Implement basic transform animation with clutter ac backend.
GraphicsLayerClutter is almost same with GraphicsLayerCA. And PlatformClutterAnimation
interfaces are also similar with PlatformCAAnimation, but they are implemented
with native clutter APIs. Clutter backend AC supports a basic single transform animation
with this patch now, but additive animation combination and keyframe animation
are not supported yet.

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetTransform):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::isTransformTypeTransformationMatrix):
(WebCore):
(WebCore::isTransformTypeFloatPoint3D):
(WebCore::isTransformTypeNumber):
(WebCore::getTransformFunctionValue):
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::appendToUncommittedAnimations):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString):
(WebCore):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

7:57 AM Changeset in webkit [142748] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk

[WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
https://bugs.webkit.org/show_bug.cgi?id=109456

Reviewed by Anders Carlsson.

Source/WebKit2:

WebView destructor now considers the situation if its WebPageProxy
instance had been closed from outside the class (explicitly
by client code).

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::~WebView):

Tools:

WebView instance must not live longer than EwkView, as EwkView owns
objects that page proxy refers to, doing otherwise leads to a crash.

Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
leads to evas objects deletion. So, the problem was that test controller was
deleted after ewk_shutdown() had been called in main() function causing
crashes on WTR exit.

The patch introduces a scope for test controller so that it is deleted first.

  • WebKitTestRunner/efl/main.cpp:

(main):

7:30 AM Changeset in webkit [142747] by loislo@chromium.org
  • 6 edits
    1 add in trunk

Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554

In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.

Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.

Reviewed by Yury Semikhatsky.

It is covered by newly added tests in TestWebKitAPI.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.

(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):

7:27 AM Changeset in webkit [142746] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: add experimental native heap graph to Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=109687

Reviewed by Alexander Pavlov.

Added experimentatl support for native heap graph on the Timeline panel.
Native memory usage data is collected after each top level task and can
be displayed instead of DOM counters graph on the Timeline panel if
corresponding experiment is enabled in the inspector settings.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineAgentState):
(WebCore::InspectorTimelineAgent::setIncludeDomCounters):
(WebCore):
(WebCore::InspectorTimelineAgent::setIncludeNativeMemoryStatistics):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):

  • inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelinePanel.js:
7:25 AM Changeset in webkit [142745] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.

No new tests.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):

6:27 AM Changeset in webkit [142744] by atwilson@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed chromium expectation changes resulting from r142719.

  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
6:19 AM Changeset in webkit [142743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix js compilation warnings in TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109685

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

Mark last argument of _applySuggestion function as optional.

No new tests: no change in behaviour.

  • inspector/front-end/TextPrompt.js:
6:09 AM Changeset in webkit [142742] by thiago.santos@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations:
6:04 AM Changeset in webkit [142741] by atwilson@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed chromium expectation changes.
Fallout from r142683.

  • platform/chromium-win/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
6:03 AM Changeset in webkit [142740] by benm@google.com
  • 13 edits
    1 copy
    6 deletes in branches/chromium/1364

Merge 141769

Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

  • features.gypi:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):

  • tests/data/non-fast-scrollable.html:
  • tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

  • compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/iframe-inside-overflow-clipping.html:
  • compositing/overflow/nested-scrolling.html:
  • compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/scrolling-without-painting.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/overflow/updating-scrolling-content.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.

TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/12254005

5:45 AM Changeset in webkit [142739] by commit-queue@webkit.org
  • 30 edits
    5 adds in trunk

Implement css-conditional's CSS.supports()
https://bugs.webkit.org/show_bug.cgi?id=100324

Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-13
Reviewed by Antti Koivisto.

Source/WebCore:

http://dev.w3.org/csswg/css3-conditional/#the-css-interface

The supports() method provides the css @supports rule's corresponding
dom api.
The patch also adds the CSS interface on DOMWindow, which holds "useful
CSS-related functions that do not belong elsewhere". This is where
supports() lives.

Test: css3/supports-dom-api.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

Add DOMWindowCSS.* to the build systems.

  • bindings/scripts/CodeGenerator.pm:

(WK_lcfirst):

Handle CSS prefixes correctly (s/cSS/css/).

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSupportsCondition):
(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:

webkit_supports_condition parses just the condition part of an
@supports rule and evaluates it, outputting whether the condition
is supported or not.

  • css/CSSAllInOne.cpp:
  • css/DOMWindowCSS.cpp: Added.
  • css/DOMWindowCSS.h: Added.
  • css/DOMWindowCSS.idl: Added.

The CSS interface object.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::css):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

window.CSS

LayoutTests:

  • css3/supports-dom-api-expected.txt: Added.
  • css3/supports-dom-api.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
5:15 AM Changeset in webkit [142738] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Simplify SplitView to rely more on CSS
https://bugs.webkit.org/show_bug.cgi?id=109426

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Vsevolod Vlasov.

Simplified Javascript code by moving large part of the layout logic into CSS rules. The patch is larger than it
should be because one of the clients (TimelinePanel) is breaking SplitView incapsulation by reparenting its
resizer.

No new tests.

  • inspector/front-end/SidebarView.js:

(WebInspector.SidebarView):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype._innerSetVertical):
(WebInspector.SplitView.prototype.setSecondIsSidebar):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/cssNamedFlows.css:

(.css-named-flow-collections-view .split-view-sidebar):
(.css-named-flow-collections-view .split-view-sidebar .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar .selection):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before, .css-named-flow-collections-view .region-empty:before, .css-named-flow-collections-view .region-fit::before, .css-named-flow-collections-view .region-overset::before):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before):

  • inspector/front-end/splitView.css:

(.split-view-contents.maximized):
(.split-view-vertical .split-view-contents):
(.split-view-vertical .split-view-contents-first):
(.split-view-vertical .split-view-contents-first.maximized):
(.split-view-vertical .split-view-contents-second):
(.split-view-vertical .split-view-contents-second.maximized):
(.split-view-horizontal .split-view-contents):
(.split-view-horizontal .split-view-contents-first):
(.split-view-horizontal .split-view-contents-first.maximized):
(.split-view-horizontal .split-view-contents-second):
(.split-view-horizontal .split-view-contents-second.maximized):
(.split-view-vertical .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical .split-view-resizer):
(.split-view-horizontal .split-view-resizer):

  • inspector/front-end/timelinePanel.css:

(.timeline.split-view-vertical .split-view-resizer):
(#timeline-container .split-view-sidebar):

4:57 AM Changeset in webkit [142737] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r142730.
http://trac.webkit.org/changeset/142730
https://bugs.webkit.org/show_bug.cgi?id=109666

chromium browser tests are failing

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

3:59 AM Changeset in webkit [142736] by gyuyoung.kim@samsung.com
  • 11 edits in trunk

[WK2] Remove web intents callbacks
https://bugs.webkit.org/show_bug.cgi?id=109654

Reviewed by Benjamin Poulain.

Web intents was removed by r142549.

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

3:39 AM Changeset in webkit [142735] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

OpenCL implementation of Flood SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=109580

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-13
Reviewed by Zoltan Herczeg.

  • Target.pri:
  • platform/graphics/filters/FEFlood.h:

(FEFlood):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore):
(WebCore::PROGRAM_STR):
(WebCore::FilterContextOpenCL::compileFill):
(WebCore::FilterContextOpenCL::fill):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Added.

(WebCore):
(WebCore::FEFlood::platformApplyOpenCL):

3:19 AM Changeset in webkit [142734] by mkwst@chromium.org
  • 11 edits
    1 copy
    2 adds in trunk

location.href does not throw SECURITY_ERR when accessed across origins with JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=43891

Reviewed by Adam Barth.

Source/WebCore:

Other browsers (IE, Firefox, and Opera) throw an exception when accessing
properties of a Location object across origins, as the spec suggests[1].
WebKit is currently the outlier.

This has a few negative effects: developers are forced to hack around
access violations in two ways rather than having a single code path, and
(more annoyingly) developers are unable to avoid generating the error
message. See every ad on the internet for the effect on the console. :)

This patch adds a SECURITY_ERR exception to these access violations,
which is the first step towards getting rid of the console spam. Getting
rid of the message entirely will require a solution to
http://wkbug.com/98050.

A fairly inconclusive thread[2] on webkit-dev popped up in 2010 and
trailed off without reaching conclusion. A more recent thread reached
agreement that this patch seems like a reasonable thing to do[3].

This is the JSC half of the patch. V8 is coming in http://wkbug.com/43892

[1]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#security-location
[2]: https://lists.webkit.org/pipermail/webkit-dev/2010-August/013880.html
[2]: https://lists.webkit.org/pipermail/webkit-dev/2012-February/023636.html

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

  • http/tests/plugins/resources/cross-frame-object-access.html:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-get.html:
  • http/tests/security/resources/cross-frame-access.js:

(accessThrowsException):

  • http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
  • http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:

Adjusting tests to check for exceptions, and adjusting expectations to match.

  • platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Added.
  • platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Copied from LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt.

V8 fails at the moment: http://wkbug.com/43892

2:59 AM Changeset in webkit [142733] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix: removed redundant testRunnet.notifyDone() call that was causing other test failures.

  • inspector/script-execution-state-change-notification.html:
2:45 AM Changeset in webkit [142732] by zandobersek@gmail.com
  • 9 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining tests after the DOM4 Events constructors and CSS image-set
support were enabled.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/gtk/fast/events/constructors: Added.
  • platform/gtk/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
  • platform/gtk/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt:
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt:
  • platform/gtk/fast/hidpi/image-set-simple-expected.txt:
  • platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt:
2:39 AM Changeset in webkit [142731] by atwilson@chromium.org
  • 10 edits in trunk/Source

Unreviewed Chromium gyp-file cleanup after glib backend removal.
https://bugs.webkit.org/show_bug.cgi?id=109672

Removed references to GLib unicode backend:

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/gtk:

  • gyp/Configuration.gypi.in:
  • gyp/Dependencies.gyp:
  • gyp/JavaScriptCore.gyp:
  • gyp/WTF.gyp:

Source/WTF:

  • WTF.gyp/WTF.gyp:
  • WTF.gypi:
2:04 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:58 AM calendar-picker.png attached to EnableFormFeatures by tkent@chromium.org
1:54 AM multiple-fields-example.png attached to EnableFormFeatures by tkent@chromium.org
1:50 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:43 AM Changeset in webkit [142730] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666

Reviewed by Adam Barth.

Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). We should generate
wrapper methods for custom getters/setters.

In the future, I will insert TRACE_EVENT() macros into these wrapper methods
to profile DOM getters/setters/methods.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):

1:28 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:27 AM Changeset in webkit [142729] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

  • platform/qt/TestExpectations:
1:21 AM WikiStart edited by tkent@chromium.org
(diff)
1:21 AM WikiStart edited by tkent@chromium.org
(diff)
1:21 AM EnableFormFeatures created by tkent@chromium.org
1:15 AM WikiStart edited by tkent@chromium.org
(diff)
12:24 AM Changeset in webkit [142728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r142611.
http://trac.webkit.org/changeset/142611
https://bugs.webkit.org/show_bug.cgi?id=109668

Suggest box is not shown anymore when user types "window." in
inspector console. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

12:10 AM Changeset in webkit [142727] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] There is no XXXConstructor that requires a custom getter
https://bugs.webkit.org/show_bug.cgi?id=109667

Reviewed by Adam Barth.

Currently '[Custom] attribute XXXConstructor xxx' generates
XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
In addition, it does make no sense to generate XXXAttrGetter() for such cases.
We can remove the logic from CodeGeneratorV8.pm.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):

Feb 12, 2013:

11:34 PM Changeset in webkit [142726] by morrita@google.com
  • 3 edits
    2 adds in trunk

[Internals] setShadowDOMEnabled() shouldn't be used except a few tests.
https://bugs.webkit.org/show_bug.cgi?id=109642

Reviewed by Kent Tamura.

Source/WebCore:

InternalSettings.setShadowDOMEnabled() shouldn't be called after
any relevant DOM bindings are touched. However for fuzzers, it
isn't trivial to regulate its behavior.

This change whitelists the URL of running test for prevent
unintended API calls. This doesn't hurt the Internals usability
since the API is called from just a couple of tests and the number
isn't expected to grow.

Test: fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html

  • testing/InternalSettings.cpp:

(WebCore::urlIsWhitelisted):
(WebCore):
(WebCore::InternalSettings::setShadowDOMEnabled):

LayoutTests:

  • fast/dom/shadow/shadow-dom-enabled-flag-whitelist-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html: Added.
11:24 PM Changeset in webkit [142725] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch introduces version controller that could be used to migrate inspector settings.

Test: inspector/version-controller.html

  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/version-controller-expected.txt: Added.
  • inspector/version-controller.html: Added.
10:30 PM Changeset in webkit [142724] by commit-queue@webkit.org
  • 9 edits
    5 deletes in trunk

[GTK] Remove the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109627

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Benjamin Poulain.

.:

Remove references to the GLib unicode backend from configuration.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/autotools/SetupAutomake.m4:

Source/WebCore:

Remove references to the GLib unicode backend from WebCore.

  • GNUmakefile.list.am: Update the source list.
  • platform/text/gtk/TextBreakIteratorGtk.cpp: Removed.
  • platform/text/gtk/TextCodecGtk.cpp: Removed.
  • platform/text/gtk/TextCodecGtk.h: Removed.

Source/WTF:

Remove references to the GLib unicode backend from WTF.

  • GNUmakefile.list.am: Remove GLib unicode files from the source list.
  • wtf/unicode/glib/UnicodeGLib.cpp: Removed.
  • wtf/unicode/glib/UnicodeGLib.h: Removed.
10:21 PM Changeset in webkit [142723] by fpizlo@apple.com
  • 7 edits
    3 deletes in trunk/LayoutTests

Eradicate fast/js/dfg-poison-fuzz.html
https://bugs.webkit.org/show_bug.cgi?id=109660

Unreviewed.

I haven't seen this test fail in ages. And I've seen a lot of DFG bugs!

This is a super expensive test for one bug that used to be in the DFG but that has
since been thoroughly eradicated. Likely the plethora of other DFG tests cover that
bug. Heck, I'm not even sure if the code that this covers is even in the repository
anymore.

In the spirit of not having super expensive and mostly useless tests, I'm removing
this test.

  • fast/js/dfg-poison-fuzz-expected.txt: Removed.
  • fast/js/dfg-poison-fuzz.html: Removed.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-poison-fuzz.js: Removed.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
10:16 PM Changeset in webkit [142722] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

10:15 PM Changeset in webkit [142721] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: crash when accessing AccessibilityScrollbar after page has been unloaded
https://bugs.webkit.org/show_bug.cgi?id=109524

Reviewed by Ryosuke Niwa.

AX clients can hold onto AccesibilityScrollbar references that reference parent
AccessibilityScrollViews that have already gone away.

AccessibilityScrollView is not calling detachFromParent after it is removed, which
leads to a crash. The fix is to clearChildren() when an object is deallocated.

I could not create a test because the crash only manifests over multiple page loads.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::detach):
10:13 PM Changeset in webkit [142720] by Lucas Forschler
  • 1 copy in tags/Safari-537.31

New Tag.

10:09 PM Changeset in webkit [142719] by hayato@chromium.org
  • 4 edits in trunk/Source/WebCore

Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=109650

Reviewed by Dimitri Glazkov.

Set FocusEvent.relatedTarget in its constructor so that each
EventDispatchMediator can use FocusEvent.relatedTarget rather than
its redundant m_{old,new}FocusedNode member variable.

I've also removed FIXME comments, mentioning bug 109261, since I
can not reproduce the issue.

No new tests. No change in functionality.

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/FocusEvent.h:

(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

9:17 PM Changeset in webkit [142718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Remove unnecessary and confusing includes from StreamBuffer.h.
https://bugs.webkit.org/show_bug.cgi?id=109652

Patch by Takeshi Yoshino <tyoshino@google.com> on 2013-02-12
Reviewed by Benjamin Poulain.

StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
FixedArray.h and PassOwnPtr.h are included but not used.

VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
is even slower).

  • wtf/StreamBuffer.h:
9:10 PM Changeset in webkit [142717] by tasak@google.com
  • 6 edits in trunk/Source/WebCore

[Refactoring] Make SelectorChecker::mode a constructor parameter.
https://bugs.webkit.org/show_bug.cgi?id=109653

Reviewed by Dimitri Glazkov.

No new tests, because just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
Made mode a constructor parameter.

  • css/SelectorChecker.h:

Removed setMode.
(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::ContentSelectorChecker):

8:58 PM Changeset in webkit [142716] by keishi@webkit.org
  • 6 edits
    3 copies in branches/chromium/1364

Merge 142572

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

  • Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.

TBR=keishi@webkit.org

8:38 PM Changeset in webkit [142715] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

[Chromium] Rebaseline suggestion-picker layout tests
https://bugs.webkit.org/show_bug.cgi?id=109647

Unreviewed rebaseline.
Text position differences, imperceptible to human sight.
Test failures possibly caused by: http://trac.webkit.org/changeset/142659

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-12

  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
8:27 PM Changeset in webkit [142714] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Remove Element::ensureAttributeData().
<http://webkit.org/b/109643>

Reviewed by Anders Carlsson.

  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):

Use attributeData() instead of ensureAttributeData(), it's already guaranteed to exist in
both these functions as they are called in response to attribute changes.

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

Use mutableAttributeData() instead of ensureAttributeData() when invalidating animated
SVG attributes. While I can't find any bugs caused by this, an element with property animations
shouldn't share attribute data with other elements.

8:25 PM Changeset in webkit [142713] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Make {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator type safe.
https://bugs.webkit.org/show_bug.cgi?id=109561

Reviewed by Dimitri Glazkov.

Use FocusEvent rather than Event in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.

No new tests. No change in functionality.

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):

  • dom/FocusEvent.h:

(FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::event):
(BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::event):
(FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::event):
(FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::event):

8:24 PM Changeset in webkit [142712] by eric@webkit.org
  • 10 edits in trunk/Source/WebCore

Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions
https://bugs.webkit.org/show_bug.cgi?id=109638

Reviewed by Adam Barth.

Darin Adler noted in:
https://bugs.webkit.org/show_bug.cgi?id=109408#c4
that HTMLToken::Attribute (then MarkupTokenBase::Attribute)
was a struct, yet incorrectly used m_ for its public members.

This patch fixes the members to not have the m_, and since I was
touching all callers, I also updated all callers to use modern
Vector-based String creation/append functions instead of manually
calling UChar*, size_t versions.

There should be no behavior change to this patch. Where I saw
performance/memory bugs, I noted them with FIXMEs to keep
this change simple.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken):

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLToken.h:

(Range):
(Attribute):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::eraseValueOfAttribute):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::nameForAttribute):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

8:08 PM Changeset in webkit [142711] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

  • editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

7:59 PM Changeset in webkit [142710] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Build fix for Chromium-Win.
Add #include <functional> for std::bind1st.

  • tests/PrerenderingTest.cpp:
7:26 PM Changeset in webkit [142709] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/features.gypi

Merge 141193
BUG=175910
Review URL: https://codereview.chromium.org/12250029

7:05 PM Changeset in webkit [142708] by cevans@google.com
  • 163 edits in branches/chromium/1364/Source

Merge 141034
BUG=175910
Review URL: https://codereview.chromium.org/12251015

6:42 PM Changeset in webkit [142707] by Nate Chapin
  • 7 edits
    3 adds in trunk

REGRESSION: Reloading a local file doesn't pick up changes
https://bugs.webkit.org/show_bug.cgi?id=109344

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/cache/reload-main-resource.php

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::cachePolicy): Don't use subresourceCachePolicy()

for main resources.

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

LayoutTests:

  • http/tests/cache/reload-main-resource-expected.txt: Added.
  • http/tests/cache/reload-main-resource.php: Added.
  • http/tests/cache/resources/reload-main-resource-iframe.php: Added.
  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt: This test

was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.

  • http/tests/misc/link-rel-icon-beforeload-expected.txt: This test

was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.

6:40 PM Changeset in webkit [142706] by mrobinson@webkit.org
  • 3 edits
    5 adds
    1 delete in trunk/Source/WebKit/gtk

[GTK] Connect the gyp build to autoconf
https://bugs.webkit.org/show_bug.cgi?id=109360

Reviewed by Dirk Pranke.

Move Configuration.gypi to Configuration.gypi.in and allow autoconf to
fill in variables during a configuration phase. Also add some scripts
to support connecting autoconf up to the gyp build. This allows us
to have a very autotools-esque experience.

  • gyp/Configuration.gypi: Removed.
  • gyp/Configuration.gypi.in: Added. Fleshed out Configuration.gypi to include

dependency CFLAGS and LIBS directly from configure. Due to the way we are
generating the gyp build now, we also need to include an absolute path to
the build directory. Fixing bugs in gyp should allow us to avoid this in the
future.

  • gyp/Dependencies.gyp: Added this file which holds external dependency targets.

We could consider auto-generating this at some point.

  • gyp/JavaScriptCore.gyp: Remove references to the old Configuration.gypi.

It's now included via the command-line -I flag. Update to support the new
s/default/global/g terminology for variables.

  • gyp/WTF.gyp: Remove the dependency targets as this is now handled entirely

by autoconf.

  • gyp/autogen.sh: Added. Set up the build directory and kick off autoconf.
  • gyp/configure.ac: Added. An autoconf build that re-uses much of our

existing autoconf setup.

  • gyp/run-gyp: Added. Script for invoking gyp for out-of-tree builds.
6:39 PM Changeset in webkit [142705] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller
https://bugs.webkit.org/show_bug.cgi?id=109549

Reviewed by Tony Chang.

Renamed avoidIntersectionWithNode to Editor::avoidIntersectionWithDeleteButtonController and added trivial
implementations when delete button controllers are disabled (ENABLE_DELETION_UI is 0).

  • editing/DeleteButtonController.cpp:
  • editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):

  • editing/Editor.cpp:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Moved from htmlediting.cpp and renamed.
The version that takes VisibleSelection has been updated to use updatePositionForNodeRemoval to share
mode code with that function.
(WebCore::Editor::rangeForPoint):

  • editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Added; trivial implementations.

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:

(WebCore::createMarkupInternal): Extracted from createMarkup.
(WebCore::createMarkup):

6:39 PM Changeset in webkit [142704] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[WK2] Page reloading will crash UIProcess after WebProcess was killed
https://bugs.webkit.org/show_bug.cgi?id=109305

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-12
Reviewed by Benjamin Poulain.

Source/WebKit2:

Re-initialize the pointer to a WebInspectorProxy object before calling
initializeWebPage().

When the WebProcess crashes, WebPageProxy::processDidCrash() will
set WebInspectorProxy pointer to null, which later is accessed by
initializeWebPage(). This patch avoids a crash scenario where
calls into a null pointer would be made.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):

Tools:

Adding a new test to simulate the case of WebProcess crash followed by a trying
to load a new page.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):

6:22 PM Changeset in webkit [142703] by benjamin@webkit.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Mac rebaseline for r142638.

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-12
Reviewed by Benjamin Poulain.

  • platform/mac-lion/accessibility/table-attributes-expected.txt: Removed.
  • platform/mac-lion/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/mac-lion/accessibility/table-sections-expected.txt: Removed.
  • platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-cell-spans-expected.txt:
  • platform/mac/accessibility/table-cells-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Added.
6:20 PM Changeset in webkit [142702] by rafaelw@chromium.org
  • 3 edits in trunk/LayoutTests

[HTMLTemplateElement] Change template.dat serialization format
https://bugs.webkit.org/show_bug.cgi?id=109635

Reviewed by Eric Seidel.

The serialization format now uses 'content' instead of '#document-fragment' to
denote template contents.

  • html5lib/resources/template.dat:
  • resources/dump-as-markup.js:

(Markup._get):

6:13 PM Changeset in webkit [142701] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[iOS] Enable PAGE_VISIBILITY_API
https://bugs.webkit.org/show_bug.cgi?id=109399

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-12
Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
6:10 PM Changeset in webkit [142700] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Update a comment in NetworkProcess to be more accurate.

Rubberstamped by Sam Weinig.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):

5:53 PM Changeset in webkit [142699] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/bindings/v8/ScriptWrappable.h

Merge 140575
BUG=171893
Review URL: https://codereview.chromium.org/12225160

5:43 PM Changeset in webkit [142698] by akling@apple.com
  • 12 edits
    2 deletes in trunk/Source/WebCore

Move ElementAttributeData into Element.cpp/h
<http://webkit.org/b/109610>

Reviewed by Anders Carlsson.

Removed ElementAttributeData.cpp/h and moved the class itself into Element headquarters.
In the near future, Element should be the only client of this class, and thus it won't
be necessary for other classes to know anything about it.

  • dom/ElementAttributeData.cpp: Removed.
  • dom/ElementAttributeData.h: Removed.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/DocumentSharedObjectPool.cpp:
  • dom/Element.cpp:
  • dom/Element.h:
  • workers/SharedWorker.cpp:
  • Modules/webdatabase/DatabaseManager.cpp: Add ExceptionCode.h since Element.h doesn't pull it in anymore.
5:37 PM Changeset in webkit [142697] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Build fix for VS2010 WebKit solution.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:28 PM Changeset in webkit [142696] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

SecItemShim should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109636

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
Add a helper function for dispatching a work queue message receiver message.

(CoreIPC::Connection::processIncomingMessage):
Check if there are any work queue message receivers registered for this message.

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::shared):
Use dispatch_once instead of the AtomicallyInitializedStatic macro.

(WebKit::SecItemShim::SecItemShim):
Initialize the queue.

(WebKit::SecItemShim::secItemResponse):
Remove the connection parameter.

(WebKit::SecItemShim::initializeConnection):
Register the shim object as a work queue message receiver.

  • Shared/mac/SecItemShim.h:

Inherit from WorkQueueMessageReceiver.

  • Shared/mac/SecItemShim.messages.in:

Remove LegacyReceiver and DispatchOnConnectionQueue.

5:25 PM Changeset in webkit [142695] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Renamed SpecObjectMask to SpecObject.

Rubber stamped by Mark Hahnenberg.

"SpecObjectMask" is a weird name considering that a bunch of the other speculated
types are also masks, but don't have "Mask" in the name.

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

5:13 PM Changeset in webkit [142694] by thakis@chromium.org
  • 7 edits in trunk/LayoutTests

Remove webintents from TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=109620

Reviewed by James Robinson.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-mac-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:10 PM Changeset in webkit [142693] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Make Plug-in XPC services "join existing sessions"
<rdar://problem/13196448>

Reviewed by Mark Rowe.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
5:00 PM Changeset in webkit [142692] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Update WebKitDirs.pm for new Windows paths
https://bugs.webkit.org/show_bug.cgi?id=107714

Reviewed by Daniel Bates.

  • Scripts/webkitdirs.pm: For each existing Windows environment

variable, also include creation of the 'new' variables. The
'old' variables will be removed in a future update.
(windowsSourceSourceDir): New helper routine to return the
actual 'Source' folder of the WebKit source tree.

4:58 PM Changeset in webkit [142691] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Crash when scrolling soon after page starts loading
https://bugs.webkit.org/show_bug.cgi?id=109631
<rdar://problem/13157533&13159627&13196727>

Reviewed by Anders Carlsson.

Make the scrolling tree more robust when the root state node,
and/or scrolling node are null. This can happen if we try to
handle a wheel event before we've done the first scrolling
tree commit.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit): Handle the case where
m_rootStateNode is null. We'll still commit, but the state tree
will have no state nodes.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent): Null-check m_rootNode.
(WebCore::ScrollingTree::commitNewTreeState): Handle a null root node.
(WebCore::ScrollingTree::updateTreeFromStateNode): If the rood state node
is null, just clear the map and null out the root scrolling node.

  • page/scrolling/ScrollingTree.h: m_debugInfoLayer was unused.
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ensureRootStateNodeForFrameView): It may be possible
to get here before we've registered the root scroll layer, in which case scrollLayerID()
will be 0. Assert to see if this can ever happen.
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeAsText): Handle case of rootStateNode()
being null.

4:58 PM Changeset in webkit [142690] by weinig@apple.com
  • 4 edits
    16 copies
    11 adds in trunk/Source/WebKit2

Add skeleton of the OfflineStorageProcess
https://bugs.webkit.org/show_bug.cgi?id=109615

Reviewed by Anders Carlsson.

This adds the skeleton of a new process to contain Database and Local Storage
backends in (hence, offline storage). We're adding a new process, rather than
using the Network or UIProcesses, to allow us to tightly sandbox these activities
away from networking and full filesystem access.

  • Configurations/OfflineStorageProcess.xcconfig: Added.
  • Configurations/OfflineStorageService.Development.xcconfig: Added.
  • Configurations/OfflineStorageService.xcconfig: Added.
  • DerivedSources.make:
  • OfflineStorageProcess: Added.
  • OfflineStorageProcess/EntryPoint: Added.
  • OfflineStorageProcess/EntryPoint/mac: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageServiceEntryPoint.mm: Added.
  • OfflineStorageProcess/OfflineStorageProcess.cpp: Added.
  • OfflineStorageProcess/OfflineStorageProcess.h: Added.
  • OfflineStorageProcess/OfflineStorageProcess.messages.in: Added.
  • OfflineStorageProcess/mac: Added.
  • OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: Added.

(WebKit::OfflineStorageProcess::initializeProcessName):
(WebKit::OfflineStorageProcess::initializeSandbox):

  • OfflineStorageProcess/mac/com.apple.WebKit.OfflineStorage.sb: Added.
  • Shared/OfflineStorage: Added.
  • Shared/OfflineStorage/OfflineStorageProcessCreationParameters.cpp: Added.
  • Shared/OfflineStorage/OfflineStorageProcessCreationParameters.h: Added.
  • Scripts/webkit2/messages.py:

(struct_or_class):
Added OfflineStorageProcessCreationParameters.

  • WebKit2.xcodeproj/project.pbxproj:
4:41 PM Changeset in webkit [142689] by eric@webkit.org
  • 4 edits in trunk/Source/WTF

Teach more WTF string classes about vectors with inline capacity
https://bugs.webkit.org/show_bug.cgi?id=109617

Reviewed by Benjamin Poulain.

The HTML and WebVTT parsers use constructions like:
AtomicString name(m_name.data(), m_name.size())
all over the place because they use inline capacity
on the parse vectors for performance.

This change just add the necessary template variants
to the related String constructors/methods in WTF so that
this parser code can just pass the vector directly instead.

I'll do the actual parser cleanups in follow-up patches to keep things simple.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::create8BitIfPossible):

  • wtf/text/WTFString.h:

(String):
(WTF::String::make8BitFrom16BitSource):
(WTF):
(WTF::append):

4:23 PM Changeset in webkit [142688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build warning after r142579
https://bugs.webkit.org/show_bug.cgi?id=109547

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-12
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

4:10 PM Changeset in webkit [142687] by Raymond Toy
  • 3 edits in trunk/Source/WebCore

Synchronize setting of panner node model and processing
https://bugs.webkit.org/show_bug.cgi?id=109599

Reviewed by Chris Rogers.

No new tests.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:
3:53 PM Changeset in webkit [142686] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Remove webintents from TestExpectations on mac - directory no longer exists.

  • platform/mac/TestExpectations:
3:53 PM Changeset in webkit [142685] by dino@apple.com
  • 7 edits in trunk/Source/WebCore

Add class name for snapshotted plugin based on dimensions
https://bugs.webkit.org/show_bug.cgi?id=108369

Reviewed by Simon Fraser.

As the size of the plugin changes, the Shadow Root for the snapshot
might want to toggle different interfaces. Expose "tiny", "small",
"medium" and "large" classes on the Shadow. (The dimensions are
currently chosen fairly arbitrarily).

Because we only know the dimensions after layout, we set up
a post layout task to add the class. Luckily there already was
a post layout task for plugins - I just updated it to handle
both real and snapshotted plugins. This involved modifying
the list of RenderEmbeddedObjects in FrameView to take generic
RenderObjects, and decide which type they are when calling
the update method.

  • html/HTMLPlugInImageElement.cpp: Some new dimensions for the various size thresholds.

(WebCore::classNameForShadowRootSize): New static function that returns a class name

after examining the size of the object.

(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Sets the class name for

the shadow root. This is called in the post layout task.

(WebCore::shouldPlugInShowLabelAutomatically): Use new size names.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Ditto.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New method updateSnapshotInfo.

  • page/FrameView.cpp:

(WebCore::FrameView::addWidgetToUpdate): Change RenderEmbeddedObject* to RenderObject*.
(WebCore::FrameView::removeWidgetToUpdate): Ditto
(WebCore::FrameView::updateWidget): Branch based on EmbeddedObject vs SnapshottedPlugIn. Call

plugin snapshot update if necessary.

(WebCore::FrameView::updateWidgets): Handle both EmbeddedObject and SnapshottedPlugIn cases.

  • page/FrameView.h: Change RenderEmbeddedObject* to RenderObject* for post layout widget updates.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::layout): New virtual override. If size has changed, ask the

FrameView to recalculate size after layout.

  • rendering/RenderSnapshottedPlugIn.h: New layout() method.
3:53 PM Changeset in webkit [142684] by alecflett@chromium.org
  • 2 edits in trunk/Tools

Fix signedness in WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=109623

Reviewed by Adam Barth.

Fix signedness problem, using size_t instead of int.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3:44 PM Changeset in webkit [142683] by mkwst@chromium.org
  • 14 edits
    11 adds in trunk

Implement script MIME restrictions for X-Content-Type-Options: nosniff
https://bugs.webkit.org/show_bug.cgi?id=71851

Reviewed by Adam Barth.

Source/WebCore:

This patch adds support for 'X-Content-Type-Options: nosniff' when
deciding whether or not to execute a given chunk of JavaScript. If the
header is present, script will only execute if it matches a predefined
set of MIME types[1] that are deemed "executable". Scripts served with
types that don't match the list will not execute.

IE introduced this feature, and Gecko is working on an implementation[2]
now. There's been some discussion on the WHATWG list about formalizing
the specification for this feature[3], but nothing significant has been
decided.

This implementation's list of acceptible MIME types differs from IE's:
it matches the list of supported JavaScript MIME types defined in
MIMETypeRegistry::initializeSupportedJavaScriptMIMETypes()[4]. In
particular, the VBScript types are not accepted, and
'text/javascript1.{1,2,3}' are accepted, along with 'text/livescript'.

This feature is locked tightly behind the ENABLE_NOSNIFF flag, which is
currently only enabled on the Chromium port.

[1]: http://msdn.microsoft.com/en-us/library/gg622941(v=vs.85).aspx
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=471020
[3]: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-November/037974.html
[4]: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/MIMETypeRegistry.cpp?rev=142086#L307

Tests: http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html

http/tests/security/contentTypeOptions/nosniff-script-allowed.html
http/tests/security/contentTypeOptions/nosniff-script-blocked.html
http/tests/security/contentTypeOptions/nosniff-script-without-content-type-allowed.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

Before executing script, ensure that it shouldn't be blocked due to
its MIME type. If it is blocked, write an error message to the
console.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::mimeType):

Make scripts' MIME type available outside the context of
CachedScript in order to correctly populate error messages we write
to the console in ScriptElement::executeScript

(WebCore):
(WebCore::CachedScript::mimeTypeAllowedByNosniff):

  • loader/cache/CachedScript.h:

(CachedScript):

A new method which checks the resource's HTTP headers to set the
'nosniff' disposition, and compares the resource's MIME type against
the list of allowed executable types. Returns true iff the script
is allowed.

  • platform/network/HTTPParsers.cpp:

(WebCore):
(WebCore::parseContentTypeOptionsHeader):

  • platform/network/HTTPParsers.h:

Adds a new enum which relates the sniffable status of the resource,
and a method to parse the HTTP header.

LayoutTests:

  • http/tests/security/contentTypeOptions/invalid-content-type-options-allowed-expected.txt: Added.
  • http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-allowed-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-allowed.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-blocked-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-blocked.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html: Added.
  • http/tests/security/contentTypeOptions/resources/script-with-header.pl: Added.

New tests!

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:

Skip the new tests on platforms where ENABLE_NOSNIFF isn't yet
enabled (everything other than Chromium).

3:38 PM Changeset in webkit [142682] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Assume setScrollingOrZooming() to be called on the WebKit thread.
https://bugs.webkit.org/show_bug.cgi?id=109614
Internal PR 294513

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

With this further simplification of threading assumptions,
we can get rid of atomic integer access as well as the
backing store mutex which was otherwise unused.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::isScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

3:35 PM Changeset in webkit [142681] by Raymond Toy
  • 2 edits in trunk/Tools

Add alias

3:28 PM Changeset in webkit [142680] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 141858
BUG=174020
Review URL: https://codereview.chromium.org/12250020

3:23 PM Changeset in webkit [142679] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA doesn't filter precisely enough for CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=109618

Reviewed by Mark Hahnenberg.

The backend speculates object for this case, but the CFA was filtering on
(SpecCell & ~SpecString) | SpecOther.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

3:10 PM Changeset in webkit [142678] by Christophe Dumez
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Reenable ewk_auth_request API tests
https://bugs.webkit.org/show_bug.cgi?id=108451

Reviewed by Benjamin Poulain.

ewk_auth_request API tests were temporarily disabled after
the C API for resource loading was removed from WebKit2.
This patches updates the tests so that they no longer rely
on the resource loading events and renables them.

This patch also corrects the naming of the static variables
in the test to follow more closely the WebKit coding style.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:

(serverCallback):
(TEST_F):
(onLoadFinished):

3:09 PM Changeset in webkit [142677] by jpetsovits@rim.com
  • 11 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate the direct rendering option.
https://bugs.webkit.org/show_bug.cgi?id=109608
RIM PR 293298

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

It added a lot of complexity and we're not going to use it anymore.
This patch removes direct rendering functionality from
WebKit/blackberry together with the assumption that blitting on the
WebKit thread is possible or acceptable. It now isn't anymore.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSettings.cpp:

(WebKit):

  • Api/WebSettings.h:
  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
(BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::initialize):

3:05 PM Changeset in webkit [142676] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp

Merge 140879
BUG=172243
Review URL: https://codereview.chromium.org/12217152

2:57 PM Changeset in webkit [142675] by tkent@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/css/html.css

Merge 142076

REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132

Reviewed by Hajime Morita.

<input type=date> should be shown in Japanese UI as:
[ ?\229?\185?\180 /?\230?\156?\136/?\230?\151?\165]
But it is shown wrongly since r141195:
/?\230?\156?\136/?\230?\151?\165

We should use white-space:pre.

No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.

  • css/html.css:

(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.

TBR=tkent@chromium.org
BUG=crbug.com/174827
Review URL: https://codereview.chromium.org/12211140

2:56 PM Changeset in webkit [142674] by eae@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed chromium rebaseline for r142638, garden-o-matic screwed up the original rebaseline :(

  • platform/chromium-mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium-win-xp/fast/dom/Window: Added.
  • platform/chromium-win-xp/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
2:44 PM Changeset in webkit [142673] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Threaded HTML parser should pass the remaining fast/tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=109607

Reviewed by Eric Seidel.

This patch fixes some edge cases involving document.write. Previously,
we would drop input characters on the floor if the tokenizer wasn't
able to consume them synchronously. In this patch, we send the unparsed
characters to the background thread for consumption after rewinding the
input stream.

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::finish):

  • html/parser/HTMLInputStream.h:

(WebCore::HTMLInputStream::closeWithoutMarkingEndOfFile):
(HTMLInputStream):

2:17 PM Changeset in webkit [142672] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Introduce a WorkQueueMessageReceiver class as a replacement for QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109612

Reviewed by Andreas Kling.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addWorkQueueMessageReceiver):
(CoreIPC):
(CoreIPC::Connection::removeWorkQueueMessageReceiver):
(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
(CoreIPC::Connection::removeWorkQueueMessageReceiverOnConnectionWorkQueue):

  • Platform/CoreIPC/Connection.h:

(Connection):

2:16 PM Changeset in webkit [142671] by dgrogan@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 142564
pre-requisite to merging https://src.chromium.org/viewvc/chrome?view=rev&revision=182008

IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519

Reviewed by Adam Barth.

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:

TBR=dgrogan@chromium.org
BUG=174895
Review URL: https://codereview.chromium.org/12212148

1:59 PM Changeset in webkit [142670] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] CSS animations stop running during zoom
https://bugs.webkit.org/show_bug.cgi?id=109606

Patch by Andrew Lo <anlo@rim.com> on 2013-02-12
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

Internal PR 286160.
New BackingStore API for suspending/resuming geometry updates.

This is needed because we want to allow render jobs to continue during
zoom, but we don't want to allow geometry updates during zoom.

Prevent scroll/zoom render jobs from being added to the queue if
the tile is outside the expanded content rect.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendGeometryUpdates):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::resumeGeometryUpdates):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStore::suspendGeometryUpdates):
(BlackBerry::WebKit::BackingStore::resumeGeometryUpdates):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):

1:51 PM QtWebKitBugs edited by jocelyn.turcotte@digia.com
(diff)
1:36 PM Changeset in webkit [142669] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix for !ENABLE(INSPECTOR) platforms after r142654.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::scriptsEnabled):

1:32 PM Changeset in webkit [142668] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Typo fix after r142663.

  • GNUmakefile.list.am:
1:28 PM Changeset in webkit [142667] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

1:26 PM Changeset in webkit [142666] by Lucas Forschler
  • 1 copy in branches/safari-536.29-branch

New Branch.

1:24 PM Changeset in webkit [142665] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.js

Merge 141890

Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.

Quick fix for regression.

  • inspector/front-end/inspector.js:

Avoid "exit route" when URL is a profile URL.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12223108

1:21 PM Changeset in webkit [142664] by Christophe Dumez
  • 8 edits in trunk

Remove remaining traces of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=109586

Reviewed by Eric Seidel.

.:

Remove references to Web Intents from CMake files as the functionality
was removed in r142549.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Remove remaining traces of Web Intents as the functionality was
removed in r142549.

No new tests, no behavior change for layout tests.

  • GNUmakefile.features.am.in:
  • html/HTMLTagNames.in:

Source/WebKit/blackberry:

Remove remaining traces of Web Intents from Blackberry port
configuration as the functionality was removed in r142549.

  • WebCoreSupport/AboutDataEnableFeatures.in:
1:19 PM Changeset in webkit [142663] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

[WK2] Unreviewed trivial buildfix after r142630 and r142651.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):

1:17 PM Changeset in webkit [142662] by luiz@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/watchlist

Adding myself to watch lists.

Unreviewed.

  • Scripts/webkitpy/common/config/watchlist:
1:15 PM Changeset in webkit [142661] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1364

Merge 142128

Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/map-expected.txt:
  • inspector/map.html:

TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/12208136

1:07 PM Changeset in webkit [142660] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js

Merge 142127

Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12225145

1:06 PM Changeset in webkit [142659] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html

The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.
1:03 PM Changeset in webkit [142658] by eae@chromium.org
  • 7 edits
    10 adds
    2 deletes in trunk/LayoutTests

Unreviewed rebaseline for r142638.

  • platform/chromium-linux-x86/fast/dom/Window: Removed.
  • platform/chromium-linux-x86/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/webkitConvertPoint-expected.txt:
  • platform/chromium-win/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/mac-lion/accessibility: Added.
  • platform/mac-lion/accessibility/table-attributes-expected.txt: Added.
  • platform/mac-lion/accessibility/table-cell-spans-expected.txt: Added.
  • platform/mac-lion/accessibility/table-sections-expected.txt: Added.
  • platform/mac-lion/fast/dom/Window: Added.
  • platform/mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Added.
  • platform/mac-wk2/fast/dom/Window: Added.
  • platform/mac-wk2/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac/accessibility/image-link-expected.txt:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt:
1:01 PM Changeset in webkit [142657] by leviw@chromium.org
  • 3 edits
    2 adds in trunk
ASSERTION FAILED: !object
object->isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker

https://bugs.webkit.org/show_bug.cgi?id=108699

Reviewed by Abhishek Arya.

Source/WebCore:

RenderListItems performs special management of its children to maintain list markers. Splitting a flow
through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splitting
flows when inside one.

Test: fast/multicol/span/list-multi-column-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

  • fast/multicol/span/list-multi-column-crash-expected.txt: Added.
  • fast/multicol/span/list-multi-column-crash.html: Added.
12:56 PM Changeset in webkit [142656] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Change the queue client base class to be private everywhere
https://bugs.webkit.org/show_bug.cgi?id=109604

Reviewed by Andreas Kling.

Move connection queue client registration inside of the respective queue client classes.

Also, it's too late to add queue clients in ChildProcessProxy::didFinishLaunching, so do this in
ChildProcessProxy::connectionWillOpen instead.

Finally, assert that queue clients are only being added and removed from the client thread.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection):

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::initializeConnection):
(WebKit):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::connectionWillOpen):
(WebKit):
(WebKit::NetworkProcessProxy::connectionWillClose):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::initializeConnection):
(WebKit):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::initializeConnection):
(WebKit):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

12:56 PM Changeset in webkit [142655] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):

12:45 PM Changeset in webkit [142654] by vivek.vg@samsung.com
  • 10 edits
    2 adds in trunk

Web Inspector: JavaScript execution disabled by browser/UA should be notified to the front-end
https://bugs.webkit.org/show_bug.cgi?id=109402

Reviewed by Yury Semikhatsky.

Source/WebCore:

Whenever the UA/Browser changes the Script Execution state of a page, it should notify the
inspector front-end. Added the InspectorInstrumentation method didScriptExecutionStateChange
to achieve this. Also the state change triggered by the inspector should be ignored to avoid
infinite loop.

Test: inspector/script-execution-state-change-notification.html

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::scriptsEnabledImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::scriptsEnabled):
(WebCore):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
(WebInspector.PageDispatcher.prototype.scriptsEnabled):

  • page/Settings.cpp:

(WebCore::Settings::setScriptEnabled):

LayoutTests:

Tests that whenever Script Execution state is changed outside inspector, its notified to the Inspector front-end.

  • inspector/script-execution-state-change-notification-expected.txt: Added.
  • inspector/script-execution-state-change-notification.html: Added.
12:23 PM Changeset in webkit [142653] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB/Worker crash during shutdown
https://bugs.webkit.org/show_bug.cgi?id=109467

Reviewed by Tony Chang.

If the message queue has already been terminated, don't bother scheduling
a new error event that will never be delivered. Speculative fix for the
issue, which only repros in multiprocess ports and so far only on some
platforms.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.

12:14 PM Changeset in webkit [142652] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Cache timer heap pointer to timers
https://bugs.webkit.org/show_bug.cgi?id=109597

Reviewed by Andreas Kling.

Accessing timer heap through thread global storage is slow (~0.1% in PLT3). We can cache the heap pointer to
each TimerBase. There are not huge numbers of timers around so memory is not an issue and many timers are heavily reused.

  • platform/Timer.cpp:

(WebCore::threadGlobalTimerHeap):
(WebCore::TimerHeapReference::operator=):
(WebCore::TimerHeapIterator::checkConsistency):
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::checkHeapIndex):
(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(WebCore::TimerBase::timerHeap):
(TimerBase):

12:12 PM Changeset in webkit [142651] by beidson@apple.com
  • 17 edits
    2 adds in trunk/Source/WebKit2

Add WKContext API to retrieve basic network process statistics
https://bugs.webkit.org/show_bug.cgi?id=109329

Reviewed by Sam Weinig.

This patch adds a WKContextGetStatisticsWithOptions which allows the client to ask for
certain types of statistics.

It also expands the "get statistics" callback mechanism to allow for a statistics request
to be answered by multiple child processes.

That mechanism still has some rough edges but will eventually allow for getting statistics
from multiple web processes, as well.

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::pendingRequestCount):
(WebKit::HostRecord::activeLoadCount):

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getNetworkProcessStatistics):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::hostsPendingCount):
(WebKit::NetworkResourceLoadScheduler::loadsPendingCount):
(WebKit::NetworkResourceLoadScheduler::hostsActiveCount):
(WebKit::NetworkResourceLoadScheduler::loadsActiveCount):

  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • Shared/Authentication/AuthenticationManager.h:

(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):

  • Shared/Downloads/DownloadManager.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/StatisticsRequest.cpp: Added.

(WebKit::StatisticsRequest::StatisticsRequest):
(WebKit::StatisticsRequest::~StatisticsRequest):
(WebKit::StatisticsRequest::addOutstandingRequest):
(WebKit::addToDictionaryFromHashMap):
(WebKit::createDictionaryFromHashMap):
(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/StatisticsRequest.h: Added.

(WebKit::StatisticsRequest::create):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::networkingProcessConnection):
(WebKit::WebContext::getStatistics):
(WebKit::WebContext::requestWebContentStatistics):
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::didGetStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

  • WebKit2.xcodeproj/project.pbxproj:
11:56 AM Changeset in webkit [142650] by mrobinson@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the gyp build of JavaScriptCore.

  • JavaScriptCore.gypi: Added some missing DFG files to the source list.
11:46 AM Changeset in webkit [142649] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r142387.
http://trac.webkit.org/changeset/142387
https://bugs.webkit.org/show_bug.cgi?id=109601

caused all layout and jscore tests on windows to fail
(Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedCodeBlock):

11:39 AM Changeset in webkit [142648] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

BackgroundHTMLParser::resumeFrom should take a struct
https://bugs.webkit.org/show_bug.cgi?id=109598

Reviewed by Eric Seidel.

This patch is purely a syntatic change that paves the way for fixing
the partial-entity document.write tests. To fix those tests, we'll need
to pass more information to resumeFrom, but we're hitting the argument
limits in Functional.h. Rather than adding yet more arguments, this
patch moves to a single argument that's a struct.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):
(BackgroundHTMLParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

11:35 AM Changeset in webkit [142647] by esprehn@chromium.org
  • 3 edits in trunk/Source/WebCore

rootRenderer in FrameView is really RenderView
https://bugs.webkit.org/show_bug.cgi?id=109510

Reviewed by Eric Seidel.

The global function rootRenderer(FrameView*) is really just a way
to get the RenderView from the Frame so replace it with a renderView()
method and replace usage of the word "root" with renderView so it's
obvious the root we're talking about is the renderView. This is an
important distinction to make since we also have rootRenderer in the code
for the documentElement()'s renderer and we also have a "layout root" which
is entirely different.

No new tests, just refactoring.

  • page/FrameView.cpp:

(WebCore::FrameView::rootRenderer): Removed.
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::usesCompositedScrolling):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::scrollLayerID):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

  • page/FrameView.h:

(WebCore::FrameView::renderView): Added.

11:27 AM Changeset in webkit [142646] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][Introspection] GObject bindings for DataTransferItemList - one add() method must be removed from .idl
https://bugs.webkit.org/show_bug.cgi?id=109180

Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-12
Reviewed by Xan Lopez.

When compiling WebKit with --enable-introspection and generating GObject bindings
for DataTransferItemList we must disable one add() method, because GObject is
based on C and C does not allow two functions with the same name.

No tests needed.

  • bindings/scripts/CodeGeneratorGObject.pm:
11:13 AM Changeset in webkit [142645] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Background size width specified in viewport percentage units not working
https://bugs.webkit.org/show_bug.cgi?id=109536

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Corrected the check for viewport percentage unit while calculating
background image width.

Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

Added a test for background image width specified in viewport percentage unit.

  • fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
  • fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
11:04 AM Changeset in webkit [142644] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

Add back the files to the Xcode project that were removed in r142580.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
10:50 AM Changeset in webkit [142643] by jochen@chromium.org
  • 14 edits
    1 copy in trunk/Tools

[chromium] move text dump generation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109575

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.

(WebTestRunner::normalizeLayoutTestURL):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::checkResponseMimeType):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpAsText):
(WebTestRunner::TestRunner::shouldGeneratePixelResults):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):
(TestShell::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::captureHistoryForWindow):

  • DumpRenderTree/chromium/WebViewHost.h:
10:49 AM Changeset in webkit [142642] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::DeleteButtonController::enable
https://bugs.webkit.org/show_bug.cgi?id=109447

Reviewed by Ryosuke Niwa.

RefPtr frame pointer since it can get deleted due to mutation events
fired inside AppendNodeCommand::doUnapply.

No new tests. Testcase is hard to minimize due to recursive
calls with DOMNodeRemovedFromDocument mutation event.

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):

10:43 AM Changeset in webkit [142641] by eric@webkit.org
  • 26 edits
    1 add
    1 delete in trunk/Source/WebCore

Remove HTMLTokenTypes header (and split out AtomicHTMLToken.h from HTMLToken.h)
https://bugs.webkit.org/show_bug.cgi?id=109525

Reviewed by Adam Barth.

We no longer need a separate HTMLTokenTypes class now that NEW_XML is gone.
However, to remove HTMLTokenTypes, I had to split AtomicHTMLToken.h from
HTMLToken.h (to fix a circular dependancy).

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addSource):

  • html/parser/AtomicHTMLToken.h: Added.

(WebCore):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::forceQuirks):
(WebCore::AtomicHTMLToken::type):
(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::selfClosing):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::characters):
(WebCore::AtomicHTMLToken::charactersLength):
(WebCore::AtomicHTMLToken::isAll8BitData):
(WebCore::AtomicHTMLToken::comment):
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::clearExternalCharacters):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/CompactHTMLToken.h:

(WebCore::CompactHTMLToken::type):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::sourceForToken):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::forceQuirks):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::publicIdentifier):
(WebCore::HTMLToken::systemIdentifier):
(WebCore::HTMLToken::setPublicIdentifierToEmptyString):
(WebCore::HTMLToken::setSystemIdentifierToEmptyString):
(WebCore::HTMLToken::appendToPublicIdentifier):
(WebCore::HTMLToken::appendToSystemIdentifier):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):
(HTMLToken):

  • html/parser/HTMLTokenTypes.h: Removed.
  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::usesName):
(WebCore::AtomicHTMLToken::usesAttributes):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):

10:40 AM Changeset in webkit [142640] by commit-queue@webkit.org
  • 8 edits in trunk

Handle error recovery in @supports
https://bugs.webkit.org/show_bug.cgi?id=103934

Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Tests 021, 024, 031, and 033 in
http://hg.csswg.org/test/file/5f94e4b03ed9/contributors/opera/submitted/css3-conditional
fail because there's no explicit error recovery in @support's grammar.
Opera and Firefox pass the tests.

No new tests, modified css3/supports{,-cssom}.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
(WebCore::CSSParser::popSupportsRuleData):

  • css/CSSParser.h:

LayoutTests:

  • css3/supports-cssom.html:
  • css3/supports-expected.txt:
  • css3/supports.html:
10:34 AM Changeset in webkit [142639] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] guard against NULL languages array
https://bugs.webkit.org/show_bug.cgi?id=109595

Reviewed by Dean Jackson.

No new tests, existing tests won't crash if this is correct.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::preferredLanguages):

9:40 AM Changeset in webkit [142638] by eae@chromium.org
  • 9 edits
    4 adds in trunk

TransformState::move should not round offset to int
https://bugs.webkit.org/show_bug.cgi?id=108266

Source/WebCore:

Reviewed by Simon Fraser.

Currently TransformState::move rounds the offset to the nearest
integer values, this results in operations using TransformState
to compute a position to misreport the location, specifically
Element:getBoundingClientRect and repaint rects. Sizes are
handled correctly and do not have the same problem.

Tests: fast/sub-pixel/boundingclientrect-subpixel-margin.html

fast/sub-pixel/clip-rect-box-consistent-rounding.html

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):
Change to use pixel snapping instead of enclosing box. All other
code paths use pixelSnappedIntRect to align the rects to device
pixels however this used enclosingIntRect (indirectly through
the FloatQuad::enclosingBoundingBox call).
Without the rounding in TransformState this causes repaint rects
for elements on subpixel bounds to be too large by up to one
pixel on each axis. For normal repaints this isn't really a
problem but in scrollContentsSlowPath it can result in moving
too large a rect.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::translateTransform):
(WebCore::TransformState::translateMappedCoordinates):
Change to take a LayoutSize instead of an IntSize.

(WebCore::TransformState::move):
(WebCore::TransformState::applyAccumulatedOffset):

  • platform/graphics/transforms/TransformState.h:

Remove rounding logic and use original, more precise, value.

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer):
Remove rounding logic and use original, more precise, value.

LayoutTests:

Reviewed by Simon Fraser.

Add new tests for Element::boundingClientRect and clip rects for
elements on subpixel boundaries.

  • fast/dom/Window/webkitConvertPoint.html:
  • platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt:

Update test and expectations to take new rounding into account.

  • fast/sub-pixel/boundingclientrect-subpixel-margin-expected.txt: Added.
  • fast/sub-pixel/boundingclientrect-subpixel-margin.html: Added.

Add test ensuring that boundingClientRect returns accurate and
precise (as opposed to rounded) metrics.

  • fast/sub-pixel/clip-rect-box-consistent-rounding-expected.html: Added.
  • fast/sub-pixel/clip-rect-box-consistent-rounding.html: Added.

Add test ensuring that clip rects and elements use consistent rounding.

9:37 AM Changeset in webkit [142637] by jberlin@webkit.org
  • 8 edits
    1 delete in trunk

Rollout r142618, it broke all the Mac builds.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(WebCore):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
9:34 AM Changeset in webkit [142636] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG CompareEq optimization should be retuned
https://bugs.webkit.org/show_bug.cgi?id=109545

Reviewed by Mark Hahnenberg.

  • Made the object-to-object equality case work again by hoisting the if statement for it. Previously, object-to-object equality would be compiled as object-to-object-or-other.


  • Added AbstractState guards for most of the type checks that the object equality code uses.


Looks like a hint of a speed-up on all of the things.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

9:05 AM Changeset in webkit [142635] by rafaelw@chromium.org
  • 5 edits in trunk

[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338

Reviewed by Adam Barth.

Source/WebCore:

This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.

Tests added to html5lib.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

  • html5lib/resources/template.dat:
9:04 AM Changeset in webkit [142634] by mrobinson@webkit.org
  • 5 edits in trunk

[GTK] Remove the enable-debug-feature configuration option
https://bugs.webkit.org/show_bug.cgi?id=109539

Reviewed by Philippe Normand.

Remove the --enable-debug-feature option from configuration. It doesn't
do anything that --enable-debug doesn't.

  • Source/autotools/PrintBuildConfiguration.m4: Remove references to --enable-debug-features.
  • Source/autotools/ReadCommandLineArguments.m4: Ditto.
  • Source/autotools/SetupAutoconfHeader.m4: Ditto.
  • Source/autotools/SetupAutomake.m4: Ditto.
8:59 AM Changeset in webkit [142633] by keishi@webkit.org
  • 5 edits
    6 copies in branches/chromium/1364

Merge 142111

Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Reviewed by Kent Tamura.

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html

platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

  • Resources/pagepopups/calendarPicker.css:

(.today-clear-area):

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
  • platform/chromium/TestExpectations:

TBR=keishi@webkit.org

8:59 AM Changeset in webkit [142632] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix after r142540 and r142518

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::didReceivePluginProcessConnectionManagerMessageOnConnectionWorkQueue):
This function was added to the header in r142518 but not implemented in that revision.
It wasn't a problem until r142540 started using it.
Add a stub implementation for it.

8:58 AM Changeset in webkit [142631] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452

Reviewed by Chris Fleizach.

Source/WebCore:

Send the accessibility childrenChanged notification in
HTMLSelectElement::setRecalcListItems instead of in childrenChanged
so that all possible codepaths are caught.

Test: accessibility/insert-selected-option-into-select-causes-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

LayoutTests:

Add test to ensure a crash doesn't happen if a selected option
is added to a select element, which was triggering a code path where
the DOM has added a new child of the select but the accessibility
object never got updated.

  • accessibility/insert-selected-option-into-select-causes-crash-expected.txt: Added.
  • accessibility/insert-selected-option-into-select-causes-crash.html: Added.
8:55 AM Changeset in webkit [142630] by beidson@apple.com
  • 7 edits in trunk/Source/WebKit2

Make PluginProcessProxy a ChildProcessProxy.
https://bugs.webkit.org/show_bug.cgi?id=109513

Reviewed by Anders Carlsson.

  • Shared/ChildProcessProxy.h: Inherit from ThreadSafeRefCounted.
  • UIProcess/Network/NetworkProcessProxy.h: Don't inherit from RefCounted.
  • UIProcess/WebProcessProxy.h: Don't inherit from ThreadSafeRefCounted
  • UIProcess/Plugins/PluginProcessProxy.h: Don't inherit from RefCounted, do inherit from ChildProcessProxy

Rely on ChildProcessProxy for process launcher management and launch options:

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::PluginProcessProxy):
(WebKit::PluginProcessProxy::getLaunchOptions):
(WebKit::PluginProcessProxy::getPluginProcessConnection):
(WebKit::PluginProcessProxy::getSitesWithData):
(WebKit::PluginProcessProxy::clearSiteData):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):
(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):

8:53 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
8:49 AM QtWebKit edited by jocelyn.turcotte@digia.com
General layouting and point users to the Qt bug tracker to report bugs (diff)
8:48 AM QtWebKitBugs edited by jocelyn.turcotte@digia.com
General cleanup related to bugs now being tracked in the Qt bug tracker (diff)
8:45 AM Changeset in webkit [142629] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

BUILD FIX (r142576): WK1 build fails when ENABLE(DELETION_UI) is off
<https://bugs.webkit.org/show_bug.cgi?id=109534>

Fixes the following build failure:

WebEditorClient.mm:243:23: error: out-of-line definition of 'shouldShowDeleteInterface' does not match any declaration in 'WebEditorClient'
bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element)


  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldShowDeleteInterface): Protect with
ENABLE(DELETION_UI) macro.

8:18 AM Changeset in webkit [142628] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13196331> NetworkProcess deny mach-lookup com.apple.PowerManagement.control

Reviewed by Sam Weinig.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
8:01 AM Changeset in webkit [142627] by commit-queue@webkit.org
  • 13 edits in trunk

Web Inspector: for event listener provide handler function value in protocol and in UI
https://bugs.webkit.org/show_bug.cgi?id=109284

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-12
Reviewed by Yury Semikhatsky.

Source/WebCore:

The feature implies that we include a real handler function value into event listener description.
Protocol description, inspector DOM agent (with V8 and JSC backends) and front-end is patched accordingly.

  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandler):
(WebCore):
(WebCore::eventListenerHandlerScriptState):

  • bindings/js/ScriptEventListener.h:

(WebCore):

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventListenerHandler):
(WebCore):
(WebCore::eventListenerHandlerScriptState):

  • bindings/v8/ScriptEventListener.h:

(WebCore):

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.eventListeners):

  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update):
(.):

LayoutTests:

Test is rebased.

  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
7:56 AM Changeset in webkit [142626] by yurys@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: add initial implementation of native memory graph to Timeline
https://bugs.webkit.org/show_bug.cgi?id=109578

Reviewed by Alexander Pavlov.

This change adds inital implementation of native memory graph UI. The graph
will be shown in the same place as DOM counters graph on the Timeline panel.

Added NativeMemoryGraph.js that reuses parts of DOM counters graph
implementation. MemoryStatistics.js was refactor to allow sharing
more code between DOM counters and native memory graph.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype._createCurrentValuesBar):
(WebInspector.MemoryStatistics.prototype._createCounterUIList):
(WebInspector.MemoryStatistics.prototype._createCounterUIList.getNodeCount):
(WebInspector.MemoryStatistics.prototype._createCounterUIList.getListenerCount):
(WebInspector.MemoryStatistics.prototype._canvasHeight):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawMarker):

  • inspector/front-end/NativeMemoryGraph.js: Added.

(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryCounterUI):
(WebInspector.NativeMemoryCounterUI.prototype._hslToString):
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):
(WebInspector.NativeMemoryCounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.NativeMemoryGraph.prototype._createCurrentValuesBar):
(WebInspector.NativeMemoryGraph.prototype._createCounterUIList.getCounterValue):
(WebInspector.NativeMemoryGraph.prototype._createCounterUIList):
(WebInspector.NativeMemoryGraph.prototype._canvasHeight):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
(WebInspector.NativeMemoryGraph.prototype._draw):
(WebInspector.NativeMemoryGraph.prototype._clearCurrentValueAndMarker):
(WebInspector.NativeMemoryGraph.prototype._updateCurrentValue):
(WebInspector.NativeMemoryGraph.prototype._restoreImageUnderMarker):
(WebInspector.NativeMemoryGraph.prototype._saveImageUnderMarker):
(WebInspector.NativeMemoryGraph.prototype._drawMarker):
(WebInspector.NativeMemoryGraph.prototype._maxCounterValue):
(WebInspector.NativeMemoryGraph.prototype._resetTotalValues):
(WebInspector.NativeMemoryGraph.prototype.valueGetter):
(WebInspector.NativeMemoryGraph.prototype._drawGraph):
(WebInspector.NativeMemoryGraph.prototype._discardImageUnderMarker):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/timelinePanel.css:

(#memory-graphs-canvas-container.dom-counters .resources-dividers):
(.memory-category-value):

7:53 AM Changeset in webkit [142625] by yurys@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Fix Chromium compilation after r142618.

  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::HeapGraphReceiver::printNode):

7:33 AM Changeset in webkit [142624] by kareng@chromium.org
  • 4 edits in branches/chromium/1410/Source/WebCore/bindings/v8

Merge 142565

[V8] ScheduledAction::m_context can be empty, so we shouldn't
retrieve an Isolate by using m_context->GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=109523

Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges

Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate().
This can crash because ScheduledAction::m_context can be empty. Specifically,
ScheduledAction::m_context is set to ScriptController::currentWorldContext(),
which can return an empty handle when a frame does not exist. In addition,
'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty.

Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.

No tests. The Chromium crash report doesn't provide enough information
to reproduce the bug.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore):
(WebCore::ScheduledAction::~ScheduledAction):

  • bindings/v8/ScheduledAction.h:

(ScheduledAction):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12211130

7:29 AM Changeset in webkit [142623] by kareng@chromium.org
  • 1 add in branches/chromium/1410/codereview.settings

for easy drovering into m26

7:28 AM Changeset in webkit [142622] by kareng@chromium.org
  • 1 copy in branches/chromium/1410

branching for m27

7:18 AM Changeset in webkit [142621] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: refactor some reusable functionality from BraceHighlighter
https://bugs.webkit.org/show_bug.cgi?id=109574

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Pavel Feldman.

Source/WebCore:

New test: inspector/editor/text-editor-brace-highlighter.html

Extract functionality which, for given line and cursor position, will
return position for a brace that should be highlighted. Add a layout
test to verify brace highlighter funcionality.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.activeBraceColumnForCursorPosition):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):

  • inspector/front-end/TextUtils.js:

(WebInspector.TextUtils.isOpeningBraceChar):
(WebInspector.TextUtils.isClosingBraceChar):
(WebInspector.TextUtils.isBraceChar):

LayoutTests:

Add layout test to verify brace highlighter functionality.

  • inspector/editor/text-editor-brace-highlighter-expected.txt: Added.
  • inspector/editor/text-editor-brace-highlighter.html: Added.
7:06 AM Changeset in webkit [142620] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[GTK] Add an optional moduleset with hard to get packages (including libsecret)
https://bugs.webkit.org/show_bug.cgi?id=109195

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Philippe Normand.

Add an optional moduleset that includes libsecret. This moduleset will
be used to install some annoyingly hard to obtain dependencies on older
distributions.

  • gtk/jhbuild-optional.modules: Added.
  • gtk/jhbuild.modules: Add a reference to the new moduleset file.
6:58 AM Changeset in webkit [142619] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectation update.
https://bugs.webkit.org/show_bug.cgi?id=109581

  • platform/chromium/TestExpectations: mark debugger-script-preprocessor.html as crashy.
6:53 AM Changeset in webkit [142618] by loislo@chromium.org
  • 8 edits
    1 add in trunk

Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554

Source/WebCore:

In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.

Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.

Reviewed by Yury Semikhatsky.

It is covered by newly added tests in TestWebKitAPI.

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializerClient):
(WebCore::HeapGraphSerializerClient::~HeapGraphSerializerClient):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
This patch has new set of tests for HeapGraphSerializer.

Reviewed by Yury Semikhatsky.

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
6:51 AM Changeset in webkit [142617] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed followup to r142606, the EFL port also enables the CSS image-set
feature so the new configuration option's default value should reflect that.

  • Scripts/webkitperl/FeatureList.pm:
6:40 AM Changeset in webkit [142616] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC asserting with long parameter list functions in debug mode on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=109565

Reviewed by Zoltan Herczeg.

Increase the value of sequenceGetByIdSlowCaseInstructionSpace to 80.

  • jit/JIT.h:
6:33 AM Changeset in webkit [142615] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed chromium rebaselines after r142586.

  • platform/chromium-mac/fast/canvas/webgl/webgl-layer-update-expected.png: Added.
6:29 AM Changeset in webkit [142614] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch introduces version controller that could be used to migrate inspector settings.

Test: inspector/version-controller.html

  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/version-controller-expected.txt: Added.
  • inspector/version-controller.html: Added.
6:19 AM Changeset in webkit [142613] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: File system should produce more verbose error messages and recover from errors
https://bugs.webkit.org/show_bug.cgi?id=109571

Reviewed by Alexander Pavlov.

Error handler prints original file system call params now.
Added callbacks to error handler to recover from errors.

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
(WebInspector.FileSystemUtils.errorMessage):
(.fileSystemLoaded):
(.fileEntryLoaded):
(.errorHandler):
(WebInspector.FileSystemUtils.requestFileContent):
(WebInspector.FileSystemUtils.setFileContent):
(WebInspector.FileSystemUtils._readDirectory):
(.innerCallback):
(WebInspector.FileSystemUtils._requestEntries):

6:17 AM Changeset in webkit [142612] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Get rid of unnecessary complexity in FileSystemUtil: remove _getDirectory() method.
https://bugs.webkit.org/show_bug.cgi?id=109567

Reviewed by Alexander Pavlov.

The code in this method was redundant as the same result could be achieved by using File System API directly.

  • inspector/front-end/FileSystemProjectDelegate.js:
6:15 AM Changeset in webkit [142611] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] SuggestBox not hidden when prefix is empty and there is preceding input
https://bugs.webkit.org/show_bug.cgi?id=109568

Reviewed by Vsevolod Vlasov.

The suggestbox would get hidden in the case of empty input, yet it should get hidden
in the case of empty user-entered prefix (which is a wider notion.)

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

6:04 AM Changeset in webkit [142610] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: separate SuggestBox from TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109430

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Alexander Pavlov.

Create WebInspector.SuggestBoxDelegate interface and
refactor TextPrompt to use this interface. Separate SuggestBox into
WebInspector.SuggestBox namespace and put it into its own file.

No new tests: no change in behaviour.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/SuggestBox.js: Added.

(WebInspector.SuggestBoxDelegate):
(WebInspector.SuggestBoxDelegate.prototype.applySuggestion):
(WebInspector.SuggestBoxDelegate.prototype.acceptSuggestion):
(WebInspector.SuggestBoxDelegate.prototype.userEnteredText):
(WebInspector.SuggestBox):
(WebInspector.SuggestBox.prototype.get visible):
(WebInspector.SuggestBox.prototype.get hasSelection):
(WebInspector.SuggestBox.prototype._onscrollresize):
(WebInspector.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.SuggestBox.prototype._updateBoxPosition):
(WebInspector.SuggestBox.prototype._onboxmousedown):
(WebInspector.SuggestBox.prototype.hide):
(WebInspector.SuggestBox.prototype.removeFromElement):
(WebInspector.SuggestBox.prototype._applySuggestion):
(WebInspector.SuggestBox.prototype.acceptSuggestion):
(WebInspector.SuggestBox.prototype._selectClosest):
(WebInspector.SuggestBox.prototype.updateSuggestions):
(WebInspector.SuggestBox.prototype._onItemMouseDown):
(WebInspector.SuggestBox.prototype._createItemElement):
(WebInspector.SuggestBox.prototype._updateItems):
(WebInspector.SuggestBox.prototype._selectItem):
(WebInspector.SuggestBox.prototype._canShowBox):
(WebInspector.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.SuggestBox.prototype._completionsReady):
(WebInspector.SuggestBox.prototype.upKeyPressed):
(WebInspector.SuggestBox.prototype.downKeyPressed):
(WebInspector.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.SuggestBox.prototype.enterKeyPressed):
(WebInspector.SuggestBox.prototype.tabKeyPressed):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.userEnteredText):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype._applySuggestion):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:56 AM Changeset in webkit [142609] by zandobersek@gmail.com
  • 4 edits in trunk

[GTK] Enable CSS Variables feature in development builds
https://bugs.webkit.org/show_bug.cgi?id=109474

Reviewed by Martin Robinson.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the feature on development

builds of the GTK port.

LayoutTests:

  • platform/gtk/TestExpectations: Remove the expectations for tests that now pass.
5:49 AM Changeset in webkit [142608] by Bruno de Oliveira Abinader
  • 3 edits in trunk/Source/WebCore

[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540

Reviewed by Noam Rosenthal.

Adds basysKom copyright info to TextureMapperFPSCounter header.

  • platform/graphics/texmap/TextureMapperFPSCounter.cpp:
  • platform/graphics/texmap/TextureMapperFPSCounter.h:
5:27 AM Changeset in webkit [142607] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r142531.
http://trac.webkit.org/changeset/142531
https://bugs.webkit.org/show_bug.cgi?id=109569

Causes html5lib/run-template layout test to crash. (Requested
by atwilson_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12

Source/WebCore:

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

  • html5lib/resources/template.dat:
5:25 AM Changeset in webkit [142606] by zandobersek@gmail.com
  • 6 edits
    1 delete in trunk

[GTK] Enable CSS image-set support in development builds
https://bugs.webkit.org/show_bug.cgi?id=109475

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - majority of the related tests now passes.

  • GNUmakefile.features.am.in: Add the feature define for the CSS image-set feature

with the define value defaulting to 0. The value gets overridden with 1 in development
builds, meaning the feature is enabled under that configuration.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.

Note that the Mac port also enables the feature but does so in Platform.h as the feature
is also enabled for the iOS port which can't at the moment be detected via webkitperl.

LayoutTests:

  • platform/gtk/TestExpectations: Reclassify two failures that now fail due to

cursor images not loading while the other expectations are removed as the tests
now pass.

  • platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Removed. The generic

expectation now matches the test output.

5:23 AM Changeset in webkit [142605] by zandobersek@gmail.com
  • 6 edits in trunk

[GTK] Enable DOM4 events constructors in development builds
https://bugs.webkit.org/show_bug.cgi?id=109471

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - the related tests now pass.

  • GNUmakefile.features.am.in: Add the feature define for the DOM4 events

constructors feature, its value defaulting to 0. This value is overridden
with 1 in development builds, effectively enabling the feature.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.

LayoutTests:

  • platform/gtk/TestExpectations: Remove the failure expectations, the related

tests now pass.

5:06 AM Changeset in webkit [142604] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for the GTK port after r142595.
Adding the TextureMapperFPSCounter files to the list of build targets
in case of using the OpenGL texture mapper.

  • GNUmakefile.list.am:
4:04 AM Changeset in webkit [142603] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in extension server and API
https://bugs.webkit.org/show_bug.cgi?id=109563

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionAPI.js: drive-by: make sure we fail if extensionServer is not defined in outer scope.
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/externs.js: add extensionServer
3:13 AM Changeset in webkit [142602] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed -- suppress stray console message that emerged after r142486.

  • inspector/extensions/extensions-events.html:
3:08 AM Changeset in webkit [142601] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Remove unnecessary variables from FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=109558

Reviewed by Daniel Bates.

A small cleanup, removing unused variables for which the related configuration
options were already removed.

  • Scripts/webkitperl/FeatureList.pm:
3:06 AM Changeset in webkit [142600] by zandobersek@gmail.com
  • 9 edits in trunk

Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
https://bugs.webkit.org/show_bug.cgi?id=109481

Reviewed by Daniel Bates.

The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
back in r120574. There are still occurrences of it in various build systems
which should all be removed as they are useless.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • features.gypi:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
2:58 AM Changeset in webkit [142599] by rniwa@webkit.org
  • 6 edits
    2 moves
    2 deletes in trunk/LayoutTests

REGRESSION(r142576): It made fast/dom/Element/id-in-deletebutton.html fail on Qt.
https://bugs.webkit.org/show_bug.cgi?id=109557

Build fix. Also move this test into platform/mac as done in r142559.

  • fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
  • fast/dom/Element/id-in-deletebutton.html: Removed.
  • platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/editing/deleting/id-in-deletebutton-expected.txt: Copied from LayoutTests/fast/dom/Element/id-in-deletebutton-expected.txt.
  • platform/mac/editing/deleting/id-in-deletebutton.html: Copied from LayoutTests/fast/dom/Element/id-in-deletebutton.html.
  • platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
2:49 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
2:34 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
2:06 AM Changeset in webkit [142598] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix !ENABLE(INSPECTOR) builds after r142575

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-12

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

2:04 AM Changeset in webkit [142597] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: move showWhitespace option into experiments
https://bugs.webkit.org/show_bug.cgi?id=109552

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Remove "show whitespace" setting and add it to experiments.

No new tests: fixed an existing test to verify changes.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

LayoutTests:

Fix layout test to switch on experiment instead of toggling one of the
options.

  • inspector/editor/text-editor-show-whitespace-expected.txt:
  • inspector/editor/text-editor-show-whitespace.html:
1:40 AM Changeset in webkit [142596] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Add error checking into OpenCL version of SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=107444

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-12
Reviewed by Zoltan Herczeg.

In case of an error the program runs through all the remaining filters by doing nothing.
After that deletes the results of every filter and starts software rendering.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore):
(WebCore::FilterEffect::applyAll): At software rendering this is a simple inline methode, but at OpenCL rendering it releases OpenCL things. If we have an error remove filter's results and start software rendering.
(WebCore::FilterEffect::clearResultsRecursive):
(WebCore::FilterEffect::openCLImageToImageBuffer):
(WebCore::FilterEffect::createOpenCLImageResult):
(WebCore::FilterEffect::transformResultColorSpace):

  • platform/graphics/filters/FilterEffect.h:

(FilterEffect):
(WebCore::FilterEffect::applyAll):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore::FilterContextOpenCL::isFailed):
(WebCore):
(WebCore::FilterContextOpenCL::freeResources):
(WebCore::FilterContextOpenCL::destroyContext):
(WebCore::FilterContextOpenCL::compileTransformColorSpaceProgram):
(WebCore::FilterContextOpenCL::openCLTransformColorSpace):
(WebCore::FilterContextOpenCL::compileProgram):
(WebCore::FilterContextOpenCL::freeResource):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(WebCore::FilterContextOpenCL::setInError):
(WebCore::FilterContextOpenCL::inError):
(FilterContextOpenCL):
(WebCore::FilterContextOpenCL::RunKernel::RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::addArgument):
(WebCore::FilterContextOpenCL::RunKernel::run):
(RunKernel):

  • platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:

(WebCore::FilterContextOpenCL::compileFEColorMatrix):
(WebCore::FEColorMatrix::platformApplyOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp:

(WebCore::FilterContextOpenCL::compileFETurbulence):
(WebCore::FETurbulence::platformApplyOpenCL):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

1:34 AM Changeset in webkit [142595] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk/Source

[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-12
Reviewed by Noam Rosenthal.

Source/WebCore:

r142524 implemented frames-per-second debug counter on WK2. This patch
applies frames-per-second debug counter to WK1 also.

Visual debugging feature, no need for new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperFPSCounter.cpp: Added.

(WebCore):
(WebCore::TextureMapperFPSCounter::TextureMapperFPSCounter):
(WebCore::TextureMapperFPSCounter::updateFPSAndDisplay):

  • platform/graphics/texmap/TextureMapperFPSCounter.h: Added.

(WebCore):
(TextureMapperFPSCounter):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::TextureMapperGL::drawNumber):

Rename from drawRepaintCounter to drawNumber.

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::TextureMapperImageBuffer::drawNumber):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:

(WebCore::CoordinatedBackingStore::drawRepaintCounter):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Move frames-per-second debug counter code to TextureMapperFPSCounter.

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/efl:

Make AcceleratedCompositingContextEfl use TextureMapperFPSCounter.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::renderLayers):

  • WebCoreSupport/AcceleratedCompositingContextEfl.h:

(AcceleratedCompositingContext):

Source/WebKit/gtk:

Make AcceleratedCompositingContext use TextureMapperFPSCounter.

  • WebCoreSupport/AcceleratedCompositingContext.h:
  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::compositeLayersToContext):

Source/WebKit/qt:

Make TextureMapperLayerClientQt use TextureMapperFPSCounter.

  • WebCoreSupport/TextureMapperLayerClientQt.cpp:

(TextureMapperLayerClientQt::renderCompositedLayers):

  • WebCoreSupport/TextureMapperLayerClientQt.h:

(TextureMapperLayerClientQt):

1:20 AM Changeset in webkit [142594] by yurys@chromium.org
  • 3 edits
    4 adds in trunk

Web Inspector: stack trace is cut at native bind if inspector is closed
https://bugs.webkit.org/show_bug.cgi?id=109427

Reviewed by Pavel Feldman.

Source/WebCore:

Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.

Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

LayoutTests:

Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
  • http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
  • platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
12:47 AM Changeset in webkit [142593] by jochen@chromium.org
  • 17 edits
    12 moves in trunk

[chromium] move webrtc mocks to testrunner library
https://bugs.webkit.org/show_bug.cgi?id=109041

Reviewed by Adam Barth.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(main):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::setInterfaces):
(MockWebKitPlatformSupport::createMediaStreamCenter):
(MockWebKitPlatformSupport::createRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(WebTestRunner):
(MockWebKitPlatformSupport):

  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::showContextMenu):
(WebTestRunner::WebTestProxy::userMediaClient):

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.

(WebTestRunner::MockConstraints::verifyConstraints):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.

(WebKit):
(WebTestRunner):
(MockConstraints):

  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.

(WebTestRunner):
(WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
(MockWebAudioDestinationConsumer):
(WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
(WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):

  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.

(WebKit):
(WebTestRunner):
(MockWebMediaStreamCenter):
(WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.

(WebTestRunner):
(DTMFSenderToneTask):
(WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
(WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
(WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
(WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
(WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
(WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.

(WebTestRunner):
(MockWebRTCDTMFSenderHandler):
(WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
(WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.

(WebTestRunner):
(DataChannelReadyStateTask):
(WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
(WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
(WebTestRunner::MockWebRTCDataChannelHandler::setClient):
(WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
(WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
(WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
(WebTestRunner::MockWebRTCDataChannelHandler::close):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.

(WebTestRunner):
(MockWebRTCDataChannelHandler):
(WebTestRunner::MockWebRTCDataChannelHandler::taskList):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.

(WebTestRunner):
(RTCSessionDescriptionRequestSuccededTask):
(WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCStatsRequestSucceededTask):
(WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(RTCVoidRequestTask):
(WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
(RTCPeerConnectionStateTask):
(WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
(RemoteDataChannelTask):
(WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
(WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
(WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
(WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
(WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
(WebTestRunner::MockWebRTCPeerConnectionHandler::stop):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.

(WebKit):
(WebTestRunner):
(MockWebRTCPeerConnectionHandler):
(WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
(WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::delegate):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::userMediaClient):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.

(WebTestRunner):
(UserMediaRequestTask):
(WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
(MockExtraData):
(WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
(WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.

(WebTestRunner):
(WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::taskList):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

LayoutTests:

Temporarily disable two WebRTC tests that fail due to a bug in
webkit_support's getCurrentTimeMillsecond.

  • platform/chromium/TestExpectations:
12:34 AM Changeset in webkit [142592] by tkent@chromium.org
  • 16 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Mouse click not on sub-fields in multiple fields input should not move focus
https://bugs.webkit.org/show_bug.cgi?id=109544

Reviewed by Kentaro Hara.

Source/WebCore:

This is similar to Bug 108914, "Should not move focus if the element
already has focus." We fixed a focus() case in Bug 108914. However we
still have the problem in a case of focusing by mouse click.

The fix for Bug 108914 intercepted focus() function to change the
behavior. However focus-by-click doesn't call focus(), but calls
FocusController::setFocusedNode. To fix this problem, we introduce
oldFocusedNode argument to handleFocusEvent, and
BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent restores the
focus to oldFocusedNode if oldFocusedNode is one of sub-fields.
handleFocusEvent is called whenever the focused node is changed.

We don't need InputType::willCancelFocus any more because the new code
in handleFocusEvent covers it.

Tests: Update fast/forms/time-multiple-fields/time-multiple-fields-focus.html.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add oldFocusedNode argument.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
Pass oldFocusedNode to handleFocusEvent.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • Add oldFocusedNode argument to handleFocusEvent.
  • Remove focus() override.
  • html/HTMLInputElement.cpp: Remove focus() override.

(WebCore::HTMLInputElement::handleFocusEvent):
Pass oldFocusedNode to InputType::handleFocusEvent.

  • html/InputType.cpp: Remove willCancelFocus.

(WebCore::InputType::handleFocusEvent):
Add oldFocusedNode argument.

  • html/InputType.h:

(InputType): Ditto.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent): Ditto.

  • html/PasswordInputType.h:

(PasswordInputType): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Remove willCancelFocus, and add oldFocusedNode argument to handleFocusEvent.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
Pass oldFocusedNode to DateTimeEditElement::focusByOwner if the
direction is FocusDirectionNone.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Add oldFocusedNode argument to focusByOwner.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusByOwner):
If oldFocusedNode is one of sub-fields, focus on it again.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-focus.html:

Add test to click a delimiter.

12:07 AM Changeset in webkit [142591] by tasak@google.com
  • 5 edits in trunk/Source/WebCore

[Refactoring] Make m_selectorChecker in StyleResolver an on-stack object.
https://bugs.webkit.org/show_bug.cgi?id=108595

Reviewed by Eric Seidel.

StyleResolver uses SelectorChecker's mode to change its resolving mode.
However it is a state of StyleResolver. StyleResolver should have the
mode and make SelectorChecker instance on a stack while required.

No new tests, just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheck):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
Changed to static class function, because these methods never use
"this".
(WebCore):

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
Now, matchesFocusPseudoClass is not a static method of
SelectorChecker, so replaced "m_selectorChecker." with
"SelectorChecker::".
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
Use m_mode instead of m_selectorChecker.mode().
Also use document()->inQuirksMode() instead of
m_selectoChecker.strictParsing().
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
Created an on-stack SelectorChecker object and used it to check
selectors.

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::State):
Added m_mode, this keeps m_selectorChecker's mode.
(State):
(StyleResolver):
Removed m_selectorChecker.

12:03 AM Changeset in webkit [142590] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
https://bugs.webkit.org/show_bug.cgi?id=109548

Unreviewed gardening.

  • tests/WebFrameTest.cpp:

Feb 11, 2013:

11:58 PM Changeset in webkit [142589] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

webkit-patch upload regenerates the WebCore ChangeLog every time it's called
https://bugs.webkit.org/show_bug.cgi?id=108983

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-11
Reviewed by Ryosuke Niwa.

This patch puts the behaviour from Bug 74358 behind the flag (default=OFF)
--update-changelogs', and removes the flag --no-prepare-changelogs'.
The flag name change from prepare to update is since we still want to
prepare changelogs in the default case when none currently exist.

  • Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

  • Scripts/webkitpy/tool/steps/options.py:

(Options):

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.options):
(PrepareChangeLog.run):

11:31 PM Changeset in webkit [142588] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove webintents from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=109537

Unreviewed. webintents tests no longer exist.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11

  • platform/efl/TestExpectations:
11:26 PM Changeset in webkit [142587] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt][EFL][WebGL] Minor refactoring of GraphicsSurface/GraphicsSurfaceGLX
https://bugs.webkit.org/show_bug.cgi?id=108686

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-11
Reviewed by Noam Rosenthal.

Remove unused platformSurface()/m_platformSurface from GraphicsSurface.
Move m_texture from GraphicsSurface to GLX GraphicsSurfacePrivate to match
Win and Mac implementations.

No new tests, refactoring only.

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::GraphicsSurface):

  • platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::surface):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::textureID):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformDestroy):

11:24 PM Changeset in webkit [142586] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[EFL][WebGL] WebGL content is not painted after resizing the viewport.
https://bugs.webkit.org/show_bug.cgi?id=106358

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-11
Reviewed by Noam Rosenthal.

Source/WebCore:

When page size changes and layer parameters get updated LayerTreeRenderer::setLayerState
clears the layer backing store and detaches the canvas surface from the layer. If the layer
size is not changed then the canvas is not recreated. This leaves the canvas detached from
the layer, but still referenced from m_surfaceBackingStores.
Don't assign layer backing store to layer in assignImageBackingToLayer if there is a canvas
surface already attached to the layer.

Test: fast/canvas/webgl/webgl-layer-update.html

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

LayoutTests:

Add test checking that canvas painting is correct if layer parameters were changed,
but webgl canvas didn't change.

  • fast/canvas/webgl/webgl-layer-update-expected.png: Added.
  • fast/canvas/webgl/webgl-layer-update-expected.txt: Added.
  • fast/canvas/webgl/webgl-layer-update.html: Added.
11:19 PM Changeset in webkit [142585] by jochen@chromium.org
  • 5 edits in trunk/Tools

[chromium] move printPage() implementation to testRunner library
https://bugs.webkit.org/show_bug.cgi?id=109436

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::showContextMenu):
(WebTestRunner::WebTestProxy::printPage):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner):
(WebTestRunner::WebTestProxyBase::printPage):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
10:50 PM Changeset in webkit [142584] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Some placeholder paint order tests are passing now
https://bugs.webkit.org/show_bug.cgi?id=109164

Unreviewed efl gardening.

fast/forms/input-placeholder-paint-order.html and
fast/forms/textarea/textarea-placeholder-paint-order.html are passing now.

RenderTheme::shouldShowPlaceholderWhenFocused() returns true by r127723
and the expectations are added by r140149.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11

  • platform/efl/TestExpectations:
10:49 PM Changeset in webkit [142583] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove editing/deleting/deletionUI-single-instance.html from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=109538

Unreviewed. This test is removed by r142559.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11

  • platform/efl/TestExpectations:
10:46 PM Changeset in webkit [142582] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

[Chromium] Get rid of WebAnimationController
https://bugs.webkit.org/show_bug.cgi?id=109235

Patch by James Robinson <jamesr@chromium.org> on 2013-02-11
Reviewed by Benjamin Poulain.

Source/WebKit/chromium:

  • public/WebAnimationController.h: Removed.
  • public/WebFrame.h:

(WebFrame):

  • src/WebAnimationControllerImpl.cpp: Removed.
  • src/WebAnimationControllerImpl.h: Removed.
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

10:42 PM Changeset in webkit [142581] by jamesr@google.com
  • 6 edits in trunk/Source

[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

  • chromium/public/WebUnitTestSupport.h:

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

10:30 PM Changeset in webkit [142580] by eric.carlson@apple.com
  • 22 edits
    2 adds in trunk

[Mac] Track language selection should be sticky
https://bugs.webkit.org/show_bug.cgi?id=109466

Reviewed by Dean Jackson.

.:

  • Source/autotools/symbols.filter: Export PageGroup::captionPreferences and Page::initGroup.

Source/WebCore:

Choosing a text track from the caption menu should make that track's language the
preferred caption language. Turning captions off from the menu should disable captions
in videos loaded subsequently.

OS X has system support for these settings, so changes made by DRT should not change the
settings on the user's system. Add support for all other ports in DRT only.

Test: media/track/track-user-preferences.html

  • WebCore.exp.in: Export PageGroup::captionPreferences().
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Use page()->group().captionPreferences().
(WebCore::HTMLMediaElement::attach): Ditto.
(WebCore::HTMLMediaElement::detach): Ditto.
(WebCore::HTMLMediaElement::userPrefersCaptions): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto. Update for

preferredLanguageFromList change.

(WebCore::HTMLMediaElement::toggleTrackAtIndex): Set user prefs for captions visible and

caption language as appropriate.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Remove unneeded comment.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Use page()->group().captionPreferences().

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::closedCaptionTracksChanged): Update caption menu button visibility.

  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::userPrefersCaptions): Support "testing" mode.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferences::preferredLanguages): Ditto.
(WebCore::CaptionUserPreferences::testingMode): Ditto.
(WebCore::CaptionUserPreferences::setTestingMode): Ditto.
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Ditto.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Change name from

registerForCaptionPreferencesChangedCallbacks. Support "testing" mode.

(WebCore::CaptionUserPreferencesMac::unregisterForPreferencesChangedCallbacks): Change name from

unregisterForCaptionPreferencesChangedCallbacks. Support "testing" mode.

(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto. Return the platform override when set.

  • page/PageGroup.cpp:

(WebCore::PageGroup::registerForCaptionPreferencesChangedCallbacks): Remove because it is already

available from the caption preference object.

(WebCore::PageGroup::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::PageGroup::userPrefersCaptions): Ditto.
(WebCore::PageGroup::userHasCaptionPreferences): Ditto.
(WebCore::PageGroup::captionFontSizeScale): Ditto.

  • page/PageGroup.h:
  • platform/Language.cpp:

(WebCore::preferredLanguageFromList): Take the list of preferred languages instead of assuming

the system list.

  • platform/Language.h:
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Disable caption testing mode.
(WebCore::Internals::Internals): Enable caption testing mode so the user's system

preferences are not modified.

LayoutTests:

  • media/track/track-user-preferences-expected.txt: Added.
  • media/track/track-user-preferences.html: Added.
  • platform/chromium/TestExpectations: Skip new test, it depends on the track menu.
  • platform/efl/TestExpectations: Ditto.
  • platform/gtk/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
10:26 PM Changeset in webkit [142579] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Coordinated Graphics: Make CoordinatedGraphicsScene not know contents size.
https://bugs.webkit.org/show_bug.cgi?id=108922

Source/WebCore:

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.

Currently, CoordinatedGraphicsScene has two methods to know contents
size: setContentsSize() and setVisibleContentsRect(). Contents size is
used when adjusting a scroll position, but adjustment is not needed
because EFL and Qt platform code (currently PageViewportController)
already adjusts a scroll position, and it is natural for each platform
to be in charge of adjusting. So this patch makes CoordinatedGraphicsScene
not know contents size.

In addition, now DrawingAreaProxy::coordinatedLayerTreeHostProxy() is only used
to get CoordinatedGraphicsScene.

This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html

ManualTests/nested-fixed-position.html

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setScrollPosition):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Benjamin Poulain.

Currently, CoordinatedGraphicsScene has two methods to know contents
size: setContentsSize() and setVisibleContentsRect(). Contents size is
used when adjusting a scroll position, but adjustment is not needed
because EFL and Qt platform code (currently PageViewportController)
already adjusts a scroll position, and it is natural for each platform
to be in charge of adjusting. So this patch makes CoordinatedGraphicsScene
not know contents size.

In addition, now DrawingAreaProxy::coordinatedLayerTreeHostProxy() is only used
to get CoordinatedGraphicsScene.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setSize):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(CoordinatedLayerTreeHostProxy):

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::didChangeContentsSize):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

9:29 PM Changeset in webkit [142578] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Coordinated Graphics: remove the DidChangeScrollPosition message.
https://bugs.webkit.org/show_bug.cgi?id=108051

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Benjamin Poulain.

Currently, we use the DidChangeScrollPosition message to send the scroll
position that WebCore used in this frame to UI Process. We had to have
some member variables for the DidChangeScrollPosition message.
However, we can send a scroll position via the DidRenderFrame message,
because CoordinatedGraphicsScene::m_renderedContentsScrollPosition is
updated at the moment of flushing. So we can remove the
DidChangeScrollPosition message and some redundant member variables.

Source/WebCore:

No tests. No change in behavior.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::flushLayerChanges):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::didRenderFrame):
(WebKit):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(CoordinatedLayerTreeHostProxy):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in: Remove the DidChangeScrollPosition message.
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):

Send a scroll position via the DidChangeScrollPosition message.

(WebKit::CoordinatedLayerTreeHost::syncLayerState):

Don't send a scroll position because flushPendingLayerChanges() does
that. In addition, it is weird to check if we must send a scroll
position at the moment of sending the SyncLayerState message of every
layers.

(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
9:11 PM Changeset in webkit [142577] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Build fix.

8:55 PM Changeset in webkit [142576] by rniwa@webkit.org
  • 40 edits in trunk

Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
https://bugs.webkit.org/show_bug.cgi?id=109534

Reviewed by Anders Carlsson.

Source/WebCore:

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::show):

  • editing/Editor.cpp:

(WebCore):

  • editing/Editor.h:

(Editor):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldDeleteRange):
(EmptyEditorClient):
(WebCore::EmptyEditorClient::shouldShowDeleteInterface):

  • page/EditorClient.h:

(EditorClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:
  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit):

  • WebCoreSupport/EditorClientWinCE.h:

(EditorClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Source/WTF:

  • wtf/Platform.h:

Tools:

  • DumpRenderTree/gtk/EditingCallbacks.cpp:

(shouldShowDeleteInterfaceForElement):

8:43 PM Changeset in webkit [142575] by hayato@chromium.org
  • 7 edits in trunk/Source/WebCore

Factor EventContext and introduces MouseOrFocusEventContext.
https://bugs.webkit.org/show_bug.cgi?id=109278

Reviewed by Dimitri Glazkov.

To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent or FocusEvent,
but also other events.

This is the first attempt to refactor event retargeting code, a
separated patch from bug 109156. EventContext is now factored and
MouseOrFocusEventContext was introduced to support MouseEvent or
FocusEvent separately.

In following patches, I'll introduce TouchEventContext and
TouchEventDispatchMediator to support Touch event retargeting.

No new tests. No change in functionality.

  • dom/EventContext.cpp:

(WebCore::EventContext::EventContext): Factor relatedTarget out from EventContext into MouseOrFocusEventContext.
(WebCore::EventContext::~EventContext):
(WebCore):
(WebCore::EventContext::handleLocalEvents):
(WebCore::EventContext::isMouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext): New. Handles MouseEvent's (or FocusEvent's) relatedTarget retargeting.
(WebCore::MouseOrFocusEventContext::~MouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::handleLocalEvents):
(WebCore::MouseOrFocusEventContext::isMouseOrFocusEventContext):

  • dom/EventContext.h:

(EventContext):
(WebCore::EventContext::node):
(WebCore::EventContext::target):
(WebCore::EventContext::currentTargetSameAsTarget):
(WebCore):
(MouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::relatedTarget):
(WebCore::MouseOrFocusEventContext::setRelatedTarget):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventPath): Renamad from ensureEventAncestors. Use the DOM Core terminology.
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):

  • dom/EventDispatcher.h:

(EventRelatedTargetAdjuster):
(EventDispatcher):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::eventHasListeners):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDispatchEvent):

8:34 PM Changeset in webkit [142574] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Curl] setCookiesFromDOM function does not save cookies to disk.
https://bugs.webkit.org/show_bug.cgi?id=109285

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-11
Reviewed by Brent Fulgham.

Write cookies to disk by using the Curl easy api.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookiesFromDOM):Write cookie to disk.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::getCurlShareHandle): Added method to get Curl share handle.
(WebCore::ResourceHandleManager::getCookieJarFileName): Added method to get cookie file name.

  • platform/network/curl/ResourceHandleManager.h: Added methods to get cookie file name, and Curl share handle.
8:32 PM Changeset in webkit [142573] by hayato@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

Split each RuleSet and feature out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107777

Reviewed by Dimitri Glazkov.

Re-landing r141964, which was reverted in r141973, since r141964 seem to be innocent.

No tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/DocumentRuleSets.cpp: Added.

(WebCore):
(WebCore::DocumentRuleSets::DocumentRuleSets):
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle): New helper to initialize each RuleSets.
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets): Factored out from StyleResolver.
(WebCore::makeRuleSet): Ditto.
(WebCore::DocumentRuleSets::resetAuthorStyle): Ditto.
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Ditto.
(WebCore::DocumentRuleSets::collectFeatures): Ditto.
(WebCore::DocumentRuleSets::reportMemoryUsage): New methods to report memory usage. Factored out from StyleResolver.

  • css/DocumentRuleSets.h: Added.

(WebCore):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::authorStyle): Moved from StyleResolver.
(WebCore::DocumentRuleSets::userStyle): Ditto.
(WebCore::DocumentRuleSets::features): Ditto.
(WebCore::DocumentRuleSets::sibling): Ditto.
(WebCore::DocumentRuleSets::uncommonAttribute): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets): Now calls DocumentRuleSets::appendAuthorStyleSheets.
(WebCore::StyleResolver::matchAuthorRules): Use m_ruleSets.
(WebCore::StyleResolver::matchUserRules): Ditto.
(WebCore::StyleResolver::classNamesAffectedByRules): Ditto.
(WebCore::StyleResolver::locateCousinList): Ditto.
(WebCore::StyleResolver::canShareStyleWithElement): Ditto.
(WebCore::StyleResolver::locateSharedStyle): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::checkRegionStyle): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::reportMemoryUsage): Now calls DocumentRuleSets::reportMemoryUsage.

  • css/StyleResolver.h:

(WebCore::StyleResolver::scopeResolver):
(StyleResolver):
(WebCore::StyleResolver::ruleSets): accessor r to DocumentRuleSets.
(WebCore::StyleResolver::usesSiblingRules): Use m_ruleSets.
(WebCore::StyleResolver::usesFirstLineRules): Ditto.
(WebCore::StyleResolver::usesBeforeAfterRules): Ditto.
(WebCore::StyleResolver::hasSelectorForAttribute): Ditto.
(WebCore::StyleResolver::hasSelectorForClass): Ditto.
(WebCore::StyleResolver::hasSelectorForId): Ditto.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

8:24 PM Changeset in webkit [142572] by keishi@webkit.org
  • 6 edits
    3 adds in trunk

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

  • Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.
8:23 PM Changeset in webkit [142571] by aelias@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium] Apply page scale to all WebInputEvent types
https://bugs.webkit.org/show_bug.cgi?id=109370

Reviewed by James Robinson.

Previously we only adjusted a few common input event types by page
scale, but in fact almost every position and size in WebInputEvents
requires it.

I also took the opportunity to change some WebGestureEvent members to
floats (which I checked causes no warnings in Chromium-side code with
GCC or Clang).

New WebInputEventConversionTest: InputEventsScaling

  • public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::widgetScaleFactor):
(WebKit):
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit::WebViewImpl::handleInputEvent):

  • tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):
(WebCore):

8:22 PM Changeset in webkit [142570] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

REGRESSION (r142549): Remove web intents code
https://bugs.webkit.org/show_bug.cgi?id=109532

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
Reviewed by Nico Weber.

Remove remaning code related to web intents.

No new tests, no change on behavior.

  • UseJSC.cmake:
  • bindings/js/JSIntentConstructor.cpp: Removed.
8:17 PM Changeset in webkit [142569] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Unreviewed, rolling out r142568.
http://trac.webkit.org/changeset/142568
https://bugs.webkit.org/show_bug.cgi?id=109541

Broke the build, won't compile. (Requested by alancutter on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

Source/Platform:

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

  • chromium/public/WebUnitTestSupport.h:

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

6:50 PM Changeset in webkit [142568] by jamesr@google.com
  • 6 edits in trunk/Source

[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

  • chromium/public/WebUnitTestSupport.h:

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

6:38 PM Changeset in webkit [142567] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
https://bugs.webkit.org/show_bug.cgi?id=109127

Reviewed by Dean Jackson.

No new tests. Built and tested WebKit and Chromium with this change.

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore):

Define temporary typedef spanning int -> size_t change.

(WebCore::getValidationResultValue):
(WebCore::getSymbolInfo):

Use temporary typedef.

6:38 PM Changeset in webkit [142566] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181817. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

  • DEPS:
6:06 PM Changeset in webkit [142565] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] ScheduledAction::m_context can be empty, so we shouldn't
retrieve an Isolate by using m_context->GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=109523

Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges

Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate().
This can crash because ScheduledAction::m_context can be empty. Specifically,
ScheduledAction::m_context is set to ScriptController::currentWorldContext(),
which can return an empty handle when a frame does not exist. In addition,
'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty.

Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.

No tests. The Chromium crash report doesn't provide enough information
to reproduce the bug.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore):
(WebCore::ScheduledAction::~ScheduledAction):

  • bindings/v8/ScheduledAction.h:

(ScheduledAction):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

5:58 PM Changeset in webkit [142564] by dgrogan@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519

Reviewed by Adam Barth.

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:
5:52 PM Changeset in webkit [142563] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Build fix: r142549 broke EFL build
https://bugs.webkit.org/show_bug.cgi?id=109527

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-11
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests, no change on behavior.

  • CMakeLists.txt:

Source/WebKit:

Build fix.

  • CMakeLists.txt:
5:42 PM Changeset in webkit [142562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Build fix
https://bugs.webkit.org/show_bug.cgi?id=109518

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-11
Reviewed by Laszlo Gombos.

Fix EFL build by including PluginProcessConnectionManager.messages.in in
CMakeLists.txt

  • CMakeLists.txt:
5:35 PM Changeset in webkit [142561] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSION (r142520?): Space no longer scrolls the page
https://bugs.webkit.org/show_bug.cgi?id=109526

Reviewed by Tim Horton.

ScrollingTree::updateTreeFromStateNode() used to bail early when it had
no children (no fixed or sticky elements), but that left updateAfterChildren()
uncalled. Fix by always calling updateAfterChildren(), which updates the scroll
position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

5:31 PM Changeset in webkit [142560] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Remove extra early-return in FrameView::setScrollPosition

Rubber-stamped by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):

5:31 PM Changeset in webkit [142559] by rniwa@webkit.org
  • 6 edits
    3 moves
    4 deletes in trunk/LayoutTests

Move deletionUI tests into platform/mac
https://bugs.webkit.org/show_bug.cgi?id=109517

Reviewed by Benjamin Poulain.

Moved deletionUI tests into platform/mac since Mac is the only port that ships this feature.

  • editing/deleting/5408255-expected.txt: Removed.
  • editing/deleting/5408255.html: Removed.
  • editing/deleting/deletionUI-single-instance.html: Removed.
  • platform/chromium/editing/deleting/deletionUI-single-instance-expected.png: Removed.
  • platform/chromium/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/mac/editing/deleting/deletionUI-click-on-delete-button-expected.txt: Copied from LayoutTests/editing/deleting/5408255-expected.txt.
  • platform/mac/editing/deleting/deletionUI-click-on-delete-button.html: Copied from LayoutTests/editing/deleting/5408255.html.
  • platform/mac/editing/deleting/deletionUI-single-instance.html: Copied from LayoutTests/editing/deleting/deletionUI-single-instance.html.
  • platform/qt-mac/TestExpectations:
  • platform/qt/editing/deleting/deletionUI-single-instance-expected.png: Removed.
  • platform/qt/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
5:29 PM Changeset in webkit [142558] by arko@motorola.com
  • 2 edits in trunk/Source/WebCore

[Microdata] Fix crash after r141034 in chromuim port
https://bugs.webkit.org/show_bug.cgi?id=109514

Reviewed by Ryosuke Niwa.

Added V8SkipVTableValidation extended attribute to skip
VTable validation check for DOMSettableTokenList interface.

This patch fixes below test failures:
Tests: fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html

fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html
fast/dom/MicroData/element-with-empty-itemprop.html
fast/dom/MicroData/itemprop-add-remove-tokens.html
fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
fast/dom/MicroData/itemprop-must-be-read-only.html
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
fast/dom/MicroData/itemref-add-remove-tokens.html
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
fast/dom/MicroData/itemref-must-be-read-only.html
fast/dom/MicroData/itemtype-add-remove-tokens.html
fast/dom/MicroData/itemtype-attribute-test.html
fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html
fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html
fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html
fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html

  • html/DOMSettableTokenList.idl:
5:20 PM Changeset in webkit [142557] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Make JSC API more NULL tolerant
https://bugs.webkit.org/show_bug.cgi?id=109515

Reviewed by Mark Hahnenberg.

We do so much marshalling for the C API these days anyway that a single null
check isn't a performance issue. Yet the existing "null is unsafe" behaviour
leads to crashes in embedding applications whenever there's an untested code
path, so it seems having defined behaviour is superior.

  • API/APICast.h:

(toJS):
(toJSForGC):

  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):

  • API/tests/testapi.c:

(main):

5:09 PM Changeset in webkit [142556] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebProcess.cpp:
5:07 PM Changeset in webkit [142555] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

Load event fires too early with threaded HTML parser (take 2)
https://bugs.webkit.org/show_bug.cgi?id=109485

Reviewed by Eric Seidel.

Source/WebCore:

This patch restores the code that was removed in
http://trac.webkit.org/changeset/142492 and adds code to
DocumentLoader.cpp to avoid the regression.

  • dom/Document.cpp:

(WebCore::Document::hasActiveParser):
(WebCore::Document::decrementActiveParserCount):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense):

LayoutTests:

This patch also fixes a bug whereby removing an iframe during the load
event would trigger DumpRenderTree to dump the test in the middle of
the load event. We now wait until the load event is over.

  • compositing/iframes/remove-iframe-crash-expected.txt:
  • fast/frames/iframe-access-screen-of-deleted-expected.txt:
  • fast/frames/remove-frame-during-load-event-expected.txt: Added.
  • fast/frames/remove-frame-during-load-event.html: Added.
  • http/tests/misc/xslt-bad-import-expected.txt:
5:05 PM Changeset in webkit [142554] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, adding a FIXME to remind ourselves of a bug.
https://bugs.webkit.org/show_bug.cgi?id=109487

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

4:55 PM Changeset in webkit [142553] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[GTK] Build fix.
https://bugs.webkit.org/show_bug.cgi?id=109516

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-11
Reviewed by Csaba Osztrogonác.

PluginProcessConnectionManagerMessages are omitted from messages list.

  • GNUmakefile.list.am:
4:53 PM Changeset in webkit [142552] by eric@webkit.org
  • 7 edits in trunk/Source/WebCore

Fold HTMLTokenizerState back into HTMLTokenizer now that MarkupTokenizerBase is RFG
https://bugs.webkit.org/show_bug.cgi?id=109502

Reviewed by Tony Gentilcore.

Just a search replace of HTMLTokenizerState with HTMLTokenizer and moving the enum.
This restores us to the peacefull world pre-NEW_XML.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::forcePlaintextForTextDocument):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::isEndTagBufferingState):
(WebCore):
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushEmitAndResumeIn):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):

  • html/parser/HTMLTokenizer.h:

(HTMLTokenizer):
(WebCore::HTMLTokenizer::create):
(WebCore::HTMLTokenizer::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::emitEndOfFile):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/TextViewSourceParser.cpp:

(WebCore::TextViewSourceParser::TextViewSourceParser):

4:49 PM Changeset in webkit [142551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181787. Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

  • DEPS:
4:46 PM Changeset in webkit [142550] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Build fix after r142528
https://bugs.webkit.org/show_bug.cgi?id=109520

Reviewed by Eric Seidel.

r142528 changed GIFImageReader from a struct to a class.
We also need to fix a forward declaration.

No tests.

  • platform/image-decoders/gif/GIFImageDecoder.h:
4:39 PM Changeset in webkit [142549] by thakis@chromium.org
  • 40 edits
    52 deletes in trunk

Remove web intents code
https://bugs.webkit.org/show_bug.cgi?id=109501

Reviewed by Eric Seidel.

See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.

Source/WebCore:

  • DerivedSources.make:
  • Modules/intents/DOMWindowIntents.cpp: Removed.
  • Modules/intents/DOMWindowIntents.h: Removed.
  • Modules/intents/DOMWindowIntents.idl: Removed.
  • Modules/intents/DeliveredIntent.cpp: Removed.
  • Modules/intents/DeliveredIntent.h: Removed.
  • Modules/intents/DeliveredIntent.idl: Removed.
  • Modules/intents/Intent.cpp: Removed.
  • Modules/intents/Intent.h: Removed.
  • Modules/intents/Intent.idl: Removed.
  • Modules/intents/IntentRequest.cpp: Removed.
  • Modules/intents/IntentRequest.h: Removed.
  • Modules/intents/IntentResultCallback.h: Removed.
  • Modules/intents/IntentResultCallback.idl: Removed.
  • Modules/intents/NavigatorIntents.cpp: Removed.
  • Modules/intents/NavigatorIntents.h: Removed.
  • Modules/intents/NavigatorIntents.idl: Removed.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • bindings/v8/custom/V8IntentCustom.cpp: Removed.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLIntentElement.cpp: Removed.
  • html/HTMLIntentElement.h: Removed.
  • html/HTMLIntentElement.idl: Removed.
  • loader/EmptyClients.cpp:
  • loader/EmptyClients.h:

(EmptyFrameLoaderClient):

  • loader/FrameLoaderClient.h:

(WebCore):

  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebDeliveredIntentClient.h: Removed.
  • public/WebFrame.h:

(WebKit):
(WebFrame):

  • public/WebFrameClient.h:

(WebKit):

  • public/WebIntent.h: Removed.
  • public/WebIntentRequest.h: Removed.
  • public/WebIntentServiceInfo.h: Removed.
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/DeliveredIntentClientImpl.cpp: Removed.
  • src/DeliveredIntentClientImpl.h: Removed.
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebKit):
(WebFrameImpl):

  • src/WebIntent.cpp: Removed.
  • src/WebIntentRequest.cpp: Removed.
  • src/WebIntentServiceInfo.cpp: Removed.
  • src/WebRuntimeFeatures.cpp:

Tools:

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner::WebTestProxy::didEndEditing):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • webintents/intent-tag-expected.txt: Removed.
  • webintents/intent-tag.html: Removed.
  • webintents/resources/pass.html: Removed.
  • webintents/resources/web-intents-reload-orig.html: Removed.
  • webintents/resources/web-intents-testing.js: Removed.
  • webintents/web-intents-api-expected.txt: Removed.
  • webintents/web-intents-api.html: Removed.
  • webintents/web-intents-delivery-expected.txt: Removed.
  • webintents/web-intents-delivery-reuse-expected.txt: Removed.
  • webintents/web-intents-delivery-reuse.html: Removed.
  • webintents/web-intents-delivery.html: Removed.
  • webintents/web-intents-failure-expected.txt: Removed.
  • webintents/web-intents-failure.html: Removed.
  • webintents/web-intents-invoke-expected.txt: Removed.
  • webintents/web-intents-invoke-port-expected.txt: Removed.
  • webintents/web-intents-invoke-port.html: Removed.
  • webintents/web-intents-invoke.html: Removed.
  • webintents/web-intents-obj-constructor-expected.txt: Removed.
  • webintents/web-intents-obj-constructor.html: Removed.
  • webintents/web-intents-reload-expected.txt: Removed.
  • webintents/web-intents-reload.html: Removed.
  • webintents/web-intents-reply-expected.txt: Removed.
  • webintents/web-intents-reply.html: Removed.
4:36 PM Changeset in webkit [142548] by schenney@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

SVG DOM manipulation crash
https://bugs.webkit.org/show_bug.cgi?id=108709

Reviewed by Eric Seidel.

Adding a test for the case where an SVG <use> tree is rebuild due to
one event listener and a subsequent listener tries to access it. This
does not crash in WebKit but has caused problems in browser code where
the listener tries to access and use toNode on the target of the
event. The test prevents regressions and gives automated security
tests something to work on.

  • svg/custom/use-listener-append-crash-expected.txt: Added.
  • svg/custom/use-listener-append-crash.html: Added.
4:33 PM Changeset in webkit [142547] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Mac build after http://trac.webkit.org/changeset/142535.

Unreviewed build fix.

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::emitAndReconsumeIn):

4:32 PM Changeset in webkit [142546] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make WebCore Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109324

Patch by David Farler <dfarler@apple.com> on 2013-02-11
Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj: Pass SDKROOT to make for DerivedSources.make
4:31 PM Changeset in webkit [142545] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
https://bugs.webkit.org/show_bug.cgi?id=109508

Reviewed by Kenneth Russell.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension): Check whether the extension support is there before returning the extension pointer.

4:29 PM Changeset in webkit [142544] by fpizlo@apple.com
  • 15 edits
    6 adds in trunk

Strange bug in DFG OSR in JSC
https://bugs.webkit.org/show_bug.cgi?id=109491

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Int32ToDouble was being injected after a side-effecting operation and before a SetLocal. Anytime we
inject something just before a SetLocal we should be aware that the previous operation may have been
a side-effect associated with the current code origin. Hence, we should use a forward exit.
Int32ToDouble does not do forward exits by default.

This patch adds a forward-exiting form of Int32ToDouble, for use in SetLocal Int32ToDouble injections.
Changed the CSE and other things to treat these nodes identically, but for the exit strategy to be
distinct (Int32ToDouble -> backward, ForwardInt32ToDouble -> forward). The use of the NodeType for
signaling exit direction is not "great" but it's what we use in other places already (like
ForwardCheckStructure).

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::willHaveCodeGenOrOSR):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

LayoutTests:

Reviewed by Mark Hahnenberg.

Added one version of the test (dfg-int32-to-double-on-set-local-and-exit) that is based
exactly on Gabor's original test, and another that ought to fail even if I fix other bugs
in the future (see https://bugs.webkit.org/show_bug.cgi?id=109511).

  • fast/js/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Added.
  • fast/js/dfg-int32-to-double-on-set-local-and-exit.html: Added.
  • fast/js/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Added.
  • fast/js/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Added.
  • fast/js/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Added.

(checkpoint):
(func1):
(func2):
(func3):
(test):

  • fast/js/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Added.

(checkpoint):
(func1):
(func2):
(func3):
(test):

4:27 PM Changeset in webkit [142543] by Lucas Forschler
  • 5 edits in branches/safari-534.59-branch/Source

Versioning.

4:21 PM Changeset in webkit [142542] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] setMinimumLayoutWidth should bail if there's no WebProcess
https://bugs.webkit.org/show_bug.cgi?id=109512
<rdar://problem/13093627>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMinimumLayoutWidth):

4:10 PM Changeset in webkit [142541] by Lucas Forschler
  • 1 copy in branches/safari-534.59-branch

New Branch.

4:08 PM Changeset in webkit [142540] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

PluginProcessConnectionManager should be a QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109496

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::didReceiveMessageOnConnectionWorkQueue):
(WebKit):
(WebKit::PluginProcessConnectionManager::didCloseOnConnectionWorkQueue):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:

(WebProcess):

4:07 PM Changeset in webkit [142539] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Change RenderFrameSet::paint to use m-rows/m_cols directly.
https://bugs.webkit.org/show_bug.cgi?id=108503

Source/WebCore:

Reviewed by Eric Seidel.

Test: fast/frames/invalid-frameset.html

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paint):

LayoutTests:

Reviewed by Eric Seidel.

Add test for how we render an invalid frameset.

  • fast/frames/invalid-frameset-expected.html: Added.
  • fast/frames/invalid-frameset.html: Added.
4:01 PM Changeset in webkit [142538] by yoli@rim.com
  • 2 edits in trunk/Source/WebCore

XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary
https://bugs.webkit.org/show_bug.cgi?id=105348

Reviewed by Alexey Proskuryakov.

Let resume() clear the defer flag and return if there is deferred events to dispatch.

No new tests as this should not affect existing cross-platform behavior. It should be
OK as long as it doesn't break anything.

  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::resume):

3:54 PM Changeset in webkit [142537] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

[iOS] Upstream changes to Platform.h
<http://webkit.org/b/109459>

Reviewed by Benjamin Poulain.

  • wtf/Platform.h:
  • Changes for armv7s.
  • Add ENABLE() definitions for DASHBOARD_SUPPORT and WEBGL.
  • Re-sort USE() macros.
  • Remove ENABLE() macros for JIT, LLINT and YARR_JIT to enable on iOS Simulator. They are already defined below.
  • Turn off HAVE(HOSTED_CORE_ANIMATION) for iOS.
  • Turn on USE(COREMEDIA) for iOS 6.0 and later.
3:53 PM Changeset in webkit [142536] by oliver@apple.com
  • 3 edits in trunk/Source/WTF

Harden FastMalloc (again)
https://bugs.webkit.org/show_bug.cgi?id=109334

Reviewed by Mark Hahnenberg.

Re-implement hardening of linked lists in TCMalloc.

In order to keep heap introspection working, we need to thread the
heap entropy manually as the introspection process can't use the
address of a global in determining the mask. Given we now have to
thread a value through anyway, I've stopped relying on ASLR for entropy
and am simply using arc4random() on darwin, and time + ASLR everywhere
else.

I've also made an explicit struct type for the FastMalloc singly linked
lists, as it seemed like the only way to reliably distinguish between
void*'s that were lists vs. void* that were not. This also made it
somewhat easier to reason about things across processes.

Verified that all the introspection tools work as expected.

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(HardenedSLL):
(WTF::HardenedSLL::create):
(WTF::HardenedSLL::null):
(WTF::HardenedSLL::setValue):
(WTF::HardenedSLL::value):
(WTF::HardenedSLL::operator!):
(WTF::HardenedSLL::operator UnspecifiedBoolType):
(TCEntry):
(WTF::SLL_Next):
(WTF::SLL_SetNext):
(WTF::SLL_Push):
(WTF::SLL_Pop):
(WTF::SLL_PopRange):
(WTF::SLL_PushRange):
(WTF::SLL_Size):
(PageHeapAllocator):
(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::Delete):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::Span::next):
(WTF::Span::remoteNext):
(WTF::Span::prev):
(WTF::Span::setNext):
(WTF::Span::setPrev):
(Span):
(WTF::DLL_Init):
(WTF::DLL_Remove):
(WTF::DLL_IsEmpty):
(WTF::DLL_Length):
(WTF::DLL_Prepend):
(TCMalloc_Central_FreeList):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(WTF::TCMalloc_Central_FreeList::entropy):
(TCMalloc_PageHeap):
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::ReturnedBytes):
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::TCMalloc_PageHeap::ReleaseFreeList):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Init):
(WTF::TCMalloc_ThreadCache_FreeList::empty):
(WTF::TCMalloc_ThreadCache_FreeList::Push):
(WTF::TCMalloc_ThreadCache_FreeList::PushRange):
(WTF::TCMalloc_ThreadCache_FreeList::PopRange):
(WTF::TCMalloc_ThreadCache_FreeList::Pop):
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects):
(TCMalloc_ThreadCache):
(WTF::TCMalloc_Central_FreeList::Init):
(WTF::TCMalloc_Central_FreeList::ReleaseListToSpans):
(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):
(WTF::TCMalloc_Central_FreeList::InsertRange):
(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):
(WTF::TCMalloc_Central_FreeList::FetchFromSpans):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Init):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::FetchFromCentralCache):
(WTF::TCMalloc_ThreadCache::ReleaseToCentralCache):
(WTF::TCMalloc_ThreadCache::InitModule):
(WTF::TCMalloc_ThreadCache::NewHeap):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/MallocZoneSupport.h:

(RemoteMemoryReader):

3:52 PM Changeset in webkit [142535] by eric@webkit.org
  • 10 edits
    1 delete in trunk/Source/WebCore

Fold MarkupTokenizerBase into HTMLTokenizer now that it is the only subclass
https://bugs.webkit.org/show_bug.cgi?id=109499

Reviewed by Adam Barth.

For great justice. And sanity.
Epic amount of template code deleted.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::HTMLTokenizer):

  • html/parser/HTMLTokenizer.h:

(HTMLTokenizer):
(Checkpoint):
(WebCore::HTMLTokenizer::state):
(WebCore::HTMLTokenizer::setState):
(WebCore::HTMLTokenizer::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::bufferCharacter):
(WebCore::HTMLTokenizer::emitAndResumeIn):
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
(WebCore::HTMLTokenizer::emitEndOfFile):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):

  • xml/parser/MarkupTokenizerBase.h: Removed.
3:48 PM Changeset in webkit [142534] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
https://bugs.webkit.org/show_bug.cgi?id=109054

Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-11
Reviewed by Julien Chaffraix.

No behavioral changes thus no new tests or test changes.

  • rendering/TextAutosizer.cpp:

(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):

Remember narrow descendants of the parent cluster for later processing.

3:47 PM Changeset in webkit [142533] by enrica@apple.com
  • 15 edits in trunk/Source

Source/WebCore: Add ENABLE_DELETION_UI to control the use of the deletion UI.
https://bugs.webkit.org/show_bug.cgi?id=109463.

Reviewed by Ryosuke Niwa.

This patch adds #if ENABLE(DELETION_UI) in every spot where
DeleteButtonController is used. This class is now only instantiated
if the feature is enabled. I've also done some cleanup in the
DeleteButtonController class, removing unused methods and making
private some methods only used internally to the class.
Both DeleteButtonController and DeleteButton classes are now excluded
from the compilation if the feature is not enabled.

No new tests, no change of functionality.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::cloneChildNodes):

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):

  • editing/DeleteButton.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/DeleteButtonController.h: Some cleanup.

(WebCore::DeleteButtonController::enabled): Made private.

  • editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):

  • editing/Editor.cpp:

(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::Editor):
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::deviceScaleFactorChanged):

  • editing/Editor.h:
  • editing/htmlediting.cpp: avoidIntersectionWithNode is

used only if the feature is enabled.

  • editing/htmlediting.h:
  • editing/markup.cpp:

(WebCore::createMarkup):
(WebCore::createFragmentFromNodes):

  • rendering/RenderTable.cpp: Removed unnecessary include

fo DeleteButtonController.h

Source/WTF: Add ENABLE_DELETION_UI to control the use of the deletion UI.
https://bugs.webkit.org/show_bug.cgi?id=109463.

ENABLE_DELETION_UI is set to 1 by default for
all ports. It is explicitly enabled for MAC and disabled for iOS.

Reviewed by Ryosuke Niwa.

  • wtf/Platform.h:
3:42 PM Changeset in webkit [142532] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed WK2 buildfix after r142518.

  • DerivedSources.pri:
3:34 PM Changeset in webkit [142531] by rafaelw@chromium.org
  • 5 edits in trunk

[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338

Reviewed by Adam Barth.

Source/WebCore:

This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.

Tests added to html5lib.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

  • html5lib/resources/template.dat:
3:34 PM Changeset in webkit [142530] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

NonStringCell and Object are practically the same thing for the purpose of speculation
https://bugs.webkit.org/show_bug.cgi?id=109492

Reviewed by Mark Hahnenberg.

Removed isNonStringCellSpeculation, and made all callers use isObjectSpeculation.

Changed isNonStringCellOrOtherSpeculation to be isObjectOrOtherSpeculation.

I believe this is correct because even weird object types like JSNotAnObject end up
being "objects" from the standpoint of our typesystem. Anyway, the assumption that
"is cell but not a string" equates to "object" is an assumption that is already made
in other places in the system so there's little value in being paranoid about it.

  • bytecode/SpeculatedType.h:

(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::shouldSpeculateObjectOrOther):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

3:28 PM Changeset in webkit [142529] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

RenderText::isAllCollapsibleWhitespace() shouldn't upconvert string to 16-bit.
<http://webkit.org/b/109354>

Reviewed by Eric Seidel.

254 KB progression on Membuster3.

  • rendering/RenderText.cpp:

(WebCore::RenderText::isAllCollapsibleWhitespace):

3:21 PM Changeset in webkit [142528] by hclam@chromium.org
  • 4 edits in trunk/Source/WebCore

Fix code style violations in GIFImageReader.{cc|h}
https://bugs.webkit.org/show_bug.cgi?id=109007

Reviewed by Stephen White.

This is just a style clean up for GIFImageReader.{cc|h}.

There's going to be a lot changes in these two files and style check
will add a lot of noise in later reviews. Fix style problems first.

There is no change in logic at all. Just style fixes.

No new tests.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::outputRow):
(GIFImageReader::doLZW):
(GIFImageReader::read):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader):
(GIFImageReader::imagesCount):
(GIFImageReader::loopCount):
(GIFImageReader::globalColormap):
(GIFImageReader::globalColormapSize):
(GIFImageReader::frameContext):

3:17 PM Changeset in webkit [142527] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

[CSS Exclusions] Handle shape-outside changing a float's overhang behavior
https://bugs.webkit.org/show_bug.cgi?id=106927

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-02-11
Reviewed by Julien Chaffraix.

Source/WebCore:

When the position on a shape outside causes a float to spill out into
another block than it's container, it was not being drawn correctly. It
became apparent that in order to fix this properly, the approach to
positioning shape outsides and floats needed to be changed. The new
approach also fixes some other outstanding issues, like hit detection.

When a float has a shape outside, inline and float layout happens
using the exclusion shape bounds instead of the float's box. The
effect of this is that the float itself no longer has any effect on
layout, both with respect to positioning of the float's siblings as
well as positioning the float's box. This means that when the float is
positioned, it is the shape's box that must obey the positioning rules
for floats. When the shape is given a position relative to the float's
box, the rules for float positioning determine where the shape sits
in the parent, causing the float's box to be offset by the position of
the shape. Since the float's box does not affect layout (due to the
shape), this is similar to relative positioning in that the offset is
a paint time occurrence.

So the new approach is to implement positioning of shape outside on
floats similar to how relative positioning is implemented, using a
RenderLayer.

This is also tested by the existing tests for shape outside on floats positioning.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html

  • rendering/ExclusionShapeOutsideInfo.h:

(WebCore::ExclusionShapeOutsideInfo::shapeLogicalOffset): Utility method to create a LayoutSize for computing the layer offset.
(ExclusionShapeOutsideInfo):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState): Check for floats with shape outside as well as in flow positioning.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::flipFloatForWritingModeForChild): Remove old positioning implementation.
(WebCore::RenderBlock::paintFloats): Remove old positioning implementation.
(WebCore::RenderBlock::blockSelectionGaps): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBlock::positionNewFloats): Remove old positioning implementation.
(WebCore::RenderBlock::addOverhangingFloats): Remove FIXME.
(WebCore::positionForPointRespectingEditingBoundaries): Check for floats with shape outside as well as in flow positioning.

  • rendering/RenderBlock.h:

(RenderBlock): Remove old positioning implementation.
(WebCore::RenderBlock::xPositionForFloatIncludingMargin): Remove old positioning implementation.
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Remove old positioning implementation.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::offsetFromContainer): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::computeRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Check for floats with shape outside as well as in flow positioning.

  • rendering/RenderBox.h: Make floats with shape outside get a layer.
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintOffset): Method to return in flow

positioning offset + offset from shape outside on floats.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject): Add paintOffset method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderInline::computeRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderInline::mapLocalToContainer): Check for floats with shape outside as well as in flow positioning.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderLayer::calculateClipRects): Check for floats with shape outside as well as in flow positioning.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::paintOffset): Rename offsetForInFlowPosition to reflect that it's not just for

in flow positioning, it also reflects shape outside position on floats.

(RenderLayer):

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasPaintOffset): Determines if this object is in flow positioined or is a float with shape outside.

  • rendering/style/RenderStyle.h: Add hasPaintOffset method, analagous to method with same name on RenderObject.

LayoutTests:

This is also tested by the existing tests for shape outside on floats positioning.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-overhang-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html: Added.
3:13 PM Changeset in webkit [142526] by timothy_horton@apple.com
  • 7 edits
    2 adds in trunk

FrameView::setScrollPosition should clamp scroll position before handing it to
ScrollingCoordinator instead of depending on ScrollView to do this
https://bugs.webkit.org/show_bug.cgi?id=109497
<rdar://problem/12631789>

Reviewed by Simon Fraser.

Clamp scroll position before handing it to ScrollingCoordinator. Also, like ScrollView does,
bail out if we've already scrolled to the clamped scroll position.

Test: platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):

Adjust some test results which previously expected out-of-bounds scrolling to happen.

Add a test that ensures that out-of-bounds scrolling doesn't happen.

  • platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html: Added.
  • platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
  • platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
3:11 PM Changeset in webkit [142525] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

The threaded HTML parser should pass all the fast/parser tests
https://bugs.webkit.org/show_bug.cgi?id=109486

Reviewed by Tony Gentilcore.

Source/WebCore:

This patch fixes the last two test failures in fast/parser, which were
crashes caused by not having a tokenizer when document.close() was
called. (The tokenizer is created lazily by calls to document.write,
which might not happen before document.close).

fast/parser/document-close-iframe-load.html
fast/parser/document-close-nested-iframe-load.html

In addition, I've added a new test to make sure we flush the tokenizer
properly in these cases.

Test: fast/parser/document-close-iframe-load-partial-entity.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):

LayoutTests:

  • fast/parser/document-close-iframe-load-partial-entity-expected.txt: Added.
  • fast/parser/document-close-iframe-load-partial-entity.html: Added.
3:07 PM Changeset in webkit [142524] by Bruno de Oliveira Abinader
  • 3 edits in trunk/Source/WebCore

[texmap] Implement frames-per-second debug counter
https://bugs.webkit.org/show_bug.cgi?id=107942

Reviewed by Noam Rosenthal.

Adds FPS counter via WEBKIT_SHOW_FPS=<interval> environment variable,
where <interval> is the period in seconds (i.e. =1.5) between FPS
updates on screen. It is measured by counting
CoordinatedGraphicsScene::paintTo* calls and is painted using
drawRepaintCounter() after TextureMapperLayer has finished painting its
contents.

Visual debugging feature, no need for new tests.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
(WebCore::CoordinatedGraphicsScene::updateFPS):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
3:00 PM Changeset in webkit [142523] by jchaffraix@webkit.org
  • 6 edits in trunk/LayoutTests

Unreviewed Chromium rebaselining after r142500.

  • platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
  • platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
  • platform/chromium-mac/fast/repaint/selection-after-remove-expected.png:
  • platform/chromium-win/fast/repaint/selection-after-remove-expected.png:

Slight painting regression that brings us back to pre-r132591 baselines.

3:00 PM Changeset in webkit [142522] by eric@webkit.org
  • 11 edits
    1 delete in trunk/Source/WebCore

Fold MarkupTokenBase into HTMLToken now that it has no other subclasses
https://bugs.webkit.org/show_bug.cgi?id=109483

Reviewed by Adam Barth.

This deletes an epic amount of template yuck, as well as removes
a vtable !?! from HTMLToken.

This paves the way for further cleanup of HTMLToken now that we
can see the whole object at once.
We'll also probably re-create an HTMLToken.cpp again, now that we're
free from the chains of template nonsense.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLToken.h:

(WebCore::findAttributeInVector):
(WebCore):
(HTMLToken):
(Attribute):
(Range):
(WebCore::HTMLToken::HTMLToken):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::setBaseOffset):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::isAll8BitData):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):

  • html/parser/HTMLTokenTypes.h:
  • html/parser/XSSAuditor.h:
  • xml/parser/MarkupTokenBase.h: Removed.
2:58 PM Changeset in webkit [142521] by barraclough@apple.com
  • 7 edits in trunk/Source

PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>

Reviewed by Brady Eidson.

Source/WebCore:

This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::MemoryPressureHandler):

  • Initialize m_lowMemoryHandler to releaseMemory.

(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOff):

  • Cleaned up spacing.

(WebCore::MemoryPressureHandler::releaseMemory):

  • Added null implementation for non-Mac builds.
  • platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::setLowMemoryHandler):

  • Added method to set m_lowMemoryHandler.
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

  • Changed to call releaseMemory via m_lowMemoryHandler.

Source/WebKit2:

PluginProcess now installs a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::lowMemoryHandler):

  • Custom callback to terminate if appropriate.

(WebKit::PluginProcess::initializeProcess):

  • Install the MemoryPressureHandler.

(WebKit::PluginProcess::shouldTerminate):

  • This method now also needs to be callable in situations where it might return false.
  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • Added declaration for lowMemoryHandler.
2:57 PM Changeset in webkit [142520] by Simon Fraser
  • 13 edits in trunk/Source/WebCore

REGRESSION (r133807): Sticky-position review bar on bugzilla review page is jumpy
https://bugs.webkit.org/show_bug.cgi?id=104276
<rdar://problem/12827187>

Reviewed by Tim Horton.

When committing new scrolling tree state, if the root node has a scroll
position update, we would handle that before updating the state of child
nodes (with possibly new viewport constraints). That would cause incorrect
child layer updates.

Fix by adding a second 'update' phase that happens after child nodes,
and moving the scroll position update into that.

Scrolling tests only dump the state tree, so cannot test the bug.

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition): If the scroll position didn't
actually change, don't request a scroll position update from the ScrollingCoordinator.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode): Keep track of the scrolling node so
that we can call updateAfterChildren() on it.

  • page/scrolling/ScrollingTreeNode.h:

(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::updateAfterChildren):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.h:

(ScrollingTreeScrollingNode):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
In the current bug the scrolling tree was scheduled for commit because of a
scroll position request, but if only the viewport constraints change, we also need
to commit the tree.

  • page/scrolling/mac/ScrollingTreeFixedNode.h:

(ScrollingTreeFixedNode):

  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateBeforeChildren):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:

(ScrollingTreeScrollingNodeMac):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::updateAfterChildren): Move code here
that updates things that have to happen after children.

  • page/scrolling/mac/ScrollingTreeStickyNode.h:

(ScrollingTreeStickyNode):

  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateBeforeChildren):

2:47 PM Changeset in webkit [142519] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Build fix for Windows after r142509

  • WebKit.vcproj/WebKitExports.def.in:
2:40 PM Changeset in webkit [142518] by andersca@apple.com
  • 9 edits
    1 add in trunk/Source/WebKit2

Move the PluginProcessCrashed message to PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=109493

Reviewed by Andreas Kling.

This is in preparation for making PluginProcessConnectionManager a connection queue client.

  • DerivedSources.make:
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didClose):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/Plugins/PluginProcessConnectionManager.messages.in: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
(WebKit::WebProcess::webResourceLoadScheduler):

  • WebProcess/WebProcess.h:

(WebProcess):

  • WebProcess/WebProcess.messages.in:
2:33 PM Changeset in webkit [142517] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix for Win7 Release.
Because of InspectorAllInOne.cpp static globals must be named differently in files included by InspectorAllInOne.
This was the case for UserInitiatedProfileName. Also removed the repeated HeapProfileType definition in
InspectorHeapProfilerAgent.cpp since it wasn't being used anyways.

  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):

2:24 PM Changeset in webkit [142516] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181770.

  • DEPS:
2:23 PM Changeset in webkit [142515] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

DFG CompareEq(a, null) and CompareStrictEq(a, const) are unsound with respect to constant folding
https://bugs.webkit.org/show_bug.cgi?id=109387

Reviewed by Oliver Hunt and Mark Hahnenberg.

Lock in the decision to use a non-speculative constant comparison as early as possible
and don't let the CFA change it by folding constants. This might be a performance
penalty on some really weird code (FWIW, I haven't seen this on benchmarks), but on
the other hand it completely side-steps the unsoundness that the bug speaks of.

Rolling back in after adding 32-bit path.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::isConstantForCompareStrictEq):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:22 PM Changeset in webkit [142514] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

SegmentedString's copy ctor should copy all fields
https://bugs.webkit.org/show_bug.cgi?id=109477

Reviewed by Adam Barth.

This fixes http/tests/inspector-enabled/document-write.html (and likely others) for the threaded HTML parser.

No new tests because covered by existing tests.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):

2:13 PM Changeset in webkit [142513] by jsbell@chromium.org
  • 8 edits
    3 adds in trunk

IndexedDB: database connections don't close after versionchange transaction aborts
https://bugs.webkit.org/show_bug.cgi?id=102298

Reviewed by Tony Chang.

Source/WebCore:

Per spec, close the database if the "versionchange" transaction aborts.

Tests: storage/indexeddb/aborted-versionchange-closes.html

storage/indexeddb/lazy-index-population.html
storage/objectstore-basics.html

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort): Tell the IDBDatabase (connection) to close if
this was a "versionchange" transaction.

LayoutTests:

Added dedicated test, updated tests dependent on buggy behavior.

  • storage/indexeddb/aborted-versionchange-closes-expected.txt: Added.
  • storage/indexeddb/aborted-versionchange-closes.html: Added.
  • storage/indexeddb/lazy-index-population-expected.txt:
  • storage/indexeddb/lazy-index-population.html: Remove manual closing.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/resources/aborted-versionchange-closes.js: Added.
  • storage/indexeddb/resources/objectstore-basics.js: Removed dependency on bug.
1:59 PM Changeset in webkit [142512] by Christophe Dumez
  • 7 edits in trunk

[EFL] fast/forms/number/number-l10n-input.html is failing
https://bugs.webkit.org/show_bug.cgi?id=109440

Reviewed by Laszlo Gombos.

Source/WebCore:

Use LocaleICU instead of LocaleNone on EFL port. The EFL
port already depends on ICU library and we get additional
functionality this way.

No new tests, already covered by existing tests.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:

LayoutTests:

Unskip fast/forms/number/number-l10n-input.html on EFL port
now that it passes.

  • platform/efl/TestExpectations:
1:48 PM Changeset in webkit [142511] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit

Rename Visual Studio solution folders to avoid conflicts with project names
https://bugs.webkit.org/show_bug.cgi?id=109484

Reviewed by Tim Horton.

  • WebKit.vcxproj/WebKit.sln: Rename several solution folders (e.g.,

WTF, WebCore, WebKit, JavaScriptCore) so that they do not conflict
with projects using the same name.

1:48 PM Changeset in webkit [142510] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Remove failure expectation now that this test is passing.

  • platform/chromium/TestExpectations:
1:41 PM Changeset in webkit [142509] by benjamin@webkit.org
  • 51 edits in trunk

Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=109349

Reviewed by Sam Weinig.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Expose setMinimumTimerInterval() and implement the backup/restore to keep
a consistent state between tests.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setMinimumTimerInterval):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Get rid of TestRunner's setMinimumTimerInterval and all the related functions.

This also fixes an oddity:
TestRunners were initialized with a minimum timer interval of 10 milliseconds instead
of using the default value. All with the same copy of an outdated comment.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests to use InternalSettings.

  • fast/dom/timer-increase-min-interval-and-reset-part-1.html:
  • fast/dom/timer-increase-min-interval-repeating.html:
  • fast/dom/timer-increase-min-interval.html:
  • fast/dom/timer-increase-then-decrease-min-interval-repeating.html:
  • fast/dom/timer-increase-then-decrease-min-interval.html:
1:39 PM Changeset in webkit [142508] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG TypeOf implementation should have its backend code aligned to what the CFA does
https://bugs.webkit.org/show_bug.cgi?id=109385

Reviewed by Sam Weinig.

The problem was that if we ended up trying to constant fold, but didn't succeed
because of prediction mismatches, then we would also fail to do filtration.

Rearranged the control flow in the CFA to fix that.

As far as I know, this is asymptomatic - it's sort of OK for the CFA to prove less
things, which is what the bug was.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

1:34 PM Changeset in webkit [142507] by dino@apple.com
  • 24 edits in trunk

Source/WebCore: Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Take three - relanding after rollout in r142400 that was caused by a global
selector interfering with CSS Instrumentation in the Inspector.

A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.

The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.

In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.

Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.

  • css/plugIns.css:

(object::-webkit-snapshotted-plugin-content): New rules for a default label style.

  • platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
  • platform/LocalizedStrings.h:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:
  • platform/chromium/LocalizedStringsChromium.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/qt/LocalizedStringsQt.cpp:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such

a renderer, otherwise use the typical plug-in path.

(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll

need to give it to the renderer.

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label

should show immediately.

(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need

to swap to the Shadow Root.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin

in being recreated. Make sure we reattach so that a plugin renderer will be created.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right

displayState for snapshots.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not

a snapshot should be immediately labeled.

  • page/ChromeClient.h: No need for plugInStartLabelImage any more.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.

  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn): New inheritance. Some method renaming.

Source/WebKit2: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Take three of this commit - after rollout in r142400 and r142405.
We no longer have any need for plugInStartLabelImage.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
  • WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.

Tools: Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273

Reviewed by Simon Fraser.

Take two - after rollout in r142405.
Removed plugInStartLabelImage entry from client structure.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

1:29 PM Changeset in webkit [142506] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

CSP reports for blocked 'data:' URLs should report the scheme only.
https://bugs.webkit.org/show_bug.cgi?id=109429

Reviewed by Adam Barth.

Source/WebCore:

https://dvcs.w3.org/hg/content-security-policy/rev/001dc8e8bcc3 changed
the CSP 1.1 spec to require that blocked URLs that don't refer to
generally resolvable schemes (e.g. 'data:', 'javascript:', etc.) be
stripped down to their scheme in violation reports.

Test: http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

If the blocked URL is a web-resolvable scheme, apply the current
stripping logic to it, otherwise, strip it to the scheme only.

  • platform/KURL.h:

(KURL):

Move KURL::isHierarchical() out into KURL's public API.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html: Added.
1:28 PM Changeset in webkit [142505] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

ScrollingTree node maps keep getting larger
https://bugs.webkit.org/show_bug.cgi?id=109348

Reviewed by Sam Weinig.

When navigating between pages, nodes would get left in the ScrollingTree's
node map, and the ScrollingStateTree's node map, so these would get larger
and larger as you browse.

Simplify map maintenance by clearing the map when setting a new root node
(which happens on the first commit of a new page). Also, don't keep root nodes
around, but create them afresh for each page, which simplifies their ID
management.

This is closer to the original behavior; keeping the root nodes around was
a fix for bug 99668, but we avoid regressing that fix by bailing early
from frameViewLayoutUpdated() if there is no root state node (we'll get
called again anyway).

This now allows state nodeIDs to be purely read-only.

  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNode):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):

1:28 PM Changeset in webkit [142504] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Move m_stateNodeMap from ScrollingCoordinatorMac to ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=109361

Reviewed by Sam Weinig.

The map of scrolling node IDs to ScollingStateNodes was maintained by
ScrollingCoordinatorMac, rather than ScrollingStateTree. This is different
from the ScrollingTree (which owns its node map), and added some amount
of to-and-fro between ScrollingStateTree and ScrollingCoordinatorMac.

Having ScrollingCoordinatorMac maintain the map of IDs to state nodes
simplifies things.

No behavior change.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNode):
(WebCore::ScrollingStateTree::stateNodeForID):

  • page/scrolling/ScrollingStateTree.h:

(ScrollingStateTree): Remove some stale comments.
(WebCore::ScrollingStateTree::removedNodes):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::recomputeWheelEventHandlerCountForFrameView):
(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinatorMac::attachToStateTree):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):
(WebCore::ScrollingCoordinatorMac::updateScrollingNode):
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

1:26 PM Changeset in webkit [142503] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/mac/PlatformSpeechSynthesizerMac.mm: Fix the case in the include.
1:26 PM Changeset in webkit [142502] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

The plug-in process connection manager doesn't need to be heap allocated
https://bugs.webkit.org/show_bug.cgi?id=109479

Reviewed by Andreas Kling.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::pluginProcessCrashed):

  • WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

1:24 PM Changeset in webkit [142501] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181742. Requested by
fmalita_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

  • DEPS:
1:11 PM Changeset in webkit [142500] by jchaffraix@webkit.org
  • 7 edits
    2 adds in trunk

Regression(r131539): Heap-use-after-free in WebCore::RenderBlock::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=107189

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/dynamic/continuation-detach-crash.html

This patch reverts r131539 and the following changes (r132591 and r139664).
This means we redo detaching from the bottom-up which solves the regression.
It fixes the attached test case as we re-attach child nodes before detaching
the parent. It seems wrong to do but this avoid a stale continuation.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::detach): Detach the children first, then ourself.

  • dom/Node.cpp:

(WebCore::Node::detach): Clear the renderer instead of ASSERT'ing.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed): Removed the code to clear the associated node's renderer.
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
Moved the repainting logic back into removeChildNode from destroyAndCleanupAnonymousWrappers.
(WebCore::RenderObjectChildList::destroyLeftoverChildren): Re-added the code to clear the associated node's
renderer.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setText): Re-added the code to set the associated node's renderer.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::detach):

  • dom/Node.cpp:

(WebCore::Node::detach):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::destroyLeftoverChildren):
(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setText):

LayoutTests:

  • fast/dynamic/continuation-detach-crash-expected.txt: Added.
  • fast/dynamic/continuation-detach-crash.html: Added.
1:04 PM Changeset in webkit [142499] by tony@chromium.org
  • 47 edits
    2 adds in trunk

Move setFrameFlatteningEnabled from layoutTestController to window.internals.settings
https://bugs.webkit.org/show_bug.cgi?id=87149

Reviewed by Simon Fraser.

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Add setFrameFlatteningEnabled to the list of overridable values.

Tools:

Remove testRunner.setFrameFlatteningEnabled from DRT and WTR. WebKit API
methods are left because there may be users of it. Add a test for Apple Mac
to ensure that the API for the preference still works using overridePreference.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update tests to use internal.settings.setFrameFlatteningEnabled, which is automatically
generated from Settings.in.
Add a Mac only test that uses overridePreference to test the API.

  • fast/frames/flattening/crash-svg-document.html:
  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-crash.html:
  • fast/frames/flattening/iframe-flattening-fixed-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width.html:
  • fast/frames/flattening/iframe-flattening-nested.html:
  • fast/frames/flattening/iframe-flattening-offscreen.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
  • fast/frames/flattening/iframe-flattening-out-of-view.html:
  • fast/frames/flattening/iframe-flattening-selection-crash.html:
  • fast/frames/flattening/iframe-flattening-simple.html:
  • fast/frames/flattening/iframe-tiny.html:
  • fast/spatial-navigation/snav-iframe-flattening-simple.html:
  • fast/text-autosizing/narrow-iframe-flattened.html:
  • http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html:
  • platform/chromium/TestExpectations: Chromium doesn't use frame flattening on mobile either.
  • plugins/frameset-with-plugin-frame.html:
  • fast/frames/flattening/crash-svg-document.html:
  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-crash.html:
  • fast/frames/flattening/iframe-flattening-fixed-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width.html:
  • fast/frames/flattening/iframe-flattening-nested.html:
  • fast/frames/flattening/iframe-flattening-offscreen.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
  • fast/frames/flattening/iframe-flattening-out-of-view.html:
  • fast/frames/flattening/iframe-flattening-selection-crash.html:
  • fast/frames/flattening/iframe-flattening-simple.html:
  • fast/frames/flattening/iframe-tiny.html:
  • fast/spatial-navigation/snav-iframe-flattening-simple.html:
  • fast/text-autosizing/narrow-iframe-flattened.html:
  • http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html:
  • platform/chromium/TestExpectations:
  • platform/mac/fast/frames/flattening/set-preference-expected.txt: Added.
  • platform/mac/fast/frames/flattening/set-preference.html: Added.
  • plugins/frameset-with-plugin-frame.html:
12:43 PM Changeset in webkit [142498] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r142491.
http://trac.webkit.org/changeset/142491
https://bugs.webkit.org/show_bug.cgi?id=109470

broke the 32 bit build (Requested by jessieberlin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:41 PM Changeset in webkit [142497] by eric@webkit.org
  • 14 edits
    1 add in trunk/Source/WebCore

Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase
https://bugs.webkit.org/show_bug.cgi?id=109411

Reviewed by Adam Barth.

Moved InputStreamPreprocessor into its own header file so it can be
used by both WebVTTTokenizer and HTMLTokenizer.

Also split out kEndOfFileMarker from InputStreamPreprocessor<T> so that
it can be used w/o a specific instantiation of the template class.
This also made it possible to fix three old fixmes about wanting to share
that constant.

Again, separating WebVTT code from Markup* base classes made it simpler
at the cost of a little copy/paste code. WebVTT tokenization is remarkably
simple compared to HTML.

This will make it immediately possible to pull MarkupTokenizerBase up into
HTMLTokenizer and further simplify the code.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::markEndOfFile):

  • html/parser/HTMLInputStream.h:

(WebCore::HTMLInputStream::markEndOfFile):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

  • html/parser/InputStreamPreprocessor.h: Added.

(WebCore):
(InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::nextInputCharacter):
(WebCore::InputStreamPreprocessor::peek):
(WebCore::InputStreamPreprocessor::advance):
(WebCore::InputStreamPreprocessor::skipNextNewLine):
(WebCore::InputStreamPreprocessor::reset):
(WebCore::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):

  • html/track/WebVTTTokenizer.cpp:

(WebCore::WebVTTTokenizer::WebVTTTokenizer):
(WebCore::WebVTTTokenizer::nextToken):

  • html/track/WebVTTTokenizer.h:

(WebVTTTokenizer):
(WebCore::WebVTTTokenizer::haveBufferedCharacterToken):
(WebCore::WebVTTTokenizer::bufferCharacter):
(WebCore::WebVTTTokenizer::emitAndResumeIn):
(WebCore::WebVTTTokenizer::emitEndOfFile):
(WebCore::WebVTTTokenizer::shouldSkipNullCharacters):

  • xml/parser/MarkupTokenizerBase.h:

(MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::bufferCharacter):

12:37 PM Changeset in webkit [142496] by fmalita@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380

Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).

Reviewed by James Robinson.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):

12:36 PM Changeset in webkit [142495] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows 7 Debug mode build fix.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
12:23 PM Changeset in webkit [142494] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
https://bugs.webkit.org/show_bug.cgi?id=108513

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-11
Reviewed by Tony Chang.

WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
to avoid introducing spaces around misspellings.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.

  • tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
11:53 AM Changeset in webkit [142493] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions
https://bugs.webkit.org/show_bug.cgi?id=108459

Patch by Claudio Saavedra <Claudio Saavedra> on 2013-02-11
Reviewed by Alexey Proskuryakov.

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
Providers might return 0 and we will end up with a null-pointer dereference.
Early check against this.

11:48 AM Changeset in webkit [142492] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

document.write during window.onload can trigger DumpRenderTree to dump the render tree
https://bugs.webkit.org/show_bug.cgi?id=109465

Reviewed by Eric Seidel.

Source/WebCore:

This patch is a partial revert of
http://trac.webkit.org/changeset/142378. It's not safe to call
checkComplete during the load event. We'll need to find another way of
calling checkComplete at the right time.

Test: fast/parser/document-write-during-load.html

  • dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

LayoutTests:

  • fast/parser/document-write-during-load-expected.txt: Added.
  • fast/parser/document-write-during-load.html: Added.
11:21 AM Changeset in webkit [142491] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG CompareEq(a, null) and CompareStrictEq(a, const) are unsound with respect to constant folding
https://bugs.webkit.org/show_bug.cgi?id=109387

Reviewed by Oliver Hunt.

Lock in the decision to use a non-speculative constant comparison as early as possible
and don't let the CFA change it by folding constants. This might be a performance
penalty on some really weird code (FWIW, I haven't seen this on benchmarks), but on
the other hand it completely side-steps the unsoundness that the bug speaks of.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::isConstantForCompareStrictEq):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:13 AM Changeset in webkit [142490] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/flexbox/line-clamp-link-after-ellipsis.html as failing
on EFL port. This test was introduced in r142335.

  • platform/efl/TestExpectations:
10:16 AM Changeset in webkit [142489] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed fix after r13954 for !ENABLE(JIT) builds.

  • llint/LowLevelInterpreter.cpp:
10:15 AM Changeset in webkit [142488] by caseq@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Timeline: invalidate and force locations are same for Layout records caused by style recalculaiton
https://bugs.webkit.org/show_bug.cgi?id=109294

Reviewed by Pavel Feldman.

Source/WebCore:

Use the stack that caused style recalculation as a cause for relayout performed due to
layout invalidation caused by style recalculation.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.Record):

LayoutTests:

  • inspector/timeline/timeline-layout-reason-expected.txt: Added.
  • inspector/timeline/timeline-layout-reason.html: Added.
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline): Extracted "performActions" step from performActionsAndPrint()
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):

10:11 AM Changeset in webkit [142487] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] Set mouse document position for mouse event in DRT.
https://bugs.webkit.org/show_bug.cgi?id=109094.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-11
Reviewed by Rob Buis.

RIM PR 246976.
Internally Reviewed by Nima Ghanavatian & Genevieve Mak.

Set mouse document position when we create mouse event in DRT.

  • DumpRenderTree/blackberry/EventSender.cpp:

(setMouseEventDocumentPos):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):

10:05 AM Changeset in webkit [142486] by caseq@chromium.org
  • 7 edits in trunk

Web Inspector: [Extension API] adjust inspectedWindow.eval() callback parameters to expose non-exceptional error
https://bugs.webkit.org/show_bug.cgi?id=108640

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • only set first parameter to eval() callback iff expression successfully evaluates;
  • use object, not bool as second parameter;
  • pass exceptions and extension errors as second parameter if evaluate failed;
  • minor drive-by changes in ExtensionAPI utilities.
  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.InspectedWindow.prototype.):
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionStatus):

LayoutTests:

Rebase tests following change in exception parameter to inspectedWindow.eval() callback.

  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/extensions/extensions-eval.html:
  • inspector/extensions/extensions-sidebar-expected.txt:
10:01 AM Changeset in webkit [142485] by caseq@chromium.org
  • 6 edits in trunk

Web Inspector: [Extensions API] expose ExtensionServerClient to tests so tests use same port as extensions API
https://bugs.webkit.org/show_bug.cgi?id=109443

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Promote extensionServer var to the outer closure, so it may be accessed by platform-specific (or test) code.

  • inspector/front-end/ExtensionAPI.js:

(buildExtensionAPIInjectedScript):

LayoutTests:

  • replace additional message ports used for evaluating code in front-end with normal extension transport.
  • http/tests/inspector/extensions-test.js:

(initialize_ExtensionsTest.window.buildPlatformExtensionAPI):
(initialize_ExtensionsTest.InspectorTest._replyToExtension):
(initialize_ExtensionsTest.onEvaluate):

  • http/tests/inspector/resources/extension-main.js:
  • inspector/extensions/extensions-audits.html:
9:54 AM Changeset in webkit [142484] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Move WebVTTToken off of MarkupTokenBase
https://bugs.webkit.org/show_bug.cgi?id=109410

Reviewed by Tony Gentilcore.

This introduces a small amount of "copy/paste" code
but actually makes WebVTTToken much smaller and simpler!
This also frees the HTMLParser to have its Token class
back to itself so we can tune it to make HTML faster.

  • html/track/WebVTTToken.h:

(WebVTTToken):
(WebCore::WebVTTToken::WebVTTToken):
(WebCore::WebVTTToken::appendToName):
(WebCore::WebVTTToken::type):
(WebCore::WebVTTToken::name):
(WebCore::WebVTTToken::ensureIsCharacterToken):
(WebCore::WebVTTToken::appendToCharacter):
(WebCore::WebVTTToken::beginEmptyStartTag):
(WebCore::WebVTTToken::beginStartTag):
(WebCore::WebVTTToken::beginEndTag):
(WebCore::WebVTTToken::beginTimestampTag):
(WebCore::WebVTTToken::makeEndOfFile):
(WebCore::WebVTTToken::clear):

9:28 AM Changeset in webkit [142483] by jsbell@chromium.org
  • 6 edits
    3 adds in trunk

[V8] IndexedDB: Minor GC can collect IDBDatabase wrapper with versionchange handler
https://bugs.webkit.org/show_bug.cgi?id=108670

Reviewed by Kentaro Hara.

Source/WebCore:

Prevent IDBDatabase's wrapper from being GC'd while the database is open if it has
listeners, as those listeners may close the database in response to events.

Also, removed extraneous super-calls from hasPendingActivity() overrides.

Test: storage/indexeddb/database-wrapper.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity): Implemented.

  • Modules/indexeddb/IDBDatabase.h: Declared.
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::hasPendingActivity): Simplified.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::hasPendingActivity): Simplified.

LayoutTests:

  • storage/indexeddb/database-wrapper-expected.txt: Added.
  • storage/indexeddb/database-wrapper.html: Added.
  • storage/indexeddb/resources/database-wrapper.js: Added.

(test):
(openDB):
(onUpgradeNeeded):
(openSuccess.get request.onsuccess):
(onVersionChange):
(collectGarbage):
(openAgain):
(onBlocked):
(openAgainSuccess):

9:17 AM Changeset in webkit [142482] by mifenton@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add form navigation control state tracking.
https://bugs.webkit.org/show_bug.cgi?id=109300

Reviewed by Rob Buis.

Add form navigation control state tracking.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::focusNextField):
(WebKit):
(BlackBerry::WebKit::WebPage::focusPreviousField):
(BlackBerry::WebKit::WebPage::submitForm):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::updateFormState):

  • WebKitSupport/InputHandler.h:

(InputHandler):

9:01 AM Changeset in webkit [142481] by rgabor@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

JSC build failing with verbose debug mode
https://bugs.webkit.org/show_bug.cgi?id=109441

Reviewed by Darin Adler.

Fixing some verbose messages which caused build errors.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

8:52 AM Changeset in webkit [142480] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove AttributeBase now that NEW_XML is gone
https://bugs.webkit.org/show_bug.cgi?id=109408

Reviewed by Adam Barth.

Just deleting code. HTMLToken::Attribute is now just
the real class and not a typedef.

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::nameForAttribute):

  • xml/parser/MarkupTokenBase.h:

(WebCore):
(MarkupTokenBase):
(Attribute):
(Range):

8:24 AM Changeset in webkit [142479] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] Add graphics subdirectory to include path.
https://bugs.webkit.org/show_bug.cgi?id=109437

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2013-02-11
Reviewed by Rob Buis.

Add browser/platform/graphics to include path.

Internal review by Jeff Rogers.

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

8:19 AM Changeset in webkit [142478] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip fast/forms/number/number-l10n-input.html that was added in r142122
but fails on EFL port.

  • platform/efl/TestExpectations:
8:06 AM Changeset in webkit [142477] by Christophe Dumez
  • 2 edits in trunk/Tools

[EFL][WKTR] Regression(r141836) fast/dom/Window/mozilla-focus-blur.html started failing
https://bugs.webkit.org/show_bug.cgi?id=109438

Reviewed by Kenneth Rohde Christiansen.

Some refactoring in r141836 caused the view not to get focus if the focused
frame is not the main one. The idea of the code was to remove focus from the
view if the focused frame was not the main one, and then focus the view again.
However, after the refactoring, the second step never happened: Focus was
removed but not given again.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::focus):

8:00 AM Changeset in webkit [142476] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed revert test fix attempt and skip it.

  • inspector/editor/text-editor-home-button.html:
  • platform/chromium/TestExpectations:
7:58 AM Changeset in webkit [142475] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Rename PreloadTask to StartTagScanner to match its purpose
https://bugs.webkit.org/show_bug.cgi?id=109406

Reviewed by Sam Weinig.

As discussed in bug 107807.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::processToken):

7:50 AM Changeset in webkit [142474] by vsevik@chromium.org
  • 13 edits
    1 move in trunk

Web Inspector: WebInspector.Project refactorings.
https://bugs.webkit.org/show_bug.cgi?id=109433

Reviewed by Alexander Pavlov.

Source/WebCore:

This change prepares Workspace and Project to migration to project-per-domain mode for network based projects.
Renamed WebInspector.WorkspaceProvider to WebInspector.ProjectDelegate.
Renamed Project.name() to Project.id() and delegated it to project delegate.
Added Project.displayName() method that is delegated to project delegate.
SimpleWorkspaceProvider is now responsible for creation of SimpleWorkspaceDelegates and
isolates various mappings from Project/ProjectDelegate concept.
UISourceCode is now created based on path in the project.
UISourceCode uri is now calculated based on project and path (right now uri is equal to path).

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileSystemProjectDelegate.js: Renamed from Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js.

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.type):
(WebInspector.FileSystemProjectDelegate.prototype.displayName):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
(WebInspector.FileSystemProjectDelegate.prototype._addFile):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
(WebInspector.FileSystemProjectDelegate.prototype.reset):
(WebInspector.FileSystemUtils):
(WebInspector.FileSystemUtils.errorHandler):
(WebInspector.FileSystemUtils.requestFileSystem):
(.fileSystemLoaded):
(.innerCallback):
(WebInspector.FileSystemUtils.requestFilesRecursive):
(.fileEntryLoaded):
(.fileLoaded):
(.readerLoadEnd):
(WebInspector.FileSystemUtils.requestFileContent):
(.fileWriterCreated.fileTruncated):
(.fileWriterCreated):
(.writerEnd):
(WebInspector.FileSystemUtils.setFileContent):
(WebInspector.FileSystemUtils._getDirectory):
(.toArray):
(WebInspector.FileSystemUtils._readDirectory):
(WebInspector.FileSystemUtils._requestEntries):

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.setFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._uniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleProjectDelegate.prototype.reset):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.path):
(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/Workspace.js:

(WebInspector.FileDescriptor):
(WebInspector.ProjectDelegate):
(WebInspector.ProjectDelegate.prototype.id):
(WebInspector.ProjectDelegate.prototype.displayName):
(WebInspector.ProjectDelegate.prototype.requestFileContent):
(WebInspector.ProjectDelegate.prototype.setFileContent):
(WebInspector.ProjectDelegate.prototype.searchInFileContent):
(WebInspector.Project):
(WebInspector.Project.prototype.id):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.displayName):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Project.prototype.dispose):
(WebInspector.Workspace.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.removeProject):
(WebInspector.Workspace.prototype.project):
(WebInspector.Workspace.prototype.uiSourceCodes):
(WebInspector.Workspace.prototype.projectForUISourceCode):

  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/uisourcecode-revisions.html:
7:45 AM Changeset in webkit [142473] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in the profiler code
https://bugs.webkit.org/show_bug.cgi?id=109432

Reviewed by Pavel Feldman.

Updated type annotations to match the code.

  • inspector/front-end/NativeMemorySnapshotView.js:
  • inspector/front-end/ProfilesPanel.js:
7:44 AM Changeset in webkit [142472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[QT] Regression (r142444): Broke qt linux minimal build
https://bugs.webkit.org/show_bug.cgi?id=109423

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2013-02-11
Reviewed by Kenneth Rohde Christiansen.

Test: cssom/cssvalue-comparison.html

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):

7:40 AM Changeset in webkit [142471] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: introduce WebInspector.TextUtils
https://bugs.webkit.org/show_bug.cgi?id=109289

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Pavel Feldman.

Add new WebInspector.TextUtils file and extract commonly used
text-operation subroutines from DefaultTextEditor into it.

No new tests: no change in behaviour.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._isWord):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._rangeForCtrlArrowMove):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):

  • inspector/front-end/TextUtils.js: Added.

(WebInspector.TextUtils.isStopChar):
(WebInspector.TextUtils.isWordChar):
(WebInspector.TextUtils.isSpaceChar):
(WebInspector.TextUtils.isWord):
(WebInspector.TextUtils.isBraceChar):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
7:26 AM Changeset in webkit [142470] by Christophe Dumez
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

  • Rebaseline fast/dynamic/002.html on EFL port after r142015.
  • Skip several compositing test cases that started failing after r142112.
  • Skip several new Kronos WebGL conformance tests that are failing on EFL WK2.
  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/dynamic/002-expected.png:
  • platform/efl/fast/dynamic/002-expected.txt:
7:12 AM Changeset in webkit [142469] by Bruno de Oliveira Abinader
  • 2 edits in trunk/Websites/webkit.org

Add basysKom to domainAffiliations in team.html
https://bugs.webkit.org/show_bug.cgi?id=109306

Reviewed by Laszlo Gombos.

Register basysKom as contributing company in
http://www.webkit.org/team.html.

  • team.html:
7:09 AM Changeset in webkit [142468] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Websites/webkit.org

Add intel.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109424

Reviewed by Kenneth Rohde Christiansen.

  • team.html:
7:05 AM Changeset in webkit [142467] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Don't generate documentation if building neither WebKit1 nor WebKit2
https://bugs.webkit.org/show_bug.cgi?id=109420

Reviewed by Philippe Normand.

Don't generate the GTK documentation if neither of the WebKit1 and WebKit2
layers was built. This just results in unnecessary errors being spewed out
by the gtkdoc utilities.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

7:03 AM Changeset in webkit [142466] by zandobersek@gmail.com
  • 1 edit in trunk/Source/WebCore

Adding the svn:ignore property that the previous commit (done through webkit-patch) failed to.

6:59 AM Changeset in webkit [142465] by zandobersek@gmail.com
  • 1 edit in trunk/ChangeLog
  • Source/WebCore: Modified property svn:ignore, adding GNUmakefile.features.am

to the list of paths to be ignored.

6:47 AM Changeset in webkit [142464] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a failure expectation for the

cssom/cssvalue-comparison.html, the test was added in r142444 and is failing
due to CSS image-set functionality not yet enabled in the GTK port.

6:43 AM Changeset in webkit [142463] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK][Clang] Build errors in LocalizedStringsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=109418

Reviewed by Philippe Normand.

Use the C++ isfinite(float) and abs(float) (instead of fabsf(float))
methods by including the WTF MathExtras.h header. Use a static cast to
an integer type on the float return value of the abs(float) method call
instead of the C-style cast.

No new tests - no new functiolnality.

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaTimeDescription):

6:42 AM Changeset in webkit [142462] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for the WTFURL backend of KURL.

  • platform/KURL.cpp:

(WebCore::KURL::isSafeToSendToAnotherThread): m_urlImpl is of RefPtr type so use
the appropriate operator on it when calling the isSafeToSendToAnotherThread method.

5:55 AM Changeset in webkit [142461] by mkwst@chromium.org
  • 3 edits in trunk/Source/WebCore

Range::collapsed callers should explicitly ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=108921

Reviewed by Jochen Eisinger.

For clarity and consistency, this patch adjusts Range::collapsed() to
drop the default value of the ExceptionCode parameter it accepts. The
three call sites that called the method with no arguments (all part of
Editor::rangeOfString) will now explicitly ASSERT_NO_EXCEPTION.

  • dom/Range.h:

(Range):

  • editing/Editor.cpp:

(WebCore::Editor::rangeOfString):

5:54 AM Changeset in webkit [142460] by commit-queue@webkit.org
  • 32 edits
    2 adds in trunk

Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
https://bugs.webkit.org/show_bug.cgi?id=108653

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-11
Reviewed by Yury Semikhatsky.

Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
In fact these two profile types have not too much in common. So put each into its own domain.
It should also help when Profiles panel gets split into several tools.
This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
change the original InspectorProfilerAgent.

PerformanceTests:

  • inspector/heap-snapshot-performance-test.js:

(test.performanceTest.cleanup):

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorHeapProfilerAgent.cpp: Added.

(WebCore):
(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::~InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetState):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::setFrontend):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::collectGarbage):
(WebCore::InspectorHeapProfilerAgent::createSnapshotHeader):
(WebCore::InspectorHeapProfilerAgent::hasHeapProfiler):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::removeProfile):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::getHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::reportMemoryUsage):

  • inspector/InspectorHeapProfilerAgent.h: Added.

(WebCore):
(InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::clearProfiles):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InstrumentingAgents.h:

(WebCore):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorHeapProfilerAgent):
(WebCore::InstrumentingAgents::setInspectorHeapProfilerAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/HeapSnapshotDataGrids.js:
  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._clearProfiles):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._populateProfiles.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.revealInView):
(WebInspector.HeapProfilerDispatcher):
(WebInspector.HeapProfilerDispatcher.prototype.addProfileHeader):
(WebInspector.HeapProfilerDispatcher.prototype.addHeapSnapshotChunk):
(WebInspector.HeapProfilerDispatcher.prototype.finishHeapSnapshot):
(WebInspector.HeapProfilerDispatcher.prototype.resetProfiles):
(WebInspector.HeapProfilerDispatcher.prototype.reportHeapSnapshotProgress):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::shouldInterruptForMessage):

LayoutTests:

  • inspector-protocol/heap-profiler/resources/heap-snapshot-common.js:

(InspectorTest.takeHeapSnapshot.InspectorTest.eventHandler.string_appeared_here):
(InspectorTest.takeHeapSnapshot):

  • inspector-protocol/nmi-webaudio-leak-test.html:
  • inspector/profiler/heap-snapshot-get-profile-crash.html:
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

5:51 AM Changeset in webkit [142459] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions.
https://bugs.webkit.org/show_bug.cgi?id=109372

Reviewed by Jochen Eisinger.

Rather than implicitly ignoring exceptions, we should use the
IGNORE_EXCEPTION macro for clarity.

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):

5:12 AM Changeset in webkit [142458] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline EFL expectation for fast/js/global-constructors.html after
r142205.

  • platform/efl/fast/js/global-constructors-expected.txt:
4:55 AM Changeset in webkit [142457] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed. Fix minimal build after r142444.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-11

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):

4:47 AM Changeset in webkit [142456] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed r142439 follow-up: test fix.

  • inspector/editor/text-editor-home-button.html:
4:46 AM Changeset in webkit [142455] by Antoine Quint
  • 2 edits in trunk/Tools

Unreviewed change to add myself to the Inspector IDLs watchlist.

  • Scripts/webkitpy/common/config/watchlist:
4:44 AM Changeset in webkit [142454] by Christophe Dumez
  • 6 edits in trunk/Source

[EFL] Stop using smart pointers for Ecore_Timer
https://bugs.webkit.org/show_bug.cgi?id=109409

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Stop using a smart pointer for Ecore_Timer in RunLoop::TimerBase. This
is a bad idea because the timer handle becomes invalid as soon as the
timer callback returns ECORE_CALLBACK_CANCEL. This may lead to crashes
on destruction because OwnPtr calls ecore_timer_del() on an invalid
handle.

No new tests, already covered by exiting tests.

  • platform/RunLoop.h:

(TimerBase):

  • platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):

Source/WTF:

Remove support in OwnPtr for EFL's Ecore_Timer. It is a bad idea to use
OwnPtr for Ecore_Timer because the timer handle may become invalid.

  • wtf/OwnPtrCommon.h:

(WTF):

  • wtf/efl/OwnPtrEfl.cpp:
4:38 AM Changeset in webkit [142453] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 webgl/conformance test cases as crashing on EFL WK2.

  • platform/efl-wk2/TestExpectations:
4:15 AM Changeset in webkit [142452] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Allow SplitView to keep the sidebar size as a fraction of the container size
https://bugs.webkit.org/show_bug.cgi?id=109414

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

SplitView now interprets defaultSidebarWidth and defaultSidebarHeight values between 0 and 1 as
fractions of the total container size. The sidebar then will grow or shrink along with the container.
When the sidebar is resized manually the updated ratio is stored in the settings.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
(WebInspector.SplitView.prototype._updateTotalSize):
(WebInspector.SplitView.prototype._innerSetSidebarSize):
(WebInspector.SplitView.prototype._saveSidebarSize):

3:51 AM Changeset in webkit [142451] by commit-queue@webkit.org
  • 5 edits
    1 copy
    2 moves
    2 adds in trunk/Tools

[GTK][EFL] Shares WebKit-GTK's DumpRenderTree accessibility implementation with other Webkit ports
https://bugs.webkit.org/show_bug.cgi?id=105007

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-02-11
Reviewed by Martin Robinson.

Shares specific ATK's accessibility implementation.
Keeps platform specific methods in EFL and GTK's directories.

  • DumpRenderTree/atk/AccessibilityCallbacks.h: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.h.
  • DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp.

(printAccessibilityEvent):
(axObjectEventListener):
(connectAccessibilityCallbacks):
(disconnectAccessibilityCallbacks):

  • DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp.

(coreAttributeToAtkAttribute):
(roleToString):
(replaceCharactersForResults):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::indexOfChild):
(attributeSetToString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(checkElementState):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::indexInTable):
(indexRangeInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::numberAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(alterCurrentValue):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::press):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(AccessibilityUIElement::url):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

  • DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers, libraries, new sources.
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(AccessibilityController::accessibleElementById):

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::helpText):

  • GNUmakefile.am: Adds renamed sources.
3:49 AM Changeset in webkit [142450] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: highlight DOM nodes on hover while debugging
https://bugs.webkit.org/show_bug.cgi?id=109355

Reviewed by Vsevolod Vlasov.

Along with showing the popover, highlight the remote object as node.

  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

3:42 AM Changeset in webkit [142449] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked editing/spelling/spellcheck-async.html
as [ Pass Failure ].

  • platform/chromium/TestExpectations:
3:36 AM Changeset in webkit [142448] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Added [Timeout] to http/tests/misc/window-dot-stop.html.

  • platform/chromium/TestExpectations:
3:29 AM Changeset in webkit [142447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: displaying whitespace characters is broken
https://bugs.webkit.org/show_bug.cgi?id=109412

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Add "pointer-events: none" rule for pseudo-class "before", which
maintains rendering of whitespace characters.

No new tests.

  • inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-whitespace::before):

3:17 AM Changeset in webkit [142446] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adjusted expectations for two flaky crashers.
Removed failure expectations for tests that pass.

  • platform/gtk/TestExpectations:
3:05 AM Changeset in webkit [142445] by apavlov@chromium.org
  • 10 edits
    4 adds
    2 deletes in trunk

Web Inspector: Implement position-based sourcemapping for stylesheets
https://bugs.webkit.org/show_bug.cgi?id=109168

Source/WebCore:

Reviewed by Vsevolod Vlasov.

This change introduces support for position-based source maps for CSS stylesheets.
Sourcemaps and originating resources (sass, scss, etc.) are loaded synchronously
upon the CSS UISourceCode addition. RangeBasedSourceMap is removed as it is not used.

Test: http/tests/inspector/stylesheet-source-mapping.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSLocation):
(WebInspector.CSSProperty):
(WebInspector.CSSProperty.parsePayload):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(WebInspector.SASSSourceMapping.prototype._loadAndProcessSourceMap):
(WebInspector.SASSSourceMapping.prototype.loadSourceMapForStyleSheet):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.SASSSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.SASSSourceMapping.prototype._reset):

  • inspector/front-end/SourceMap.js:

(WebInspector.SourceMap):
(WebInspector.SourceMap.load):
(WebInspector.SourceMap.prototype.findEntry):
(WebInspector.SourceMap.prototype.findEntryReversed):
(WebInspector.SourceMap.prototype._parseMap):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._bindUISourceCode):

  • inspector/front-end/inspector.js:

LayoutTests:

Added test for the stylesheet source mappings, followed the API changes,
removed RangeBasedSourceMap tests as this type of sourcemap is gone.

Reviewed by Vsevolod Vlasov.

  • http/tests/inspector/compiler-script-mapping-expected.txt:
  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/resources/example.css.map: Added.
  • http/tests/inspector/resources/example.scss: Added.
  • http/tests/inspector/stylesheet-source-mapping-expected.txt: Added.
  • http/tests/inspector/stylesheet-source-mapping.html: Added.
  • inspector/styles/range-based-mapping-expected.txt: Removed.
  • inspector/styles/range-based-mapping.html: Removed.
3:00 AM Changeset in webkit [142444] by commit-queue@webkit.org
  • 69 edits
    2 adds in trunk

Implement CSSValue::equals(const CSSValue&) to optimise CSSValue comparison
https://bugs.webkit.org/show_bug.cgi?id=102901

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2013-02-11
Reviewed by Antti Koivisto.

Source/WebCore:

Added comparison method to CSSValue and its children, so that the
css values could be compared efficiently. Before this patch, CSSValue
objects were compared using strings that were generated by the cssText() method.

Test: cssom/cssvalue-comparison.html

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::equals):
(WebCore):

  • css/CSSAspectRatioValue.h:

(CSSAspectRatioValue):

  • css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeRectangle::equals):
(WebCore):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):

  • css/CSSBasicShapes.h:

(CSSBasicShapeRectangle):
(CSSBasicShapeCircle):
(CSSBasicShapeEllipse):
(CSSBasicShapePolygon):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::equals):
(WebCore):

  • css/CSSBorderImageSliceValue.h:

(CSSBorderImageSliceValue):

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::equals):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::equals):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::type):
(WebCore::CSSCalcBinaryOperation::equals):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::type):

  • css/CSSCalculationValue.h:

(WebCore::CSSCalcExpressionNode::equals):
(CSSCalcExpressionNode):
(CSSCalcValue):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::equals):
(WebCore):

  • css/CSSCanvasValue.h:

(CSSCanvasValue):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::equals):
(WebCore):

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::equals):
(WebCore):

  • css/CSSCursorImageValue.h:

(CSSCursorImageValue):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::equals):
(WebCore):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::equals):
(WebCore):

  • css/CSSFunctionValue.h:

(CSSFunctionValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::equals):
(WebCore):
(WebCore::CSSRadialGradientValue::equals):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientColorStop::operator==):
(CSSLinearGradientValue):
(CSSRadialGradientValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::equals):
(WebCore):

  • css/CSSImageValue.h:

(CSSImageValue):

  • css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::equals):
(CSSInheritedValue):

  • css/CSSInitialValue.h:

(WebCore::CSSInitialValue::equals):
(CSSInitialValue):

  • css/CSSLineBoxContainValue.h:

(WebCore::CSSLineBoxContainValue::equals):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::equals):
(WebCore):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::equals):
(WebCore):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSTimingFunctionValue.cpp:

(WebCore::CSSCubicBezierTimingFunctionValue::equals):
(WebCore):
(WebCore::CSSStepsTimingFunctionValue::equals):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSLinearTimingFunctionValue::equals):
(CSSLinearTimingFunctionValue):
(CSSCubicBezierTimingFunctionValue):
(CSSStepsTimingFunctionValue):

  • css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::equals):
(WebCore):

  • css/CSSUnicodeRangeValue.h:

(CSSUnicodeRangeValue):

  • css/CSSValue.cpp:

(WebCore):
(WebCore::compareCSSValues):
(WebCore::CSSValue::equals):

  • css/CSSValue.h:

(CSSValue):
(WebCore):
(WebCore::compareCSSValueVector):
(WebCore::compareCSSValuePtr):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::removeAll):
(WebCore::CSSValueList::hasValue):
(WebCore::CSSValueList::equals):
(WebCore):

  • css/CSSValueList.h:

(CSSValueList):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::equals):
(CSSVariableValue):

  • css/Counter.h:

(Counter):
(WebCore::Counter::equals):

  • css/DashboardRegion.h:

(WebCore::DashboardRegion::equals):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::equals):
(WebCore):

  • css/FontFeatureValue.h:

(FontFeatureValue):

  • css/FontValue.cpp:

(WebCore::FontValue::equals):
(WebCore):

  • css/FontValue.h:

(FontValue):

  • css/MediaQueryExp.h:

(WebCore::MediaQueryExp::operator==):

  • css/Pair.h:

(WebCore::Pair::equals):
(Pair):

  • css/Rect.h:

(WebCore::RectBase::equals):
(RectBase):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::equals):
(WebCore):

  • css/ShadowValue.h:

(ShadowValue):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::propertyMatches):

  • css/WebKitCSSArrayFunctionValue.cpp:

(WebCore::WebKitCSSArrayFunctionValue::equals):
(WebCore):

  • css/WebKitCSSArrayFunctionValue.h:

(WebKitCSSArrayFunctionValue):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::equals):
(WebCore):

  • css/WebKitCSSFilterValue.h:

(WebKitCSSFilterValue):

  • css/WebKitCSSMixFunctionValue.cpp:

(WebCore::WebKitCSSMixFunctionValue::equals):
(WebCore):

  • css/WebKitCSSMixFunctionValue.h:

(WebKitCSSMixFunctionValue):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::equals):
(WebCore):

  • css/WebKitCSSSVGDocumentValue.h:

(WebKitCSSSVGDocumentValue):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::equals):
(WebCore):

  • css/WebKitCSSShaderValue.h:

(WebKitCSSShaderValue):

  • css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::equals):

  • editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::equals):
(WebCore):

  • svg/SVGColor.h:

(SVGColor):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::equals):
(WebCore):

  • svg/SVGPaint.h:

(SVGPaint):

LayoutTests:

New layout test to verify that CSSValue objects comparison works properly.

  • cssom/cssvalue-comparison-expected.txt: Added.
  • cssom/cssvalue-comparison.html: Added.
2:24 AM Changeset in webkit [142443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Inspector] Network panel, sort by "transferSize" instead of "resourceSize".
https://bugs.webkit.org/show_bug.cgi?id=109142.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Sort by "transferSize" as it is the primary rather than "resoureSize".

No new tests.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.SizeComparator):

2:22 AM Changeset in webkit [142442] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Mark svg/custom/foreign-object-skew.svg
as [ ImageOnlyFailure Pass ].

  • platform/chromium/TestExpectations:
2:11 AM Changeset in webkit [142441] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Resources] Prefactorings in DataGrid and CookieTable
https://bugs.webkit.org/show_bug.cgi?id=109141

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

1) Make deleteCookie method static and move to WebInspector.Cookie
2) Replace resfreshCallback getter/setter in DataGrid with
constructor parameter

  • inspector/front-end/CookieItemsView.js: Adopt changes.
  • inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.remove): Moved from CookiesTable.

  • inspector/front-end/CookiesTable.js: Adopt changes.
  • inspector/front-end/DataGrid.js:

Replace setter with constructor parameter.

1:39 AM Changeset in webkit [142440] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: Don't throw exceptions in WebInspector.Color
https://bugs.webkit.org/show_bug.cgi?id=104835

Source/WebCore:

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

WebInspector.Color.parse() returns a Color from a string, or null;
Ctor calls now call parse();
In the StylesSideBarPane, test null rather than catch(e).

Added case to inspector/styles/styles-invalid-color-values.html

  • inspector/front-end/Color.js:

(WebInspector.Color):
(WebInspector.Color.parse):
(WebInspector.Color.fromRGBA):
(WebInspector.Color.fromRGB):
(WebInspector.Color.prototype.toString):
(WebInspector.Color.prototype._parse.this.alpha.set 0):
(WebInspector.Color.prototype._parse.this.nickname.set 2):
(WebInspector.Color.prototype._parse.this.hsla.set 1):
(WebInspector.Color.prototype._parse.this.rgba.set 0):
(WebInspector.Color.prototype._parse.set WebInspector):
(WebInspector.Color.prototype._parse):

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.prototype.get color):

  • inspector/front-end/StylesSidebarPane.js:

LayoutTests:

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Added case to test parsing 'none' from border style

  • inspector/styles/styles-invalid-color-values-expected.txt:
  • inspector/styles/styles-invalid-color-values.html:
1:34 AM Changeset in webkit [142439] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Handle home key shortcut explicitly in TextEditorMainPanel.

New test: inspector/editor/text-editor-home-button.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):

LayoutTests:

Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.

  • inspector/editor/editor-test.js:

(initialize_EditorTests.lineWithCursor):
(initialize_EditorTests.InspectorTest.textWithSelection): Added helper method to add selection symbols in text.

  • inspector/editor/text-editor-home-button-expected.txt: Added.
  • inspector/editor/text-editor-home-button.html: Added.
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
1:04 AM Changeset in webkit [142438] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] clear the webcache from within the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109405

Reviewed by Kentaro Hara.

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

1:02 AM Changeset in webkit [142437] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] add a destructor to EventSender
https://bugs.webkit.org/show_bug.cgi?id=109401

Reviewed by Kentaro Hara.

Otherwise, the compiler will automatically generate a destructor, for
which we need to unnecessarily include WebContextMenuData.h in the
header.

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::~EventSender):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):
(EventSender):

12:36 AM Changeset in webkit [142436] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening

  • platform/gtk/TestExpectations: Flagging media tests affected

by bug 108682

12:27 AM Changeset in webkit [142435] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip faling test.
https://bugs.webkit.org/show_bug.cgi?id=109353.

  • platform/qt/TestExpectations:
12:06 AM Changeset in webkit [142434] by inferno@chromium.org
  • 33 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
https://bugs.webkit.org/show_bug.cgi?id=108981

Reviewed by Eric Seidel.

Source/WebCore:

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):
(WebCore::RTCStatsResponse::addStatistic):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::skipBuffer):

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::transformValueToCssString):

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::search):

  • html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

  • html/ImageData.cpp:

(WebCore::ImageData::ImageData):

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::getSomeData):

  • platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunk):

  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::getKernelsFromAzimuthElevation):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/Region.cpp:

(WebCore::Region::Shape::segments_end):

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::getValues):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::inputEffect):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

  • platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkFloatsInCleanLine):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculatePercentForSpline):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

Source/WTF:

  • wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):

  • wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::ensureSegment):

  • wtf/StringPrintStream.cpp:

(WTF::StringPrintStream::vprintf):

  • wtf/Vector.h:

(WTF::::insert):
(WTF::::remove):

  • wtf/dtoa/utils.h:

(WTF::double_conversion::StringBuilder::SetPosition):
(WTF::double_conversion::StringBuilder::AddSubstring):

Feb 10, 2013:

11:24 PM Changeset in webkit [142433] by Chris Fleizach
  • 12 edits
    2 adds in trunk

WebSpeech: Implement basic speaking/finished speaking behavior
https://bugs.webkit.org/show_bug.cgi?id=107135

Reviewed by Sam Weinig.

Source/WebCore:

Implements the basic functionality of speaking utterances.

In the WebCore side, it manages the speech queue the way the spec defines
(that is, new jobs are appended to a queue and wait for other jobs to finish).

On the Mac side, it instantiates a synthesizer and handles the callbacks for when
jobs are finished. It sends those jobs back to WebCore to dispatch the right events.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-speak.html

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::speak):
(WebCore):
(WebCore::SpeechSynthesis::fireEvent):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):

  • Modules/speech/SpeechSynthesis.h:

(WebCore):
(WebCore::SpeechSynthesis::speaking):
(SpeechSynthesis):

  • Modules/speech/SpeechSynthesisEvent.cpp:

(WebCore::SpeechSynthesisEvent::create):
(WebCore):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):

  • Modules/speech/SpeechSynthesisEvent.h:

(SpeechSynthesisEvent):
(WebCore::SpeechSynthesisEvent::interfaceName):

  • Modules/speech/SpeechSynthesisUtterance.h:

(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(SpeechSynthesisUtterance):

  • platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):

  • platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
(WebCore::PlatformSpeechSynthesisUtterance::startTime):
(WebCore::PlatformSpeechSynthesisUtterance::setStartTime):
(WebCore::PlatformSpeechSynthesisUtterance::client):

  • platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):

  • platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::client):
(PlatformSpeechSynthesizer):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
(-[WebSpeechSynthesisWrapper dealloc]):
(-[WebSpeechSynthesisWrapper convertRateToWPM:]):
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-speak-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-speak.html: Added.
11:06 PM EFLWebKitBuildBots edited by Christophe Dumez
(diff)
11:04 PM EFLWebKitBuildBots edited by Christophe Dumez
(diff)
10:54 PM Changeset in webkit [142432] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
10:53 PM Changeset in webkit [142431] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked http/tests/css/css-image-loading.html as SLOW.

  • platform/chromium/TestExpectations:
10:47 PM Changeset in webkit [142430] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
10:38 PM Changeset in webkit [142429] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add adobe.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109396

Patch by Dirk Schulze <dschulze@adobe.com> on 2013-02-10
Reviewed by Laszlo Gombos.

  • team.html:
9:16 PM Changeset in webkit [142428] by weinig@apple.com
  • 22 edits in trunk/Source/WebKit2

Make the Plug-in XPCService build work even when building in Xcode
<rdar://problem/13011186>
https://bugs.webkit.org/show_bug.cgi?id=109392

Reviewed by Anders Carlsson.

  • Configurations/DebugRelease.xcconfig:

Add a DEBUG_OR_RELEASE variable to test against.

  • Configurations/PluginService.32.xcconfig:
  • Configurations/PluginService.64.xcconfig:

In non-production builds, don't link against WebKit2, so that we don't get warnings about WebKit2.framework
not containing the right architectures. This is ok, as these services are not used in non-production builds.

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:

Switch off the the old idiom of defining a macro for the initializer function, and instead set
it in the Info.plist, so the XPCServiceBootstrapper can grab it.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h:

(WebKit::XPCServiceEventHandler):
Get the entry point from the bundle, rather than the macro. This is not only a bit less gross,
but also allows us to build without having linked against WebKit2.framework.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Re-enable using XPC for plug-ins.

  • WebKit2.xcodeproj/project.pbxproj:

Update project.

9:14 PM Changeset in webkit [142427] by eric@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Make the existing HTMLPreloadScanner threading-aware
https://bugs.webkit.org/show_bug.cgi?id=107807

Reviewed by Adam Barth.

The HTMLPreloadScanner and CSSPreloadScanner do a number of things.
CSSPreloadScanner is mostly just a helper class for HTMLPreloadScanner.
HTMLPreloadScanner runs its own copy of the HTMLTokenizer and uses
HTMLTokenizer::updateStateFor to emulate enough of the TreeBuilder
to get a realistic stream of tokens. It does some additional TreeBuilder
emulation, including tracking template tags and base tags, but mostly
just scans the token stream for start-tags and looks for URLs in them.
It tracks when it has seen a <style> tag and starts sending all character tokens
to the CSSPreloadScanner until a </style> tag is seen.
It also (unfortunately) knows some about the loader guts and how to construct
a proper CachedResourcRequest and issue a preload.

This patch changes the model so that the preload scanners only know how to produce
PreloadRequest objects and append them to a passed-in vector.

This changes the preload-scanner behavior so that preloads are now all issued in one large
batch at the end of scanning, instead of as we hit each resource. It's possible that
we'll wait to instead check for preload requests more often, at a possible tradeoff
to tokenizing speed.

An alternate approach might be to pass in a preload-delegate of sorts which knew how
to either build a vector, or send requests immediately. For now the build-a-vector-always
approach seems clean, and does not seem to slow down our PerformanceTest microbenchmarks at least.

This patch has 2 main pieces:

  • Remove Document and (and loader) dependencies from HTMLPreloadScanner/CSSPreloadScanner This is done through introduction of a new HTMLResourcePreloader class which holds a Document* and knows how to talk to the CachedResourceLoader.
  • Clean-up HTMLPreloadScanners token-loop to not be tied to having a Tokenizer. (On a background thead, the HTMLPreloadScanner won't own the tokenizer, it will just

be passed in tokens and expected to issue loads if necessary.)

This passes all of the LayoutTests using the main thread parser.

This patch does not make the HTMLPreloadScanner 100% ready for threading
(it still uses AtomicString which is currently not-OK on the parser thread)
but it's very close. Two further (already written) patches will complete this.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::CSSPreloadScanner):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::PreloadTask::processAttributes):
(WebCore::PreloadTask::charset):
(PreloadTask):
(WebCore::PreloadTask::resourceType):
(WebCore::PreloadTask::shouldPreload):
(WebCore::PreloadTask::createPreloadRequest):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleTemplateTag):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLPreloadScanner.h:

(HTMLPreloadScanner):

  • html/parser/HTMLResourcePreloader.cpp: Added.

(WebCore):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::PreloadRequest::isSafeToSendToAnotherThread):
(WebCore::PreloadRequest::completeURL):
(WebCore::PreloadRequest::resourceRequest):
(WebCore::HTMLResourcePreloader::preload):

  • html/parser/HTMLResourcePreloader.h: Added.

(WebCore):
(PreloadRequest):
(WebCore::PreloadRequest::create):
(WebCore::PreloadRequest::PreloadRequest):
(HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::createWeakPtr):

  • loader/cache/CachedResourceRequest.h:
8:37 PM Changeset in webkit [142426] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
8:29 PM Changeset in webkit [142425] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add sisa.samsung.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109394

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-10
Reviewed by Dirk Schulze.

  • team.html:
8:14 PM Changeset in webkit [142424] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

[V8] Rename isolated() to getWorld(), rename worldForEnteredContextIfIsolated() to worldForEnteredContext()
https://bugs.webkit.org/show_bug.cgi?id=109039

Reviewed by Adam Barth.

This is a follow-up patch for r141983.
Rename methods for consistency.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::getWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContext):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

6:54 PM Changeset in webkit [142423] by aelias@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix Android scrollbar size
https://bugs.webkit.org/show_bug.cgi?id=109374

Reviewed by James Robinson.

This shrinks scrollbars to 3 device-independent pixels (usually 6
physical pixels) and deletes the edge fade. Although the Android
system theme does have an edge fade, it's a much sharper cliff
than we had (against black, the colors go 64 -> 64 -> 52 -> 21 -> 0)
and I can't perceive any difference compared with no fade at all.

No new tests (due for rewrite in a week anyway).

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):

6:38 PM Changeset in webkit [142422] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit/chromium

[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369

Patch by James Robinson <jamesr@chromium.org> on 2013-02-10
Reviewed by Darin Fisher.

Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
calling into webkit_support so they work in component builds.

  • WebKit.gyp:
  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebViewAndLoad):
(QuitTask):
(WebKit::FrameTestHelpers::QuitTask::run):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::runPendingTasks):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/ListenerLeakTest.cpp:
  • tests/PopupMenuTest.cpp:
  • tests/PrerenderingTest.cpp:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::navigateTo):

  • tests/URLTestHelpers.cpp:

(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/WebFrameTest.cpp:
  • tests/WebImageTest.cpp:

(WebKit::readFile):

  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebPluginContainerTest.cpp:

(WebKit::WebPluginContainerTest::TearDown):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:
5:29 PM Changeset in webkit [142421] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked fast/frames/seamless/seamless-inherited-origin.html as FAIL.

  • platform/chromium/TestExpectations:
5:23 PM Changeset in webkit [142420] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined svg/custom/foreign-object-skew.svg.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
5:16 PM Changeset in webkit [142419] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

1:50 PM Changeset in webkit [142418] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181645. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-10

  • DEPS:
1:04 PM Changeset in webkit [142417] by commit-queue@webkit.org
  • 6 edits in trunk

Consolidate the way WTF_USE_PTHREADS is enabled
https://bugs.webkit.org/show_bug.cgi?id=108191

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-10
Reviewed by Benjamin Poulain.

.:

Remove duplicated definition of WTF_USE_PTHREADS.

WTF_USE_PTHREADS is defined to 1 on all OS(UNIX) environments in
Platform.h.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WTF:

Define WTF_USE_PTHREADS to 1 on all OS(UNIX) environments.

  • WTF.gyp/WTF.gyp: Remove duplicated definition of WTF_USE_PTHREADS.
  • wtf/Platform.h:
12:11 PM Changeset in webkit [142416] by timothy_horton@apple.com
  • 3 edits
    5 adds in trunk

REGRESSION (r132422): Page content and scrollbars are incorrectly offset after restoring a page from the page cache
https://bugs.webkit.org/show_bug.cgi?id=109317
<rdar://problem/12649131>

Reviewed by Simon Fraser.

Mark all scrolling that occurs beneath FrameView::layout as programmatic.

Test: platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

Add a test that ensures that scroll position is correctly restored for pages coming out of the page cache when tiled drawing is enabled.

  • platform/mac-wk2/tiled-drawing/resources/go-back.html: Added.
  • platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html: Added.
  • platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html: Added.
11:54 AM Changeset in webkit [142415] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Unreviewed attempted build fix for Gtk after r142412

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

11:51 AM Changeset in webkit [142414] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r142413.
http://trac.webkit.org/changeset/142413
https://bugs.webkit.org/show_bug.cgi?id=109383

didn't fix the gtk build (Requested by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-10

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
11:40 AM Changeset in webkit [142413] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Unreviewed attempted build fix for Gtk after r142412

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
11:27 AM Changeset in webkit [142412] by timothy_horton@apple.com
  • 7 edits in trunk/Tools

WKTR should propagate view creation options to opened windows
https://bugs.webkit.org/show_bug.cgi?id=109381

Reviewed by Simon Fraser.

  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::options):
Add storage and a getter for PlatformWebView's creation options dictionary.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
Propagate creation options from parent to child PlatformWebView when creating subwindows.

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):
Store creation options on the PlatformWebView.

10:26 AM Changeset in webkit [142411] by mrobinson@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the GTK+ gyp build

reflect what's in the repository and remove the offsets extractor
from the list of JavaScriptCore files. It's only used to build
the extractor binary.

10:18 AM Changeset in webkit [142410] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Mac] Fix release build failure by recent reverts

  • WebCore.exp.in:
9:55 AM Changeset in webkit [142409] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Add back code that was accidentally removed when moving plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109379

Reviewed by Andreas Kling.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):

9:48 AM Changeset in webkit [142408] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Added *.pdf to EXCLUDED_SOURCE_FILE_NAMES_iphoneos.

Rubber-stamped by Anders Carlsson.

  • Configurations/WebKit.xcconfig:
9:33 AM Changeset in webkit [142407] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/TestExpectations: Remove duplicate test expectation

for media/track/track-in-band-style.html.

9:29 AM Changeset in webkit [142406] by Philippe Normand
  • 9 edits in trunk

[GStreamer] media/video-controls-fullscreen-volume.html crashes
https://bugs.webkit.org/show_bug.cgi?id=108682

Reviewed by Martin Robinson.

Source/WebCore:

Clean up various signal handlers and avoid bad interaction between
the FullscreenVideoControllerGStreamer and its subclasses,
especially when the platform video window is created.

  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:

(WebCore::FullscreenVideoControllerGStreamer::enterFullscreen):
Initialize the window before connecting to the volume/mute
signals. This ensures that the signals won't ever interfere with
an inexisting window.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::~GStreamerGWorld): Remove GstBus
synchronous handler function.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect from volume/mute signals.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
Keep a trace of volume/mute signal handlers.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Various forward type declarations to avoid un-necessary header includes.
(MediaPlayerPrivateGStreamerBase):

  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:

(WebCore::FullscreenVideoControllerGtk::FullscreenVideoControllerGtk):
(WebCore::FullscreenVideoControllerGtk::volumeChanged): Bail out
if volume button hasn't been created yet.
(WebCore::FullscreenVideoControllerGtk::muteChanged): Ditto.

LayoutTests:

  • platform/gtk/TestExpectations: Unflag now passing tests.
8:39 AM Changeset in webkit [142405] by tkent@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r142347.
http://trac.webkit.org/changeset/142347
https://bugs.webkit.org/show_bug.cgi?id=108273

Because a depending change r142343 was rolled out.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

8:04 AM Changeset in webkit [142404] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

RenderStyle should use copy-on-write inheritance for NinePieceImage.
<http://webkit.org/b/109366>

Reviewed by Antti Koivisto.

Refactor NinePieceImage to hold a copy-on-write DataRef like other RenderStyle substructures.
This allows us to avoids copying the NinePieceImageData when one RenderStyle inherits from another
but modifies something in the substructure holding the NinePieceImage (typically StyleSurroundData.)

Also made RenderStyle not copy-on-write its StyleSurroundData prematurely when doing a no-op write
to a border-image related value.

1.23 MB progression on Membuster3.

  • rendering/style/NinePieceImage.cpp:

(WebCore::defaultData):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImageData::NinePieceImageData):
(WebCore::NinePieceImageData::operator==):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImageData::create):
(WebCore::NinePieceImageData::copy):
(NinePieceImageData):
(NinePieceImage):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::computeOutset):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setBorderImageSource):
(WebCore::RenderStyle::setBorderImageSlices):
(WebCore::RenderStyle::setBorderImageWidth):
(WebCore::RenderStyle::setBorderImageOutset):

  • rendering/style/RenderStyle.h:
7:05 AM Changeset in webkit [142403] by tkent@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Build fix for r142371
https://bugs.webkit.org/show_bug.cgi?id=109313

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):

6:33 AM Changeset in webkit [142402] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=109376

  • platform/chromium/TestExpectations:

fast/frames/seamless/seamless-inherited-origin.html is failing on debug bots.

6:26 AM Changeset in webkit [142401] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/TestExpectations: Flag new failing media/track test.
6:24 AM Changeset in webkit [142400] by tkent@chromium.org
  • 21 edits in trunk/Source

Unreviewed, rolling out r142343.
http://trac.webkit.org/changeset/142343
https://bugs.webkit.org/show_bug.cgi?id=108284

It might make inspector/profiler/selector-profiler-url.html
crashy.

Source/WebCore:

  • WebCore.exp.in:
  • css/plugIns.css:

(p):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::createRenderer):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::updateSnapshot):
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

  • html/HTMLPlugInImageElement.h:

(WebCore):
(HTMLPlugInImageElement):

  • page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelImage):

  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:
  • platform/chromium/LocalizedStringsChromium.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore):

  • platform/qt/LocalizedStringsQt.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::paint):
(WebCore::RenderSnapshottedPlugIn::paintReplaced):
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::RenderSnapshottedPlugIn::startLabelImage):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel):

  • rendering/RenderSnapshottedPlugIn.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelImage):
(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

6:13 AM Changeset in webkit [142399] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Refactor the way HAVE_XXX macros are set
https://bugs.webkit.org/show_bug.cgi?id=108132

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-10
Reviewed by Benjamin Poulain.

OS(WINDOWS) and OS(UNIX) are so broadly defined that for each
builds exactly one of them is enabled. Use this assumption to
cleanup Platform.h.

  • wtf/Platform.h:
5:44 AM Changeset in webkit [142398] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderText: Access characters through m_text instead of caching data pointers separately.
<http://webkit.org/b/109357>

Reviewed by Antti Koivisto.

Go through RenderText::m_text.impl() instead of caching the character data pointer.
RenderText should never have a null String in m_text so it's safe to access impl() directly.
We have assertions for this since before.

Removing this pointer shrinks RenderText by 8 bytes, allowing it to fit into a snugger size class.
749 KB progression on Membuster3.

  • rendering/RenderText.cpp:

(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::setTextInternal):

  • rendering/RenderText.h:

(WebCore::RenderText::is8Bit):
(WebCore::RenderText::characters8):
(WebCore::RenderText::characters16):
(WebCore::RenderText::characterAt):
(WebCore::RenderText::operator[]):
(RenderText):

5:01 AM Changeset in webkit [142397] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=92941

  • platform/chromium/TestExpectations:

accessibility/loading-iframe-updates-axtree.html is [ Timeout ].

4:49 AM FeatureFlags edited by tkent@chromium.org
Remove GLIB_SUPPORT, add ENCRYPTED_MEDiA_V2 and NOSNIFF (diff)
4:42 AM Changeset in webkit [142396] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip fast/encoding/parser-tests-*.html tests now that the crashes
have been fixed by r142385.

  • platform/efl-wk2/TestExpectations:
3:23 AM Changeset in webkit [142395] by commit-queue@webkit.org
  • 18 edits in trunk

Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
https://bugs.webkit.org/show_bug.cgi?id=104266

Patch by Jae Hyun Park <jae.park08@gmail.com> on 2013-02-10
Reviewed by Philippe Normand.

Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
the existing macro naming conventions.

From Platform.h
USE() - use a particular third-party library or optional OS service
ENABLE() - turn on a specific feature of WebKit

.:

  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

No new tests, no new functionality.

  • WebCore.pri:

Source/WebKit/gtk:

  • gyp/Configuration.gypi:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Source/WTF:

  • WTF.pri:
  • wtf/Platform.h:
  • wtf/gobject/GOwnPtr.cpp:
  • wtf/gobject/GOwnPtr.h:
  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:
2:44 AM Changeset in webkit [142394] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

gtkdoc-scangobj throwing warnings when using Clang, causes generate-gtkdoc to fail
https://bugs.webkit.org/show_bug.cgi?id=109315

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Philippe Normand.

  • GNUmakefile.am: Define the CC environment variable to the CC compiler that the whole

project was configured to use. This ensures both the regular build and the gtkdoc-scangobj
program use the same compiler.

  • gtk/generate-gtkdoc: Add '-Qunused-arguments' to the CFLAGS in case we're using Clang. This

forces Clang to suppress unused arguments warnings that can unnecessarily cause generate-gtkdoc
script to fail.

2:42 AM Changeset in webkit [142393] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[WebKit2][Gtk] Remove the fullscreen manager proxy message receiver upon invalidating
https://bugs.webkit.org/show_bug.cgi?id=109352

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Sam Weinig.

As added for the Mac port in r142160 due to the changes in the same revision, remove
the fullscreen manager proxy as a message receiver. Also fixes a failing unit test.

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

2:40 AM Changeset in webkit [142392] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Build errors in TextureMapperShaderProgram.cpp when compiling with Clang
https://bugs.webkit.org/show_bug.cgi?id=109321

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Noam Rosenthal.

Clang is reporting errors due to non-constant expressions that cannot be narrowed
from double to float type in initializer list when constructing a matrix of GC3Dfloat
numbers. To avoid this every parameter is passed through an explicit GC3Dfloat constructor.

No new tests - no new functionality.

  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::setMatrix):

2:00 AM Changeset in webkit [142391] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] audio is muted when playback rate is between 0.8 and 2.0
https://bugs.webkit.org/show_bug.cgi?id=109362

Reviewed by Martin Robinson.

Don't mute sound if the audio pitch is preserved. If this is not
the case mute it if it's too extreme, as the HTML5 spec recommends.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setRate):

12:36 AM Changeset in webkit [142390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix build on PLUGIN_ARCHITECTURE(UNSUPPORTED) after r142314
https://bugs.webkit.org/show_bug.cgi?id=109364

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-10
Reviewed by Simon Hausmann.

void NetscapePlugin::platformPreInitialize() is need to be added to NetscapePluginNone.cpp.

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):

Feb 9, 2013:

11:37 PM Changeset in webkit [142389] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by Joseph Pecoraro.

  • TestWebKitAPI/Configurations/Base.xcconfig:

Added back FRAMEWORK_SEARCH_PATHS for Lion builds.

11:09 PM Changeset in webkit [142388] by jamesr@google.com
  • 2 edits
    1 add in trunk/Source/Platform

[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369

Reviewed by Darin Fisher.

Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
in component builds.

  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::unitTestSupport):

  • chromium/public/WebUnitTestSupport.h: Added.

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::registerMockedURL):
(WebKit::WebUnitTestSupport::registerMockedErrorURL):
(WebKit::WebUnitTestSupport::unregisterMockedURL):
(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
(WebKit::WebUnitTestSupport::webKitRootDir):

10:41 PM Changeset in webkit [142387] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Shrink-wrap UnlinkedCodeBlock members.
<http://webkit.org/b/109368>

Reviewed by Oliver Hunt.

Rearrange the members of UnlinkedCodeBlock to avoid unnecessary padding on 64-bit.
Knocks ~600 KB off of the Membuster3 peak.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedCodeBlock):

10:26 PM Changeset in webkit [142386] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

Chromium gardening

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium/TestExpectations:
10:11 PM Changeset in webkit [142385] by dmazzoni@google.com
  • 4 edits in trunk

fast/encoding/parser-tests-*.html tests sometimes crash
https://bugs.webkit.org/show_bug.cgi?id=108058

Reviewed by Chris Fleizach.

Source/WebCore:

To avoid calling accessibilityIsIgnored while the render
tree is unstable, call accessibilityIsIgnored in the
notification timer handler, only for childrenChanged
notifications.

This exposed a problem where notifications queued on
objects can fire after the object has been deleted; fix that
by checking the object's id, which is always set to 0 when
removed from the tree.

Covered by existing tests.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):

LayoutTests:

Make test less brittle by (1) giving the iframe an aria-role so
it's never ignored, and (2) using accessibilityElementById instead
of assuming an element is in a specific place in the AX tree.

  • accessibility/loading-iframe-updates-axtree.html:
7:48 PM Changeset in webkit [142384] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r137328.
http://trac.webkit.org/changeset/137328
https://bugs.webkit.org/show_bug.cgi?id=109367

causes memory usage to balloon if connection queue is filling
faster than sending (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):

  • Platform/CoreIPC/ArgumentEncoder.h:

(CoreIPC::ArgumentEncoder::buffer):
(ArgumentEncoder):

4:50 PM Changeset in webkit [142383] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Do not assume MediaAccessibility framework is installed
https://bugs.webkit.org/show_bug.cgi?id=109365

Reviewed by Sam Weinig.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Call the base class if the framework

is not available.

(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Ditto.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto.

3:06 PM Changeset in webkit [142382] by dmazzoni@google.com
  • 39 edits in trunk/Source/WebCore

AX: move isIgnored caching to AXObject
https://bugs.webkit.org/show_bug.cgi?id=109322

Reviewed by Chris Fleizach.

There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.

AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.

No new tests.

  • accessibility/AccessibilityImageMapLink.h:

(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.h:

(AccessibilityList):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBoxOption.h:

(AccessibilityListBoxOption):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):

  • accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListOption.h:

(AccessibilityMenuListOption):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListPopup.h:

(AccessibilityMenuListPopup):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityProgressIndicator.h:

(AccessibilityProgressIndicator):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityScrollView.h:

(AccessibilityScrollView):

  • accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):
(AccessibilitySliderThumb):

  • accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.h:

(AccessibilityTableCell):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.h:

(AccessibilityTableColumn):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.h:

(AccessibilityTableHeaderContainer):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableRow.h:

(AccessibilityTableRow):

2:53 PM Changeset in webkit [142381] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 move
    1 add in trunk

Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

Source/WebCore:

Tests already exist - refactor only.

  • WebCore.exp.in: Lumped ZNK7WebCore4KURL7hasPathEv with related methods.
  • platform/KURL.cpp: Inlined hasPath() into the header
  • platform/KURL.h: Inlined hasPath() into the header

Tools:

  • Makefile: Added TestWebKitAPI to iOS MODULES list.
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • Include FeatureDefines
  • Removed VALID_ARCHS
  • Removed FRAMEWORK_SEARCH_PATHS - allows building against other SDKs
  • Excluded source files per platform
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • framework and library switches per platform
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • Remove explicit framework and library linking (moved to xcconfigs)
  • Added iOS main.mm
  • TestWebKitAPI/config.h:
  • Guard importing Cocoa.h and WebKit2_C.h on iOS
  • TestWebKitAPI/ios/mainIOS.mm: Copied from Tools/TestWebKitAPI/mac/main.mm.
  • TestWebKitAPI/mac/mainMac.mm: Renamed from Tools/TestWebKitAPI/mac/main.mm.
1:00 PM Changeset in webkit [142380] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Reverting earlier change now

Unreviewed expectations.

  • platform/chromium/TestExpectations: Removed all the expectations added earlier.
12:13 PM Changeset in webkit [142379] by jschuh@chromium.org
  • 2 edits in trunk/Tools

[CHROMIUM] Suppress c4267 build warnings for Win64 tests
https://bugs.webkit.org/show_bug.cgi?id=109359

Reviewed by Abhishek Arya.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11:34 AM Changeset in webkit [142378] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

Load event fires too early with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108984

Reviewed by Eric Seidel.

Previously, the DocumentLoader would always be on the stack when the
HTMLDocumentParser was processing data from the network. The
DocumentLoader would then tell isLoadingInAPISense not to fire the load
event. Now that we process data asynchronously with the threaded
parser, the DocumentLoader is not always on the stack, which means we
need to delay the load event using the clause that asks the parser
whether it is processing data.

Unfortunately, that clause is fragile because we can check for load
completion while we're switching parsers between the network-created
parser and a script-created parser. To avoid accidentially triggerin
the load event during these "gaps," this patch introduces a counter on
document to record how many parsers are active on the stack. While
that numer is non-zero, we'll delay the load event. When that number
reaches zero, we'll check for load complete.

That last step is required because the DocumentLoader::finishLoading
method is no longer guarunteed to check for load complete after calling
finish on the parser because the finish operation might complete
asynchronously.

After this patch, the threaded parser passes all but four fast/parser
tests.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::hasActiveParser):
(WebCore):
(WebCore::Document::decrementActiveParserCount):

  • dom/Document.h:

(Document):
(WebCore::Document::incrementActiveParserCount):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::ActiveParserSession::ActiveParserSession):
(WebCore):
(WebCore::ActiveParserSession::~ActiveParserSession):
(WebCore::PumpSession::PumpSession):
(WebCore::PumpSession::~PumpSession):

  • html/parser/HTMLParserScheduler.h:

(WebCore):
(ActiveParserSession):
(PumpSession):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense):

11:33 AM Changeset in webkit [142377] by fpizlo@apple.com
  • 33 edits
    6 adds in trunk/Source/JavaScriptCore

DFG should allow phases to break Phi's and then have one phase to rebuild them
https://bugs.webkit.org/show_bug.cgi?id=108414

Reviewed by Mark Hahnenberg.

Introduces two new DFG forms: LoadStore and ThreadedCPS. These are described in
detail in DFGCommon.h.

Consequently, DFG phases no longer have to worry about preserving data flow
links between basic blocks. It is generally always safe to request that the
graph be dethreaded (Graph::dethread), which brings it into LoadStore form, where
the data flow is implicit. In this form, only liveness-at-head needs to be
preserved.

All of the machinery for "threading" the graph to introduce data flow between
blocks is now moved out of the bytecode parser and into the CPSRethreadingPhase.
All phases that previously did this maintenance themselves now just rely on
being able to dethread the graph. The one exception is the structure check
hoising phase, which operates over a threaded graph and preserves it, for the
sake of performance.

Also moved two other things into their own phases: unification (previously found
in the parser) and prediction injection (previously found in various places).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/Operands.h:

(Operands):
(JSC::Operands::sizeFor):
(JSC::Operands::atFor):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAllocator.h:

(JSC::DFG::::allocateSlow):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGBasicBlockInlines.h:

(DFG):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCPSRethreadingPhase.cpp: Added.

(DFG):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::clearVariablesAtHeadAndTail):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
(JSC::DFG::CPSRethreadingPhase::addPhi):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):
(JSC::DFG::performCPSRethreading):

  • dfg/DFGCPSRethreadingPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp:

(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.cpp:

(WTF):
(WTF::printInternal):

  • dfg/DFGCommon.h:

(JSC::DFG::logCompilationChanges):
(DFG):
(WTF):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dethread):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::performSubstitution):
(Graph):
(JSC::DFG::Graph::performSubstitutionForEdge):
(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPhantomLocal):
(Node):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::hasVariableAccessData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):

  • dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

  • dfg/DFGPredictionInjectionPhase.cpp: Added.

(DFG):
(PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::run):
(JSC::DFG::performP