Timeline



Feb 15, 2013:

11:36 PM WikiStart edited by fpizlo@apple.com
(diff)
11:35 PM JavaScriptCore edited by fpizlo@apple.com
(diff)
10:15 PM WebKit Team edited by silviapf@chromium.org
added new committer silvia (diff)
9:56 PM Changeset in webkit [143098] by Chris Fleizach
  • 5 edits
    2 copies in trunk/Source/WebCore

AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
https://bugs.webkit.org/show_bug.cgi?id=109849

Reviewed by David Kilzer.

Split up the WebAccessibilityObjectWrapper so that iOS can share more
code with MacOS. I imagine over time, more code will move into this base class,
but for now this will be a good start.

A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
of that. iOS will be able to do the same.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/WebAccessibilityObjectWrapper.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Added.

(std):
(-[WebAccessibilityObjectWrapperMac detach]):
(-[WebAccessibilityObjectWrapperMac attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
(-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
(-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapperMac position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapperMac role]):
(-[WebAccessibilityObjectWrapperMac subrole]):
(-[WebAccessibilityObjectWrapperMac roleDescription]):
(-[WebAccessibilityObjectWrapperMac scrollViewParent]):
(-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
(-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
(-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
(-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):

9:31 PM Changeset in webkit [143097] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Structure should be more methodical about the relationship between m_offset and m_propertyTable
https://bugs.webkit.org/show_bug.cgi?id=109978

Reviewed by Mark Hahnenberg.

Allegedly, the previous relationship was that either m_propertyTable or m_offset
would be set, and if m_propertyTable was not set you could rebuild it. In reality,
we would sometimes "reset" both: some transitions wouldn't set m_offset, and other
transitions would clear the previous structure's m_propertyTable. So, in a
structure transition chain of A->B->C you could have:

A transitions to B: B doesn't copy m_offset but does copy m_propertyTable, because

that seemed like a good idea at the time (this was a common idiom in the code).

B transitions to C: C steals B's m_propertyTable, leaving B with neither a

m_propertyTable nor a m_offset.

Then we would ask for the size of the property storage of B and get the answer
"none". That's not good.

Now, there is a new relationship, which, hopefully, should fix things: m_offset is
always set and always refers to the maximum offset ever used by the property table.
From this, you can infer both the inline and out-of-line property size, and
capacity. This is accomplished by having PropertyTable::add() take a
PropertyOffset reference, which must be Structure::m_offset. It will update this
offset. As well, all transitions now copy m_offset. And we frequently assert
(using RELEASE_ASSERT) that the m_offset matches what m_propertyTable would tell
you. Hence if you ever modify the m_propertyTable, you'll also update the offset.
If you ever copy the property table, you'll also copy the offset. Life should be
good, I think.

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::add):

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::checkConsistency):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::PropertyTable::checkConsistency):

  • runtime/Structure.h:

(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::outOfLineSize):
(JSC::Structure::isEmpty):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(Structure):
(JSC::Structure::checkOffsetConsistency):

9:19 PM Changeset in webkit [143096] by benjamin@webkit.org
  • 8 edits in trunk/Source

[Mac] remove wkCaptionAppearance from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=109996

Patch by Eric Carlson <eric.carlson@apple.com> on 2013-02-15
Reviewed by Simon Fraser.

Source/WebCore:

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

8:31 PM Changeset in webkit [143095] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Unreviewed, rolling out r143088.
http://trac.webkit.org/changeset/143088
https://bugs.webkit.org/show_bug.cgi?id=110000

Breaks the build (Requested by dgorbik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15

Source/WebCore:

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:47 PM Changeset in webkit [143094] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

Enhance AudioBus copyFrom() and sumFrom() to be able to handle discrete and speakers up and down-mixing
https://bugs.webkit.org/show_bug.cgi?id=109983

Reviewed by Kenneth Russell.

The Web Audio spec has a more detailed explanation for how channels are to be up and down-mixed:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix

This patch adds the initial support for handling ChannelInterpretation, although no
new JS API is yet implemented.

No new tests since no new APIs have yet been exposed.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyFrom):
(WebCore):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::discreteCopyFrom):
(WebCore::AudioBus::discreteSumFrom):

  • platform/audio/AudioBus.h:

(AudioBus):

7:26 PM Changeset in webkit [143093] by mrobinson@webkit.org
  • 5 edits
    3 moves in trunk/Source

[GTK] Spread the gyp build files throughout the tree
https://bugs.webkit.org/show_bug.cgi?id=109960

Reviewed by Dirk Pranke.

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Renamed from Source/WebKit/gtk/gyp/JavaScriptCore.gyp.
  • JavaScriptCore.gyp/generate-derived-sources.sh: Renamed from Source/WebKit/gtk/gyp/generate-derived-sources.sh.

Source/WebKit/gtk:

  • gyp/Configuration.gypi.in: Remove the 'Source', since now it cannot be shared.
  • gyp/run-gyp: Update the path to the JavaScriptCore gypfile.

Source/WTF:

  • WTF.gyp/WTFGTK.gyp: Renamed from Source/WebKit/gtk/gyp/WTF.gyp.
7:06 PM Changeset in webkit [143092] by tony@chromium.org
  • 4 edits
    2 adds in trunk

Padding and border changes doesn't trigger relayout of children
https://bugs.webkit.org/show_bug.cgi?id=109639

Reviewed by Kent Tamura.

Source/WebCore:

In RenderBlock::layoutBlock, we only relayout our children if our logical width
changes. This misses cases where our logical width doesn't change (i.e., padding
or border changes), but our content width does change.

Also convert the needsLayout ASSERT into the if statement. This is because
RenderScrollbarPart can change border widths and not need a layout if the scrollbar
doesn't have a parent. In this case, we don't need to set any children for layout.

This is a more general case of bug 104997.

Test: fast/block/dynamic-padding-border.html

  • rendering/RenderBox.cpp:

(WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
(WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
even without border-box box sizing.

LayoutTests:

  • fast/block/dynamic-padding-border-expected.txt: Added.
  • fast/block/dynamic-padding-border.html: Added.
  • fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying

out the table when the border changed. The pixel results in this case is the same, but the
render tree shows the difference.

7:06 PM Changeset in webkit [143091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Disable sudden termination on Mac
https://bugs.webkit.org/show_bug.cgi?id=109990

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-15
Reviewed by Mark Rowe.

Sudden Termination is causing WebContent XPC services to be killed in
response to memory pressure. Hence, disable it until we can identify
if it is being enabled in error or not.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::platformInitialize): Add call to
[NSProcessInfo disableSuddenTermination].

7:03 PM Changeset in webkit [143090] by mark.lam@apple.com
  • 17 edits
    2 copies in trunk/Source/WebCore

Split SQLStatement work between the frontend and backend.
https://bugs.webkit.org/show_bug.cgi?id=104751.

Reviewed by Geoffrey Garen.

This is part of the webdatabase refactoring for webkit2.

  1. Copied SQLTransaction to SQLTransactionBackend, and then reduce the 2 to only handle frontend and backend work respectively.
  1. Changed how statements are created.
  • SQLTransaction::executeSQL() first creates a SQLStatement frontend which encapsulates the 2 script callbacks. It then passes the SQLStatement to the backend database to create the SQLStatementBackend.
  • The SQLStatementBackend manages all sqlite work.
  1. Remove the Database::reportExecuteStatementResult() wrapper because it is only needed in the backend now.
  1. Added new files to the build / project files.
  1. Updated / added comments about how the SQLStatement life-cycle works.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/Database.h:

(Database):
(WebCore::Database::reportCommitTransactionResult):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::create):
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::setBackend):
(WebCore::SQLStatement::hasCallback):
(WebCore::SQLStatement::hasErrorCallback):
(WebCore::SQLStatement::performCallback):

  • Modules/webdatabase/SQLStatement.h:

(SQLStatement):

  • Modules/webdatabase/SQLStatementBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLStatement.cpp.

(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::frontend):
(WebCore::SQLStatementBackend::sqlError):
(WebCore::SQLStatementBackend::sqlResultSet):
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
(WebCore::SQLStatementBackend::clearFailureDueToQuota):
(WebCore::SQLStatementBackend::lastExecutionFailedDueToQuota):

  • Modules/webdatabase/SQLStatementBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLStatement.h.

(SQLStatementBackend):
(WebCore::SQLStatementBackend::hasStatementCallback):
(WebCore::SQLStatementBackend::hasStatementErrorCallback):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::executeSQL):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
6:36 PM Changeset in webkit [143089] by esprehn@chromium.org
  • 20 edits in trunk/Source/WebCore

Rename HasCustomCallbacks to HasCustomStyleCallbacks
https://bugs.webkit.org/show_bug.cgi?id=109982

Reviewed by Eric Seidel.

Now that inside ChildFrameDisconnector we only call isFrameOwnerElement()
on elements that report having descendants (or themselves) have connected
frames we don't need to be as agressive about avoiding the virtual call
to isFrameOwnerElement() which lets us rename hasCustomCallbacks to
hasCustomStyleCallbacks to better reflect it's purpose.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::collectFrameOwners):

  • dom/Element.cpp:

(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::customStyleForRenderer):

  • dom/Node.h:

(WebCore::Node::pseudoId):
(WebCore::Node::hasCustomStyleCallbacks):
(WebCore::Node::customPseudoId):
(WebCore::Node::setHasCustomStyleCallbacks):

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::HTMLIFrameElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::HTMLOptionElement):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):

6:33 PM Changeset in webkit [143088] by eric.carlson@apple.com
  • 7 edits in trunk/Source

[Mac] remove wkCaptionAppearance from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=109996

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

6:23 PM Changeset in webkit [143087] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142899
BUG=168982
Review URL: https://codereview.chromium.org/12279020

6:19 PM Changeset in webkit [143086] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1410

Merge 142500
BUG=169398
Review URL: https://codereview.chromium.org/12278026

6:13 PM Changeset in webkit [143085] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142922
BUG=170679
Review URL: https://codereview.chromium.org/12284016

6:11 PM Changeset in webkit [143084] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1410

Merge 142816
BUG=171557
Review URL: https://codereview.chromium.org/12281016

6:09 PM Changeset in webkit [143083] by cevans@google.com
  • 2 edits in branches/chromium/1410/Source/WebCore/Modules/webaudio

Merge 142687
BUG=172331
Review URL: https://codereview.chromium.org/12284015

6:00 PM Changeset in webkit [143082] by cevans@google.com
  • 3 edits in branches/chromium/1410

Merge 142635
BUG=172794
Review URL: https://codereview.chromium.org/12285018

5:58 PM Changeset in webkit [143081] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142539
BUG=173068
Review URL: https://codereview.chromium.org/12282015

5:56 PM Changeset in webkit [143080] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142657
BUG=173399
Review URL: https://codereview.chromium.org/12283026

5:49 PM Changeset in webkit [143079] by cevans@google.com
  • 15 edits in branches/chromium/1410

Merge 142759
BUG=174566
Review URL: https://codereview.chromium.org/12288020

5:44 PM Changeset in webkit [143078] by cevans@google.com
  • 1 edit in branches/chromium/1410/Source/WebCore/editing/CompositeEditCommand.cpp

Merge 142642
BUG=175342
Review URL: https://codereview.chromium.org/12286016

5:42 PM Changeset in webkit [143077] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Crash on window resize if WebProcess is closed/crashed
https://bugs.webkit.org/show_bug.cgi?id=109216

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-15
Reviewed by Benjamin Poulain.

Only make calls into DrawingAreaProxy pointer after checking its state.

When the WebProcess was closed or crashed, WebKit::WebPageProxy will set
its DrawingAreaProxy pointer to null. Resize events on UIProcess/client will
try to access the object to update the geometry and forward this information
into the WebProcess. This would create a crash scenario that is fixed by this patch.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewLegacyPrivate::updateViewportSize):

5:39 PM Changeset in webkit [143076] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Calling DOM Element.attributes shouldn't force creation of ElementData.
<http://webkit.org/b/109976>

Reviewed by Darin Adler.

Don't create ElementData for an Element unnecessarily just because someone calls .attributes on it.
Previously, JS like this would create empty ElementData when 'element' has no attributes:

for (i = 0; i < element.attributes.length; ++i)

doStuff(element.attributes[i]);

Make NamedNodeMap::length() short-circuit and return 0 if !Element::hasAttributes().

  • dom/Element.cpp:

(WebCore::Element::attributes):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::length):

5:24 PM Changeset in webkit [143075] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node*
https://bugs.webkit.org/show_bug.cgi?id=109895

Reviewed by Adam Barth.

Currently an "EventTarget" type in IDL is converted to Node*.
This is wrong because there are non-Node interfaces that inherit
a EventTarget. We should convert an "EventTarget" type to EventTarget*.
This will fix FIXMEs in CodeGeneratorV8.pm.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeType):
(JSValueToNative):

5:20 PM Changeset in webkit [143074] by Simon Fraser
  • 4 edits
    1 add in trunk

REGRESSION (r142505?): Crashes in WebCore::ScrollingStateNode::appendChild when using back/forward buttons
https://bugs.webkit.org/show_bug.cgi?id=109826
<rdar://problem/13216100>

Source/WebCore:

Reviewed by Beth Dakin.

Fix a crash when going Back on some pages with fixed position elements.

When a page was being restored from the page cache, and a layout from
FrameLoader::commitProvisionalLoad() caused us to try to register the fixed
position layer before the main scrolling layer, we'd crash trying to dereference
the root node.

Fix by bailing from ScrollingStateTree::attachNode() if we can't find the parent
node.

Test: platform/mac-wk2/tiled-drawing/null-parent-back-crash.html

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::stateNodeForID):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

LayoutTests:

Reviewed by Beth Dakin.

Test having a page with an iframe that navigates forwards then back.

  • platform/mac-wk2/tiled-drawing/null-parent-back-crash.html: Added.
5:05 PM Changeset in webkit [143073] by Simon Fraser
  • 3 edits
    2 adds in trunk

Constrain fixed layers to the viewport, not the document
https://bugs.webkit.org/show_bug.cgi?id=109646

Source/WebCore:

Reviewed by Beth Dakin.

It's bad to constrain position:fixed compositing layers to the
document rect, because their bounds will change every time the scroll
position changes, and we're not good currently at synchronizing scrolling
thread layer updates with main thread layer updates, so jiggles ensue.

Fix by constraining position:fixed layers to the viewport.

Test: compositing/geometry/limit-layer-bounds-fixed.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

LayoutTests:

Reviewed by Beth Dakin.

Test with a big fixed element in a compositing layer.

  • compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • compositing/geometry/limit-layer-bounds-fixed.html: Added.
5:03 PM Changeset in webkit [143072] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebCore

Add a CDMClient class which allows the CDM to query for the currently attached MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=109702

Reviewed by Eric Carlson.

Some CDM implementations will need to work closely with an associated
MediaPlayer in order to generate key requests and provide keys. Add a
client protocol to be implemented by the MediaKeys object which can
provide access to the associated MediaPlayer if present.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::CDM): Initialize the m_client ivar.
(WebCore::CDM::mediaPlayer): Pass to the client, if present.

  • Modules/encryptedmedia/CDM.h:

(WebCore::CDM::client): Simple getter.
(WebCore::CDM::setClient): Simple setter.

  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::MediaKeys): Initialize the m_mediaElement ivar

and call setClient() on the passed in CDM.

(WebCore::MediaKeys::setMediaElement): Simple setter.
(WebCore::MediaKeys::cdmMediaPlayer): Retrieve the MediaPlayer from

the m_mediaElement if present.

  • Modules/encryptedmedia/MediaKeys.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call setMediaKeys(0)

to clear the mediaElement in any associated MediaKeys.

(WebCore::HTMLMediaElement::setMediaKeys): Clear the mediaElement on

any associated MediaKeys, and set the mediaElement on the newly
associated MediaKeys.

5:01 PM Changeset in webkit [143071] by andersca@apple.com
  • 5 edits in trunk/Source

Add HashMap::isValidKey and HashSet::isValidValue
https://bugs.webkit.org/show_bug.cgi?id=109977

Reviewed by Sam Weinig and Darin Adler.

Source/WebKit2:

Just call HashMap::isValidKey directly.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::generatePageID):
Initialize the id to 0 and use prefix increment.

(WebKit::WebProcessProxy::webFrame):
(WebKit::WebProcessProxy::canCreateFrame):
(WebKit::WebProcessProxy::didDestroyFrame):

Source/WTF:

Add helper functions for determining whether keys are valid, i.e. if
they are _not_ empty or deleted according to the hash traits.

  • wtf/HashMap.h:
  • wtf/HashSet.h:
4:55 PM Changeset in webkit [143070] by Simon Fraser
  • 4 edits
    2 adds in trunk

drop-shadow filter with overflow:hidden child misbehaves
https://bugs.webkit.org/show_bug.cgi?id=109783

Source/WebCore:

Reviewed by Dean Jackson.

The change in r112745 was not sufficient; it failed to account
for descendant layers that needed to not clipping to avoid artefacts
with filters like drop-shadow.

Test: css3/filters/filter-repaint-shadow-layer-child.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents): Remove the useClipRect bool.
Replace it with a clipToDirtyRect member on the LayerPaintingInfo, which
gets passed to descendants. Remove some "Restore the clip" comments that added
nothing.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
(LayerPaintingInfo):

LayoutTests:

Reviewed by Dean Jackson.

  • css3/filters/filter-repaint-shadow-layer-child-expected.html: Added.
  • css3/filters/filter-repaint-shadow-layer-child.html: Added.
4:52 PM Changeset in webkit [143069] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r143066.
http://trac.webkit.org/changeset/143066
https://bugs.webkit.org/show_bug.cgi?id=109986

Broke the Apple Lion build (among others). (Requested by
ddkilzer on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/WebAccessibilityObjectWrapper.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper scrollViewParent]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapper accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapper doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.m: Removed.
4:33 PM Changeset in webkit [143068] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Change MouseRelatedEvent to use LayoutPoint::scale
https://bugs.webkit.org/show_bug.cgi?id=109979

Reviewed by Dimitri Glazkov.

Change MouseRelatedEvent::MouseRelatedEvent to use LayoutPoint::
scale to adjust location and scroll offset for scale factor and
zooming.

No new tests, no change in functionality.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

4:22 PM Changeset in webkit [143067] by benjamin@webkit.org
  • 4 edits
    1 add in trunk/Tools

[WK2] Write a test to simulate crashed WebProcess followed by Window resize
https://bugs.webkit.org/show_bug.cgi?id=109842

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-15
Reviewed by Benjamin Poulain.

This new test will kill WebProcess, followed by next resizing the Window. It helps to
identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
before making calls into them.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::didCrash):
(TestWebKitAPI::TEST):

4:17 PM Changeset in webkit [143066] by Chris Fleizach
  • 4 edits
    2 adds in trunk/Source/WebCore

AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
https://bugs.webkit.org/show_bug.cgi?id=109849

Reviewed by David Kilzer.

Split up the WebAccessibilityObjectWrapper so that iOS can share more
code with MacOS. I imagine over time, more code will move into this base class,
but for now this will be a good start.

A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
of that. iOS will be able to do the same.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/WebAccessibilityObjectWrapper.h:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.m: Added.

(std):
(-[WebAccessibilityObjectWrapperMac detach]):
(-[WebAccessibilityObjectWrapperMac attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
(-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
(-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapperMac position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapperMac role]):
(-[WebAccessibilityObjectWrapperMac subrole]):
(-[WebAccessibilityObjectWrapperMac roleDescription]):
(-[WebAccessibilityObjectWrapperMac scrollViewParent]):
(-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
(-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
(-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
(-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):

3:58 PM Changeset in webkit [143065] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Typo fix after r143064.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

3:47 PM Changeset in webkit [143064] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more buildfix after r143052.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

3:14 PM Changeset in webkit [143063] by roger_fong@apple.com
  • 1 edit in trunk/Tools/EWSTools/start-queue-win.sh

Win EWS script, credentials passed in.

3:14 PM Changeset in webkit [143062] by Csaba Osztrogonác
  • 12 edits in trunk/Source/WebKit2

Unreviewed buildfix after r143052 for Qt/GTK/EFL ports.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::encode):

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::encode):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode):

  • Shared/WebBatteryStatus.cpp:

(WebKit::WebBatteryStatus::Data::encode):

  • Shared/WebNetworkInfo.cpp:

(WebKit::WebNetworkInfo::Data::encode):

  • Shared/efl/LayerTreeContextEfl.cpp:

(WebKit::LayerTreeContext::encode):

  • Shared/gtk/LayerTreeContextGtk.cpp:

(WebKit::LayerTreeContext::encode):

  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::encode):

  • Shared/qt/QtNetworkReplyData.cpp:

(WebKit::QtNetworkReplyData::encode):

  • Shared/qt/QtNetworkRequestData.cpp:

(WebKit::QtNetworkRequestData::encode):

  • Shared/soup/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::encode):

3:12 PM Changeset in webkit [143061] by commit-queue@webkit.org
  • 20 edits
    1 delete in trunk/Source/WTF

Remove support for RVCT version less than 4.0
https://bugs.webkit.org/show_bug.cgi?id=109390

The 4.0 version of the RVCT compiler was
released in 2008.

Remove support for version older then 4.0 of RVCT,
and keep the support for newer RVCT versions.

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-15
Reviewed by Zoltan Herczeg.

  • WTF.gypi: Remove StringExtras.cpp.
  • WTF.vcproj/WTF.vcproj: Remove StringExtras.cpp.
  • WTF.vcxproj/WTF.vcxproj: Remove StringExtras.cpp.
  • WTF.vcxproj/WTF.vcxproj.filters: Remove StringExtras.cpp.
  • WTF.xcodeproj/project.pbxproj: Remove StringExtras.cpp.
  • wtf/CMakeLists.txt: Remove StringExtras.cpp.
  • wtf/Compiler.h: Remove tests for RVCT_VERSION_AT_LEAST(3, 0, 0, 0).
  • wtf/Float32Array.h: Remove a quirk introduced for RVCT version <=2.2 .
  • wtf/Float64Array.h: Ditto.
  • wtf/Int16Array.h: Ditto.
  • wtf/Int32Array.h: Ditto.
  • wtf/Int8Array.h: Ditto.
  • wtf/MathExtras.h: Remove a quirk needed for RVCT version <= 3.0.
  • wtf/Platform.h: Remove test for RVCT 4.0. Remove OS(RVCT).
  • wtf/StringExtras.cpp: Removed.
  • wtf/StringExtras.h: Remove a quirk introduced for RVCT version < 4.0.
  • wtf/Uint16Array.h: Remove a quirk introduced for RVCT version <= 2.2.
  • wtf/Uint32Array.h: Ditto.
  • wtf/Uint8Array.h: Ditto.
  • wtf/Uint8ClampedArray.h: Ditto.
3:11 PM Changeset in webkit [143060] by esprehn@chromium.org
  • 6 edits
    2 adds in trunk

RenderQuote should not mark renderers as needing layout during layout
https://bugs.webkit.org/show_bug.cgi?id=109876

Reviewed by Ojan Vafai.

Source/WebCore:

Marking RenderQuotes as needing pref width recalcs and layouts during a
layout is dangerous since an ancestor may mark itself as having completed
layout, but then some subtree still thinks it needs layout.

Instead, since the only time we create RenderQuote instances is inside
PseudoElement, we can call attachQuote inside PseudoElement::attach during
the regular tree mutating cycle. We can then use RenderQuote::styleDidChange
to update the kind of quotes on normal style changes.

This makes RenderQuote behave much more similarly to DOM nodes and means
we no longer need to set dirty bits during layout.

Test: fast/css-generated-content/quote-layout-focus-crash.html

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::attach): Now call attachQuote().

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateText):
(WebCore::RenderQuote::attachQuote):
(WebCore::RenderQuote::detachQuote):
(WebCore::RenderQuote::updateDepth):

  • rendering/RenderQuote.h:

(RenderQuote):

LayoutTests:

  • fast/block/float/float-not-removed-from-pre-block-expected.txt:
  • fast/css-generated-content/quote-layout-focus-crash-expected.txt: Added.
  • fast/css-generated-content/quote-layout-focus-crash.html: Added.
3:07 PM Changeset in webkit [143059] by roger_fong@apple.com
  • 1 edit in trunk/Tools/EWSTools/start-queue-win.sh

Unreviewed. Modify Win EWS script.

3:07 PM Changeset in webkit [143058] by sadrul@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add myself (sadrul@chromium.org) as committer.

2:57 PM Changeset in webkit [143057] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG SpeculativeJIT64 should be more precise about when it's dealing with a cell (even though it probably doesn't matter)
https://bugs.webkit.org/show_bug.cgi?id=109625

Reviewed by Mark Hahnenberg.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compile):

2:49 PM Changeset in webkit [143056] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142492

document.write during window.onload can trigger DumpRenderTree to dump the render tree
https://bugs.webkit.org/show_bug.cgi?id=109465

Reviewed by Eric Seidel.

Source/WebCore:

This patch is a partial revert of
http://trac.webkit.org/changeset/142378. It's not safe to call
checkComplete during the load event. We'll need to find another way of
calling checkComplete at the right time.

Test: fast/parser/document-write-during-load.html

  • dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

LayoutTests:

  • fast/parser/document-write-during-load-expected.txt: Added.
  • fast/parser/document-write-during-load.html: Added.

TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/12287016

2:48 PM Changeset in webkit [143055] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Stub out SharedBuffer version of get()
https://bugs.webkit.org/show_bug.cgi?id=108993

Reviewed by Darin Fisher.

All asynchronous get()-like calls go through WebIDBCallbacks,
so this includes both get() and cursor callbacks.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onSuccess):
(WebKit::WebIDBCallbacks::onSuccessWithPrefetch):

2:47 PM Changeset in webkit [143054] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r143044.
http://trac.webkit.org/changeset/143044
https://bugs.webkit.org/show_bug.cgi?id=109974

broke windows build (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/Element.cpp:

(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):

  • dom/Element.h:

(WebCore::ShareableElementData::immutableAttributeArray):
(ShareableElementData):
(WebCore::ElementData::attributeItem):

2:41 PM Changeset in webkit [143053] by jamesr@google.com
  • 11 edits in branches/chromium/1410/Source/WebCore

Revert 140571

https://bugs.webkit.org/show_bug.cgi?id=107628
Sometimes scroll position is jerky during rubber-band, affects nytimes.com
-and corresponding-
<rdar://problem/12679549>

Reviewed by Simon Fraser.

The basic problem here is that isRubberBandInProgress() was only implemented for
main thread scrolling. So when we were actually scrolling on the scrolling thread,
that function would always return false regardless.

New ScrollableArea virtual function isRubberBandInProgress() will allow us to ask
the ScrollingCoordinator when the scrolling thread is scrolling, or the
ScrollAnimator otherwise.

  • page/FrameView.cpp:

(WebCore::FrameView::isRubberBandInProgress):

  • page/FrameView.h:

(FrameView):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::isRubberBandInProgress):

New ScrollingCoordinator function isRubberBandInProgress() always returns false
for non-Mac ports, and is overridden in ScrollingCoordinatorMac to consult the
ScrollingTree.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::isRubberBandInProgress):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::isRubberBandInProgress):

New variable m_mainFrameIsRubberBanding keeps track of whether there is currently
a rubber-band happening on the scrolling thread.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::isRubberBandInProgress):
(WebCore::ScrollingTree::setMainFrameIsRubberBanding):

  • page/scrolling/ScrollingTree.h:

(ScrollingTree):
(WebCore::ScrollingTree::rootNode):

Call setMainFrameIsRubberBanding() whenever the stretchAmount is calculated and
whenever we stop the rubber-band timer.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::stretchAmount):
(WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer):

Consult FrameView for isRubberBandInProgress().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

TBR=jamesr@chromium.org
BUG=173009
Review URL: https://codereview.chromium.org/12279017

2:27 PM Changeset in webkit [143052] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Make most ArgumentEncoder::encode member functions private
https://bugs.webkit.org/show_bug.cgi?id=109973

Reviewed by Sam Weinig.

Make the encode overloads private; the stream operator should be used instead.

  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments1::encode):
(CoreIPC::Arguments2::encode):
(CoreIPC::Arguments3::encode):
(CoreIPC::Arguments4::encode):
(CoreIPC::Arguments5::encode):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments10::encode):

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):

  • Platform/CoreIPC/MessageEncoder.cpp:

(CoreIPC::MessageEncoder::MessageEncoder):

  • Scripts/webkit2/messages.py:

(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::EncoderAdapter):
(WebKit::EncoderAdapter::encodeBytes):
(WebKit::EncoderAdapter::encodeBool):
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit::EncoderAdapter::encodeUInt32):
(WebKit::EncoderAdapter::encodeUInt64):
(WebKit::EncoderAdapter::encodeInt32):
(WebKit::EncoderAdapter::encodeInt64):
(WebKit::EncoderAdapter::encodeFloat):
(WebKit::EncoderAdapter::encodeDouble):
(WebKit::EncoderAdapter::encodeString):

2:14 PM Changeset in webkit [143051] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

Enable the preload scanner on the background parser thread
https://bugs.webkit.org/show_bug.cgi?id=108027

Reviewed by Tony Gentilcore.

The patch causes us to pass all the fast/preloader tests with the
threaded parser enabled.

This patch wires up the BackgroundHTMLParser to the
TokenPreloadScanner. Currently, we bail out of preload scanning if we
encounter a document.write becaues we don't know how to rewind the
preload scanner, but that's something we can tune in the future.

The BackgroundHTMLParser delivers the preloads to the
HTMLDocumentParser together with the token stream. If the
HTMLDocumentParser isn't able to use the token stream immediately, it
kicks off the preloads.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::checkThatPreloadsAreSafeToSendToAnotherThread):
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

  • html/parser/BackgroundHTMLParser.h:

(Configuration):

  • We need to add a struct for the create function because the number of arguments exceeds the limits of Functional.h.

(BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::create):

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

  • We need to use a new string here so that the string is safe to send to another thread.
  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::startBackgroundParser):

  • Following the example of the XSSAuditor, we create the TokenPreloadScanner on the main thread and then send it to the background thread for operation.
  • html/parser/HTMLDocumentParser.h:

(WebCore):
(ParsedChunk):

  • html/parser/HTMLParserOptions.h:

(HTMLParserOptions):

  • We need to add a default constructor so that the HTMLDocumentParser can create an empty BackgroundHTMLParser::Configuration struct.
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::isSafeToSendToAnotherThread):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore):

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::PreloadRequest):
(WebCore):
(HTMLResourcePreloader):

2:01 PM Changeset in webkit [143050] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Add a synchronous GetValues message to StorageManager
https://bugs.webkit.org/show_bug.cgi?id=109968

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
Handle synchronous messages.

(CoreIPC::Connection::processIncomingMessage):
Check for work queue message receivers before doing any other processing.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getValues):
Add empty stub.

  • UIProcess/Storage/StorageManager.h:
  • UIProcess/Storage/StorageManager.messages.in:

Add GetValues message.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::loadValuesIfNeeded):
Send the GetValues message.

1:53 PM Changeset in webkit [143049] by Christophe Dumez
  • 5 edits in trunk

Add CString operators for comparison with const char*
https://bugs.webkit.org/show_bug.cgi?id=109947

Reviewed by Darin Adler.

Source/WTF:

Add operators to WTF::CString for equality/inequality comparison
with const char* strings. This avoids constructing a CString
from a const char* in such cases, which is can be expensive as
it would copy it and call strlen().

  • wtf/text/CString.cpp:

(WTF::operator==): Use memcmp instead of strncmp to compare the
CString buffers as we know they are the same size and we don't
want to scan for terminating null byte.
(WTF):

  • wtf/text/CString.h:

(WTF):
(WTF::operator!=):

Tools:

Add tests for WTF::CString's comparison operators.

  • TestWebKitAPI/Tests/WTF/CString.cpp:

(TEST):

1:50 PM Changeset in webkit [143048] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r143030. We need to keep updatedRange around until createMarkupInternal returns.

  • editing/markup.cpp:

(WebCore::createMarkup):

1:48 PM Changeset in webkit [143047] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: fix chromium windows bustage
https://bugs.webkit.org/show_bug.cgi?id=109970

Unreviewed build fix for Chromium Windows.

  • tests/IDBDatabaseBackendTest.cpp:
1:43 PM Changeset in webkit [143046] by commit-queue@webkit.org
  • 23 edits
    10 adds in trunk

Add platform support for -webkit-background-blend-mode to CG context
https://bugs.webkit.org/show_bug.cgi?id=108549

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-15
Reviewed by Dean Jackson.

Source/WebCore:

Tests: css3/compositing/effect-background-blend-mode-stacking.html

css3/compositing/effect-background-blend-mode.html

This patch adds support for blending on background images to the Core Graphics port of WebKit.

  • platform/graphics/CrossfadeGeneratedImage.cpp: Added interface change for blending.

(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h: Added interface change for blending.

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h: Added interface change for blending.

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp: Added interface change for blending.

(WebCore::GeneratorGeneratedImage::drawPattern):

  • platform/graphics/GeneratorGeneratedImage.h: Added interface change for blending.

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp: Added interface change for blending and passes blend mode to image object.

(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::blendModeOperation):
(WebCore):

  • platform/graphics/GraphicsContext.h: Added interface change for blending.

(GraphicsContext):

  • platform/graphics/Image.cpp: Added interface change for blending and passed it to graphics layer.

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h: Added interface change for blending.

(Image):

  • platform/graphics/cg/ImageCG.cpp: Added interface change for blending and passed it to OS.

(WebCore::Image::drawPattern):

  • rendering/RenderBoxModelObject.cpp: Passed blend mode when drawing background images.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • platform/graphics/cairo/ImageCairo.cpp: Added interface change for blending.

(WebCore::Image::drawPattern):

  • platform/graphics/qt/ImageQt.cpp: Added interface change for blending.

(WebCore::Image::drawPattern):

  • platform/graphics/skia/ImageSkia.cpp: Added interface change for blending.

(WebCore::Image::drawPattern):

  • rendering/RenderBoxModelObject.cpp: Added interface change for blending.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • svg/graphics/SVGImageForContainer.cpp: Added interface change for blending.

(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h: Added interface change for blending.

Source/WebKit:

Fixed build issue.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Fixed build issue.

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

Added tests for background images.

  • css3/compositing/effect-background-blend-mode-expected.png: Added.
  • css3/compositing/effect-background-blend-mode-expected.txt: Added.
  • css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
  • css3/compositing/effect-background-blend-mode-stacking-expected.txt: Added.
  • css3/compositing/effect-background-blend-mode-stacking.html: Added.
  • css3/compositing/effect-background-blend-mode.html: Added.
  • css3/compositing/resources/ducky.png: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/css3/compositing: Added.
  • platform/mac/css3/compositing/effect-background-blend-mode-expected.png: Added.
  • platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
1:35 PM Changeset in webkit [143045] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Clamp span value in RenderTableCell::parse[Col|Row]SpanFromDOM
https://bugs.webkit.org/show_bug.cgi?id=109878

Source/WebCore:

Reviewed by Abhishek Arya.

Test: fast/table/colspan-huge-number.html

Clamp colspan and rowspan values to their respective maximum
supported values.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):

LayoutTests:

Reviewed by Abhishek Arya.

Add test for handling of very large colspan value.

  • fast/table/colspan-huge-number-expected.txt: Added.
  • fast/table/colspan-huge-number.html: Added.
1:30 PM Changeset in webkit [143044] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

ShareableElementData should use zero-length array for storage.
<http://webkit.org/b/109959>

Reviewed by Anders Carlsson.

Use a zero-length Attribute array instead of always casting from void* to an array.
It was done this way originally because I didn't know we could sidestep the MSVC
build error with some #pragma hackery.

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/Element.cpp:

(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):

  • dom/Element.h:

(ShareableElementData):
(WebCore::ElementData::attributeItem):

1:18 PM Changeset in webkit [143043] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement RenderGrid::computeIntrinsicLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=109881

Reviewed by Tony Chang.

For now this is not observable due to the FIXMEs for unimplemented bits
of computePreferredLogicalWidths. But, soon, I'll be removing the computePreferredLogicalWidths
override entirely and instead use RenderBlock's, which will also address the
RenderGrid FIXMEs.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
const_cast the usages of m_grid. Alternately, we could stack allocate it, but there's disagreement on
whether that's the right choice. See https://bugs.webkit.org/show_bug.cgi?id=109880.

(WebCore::RenderGrid::computePreferredLogicalWidths):

  • rendering/RenderGrid.h:
1:16 PM Changeset in webkit [143042] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Flexbox should ignore firstLine pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=104485

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-02-15
Reviewed by Tony Chang.

Source/WebCore:

Spec[1] said that "None of the properties defined in this module
apply to '::first-line' or '::first-letter' pseudo-elements." and
css2[2] define "The :first-line pseudo-element can only be attached
to a block container element."
[1]http://dev.w3.org/csswg/css3-flexbox/#display-flex
[2]http://www.w3.org/TR/CSS2/selector.html#first-line-pseudo

tests:
css3/flexbox/flexbox-ignore-firstLine.html
css3/flexbox/flexitem-firstLine-valid.html
css3/flexbox/inline-flexbox-ignore-firstLine.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::firstLineBlock):

LayoutTests:

Spec[1] said that "None of the properties defined in this module
apply to '::first-line' or '::first-letter' pseudo-elements." and
css2[2] define "The :first-line pseudo-element can only be attached
to a block container element."
[1]http://dev.w3.org/csswg/css3-flexbox/#display-flex
[2]http://www.w3.org/TR/CSS2/selector.html#first-line-pseudo

some case by Kenny Lu <kanghaol@oupeng.com>

  • css3/flexbox/flex-item-firstLine-valid-expected.txt: Added.
  • css3/flexbox/flex-item-firstLine-valid.html: Added.
  • css3/flexbox/flexbox-ignore-firstLine-expected.txt: Added.
  • css3/flexbox/flexbox-ignore-firstLine.html: Added.
  • css3/flexbox/inline-flexbox-ignore-firstLine-expected.txt: Added.
  • css3/flexbox/inline-flexbox-ignore-firstLine.html: Added.
1:15 PM Changeset in webkit [143041] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.2/Source

Versioning.

1:11 PM Changeset in webkit [143040] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.2

New Tag.

1:05 PM Changeset in webkit [143039] by mrobinson@webkit.org
  • 5 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out parts of r142731.
http://trac.webkit.org/changeset/142731
https://bugs.webkit.org/show_bug.cgi?id=109672

This patch broke the GTK+ gyp build. Roll out the changes there,
since they were actually unnecessary.

  • gyp/Configuration.gypi.in:
  • gyp/Dependencies.gyp:
  • gyp/JavaScriptCore.gyp:
  • gyp/WTF.gyp:
1:03 PM Changeset in webkit [143038] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

A storage area should know its storage type
https://bugs.webkit.org/show_bug.cgi?id=109964

Reviewed by Andreas Kling.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageNamespaceProxy.cpp:

(WebKit::StorageNamespaceProxy::storageType):
(WebKit):

  • WebProcess/Storage/StorageNamespaceProxy.h:

(StorageNamespaceProxy):

1:01 PM Changeset in webkit [143037] by alecflett@chromium.org
  • 13 edits in trunk/Source

IndexedDB: Implement SharedBuffer version of put()
https://bugs.webkit.org/show_bug.cgi?id=109092

Reviewed by Adam Barth.

Source/WebCore:

Switch IDBDatabaseBackendInterface::put over
to SharedBuffer, to avoid buffer copies of the value.

No new tests, this is a refactor.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::putRecord):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(PutOperation):
(WebCore::IDBDatabaseBackendImpl::put):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

Source/WebKit/chromium:

Implement SharedBuffer/WebData version of
IDBDatabaseBackendInterface::put, and put
temporary scaffolding in until chrome is ready.

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::put):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::put):
(WebKit):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • tests/IDBDatabaseBackendTest.cpp:
12:56 PM Changeset in webkit [143036] by pdr@google.com
  • 28 edits in trunk/LayoutTests

Rebaseline 7 SVG tests after r142765.

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-mac-lion/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-mac/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium/TestExpectations:
12:50 PM Changeset in webkit [143035] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark inspector/profiler/heap-snapshot-get-profile-crash.html flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=109963

Unreviewed gardening.

  • platform/chromium/TestExpectations:
12:49 PM Changeset in webkit [143034] by andersca@apple.com
  • 5 edits in trunk/Source

Implement StorageAreaProxy::length
https://bugs.webkit.org/show_bug.cgi?id=109962

Reviewed by Andreas Kling.

Source/WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::length):
Load the values if needed and then return the length.

(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Add helper function.

(WebKit::StorageAreaProxy::loadValuesIfNeeded):
Just allocate the hash map for now.

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

12:45 PM Changeset in webkit [143033] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

webkit-patch suggest-reviewers should limit itself to 5 reviewers
https://bugs.webkit.org/show_bug.cgi?id=107528

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.suggested_reviewers): Iterate through the sorted commit info list,
scraping reviewers from the commit information and in the end producing a list
of reviewers that's sorted from the most to least recent activity of any reviewer
that has reviewed or authored patches for the changed files.

  • Scripts/webkitpy/tool/commands/queries.py:

(SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
the same logic.
(SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
defaults to False.

  • Scripts/webkitpy/tool/steps/suggestreviewers.py:

(SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
on a single line. Only ask for CC-ing the suggested reviewers to the bug if the
bug ID is located in the command's state.

12:35 PM Changeset in webkit [143032] by aelias@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] WebInputEventBuilders should not reverse page scale
https://bugs.webkit.org/show_bug.cgi?id=109901

Reviewed by James Robinson.

Though in theory logical that if WebInputEvent -> PlatformEvent
conversions divide by page scale, then the reverse builders should
multiply, in reality the only user of the reverse builders is
plugins which expect the same coordinate space as WebCore.

  • src/WebInputEventConversion.cpp:

(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

  • tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):

12:05 PM Changeset in webkit [143031] by andersca@apple.com
  • 10 edits in trunk/Source

Remove const from a bunch of StorageArea member functions
https://bugs.webkit.org/show_bug.cgi?id=109957

Reviewed by Beth Dakin.

Source/WebCore:

StorageArea is an abstract base class, and its subclasses might want to mutate the object
when certain member functions are called so remove const from all member functions.

  • storage/StorageArea.h:

(WebCore):
(StorageArea):
(WebCore::StorageArea::~StorageArea):
(WebCore::StorageArea::incrementAccessCount):
(WebCore::StorageArea::decrementAccessCount):
(WebCore::StorageArea::closeDatabaseIfIdle):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::canAccessStorage):
(WebCore::StorageAreaImpl::length):
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::getItem):
(WebCore::StorageAreaImpl::contains):
(WebCore::StorageAreaImpl::memoryBytesUsedByCache):

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

Source/WebKit/chromium:

Update for WebCore changes.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::length):
(WebCore::StorageAreaProxy::key):
(WebCore::StorageAreaProxy::getItem):
(WebCore::StorageAreaProxy::contains):
(WebCore::StorageAreaProxy::canAccessStorage):
(WebCore::StorageAreaProxy::memoryBytesUsedByCache):

  • src/StorageAreaProxy.h:

(StorageAreaProxy):

Source/WebKit2:

Update for WebCore changes.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::length):
(WebKit::StorageAreaProxy::key):
(WebKit::StorageAreaProxy::getItem):
(WebKit::StorageAreaProxy::contains):
(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::memoryBytesUsedByCache):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

11:59 AM Changeset in webkit [143030] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

DeleteButtonController::enable and disable should be called via a RAII object
https://bugs.webkit.org/show_bug.cgi?id=109550

Reviewed by Enrica Casucci.

Added DeleteButtonControllerDisableScope, a friend class of DeleteButtonController,
and made DeleteButtonController::enable/disable private.

  • dom/ContainerNode.cpp:
  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):

  • editing/DeleteButtonController.h:

(WebCore):
(DeleteButtonController):
(DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope):

  • editing/markup.cpp:

(WebCore::createMarkup):
(WebCore::createFragmentFromNodes):

11:58 AM Changeset in webkit [143029] by pdr@google.com
  • 16 edits in trunk/LayoutTests

Rebaseline 4 svg/zoom/page tests after r142765

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium/TestExpectations:
11:54 AM Changeset in webkit [143028] by mvujovic@adobe.com
  • 7 edits
    6 adds in trunk

Source/WebCore: Add code from other branch.

[CSS Shaders] Parse src property in @-webkit-filter at-rules
https://bugs.webkit.org/show_bug.cgi?id=109770

Reviewed by Dean Jackson.

This patch implements the parsing for the CSS src property in @-webkit-filter at-rules.

The Filter Effects spec [1] specifies its syntax:

src: [ <uri> [format(<string>)]?]#

In practice, it can look like:

src: url(shader.vs) format('x-shader/x-vertex'),

url(shader.fs) format('x-shader/x-fragment');

This src property is similar to the src property in CSS font-face rules, but a little
different. The CSS Fonts spec [2] specifies:

src: [ <uri> [format(<string>#)]? | <font-face-name> ]#
The syntax for a <font-face-name> is a unique font face name enclosed by "local("
and ")".

Unlike the filter src property, the font face src property accepts the local function
[e.g. src: local("SomeFont");]. Also, the font face src property accepts a list of strings
instead of just one string in its format function.

[1]: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-src
[2]: http://www.w3.org/TR/css3-fonts/#src-desc

Tests: css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html

  • css/CSSGrammar.y.in:

Set (and unset) a flag called "m_inFilterRule", which tells us if we are in a
@-webkit-filter at-rule or in a @font-face at-rule when we encounter a src property.
We parse the two variants of the src property separately so that we can create different
objects (WebKitCSSShaderValue vs. CSSFontFaceSrcValue) and because their syntax is a
little different.

  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleSrcUriAndFormat):

Parses a URI and format pair found in the @-webkit-filter src property.

(WebCore::CSSParser::parseFilterRuleSrc):

Parse the @-webkit-filter src property.

  • css/CSSParser.h:

(CSSParser):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::customCssText):

WebKitCSSShaderValue now has an m_format member, which needs to be included in its
cssText.

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):

  • css/WebKitCSSShaderValue.h:

(WebCore::WebKitCSSShaderValue::format):
(WebCore::WebKitCSSShaderValue::setFormat):
(WebKitCSSShaderValue):

LayoutTests: [CSS Shaders] Parse src property in @-webkit-filter at-rules
https://bugs.webkit.org/show_bug.cgi?id=109770

Reviewed by Dean Jackson.

Add positive and negative parsing tests for the @-webkit-filter src property.

  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-invalid.js: Added.

(testInvalidSrcProperty):

  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-valid.js: Added.

(testSrcProperty):

11:54 AM Changeset in webkit [143027] by ggaren@apple.com
  • 4 edits in trunk/Source

Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660

Reviewed by Sam Weinig.

Responding to review comments by Darin Adler.

../JavaScriptCore:

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
in the hash table deleted value because they're meaningless.

../WTF:

  • wtf/HashTraits.h: Added a using directive to simplify client code.
11:53 AM Changeset in webkit [143026] by pdr@google.com
  • 19 edits in trunk/LayoutTests

Rebaseline 4 tests after r142765

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-mac/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png:
  • platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium/TestExpectations:
11:50 AM Changeset in webkit [143025] by pablof@motorola.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
11:47 AM Changeset in webkit [143024] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG AbstractState should filter operands to NewArray more precisely
https://bugs.webkit.org/show_bug.cgi?id=109900

Reviewed by Mark Hahnenberg.

NewArray for primitive indexing types speculates that the inputs are the appropriate
primitives. Now, the CFA filters the abstract state accordingly, as well.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

11:46 AM Changeset in webkit [143023] by pdr@google.com
  • 11 edits
    1 add in trunk/LayoutTests

Rebaseline 3 tests after r142765

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium/TestExpectations:
11:17 AM Changeset in webkit [143022] by roger_fong@apple.com
  • 1 edit
    1 add in trunk/Tools

Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.

  • EWSTools/start-queue-win.sh: Added.
11:15 AM Changeset in webkit [143021] by eric.carlson@apple.com
  • 4 edits in trunk

Crash occurs at WebCore::TextTrackList::length() when enabling closed captions in movie
https://bugs.webkit.org/show_bug.cgi?id=109886

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, media/media-captions.html does not crash with this change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Early return when

m_textTracks is NULL.

LayoutTests:

  • platform/mac/TestExpectations: Remove media/media-captions.html.
11:11 AM Changeset in webkit [143020] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

TokenPreloadScanner should be able to scan CompactHTMLTokens
https://bugs.webkit.org/show_bug.cgi?id=109861

Reviewed by Eric Seidel.

This patch moves the main scanning logic for the TokenPreloadScanner to
a templated scanCommon routine that can scan either an HTMLToken or a
CompactHTMLToken. This patch will let the BackgroundHTMLParser preload
scan its CompactHTMLTokens.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore):
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • Tweak the CSSPreloadScanner API slightly to make it easier to call from templated code.
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(TokenPreloadScanner):

11:06 AM WebKit Team edited by glenn@skynav.com
add myself as committer (diff)
11:06 AM Changeset in webkit [143019] by alexis@webkit.org
  • 10 edits in trunk

WebKit shouldn't accept "none, none" in transition shorthand property.
https://bugs.webkit.org/show_bug.cgi?id=108751

Reviewed by Dean Jackson.

Source/WebCore:

http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property
specifies that if there is more than one transition defined in the
shorthand and any of them has a value of 'none' then the declaration is
invalid. This patch fixes the problem by passing a parsing context to
track if a keyword has been set for the transition-property and if so
then use it to invalidate or not the declaration.

Test: transitions/transitions-parsing.html

  • css/CSSParser.cpp:

(AnimationParseContext):
(WebCore::AnimationParseContext::AnimationParseContext):
(WebCore::AnimationParseContext::commitFirstAnimation): track whether
it's the first <single-transition/animation> or not defined in the
shorthand.
(WebCore::AnimationParseContext::hasCommittedFirstAnimation):
(WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand):
In the shorthand as soon as a keyword has been found then the parsing
is 'finished', if any other animation/transition declaration part of
the shorthand are with a keyword then it's invalid.
(WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed):
(WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword):
(WebCore::AnimationParseContext::sawAnimationPropertyKeyword):
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseAnimationProperty):

  • css/CSSParser.h:

(WebCore):

LayoutTests:

Extend exisiting tests to cover the bug. Modify old tests with invalid declarations.

  • fast/css/transform-inline-style-expected.txt:
  • fast/css/transform-inline-style-remove-expected.txt:
  • fast/css/transform-inline-style-remove.html:
  • fast/css/transform-inline-style.html:
  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:56 AM Changeset in webkit [143018] by akling@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Yarr: Use OwnPtr to make pattern/disjunction/character-class ownership clearer.
<http://webkit.org/b/109218>

Reviewed by Benjamin Poulain.

  • Let classes that manage lifetime of other objects hold on to them with OwnPtr instead of raw pointers.
  • Placed some strategic Vector::shrinkToFit(), ::reserveInitialCapacity() and ::swap().

668 kB progression on Membuster3.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(ByteCompiler):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):
(BytecodePattern):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):

  • yarr/YarrPattern.h:

(JSC::Yarr::PatternDisjunction::addNewAlternative):
(PatternDisjunction):
(YarrPattern):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

10:55 AM Changeset in webkit [143017] by akling@apple.com
  • 2 edits in trunk/Tools

Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.

  • Scripts/webkitpy/common/config/committers.py:
10:33 AM Changeset in webkit [143016] by jdiggs@igalia.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:29 AM Changeset in webkit [143015] by rniwa@webkit.org
  • 2 edits in trunk/Tools

NRWT: ML Debug Test bot is timing out after cleaning up ports
https://bugs.webkit.org/show_bug.cgi?id=109912

Reviewed by Simon Fraser.

Added more debug messgaes to diagnose the issue.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

10:28 AM Changeset in webkit [143014] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

ElementData: Move leafy things out of the base class.
<http://webkit.org/b/109888>

Reviewed by Antti Koivisto.

  • Moved functions for mutating/adding/removing attributes into UniqueElementData. Attempts to modify shared element data will now fail at compile-time.
  • Removed mutableAttributeVector() and have call sites access the vector directly.
  • Move immutableAttributeArray() to ShareableElementData.
  • Move some function bodies from Element.h to Element.cpp since all clients are in there.
  • dom/Element.cpp:

(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::UniqueElementData::addAttribute):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::UniqueElementData::getAttributeItem):
(WebCore::UniqueElementData::attributeItem):

  • dom/Element.h:

(ElementData):
(WebCore::ShareableElementData::immutableAttributeArray):
(ShareableElementData):
(UniqueElementData):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeItem):

10:27 AM Changeset in webkit [143013] by Claudio Saavedra
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:24 AM Changeset in webkit [143012] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
emails on their behalf.

  • Scripts/webkitpy/common/config/committers.py:
10:09 AM WebKit Team edited by jdiggs@igalia.com
adding myself as a committer (diff)
9:53 AM Changeset in webkit [143011] by sudarsana.nagineni@linux.intel.com
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip failing tests on EFL wk1 and wk2 bots.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
9:31 AM Changeset in webkit [143010] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Enable shape-inside support for circles
https://bugs.webkit.org/show_bug.cgi?id=109713

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-15
Reviewed by Dirk Schulze.

Source/WebCore:

Removed the test that disabled circle values for shape-inside.
The remaining support for circles, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.

Test: fast/exclusions/shape-inside/shape-inside-circle.html

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Now only disallows ellipse.

LayoutTests:

Added a test for circle shape-inside values.

  • fast/exclusions/shape-inside/shape-inside-circle-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-circle.html: Added.
9:09 AM Changeset in webkit [143009] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Soup] Leverage new soup_cookie_jar_get_cookie_list() API
https://bugs.webkit.org/show_bug.cgi?id=109931

Reviewed by Kenneth Rohde Christiansen.

In several cases, the CookieJarSoup implementation was retrieving / copying ALL the
cookies using soup_cookie_jar_all_cookies() and then using soup_cookie_applies_to_uri()
to filter out cookies it is not interested in. This was inefficient.

In libsoup 2.40, soup_cookie_jar_get_cookie_list() was introduced to retrieve only the
cookies that apply to a given URI. This patch leverages this new API in CookieJarSoup's
getRawCookies() and deleteCookie(). This way, only the cookies we are interested in
are retrieved and copied. Libsoup does not need to iterate over all the cookies itself
because it keeps the cookies in a hash table using the host names as key.

No new tests, no behavior change.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):
(WebCore::deleteCookie):

9:09 AM Changeset in webkit [143008] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside BatteryProvider and NetworkInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=107821

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-15
Reviewed by Anders Carlsson.

BatteryProvider and NetworkInfoProvider should use C API
instead of accessing the internal C++ classes directly.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):

  • UIProcess/efl/BatteryProvider.h:

(BatteryProvider):

  • UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):

  • UIProcess/efl/NetworkInfoProvider.h:

(NetworkInfoProvider):

9:07 AM Changeset in webkit [143007] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk/Source/WebKit2

[WK2][EFL]REGRESSION (r141978): ewk_view_type_check api test failing
https://bugs.webkit.org/show_bug.cgi?id=109038

Reviewed by Anders Carlsson.

EFL API is defensive by its nature and expects graceful handling of wrong function arguments
whereas webkit implementation code does not. This patch adds new 'toEwkViewChecked' function,
which provides handling of wrong arguments, to be used within EFL API layer code.

  • UIProcess/API/efl/EwkView.cpp:

(toEwkView):

EwkView* toEwkView(const Ewk_View_Smart_Data* smartData) is not exported anymore
as it's used within EwkView class only.

(EwkView::handleTouchMove):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/ewk_view.cpp:

(toEwkViewChecked):

9:05 AM Changeset in webkit [143006] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Added an option to split Elements and Sources sidebars in two panes.
https://bugs.webkit.org/show_bug.cgi?id=109298.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-15
Reviewed by Vsevolod Vlasov.

Introduced the "Split sidebar" context menu option that splits the horizontal sidebar into two panes.
The width split ratio is 1:1 by default and is preserved when the Inspector window is resized.
Elements sidebar is split into two tabbed panes, Sources sidebar is split into a pane stack and a tabbed pane.

No new tests.

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._populateContextMenuForSidebar.toggleSetting):
(WebInspector.ElementsPanel.prototype.get _arrangeSidebarPanes.get this):
(WebInspector.ElementsPanel.prototype.addExtensionSidebarPane):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):
(WebInspector.ScriptsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ScriptsPanel.prototype._populateContextMenuForSidebar.toggleSetting):
(WebInspector.ScriptsPanel.prototype.get _arrangeSidebarPanes.get this):

  • inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarPaneTitle.prototype._expand):
(WebInspector.SidebarPaneTitle.prototype._collapse):
(WebInspector.SidebarPaneTitle.prototype._toggleExpanded):
(WebInspector.SidebarPaneTitle.prototype._onTitleKeyDown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):

  • inspector/front-end/SidebarView.js:
  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype.get mainElement):
(WebInspector.SplitView.prototype.get sidebarElement):

8:53 AM Changeset in webkit [143005] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Several consecutive Backspace or Delete strikes should not be marked as undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109915

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted _isEditRangeUndoBoundary() and _isEditRangeAdjacentToLastCommand() in TextEditorModel
to detect if markUndoableState() call is needed before and after editRange.

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextRange.prototype.immediatelyPrecedes):
(WebInspector.TextRange.prototype.immediatelyFollows):
(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt:
  • inspector/editor/text-editor-undo-redo.html:
8:49 AM Changeset in webkit [143004] by Christophe Dumez
  • 10 edits
    6 deletes in trunk/Source/WebKit2

[EFL][WK2] Have WebView subclass PageClient
https://bugs.webkit.org/show_bug.cgi?id=109684

Reviewed by Anders Carlsson.

Stop constructing the PageClient in EwkView. PageClient is an internal
class and we should not use it directly in our Ewk implementation.
Instead, have WebView subclass PageClient. The PageClient implementation
just calls WebView methods otherwise.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::setSize):

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(EwkView):
(EwkView::webView):

  • UIProcess/API/efl/ewk_view.cpp:
  • UIProcess/efl/PageClientBase.cpp: Removed.
  • UIProcess/efl/PageClientBase.h: Removed.
  • UIProcess/efl/PageClientDefaultImpl.cpp: Removed.
  • UIProcess/efl/PageClientDefaultImpl.h: Removed.
  • UIProcess/efl/PageClientLegacyImpl.cpp: Removed.
  • UIProcess/efl/PageClientLegacyImpl.h: Removed.
  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

  • UIProcess/efl/PageViewportControllerClientEfl.h:
  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::evasObject):
(WebKit::WebView::setThemePath):
(WebKit::WebView::setDrawsBackground):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::createDrawingAreaProxy):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::displayView):
(WebKit::WebView::scrollView):
(WebKit::WebView::viewSize):
(WebKit::WebView::isViewWindowActive):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
(WebKit::WebView::isViewInWindow):
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
(WebKit::WebView::pageClosed):
(WebKit::WebView::toolTipChanged):
(WebKit::WebView::setCursor):
(WebKit::WebView::setCursorHiddenUntilMouseMoves):
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
(WebKit::WebView::screenToWindow):
(WebKit::WebView::windowToScreen):
(WebKit::WebView::doneWithKeyEvent):
(WebKit::WebView::doneWithTouchEvent):
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorChooserProxy):
(WebKit::WebView::setFindIndicator):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::updateAcceleratedCompositingMode):
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
(WebKit::WebView::customRepresentationZoomFactor):
(WebKit::WebView::setCustomRepresentationZoomFactor):
(WebKit::WebView::flashBackingStoreUpdates):
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
(WebKit::WebView::updateTextInputState):
(WebKit::WebView::handleDownloadRequest):
(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

  • UIProcess/efl/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::page):
(WebKit::WebView::canScrollView):

8:26 AM Changeset in webkit [143003] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix inconsistency in WebGLRenderingContext.idl for getAttribLocation
https://bugs.webkit.org/show_bug.cgi?id=109892

Reviewed by Kentaro Hara.

  • html/canvas/WebGLRenderingContext.idl:
8:21 AM Changeset in webkit [143002] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip failing WebGL conformance tests added in r142851.

  • platform/efl-wk2/TestExpectations:
8:12 AM Changeset in webkit [143001] by kov@webkit.org
  • 2 edits in trunk

Unreviewed build fix.

  • Source/autotools/SetupLibtool.m4: Move AR_FLAGS definition so it comes before dolt

and libtool initialization, thus having an effect once again.

7:56 AM Changeset in webkit [143000] by aandrey@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: [Canvas] show replay log grouped by draw calls
https://bugs.webkit.org/show_bug.cgi?id=109592

Reviewed by Pavel Feldman.

Source/WebCore:

Show canvas capturing log grouped by drawing calls.
Drive-by: extended Array.prototype with a handy peekLast function.
Drive-by: removed code dups in few places.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._selectedDrawCallGroupIndex):
(WebInspector.CanvasProfileView.prototype._appendCallNode):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.setColumnVisible):
(WebInspector.DataGridNode.prototype.set hasChildren):
(WebInspector.DataGridNode.prototype.set revealed):
(WebInspector.DataGridNode.prototype.get leftPadding):

  • inspector/front-end/externs.js:

(Array.prototype.peekLast):

  • inspector/front-end/utilities.js:

LayoutTests:

A test to dump canvas replay log.

  • inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt: Added.
  • inspector/profiler/canvas2d/canvas-replay-log-grid.html: Added.
7:47 AM Changeset in webkit [142999] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: highlight record revealed in Timeline
https://bugs.webkit.org/show_bug.cgi?id=109930

Reviewed by Pavel Feldman.

Revealed timeline record is now highlighted with yellow background
that fades out in 2 seconds.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._revealRecord):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._clearRecordHighlight):

  • inspector/front-end/timelinePanel.css:

(.highlighted-timeline-record):
(@-webkit-keyframes timeline_record_highlight):
(to):

7:45 AM Changeset in webkit [142998] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Pass original selection to textModel to correctly restore it after undo.
https://bugs.webkit.org/show_bug.cgi?id=109911

Reviewed by Pavel Feldman.

Source/WebCore:

We can distinguish backspace pressed with and without selection now.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlBackspace):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorCommand):
(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt:
  • inspector/editor/text-editor-undo-redo.html:
7:33 AM Changeset in webkit [142997] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Restore URL Scheme Delegates after QtWebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=108808

When the QtWebProcess crashes, the registered URL Scheme
Delegates are not properly restored over IPC in the newly
launched process instance.

Patch by Milian Wolff <milian.wolff@kdab.com> on 2013-02-15
Reviewed by Simon Hausmann.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::updateSchemeDelegates):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

7:25 AM Changeset in webkit [142996] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Remove redundant requireAuth parameter of NetworkJob::notifyAuthReceived
https://bugs.webkit.org/show_bug.cgi?id=109855

Patch by Joe Mason <jmason@rim.com> on 2013-02-15
Reviewed by Yong Li.

Internal PR: 296697
Internally Reviewed By: Leo Yang

Code cleanup: The requireAuth parameter of NetworkJob::notifyAuthReceived is redundant as its value
can be determined from "result" - if result is AuthResultRetry, requireAuth is false, otherwise it
is true.

No new tests as there is no behaviour change.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

7:03 AM QtWebKitBuildBots edited by Csaba Osztrogonác
(diff)
6:56 AM Changeset in webkit [142995] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium rebaselines for r142947.

  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
6:55 AM Changeset in webkit [142994] by vsevik@chromium.org
  • 4 edits in trunk

Web Inspector: Redo in text editor should always collapse selection to end.
https://bugs.webkit.org/show_bug.cgi?id=109907

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt:
6:53 AM Changeset in webkit [142993] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip failing tests after r142947.

  • platform/efl/TestExpectations:
6:42 AM Changeset in webkit [142992] by atwilson@chromium.org
  • 46 edits
    1 add in trunk/LayoutTests

Unreviewed chromium expectations changes for r142947.

  • platform/chromium-mac-lion/media/audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/controls-after-reload-expected.png:
  • platform/chromium-mac-lion/media/controls-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-without-preload-expected.png:
  • platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Added.
  • platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/video-display-toggle-expected.png:
  • platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium/TestExpectations:
6:38 AM Changeset in webkit [142991] by kadam@inf.u-szeged.hu
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

  • platform/qt/TestExpectations:
  • platform/qt/fast/replaced/width100percent-image-expected.png: Added after r142931.
  • platform/qt/fast/replaced/width100percent-image-expected.txt: Added after r142931.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added after r142931.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added after r142931.
6:20 AM Changeset in webkit [142990] by sudarsana.nagineni@linux.intel.com
  • 5 edits
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaselining after r142931 and r142759.

  • platform/efl/fast/replaced/width100percent-image-expected.png:
  • platform/efl/fast/replaced/width100percent-image-expected.txt:
  • platform/efl/svg/dom/SVGLengthList-basics-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
6:15 AM Changeset in webkit [142989] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] persistent handle dispose before last use
https://bugs.webkit.org/show_bug.cgi?id=109927

Patch by Dan Carney <dcarney@google.com> on 2013-02-15
Reviewed by Jochen Eisinger.

No new tests. No change in functionality.

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::weakCallback):

6:05 AM Changeset in webkit [142988] by keishi@webkit.org
  • 15 edits in trunk/Source

PagePopupController.formatMonth should support short month format
https://bugs.webkit.org/show_bug.cgi?id=109530

Reviewed by Kent Tamura.

Source/WebCore:

PagePopupController.formatMonth should support short month format so we
can use it in the new calendar picker.

Tested by LocaleMacTest::formatMonth.

  • page/PagePopupController.cpp:

(WebCore::PagePopupController::formatMonth): Take an extra bool argument to switch to short month format.

  • page/PagePopupController.h:

(PagePopupController):

  • page/PagePopupController.idl:
  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::shortMonthFormat):
(WebCore):

  • platform/text/LocaleICU.h:

(LocaleICU):

  • platform/text/LocaleNone.cpp:

(WebCore::shortMonthFormat):
(WebCore):

  • platform/text/PlatformLocale.cpp:

(WebCore::DateTimeStringBuilder::visitField):
(WebCore::Locale::formatDateTime):

  • platform/text/PlatformLocale.h:

(Locale):

  • platform/text/mac/LocaleMac.h:

(LocaleMac):

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::shortMonthFormat):
(WebCore):

  • platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::shortMonthFormat): Windows doesn't have a short
month format so we just replace MMMM with MMM.
(WebCore):

  • platform/text/win/LocaleWin.h:

(LocaleWin):

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest::formatMonth):
(TEST_F):

5:36 AM Changeset in webkit [142987] by keishi@webkit.org
  • 21 edits in trunk

Add setValue and closePopup methods to PagePopupController
https://bugs.webkit.org/show_bug.cgi?id=109897

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added mock setValue and closePopup implementation.
  • ManualTests/forms/color-suggestion-picker.html: Ditto.

Source/WebCore:

The new calendar picker (Bug 109439) needs to set a value without
closing the popup. We can't do that with the existing
setValueAndClosePopup.

No new tests. Existing calendar picker and color suggestion picker tests
that closing and setting values work properly.

  • Resources/pagepopups/pickerCommon.js:

(Picker.prototype.submitValue): Stop using setValueAndClosePopup.
(Picker.prototype.handleCancel): Ditto.

  • page/PagePopupClient.h:

(PagePopupClient):

  • page/PagePopupController.cpp:

(WebCore::PagePopupController::setValue): Sets value to element without closing popup.
(WebCore):
(WebCore::PagePopupController::closePopup): Just closes popup.

  • page/PagePopupController.h:

(PagePopupController):

  • page/PagePopupController.idl:

Source/WebKit/blackberry:

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::setValue): Added empty implementation.
(WebCore):

  • WebCoreSupport/ColorPickerClient.h:

(ColorPickerClient):

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValue): Ditto.
(WebCore):

  • WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValue): Ditto.
(WebCore):

  • WebCoreSupport/SelectPopupClient.h:

(SelectPopupClient):

Source/WebKit/chromium:

  • src/ColorChooserPopupUIController.cpp:

(WebKit::ColorChooserPopupUIController::setValue):
(WebKit):

  • src/ColorChooserPopupUIController.h:

(ColorChooserPopupUIController):

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::setValueAndClosePopup): Use setValue and closePopup.
(WebKit):
(WebKit::DateTimeChooserImpl::setValue):
(WebKit::DateTimeChooserImpl::closePopup):

  • src/DateTimeChooserImpl.h:

(DateTimeChooserImpl):

5:18 AM Changeset in webkit [142986] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL WK1 gardening.

EFL WK1 doesn't support WebGL conformance tests which were added by r142847.

  • platform/efl-wk1/TestExpectations: Skipped WebGL conformance tests.
5:04 AM Changeset in webkit [142985] by atwilson@chromium.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

Unreviewed chromium expectations update for r142955.

  • platform/chromium-mac/svg/filters/filter-hidden-content-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-hidden-content-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png.
  • platform/chromium/svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.txt.
5:00 AM Changeset in webkit [142984] by mihnea@adobe.com
  • 10 edits in trunk

[CSS Regions] RenderRegion should inherit from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=74132

Reviewed by Julien Chaffraix.

Source/WebCore:

Change the base class for RenderRegion to be RenderBlock instead of RenderReplaced.
Per spec http://dev.w3.org/csswg/css3-regions/#the-flow-from-property, a region is a non-replaced block container.
This change is covered by the existing regions tests (in fast/region and fast/repaint).

The RenderFlowThread object is a self-painting layer (it requires layer and is positioned).
Because of that, the RenderFlowThread object is responsible for painting its children,
the collected objects. When the RenderRegion::paintObject is called during paint, it delegates painting
of content collected inside the flow thread to the associated RenderFlowThread object.
Since we do not want to paint the flow thread content multiple times (for each paint phase
in which the RenderRegion::paintObject is called), we allow RenderFlowThread painting only for
selection and foreground paint phases.

  • rendering/RenderBox.cpp: Clean-up the code from regions specific stuff, now that the regions are render blocks.

(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderLayerBacking.cpp: A region should always render content from its associated flow thread,

even when it does not have children of its own.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderMultiColumnSet.cpp: Make changes to match the new inheritance for RenderRegion.

(WebCore::RenderMultiColumnSet::paint):
(WebCore::RenderMultiColumnSet::paintColumnRules):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::willBeRemovedFromTree):
(WebCore::RenderRegion::computePreferredLogicalWidths): Use this method instead of min/maxPreferredLogicalWidth.
(WebCore::RenderRegion::updateLogicalHeight):

  • rendering/RenderRegion.h: For now, assume the region is not allowed to have children.

When we will implement the processing model for pseudo-elements http://dev.w3.org/csswg/css3-regions/#processing-model,
we will have to remove this function. By having this function return false i was able to leave some tests unchanged.

LayoutTests:

Fix tests that were failing after the inheritance change.

  • fast/regions/flows-dependency-dynamic-remove.html: As a block, an empty region can self collapse,

which was not possible for a replaced element. I used '-webkit-margin-collapse: separate' to prevent
margins self collapsing for body and avoid recreating the expectations.
I want regions margins to be able to self collapse, just like the other block elements.

  • fast/regions/flows-dependency-same-flow.html: Ditto.
4:30 AM Changeset in webkit [142983] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Web Inspector: implement smart braces functionality
https://bugs.webkit.org/show_bug.cgi?id=109200

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-15
Reviewed by Pavel Feldman.

Source/WebCore:

  • implement SmartBraceController which will handle character insertions

and override them if brace character was inserted. Additionally it
should handle Backspace key and override it if a cursor is located
inside of a bracket pair.

  • guard smart brace functionality via experiment checkbox.

New test: inspector/editor/text-editor-smart-braces.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleKeyPress):
(WebInspector.TextEditorMainPanel.SmartBraceController):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype.registerShortcuts):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype.registerCharOverrides):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleBackspace):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleBracePairInsertion):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleClosingBraceOverride):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

Tools:

Fix eventSender.keyDown implementation to correctly process opening
round brace symbol.

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::keyDown):

LayoutTests:

  • inspector/editor/text-editor-smart-braces-expected.txt: Added.
  • inspector/editor/text-editor-smart-braces.html: Added.
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
4:28 AM Changeset in webkit [142982] by commit-queue@webkit.org
  • 7 edits in trunk

[CSS Regions][Mac] fast/regions/full-screen-video-from-region.html hits an assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=106075

Patch by Andrei Bucur <abucur@adobe.com> on 2013-02-15
Reviewed by Tony Chang.

Source/WebCore:

The crash is caused by two issues.

The first problem is how a block inside a flow thread determines if the children needs relayout or not.
When the region chain is invalidated, the information is lost so we need to return true, even for the
enclosing RenderFlowThread. Because the video renderer is the first child of the flow thread this doesn't
happen.

The patch implements this behaviour by inspecting both if the region chain has changed and
if the block has no range computed yet.

The second problem is RenderMedia not inheriting from RenderBlock. The logic of child relayout doesn't apply
to it. In the test case, when the full screen button is pressed, the region changes width to fill the viewport,
the chain is invalidated and the box info hash map is cleared. When the video is laid out again (after fixing
the first issue) it has the same size so the controls don't do a layout. They remain without box info inside
the flow thread, thus causing the assertion.

The patch forces the controls to relayout if the region chain was invalidated. We can't use the
logicalWidthChangedInRegions method because it is block specific. This will be fixed in a later patch.

Tests: No new tests. fast/regions/full-screen-video-from-region.html no longer crashes.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):

  • rendering/RenderFlowThread.h: Renamed pageLogicalHeightChanged to pageLogicalSizeChanged.
  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

LayoutTests:

Removed the crash/fail expectation for fast/regions/full-screen-video-from-region.html.

  • platform/mac/TestExpectations:
4:25 AM Changeset in webkit [142981] by atwilson@chromium.org
  • 10 edits
    2 copies
    1 move
    1 delete in trunk/LayoutTests

Unreviewed chromium expectation changes after r142931.

  • platform/chromium-mac-lion/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-lion/fast/replaced/width100percent-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-image-expected.txt.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-image-expected.txt.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
  • platform/chromium-win/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt.
4:18 AM Changeset in webkit [142980] by zandobersek@gmail.com
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding expectations for tests that need checking after r142947.
  • platform/gtk/fast/replaced/width100percent-image-expected.txt: Added. Rebaselining after r142931.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Ditto.
4:09 AM Changeset in webkit [142979] by allan.jensen@digia.com
  • 7 edits
    2 adds in trunk

Source/WebCore: [CoordGfx] Regression from r135212: big layers with transform animations sometime fail to render tiles
https://bugs.webkit.org/show_bug.cgi?id=109179

Reviewed by Jocelyn Turcotte.

Fix adjustForContentsRect logic for AC layers that are higher or wider than the visible rect.

Force updates of the visible rect while it is animating, and until we have done one last update after
it stops animating.

Test: compositing/transitions/transform-on-large-layer.html

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

LayoutTests: [CoordGfx] Regression from r135212: big layers with transform animations sometime fail to render tiles.
https://bugs.webkit.org/show_bug.cgi?id=109179

Reviewed by Jocelyn Turcotte.

Test of a large layer with an animated transform. Skipped on WK1 due to resize event not firing in DRT.

  • compositing/transitions/transform-on-large-layer-expected.html: Added.
  • compositing/transitions/transform-on-large-layer.html: Added.
  • platform/mac/TestExpectations:
  • platform/qt-5.0-wk1/TestExpectations:
3:40 AM Changeset in webkit [142978] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r142876.
http://trac.webkit.org/changeset/142876
https://bugs.webkit.org/show_bug.cgi?id=109920

Broke relative URL linkification in the computed styles pane
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

2:46 AM Changeset in webkit [142977] by allan.jensen@digia.com
  • 46 edits in trunk

Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

.:

Reviewed by Julien Chaffraix.

Update exported symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Reviewed by Julien Chaffraix.

The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

(WebCore):
(EventHandler):

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::allowsFrameScrollbars):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::hitTestResultForWindowPos):

Source/WebKit/efl:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/mac:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary):

  • WebView/WebFrame.mm:

(-[WebFrame elementAtPoint:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::hitTestContent):

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::TouchAdjuster::findCandidatePointForTouch):
(QWebPageAdapter::handleSoftwareInputPanel):
(QWebPageAdapter::updatePositionDependentMenuActions):

Source/WebKit/win:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

  • WebKit.vcproj/WebKitExports.def.in:
  • WebView.cpp:

(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

Reviewed by Julien Chaffraix.

Update calls to new API.

  • WebFrame.cpp:

(WebKit::WebFrame::HitTest):

Source/WebKit2:

Reviewed by Julien Chaffraix and Maciej Stachowiak.

Update calls to new API and update exported symbols.

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::hitTest):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

2:37 AM Changeset in webkit [142976] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: make component-based compile-front-end happy
https://bugs.webkit.org/show_bug.cgi?id=109798

Reviewed by Vsevolod Vlasov.

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setVariableValue):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/compile-front-end.py:
  • inspector/front-end/AuditResultView.js:
  • inspector/front-end/CPUProfileView.js:
  • inspector/front-end/DataGrid.js:
  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadTimelineFromURL):

2:29 AM Changeset in webkit [142975] by apavlov@chromium.org
  • 12 edits
    3 adds in trunk

Web Inspector: Implement tracking of active stylesheets in the frontend
https://bugs.webkit.org/show_bug.cgi?id=105828

Reviewed by Pavel Feldman.

Source/WebCore:

  • This change introduces the CSS.styleSheetAdded() and CSS.styleSheetRemoved() events

that update the frontend with all active stylesheet changes in the inspected page.
As such, fetching stylesheet headers from the backend manually is no longer needed,
and many asynchronous methods have been turned into normal accessors.

  • One notable change to the stylesheet binding process is that when a via-inspector stylesheet

is created, it is instantly reported through the instrumentation, and the viaInspectorStyleSheet() method
is [indirectly] called recursively from bindStyleSheet(). Thus, the actual creation and registration
of the respective InspectorStyleSheet have been moved into bindStyleSheet(),
which relies upon the m_creatingViaInspectorStyleSheet flag.

Test: inspector/styles/stylesheet-tracking.html

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Instrumented.

  • inspector/Inspector.json: Add events, update the CSS domain description.
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable): Push all existing stylesheet headers into the frontend.
(WebCore::InspectorCSSAgent::activeStyleSheetsUpdated): Push added/removed stylesheet into the frontend.
(WebCore::InspectorCSSAgent::getAllStyleSheets): Slightly refactored to make use of collectAllStyleSheets().
(WebCore::InspectorCSSAgent::collectAllStyleSheets): Added to collect InspectorStyleSheets rather than headers.
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet): Binds via-inspector stylesheets, too.
(WebCore::InspectorCSSAgent::unbindStyleSheet): Now we can unbind stylesheets upon their removal from the document.
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet): Modifies m_creatingViaInspectorStyleSheet when necessary.
(WebCore::InspectorCSSAgent::detectOrigin): Modified to make use of m_creatingViaInspectorStyleSheet.
(WebCore::InspectorCSSAgent::buildObjectForRule): Removed extraneous bound InspectorStyleSheet 0-check.

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorInstrumentation.cpp: Instrumentation of active stylesheet set updates.

(WebCore::InspectorInstrumentation::activeStyleSheetsUpdatedImpl):

  • inspector/InspectorInstrumentation.h: Ditto.

(WebCore::InspectorInstrumentation::activeStyleSheetsUpdated):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.styleSheetHeaders):
(WebInspector.CSSStyleModel.prototype._styleSheetAdded): Added.
(WebInspector.CSSStyleModel.prototype._styleSheetRemoved): Added.
(WebInspector.CSSStyleModel.prototype.viaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype._setHeaderForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype.resourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype.styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._headerKey): Calculate the (frameID + URL) key for CSSStyleSheetHeader.
(WebInspector.CSSStyleModelResourceBinding.prototype._createInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._inspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
(WebInspector.CSSDispatcher.prototype.styleSheetAdded): Added.
(WebInspector.CSSDispatcher.prototype.styleSheetRemoved): Added.

  • inspector/front-end/SASSSourceMapping.js: Get rid of async implementations.

(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):

  • inspector/front-end/StylesSidebarPane.js: Ditto.

(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

  • inspector/front-end/StylesSourceMapping.js: Ditto.

(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):

LayoutTests:

  • inspector/styles/resources/stylesheet-tracking.css: Added.
  • inspector/styles/stylesheet-tracking-expected.txt: Added.
  • inspector/styles/stylesheet-tracking.html: Added.
2:22 AM Changeset in webkit [142974] by commit-queue@webkit.org
  • 5 edits
    8 adds in trunk

Implement the -webkit-margin-collapse properties correct rendering
https://bugs.webkit.org/show_bug.cgi?id=108168

Patch by Andrei Bucur <abucur@adobe.com> on 2013-02-15
Reviewed by David Hyatt.

Source/WebCore:

The patch implements the correct behavior for the -webkit-margin-collapse properties:

  • a value of "discard" on a margin will truncate all the margins collapsing with it;
  • a value of "separate" will prevent the margin to collapse;
  • a value of "collapse" is the default collapse behavior.

The implementation is aware of multiple writing-modes:

  • if the writing mode of a child is parallel with the writing mode of the container and has the same direction,

the -webkit-margin-collapse properties on the child are left as is;

  • if the writing mode of a child is parallel with the writing mode of the container but has a different direction,

the -webkit-margin-collapse properties on the child are reversed;

  • if the writing mode of a child is perpendicular on the writing mode of the container,

the -webkit-margin-collapse properties on the child are ignored;

  1. The "discard" value implementation

There are two new bits (before and after) added on the RenderBlockRareData structure specifying if the margins
of the block will be discarded or not. We can't rely only on the value from style() because
it's possible a block to discard it's margins because it has collapsed with a children that
specified "discard" for -webkit-margin-collapse. However, the bits are set only if it is
required.
Another bit is added on the MarginInfo structure specifying if the margin has to be discarded or not. When
collapsing at the before side of a block it will hold information if the container block needs to discard
or not. If the collapsing happens between siblings/with after side of the container it will tell if the previous
child discards the margin or not. The self collapsing blocks are a special case. If any of its margins
discards then both its margins discard and all the other margins collapsing with it.
To ensure an optimal behavior it is asserted margin values can't be set on the MarginInfo object if the
discard flag is active. If this happens it may indicate someone ignored the possibility of the margin being
discarded altogether and incorrectly updated the margin values.
Float clearing also needs to change because it may force margins to stop collapsing. If this happens the discard
flags and margins needs to be restored to their values before the collapse.

  1. The "separate" value implementation

The implementation for separate was not changed too much. I've added new accessor methods for the property
that take writing mode into consideration and I've removed some code that didn't work correctly in layoutBlockChild.
The problem was the marginInfo structure was cleared if the child was specifying the "separate" value for before.
This is wrong because you lose the margin information of the previous child/before side.

Tests: fast/block/margin-collapse/webkit-margin-collapse-container.html

fast/block/margin-collapse/webkit-margin-collapse-floats.html
fast/block/margin-collapse/webkit-margin-collapse-siblings-bt.html
fast/block/margin-collapse/webkit-margin-collapse-siblings.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMustDiscardMarginBefore):
(WebCore):
(WebCore::RenderBlock::setMustDiscardMarginAfter):
(WebCore::RenderBlock::mustDiscardMarginBefore):
(WebCore::RenderBlock::mustDiscardMarginAfter):
(WebCore::RenderBlock::mustDiscardMarginBeforeForChild):
(WebCore::RenderBlock::mustDiscardMarginAfterForChild):
(WebCore::RenderBlock::mustSeparateMarginBeforeForChild):
(WebCore::RenderBlock::mustSeparateMarginAfterForChild):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::initMaxMarginValues):
(MarginInfo):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::setCanCollapseMarginAfterWithChildren):
(WebCore::RenderBlock::MarginInfo::setDiscardMargin):
(WebCore::RenderBlock::MarginInfo::discardMargin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(RenderBlockRareData):

  • rendering/style/RenderStyle.h:

LayoutTests:

Four new tests covering the -webkit-margin-collapse property basic behavior: collapsing
between a block container and its children, collapsing between sibling boxes in both TTB
and BTT direction. The last test verifies if a container's before margin correctly resets
the discard value after a clear of the child that initally caused it.

  • fast/block/margin-collapse/webkit-margin-collapse-container-expected.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-container.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-floats-expected.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-floats.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-siblings-bt-expected.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-siblings-bt.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-siblings-expected.html: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-siblings.html: Added.
1:49 AM Changeset in webkit [142973] by jochen@chromium.org
  • 2 edits in trunk/Tools

Speculative build fix for chromium-win.

Unreviewed build fix.

Add declarations of the copy constructor and assignment operator to
WebTestProxyBase, so VS doesn't try to generate them.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1:44 AM Changeset in webkit [142972] by commit-queue@webkit.org
  • 10 edits
    1 delete in trunk

[Qt] Port GCController to JSC C API
https://bugs.webkit.org/show_bug.cgi?id=109690

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-15
Reviewed by Benjamin Poulain.

Source/WebKit/qt:

Add hooks to retrieve JSContextRef and window object.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::getJSWindowObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Rename TestRunner to TestRunnerQt to avoid conflict when
including TestRunner.h in the future.

Replaced QObject based GCController implementation with JSC C API
based one.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::initJSObjects):
(WebCore::methodNameStringForFailedTest):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(WebCore::DumpRenderTree::testRunner):
(DumpRenderTree):

  • DumpRenderTree/qt/GCControllerQt.cpp:

(GCController::getJSObjectCount):

  • DumpRenderTree/qt/GCControllerQt.h: Removed.
  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::TestRunnerQt):
(TestRunnerQt::reset):
(TestRunnerQt::dumpNotifications):
(TestRunnerQt::processWork):
(TestRunnerQt::maybeDump):
(TestRunnerQt::dumpAsText):
(TestRunnerQt::waitUntilDone):
(TestRunnerQt::setViewModeMediaFeature):
(TestRunnerQt::webHistoryItemCount):
(TestRunnerQt::keepWebHistory):
(TestRunnerQt::notifyDone):
(TestRunnerQt::windowCount):
(TestRunnerQt::grantWebNotificationPermission):
(TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
(TestRunnerQt::denyWebNotificationPermission):
(TestRunnerQt::removeAllWebNotificationPermissions):
(TestRunnerQt::simulateWebNotificationClick):
(TestRunnerQt::simulateLegacyWebNotificationClick):
(TestRunnerQt::display):
(TestRunnerQt::displayInvalidatedRegion):
(TestRunnerQt::clearBackForwardList):
(TestRunnerQt::pathToLocalResource):
(TestRunnerQt::dumpEditingCallbacks):
(TestRunnerQt::dumpFrameLoadCallbacks):
(TestRunnerQt::dumpProgressFinishedCallback):
(TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
(TestRunnerQt::dumpResourceLoadCallbacks):
(TestRunnerQt::dumpResourceResponseMIMETypes):
(TestRunnerQt::dumpWillCacheResponse):
(TestRunnerQt::dumpHistoryCallbacks):
(TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
(TestRunnerQt::setWillSendRequestReturnsNull):
(TestRunnerQt::setWillSendRequestClearHeader):
(TestRunnerQt::setDeferMainResourceDataLoad):
(TestRunnerQt::queueBackNavigation):
(TestRunnerQt::queueForwardNavigation):
(TestRunnerQt::queueLoad):
(TestRunnerQt::queueLoadHTMLString):
(TestRunnerQt::queueReload):
(TestRunnerQt::queueLoadingScript):
(TestRunnerQt::queueNonLoadingScript):
(TestRunnerQt::provisionalLoad):
(TestRunnerQt::timerEvent):
(TestRunnerQt::encodeHostName):
(TestRunnerQt::decodeHostName):
(TestRunnerQt::closeWebInspector):
(TestRunnerQt::setDeveloperExtrasEnabled):
(TestRunnerQt::setAsynchronousSpellCheckingEnabled):
(TestRunnerQt::showWebInspector):
(TestRunnerQt::evaluateInWebInspector):
(TestRunnerQt::goBack):
(TestRunnerQt::setDefersLoading):
(TestRunnerQt::setAllowUniversalAccessFromFileURLs):
(TestRunnerQt::setAllowFileAccessFromFileURLs):
(TestRunnerQt::setAppCacheMaximumSize):
(TestRunnerQt::setAutofilled):
(TestRunnerQt::setValueForUser):
(TestRunnerQt::setFixedContentsSize):
(TestRunnerQt::setPrivateBrowsingEnabled):
(TestRunnerQt::setSpatialNavigationEnabled):
(TestRunnerQt::setPopupBlockingEnabled):
(TestRunnerQt::setPluginsEnabled):
(TestRunnerQt::setPOSIXLocale):
(TestRunnerQt::setWindowIsKey):
(TestRunnerQt::setMainFrameIsFirstResponder):
(TestRunnerQt::setJavaScriptCanAccessClipboard):
(TestRunnerQt::setXSSAuditorEnabled):
(TestRunnerQt::dispatchPendingLoadRequests):
(TestRunnerQt::clearAllApplicationCaches):
(TestRunnerQt::clearApplicationCacheForOrigin):
(TestRunnerQt::localStorageDiskUsageForOrigin):
(TestRunnerQt::setApplicationCacheOriginQuota):
(TestRunnerQt::applicationCacheDiskUsageForOrigin):
(TestRunnerQt::originsWithApplicationCache):
(TestRunnerQt::setCacheModel):
(TestRunnerQt::setDatabaseQuota):
(TestRunnerQt::clearAllDatabases):
(TestRunnerQt::addOriginAccessWhitelistEntry):
(TestRunnerQt::removeOriginAccessWhitelistEntry):
(TestRunnerQt::setCustomPolicyDelegate):
(TestRunnerQt::waitForPolicyDelegate):
(TestRunnerQt::overridePreference):
(TestRunnerQt::setUserStyleSheetLocation):
(TestRunnerQt::setCaretBrowsingEnabled):
(TestRunnerQt::setAuthorAndUserStylesEnabled):
(TestRunnerQt::setUserStyleSheetEnabled):
(TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
(TestRunnerQt::callShouldCloseOnWebView):
(TestRunnerQt::setScrollbarPolicy):
(TestRunnerQt::setSmartInsertDeleteEnabled):
(TestRunnerQt::setSelectTrailingWhitespaceEnabled):
(TestRunnerQt::execCommand):
(TestRunnerQt::isCommandEnabled):
(TestRunnerQt::findString):
(TestRunnerQt::markerTextForListItem):
(TestRunnerQt::computedStyleIncludingVisitedInfo):
(TestRunnerQt::elementDoesAutoCompleteForElementWithId):
(TestRunnerQt::authenticateSession):
(TestRunnerQt::setIconDatabaseEnabled):
(TestRunnerQt::setMockDeviceOrientation):
(TestRunnerQt::setGeolocationPermission):
(TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
(TestRunnerQt::setGeolocationPermissionCommon):
(TestRunnerQt::setMockGeolocationPositionUnavailableError):
(TestRunnerQt::setMockGeolocationPosition):
(TestRunnerQt::addMockSpeechInputResult):
(TestRunnerQt::setMockSpeechInputDumpRect):
(TestRunnerQt::startSpeechInput):
(TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
(TestRunnerQt::evaluateScriptInIsolatedWorld):
(TestRunnerQt::addUserStyleSheet):
(TestRunnerQt::removeAllVisitedLinks):
(TestRunnerQt::addURLToRedirect):
(TestRunnerQt::originsWithLocalStorage):
(TestRunnerQt::deleteAllLocalStorage):
(TestRunnerQt::deleteLocalStorageForOrigin):
(TestRunnerQt::observeStorageTrackerNotifications):
(TestRunnerQt::syncLocalStorage):
(TestRunnerQt::resetPageVisibility):
(TestRunnerQt::setPageVisibility):
(TestRunnerQt::setAutomaticLinkDetectionEnabled):
(TestRunnerQt::setTextDirection):
(TestRunnerQt::setAlwaysAcceptCookies):
(TestRunnerQt::setAlwaysBlockCookies):
(TestRunnerQt::setAudioData):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

1:02 AM Changeset in webkit [142971] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/forms/input-text-scroll-left-on-blur.html is passing now
https://bugs.webkit.org/show_bug.cgi?id=109896

Unreviewed efl gardening.

The expectations are added by r140250 and the test seems to be passing now.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-15

  • platform/efl/TestExpectations:
1:00 AM Changeset in webkit [142970] by zherczeg@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

ChangeLog fix for bug 109689.
https://bugs.webkit.org/show_bug.cgi?id=109689

Feb 14, 2013:

11:45 PM Changeset in webkit [142969] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: always show memory size in Mb on the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=109813

Reviewed by Pavel Feldman.

Memory size vlue is alway shown in Mb on the native memory graph.

  • inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):

11:28 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
11:27 PM chooser-only.png attached to EnableFormFeatures by tkent@chromium.org
11:15 PM Changeset in webkit [142968] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebKit2

[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=109885

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-14
Reviewed by Simon Fraser.

Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it
scrollOffset. So this patch corrects this misnaming.

In addition, all subclasses of LayerTreeHost don't use the misnamed
scrollOffset in scrollNonCompositedContents(), so this patch removes the
scrollOffset argument.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scroll):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:

(LayerTreeHostMac):

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::scrollNonCompositedContents):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::scroll):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scroll):

11:01 PM Changeset in webkit [142967] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Use GL typedefs in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=109060

Reviewed by Kenneth Russell.

Use GL typedefs in WebGLRenderingContext.idl according to the specs.
Added a FIXME about inconsistency with the current WebGL spec for getAttribLocation.

Tested manually that generators V8, JS, ObjC, GObject, CPP produce same output.

  • html/canvas/WebGLRenderingContext.idl:
10:41 PM Changeset in webkit [142966] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660

Reviewed by Sam Weinig.

This has a few benefits:

(*) Saves a few kB by removing a second cache data structure.

(*) Reduces the worst case memory usage of the cache by 1.75X. (Heavy
use of 'new Function' and other techniques could cause us to fill
both root caches, and they didn't trade off against each other.)

(*) Paves the way for future improvements based on a non-trivial
cache key (for example, shrinkable pointer to the key string, and
more precise cache size accounting).

Also cleaned up the cache implementation and simplified it a bit.

  • heap/Handle.h:

(HandleBase):

  • heap/Strong.h:

(Strong): Build!

  • runtime/CodeCache.cpp:

(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode): Updated for three interface changes:

(*) SourceCodeKey is a class, not a pair.

(*) Table values are abstract pointers, since they can be executables
or code blocks. (In a future patch, I'd like to change this so we
always store only code blocks. But that's too much for one patch.)

(*) The cache function is named "set" because it always overwrites
unconditionally.

  • runtime/CodeCache.h:

(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear): Added support for specifying hash traits, so we
can use a SourceCodeKey.

Removed side table and random number generator to save space and reduce
complexity. Hash tables are already random, so we don't need another source
of randomness.

(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue): A SourceCodeKey is just a
fancy triplet: source code string; function name (or null, for non-functions);
and flags. Flags and function name distinguish between functions and programs
with identical code, so they can live in the same cache.

I chose to use the source code string as the primary hashing reference
because it's likely to be unique. We can use profiling to choose another
technique in future, if collisions between functions and programs prove
to be hot. I suspect they won't.

(JSC::CodeCache::clear):
(CodeCache): Removed the second cache.

  • heap/Handle.h:

(HandleBase):

  • heap/Strong.h:

(Strong):

  • runtime/CodeCache.cpp:

(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):

  • runtime/CodeCache.h:

(JSC):
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear):
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue):
(JSC::CodeCache::clear):
(CodeCache):

10:39 PM Changeset in webkit [142965] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Copy-pasting selected text over itself should be an undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109830

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt:
  • inspector/editor/text-editor-undo-redo.html:
10:33 PM Changeset in webkit [142964] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a test expectation now that the culprit has been rolled out in r142962.

  • platform/mac/TestExpectations:
10:29 PM Changeset in webkit [142963] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium test fix: incorrect field was used for UISourceCode url.

  • src/js/Tests.js:

(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):

10:26 PM Changeset in webkit [142962] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r142889.
http://trac.webkit.org/changeset/142889
https://bugs.webkit.org/show_bug.cgi?id=109891

It caused an assertion failure in scrollbars/overflow-
scrollbar-combinations.html (Requested by tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::borderWidthChanged):
(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/block/dynamic-padding-border-expected.txt: Removed.
  • fast/block/dynamic-padding-border.html: Removed.
  • fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
10:21 PM Changeset in webkit [142961] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add assertion failure expectations on Mac per bugs 109869 and 109890.

  • platform/mac/TestExpectations:
  • platform/mac-wk2/TestExpectations:
10:06 PM JavaScriptCore edited by fpizlo@apple.com
(diff)
9:59 PM JavaScriptCore slides.pdf attached to JavaScriptCore by fpizlo@apple.com
9:59 PM JavaScriptCore slides.key attached to JavaScriptCore by fpizlo@apple.com
9:59 PM Changeset in webkit [142960] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.
https://bugs.webkit.org/show_bug.cgi?id=106452

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Pressing the down or the right arrow key at the end of a text line in
vertical writing mode would make the caret dissapear. This occurs only
when the text line is followed by an empty block.

When trying to compute the next position for placing the caret (for
down/right key), we try to ascertain whether the renderer (in this
case the empty block) is a valid candidate or not. For blockFlow
elements we check against their height.
In vertical writing mode though we would fail such a check since we
should instead be comparing against the renderer's width and not
it's height. Thus, a valid position for the placement of the caret
was not found in such a case.

Test: editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):
Instead of checking against the height(), check against the
logicalHeight() of the renderer has been added. logicalHeight()
on blockFlow renderer's returns a value in accordance with
the writing mode.

LayoutTests:

  • editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt: Added.
  • editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html: Added.

Layout test case added for verifying that pressing the down or the right arrow
key at the end of the text line in vertical writing mode will not make the caret
dissapear.
Caret positions at the start, the end, and after pressing the right and the down
arrow keys at the end of the text line, are compared for verification.

9:55 PM Changeset in webkit [142959] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix after r142957.

  • dom/DOMAllInOne.cpp:
9:54 PM JavaScriptCore edited by fpizlo@apple.com
(diff)
9:53 PM JavaScriptCore edited by fpizlo@apple.com
(diff)
9:47 PM Changeset in webkit [142958] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a typo introduced in r142705.

Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.
e.g. "run-webkit-tests platform/mac/editing/deleting/deletionUI-single-instance.html

platform/mac/editing/input/text-input-controller.html --child-processes=1"

  • editing/Editor.cpp:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

9:47 PM JavaScriptCore edited by fpizlo@apple.com
(diff)
8:38 PM Changeset in webkit [142957] by hayato@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Factor Event retargeting code.
https://bugs.webkit.org/show_bug.cgi?id=109156

Reviewed by Dimitri Glazkov.

To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent,
but also other events.

New class, EventRetargeter, was introduced. From now,
EventDispatchMediator (and its subclasses) should call, if event
retargeting is required, an appropriate function provided in
EventRetargeter rather than calling
EventDispatcher::adjustRelatedTarget(), which was removed in this
patch.

No tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventDispatchMediator.cpp:
  • dom/EventDispatcher.cpp:

(WebCore):
(WebCore::EventDispatcher::ensureEventPath): Changed to return an EventPath, which will be used by EventRetargeter.
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:

(WebCore):
(EventDispatcher):

  • dom/EventRetargeter.cpp: Added.

(WebCore):
(WebCore::inTheSameScope):
(WebCore::determineDispatchBehavior):
(WebCore::EventRetargeter::calculateEventPath): Factored out from EventDispatcher::ensureEventPath().
(WebCore::EventRetargeter::adjustForMouseEvent):
(WebCore::EventRetargeter::adjustForFocusEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::buildRelatedNodeMap): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::findRelatedNode):

  • dom/EventRetargeter.h: Added.

(WebCore):
(EventRetargeter):
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForFocusEvent().
(WebCore::BlurEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusInEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusOutEventDispatchMediator::dispatchEvent): Ditto.

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForMouseEvent().

8:28 PM Changeset in webkit [142956] by Simon Fraser
  • 6 edits
    4 deletes in trunk

Reverting r142861. Hit testing inside of style recalc is fundamentally wrong

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):

  • page/EventHandler.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):
(WebCore::areNonIdenticalCursorListsEqual):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::styleDidChange):

LayoutTests:

  • fast/events/mouse-cursor-change-expected.txt: Removed.
  • fast/events/mouse-cursor-change.html: Removed.
  • fast/events/mouse-cursor-no-mousemove-expected.txt: Removed.
  • fast/events/mouse-cursor-no-mousemove.html: Removed.
  • platform/mac/TestExpectations:
7:58 PM Changeset in webkit [142955] by fmalita@chromium.org
  • 11 edits
    3 adds in trunk

[SVG] Cached filter results are not invalidated on repaint rect change
https://bugs.webkit.org/show_bug.cgi?id=106221

Reviewed by Dean Jackson.

Source/WebCore:

Since the cached filter results are not invalidated for different repaint rects, we need
to render the content of the whole filter region upfront (otherwise elements not visible
during the initial paint due to scrolling/window size/etc. are never redrawn).

Tests: svg/filters/filter-hidden-content-expected.svg

svg/filters/filter-hidden-content.svg

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::drawingRegion):
(WebCore):

  • rendering/svg/RenderSVGResourceFilter.h:

(FilterData):
(RenderSVGResourceFilter):
Track the filter drawing region in FilterData.

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

Update paintInfo.rect to cover the whole drawing region while rendering filter content, and
restore it when done.

LayoutTests:

  • svg/filters/filter-hidden-content-expected.svg: Added.
  • svg/filters/filter-hidden-content.svg: Added.
7:57 PM Changeset in webkit [142954] by roger_fong@apple.com
  • 19 edits in trunk

Unreviewed. Some final touch-ups to the VS2010 WebKit solution before nuking the VS2005 solution.
Remove un-needed include directories and force includes.
Update exports file.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebKit.vcxproj/common.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
  • win/record-memory/record-memoryCommon.props:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
  • JavaScriptCore.vcxproj/jsc/jscCommon.props:
  • JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
  • JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
  • WTF.vcxproj/WTFCommon.props:
7:07 PM Changeset in webkit [142953] by morrita@google.com
  • 2 edits
    1 copy in trunk/LayoutTests

Unreviewed rebaselining following r142940.

  • fast/events/onerror-no-constructor-expected.txt:
  • platform/chromium/fast/events/onerror-no-constructor-expected.txt: Copied from LayoutTests/fast/events/onerror-no-constructor-expected.txt.
6:38 PM Changeset in webkit [142952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Correct the mismatched cursor map
https://bugs.webkit.org/show_bug.cgi?id=109655

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-14
Reviewed by Laszlo Gombos.

Correct the mismatched ECORE_X_CURSOR values in the cursor map.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::CursorMap::CursorMap):

6:07 PM Changeset in webkit [142951] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::anyAttribute):
(WebDOMTestObj::setAnyAttribute):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_any_attribute):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcWithClampCallback):

6:02 PM Changeset in webkit [142950] by kareng@chromium.org
  • 1 edit in trunk/Tools/ChangeLog

adding myself as a committer

6:00 PM Changeset in webkit [142949] by kareng@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

adding myself as a committer

5:42 PM Changeset in webkit [142948] by roger_fong@apple.com
  • 1 edit in trunk/Source/WebCore/Modules/webdatabase/SQLTransactionStateMachine.cpp

Commented out code meant to be deleted.

5:39 PM Changeset in webkit [142947] by commit-queue@webkit.org
  • 158 edits in trunk

Convert media controls from DeprecatedFlexibleBox to FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109775

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-14
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests in media/.

  • css/mediaControls.css:
  • css/mediaControlsBlackBerry.css:
  • css/mediaControlsChromium.css:
  • css/mediaControlsChromiumAndroid.css:
  • css/mediaControlsEfl.css:
  • css/mediaControlsGtk.css:
  • css/mediaControlsQt.css:
  • css/mediaControlsQuickTime.css:

Automated search and replace of old flexbox CSS rules to new ones.
Minor tuning of the chromium rules.

  • rendering/RenderMediaControlElements.cpp:

(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderMediaControlTimeDisplay::layout):

  • rendering/RenderMediaControlElements.h:

Make media controls inherit from RenderFlexibleBox

LayoutTests:

Rebaselined lots of tests. There were two kinds of changes:

  • Replaced the RenderDeprecatedFlexibleBox class name with

RenderFlexibleBox, and minor printing differences

  • Slight positioning/size changes due to a different algorithm for

shrinking elements (old flexbox shrinks elements evenly, new flexbox
shrinks in proportion to the size of the flex item)

5:28 PM Changeset in webkit [142946] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for Windows.

  • Modules/webdatabase/SQLTransactionStateMachine.cpp:

(WebCore::nameForSQLTransactionState):

5:23 PM Changeset in webkit [142945] by rniwa@webkit.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Mac rebaseline after r142931.

  • platform/chromium-mac/fast/replaced/width100percent-image-expected.txt: Added.
  • platform/chromium/fast/replaced/width100percent-image-expected.txt: Removed.
  • platform/mac/fast/replaced/width100percent-image-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
5:19 PM Changeset in webkit [142944] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Inspector doesn't show rules from pluginsStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=109872

Reviewed by Darin Adler.

Make sure getWrapperForRuleInSheets collects the rules
from CSSDefaultStyleSheets::plugInsStyleSheet.

Making a test for this is difficult because the rules in
this sheet only apply to snapshotted plugins at the moment,
which are disabled in DRT, and would require a fairly long
timeout in the test.

  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):

5:19 PM Changeset in webkit [142943] by dino@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648

Unreviewed. Adding the files I forgot to commit in r142774.

  • media/video-controls-captions-trackmenu-hide-on-click.html: Added.
  • platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
5:01 PM Changeset in webkit [142942] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Recover edge names used in MemoryInstrumentation for DocumentRuleSets.
https://bugs.webkit.org/show_bug.cgi?id=109800

Reviewed by Hajime Morita.

This is a following patch for r142573.
r142563 accidentally removes edge names for MemoryInstrumentation. We should recover edge names.

No tests. No change in behavior.

  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::reportMemoryUsage):

4:56 PM Changeset in webkit [142941] by commit-queue@webkit.org
  • 18 edits
    1 add in trunk

new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
https://bugs.webkit.org/show_bug.cgi?id=37565

Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
is LayoutTests/TestExpectations.

Patch by Glenn Adams <glenn@skynav.com> on 2013-02-14
Reviewed by Dirk Pranke.

Tools:

  • Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:

(FakePort.path_to_generic_test_expectations_file):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_generic_test_expectations_file):
(Port):
(Port._port_specific_expectations_files):
(Port.expectations_files):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._port_specific_expectations_files):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._port_specific_expectations_files):

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_expectations_files):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._port_specific_expectations_files):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._port_specific_expectations_files):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest.test_expectations_files):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._port_specific_expectations_files):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_expectations_ordering):
(test_expectations_files):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._port_specific_expectations_files):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_expectations_files):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_expectations_files):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_paths):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):

LayoutTests:

4:42 PM Changeset in webkit [142940] by morrita@google.com
  • 3 edits
    2 adds in trunk

[V8] Assertion failure on an exception is thrown
https://bugs.webkit.org/show_bug.cgi?id=109129

Source/WebCore:

An assertion in V8AbstractEventListener is wrong. This change turns it into an error check.

Reviewed by Kentaro Hara.

Test: fast/events/onerror-no-constructor.html

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::handleEvent):

LayoutTests:

Reviewed by Kentaro Hara.

  • fast/events/onerror-no-constructor-expected.txt: Added.
  • fast/events/onerror-no-constructor.html: Added.
4:38 PM Changeset in webkit [142939] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] CodeGeneratorV8.pm can assume that DOMWindow has [CheckSecurity]
https://bugs.webkit.org/show_bug.cgi?id=109788

Reviewed by Adam Barth.

There is code like this:

if ($extendedAttr{"CheckSecurity"}
$interfaceName eq "DOMWindow")

This check is redundant. DOMWindow has [CheckSecurity]. We can remove the
DOMWindow check.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

4:36 PM Changeset in webkit [142938] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] IndexedDB: Remove unused creationContext paramter from idbKeyToV8Value
https://bugs.webkit.org/show_bug.cgi?id=109870

Reviewed by Kentaro Hara.

This parameter was left over from when the function was toV8(IDBKey). Remove it.

No new tests - just removing dead code.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::idbKeyToV8Value): Remove unused parameter.
(WebCore::injectIDBKeyIntoScriptValue): No need for dummy handle.
(WebCore::idbKeyToScriptValue): No need for dummy handle.

4:35 PM Changeset in webkit [142937] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL][Qt] regression:r142786 Qt Build fix for Arm and Windows.
https://bugs.webkit.org/show_bug.cgi?id=109797

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-14
Reviewed by Csaba Osztrogonác.

After r142786, we use OpenGLShims to load necessary GL functions
exposed by ARB_vertex_array_object extension. Qt uses OpenGLShims
to load functions with GLES too. This patch adds support for loading the
equivalent functions on GLES exposed by OES_vertex_array_object.

  • platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h:
4:27 PM Changeset in webkit [142936] by ap@apple.com
  • 8 edits in trunk/Source/WebCore

<rdar://problem/13210723> CORS preflight broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=109753

Reviewed by Brady Eidson.

  • loader/DocumentThreadableLoader.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::cancel): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::dataReceived): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::notifyFinished): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::preflightFailure): Notify InspectorInstrumentation immediately. In addition to keeping up eith other changes, this means that an accurate error will be passed now, not a cancellation. (WebCore::DocumentThreadableLoader::loadRequest): Get rid of m_preflightRequestIdentifier. Every loader has an identifier, and tracking identifiers twice is wrong. Pass identifier explicitly to more internal functions, so that they would not have to second-guess callers.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): Create an identifier for all loaders, not just those that we expect to have client callbacks about. Both Inspector and NetworkProcess need identifiers everywhere.
  • loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource):
  • loader/TextTrackLoader.h:
  • loader/cache/CachedResourceClient.h: (WebCore::CachedResourceClient::deprecatedDidReceiveCachedResource):
  • loader/cache/CachedTextTrack.cpp: (WebCore::CachedTextTrack::data): Renamed didReceiveData to avoid conflict with the new DocumentThreadableLoader::didReceiveData. And we should really get rid of this CachedResourceClient function anyway.
4:25 PM Changeset in webkit [142935] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

Replace 'DOMObject' with 'any'
https://bugs.webkit.org/show_bug.cgi?id=109793

Reviewed by Dimitri Glazkov.

In the Web IDL spec, there is no type named 'DOMObject'.
It should be 'any'. We should replace all 'DOMObject's in WebKit IDLs with 'any's.

  • Modules/webdatabase/SQLResultSetRowList.idl:
  • bindings/scripts/CodeGeneratorCPP.pm:

(GetClassName):
(AddIncludesForType):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateImplementation):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeType):
(JSValueToNative):
(GetV8HeaderName):

  • dom/CustomEvent.idl:
  • dom/MessageEvent.idl:
  • dom/PopStateEvent.idl:
  • fileapi/FileReader.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLElement.idl:
  • html/canvas/DataView.idl:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorFrontendHost.idl:
  • inspector/JavaScriptCallFrame.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
4:17 PM Changeset in webkit [142934] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove GenerateEventListenerCallback() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=109786

Reviewed by Adam Barth.

Some code is duplicated between GenerateEventListenerCallback()
and GenerateFunctionCallback(). By inlining GenerateEventListenerCallback()
into GenerateFunctionCallback(), we can remove the duplication.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

4:16 PM Changeset in webkit [142933] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/13161700> REGRESSION: Safari is unable to make SSL connections
when running from recovery partition

Reviewed by Sam Weinig.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in: Re-added /private/var/db/mds/system rules lost in r141445.
4:08 PM Changeset in webkit [142932] by pdr@google.com
  • 41 edits
    1 delete in trunk/LayoutTests

Rebaseline 9 SVG tests after r142765

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-win-xp/svg/as-background-image: Removed.
  • platform/chromium-win-xp/svg/as-background-image/svg-as-background-1-expected.png: Removed.
  • platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium/TestExpectations:
3:58 PM Changeset in webkit [142931] by ojan@chromium.org
  • 10 edits
    2 adds in trunk

Intrinsic and preferred widths on replaced elements are wrong in many cases
https://bugs.webkit.org/show_bug.cgi?id=109859

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/replaced/preferred-widths.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
Separate out computing the intrinsic widths. Eventually,
we should be able to share computePreferredLogicalWidth implementations
for all replaced elements and form controls since only the intrinsic width
changes.

(WebCore::RenderReplaced::computePreferredLogicalWidths):
-Apply min-width and max-width constraints and then add borderAndPaddingLogicalWidth
at the end to make sure it's always applied. This matches all our other
computePreferredLogicalWidths override and makes use match Gecko's/Opera's rendering.
-Only set the minPreferredLogicalWidth to 0 if the width or max-width is a percent value.
Doing it for height values and for min-width doesn't make any sense and doesn't
match other browsers. Doing this for max-width still doesn't match other browsers,
but it sounds like Gecko at least would like to change that.

  • rendering/RenderReplaced.h:

(WebCore::RenderReplaced::hasRelativeIntrinsicLogicalWidth):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::hasRelativeIntrinsicLogicalWidth):
Add a way to check if the logicalWidth is relative so that we only check
the width in computePreferredLogicalWidths instead of also checking the height.

  • rendering/svg/RenderSVGRoot.h:

LayoutTests:

  • fast/replaced/preferred-widths-expected.txt: Added.
  • fast/replaced/preferred-widths.html: Added.

These results match Gecko and Opera except for the 3rd container div.
Talking to dbaron and bz and Mozilla they sound likely to match our behavior there.
See https://bugzilla.mozilla.org/show_bug.cgi?id=823483 for example.

The width of the containers is wrong in some of these cases because our
computePreferredLogicalWidths methods don't currently account for
intrinsic sizes (e.g. min-content, max-content, etc).

  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-image-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

These new results are more correct. The width100percent-image case now
matches other browsers and is due to not setting the minPreferrredLogicalWidth to
0 if the height is a percentage. The bugs85016 case is different because we
now correctly add the border and padding width to the preferred width of the image.

3:51 PM Changeset in webkit [142930] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a crash test expectation to media/media-captions.html on Mac per bug 109869.

  • platform/mac/TestExpectations:
3:49 PM Changeset in webkit [142929] by jochen@chromium.org
  • 15 edits in trunk/Tools

[chromium] move pixel generation logic to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109686

Reviewed by Stephen White.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::proxy):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebTestRunner):
(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::setWebView):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::display):
(WebTestRunner::TestRunner::displayInvalidatedRegion):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::setWebView):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::capturePixels):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::paintRect):
(WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
(WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
(WebTestRunner::WebTestProxyBase::canvas):
(WebTestRunner::WebTestProxyBase::displayRepaintMask):
(WebTestRunner::WebTestProxyBase::display):
(WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
(WebTestRunner::WebTestProxyBase::discardBackingStore):
(WebTestRunner::WebTestProxyBase::setWindowRect):
(WebTestRunner::WebTestProxyBase::userMediaClient):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::showDevTools):
(TestShell::closeDevTools):
(TestShell::dump):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::reset):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

3:45 PM Changeset in webkit [142928] by schenney@chromium.org
  • 4 edits
    2 adds in trunk

Crash when selecting a HarfBuzz text run with SVG fonts included
https://bugs.webkit.org/show_bug.cgi?id=109833

Reviewed by Tony Chang.

Source/WebCore:

There is an assert in SimpleFontData::applyTransforms that should not
be there, as the code is valid for SVG fonts. If we get past this,
then the HarfBuzz text run shaping code assumes that font data has a
SkTypeface member, and SVG fonts do not. So we crash there too.

For now, we fix the crashes. This still leaves incorrect selection
rectangles in this situation, on all platforms, tracked in
https://bugs.webkit.org/show_bug.cgi?id=108133

Test: svg/css/font-face-crash.html

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.

LayoutTests:

Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.

  • svg/css/font-face-crash-expected.txt: Added.
  • svg/css/font-face-crash.html: Added.
3:42 PM Changeset in webkit [142927] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] No triggering autofill on unfocus
https://bugs.webkit.org/show_bug.cgi?id=109735

Patch by David Trainor <dtrainor@chromium.org> on 2013-02-14
Reviewed by James Robinson.

Need to notify the autofill client to not process text changes when we're setting
focus to false and are trying to commit a composition.

  • public/WebAutofillClient.h:

(WebAutofillClient):
(WebKit::WebAutofillClient::setIgnoreTextChanges):
(WebKit::WebAutofillClient::~WebAutofillClient):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):

  • tests/WebViewTest.cpp:
3:14 PM Changeset in webkit [142926] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[BlackBerry] Notify platform layer of failing to get authentication credentials
https://bugs.webkit.org/show_bug.cgi?id=109751

Patch by Joe Mason <jmason@rim.com> on 2013-02-13
Reviewed by Yong Li.
Reviewed internally by Leo Yang
Internal PR: 181302

The BlackBerry platform network layer needs to know if a stream failed to get authentication credentials.
This patch is using newly added stream API to do it.

No functionality changed no new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):

  • platform/network/blackberry/NetworkJob.h:
  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::protectionSpaceToPlatformAuth):
(WebCore):
(WebCore::setAuthCredentials):

  • platform/network/blackberry/NetworkManager.h:

(WebCore):

2:54 PM Changeset in webkit [142925] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix indentation in GNUmakefile.list.am.
https://bugs.webkit.org/show_bug.cgi?id=109854

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-14
Reviewed by Martin Robinson.

This patch fixes indentation in GNUmakefile.list.am.

  • GNUmakefile.list.am:
2:50 PM Changeset in webkit [142924] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

No easy way to use a RetainPtr as a key in a HashMap using object (rather than pointer) equality
https://bugs.webkit.org/show_bug.cgi?id=109864

Reviewed by Sam Weinig and Benjamin Poulain.

Added RetainPtrObjectHashTraits and RetainPtrObjectHash, which use CFEqual
and CFHash.

  • wtf/RetainPtr.h:

(RetainPtrObjectHashTraits):
(WTF::RetainPtrObjectHashTraits::emptyValue):
(WTF::RetainPtrObjectHashTraits::constructDeletedValue):
(WTF::RetainPtrObjectHashTraits::isDeletedValue):
(WTF):
(WTF::RetainPtrObjectHash::hash):
(WTF::RetainPtrObjectHash::equal):
(RetainPtrObjectHash):

2:46 PM Changeset in webkit [142923] by tony@chromium.org
  • 81 edits in trunk

Unreviewed, set svn:eol-style native for .sln, .vsprops, and .vcproj files.
https://bugs.webkit.org/show_bug.cgi?id=96934

2:34 PM Changeset in webkit [142922] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Bad cast in RenderBlock::splitBlocks.
https://bugs.webkit.org/show_bug.cgi?id=108691

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/multicol/remove-child-split-flow-crash.html

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): rename gIsInColumnFlowSplit to gColumnFlowSplitEnabled
and use it to decide when to do the column flow split or not.
(WebCore::RenderBlock::removeChild): Do not allow column flow split inside removeChild
since we might be merging anonymous blocks.

LayoutTests:

  • fast/multicol/remove-child-split-flow-crash-expected.txt: Added.
  • fast/multicol/remove-child-split-flow-crash.html: Added.
2:31 PM Changeset in webkit [142921] by mark.lam@apple.com
  • 32 edits
    4 adds in trunk/Source/WebCore

Split SQLTransaction work between the frontend and backend.
https://bugs.webkit.org/show_bug.cgi?id=104750.

Reviewed by Sam Weinig.

This is part of the webdatabase refactoring for webkit2.

  1. Changed how transactions are created.
  • Database::runTransaction() first creates a SQLTransaction frontend which encapsulates the 3 script callbacks. It then passes the SQLTransaction to the backend database to create the SQLTransactionBackend.
  • The SQLTransactionBackend manages all SQLiteTransaction work.
  1. Introduced SQLTransactionState and SQLTransactionStateMachine.
  • Instead of tracking the transaction phases as "steps" in m_nextStep, we now use m_nextState which is of enum class SQLTransactionState. Unlike m_nextStep which is a pointer to a "step" function, m_nextState is a state variable which is used to index into a state dispatch table.
  • Both SQLTransaction and SQLTransactionBackend now extends SQLTransactionStateMachine, and uses its dispatch mechanism based on the SQLTransactionState.
  • Instead of having 1 state machine instances, there are 2: 1 in the frontend, and 1 in the backend. The 2 have mirrored states, and transfers work to the other state machine when needed.
  • Previously, state functions can be called inline from other states. They are now only called from the state machines runStateMachine() method. This makes it possible to isolate the state transition mechanism going between the sides (frontend and backend) to 2 functions only: SQLTransaction::sendToBackendState() and SQLTransactionBackend::sendToFrontendState().
  1. Consolidated cleanup work (mostly) to a unified cleanup function.
  1. Changed the frontend Database::runTransaction() to use a ChangeVersionData* (instead of a ChangeVersionWrapper ref ptr).
  • This is necessary because ChangeVersionWrapper contains functionality used in processing a transaction (to be invoked in the backend). Instead, what we want is to simply pass the 2 old and new version strings to the backend. The new ChangeVersionData simply packages up these 2 strings.
  • This makes ChangeVersionData easy to serialize for IPC messaging later.
  1. Moved some transaction functions back to the frontend SQLTransaction because they belong there.
  1. Moved some Database functions to its DatabaseBackendAsync backend now that the transaction has been split up.
  • This is driven naturally by those functions being used exclusively in the backend for transaction work.
  • SQLTransactionClient, SQLTransactionCoordinator, and SQLTransactionWrapper are now exclusively backend data structures. SQLTransactionClient still has some frontend "pollution" that I'll fix later.
  1. Made the few database report functions used only by Chromium conditional on PLATFORM(chromium).
  • The report functions gets re-routed to Chromium's DatabaseObserver which further routes them elsewhere. It is unclear how Chromium uses these routed messages, and I am therefore not able to determine how they should work in a frontend/backend world. So, I'm #ifdef'ing them out. They still work like in the old way for Chromium.
  1. Added new files to the build / project files.
  1. Updated / added comments about how the transaction and its states work.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/ChangeVersionData.h: Added.

(ChangeVersionData):
(WebCore::ChangeVersionData::ChangeVersionData):
(WebCore::ChangeVersionData::oldVersion):
(WebCore::ChangeVersionData::newVersion):

  • Modules/webdatabase/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):

  • Modules/webdatabase/ChangeVersionWrapper.h:

(ChangeVersionWrapper):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::close):
(WebCore::Database::changeVersion):
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
(WebCore::Database::reportStartTransactionResult):
(WebCore::Database::reportCommitTransactionResult):
(WebCore::Database::reportExecuteStatementResult):

  • Modules/webdatabase/Database.h:

(WebCore::Database::databaseContext):
(Database):
(WebCore::Database::reportStartTransactionResult):
(WebCore::Database::reportCommitTransactionResult):
(WebCore::Database::reportExecuteStatementResult):

  • Modules/webdatabase/DatabaseBackend.cpp:
  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):
(WebCore::DatabaseBackend::reportOpenDatabaseResult):
(WebCore::DatabaseBackend::reportChangeVersionResult):
(WebCore::DatabaseBackend::reportStartTransactionResult):
(WebCore::DatabaseBackend::reportCommitTransactionResult):
(WebCore::DatabaseBackend::reportExecuteStatementResult):
(WebCore::DatabaseBackend::reportVacuumDatabaseResult):

  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::runTransaction):
(WebCore::DatabaseBackendAsync::inProgressTransactionCompleted): Moved from frontend.
(WebCore::DatabaseBackendAsync::scheduleTransaction): Moved from frontend.
(WebCore::DatabaseBackendAsync::scheduleTransactionStep): Moved from frontend.
(WebCore::DatabaseBackendAsync::transactionClient): Moved from frontend.
(WebCore::DatabaseBackendAsync::transactionCoordinator): Moved from frontend.

  • Modules/webdatabase/DatabaseBackendAsync.h:

(DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendContext.cpp:

(WebCore::DatabaseBackendContext::frontend):

  • Modules/webdatabase/DatabaseBackendContext.h:

(DatabaseBackendContext):

  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::setBackend):
(WebCore::SQLTransaction::stateFunctionFor):
(WebCore::SQLTransaction::requestTransitToState):
(WebCore::SQLTransaction::nextStateForTransactionError):

  • was handleTransactionError(). There's also a backend version.

(WebCore::SQLTransaction::deliverTransactionCallback): Moved from backend.
(WebCore::SQLTransaction::deliverTransactionErrorCallback): Moved from backend.
(WebCore::SQLTransaction::deliverStatementCallback): Moved from backend.
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Moved from backend.
(WebCore::SQLTransaction::deliverSuccessCallback): Moved from backend.
(WebCore::SQLTransaction::unreachableState):
(WebCore::SQLTransaction::sendToBackendState):
(WebCore::SQLTransaction::performPendingCallback): Moved from backend.
(WebCore::SQLTransaction::executeSQL): Moved from backend.
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::clearCallbackWrappers):

  • Modules/webdatabase/SQLTransaction.h:

(SQLTransaction):
(WebCore::SQLTransaction::database):
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::transactionError):
(WebCore::SQLTransactionBackend::setShouldRetryCurrentStatement):
(WebCore::SQLTransactionBackend::stateFunctionFor):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):

  • was runCurrentStatement().

(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):

  • was handleCurrentStatementError().

(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
(WebCore::SQLTransactionBackend::nextStateForTransactionError):

  • was handleTransactionError(). There's also a frontend version.

(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::requestTransitToState):
(WebCore::SQLTransactionBackend::unreachableState):
(WebCore::SQLTransactionBackend::sendToFrontendState):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionWrapper):
(SQLTransactionBackend):
(WebCore::SQLTransactionBackend::database):

  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::getDatabaseIdentifier):

  • Modules/webdatabase/SQLTransactionState.h: Added.
  • Modules/webdatabase/SQLTransactionStateMachine.cpp: Added.

(WebCore::nameForSQLTransactionState):

  • was debugStepName().
  • Modules/webdatabase/SQLTransactionStateMachine.h: Added.

(SQLTransactionStateMachine):
(WebCore::SQLTransactionStateMachine::~SQLTransactionStateMachine):
(WebCore::::SQLTransactionStateMachine):
(WebCore::::setStateToRequestedState):
(WebCore::::runStateMachine):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorDatabaseAgent.cpp:
2:30 PM Changeset in webkit [142920] by leviw@chromium.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142788. Requested by Christian Biesinger <cbiesinger@chromium.org>.

Crash when encountering <object style="resize:both;">
https://bugs.webkit.org/show_bug.cgi?id=109728

Source/WebCore:

See also https://code.google.com/p/chromium/issues/detail?id=175535
This bug can be reproduced on
http://dramalink.net/tudou.y/?xink=162601060

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

Test: fast/css/resize-object-crash.html

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):
Only call paintResizer() if we have a layer and canResize() is true

LayoutTests:

See also https://code.google.com/p/chromium/issues/detail?id=175535

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

  • fast/css/resize-object-crash-expected.txt: Added.
  • fast/css/resize-object-crash.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12252048

2:27 PM Changeset in webkit [142919] by andersca@apple.com
  • 7 edits
    1 move in trunk

Add WKContextIsPlugInUpdateAvailable
https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp.

(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
(WKContextIsPlugInUpdateAvailable):

  • WebKit2.xcodeproj/project.pbxproj:

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
2:26 PM Changeset in webkit [142918] by jer.noble@apple.com
  • 10 edits in trunk

EME: replace MediaKeySession.addKey() -> update()
https://bugs.webkit.org/show_bug.cgi?id=109461

Source/WebCore:

Reviewed by Eric Carlson.

No new tests; updated media/encrypted-media/encrypted-media-v2-syntax.html test.

In the latest draft of the Encrypted Media Spec, the addKeys() method has been replaced
with update().

  • Modules/encryptedmedia/CDM.h:
  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::addKeyTimerFired):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitAddKey):

  • testing/MockCDM.cpp:

(WebCore::MockCDMSession::update):

LayoutTests:

Rebaseline after API change.

Reviewed by Eric Carlson.

  • media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
  • media/encrypted-media/encrypted-media-v2-syntax.html:
2:04 PM Changeset in webkit [142917] by roger_fong@apple.com
  • 51 edits
    5 moves in trunk

Move all .props files from WebKitLibraries folder to WebKit Source folder.
https://bugs.webkit.org/show_bug.cgi?id=109761

Reviewed by Brent Fulgham.

  • win/tools/vsprops/FeatureDefines.props: Removed.
  • win/tools/vsprops/common.props: Removed.
  • win/tools/vsprops/debug.props: Removed.
  • win/tools/vsprops/release.props: Removed.
  • win/tools/vsprops/releaseproduction.props: Removed.
2:01 PM Changeset in webkit [142916] by Lucas Forschler
  • 7 edits
    3 copies in tags/Safari-537.31.1/Source/WebKit2

Merged r142900. <rdar://problem/13205468>

2:00 PM Changeset in webkit [142915] by tony@chromium.org
  • 14 edits in trunk

Unreviewed, set svn:eol-style CRLF for .sln files.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property
  • svn:eol-style.

Source/ThirdParty:

  • gtest/msvc/gtest-md.sln: Added property svn:eol-style.
  • gtest/msvc/gtest.sln: Added property svn:eol-style.

Source/WebCore:

  • WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
  • WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.

Source/WebKit:

  • WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
  • WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.

Source/WTF:

  • WTF.vcproj/WTF.sln: Added property svn:eol-style.

Tools:

  • CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
  • DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
  • MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
  • WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
1:58 PM Changeset in webkit [142914] by tony@chromium.org
  • 7 edits in trunk

Unreviewed, set svn:eol-style CRLF for .sln files.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.

Source/ThirdParty:

  • gtest/msvc/gtest-md.sln: Added property svn:eol-style.
  • gtest/msvc/gtest.sln: Added property svn:eol-style.

Source/WebCore:

  • WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
  • WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.

Source/WebKit:

  • WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
  • WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.

Source/WTF:

  • WTF.vcproj/WTF.sln: Added property svn:eol-style.

Tools:

  • CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
  • DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
  • MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
  • WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
1:56 PM Changeset in webkit [142913] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My patch 142571 broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

142808 was an earlier version of this patch that was reverted
due to fling events asserting they can't be converted to
PlatformGestureEvent. This version moves fling earlier in the
function to avoid that.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

1:54 PM Changeset in webkit [142912] by Lucas Forschler
  • 1 delete in tags/Safari-537.31.1/Safari-537.31
1:54 PM Changeset in webkit [142911] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r142901.
http://trac.webkit.org/changeset/142901

r182258 introduces a dependency on chrome.gyp that breaks the win
build. Rolling back to r182150 until I can work up a workaround.

  • DEPS:
1:51 PM Changeset in webkit [142910] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] adjust caption color user preference calculation
https://bugs.webkit.org/show_bug.cgi?id=109840

Reviewed by Dean Jackson.

No new tests, it isn't possible to test this with DRT.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): The color is "important" if either the

color or opacity are supposed to override.

(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsTextColor): Ditto.

1:49 PM Changeset in webkit [142909] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Numeric identifiers of events are not guaranteed to be unique
https://bugs.webkit.org/show_bug.cgi?id=103259

Patch by Cosmin Truta <ctruta@rim.com> on 2013-02-14
Reviewed by Alexey Proskuryakov.

The results of setTimeout, setInterval and navigator.geolocation.watchPosition
are positive integer values extracted from a simple circular sequential number
generator, whose uniqueness can be guaranteed for no more than 231 calls to
any of these functions. In order to provide this guarantee beyond this limit,
we repeatedly ask for the next sequential id until we get one that's not used
already.

This solution works instantly under normal circumstances, when there are few
live timeout ids or geolocation ids at any given moment. Handling millions of
live ids will require another solution.

No new tests. Brief tests of uniqueness already exist.
Moreover, reproducing this particular issue would require 231 set/clear
function calls, which is prohibitively expensive.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::add): Rename from Watchers::set; return false if watch id already exists.
(WebCore::Geolocation::watchPosition): Repeat until the new watch id is unique.

  • Modules/geolocation/Geolocation.h:

(Watchers): Rename Watchers::set to Watchers::add.

  • Modules/geolocation/Geolocation.idl: Rename the argument of Geolocation::clearWatch to WatchID.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext): Update initialization.
(WebCore::ScriptExecutionContext::circularSequentialID): Rename from newUniqueID; remove FIXME note.

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext): Rename ScriptExecutionContext::newUniqueID to ScriptExecutionContext::circularSequentialID.
(WebCore::ScriptExecutionContext::addTimeout): Return false (do not assert) if timeout id already exists.

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): Repeat until the new timeout id is unique.

1:40 PM Changeset in webkit [142908] by zandobersek@gmail.com
  • 7 edits in trunk

[GTK] Errors when building WebKit2 with Clang
https://bugs.webkit.org/show_bug.cgi?id=109603

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(setWindowFrame): Cast the position parameters to the integer type when constructing the GdkRectangle.

  • UIProcess/Authentication/WebCredential.cpp: Add an empty implementation of the newly specified destructor.
  • UIProcess/Authentication/WebCredential.h: Work around the incomplete WebCertificateInfo type errors thrown in the inline

RefPtr destructor of the m_certificateInfo class member by defining a destructor in the class.

  • WebProcess/WebCoreSupport/WebEditorClient.h: The GTK-specific methods are not virtual and as such cannot be overriden.

The OVERRIDE keywords are thus unnecessary.

Tools:

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
type when constructing the GtkAllocation.

1:34 PM Changeset in webkit [142907] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r142825.
http://trac.webkit.org/changeset/142825
https://bugs.webkit.org/show_bug.cgi?id=109856

Causes some inspector tests to time out (Requested by anttik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

  • platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

1:31 PM Changeset in webkit [142906] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.1/Safari-537.31

New Tag.

1:30 PM Changeset in webkit [142905] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.1

New Tag.

1:18 PM Changeset in webkit [142904] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Support the ch unit from css3-values
https://bugs.webkit.org/show_bug.cgi?id=85755

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-14
Reviewed by David Hyatt.

Original patch by Sumedha Widyadharma <sumedha.widyadharma@basyskom.com>.

Source/WebCore:

Test: fast/css/css3-ch-unit.html

  • css/CSSCalculationValue.cpp:

(WebCore::unitCategory):

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isLength):

  • platform/graphics/FontMetrics.h:

(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::zeroWidth):
(WebCore::FontMetrics::setZeroWidth):
(FontMetrics):
(WebCore::FontMetrics::hasZeroWidth):
(WebCore::FontMetrics::setHasZeroWidth):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::zeroGlyph):
(WebCore::SimpleFontData::setZeroGlyph):
(SimpleFontData):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

  • fast/css/css3-ch-unit-expected.txt: Added.
  • fast/css/css3-ch-unit.html: Added.
1:16 PM Changeset in webkit [142903] by ddkilzer@apple.com
  • 10 edits in trunk/Source

[Mac] Clean up WARNING_CFLAGS
<http://webkit.org/b/109747>
<rdar://problem/13208373>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Use

GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WebCore:

  • Configurations/Base.xcconfig: Use

GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WebKit/mac:

  • Configurations/Base.xcconfig: Use

GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WebKit2:

  • Configurations/Base.xcconfig: Use

GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

Source/WTF:

  • Configurations/Base.xcconfig: Use

GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.

1:11 PM Changeset in webkit [142902] by Christophe Dumez
  • 5 edits in trunk/Source/WebCore

Add addHTTPHeaderField() method to ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=109844

Reviewed by Adam Barth.

ResourceRequestBase provides both setHTTPHeaderField() and addHTTPHeaderField(). However,
ResourceResponseBase only provides setHTTPHeaderField(). This is a bit inconsistent. As a
result, the addHTTPHeaderField() functionality's implementation is duplicated in several
ports (at least chromium and soup).

This patch introduces addHTTPHeaderField() to ResourceResponseBase and makes use of it
in Chromium and Soup backends.

No new tests, no behavior change.

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField): Use ResourceResponseBase::addHTTPHeaderField().

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::updateHeaderParsedState): Move headers' parsed state update code
from setHTTPHeaderField() to a new updateHeaderParsedState() method to avoid code duplication.
(WebCore):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):

  • platform/network/ResourceResponseBase.h:

(ResourceResponseBase):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Use ResourceResponseBase::addHTTPHeaderField().

1:08 PM Changeset in webkit [142901] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, chromium roll 182150 -> 182448

  • DEPS:
12:53 PM Changeset in webkit [142900] by weinig@apple.com
  • 7 edits
    3 adds in trunk/Source/WebKit2

Add conversions between ObjC and C DOM wrappers
<rdar://problem/13205468>
https://bugs.webkit.org/show_bug.cgi?id=109851

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:

(WKBundleRangeHandleCreate):

  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode _copyBundleNodeHandleRef]):

  • WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h: Added.
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange _copyBundleRangeHandleRef]):

  • WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:

(InjectedBundleRangeHandle):

12:16 PM Changeset in webkit [142899] by pdr@google.com
  • 3 edits
    2 adds in trunk

Prevent inconsistent firstChild during document destruction
https://bugs.webkit.org/show_bug.cgi?id=106530

Reviewed by Abhishek Arya.

Source/WebCore:

During document destruction, addChildNodesToDeletionQueue can allow a container
node to have an invalid first child, causing a crash. This patch updates
addChildNodesToDeletionQueue to maintain a valid value for firstChild() even
while updating its children.

Test: svg/custom/animateMotion-path-change-crash.svg

  • dom/ContainerNodeAlgorithms.h:

(WebCore::Private::addChildNodesToDeletionQueue):

To ensure prevoiusSibling() is also valid, this code was slightly refactored
to call setPreviousSibling(0) on the next node instead of the current node.

LayoutTests:

  • svg/custom/animateMotion-path-change-crash-expected.txt: Added.
  • svg/custom/animateMotion-path-change-crash.svg: Added.
12:15 PM Changeset in webkit [142898] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Grid Layout] Add an internal 2D grid representation to RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=109714

Reviewed by Ojan Vafai.

This change introduces a 2D grid representation of the grid areas. Our implementation
is a straight Vector of Vectors for the grid areas, each grid area able to hold an
arbitrary number of RenderBox* so they hold a Vector of RenderBoxes. As an optimization,
each grid area has enough inline storage to hold one grid item which should cover
most cases.

In order to keep the code readable, a GridIterator was introduced to hide the new grid.

Refactoring, covered by existing tests.

  • rendering/RenderGrid.cpp:

(RenderGrid::GridIterator):
(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::GridIterator::nextGridItem):
Added a mono-directional iterator. In order to be more aligned with the rest of the code,
this iterator actually walks orthogonally to the |direction| (ie fixing the |direction|'s track).

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):
Updated these 2 functions to place the items on the grid and clear it at the end.

(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated to use the GridIterator to walk over the rows / columns.

(WebCore::RenderGrid::placeItemsOnGrid):
Added this function that inserts the grid items into the right grid area.

  • rendering/RenderGrid.h:

(WebCore::RenderGrid::gridColumnCount):
(WebCore::RenderGrid::gridRowCount):
Added these helper functions.

11:53 AM Changeset in webkit [142897] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r141990.
http://trac.webkit.org/changeset/141990
https://bugs.webkit.org/show_bug.cgi?id=109850

~5% regression on intl2 page cycler (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::create):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(GlyphPage):
(WebCore::GlyphPage::copyFrom):
(WebCore::GlyphPage::clear):
(WebCore::GlyphPage::clearForFontData):
(WebCore::GlyphPage::GlyphPage):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

11:31 AM Changeset in webkit [142896] by pilgrim@chromium.org
  • 10 edits
    2 moves
    1 add in trunk/Source

[Chromium] Move PlatformMessagePortChannel to WebCore
https://bugs.webkit.org/show_bug.cgi?id=109845

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • dom/default/chromium: Added.
  • dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Added.

(WebCore):
(WebCore::MessagePortChannel::create):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::~MessagePortChannel):
(WebCore::MessagePortChannel::entangleIfOpen):
(WebCore::MessagePortChannel::disentangle):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
(WebCore::MessagePortChannel::close):
(WebCore::MessagePortChannel::isConnectedTo):
(WebCore::MessagePortChannel::hasPendingActivity):
(WebCore::MessagePortChannel::locallyEntangledPort):
(WebCore::PlatformMessagePortChannel::create):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::createChannel):
(WebCore::PlatformMessagePortChannel::messageAvailable):
(WebCore::PlatformMessagePortChannel::entangleIfOpen):
(WebCore::PlatformMessagePortChannel::disentangle):
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
(WebCore::PlatformMessagePortChannel::close):
(WebCore::PlatformMessagePortChannel::isConnectedTo):
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
(WebCore::PlatformMessagePortChannel::setEntangledChannel):
(WebCore::PlatformMessagePortChannel::webChannelRelease):

  • dom/default/chromium/PlatformMessagePortChannelChromium.h: Added.

(WebKit):
(WebCore):
(PlatformMessagePortChannel):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/PlatformMessagePortChannel.cpp: Removed.
  • src/PlatformMessagePortChannel.h: Removed.
  • src/SharedWorkerRepository.cpp:
  • src/WebDOMMessageEvent.cpp:
  • src/WebFrameImpl.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • src/WebWorkerClientImpl.cpp:
11:22 AM Changeset in webkit [142895] by Chris Fleizach
  • 9 edits in trunk/Source/WebCore

Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
https://bugs.webkit.org/show_bug.cgi?id=90250

Reviewed by Eric Seidel.

The Leopard era checks for accessibility lists and accessibility tables can be removed now.

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::isTableExposableThroughAccessibility):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::init):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):

11:17 AM Changeset in webkit [142894] by eric@webkit.org
  • 2 edits in trunk/Source/WTF

String(Vector) behaves differently from String(vector.data(), vector.size()) for vectors with inline capacity in the size=0 case
https://bugs.webkit.org/show_bug.cgi?id=109784

Reviewed by Darin Adler.

This makes String(Vector) never return null strings.
Which matches behavior of String(UChar*, size_t)
for vectors with inlineCapacity, but differs from
String(UChar*, size_t) in the no-inlineCapacity case.

This incidentally will fix a behavioral regression
in the html threaded parser which came from converting
many String(UChar*, size_t) callsites to using String(Vector).

  • wtf/text/WTFString.h:

(String):
(WTF::String::String):

11:09 AM Changeset in webkit [142893] by commit-queue@webkit.org
  • 10 edits in trunk

Make outside-shape the default value for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=109605

Patch by Bear Travis <betravis@adobe.com> on 2013-02-14
Reviewed by Levi Weintraub.

Source/WebCore:

Creating a single reference outside-shape value and setting it as the default
for shape-inside.

Existing tests cover the default value, just updating them to use outside-shape.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::initialShapeInside): Define a local static outside-shape
value.
(WebCore):

  • rendering/style/RenderStyle.h: Move the initialShapeInside method to the .cpp

file.

LayoutTests:

Updating tests to account for the new default value of shape-inside.

  • fast/exclusions/css-exclusions-disabled-expected.txt:
  • fast/exclusions/css-exclusions-disabled.html:
  • fast/exclusions/parsing-wrap-shape-inside-expected.txt:
  • fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
  • fast/exclusions/parsing-wrap-shape-lengths.html:
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:

(negative_test):

11:06 AM Changeset in webkit [142892] by roger_fong@apple.com
  • 3 edits
    1 add in trunk/Tools

Add eol-style=native to solution files. Add a new solution file.

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
  • TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
10:49 AM Changeset in webkit [142891] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Passing alpha to DeferredImageDecoder once decoding completes
https://bugs.webkit.org/show_bug.cgi?id=108892

Patch by Min Qin <qinmin@chromium.org> on 2013-02-14
Reviewed by Stephen White.

Source/WebCore:

We should pass hasAlpha value back to the DeferredImageDecoder once decoding is completed
Added unit tests in ImageFrameGeneratorTest.

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::decode):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(WebCore::LazyDecodingPixelRef::hasAlpha):
(LazyDecodingPixelRef):

  • platform/graphics/chromium/ScaledImageFragment.cpp:

(WebCore::ScaledImageFragment::ScaledImageFragment):

  • platform/graphics/chromium/ScaledImageFragment.h:

(WebCore::ScaledImageFragment::create):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::hasAlpha):

Source/WebKit/chromium:

Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.

  • tests/ImageFrameGeneratorTest.cpp:

(WebCore::MockImageDecoderFactory::create):
(WebCore::TEST_F):

  • tests/MockImageDecoder.h:

(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::setFrameHasAlpha):
(MockImageDecoder):
(WebCore::MockImageDecoder::frameHasAlphaAtIndex):

10:17 AM Changeset in webkit [142890] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762

Reviewed by Tony Chang.

A few places where commits could fail weren't being logged.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):

9:53 AM Changeset in webkit [142889] by tony@chromium.org
  • 4 edits
    2 adds in trunk

Padding and border changes doesn't trigger relayout of children
https://bugs.webkit.org/show_bug.cgi?id=109639

Reviewed by Kent Tamura.

Source/WebCore:

In RenderBlock::layoutBlock, we only relayout our children if our logical width
changes. This misses cases where our logical width doesn't change (i.e., padding
or border changes), but our content width does change.

This is a more general case of bug 104997.

Test: fast/block/dynamic-padding-border.html

  • rendering/RenderBox.cpp:

(WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
(WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
even without border-box box sizing.

LayoutTests:

  • fast/block/dynamic-padding-border-expected.txt: Added.
  • fast/block/dynamic-padding-border.html: Added.
  • fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying

out the table when the border changed. The pixel results in this case is the same, but the
render tree shows the difference.

9:52 AM Changeset in webkit [142888] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: fix closure compilation warnings caused by setVariableValue change
https://bugs.webkit.org/show_bug.cgi?id=109488

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-14
Reviewed by Pavel Feldman.

Annotations are fixed as required by closure compiler.
Parameters in Inspector.json are reordered as required.

  • inspector/InjectedScriptExterns.js:

(InjectedScriptHost.prototype.setFunctionVariableValue):
(JavaScriptCallFrame.prototype.setVariableValue):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setVariableValue):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

9:47 AM Changeset in webkit [142887] by tommyw@google.com
  • 3 edits in trunk/Source/WebCore

MediaStream API: RTCDataChannel triggers a use-after-free
https://bugs.webkit.org/show_bug.cgi?id=109806

Reviewed by Adam Barth.

Making sure RTCPeerConnection::stop() is always called at least once.
Also making sure that RTCDataChannels state gets set to Closed correctly.

Hard to test in WebKit but covered by Chromium tests.

  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::stop):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::stop):

9:38 AM Changeset in webkit [142886] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: [Regression] When several consecutive characters are typed each of them is marked as undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109823

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt:
  • inspector/editor/text-editor-undo-redo.html:
9:23 AM Changeset in webkit [142885] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r142820.
http://trac.webkit.org/changeset/142820
https://bugs.webkit.org/show_bug.cgi?id=109839

Causing crashes on chromium canaries (Requested by atwilson_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateLayout):
(WebCore::Document::implicitClose):

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/RenderView.cpp:
  • rendering/RenderView.h:

LayoutTests:

  • fast/block/float/float-not-removed-from-pre-block-expected.txt:
  • fast/css-generated-content/quote-layout-focus-crash-expected.txt: Removed.
  • fast/css-generated-content/quote-layout-focus-crash.html: Removed.
9:21 AM Changeset in webkit [142884] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update keyboard event details to match platform details.
https://bugs.webkit.org/show_bug.cgi?id=109693

Reviewed by Yong Li.

PR 220170.

When re-creating the Platform::Keyboard event ensure
all values are updated.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

9:15 AM Changeset in webkit [142883] by mario@webkit.org
  • 9 edits
    2 adds in trunk

[GTK] Missing call to g_object_ref while retrieving accessible table cells
https://bugs.webkit.org/show_bug.cgi?id=106903

Reviewed by Martin Robinson.

Source/WebCore:

Add missing extra ref to implementation of atk_table_ref_at().

Test: accessibility/table-cell-for-column-and-row-crash.html

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableRefAt): This method transfers full ownership
over the returned AtkObject, so an extra reference is needed here.

Tools:

Both DRT and WKTR need to call g_object_unref() now that an extra
reference is added in the implementation of atk_table_ref_at().

  • DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
before returning the new instance of AccessibilityUIElement.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.

LayoutTests:

Added new test. It should work fine at least in Mac and GTK ports,
but will need specific results for chromium and windows.

  • accessibility/table-cell-for-column-and-row-crash.html: Added.
  • accessibility/table-cell-for-column-and-row-crash-expected.txt: Added.
  • platform/chromium/TestExpectations: Skipped test.
  • platform/win/TestExpectations: Ditto.
  • platform/wincairo/TestExpectations: Ditto.
9:11 AM Changeset in webkit [142882] by mifenton@rim.com
  • 4 edits in trunk/Source

[BlackBerry] Update keyboard event details to match platform details.
https://bugs.webkit.org/show_bug.cgi?id=109693

Reviewed by Yong Li.

PR 220170.

Source/WebCore:

Update the keyboard event details to match the
platform details available.

Rename helper function to better describe the conversion.

Reviewed Internally by Nima Ghanavatian and Gen Mak.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::windowsKeyCodeForBlackBerryKeycode):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Source/WebKit/blackberry:

Update keyboard event details.

Reviewed Internally by Nima Ghanavatian and Gen Mak.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::keyEvent):

9:06 AM Changeset in webkit [142881] by kadam@inf.u-szeged.hu
  • 2 edits
    6 adds in trunk/LayoutTests

[Qt] Reviewing TestExpectations. Added platform specific expected files and unskip them.
https://bugs.webkit.org/show_bug.cgi?id=59334.

  • platform/qt-5.0-wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/qt/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
8:47 AM Changeset in webkit [142880] by fmalita@chromium.org
  • 21 edits in trunk/LayoutTests

[Chromium] Unreviewed rebaseline after brightness filter update.

  • platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
  • platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
  • platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/chromium/TestExpectations:
8:39 AM Changeset in webkit [142879] by caseq@chromium.org
  • 18 edits in trunk

Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
https://bugs.webkit.org/show_bug.cgi?id=109192

Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • remove frame and compositing instrumentation methods from InspectorInstrumentation;
  • expose those methods on InspectorController instead.
  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didBeginFrame):
(WebCore):
(WebCore::InspectorController::didCancelFrame):
(WebCore::InspectorController::willComposite):
(WebCore::InspectorController::didComposite):

  • inspector/InspectorController.h:

(InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • testing/Internals.cpp:

(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):

Source/WebKit/blackberry:

  • invoke frame instrumentation methods on InspectorController, not on InspectorInstrumentation.
  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):

Source/WebKit/chromium:

  • expose frame and compositing insturmentation methods on WebDevToolsAgent;
  • temporarily route them from WebViewImpl to WebDevToolsAgent;
  • public/WebDevToolsAgent.h:

(WebDevToolsAgent):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::didBeginFrame):
(WebKit):
(WebKit::WebDevToolsAgentImpl::didCancelFrame):
(WebKit::WebDevToolsAgentImpl::willComposite):
(WebKit::WebDevToolsAgentImpl::didComposite):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit::WebViewImpl::didBeginFrame):
(WebKit::WebViewImpl::willCommit):

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
8:15 AM Changeset in webkit [142878] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fixed a layout regression in CanvasProfileView.
https://bugs.webkit.org/show_bug.cgi?id=109835

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
Reviewed by Pavel Feldman.

Changed splitView.css to supported nested SplitView instances.

  • inspector/front-end/splitView.css:

(.split-view-vertical > .split-view-contents):
(.split-view-vertical > .split-view-contents-first):
(.split-view-vertical > .split-view-contents-first.maximized):
(.split-view-vertical > .split-view-contents-second):
(.split-view-vertical > .split-view-contents-second.maximized):
(.split-view-horizontal > .split-view-contents):
(.split-view-horizontal > .split-view-contents-first):
(.split-view-horizontal > .split-view-contents-first.maximized):
(.split-view-horizontal > .split-view-contents-second):
(.split-view-horizontal > .split-view-contents-second.maximized):
(.split-view-vertical > .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical > .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal > .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal > .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical > .split-view-resizer):
(.split-view-horizontal > .split-view-resizer):

8:05 AM Changeset in webkit [142877] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Unskip mediastream tests that are passing after webkit_support update

Unreviewed gardening.

  • platform/chromium/TestExpectations:
7:15 AM Changeset in webkit [142876] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Color picker should not be available in Computed Styles pane.
https://bugs.webkit.org/show_bug.cgi?id=109697

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
Reviewed by Alexander Pavlov.

Changed the parentPane parameter of WebInspector.ComputedStylePropertiesSection to the correct value
(the ComputedStyleSidebarPane instance).

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):

5:53 AM Changeset in webkit [142875] by mnaganov@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebKit/chromium

[Chromium] Add a setting to control scaling content to fit viewport
https://bugs.webkit.org/show_bug.cgi?id=109584

Adds a setting called 'initializeAtMinimumPageScale'. By default,
it is set to 'true' which corresponds to Chrome on Android behavior--
adjust the page scale to make the content fit into the viewport
by width. When set to false, the setting instructs ChromeClientImpl to
set page scale to 1.0, unless the scale value is set by the page
in the viewport meta-tag.

Reviewed by Adam Barth.

  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::initializeAtMinimumPageScale):

  • tests/WebFrameTest.cpp:
  • tests/data/viewport-2x-initial-scale.html: Added.
  • tests/data/viewport-auto-initial-scale.html: Added.
5:39 AM Changeset in webkit [142874] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip flaky test after r140689.

  • platform/qt/TestExpectations:
5:19 AM Changeset in webkit [142873] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: don't create static local string for program literal in InspectorTimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=109811

Reviewed by Pavel Feldman.

Use const char* constant value instead of creating String from it in thread-unsafe
static local variable.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

5:08 AM Changeset in webkit [142872] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r142808.
http://trac.webkit.org/changeset/142808
https://bugs.webkit.org/show_bug.cgi?id=109816

Crashes on chromium webkit canary bots (Requested by atwilson_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::enableTouchHighlight):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

5:01 AM Changeset in webkit [142871] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Web Inspector] Fix initiator name issue in reload scenario for Network Panel.
https://bugs.webkit.org/show_bug.cgi?id=108746.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-14
Reviewed by Vsevolod Vlasov.

WebInspector.displayNameForURL() does not work as expected in the reload scenario,
for example, "http://www.yahoo.com/" was trimed to "/" at one time, but at another,
the full host name will be displayed.
This fix return host + "/" in the issue scenario, and keep with get displayName() in ParsedURL.

No new tests.

  • inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.prototype.get displayName): append "/" in the display host scenario.

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL): add host in the head if url trimed as a "/".

4:57 AM Changeset in webkit [142870] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix to record button remaining red after heap snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=109804

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.

Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

4:47 AM Changeset in webkit [142869] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Consistently use SecurityOrigin::toRawString() for serialization across the backend code
https://bugs.webkit.org/show_bug.cgi?id=109801

Reviewed by Yury Semikhatsky.

No new tests, as existing tests cover the change.

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didClearWindowObjectInWorld):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

4:35 AM Changeset in webkit [142868] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

Add logging support to IndexedDB for non-Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=109809

Reviewed by Kentaro Hara.

Enable logging of IndexedDB through the StorageAPI log channel for
non-Chromium architectures.

No new tests required, we're just enabling logging for IndexedDB
using the currently available logging framework.

  • Modules/indexeddb/IDBTracing.h:
4:27 AM Changeset in webkit [142867] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Remove uriForFile and fileForURI methods from FileSystemMapping.
https://bugs.webkit.org/show_bug.cgi?id=109704

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced this methods with one line implementation on the only call site.

  • inspector/front-end/FileSystemMapping.js:
  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype._filePathForURI):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):

LayoutTests:

  • inspector/file-system-mapping-expected.txt:
  • inspector/file-system-mapping.html:
4:09 AM Changeset in webkit [142866] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[Text Autosizing] Process narrow descendants with the same multiplier for the font size.
https://bugs.webkit.org/show_bug.cgi?id=109573

Source/WebCore:

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.

Combine narrow descendants of the same autosizing cluster into a group that is autosized
with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we want them all to share the same multiplier, as
if they were a single cluster.

Test: fast/text-autosizing/narrow-descendants-combined.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Common implementation for processCluster() and processCompositeCluster that accepts the
text width and whether the cluster should be autosized as parameters instead of
calculating it inline.

(WebCore::TextAutosizer::processCluster):

Calculates the text width for a single cluster and whether it should be autosized, then
calls processClusterInternal() to apply the multiplier and process the cluster's
descendants.

(WebCore::TextAutosizer::processCompositeCluster):

Calculates the text width for a group of renderers and if the group should be autosized,
then calls processClusterInternal() repeatedly with the same multiplier to apply it and
process all the descendants of the group.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

Calls the multiple renderers version to avoid code duplication.

(WebCore::TextAutosizer::compositeClusterShouldBeAutosized):

The multiple renderers version of clusterShouldBeAutosized.

  • rendering/TextAutosizer.h:

Updated method declarations.

LayoutTests:

Test to verify that all narrow descendants of a cluster are autosized with the same
multiplier.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.

  • fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
  • fast/text-autosizing/narrow-descendants-combined.html: Added.
3:53 AM Changeset in webkit [142865] by aandrey@chromium.org
  • 2 edits
    13 adds in trunk/Source/WebCore

Look into possibilities of typedef in webkit idl files
https://bugs.webkit.org/show_bug.cgi?id=52340

Reviewed by Kentaro Hara.

Add typedef support for WebKit IDL parser.
Drive by: fixed a bug of generating "unrestrictedfloat" without a space.

Added a new IDL test TestTypedefs.idl. The results were generated without typedefs.

  • bindings/scripts/IDLParser.pm:

(assertNoExtendedAttributesInTypedef):
(parseDefinitions):
(applyTypedefs):
(applyTypedefsForSignature):
(parseTypedef):
(parseUnrestrictedFloatType):

  • bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp: Added.

(WebDOMTestTypedefs::WebDOMTestTypedefsPrivate::WebDOMTestTypedefsPrivate):
(WebDOMTestTypedefs::WebDOMTestTypedefsPrivate):
(WebDOMTestTypedefs::WebDOMTestTypedefs):
(WebDOMTestTypedefs::operator=):
(WebDOMTestTypedefs::impl):
(WebDOMTestTypedefs::~WebDOMTestTypedefs):
(WebDOMTestTypedefs::unsignedLongLongAttr):
(WebDOMTestTypedefs::setUnsignedLongLongAttr):
(WebDOMTestTypedefs::immutableSerializedScriptValue):
(WebDOMTestTypedefs::setImmutableSerializedScriptValue):
(WebDOMTestTypedefs::func):
(WebDOMTestTypedefs::multiTransferList):
(WebDOMTestTypedefs::setShadow):
(WebDOMTestTypedefs::nullableArrayArg):
(WebDOMTestTypedefs::immutablePointFunction):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestTypedefs.h: Added.

(WebCore):
(WebDOMTestTypedefs):

  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp: Added.

(_WebKitDOMTestTypedefsPrivate):
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestTypedefs):
(webkit_dom_test_typedefs_finalize):
(webkit_dom_test_typedefs_set_property):
(webkit_dom_test_typedefs_get_property):
(webkit_dom_test_typedefs_constructor):
(webkit_dom_test_typedefs_class_init):
(webkit_dom_test_typedefs_init):
(webkit_dom_test_typedefs_func):
(webkit_dom_test_typedefs_multi_transfer_list):
(webkit_dom_test_typedefs_set_shadow):
(webkit_dom_test_typedefs_nullable_array_arg):
(webkit_dom_test_typedefs_immutable_point_function):
(webkit_dom_test_typedefs_string_array_function):
(webkit_dom_test_typedefs_get_unsigned_long_long_attr):
(webkit_dom_test_typedefs_set_unsigned_long_long_attr):
(webkit_dom_test_typedefs_get_immutable_serialized_script_value):
(webkit_dom_test_typedefs_set_immutable_serialized_script_value):

  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h: Added.

(_WebKitDOMTestTypedefs):
(_WebKitDOMTestTypedefsClass):

  • bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h: Added.

(WebKit):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp: Added.

(WebCore):
(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefsConstructor::getOwnPropertySlot):
(WebCore::JSTestTypedefsConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestTypedefsConstructor::getConstructData):
(WebCore::JSTestTypedefsPrototype::self):
(WebCore::JSTestTypedefsPrototype::getOwnPropertySlot):
(WebCore::JSTestTypedefsPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::finishCreation):
(WebCore::JSTestTypedefs::createPrototype):
(WebCore::JSTestTypedefs::destroy):
(WebCore::JSTestTypedefs::~JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot):
(WebCore::JSTestTypedefs::getOwnPropertyDescriptor):
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsImmutableSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsConstructor):
(WebCore::JSTestTypedefs::put):
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::JSTestTypedefs::getConstructor):
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp):
(WebCore::jsTestTypedefsPrototypeFunctionImmutablePointFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::isObservable):
(WebCore::JSTestTypedefsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestTypedefsOwner::finalize):
(WebCore::toJS):
(WebCore::toTestTypedefs):

  • bindings/scripts/test/JS/JSTestTypedefs.h: Added.

(WebCore):
(JSTestTypedefs):
(WebCore::JSTestTypedefs::create):
(WebCore::JSTestTypedefs::createStructure):
(WebCore::JSTestTypedefs::impl):
(WebCore::JSTestTypedefs::releaseImpl):
(WebCore::JSTestTypedefs::releaseImplIfNotNull):
(JSTestTypedefsOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestTypedefsPrototype):
(WebCore::JSTestTypedefsPrototype::create):
(WebCore::JSTestTypedefsPrototype::createStructure):
(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):
(JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestTypedefs.h: Added.
  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm: Added.

(-[DOMTestTypedefs dealloc]):
(-[DOMTestTypedefs finalize]):
(-[DOMTestTypedefs unsignedLongLongAttr]):
(-[DOMTestTypedefs setUnsignedLongLongAttr:]):
(-[DOMTestTypedefs immutableSerializedScriptValue]):
(-[DOMTestTypedefs setImmutableSerializedScriptValue:]):
(-[DOMTestTypedefs multiTransferList:tx:second:txx:]):
(-[DOMTestTypedefs setShadow:height:blur:color:alpha:]):
(-[DOMTestTypedefs immutablePointFunction]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h: Added.

(WebCore):

  • bindings/scripts/test/TestTypedefs.idl: Added.
  • bindings/scripts/test/V8/V8TestTypedefs.cpp: Added.

(WebCore):
(WebCore::checkTypeOrDieTrying):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::V8_USE):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetter):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
(WebCore::TestTypedefsV8Internal::TestTypedefsConstructorGetter):
(WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetter):
(WebCore::TestTypedefsV8Internal::funcCallback):
(WebCore::TestTypedefsV8Internal::multiTransferListCallback):
(WebCore::TestTypedefsV8Internal::setShadowCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgCallback):
(WebCore::TestTypedefsV8Internal::funcWithClampCallback):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionCallback):
(WebCore::V8TestTypedefs::constructorCallback):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetRawTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
(WebCore::V8TestTypedefs::createWrapper):
(WebCore::V8TestTypedefs::derefObject):

  • bindings/scripts/test/V8/V8TestTypedefs.h: Added.

(WebCore):
(V8TestTypedefs):
(WebCore::V8TestTypedefs::toNative):
(WebCore::V8TestTypedefs::installPerContextProperties):
(WebCore::V8TestTypedefs::installPerContextPrototypeProperties):
(WebCore::wrap):
(WebCore::toV8):
(WebCore::toV8Fast):

3:18 AM Changeset in webkit [142864] by haraken@chromium.org
  • 2 edits in trunk

[V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(),
and XXXAccessorSetter() to XXXAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=109679

Reviewed by Adam Barth.

For naming consistency and clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateHeaderCustomCall):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(WebCore::TestObjV8Internal::customAttrAttrSetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BiquadFilterNodeCustom.cpp:

(WebCore::V8BiquadFilterNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrSetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrSetterCustom):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAttrGetterCustom):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAttrGetterCustom):
(WebCore::V8Coordinates::altitudeAccuracyAttrGetterCustom):
(WebCore::V8Coordinates::headingAttrGetterCustom):
(WebCore::V8Coordinates::speedAttrGetterCustom):

  • bindings/v8/custom/V8CustomEventCustom.cpp:

(WebCore::V8CustomEvent::detailAttrGetterCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::locationAttrSetterCustom):
(WebCore::V8DOMWindow::openerAttrSetterCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::rotationRateAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::intervalAttrGetterCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::betaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::gammaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::absoluteAttrGetterCustom):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAttrGetterCustom):
(WebCore::V8Document::locationAttrSetterCustom):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAttrGetterCustom):
(WebCore::V8Event::clipboardDataAttrGetterCustom):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAttrGetterCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::allAttrSetterCustom):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAttrGetterCustom):
(WebCore::V8HTMLElement::itemValueAttrSetterCustom):

  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:

(WebCore::V8HTMLFrameElement::locationAttrSetterCustom):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionStartAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrSetterCustom):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAttrGetterCustom):
(WebCore::V8HTMLLinkElement::sizesAttrSetterCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAttrSetterCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAttrGetterCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::scopeChainAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::thisObjectAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::typeAttrGetterCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::hashAttrSetterCustom):
(WebCore::V8Location::hostAttrSetterCustom):
(WebCore::V8Location::hostnameAttrSetterCustom):
(WebCore::V8Location::hrefAttrSetterCustom):
(WebCore::V8Location::pathnameAttrSetterCustom):
(WebCore::V8Location::portAttrSetterCustom):
(WebCore::V8Location::protocolAttrSetterCustom):
(WebCore::V8Location::searchAttrSetterCustom):
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):
(WebCore::V8MessageEvent::portsAttrGetterCustom):

  • bindings/v8/custom/V8OscillatorNodeCustom.cpp:

(WebCore::V8OscillatorNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8PannerNodeCustom.cpp:

(WebCore::V8PannerNode::panningModelAttrSetterCustom):
(WebCore::V8PannerNode::distanceModelAttrSetterCustom):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAttrGetterCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAttrGetterCustom):
(WebCore::V8SVGLength::valueAttrSetterCustom):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAttrGetterCustom):

  • bindings/v8/custom/V8WebKitAnimationCustom.cpp:

(WebCore::V8WebKitAnimation::iterationCountAttrGetterCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAttrGetterCustom):
(WebCore::V8XMLHttpRequest::responseAttrGetterCustom):

2:23 AM Changeset in webkit [142863] by eric@webkit.org
  • 2 edits in trunk/Source/WTF

REGRESSION(r142712): attribute values show up as "(null)" instead of null with the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=109784

Reviewed by Benjamin Poulain.

When I changed many callsites to use the (existing) String(Vector) constructor
I inadvertantly made those callsites convert empty vectors to null strings
instead of empty strings (like String(UChar,size_t) does).

This is due to an oddity/bug in our Vector implementation where data()
will be 0 if the Vector is empty, but only if it doesn't have inline capacity.
https://bugs.webkit.org/show_bug.cgi?id=109792

This changes String(Vector) to exactly match the behavior of String(vector.data(), vector.size()).

This regression was easily detectable with the threaded parser, because we use String
instead of AtomicString in our CompactToken (used to send the Token data
between threads). The main-thread parser path uses AtomicHTMLToken which
uses AtomicString(Vector) and does not have this bug.

  • wtf/text/WTFString.h:

(String):
(WTF::String::String):

2:22 AM Changeset in webkit [142862] by yurys@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: extract DOM counters graph implementation into its own class
https://bugs.webkit.org/show_bug.cgi?id=109796

Reviewed by Alexander Pavlov.

Extracted DOM counters graph implementation into DOMCountersGraph.js leaving
in MemoryStatistics.js only common parts shared with NativeMemoryGraph.js
Added some closure annotations and converted object literals into classes
with named constructors.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DOMCountersGraph.js: Added.

(WebInspector.DOMCountersGraph):
(WebInspector.DOMCounterUI):
(WebInspector.DOMCountersGraph.Counter):
(WebInspector.DOMCounterUI.prototype.setRange):
(WebInspector.DOMCounterUI.prototype.updateCurrentValue):
(WebInspector.DOMCounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.DOMCounterUI.prototype.saveImageUnderMarker):
(WebInspector.DOMCounterUI.prototype.restoreImageUnderMarker):
(WebInspector.DOMCounterUI.prototype.discardImageUnderMarker):
(WebInspector.DOMCountersGraph.prototype._createCurrentValuesBar):
(WebInspector.DOMCountersGraph.prototype._createCounterUIList):
(WebInspector.DOMCountersGraph.prototype._createCounterUIList.getNodeCount):
(WebInspector.DOMCountersGraph.prototype._createCounterUIList.getListenerCount):
(WebInspector.DOMCountersGraph.prototype._canvasHeight):
(WebInspector.DOMCountersGraph.prototype._onRecordAdded):
(WebInspector.DOMCountersGraph.prototype._draw):
(WebInspector.DOMCountersGraph.prototype._restoreImageUnderMarker):
(WebInspector.DOMCountersGraph.prototype._saveImageUnderMarker):
(WebInspector.DOMCountersGraph.prototype._drawMarker):
(WebInspector.DOMCountersGraph.prototype._drawGraph):
(WebInspector.DOMCountersGraph.prototype._discardImageUnderMarker):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.Counter):
(WebInspector.MemoryStatistics.prototype._createCurrentValuesBar):
(WebInspector.MemoryStatistics.prototype._createCounterUIList):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype._canvasHeight):
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onClick):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._onMouseMove):
(WebInspector.MemoryStatistics.prototype._restoreImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._drawMarker):
(WebInspector.MemoryStatistics.prototype._discardImageUnderMarker):

  • inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryGraph.Counter):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
(WebInspector.NativeMemoryGraph.prototype._draw):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/WebKit.qrc:
2:14 AM Changeset in webkit [142861] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Source/WebCore: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857

Patch by Aivo Paas <aivopaas@gmail.com> on 2013-02-14
Reviewed by Allan Sandfeld Jensen.

Mouse cursor changes in styles used to be reflected in UI through dispatching a fake
mousemove event. The old approach has some flaws: it emits a mousemove event in
javascript when there is no mouse movement involved (bug 85343); the fake mousemove
event is cancelled while there is a mouse button held down - cursor won't change
until mouse is moved or the button released (bug 53341); it has extra overhead of
using a timer which was introduced to make scrolling smoother.

The new approach does not use the fake mousemove event. Instead, it uses only the logic
needed for the actual cursor change to happen. This bypasses all the mousemove event related
overhead. The remaining code is a stripped version of what was run through the mousemove
event path. Everything that was not needed for changing a cursor is stripped off, everything
that is needed, remains the same.

The call to update cursor was moved up in the call tree from RenderObject::StyleDidChange
to RenderObject::SetStyle right after the StyleDidChange call. This allows to any updates
and style propagations in StyleDidChange to happen and makes sure that a cursor change is
not missed. Previous place was at the end of RenderObject::StyleDidChange, where it could
have been missed because of an early exit. For example, cursor change on mousedown/up on
a text node missed the correct cursor in the first pass.

Refactored EventHandler::selectCursor to not take a whole mouse event but instead work with
HitTestResult so that EventHandler::updateCursor must not create a useless PlatformEvent.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=85343 (mousemove event on cursor change)

https://bugs.webkit.org/show_bug.cgi?id=53341 (no cursor change when mouse button down)

Tests: fast/events/mouse-cursor-change.html

fast/events/mouse-cursor-no-mousemove.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateCursor): Newly added method for updating mouse cursor
(WebCore):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):

  • page/EventHandler.h:

(EventHandler):

  • rendering/RenderObject.cpp:

(WebCore::areNonIdenticalCursorListsEqual):
(WebCore):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

LayoutTests: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857
Changing CSS cursor should work no matter is mouse button is pressed or not
https://bugs.webkit.org/show_bug.cgi?id=53341

Patch by Aivo Paas <aivopaas@gmail.com> on 2013-02-14
Reviewed by Allan Sandfeld Jensen.

Added tests for changing cursor on mousemove, mousedown, mouseup and mousemove
while mouse button being hold down. Also added test to verify that a mousemove
event is not fired for changing cursor while mouse is not moving.

  • fast/events/mouse-cursor-change-expected.txt: Added.
  • fast/events/mouse-cursor-change.html: Added.
  • fast/events/mouse-cursor-no-mousemove-expected.txt: Added.
  • fast/events/mouse-cursor-no-mousemove.html: Added.
  • platform/mac/TestExpectations:
1:16 AM Changeset in webkit [142860] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r142841.
http://trac.webkit.org/changeset/142841
https://bugs.webkit.org/show_bug.cgi?id=109791

Caused webkit_unit_tests to crash on chromium bots. (Requested
by atwilson_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14

Source/Platform:

  • chromium/public/WebUnitTestSupport.h:

(WebKit):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

12:57 AM Changeset in webkit [142859] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Silence GSettings-related warning.
https://bugs.webkit.org/show_bug.cgi?id=109749

Reviewed by Martin Robinson.

Apply the same change done to the GTK+ port in r109127; this
silences the warnings printed by glib about the memory GSettings
backend being used.

Not only does this make the bots (as well as manual runs of, say,
WebKitTestRunner) much more silent, but it also removes an stderr
line (which run-perf-tests considers as a failure).

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.setup_environ_for_server): Explicitly set the
GSETTINGS_BACKEND environment variable to "memory".

12:38 AM Changeset in webkit [142858] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: Report child nodes as direct members of a container node to make them look like a tree in the snapshot.
https://bugs.webkit.org/show_bug.cgi?id=109703

Also we need to traverse the tree from the top root element down to the leaves.

Reviewed by Yury Semikhatsky.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

12:07 AM Changeset in webkit [142857] by jochen@chromium.org
  • 11 edits
    2 moves in trunk/Tools

[chromium] move mock notification presenter to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109706

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner::WebTestProxy::notificationPresenter):

  • DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.

(WebTestRunner::NotificationPresenter::NotificationPresenter):
(WebTestRunner):
(WebTestRunner::NotificationPresenter::~NotificationPresenter):
(WebTestRunner::NotificationPresenter::grantPermission):
(WebTestRunner::NotificationPresenter::simulateClick):
(WebTestRunner::NotificationPresenter::show):
(WebTestRunner::NotificationPresenter::cancel):
(WebTestRunner::NotificationPresenter::objectDestroyed):
(WebTestRunner::NotificationPresenter::checkPermission):
(WebTestRunner::NotificationPresenter::requestPermission):

  • DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.

(WebTestRunner):
(NotificationPresenter):
(WebTestRunner::NotificationPresenter::setDelegate):
(WebTestRunner::NotificationPresenter::reset):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setDelegate):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::notificationPresenter):
(WebTestRunner):
(WebTestRunner::TestRunner::grantWebNotificationPermission):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebKit):
(WebTestRunner):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::notificationPresenter):
(WebTestRunner):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::resetTestController):

  • DumpRenderTree/chromium/TestShell.h:

(WebKit):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
12:01 AM Changeset in webkit [142856] by gman@chromium.org
  • 2 edits
    15 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests limits folder.
https://bugs.webkit.org/show_bug.cgi?id=108904

Reviewed by Kenneth Russell.

  • platform/mac/TestExpectations:
  • webgl/conformance/limits/gl-max-texture-dimensions-expected.txt: Added.
  • webgl/conformance/limits/gl-max-texture-dimensions.html: Added.
  • webgl/conformance/limits/gl-min-attribs-expected.txt: Added.
  • webgl/conformance/limits/gl-min-attribs.html: Added.
  • webgl/conformance/limits/gl-min-textures-expected.txt: Added.
  • webgl/conformance/limits/gl-min-textures.html: Added.
  • webgl/conformance/limits/gl-min-uniforms-expected.txt: Added.
  • webgl/conformance/limits/gl-min-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/limits/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/limits/gl-max-texture-dimensions.html: Added.
  • webgl/resources/webgl_test_files/conformance/limits/gl-min-attribs.html: Added.
  • webgl/resources/webgl_test_files/conformance/limits/gl-min-textures.html: Added.
  • webgl/resources/webgl_test_files/conformance/limits/gl-min-uniforms.html: Added.

Feb 13, 2013:

11:51 PM Changeset in webkit [142855] by hayato@chromium.org
  • 21 edits
    22 adds in trunk

[Shadow DOM] Implements a '::distributed()' pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=82169

Reviewed by Dimitri Glazkov.

Source/WebCore:

Implements a '::distributed()' pseudo element.
See the Shadow DOM specification and the filed bug for the detail.

For example, suppose we are given the following DOM tree and shadow tree:

  • <A>
    • <B>
      • <C>

[A's ShadowRoot]

<D>

  • <style>

E content::distributed(B C) { color: green; }

  • <E>
    • <content> (Node B is distributed to this insertion point.)

In this case, the style rule defined in the shadow tree matches node 'C'.

A '::distributed()' pseudo element can not be a pseudo class since
an intersection between matched_elements(some_selector) and
matched_elements(some_selector::distributed(...)) is always an
empty set. A '::distributed()' pseudo element is the first-ever
*functional* pseudo element which takes a parameter, which can be
a selector.

This rule crosses the shadow boundary from a shadow tree to the
tree of its shadow host. That means a rule which includes
'::distributed()' pseudo element is defined in shadow tree, but
the node which is matched in the rule, the subject of the
selector, is outside of the shadow tree. Therefore, we cannot
predict where the subject of the selector will be beforehand.
Current CSS implementation assumes the subject of the selector
must exist in the current scope.

To overcome this issue, DocumentRuleSets now has a instance of
ShadowDistributedRules class. A style rule will be stored in this
instance if the rule includes a '::distributed()' pseudo element.
This class also keeps track of each RuleSet by mapping it with a
scope where the rule was originally defined. In the example, the
scope is A's ShadowRoot. The scope is used to check whether the
left-most matched element (in the example, it's a node 'E') exists
in the scope.

Internally, a '::distributed' pseudo element is represented by a
newly introduced 'ShadowDistributed' relation. That makes an
implementation of SelectorChecker::checkSelector() much simpler.
A transformation from a distributed pseudo element to a
ShadowDistributed is done in parsing stage of CSS.

Since '::distributed()' is an experimental feature, it's actually
prefixed with '-webkit-' and guarded by SHADOW_DOM flag.

Tests: fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html

fast/dom/shadow/distributed-pseudo-element-match-all.html
fast/dom/shadow/distributed-pseudo-element-match-descendant.html
fast/dom/shadow/distributed-pseudo-element-nested.html
fast/dom/shadow/distributed-pseudo-element-no-match.html
fast/dom/shadow/distributed-pseudo-element-reprojection.html
fast/dom/shadow/distributed-pseudo-element-scoped.html
fast/dom/shadow/distributed-pseudo-element-support-selector.html
fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html
fast/dom/shadow/distributed-pseudo-element-with-any.html
fast/dom/shadow/distributed-pseudo-element.html

  • css/CSSGrammar.y.in:

CSS Grammar was updated to support '::distrbuted(selector)'.
This pseudo element is the first pseudo element which can take a selector as a parameter.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Here we are converting a '::distributed' pseudo element into a
ShadowDistributed relation internally. To support the conversion,
these rewriteSpecifiersXXX functions (formally called
updateSpecifiersXXX) now return the specifiers which may be
converted.
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParser.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):

  • css/CSSParserValues.h:

(CSSParserSelector):
(WebCore::CSSParserSelector::functionArgumentSelector):
To hold an intermediate selector which appears at the position of an argument in
functional pseudo element when parsing CSS.
(WebCore::CSSParserSelector::setFunctionArgumentSelector):
(WebCore::CSSParserSelector::isDistributedPseudoElement):

  • css/CSSSelector.cpp:

Add new pseudo element, PseudoDistributed, and its internal representation, ShadowDistributed relation.
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(CSSSelector):
(WebCore):
(WebCore::CSSSelector::isDistributedPseudoElement):
(WebCore::CSSSelector::isShadowDistributed):

  • css/CSSSelectorList.cpp:

(WebCore):
(SelectorHasShadowDistributed):
(WebCore::SelectorHasShadowDistributed::operator()):
(WebCore::CSSSelectorList::hasShadowDistributedAt):

  • css/CSSSelectorList.h:

(CSSSelectorList):

  • css/DocumentRuleSets.cpp:

(WebCore):
(WebCore::ShadowDistributedRules::addRule):
Every CSS rule which includes '::distributed(...)' should be managed by calling this function.
(WebCore::ShadowDistributedRules::collectMatchRequests):
(WebCore::DocumentRuleSets::resetAuthorStyle):

  • css/DocumentRuleSets.h:

(WebCore):
(ShadowDistributedRules):
(WebCore::ShadowDistributedRules::clear):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::shadowDistributedRules)
DocumentRuleSets owns an instance of ShadowDistributedRules.

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):
Updated to check whether the rule contains '::distributed()' or not.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
Support ShadowDistributed relation. Check all possible insertion points where a node is distributed.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
Adds enum of BehaviorAtBoundary. '::distributed()' is the only
rule which uses 'CrossedBoundary' since it is the only rule which
crosses shadow boundaries.
(SelectorCheckingContext):

  • css/SelectorFilter.cpp:

(WebCore::SelectorFilter::collectIdentifierHashes):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::ruleMatches):

  • css/StyleResolver.h:

(MatchRequest):
(WebCore::MatchRequest::MatchRequest): Add behaviorAtBoundary field.
(WebCore):
(StyleResolver):

  • html/shadow/InsertionPoint.cpp:

(WebCore::collectInsertionPointsWhereNodeIsDistributed):
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore):

LayoutTests:

  • fast/dom/shadow/distributed-pseudo-element-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-for-shadow-element-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-all-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-all.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-descendant-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-descendant.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-nested-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-nested.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-no-match-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-no-match.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-reprojection-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-reprojection.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-scoped-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-scoped.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-support-selector-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-support-selector.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-used-in-selector-list-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-with-any-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-with-any.html: Added.
  • fast/dom/shadow/distributed-pseudo-element.html: Added.
11:41 PM Changeset in webkit [142854] by gman@chromium.org
  • 1 edit
    126 adds in trunk/LayoutTests

Add WebGL Conformance Tests more folder.
https://bugs.webkit.org/show_bug.cgi?id=109118

Reviewed by Kenneth Russell.

  • webgl/conformance/more/conformance/constants-expected.txt: Added.
  • webgl/conformance/more/conformance/constants.html: Added.
  • webgl/conformance/more/conformance/getContext-expected.txt: Added.
  • webgl/conformance/more/conformance/getContext.html: Added.
  • webgl/conformance/more/conformance/methods-expected.txt: Added.
  • webgl/conformance/more/conformance/methods.html: Added.
  • webgl/conformance/more/conformance/webGLArrays-expected.txt: Added.
  • webgl/conformance/more/conformance/webGLArrays.html: Added.
  • webgl/conformance/more/functions/bindBuffer-expected.txt: Added.
  • webgl/conformance/more/functions/bindBuffer.html: Added.
  • webgl/conformance/more/functions/bindBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bindBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/bindFramebufferLeaveNonZero-expected.txt: Added.
  • webgl/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
  • webgl/conformance/more/functions/bufferData-expected.txt: Added.
  • webgl/conformance/more/functions/bufferData.html: Added.
  • webgl/conformance/more/functions/bufferSubData-expected.txt: Added.
  • webgl/conformance/more/functions/bufferSubData.html: Added.
  • webgl/conformance/more/functions/bufferSubDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferSubDataBadArgs.html: Added.
  • webgl/conformance/more/functions/isTests-expected.txt: Added.
  • webgl/conformance/more/functions/isTests.html: Added.
  • webgl/conformance/more/functions/isTestsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/isTestsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixels-expected.txt: Added.
  • webgl/conformance/more/functions/readPixels.html: Added.
  • webgl/conformance/more/functions/texImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2D.html: Added.
  • webgl/conformance/more/functions/texImage2DHTMLBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2D.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTMLBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformMatrix-expected.txt: Added.
  • webgl/conformance/more/functions/uniformMatrix.html: Added.
  • webgl/conformance/more/functions/uniformMatrixBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformMatrixBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformf-expected.txt: Added.
  • webgl/conformance/more/functions/uniformf.html: Added.
  • webgl/conformance/more/functions/uniformfArrayLen1-expected.txt: Added.
  • webgl/conformance/more/functions/uniformfArrayLen1.html: Added.
  • webgl/conformance/more/functions/uniformfBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformfBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformi-expected.txt: Added.
  • webgl/conformance/more/functions/uniformi.html: Added.
  • webgl/conformance/more/functions/uniformiBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformiBadArgs.html: Added.
  • webgl/conformance/more/functions/vertexAttrib-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttrib.html: Added.
  • webgl/conformance/more/functions/vertexAttribBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribBadArgs.html: Added.
  • webgl/conformance/more/functions/vertexAttribPointer-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribPointer.html: Added.
  • webgl/conformance/more/functions/vertexAttribPointerBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
  • webgl/conformance/more/glsl/arrayOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/glsl/arrayOutOfBounds.html: Added.
  • webgl/conformance/more/glsl/uniformOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/glsl/uniformOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/more/README.md: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests_linkonly.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests_sequential.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-A.js: Added.

(ArgGenerators.activeTexture.generate):
(ArgGenerators.activeTexture.checkArgValidity):
(ArgGenerators.activeTexture.teardown):
(ArgGenerators.attachShader.generate):
(ArgGenerators.attachShader.checkArgValidity):
(ArgGenerators.attachShader.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B1.js: Added.

(ArgGenerators.bindAttribLocation.generate):
(ArgGenerators.bindAttribLocation.checkArgValidity):
(ArgGenerators.bindAttribLocation.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B2.js: Added.

(ArgGenerators.bindBuffer.generate):
(ArgGenerators.bindBuffer.checkArgValidity):
(ArgGenerators.bindBuffer.cleanup):
(ArgGenerators.bindFramebuffer.generate):
(ArgGenerators.bindFramebuffer.checkArgValidity):
(ArgGenerators.bindFramebuffer.cleanup):
(ArgGenerators.bindRenderbuffer.generate):
(ArgGenerators.bindRenderbuffer.checkArgValidity):
(ArgGenerators.bindRenderbuffer.cleanup):
(ArgGenerators.bindTexture.generate):
(ArgGenerators.bindTexture.checkArgValidity):
(ArgGenerators.bindTexture.cleanup):
(ArgGenerators.blendColor.generate):
(ArgGenerators.blendColor.teardown):
(ArgGenerators.blendEquation.generate):
(ArgGenerators.blendEquation.checkArgValidity):
(ArgGenerators.blendEquation.teardown):
(ArgGenerators.blendEquationSeparate.generate):
(ArgGenerators.blendEquationSeparate.checkArgValidity):
(ArgGenerators.blendEquationSeparate.teardown):
(ArgGenerators.blendFunc.generate):
(ArgGenerators.blendFunc.checkArgValidity):
(ArgGenerators.blendFunc.teardown):
(ArgGenerators.blendFuncSeparate.generate):
(ArgGenerators.blendFuncSeparate.checkArgValidity):
(ArgGenerators.blendFuncSeparate.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B3.js: Added.

(ArgGenerators.bufferData.setup):
(ArgGenerators.bufferData.generate):
(ArgGenerators.bufferData.checkArgValidity):
(ArgGenerators.bufferData.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B4.js: Added.

(ArgGenerators.bufferSubData.setup):
(ArgGenerators.bufferSubData.generate):
(ArgGenerators.bufferSubData.checkArgValidity):
(ArgGenerators.bufferSubData.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-C.js: Added.

(ArgGenerators.checkFramebufferStatus.generate):
(ArgGenerators.checkFramebufferStatus.checkArgValidity):
(ArgGenerators.checkFramebufferStatus.cleanup):
(ArgGenerators.clear.generate):
(ArgGenerators.clear.checkArgValidity):
(ArgGenerators.clearColor.generate):
(ArgGenerators.clearColor.teardown):
(ArgGenerators.clearDepth.generate):
(ArgGenerators.clearDepth.teardown):
(ArgGenerators.clearStencil.generate):
(ArgGenerators.clearStencil.teardown):
(ArgGenerators.colorMask.generate):
(ArgGenerators.colorMask.teardown):
(ArgGenerators.createBuffer.generate):
(ArgGenerators.createBuffer.returnValueCleanup):
(ArgGenerators.createFramebuffer.generate):
(ArgGenerators.createFramebuffer.returnValueCleanup):
(ArgGenerators.createProgram.generate):
(ArgGenerators.createProgram.returnValueCleanup):
(ArgGenerators.createRenderbuffer.generate):
(ArgGenerators.createRenderbuffer.returnValueCleanup):
(ArgGenerators.createShader.generate):
(ArgGenerators.createShader.checkArgValidity):
(ArgGenerators.createShader.returnValueCleanup):
(ArgGenerators.createTexture.generate):
(ArgGenerators.createTexture.returnValueCleanup):
(ArgGenerators.cullFace.generate):
(ArgGenerators.cullFace.checkArgValidity):
(ArgGenerators.cullFace.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-D_G.js: Added.

(ArgGenerators.deleteBuffer.generate):
(ArgGenerators.deleteBuffer.checkArgValidity):
(ArgGenerators.deleteBuffer.cleanup):
(ArgGenerators.deleteFramebuffer.generate):
(ArgGenerators.deleteFramebuffer.checkArgValidity):
(ArgGenerators.deleteFramebuffer.cleanup):
(ArgGenerators.deleteProgram.generate):
(ArgGenerators.deleteProgram.checkArgValidity):
(ArgGenerators.deleteProgram.cleanup):
(ArgGenerators.deleteRenderbuffer.generate):
(ArgGenerators.deleteRenderbuffer.checkArgValidity):
(ArgGenerators.deleteRenderbuffer.cleanup):
(ArgGenerators.deleteShader.generate):
(ArgGenerators.deleteShader.checkArgValidity):
(ArgGenerators.deleteShader.cleanup):
(ArgGenerators.deleteTexture.generate):
(ArgGenerators.deleteTexture.checkArgValidity):
(ArgGenerators.deleteTexture.cleanup):
(ArgGenerators.depthFunc.generate):
(ArgGenerators.depthFunc.checkArgValidity):
(ArgGenerators.depthFunc.teardown):
(ArgGenerators.depthMask.generate):
(ArgGenerators.depthMask.teardown):
(ArgGenerators.depthRange.generate):
(ArgGenerators.depthRange.teardown):
(ArgGenerators.detachShader.generate):
(ArgGenerators.detachShader.checkArgValidity):
(ArgGenerators.detachShader.cleanup):
(ArgGenerators.disable.generate):
(ArgGenerators.disable.checkArgValidity):
(ArgGenerators.disable.cleanup):
(ArgGenerators.disableVertexAttribArray.generate):
(ArgGenerators.disableVertexAttribArray.checkArgValidity):
(ArgGenerators.enable.generate):
(ArgGenerators.enable.checkArgValidity):
(ArgGenerators.enable.cleanup):
(ArgGenerators.enableVertexAttribArray.generate):
(ArgGenerators.enableVertexAttribArray.checkArgValidity):
(ArgGenerators.enableVertexAttribArray.cleanup):
(ArgGenerators.finish.generate):
(ArgGenerators.flush.generate):
(ArgGenerators.frontFace.generate):
(ArgGenerators.frontFace.checkArgValidity):
(ArgGenerators.frontFace.cleanup):
(ArgGenerators.generateMipmap.setup):
(ArgGenerators.generateMipmap.generate):
(ArgGenerators.generateMipmap.checkArgValidity):
(ArgGenerators.generateMipmap.teardown):
(ArgGenerators.getAttachedShaders.setup):
(ArgGenerators.getAttachedShaders.generate):
(ArgGenerators.getAttachedShaders.checkArgValidity):
(ArgGenerators.getAttachedShaders.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-G_I.js: Added.

(ArgGenerators.getAttribLocation.generate):
(ArgGenerators.getAttribLocation.checkArgValidity):
(ArgGenerators.getAttribLocation.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-L_S.js: Added.

(ArgGenerators.lineWidth.generate):
(ArgGenerators.lineWidth.teardown):
(ArgGenerators.pixelStorei.generate):
(ArgGenerators.pixelStorei.checkArgValidity):
(ArgGenerators.pixelStorei.teardown):
(ArgGenerators.polygonOffset.generate):
(ArgGenerators.polygonOffset.teardown):
(ArgGenerators.sampleCoverage.generate):
(ArgGenerators.sampleCoverage.teardown):
(ArgGenerators.scissor.generate):
(ArgGenerators.scissor.checkArgValidity):
(ArgGenerators.scissor.teardown):
(ArgGenerators.stencilFunc.generate):
(ArgGenerators.stencilFunc.checkArgValidity):
(ArgGenerators.stencilFunc.teardown):
(ArgGenerators.stencilFuncSeparate.generate):
(ArgGenerators.stencilFuncSeparate.checkArgValidity):
(ArgGenerators.stencilFuncSeparate.teardown):
(ArgGenerators.stencilMask.generate):
(ArgGenerators.stencilMask.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-S_V.js: Added.

(ArgGenerators.stencilMaskSeparate.generate):
(ArgGenerators.stencilMaskSeparate.checkArgValidity):
(ArgGenerators.stencilMaskSeparate.teardown):
(ArgGenerators.stencilOp.generate):
(ArgGenerators.stencilOp.checkArgValidity):
(ArgGenerators.stencilOp.teardown):
(ArgGenerators.stencilOpSeparate.generate):
(ArgGenerators.stencilOpSeparate.checkArgValidity):
(ArgGenerators.stencilOpSeparate.teardown):
(ArgGenerators.texImage2D.setup):
(ArgGenerators.texImage2D.generate):
(ArgGenerators.texImage2D.checkArgValidity):
(ArgGenerators.texImage2D.teardown):
(ArgGenerators.texParameterf.generate):
(ArgGenerators.texParameterf.checkArgValidity):
(ArgGenerators.texParameteri.generate):
(ArgGenerators.texParameteri.checkArgValidity):
(ArgGenerators.viewport.generate):
(ArgGenerators.viewport.checkArgValidity):
(ArgGenerators.viewport.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/badArgsArityLessThanArgc.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/constants.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/fuzzTheAPI.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/getContext.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/methods.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI.js: Added.

(Array.from):
(Array.prototype.has):
(Array.prototype.random):
(castToInt):
(constCheck.a.has):
(constCheck):
(isBufferData):
(isVertexAttribute):
(isValidName):
(randomWebGLArray):
(randomArrayBuffer):
(randomBufferData):
(randomSmallWebGLArray):
(randomBufferSubData):
(randomColor):
(randomName):
(randomVertexAttribute):
(randomBool):
(randomStencil):
(randomLineWidth):
(randomImage):
(mutateArgs):
(argGeneratorTestRunner):

  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPIBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/webGLArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/demos/opengl_web.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/demos/video.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindBuffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferData.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferSubData.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferSubDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/isTests.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/isTestsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixels.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrix.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrixBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformf.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformfArrayLen1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformfBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformi.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformiBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointer.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/arrayOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/longLoops.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/uniformOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/unusedAttribsUniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/index.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/CPUvsGPU.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/bandwidth.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsGCPause.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsMatrixMult.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsToGLOverhead.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/unit.css: Added.

(.ok):
(.fail):
(canvas):
(#test-status):
(#test-log):
(#test-log > div):
(#test-log h2):
(#test-log h3):
(#test-log p):

  • webgl/resources/webgl_test_files/conformance/more/unit.js: Added.

(.window.console.log):
(.window.console.error):
(Tests.startUnit):
(Tests.setup):
(Tests.teardown):
(Tests.endUnit):
(.):
(Object.toSource):

  • webgl/resources/webgl_test_files/conformance/more/util.js: Added.

(loadTexture):
(getShader):
(loadShaderArray):
(loadShader):
(getGLErrorAsString):
(checkError):
(throwError):
(Math.cot):
(Matrix.newIdentity):
(Matrix.newIdentity3x3):
(Matrix.copyMatrix):
(Matrix.to3x3):
(Matrix.inverseON):
(Matrix.inverseTo3x3):
(Matrix.inverseTo3x3InPlace):
(Matrix.inverse3x3):
(Matrix.inverse3x3InPlace):
(Matrix.frustum):
(Matrix.perspective):
(Matrix.mul4x4):
(Matrix.mul4x4InPlace):
(Matrix.mulv4):
(Matrix.rotate):
(Matrix.rotateInPlace):
(Matrix.scale):
(Matrix.scale3):
(Matrix.scale1):
(Matrix.scale3InPlace):
(Matrix.scale1InPlace):
(Matrix.scaleInPlace):
(Matrix.translate3):
(Matrix.translate):
(Matrix.translate3InPlace):
(Matrix.translateInPlace):
(Matrix.lookAt):
(Matrix.transpose4x4):
(Matrix.transpose4x4InPlace):
(Matrix.transpose3x3):
(Matrix.transpose3x3InPlace):
(Vec3.make):
(Vec3.copy):
(Vec3.add):
(Vec3.sub):
(Vec3.negate):
(Vec3.direction):
(Vec3.normalizeInPlace):
(Vec3.normalize):
(Vec3.scale):
(Vec3.dot):
(Vec3.inner):
(Vec3.cross):
(Shader):
(Shader.prototype.destroy):
(Shader.prototype.compile):
(Shader.prototype.use):
(Shader.prototype.uniform1fv):
(Shader.prototype.uniform2fv):
(Shader.prototype.uniform3fv):
(Shader.prototype.uniform4fv):
(Shader.prototype.uniform1f):
(Shader.prototype.uniform2f):
(Shader.prototype.uniform3f):
(Shader.prototype.uniform4f):
(Shader.prototype.uniform1iv):
(Shader.prototype.uniform2iv):
(Shader.prototype.uniform3iv):
(Shader.prototype.uniform4iv):
(Shader.prototype.uniform1i):
(Shader.prototype.uniform2i):
(Shader.prototype.uniform3i):
(Shader.prototype.uniform4i):
(Shader.prototype.uniformMatrix4fv):
(Shader.prototype.uniformMatrix3fv):
(Shader.prototype.uniformMatrix2fv):
(Shader.prototype.attrib):
(Shader.prototype.uniform):
(Filter):
(Filter.prototype.apply):
(VBO):
(VBO.prototype.setData):
(VBO.prototype.destroy):
(VBO.prototype.init):
(VBO.prototype.use):
(VBO.prototype.draw):
(FBO):
(FBO.prototype.destroy):
(FBO.prototype.init):
(FBO.prototype.getTempCanvas):
(FBO.prototype.use):
(GLError):
(makeGLErrorWrapper):
(wrapGLContext.wrap.getError):
(getGLContext):
(assertSomeGLError):
(assertThrowNoGLError):
(Quad.makeVBO):
(.gl):
(Quad.getCachedVBO):
(deleteShader):
(Cube.create):
(Cube.makeVBO):
(Cube.getCachedVBO):
(Sphere.create.vert):
(Sphere.create):
(initGL_CONTEXT_ID):

11:36 PM Changeset in webkit [142853] by gman@chromium.org
  • 1 edit
    45 adds in trunk/LayoutTests

Add the WebGL Conformance Tests extensions folder.
https://bugs.webkit.org/show_bug.cgi?id=109117

Reviewed by Kenneth Russell.

  • webgl/conformance/extensions/ext-texture-filter-anisotropic-expected.txt: Added.
  • webgl/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
  • webgl/conformance/extensions/get-extension-expected.txt: Added.
  • webgl/conformance/extensions/get-extension.html: Added.
  • webgl/conformance/extensions/oes-element-index-uint-expected.txt: Added.
  • webgl/conformance/extensions/oes-element-index-uint.html: Added.
  • webgl/conformance/extensions/oes-standard-derivatives-expected.txt: Added.
  • webgl/conformance/extensions/oes-standard-derivatives.html: Added.
  • webgl/conformance/extensions/oes-texture-float-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-canvas-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-canvas.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-data-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-data.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-video-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-video.html: Added.
  • webgl/conformance/extensions/oes-texture-float.html: Added.
  • webgl/conformance/extensions/oes-vertex-array-object-expected.txt: Added.
  • webgl/conformance/extensions/oes-vertex-array-object.html: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
  • webgl/conformance/extensions/webgl-debug-renderer-info-expected.txt: Added.
  • webgl/conformance/extensions/webgl-debug-renderer-info.html: Added.
  • webgl/conformance/extensions/webgl-debug-shaders-expected.txt: Added.
  • webgl/conformance/extensions/webgl-debug-shaders.html: Added.
  • webgl/conformance/extensions/webgl-depth-texture-expected.txt: Added.
  • webgl/conformance/extensions/webgl-depth-texture.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/get-extension.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-standard-derivatives.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-vertex-array-object.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-renderer-info.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-shaders.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html: Added.
11:31 PM Changeset in webkit [142852] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark new WebGL conformance tests added in r142847 as failing for
EFL WK2.

  • platform/efl-wk2/TestExpectations:
11:10 PM Changeset in webkit [142851] by gman@chromium.org
  • 1 edit
    454 adds in trunk/LayoutTests

Add the WebGL Conformance Tests ogles folder.
https://bugs.webkit.org/show_bug.cgi?id=109116

Reviewed by Kenneth Russell.

  • webgl/conformance/ogles/GL/abs/abs_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/all/all_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/all/all_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/any/any_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/any/any_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/array/array_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/array/array_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/ceil/ceil_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/clamp/clamp_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
  • webgl/conformance/ogles/GL/cos/cos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/cross/cross_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/default/default_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/default/default_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/degrees/degrees_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/discard/discard_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/distance/distance_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/dot/dot_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/equal/equal_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/equal/equal_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/exp/exp_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/exp/exp_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/floor/floor_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/fract/fract_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_057_to_064-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_065_to_072-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_073_to_080-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_081_to_088-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_089_to_096-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_097_to_104-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_105_to_112-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_113_to_120-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_121_to_126-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
  • webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt: Added.
  • webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
  • webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/length/length_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/length/length_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_041_to_046-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
  • webgl/conformance/ogles/GL/mat3/mat3_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/max/max_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/max/max_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/min/min_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/min/min_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/mix/mix_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/mod/mod_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/normalize/normalize_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/not/not_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/not/not_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_025_to_026-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/radians/radians_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/reflect/reflect_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/refract/refract_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sign/sign_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sin/sin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/step/step_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/step/step_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
  • webgl/conformance/ogles/GL/tan/tan_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_017_to_018-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
  • webgl/conformance/ogles/GL/vec3/vec3_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/array_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/README.md: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/mustpass.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/process-ogles2-tests.py: Added.

(Log):
(TransposeMatrix):
(GetValidTypeName):
(WriteOpen):
(TxtWriter):
(TxtWriter.init):
(TxtWriter.Write):
(TxtWriter.Close):
(ReadFileAsLines):
(ReadFile):
(Chunkify):
(GetText):
(GetElementText):
(GetBoolElement):
(GetModel):
(RelativizePaths):
(CopyFile):
(CopyShader):
(IsOneOf):
(CheckForUnknownTags):
(IsFileWeWant):
(TestReader):
(TestReader.to):
(TestReader.init):
(TestReader.Print):
(TestReader.MakeOutPath):
(TestReader.ReadTests):
(TestReader.ReadTest):
(TestReader.ProcessTest):
(TestReader.WriteTests):
(CopyShaders):
(Process_compare):
(Process_shaderload):
(Process_extension):
(Process_createtests):
(Process_GL2Test):
(Process_uniformquery):
(Process_egl_image_external):
(Process_dismount):
(Process_build):
(Process_coverage):
(Process_attributes):
(Process_fixed):
(main):

10:56 PM Changeset in webkit [142850] by gman@chromium.org
  • 1 edit
    592 adds in trunk/LayoutTests

Add WebGL Conformance Tests glsl folder.
https://bugs.webkit.org/show_bug.cgi?id=109115

Reviewed by Kenneth Russell.

  • webgl/conformance/glsl/functions/glsl-function-abs-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-abs.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-acos-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-acos.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-asin-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-asin.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-xy-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-ceil-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-ceil.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-cos-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-cos.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-cross-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-cross.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-distance-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-distance.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-dot-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-dot.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-faceforward-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-faceforward.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-floor-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-floor.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-fract-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-fract.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-length-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-length.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-normalize-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-normalize.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-reflect-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-reflect.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-sign-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-sign.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-sin-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-sin.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function.html: Added.
  • webgl/conformance/glsl/implicit/add_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_int_to_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/construct_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/construct_struct.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/greater_than.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/greater_than.vert.html: Added.
  • webgl/conformance/glsl/implicit/greater_than_equal.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
  • webgl/conformance/glsl/implicit/less_than.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/less_than.vert.html: Added.
  • webgl/conformance/glsl/implicit/less_than_equal.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/less_than_equal.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/matrices/glsl-mat4-to-mat3-expected.txt: Added.
  • webgl/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
  • webgl/conformance/glsl/misc/attrib-location-length-limits-expected.txt: Added.
  • webgl/conformance/glsl/misc/attrib-location-length-limits.html: Added.
  • webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden-expected.txt: Added.
  • webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
  • webgl/conformance/glsl/misc/glsl-function-nodes-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-function-nodes.html: Added.
  • webgl/conformance/glsl/misc/glsl-long-variable-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-long-variable-names.html: Added.
  • webgl/conformance/glsl/misc/glsl-vertex-branch-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-vertex-branch.html: Added.
  • webgl/conformance/glsl/misc/large-loop-compile-expected.txt: Added.
  • webgl/conformance/glsl/misc/large-loop-compile.html: Added.
  • webgl/conformance/glsl/misc/non-ascii-comments.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
  • webgl/conformance/glsl/misc/non-ascii.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/non-ascii.vert.html: Added.
  • webgl/conformance/glsl/misc/re-compile-re-link-expected.txt: Added.
  • webgl/conformance/glsl/misc/re-compile-re-link.html: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-define-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-define.html: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-define-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-define.html: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-array.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-clipvertex.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-assignment-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-do-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-do-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-with-error-directive-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-error-directive.html: Added.
  • webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-float-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-for-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-for-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-with-for-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-for-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-frag-depth.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-function-recursion.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-function-scoped-struct-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
  • webgl/conformance/glsl/misc/shader-with-functional-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-glcolor.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-1.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-symbol.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
  • webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-include.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-include.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-int-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-limited-indexing.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-long-line-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-long-line.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-quoted-error.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-too-many-uniforms-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
  • webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-120.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-130.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-while-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-while-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-without-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-without-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-missing-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
  • webgl/conformance/glsl/misc/shared-expected.txt: Added.
  • webgl/conformance/glsl/misc/shared.html: Added.
  • webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum-expected.txt: Added.
  • webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
  • webgl/conformance/glsl/misc/struct-nesting-under-maximum-expected.txt: Added.
  • webgl/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
  • webgl/conformance/glsl/misc/uniform-location-length-limits-expected.txt: Added.
  • webgl/conformance/glsl/misc/uniform-location-length-limits.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_field.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_field.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_function.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_function.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_variable.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_field.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_field.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_function.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_function.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_preprocessor_reserved-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
  • webgl/conformance/glsl/reserved/webgl_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_struct.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_variable.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_variable.vert.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2d-bias-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dlod-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dproj-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
  • webgl/conformance/glsl/variables/gl-fragcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-fragcoord.html: Added.
  • webgl/conformance/glsl/variables/gl-frontfacing-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-frontfacing.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-abs.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-acos.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-asin.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-ceil.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cos.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cross.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-distance.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-dot.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-faceforward.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-floor.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-fract.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-length.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-lessThan.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-normalize.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-reflect.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-refract.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sign.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sin.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/construct_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than_equal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/matrices/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/attrib-location-length-limits.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/foo: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-2types-of-textures-on-same-unit.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-function-nodes.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-long-variable-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-vertex-branch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/include.vs: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/large-loop-compile.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/re-compile-re-link.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-define.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-define.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-do-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-error-directive.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-include.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-long-line.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-while-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-without-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shared.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/uniform-location-length-limits.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_field.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_function.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_field.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_function.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_variable.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-fragcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-frontfacing.html: Added.
10:17 PM Changeset in webkit [142849] by haraken@chromium.org
  • 45 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom methods
https://bugs.webkit.org/show_bug.cgi?id=109678

Reviewed by Adam Barth.

Currently V8 directly calls back custom methods written
in custom binding files. This makes it impossible for code
generators to hook custom methods (e.g. Code generators cannot
insert a code for FeatureObservation into custom methods).
To solve the problem, we should generate wrapper methods for
custom methods.

No tests. No change in behavior.

  • page/DOMWindow.idl: Removed overloaded methods. The fact that methods in an IDL

file are overloaded but they are not overloaded in custom bindings confuses code
generators. (For some reason, this problem hasn't appeared before this change.)

  • xml/XMLHttpRequest.idl: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateEventListenerCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod3Callback):
(TestInterfaceV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customMethodWithArgsCallback):
(WebCore::TestObjV8Internal::classMethod2Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallbackCustom):
(WebCore::V8Clipboard::setDragImageCallbackCustom):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::traceCallbackCustom):
(WebCore::V8Console::assertCallbackCustom):
(WebCore::V8Console::profileCallbackCustom):
(WebCore::V8Console::profileEndCallbackCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallbackCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallbackCustom):
(WebCore::V8DOMWindow::removeEventListenerCallbackCustom):
(WebCore::V8DOMWindow::postMessageCallbackCustom):
(WebCore::V8DOMWindow::toStringCallbackCustom):
(WebCore::V8DOMWindow::releaseEventsCallbackCustom):
(WebCore::V8DOMWindow::captureEventsCallbackCustom):
(WebCore::V8DOMWindow::showModalDialogCallbackCustom):
(WebCore::V8DOMWindow::openCallbackCustom):
(WebCore::V8DOMWindow::setTimeoutCallbackCustom):
(WebCore::V8DOMWindow::setIntervalCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8CallbackCustom):
(WebCore::V8DataView::getUint8CallbackCustom):
(WebCore::V8DataView::setInt8CallbackCustom):
(WebCore::V8DataView::setUint8CallbackCustom):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageCallbackCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallbackCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallbackCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallbackCustom):
(WebCore::V8Document::createTouchListCallbackCustom):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::V8Geolocation::getCurrentPositionCallbackCustom):
(WebCore::V8Geolocation::watchPositionCallbackCustom):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::itemCallbackCustom):
(WebCore::V8HTMLAllCollection::namedItemCallbackCustom):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallbackCustom):
(WebCore::V8HTMLCanvasElement::toDataURLCallbackCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::writeCallbackCustom):
(WebCore::V8HTMLDocument::writelnCallbackCustom):
(WebCore::V8HTMLDocument::openCallbackCustom):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::V8HTMLFormControlsCollection::namedItemCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallbackCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::setSelectionRangeCallbackCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::namedItemCallbackCustom):
(WebCore::V8HTMLOptionsCollection::removeCallbackCustom):
(WebCore::V8HTMLOptionsCollection::addCallbackCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::removeCallbackCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallbackCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameCallbackCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallbackCustom):
(WebCore::V8InjectedScriptHost::typeCallbackCustom):
(WebCore::V8InjectedScriptHost::functionDetailsCallbackCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesCallbackCustom):
(WebCore::V8InjectedScriptHost::getEventListenersCallbackCustom):
(WebCore::V8InjectedScriptHost::inspectCallbackCustom):
(WebCore::V8InjectedScriptHost::databaseIdCallbackCustom):
(WebCore::V8InjectedScriptHost::storageIdCallbackCustom):
(WebCore::V8InjectedScriptHost::evaluateCallbackCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallbackCustom):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallbackCustom):
(WebCore::V8InspectorFrontendHost::portCallbackCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallbackCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateCallbackCustom):
(WebCore::V8JavaScriptCallFrame::restartCallbackCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueCallbackCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeCallbackCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::reloadCallbackCustom):
(WebCore::V8Location::replaceCallbackCustom):
(WebCore::V8Location::assignCallbackCustom):
(WebCore::V8Location::valueOfCallbackCustom):
(WebCore::V8Location::toStringCallbackCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallbackCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventCallbackCustom):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::V8MessagePort::postMessageCallbackCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallbackCustom):
(WebCore::V8Node::replaceChildCallbackCustom):
(WebCore::V8Node::removeChildCallbackCustom):
(WebCore::V8Node::appendChildCallbackCustom):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallbackCustom):

  • bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionCallbackCustom):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallbackCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsCallbackCustom):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallbackCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getExtensionCallbackCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallbackCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getUniformCallbackCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvCallbackCustom):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallbackCustom):
(WebCore::V8WorkerContext::setTimeoutCallbackCustom):
(WebCore::V8WorkerContext::setIntervalCallbackCustom):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::postMessageCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallbackCustom):
(WebCore::V8XMLHttpRequest::sendCallbackCustom):

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::setParameterCallbackCustom):
(WebCore::V8XSLTProcessor::getParameterCallbackCustom):
(WebCore::V8XSLTProcessor::removeParameterCallbackCustom):

10:04 PM Changeset in webkit [142848] by commit-queue@webkit.org
  • 8 edits in trunk

JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
https://bugs.webkit.org/show_bug.cgi?id=109542

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

Source/WebCore:

"JSGenerateToJSObject" should be included in IDL files
of ChannelSplitterNode and ChannelMergerNode in WebAudio.
This ensures html files to access corresponding objects.

  • Modules/webaudio/ChannelMergerNode.idl:
  • Modules/webaudio/ChannelSplitterNode.idl:

LayoutTests:

Test cases updated to check validity of ChannelSplitterNode
and ChannelMergerNode Objects.

  • webaudio/audiochannelmerger-basic-expected.txt:
  • webaudio/audiochannelmerger-basic.html:
  • webaudio/audiochannelsplitter-expected.txt:
  • webaudio/audiochannelsplitter.html:
9:49 PM Changeset in webkit [142847] by gman@chromium.org
  • 3 edits
    249 adds in trunk/LayoutTests

Adds failing WebGL Conformance Tests.
https://bugs.webkit.org/show_bug.cgi?id=109075

Reviewed by Kenneth Russell.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/conformance/canvas/buffer-preserve-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • webgl/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/conformance/canvas/to-data-url-test-expected.txt: Added.
  • webgl/conformance/canvas/to-data-url-test.html: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/conformance/context/context-creation-and-destruction-expected.txt: Added.
  • webgl/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Added.
  • webgl/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/drawArrays-expected.txt: Added.
  • webgl/conformance/more/functions/drawArrays.html: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/conformance/more/functions/drawElements-expected.txt: Added.
  • webgl/conformance/more/functions/drawElements.html: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/conformance/programs/program-test-expected.txt: Added.
  • webgl/conformance/programs/program-test.html: Added.
  • webgl/conformance/reading/read-pixels-test-expected.txt: Added.
  • webgl/conformance/reading/read-pixels-test.html: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/conformance/rendering/gl-scissor-test-expected.txt: Added.
  • webgl/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/conformance/rendering/more-than-65536-indices-expected.txt: Added.
  • webgl/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/conformance/rendering/multisample-corruption-expected.txt: Added.
  • webgl/conformance/rendering/multisample-corruption.html: Added.
  • webgl/conformance/rendering/point-size-expected.txt: Added.
  • webgl/conformance/rendering/point-size.html: Added.
  • webgl/conformance/state/gl-object-get-calls-expected.txt: Added.
  • webgl/conformance/state/gl-object-get-calls.html: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/conformance/textures/gl-pixelstorei-expected.txt: Added.
  • webgl/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/conformance/textures/origin-clean-conformance-expected.txt: Added.
  • webgl/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/conformance/textures/texture-active-bind-2-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/conformance/textures/texture-active-bind-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind.html: Added.
  • webgl/conformance/textures/texture-mips-expected.txt: Added.
  • webgl/conformance/textures/texture-mips.html: Added.
  • webgl/conformance/textures/texture-npot-video-expected.txt: Added.
  • webgl/conformance/textures/texture-npot-video.html: Added.
  • webgl/conformance/textures/texture-size-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit.html: Added.
  • webgl/conformance/textures/texture-size.html: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/conformance/uniforms/uniform-default-values-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/conformance/uniforms/uniform-location-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-location.html: Added.
  • webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-samplers-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/program-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Added.
8:17 PM Changeset in webkit [142846] by Vineet
  • 4 edits in trunk/Source/WebCore

[Regression] After r142831 collection-null-like-arguments.html layout test failing
https://bugs.webkit.org/show_bug.cgi?id=109780

Reviewed by Kentaro Hara.

No new tests. LayoutTests/fast/dom/collection-null-like-arguments.html
Should pass now.

  • bindings/js/JSHTMLAllCollectionCustom.cpp: Return null for namedItem() only.

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):
(WebCore::JSHTMLFormControlsCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):
(WebCore::JSHTMLOptionsCollection::namedItem):

7:45 PM Changeset in webkit [142845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix indentation error in MediaPlayerPrivateGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=109768

Patch by Soo-Hyun Choi <sh9.choi@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

No new tests as this patch just changes indentation style.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::hasVideo):
(WebCore::MediaPlayerPrivateGStreamer::hasAudio):
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):

7:44 PM Changeset in webkit [142844] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=109779

Rebaseline http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html
on Linux after r142683.

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13

  • platform/chromium-linux/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
7:31 PM Changeset in webkit [142843] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

TokenPreloadScanner should be (mostly!) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109760

Reviewed by Eric Seidel.

This patch makes the bulk of TokenPreloadScanner thread-safe. The one
remaining wart is processPossibleBaseTag because it wants to grub
around in the base tag's attributes. I have a plan for that, but it's
going to need to wait for the next patch.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(WebCore):

6:36 PM Changeset in webkit [142842] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/Tools

Unreviewed. Add separate DumpRenderTree VS2010 solution file.

  • DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
6:30 PM Changeset in webkit [142841] by jamesr@google.com
  • 6 edits in trunk

[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebUnitTestSupport.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

6:16 PM Changeset in webkit [142840] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

StartTagScanner should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109750

Reviewed by Eric Seidel.

This patch weens the StartTagScanner off AtomicString using two
techniques:

1) This patch creates an enum to represent the four tag names that the

StartTagScanner needs to understand. Using an enum is better than
using an AtomicString because we can use the enum on both the main
thread and on the background thread.

2) For attributes, this patch uses threadSafeMatch. We're not able to

use threadSafeMatch everywhere due to performance, but using it for
attributes appears to be ok becaues we only call threadSafeMatch on
the attributes of "interesting" tags.

I tested the performance of this patch using
PerformanceTests/Parser/html-parser.html and did not see any slowdown.
(There actually appeared to be a <1% speedup, but I'm attributing that
to noise.)

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::identifierFor):
(WebCore):
(WebCore::inititatorFor):
(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(StartTagScanner):
(WebCore::StartTagScanner::createPreloadRequest):
(WebCore::StartTagScanner::processAttribute):
(WebCore::StartTagScanner::charset):
(WebCore::StartTagScanner::resourceType):
(WebCore::StartTagScanner::shouldPreload):
(WebCore::HTMLPreloadScanner::processToken):

6:11 PM Changeset in webkit [142839] by andersca@apple.com
  • 5 edits
    1 delete in trunk/Source/WebKit2

Remove StringPairVector
https://bugs.webkit.org/show_bug.cgi?id=109778

Reviewed by Ryosuke Niwa.

Our message generation scripts can handle nested template parameter types now,
so we no longer need to use StringPairVector.

  • Shared/StringPairVector.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

5:58 PM Changeset in webkit [142838] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Better build fix.

  • API/tests/testapi.c:

(assertEqualsAsNumber):
(main):

5:57 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
5:56 PM Changeset in webkit [142837] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Coordinated Graphics: a long page is scaled vertically while loading.
https://bugs.webkit.org/show_bug.cgi?id=109645

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-13
Reviewed by Noam Rosenthal.

When loading http://www.w3.org/TR/xpath-datamodel/, Coordinated Graphics draws
vertically scaled contents. It is because there is the difference between the
size of a layer and the size of CoordinatedBackingStore.

Currently, CoordinatedGraphicsScene notifies the size to CoordinatedBackingStore
at the moment of creating, updating and removing a tile. However, it is not
necessary to send tile-related messages when the size of layer is changed.
So this patch resets the size of CoordinatedBackingStore when receiving the
message that is created when the size is changed: SyncLayerState.

There is no current way to reliably test flicker issues.

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Add m_pendingSize to set m_size at the moment of flushing. After http://webkit.org/b/108294, m_pendingSize will be removed because the bug makes CoordinatedGraphicsScene execute all messages at the moment of flushing.

(WebCore::CoordinatedBackingStore::setSize):
(WebCore::CoordinatedBackingStore::commitTileOperations):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTile):
(WebCore::CoordinatedGraphicsScene::removeTile):
(WebCore::CoordinatedGraphicsScene::updateTile):

5:50 PM Changeset in webkit [142836] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

PlugIn Autostart should expire in 30 days, not half a day
https://bugs.webkit.org/show_bug.cgi?id=109767

Reviewed by Brian Weinstein.

We forgot to multiply by 60 seconds in a minute.

  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:
5:49 PM Changeset in webkit [142835] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Message generation should handle nested templates
https://bugs.webkit.org/show_bug.cgi?id=109771

Reviewed by Ryosuke Niwa.

Make it possible to have nested class template types as message parameters and
correctly gather all the needed headers and argument coder headers.

  • Scripts/webkit2/messages.py:

(class_template_headers):
Recursively figure out the types and template headers needed for a given type.

(argument_coder_headers_for_type):
(headers_for_type):
Call class_template_headers.

  • Scripts/webkit2/messages_unittest.py:

(CoreIPC):

  • Scripts/webkit2/parser.py:

(split_parameters_string):
(parse_parameters_string):

5:48 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
5:43 PM Changeset in webkit [142834] by haraken@chromium.org
  • 35 edits in trunk/Source/WebCore

[V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(),
and XXXAccessorSetter() to XXXAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=109679

Reviewed by Adam Barth.

For naming consistency and clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateHeaderCustomCall):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(WebCore::TestObjV8Internal::customAttrAttrSetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BiquadFilterNodeCustom.cpp:

(WebCore::V8BiquadFilterNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrSetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrSetterCustom):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAttrGetterCustom):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAttrGetterCustom):
(WebCore::V8Coordinates::altitudeAccuracyAttrGetterCustom):
(WebCore::V8Coordinates::headingAttrGetterCustom):
(WebCore::V8Coordinates::speedAttrGetterCustom):

  • bindings/v8/custom/V8CustomEventCustom.cpp:

(WebCore::V8CustomEvent::detailAttrGetterCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::locationAttrSetterCustom):
(WebCore::V8DOMWindow::openerAttrSetterCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::rotationRateAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::intervalAttrGetterCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::betaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::gammaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::absoluteAttrGetterCustom):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAttrGetterCustom):
(WebCore::V8Document::locationAttrSetterCustom):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAttrGetterCustom):
(WebCore::V8Event::clipboardDataAttrGetterCustom):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAttrGetterCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::allAttrSetterCustom):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAttrGetterCustom):
(WebCore::V8HTMLElement::itemValueAttrSetterCustom):

  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:

(WebCore::V8HTMLFrameElement::locationAttrSetterCustom):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionStartAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrSetterCustom):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAttrGetterCustom):
(WebCore::V8HTMLLinkElement::sizesAttrSetterCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAttrSetterCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAttrGetterCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::scopeChainAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::thisObjectAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::typeAttrGetterCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::hashAttrSetterCustom):
(WebCore::V8Location::hostAttrSetterCustom):
(WebCore::V8Location::hostnameAttrSetterCustom):
(WebCore::V8Location::hrefAttrSetterCustom):
(WebCore::V8Location::pathnameAttrSetterCustom):
(WebCore::V8Location::portAttrSetterCustom):
(WebCore::V8Location::protocolAttrSetterCustom):
(WebCore::V8Location::searchAttrSetterCustom):
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):
(WebCore::V8MessageEvent::portsAttrGetterCustom):

  • bindings/v8/custom/V8OscillatorNodeCustom.cpp:

(WebCore::V8OscillatorNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8PannerNodeCustom.cpp:

(WebCore::V8PannerNode::panningModelAttrSetterCustom):
(WebCore::V8PannerNode::distanceModelAttrSetterCustom):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAttrGetterCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAttrGetterCustom):
(WebCore::V8SVGLength::valueAttrSetterCustom):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAttrGetterCustom):

  • bindings/v8/custom/V8WebKitAnimationCustom.cpp:

(WebCore::V8WebKitAnimation::iterationCountAttrGetterCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAttrGetterCustom):
(WebCore::V8XMLHttpRequest::responseAttrGetterCustom):

5:35 PM Changeset in webkit [142833] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666

Reviewed by Adam Barth.

Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). To solve the problem,
we should generate wrapper methods for custom getters/setters.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):

5:32 PM Changeset in webkit [142832] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix.

  • API/tests/testapi.c:

(assertEqualsAsNumber):
(main):

5:31 PM Changeset in webkit [142831] by Vineet
  • 10 edits
    2 adds in trunk

HTMLCollections namedItem() methods should return null than undefined for empty collections.
https://bugs.webkit.org/show_bug.cgi?id=104096

Reviewed by Kentaro Hara.

As per specification namedItem() should return null if collection is empty.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection

Source/WebCore:

Test: fast/dom/htmlcollection-namedItem.html

  • bindings/js/JSHTMLAllCollectionCustom.cpp: Returning null.

(WebCore::getNamedItems):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLAllCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLFormControlsCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLOptionsCollection::namedItemCallback):

LayoutTests:

  • fast/dom/HTMLFormElement/move-option-between-documents-expected.txt:
  • fast/dom/HTMLFormElement/move-option-between-documents.html:
  • fast/dom/htmlcollection-namedItem-expected.txt: Added.
  • fast/dom/htmlcollection-namedItem.html: Added.
5:31 PM Changeset in webkit [142830] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Make WebKit2 Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109763

Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.

  • WebKit2.xcodeproj/project.pbxproj: Pass SDKROOT=${SDKROOT} to DerivedSources.make
5:25 PM Changeset in webkit [142829] by tonyg@chromium.org
  • 7 edits in trunk

Fix svg/in-html/script-write.html with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109495

Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the background parser's simulateTreeBuilder() more realistic.

  1. The HTMLTreeBuilder does not call the updateStateFor() setState()s when in foreign content mode so we shouldn't do it when simulating the tree builder.
  2. HTMLTreeBuilder::processTokenInForeignContent has a list of tags which exit foreign content mode. We need to respect those.
  3. Support the <foreignObject> tag which enters and leaves foreign content mode.
  4. The tree builder sets state to DataState upon a </script> tag when not in foreign content mode. We need to do the same.

This involved creating a namespace stack where we push upon entering each namespace and pop upon leaving.
We are in foreign content if the topmost namespace is SVG or MathML.

This fixes svg/in-html/script-write.html and likely others.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::getAttributeItem): Returns the attribute of the given name. Necessary to test for <font> attributes in simulateTreeBuilder.
(WebCore):

  • html/parser/CompactHTMLToken.h:

(WebCore):
(CompactHTMLToken):

LayoutTests:

Added 3 new test cases:

  1. Test the behavior of a plaintext tag inside an svg foreignObject. It applies to the remainder of the document. This behavior seems a little wonky, but it matches our current behavior and Firefox's behavior.
  2. Test that we don't blindly go into HTML mode after </foreignObject>.
  3. Test that unmatched </foreignObject>s are ignored.
  • html5lib/resources/webkit02.dat:
5:17 PM Changeset in webkit [142828] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
https://bugs.webkit.org/show_bug.cgi?id=109766

Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • Don't search Mac OS X header search paths when building on iOS
5:11 PM Changeset in webkit [142827] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
<http://webkit.org/b/109756>

Reviewed by Antti Koivisto.

Remove this to prevent callers from accidentally causing elements to convert to UniqueElementData.
There are two call sites (Attr and HTMLSelectElement) that legitimately need to mutate Attribute
objects in-place, they now use Element::ensureUniqueElementData()->getAttributeItem() directly instead.

Small progression on Membuster3, mostly for peace of mind.

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/Element.h:

(Element):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

5:07 PM Changeset in webkit [142826] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Stronger ElementData pointer typing.
<http://webkit.org/b/109752>

Reviewed by Antti Koivisto.

Use ShareableElementData/UniqueElementData pointers instead of generic ElementData pointers
where possible. Moved some methods from base class into leaf classes that don't make sense
for both classes.

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/DocumentSharedObjectPool.h:

(DocumentSharedObjectPool):

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::ShareableElementData::createWithAttributes):
(WebCore::UniqueElementData::create):
(WebCore::ElementData::makeUniqueCopy):
(WebCore::UniqueElementData::makeShareableCopy):

  • dom/Element.h:

(ElementData):
(ShareableElementData):
(UniqueElementData):
(Element):
(WebCore::Element::ensureUniqueElementData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

5:03 PM Changeset in webkit [142825] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765

Reviewed by Andreas Kling and Anders Carlsson.

Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.

  • platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::sharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

5:02 PM Changeset in webkit [142824] by eae@chromium.org
  • 6 edits
    2 adds in trunk

getComputedStyle returns truncated value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=109759

Source/WebCore:

Reviewed by Tony Chang.

Due to an unfortunate cast in CSSComputedStyleDeclaration::
getPropertyCSSValue getComputedStyle returns truncated styles
for margin-right in cases where it isn't set to a specific pixel
value.

Test: fast/sub-pixel/computedstylemargin.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Change type of temporary value variable to float to prevent loss of precision.

LayoutTests:

Reviewed by Tony Chang.

Add test for getComputedStyle with fractional margin values.

  • fast/sub-pixel/computedstylemargin-expected.txt: Added.
  • fast/sub-pixel/computedstylemargin.html: Added.
4:59 PM Changeset in webkit [142823] by mvujovic@adobe.com
  • 14 edits
    1 add in trunk/Source

[CSS Filters] Refactor filter outsets into a class
https://bugs.webkit.org/show_bug.cgi?id=109330

Source/WebCore:

Reviewed by Dean Jackson.

In filters related code, we're often operating on 4 ints representing the top, right,
bottom, and left filter outsets. These outsets come from a filter like blur or drop-shadow.
This patch packages those ints and their related operations into a class called
IntRectExtent.

Here are some signs that we should make a class to hold those 4 ints:
1) In RenderLayer.cpp, we have a expandRectForFilterOutsets function, which looks like

feature envy.

2) RenderStyle and other classes have methods like getFilterOutsets which set the 4 ints by

reference. The calling code has to define 4 ints, which looks bloated.

3) To fix bug 109098, we will need to check if filter outsets changed, which sounds like a

nice job for an inequality operator. (https://bugs.webkit.org/show_bug.cgi?id=109098)

No new tests. No change in behavior. Just refactoring.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntRectExtent.h: Added.

(WebCore):
(IntRectExtent):
(WebCore::IntRectExtent::IntRectExtent):
(WebCore::IntRectExtent::top):
(WebCore::IntRectExtent::setTop):
(WebCore::IntRectExtent::right):
(WebCore::IntRectExtent::setRight):
(WebCore::IntRectExtent::bottom):
(WebCore::IntRectExtent::setBottom):
(WebCore::IntRectExtent::left):
(WebCore::IntRectExtent::setLeft):
(WebCore::IntRectExtent::expandRect):
(WebCore::IntRectExtent::isZero):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::operator+=):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::outsets):

  • platform/graphics/filters/FilterOperations.h:

(FilterOperations):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::intermediateSurfaceRect):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/style/RenderStyle.h:

Source/WebKit/chromium:

Update FilterOperations unit tests to use new interface for getting filter outsets.

Reviewed by Dean Jackson.

  • tests/FilterOperationsTest.cpp:

(WebKit::TEST):

4:56 PM Changeset in webkit [142822] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Factor HTMLTokenScanner out of HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109754

Reviewed by Eric Seidel.

This patch is just a mechanical separation of the per-token "scanning"
logic from HTMLPreloadScanner into a separate class.
HTMLPreloadScanner's job is now to keep track of the input stream and
to pump the tokenizer.

This factorization class will let us use HTMLTokenScanner on the
background thread (once we finish making it thread-safe). In a follow
up patch, I'll move HTMLTokenScanner to its own file.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLTokenScanner::HTMLTokenScanner):
(WebCore::HTMLTokenScanner::~HTMLTokenScanner):
(WebCore::HTMLTokenScanner::processPossibleTemplateTag):
(WebCore::HTMLTokenScanner::processPossibleStyleTag):
(WebCore::HTMLTokenScanner::processPossibleBaseTag):
(WebCore::HTMLTokenScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore):
(WebCore::HTMLPreloadScanner::~HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::appendToEnd):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(HTMLTokenScanner):
(WebCore::HTMLTokenScanner::setPredictedBaseElementURL):
(HTMLPreloadScanner):
(WebCore):

4:37 PM Changeset in webkit [142821] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r125794) - inline-children-root-linebox-crash asserts in Chromium debug
https://bugs.webkit.org/show_bug.cgi?id=94256

Unreviewed test expectations update. Re-enabling inline-children-root-linebox-crash
as it was fixed by r139479.

  • platform/chromium/TestExpectations:
4:12 PM Changeset in webkit [142820] by esprehn@chromium.org
  • 7 edits
    2 adds in trunk

ASSERT(!renderer()->needsLayout()) when calling Element::focus() with generated content
https://bugs.webkit.org/show_bug.cgi?id=109616

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/quote-layout-focus-crash.html

In some cases RenderQuote may mark itself and containing blocks as needing layout
during a layout, but then one of it's containing blocks will mark itself as having
finished layout so the RenderQuote and potentially some of it's ancestor renderers
needLayout(), but the ancestors above those do not.

Until we have proper pre-layout tasks we should just walk the list of quotes
right before layout and mark all their ancestors as needing layout if the quote
needs layout.

  • dom/Document.cpp:

(WebCore::Document::updateLayout): Call markQuoteContainingBlocksForLayoutIfNeeded.
(WebCore::Document::implicitClose): Call markQuoteContainingBlocksForLayoutIfNeeded.

  • rendering/RenderQuote.h:

(WebCore::RenderQuote::next): Added.

  • rendering/RenderView.cpp:

(WebCore::RenderView::markQuoteContainingBlocksForLayoutIfNeeded): Added.

  • rendering/RenderView.h:

(RenderView):

LayoutTests:

  • fast/block/float/float-not-removed-from-pre-block-expected.txt: Changed output.
  • fast/css-generated-content/quote-layout-focus-crash-expected.txt: Added.
  • fast/css-generated-content/quote-layout-focus-crash.html: Added.
4:02 PM Changeset in webkit [142819] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

EME: MediaPlayer::keyNeede() should return a bool indicating whether an event listener was triggered.
https://bugs.webkit.org/show_bug.cgi?id=109701

Reviewed by Eric Carlson.

Clients of MediaPlayer may need to do cleanup if calling keyNeeded()
results in no event listener being triggered. Return a bool (like the
v1 equivalent keyNeeded method) to indicate this.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyNeeded):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):

3:57 PM Changeset in webkit [142818] by mrobinson@webkit.org
  • 3 edits in trunk

Try once again to fix the build after r142756

  • Source/autotools/PrintBuildConfiguration.m4: Do not try to print the GStreamer version

in the build output.

  • Source/autotools/SetupAutoconfHeader.m4: Remove the last reference to have_gstreamer.
3:53 PM Changeset in webkit [142817] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more buildfix for !ENABLE(PLUGIN_PROCESS) platforms.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

3:44 PM Changeset in webkit [142816] by inferno@chromium.org
  • 4 edits
    2 adds in trunk
ASSERTION FAILED: !object
object->isBox(), Bad cast in RenderBox::computeLogicalHeight

https://bugs.webkit.org/show_bug.cgi?id=107748

Reviewed by Levi Weintraub.

Source/WebCore:

Make sure that body renderer is not an inline-block display
when determining that it stretches to viewport or when paginated
content needs base height.

Test: fast/block/body-inline-block-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

LayoutTests:

  • fast/block/body-inline-block-crash-expected.txt: Added.
  • fast/block/body-inline-block-crash.html: Added.
3:43 PM Changeset in webkit [142815] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix debug assertion being triggered because we may access dirty normalFlowList.
https://bugs.webkit.org/show_bug.cgi?id=109740

A debug assertion in RenderLayer.h is being hit when trying to
access the normalFlowList when it is dirty. This is caused by a
new recursion that I added in RenderLayerBacking::hasVisibleNonCompositingDescendant(),
but I overlooked the need to call updateLayerListsIfNeeded()
recursively as well.

Reviewed by Simon Fraser.

No test, because there's no reliable way to test this (same as bug 85512).

  • rendering/RenderLayerBacking.cpp:

(WebCore::hasVisibleNonCompositingDescendant):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):

3:37 PM Changeset in webkit [142814] by roger_fong@apple.com
  • 3 adds in trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj

Unreviewed. Add some missing property sheets for TestWebKitAPI.

  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Added.
3:37 PM Changeset in webkit [142813] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Yet another build fix

3:34 PM Changeset in webkit [142812] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt-Mac and Qt-Win buildfix after r142768.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13

  • WebProcess/WebProcess.h:

(WebKit):

3:09 PM Changeset in webkit [142811] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Don't restart shared timer if both the current and the new fire time are in the past
https://bugs.webkit.org/show_bug.cgi?id=109731

Reviewed by Andreas Kling.

In 40-50% of cases we reschedule the shared timer both the old and the new fire time have already passed. This can happen at least when rescheduling
a zero duration timer and when stopping a timer that was ready to fire.

We can skip rescheduling in this case, the shared timer will fire immediately anyway.

Scheduling timers calls into platform layer and can be slow. This about halves the time under setSharedTimerFireInterval in PLT3
for ~0.1% total CPU time reduction.

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::setSharedTimer):
(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/ThreadTimers.h:

(ThreadTimers):

3:01 PM Changeset in webkit [142810] by zandobersek@gmail.com
  • 79 edits in trunk

The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
https://bugs.webkit.org/show_bug.cgi?id=109325

Reviewed by Anders Carlsson.

Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
two methods as they're provided by the C++ standard library being used.

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueMakeNumber):

  • JSCTypedArrayStubs.h:

(JSC):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::constantNaN):

  • offlineasm/cloop.rb:
  • runtime/DateConstructor.cpp:

(JSC::dateUTC): Also include an opportunistic style fix.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toInteger):

  • runtime/JSDateMath.cpp:

(JSC::getUTCOffset):
(JSC::parseDateFromNullTerminatedCharacters):
(JSC::parseDate):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):

  • runtime/PropertyDescriptor.cpp:

(JSC::sameValue):

Source/WebCore:

No new tests as there's no change in functionality.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::setValue):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::isValidNumber):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::fixNANs):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::setTimeout):
(WebCore::setMaximumAge):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::setLength):

  • bindings/js/JSWebKitPointCustom.cpp:

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getByIndex):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::classMethodWithClampCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::toInt32):
(WebCore::toUInt32):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::createPositionOptions):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::translate):
(WebCore::WebKitCSSMatrix::scale):
(WebCore::WebKitCSSMatrix::rotate):
(WebCore::WebKitCSSMatrix::rotateAxisAngle):
(WebCore::WebKitCSSMatrix::skewX):
(WebCore::WebKitCSSMatrix::skewY):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::endedPlayback):

  • html/MediaController.cpp:

(MediaController::duration):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::clearColor):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::addCue):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setStartTime):
(WebCore::TextTrackCue::setEndTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::floatFeature): Also include an opportunistic style fix.

  • platform/CalculationValue.cpp:

(WebCore::CalculationValue::evaluate):

  • platform/Decimal.cpp:

(WebCore::Decimal::fromDouble):

  • platform/Length.cpp:

(WebCore::Length::nonNanCalculatedValue):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::setRate):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/Reverb.cpp:

(WebCore::calculateNormalizationScale):

  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::isLiveStream):

  • platform/graphics/gpu/LoopBlinnMathUtils.cpp:

(LoopBlinnMathUtils):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenTypeVerticalData::getVerticalTranslationsForGlyphs):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider):
(WebCore::paintMediaVolumeSlider):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentTime):

  • svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSubstring::evaluate):
(WebCore::XPath::FunRound::round):

  • xml/XPathValue.cpp:

(WebCore::XPath::Value::toBoolean): Also include an opportunistic style fix.
(WebCore::XPath::Value::toString):

Source/WebKit/chromium:

  • tests/DecimalTest.cpp:

(TEST_F):

Source/WebKit/mac:

  • tests/DecimalTest.cpp:

(TEST_F):

Source/WTF:

  • wtf/Compiler.h: Remove the global isinf/isnan compiler quirk definitions. They're not required anymore.
  • wtf/DateMath.cpp: Move the workaround for isinf on Solaris into the std namespace. Ditto for isinf and isnan

when using MSVC. Stop bringing the isinf and isnan methods into the global scope when using other configurations.
(WTF::parseDateFromNullTerminatedCharacters):

  • wtf/IntegralTypedArrayBase.h:

(WTF::IntegralTypedArrayBase::set):

  • wtf/MathExtras.h:

(std):
(std::isinf):
(wtf_fmod):
(wtf_pow):
(doubleToInteger):

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

  • wtf/Uint8ClampedArray.h:

(WTF::Uint8ClampedArray::set):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(setAppCacheMaximumSizeCallback):
(setApplicationCacheOriginQuotaCallback):
(setDatabaseQuotaCallback):

2:57 PM Changeset in webkit [142809] by eric.carlson@apple.com
  • 16 edits
    1 add in trunk

[Mac] Caption menu should have only one item selected
https://bugs.webkit.org/show_bug.cgi?id=109730

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, media/track/track-user-preferences.html was modified to test the changes.

  • CMakeLists.txt: Add CaptionUserPreferences.cpp.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_processingPreferenceChange.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Only end up with one selected track when

called because of a preferences change.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Call setClosedCaptionsVisible instead

of calling markCaptionAndSubtitleTracksAsUnconfigured directly.

(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Process all tracks,

not just track elements.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp: Added so the functionality can be tested in DRT.

(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::setUserPrefersCaptions):
(WebCore::CaptionUserPreferences::captionPreferencesChanged):
(WebCore::CaptionUserPreferences::preferredLanguages):
(WebCore::CaptionUserPreferences::setPreferredLanguage):
(WebCore::CaptionUserPreferences::displayNameForTrack):

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Moved some logic

to base class.

(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Ditto.

LayoutTests:

  • media/track/track-user-preferences-expected.txt:
  • media/track/track-user-preferences.html: Update test to check for reactions to preferences.
2:54 PM Changeset in webkit [142808] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix scaling in WebViewImpl::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My last patch broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

2:54 PM Changeset in webkit [142807] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove bogus ASSERT in WebFrameProxy::didStartProvisionalLoad
https://bugs.webkit.org/show_bug.cgi?id=109733

Reviewed by Sam Weinig.

After http://trac.webkit.org/changeset/142555, this ASSERT is
triggering on these tests:

fast/dom/window-load-crash.html
fast/frames/seamless/seamless-hyperlink-named.html
fast/frames/seamless/seamless-hyperlink.html

The ASSERT appears to be bogus. This patch removes it.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

2:46 PM Changeset in webkit [142806] by weinig@apple.com
  • 17 edits
    1 copy
    4 moves
    2 adds
    14 deletes in trunk/Source/WebKit2

Consolidate main functions in WebKit2 now that they are all identical
https://bugs.webkit.org/show_bug.cgi?id=109748

Reviewed by Anders Carlsson.

  • Consolidates all the LegacyProcess main functions into ChildProcessMain.mm
  • Consolidates all the XPCService main functions into XPCServiceMain.mm and XPCServiceMain.Development.mm
  • Rename existing ChildProcessMain.h/mm to ChildProcessEntryPoint.h/mm to match the XPCService ones.
  • Switch LegacyProcess to use the "entry point in the plist" idiom, instead of hard coding each one, again matching the XPCService.
  • Configurations/BaseLegacyProcess.xcconfig: Add base configuration to hold common legacy process options.
  • Configurations/BaseXPCService.xcconfig:
  • Configurations/NetworkProcess.xcconfig:
  • Configurations/OfflineStorageProcess.xcconfig:
  • Configurations/PluginProcess.xcconfig:
  • Configurations/SharedWorkerProcess.xcconfig:
  • Configurations/WebContentProcess.xcconfig: Renamed form WebProcess.xcconfig.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Removed.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Removed.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Removed.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm:
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Removed.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Removed.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Removed.
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Removed.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Removed.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Replaced.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Removed.
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
2:43 PM Changeset in webkit [142805] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Exclusions] ExclusionPolygon reflex vertices should constrain the first fit location.
https://bugs.webkit.org/show_bug.cgi?id=107568

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-13
Reviewed by Dirk Schulze.

Source/WebCore:

The ExclusionPolygon::firstIncludedIntervalLogicalTop() method now includes offset edges
for each of the polygon's reflex vertices. The motivation for this change is explained
here: http://hansmuller-webkit.blogspot.com/2013/01/getting-to-point-reflex-vertices.html.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::isReflexVertex): Given three vertices that represent a pair of connected polygon edges, return true if the second vertex is a reflex vertex.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This method now includes offset edges for reflex vertices.

  • rendering/ExclusionPolygon.h:

(WebCore::OffsetPolygonEdge::OffsetPolygonEdge): Added a constructor for creating an OffsetPolygonEdge given a reflex vertex.
(WebCore::OffsetPolygonEdge::edgeIndex): Changed this property from unsigned to int. Now using -1 to indicate that the offset edge doesn't correspond to a single polygon edge.

LayoutTests:

In this carefully contrived test case, the Y coordinate of the origin of the line
of text is only computed correctly if the constraints implied by the polygon's
reflex vertices are considered.

  • fast/exclusions/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html: Added.
2:40 PM Changeset in webkit [142804] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Change another use of (SpecCell & ~SpecString) to SpecObject.

Reviewed by Mark Hahnenberg.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

2:40 PM Changeset in webkit [142803] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

CSSPreloadScanner should not depend on HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=109742

Reviewed by Eric Seidel.

There's no need for the CSSPreloadScanner to depend on HTMLToken. On
the background thread, we'll likely want to use a CompactHTMLToken for
preload scanning, so this dependency is problematic. This patch also
teaches the CSSPreloadScanner how to scan LChars.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::~CSSPreloadScanner):
(WebCore):
(WebCore::CSSPreloadScanner::scan):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::processToken):

2:39 PM Changeset in webkit [142802] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

cr-linux debug should use clang and maybe be a components build
https://bugs.webkit.org/show_bug.cgi?id=108512

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13
Reviewed by Adam Barth.

Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
Build bots will update clang with each bot cycle.
Updated GCE image paths to suit gcutil 1.6.1.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
  • EWSTools/start-queue.sh:
2:39 PM Changeset in webkit [142801] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix !ENABLE(BLOB) build.

Reviewed by NOBODY (OOPS!).

  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::getCachedOrigin):
  • page/SecurityOrigin.cpp: (WebCore::getCachedOrigin):
2:36 PM Changeset in webkit [142800] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726

Reviewed by Mark Hahnenberg.

If you add it to the list of relevant node types, you also need to make sure
it's listed as either hasChild or one of the other kinds. Otherwise you get
an assertion. This is causing test failures in run-javascriptcore-tests.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::MinifiedNode::hasChild):

2:31 PM Changeset in webkit [142799] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking a few tests as slow on the debug builds. This shall prevent them timing out unnecessarily.

  • platform/gtk/TestExpectations:
2:17 PM Changeset in webkit [142798] by jchaffraix@webkit.org
  • 14 edits
    4 adds in trunk

[CSS Grid Layout] Adding or removing grid items doesn't properly recompute the track sizes
https://bugs.webkit.org/show_bug.cgi?id=109100

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-removal-track-breadth-update.html

The test uncovered several bugs in our implementation that is fixed as part
of this change. They will be detailed below.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
Added this function to share the code between minContentForChild and maxContentForChild.
Also forced a relayout in this case to avoid getting a wrong answer (e.g. the logical height
constrained by the previous layout's grid breadth).

(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Updated to use logicalContentHeightForChild.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated to match the specification and set max breadth to current breadth per the specification.
This made us over-grow some cases in the test.

(WebCore::RenderGrid::distributeSpaceToTracks):
Updated to match the specification and use an extra variable to do the intermediate spreading. Also removed
a now unneeded max. This fixes the case of multiple grid items in the same grid area that was completely broken.

(WebCore::RenderGrid::layoutGridItems):
Added a FIXME about always relaying out content sized tracks' children.

  • rendering/RenderGrid.h:

Added logicalContentHeightForChild.

LayoutTests:

  • fast/css-grid-layout/grid-item-addition-track-breadth-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-addition-track-breadth-update.html: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html: Added.

New tests.

  • fast/css-grid-layout/resources/grid.css:

(.constrainedContainer):
(.unconstrainedContainer):
Added these class to share them with other tests.

  • fast/css-grid-layout/auto-content-resolution-columns.html:
  • fast/css-grid-layout/auto-content-resolution-rows.html:
  • fast/css-grid-layout/implicit-columns-auto-resolution.html:
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/implicit-rows-auto-resolution.html:
  • fast/css-grid-layout/minmax-max-content-resolution-columns.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:

Removed constrainedContainer definition as it was moved to grid.css.

2:12 PM Changeset in webkit [142797] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Rebasline after r142765

Unreviewed test expectations update.

The change caused sub-pixel changing in SVG-as-image positions.

  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
2:03 PM Changeset in webkit [142796] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Clean up some style nits in HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109738

Reviewed by Tony Gentilcore.

This patch just fixes a few style nits I noticed when reading through
the code.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::StartTagScanner):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::isSafeToSendToAnotherThread):

  • html/parser/HTMLResourcePreloader.h:

(PreloadRequest):
(WebCore::PreloadRequest::PreloadRequest):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):

2:02 PM Changeset in webkit [142795] by alecflett@chromium.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r142747.
http://trac.webkit.org/changeset/142747
https://bugs.webkit.org/show_bug.cgi?id=109746

broke component build (Requested by alecf_gardening on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(WebCore):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1:56 PM Changeset in webkit [142794] by Christophe Dumez
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using WebString in ewk_cookie_manager, ewk_form_submission_request and ewk_text_checker
https://bugs.webkit.org/show_bug.cgi?id=108794

Reviewed by Alexey Proskuryakov.

Stop using WebString in ewk_cookie_manager, ewk_form_submission_request
and ewk_text_checker as it is internal C++ API. WKString and
WKEinaSharedString are used instead.

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::leakString): Add leakString() method to
WKEinaSharedString so that we can conveniently convert a WKString to a
Eina shared string and take ownership of it.

  • UIProcess/API/cpp/efl/WKEinaSharedString.h:
  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(EwkFormSubmissionRequest::copyFieldValue):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):

  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(EwkFormSubmissionRequest):

  • UIProcess/API/efl/ewk_text_checker.cpp:

(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):

  • UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:

(TEST_F): Add API test for new WKEinaSharedString::leakString() method.

1:55 PM Changeset in webkit [142793] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137

Reviewed by Eric Seidel.

Source/WebCore:

First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.

Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html

  • rendering/InlineIterator.h:

(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.

LayoutTests:

  • fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
  • fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
1:49 PM Changeset in webkit [142792] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109744

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(Connection):

1:48 PM Changeset in webkit [142791] by akling@apple.com
  • 16 edits in trunk/Source/WebCore

Better names for ElementAttributeData & subclasses.
<http://webkit.org/b/109529>

Reviewed by Antti Koivisto.

  • ElementAttributeData => ElementData

Because ElementAttributeData won't be a good name once we move some non-attribute related
things to this structure.

  • ImmutableElementAttributeData => ShareableElementData

These objects can be shared with other Elements that have the same attribute name/value pairs.

  • MutableElementAttributeData => UniqueElementData

These objects contain data that is unique to a specific Element, and cannot be shared with
other Elements. This is what's important about it, not that its underlying storage is mutable.

  • attributeData() -> elementData()
  • updatedAttributeData() -> elementDataWithSynchronizedAttributes()
  • ensureUpdatedAttributeData() -> ensureElementDataWithSynchronizedAttributes()
  • mutableAttributeData() -> ensureUniqueElementData()

Ride-along renames. Much less vague than previous names IMO.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::ShareableElementDataCacheKey::ShareableElementDataCacheKey):
(WebCore::ShareableElementDataCacheKey::operator!=):
(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/DocumentSharedObjectPool.h:

(DocumentSharedObjectPool):

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::Element::reportMemoryUsage):
(WebCore::ElementData::deref):
(WebCore::ElementData::ElementData):
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ElementData::createShareableWithAttributes):
(WebCore::ElementData::createUnique):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
(WebCore::ElementData::makeMutableCopy):
(WebCore::ElementData::makeImmutableCopy):
(WebCore::ElementData::setPresentationAttributeStyle):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::ElementData::getAttributeItemIndexSlowCase):

  • dom/Element.h:

(ElementData):
(WebCore::ElementData::isUnique):
(ShareableElementData):
(UniqueElementData):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::elementData):
(Element):
(WebCore::Element::elementDataWithSynchronizedAttributes):
(WebCore::Element::ensureElementDataWithSynchronizedAttributes):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::classNames):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::updateInvalidAttributes):
(WebCore::Element::hasID):
(WebCore::Element::hasClass):
(WebCore::Element::ensureUniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::attributeItem):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::compareDocumentPosition):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
(WebCore::StyledElement::setInlineStyleFromString):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):

  • html/ClassList.cpp:

(WebCore::ClassList::classNames):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::updateAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

1:47 PM Changeset in webkit [142790] by jochen@chromium.org
  • 9 edits in trunk/Tools

[chromium] fix TestRunner build with enable_webrtc=0
https://bugs.webkit.org/show_bug.cgi?id=109700

Reviewed by Tony Chang.

We can't use ENABLE() macros in the TestRunner library, however,
ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::userMediaClient):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1:40 PM Changeset in webkit [142789] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

Rearranged the code somewhat to reduce the number of
DFG related ifdefs.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

1:36 PM Changeset in webkit [142788] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when encountering <object style="resize:both;">
https://bugs.webkit.org/show_bug.cgi?id=109728

Source/WebCore:

See also https://code.google.com/p/chromium/issues/detail?id=175535
This bug can be reproduced on
http://dramalink.net/tudou.y/?xink=162601060

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

Test: fast/css/resize-object-crash.html

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):
Only call paintResizer() if we have a layer and canResize() is true

LayoutTests:

See also https://code.google.com/p/chromium/issues/detail?id=175535

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

  • fast/css/resize-object-crash-expected.txt: Added.
  • fast/css/resize-object-crash.html: Added.
1:33 PM Changeset in webkit [142787] by arko@motorola.com
  • 3 edits in trunk/Source/WebCore

[Microdata] HTMLPropertiesCollection code cleanup
https://bugs.webkit.org/show_bug.cgi?id=109721

Reviewed by Ryosuke Niwa.

Removed forward declaration of DOMStringList class.
Removed unused findRefElements() method declaration.
Also Removed unused parameter Element* from updatePropertyCache() method.

No new test since no change in behavior.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateNameCache):

  • html/HTMLPropertiesCollection.h:

(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

1:30 PM Changeset in webkit [142786] by commit-queue@webkit.org
  • 9 edits in trunk

[WebGL][EFL][GTK][Qt]Add support for OES_vertex_array_object.
https://bugs.webkit.org/show_bug.cgi?id=109382

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-13
Reviewed by Kenneth Russell.

Source/WebCore:

Covered by fast/canvas/webgl/oes-vertex-array-object.html

This patch adds support for using Vertex Array Object with OpenGl.
The patch adds support for loading necessary opengl functions
and support for checking GL_ARB_vertex_array_object. The support
for OES_vertex_array_object is advertised if GL_ARB_vertex_array_object is
supported.

  • platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h:

(_OpenGLFunctionTable):
Added support for loading the necessary functions.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):

(WebCore):
(WebCore::Extensions3DOpenGL::isVertexArrayObjectSupported):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

LayoutTests:

Enable oes-vertex-array-object for EFL port.

  • fast/canvas/webgl/oes-vertex-array-object-expected.txt:
  • fast/canvas/webgl/oes-vertex-array-object.html:
  • platform/efl/TestExpectations:
1:29 PM Changeset in webkit [142785] by roger_fong@apple.com
  • 4 edits
    3 copies
    11 adds in trunk

TestWebKitAPI, record-memory and gtest-md projects and property sheets for VS2010.
https://bugs.webkit.org/show_bug.cgi?id=107034

Reviewed by Brent Fulgham.

  • TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
  • win/record-memory: Added.
  • win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
  • win/record-memory/record-memory.vcxproj: Added.
  • win/record-memory/record-memory.vcxproj.filters: Added.
  • win/record-memory/record-memoryCommon.props: Added.
  • win/record-memory/record-memoryDebug.props: Added.
  • win/record-memory/record-memoryRelease.props: Added.
  • gtest/msvc/gtest-md.vcxproj: Added.
  • gtest/msvc/gtest-md.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKit.sln:
1:29 PM Changeset in webkit [142784] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Lion build.

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

1:27 PM Changeset in webkit [142783] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove support for the DispatchOnConnectionQueue message attribute
https://bugs.webkit.org/show_bug.cgi?id=109743

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):

  • Scripts/webkit2/messages.py:

(handler_function):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
1:22 PM Changeset in webkit [142782] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk/Source

chromium: remove CompositorHUDFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=109328

Patch by Eberhard Graether <egraether@google.com> on 2013-02-13
Reviewed by James Robinson.

After switching the HudLayer to use skia's font rendering the
CompositorHUDFontAtlas has become obsolete. This change removes
this class and the related WebLayerTreeView API.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

No new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Removed.
  • platform/graphics/chromium/CompositorHUDFontAtlas.h: Removed.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
1:17 PM Changeset in webkit [142781] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

StorageManager should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109741

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
(WebKit::StorageManager::processWillCloseConnection):
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
1:15 PM Changeset in webkit [142780] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726

Reviewed by Gavin Barraclough.

This is asymptomatic because ForwardInt32ToDouble is only used in SetLocals, in
which case the value is already stored to the stack. Still, we should fix this.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):

1:00 PM Changeset in webkit [142779] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG LogicalNot/Branch peephole removal and inversion ignores the possibility of things exiting
https://bugs.webkit.org/show_bug.cgi?id=109489

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

If things can exit between the LogicalNot and the Branch then don't peephole.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-branch-logical-not-peephole-around-osr-exit-expected.txt: Added.
  • fast/js/dfg-branch-logical-not-peephole-around-osr-exit.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-branch-logical-not-peephole-around-osr-exit.js: Added.

(foo):

12:58 PM Changeset in webkit [142778] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

EventDispatcher should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109736

Reviewed by Andreas Kling.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::create):
(WebKit):
(WebKit::EventDispatcher::EventDispatcher):
(WebKit::EventDispatcher::initializeConnection):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebPage/EventDispatcher.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:

(WebKit):
(WebKit::WebProcess::eventDispatcher):
(WebProcess):

12:52 PM Changeset in webkit [142777] by mrobinson@webkit.org
  • 2 edits in trunk

Try to fix the build after r142756

  • Source/autotools/SetupAutomake.m4: Instead of using the (now gone) have_gstreamer

variable, activate GStreamer if either web audio or web video is enabled.

12:51 PM Changeset in webkit [142776] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r142768.

r142768 broke the EFL WK2 build due to wrong member initialization
order in the WebProcess constructor initialization list.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

12:34 PM Changeset in webkit [142775] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Small update to speech bubble for captions menu [Mac]
https://bugs.webkit.org/show_bug.cgi?id=109641

Reviewed by Eric Carlson

Small adjustment to the embedded SVG that draws a speech bubble
for the captions button. Remove a polygon that was so small
it looked like a rendering error.

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button):

12:34 PM Changeset in webkit [142774] by dino@apple.com
  • 9 edits in trunk

Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648

Reviewed by Eric Carlson.

Source/WebCore:

Add a virtual override to the platform-specific
defaultEventHandler to intercept any click in the controls,
and hide the captions menu if it is showing.

Test: media/video-controls-captions-trackmenu-hide-on-click.html

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::defaultEventHandler): Override from MediaControls. Hide

captions menu if a click event comes in.

  • html/shadow/MediaControlsApple.h:

LayoutTests:

New test for captions menu. Skip it everywhere but Mac.

  • media/video-controls-captions-trackmenu-hide-on-click.html: Added.
  • platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
12:32 PM Changeset in webkit [142773] by tommyw@google.com
  • 10 edits in trunk

MediaStream API: Use the source id when creating new tracks
https://bugs.webkit.org/show_bug.cgi?id=109688

Reviewed by Adam Barth.

Source/Platform:

Added id to initialize and renamed audio/videoSources to audio/videoTracks.

  • chromium/public/WebMediaStream.h:

(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):

  • chromium/public/WebMediaStreamTrack.h:

(WebMediaStreamTrack):

Source/WebCore:

This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.

Covered by existing tests.

  • platform/chromium/support/WebMediaStream.cpp:

(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):

  • platform/chromium/support/WebMediaStreamTrack.cpp:

(WebKit::WebMediaStreamTrack::initialize):
(WebKit):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Tools:

Switching mock to new API.

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:

(WebTestRunner::WebUserMediaClientMock::requestUserMedia):

12:23 PM Changeset in webkit [142772] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Use fancy new Vector-based String constructors in the WebVTT parser
https://bugs.webkit.org/show_bug.cgi?id=109619

Reviewed by Benjamin Poulain.

No change in behavior. Added some FIXMEs for future perf optimization.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

12:14 PM Changeset in webkit [142771] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

[Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
to include paths, to match VS2005 build behavior.

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
12:11 PM Changeset in webkit [142770] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

WebKit ignores column-rules wider than column-gap
https://bugs.webkit.org/show_bug.cgi?id=15553

Paint column rules even if they are wider than the gap.
Rules wider than the gap should just overlap with column contents.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-13
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/rule-thicker-than-gap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):

LayoutTests:

  • fast/multicol/rule-thicker-than-gap-expected.html: Added.
  • fast/multicol/rule-thicker-than-gap.html: Added.
12:08 PM Changeset in webkit [142769] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Remove unnecessary indirection to non-local variable access operations
https://bugs.webkit.org/show_bug.cgi?id=109724

Reviewed by Filip Pizlo.

Linked bytecode now stores a direct pointer to the resolve operation
vectors, so the interpreter no longer needs a bunch of indirection to
to perform non-local lookup.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/Instruction.h:
  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(ResolveOperationData):
(PutToBaseOperationData):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_put_to_base):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
12:08 PM Changeset in webkit [142768] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make PluginProcessConnectionManager a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109727

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::create):
(WebKit):
(WebKit::PluginProcessConnectionManager::PluginProcessConnectionManager):
(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::pluginProcessConnectionManager):

  • WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

12:05 PM Changeset in webkit [142767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r182150. Requested by
jamesr_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • DEPS:
11:56 AM Changeset in webkit [142766] by eric@webkit.org
  • 3 edits in trunk/Source/WTF

Don't copy Vector<UChar> when passing to new String methods from bug 109617
https://bugs.webkit.org/show_bug.cgi?id=109708

Reviewed by Tony Gentilcore.

Thanks for the catch Darin.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::create8BitIfPossible):

11:44 AM Changeset in webkit [142765] by pdr@google.com
  • 14 edits
    6 adds in trunk

Replace SVG bitmap cache with directly-rendered SVG
https://bugs.webkit.org/show_bug.cgi?id=106159

Reviewed by Tim Horton.

Source/WebCore:

This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
http://ie.microsoft.com/testdrive/Performance/Chalkboard/

On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(http://philbit.com/SvgImagePerformance/viewport.html):

without patch: ~20FPS
with patch: ~55FPS

The bitmap SVG image cache had several shortcomings:

  • The bitmap cache prevented viewport rendering. (WK104693)
  • Bitmap memory usage was high. (WK106484)
  • Caching animating images was expensive.

This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

Tests: svg/as-image/svg-image-scaled.html

svg/as-image/svg-image-viewbox.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):

SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):

drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:

the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed

SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.

(WebCore::SVGImage::drawPatternForContainer):

For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.

(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):

  • svg/graphics/SVGImage.h:

(WebCore):
(SVGImage):

  • svg/graphics/SVGImageCache.cpp:

Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.

To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.

Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.

(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):

Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.

(WebCore::SVGImageCache::imageForRenderer):

A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

  • svg/graphics/SVGImageForContainer.cpp: Added.

(WebCore):

SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.

(WebCore::SVGImageForContainer::size):

This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.

(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h: Added.

(WebCore):
(SVGImageForContainer):

In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

LayoutTests:

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

  • platform/chromium/TestExpectations:
  • svg/as-image/svg-image-scaled-expected.html: Added.
  • svg/as-image/svg-image-scaled.html: Added.
  • svg/as-image/svg-image-viewbox-expected.html: Added.
  • svg/as-image/svg-image-viewbox.html: Added.
11:30 AM Changeset in webkit [142764] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Avoid updating timer heap when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=109630

Reviewed by Andreas Kling.

When the fire time of a Timer is changed we remove it from the timer heap and reinsert it. This is pretty slow.
Turns out that in ~80% of cases we are already in the heap and the insertion position is the same as the
original position. We can check if anything is actually going to change before doing this work.

This makes starting a timer ~30% faster in average, ~0.1% progression in PLT3.

  • platform/Timer.cpp:

(TimerHeapLessThanFunction):
(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::parentHeapPropertyHolds):
(WebCore):
(WebCore::childHeapPropertyHolds):
(WebCore::TimerBase::hasValidHeapPosition):

The code here assumes that STL heap is a normal binary heap. If there is a different implementation
somewhere the assertions will catch it.

(WebCore::TimerBase::updateHeapIfNeeded):

Skip updating the heap if it is already valid.

(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(TimerBase):

11:18 AM Changeset in webkit [142763] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make SecItemShimProxy be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109719

Reviewed by Sam Weinig.

This adds a WantsConnection message attribute to be used for messages whose handlers
should take the connection the message was delivered to.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • Scripts/webkit2/messages.py:

(async_message_statement):
(generate_message_handler):
Handle the WantsMessage attribute.

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::shared):
Use dispatch_once and adoptRef.

(WebKit::SecItemShimProxy::SecItemShimProxy):
Initialize the queue.

(WebKit::SecItemShimProxy::initializeConnection):
Add the proxy as a work queue message receiver.

(WebKit::SecItemShimProxy::secItemRequest):
This no longer needs to call out to a dispatch queue, it's already on a queue.

  • UIProcess/mac/SecItemShimProxy.messages.in:

This doesn't need to be a legacy receiver. Also, add the WantsConnection message.

10:51 AM Changeset in webkit [142762] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716

Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

10:49 AM Changeset in webkit [142761] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[GTK] Remove remaining dead code from the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109707

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.

Source/WebCore:

  • platform/KURL.cpp:

(WebCore::appendEncodedHostname):

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

Source/WTF:

  • wtf/unicode/Unicode.h:
10:37 AM Changeset in webkit [142760] by wangxianzhu@chromium.org
  • 4 edits
    1 add in trunk

.: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects.
https://bugs.webkit.org/show_bug.cgi?id=108695

Add a manual test. Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.

Reviewed by Abhishek Arya.

  • ManualTests/scrolling-coordinator-viewport-constrained-crash.html: Added.

Source/WebCore: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects
https://bugs.webkit.org/show_bug.cgi?id=108695

See comments of RenderLayerModelObject::willBeDestroyed() below for details.

Reviewed by Abhishek Arya.

Test: ManulTests/scrolling-coordinator-viewport-constrained-crash.html
Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed): Moved removeViewportConstrainedObject() call into RenderLayerModelObject::willBeDestroyed() because only RenderLayerModelObjects can be added as viewportConstrainedObjects.

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::willBeDestroyed): Changed this->view() (then view->frameView()) to this->frame() (then frame->view()) because when willBeDestroyed() is called, the document has set its renderView to 0 thus this->view() will return 0, causing removeViewportConstrainedObject() not called and a deleted RenderLayerModelObject in FrameView's viewportConstrainedObjects.

9:49 AM Changeset in webkit [142759] by fmalita@chromium.org
  • 17 edits in trunk

[SVG] OOB access in SVGListProperty::replaceItemValues()
https://bugs.webkit.org/show_bug.cgi?id=109293

Source/WebCore:

Replacing a list property item with itself should be a no-op. This patch updates the related
APIs and logic to detect the self-replace case and prevent removal of the item from the list.

To avoid scanning the list multiple times, removeItemFromList() is updated to operate on
indices and a findItem() method is added to resolve an item to an index.

Reviewed by Dirk Schulze.

No new tests: updated existing tests cover the change.

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::findItem):
(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::findItem):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
Add a findItem() delegating method, and update removeItemFromList() to use the new
index-based API.

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(SVGListProperty):
Updated to handle the no-op case for insertItemBefore() & replaceItem().

  • svg/properties/SVGListPropertyTearOff.h:

(WebCore::SVGListPropertyTearOff::findItem):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
Index-based API updates.

(WebCore::SVGListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGListPropertyTearOff::processIncomingListItemWrapper):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue):
Detect the self-replace case and return without removing the item from the list.

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::findItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

  • svg/properties/SVGStaticListPropertyTearOff.h:

(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemWrapper):
Index-based API updates.

LayoutTests:

Updated tests to cover the crash and new behavior.

Reviewed by Dirk Schulze.

  • svg/dom/SVGLengthList-basics-expected.txt:
  • svg/dom/SVGLengthList-basics.xhtml:
  • svg/dom/SVGNumberList-basics-expected.txt:
  • svg/dom/SVGNumberList-basics.xhtml:
  • svg/dom/SVGPointList-basics-expected.txt:
  • svg/dom/SVGPointList-basics.xhtml:
  • svg/dom/SVGTransformList-basics-expected.txt:
  • svg/dom/SVGTransformList-basics.xhtml:
9:46 AM Changeset in webkit [142758] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL] Cleanup of graphics related code in EwkView
https://bugs.webkit.org/show_bug.cgi?id=109377

Reviewed by Anders Carlsson.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

Initialize the evasGL dependencies here and
set m_isAccelerated to false if this fails.

Set the coordinated graphics scene as active
when using fixed layout.

(EwkView::setSize):

Add a method to set the size and user-viewport
transform from the outside. The idea is moving
this to our pure WK C API in the future.

(EwkView::transformFromScene):
(EwkView::transformToScene):

Update the transform methods to use the user-
viewport transform.

(EwkView::paintToCurrentGLContext):
(EwkView::paintToCairoSurface):

Add methods to paint to either the current GL context
or to a given cairo_surface_t (for software fallback
cases).

(EwkView::displayTimerFired):

Clean up and use the two above methods.

(EwkView::scheduleUpdateDisplay):

Use the new size() methods instead of using the
smart-object data directly.

(EwkView::createGLSurface):

Make this method use size() to query the surface size
and avoid creating the context (done in ctor now).
Also avoid using the smart-object data directly.

(EwkView::enterAcceleratedCompositingMode):
(EwkView::exitAcceleratedCompositingMode):

Turn on/off the use of the coord. graphics scene.

(EwkView::handleEvasObjectCalculate):

Use the new setSize and setUserViewportTransform.

(EwkView::takeSnapshot):

  • UIProcess/API/efl/EwkView.h:

(WebCore):
(EwkView):
(EwkView::size):
(EwkView::setUserViewportTransform):
(EwkView::userViewportTransform):

Add the new method definitions and rename isHardwareAccelerated
to isAccelerated which fits better with the naming in WebCore.

9:26 AM Changeset in webkit [142757] by tasak@google.com
  • 6 edits in trunk

Source/WebCore: [Refactoring] StyleResolver::State should have methods to access its member variables.
https://bugs.webkit.org/show_bug.cgi?id=108563

Reviewed by Antti Koivisto.

Made all member variables private and added methods to access the
variables, because most of the member variables are read-only.
We don't need to update those read-only variables while resolving
styles.

No new tests, because just refactoring.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::initElement):
Modified to invoke m_state.initElement if a given element is
different from current m_state's element.
(WebCore::StyleResolver::State::initForStyleResolve):
Moved from StyleResolver.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
Changed ASSERT in the first line. ASSERT(m_state.parentStyle) would be
wrong, because it depends on previous resolving. However,
initForStyleResolve will also update m_state.parentStyle. No code in
pseudoStyleForElement depends on previous resolving state.
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
Added one more parameter, dynamicPseudo, because dynamicPseudo in
State class is just used for returning matched pseudo style from
this ruleMatches to collectMatchingRulesForList. No need to keep
dynamicPseudo while resolving styles.
(WebCore::StyleResolver::checkRegionSelector):
Removed m_pseudoStyle = NOPSEUDO, because this method uses just
SelectorChecker::matched. SelectorChecker doesn't see StyleResolver's
m_pseudoStyle directly. Need to use SelectorCheckerContext. So no
need to set m_pseudoStyle to be NOPSEUDO.
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):

  • css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::clear):
Modified to use clear at the end of styleForElement.
(WebCore::StyleResolver::State::document):
(WebCore::StyleResolver::State::element):
(WebCore::StyleResolver::State::styledElement):
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::State::style):
(WebCore::StyleResolver::State::takeStyle):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::parentNode):
(WebCore::StyleResolver::State::setParentStyle):
(WebCore::StyleResolver::State::parentStyle):
(WebCore::StyleResolver::State::rootElementStyle):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyle):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::distributedToInsertionPoint):
(WebCore::StyleResolver::State::setElementAffectedByClassRules):
(WebCore::StyleResolver::State::elementAffectedByClassRules):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::applyPropertyToRegularStyle):
(WebCore::StyleResolver::State::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::pendingImageProperties):
(WebCore::StyleResolver::State::pendingSVGDocuments):
(WebCore::StyleResolver::State::setHasPendingShaders):
(WebCore::StyleResolver::State::hasPendingShaders):
(WebCore::StyleResolver::State::setLineHeightValue):
(WebCore::StyleResolver::State::lineHeightValue):
(WebCore::StyleResolver::State::setFontDirty):
(WebCore::StyleResolver::State::fontDirty):
(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::State::hasUAAppearance):
(WebCore::StyleResolver::State::borderData):
(WebCore::StyleResolver::State::backgroundData):
(WebCore::StyleResolver::State::backgroundColor):
(WebCore::StyleResolver::State::fontDescription):
(WebCore::StyleResolver::State::parentFontDescription):
(WebCore::StyleResolver::State::setFontDescription):
(WebCore::StyleResolver::State::setZoom):
(WebCore::StyleResolver::State::setEffectiveZoom):
(WebCore::StyleResolver::State::setTextSizeAdjust):
(WebCore::StyleResolver::State::setWritingMode):
(WebCore::StyleResolver::State::setTextOrientation):
fontDescription, ... and setTextOrientation were moved from
StyleResolver.
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
Moved from StyleResolver.
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
These fontDescription, ..., setTextOrientation are wrappers to
invoke State's methods. StyleBuilder still depends on StyleResolver
and invokes these methods. So we need these wrappers.

LayoutTests: [Refactoring] StyleResolver::State should have methods to access its me
https://bugs.webkit.org/show_bug.cgi?id=108563

Reviewed by Antti Koivisto.

  • inspector/styles/region-style-crash-expected.txt:

Rebaseline. Since inspector hasn't supported CSS region styles yet,
region-style-crash.html has no CSS region styles as its result.

9:24 AM Changeset in webkit [142756] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] Remove support for compiling with GStreamer 0.10
https://bugs.webkit.org/show_bug.cgi?id=109593

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.

Remove support for building WebKitGTK+ with GStreamer 0.10. We
can simplify things greatly because we don't have to worry any
longer about selecting one GStreamer API set.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/autotools/Versions.m4:
9:21 AM Changeset in webkit [142755] by allan.jensen@digia.com
  • 8 edits in trunk/Source

[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

9:01 AM Changeset in webkit [142754] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

The 2D Canvas functions fillText()/strokeText() should display nothing when maxWidth is less then or equal to zero
https://bugs.webkit.org/show_bug.cgi?id=102656

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-13
Reviewed by Dirk Schulze.

The functions fillText()/strokeText() should not display anything when
maxWidth is less than or equal to zero, according to spec :
http://www.w3.org/TR/2dcontext/#text-preparation-algorithm

Source/WebCore:

Test: fast/canvas/canvas-fillText-maxWidth-zero.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

  • fast/canvas/canvas-fillText-invalid-maxWidth-expected.txt: Added.
  • fast/canvas/canvas-fillText-invalid-maxWidth.html: Added.
  • fast/canvas/canvas-strokeText-invalid-maxWidth-expected.txt: Added.
  • fast/canvas/canvas-strokeText-invalid-maxWidth.html: Added.
  • fast/canvas/script-tests/canvas-fillText-invalid-maxWidth.js: Added.
  • fast/canvas/script-tests/canvas-strokeText-invalid-maxWidth.js: Added.
8:47 AM Changeset in webkit [142753] by sergio@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Provide the same custom expectations as all the other
platforms. This likely means that there is a bug in the code or
that the expected result is incorrect.

  • platform/gtk/TestExpectations:
  • platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.
8:25 AM Changeset in webkit [142752] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
https://bugs.webkit.org/show_bug.cgi?id=109611

The deltas in mousewheel events generated by track can be accelerated (e.g. when
scrolling repeatedly). Keep track of the ratio of the acceleration since that is
useful for some tasks (e.g. overflow navigation gesture).

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2013-02-13
Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebMouseWheelEvent):

8:23 AM Changeset in webkit [142751] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

replaceWithJump should not decrease the offset by 1 on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109689

Reviewed by Zoltan Herczeg.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::replaceWithJump):

8:16 AM Changeset in webkit [142750] by Christophe Dumez
  • 13 edits
    4 copies in trunk/Source/WebKit2

[EFL][WK2] Introduce WKViewClient C API
https://bugs.webkit.org/show_bug.cgi?id=109559

Reviewed by Anders Carlsson.

This patch introduces the WKViewClient C API for EFL's WKView. The purpose of
this new C API is to eventually remove the interdependency between EFL's
PageClient and EwkView. When completed, PageClient should only interact with
WebView and not be aware of EwkView so that we have a clean separation between
internal WebKit2 classes and our EFL Ewk API implementation.

This patch is only a first step towards this goal as there is a lot of work
to do to achieve complete separation between EwkView and PageClient. The purpose
of this patch is to introduce the needed architecture which will later be
extended by introducing new WKViewClient callbacks.

  • PlatformEfl.cmake: Add new ViewClientEfl.cpp and WebViewClient.cpp to EFL's CMake

configuration.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetViewClient):

  • UIProcess/API/C/efl/WKView.h: Introduce new WKViewClient C API.
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView): Initialize ViewClientEfl.

  • UIProcess/API/efl/EwkView.h: Add new ViewClientEfl member.

(WebKit):
(EwkView):

  • UIProcess/API/efl/EwkViewCallbacks.h: Update ContentsSizeChanged smart callback to

accept a WKSize in parameter instead of an IntRect.

  • UIProcess/efl/PageClientBase.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientBase::view):
(WebKit::PageClientBase::setViewNeedsDisplay):

  • UIProcess/efl/PageClientBase.h:

(WebKit):
(PageClientBase):

  • UIProcess/efl/PageClientDefaultImpl.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientDefaultImpl::didChangeContentsSize):

  • UIProcess/efl/PageClientLegacyImpl.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientLegacyImpl::didChangeContentsSize):

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit):
(WebKit::ViewClientEfl::toEwkView):
(WebKit::ViewClientEfl::viewNeedsDisplay):
(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):

  • UIProcess/efl/ViewClientEfl.h: Introduce new ViewClientEfl which handles WKViewClient callbacks

and interacts with EwkView.
(WebKit):
(ViewClientEfl):
(WebKit::ViewClientEfl::create):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::initializeClient):
(WebKit):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::didChangeContentsSize):

  • UIProcess/efl/WebView.h: Add new WebViewClient member and corresponding methods to interact

with it.
(WebView):

  • UIProcess/efl/WebViewClient.cpp:

(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):

  • UIProcess/efl/WebViewClient.h: Add new WebViewClient APIClient for WKViewClient.

(WebCore):
(WebKit):

8:15 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
8:12 AM Changeset in webkit [142749] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GTK][AC] Implement basic transform animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109363

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-13
Reviewed by Gustavo Noronha Silva.

Implement basic transform animation with clutter ac backend.
GraphicsLayerClutter is almost same with GraphicsLayerCA. And PlatformClutterAnimation
interfaces are also similar with PlatformCAAnimation, but they are implemented
with native clutter APIs. Clutter backend AC supports a basic single transform animation
with this patch now, but additive animation combination and keyframe animation
are not supported yet.

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetTransform):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::isTransformTypeTransformationMatrix):
(WebCore):
(WebCore::isTransformTypeFloatPoint3D):
(WebCore::isTransformTypeNumber):
(WebCore::getTransformFunctionValue):
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::appendToUncommittedAnimations):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString):
(WebCore):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

7:57 AM Changeset in webkit [142748] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk

[WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
https://bugs.webkit.org/show_bug.cgi?id=109456

Reviewed by Anders Carlsson.

Source/WebKit2:

WebView destructor now considers the situation if its WebPageProxy
instance had been closed from outside the class (explicitly
by client code).

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::~WebView):

Tools:

WebView instance must not live longer than EwkView, as EwkView owns
objects that page proxy refers to, doing otherwise leads to a crash.

Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
leads to evas objects deletion. So, the problem was that test controller was
deleted after ewk_shutdown() had been called in main() function causing
crashes on WTR exit.

The patch introduces a scope for test controller so that it is deleted first.

  • WebKitTestRunner/efl/main.cpp:

(main):

7:30 AM Changeset in webkit [142747] by loislo@chromium.org
  • 6 edits
    1 add in trunk

Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554

In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.

Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.

Reviewed by Yury Semikhatsky.

It is covered by newly added tests in TestWebKitAPI.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.

(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):

7:27 AM Changeset in webkit [142746] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: add experimental native heap graph to Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=109687

Reviewed by Alexander Pavlov.

Added experimentatl support for native heap graph on the Timeline panel.
Native memory usage data is collected after each top level task and can
be displayed instead of DOM counters graph on the Timeline panel if
corresponding experiment is enabled in the inspector settings.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineAgentState):
(WebCore::InspectorTimelineAgent::setIncludeDomCounters):
(WebCore):
(WebCore::InspectorTimelineAgent::setIncludeNativeMemoryStatistics):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):

  • inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelinePanel.js:
7:25 AM Changeset in webkit [142745] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.

No new tests.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):

6:27 AM Changeset in webkit [142744] by atwilson@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed chromium expectation changes resulting from r142719.

  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
6:19 AM Changeset in webkit [142743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix js compilation warnings in TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109685

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

Mark last argument of _applySuggestion function as optional.

No new tests: no change in behaviour.

  • inspector/front-end/TextPrompt.js:
6:09 AM Changeset in webkit [142742] by thiago.santos@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations:
6:04 AM Changeset in webkit [142741] by atwilson@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed chromium expectation changes.
Fallout from r142683.

  • platform/chromium-win/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
6:03 AM Changeset in webkit [142740] by benm@google.com
  • 13 edits
    1 copy
    6 deletes in branches/chromium/1364

Merge 141769

Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

  • features.gypi:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):

  • tests/data/non-fast-scrollable.html:
  • tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

  • compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/iframe-inside-overflow-clipping.html:
  • compositing/overflow/nested-scrolling.html:
  • compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/scrolling-without-painting.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/overflow/updating-scrolling-content.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.

TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/12254005

5:45 AM Changeset in webkit [142739] by commit-queue@webkit.org
  • 30 edits
    5 adds in trunk

Implement css-conditional's CSS.supports()
https://bugs.webkit.org/show_bug.cgi?id=100324

Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-13
Reviewed by Antti Koivisto.

Source/WebCore:

http://dev.w3.org/csswg/css3-conditional/#the-css-interface

The supports() method provides the css @supports rule's corresponding
dom api.
The patch also adds the CSS interface on DOMWindow, which holds "useful
CSS-related functions that do not belong elsewhere". This is where
supports() lives.

Test: css3/supports-dom-api.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

Add DOMWindowCSS.* to the build systems.

  • bindings/scripts/CodeGenerator.pm:

(WK_lcfirst):

Handle CSS prefixes correctly (s/cSS/css/).

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSupportsCondition):
(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:

webkit_supports_condition parses just the condition part of an
@supports rule and evaluates it, outputting whether the condition
is supported or not.

  • css/CSSAllInOne.cpp:
  • css/DOMWindowCSS.cpp: Added.
  • css/DOMWindowCSS.h: Added.
  • css/DOMWindowCSS.idl: Added.

The CSS interface object.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::css):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

window.CSS

LayoutTests:

  • css3/supports-dom-api-expected.txt: Added.
  • css3/supports-dom-api.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
5:15 AM Changeset in webkit [142738] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Simplify SplitView to rely more on CSS
https://bugs.webkit.org/show_bug.cgi?id=109426

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Vsevolod Vlasov.

Simplified Javascript code by moving large part of the layout logic into CSS rules. The patch is larger than it
should be because one of the clients (TimelinePanel) is breaking SplitView incapsulation by reparenting its
resizer.

No new tests.

  • inspector/front-end/SidebarView.js:

(WebInspector.SidebarView):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype._innerSetVertical):
(WebInspector.SplitView.prototype.setSecondIsSidebar):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/cssNamedFlows.css:

(.css-named-flow-collections-view .split-view-sidebar):
(.css-named-flow-collections-view .split-view-sidebar .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar .selection):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before, .css-named-flow-collections-view .region-empty:before, .css-named-flow-collections-view .region-fit::before, .css-named-flow-collections-view .region-overset::before):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before):

  • inspector/front-end/splitView.css:

(.split-view-contents.maximized):
(.split-view-vertical .split-view-contents):
(.split-view-vertical .split-view-contents-first):
(.split-view-vertical .split-view-contents-first.maximized):
(.split-view-vertical .split-view-contents-second):
(.split-view-vertical .split-view-contents-second.maximized):
(.split-view-horizontal .split-view-contents):
(.split-view-horizontal .split-view-contents-first):
(.split-view-horizontal .split-view-contents-first.maximized):
(.split-view-horizontal .split-view-contents-second):
(.split-view-horizontal .split-view-contents-second.maximized):
(.split-view-vertical .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical .split-view-resizer):
(.split-view-horizontal .split-view-resizer):

  • inspector/front-end/timelinePanel.css:

(.timeline.split-view-vertical .split-view-resizer):
(#timeline-container .split-view-sidebar):

4:57 AM Changeset in webkit [142737] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r142730.
http://trac.webkit.org/changeset/142730
https://bugs.webkit.org/show_bug.cgi?id=109666

chromium browser tests are failing

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

3:59 AM Changeset in webkit [142736] by gyuyoung.kim@samsung.com
  • 11 edits in trunk

[WK2] Remove web intents callbacks
https://bugs.webkit.org/show_bug.cgi?id=109654

Reviewed by Benjamin Poulain.

Web intents was removed by r142549.

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

3:39 AM Changeset in webkit [142735] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

OpenCL implementation of Flood SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=109580

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-13
Reviewed by Zoltan Herczeg.

  • Target.pri:
  • platform/graphics/filters/FEFlood.h:

(FEFlood):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore):
(WebCore::PROGRAM_STR):
(WebCore::FilterContextOpenCL::compileFill):
(WebCore::FilterContextOpenCL::fill):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Added.

(WebCore):
(WebCore::FEFlood::platformApplyOpenCL):

3:19 AM Changeset in webkit [142734] by mkwst@chromium.org
  • 11 edits
    1 copy
    2 adds in trunk

location.href does not throw SECURITY_ERR when accessed across origins with JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=43891

Reviewed by Adam Barth.

Source/WebCore:

Other browsers (IE, Firefox, and Opera) throw an exception when accessing
properties of a Location object across origins, as the spec suggests[1].
WebKit is currently the outlier.

This has a few negative effects: developers are forced to hack around
access violations in two ways rather than having a single code path, and
(more annoyingly) developers are unable to avoid generating the error
message. See every ad on the internet for the effect on the console. :)

This patch adds a SECURITY_ERR exception to these access violations,
which is the first step towards getting rid of the console spam. Getting
rid of the message entirely will require a solution to
http://wkbug.com/98050.

A fairly inconclusive thread[2] on webkit-dev popped up in 2010 and
trailed off without reaching conclusion. A more recent thread reached
agreement that this patch seems like a reasonable thing to do[3].

This is the JSC half of the patch. V8 is coming in http://wkbug.com/43892

[1]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#security-location
[2]: https://lists.webkit.org/pipermail/webkit-dev/2010-August/013880.html
[2]: https://lists.webkit.org/pipermail/webkit-dev/2012-February/023636.html

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

  • http/tests/plugins/resources/cross-frame-object-access.html:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-get.html:
  • http/tests/security/resources/cross-frame-access.js:

(accessThrowsException):

  • http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
  • http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:

Adjusting tests to check for exceptions, and adjusting expectations to match.

  • platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Added.
  • platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Copied from LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt.

V8 fails at the moment: http://wkbug.com/43892

2:59 AM Changeset in webkit [142733] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix: removed redundant testRunnet.notifyDone() call that was causing other test failures.

  • inspector/script-execution-state-change-notification.html:
2:45 AM Changeset in webkit [142732] by zandobersek@gmail.com
  • 9 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining tests after the DOM4 Events constructors and CSS image-set
support were enabled.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/gtk/fast/events/constructors: Added.
  • platform/gtk/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
  • platform/gtk/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt:
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt:
  • platform/gtk/fast/hidpi/image-set-simple-expected.txt:
  • platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt:
2:39 AM Changeset in webkit [142731] by atwilson@chromium.org
  • 10 edits in trunk/Source

Unreviewed Chromium gyp-file cleanup after glib backend removal.
https://bugs.webkit.org/show_bug.cgi?id=109672

Removed references to GLib unicode backend:

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/gtk:

  • gyp/Configuration.gypi.in:
  • gyp/Dependencies.gyp:
  • gyp/JavaScriptCore.gyp:
  • gyp/WTF.gyp:

Source/WTF:

  • WTF.gyp/WTF.gyp:
  • WTF.gypi:
2:04 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:58 AM calendar-picker.png attached to EnableFormFeatures by tkent@chromium.org
1:54 AM multiple-fields-example.png attached to EnableFormFeatures by tkent@chromium.org
1:50 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:43 AM Changeset in webkit [142730] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666

Reviewed by Adam Barth.

Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). We should generate
wrapper methods for custom getters/setters.

In the future, I will insert TRACE_EVENT() macros into these wrapper methods
to profile DOM getters/setters/methods.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):

1:28 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:27 AM Changeset in webkit [142729] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

  • platform/qt/TestExpectations:
1:21 AM WikiStart edited by tkent@chromium.org
(diff)
1:21 AM WikiStart edited by tkent@chromium.org
(diff)
1:21 AM EnableFormFeatures created by tkent@chromium.org
1:15 AM WikiStart edited by tkent@chromium.org
(diff)
12:24 AM Changeset in webkit [142728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r142611.
http://trac.webkit.org/changeset/142611
https://bugs.webkit.org/show_bug.cgi?id=109668

Suggest box is not shown anymore when user types "window." in
inspector console. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

12:10 AM Changeset in webkit [142727] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] There is no XXXConstructor that requires a custom getter
https://bugs.webkit.org/show_bug.cgi?id=109667

Reviewed by Adam Barth.

Currently '[Custom] attribute XXXConstructor xxx' generates
XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
In addition, it does make no sense to generate XXXAttrGetter() for such cases.
We can remove the logic from CodeGeneratorV8.pm.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):

Feb 12, 2013:

11:34 PM Changeset in webkit [142726] by morrita@google.com
  • 3 edits
    2 adds in trunk

[Internals] setShadowDOMEnabled() shouldn't be used except a few tests.
https://bugs.webkit.org/show_bug.cgi?id=109642

Reviewed by Kent Tamura.

Source/WebCore:

InternalSettings.setShadowDOMEnabled() shouldn't be called after
any relevant DOM bindings are touched. However for fuzzers, it
isn't trivial to regulate its behavior.

This change whitelists the URL of running test for prevent
unintended API calls. This doesn't hurt the Internals usability
since the API is called from just a couple of tests and the number
isn't expected to grow.

Test: fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html

  • testing/InternalSettings.cpp:

(WebCore::urlIsWhitelisted):
(WebCore):
(WebCore::InternalSettings::setShadowDOMEnabled):

LayoutTests:

  • fast/dom/shadow/shadow-dom-enabled-flag-whitelist-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html: Added.
11:24 PM Changeset in webkit [142725] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch introduces version controller that could be used to migrate inspector settings.

Test: inspector/version-controller.html

  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/version-controller-expected.txt: Added.
  • inspector/version-controller.html: Added.
10:30 PM Changeset in webkit [142724] by commit-queue@webkit.org
  • 9 edits
    5 deletes in trunk

[GTK] Remove the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109627

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Benjamin Poulain.

.:

Remove references to the GLib unicode backend from configuration.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/autotools/SetupAutomake.m4:

Source/WebCore:

Remove references to the GLib unicode backend from WebCore.

  • GNUmakefile.list.am: Update the source list.
  • platform/text/gtk/TextBreakIteratorGtk.cpp: Removed.
  • platform/text/gtk/TextCodecGtk.cpp: Removed.
  • platform/text/gtk/TextCodecGtk.h: Removed.

Source/WTF:

Remove references to the GLib unicode backend from WTF.

  • GNUmakefile.list.am: Remove GLib unicode files from the source list.
  • wtf/unicode/glib/UnicodeGLib.cpp: Removed.
  • wtf/unicode/glib/UnicodeGLib.h: Removed.
10:21 PM Changeset in webkit [142723] by fpizlo@apple.com
  • 7 edits
    3 deletes in trunk/LayoutTests

Eradicate fast/js/dfg-poison-fuzz.html
https://bugs.webkit.org/show_bug.cgi?id=109660

Unreviewed.

I haven't seen this test fail in ages. And I've seen a lot of DFG bugs!

This is a super expensive test for one bug that used to be in the DFG but that has
since been thoroughly eradicated. Likely the plethora of other DFG tests cover that
bug. Heck, I'm not even sure if the code that this covers is even in the repository
anymore.

In the spirit of not having super expensive and mostly useless tests, I'm removing
this test.

  • fast/js/dfg-poison-fuzz-expected.txt: Removed.
  • fast/js/dfg-poison-fuzz.html: Removed.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-poison-fuzz.js: Removed.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
10:16 PM Changeset in webkit [142722] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

10:15 PM Changeset in webkit [142721] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: crash when accessing AccessibilityScrollbar after page has been unloaded
https://bugs.webkit.org/show_bug.cgi?id=109524

Reviewed by Ryosuke Niwa.

AX clients can hold onto AccesibilityScrollbar references that reference parent
AccessibilityScrollViews that have already gone away.

AccessibilityScrollView is not calling detachFromParent after it is removed, which
leads to a crash. The fix is to clearChildren() when an object is deallocated.

I could not create a test because the crash only manifests over multiple page loads.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::detach):
10:13 PM Changeset in webkit [142720] by Lucas Forschler
  • 1 copy in tags/Safari-537.31

New Tag.

10:09 PM Changeset in webkit [142719] by hayato@chromium.org
  • 4 edits in trunk/Source/WebCore

Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=109650

Reviewed by Dimitri Glazkov.

Set FocusEvent.relatedTarget in its constructor so that each
EventDispatchMediator can use FocusEvent.relatedTarget rather than
its redundant m_{old,new}FocusedNode member variable.

I've also removed FIXME comments, mentioning bug 109261, since I
can not reproduce the issue.

No new tests. No change in functionality.

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/FocusEvent.h:

(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

9:17 PM Changeset in webkit [142718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Remove unnecessary and confusing includes from StreamBuffer.h.
https://bugs.webkit.org/show_bug.cgi?id=109652

Patch by Takeshi Yoshino <tyoshino@google.com> on 2013-02-12
Reviewed by Benjamin Poulain.

StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
FixedArray.h and PassOwnPtr.h are included but not used.

VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
is even slower).

  • wtf/StreamBuffer.h:
9:10 PM Changeset in webkit [142717] by tasak@google.com
  • 6 edits in trunk/Source/WebCore

[Refactoring] Make SelectorChecker::mode a constructor parameter.
https://bugs.webkit.org/show_bug.cgi?id=109653

Reviewed by Dimitri Glazkov.

No new tests, because just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
Made mode a constructor parameter.

  • css/SelectorChecker.h:

Removed setMode.
(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::ContentSelectorChecker):

8:58 PM Changeset in webkit [142716] by keishi@webkit.org
  • 6 edits
    3 copies in branches/chromium/1364

Merge 142572

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

  • Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.

TBR=keishi@webkit.org

8:38 PM Changeset in webkit [142715] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

[Chromium] Rebaseline suggestion-picker layout tests
https://bugs.webkit.org/show_bug.cgi?id=109647

Unreviewed rebaseline.
Text position differences, imperceptible to human sight.
Test failures possibly caused by: http://trac.webkit.org/changeset/142659

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-12

  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
8:27 PM Changeset in webkit [142714] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Remove Element::ensureAttributeData().
<http://webkit.org/b/109643>

Reviewed by Anders Carlsson.

  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):

Use attributeData() instead of ensureAttributeData(), it's already guaranteed to exist in
both these functions as they are called in response to attribute changes.

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

Use mutableAttributeData() instead of ensureAttributeData() when invalidating animated
SVG attributes. While I can't find any bugs caused by this, an element with property animations
shouldn't share attribute data with other elements.

8:25 PM Changeset in webkit [142713] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Make {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator type safe.
https://bugs.webkit.org/show_bug.cgi?id=109561

Reviewed by Dimitri Glazkov.

Use FocusEvent rather than Event in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.

No new tests. No change in functionality.

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):

  • dom/FocusEvent.h:

(FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::event):
(BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::event):
(FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::event):
(FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::event):

8:24 PM Changeset in webkit [142712] by eric@webkit.org
  • 10 edits in trunk/Source/WebCore

Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions
https://bugs.webkit.org/show_bug.cgi?id=109638

Reviewed by Adam Barth.

Darin Adler noted in:
https://bugs.webkit.org/show_bug.cgi?id=109408#c4
that HTMLToken::Attribute (then MarkupTokenBase::Attribute)
was a struct, yet incorrectly used m_ for its public members.

This patch fixes the members to not have the m_, and since I was
touching all callers, I also updated all callers to use modern
Vector-based String creation/append functions instead of manually
calling UChar*, size_t versions.

There should be no behavior change to this patch. Where I saw
performance/memory bugs, I noted them with FIXMEs to keep
this change simple.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken):

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLToken.h:

(Range):
(Attribute):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::eraseValueOfAttribute):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::nameForAttribute):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

8:08 PM Changeset in webkit [142711] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

  • editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

7:59 PM Changeset in webkit [142710] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Build fix for Chromium-Win.
Add #include <functional> for std::bind1st.

  • tests/PrerenderingTest.cpp:
7:26 PM Changeset in webkit [142709] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/features.gypi

Merge 141193
BUG=175910
Review URL: https://codereview.chromium.org/12250029

7:05 PM Changeset in webkit [142708] by cevans@google.com
  • 163 edits in branches/chromium/1364/Source

Merge 141034
BUG=175910
Review URL: https://codereview.chromium.org/12251015

6:42 PM Changeset in webkit [142707] by Nate Chapin
  • 7 edits
    3 adds in trunk

REGRESSION: Reloading a local file doesn't pick up changes
https://bugs.webkit.org/show_bug.cgi?id=109344

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/cache/reload-main-resource.php

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::cachePolicy): Don't use subresourceCachePolicy()

for main resources.

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

LayoutTests:

  • http/tests/cache/reload-main-resource-expected.txt: Added.
  • http/tests/cache/reload-main-resource.php: Added.
  • http/tests/cache/resources/reload-main-resource-iframe.php: Added.
  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt: This test

was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.

  • http/tests/misc/link-rel-icon-beforeload-expected.txt: This test

was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.

6:40 PM Changeset in webkit [142706] by mrobinson@webkit.org
  • 3 edits
    5 adds
    1 delete in trunk/Source/WebKit/gtk

[GTK] Connect the gyp build to autoconf
https://bugs.webkit.org/show_bug.cgi?id=109360

Reviewed by Dirk Pranke.

Move Configuration.gypi to Configuration.gypi.in and allow autoconf to
fill in variables during a configuration phase. Also add some scripts
to support connecting autoconf up to the gyp build. This allows us
to have a very autotools-esque experience.

  • gyp/Configuration.gypi: Removed.
  • gyp/Configuration.gypi.in: Added. Fleshed out Configuration.gypi to include

dependency CFLAGS and LIBS directly from configure. Due to the way we are
generating the gyp build now, we also need to include an absolute path to
the build directory. Fixing bugs in gyp should allow us to avoid this in the
future.

  • gyp/Dependencies.gyp: Added this file which holds external dependency targets.

We could consider auto-generating this at some point.

  • gyp/JavaScriptCore.gyp: Remove references to the old Configuration.gypi.

It's now included via the command-line -I flag. Update to support the new
s/default/global/g terminology for variables.

  • gyp/WTF.gyp: Remove the dependency targets as this is now handled entirely

by autoconf.

  • gyp/autogen.sh: Added. Set up the build directory and kick off autoconf.
  • gyp/configure.ac: Added. An autoconf build that re-uses much of our

existing autoconf setup.

  • gyp/run-gyp: Added. Script for invoking gyp for out-of-tree builds.
6:39 PM Changeset in webkit [142705] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller
https://bugs.webkit.org/show_bug.cgi?id=109549

Reviewed by Tony Chang.

Renamed avoidIntersectionWithNode to Editor::avoidIntersectionWithDeleteButtonController and added trivial
implementations when delete button controllers are disabled (ENABLE_DELETION_UI is 0).

  • editing/DeleteButtonController.cpp:
  • editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):

  • editing/Editor.cpp:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Moved from htmlediting.cpp and renamed.
The version that takes VisibleSelection has been updated to use updatePositionForNodeRemoval to share
mode code with that function.
(WebCore::Editor::rangeForPoint):

  • editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Added; trivial implementations.

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:

(WebCore::createMarkupInternal): Extracted from createMarkup.
(WebCore::createMarkup):

6:39 PM Changeset in webkit [142704] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[WK2] Page reloading will crash UIProcess after WebProcess was killed
https://bugs.webkit.org/show_bug.cgi?id=109305

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-12
Reviewed by Benjamin Poulain.

Source/WebKit2:

Re-initialize the pointer to a WebInspectorProxy object before calling
initializeWebPage().

When the WebProcess crashes, WebPageProxy::processDidCrash() will
set WebInspectorProxy pointer to null, which later is accessed by
initializeWebPage(). This patch avoids a crash scenario where
calls into a null pointer would be made.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):

Tools:

Adding a new test to simulate the case of WebProcess crash followed by a trying
to load a new page.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):

6:22 PM Changeset in webkit [142703] by benjamin@webkit.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Mac rebaseline for r142638.

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-12
Reviewed by Benjamin Poulain.

  • platform/mac-lion/accessibility/table-attributes-expected.txt: Removed.
  • platform/mac-lion/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/mac-lion/accessibility/table-sections-expected.txt: Removed.
  • platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-cell-spans-expected.txt:
  • platform/mac/accessibility/table-cells-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Added.
6:20 PM Changeset in webkit [142702] by rafaelw@chromium.org
  • 3 edits in trunk/LayoutTests

[HTMLTemplateElement] Change template.dat serialization format
https://bugs.webkit.org/show_bug.cgi?id=109635

Reviewed by Eric Seidel.

The serialization format now uses 'content' instead of '#document-fragment' to
denote template contents.

  • html5lib/resources/template.dat:
  • resources/dump-as-markup.js:

(Markup._get):

6:13 PM Changeset in webkit [142701] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[iOS] Enable PAGE_VISIBILITY_API
https://bugs.webkit.org/show_bug.cgi?id=109399

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-12
Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
6:10 PM Changeset in webkit [142700] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Update a comment in NetworkProcess to be more accurate.

Rubberstamped by Sam Weinig.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):

5:53 PM Changeset in webkit [142699] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/bindings/v8/ScriptWrappable.h

Merge 140575
BUG=171893
Review URL: https://codereview.chromium.org/12225160

5:43 PM Changeset in webkit [142698] by akling@apple.com
  • 12 edits
    2 deletes in trunk/Source/WebCore

Move ElementAttributeData into Element.cpp/h
<http://webkit.org/b/109610>

Reviewed by Anders Carlsson.

Removed ElementAttributeData.cpp/h and moved the class itself into Element headquarters.
In the near future, Element should be the only client of this class, and thus it won't
be necessary for other classes to know anything about it.

  • dom/ElementAttributeData.cpp: Removed.
  • dom/ElementAttributeData.h: Removed.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/DocumentSharedObjectPool.cpp:
  • dom/Element.cpp:
  • dom/Element.h:
  • workers/SharedWorker.cpp:
  • Modules/webdatabase/DatabaseManager.cpp: Add ExceptionCode.h since Element.h doesn't pull it in anymore.
5:37 PM Changeset in webkit [142697] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Build fix for VS2010 WebKit solution.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:28 PM Changeset in webkit [142696] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

SecItemShim should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109636

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
Add a helper function for dispatching a work queue message receiver message.

(CoreIPC::Connection::processIncomingMessage):
Check if there are any work queue message receivers registered for this message.

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::shared):
Use dispatch_once instead of the AtomicallyInitializedStatic macro.

(WebKit::SecItemShim::SecItemShim):
Initialize the queue.

(WebKit::SecItemShim::secItemResponse):
Remove the connection parameter.

(WebKit::SecItemShim::initializeConnection):
Register the shim object as a work queue message receiver.

  • Shared/mac/SecItemShim.h:

Inherit from WorkQueueMessageReceiver.

  • Shared/mac/SecItemShim.messages.in:

Remove LegacyReceiver and DispatchOnConnectionQueue.

5:25 PM Changeset in webkit [142695] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Renamed SpecObjectMask to SpecObject.

Rubber stamped by Mark Hahnenberg.

"SpecObjectMask" is a weird name considering that a bunch of the other speculated
types are also masks, but don't have "Mask" in the name.

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

5:13 PM Changeset in webkit [142694] by thakis@chromium.org
  • 7 edits in trunk/LayoutTests

Remove webintents from TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=109620

Reviewed by James Robinson.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-mac-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:10 PM Changeset in webkit [142693] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Make Plug-in XPC services "join existing sessions"
<rdar://problem/13196448>

Reviewed by Mark Rowe.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
5:00 PM Changeset in webkit [142692] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Update WebKitDirs.pm for new Windows paths
https://bugs.webkit.org/show_bug.cgi?id=107714

Reviewed by Daniel Bates.

  • Scripts/webkitdirs.pm: For each existing Windows environment

variable, also include creation of the 'new' variables. The
'old' variables will be removed in a future update.
(windowsSourceSourceDir): New helper routine to return the
actual 'Source' folder of the WebKit source tree.

4:58 PM Changeset in webkit [142691] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Crash when scrolling soon after page starts loading
https://bugs.webkit.org/show_bug.cgi?id=109631
<rdar://problem/13157533&13159627&13196727>

Reviewed by Anders Carlsson.

Make the scrolling tree more robust when the root state node,
and/or scrolling node are null. This can happen if we try to
handle a wheel event before we've done the first scrolling
tree commit.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit): Handle the case where
m_rootStateNode is null. We'll still commit, but the state tree
will have no state nodes.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent): Null-check m_rootNode.
(WebCore::ScrollingTree::commitNewTreeState): Handle a null root node.
(WebCore::ScrollingTree::updateTreeFromStateNode): If the rood state node
is null, just clear the map and null out the root scrolling node.

  • page/scrolling/ScrollingTree.h: m_debugInfoLayer was unused.
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ensureRootStateNodeForFrameView): It may be possible
to get here before we've registered the root scroll layer, in which case scrollLayerID()
will be 0. Assert to see if this can ever happen.
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeAsText): Handle case of rootStateNode()
being null.

4:58 PM Changeset in webkit [142690] by weinig@apple.com
  • 4 edits
    16 copies
    11 adds in trunk/Source/WebKit2

Add skeleton of the OfflineStorageProcess
https://bugs.webkit.org/show_bug.cgi?id=109615

Reviewed by Anders Carlsson.

This adds the skeleton of a new process to contain Database and Local Storage
backends in (hence, offline storage). We're adding a new process, rather than
using the Network or UIProcesses, to allow us to tightly sandbox these activities
away from networking and full filesystem access.

  • Configurations/OfflineStorageProcess.xcconfig: Added.
  • Configurations/OfflineStorageService.Development.xcconfig: Added.
  • Configurations/OfflineStorageService.xcconfig: Added.
  • DerivedSources.make:
  • OfflineStorageProcess: Added.
  • OfflineStorageProcess/EntryPoint: Added.
  • OfflineStorageProcess/EntryPoint/mac: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageServiceEntryPoint.mm: Added.
  • OfflineStorageProcess/OfflineStorageProcess.cpp: Added.
  • OfflineStorageProcess/OfflineStorageProcess.h: Added.
  • OfflineStorageProcess/OfflineStorageProcess.messages.in: Added.
  • OfflineStorageProcess/mac: Added.
  • OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: Added.

(WebKit::OfflineStorageProcess::initializeProcessName):
(WebKit::OfflineStorageProcess::initializeSandbox):

  • OfflineStorageProcess/mac/com.apple.WebKit.OfflineStorage.sb: Added.
  • Shared/OfflineStorage: Added.
  • Shared/OfflineStorage/OfflineStorageProcessCreationParameters.cpp: Added.
  • Shared/OfflineStorage/OfflineStorageProcessCreationParameters.h: Added.
  • Scripts/webkit2/messages.py:

(struct_or_class):
Added OfflineStorageProcessCreationParameters.

  • WebKit2.xcodeproj/project.pbxproj:
4:41 PM Changeset in webkit [142689] by eric@webkit.org
  • 4 edits in trunk/Source/WTF

Teach more WTF string classes about vectors with inline capacity
https://bugs.webkit.org/show_bug.cgi?id=109617

Reviewed by Benjamin Poulain.

The HTML and WebVTT parsers use constructions like:
AtomicString name(m_name.data(), m_name.size())
all over the place because they use inline capacity
on the parse vectors for performance.

This change just add the necessary template variants
to the related String constructors/methods in WTF so that
this parser code can just pass the vector directly instead.

I'll do the actual parser cleanups in follow-up patches to keep things simple.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::create8BitIfPossible):

  • wtf/text/WTFString.h:

(String):
(WTF::String::make8BitFrom16BitSource):
(WTF):
(WTF::append):

4:23 PM Changeset in webkit [142688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build warning after r142579
https://bugs.webkit.org/show_bug.cgi?id=109547

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-12
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

4:10 PM Changeset in webkit [142687] by Raymond Toy
  • 3 edits in trunk/Source/WebCore

Synchronize setting of panner node model and processing
https://bugs.webkit.org/show_bug.cgi?id=109599

Reviewed by Chris Rogers.

No new tests.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:
3:53 PM Changeset in webkit [142686] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Remove webintents from TestExpectations on mac - directory no longer exists.

  • platform/mac/TestExpectations:
3:53 PM Changeset in webkit [142685] by dino@apple.com
  • 7 edits in trunk/Source/WebCore

Add class name for snapshotted plugin based on dimensions
https://bugs.webkit.org/show_bug.cgi?id=108369

Reviewed by Simon Fraser.

As the size of the plugin changes, the Shadow Root for the snapshot
might want to toggle different interfaces. Expose "tiny", "small",
"medium" and "large" classes on the Shadow. (The dimensions are
currently chosen fairly arbitrarily).

Because we only know the dimensions after layout, we set up
a post layout task to add the class. Luckily there already was
a post layout task for plugins - I just updated it to handle
both real and snapshotted plugins. This involved modifying
the list of RenderEmbeddedObjects in FrameView to take generic
RenderObjects, and decide which type they are when calling
the update method.

  • html/HTMLPlugInImageElement.cpp: Some new dimensions for the various size thresholds.

(WebCore::classNameForShadowRootSize): New static function that returns a class name

after examining the size of the object.

(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Sets the class name for

the shadow root. This is called in the post layout task.

(WebCore::shouldPlugInShowLabelAutomatically): Use new size names.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Ditto.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New method updateSnapshotInfo.

  • page/FrameView.cpp:

(WebCore::FrameView::addWidgetToUpdate): Change RenderEmbeddedObject* to RenderObject*.
(WebCore::FrameView::removeWidgetToUpdate): Ditto
(WebCore::FrameView::updateWidget): Branch based on EmbeddedObject vs SnapshottedPlugIn. Call

plugin snapshot update if necessary.

(WebCore::FrameView::updateWidgets): Handle both EmbeddedObject and SnapshottedPlugIn cases.

  • page/FrameView.h: Change RenderEmbeddedObject* to RenderObject* for post layout widget updates.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::layout): New virtual override. If size has changed, ask the

FrameView to recalculate size after layout.

  • rendering/RenderSnapshottedPlugIn.h: New layout() method.
3:53 PM Changeset in webkit [142684] by alecflett@chromium.org
  • 2 edits in trunk/Tools

Fix signedness in WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=109623

Reviewed by Adam Barth.

Fix signedness problem, using size_t instead of int.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3:44 PM Changeset in webkit [142683] by mkwst@chromium.org
  • 14 edits
    11 adds in trunk

Implement script MIME restrictions for X-Content-Type-Options: nosniff
https://bugs.webkit.org/show_bug.cgi?id=71851

Reviewed by Adam Barth.

Source/WebCore:

This patch adds support for 'X-Content-Type-Options: nosniff' when
deciding whether or not to execute a given chunk of JavaScript. If the
header is present, script will only execute if it matches a predefined
set of MIME types[1] that are deemed "executable". Scripts served with
types that don't match the list will not execute.

IE introduced this feature, and Gecko is working on an implementation[2]
now. There's been some discussion on the WHATWG list about formalizing
the specification for this feature[3], but nothing significant has been
decided.

This implementation's list of acceptible MIME types differs from IE's:
it matches the list of supported JavaScript MIME types defined in
MIMETypeRegistry::initializeSupportedJavaScriptMIMETypes()[4]. In
particular, the VBScript types are not accepted, and
'text/javascript1.{1,2,3}' are accepted, along with 'text/livescript'.

This feature is locked tightly behind the ENABLE_NOSNIFF flag, which is
currently only enabled on the Chromium port.

[1]: http://msdn.microsoft.com/en-us/library/gg622941(v=vs.85).aspx
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=471020
[3]: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-November/037974.html
[4]: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/MIMETypeRegistry.cpp?rev=142086#L307

Tests: http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html

http/tests/security/contentTypeOptions/nosniff-script-allowed.html
http/tests/security/contentTypeOptions/nosniff-script-blocked.html
http/tests/security/contentTypeOptions/nosniff-script-without-content-type-allowed.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

Before executing script, ensure that it shouldn't be blocked due to
its MIME type. If it is blocked, write an error message to the
console.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::mimeType):

Make scripts' MIME type available outside the context of
CachedScript in order to correctly populate error messages we write
to the console in ScriptElement::executeScript

(WebCore):
(WebCore::CachedScript::mimeTypeAllowedByNosniff):

  • loader/cache/CachedScript.h:

(CachedScript):

A new method which checks the resource's HTTP headers to set the
'nosniff' disposition, and compares the resource's MIME type against
the list of allowed executable types. Returns true iff the script
is allowed.

  • platform/network/HTTPParsers.cpp:

(WebCore):
(WebCore::parseContentTypeOptionsHeader):

  • platform/network/HTTPParsers.h:

Adds a new enum which relates the sniffable status of the resource,
and a method to parse the HTTP header.

LayoutTests:

  • http/tests/security/contentTypeOptions/invalid-content-type-options-allowed-expected.txt: Added.
  • http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-allowed-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-allowed.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-blocked-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-blocked.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html: Added.
  • http/tests/security/contentTypeOptions/resources/script-with-header.pl: Added.

New tests!

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:

Skip the new tests on platforms where ENABLE_NOSNIFF isn't yet
enabled (everything other than Chromium).

3:38 PM Changeset in webkit [142682] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Assume setScrollingOrZooming() to be called on the WebKit thread.
https://bugs.webkit.org/show_bug.cgi?id=109614
Internal PR 294513

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

With this further simplification of threading assumptions,
we can get rid of atomic integer access as well as the
backing store mutex which was otherwise unused.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::isScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

3:35 PM Changeset in webkit [142681] by Raymond Toy
  • 2 edits in trunk/Tools

Add alias

3:28 PM Changeset in webkit [142680] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 141858
BUG=174020
Review URL: https://codereview.chromium.org/12250020

3:23 PM Changeset in webkit [142679] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA doesn't filter precisely enough for CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=109618

Reviewed by Mark Hahnenberg.

The backend speculates object for this case, but the CFA was filtering on
(SpecCell & ~SpecString) | SpecOther.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

3:10 PM Changeset in webkit [142678] by Christophe Dumez
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Reenable ewk_auth_request API tests
https://bugs.webkit.org/show_bug.cgi?id=108451

Reviewed by Benjamin Poulain.

ewk_auth_request API tests were temporarily disabled after
the C API for resource loading was removed from WebKit2.
This patches updates the tests so that they no longer rely
on the resource loading events and renables them.

This patch also corrects the naming of the static variables
in the test to follow more closely the WebKit coding style.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:

(serverCallback):
(TEST_F):
(onLoadFinished):

3:09 PM Changeset in webkit [142677] by jpetsovits@rim.com
  • 11 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate the direct rendering option.
https://bugs.webkit.org/show_bug.cgi?id=109608
RIM PR 293298

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

It added a lot of complexity and we're not going to use it anymore.
This patch removes direct rendering functionality from
WebKit/blackberry together with the assumption that blitting on the
WebKit thread is possible or acceptable. It now isn't anymore.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSettings.cpp:

(WebKit):

  • Api/WebSettings.h:
  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
(BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::initialize):

3:05 PM Changeset in webkit [142676] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp

Merge 140879
BUG=172243
Review URL: https://codereview.chromium.org/12217152

2:57 PM Changeset in webkit [142675] by tkent@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/css/html.css

Merge 142076

REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132

Reviewed by Hajime Morita.

<input type=date> should be shown in Japanese UI as:
[ ?\229?\185?\180 /?\230?\156?\136/?\230?\151?\165]
But it is shown wrongly since r141195:
/?\230?\156?\136/?\230?\151?\165

We should use white-space:pre.

No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.

  • css/html.css:

(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.

TBR=tkent@chromium.org
BUG=crbug.com/174827
Review URL: https://codereview.chromium.org/12211140

2:56 PM Changeset in webkit [142674] by eae@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed chromium rebaseline for r142638, garden-o-matic screwed up the original rebaseline :(

  • platform/chromium-mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium-win-xp/fast/dom/Window: Added.
  • platform/chromium-win-xp/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
2:44 PM Changeset in webkit [142673] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Threaded HTML parser should pass the remaining fast/tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=109607

Reviewed by Eric Seidel.

This patch fixes some edge cases involving document.write. Previously,
we would drop input characters on the floor if the tokenizer wasn't
able to consume them synchronously. In this patch, we send the unparsed
characters to the background thread for consumption after rewinding the
input stream.

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::finish):

  • html/parser/HTMLInputStream.h:

(WebCore::HTMLInputStream::closeWithoutMarkingEndOfFile):
(HTMLInputStream):

2:17 PM Changeset in webkit [142672] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Introduce a WorkQueueMessageReceiver class as a replacement for QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109612

Reviewed by Andreas Kling.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addWorkQueueMessageReceiver):
(CoreIPC):
(CoreIPC::Connection::removeWorkQueueMessageReceiver):
(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
(CoreIPC::Connection::removeWorkQueueMessageReceiverOnConnectionWorkQueue):

  • Platform/CoreIPC/Connection.h:

(Connection):

2:16 PM Changeset in webkit [142671] by dgrogan@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 142564
pre-requisite to merging https://src.chromium.org/viewvc/chrome?view=rev&revision=182008

IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519

Reviewed by Adam Barth.

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:

TBR=dgrogan@chromium.org
BUG=174895
Review URL: https://codereview.chromium.org/12212148

1:59 PM Changeset in webkit [142670] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] CSS animations stop running during zoom
https://bugs.webkit.org/show_bug.cgi?id=109606

Patch by Andrew Lo <anlo@rim.com> on 2013-02-12
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

Internal PR 286160.
New BackingStore API for suspending/resuming geometry updates.

This is needed because we want to allow render jobs to continue during
zoom, but we don't want to allow geometry updates during zoom.

Prevent scroll/zoom render jobs from being added to the queue if
the tile is outside the expanded content rect.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendGeometryUpdates):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::resumeGeometryUpdates):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStore::suspendGeometryUpdates):
(BlackBerry::WebKit::BackingStore::resumeGeometryUpdates):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):

1:51 PM QtWebKitBugs edited by jocelyn.turcotte@digia.com
(diff)
1:36 PM Changeset in webkit [142669] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix for !ENABLE(INSPECTOR) platforms after r142654.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::scriptsEnabled):

1:32 PM Changeset in webkit [142668] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Typo fix after r142663.

  • GNUmakefile.list.am:
1:28 PM Changeset in webkit [142667] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

1:26 PM Changeset in webkit [142666] by Lucas Forschler
  • 1 copy in branches/safari-536.29-branch

New Branch.

1:24 PM Changeset in webkit [142665] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.js

Merge 141890

Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.

Quick fix for regression.

  • inspector/front-end/inspector.js:

Avoid "exit route" when URL is a profile URL.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12223108

1:21 PM Changeset in webkit [142664] by Christophe Dumez
  • 8 edits in trunk

Remove remaining traces of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=109586

Reviewed by Eric Seidel.

.:

Remove references to Web Intents from CMake files as the functionality
was removed in r142549.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Remove remaining traces of Web Intents as the functionality was
removed in r142549.

No new tests, no behavior change for layout tests.

  • GNUmakefile.features.am.in:
  • html/HTMLTagNames.in:

Source/WebKit/blackberry:

Remove remaining traces of Web Intents from Blackberry port
configuration as the functionality was removed in r142549.

  • WebCoreSupport/AboutDataEnableFeatures.in:
1:19 PM Changeset in webkit [142663] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

[WK2] Unreviewed trivial buildfix after r142630 and r142651.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):

1:17 PM Changeset in webkit [142662] by luiz@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/watchlist

Adding myself to watch lists.

Unreviewed.

  • Scripts/webkitpy/common/config/watchlist:
1:15 PM Changeset in webkit [142661] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1364

Merge 142128

Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/map-expected.txt:
  • inspector/map.html:

TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/12208136

1:07 PM Changeset in webkit [142660] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js

Merge 142127

Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12225145

1:06 PM Changeset in webkit [142659] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html

The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.
1:03 PM Changeset in webkit [142658] by eae@chromium.org
  • 7 edits
    10 adds
    2 deletes in trunk/LayoutTests

Unreviewed rebaseline for r142638.

  • platform/chromium-linux-x86/fast/dom/Window: Removed.
  • platform/chromium-linux-x86/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/webkitConvertPoint-expected.txt:
  • platform/chromium-win/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/mac-lion/accessibility: Added.
  • platform/mac-lion/accessibility/table-attributes-expected.txt: Added.
  • platform/mac-lion/accessibility/table-cell-spans-expected.txt: Added.
  • platform/mac-lion/accessibility/table-sections-expected.txt: Added.
  • platform/mac-lion/fast/dom/Window: Added.
  • platform/mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Added.
  • platform/mac-wk2/fast/dom/Window: Added.
  • platform/mac-wk2/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac/accessibility/image-link-expected.txt:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt:
1:01 PM Changeset in webkit [142657] by leviw@chromium.org
  • 3 edits
    2 adds in trunk
ASSERTION FAILED: !object
object->isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker

https://bugs.webkit.org/show_bug.cgi?id=108699

Reviewed by Abhishek Arya.

Source/WebCore:

RenderListItems performs special management of its children to maintain list markers. Splitting a flow
through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splitting
flows when inside one.

Test: fast/multicol/span/list-multi-column-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

  • fast/multicol/span/list-multi-column-crash-expected.txt: Added.
  • fast/multicol/span/list-multi-column-crash.html: Added.
12:56 PM Changeset in webkit [142656] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Change the queue client base class to be private everywhere
https://bugs.webkit.org/show_bug.cgi?id=109604

Reviewed by Andreas Kling.

Move connection queue client registration inside of the respective queue client classes.

Also, it's too late to add queue clients in ChildProcessProxy::didFinishLaunching, so do this in
ChildProcessProxy::connectionWillOpen instead.

Finally, assert that queue clients are only being added and removed from the client thread.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection):

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::initializeConnection):
(WebKit):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::connectionWillOpen):
(WebKit):
(WebKit::NetworkProcessProxy::connectionWillClose):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::initializeConnection):
(WebKit):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::initializeConnection):
(WebKit):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

12:56 PM Changeset in webkit [142655] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):

12:45 PM Changeset in webkit [142654] by vivek.vg@samsung.com
  • 10 edits
    2 adds in trunk

Web Inspector: JavaScript execution disabled by browser/UA should be notified to the front-end
https://bugs.webkit.org/show_bug.cgi?id=109402

Reviewed by Yury Semikhatsky.

Source/WebCore:

Whenever the UA/Browser changes the Script Execution state of a page, it should notify the
inspector front-end. Added the InspectorInstrumentation method didScriptExecutionStateChange
to achieve this. Also the state change triggered by the inspector should be ignored to avoid
infinite loop.

Test: inspector/script-execution-state-change-notification.html

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::scriptsEnabledImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::scriptsEnabled):
(WebCore):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
(WebInspector.PageDispatcher.prototype.scriptsEnabled):

  • page/Settings.cpp:

(WebCore::Settings::setScriptEnabled):

LayoutTests:

Tests that whenever Script Execution state is changed outside inspector, its notified to the Inspector front-end.

  • inspector/script-execution-state-change-notification-expected.txt: Added.
  • inspector/script-execution-state-change-notification.html: Added.
12:23 PM Changeset in webkit [142653] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB/Worker crash during shutdown
https://bugs.webkit.org/show_bug.cgi?id=109467

Reviewed by Tony Chang.

If the message queue has already been terminated, don't bother scheduling
a new error event that will never be delivered. Speculative fix for the
issue, which only repros in multiprocess ports and so far only on some
platforms.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.

12:14 PM Changeset in webkit [142652] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Cache timer heap pointer to timers
https://bugs.webkit.org/show_bug.cgi?id=109597

Reviewed by Andreas Kling.

Accessing timer heap through thread global storage is slow (~0.1% in PLT3). We can cache the heap pointer to
each TimerBase. There are not huge numbers of timers around so memory is not an issue and many timers are heavily reused.

  • platform/Timer.cpp:

(WebCore::threadGlobalTimerHeap):
(WebCore::TimerHeapReference::operator=):
(WebCore::TimerHeapIterator::checkConsistency):
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::checkHeapIndex):
(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(WebCore::TimerBase::timerHeap):
(TimerBase):

12:12 PM Changeset in webkit [142651] by beidson@apple.com
  • 17 edits
    2 adds in trunk/Source/WebKit2

Add WKContext API to retrieve basic network process statistics
https://bugs.webkit.org/show_bug.cgi?id=109329

Reviewed by Sam Weinig.

This patch adds a WKContextGetStatisticsWithOptions which allows the client to ask for
certain types of statistics.

It also expands the "get statistics" callback mechanism to allow for a statistics request
to be answered by multiple child processes.

That mechanism still has some rough edges but will eventually allow for getting statistics
from multiple web processes, as well.

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::pendingRequestCount):
(WebKit::HostRecord::activeLoadCount):

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getNetworkProcessStatistics):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::hostsPendingCount):
(WebKit::NetworkResourceLoadScheduler::loadsPendingCount):
(WebKit::NetworkResourceLoadScheduler::hostsActiveCount):
(WebKit::NetworkResourceLoadScheduler::loadsActiveCount):

  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • Shared/Authentication/AuthenticationManager.h:

(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):

  • Shared/Downloads/DownloadManager.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/StatisticsRequest.cpp: Added.

(WebKit::StatisticsRequest::StatisticsRequest):
(WebKit::StatisticsRequest::~StatisticsRequest):
(WebKit::StatisticsRequest::addOutstandingRequest):
(WebKit::addToDictionaryFromHashMap):
(WebKit::createDictionaryFromHashMap):
(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/StatisticsRequest.h: Added.

(WebKit::StatisticsRequest::create):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::networkingProcessConnection):
(WebKit::WebContext::getStatistics):
(WebKit::WebContext::requestWebContentStatistics):
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::didGetStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

  • WebKit2.xcodeproj/project.pbxproj:
11:56 AM Changeset in webkit [142650] by mrobinson@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the gyp build of JavaScriptCore.

  • JavaScriptCore.gypi: Added some missing DFG files to the source list.
11:46 AM Changeset in webkit [142649] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r142387.
http://trac.webkit.org/changeset/142387
https://bugs.webkit.org/show_bug.cgi?id=109601

caused all layout and jscore tests on windows to fail
(Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedCodeBlock):

11:39 AM Changeset in webkit [142648] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

BackgroundHTMLParser::resumeFrom should take a struct
https://bugs.webkit.org/show_bug.cgi?id=109598

Reviewed by Eric Seidel.

This patch is purely a syntatic change that paves the way for fixing
the partial-entity document.write tests. To fix those tests, we'll need
to pass more information to resumeFrom, but we're hitting the argument
limits in Functional.h. Rather than adding yet more arguments, this
patch moves to a single argument that's a struct.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):
(BackgroundHTMLParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

11:35 AM Changeset in webkit [142647] by esprehn@chromium.org
  • 3 edits in trunk/Source/WebCore

rootRenderer in FrameView is really RenderView
https://bugs.webkit.org/show_bug.cgi?id=109510

Reviewed by Eric Seidel.

The global function rootRenderer(FrameView*) is really just a way
to get the RenderView from the Frame so replace it with a renderView()
method and replace usage of the word "root" with renderView so it's
obvious the root we're talking about is the renderView. This is an
important distinction to make since we also have rootRenderer in the code
for the documentElement()'s renderer and we also have a "layout root" which
is entirely different.

No new tests, just refactoring.

  • page/FrameView.cpp:

(WebCore::FrameView::rootRenderer): Removed.
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::usesCompositedScrolling):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::scrollLayerID):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

  • page/FrameView.h:

(WebCore::FrameView::renderView): Added.

11:27 AM Changeset in webkit [142646] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][Introspection] GObject bindings for DataTransferItemList - one add() method must be removed from .idl
https://bugs.webkit.org/show_bug.cgi?id=109180

Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-12
Reviewed by Xan Lopez.

When compiling WebKit with --enable-introspection and generating GObject bindings
for DataTransferItemList we must disable one add() method, because GObject is
based on C and C does not allow two functions with the same name.

No tests needed.

  • bindings/scripts/CodeGeneratorGObject.pm:
11:13 AM Changeset in webkit [142645] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Background size width specified in viewport percentage units not working
https://bugs.webkit.org/show_bug.cgi?id=109536

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Corrected the check for viewport percentage unit while calculating
background image width.

Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

Added a test for background image width specified in viewport percentage unit.

  • fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
  • fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
11:04 AM Changeset in webkit [142644] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

Add back the files to the Xcode project that were removed in r142580.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
10:50 AM Changeset in webkit [142643] by jochen@chromium.org
  • 14 edits
    1 copy in trunk/Tools

[chromium] move text dump generation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109575

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.

(WebTestRunner::normalizeLayoutTestURL):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::checkResponseMimeType):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpAsText):
(WebTestRunner::TestRunner::shouldGeneratePixelResults):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):
(TestShell::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::captureHistoryForWindow):

  • DumpRenderTree/chromium/WebViewHost.h:
10:49 AM Changeset in webkit [142642] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::DeleteButtonController::enable
https://bugs.webkit.org/show_bug.cgi?id=109447

Reviewed by Ryosuke Niwa.

RefPtr frame pointer since it can get deleted due to mutation events
fired inside AppendNodeCommand::doUnapply.

No new tests. Testcase is hard to minimize due to recursive
calls with DOMNodeRemovedFromDocument mutation event.

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):

10:43 AM Changeset in webkit [142641] by eric@webkit.org
  • 26 edits
    1 add
    1 delete in trunk/Source/WebCore

Remove HTMLTokenTypes header (and split out AtomicHTMLToken.h from HTMLToken.h)
https://bugs.webkit.org/show_bug.cgi?id=109525

Reviewed by Adam Barth.

We no longer need a separate HTMLTokenTypes class now that NEW_XML is gone.
However, to remove HTMLTokenTypes, I had to split AtomicHTMLToken.h from
HTMLToken.h (to fix a circular dependancy).

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addSource):

  • html/parser/AtomicHTMLToken.h: Added.

(WebCore):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::forceQuirks):
(WebCore::AtomicHTMLToken::type):
(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::selfClosing):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::characters):
(WebCore::AtomicHTMLToken::charactersLength):
(WebCore::AtomicHTMLToken::isAll8BitData):
(WebCore::AtomicHTMLToken::comment):
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::clearExternalCharacters):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/CompactHTMLToken.h:

(WebCore::CompactHTMLToken::type):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::sourceForToken):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::forceQuirks):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::publicIdentifier):
(WebCore::HTMLToken::systemIdentifier):
(WebCore::HTMLToken::setPublicIdentifierToEmptyString):
(WebCore::HTMLToken::setSystemIdentifierToEmptyString):
(WebCore::HTMLToken::appendToPublicIdentifier):
(WebCore::HTMLToken::appendToSystemIdentifier):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):
(HTMLToken):

  • html/parser/HTMLTokenTypes.h: Removed.
  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::usesName):
(WebCore::AtomicHTMLToken::usesAttributes):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):

10:40 AM Changeset in webkit [142640] by commit-queue@webkit.org
  • 8 edits in trunk

Handle error recovery in @supports
https://bugs.webkit.org/show_bug.cgi?id=103934

Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Tests 021, 024, 031, and 033 in
http://hg.csswg.org/test/file/5f94e4b03ed9/contributors/opera/submitted/css3-conditional
fail because there's no explicit error recovery in @support's grammar.
Opera and Firefox pass the tests.

No new tests, modified css3/supports{,-cssom}.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
(WebCore::CSSParser::popSupportsRuleData):

  • css/CSSParser.h:

LayoutTests:

  • css3/supports-cssom.html:
  • css3/supports-expected.txt:
  • css3/supports.html:
10:34 AM Changeset in webkit [142639] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] guard against NULL languages array
https://bugs.webkit.org/show_bug.cgi?id=109595

Reviewed by Dean Jackson.

No new tests, existing tests won't crash if this is correct.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::preferredLanguages):

9:40 AM Changeset in webkit [142638] by eae@chromium.org
  • 9 edits
    4 adds in trunk

TransformState::move should not round offset to int
https://bugs.webkit.org/show_bug.cgi?id=108266

Source/WebCore:

Reviewed by Simon Fraser.

Currently TransformState::move rounds the offset to the nearest
integer values, this results in operations using TransformState
to compute a position to misreport the location, specifically
Element:getBoundingClientRect and repaint rects. Sizes are
handled correctly and do not have the same problem.

Tests: fast/sub-pixel/boundingclientrect-subpixel-margin.html

fast/sub-pixel/clip-rect-box-consistent-rounding.html

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):
Change to use pixel snapping instead of enclosing box. All other
code paths use pixelSnappedIntRect to align the rects to device
pixels however this used enclosingIntRect (indirectly through
the FloatQuad::enclosingBoundingBox call).
Without the rounding in TransformState this causes repaint rects
for elements on subpixel bounds to be too large by up to one
pixel on each axis. For normal repaints this isn't really a
problem but in scrollContentsSlowPath it can result in moving
too large a rect.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::translateTransform):
(WebCore::TransformState::translateMappedCoordinates):
Change to take a LayoutSize instead of an IntSize.

(WebCore::TransformState::move):
(WebCore::TransformState::applyAccumulatedOffset):

  • platform/graphics/transforms/TransformState.h:

Remove rounding logic and use original, more precise, value.

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer):
Remove rounding logic and use original, more precise, value.

LayoutTests:

Reviewed by Simon Fraser.

Add new tests for Element::boundingClientRect and clip rects for
elements on subpixel boundaries.

  • fast/dom/Window/webkitConvertPoint.html:
  • platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt:

Update test and expectations to take new rounding into account.

  • fast/sub-pixel/boundingclientrect-subpixel-margin-expected.txt: Added.
  • fast/sub-pixel/boundingclientrect-subpixel-margin.html: Added.

Add test ensuring that boundingClientRect returns accurate and
precise (as opposed to rounded) metrics.

  • fast/sub-pixel/clip-rect-box-consistent-rounding-expected.html: Added.
  • fast/sub-pixel/clip-rect-box-consistent-rounding.html: Added.

Add test ensuring that clip rects and elements use consistent rounding.

9:37 AM Changeset in webkit [142637] by jberlin@webkit.org
  • 8 edits
    1 delete in trunk

Rollout r142618, it broke all the Mac builds.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(WebCore):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
9:34 AM Changeset in webkit [142636] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG CompareEq optimization should be retuned
https://bugs.webkit.org/show_bug.cgi?id=109545

Reviewed by Mark Hahnenberg.

  • Made the object-to-object equality case work again by hoisting the if statement for it. Previously, object-to-object equality would be compiled as object-to-object-or-other.


  • Added AbstractState guards for most of the type checks that the object equality code uses.


Looks like a hint of a speed-up on all of the things.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

9:05 AM Changeset in webkit [142635] by rafaelw@chromium.org
  • 5 edits in trunk

[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338

Reviewed by Adam Barth.

Source/WebCore:

This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.

Tests added to html5lib.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

  • html5lib/resources/template.dat:
9:04 AM Changeset in webkit [142634] by mrobinson@webkit.org
  • 5 edits in trunk

[GTK] Remove the enable-debug-feature configuration option
https://bugs.webkit.org/show_bug.cgi?id=109539

Reviewed by Philippe Normand.

Remove the --enable-debug-feature option from configuration. It doesn't
do anything that --enable-debug doesn't.

  • Source/autotools/PrintBuildConfiguration.m4: Remove references to --enable-debug-features.
  • Source/autotools/ReadCommandLineArguments.m4: Ditto.
  • Source/autotools/SetupAutoconfHeader.m4: Ditto.
  • Source/autotools/SetupAutomake.m4: Ditto.
8:59 AM Changeset in webkit [142633] by keishi@webkit.org
  • 5 edits
    6 copies in branches/chromium/1364

Merge 142111

Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute