Timeline



Jun 18, 2013:

10:10 PM Changeset in webkit [151722] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

9:37 PM Changeset in webkit [151721] by gyuyoung.kim@samsung.com
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed, EFL gardening. Added new baselines for some of editing/delete
tests after system upgrade.

  • platform/efl/TestExpectations:
  • platform/efl/editing/deleting/smart-delete-003-expected.png: Added.
  • platform/efl/editing/deleting/smart-delete-003-expected.txt: Added.
  • platform/efl/editing/deleting/smart-delete-004-expected.png: Added.
  • platform/efl/editing/deleting/smart-delete-004-expected.txt: Added.
9:31 PM Changeset in webkit [151720] by Lucas Forschler
  • 11 edits
    1 add in tags/Safari-537.46

Merge <rdar://problem/14171207>

9:11 PM Changeset in webkit [151719] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Input type range slider is not updated when min or max are changed
https://bugs.webkit.org/show_bug.cgi?id=117778

Reviewed by Kent Tamura.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.

Test: fast/forms/range/range-change-min-max.html

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::minOrMaxAttributeChanged):

LayoutTests:

  • fast/forms/range/range-change-min-max-expected.html: Added.
  • fast/forms/range/range-change-min-max.html: Added.
8:37 PM Changeset in webkit [151718] by Lucas Forschler
  • 1 copy in tags/Safari-537.46

New Tag.

8:31 PM Changeset in webkit [151717] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove two superfluous overrides of supportsFocus
https://bugs.webkit.org/show_bug.cgi?id=117770

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/4228964a63e3a889a40efce0d01866629fdcd9b9.

  • html/HTMLOptGroupElement.cpp:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp:
  • html/HTMLOptionElement.h:
7:02 PM Changeset in webkit [151716] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Media elements never fail to load
https://bugs.webkit.org/show_bug.cgi?id=117767

Mark the media tests as failing for now.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18

  • platform/mac-wk2/TestExpectations:
6:51 PM Changeset in webkit [151715] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Improve style of null checks in FrameView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=117681

Reviewed by Sam Weinig.

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect): Used nested if statements and local variables
to tighten this code up a little.

6:45 PM Changeset in webkit [151714] by Christophe Dumez
  • 19 edits in trunk/Source/WebCore

Move IDL extended attributes to their correct location
https://bugs.webkit.org/show_bug.cgi?id=117732

Reviewed by Kentaro Hara.

Move IDL extended attributes to their correct location according to the
latest Web IDL specification. We used to be inconsistent in the positioning
of the extended attributes. This simplifies a lot the code of the IDL parser
and makes our IDL files more standard.

Based on Blink r148345 by Kentaro Hara <haraken@chromium.org>.

No new tests, no behavior change.

  • Modules/encryptedmedia/MediaKeyMessageEvent.idl:
  • Modules/notifications/Notification.idl:
  • Modules/speech/SpeechSynthesisVoice.idl:
  • bindings/scripts/IDLParser.pm:

(parseDefinitions):
(parseInterfaceMembers):
(parseInterfaceMember):
(parseDictionaryMembers):
(parseAttributeOrOperationOrIterator):
(parseAttribute):

  • css/CSSFontFaceLoadEvent.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLSourceElement.idl:
  • page/DOMWindow.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGScriptElement.idl:
  • testing/TypeConversions.idl:
6:32 PM Changeset in webkit [151713] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Let the script to update the Localizable.strings file do the reordering it wants to do.

Rubber-stamped by Anders Carlsson.

  • English.lproj/Localizable.strings:
6:15 PM Changeset in webkit [151712] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
files in Visual Studio.

  • WebCore.vcxproj/WebCore.vcxproj: Add missing files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
6:12 PM Changeset in webkit [151711] by achristensen@apple.com
  • 2 edits
    1 add in trunk/Tools

Working on coverage script, added xml to json data extraction script.
https://bugs.webkit.org/show_bug.cgi?id=117648

This is part of a new test code coverage analysis tool. This compiles WebKit to generate
coverage data, runs the tests, and collects all of the data in json format.

Reviewed by Stephanie Lewis.

  • Scripts/generate-coverage-data:

(parseGcovrOutput):
(getFileHitsAndBranches):
(addLineCounts):
(createResultName):

  • Scripts/webkitpy/tool/gcovr: Added.
5:51 PM Changeset in webkit [151710] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

Unreviewed build fix after r151699.

  • TestWebKitAPI/CMakeLists.txt:
  • WebKitTestRunner/CMakeLists.txt:

Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h

5:36 PM Changeset in webkit [151709] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Going to google.com/trends causes a crash
https://bugs.webkit.org/show_bug.cgi?id=117602

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

When handling op_throw, etc we need to flush the variables and arguments
for the entire inline stack, not just the top frame.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushAllArgumentsAndCapturedVariablesInInlineStack):
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Make sure we correctly initialise the appropriate argument registers,
and make sure we perform the tearoff correctly.

  • fast/js/inline-arguments-tear-off-expected.txt: Added.
  • fast/js/inline-arguments-tear-off.html: Added.
  • fast/js/script-tests/inline-arguments-tear-off.js: Added.

(g):
(f):
(doStuff):

5:12 PM Changeset in webkit [151708] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix a typo that may be causing some test failures.

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):

4:39 PM Changeset in webkit [151707] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r151513.
http://trac.webkit.org/changeset/151513
https://bugs.webkit.org/show_bug.cgi?id=117763

It causes assertions in debug (Requested by benjaminp on
#webkit).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

4:16 PM Changeset in webkit [151706] by roger_fong@apple.com
  • 145 edits
    1 move in trunk

Replace tools32 folder with tools and update WebKit Windows solution accordingly.
<rdar://problem/14118143>.

Rubberstamped by Brent Fulgham.

3:50 PM Changeset in webkit [151705] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline after system update

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18

  • http/tests/cache/partitioned-cache-expected.txt:
  • http/tests/cache/partitioned-cache-iframe-expected.txt:

System fix, the tests pass.

3:44 PM Changeset in webkit [151704] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
https://bugs.webkit.org/show_bug.cgi?id=117755

Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
and Rect prototypes, so they get the expected methods. We then need to
handle the ZERO_RECT case better, and not attempt to draw a background
in a canvas with a 0 size, which would produce an exception.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-18
Reviewed by Timothy Hatcher.

  • UserInterface/Geometry.js:
  • UserInterface/Popover.js:

(WebInspector.Popover.prototype._update):

3:31 PM Changeset in webkit [151703] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRunsAndFloatsInRange function
https://bugs.webkit.org/show_bug.cgi?id=117757

Reviewed by David Hyatt.

We don't need keep lineOverflowsFromShapeInside boolean in RenderBlock::layoutRunsAndFloatsInRange and in its
helpers because it's easy to decide whether we are in an shape content overflow state or not, so I got rid of
lineOverflowsFromShapeInside's occurences and updated the affected functions.

Covered by existing overflow tests in fast/exclusions/shape-inside and fast/regions/shape-inside.

  • rendering/RenderBlock.h: Update helper's definition.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox): Add condition when overflow is already positioned.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Remove lineOverflowsFromShapeInside.

3:03 PM Changeset in webkit [151702] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

widthMediaFeatureEval ends up with null FrameView during iframe unload.
https://bugs.webkit.org/show_bug.cgi?id=117754

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-18
Reviewed by Geoffrey Garen.

Ensure that MediaQueryEvaluator checks against NULL FrameView.

While frames are being unloaded, the Frame object does not necessarily have valid
FrameView anymore. Layout on the main frame can end up querying media values on such child
frames, while detaching.

Source/WebCore:

Test: fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html

  • css/MediaQueryEvaluator.cpp:

(WebCore::orientationMediaFeatureEval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::MediaQueryEvaluator::eval):

LayoutTests:

  • fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery-expected.txt: Added.
  • fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html: Added.
  • fast/frames/resources/child-iframe-forces-parent-layout-on-unload.html: Added.
3:01 PM Changeset in webkit [151701] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Make it possible to set a minimum height for auto-layout
https://bugs.webkit.org/show_bug.cgi?id=117758
<rdar://problem/12849080>

Reviewed by Tim Horton.

Change a bunch of minimumLayoutWidth declarations to minimumLayoutSize and add a new minimumLayoutSize property.
If minimumLayoutSize.height is greater than zero, use it to set the minimum layout size on the frame view.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _setIntrinsicContentSize:]):
(-[WKView minimumLayoutWidth]):
(-[WKView setMinimumLayoutWidth:]):
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]):
(-[WKView minimumSizeForAutoLayout]):
(-[WKView setMinimumSizeForAutoLayout:]):

  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMinimumLayoutSize):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::minimumLayoutSize):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMinimumLayoutSize):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::minimumLayoutSize):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

2:53 PM Changeset in webkit [151700] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

sandbox violation when Flash runs for the first time
https://bugs.webkit.org/show_bug.cgi?id=117753
<rdar://problem/14165466>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-18
Reviewed by Alexey Proskuryakov.

Allow flash to try and change the ownership of directories it has just created.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
2:39 PM Changeset in webkit [151699] by Beth Dakin
  • 11 edits
    1 add in trunk/Source

Expose a getMediaType method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-18
Reviewed by Brady Eidson.

Source/WebCore:

  • WebCore.exp.in: Updated to add a symbol for

HitTestResult::mediaIsVideo method
and alphabetize the list of exposed methods.

Source/WebKit2:

  • GNUmakefile.list.am:
  • Target.pri:

Updated to include the added header file InjectedBundleHitTestResultMediaType.h

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toBundleHitTestResultMediaType):
(WebKit::toAPI):
Added methods to convert between BundleHitTestResultMediaType
and WKBundleHitTestResultMediaType.

  • WebKit2.xcodeproj/project.pbxproj: Updated to include

InjectedBundleHitTestResultMediaType.h in the WebKit2 project.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultGetMediaType): Exposes the method getMediaType and
hooks into InjectedBundleHitTestResult::getMediaType.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::getMediaType): Added to return
what type, if any, a media element is.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResultMediaType.h: Added

to contain new BundleHitTestResultMediaType enums.

2:34 PM Changeset in webkit [151698] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused bool argument from ReplacementFragment's constructor
https://bugs.webkit.org/show_bug.cgi?id=117752

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/265586d9f154a9dff657511d09926429b8e1b53d.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplaceSelectionCommand::doApply):

2:29 PM Changeset in webkit [151697] by eric.carlson@apple.com
  • 13 edits in trunk

Not all subtitle tracks are SDH
https://bugs.webkit.org/show_bug.cgi?id=117738

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::isSDH): New.

  • html/track/InbandTextTrack.h: Add isSDH override.
  • html/track/TextTrack.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::isSDH): New.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes

spoken dialog for accessibility" and "describes music and sound for accessibility"
characteristics.

LayoutTests:

  • media/video-controls-captions-trackmenu-localized.html:
  • media/video-controls-captions-trackmenu-sorted.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
2:25 PM Changeset in webkit [151696] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify FormKeyGenerator::willDeleteForm
https://bugs.webkit.org/show_bug.cgi?id=117751

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/c6399efb9da863eb1d1fc98b17ef925998b985ac

  • html/FormController.cpp:

(WebCore::FormKeyGenerator::willDeleteForm):

2:25 PM Changeset in webkit [151695] by rniwa@webkit.org
  • 3 edits
    1 add in trunk

REGRESSION(r147602): Search text field doesn't render selection when it has some :focus rules
https://bugs.webkit.org/show_bug.cgi?id=117747

Reviewed by Kent Tamura.

.:

  • ManualTests/search-select-all-with-focus-style.html: Added.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/7ff656c8239ce3b125246abcc8b149a603fcff28

r147612 added setNeedsLayout(true, MarkOnlyThis) for
TextControlInnerTextElement renderer. It's ok for input[type=text]
because RenderTextControlSingleLine also has needsLayout flag, and it
has only the inner text renderer as a child.

As for input[type=search], it doesn't work. Renderer structure for
input[type=search] is:

RenderTextControlSingleLine
└Renderer for TextControlInnerContainer

└Renderer for TextControlInnerElement

└Renderer for TextControlInnerTextElement

After r147612, there is a case that only RenderTextControlSingleLine
and TextControlInnerTextElement renderer have needsLayout flag, and
others don't. It won't trigger layout for
TextControlInnerTextElement renderer.

We should set needsLayout flags of TextControlInnerContainer renderer
and TextControlInnerElement renderer by MarkContainingBlockChain.

Manual Tests: search-select-all-with-focus-style.html
(I tried but couldn't make a test that works in DRT)

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::styleDidChange):

1:40 PM Changeset in webkit [151694] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix for non-Mac.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData):

1:28 PM Changeset in webkit [151693] by dino@apple.com
  • 10 edits
    5 adds in trunk

Synthesized vertical italics on rotated glyphs are transformed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117726

Reviewed by Enrica Casucci.

Source/WebCore:

If a font does not have italic glyphs, and is in a vertical flow, then
the synthesis of italics was skewing in the wrong direction. While here,
ensure that no CJK text will get italics in vertical layout.

This is a topic under discussion in the CSS Working Group. The resolution
at the June 2013 face-to-face was that:

  • italics in Japanese (and Chinese) text are rare in vertical layout
  • most people wanted Latin text to italicize in the direction of the line flow

The final behaviour was left undefined, but we consider the change here
to be sufficient for now. In all cases, the best solution is to avoid
synthesized italics by specifying a font that includes such forms.

Tests: fast/text/international/synthesized-italic-vertical-latin.html

fast/text/international/synthesized-italic-vertical.html

  • platform/graphics/FontGlyphs.cpp:

(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): New function

that makes a new glyph data pair that is marked as NOT using a synthesized italic.

(WebCore::FontGlyphs::glyphDataAndPageForCharacter): If this is a CJK character and

has a synthesized oblique, then run it through the function above to make a new glyph data pair.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData): Creates/returns a new SimpleFontData that will

not synthesize italics.

  • platform/graphics/SimpleFontData.h: New method nonSyntheticItalicFontData.
  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): This is the actual bug fix. If you are in a vertical flow, the

skew direction should be downwards, not leftwards.

LayoutTests:

Two new tests. One ensures that CJK characters do not get italics
when vertical. The other ensures that Latin text does get italics in
a font that is not synthesized, but unfortunately has to be a pixel test.
The latter is skipped on non-Mac since they don't support
synthesized obliques in FontPlatformData.

  • fast/text/international/synthesized-italic-vertical-expected.html: Added.
  • fast/text/international/synthesized-italic-vertical-latin.html: Added.
  • fast/text/international/synthesized-italic-vertical.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
1:28 PM Changeset in webkit [151692] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebKit

Unreviewed. Build fix for Mac and Win

1:14 PM Changeset in webkit [151691] by roger_fong@apple.com
  • 3 edits
    6 adds in trunk/Source

Re-implement WebFrameNetworkingContext.
<rdar://problem/13174821>.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h: Added.

(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: Added.

(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::blockedError):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebCoreSupport/WebFrameNetworkingContext.h: Added.

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebFrameNetworkingContext::userAgent):

  • WebCoreSupport/WebFrameNetworkingContext.mm: Added.

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::sourceApplicationAuditData):
(WebFrameNetworkingContext::blockedError):
(WebFrameNetworkingContext::storageSession):

1:05 PM Changeset in webkit [151690] by ap@apple.com
  • 3 edits
    6 deletes in trunk/Source

<rdar://problem/13174821> Remove files with an incorrect license.

Rubber-stamped by Maciej Stachowiak.

This will break the build, stay tuned for a fix coming soon.

12:58 PM Changeset in webkit [151689] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WTF

PackedIntVector: check template arguments at compile time
https://bugs.webkit.org/show_bug.cgi?id=117737

Use 'COMPILE_ASSERT' instead of 'ASSERT' in PackedIntVector class
constructor.

Reviewed by Sam Weinig.

  • wtf/PackedIntVector.h:

(WTF::PackedIntVector::PackedIntVector):

12:38 PM Changeset in webkit [151688] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

If the tree outline is processing a selection currently, then don't change the selection.

This is needed to allow breakpoints tree elements to be selected without jumping back to
selecting the resource tree element.

https://bugs.webkit.org/show_bug.cgi?id=117746

Reviewed by Joseph Pecoraro.

  • UserInterface/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):

  • UserInterface/TreeOutline.js:

(TreeElement.prototype.select):

11:49 AM Changeset in webkit [151687] by timothy@apple.com
  • 14 edits
    1 add in trunk/Source/WebInspectorUI

Update breakpoints to match Xcode 5.

This updates the breakpoint images, line colors, and moves breakpoints toggle button
to the Debugger sidebar navigation bar.

https://bugs.webkit.org/show_bug.cgi?id=117723

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
  • UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):

  • UserInterface/Images/Breakpoint.png: Updated.
  • UserInterface/Images/Breakpoints.pdf: Added.
  • UserInterface/Images/Breakpoint@2x.png: Updated.
  • UserInterface/Images/BreakpointButton.pdf: Updated.
  • UserInterface/Images/BreakpointInactive.png: Updated.
  • UserInterface/Images/BreakpointInactive@2x.png: Updated.
  • UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
  • UserInterface/Images/InstructionPointer.png: Updated.
  • UserInterface/Images/InstructionPointer@2x.png: Updated.
  • UserInterface/SourceCodeTextEditor.css:

(.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
(.source-code.text-editor > .CodeMirror .warning): Ditto.

  • UserInterface/TextEditor.css:

(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
(.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
(.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.

10:51 AM Changeset in webkit [151686] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

The page title of technical-articles.html is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=117727

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-18
Reviewed by Ryosuke Niwa.

Changed the page title of technical-articles.html to "WebKit Technical Articles".

  • coding/technical-articles.html:
10:38 AM Changeset in webkit [151685] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r151549.
http://trac.webkit.org/changeset/151549
https://bugs.webkit.org/show_bug.cgi?id=117741

broke selection in the web inspector source after scrolling
(Requested by smfr on #webkit).

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderLayerModelObject.cpp:
  • rendering/RenderLayerModelObject.h:

LayoutTests:

  • fast/repaint/change-overflow-and-display-of-relative-expected.txt: Removed.
  • fast/repaint/change-overflow-and-display-of-relative.html: Removed.
9:09 AM BuildingGtk edited by Manuel Rego Casasnovas
Add link to WebKitGTK+ main page in trac.webkit.org (diff)
8:16 AM Changeset in webkit [151684] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

<video> element delays document load event for ~ 3 seconds
https://bugs.webkit.org/show_bug.cgi?id=90272

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-18
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-preload-no-delay-loadevent.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
No need to delay document load event here when preload="none"

LayoutTests:

  • media/media-preload-no-delay-loadevent-expected.txt: Added.
  • media/media-preload-no-delay-loadevent.html: Added.
6:16 AM Changeset in webkit [151683] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.2

Tagging the WebKitGTK+ 2.1.2 release

6:04 AM Changeset in webkit [151682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
https://bugs.webkit.org/show_bug.cgi?id=117546

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-18
Reviewed by Xan Lopez.

According to the WebKit IDL spec the modifier ObjCPolymorphic only
applies to the Objective-C bindings generator

  • bindings/scripts/CodeGeneratorGObject.pm:

(IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
concatening a series of 'or' conditionals.

5:24 AM Changeset in webkit [151681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix after r151673
https://bugs.webkit.org/show_bug.cgi?id=116042

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

Removed a spurious semicolon in the video sink caps definition.

No new tests, no behavior change.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
4:23 AM Changeset in webkit [151680] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebSpeech] Speech Recognition requires convertValue support in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=117731

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-18
Reviewed by Christophe Dumez.

Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
resolves the issue.

No new tests. No change in behaviour.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:
3:30 AM Changeset in webkit [151679] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.1.2 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.1.2.
2:35 AM Changeset in webkit [151678] by zarvai@inf.u-szeged.hu
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaseline and skipping some tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-18

  • platform/qt-5.0-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.
  • platform/qt/TestExpectations:
  • platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
2:13 AM Changeset in webkit [151677] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] only notify download client when download error
https://bugs.webkit.org/show_bug.cgi?id=117687

Reviewed by Rob Buis.

When met network error in downloading, we notify the error to download
client through download stream, we shouldn't notify page client the error.
RIM JIRA 419985

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::shouldNotifyClientFailed):

1:35 AM Changeset in webkit [151676] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

Shader compiler not properly configured for GLES on cairo based ports
https://bugs.webkit.org/show_bug.cgi?id=117705

Reviewed by Martin Robinson.

Configure the shader compiler with SH_ESSL_OUTPUT for GLESv2
compliant platforms, and with SH_GLSL_OUTPUT otherwise.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

1:29 AM Changeset in webkit [151675] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

touching any idl rebuilds all derived sources
https://bugs.webkit.org/show_bug.cgi?id=117708

Reviewed by Kentaro Hara.

Fix preprocess-idls.pl script to update the following files only
if they have changed:
DerivedSources/WebCore/supplemental_dependency.tmp
DerivedSources/WebCore/DOMWindowConstructors.idl
DerivedSources/WebCore/WorkerContextConstructors.idl

This avoids triggering uselessly bindings generation for all IDL
files whenever an IDL file is touched.

No new tests, no behavior change.

  • bindings/scripts/preprocess-idls.pl:

(WriteFileIfChanged):
(GeneratePartialInterface):

1:18 AM Changeset in webkit [151674] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK][GStreamer] Fullscreen option in video element context menu not working
https://bugs.webkit.org/show_bug.cgi?id=105191

.:

Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

  • Source/autotools/SetupAutoconfHeader.m4: Removed the use of

fullscreen native media controls.

LayoutTests:

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

  • platform/gtk-wk1/TestExpectations:

fullscreen/video-controls-drag.html does not time out anymore.

  • platform/gtk-wk2/TestExpectations:

media/video-display-aspect-ratio.html crashes sometimes.

  • platform/gtk/TestExpectations:

media/video-playing-and-pause.html was already flaky.

1:09 AM Changeset in webkit [151673] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] [texmap] upload a video buffer into the video texture
https://bugs.webkit.org/show_bug.cgi?id=116042

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

This patch prepares more quickly the texture when the video frame is
already in the GPU memory.

It is done using a new buffer's metadata available in GStreamer 1.2,
and its purpose is to upload buffers into a OpenGL texture.

If the decoder provides buffers with this metadata, the buffer will be
uploaded into the texture used for the video display and it will be
rendered, avoiding a expensive mem copies. This is particularly useful
for Full HD videos, where all the processing and display will be done
in the GPU.

No new tests, covered by existing tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkProposeAllocation):

12:20 AM Changeset in webkit [151672] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Mark two tests that are flakily timing out as slow.
12:02 AM Changeset in webkit [151671] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

A static_assert() in RetainPtr.h sometimes causes the build to fail.

Wrap the first argument to a static_assert() in parentheses since it
contains a comma, which sometimes tricks the preprocessor into thinking
the macro is being passed three arguments rather than two.

Reviewed by Brian Weinstein.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):

12:00 AM Changeset in webkit [151670] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

REGRESSION (r149184): Build errors in RefPtr.h when building with Clang, C++98 standard
https://bugs.webkit.org/show_bug.cgi?id=116352

Reviewed by Anders Carlsson.

Use the has_feature macro instead of the has_extension one when detecting what features the Clang compiler
that's being used is capable to provide. With the project moving onto using C++11 throughout its components,
there currently exist cases where C++11-specific functionality (for instance std::move) is used despite being
guarded by compiler-specific feature guards that still get enabled even when compiling in C++98 with Clang.
The problematic features are enabled because they're available as C++98 language extensions by Clang.

Using has_feature instead enables the feature guard only if the tested feature is actually standardized in
the currently used language standard.

  • wtf/Compiler.h:

Jun 17, 2013:

11:24 PM Changeset in webkit [151669] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Extra whitespace in blank line in PlatformPopupMenuData.cpp
https://bugs.webkit.org/show_bug.cgi?id=117627

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-17
Reviewed by Brent Fulgham.

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::decode):
Removing extra space

11:09 PM Changeset in webkit [151668] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Set the http response status text
https://bugs.webkit.org/show_bug.cgi?id=117307

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-17
Reviewed by Brent Fulgham.

No new tests, covered by existing ones.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback):

10:59 PM Changeset in webkit [151667] by Brent Fulgham
  • 1 edit
    4 adds in trunk/LayoutTests

[Windows] Unreviewed AX gardening of windows-specific results.

  • platform/win/accessibility/aria-combobox-expected.txt: Added.
  • platform/win/aria-labelledby-on-input-expected.txt: Added.
  • platform/win/aria-menubar-menuitems-expected.txt: Added.
  • platform/win/aria-roles-expected.txt: Added.
10:59 PM Changeset in webkit [151666] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unneeded WebCore namespace in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=117718

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-17
Reviewed by Christophe Dumez.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: Remove 'using namespace WebCore'.
6:30 PM Changeset in webkit [151665] by Brent Fulgham
  • 5 edits
    3 adds in trunk

AX: Correct accessibility role when -webkit-box:display is used.
https://bugs.webkit.org/show_bug.cgi?id=117706

Reviewed by Chris Fleizach.

Source/WebCore:

accessibility/box-styled-lists.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
of the list element type, treat it as a ListItemRole accessibility role, regardless
of what specific renderer is being used.

LayoutTests:

  • accessibility/box-styled-lists.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/accessibility/box-styled-lists-expected.txt: Added.
  • platform/win/TestExpectations:
  • platform/win/accessibility/box-styled-lists-expected.txt: Added.
6:19 PM Changeset in webkit [151664] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Mac rebaseline.

  • fast/repaint/table-cell-collapsed-border-scroll-expected.png:
  • fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
6:08 PM Changeset in webkit [151663] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk/Source/WTF

Initialize AtomicStringTable in WTFThreadData's constructor
https://bugs.webkit.org/show_bug.cgi?id=117671

Reviewed by Geoffrey Garen.

Extracted AtomicStringTable from AtomicString.cpp into AtomicStringTable.h/cpp
and made WTFThreadDada::WTFThreadData create the atomic string table for the thread.

This eliminates a branch from stringTable() in AtomicString.cpp.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

  • wtf/text/AtomicString.cpp:

(WTF::stringTable):

  • wtf/text/AtomicStringTable.cpp: Added.

(WTF::AtomicStringTable::create):
(WTF::AtomicStringTable::destroy):

  • wtf/text/AtomicStringTable.h: Added.

(WTF::AtomicStringTable::table):

5:54 PM Changeset in webkit [151662] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Add some UNUSED_PARAMs to RenderBlock.cpp so that it builds properly if CSS_EXCLUSIONS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=117722.
Rubberstamped by Jon Lee.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

5:41 PM Changeset in webkit [151661] by Beth Dakin
  • 9 edits in trunk/Source

PageBanners appear over HTML5 video when media element is in full screen mode
https://bugs.webkit.org/show_bug.cgi?id=117721
-and corresponding-
<rdar://problem/13686998>

Reviewed by Sam Weinig.

Source/WebCore:

Update the scrolling tree when a header/footer has been removed.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):

Source/WebKit2:

When an element enters fullscreen, hide the banners. Show them again when the
element exits fullscreen.

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):

Handle hiding and showing by removing or re-creating a parent layer for m_layer.

  • WebProcess/WebPage/PageBanner.cpp:

(WebKit::PageBanner::hide):
(WebKit::PageBanner::showIfHidden):

  • WebProcess/WebPage/PageBanner.h:
  • WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::hide):
(WebKit::PageBanner::showIfHidden):
(WebKit::PageBanner::mouseEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hidePageBanners):
(WebKit::WebPage::showPageBanners):

  • WebProcess/WebPage/WebPage.h:
5:23 PM Changeset in webkit [151660] by roger_fong@apple.com
  • 8 edits in trunk/Source

Modify Windows makefiles to copy some bin output into Program Files.
https://bugs.webkit.org/show_bug.cgi?id=117714.
<rdar://problem/14179054>

Reviewed by Brent Fulgham.

  • WTF.vcxproj/WTF.make:
  • JavaScriptCore.vcxproj/JavaScriptCore.make:
  • WebCore.vcxproj/WebCore.make:
  • WebKit.vcxproj/WebKit.make:
5:09 PM Changeset in webkit [151659] by roger_fong@apple.com
  • 12 edits
    1 add in tags/Safari-537.45.1

Disable some feature flags and update test expectations.
<rdar://problem/14171207>.

Rubberstamped by Jon Lee.

  • Configurations/FeatureDefines.xcconfig:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • platform/mac/TestExpectations:
  • platform/mac/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
  • platform/mac/fast/js/constructor-length-expected.txt:
4:50 PM Changeset in webkit [151658] by msaboff@apple.com
  • 12 edits in branches/dfgFourthTier/Source/JavaScriptCore

FTL: Add another temp register regT4 to JSInterfaceJIT
https://bugs.webkit.org/show_bug.cgi?id=117719

Reviewed by Geoffrey Garen.

Made the dedicated bucketCounterRegister to be regT4 and then used regT4 wherever
bucketCounterRegister had been used. Since it is masked whenever it is used and
we are looking for some randomness in the register anyway, we can use it without
any issues.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):

  • jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSite):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_get_argument_by_val):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_get_argument_by_val):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):

  • jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

3:42 PM Changeset in webkit [151657] by mvujovic@adobe.com
  • 2 edits in trunk/Source/WebCore

Crash in loadPendingShaders
https://bugs.webkit.org/show_bug.cgi?id=117665

Reviewed by Dean Jackson.

Speculative fix because the crash reports do not contain a test case.

Rearrange the conditions to check m_state.hasPendingShaders() first. Additionally, check if
m_state.style() is non-null.

No new tests. We don't know how to reproduce this crash yet.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShaders):

2:50 PM Changeset in webkit [151656] by commit-queue@webkit.org
  • 19 edits in trunk/Source

REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
https://bugs.webkit.org/show_bug.cgi?id=20599

Add a "Download Video"/"Download Audio" context menu item to download media
elements.

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-17
Reviewed by Beth Dakin.

Source/WebCore:

No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

  • English.lproj/Localizable.strings: Updated to

include localizable strings for "Download Video" and "Download Audio".

  • page/ContextMenuController.cpp: Updated to

include and handle a "Download Video/Audio" context menu item.

  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/qt/LocalizedStringsQt.cpp:

Updated to include localizable strings for "Download Video" and "Download Audio".

Source/WebKit/efl:

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_contextmenu.h:

Updated to include new EWK enum type for "Download Video/Audio" context menu item.

Source/WebKit2:

  • Shared/API/c/WKContextMenuItemTypes.h: Updated to include

an enum type for the "Download Video/Audio" context menu item.

  • Shared/API/c/WKSharedAPICast.h: Updated to associate

the enums in WebKit and WebCore that handle the "Download Video/Audio"
context menu item.

  • UIProcess/API/efl/ewk_context_menu.cpp:
  • UIProcess/API/efl/ewk_context_menu_item.cpp:
  • UIProcess/API/efl/ewk_context_menu_item.h:

Updated to include new EWK enum type for "Download Video/Audio" context menu item.

  • UIProcess/WebPageProxy.cpp: Updated to

handle the "Download Video/Audio" context menu item mouse click
and download the media item in the UI process.

2:27 PM Changeset in webkit [151655] by Lucas Forschler
  • 5 edits in tags/Safari-537.45.1/Source

Versioning.

2:22 PM Changeset in webkit [151654] by Lucas Forschler
  • 1 copy in tags/Safari-537.45.1

New Tag.

2:18 PM Changeset in webkit [151653] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][CSS Shaders] Use forwarding header for TextureMapperPlatformCompiledProgram.h
https://bugs.webkit.org/show_bug.cgi?id=117712

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-17
Reviewed by Noam Rosenthal.

  • Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.h:
1:23 PM Changeset in webkit [151652] by zoltan@webkit.org
  • 8 edits
    2 copies in trunk

[CSS Shapes] Consider bottom borders when calculating the position of the overflow
https://bugs.webkit.org/show_bug.cgi?id=117663

Reviewed by Alexandru Chiculita.

When you have a shape and the content overflows from the shape we need to push the overflow below the content box,
not below the border box. We didn't consider the bottom borders of the content box, now I fixed it too and the overflow
just starts after the content box. I added a new helper function called pushShapeContentOverflowBelowTheContentBox. Now
both the shape in flow thread and the shape overflow use the same function. I added a new test and modified the existing
tests to cover all the affected cases.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
Existing overflow tests also modified to test the behavior:

fast/exclusions/shape-inside/shape-inside-empty-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):

LayoutTests:

  • fast/exclusions/shape-inside/shape-inside-empty-expected.html:
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html.
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html.
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html:
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html:
11:54 AM Changeset in webkit [151651] by mark.lam@apple.com
  • 24 edits
    4 adds in branches/dfgFourthTier/Source

Rolling r151456, r151420 back in with some fixes.
https://bugs.webkit.org/show_bug.cgi?id=117390.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

New changes on top of the old patch:

  • Renamed CallFrame::beginAt() to CallFrame::find(), and also provide a version that takes a CallFrame* to search for.

There are 3 types of users of the StackIterator. We need to cater
to each of these as follows:

  1. Users who want a stack trace
    • Here we need to start iterating from vm.topCallFrame.
    • To do this, create the StackIterator as follows:

StackIterator iter = vm.topCallFrame->begin();

  1. Users who want their caller frame
    • Here we need to start iterating from the specified CallFrame*.
    • To do this, create the StackIterator as follows:

StackIterator iter = callFrame->begin();

  1. Users who want the frame of a specific JSFunction object
    • Here we need to start iterating from vm.topCallFrame and find the frame that has a callee matching the specified JSFunction*.
    • To do this, create the StackIterator as follows:

StackIterator iter = exec->find(functionObj);

The previous layout test failures were due to conflation of case 1
and 2. They are now handled appropriately.

  • Fixed a pre-existing layout test crash in inspector/profiler/cpu-profiler-agent-crash-on-start.html.
  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • interpreter/CallFrame.cpp:
  • interpreter/CallFrame.h:

(JSC::ExecState::setInlineCallFrame):
(ExecState):

  • interpreter/CallFrameInlines.h:

(JSC::CallFrame::begin):
(JSC::CallFrame::find):
(JSC::CallFrame::end):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):

  • interpreter/Interpreter.h:

(Interpreter):

  • interpreter/StackIterator.cpp: Added.

(JSC::StackIterator::StackIterator):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::find):
(JSC::StackIterator::Frame::codeType):
(JSC::StackIterator::Frame::functionName):
(JSC::StackIterator::Frame::sourceURL):
(JSC::StackIterator::Frame::toString):
(JSC::StackIterator::Frame::bytecodeOffset):
(JSC::StackIterator::Frame::line):
(JSC::StackIterator::Frame::column):
(JSC::StackIterator::Frame::arguments):
(JSC::StackIterator::Frame::retrieveExpressionInfo):
(JSC::StackIterator::Frame::logicalFrame):
(JSC::StackIterator::Frame::logicalCallerFrame):
(JSC::jitTypeName):
(JSC::printIndents):
(JSC::printif):
(JSC::StackIterator::Frame::print):
(debugPrintCallFrame):

  • interpreter/StackIterator.h: Added.

(StackIterator::Frame):
(JSC::StackIterator::Frame::create):
(JSC::StackIterator::Frame::isJSFrame):
(JSC::StackIterator::Frame::callFrame):

  • interpreter/StackIteratorPrivate.h: Added.

(StackIterator):
(JSC::StackIterator::operator*):
(JSC::StackIterator::operator->):
(JSC::StackIterator::operator==):
(JSC::StackIterator::operator!=):
(JSC::StackIterator::operator++):
(JSC::StackIterator::end):

  • jsc.cpp:

(functionJSCStack):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

  • profiler/ProfileNode.h:

(ProfileNode):

  • runtime/JSFunction.cpp:

(JSC::retrieveArguments):
(JSC::JSFunction::argumentsGetter):
(JSC::skipOverBoundFunctions):
(JSC::retrieveCallerFunction):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • runtime/Operations.h:

Source/WebCore:

No new tests.

  • ForwardingHeaders/interpreter/StackIterator.h: Copied from Source/WebCore/ForwardingHeaders/interpreter/StackIterator.h.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

11:53 AM Changeset in webkit [151650] by betravis@adobe.com
  • 2 edits
    2 adds in trunk/LayoutTests

[CSS Exclusions] Implement text alignment for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=101086

Reviewed by Alexandru Chiculita.

Adding tests to make sure that shape-inside layout correctly supports
the different values of text-align.

  • fast/exclusions/resources/multi-segment-polygon.js:

(createOrInsert):

  • fast/exclusions/shape-inside/shape-inside-text-align-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-text-align.html: Added.
11:17 AM Changeset in webkit [151649] by fpizlo@apple.com
  • 8 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support Switch
https://bugs.webkit.org/show_bug.cgi?id=117704

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::clearImmediateSwitchJumpTables):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildFPToSI):
(JSC::FTL::buildSwitch):
(JSC::FTL::addCase):
(FTL):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(LowerDFGToLLVM):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::fpToInt):
(JSC::FTL::Output::fpToInt32):
(Output):
(JSC::FTL::Output::switchInstruction):

  • ftl/FTLSwitchCase.h: Added.

(FTL):
(SwitchCase):
(JSC::FTL::SwitchCase::SwitchCase):
(JSC::FTL::SwitchCase::value):
(JSC::FTL::SwitchCase::target):

11:06 AM Changeset in webkit [151648] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

Cache FatFinger Text Result.
https://bugs.webkit.org/show_bug.cgi?id=107403.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-17
Reviewed by Rob Buis.

Internally Reviewed by Genevieve Mak.
Cache the FatFinger text result for later use in TouchEventHandler.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

  • WebKitSupport/TouchEventHandler.h:

(BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
(TouchEventHandler):

11:05 AM Changeset in webkit [151647] by igor.o@sisa.samsung.com
  • 4 edits
    6 adds in trunk

[CSS Regions] ::before and ::after pseudo-elements are not displayed for regions
https://bugs.webkit.org/show_bug.cgi?id=80163

Source/WebCore:

When the implementation of the before/after was moved to the DOM, before/after generated
content stoppped to work with css regions. The problem happens when:

  1. RenderRegion can not have children and when the PseudoElement::attach tries to create a renderer for the

generated content, it fails.

  1. RenderRegion::canHaveGeneratedChildren should not be false because regions can have generated content.

Reviewed by David Hyatt.

Tests: fast/regions/region-dynamic-after-before.html

fast/regions/region-generated-content-before-after.html

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • rendering/RenderRegion.h:

LayoutTests:

Add two simple tests verifying if region works with before/after generated content.

Reviewed by David Hyatt.

  • fast/regions/region-dynamic-after-before.html: Added.
  • fast/regions/region-generated-content-before-after.html: Added.
  • platform/mac/fast/regions/region-dynamic-after-before-expected.png: Added.
  • platform/mac/fast/regions/region-dynamic-after-before-expected.txt: Added.
  • platform/mac/fast/regions/region-generated-content-before-after-expected.png: Added.
  • platform/mac/fast/regions/region-generated-content-before-after-expected.txt: Added.
10:53 AM Changeset in webkit [151646] by mrowe@apple.com
  • 4 edits
    1 copy in trunk/Source/WebKit2

<rdar://problem/13145014> Allow CoreIPC messages to transmit importance boosts

Transmitting the importance boost from the UI process to the web process is particularly
important when disabling process suppression on a web process, as it will minimize the
delays that can occur before the message instructing process suppression to be disabled
is processed by the web process.

We keep the importance boost alive for the duration of the CoreIPC message handler. We
achieve this by having an ImportanceAssertion object that owns the assertion, and whose
lifetime is tied to that of the MessageDecoder.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::setImportanceAssertion): Associate an importance assertion
with this message.

  • Platform/CoreIPC/MessageDecoder.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open): Mark our receive port as allowing importance boosts to be received.
(CoreIPC::Connection::receiveSourceEventHandler):

  • Platform/CoreIPC/mac/ImportanceAssertion.h:

(CoreIPC::ImportanceAssertion::create):
(CoreIPC::ImportanceAssertion::~ImportanceAssertion): Release the assertion.
(CoreIPC::ImportanceAssertion::ImportanceAssertion): Take an assertion if a boost was present in
the Mach message.

10:08 AM Writing Layout Tests for DumpRenderTree edited by bfulgham@webkit.org
(diff)
9:40 AM Changeset in webkit [151645] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/14051357> Web processes sometimes remain in a suppressed
state after their window is unoccluded.

The code in WKView that responds to occlusion notifications was incorrectly
treating the window's occlusion state as being an enum rather than the set of
flags that it is.

Reviewed by Oliver Hunt.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidChangeOcclusionState:]): Test only the visibility state.
(-[WKView setWindowOcclusionDetectionEnabled:]): Ditto.

9:22 AM Changeset in webkit [151644] by fpizlo@apple.com
  • 9 edits
    6 adds in branches/dfgFourthTier

fourthTier: Add CFG simplification for Switch
https://bugs.webkit.org/show_bug.cgi?id=117677

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This is for completeness. It only speeds up a microbenchmark at this point.
Broadly, we want all control constructs to be known to the CFG simplifier.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::noBlocks):
(JSC::DFG::CFGSimplificationPhase::oneBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • runtime/JSCJSValue.h:

(JSValue):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureStrictEqual):
(JSC):

Source/WTF:

Reviewed by Mark Hahnenberg.

  • wtf/TriState.h:
  • wtf/text/StringImpl.h:

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/regress/script-tests/switch-constant.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/switch.js: Added.

(foo):
(bar):

  • fast/js/regress/switch-constant-expected.txt: Added.
  • fast/js/regress/switch-constant.html: Added.
  • fast/js/regress/switch-expected.txt: Added.
  • fast/js/regress/switch.html: Added.
8:26 AM Changeset in webkit [151643] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebCore

[Mac] Remove unmaintained GStreamer specific video code.
https://bugs.webkit.org/show_bug.cgi?id=117694

Reviewed by Philippe Normand.

No new tests, no behaviour change.

  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setupVideoOverlay:]):
(-[WebVideoFullscreenController windowDidLoad]):
(-[WebVideoFullscreenController setMediaElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):

7:35 AM Changeset in webkit [151642] by michael.bruning@digia.com
  • 35 edits
    6 deletes in trunk

[Qt] Remove Qt specific QTKIT flagged code.
https://bugs.webkit.org/show_bug.cgi?id=117635

Reviewed by Simon Hausmann.

Due to disabling QTKIT for Qt in r151546, the
code the flags that are not taken into account
anymore and the code that has been rendered
unreachable by this are removed.

.:

  • Source/widgetsapi.pri:

Source/WebCore:

No new tests, no behavioural change.

  • Target.pri:
  • WebCore.exp.in:
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/KURL.h:
  • platform/SharedBuffer.h:
  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::fileSystemPath):

  • platform/cf/SharedBufferCF.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines):

  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::paint):
(-[WebCoreMovieObserver layerHostChanged:]):

  • platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]):
(WebCore::SharedBuffer::createWithContentsOfFile):

Source/WebKit:

  • WebKit1.pro:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):

  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/QTKitFullScreenVideoHandler.h: Removed.
  • WebCoreSupport/QTKitFullScreenVideoHandler.mm: Removed.
  • WebCoreSupport/WebSystemInterface.h: Removed.
  • WebCoreSupport/WebSystemInterface.mm: Removed.

Source/WebKit2:

  • Target.pri:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Removed.
  • WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Removed.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

7:32 AM Changeset in webkit [151641] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Remove invalid checks from block-cursor-overtype-mode.html
https://bugs.webkit.org/show_bug.cgi?id=117587

Reviewed by Darin Adler.

The test uses an array of ">" "<" symbols to perform comparisons
between consecutive positions of the block cursor. Since those
checks are done for each pair of consecutive characters the total
amount of checks is lengthOfTheWord - 1. We were adding an extra
symbol that was not used at all in the test.

  • editing/selection/block-cursor-overtype-mode.html:
6:57 AM Changeset in webkit [151640] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

REGRESSSION(r151632) : Build error on ASSERT(WTF_USE_GRAMMAR_CHECKING)
https://bugs.webkit.org/show_bug.cgi?id=117692

Reviewed by Jocelyn Turcotte.

Ifdef the feature-depending code and fix the assertions to check runtime conditions.

  • editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::markBadGrammar):

  • editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::markAllBadGrammar):
(WebCore::checkTextOfParagraph):

  • editing/TextCheckingHelper.h:
6:43 AM Changeset in webkit [151639] by kangil.han@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add my email to a DOM watchlist.

  • Scripts/webkitpy/common/config/watchlist:
6:32 AM Changeset in webkit [151638] by g.czajkowski@samsung.com
  • 19 edits in trunk/Source

Unreviewed, rolling out r151632.
http://trac.webkit.org/changeset/151632
https://bugs.webkit.org/show_bug.cgi?id=117585

Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC
platforms

Source/WebCore:

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action):

Source/WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusReceivedFromOldClients):

Source/WebKit2:

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • UIProcess/API/efl/ewk_context_menu_item.cpp:

(getEwkActionFromWKTag):

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(onContextMenuShow):
(TEST_F):

  • UIProcess/API/gtk/WebKitContextMenuActions.cpp:

(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):

Source/WTF:

  • wtf/Platform.h:
5:24 AM Changeset in webkit [151637] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Remove non existent files from compilation

and add a missing header file.

2:44 AM Changeset in webkit [151636] by zarvai@inf.u-szeged.hu
  • 1 edit
    2 moves in trunk/LayoutTests

[Qt] Unreviewed gardening. Correcting rebaselining after r151634.

  • platform/qt-5.0-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt.
  • platform/qt-5.0-wk2/compositing/repaint/positioned-movement-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt.
1:39 AM Changeset in webkit [151635] by Carlos Garcia Campos
  • 3 edits in trunk

Unreviewed. Rename gobject_introspection_required variable.

As gobject_introspection_required_version for consistency with all
other required_version variables.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/Versions.m4:
1:17 AM Changeset in webkit [151634] by zarvai@inf.u-szeged.hu
  • 1 edit
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining repaint tests, see bug 115372.

  • platform/qt-5.0-wk2/fast/repaint/change-overflow-and-display-of-relative-expected.txt: Rebaselining after r151549.
  • platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt: Rebaselining after r151624.
  • platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt: Rebaselining after r151622.
12:43 AM Changeset in webkit [151633] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skip three WebKit2APITests suites that are currently timing out.

12:28 AM Changeset in webkit [151632] by g.czajkowski@samsung.com
  • 19 edits in trunk/Source

Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off
https://bugs.webkit.org/show_bug.cgi?id=117585

Reviewed by Anders Carlsson.

Source/WebCore:

Do not add "Check Grammar With Spelling" and "Ignore Grammar" to the context menu
when GRAMMAR_CHECKING is off.
Replace "Spelling and Grammar" with "Spelling" as the sub menu title and "Show/Hide Spelling
and Grammar" with "Show/Hide Spelling" when GRAMMAR_CHECKING is off.

Additionally, guard grammar checking in context menu code to not necessarily
compile it.

No new layout tests because every port has a different way of showing
spelling/grammar context menu items.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

Source/WebKit/gtk:

Add GRAMMAR_CHECKING guard to the context menu grammar items.

  • webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action):

Source/WebKit/mac:

Add GRAMMAR_CHECKING guard to the context menu grammar items.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusReceivedFromOldClients):

Source/WebKit2:

Add GRAMMAR_CHECKING guard to the context menu grammar items.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • UIProcess/API/efl/ewk_context_menu_item.cpp:

(getEwkActionFromWKTag):

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(checkSpellingItemsAvailability):
Change callback name, to be consistent with a newly added.

(checkSpellingAndGrammarSubmenuAvailability):
(checkGrammarWithSpellingItemAvailability):
Add two unit tests for EFL to check whether context menu grammar items are
available only when GRAMMAR_CHECKING macro is enabled.

  • UIProcess/API/gtk/WebKitContextMenuActions.cpp:

(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):

Source/WTF:

Enable GRAMMAR_CHECKING for WebKit ports that use/implement it.

  • wtf/Platform.h:
12:23 AM Changeset in webkit [151631] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk-wk1/TestExpectations: Add a crashing expectation for a test that most likely regressed with r151021.
  • platform/gtk/TestExpectations: Add failure expectations for a couple of tests failing due to stack size misbehavior.

Jun 16, 2013:

11:53 PM Changeset in webkit [151630] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[CSS Blending] Update the background-blend-mode-image-color-dynamic test to use the repaint test logic

Updating testcase verifying if background blend modes are updated dynamically from script. This now
properly uses the repaint test mechanism. Also, the background image resource is addded.

https://bugs.webkit.org/show_bug.cgi?id=117686

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-16
Reviewed by Dean Jackson.

  • fast/repaint/background-blend-mode-image-color-dynamic-expected.html:
  • fast/repaint/background-blend-mode-image-color-dynamic.html:
  • fast/repaint/resources/ducky.png: Added.
11:28 PM WebKitIDL edited by Christophe Dumez
Fix several index links (diff)
9:23 PM Changeset in webkit [151629] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix test assertion after r151624

An assertion was hit in RenderObject::willBeDestroyed()
for fast/css/getComputedStyle/getComputedStyle-background-shorthand.html
because the code asserted that the RenderObject had been removed from
the FrameView's slowRepaintObject set before remove() was called,
so move the assertion to after that call.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

8:56 PM Changeset in webkit [151628] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()
https://bugs.webkit.org/show_bug.cgi?id=117685

Reviewed by Andreas Kling.

From Blink r152490 by <vivek.vg@samsung.com>

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect): Avoid hostWindow() twice call.

7:25 PM Changeset in webkit [151627] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

Fix two assertion failures in Range::insertNode
https://bugs.webkit.org/show_bug.cgi?id=116511

Reviewed by Ryosuke Niwa.

Source/WebCore:

ASSERTION FAILED: childBefore == (offset ? container->childNode(offset - 1) : 0)
third_party/WebKit/Source/WebCore/dom/RangeBoundaryPoint.h(115) : void WebCore::RangeBoundaryPoint::set(PassRefPtr<WebCore::Node>, int, WebCore::Node *)

ASSERTION FAILED: child->parentNode()
../../third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h(133) : void WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node *)

1 0x87594b2 WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node*)
2 0x87534a9 WebCore::Range::insertNode(WTF::PassRefPtr<WebCore::Node>, int&)

Range::insertNode calls Node::insertBefore, in which an event handler
can update the DOM structure so that RangeBoundaryPoint don't like. We
postpone event dispatching by EventQueueScope.

Also, remove old comments about Acid3. The behavior is standardized.
(Step 9 of http://dom.spec.whatwg.org/#dom-range-insertnode)

This patch imports http://src.chromium.org/viewvc/blink?view=revision&revision=150470 .

Test: fast/dom/Range/range-insertNode-assertion.html

  • dom/Range.cpp:

(WebCore::Range::insertNode):

  • Add EventQueueScope
  • Remove obsolete comments

LayoutTests:

We need to update fast/dom/insertBefore-refChild-crash.html because the
test caused recursive calls to the event handler. container.innerHTML=
did nothing before this CL. Now container has the newChild because
DOMNodeRemoved event dispatching is delayed until Range::insertNode
completion.

We need to update fast/text/split-text-crash.xhtml so that it doesn't
stop when the event handler is called twice. I'm not sure why the test
worked before this CL.

  • fast/dom/Range/range-insertNode-assertion-expected.txt: Added.
  • fast/dom/Range/range-insertNode-assertion.html: Added.
  • fast/dom/insertBefore-refChild-crash.html:
  • fast/text/split-text-crash.xhtml:
6:58 PM Changeset in webkit [151626] by gyuyoung.kim@samsung.com
  • 2 edits
    10 adds in trunk/LayoutTests

Unreviewed. Added new baselines for some of editing/style tests, which works on EFL port.

  • platform/efl/TestExpectations:
  • platform/efl/editing/style/5017613-1-expected.png: Added.
  • platform/efl/editing/style/5017613-1-expected.txt: Added.
  • platform/efl/editing/style/5046875-1-expected.png: Added.
  • platform/efl/editing/style/5046875-1-expected.txt: Added.
  • platform/efl/editing/style/5065910-expected.png: Added.
  • platform/efl/editing/style/5065910-expected.txt: Added.
  • platform/efl/editing/style/5228141-expected.png: Added.
  • platform/efl/editing/style/5228141-expected.txt: Added.
  • platform/efl/editing/style/5279521-expected.png: Added.
  • platform/efl/editing/style/5279521-expected.txt: Added.
6:13 PM Changeset in webkit [151625] by gyuyoung.kim@samsung.com
  • 2 edits
    18 adds in trunk/LayoutTests

Unreviewed. Added new baselines for some of editing/selection tests as r151533 on EFL port.

  • platform/efl/TestExpectations:
4:32 PM Changeset in webkit [151624] by Simon Fraser
  • 5 edits
    2 adds in trunk

Fixed backgrounds in composited layers not repainted on scrolling
https://bugs.webkit.org/show_bug.cgi?id=117684

Source/WebCore:

Reviewed by Tim Horton.

FrameView is aware that "slow-repaint objects" (i.e. renderers with
background-attachment:fixed) require a slow-scrolling path. However,
it was ignorant of the fact that such objects could be painting into
compositing layers; it simply dirtied the main tiles, and nothing else.

Fix by having FrameView track the slow-repaints objects explicitly, as we
do for position:fixed, and repaint each of them on scrolling.

Test: compositing/repaint/fixed-background-scroll.html

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView): No need to initialize m_slowRepaintObjectCount,
which is now an OwnPtr<RenderObjectSet>.
(WebCore::FrameView::useSlowRepaints): Use hasSlowRepaintObjects() now.
(WebCore::FrameView::addSlowRepaintObject): Now adds the object to a set,
allocating the set if necessary.
(WebCore::FrameView::removeSlowRepaintObject): Remove the object from the set,
and deallocate the set if empty.
(WebCore::FrameView::scrollContentsSlowPath): Call repaintSlowRepaintObjects();
this is the change that fixes the bug for always-composited implementations (e.g.
tile cache). This is a conservative change; we still invalidate the tile cache
as well. This could be optimized later.
(WebCore::FrameView::repaintSlowRepaintObjects): Repaint each object in the set.
Their appropriate compositing ancestor will be repainted.
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget): Call
repaintSlowRepaintObjects() so that fixed backgrounds in composited layers are
correctly repainted; this fixes the bug for WebKit1.

  • page/FrameView.h: Replace m_slowRepaintObjectCount with a HashSet of

RenderObjects.
(WebCore::FrameView::hasSlowRepaintObject): Takes a RenderObject* now.
(WebCore::FrameView::hasSlowRepaintObjects): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange): Pass the RenderObject.
(WebCore::RenderObject::willBeDestroyed): Assert that this RenderObject
has been removed from FrameView's set of slow-repaint objects already, if
the document is not being destroyed.
(WebCore::RenderObject::willBeRemovedFromTree): Pass the RenderObject.

LayoutTests:

Reviewed by Tim Horton.

Test that verifies that a composited layer with a fixed background is repainted
on scrolling.

  • compositing/repaint/fixed-background-scroll-expected.txt: Added.
  • compositing/repaint/fixed-background-scroll.html: Added.
10:24 AM Changeset in webkit [151623] by Simon Fraser
  • 8 edits
    5 adds in trunk

Source/WebCore: Painting of fixed background images is wrong in composited layers
https://bugs.webkit.org/show_bug.cgi?id=65793

Reviewed by Sam Weinig.

The code that computed background image geometry for background-attachment:fixed
images was unaware of compositing, so often painting the image at the wrong location.

Fix by having RenderBoxModelObject::calculateBackgroundImageGeometry() do the correct
math for fixed backgrounds in composited layer by offsetting the viewport rect by
the paint container's absolute position.

Tests: compositing/backgrounds/fixed-background-on-descendant.html

compositing/backgrounds/fixed-backgrounds.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::getBackgroundPaintedExtent): Now returns a bool indicating
whether it is returning a reliable extent rect. It can return false in the case where
a background is fixed, since computing the correct extent would require finding
the appropriate composited ancestor to pass to calculateBackgroundImageGeometry().
This is OK since this function is used for "background opaque" optimizations.
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
returns false, return false.
(WebCore::RenderBox::maskClipRect): We removed mask-attachment, so we never need to
compute the composited ancestor here and can pass null.
(WebCore::RenderBox::repaintLayerRectsForImage): Unwrap a comment.
If the changed image is related to a fixed background, geometry.hasNonLocalGeometry()
will be true. In that cause, just repaint the entire renderer rather than groveling
around for a composited ancestor.

  • rendering/RenderBox.h: Changed name and signature of backgroundPaintedExtent.
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): calculateBackgroundImageGeometry()
now needs to know the painting container.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Now takes a painting
container, that is required to correctly compute the viewport-relative offset for fixed
backgrounds. geometry.setHasNonLocalGeometry() is set for fixed backgrounds to indicate
to callers that, if they didn't pass a paint container, the destRect is not accurate.
The main bug fix is also here: we move the viewportRect by the absolute location of
paint container, which is equivalent to the composited layer offset.
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage): calculateBackgroundImageGeometry()
takes a paint container.

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::BackgroundImageGeometry::BackgroundImageGeometry):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setHasNonLocalGeometry):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::hasNonLocalGeometry):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
can't cheaply give an accurate answer, return false.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage): Pass the paint container,
which is our own renderer.

LayoutTests: Fixed background images behave strangely with webkit transitions
https://bugs.webkit.org/show_bug.cgi?id=65793

Reviewed by Sam Weinig.

Ref tests that compare fixed background rendering after a scroll, with and
without compositing, with a couple of layer configurations.

  • compositing/backgrounds/fixed-background-on-descendant-expected.html: Added.
  • compositing/backgrounds/fixed-background-on-descendant.html: Added.
  • compositing/backgrounds/fixed-backgrounds-expected.html: Added.
  • compositing/backgrounds/fixed-backgrounds.html: Added.
9:57 AM Changeset in webkit [151622] by Simon Fraser
  • 7 edits
    2 adds in trunk

webkit-backface-visibility on a parent element stops background-position from updating
https://bugs.webkit.org/show_bug.cgi?id=116319

Source/WebCore:

Reviewed by Darin Adler.

The optimization added in r102952 was incorrect in the case where a style change
resulted in a positioned-movement-only layout but also required a repaint; it assumed
that a composited layer did not need to be repainted for a a positioned-movement-only layout.

Fix by making RenderObject::setNeedsLayoutForPositionedMovement() check whether the
style change requires a repaint, and calling setLayerNeedsFullRepaint() in that situation.

Test: compositing/repaint/positioned-movement.html

  • rendering/RenderLayer.h: RepaintStatus values do not need to be bit flags.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle): Pass the old style to setNeedsPositionedMovementLayout().
(WebCore::RenderObject::styleDidChange): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setNeedsPositionedMovementLayout): Now takes a const RenderStyle*.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Remove a comment now that this bug is fixed.
(WebCore::RenderStyle::diffRequiresRepaint): Public wrapper for changeRequiresRepaint().
That function never uses contextSensitiveProperties so we can safely ignore them.

  • rendering/style/RenderStyle.h: Expose a way to call changeRequiresRepaint().

LayoutTests:

Reviewed by Darin Adler.

Test that does a positioned-movement-only layout and dumps a layer tree with
repaint rects.

  • compositing/repaint/positioned-movement-expected.txt: Added.
  • compositing/repaint/positioned-movement.html: Added.
8:06 AM Changeset in webkit [151621] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix iOS after last Pasteboard change.

  • platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::writeSelection): Put the new code inline here because the stringSelectionForPasteboard function is currently Mac-only.

Jun 15, 2013:

7:21 PM Changeset in webkit [151620] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Move Pasteboard::getStringSelection to Editor, fixing a layering violation
https://bugs.webkit.org/show_bug.cgi?id=117673

Reviewed by Ryosuke Niwa.

  • editing/Editor.h: Added stringSelectionForPasteboardWithImageAltText.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::stringSelectionForPasteboard): Moved code here from the Pasteboard
class, since all the Pasteboard class did really was turn around and call back here.
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText): Added. Variant of
the function above that includes image alt text. Separate named functions are often
the best pattern for something like this unless there are many different combinations.

  • platform/Pasteboard.h: Remove the Mac-only Pasteboard::getStringSelectioon.
  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writeSelection):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelectionForTypes):
Call the two new functions instead of the old Pasteboard::getStringSelection.

7:15 PM Changeset in webkit [151619] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Support using clang instead of gcc for bindings preprocessing
https://bugs.webkit.org/show_bug.cgi?id=117674

Reviewed by Sam Weinig.

I couldn't build on my computer because I don't have gcc installed.
This is my cut at fixing it.

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces): Use clang if present.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): Ditto.

6:49 PM Changeset in webkit [151618] by fpizlo@apple.com
  • 8 edits in branches/dfgFourthTier/Source

Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy
https://bugs.webkit.org/show_bug.cgi?id=117676

Reviewed by Sam Weinig.

Source/JavaScriptCore:

CodeBlock now caches m_hash, and the DFG Driver will force its computation if we're doing debug dumps of any kind.

Also made sure that CodeBlock::CodeBlock initializes all of its fields; it was previously missing the
initialization of m_capabilityLevelState.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hash):
(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):

  • bytecode/CodeBlockHash.h:

(CodeBlockHash):
(JSC::CodeBlockHash::isSet):
(JSC::CodeBlockHash::operator!):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

Source/WebCore:

Remove the broken hack for the concurrent JIT, since now the concurrent JIT won't use this code anymore.

No new tests because no new behavior.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

3:56 PM Changeset in webkit [151617] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in supportsSnapshotting
https://bugs.webkit.org/show_bug.cgi?id=117670
<rdar://problem/14059711>

Reviewed by Darin Adler.

Speculative fix for deferencing a null RefPtr in supportsSnapshotting.
It seems like it was possible to get in a state where the plugin machinery
would fire up and attempt to get a screenshot before there was an active
connection to the plugin process (usually under periods of high load, such
as opening a lot of tabs at once). In this case we're now returning false
from supportsSnapshotting, which will trigger the plugin to restart, but
that's better than requesting a snapshot on something that doesn't yet exist.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::supportsSnapshotting): Guard for an empty connection object.

3:37 PM Changeset in webkit [151616] by fpizlo@apple.com
  • 26 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should support op_switch_imm
https://bugs.webkit.org/show_bug.cgi?id=117559

Reviewed by Oliver Hunt.

Implement integer (i.e. immediate) switches in the DFG. Reduce the minimum
threshold for using op_switch.

Also get rid of edge code support, since we haven't used it in the year since
I introduced it. It was supposed to allow us to break critical edges late in
the backend, thus enabling global register allocation from an SSA-form graph.
But we aren't doing that so I figure we should just kill the code for now. It
would have made implementing switch harder.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::timesPtr):

  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::dumpWithName):
(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::dump):
(MacroAssemblerCodeRef):
(JSC::MacroAssemblerCodeRef::dump):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

  • bytecode/JumpTable.h:

(SimpleJumpTable):
(JSC::SimpleJumpTable::clear):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JITCompiler):
(JSC::DFG::JITCompiler::blockHeads):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::SwitchCase::SwitchCase):
(SwitchCase):
(SwitchData):
(JSC::DFG::SwitchData::SwitchData):
(Node):
(JSC::DFG::Node::isSwitch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::switchData):
(JSC::DFG::Node::numSuccessors):
(JSC::DFG::Node::successor):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::emitSwitchImmIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitch):
(JSC::DFG::SpeculativeJIT::linkBranches):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branch64):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • parser/Nodes.h:

(CaseBlockNode):

3:29 PM Changeset in webkit [151615] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/WTF

Printing a StringImpl* should really guard against NULL
https://bugs.webkit.org/show_bug.cgi?id=117675

Reviewed by Mark Hahnenberg.

  • wtf/PrintStream.cpp:

(WTF::printInternal):

8:44 AM Changeset in webkit [151614] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Reorder my email addresses.
https://bugs.webkit.org/show_bug.cgi?id=100122

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-06-15

  • Scripts/webkitpy/common/config/contributors.json:

Jun 14, 2013:

11:59 PM Changeset in webkit [151613] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r148367): Facebook and Twitter icons at macworld.com are stacked vertically, obscuring Twitter one
https://bugs.webkit.org/show_bug.cgi?id=117284

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/text/whitespace/inline-whitespace-wrapping-7.html

We were looking for line breaks in trailing collapsed whitespace even when inside a nowrap inline.
It's wrong to do this as we don't know yet if we will want or need to break - that decision has to
be deferred until we enter a part of the line that is autowrap.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/inline-whitespace-wrapping-7-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-7.html: Added.
9:42 PM Changeset in webkit [151612] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

background-color is not preserved when inserting a new paragraph
https://bugs.webkit.org/show_bug.cgi?id=117138

Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-06-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

The style isn't copied because background-color isn't defined as inheritable property.

Test: editing/inserting/insert-paragraph-not-preserving-background-color.html

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
Passing EditingPropertiesInEffect instead of implicit parameter OnlyEditingInheritableProperties.

LayoutTests:

Adding layout test and expected result to reproduce the issue.

  • editing/inserting/insert-paragraph-with-font-and-background-color-expected.txt: Added.
  • editing/inserting/insert-paragraph-with-font-and-background-color.html: Added.
4:05 PM Changeset in webkit [151611] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

Threaded HTML parser can ASSERT in some situations
https://bugs.webkit.org/show_bug.cgi?id=117662

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch merges https://chromium.googlesource.com/chromium/blink/+/3c0a112b42d72c7623f78463166dd7f04d680b4c

--->8---
The parser is supposed to stop processing data when there's a pending
location change, but before this CL we would actually process the first
token from every chunk when there was a pending location change.

If the first token in a chunk was a "script" start tag, that would put
the tree builder into TextMode, which can only process character
tokens. If the next chunk starts with another start tag token, the tree
builder would be sad and hit an ASSERT.

This CL reorders a couple lines in HTMLDocumentParser so that we check
for pending location changes before processing any tokens. This change
stops us from processing the first token from each chunk while there is
a pending location change.

This issue can reproduce on any platform, but it reproduced often on
Android because mobile markup often elides spaces between consecutive
script tags. If there are space characters between the script tags,
then those space characters will be the first ones processes in the
chunk, which doesn't trigger the ASSERT.
---8<---

Since we landed this patch in Blink, we've been able to reproduce this
issue on desktops as well. I spoke with rniwa in #webkit and he said
that WebKit doesn't have any current plans to enable the threaded
parser but that it was probably worth merging this patch anyway.

Test: http/tests/navigation/pending-location-change-assert.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

LayoutTests:

  • http/tests/navigation/pending-location-change-assert-expected.txt: Added.
  • http/tests/navigation/pending-location-change-assert.html: Added.
  • http/tests/resources/slow-notify-done.php: Added.
3:49 PM Changeset in webkit [151610] by Patrick Gansterer
  • 17 edits in trunk

Introduce USE(WINGDI) for the Windows port
https://bugs.webkit.org/show_bug.cgi?id=116138

Reviewed by Ryosuke Niwa.

Using USE(WINGDI) instead of OS(WINCE) will allow us to
compile the GDI based Windows port on WinNT too.

.:

  • Source/cmake/OptionsWinCE.cmake:

Source/WebCore:

  • config.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GlyphBuffer.h:

(WebCore):
(GlyphBuffer):

  • platform/graphics/Gradient.h:

(Gradient):

  • platform/graphics/GraphicsContext.cpp:

(WebCore):

  • platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

  • platform/graphics/ImageBufferData.h:
  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::snapshot):

Source/WTF:

  • wtf/Platform.h:
3:40 PM Changeset in webkit [151609] by jer.noble@apple.com
  • 10 edits in trunk/Source/WebCore

Report the memory cost of HTMLMediaElements to GC.
https://bugs.webkit.org/show_bug.cgi?id=117608

Reviewed by Darin Adler.

Report the extra memory cost of a HTMLMediaElement to the VM, in order to
encourage GC to occur after a media element is removed from the DOM.

Because we cannot know for sure the memory cost of our underlying media
framework objects, use the worst case scenario for the media memory cost:
the buffered percentage of movie * the total data length of the movie.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_reportedExtraMemoryCost.
(WebCore::HTMLMediaElement::removedFrom): Report the extra memory cost.

  • html/HTMLMediaElement.h:
  • html/TimeRanges.cpp:

(TimeRanges::totalDuration): Added convenience function.

  • html/TimeRanges.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::extraMemoryCost): Pass to MediaPlayerPrivate.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::extraMemoryCost): Default to 0.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): Return the percentage

loaded * total data length.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3:27 PM Changeset in webkit [151608] by jer.noble@apple.com
  • 5 edits in trunk/Source

Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
https://bugs.webkit.org/show_bug.cgi?id=117597

Reviewed by Eric Carlson.

Source/WebCore:

Check for media elements with AVFoundation media types and create a AVPlayerLayer
rather than a QTMovieLayer.

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setupVideoOverlay:]): Take a CALayer rather than a

QTMovieLayer. Move the code which connects the layer with it's media source into
setMediaElement.

(-[WebVideoFullscreenController windowDidLoad]): Give the window's contentView a generic

CALayer instaead of a QTMovieLayer.

(-[WebVideoFullscreenController setMediaElement:]): Test whether the incoming media

element is backed by a QTMovie or an AVPlayer, and create the appropriate layer.

(-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the observer of

AVPlayer's rate property.

(-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):

If the keyPath is "rate", call rateChanged.

Source/WebKit/mac:

Allow AVFoundation to be enabled even when the FullScreen API is disabled.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

3:21 PM Changeset in webkit [151607] by enrica@apple.com
  • 8 edits
    1 add in trunk

WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
https://bugs.webkit.org/show_bug.cgi?id=117647
<rdar://problem/13881024>

Source/WebCore:

Reviewed by Darin Adler.

The API returns the matched ranges in the DOM order regardless of the
find direction, but the index of the first match after the user selection
should take the find direction into account.

Extended existing test in TestWebKitAPI.

  • page/Page.cpp:

(WebCore::Page::findStringMatchingRanges): Added handling of the Backwards case.

  • page/Page.h: Fixed incorrect name of the enum.

Source/WebKit2:

Reviewed by Darin Adler.

The API returns the matched ranges in the DOM order regardless of the
find direction, but the index of the first match after the user selection
should take the find direction into account.

Extended existing test in TestWebKitAPI.

  • Shared/API/c/WKFindOptions.h: Added enum for the case where there are

no matches after the user selection in the direction of the find.

Tools:

Reviewed by Darin Adler.

The test now uses content with a selection and tests both
forwards and backward find as well as the case of a find
that has no matches after the user selection.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/FindMatches.mm:

(TestWebKitAPI::didFindStringMatches):

  • TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
2:55 PM Changeset in webkit [151606] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r150651): Web Audio doesn't work at all (silence or squawks) on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=117652

Reviewed by Eric Carlson.

r150651 disabled setting the buffer size to a large value, but in so doing, also
disabled setting the buffer size to a small value for Web Audio. Narrow the Mountain
Lion protection to just the <video> element case.

  • platform/audio/mac/AudioSessionManagerMac.cpp:

(AudioSessionManager::updateSessionState):

1:36 PM Changeset in webkit [151605] by rniwa@webkit.org
  • 9 edits in trunk/Source

Function names on Object.prototype should be common identifiers
https://bugs.webkit.org/show_bug.cgi?id=117614

Reviewed by Darin Adler.

Source/JavaScriptCore:

Patch written by Sam Weinig. Make Object's prototype function names common identififers since they're used frequently.

  • runtime/CommonIdentifiers.h:
  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

Source/WebCore:

Use the added common identifiers.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::updateDocument):

1:13 PM Changeset in webkit [151604] by a.bah@samsung.com
  • 3 edits
    2 adds in trunk

Editing: wrong text position when you click enter on the text behind the image
https://bugs.webkit.org/show_bug.cgi?id=115023

Reviewed by Ryosuke Niwa.

Source/WebCore:

When trying to break a line after an image followed by some text, contrary
to the expected behavior the text doesn't move to a new line, instead, the
caret position just shifts to the end of line.

As per the existing implementation for inserting a paragraph separator,
the insertion position obtained corresponds to the point after the image
element.
Since the insertion position doesn't resolve to being offset in the
following text node (0 offset), no splitting of text occurs and the block
to be inserted is placed after the containing (start) block (thereby
causing the caret position to shift).

If the computed insertionPosition points to an element that shall be
ignored for editing purposes (i.e. cannot have a VisiblePosition inside
it), and the position lies either at the start or at the end of such
an element, we should move our Position either upstream or
downstream (respectively) so as to obtain a valid position which can
be used further for splitting of the text.

Test: editing/inserting/insert-paragraph-after-non-editable-node-before-text.html

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):
Moving the insertionPosition either upstream or downstream, if the point
lies either at the start or at the end of the anchor node.
The ensuing position, if a text node, can then be used for splitting of
the text correctly.

LayoutTests:

  • editing/inserting/insert-paragraph-after-non-editable-node-before-text-expected.txt: Added.
  • editing/inserting/insert-paragraph-after-non-ediatble-node-before-text.html: Added.

Layout test added for verifying the insert paragraph behavior between an inline node
which is ignored for editing purposes and some text.

1:02 PM Changeset in webkit [151603] by commit-queue@webkit.org
  • 7 edits
    4 deletes in trunk/Source

[BlackBerry] Remove implementation of ContextMenu classes
https://bugs.webkit.org/show_bug.cgi?id=114860

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-14
Reviewed by Rob Buis.

This code is not being used so we can safely remove it.

Source/WebCore:

  • PlatformBlackBerry.cmake:
  • platform/blackberry/ContextMenuBlackBerry.cpp: Removed.
  • platform/blackberry/ContextMenuItemBlackBerry.cpp: Removed.
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
  • WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
12:37 PM Changeset in webkit [151602] by timothy@apple.com
  • 3 edits in trunk/Websites/webkit.org

Shrink larger images to fit the width of the blog.

  • blog-files/new-inspector/hero-labeled.png:
  • blog-files/new-inspector/hero.png:
12:34 PM Changeset in webkit [151601] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

[Windows] Provide simple <meter> drawing logic for testing.
https://bugs.webkit.org/show_bug.cgi?id=117645.

Reviewed by Anders Carlsson.

accessbility/meter-element.html

  • rendering/RenderThemeSafari.cpp: Simple test implementation

(WebCore::RenderThemeSafari::adjustMeterStyle): Added.
(WebCore::RenderThemeSafari::supportsMeter): Added.
(WebCore::RenderThemeSafari::meterSizeForBounds): Added.
(WebCore::RenderThemeSafari::paintMeter): Added.

  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::progressBarTheme): Added.
(WebCore::RenderThemeWin::getClassicThemeData): Support meters.
(WebCore::RenderThemeWin::getThemeData): Support meter theme.
(WebCore::RenderThemeWin::adjustMeterStyle): Added.
(WebCore::RenderThemeWin::supportsMeter): Added.
(WebCore::RenderThemeWin::meterSizeForBounds): Added.
(WebCore::RenderThemeWin::paintMeter): Added.

  • rendering/RenderThemeWin.h:
10:18 AM Changeset in webkit [151600] by eric.carlson@apple.com
  • 4 edits
    2 adds in trunk

Potential use-after-free with an event fired at a HTMLMediaElement which is currently being deleted
https://bugs.webkit.org/show_bug.cgi?id=117466

Reviewed by Oliver Hunt.

Merge https://chromium.googlesource.com/chromium/blink/+/f4200a0093b3d9376f703961615359ec7fb712b4

If an event is created using as target an HTMLMediaElement which is
currently being deleted it becomes a heap-use-after free situation.

The GenericEventQueue instance is already owned by the HTMLMediaElement,
and there already is an underlying mechanism to set the target of the
event to NULL, if their target is owner of the queue.

In order to avoid creating this reference in the first place, we enqueue
the event with a NULL target to defer the refcount increment until the
timer for dispatching the event happens (which won't happen at all if
garbage collection is already destroying the objects).

Source/WebCore:

Test: media/track/media-element-enqueue-event-crash.html

  • dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::enqueueEvent): Don't ASSERT if the event has no target.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Close the event queue so it won't try to

dispatch any pending events.

(WebCore::HTMLMediaElement::scheduleEvent): Don't set the event target, it will happen just

prior to event dispatch.

(WebCore::HTMLMediaElement::stop): Close the event queue.

LayoutTests:

  • media/track/media-element-enqueue-event-crash-expected.txt: Added.
  • media/track/media-element-enqueue-event-crash.html: Added.
10:09 AM Changeset in webkit [151599] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Clicking on snapshotting plug-ins does not restart them
https://bugs.webkit.org/show_bug.cgi?id=117620
<rdar://problem/13821729>

Follow-up review comments from Darin Adler, with some
discussion on IRC.

Sprinkle OVERRIDE on virtual functions where needed. Also
make sure that the Event is a MouseEvent before casting to it.

  • html/HTMLPlugInElement.h: Move defaultEventHandler back to protected and add OVERRIDE.
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler): Check for MouseEvent and
use toMouseEvent().

  • html/HTMLPlugInImageElement.h: Sprinkle some OVERRIDEs, and move defaultEventHandler

to private.

9:52 AM Changeset in webkit [151598] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Remove front-end from the WebCore Xcode project.
https://bugs.webkit.org/show_bug.cgi?id=117640

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
9:36 AM Changeset in webkit [151597] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSParser::parseImageSet() doesn't need a parameter.
https://bugs.webkit.org/show_bug.cgi?id=117617

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-06-14
Reviewed by Darin Adler.

parseImageSet() can get m_valueList directly.
And minor fixes.

No new tests, no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):

  • css/CSSParser.h:
9:25 AM Changeset in webkit [151596] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Dropdown button UX updates.
https://bugs.webkit.org/show_bug.cgi?id=117642.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-14
Reviewed by Rob Buis.

JIRA 388652
Internally Reviewed by Jeff Rogers.

Change arrow assert.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMenuList):

8:00 AM Changeset in webkit [151595] by anilsson@rim.com
  • 16 edits in trunk/Source

[BlackBerry] LayerTiler fails to tile really big layers
https://bugs.webkit.org/show_bug.cgi?id=117211

Reviewed by Carlos Garcia Campos.

PR 273550

Source/WebCore:

The cause for this bug was that LayerTiler computed which tiles are
visible by exhaustively mapping every tile to normalized device
coordinates and checking if it intersected the viewport. If there was a
lot of tiles, it would get stuck in this loop, iterating over all
tiles, for a very long time. Also, the visibility information was
transferred to the WebKit thread using mutexes, which added unnecessary
mutex contention to the mix.

Fixed by doing the reverse calculation, unprojecting the visible part
of the layer to layer coordinate space to find which tiles are visible.
Instead of doing a traditional unprojection of point to line and see
where the line intersects the layer, this patch uses the w-coordinates
of triangle vertices to perform "perspective correct texturing" of the
intersection points in device space, which is equivalent to
unprojection since perspective correct texturing computes a 2D
coordinate in (normalized) layer coordinate space which is easily
scaled up to the layer bounds and get the visible region expressed in
layer coordinate space.

The visible area is approximated by a rectangle, and a set of tiles
needing render are added to the mix, and we have a swappable data
structure so visbility can be transferred to WebKit thread without
mutexes, but instead using atomic swap.

No new tests, covered by existing tests.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:

(EGLImageLayerCompositingThreadClient):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

  • platform/graphics/blackberry/LayerCompositingThreadClient.h:

(WebCore):
(LayerCompositingThreadClient):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayersRecursive):

  • platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):

  • platform/graphics/blackberry/LayerTile.h:

(LayerTile):
(WebCore::LayerTile::contentsScale):
(WebCore::LayerTile::setContentsDirty):

  • platform/graphics/blackberry/LayerTiler.cpp:

(LayerVisibility):
(WebCore::LayerVisibility::LayerVisibility):
(WebCore::LayerVisibility::visibleRect):
(WebCore::LayerVisibility::setVisibleRect):
(WebCore::LayerVisibility::needsRender):
(WebCore::LayerVisibility::tileNeedsRender):
(WebCore::LayerVisibility::willRenderTile):
(WebCore::LayerVisibility::swapTilesNeedingRender):
(WebCore::LayerVisibility::merge):
(WebCore):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::swapFrontVisibility):
(WebCore::LayerTiler::setFrontVisibility):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::inflateViewport):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::rectForTile):

  • platform/graphics/blackberry/LayerTiler.h:

(WebCore):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::takeFrontVisibility):

  • platform/graphics/blackberry/LayerUtilities.h:

(WebCore):
(WebCore::det):
(WebCore::dot):
(LayerClipEdge):
(WebCore::LayerClipEdge::LayerClipEdge):
(WebCore::LayerClipEdge::isPointInside):
(WebCore::LayerClipEdge::computeIntersection):
(WebCore::intersectPolygonWithRect):
(WebCore::computeBarycentricCoordinates):
(WebCore::manhattanDistanceToViewport):
(UnprojectionVertex):
(WebCore::compareManhattanDistanceToViewport):
(WebCore::unproject):

Source/WebKit/blackberry:

Adapt to changes in LayerCompositingThreadClient interface.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):

  • Api/WebOverlay_p.h:

(WebOverlayLayerCompositingThreadClient):

7:53 AM Changeset in webkit [151594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Compilation problems - hb.h not found
https://bugs.webkit.org/show_bug.cgi?id=117636

Unreviewed GTK+ build fix.

Patch by Andres Gomez <Andres Gomez> on 2013-06-14

  • GNUmakefile.am: Added freetype cflags for WebKit2 GTK+ Platform

library.

7:50 AM Changeset in webkit [151593] by zarvai@inf.u-szeged.hu
  • 3 edits
    26 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Generate new baseline to some tests and bot greening.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-14

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/animations/3d/change-transform-in-end-event-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-percent-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-wide-border-05-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/forms/zoomed-controls-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
  • platform/qt/TestExpectations:
7:43 AM Changeset in webkit [151592] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

[Mac] clicking caption track glyph should dismiss menu
https://bugs.webkit.org/show_bug.cgi?id=117621

We now correctly capture all click events while the captions track menu
is showing, and ensure that no other control in the media player can be
activated as the track list gets dismissed by clicking anywhere but on
itself.

Reviewed by Eric Carlson.

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::showClosedCaptionTrackList):
Make the controls panel non-interactive and track click events in the
capture phase also on the controls container itself such that we can
identify correctly whether a click in the <video> shadow tree is on
the track list or another element (the target could only be resolved
to a shadow tree node if the event is handled within the shadow tree).

(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
Make the controls panel interactive again and remove the new click
event handler on the controls container.

(WebCore::MediaControlsApple::handleClickEvent):
Capture any click event that targets a node anywhere outside of the track
list container and its subtree and hide the track list in this condition.

(WebCore::MediaControlsAppleEventListener::handleEvent):
Call handleClickEvent() on the media controls when a click event is handled.

  • html/shadow/MediaControlsApple.h:

New public handleClickEvent() API such that it can be called from
MediaControlsAppleEventListener::handleEvent().

7:04 AM Changeset in webkit [151591] by anilsson@rim.com
  • 9 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Accelerated compositing layers that intersect the image plane are incorrectly transformed
https://bugs.webkit.org/show_bug.cgi?id=117067

Reviewed by Carlos Garcia Campos.

PR 273550

The BlackBerry port used to mathematically project each corner of each
layer bounds rectangle, which gives the wrong results when the layer
intersects the image plane.

For display lists, we still got the correct appearance of the layer
contents, since the display list results in geometry that's transformed
in the vertex shader, on the GPU.

However, the transformed bounds are used for drawing the debug border,
performing visibility calculations on the CPU and drawing of WebGL,
masks/reflections and filters. Using the mathematical projection of
points that lie behind the image plane gives the wrong results.

The most important consequence of this bug was that the wrong area of
the layer would be considered visible, so a tiled layer would not
populate the right tiles (or any tiles at all).

Fixed by implementing something along the lines of the recipe in
section 6.2 of http://www.w3.org/TR/css3-transforms.

No new tests, manually testable by enabling debug border on
https://developer.mozilla.org/en-US/demos/detail/the-box/launch.

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore):
(WebCore::LayerCompositingThread::textureCoordinates):
(WebCore::LayerCompositingThread::drawTextures):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WebCore::LayerCompositingThread::transformedBounds):
(WebCore::LayerCompositingThread::ws):
(WebCore::LayerCompositingThread::centerW):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::compareLayerW):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):

  • platform/graphics/blackberry/LayerRenderer.h:

(WebCore):
(LayerRenderer):

  • platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::boundingBox):
(WebCore::LayerRendererSurface::transformedBounds):

  • platform/graphics/blackberry/LayerRendererSurface.h:

(WebCore::LayerRendererSurface::setDrawTransform):
(WebCore::LayerRendererSurface::setReplicaDrawTransform):
(LayerRendererSurface):

  • platform/graphics/blackberry/LayerUtilities.h: Added.

(WebCore):
(LayerClipPlane):
(WebCore::LayerClipPlane::LayerClipPlane):
(WebCore::LayerClipPlane::isPointInside):
(WebCore::LayerClipPlane::computeIntersection):
(WebCore::intersect):
(WebCore::boundingBox):
(WebCore::multVecMatrix):
(WebCore::toVector):

5:53 AM Changeset in webkit [151590] by zarvai@inf.u-szeged.hu
  • 28 edits
    48 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Some more rebaselining after r151205 and r150798.

  • platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
  • platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-70-expected.png: Added.
  • platform/qt-5.0-wk2/css3/selectors3/xhtml/css3-modsel-131b-expected.png: Added.
  • platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png:
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/qt-5.0-wk2/fast/css/error-in-last-decl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/font-size-negative-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/namespaces/004-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/table-text-align-strict-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dom/34176-expected.png:
  • platform/qt-5.0-wk2/fast/dom/inner-text-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/qt-5.0-wk2/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png:
  • platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png:
  • platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/qt-5.0-wk2/fast/invalid/014-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/childFocusRingClip-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/hit-test-overflow-controls-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
  • platform/qt-5.0-wk2/fast/runin/generated-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/multiple-captions-display-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/remove-td-display-none-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/text-ctm-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug81934-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tables_bgcolor_red-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tfoot_align_left-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_align_right-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_class-expected.png: Added.
4:43 AM Changeset in webkit [151589] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed TestExpectation cleanup
https://bugs.webkit.org/show_bug.cgi?id=117626

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-14

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations:
4:34 AM Changeset in webkit [151588] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Map rewind and fast forward keys to match GoogleTV
https://bugs.webkit.org/show_bug.cgi?id=117634

Reviewed by Jocelyn Turcotte.

Set the same keycode for media keys rewind and fast-forward as
GoogleTV does.

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

4:26 AM Changeset in webkit [151587] by zandobersek@gmail.com
  • 2 edits in trunk/Source/Platform

Unreviewed GTK build fix.

  • GNUmakefile.am: Add the Freetype CFLAGS to the list of libPlatformGtk's CPPFLAGS. These are required as there are

specific build targets that end up including the HarfBuzz headers which are included in the Freetype CFLAGS variable.

3:59 AM Changeset in webkit [151586] by Carlos Garcia Campos
  • 24 edits in trunk/Source/WebCore

Avoid unnecessary data copies when loading subresources with DoNotBufferData option
https://bugs.webkit.org/show_bug.cgi?id=115804

Reviewed by Darin Adler.

When DoNotBufferData option is used to load a resource its data
is always copied before sending it to the CachedResource. Most
of the cached resources ignore the incremental data and wait
until all data has been received to save the ResourceBuffer,
that will be NULL anyway when DoNotBufferData is used.
CachedRawResource notifies its clients about the incremental
data, but it doesn't save the data when DoNotBufferData option
is present. In those cases we are unnecessary copying the data.

CachedResource::data has been split into
CachedResource::addDataBuffer() used for incremental data chunks
when buffering data, CachedResource::addData() used for
incremental data chunks when not buffering and
CachedResource::finishLoading() used to finish the loading. This
way we get rid of the allDataReceived boolean parameter and cached
resources not interested in incremenetal data chunks only have to
implement finishLoading() without having to check if all data have
been received or not.

SubresourceLoader::sendDataToResource was always called after
checking if loading multipart content, and then it was checked
again to decided whether to copy the data or not. It has been
removed in favor of calling directly the resource methods,
finishLoading for multipart content, addDataBuffer for data chunks
when buffering and addData for data chunks when not buffering.

No new functionality, covered by existing tests.

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes): Update to API changes.
(WebCore::ImageDocumentParser::finish): Ditto.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Call
finishLoading() for multipart content.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Add data to
the resource using addDataBuffer or addData depending on whether
we are buffering or not.
(WebCore::SubresourceLoader::didFinishLoading): Call
finishLoading() for the cached resource instead of data.

  • loader/SubresourceLoader.h:
  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::finishLoading):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::finishLoading):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isValidDecodedImageSize): Helper function
to check if the image size is valid.
(WebCore::CachedImage::addIncrementalDataBuffer): Helper function
to add incremental data buffer.
(WebCore::CachedImage::addDataBuffer): Call
addIncrementalDataBuffer().
(WebCore::CachedImage::addData): Create a ResourceBuffer and call
addIncrementalDataBuffer().
(WebCore::CachedImage::finishLoading):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::calculateIncrementalDataChunk):
Returns a pointer to the data corresponding to the current chunk
and its length.
(WebCore::CachedRawResource::addDataBuffer): Assert to make sure
this is only called when BufferData option is present. Use
calculateIncrementalDataChunk().
(WebCore::CachedRawResource::addData): Assert to make sure this is
only called when DoNotBufferData option is present.
(WebCore::CachedRawResource::finishLoading):
(WebCore::CachedRawResource::notifyClientsDataWasReceived): Helper
private function to notify the clients about data received.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addDataBuffer):
(WebCore::CachedResource::addData):
(WebCore::CachedResource::finishLoading):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::finishLoading):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::finishLoading):

  • loader/cache/CachedScript.h:
  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::finishLoading):

  • loader/cache/CachedShader.h:
  • loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::addDataBuffer):
(WebCore::CachedTextTrack::finishLoading):

  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::finishLoading):

  • loader/cache/CachedXSLStyleSheet.h:
3:03 AM Changeset in webkit [151585] by vestbo@webkit.org
  • 2 edits in trunk/Tools

Remove myself from Qt build system watchlist

1:26 AM Changeset in webkit [151584] by zarvai@inf.u-szeged.hu
  • 2 edits
    73 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r151205.

  • platform/qt-5.0-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-39-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/4960120-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/5057506-expected.png: Added.
  • platform/qt-5.0-wk2/fast/invalid/003-expected.png: Added.
  • platform/qt-5.0-wk2/fast/selectors/061-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/table-display-types-strict-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug727-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tables_border_1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png: Added.
1:20 AM Changeset in webkit [151583] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK][WK1] Missing symbols
https://bugs.webkit.org/show_bug.cgi?id=117629

Unreviewed GTK+ build fix.

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-06-14

  • Source/autotools/symbols.filter: Added missing symbols needed when

compiling WK1.

12:55 AM Changeset in webkit [151582] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build when DRAG_SUPPORT is set OFF
https://bugs.webkit.org/show_bug.cgi?id=117628

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-14
Reviewed by Gyuyoung Kim.

Add guard around Clipboard::declareAndWriteDragImage.

  • platform/efl/ClipboardEfl.cpp:
Note: See TracTimeline for information about the timeline view.