Timeline
Jun 20, 2013:
- 11:02 PM Changeset in webkit [151825] by
-
- 8 edits1 add in trunk/Source
[WK2] Looping for EINTR on close() is incorrect for Linux, at least
https://bugs.webkit.org/show_bug.cgi?id=117266
Patch by Sergio Correia <Sergio Correia> on 2013-06-20
Reviewed by Darin Adler.
Source/WebKit2:
Call closeWithRetry() to work around a difference in how the retry needs to
be done on Linux.
- Platform/CoreIPC/unix/AttachmentUnix.cpp:
(CoreIPC::Attachment::dispose):
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::createWebProcessConnection):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess): All these places had
close-followed-by-EINTR-handling replaced with the new closeWithRetry()
function added in this commit.
Source/WTF:
Added file UniStdExtras with a closeWithRetry() function that works around
the EINTR behavior on Linux during a close() call: it closes the descriptor
unconditionally even when the call is interrupted.
- wtf/UniStdExtras.h: Added.
(WTF::closeWithRetry): Wrapper around POSIX close() that handles EINTR
correctly.
- 9:21 PM Changeset in webkit [151824] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Structure should have a dump()
https://bugs.webkit.org/show_bug.cgi?id=117859
Reviewed by Geoffrey Garen.
This is pretty cool. Anywhere we previously printed Structure pointers in dumps,
we now print a bunch of other info as well. For example, for an object literal
like "{f:42, g:64, h:24}", when we print the structure we'll now get:
0x107a0af80:[Object, {f:0, g:1, h:2}, NonArray, Proto:0x107a8fff0]
This also changes a bunch of places to use the dump method.
- bytecode/StructureSet.h:
(JSC::StructureSet::dump):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dump):
- runtime/Structure.cpp:
(JSC::Structure::dump):
(JSC):
- runtime/Structure.h:
(Structure):
- 9:00 PM Changeset in webkit [151823] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r151808): fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=117862
Add a failing test expectation.
- platform/mac/TestExpectations:
- 8:52 PM Changeset in webkit [151822] by
-
- 4 edits2 adds in trunk
REGRESSION(r145788): mouse drag on canvas shouldn't start selection
https://bugs.webkit.org/show_bug.cgi?id=117860
Reviewed by Benjamin Poulain.
Source/WebCore:
Like HTMLImageElement, HTMLCanvasElement shouldn't start selection.
Also uninline some virtual function overrides.
Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::areAuthorShadowsAllowed):
(WebCore::HTMLCanvasElement::canContainRangeEndPoint):
(WebCore::HTMLCanvasElement::canStartSelection):
- html/HTMLCanvasElement.h:
LayoutTests:
Add a regression test for dragging mouse inside a canvas.
The canvas should not be selected and mouseup event should fire.
- fast/events/mosuedrag-on-canvas-should-not-start-selection-expected.txt: Added.
- fast/events/mosuedrag-on-canvas-should-not-start-selection.html: Added.
- 8:50 PM Changeset in webkit [151821] by
-
- 3 edits2 adds in trunk
REGRESSION(r149652): accessing items in .children via id doesn't work when element is not rooted in DOM tree
https://bugs.webkit.org/show_bug.cgi?id=117836
Reviewed by Benjamin Poulain.
Source/WebCore:
When the root node of a HTML collection is not in the document or in a shadow tree,
we shouldn't use its tree scope's id and name maps to find name getters.
Always use the slow path in such cases.
Test: fast/dom/htmlallcollection-detached-node-children.html
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItem):
LayoutTests:
Add a regression test for named getter for a detached element.
- fast/dom/htmlallcollection-detached-node-children-expected.txt: Added.
- fast/dom/htmlallcollection-detached-node-children.html: Added.
- 7:57 PM Changeset in webkit [151820] by
-
- 19 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: There should only be one table of SimpleJumpTables
https://bugs.webkit.org/show_bug.cgi?id=117856
Reviewed by Geoffrey Garen.
Having multiple tables of SimpleJumpTables just means we have to duplicate a
ton of code. This patch deduplicates all of it.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfSwitchJumpTables):
(JSC::CodeBlock::addSwitchJumpTable):
(JSC::CodeBlock::switchJumpTable):
(JSC::CodeBlock::clearSwitchJumpTables):
(RareData):
- bytecode/PreciseJumpTargets.cpp:
(JSC):
(JSC::computePreciseJumpTargets):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::shrinkToFit):
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables):
(JSC::UnlinkedCodeBlock::addSwitchJumpTable):
(JSC::UnlinkedCodeBlock::switchJumpTable):
(RareData):
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
(JSC::prepareJumpTableForSwitch):
(JSC::BytecodeGenerator::endSwitch):
- dfg/DFGByteCodeParser.cpp:
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 7:52 PM Changeset in webkit [151819] by
-
- 5 edits in tags/Safari-537.46.2/Source
Versioning.
- 7:50 PM Changeset in webkit [151818] by
-
- 1 copy in tags/Safari-537.46.2
New Tag.
- 7:49 PM Changeset in webkit [151817] by
-
- 2 edits in trunk/Source/WTF
Refine the StackBounds computation for Windows.
https://bugs.webkit.org/show_bug.cgi?id=117854.
Reviewed by Brent Fulgham.
- wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
- 7:29 PM Changeset in webkit [151816] by
-
- 1 delete in branches/safari-537-branch/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements.html
correct mismerge from 151799. <rdar://problem/14159682>
- 7:26 PM Changeset in webkit [151815] by
-
- 8 edits in trunk
[CMAKE][EFL] Enable DOM4 Events Constructor
https://bugs.webkit.org/show_bug.cgi?id=117858
Reviewed by Laszlo Gombos.
.:
- Source/cmake/OptionsEfl.cmake: Enabled ENABLE_DOM4_EVENTS_CONSTRUCTOR.
- Source/cmake/WebKitFeatures.cmake: Added ENABLE_DOM4_EVENTS_CONSTRUCTOR.
- Source/cmakeconfig.h.cmake: Ditto.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
LayoutTests:
- platform/efl/TestExpectations: Unskip the related tests.
- 7:24 PM Changeset in webkit [151814] by
-
- 16 edits4 deletes in branches/safari-537-branch
Merged r151799. <rdar://problem/14159682>
- 7:17 PM Changeset in webkit [151813] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151762. <rdar://problem/13837412>
- 5:44 PM Changeset in webkit [151812] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=116495
Fix null-pointer deref in DocumentLoader::responseReceived()
Patch by Nate Chapin, reviewed by Mike West and myself.
Test: http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): Added a null check.
- 4:43 PM Changeset in webkit [151811] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Roll out part of r150618.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 4:36 PM Changeset in webkit [151810] by
-
- 2 edits in trunk/Source/WTF
[Windows] Undoing r150621 to roll r150600 back in as the jsc test
failures have been fixed in r151808.
https://bugs.webkit.org/show_bug.cgi?id=116661.
Reviewed by Brent Fulgham.
- wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
- 3:52 PM Changeset in webkit [151809] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Send the correct offsets for misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=117846
JIRA116916.
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-06-20
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 3:17 PM Changeset in webkit [151808] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change stack capacity requirement to be more reasonable.
https://bugs.webkit.org/show_bug.cgi?id=117801.
Reviewed by Geoffrey Garen.
Previously, the requiredStack in StackPolicy::StackPolicy() was set to
to a high value like 256K to reduce the chances of encountering an
undetected stack overflow in a scenario where we have a combination of
deeply nested divs and a large amount recursive re-entries into the VM.
However, this high value of requiredStack still does not completely
ensure that we will never encounter an undetected stack overflow. It
only lessens the probability of encountering it.
Secondly, on some platforms, the total stack size can be less than 256K
to start with. Hence, this high value requiredStack renders the VM
unuseable on those platforms.
This patch will fix the requiredStack to be more reasonable based on
real world stack usage by the VM. We won't (and cannot) try to prevent
undetected stack overflows outside of JSC as well. External code that
do deep recursion (e.g. Documnet::updateLayout()) should do their own
stack checks.
From a previous experiment, we measured the following:
On a debug build on OSX:
- Stack usage different between recursive calls to interpreter entry: 7744 bytes
On a release build on OSX:
- Stack usage difference between recursive calls to interpreter entry: 6352 bytes
Using these as a guide, we'll pick the following values for the
StackPolicy:
requiredStack: 32K
errorModeRequiredStack: 16K
The requiredStack is chosen to be 4x the measured usage above. The
additional 3x is a conservative estimate to account for stack space
that may be needed by other native functions called while in the
interpreter.
The errorModeRequiredStack has to be less than the requiredStack or we
won't be able to reenter the interpreter to do error handling work when
an imminent stack overflow is detected. It is assumed that the error
handling code will only do minimal work to allocate an exception and its
stack trace, and not run any arbitrary JS code. As such, it is safe to
allow re-entry into the interpreter with only 2x the measured usage in
this case.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::StackPolicy::StackPolicy):
- 3:15 PM Changeset in webkit [151807] by
-
- 3 edits2 adds in trunk
Initial advance on the first glyph of the run is not correctly set for rtl text.
https://bugs.webkit.org/show_bug.cgi?id=117839
<rdar://problem/13860717>
Reviewed by Sam Weinig.
Source/WebCore:
We need to set the initial advance to the glyphBuffer, using the
initial advance of the complex run that will be drawn first.
In order to choose the run correctly we must consider the text direction.
Test: fast/text/complex-first-glyph-with-initial-advance.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::advance):
LayoutTests:
- fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
- fast/text/complex-first-glyph-with-initial-advance.html: Added.
- 2:42 PM Changeset in webkit [151806] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should clear character switch jump tables
https://bugs.webkit.org/show_bug.cgi?id=117852
Reviewed by Sam Weinig.
The FTL just uses LLVM's switch, which results in LLVM allocating its own switch
jump tables as needed.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::clearCharacterSwitchJumpTables):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- 2:37 PM Changeset in webkit [151805] by
-
- 5 edits in trunk/Source/WebCore
Fixed WebGL compile errors on Windows.
https://bugs.webkit.org/show_bug.cgi?id=117805
Reviewed by Brent Fulgham.
- html/canvas/WebGLRenderingContext.cpp: Included CString.h.
Added PLATFORM(WIN) to existing lists of platform macros.
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
- platform/graphics/OpenGLESShims.h:
- 2:28 PM Changeset in webkit [151804] by
-
- 6 edits in trunk/Source
FrameView needs to initialize paintsEntireContents on creation
https://bugs.webkit.org/show_bug.cgi?id=117844
Source/WebCore:
Reviewed by Anders Carlsson.
In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldPaintEntireContents):
- page/FrameView.cpp:
(WebCore::FrameView::init):
Source/WebKit/mac:
Reviewed by Anders Carlsson.
In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldPaintEntireContents):
- 2:28 PM Changeset in webkit [151803] by
-
- 2 edits in trunk/Source/WebCore
Sticky elements are missing or misplaced sometimes when reloading a page that scrolls to a named anchor
https://bugs.webkit.org/show_bug.cgi?id=117819
Reviewed by Anders Carlsson.
At the end of FrameView::performPostLayoutTasks() we call scrollToAnchor() which attempts
to restore the scroll position to a named anchor, even when the document has been
changed by layout. This ends up in a call to ScrollView::scrollTo(), which in turn
calls repaintFixedElementsAfterScrolling(). However, repaintFixedElementsAfterScrolling()
would bail if m_nestedLayoutCount != 0, so we never updated layer positions which
depend on scroll position (but which would not be updated by layout, since their
renderers are not marked for layout when scrolling happens).
We've solved this problem once before in updateFixedElementsAfterScrolling() which
checks for m_nestedLayoutCount <= 1, so that we do work on the outermost nested layout.
Apply that same fix to repaintFixedElementsAfterScrolling().
Very timing-dependent, so hard to make a test.
- page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
- 2:18 PM Changeset in webkit [151802] by
-
- 17 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support SwitchChar
https://bugs.webkit.org/show_bug.cgi?id=117849
Reviewed by Geoffrey Garen.
This adds Switch(SwitchChar) to the FTL and also implicitly does some other things.
SwitchChar requires calling a slow path to resolve ropes. Previously the FTL had no
support for calling slow paths, and we avoided adding coverage that would require
that. Well, this patch adds the ability to call slow paths and just uses that for
resolving ropes for SwitchChar. Also SwitchChar required adding awareness of strings,
so I did that, too.
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::addCodeOrigin):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNode.cpp:
(WTF):
(WTF::printInternal):
- dfg/DFGNode.h:
(WTF):
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- ftl/FTLAbbreviations.h:
(JSC::FTL::int16Type):
(JSC::FTL::constInt):
- ftl/FTLAbstractHeapRepository.h:
(FTL):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLIntrinsicRepository.cpp:
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
(FTL):
- ftl/FTLIntrinsicRepository.h:
(FTL):
(IntrinsicRepository):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::buildSwitch):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowString):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isObject):
(JSC::FTL::LowerDFGToLLVM::isNotString):
(JSC::FTL::LowerDFGToLLVM::isString):
(JSC::FTL::LowerDFGToLLVM::isNotObject):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::speculateString):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::vmCall):
(JSC::FTL::LowerDFGToLLVM::callPreflight):
(JSC::FTL::LowerDFGToLLVM::callCheck):
(JSC::FTL::LowerDFGToLLVM::lowBlock):
- ftl/FTLOutput.h:
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::load16):
(JSC::FTL::Output::isNull):
(JSC::FTL::Output::notNull):
(JSC::FTL::Output::testIsZero32):
(JSC::FTL::Output::testNonZero32):
(Output):
(JSC::FTL::Output::operation):
(JSC::FTL::Output::crash):
- 2:10 PM Changeset in webkit [151801] by
-
- 6 edits3 deletes in trunk/LayoutTests
Unreviewed, rolling out r151463.
http://trac.webkit.org/changeset/151463
https://bugs.webkit.org/show_bug.cgi?id=117850
"r151451 was rolled out" (Requested by rhogan on #webkit).
- platform/efl/fast/forms/button-positioned-expected.txt:
- platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/gtk/fast/forms/button-positioned-expected.txt:
- platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
- platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/win/fast/forms/onselect-textfield-expected.txt: Removed.
- 2:09 PM Changeset in webkit [151800] by
-
- 63 edits in trunk/Source
HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
https://bugs.webkit.org/show_bug.cgi?id=117830
Reviewed by Anders Carlsson.
The order of the template arguments at HashSet alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.
Source/JavaScriptCore:
- runtime/Identifier.h:
(JSC::IdentifierTable::add):
Source/WebCore:
No new tests. No new functionality.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedName):
- platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::getSubimage):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::isSupportedAttribute):
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::isSupportedAttribute):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isSupportedAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
- svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::isSupportedAttribute):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::isSupportedAttribute):
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::isSupportedAttribute):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::isSupportedAttribute):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::isSupportedAttribute):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::isSupportedAttribute):
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::isSupportedAttribute):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::isSupportedAttribute):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::isSupportedAttribute):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::isSupportedAttribute):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::isSupportedAttribute):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::isSupportedAttribute):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::isSupportedAttribute):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::isSupportedAttribute):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::isSupportedAttribute):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::isSupportedAttribute):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isSupportedAttribute):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::isSupportedAttribute):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::isSupportedAttribute):
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isSupportedAttribute):
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::isSupportedAttribute):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::isSupportedAttribute):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isSupportedAttribute):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::isSupportedAttribute):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::isSupportedAttribute):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::isSupportedAttribute):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::isSupportedAttribute):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):
Source/WTF:
- wtf/HashSet.h:
- wtf/text/AtomicString.cpp:
(WTF::addToStringTable):
(WTF::findString):
- 1:46 PM Changeset in webkit [151799] by
-
- 16 edits5 deletes in trunk
Unreviewed, rolling out r151451.
http://trac.webkit.org/changeset/151451
https://bugs.webkit.org/show_bug.cgi?id=117848
"Broke quite a lot of sites" (Requested by rhogan on #webkit).
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
- rendering/RenderButton.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
- rendering/RenderListBox.h:
- rendering/RenderMenuList.h:
- rendering/RenderReplaced.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
- rendering/RenderTextControl.h:
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Removed.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- fast/replaced/width-and-height-of-positioned-replaced-elements.html: Removed.
- platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/qt/fast/forms/button-positioned-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 1:37 PM Changeset in webkit [151798] by
-
- 10 edits2 deletes in trunk
Unreviewed, rolling out r151788.
http://trac.webkit.org/changeset/151788
https://bugs.webkit.org/show_bug.cgi?id=117847
"This is the wrong fix" (Requested by rhogan on #webkit).
Source/WebCore:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/height-of-positioned-text-control-expected.html: Removed.
- fast/replaced/height-of-positioned-text-control.html: Removed.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 1:19 PM Changeset in webkit [151797] by
-
- 5 edits in trunk
[Gstreamer] cleanup buffering and state updates
https://bugs.webkit.org/show_bug.cgi?id=116642
Reviewed by Philippe Normand.
Source/WebCore:
Covered by existing media tests, especially the ones that have been unskipped.
Always do download buffering. It should not differ if preload is "none" because
it's about when to start buffering, not about how. Fix a bunch other subtle issues
to make this change go smoothly with the tests. As a bonus some tests that were
failing so far started to pass.
It is possible to further tweak the buffering in a way that will enable us to support
a different and appropriate behavior for preload="metadata" but it should be managed
a bit differently. I will implement it in a follow-up.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Don't call setDownloadBuffering
yet. Now it also responsible for starting the fill timer and it turned out that
setting the download flag before the pipeline is set to a state has negative
effect on some tests. Most probably GStreamer starts buffering too early if
we set the download flag.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): Call setDownloadBuffering now.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto, plus set m_delayingLoad to false
because otherwise setPreload will wrongly assume that the load has not been committed
yet if prepareToPlay is not called before play.
(WebCore::MediaPlayerPrivateGStreamer::pause): Make sure we don't commit a load here
if it was not committed yet by looking in the pipeline state.
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): No need to observe the
type of buffering.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Introduced m_downloadFinished to update
ready and network states in updateStates based on it. The previously used condition
- (maxTimeLoaded() == duration()) - was not correct in the case when duration is not known.
(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): Removed a lie. If the fill timer is not active
it does not necesarily means that download has been finished. This lie was actually ensuring
a lot of tests to pass because it made the condition (maxTimeLoaded() == duration()) true.
Now that state updates has been cleaned up we don't need to lie.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Merge all the parts that takes part in updating
ready and network states. It was untrackable. Unset download buffering for for live streams early so
we don't need to restart them.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer): Removed m_startedBuffering because there is no need for it now.
LayoutTests:
Remove failure expectations from tests that started to pass.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 1:14 PM Changeset in webkit [151796] by
-
- 5 edits2 adds in trunk
ASSERT removing then adding a <track> element
https://bugs.webkit.org/show_bug.cgi?id=117814
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/add-and-remove-track.html
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto): Always call ensureTrack before adding the track
to the parent <video> element.
(WebCore::HTMLTrackElement::ensureTrack): Call m_track->setTrackElement() in case the
parent was cleared after m_track was created.
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::setTrackElement): New, set m_trackElement.
- html/track/LoadableTextTrack.h:
LayoutTests:
- media/track/add-and-remove-track-expected.txt: Added.
- media/track/add-and-remove-track.html: Added.
- 1:12 PM Changeset in webkit [151795] by
-
- 6 edits in trunk/Source/WebKit2
WebProcess hangs loading eff.org (Waiting forever on a sync XHR, NetworkProcess unable to service it).
<rdar://problem/14112329> and https://bugs.webkit.org/show_bug.cgi?id=117842
Reviewed by Alexey Proskuryakov.
- NetworkProcess/HostRecord.cpp:
(WebKit::removeLoaderFromQueue): Utility to clear a Loader out of a LoaderQueue.
(WebKit::HostRecord::removeLoader): Use removeLoaderFromQueue, and also try to clear the loader from m_syncLoadersPending.
(WebKit::HostRecord::servePendingRequestsForQueue): Small refactoring/cleanup.
(WebKit::HostRecord::limitsRequests): Change so that if the number of loaders in flight is exactly equal to the limit, then
allow serving a synchronous loader to go exactly one beyond the limit.
- NetworkProcess/HostRecord.h:
Make the static maxRequestsInFlightPerHost a member of the NetworkResourceLoadScheduler, instead:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::hostForURL):
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost): Tell CFNetwork to allow
7 connections per host instead of 6, but tell the scheduler that 6 is still the normal limit.
- 1:12 PM Changeset in webkit [151794] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Build fix for Apple Windows port.
- rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
- 1:06 PM Changeset in webkit [151793] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Downloaded file name encoding is incorrect when download link opens in a new window
https://bugs.webkit.org/show_bug.cgi?id=117818
<rdar://problem/14212635>
Reviewed by Brady Eidson.
No tests added. The machinery we have for logging downloaded file name is very
far from being able to work in a secondary window.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Made a targeted fix - don't update encoding fallback array if we already have one, there is no chance for it to be more correct. In this case, it's incorrect because it comes from a new blank window, instead of original referer. We have a lot of code in addExtraFieldsToRequest() to struggle with this, and we have a FIXME to try not calling it from policy delegate.
- 12:44 PM Changeset in webkit [151792] by
-
- 5 edits in trunk/Source
Versioning.
- 12:32 PM Changeset in webkit [151791] by
-
- 2 edits in trunk
[GTK] remove bashism from configure
https://bugs.webkit.org/show_bug.cgi?id=117796
Reviewed by Gustavo Noronha Silva.
- Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value
of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.
- 12:16 PM Changeset in webkit [151790] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-20
- platform/mac-wk2/TestExpectations:
The test fails regularly in Debug on Mountain Lion.
- 12:10 PM Changeset in webkit [151789] by
-
- 4 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=117824
Unreviewed, rebaselining.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt:
- 11:58 AM Changeset in webkit [151788] by
-
- 10 edits2 adds in trunk
REGRESSION (r151451): Text not vertically centered correctly on icloud.com
https://bugs.webkit.org/show_bug.cgi?id=117744
Reviewed by David Hyatt.
Source/WebCore:
The positioned height and width computation adds in the element's border and padding so
don't add it to the intrinsic height and preferred widths of text controls that are
absolutely positioned.
Test: fast/replaced/height-of-positioned-text-control.html
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/height-of-positioned-text-control-expected.html: Added.
- fast/replaced/height-of-positioned-text-control.html: Added.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 11:55 AM Changeset in webkit [151787] by
-
- 8 edits in trunk/Source
Make Windows makefile copy build output to a different folder.
<rdar://problem/14219184>.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- WebKit.vcxproj/WebKit.make:
- 11:36 AM Changeset in webkit [151786] by
-
- 3 edits in trunk/Source/JavaScriptCore
Improper deallocation of JSManagedValue causes crashes during autorelease pool draining
https://bugs.webkit.org/show_bug.cgi?id=117840
Reviewed by Geoffrey Garen.
Improperly managing a JSManagedValue can cause a crash when the JSC::Weak inside the
JSManagedValue is destroyed upon deallocation. We would rather have improperly maintained
JSManagedValues cause memory leaks than take down the whole app.
The fix is to use the callback to the JSC::Weak on the destruction of the VM so that we
can safely null it out. This will prevent ~Weak from crashing.
- API/JSManagedValue.mm:
(-[JSManagedValue JSC::JSC::]):
(JSManagedValueHandleOwner::finalize):
- API/tests/testapi.mm: Added a test that crashed prior to this fix due to a leaked
managed reference. Also fixed a small style nit I noticed in another test.
- 11:24 AM Changeset in webkit [151785] by
-
- 2 edits in trunk/Source/WebCore
Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
https://bugs.webkit.org/show_bug.cgi?id=117811
Reviewed by Eric Carlson.
When comparing Generic cues, we should check that their type is Generic, not WebVTT.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore):
- 11:07 AM Changeset in webkit [151784] by
-
- 2 edits in trunk/Source/WebCore
[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=117711
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-20
Reviewed by Laszlo Gombos.
No new tests, no CMake platforms currently enable this functionality.
- CMakeLists.txt:
- 11:04 AM Changeset in webkit [151783] by
-
- 44 edits in trunk/Source/WebCore
Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117829
Reviewed by Andreas Kling.
A lot of call sites were using integers to represent them. While it's
not incorrect per se, it's not ideal for various reason such as type
safety or to remove ambiguity.
This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.
Instead we use new but typed functions to construct the values as well
as getting them. Two customs and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.
It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.
No new tests: refactor, existing tests should cover.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSGradientValue.cpp:
(WebCore::positionFromValue):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSystemColor):
(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isBlendMode):
(WebCore::CSSParser::isCompositeOperator):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::propertyName):
(WebCore::valueName):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isValueID):
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createParserOperator):
(WebCore::CSSPrimitiveValue::getPropertyID):
(WebCore::CSSPrimitiveValue::getValueID):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::convertToLength):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/Counter.h:
(WebCore::Counter::listStyleIdent):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaQueryEvaluator.cpp:
(WebCore::orientationMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::colorForCSSValue):
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::toIdentifier):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::create):
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::create):
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::fontWeightIsBold):
(WebCore::legacyFontSizeFromCSSValue):
(WebCore::isTransparentColorValue):
- editing/EditingStyle.h:
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::systemFont):
- platform/blackberry/RenderThemeBlackBerry.h:
(WebCore::RenderThemeBlackBerry::systemFont):
- platform/blackberry/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont):
- platform/blackberry/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::systemFont):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemFont):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::systemColor):
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::systemColor):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::systemColor):
- platform/qt/RenderThemeQt.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::systemColor):
- rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::systemFont):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::systemFont):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
- rendering/RenderThemeWin.h:
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):
- rendering/RenderThemeWinCE.h:
- 10:57 AM Changeset in webkit [151782] by
-
- 1 copy in branches/safari-537-branch
New Branch.
- 10:54 AM Changeset in webkit [151781] by
-
- 22 edits8 adds in branches/dfgFourthTier
fourthTier: DFG should have switch_char
https://bugs.webkit.org/show_bug.cgi?id=117710
Source/JavaScriptCore:
Reviewed by Michael Saboff.
Add op_switch_char. Most of this is fairly simple, except for the whole
LazyJSValue thing.
It's long been the case that anytime you wanted the DFG to speak of a string
that didn't appear in the constant pool, you would have a hard time since
the DFG isn't allowed to allocate in the GC heap. For example, if you know
that you want to speak of a single character string, you might find that
the one you wanted to speak of had been GC'd. Another example is if you
wanted to add constant folding for string concatenation - something we don't
have yet but will want eventually.
I solve this by finally adding the notion of LazyJSValue. In the future I
anticipate using this for a variety of string-related things. The idea here
is that the DFG can either say that it already knows what the value is, or
it can describe the value. For example, in this patch I needed to be able to
describe single-character strings.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/JumpTable.h:
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::payloadGPR):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpTable):
(DFG):
(JSC::DFG::JITCompiler::numberOfJumpTables):
(JSC::DFG::JITCompiler::linkSwitches):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- dfg/DFGLazyJSValue.cpp: Added.
(DFG):
(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToSingleCharacter):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):
- dfg/DFGLazyJSValue.h: Added.
(DFG):
(LazyJSValue):
(JSC::DFG::LazyJSValue::LazyJSValue):
(JSC::DFG::LazyJSValue::singleCharacterString):
(JSC::DFG::LazyJSValue::tryGetValue):
(JSC::DFG::LazyJSValue::value):
(JSC::DFG::LazyJSValue::character):
(JSC::DFG::LazyJSValue::switchLookupValue):
- dfg/DFGNode.h:
(JSC::DFG::SwitchCase::SwitchCase):
(SwitchCase):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImmIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitch):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
Source/WTF:
Reviewed by Michael Saboff.
I wanted to be able to say stringImpl->at(index), and now I can!
Also made it possible to convert a UChar to a utf8 CString without
allocating a StringImpl.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::utf8Impl):
(WTF):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::utf8ForRange):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::at):
(WTF::StringImpl::operator[]):
LayoutTests:
Rubber stamped by Mark Hahnenberg.
- fast/js/regress/script-tests/switch-char-constant.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/switch-char.js: Added.
(foo):
(bar):
- fast/js/regress/switch-char-constant-expected.txt: Added.
- fast/js/regress/switch-char-constant.html: Added.
- fast/js/regress/switch-char-expected.txt: Added.
- fast/js/regress/switch-char.html: Added.
- 10:14 AM Changeset in webkit [151780] by
-
- 6 edits in trunk
[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
https://bugs.webkit.org/show_bug.cgi?id=117827
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-20
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.
Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.
- Api/DumpRenderTreeClient.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Tools:
Reset the passed in request if willSendRequestReturnsNull() is
true or willSendRequestReturnsNullOnRedirect() is true and it's a
redirection.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
- 9:59 AM Changeset in webkit [151779] by
-
- 2 edits in trunk/Tools
Commit queue shouldn't reopen unrelated bugs because of flakiness
https://bugs.webkit.org/show_bug.cgi?id=117503
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
(_follow_duplicate_chain):
(_update_bug_for_flaky_test):
- 9:16 AM Changeset in webkit [151778] by
-
- 7 edits in trunk/Source/WebCore
AX: List Items should support a default action
https://bugs.webkit.org/show_bug.cgi?id=117812
Reviewed by Chris Fleizach.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
for use in ListItemRole objects.
- platform/LocalizedStrings.cpp:
(WebCore::AXListItemActionVerb): Added.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXListItemActionVerb):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXListItemActionVerb):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXListItemActionVerb):
- 9:13 AM Changeset in webkit [151777] by
-
- 36 edits3 copies4 adds in trunk
[CSS Regions] Add new regionOversetChange event
https://bugs.webkit.org/show_bug.cgi?id=117508
Source/WebCore:
Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData
object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing
the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again,
there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.
Tests: fast/regions/webkit-named-flow-event-add-to-flow.html:
fast/regions/webkit-named-flow-event-auto-height.html:
fast/regions/webkit-named-flow-event-crash.html:
fast/regions/webkit-named-flow-event-no-regions.html:
fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
fast/regions/webkit-named-flow-event-remove-from-dom.html:
fast/regions/webkit-named-flow-event-remove-from-flow.html:
fast/regions/webkit-named-flow-event-target.html:
fast/regions/webkit-named-flow-event-to-null.html:
fast/regions/webkit-named-flow-event.html:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::setRegionOversetState):
(WebCore::Element::regionOversetState):
(WebCore::Element::webkitRegionOverset):
- dom/Element.h:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::regionOversetState):
(WebCore::ElementRareData::setRegionOversetState):
(WebCore::ElementRareData::ElementRareData):
- dom/EventNames.h:
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):
- dom/WebKitNamedFlow.h:
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
- rendering/RegionOversetState.h: Added.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOversetStateForRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
- rendering/RenderRegion.h:
LayoutTests:
Changed regionLayoutUpdate tests to regionOversetChange and added new tests for regionOversetChange.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.
- fast/regions/webkit-named-flow-event-add-to-flow-expected.txt:
- fast/regions/webkit-named-flow-event-add-to-flow.html:
- fast/regions/webkit-named-flow-event-auto-height-expected.txt:
- fast/regions/webkit-named-flow-event-auto-height.html: Added.
- fast/regions/webkit-named-flow-event-crash-expected.txt:
- fast/regions/webkit-named-flow-event-crash.html:
- fast/regions/webkit-named-flow-event-expected.txt:
- fast/regions/webkit-named-flow-event-no-regions-expected.txt:
- fast/regions/webkit-named-flow-event-no-regions.html:
- fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt:
- fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
- fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt:
- fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
- fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt:
- fast/regions/webkit-named-flow-event-remove-from-dom.html:
- fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt:
- fast/regions/webkit-named-flow-event-remove-from-flow.html:
- fast/regions/webkit-named-flow-event-target-expected.txt:
- fast/regions/webkit-named-flow-event-target.html:
- fast/regions/webkit-named-flow-event-to-null-expected.txt:
- fast/regions/webkit-named-flow-event-to-null.html:
- fast/regions/webkit-named-flow-event.html:
- 9:08 AM Changeset in webkit [151776] by
-
- 9 edits in trunk
AX: aria-required is not exposed on all expected roles
https://bugs.webkit.org/show_bug.cgi?id=115123
Patch by James Craig <james@cookiecrook.com> on 2013-06-20
Reviewed by Chris Fleizach.
aria-required is now exposed on more roles. Updated existing test file.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsRequiredAttribute):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
LayoutTests:
- platform/mac/accessibility/aria-required-expected.txt:
- platform/mac/accessibility/aria-required.html:
- platform/mac/accessibility/radio-button-group-members-expected.txt:
- 7:26 AM WebKitGTK/StartHacking edited by
- More minor changes (diff)
- 7:24 AM WebKitGTK/StartHacking edited by
- Minor change (diff)
- 7:20 AM WebKitGTK/StartHacking edited by
- Minor styling (diff)
- 7:17 AM WebKitGTK/StartHacking edited by
- (diff)
- 7:11 AM Changeset in webkit [151775] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Update text checker documentation.
https://bugs.webkit.org/show_bug.cgi?id=117828
Reviewed by Christophe Dumez.
- UIProcess/API/efl/ewk_text_checker.h:
The client is not responsible for destroying the memory.
- 7:09 AM WebKitGTK/StartHacking edited by
- Added choosing distribution section (diff)
- 6:21 AM Changeset in webkit [151774] by
-
- 9 edits2 deletes in trunk
Web Inspector: Use console.timeStamp instead of console.markTimeline
https://bugs.webkit.org/show_bug.cgi?id=117810
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-20
Reviewed by Joseph Pecoraro.
Source/WebCore:
Webkit supports both console.timeStamp and console.markTimeline.
And they do the exact same thing.
This patch gets rid of console.markTimeline for Chrome/Firebug compatibility.
No new functionality, no new tests.
- WebCore.order:
- page/Console.cpp:
- page/Console.h:
- page/Console.idl:
LayoutTests:
Use 'console.timeStamp' instead of 'console.markTimeline' in LayoutTests.
And remove inspector/timeline/timeline-mark-timeline.html.
- inspector/console/console-messages-stack-traces-expected.txt:
- inspector/console/console-messages-stack-traces.html:
- inspector/timeline/timeline-mark-timeline-expected.txt: Removed.
- inspector/timeline/timeline-mark-timeline.html: Removed.
- inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
- 1:22 AM Changeset in webkit [151773] by
-
- 2 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
Rebselining after r151761, see bug 115372.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/vertical-overflow-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/vertical-overflow-parent-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/vertical-overflow-same-expected.txt: Added.
- 1:04 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:39 AM Changeset in webkit [151772] by
-
- 4 edits6 adds in trunk
background-color and text-decoration are not preserved when merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=116215
Reviewed by Ryosuke Niwa.
Source/WebCore:
In mergeInlineAndImplicitStyleOfElement(), style from matched rules are retrieved.
If they contain either background-color or text-decoration they will be removed
by removeNonEditingProperties() due to copyEditingProperties() implicit
'OnlyInheritableEditingProperties' parameter.
We have already had similar issue at https://bugs.webkit.org/show_bug.cgi?id=53196
Tests: editing/deleting/merge-div-from-span-with-style.html
editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html
editing/deleting/merge-paragraph-from-span-with-style.html
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
Add EditingStyle:: due to move EditingPropertiesToInclude to EditingStyle.h.
(WebCore::toEditingProperties):
Add a helper to easy convert PropertiesToInclude to EditingPropertiesToInclude,
needed in mergeInlineAndImplicitStyleOfElement().
(WebCore::EditingStyle::removeAllButEditingProperties):
Add a parameter to choose which editing properties should be preserved while
removing all properties (OnlyInheritableEditingProperties implicite).
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
Call removeAllButEditingProperties with parameter.
- editing/EditingStyle.h:
Move EditingPropertiesType to the header as it's needed by removeAllButEditingProperties().
Change EditingPropertiesType to EditingPropertiesToInclude to be consistent with
PropertiesToInclude.
Change removeNonEditingProperties() to removeAllButEditingProperties().
LayoutTests:
Added tests for verifying merge of paragraph/div from span with non-inline styles.
- editing/deleting/merge-div-from-span-with-style-expected.txt: Added.
- editing/deleting/merge-div-from-span-with-style.html: Added.
- editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt: Added.
- editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html: Added.
- editing/deleting/merge-paragraph-from-span-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-from-span-with-style.html: Added.
Jun 19, 2013:
- 10:44 PM Changeset in webkit [151771] by
-
- 2 edits in trunk/Source/WebCore
The order of the generated supplemental code is not guaranteed
https://bugs.webkit.org/show_bug.cgi?id=117820
Reviewed by Kentaro Hara.
Sort the supplemental idl files before generating the code so that it is
generated in a consistent order.
No new tests, covered by existing bindings tests.
- bindings/scripts/generate-bindings.pl:
- 10:39 PM Changeset in webkit [151770] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r151769.
http://trac.webkit.org/changeset/151769
https://bugs.webkit.org/show_bug.cgi?id=117821
Broke windows build due to missing GL/glext.h header.
(Requested by bfulgham on #webkit).
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 10:06 PM Changeset in webkit [151769] by
-
- 3 edits in trunk/Source/WebCore
Added WebGL files to Windows build without enabling them.
https://bugs.webkit.org/show_bug.cgi?id=117809
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-06-19
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
- 10:04 PM Changeset in webkit [151768] by
-
- 4 edits in trunk/Source/WebCore
Windows build should include WebGL generated files if WebGL is enabled.
https://bugs.webkit.org/show_bug.cgi?id=117802
Reviewed by Brent Fulgham.
Added WebGL generated files to Windows build if WebGL is enabled.
- DerivedSources.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 9:30 PM Changeset in webkit [151767] by
-
- 8 edits in trunk/Source/WebKit2
Expose plug-ins CFBundleShortVersionString in the WKPluginInformation dictionary
https://bugs.webkit.org/show_bug.cgi?id=117816
Reviewed by Geoffrey Garen.
- Adds a new key for the WKPluginInformation dictionary: WKPluginInformationBundleShortVersionKey().
- Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationBundleShortVersionKey):
- Shared/API/c/WKPluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::pluginInformationBundleShortVersionKey):
- Shared/Plugins/Netscape/PluginInformation.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation):
- Shared/Plugins/PluginModuleInfo.h:
- 9:22 PM Changeset in webkit [151766] by
-
- 1 edit1 add in trunk/LayoutTests
Adding a Mac pixel result.
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
- 9:20 PM Changeset in webkit [151765] by
-
- 1 edit3 adds in trunk/LayoutTests
[Windows] Unreviewed AX test expecation gardening.
- platform/win/accessibility/aria-labelledby-on-input-expected.txt: Added.
- platform/win/accessibility/aria-list-and-listitem-expected.txt: Added.
- platform/win/accessibility/aria-roles-expected.txt: Added.
- 9:14 PM Changeset in webkit [151764] by
-
- 2 edits in trunk/Tools
[Windows] AX: Expand notification support.
https://bugs.webkit.org/show_bug.cgi?id=117761
Reviewed by Anders Carlsson.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isPressActionSupported): Provide implementation.
(AccessibilityUIElement::press): Provide implementation.
- 7:35 PM Changeset in webkit [151763] by
-
- 2 edits in trunk/LayoutTests
Unskip feSpecularLight-premultiplied.svg on Mountain Lion
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
- platform/mac/TestExpectations:
The test is failing on Lion exclusively.
- 7:18 PM Changeset in webkit [151762] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Common crashes when playing media
https://bugs.webkit.org/show_bug.cgi?id=117813
<rdar://problem/13837412>
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): This method may be called from a secondary thread, but it does things that are not thread safe.
- 6:06 PM Changeset in webkit [151761] by
-
- 4 edits12 adds in trunk
Incomplete repaint of input elements in writing-mode overflow
https://bugs.webkit.org/show_bug.cgi?id=110246
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-19
Reviewed by Simon Fraser.
Source/WebCore:
We calculate repaint rect using unflipped rect.
However, RenderBox::applyCachedClipAndScrollOffsetForRepaint() which is called from repaint rect calculation
wants that its argument rect is flipped.
The reason is:
- paintRect.move(-scrolledContentOffset()); cannot scroll if the rect is unflipped.
- It cannot clip using intersect.
Passing unflipped rect to applyCachedClipAndScrollOffsetForRepaint() cause invalid clipping.
Therefore, this patch flipped the rect at the first part of the function and unflipped it at the last part of the function.
Scroll bar rect is absolute rect, so it is flipped rect.
RenderLayer::invalidateScrollbarRect() pass the rect to repaintRectangle() which expects an argument rect is unflipped.
This cause part of overlapping scroll bar doesn't fade out.
Therefore, this patch flipped the rect and pass it to repaintRectangle().
Tests: fast/repaint/horizontal-bt-overflow-child.html
fast/repaint/horizontal-bt-overflow-parent.html
fast/repaint/horizontal-bt-overflow-same.html
fast/repaint/vertical-overflow-child.html
fast/repaint/vertical-overflow-parent.html
fast/repaint/vertical-overflow-same.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
LayoutTests:
- fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
- fast/repaint/horizontal-bt-overflow-child.html: Added.
- fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
- fast/repaint/horizontal-bt-overflow-parent.html: Added.
- fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
- fast/repaint/horizontal-bt-overflow-same.html: Added.
- fast/repaint/vertical-overflow-child-expected.txt: Added.
- fast/repaint/vertical-overflow-child.html: Added.
- fast/repaint/vertical-overflow-parent-expected.txt: Added.
- fast/repaint/vertical-overflow-parent.html: Added.
- fast/repaint/vertical-overflow-same-expected.txt: Added.
- fast/repaint/vertical-overflow-same.html: Added.
- 5:10 PM Changeset in webkit [151760] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/14197983> Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms (117765)
https://bugs.webkit.org/show_bug.cgi?id=117765
Patch by Ruth Fong <ruth_fong@apple.com>.
Reviewed by Brady Eidson.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultGetMediaType): Updated to use mediaType().
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaType): Updated.
Renamed getMediaType() to mediaType() and now handles !ENABLE(VIDEO) platforms.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- 4:37 PM Changeset in webkit [151759] by
-
- 2 edits in trunk/LayoutTests
Unskip two canvas tests that only fail on Lion
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
- platform/mac/TestExpectations:
- 4:17 PM Changeset in webkit [151758] by
-
- 2 edits in trunk/LayoutTests
Rebaseline 24bit-22khz-resample on Mac
The result did not match the expectation after a system update.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
- platform/mac-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav:
Comparing the files, they have the exact same length, sample rate, bit per sample and binary size.
I cannot ear a difference in the files.
- 3:41 PM Changeset in webkit [151757] by
-
- 28 edits in trunk
Use the PlatformEvent timestamp when creating a DOM Event
https://bugs.webkit.org/show_bug.cgi?id=117179
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
Reviewed by Darin Adler.
Source/WebCore:
Previously, the platform event's timestamp was ignored by WebCore and each
new event would get a new timestamp by calling WTF::currentTime().
The problem is there can be a significant delay between the input event and
it being dispatched to JavaScript. Computing the velocity/acceleration of the cursor
is impossible since the delay vary from event to events.
On WebKit2, the delay per event typically vary between 0 and 30ms.
This patch changes the Event creation code to use the timer passed by the underlying platform event.
- WebCore.exp.in:
- dom/Event.cpp:
(WebCore::Event::Event):
- dom/Event.h:
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::GestureEvent):
- dom/GestureEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
- dom/MouseEvent.h:
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
- dom/MouseRelatedEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
- dom/UIEvent.cpp:
(WebCore::UIEvent::UIEvent):
- dom/UIEvent.h:
- dom/UIEventWithKeyState.h:
(WebCore::UIEventWithKeyState::UIEventWithKeyState):
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
- dom/WheelEvent.h:
(WebCore::WheelEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
Source/WebKit/mac:
- WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebGestureEvent):
Tools:
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):
- 3:28 PM Changeset in webkit [151756] by
-
- 1 edit in trunk/Source/WTF/ChangeLog
Fixed reviewer name
- 3:27 PM Changeset in webkit [151755] by
-
- 2 edits in trunk/Source/WTF
Remove the SegmentedVector inline segment to shrink CodeBlock by 6X
https://bugs.webkit.org/show_bug.cgi?id=117808
Reviewed by Geoffrey Garen.
SegmentedVector allocation isn't super hot, but we do tend to have many
live SegmentedVectors at runtime, particularly in CodeBlocks, so the
right tradeoff is to allocate segments out-of-line as needed.
This reduces startup memory usage @ google.com by about 6MB.
No regression on SunSpider.
- wtf/SegmentedVector.h:
(WTF::SegmentedVector::SegmentedVector):
(WTF::SegmentedVector::at):
(WTF::SegmentedVector::append):
(WTF::SegmentedVector::removeLast):
(WTF::SegmentedVector::clear):
(WTF::SegmentedVector::deleteAllSegments): No more inline segment.
(WTF::SegmentedVector::ensureSegmentsFor): This code used to assume
that there was always a 0 segment, so the math would underflow if there
were no 0 segment. I udpated the math to account for having no segments.
- 3:16 PM BuildingGtk edited by
- Added links to root pages (diff)
- 3:12 PM WebKitGTK/StartHacking edited by
- (diff)
- 3:11 PM WebKitGTK/StartHacking edited by
- Added hacking guide section (diff)
- 3:07 PM WebKitGTK/Chroot edited by
- (diff)
- 3:07 PM Changeset in webkit [151754] by
-
- 21 edits in trunk/Source/WebCore
Make sure to use CSSValueID and CSSPropertyID rather than integers
https://bugs.webkit.org/show_bug.cgi?id=117481
Reviewed by Benjamin Poulain.
This will ensure that types are enforced when passing arguments in various
css functions. Having a compile time check make sure that no mistakes
will be done over the type.
The parser was also patched to directly use CSSValueID over integers.
This patch also fixes various call sites abusing the usage of integers.
This is part 1 of 2.
No new tests : existing ones should cover.
- WebCore.xcodeproj/project.pbxproj: copy CSSValueKeywords.h as it could be used in WebKit/ for example.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForRepeatRule):
(WebCore::cssIdentifierForFontSizeKeyword):
(WebCore::identifierForFamily):
(WebCore::valueForFamily):
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseLineHeight):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::createFontWeightValueKeyword):
(WebCore::CSSParser::parseFontWeight):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSParser.h:
- css/CSSParserValues.h:
- css/CSSPrimitiveValue.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createIdentifierValue):
- css/CSSValuePool.h:
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):
- css/StylePropertySet.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
- dom/StyledElement.h:
- editing/EditingStyle.cpp:
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::prepareToApplyAt):
- editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeFontSize):
- html/HTMLElement.cpp:
(WebCore::unicodeBidiAttributeForDirAuto):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
- html/HTMLFontElement.h:
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCSSWritingDirection):
(WebCore::TextTrackCue::getCSSWritingMode):
- html/track/TextTrackCue.h:
- 2:54 PM WebKitGTK/Chroot edited by
- Minor fix (diff)
- 2:53 PM WebKitGTK/Chroot edited by
- Added Fixes (diff)
- 1:54 PM Changeset in webkit [151753] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Correct style on last patch.
Reviewed by Tim Horton.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
- 1:51 PM Changeset in webkit [151752] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build correction.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Make sure returned generic
type is a CFStringRef before casting.
- 1:37 PM Changeset in webkit [151751] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed build fix for Apple Windows port.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
- 1:11 PM Changeset in webkit [151750] by
-
- 6 edits in trunk/Source/WebCore
Fix a few missed renames from Exclusions -> Shapes
https://bugs.webkit.org/show_bug.cgi?id=117803
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-19
Reviewed by David Hyatt.
In the great CSS Exclusions to CSS Shapes rename, a few instances were
missed. This fixes those instances.
No new tests, no behavior change, just renames.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
(WebCore::RenderBlock::updateRegionsAndShapesAfterChildLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- rendering/RenderBlock.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- 1:09 PM Changeset in webkit [151749] by
-
- 9 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
Refactor ObjCCallbackFunction to inherit directly from InternalFunction
https://bugs.webkit.org/show_bug.cgi?id=117595
Reviewed by Geoffrey Garen.
- API/APICallbackFunction.h: Added. New struct that allows JSCallbackFunction and
ObjCCallbackFunction to share their host call() implementation through the magic of
templates.
(JSC::APICallbackFunction::call):
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallData): Changed to get the template-ized version of
the host function.
- API/JSCallbackFunction.h:
- API/ObjCCallbackFunction.h: Now inherits directly from InternalFunction.
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
(JSC::ObjCCallbackFunction::getCallData): Ditto.
- GNUmakefile.list.am: Build files!
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:05 PM Changeset in webkit [151748] by
-
- 8 edits in trunk/Source/WebKit2
REGRESSION: Cannot open Silverlight preferences via context menu
https://bugs.webkit.org/show_bug.cgi?id=117806
<rdar://problem/14166644>
Reviewed by Beth Dakin.
Hook the LSOpenCFURLRef function and make the UI process open the URL if it's the URL for the
Silverlight Preferences application. This is what we do for the Flash updater.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::openCFURLRef):
(WebKit::initializeShim):
(WebKit::PluginProcess::openURL):
- PluginProcess/mac/PluginProcessShim.h:
- PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shimLSOpenCFURLRef):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isSilverlightPreferencesURL):
(WebKit::shouldOpenURL):
(WebKit::PluginProcessProxy::openURL):
- 12:45 PM Changeset in webkit [151747] by
-
- 2 edits in trunk/Source/WebCore
Incorrect use of jsCast in a finalizer
https://bugs.webkit.org/show_bug.cgi?id=117807
Reviewed by Geoffrey Garen.
We can't use jsCast in a finalizer as it checks an object's structure,
and the structure may already have been swept by that point. Use a
static_cast instead.
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::destroy):
- 11:54 AM Changeset in webkit [151746] by
-
- 26 edits in trunk/LayoutTests
Rebaseline results on GTK and EFL after r151737
Unreviewed, gardening.
- platform/efl/fast/css/word-space-extra-expected.txt:
- platform/efl/fast/replaced/width100percent-image-expected.png:
- platform/efl/fast/replaced/width100percent-image-expected.txt:
- platform/efl/fast/replaced/width100percent-menulist-expected.png:
- platform/efl/fast/replaced/width100percent-menulist-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.png:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- platform/efl/fast/replaced/width100percent-textarea-expected.png:
- platform/efl/fast/replaced/width100percent-textarea-expected.txt:
- platform/efl/fast/replaced/width100percent-textfield-expected.png:
- platform/efl/fast/replaced/width100percent-textfield-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57828-expected.png:
- platform/efl/tables/mozilla/bugs/bug57828-expected.txt:
- platform/gtk/fast/css/word-space-extra-expected.txt:
- platform/gtk/fast/replaced/width100percent-image-expected.png:
- platform/gtk/fast/replaced/width100percent-image-expected.txt:
- platform/gtk/fast/replaced/width100percent-menulist-expected.png:
- platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
- platform/gtk/fast/replaced/width100percent-textarea-expected.png:
- platform/gtk/fast/replaced/width100percent-textarea-expected.txt:
- platform/gtk/fast/replaced/width100percent-textfield-expected.png:
- platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:
- 11:45 AM Changeset in webkit [151745] by
-
- 8 edits in trunk/Source
../WebCore: [Windows] AX: Extend notification handling
https://bugs.webkit.org/show_bug.cgi?id=117761.
Reviewed by Anders Carlsson.
accessibility/press-works-on-control-types.html
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Add handlers for more event notifications.
- accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Protect against null
pointer dereference found during testing.
- dom/Document.cpp:
(WebCore::Document::implicitClose): Execute notification handler for Windows as well as Mac.
- page/FrameView.cpp:
(WebCore::FrameView::layout): Ditto.
../WebKit/win: [Windows] AX: Extend notification support.
https://bugs.webkit.org/show_bug.cgi?id=117761
Reviewed by Anders Carlsson.
- AccessibleDocument.cpp:
(AccessibleDocument::state): Improve handling of focus state.
- AccessibleDocument.h: Provide signature for new state override.
- 11:38 AM Changeset in webkit [151744] by
-
- 14 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Arity fixup should be done while on same stack
https://bugs.webkit.org/show_bug.cgi?id=117102
Reviewed by Oliver Hunt.
Removed the fixup part of op_call_arityCheck() and op_construct_arityCheck() and moved it to
a thunk for the JITs and as assembly for the llint. This patch provides the plumbing needed to
move to the C stack for JS execution. The fixup thunk and llint code would need to be change to
work with a stack that grows down when we do move to the C stack.
Due to an issue with the offline assembler, I moved the const at the top of LowLevelInterpreter64.asm
and LowLevelInterpreter32_64.asm to LowLevelInterpreter.asm. The problem is that a const defined in
one file that are used in a macro doesn't resolve the const if the macro is used in another file. This
seemed like the quickest path.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
- jit/ThunkGenerators.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- 11:17 AM Changeset in webkit [151743] by
-
- 4 edits1 delete in trunk/Source/WebCore
[WinCairo] Webfont rendering is broken.
https://bugs.webkit.org/show_bug.cgi?id=117695
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.
The native font handle created from webfont data is invalid.
In much the same way it's done in WinApple, we first need to install the webfont,
create a native font handle from the new font name,
and pass the font handle to the FontPlatformData object, where it's needed to get the glyphs.
- platform/graphics/FontPlatformData.h: Added HFONT parameter to constructor.
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Release installed webfont.
(WebCore::FontCustomPlatformData::fontPlatformData): Create valid HFONT handle for webfont.
(WebCore::createUniqueFontName): Added method to create webfont name.
(WebCore::createFontCustomPlatformData): Install font from webfont data.
- platform/graphics/win/FontCustomPlatformDataCairo.h: Removed.
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Added HFONT parameter to constructor.
- 11:05 AM Changeset in webkit [151742] by
-
- 3 edits in trunk/Source/WebKit/win
[WinCairo] Does not compile.
https://bugs.webkit.org/show_bug.cgi?id=117798
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.
Add USE(CFNETWORK) guards.
- WebCoreSupport/WebFrameNetworkingContext.cpp: Add USE(CFNETWORK) guard.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Change USE(CF_NETWORK) to USE(CFNETWORK).
- WebCoreSupport/WebFrameNetworkingContext.h: Add USE(CFNETWORK) guard.
- 10:42 AM Changeset in webkit [151741] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
FTL: arm build is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=117800
Unreviewed build fixes.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler): Merge of r147941
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod): Moved variable declaration back inside #ifdef where used.
- 10:40 AM Changeset in webkit [151740] by
-
- 18 edits1 copy9 adds in trunk/Source/WebCore
Implement WebIDL implements
https://bugs.webkit.org/show_bug.cgi?id=117785
Reviewed by Kentaro Hara.
Add support for Web IDL 'implements' statements to the bindings generator:
http://www.w3.org/TR/WebIDL/#dfn-implements-statement
Introduce ChildNode IDL interface and have Element, DocumentType and
CharacterData implement it, to match the specification:
http://dom.spec.whatwg.org/#childnode
There is no change in behavior, merely refactoring to match the
specification by leveraging support for Web IDL implements statements.
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- bindings/scripts/generate-bindings.pl:
- bindings/scripts/preprocess-idls.pl:
(GeneratePartialInterface):
(getImplementersFromIDL):
- bindings/scripts/test/CPP/WebDOMTestImplements.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestImplements.h: Added.
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
(WebDOMTestInterface::implementsStr1):
(WebDOMTestInterface::implementsStr2):
(WebDOMTestInterface::setImplementsStr2):
(WebDOMTestInterface::implementsNode):
(WebDOMTestInterface::setImplementsNode):
(WebDOMTestInterface::implementsMethod1):
(WebDOMTestInterface::implementsMethod4):
- bindings/scripts/test/CPP/WebDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestImplements.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestImplements.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_implements_method1):
(webkit_dom_test_interface_implements_method2):
(webkit_dom_test_interface_implements_method4):
(webkit_dom_test_interface_get_implements_str1):
(webkit_dom_test_interface_get_implements_str2):
(webkit_dom_test_interface_set_implements_str2):
(webkit_dom_test_interface_get_implements_node):
(webkit_dom_test_interface_set_implements_node):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/JS/JSTestImplements.cpp: Added.
- bindings/scripts/test/JS/JSTestImplements.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3):
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT1):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT2):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestImplements.cpp: Added.
- bindings/scripts/test/ObjC/DOMTestImplements.h: Added.
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface implementsStr1]):
(-[DOMTestInterface implementsStr2]):
(-[DOMTestInterface setImplementsStr2:]):
(-[DOMTestInterface implementsStr3]):
(-[DOMTestInterface setImplementsStr3:]):
(-[DOMTestInterface implementsNode]):
(-[DOMTestInterface setImplementsNode:]):
(-[DOMTestInterface implementsMethod1]):
(-[DOMTestInterface implementsMethod2:objArg:]):
(-[DOMTestInterface implementsMethod3]):
(-[DOMTestInterface implementsMethod4]):
- bindings/scripts/test/TestImplements.idl: Added.
- dom/CharacterData.idl:
- dom/ChildNode.idl: Copied from Source/WebCore/dom/DocumentType.idl.
- dom/DocumentType.idl:
- dom/Element.idl:
- 10:33 AM Changeset in webkit [151739] by
-
- 2 edits in trunk/Source/WTF
BUILD FIX (r151663): Fix build for iOS WebKit
- wtf/text/AtomicStringTable.cpp: Include MainThread.h.
(WTF::AtomicStringTable::create): Use AtomicStringTable::destroy
instead of non-existent destroyAtomicStringTable function.
- 10:29 AM Changeset in webkit [151738] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Copying array or object output does not contain values
https://bugs.webkit.org/show_bug.cgi?id=117669
ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
and, additionally, only use that prefix if we're copying more than a single message since it's
the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
a log level always print the level and when saving the console log using Cmd+S, all messages
contain their prefix as well.
Reviewed by Timothy Hatcher.
- UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toClipboardString):
Handle the new isPrefixOptional argument.
- UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
the prefix isn't printed out in situations when it may not.
- UserInterface/ConsoleMessageImpl.js:
Set "enforcesClipboardPrefixString" to true since we always want to log the log level
prefix in all situations.
(WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
Implement this new getter to return our clipboard string such that subclasses may
customize it.
(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
to only log the prefix if necessary.
- UserInterface/LogContentView.js:
(WebInspector.LogContentView.prototype._formatMessagesAsData):
Make the logging of prefix optional when we have a single message selected and we're
not saving via Cmd+S.
- 10:20 AM Changeset in webkit [151737] by
-
- 15 edits2 adds in trunk
Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children
https://bugs.webkit.org/show_bug.cgi?id=114879
Source/WebCore:
Reviewed by David Hyatt.
Per http://www.w3.org/TR/CSS21/visudet.html#Computing_widths_and_margins when width is auto then floating non-replaced,
absolute non-replaced, and inline-block non-replaced elements should use shrink-to-fit width. This trumps any no-wrap property
on the element so if we are shrinking to fit ensure our minimum width respects all possible line breaks.
Test: fast/block/shrink-to-fit-width-container-with-floating-children.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
LayoutTests:
Reviewed by David Hyatt.
- fast/block/shrink-to-fit-width-container-with-floating-children-expected.txt: Added.
- fast/block/shrink-to-fit-width-container-with-floating-children.html: Added.
- platform/qt/fast/css/word-space-extra-expected.txt:
- platform/qt/fast/replaced/width100percent-image-expected.txt:
- platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
- platform/qt/fast/replaced/width100percent-textfield-expected.txt:
- platform/qt/tables/mozilla/bugs/bug57828-expected.txt:
- 10:20 AM WebKitGtkLayoutTests edited by
- (diff)
- 10:19 AM WebKitGTK/Chroot created by
- Initial editing
- 10:12 AM Changeset in webkit [151736] by
-
- 14 edits7 deletes in trunk/Source/WebCore
Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
https://bugs.webkit.org/show_bug.cgi?id=117795
Reviewed by Kentaro Hara.
Fix the JS bindings generator so that it stops including JS*Custom.h header whenever
[CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used. We don't
really need this custom header and this forces the developer to create dummy custom
headers so that it builds.
If the developer really needs such custom header to be included, he can still use
[JSCustomHeader] IDL extended attribute to do so.
This patch also remove the dummy custom headers that were created but are no longer
required to build.
No new tests, no behavior change. Already covered by the following bindings test:
TestInterface.idl
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMStringMapCustom.h: Removed.
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLAppletElementCustom.h: Removed.
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.h: Removed.
- bindings/js/JSHTMLObjectElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.h: Removed.
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSHistoryCustom.h: Removed.
- bindings/js/JSLocationCustom.cpp:
- bindings/js/JSLocationCustom.h: Removed.
- bindings/js/JSStorageCustom.cpp:
- bindings/js/JSStorageCustom.h: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- 10:11 AM WebKitGTK/StartHacking edited by
- Added other section (diff)
- 9:27 AM WebKitGTK/StartHacking edited by
- Added contributin patches section (diff)
- 9:16 AM WebKitGTK/StartHacking edited by
- Added compilation issues section (diff)
- 9:09 AM WebKitGTK/StartHacking edited by
- Added continuous integration section (diff)
- 9:08 AM WebKitGTK/StartHacking edited by
- Added continuous integration section (diff)
- 9:01 AM WebKitGTK/Debugging edited by
- (diff)
- 9:00 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 8:55 AM WebKitGTK/Debugging created by
- Initial editing
- 8:47 AM WebKitGTK/StartHacking edited by
- Added debugging section (diff)
- 8:45 AM WebKitGTK/StartHacking edited by
- Added rebuild and testing (diff)
- 8:30 AM Changeset in webkit [151735] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=117799
https://jira.bbqnx.net/browse/BRWSR-11712
JIRA413289
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-19
Reviewed by Carlos Garcia Campos.
Discovered by Xuefei Ren.
If, in rare cases, renderContents() returns false,
the for() loop in render() will take a tile buffer from
the surface pool but due to aborting the iteration early,
won't put it into the new tile map. In order to prevent
losing the buffer, we need to put it back into the
surface pool before continuing.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
- 8:23 AM Changeset in webkit [151734] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=117793
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-19
Reviewed by Rob Buis.
JIRA 388741
Fixes a crash in several layout tests due to an assert when
creating an ImageBuffer with an empty size.
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer): Return early if the given
size is empty.
- 8:03 AM Changeset in webkit [151733] by
-
- 4 edits in trunk
[GStreamer] [texmap] the bytesPerLine is wrong when updating the texture
https://bugs.webkit.org/show_bug.cgi?id=117551
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.
Source/WebCore:
The bytesPerLine (or stride) is wrong when updating the texture
content. This is because the naturalSize() is not updated to the
current buffer. This patch extracts the current value of the size and
the stride.
No tests required.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
LayoutTests:
- platform/gtk-wk2/TestExpectations:
enabled media/video-display-aspect-ratio.html
- 7:23 AM Changeset in webkit [151732] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed rebaselining after 151705.
- platform/qt/http/tests/cache/partitioned-cache-expected.txt: Added.
- platform/qt/http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
- 6:22 AM Changeset in webkit [151731] by
-
- 2 edits in trunk/Source/WebCore
Adjust internal size on gstreamer source element when receiving data if necessary
https://bugs.webkit.org/show_bug.cgi?id=116534
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-06-19
Reviewed by Philippe Normand.
If the size received in didReceiveResponse is smaller than the actual size of the received data
update the internal size and the appsrc size to the proper value.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveData):
- 6:10 AM Changeset in webkit [151730] by
-
- 2 edits in trunk/LayoutTests
[Qt] TestExpectation sorting on Qt WK2.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-19
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/TestExpectations:
- 5:36 AM WebKitGTK/StartHacking edited by
- Added compiling section (diff)
- 5:12 AM WebKitGTK/SpeedUpBuild edited by
- (diff)
- 5:11 AM WebKitGTK/SpeedUpBuild edited by
- Indenting (diff)
- 5:05 AM WebKitGTK/SpeedUpBuild created by
- Initial editing
- 4:49 AM WebKitGTK/StartHacking edited by
- Added initial compiling section (diff)
- 4:29 AM WebKitGTK/StartHacking created by
- 3:53 AM Changeset in webkit [151729] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Implement unit test callback: onSettingChange.
https://bugs.webkit.org/show_bug.cgi?id=117728
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-06-19
Reviewed by Christophe Dumez.
It is finally possible to implement missing unit tests as WebKit2-EFL
has delivered sub menu (r150254).
Add two unit tests for checking onSettingChange callback behaviour,
when toggling "Check Spelling While Typing" in context menu.
Changed types inside callbacksExecutionStats struct from bit field to bool,
because casting from bit field to &bool is invalid (in using waitUntilTrue method).
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(resetCallbacksExecutionStats):
(onSettingChange):
(findContextMenuItem):
Get determined option from context menu.
(checkCorrectnessOfSpellingItems):
Changed the name of onContextMenuShow method to be consistent with new methods.
(toogleCheckSpellingWhileTyping):
Select "Check Spelling While Typing" in context menu to test whether
onSettingChange is called.
- 3:30 AM WebKitGTK edited by
- Added newbies section (diff)
- 2:14 AM Changeset in webkit [151728] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Potential race condition when getting the video sink caps.
https://bugs.webkit.org/show_bug.cgi?id=117736
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.
There is a potential race condition with the pad setting caps, as the
buffer and the caps won't match when renegotiation happens, and might
cause a crash.
This patch keeps an instance of the current caps in the video sink,
and it is accessible through a getter method. Hence the player can ask
for the current caps without running into a race condition.
No new tests. No change in behaviour.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkGetProperty):
(webkitVideoSinkStop):
(webkitVideoSinkSetCaps):
(webkit_video_sink_class_init):
- 1:07 AM Changeset in webkit [151727] by
-
- 11 edits2 moves3 adds in trunk
Vibration can be canceled even if page visibility status is hidden
https://bugs.webkit.org/show_bug.cgi?id=117333
Reviewed by Gyuyoung Kim.
Source/WebCore:
vibration can be canceled in the onvisibilitychange listener even if page visibility is changed to hidden status.
Therefore cancelVibration needs to work when page visibility is hidden.
Tests: vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- Modules/vibration/Vibration.h:
(WebCore::Vibration::isVibrating):
- testing/Internals.cpp:
(WebCore::Internals::isVibrating):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add a test case for cancel vibration after page visibility is changed to hidden status.
In addition, move navigator-vibration.html to vibration directory.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden-expected.txt: Added.
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html: Added.
- vibration/navigator-vibration-expected.txt: Renamed from LayoutTests/fast/dom/navigator-vibration-expected.txt.
- vibration/navigator-vibration.html: Renamed from LayoutTests/fast/dom/navigator-vibration.html.
- 12:33 AM Changeset in webkit [151726] by
-
- 4 edits in trunk/Source/WebKit2
[GTK][SOUP] Migrate SoupRequestManager to GTask
https://bugs.webkit.org/show_bug.cgi?id=117157
Reviewed by Gustavo Noronha Silva.
GSimpleAsyncResult has been deprecated in favour of GTask.
- WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::WebSoupRequestManager::didHandleURIRequest):
(WebKit::WebSoupRequestManager::didFailURIRequest):
(WebKit::WebSoupRequestManager::send):
(WebKit::WebSoupRequestManager::finish):
- WebProcess/soup/WebSoupRequestManager.h:
- 12:24 AM Changeset in webkit [151725] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitFaviconDatabase to GTask
https://bugs.webkit.org/show_bug.cgi?id=117156
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):
(webkit_favicon_database_get_favicon_finish):
- 12:19 AM Changeset in webkit [151724] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitWebView to GTask
https://bugs.webkit.org/show_bug.cgi?id=117154
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebView.cpp:
(didValidateCommand):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_can_execute_editing_command_finish):
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_finish):
(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):
(fileReplaceContentsCallback):
(getContentsAsMHTMLDataCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):
(webkit_web_view_save_to_file_finish):
(webKitWebViewDidReceiveSnapshot):
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish):
- 12:13 AM Changeset in webkit [151723] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitCookieManager to GTask
https://bugs.webkit.org/show_bug.cgi?id=117150
Reviewed by Gustavo Noronha Silva.
Don't use helper structs for async data since the cancellable is
now accessible from the GTask.
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerGetAcceptPolicyCallback):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_get_accept_policy_finish):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_get_domains_with_cookies_finish):
Jun 18, 2013:
- 10:10 PM Changeset in webkit [151722] by
-
- 5 edits in trunk/Source
Versioning.
- 9:37 PM Changeset in webkit [151721] by
-
- 2 edits4 adds in trunk/LayoutTests
Unreviewed, EFL gardening. Added new baselines for some of editing/delete
tests after system upgrade.
- platform/efl/TestExpectations:
- platform/efl/editing/deleting/smart-delete-003-expected.png: Added.
- platform/efl/editing/deleting/smart-delete-003-expected.txt: Added.
- platform/efl/editing/deleting/smart-delete-004-expected.png: Added.
- platform/efl/editing/deleting/smart-delete-004-expected.txt: Added.
- 9:31 PM Changeset in webkit [151720] by
-
- 11 edits1 add in tags/Safari-537.46
Merge <rdar://problem/14171207>
- 9:11 PM Changeset in webkit [151719] by
-
- 3 edits2 adds in trunk
Input type range slider is not updated when min or max are changed
https://bugs.webkit.org/show_bug.cgi?id=117778
Reviewed by Kent Tamura.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.
Test: fast/forms/range/range-change-min-max.html
- html/RangeInputType.cpp:
(WebCore::RangeInputType::minOrMaxAttributeChanged):
LayoutTests:
- fast/forms/range/range-change-min-max-expected.html: Added.
- fast/forms/range/range-change-min-max.html: Added.
- 8:37 PM Changeset in webkit [151718] by
-
- 1 copy in tags/Safari-537.46
New Tag.
- 8:31 PM Changeset in webkit [151717] by
-
- 5 edits in trunk/Source/WebCore
Remove two superfluous overrides of supportsFocus
https://bugs.webkit.org/show_bug.cgi?id=117770
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/4228964a63e3a889a40efce0d01866629fdcd9b9.
- html/HTMLOptGroupElement.cpp:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp:
- html/HTMLOptionElement.h:
- 7:02 PM Changeset in webkit [151716] by
-
- 2 edits in trunk/LayoutTests
[WK2] Media elements never fail to load
https://bugs.webkit.org/show_bug.cgi?id=117767
Mark the media tests as failing for now.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18
- platform/mac-wk2/TestExpectations:
- 6:51 PM Changeset in webkit [151715] by
-
- 2 edits in trunk/Source/WebCore
Improve style of null checks in FrameView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=117681
Reviewed by Sam Weinig.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect): Used nested if statements and local variables
to tighten this code up a little.
- 6:45 PM Changeset in webkit [151714] by
-
- 19 edits in trunk/Source/WebCore
Move IDL extended attributes to their correct location
https://bugs.webkit.org/show_bug.cgi?id=117732
Reviewed by Kentaro Hara.
Move IDL extended attributes to their correct location according to the
latest Web IDL specification. We used to be inconsistent in the positioning
of the extended attributes. This simplifies a lot the code of the IDL parser
and makes our IDL files more standard.
Based on Blink r148345 by Kentaro Hara <haraken@chromium.org>.
No new tests, no behavior change.
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/notifications/Notification.idl:
- Modules/speech/SpeechSynthesisVoice.idl:
- bindings/scripts/IDLParser.pm:
(parseDefinitions):
(parseInterfaceMembers):
(parseInterfaceMember):
(parseDictionaryMembers):
(parseAttributeOrOperationOrIterator):
(parseAttribute):
- css/CSSFontFaceLoadEvent.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- html/HTMLBodyElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFrameSetElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLSourceElement.idl:
- page/DOMWindow.idl:
- svg/SVGElementInstance.idl:
- svg/SVGScriptElement.idl:
- testing/TypeConversions.idl:
- 6:32 PM Changeset in webkit [151713] by
-
- 2 edits in trunk/Source/WebCore
Let the script to update the Localizable.strings file do the reordering it wants to do.
Rubber-stamped by Anders Carlsson.
- English.lproj/Localizable.strings:
- 6:15 PM Changeset in webkit [151712] by
-
- 3 edits in trunk/Source/WebCore
[Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
files in Visual Studio.
- WebCore.vcxproj/WebCore.vcxproj: Add missing files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 6:12 PM Changeset in webkit [151711] by
-
- 2 edits1 add in trunk/Tools
Working on coverage script, added xml to json data extraction script.
https://bugs.webkit.org/show_bug.cgi?id=117648
This is part of a new test code coverage analysis tool. This compiles WebKit to generate
coverage data, runs the tests, and collects all of the data in json format.
Reviewed by Stephanie Lewis.
- Scripts/generate-coverage-data:
(parseGcovrOutput):
(getFileHitsAndBranches):
(addLineCounts):
(createResultName):
- Scripts/webkitpy/tool/gcovr: Added.
- 5:51 PM Changeset in webkit [151710] by
-
- 3 edits in trunk/Tools
Unreviewed build fix after r151699.
- TestWebKitAPI/CMakeLists.txt:
- WebKitTestRunner/CMakeLists.txt:
Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
- 5:36 PM Changeset in webkit [151709] by
-
- 3 edits3 adds in trunk
Going to google.com/trends causes a crash
https://bugs.webkit.org/show_bug.cgi?id=117602
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
When handling op_throw, etc we need to flush the variables and arguments
for the entire inline stack, not just the top frame.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushAllArgumentsAndCapturedVariablesInInlineStack):
(JSC::DFG::ByteCodeParser::parseBlock):
LayoutTests:
Make sure we correctly initialise the appropriate argument registers,
and make sure we perform the tearoff correctly.
- fast/js/inline-arguments-tear-off-expected.txt: Added.
- fast/js/inline-arguments-tear-off.html: Added.
- fast/js/script-tests/inline-arguments-tear-off.js: Added.
(g):
(f):
(doStuff):
- 5:12 PM Changeset in webkit [151708] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix a typo that may be causing some test failures.
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
- 4:39 PM Changeset in webkit [151707] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r151513.
http://trac.webkit.org/changeset/151513
https://bugs.webkit.org/show_bug.cgi?id=117763
It causes assertions in debug (Requested by benjaminp on
#webkit).
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
- 4:16 PM Changeset in webkit [151706] by
-
- 145 edits1 move in trunk
Replace tools32 folder with tools and update WebKit Windows solution accordingly.
<rdar://problem/14118143>.
Rubberstamped by Brent Fulgham.
- 3:50 PM Changeset in webkit [151705] by
-
- 3 edits in trunk/LayoutTests
Rebaseline after system update
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18
- http/tests/cache/partitioned-cache-expected.txt:
- http/tests/cache/partitioned-cache-iframe-expected.txt:
System fix, the tests pass.
- 3:44 PM Changeset in webkit [151704] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
https://bugs.webkit.org/show_bug.cgi?id=117755
Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
and Rect prototypes, so they get the expected methods. We then need to
handle the ZERO_RECT case better, and not attempt to draw a background
in a canvas with a 0 size, which would produce an exception.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-18
Reviewed by Timothy Hatcher.
- UserInterface/Geometry.js:
- UserInterface/Popover.js:
(WebInspector.Popover.prototype._update):
- 3:31 PM Changeset in webkit [151703] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRunsAndFloatsInRange function
https://bugs.webkit.org/show_bug.cgi?id=117757
Reviewed by David Hyatt.
We don't need keep lineOverflowsFromShapeInside boolean in RenderBlock::layoutRunsAndFloatsInRange and in its
helpers because it's easy to decide whether we are in an shape content overflow state or not, so I got rid of
lineOverflowsFromShapeInside's occurences and updated the affected functions.
Covered by existing overflow tests in fast/exclusions/shape-inside and fast/regions/shape-inside.
- rendering/RenderBlock.h: Update helper's definition.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::pushShapeContentOverflowBelowTheContentBox): Add condition when overflow is already positioned.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Remove lineOverflowsFromShapeInside.
- 3:03 PM Changeset in webkit [151702] by
-
- 3 edits3 adds in trunk
widthMediaFeatureEval ends up with null FrameView during iframe unload.
https://bugs.webkit.org/show_bug.cgi?id=117754
Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-18
Reviewed by Geoffrey Garen.
Ensure that MediaQueryEvaluator checks against NULL FrameView.
While frames are being unloaded, the Frame object does not necessarily have valid
FrameView anymore. Layout on the main frame can end up querying media values on such child
frames, while detaching.
Source/WebCore:
Test: fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html
- css/MediaQueryEvaluator.cpp:
(WebCore::orientationMediaFeatureEval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::MediaQueryEvaluator::eval):
LayoutTests:
- fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery-expected.txt: Added.
- fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html: Added.
- fast/frames/resources/child-iframe-forces-parent-layout-on-unload.html: Added.
- 3:01 PM Changeset in webkit [151701] by
-
- 15 edits in trunk/Source/WebKit2
Make it possible to set a minimum height for auto-layout
https://bugs.webkit.org/show_bug.cgi?id=117758
<rdar://problem/12849080>
Reviewed by Tim Horton.
Change a bunch of minimumLayoutWidth declarations to minimumLayoutSize and add a new minimumLayoutSize property.
If minimumLayoutSize.height is greater than zero, use it to set the minimum layout size on the frame view.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setIntrinsicContentSize:]):
(-[WKView minimumLayoutWidth]):
(-[WKView setMinimumLayoutWidth:]):
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]):
(-[WKView minimumSizeForAutoLayout]):
(-[WKView setMinimumSizeForAutoLayout:]):
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMinimumLayoutSize):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::minimumLayoutSize):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMinimumLayoutSize):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::minimumLayoutSize):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
- 2:53 PM Changeset in webkit [151700] by
-
- 2 edits in trunk/Source/WebKit2
sandbox violation when Flash runs for the first time
https://bugs.webkit.org/show_bug.cgi?id=117753
<rdar://problem/14165466>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-18
Reviewed by Alexey Proskuryakov.
Allow flash to try and change the ownership of directories it has just created.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- 2:39 PM Changeset in webkit [151699] by
-
- 11 edits1 add in trunk/Source
Expose a getMediaType method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-18
Reviewed by Brady Eidson.
Source/WebCore:
- WebCore.exp.in: Updated to add a symbol for
HitTestResult::mediaIsVideo method
and alphabetize the list of exposed methods.
Source/WebKit2:
- GNUmakefile.list.am:
- Target.pri:
Updated to include the added header file InjectedBundleHitTestResultMediaType.h
- UIProcess/API/C/WKAPICast.h:
(WebKit::toBundleHitTestResultMediaType):
(WebKit::toAPI):
Added methods to convert between BundleHitTestResultMediaType
and WKBundleHitTestResultMediaType.
- WebKit2.xcodeproj/project.pbxproj: Updated to include
InjectedBundleHitTestResultMediaType.h in the WebKit2 project.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultGetMediaType): Exposes the method getMediaType and
hooks into InjectedBundleHitTestResult::getMediaType.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::getMediaType): Added to return
what type, if any, a media element is.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResultMediaType.h: Added
to contain new BundleHitTestResultMediaType enums.
- 2:34 PM Changeset in webkit [151698] by
-
- 2 edits in trunk/Source/WebCore
Remove unused bool argument from ReplacementFragment's constructor
https://bugs.webkit.org/show_bug.cgi?id=117752
Reviewed by Antti Koivisto.
Merge https://chromium.googlesource.com/chromium/blink/+/265586d9f154a9dff657511d09926429b8e1b53d.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplaceSelectionCommand::doApply):
- 2:29 PM Changeset in webkit [151697] by
-
- 13 edits in trunk
Not all subtitle tracks are SDH
https://bugs.webkit.org/show_bug.cgi?id=117738
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing tests updated.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::isSDH): New.
- html/track/InbandTextTrack.h: Add isSDH override.
- html/track/TextTrack.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.
- platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::isSDH): New.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes
spoken dialog for accessibility" and "describes music and sound for accessibility"
characteristics.
LayoutTests:
- media/video-controls-captions-trackmenu-localized.html:
- media/video-controls-captions-trackmenu-sorted.html:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- 2:25 PM Changeset in webkit [151696] by
-
- 2 edits in trunk/Source/WebCore
Simplify FormKeyGenerator::willDeleteForm
https://bugs.webkit.org/show_bug.cgi?id=117751
Reviewed by Antti Koivisto.
Merge https://chromium.googlesource.com/chromium/blink/+/c6399efb9da863eb1d1fc98b17ef925998b985ac
- html/FormController.cpp:
(WebCore::FormKeyGenerator::willDeleteForm):
- 2:25 PM Changeset in webkit [151695] by
-
- 3 edits1 add in trunk
REGRESSION(r147602): Search text field doesn't render selection when it has some :focus rules
https://bugs.webkit.org/show_bug.cgi?id=117747
Reviewed by Kent Tamura.
.:
- ManualTests/search-select-all-with-focus-style.html: Added.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/7ff656c8239ce3b125246abcc8b149a603fcff28
r147612 added setNeedsLayout(true, MarkOnlyThis) for
TextControlInnerTextElement renderer. It's ok for input[type=text]
because RenderTextControlSingleLine also has needsLayout flag, and it
has only the inner text renderer as a child.
As for input[type=search], it doesn't work. Renderer structure for
input[type=search] is:
RenderTextControlSingleLine
└Renderer for TextControlInnerContainer
└Renderer for TextControlInnerElement
└Renderer for TextControlInnerTextElement
After r147612, there is a case that only RenderTextControlSingleLine
and TextControlInnerTextElement renderer have needsLayout flag, and
others don't. It won't trigger layout for
TextControlInnerTextElement renderer.
We should set needsLayout flags of TextControlInnerContainer renderer
and TextControlInnerElement renderer by MarkContainingBlockChain.
Manual Tests: search-select-all-with-focus-style.html
(I tried but couldn't make a test that works in DRT)
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
- 1:40 PM Changeset in webkit [151694] by
-
- 2 edits in trunk/Source/WebCore
Attempted build fix for non-Mac.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::nonSyntheticItalicFontData):
- 1:28 PM Changeset in webkit [151693] by
-
- 10 edits5 adds in trunk
Synthesized vertical italics on rotated glyphs are transformed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117726
Reviewed by Enrica Casucci.
Source/WebCore:
If a font does not have italic glyphs, and is in a vertical flow, then
the synthesis of italics was skewing in the wrong direction. While here,
ensure that no CJK text will get italics in vertical layout.
This is a topic under discussion in the CSS Working Group. The resolution
at the June 2013 face-to-face was that:
- italics in Japanese (and Chinese) text are rare in vertical layout
- most people wanted Latin text to italicize in the direction of the line flow
The final behaviour was left undefined, but we consider the change here
to be sufficient for now. In all cases, the best solution is to avoid
synthesized italics by specifying a font that includes such forms.
Tests: fast/text/international/synthesized-italic-vertical-latin.html
fast/text/international/synthesized-italic-vertical.html
- platform/graphics/FontGlyphs.cpp:
(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): New function
that makes a new glyph data pair that is marked as NOT using a synthesized italic.
(WebCore::FontGlyphs::glyphDataAndPageForCharacter): If this is a CJK character and
has a synthesized oblique, then run it through the function above to make a new glyph data pair.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::nonSyntheticItalicFontData): Creates/returns a new SimpleFontData that will
not synthesize italics.
- platform/graphics/SimpleFontData.h: New method nonSyntheticItalicFontData.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): This is the actual bug fix. If you are in a vertical flow, the
skew direction should be downwards, not leftwards.
LayoutTests:
Two new tests. One ensures that CJK characters do not get italics
when vertical. The other ensures that Latin text does get italics in
a font that is not synthesized, but unfortunately has to be a pixel test.
The latter is skipped on non-Mac since they don't support
synthesized obliques in FontPlatformData.
- fast/text/international/synthesized-italic-vertical-expected.html: Added.
- fast/text/international/synthesized-italic-vertical-latin.html: Added.
- fast/text/international/synthesized-italic-vertical.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 1:28 PM Changeset in webkit [151692] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed. Build fix for Mac and Win
- 1:14 PM Changeset in webkit [151691] by
-
- 3 edits6 adds in trunk/Source
Re-implement WebFrameNetworkingContext.
<rdar://problem/13174821>.
Reviewed by Alexey Proskuryakov.
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h: Added.
(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: Added.
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::blockedError):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebCoreSupport/WebFrameNetworkingContext.h: Added.
(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebFrameNetworkingContext::userAgent):
- WebCoreSupport/WebFrameNetworkingContext.mm: Added.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::sourceApplicationAuditData):
(WebFrameNetworkingContext::blockedError):
(WebFrameNetworkingContext::storageSession):
- 1:05 PM Changeset in webkit [151690] by
-
- 3 edits6 deletes in trunk/Source
<rdar://problem/13174821> Remove files with an incorrect license.
Rubber-stamped by Maciej Stachowiak.
This will break the build, stay tuned for a fix coming soon.
- 12:58 PM Changeset in webkit [151689] by
-
- 2 edits in trunk/Source/WTF
PackedIntVector: check template arguments at compile time
https://bugs.webkit.org/show_bug.cgi?id=117737
Use 'COMPILE_ASSERT' instead of 'ASSERT' in PackedIntVector class
constructor.
Reviewed by Sam Weinig.
- wtf/PackedIntVector.h:
(WTF::PackedIntVector::PackedIntVector):
- 12:38 PM Changeset in webkit [151688] by
-
- 3 edits in trunk/Source/WebInspectorUI
If the tree outline is processing a selection currently, then don't change the selection.
This is needed to allow breakpoints tree elements to be selected without jumping back to
selecting the resource tree element.
https://bugs.webkit.org/show_bug.cgi?id=117746
Reviewed by Joseph Pecoraro.
- UserInterface/Main.js:
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
- UserInterface/TreeOutline.js:
(TreeElement.prototype.select):
- 11:49 AM Changeset in webkit [151687] by
-
- 14 edits1 add in trunk/Source/WebInspectorUI
Update breakpoints to match Xcode 5.
This updates the breakpoint images, line colors, and moves breakpoints toggle button
to the Debugger sidebar navigation bar.
https://bugs.webkit.org/show_bug.cgi?id=117723
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
- UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):
- UserInterface/Images/Breakpoint.png: Updated.
- UserInterface/Images/Breakpoints.pdf: Added.
- UserInterface/Images/Breakpoint@2x.png: Updated.
- UserInterface/Images/BreakpointButton.pdf: Updated.
- UserInterface/Images/BreakpointInactive.png: Updated.
- UserInterface/Images/BreakpointInactive@2x.png: Updated.
- UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
- UserInterface/Images/InstructionPointer.png: Updated.
- UserInterface/Images/InstructionPointer@2x.png: Updated.
- UserInterface/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
(.source-code.text-editor > .CodeMirror .warning): Ditto.
- UserInterface/TextEditor.css:
(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
(.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
(.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.
- 10:51 AM Changeset in webkit [151686] by
-
- 2 edits in trunk/Websites/webkit.org
The page title of technical-articles.html is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=117727
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-18
Reviewed by Ryosuke Niwa.
Changed the page title of technical-articles.html to "WebKit Technical Articles".
- coding/technical-articles.html:
- 10:38 AM Changeset in webkit [151685] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r151549.
http://trac.webkit.org/changeset/151549
https://bugs.webkit.org/show_bug.cgi?id=117741
broke selection in the web inspector source after scrolling
(Requested by smfr on #webkit).
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderLayerModelObject.cpp:
- rendering/RenderLayerModelObject.h:
LayoutTests:
- fast/repaint/change-overflow-and-display-of-relative-expected.txt: Removed.
- fast/repaint/change-overflow-and-display-of-relative.html: Removed.
- 9:09 AM BuildingGtk edited by
- Add link to WebKitGTK+ main page in trac.webkit.org (diff)
- 8:16 AM Changeset in webkit [151684] by
-
- 3 edits2 adds in trunk
<video> element delays document load event for ~ 3 seconds
https://bugs.webkit.org/show_bug.cgi?id=90272
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-18
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-preload-no-delay-loadevent.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
No need to delay document load event here when preload="none"
LayoutTests:
- media/media-preload-no-delay-loadevent-expected.txt: Added.
- media/media-preload-no-delay-loadevent.html: Added.
- 6:16 AM Changeset in webkit [151683] by
-
- 1 copy in releases/WebKitGTK/webkit-2.1.2
Tagging the WebKitGTK+ 2.1.2 release
- 6:04 AM Changeset in webkit [151682] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
https://bugs.webkit.org/show_bug.cgi?id=117546
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-18
Reviewed by Xan Lopez.
According to the WebKit IDL spec the modifier ObjCPolymorphic only
applies to the Objective-C bindings generator
- bindings/scripts/CodeGeneratorGObject.pm:
(IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
concatening a series of 'or' conditionals.
- 5:24 AM Changeset in webkit [151681] by
-
- 2 edits in trunk/Source/WebCore
Fix after r151673
https://bugs.webkit.org/show_bug.cgi?id=116042
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.
Removed a spurious semicolon in the video sink caps definition.
No new tests, no behavior change.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
- 4:23 AM Changeset in webkit [151680] by
-
- 3 edits in trunk/Source/WebCore
[WebSpeech] Speech Recognition requires convertValue support in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=117731
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-18
Reviewed by Christophe Dumez.
Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
resolves the issue.
No new tests. No change in behaviour.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
- 3:30 AM Changeset in webkit [151679] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.1.2 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.1.2.
- 2:35 AM Changeset in webkit [151678] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaseline and skipping some tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-18
- platform/qt-5.0-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.
- platform/qt/TestExpectations:
- platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
- 2:13 AM Changeset in webkit [151677] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] only notify download client when download error
https://bugs.webkit.org/show_bug.cgi?id=117687
Reviewed by Rob Buis.
When met network error in downloading, we notify the error to download
client through download stream, we shouldn't notify page client the error.
RIM JIRA 419985
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::shouldNotifyClientFailed):
- 1:35 AM Changeset in webkit [151676] by
-
- 2 edits in trunk/Source/WebCore
Shader compiler not properly configured for GLES on cairo based ports
https://bugs.webkit.org/show_bug.cgi?id=117705
Reviewed by Martin Robinson.
Configure the shader compiler with SH_ESSL_OUTPUT for GLESv2
compliant platforms, and with SH_GLSL_OUTPUT otherwise.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 1:29 AM Changeset in webkit [151675] by
-
- 2 edits in trunk/Source/WebCore
touching any idl rebuilds all derived sources
https://bugs.webkit.org/show_bug.cgi?id=117708
Reviewed by Kentaro Hara.
Fix preprocess-idls.pl script to update the following files only
if they have changed:
DerivedSources/WebCore/supplemental_dependency.tmp
DerivedSources/WebCore/DOMWindowConstructors.idl
DerivedSources/WebCore/WorkerContextConstructors.idl
This avoids triggering uselessly bindings generation for all IDL
files whenever an IDL file is touched.
No new tests, no behavior change.
- bindings/scripts/preprocess-idls.pl:
(WriteFileIfChanged):
(GeneratePartialInterface):
- 1:18 AM Changeset in webkit [151674] by
-
- 6 edits in trunk
[GTK][GStreamer] Fullscreen option in video element context menu not working
https://bugs.webkit.org/show_bug.cgi?id=105191
.:
Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.
- Source/autotools/SetupAutoconfHeader.m4: Removed the use of
fullscreen native media controls.
LayoutTests:
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.
- platform/gtk-wk1/TestExpectations:
fullscreen/video-controls-drag.html does not time out anymore.
- platform/gtk-wk2/TestExpectations:
media/video-display-aspect-ratio.html crashes sometimes.
- platform/gtk/TestExpectations:
media/video-playing-and-pause.html was already flaky.
- 1:09 AM Changeset in webkit [151673] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] [texmap] upload a video buffer into the video texture
https://bugs.webkit.org/show_bug.cgi?id=116042
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.
This patch prepares more quickly the texture when the video frame is
already in the GPU memory.
It is done using a new buffer's metadata available in GStreamer 1.2,
and its purpose is to upload buffers into a OpenGL texture.
If the decoder provides buffers with this metadata, the buffer will be
uploaded into the texture used for the video display and it will be
rendered, avoiding a expensive mem copies. This is particularly useful
for Full HD videos, where all the processing and display will be done
in the GPU.
No new tests, covered by existing tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkProposeAllocation):
- 12:20 AM Changeset in webkit [151672] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Mark two tests that are flakily timing out as slow.
- 12:02 AM Changeset in webkit [151671] by
-
- 2 edits in trunk/Source/WTF
A static_assert() in RetainPtr.h sometimes causes the build to fail.
Wrap the first argument to a static_assert() in parentheses since it
contains a comma, which sometimes tricks the preprocessor into thinking
the macro is being passed three arguments rather than two.
Reviewed by Brian Weinstein.
- wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):
- 12:00 AM Changeset in webkit [151670] by
-
- 2 edits in trunk/Source/WTF
REGRESSION (r149184): Build errors in RefPtr.h when building with Clang, C++98 standard
https://bugs.webkit.org/show_bug.cgi?id=116352
Reviewed by Anders Carlsson.
Use the has_feature macro instead of the has_extension one when detecting what features the Clang compiler
that's being used is capable to provide. With the project moving onto using C++11 throughout its components,
there currently exist cases where C++11-specific functionality (for instance std::move) is used despite being
guarded by compiler-specific feature guards that still get enabled even when compiling in C++98 with Clang.
The problematic features are enabled because they're available as C++98 language extensions by Clang.
Using has_feature instead enables the feature guard only if the tested feature is actually standardized in
the currently used language standard.
- wtf/Compiler.h:
Jun 17, 2013:
- 11:24 PM Changeset in webkit [151669] by
-
- 2 edits in trunk/Source/WebKit2
Extra whitespace in blank line in PlatformPopupMenuData.cpp
https://bugs.webkit.org/show_bug.cgi?id=117627
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-17
Reviewed by Brent Fulgham.
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::decode):
Removing extra space
- 11:09 PM Changeset in webkit [151668] by
-
- 2 edits in trunk/Source/WebCore
[curl] Set the http response status text
https://bugs.webkit.org/show_bug.cgi?id=117307
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-17
Reviewed by Brent Fulgham.
No new tests, covered by existing ones.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback):
- 10:59 PM Changeset in webkit [151667] by
-
- 1 edit4 adds in trunk/LayoutTests
[Windows] Unreviewed AX gardening of windows-specific results.
- platform/win/accessibility/aria-combobox-expected.txt: Added.
- platform/win/aria-labelledby-on-input-expected.txt: Added.
- platform/win/aria-menubar-menuitems-expected.txt: Added.
- platform/win/aria-roles-expected.txt: Added.
- 10:59 PM Changeset in webkit [151666] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove unneeded WebCore namespace in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=117718
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-17
Reviewed by Christophe Dumez.
- WebCoreSupport/FrameLoaderClientEfl.cpp: Remove 'using namespace WebCore'.
- 6:30 PM Changeset in webkit [151665] by
-
- 5 edits3 adds in trunk
AX: Correct accessibility role when -webkit-box:display is used.
https://bugs.webkit.org/show_bug.cgi?id=117706
Reviewed by Chris Fleizach.
Source/WebCore:
accessibility/box-styled-lists.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
of the list element type, treat it as a ListItemRole accessibility role, regardless
of what specific renderer is being used.
LayoutTests:
- accessibility/box-styled-lists.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/accessibility/box-styled-lists-expected.txt: Added.
- platform/win/TestExpectations:
- platform/win/accessibility/box-styled-lists-expected.txt: Added.
- 6:19 PM Changeset in webkit [151664] by
-
- 2 edits1 add in trunk/LayoutTests
Mac rebaseline.
- fast/repaint/table-cell-collapsed-border-scroll-expected.png:
- fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- 6:08 PM Changeset in webkit [151663] by
-
- 9 edits2 adds in trunk/Source/WTF
Initialize AtomicStringTable in WTFThreadData's constructor
https://bugs.webkit.org/show_bug.cgi?id=117671
Reviewed by Geoffrey Garen.
Extracted AtomicStringTable from AtomicString.cpp into AtomicStringTable.h/cpp
and made WTFThreadDada::WTFThreadData create the atomic string table for the thread.
This eliminates a branch from stringTable() in AtomicString.cpp.
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
- wtf/text/AtomicString.cpp:
(WTF::stringTable):
- wtf/text/AtomicStringTable.cpp: Added.
(WTF::AtomicStringTable::create):
(WTF::AtomicStringTable::destroy):
- wtf/text/AtomicStringTable.h: Added.
(WTF::AtomicStringTable::table):
- 5:54 PM Changeset in webkit [151662] by
-
- 2 edits in trunk/Source/WebCore
Add some UNUSED_PARAMs to RenderBlock.cpp so that it builds properly if CSS_EXCLUSIONS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=117722.
Rubberstamped by Jon Lee.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- 5:41 PM Changeset in webkit [151661] by
-
- 9 edits in trunk/Source
PageBanners appear over HTML5 video when media element is in full screen mode
https://bugs.webkit.org/show_bug.cgi?id=117721
-and corresponding-
<rdar://problem/13686998>
Reviewed by Sam Weinig.
Source/WebCore:
Update the scrolling tree when a header/footer has been removed.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
Source/WebKit2:
When an element enters fullscreen, hide the banners. Show them again when the
element exits fullscreen.
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
Handle hiding and showing by removing or re-creating a parent layer for m_layer.
- WebProcess/WebPage/PageBanner.cpp:
(WebKit::PageBanner::hide):
(WebKit::PageBanner::showIfHidden):
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::hide):
(WebKit::PageBanner::showIfHidden):
(WebKit::PageBanner::mouseEvent):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::hidePageBanners):
(WebKit::WebPage::showPageBanners):
- WebProcess/WebPage/WebPage.h:
- 5:23 PM Changeset in webkit [151660] by
-
- 8 edits in trunk/Source
Modify Windows makefiles to copy some bin output into Program Files.
https://bugs.webkit.org/show_bug.cgi?id=117714.
<rdar://problem/14179054>
Reviewed by Brent Fulgham.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- WebKit.vcxproj/WebKit.make:
- 5:09 PM Changeset in webkit [151659] by
-
- 12 edits1 add in tags/Safari-537.45.1
Disable some feature flags and update test expectations.
<rdar://problem/14171207>.
Rubberstamped by Jon Lee.
- Configurations/FeatureDefines.xcconfig:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- platform/mac/TestExpectations:
- platform/mac/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
- platform/mac/fast/js/constructor-length-expected.txt:
- 4:50 PM Changeset in webkit [151658] by
-
- 12 edits in branches/dfgFourthTier/Source/JavaScriptCore
FTL: Add another temp register regT4 to JSInterfaceJIT
https://bugs.webkit.org/show_bug.cgi?id=117719
Reviewed by Geoffrey Garen.
Made the dedicated bucketCounterRegister to be regT4 and then used regT4 wherever
bucketCounterRegister had been used. Since it is masked whenever it is used and
we are looking for some randomness in the register anyway, we can use it without
any issues.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITCall.cpp:
(JSC::JIT::emitPutCallResult):
- jit/JITCall32_64.cpp:
(JSC::JIT::emitPutCallResult):
- jit/JITInlines.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
- jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
- 3:42 PM Changeset in webkit [151657] by
-
- 2 edits in trunk/Source/WebCore
Crash in loadPendingShaders
https://bugs.webkit.org/show_bug.cgi?id=117665
Reviewed by Dean Jackson.
Speculative fix because the crash reports do not contain a test case.
Rearrange the conditions to check m_state.hasPendingShaders() first. Additionally, check if
m_state.style() is non-null.
No new tests. We don't know how to reproduce this crash yet.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShaders):
- 2:50 PM Changeset in webkit [151656] by
-
- 19 edits in trunk/Source
REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
https://bugs.webkit.org/show_bug.cgi?id=20599
Add a "Download Video"/"Download Audio" context menu item to download media
elements.
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-17
Reviewed by Beth Dakin.
Source/WebCore:
No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.
- English.lproj/Localizable.strings: Updated to
include localizable strings for "Download Video" and "Download Audio".
- page/ContextMenuController.cpp: Updated to
include and handle a "Download Video/Audio" context menu item.
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
Updated to include localizable strings for "Download Video" and "Download Audio".
Source/WebKit/efl:
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_contextmenu.h:
Updated to include new EWK enum type for "Download Video/Audio" context menu item.
Source/WebKit2:
- Shared/API/c/WKContextMenuItemTypes.h: Updated to include
an enum type for the "Download Video/Audio" context menu item.
- Shared/API/c/WKSharedAPICast.h: Updated to associate
the enums in WebKit and WebCore that handle the "Download Video/Audio"
context menu item.
- UIProcess/API/efl/ewk_context_menu.cpp:
- UIProcess/API/efl/ewk_context_menu_item.cpp:
- UIProcess/API/efl/ewk_context_menu_item.h:
Updated to include new EWK enum type for "Download Video/Audio" context menu item.
- UIProcess/WebPageProxy.cpp: Updated to
handle the "Download Video/Audio" context menu item mouse click
and download the media item in the UI process.
- 2:27 PM Changeset in webkit [151655] by
-
- 5 edits in tags/Safari-537.45.1/Source
Versioning.
- 2:22 PM Changeset in webkit [151654] by
-
- 1 copy in tags/Safari-537.45.1
New Tag.
- 2:18 PM Changeset in webkit [151653] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics][CSS Shaders] Use forwarding header for TextureMapperPlatformCompiledProgram.h
https://bugs.webkit.org/show_bug.cgi?id=117712
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-17
Reviewed by Noam Rosenthal.
- Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.h:
- 1:23 PM Changeset in webkit [151652] by
-
- 8 edits2 copies in trunk
[CSS Shapes] Consider bottom borders when calculating the position of the overflow
https://bugs.webkit.org/show_bug.cgi?id=117663
Reviewed by Alexandru Chiculita.
When you have a shape and the content overflows from the shape we need to push the overflow below the content box,
not below the border box. We didn't consider the bottom borders of the content box, now I fixed it too and the overflow
just starts after the content box. I added a new helper function called pushShapeContentOverflowBelowTheContentBox. Now
both the shape in flow thread and the shape overflow use the same function. I added a new test and modified the existing
tests to cover all the affected cases.
Source/WebCore:
Test: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
Existing overflow tests also modified to test the behavior:
fast/exclusions/shape-inside/shape-inside-empty-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):
LayoutTests:
- fast/exclusions/shape-inside/shape-inside-empty-expected.html:
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html.
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html.
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html:
- 11:54 AM Changeset in webkit [151651] by
-
- 24 edits4 adds in branches/dfgFourthTier/Source
Rolling r151456, r151420 back in with some fixes.
https://bugs.webkit.org/show_bug.cgi?id=117390.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
New changes on top of the old patch:
- Renamed CallFrame::beginAt() to CallFrame::find(), and also provide a version that takes a CallFrame* to search for.
There are 3 types of users of the StackIterator. We need to cater
to each of these as follows:
- Users who want a stack trace
- Here we need to start iterating from vm.topCallFrame.
- To do this, create the StackIterator as follows:
StackIterator iter = vm.topCallFrame->begin();
- Users who want their caller frame
- Here we need to start iterating from the specified CallFrame*.
- To do this, create the StackIterator as follows:
StackIterator iter = callFrame->begin();
- Users who want the frame of a specific JSFunction object
- Here we need to start iterating from vm.topCallFrame and find the frame that has a callee matching the specified JSFunction*.
- To do this, create the StackIterator as follows:
StackIterator iter = exec->find(functionObj);
The previous layout test failures were due to conflation of case 1
and 2. They are now handled appropriately.
- Fixed a pre-existing layout test crash in inspector/profiler/cpu-profiler-agent-crash-on-start.html.
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- interpreter/CallFrame.cpp:
- interpreter/CallFrame.h:
(JSC::ExecState::setInlineCallFrame):
(ExecState):
- interpreter/CallFrameInlines.h:
(JSC::CallFrame::begin):
(JSC::CallFrame::find):
(JSC::CallFrame::end):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):
- interpreter/Interpreter.h:
(Interpreter):
- interpreter/StackIterator.cpp: Added.
(JSC::StackIterator::StackIterator):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::find):
(JSC::StackIterator::Frame::codeType):
(JSC::StackIterator::Frame::functionName):
(JSC::StackIterator::Frame::sourceURL):
(JSC::StackIterator::Frame::toString):
(JSC::StackIterator::Frame::bytecodeOffset):
(JSC::StackIterator::Frame::line):
(JSC::StackIterator::Frame::column):
(JSC::StackIterator::Frame::arguments):
(JSC::StackIterator::Frame::retrieveExpressionInfo):
(JSC::StackIterator::Frame::logicalFrame):
(JSC::StackIterator::Frame::logicalCallerFrame):
(JSC::jitTypeName):
(JSC::printIndents):
(JSC::printif):
(JSC::StackIterator::Frame::print):
(debugPrintCallFrame):
- interpreter/StackIterator.h: Added.
(StackIterator::Frame):
(JSC::StackIterator::Frame::create):
(JSC::StackIterator::Frame::isJSFrame):
(JSC::StackIterator::Frame::callFrame):
- interpreter/StackIteratorPrivate.h: Added.
(StackIterator):
(JSC::StackIterator::operator*):
(JSC::StackIterator::operator->):
(JSC::StackIterator::operator==):
(JSC::StackIterator::operator!=):
(JSC::StackIterator::operator++):
(JSC::StackIterator::end):
- jsc.cpp:
(functionJSCStack):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
- profiler/ProfileNode.h:
(ProfileNode):
- runtime/JSFunction.cpp:
(JSC::retrieveArguments):
(JSC::JSFunction::argumentsGetter):
(JSC::skipOverBoundFunctions):
(JSC::retrieveCallerFunction):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
- runtime/Operations.h:
Source/WebCore:
No new tests.
- ForwardingHeaders/interpreter/StackIterator.h: Copied from Source/WebCore/ForwardingHeaders/interpreter/StackIterator.h.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- 11:53 AM Changeset in webkit [151650] by
-
- 2 edits2 adds in trunk/LayoutTests
[CSS Exclusions] Implement text alignment for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=101086
Reviewed by Alexandru Chiculita.
Adding tests to make sure that shape-inside layout correctly supports
the different values of text-align.
- fast/exclusions/resources/multi-segment-polygon.js:
(createOrInsert):
- fast/exclusions/shape-inside/shape-inside-text-align-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-text-align.html: Added.
- 11:17 AM Changeset in webkit [151649] by
-
- 8 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support Switch
https://bugs.webkit.org/show_bug.cgi?id=117704
Reviewed by Oliver Hunt.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::clearImmediateSwitchJumpTables):
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildFPToSI):
(JSC::FTL::buildSwitch):
(JSC::FTL::addCase):
(FTL):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::fpToInt):
(JSC::FTL::Output::fpToInt32):
(Output):
(JSC::FTL::Output::switchInstruction):
- ftl/FTLSwitchCase.h: Added.
(FTL):
(SwitchCase):
(JSC::FTL::SwitchCase::SwitchCase):
(JSC::FTL::SwitchCase::value):
(JSC::FTL::SwitchCase::target):
- 11:06 AM Changeset in webkit [151648] by
-
- 4 edits in trunk/Source/WebKit/blackberry
Cache FatFinger Text Result.
https://bugs.webkit.org/show_bug.cgi?id=107403.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-17
Reviewed by Rob Buis.
Internally Reviewed by Genevieve Mak.
Cache the FatFinger text result for later use in TouchEventHandler.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- WebKitSupport/TouchEventHandler.h:
(BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
(TouchEventHandler):
- 11:05 AM Changeset in webkit [151647] by
-
- 4 edits6 adds in trunk
[CSS Regions] ::before and ::after pseudo-elements are not displayed for regions
https://bugs.webkit.org/show_bug.cgi?id=80163
Source/WebCore:
When the implementation of the before/after was moved to the DOM, before/after generated
content stoppped to work with css regions. The problem happens when:
- RenderRegion can not have children and when the PseudoElement::attach tries to create a renderer for the
generated content, it fails.
- RenderRegion::canHaveGeneratedChildren should not be false because regions can have generated content.
Reviewed by David Hyatt.
Tests: fast/regions/region-dynamic-after-before.html
fast/regions/region-generated-content-before-after.html
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
- rendering/RenderRegion.h:
LayoutTests:
Add two simple tests verifying if region works with before/after generated content.
Reviewed by David Hyatt.
- fast/regions/region-dynamic-after-before.html: Added.
- fast/regions/region-generated-content-before-after.html: Added.
- platform/mac/fast/regions/region-dynamic-after-before-expected.png: Added.
- platform/mac/fast/regions/region-dynamic-after-before-expected.txt: Added.
- platform/mac/fast/regions/region-generated-content-before-after-expected.png: Added.
- platform/mac/fast/regions/region-generated-content-before-after-expected.txt: Added.
- 10:53 AM Changeset in webkit [151646] by
-
- 4 edits1 copy in trunk/Source/WebKit2
<rdar://problem/13145014> Allow CoreIPC messages to transmit importance boosts
Transmitting the importance boost from the UI process to the web process is particularly
important when disabling process suppression on a web process, as it will minimize the
delays that can occur before the message instructing process suppression to be disabled
is processed by the web process.
We keep the importance boost alive for the duration of the CoreIPC message handler. We
achieve this by having an ImportanceAssertion object that owns the assertion, and whose
lifetime is tied to that of the MessageDecoder.
Reviewed by Anders Carlsson.
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::setImportanceAssertion): Associate an importance assertion
with this message.
- Platform/CoreIPC/MessageDecoder.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open): Mark our receive port as allowing importance boosts to be received.
(CoreIPC::Connection::receiveSourceEventHandler):
- Platform/CoreIPC/mac/ImportanceAssertion.h:
(CoreIPC::ImportanceAssertion::create):
(CoreIPC::ImportanceAssertion::~ImportanceAssertion): Release the assertion.
(CoreIPC::ImportanceAssertion::ImportanceAssertion): Take an assertion if a boost was present in
the Mach message.
- 10:08 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 9:40 AM Changeset in webkit [151645] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14051357> Web processes sometimes remain in a suppressed
state after their window is unoccluded.
The code in WKView that responds to occlusion notifications was incorrectly
treating the window's occlusion state as being an enum rather than the set of
flags that it is.
Reviewed by Oliver Hunt.
- UIProcess/API/mac/WKView.mm:
(-[WKView _windowDidChangeOcclusionState:]): Test only the visibility state.
(-[WKView setWindowOcclusionDetectionEnabled:]): Ditto.
- 9:22 AM Changeset in webkit [151644] by
-
- 9 edits6 adds in branches/dfgFourthTier
fourthTier: Add CFG simplification for Switch
https://bugs.webkit.org/show_bug.cgi?id=117677
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This is for completeness. It only speeds up a microbenchmark at this point.
Broadly, we want all control constructs to be known to the CFG simplifier.
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::noBlocks):
(JSC::DFG::CFGSimplificationPhase::oneBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- runtime/JSCJSValue.h:
(JSValue):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureStrictEqual):
(JSC):
Source/WTF:
Reviewed by Mark Hahnenberg.
- wtf/TriState.h:
- wtf/text/StringImpl.h:
LayoutTests:
Reviewed by Mark Hahnenberg.
- fast/js/regress/script-tests/switch-constant.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/switch.js: Added.
(foo):
(bar):
- fast/js/regress/switch-constant-expected.txt: Added.
- fast/js/regress/switch-constant.html: Added.
- fast/js/regress/switch-expected.txt: Added.
- fast/js/regress/switch.html: Added.
- 8:26 AM Changeset in webkit [151643] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Remove unmaintained GStreamer specific video code.
https://bugs.webkit.org/show_bug.cgi?id=117694
Reviewed by Philippe Normand.
No new tests, no behaviour change.
- platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setupVideoOverlay:]):
(-[WebVideoFullscreenController windowDidLoad]):
(-[WebVideoFullscreenController setMediaElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
- 7:35 AM Changeset in webkit [151642] by
-
- 35 edits6 deletes in trunk
[Qt] Remove Qt specific QTKIT flagged code.
https://bugs.webkit.org/show_bug.cgi?id=117635
Reviewed by Simon Hausmann.
Due to disabling QTKIT for Qt in r151546, the
code the flags that are not taken into account
anymore and the code that has been rendered
unreachable by this are removed.
.:
- Source/widgetsapi.pri:
Source/WebCore:
No new tests, no behavioural change.
- Target.pri:
- WebCore.exp.in:
- page/Settings.cpp:
- page/Settings.h:
- platform/KURL.h:
- platform/SharedBuffer.h:
- platform/cf/KURLCFNet.cpp:
(WebCore::KURL::fileSystemPath):
- platform/cf/SharedBufferCF.cpp:
- platform/graphics/FloatSize.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines):
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::paint):
(-[WebCoreMovieObserver layerHostChanged:]):
- platform/mac/SharedBufferMac.mm:
(+[WebCoreSharedBufferData initialize]):
(WebCore::SharedBuffer::createWithContentsOfFile):
Source/WebKit:
- WebKit1.pro:
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):
- WebCoreSupport/FullScreenVideoQt.h:
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/QTKitFullScreenVideoHandler.h: Removed.
- WebCoreSupport/QTKitFullScreenVideoHandler.mm: Removed.
- WebCoreSupport/WebSystemInterface.h: Removed.
- WebCoreSupport/WebSystemInterface.mm: Removed.
Source/WebKit2:
- Target.pri:
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Removed.
- WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Removed.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- 7:32 AM Changeset in webkit [151641] by
-
- 2 edits in trunk/LayoutTests
Remove invalid checks from block-cursor-overtype-mode.html
https://bugs.webkit.org/show_bug.cgi?id=117587
Reviewed by Darin Adler.
The test uses an array of ">" "<" symbols to perform comparisons
between consecutive positions of the block cursor. Since those
checks are done for each pair of consecutive characters the total
amount of checks is lengthOfTheWord - 1. We were adding an extra
symbol that was not used at all in the test.
- editing/selection/block-cursor-overtype-mode.html:
- 6:57 AM Changeset in webkit [151640] by
-
- 4 edits in trunk/Source/WebCore
REGRESSSION(r151632) : Build error on ASSERT(WTF_USE_GRAMMAR_CHECKING)
https://bugs.webkit.org/show_bug.cgi?id=117692
Reviewed by Jocelyn Turcotte.
Ifdef the feature-depending code and fix the assertions to check runtime conditions.
- editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::markBadGrammar):
- editing/TextCheckingHelper.cpp:
(WebCore::findBadGrammars):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::markAllBadGrammar):
(WebCore::checkTextOfParagraph):
- editing/TextCheckingHelper.h:
- 6:43 AM Changeset in webkit [151639] by
-
- 2 edits in trunk/Tools
Unreviewed. Add my email to a DOM watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 6:32 AM Changeset in webkit [151638] by
-
- 19 edits in trunk/Source
Unreviewed, rolling out r151632.
http://trac.webkit.org/changeset/151632
https://bugs.webkit.org/show_bug.cgi?id=117585
Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC
platforms
Source/WebCore:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
Source/WebKit/gtk:
- webkit/webkitglobals.cpp:
(webkit_context_menu_item_get_action):
Source/WebKit/mac:
- WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients):
Source/WebKit2:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(getEwkActionFromWKTag):
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onContextMenuShow):
(TEST_F):
- UIProcess/API/gtk/WebKitContextMenuActions.cpp:
(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
Source/WTF:
- wtf/Platform.h:
- 5:24 AM Changeset in webkit [151637] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Remove non existent files from compilation
and add a missing header file.
- 2:44 AM Changeset in webkit [151636] by
-
- 1 edit2 moves in trunk/LayoutTests
[Qt] Unreviewed gardening. Correcting rebaselining after r151634.
- platform/qt-5.0-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt.
- platform/qt-5.0-wk2/compositing/repaint/positioned-movement-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt.
- 1:39 AM Changeset in webkit [151635] by
-
- 3 edits in trunk
Unreviewed. Rename gobject_introspection_required variable.
As gobject_introspection_required_version for consistency with all
other required_version variables.
- Source/autotools/FindDependencies.m4:
- Source/autotools/Versions.m4:
- 1:17 AM Changeset in webkit [151634] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining repaint tests, see bug 115372.
- platform/qt-5.0-wk2/fast/repaint/change-overflow-and-display-of-relative-expected.txt: Rebaselining after r151549.
- platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt: Rebaselining after r151624.
- platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt: Rebaselining after r151622.
- 12:43 AM Changeset in webkit [151633] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skip three WebKit2APITests suites that are currently timing out.
- 12:28 AM Changeset in webkit [151632] by
-
- 19 edits in trunk/Source
Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off
https://bugs.webkit.org/show_bug.cgi?id=117585
Reviewed by Anders Carlsson.
Source/WebCore:
Do not add "Check Grammar With Spelling" and "Ignore Grammar" to the context menu
when GRAMMAR_CHECKING is off.
Replace "Spelling and Grammar" with "Spelling" as the sub menu title and "Show/Hide Spelling
and Grammar" with "Show/Hide Spelling" when GRAMMAR_CHECKING is off.
Additionally, guard grammar checking in context menu code to not necessarily
compile it.
No new layout tests because every port has a different way of showing
spelling/grammar context menu items.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
Source/WebKit/gtk:
Add GRAMMAR_CHECKING guard to the context menu grammar items.
- webkit/webkitglobals.cpp:
(webkit_context_menu_item_get_action):
Source/WebKit/mac:
Add GRAMMAR_CHECKING guard to the context menu grammar items.
- WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients):
Source/WebKit2:
Add GRAMMAR_CHECKING guard to the context menu grammar items.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(getEwkActionFromWKTag):
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(checkSpellingItemsAvailability):
Change callback name, to be consistent with a newly added.
(checkSpellingAndGrammarSubmenuAvailability):
(checkGrammarWithSpellingItemAvailability):
Add two unit tests for EFL to check whether context menu grammar items are
available only when GRAMMAR_CHECKING macro is enabled.
- UIProcess/API/gtk/WebKitContextMenuActions.cpp:
(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
Source/WTF:
Enable GRAMMAR_CHECKING for WebKit ports that use/implement it.
- wtf/Platform.h:
- 12:23 AM Changeset in webkit [151631] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk-wk1/TestExpectations: Add a crashing expectation for a test that most likely regressed with r151021.
- platform/gtk/TestExpectations: Add failure expectations for a couple of tests failing due to stack size misbehavior.
Jun 16, 2013:
- 11:53 PM Changeset in webkit [151630] by
-
- 3 edits1 add in trunk/LayoutTests
[CSS Blending] Update the background-blend-mode-image-color-dynamic test to use the repaint test logic
Updating testcase verifying if background blend modes are updated dynamically from script. This now
properly uses the repaint test mechanism. Also, the background image resource is addded.
https://bugs.webkit.org/show_bug.cgi?id=117686
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-16
Reviewed by Dean Jackson.
- fast/repaint/background-blend-mode-image-color-dynamic-expected.html:
- fast/repaint/background-blend-mode-image-color-dynamic.html:
- fast/repaint/resources/ducky.png: Added.
- 11:28 PM WebKitIDL edited by
- Fix several index links (diff)
- 9:23 PM Changeset in webkit [151629] by
-
- 2 edits in trunk/Source/WebCore
Fix test assertion after r151624
An assertion was hit in RenderObject::willBeDestroyed()
for fast/css/getComputedStyle/getComputedStyle-background-shorthand.html
because the code asserted that the RenderObject had been removed from
the FrameView's slowRepaintObject set before remove() was called,
so move the assertion to after that call.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- 8:56 PM Changeset in webkit [151628] by
-
- 2 edits in trunk/Source/WebCore
Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()
https://bugs.webkit.org/show_bug.cgi?id=117685
Reviewed by Andreas Kling.
From Blink r152490 by <vivek.vg@samsung.com>
- page/FrameView.cpp:
(WebCore::FrameView::invalidateRect): Avoid hostWindow() twice call.
- 7:25 PM Changeset in webkit [151627] by
-
- 5 edits2 adds in trunk
Fix two assertion failures in Range::insertNode
https://bugs.webkit.org/show_bug.cgi?id=116511
Reviewed by Ryosuke Niwa.
Source/WebCore:
ASSERTION FAILED: childBefore == (offset ? container->childNode(offset - 1) : 0)
third_party/WebKit/Source/WebCore/dom/RangeBoundaryPoint.h(115) : void WebCore::RangeBoundaryPoint::set(PassRefPtr<WebCore::Node>, int, WebCore::Node *)
ASSERTION FAILED: child->parentNode()
../../third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h(133) : void WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node *)
1 0x87594b2 WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node*)
2 0x87534a9 WebCore::Range::insertNode(WTF::PassRefPtr<WebCore::Node>, int&)
Range::insertNode calls Node::insertBefore, in which an event handler
can update the DOM structure so that RangeBoundaryPoint don't like. We
postpone event dispatching by EventQueueScope.
Also, remove old comments about Acid3. The behavior is standardized.
(Step 9 of http://dom.spec.whatwg.org/#dom-range-insertnode)
This patch imports http://src.chromium.org/viewvc/blink?view=revision&revision=150470 .
Test: fast/dom/Range/range-insertNode-assertion.html
- dom/Range.cpp:
(WebCore::Range::insertNode):
- Add EventQueueScope
- Remove obsolete comments
LayoutTests:
We need to update fast/dom/insertBefore-refChild-crash.html because the
test caused recursive calls to the event handler. container.innerHTML=
did nothing before this CL. Now container has the newChild because
DOMNodeRemoved event dispatching is delayed until Range::insertNode
completion.
We need to update fast/text/split-text-crash.xhtml so that it doesn't
stop when the event handler is called twice. I'm not sure why the test
worked before this CL.
- fast/dom/Range/range-insertNode-assertion-expected.txt: Added.
- fast/dom/Range/range-insertNode-assertion.html: Added.
- fast/dom/insertBefore-refChild-crash.html:
- fast/text/split-text-crash.xhtml:
- 6:58 PM Changeset in webkit [151626] by
-
- 2 edits10 adds in trunk/LayoutTests
Unreviewed. Added new baselines for some of editing/style tests, which works on EFL port.
- platform/efl/TestExpectations:
- platform/efl/editing/style/5017613-1-expected.png: Added.
- platform/efl/editing/style/5017613-1-expected.txt: Added.
- platform/efl/editing/style/5046875-1-expected.png: Added.
- platform/efl/editing/style/5046875-1-expected.txt: Added.
- platform/efl/editing/style/5065910-expected.png: Added.
- platform/efl/editing/style/5065910-expected.txt: Added.
- platform/efl/editing/style/5228141-expected.png: Added.
- platform/efl/editing/style/5228141-expected.txt: Added.
- platform/efl/editing/style/5279521-expected.png: Added.
- platform/efl/editing/style/5279521-expected.txt: Added.
- 6:13 PM Changeset in webkit [151625] by
-
- 2 edits18 adds in trunk/LayoutTests
Unreviewed. Added new baselines for some of editing/selection tests as r151533 on EFL port.
- platform/efl/TestExpectations:
- 4:32 PM Changeset in webkit [151624] by
-
- 5 edits2 adds in trunk
Fixed backgrounds in composited layers not repainted on scrolling
https://bugs.webkit.org/show_bug.cgi?id=117684
Source/WebCore:
Reviewed by Tim Horton.
FrameView is aware that "slow-repaint objects" (i.e. renderers with
background-attachment:fixed) require a slow-scrolling path. However,
it was ignorant of the fact that such objects could be painting into
compositing layers; it simply dirtied the main tiles, and nothing else.
Fix by having FrameView track the slow-repaints objects explicitly, as we
do for position:fixed, and repaint each of them on scrolling.
Test: compositing/repaint/fixed-background-scroll.html
- page/FrameView.cpp:
(WebCore::FrameView::FrameView): No need to initialize m_slowRepaintObjectCount,
which is now an OwnPtr<RenderObjectSet>.
(WebCore::FrameView::useSlowRepaints): Use hasSlowRepaintObjects() now.
(WebCore::FrameView::addSlowRepaintObject): Now adds the object to a set,
allocating the set if necessary.
(WebCore::FrameView::removeSlowRepaintObject): Remove the object from the set,
and deallocate the set if empty.
(WebCore::FrameView::scrollContentsSlowPath): Call repaintSlowRepaintObjects();
this is the change that fixes the bug for always-composited implementations (e.g.
tile cache). This is a conservative change; we still invalidate the tile cache
as well. This could be optimized later.
(WebCore::FrameView::repaintSlowRepaintObjects): Repaint each object in the set.
Their appropriate compositing ancestor will be repainted.
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget): Call
repaintSlowRepaintObjects() so that fixed backgrounds in composited layers are
correctly repainted; this fixes the bug for WebKit1.
- page/FrameView.h: Replace m_slowRepaintObjectCount with a HashSet of
RenderObjects.
(WebCore::FrameView::hasSlowRepaintObject): Takes a RenderObject* now.
(WebCore::FrameView::hasSlowRepaintObjects): Ditto.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Pass the RenderObject.
(WebCore::RenderObject::willBeDestroyed): Assert that this RenderObject
has been removed from FrameView's set of slow-repaint objects already, if
the document is not being destroyed.
(WebCore::RenderObject::willBeRemovedFromTree): Pass the RenderObject.
LayoutTests:
Reviewed by Tim Horton.
Test that verifies that a composited layer with a fixed background is repainted
on scrolling.
- compositing/repaint/fixed-background-scroll-expected.txt: Added.
- compositing/repaint/fixed-background-scroll.html: Added.
- 10:24 AM Changeset in webkit [151623] by
-
- 8 edits5 adds in trunk
Source/WebCore: Painting of fixed background images is wrong in composited layers
https://bugs.webkit.org/show_bug.cgi?id=65793
Reviewed by Sam Weinig.
The code that computed background image geometry for background-attachment:fixed
images was unaware of compositing, so often painting the image at the wrong location.
Fix by having RenderBoxModelObject::calculateBackgroundImageGeometry() do the correct
math for fixed backgrounds in composited layer by offsetting the viewport rect by
the paint container's absolute position.
Tests: compositing/backgrounds/fixed-background-on-descendant.html
compositing/backgrounds/fixed-backgrounds.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::getBackgroundPaintedExtent): Now returns a bool indicating
whether it is returning a reliable extent rect. It can return false in the case where
a background is fixed, since computing the correct extent would require finding
the appropriate composited ancestor to pass to calculateBackgroundImageGeometry().
This is OK since this function is used for "background opaque" optimizations.
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
returns false, return false.
(WebCore::RenderBox::maskClipRect): We removed mask-attachment, so we never need to
compute the composited ancestor here and can pass null.
(WebCore::RenderBox::repaintLayerRectsForImage): Unwrap a comment.
If the changed image is related to a fixed background, geometry.hasNonLocalGeometry()
will be true. In that cause, just repaint the entire renderer rather than groveling
around for a composited ancestor.
- rendering/RenderBox.h: Changed name and signature of backgroundPaintedExtent.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): calculateBackgroundImageGeometry()
now needs to know the painting container.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Now takes a painting
container, that is required to correctly compute the viewport-relative offset for fixed
backgrounds. geometry.setHasNonLocalGeometry() is set for fixed backgrounds to indicate
to callers that, if they didn't pass a paint container, the destRect is not accurate.
The main bug fix is also here: we move the viewportRect by the absolute location of
paint container, which is equivalent to the composited layer offset.
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage): calculateBackgroundImageGeometry()
takes a paint container.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::BackgroundImageGeometry):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setHasNonLocalGeometry):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::hasNonLocalGeometry):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
can't cheaply give an accurate answer, return false.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage): Pass the paint container,
which is our own renderer.
LayoutTests: Fixed background images behave strangely with webkit transitions
https://bugs.webkit.org/show_bug.cgi?id=65793
Reviewed by Sam Weinig.
Ref tests that compare fixed background rendering after a scroll, with and
without compositing, with a couple of layer configurations.
- compositing/backgrounds/fixed-background-on-descendant-expected.html: Added.
- compositing/backgrounds/fixed-background-on-descendant.html: Added.
- compositing/backgrounds/fixed-backgrounds-expected.html: Added.
- compositing/backgrounds/fixed-backgrounds.html: Added.
- 9:57 AM Changeset in webkit [151622] by
-
- 7 edits2 adds in trunk
webkit-backface-visibility on a parent element stops background-position from updating
https://bugs.webkit.org/show_bug.cgi?id=116319
Source/WebCore:
Reviewed by Darin Adler.
The optimization added in r102952 was incorrect in the case where a style change
resulted in a positioned-movement-only layout but also required a repaint; it assumed
that a composited layer did not need to be repainted for a a positioned-movement-only layout.
Fix by making RenderObject::setNeedsLayoutForPositionedMovement() check whether the
style change requires a repaint, and calling setLayerNeedsFullRepaint() in that situation.
Test: compositing/repaint/positioned-movement.html
- rendering/RenderLayer.h: RepaintStatus values do not need to be bit flags.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle): Pass the old style to setNeedsPositionedMovementLayout().
(WebCore::RenderObject::styleDidChange): Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsPositionedMovementLayout): Now takes a const RenderStyle*.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Remove a comment now that this bug is fixed.
(WebCore::RenderStyle::diffRequiresRepaint): Public wrapper for changeRequiresRepaint().
That function never uses contextSensitiveProperties so we can safely ignore them.
- rendering/style/RenderStyle.h: Expose a way to call changeRequiresRepaint().
LayoutTests:
Reviewed by Darin Adler.
Test that does a positioned-movement-only layout and dumps a layer tree with
repaint rects.
- compositing/repaint/positioned-movement-expected.txt: Added.
- compositing/repaint/positioned-movement.html: Added.
- 8:06 AM Changeset in webkit [151621] by
-
- 2 edits in trunk/Source/WebCore
Try to fix iOS after last Pasteboard change.
- platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::writeSelection): Put the new code inline here because the stringSelectionForPasteboard function is currently Mac-only.
