Timeline



Dec 1, 2013:

11:48 PM Changeset in webkit [159913] by ChangSeok Oh
  • 5 edits in trunk/Source/WebKit2

Unreviewed Gtk port Build fix after r159903

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

9:44 PM Changeset in webkit [159912] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVG: Intersection/enclosure checks should use RenderElement.
<https://webkit.org/b/125058>

Make RenderSVGModelObject's checkIntersection() and checkEnclosure()
take RenderElement* instead of RenderObject*. They are only ever
called with SVGElement's renderers.

Reviewed by Sam Weinig.

9:43 PM Changeset in webkit [159911] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unreachable labels for -webkit-margin-*-collapse properties.
<https://webkit.org/b/125057>

The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:

-webkit-margin-before-collapse
-webkit-margin-top-collapse
-webkit-margin-after-collapse
-webkit-margin-bottom-collapse

This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.

Reviewed by Anders Carlsson.

9:41 PM Changeset in webkit [159910] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

CSSFunctionValue constructors should return PassRef.
<https://webkit.org/b/125054>

Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.

Reviewed by Anders Carlsson.

7:36 PM Changeset in webkit [159909] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r159764.
http://trac.webkit.org/changeset/159764
https://bugs.webkit.org/show_bug.cgi?id=125055

appears to hurt html5-full-render times (Requested by kling on
#webkit).

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

  • html/parser/HTMLConstructionSite.h:
7:36 PM Changeset in webkit [159908] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

Give UserMessageEncoders WebProcessProxy reference (like the decoders already have)
https://bugs.webkit.org/show_bug.cgi?id=125053

Reviewed by Dan Bernstein.

  • Give the UserMessageEncoders a process reference.
  • Switch UserMessageDecoders to storing a process reference, rather than pointer.
  • Shared/UserMessageCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:
  • UIProcess/WebConnectionToWebProcess.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContextUserMessageCoders.h:
  • UIProcess/WebPageProxy.cpp:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
6:47 PM Changeset in webkit [159907] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Make more computed style helpers return PassRef.
<https://webkit.org/b/125043>

Reduce branchiness in computed style code by making more of the
file-local helpers return PassRef instead of PassRefPtr.

Reviewed by Anders Carlsson.

5:53 PM Changeset in webkit [159906] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] The PageLoadState::Observer is not being set on iOS
https://bugs.webkit.org/show_bug.cgi?id=125051

Reviewed by Dan Bernstein.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformInitialize):
Add missing call to _finishInitialization.

5:16 PM Changeset in webkit [159905] by ryuan.choi@samsung.com
  • 9 edits in trunk/Source/WebKit2

Unreviewed EFL Build fix attempt after r159903

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::CoordinatedDrawingAreaProxy::update):
(WebKit::CoordinatedDrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::sendUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::renderNextFrame):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):

  • UIProcess/WebTextChecker.cpp:

(WebKit::WebTextChecker::checkSpelling):
(WebKit::WebTextChecker::changeSpellingToWord):

  • UIProcess/WebTextChecker.h:
  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

5:04 PM Changeset in webkit [159904] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix the iOS build.

  • UIProcess/API/ios/WKContentView.mm:
  • UIProcess/API/ios/WKInteractionView.mm:
  • UIProcess/ios/WebPageProxyIOS.mm:
4:50 PM Changeset in webkit [159903] by weinig@apple.com
  • 33 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebProcessProxy is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125047

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Downloads/DownloadProxy.cpp:
  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxyMap.cpp:
  • UIProcess/Downloads/DownloadProxyMap.h:
  • UIProcess/DrawingAreaProxy.cpp:
  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/WebEditCommandProxy.cpp:
  • UIProcess/WebFrameProxy.cpp:
  • UIProcess/WebFullScreenManagerProxy.cpp:
  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
  • UIProcess/mac/RemoteLayerTreeHost.mm:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
4:50 PM Changeset in webkit [159902] by mitz@apple.com
  • 4 edits in trunk/Tools

[Mac] Transition MiniBrowser to the Cocoa API: policy delegate
https://bugs.webkit.org/show_bug.cgi?id=125046

Reviewed by Sam Weinig.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
(-[BrowserAppDelegate openDocument:]): Ditto.

  • MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the

interface to the implementation.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
the policy client.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
Moved policy client implementation into this delegate method.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
Ditto.

3:40 PM Changeset in webkit [159901] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

11:14 AM WebInspectorCodingStyleGuide edited by Brian Burg
Fix tt styles, add links to mechanization tracking bug, repository … (diff)
11:00 AM WebInspectorCodingStyleGuide edited by Brian Burg
Add protected (diff)
10:46 AM WikiStart edited by Brian Burg
Move and relabel Web Inspector links; add inspector style guide (diff)
9:03 AM Changeset in webkit [159900] by mitz@apple.com
  • 3 edits
    2 deletes in trunk/Tools

[Mac] Remove the MiniBrowser injected bundle
https://bugs.webkit.org/show_bug.cgi?id=125041

Reviewed by Anders Carlsson.

It had no ops!

  • MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/Info.plist: Removed.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
5:45 AM Changeset in webkit [159899] by Philippe Normand
  • 4 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159896.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseUpdatePreferences):

12:07 AM Changeset in webkit [159898] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

Unreviewed build fix after r159896.

  • UIProcess/API/efl/ewk_settings.cpp:

(EwkSettings::preferences):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

Nov 30, 2013:

11:05 PM Changeset in webkit [159897] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebCore

[EFL] Implement scrollbarThickness for opaque scrollbar
https://bugs.webkit.org/show_bug.cgi?id=125034

Reviewed by Gyuyoung Kim.

Implemented scrollbarThickness to support opaque scrollbar.
Now, edj can decide whether to support opaque scrollbar by adding scrollbar.thickness.
In addition, added OVERRIDE/FINAL keyword and removed unnecessary destructor
in ScrollbarThemeEfl.cpp.

No new tests, no behavior changes with default theme.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::loadTheme):
Update thickness of scrollbar when theme was loaded.

  • platform/efl/ScrollbarThemeEfl.cpp:
  • platform/efl/ScrollbarThemeEfl.h:

(WebCore::ScrollbarThemeEfl::setScrollbarThickness):
(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

10:40 PM Changeset in webkit [159896] by weinig@apple.com
  • 17 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125038

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(WKPageIsURLKnownHSTSHost):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController browsingContextGroup]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorProxy::isInspectorPage):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::createNonNull):

  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::preferencesDidChange):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageGroup):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::pageIsProcessSuppressible):

10:24 PM Changeset in webkit [159895] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

Added a version of +[NSURL _web_URLWithWTFString:relativeToURL:] that doesn’t take a base URL and switched all callers to it.
https://bugs.webkit.org/show_bug.cgi?id=125040

Reviewed by Sam Weinig.

  • Shared/Cocoa/WKNSURLExtras.h: Declared new method.
  • Shared/Cocoa/WKNSURLExtras.mm:

(urlWithWTFString): Added helper function.
(+[NSURL _web_URLWithWTFString:]): Added.
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Changed to use helper function.

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to call new method.
(-[WKBackForwardListItem originalURL]): Ditto.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Ditto.
(setUpPagePolicyClient): Ditto.

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

10:02 PM Changeset in webkit [159894] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Stop using the WKPageRef API in WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=125036

Reviewed by Sam Weinig.

  • Shared/Cocoa/WKNSURLExtras.h: Declared new method.
  • Shared/Cocoa/WKNSURLExtras.mm:

(-[NSURL _web_originalDataAsWTFString]): Added. Returns a WTF::String with the receiver’s
bytes.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadRequest:userData:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController _pageRef]):
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):

7:52 PM Changeset in webkit [159893] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159865.
http://trac.webkit.org/changeset/159865
https://bugs.webkit.org/show_bug.cgi?id=125037

the position of mouse events are wrong at MiniBrowser/efl
(Requested by ryuan on #webkit).

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):

7:33 PM Changeset in webkit [159892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Win] Some JavaScript date tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=124946

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-30
Reviewed by Brent Fulgham.

Use native Win32 api functions to compute Daylight saving time offset.

  • wtf/DateMath.cpp:

(WTF::UnixTimeToFileTime): Added method to calculate Win32 specific struct FILETIME from time_t value.
(WTF::calculateDSTOffset): Use native Win32 api functions to compute Daylight saving time offset.

6:25 PM Changeset in webkit [159891] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebBackForwardList is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125035

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetBackForwardList):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Remove null check.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::currentItem): Constify.
(WebKit::WebBackForwardList::backItem): Constify.
(WebKit::WebBackForwardList::forwardItem): Constify.
(WebKit::WebBackForwardList::itemAtIndex): Constify.

  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::create):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::backForwardList):

12:15 PM Changeset in webkit [159890] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159889.

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::viewWidget): Adjust the static cast of the PageClient reference to PageClientImpl.

11:14 AM Changeset in webkit [159889] by weinig@apple.com
  • 15 edits in trunk/Source/WebKit2

[CTTE] WebPageProxy should store the PageClient as a reference
https://bugs.webkit.org/show_bug.cgi?id=125030

Reviewed by Dan Bernstein.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:

(WebKit::WebPageProxy::didFindZoomableArea):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setViewNeedsDisplay):
(WebKit::WebPageProxy::displayView):
(WebKit::WebPageProxy::canScrollView):
(WebKit::WebPageProxy::scrollView):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::viewSize):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::screenToWindow):
(WebKit::WebPageProxy::windowToScreen):
(WebKit::WebPageProxy::pageDidRequestScroll):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):
(WebKit::WebPageProxy::didChangeViewportProperties):
(WebKit::WebPageProxy::handleDownloadRequest):
(WebKit::WebPageProxy::didChangeContentSize):
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::setFindIndicator):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::setToolTip):
(WebKit::WebPageProxy::setCursor):
(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::initializeCreationParameters):
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
(WebKit::WebPageProxy::updateAcceleratedCompositingMode):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::mainDocumentDidReceiveMobileDocType):
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
(WebKit::WebPageProxy::didChangeViewportArguments):
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedData):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::makeFirstResponder):
(WebKit::WebPageProxy::colorSpace):
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
(WebKit::WebPageProxy::setPluginComplexTextInputState):
(WebKit::WebPageProxy::executeSavedCommandBySelector):
(WebKit::WebPageProxy::wkView):
(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

10:55 AM Changeset in webkit [159888] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

[RTTE] The PermissionRequestManagerProxies should use WebPageProxy references.
https://bugs.webkit.org/show_bug.cgi?id=125029

Reviewed by Dan Bernstein.

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::GeolocationPermissionRequestManagerProxy):
(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

  • UIProcess/GeolocationPermissionRequestManagerProxy.h:
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Do some additional modernization while we are here.

10:49 AM Changeset in webkit [159887] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/15560240> ResourceError encoding drops NSURL-valued keys in the NSError’s userInfo, including NSErrorFailingURLKey
https://bugs.webkit.org/show_bug.cgi?id=125016

Reviewed by Anders “happy name day” Carlsson.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData): Encode all string- and URL-valued keys as a dictionary.
(CoreIPC::::decodePlatformData): Decode user info as a dictionary.

9:23 AM Changeset in webkit [159886] by fpizlo@apple.com
  • 28 edits in trunk/Source/JavaScriptCore

Finally remove those DFG_ENABLE things
https://bugs.webkit.org/show_bug.cgi?id=125025

Rubber stamped by Sam Weinig.

This removes a bunch of unused and untested insanity.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getArrayModeConsideringSlowPath):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:

(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldDumpGraphAtEachPhase):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • dfg/DFGVariableEventStream.h:

(JSC::DFG::VariableEventStream::appendAndLog):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

9:05 AM Changeset in webkit [159885] by mrowe@apple.com
  • 3 edits in trunk/Websites/webkit.org

<https://webkit.org/b/125027> Update the analytics account used by webkit.org

Switch to a Google Analytics id that's accessible to someone that's involved with the WebKit project.

Reviewed by Sam Weinig.

  • footer.inc: Remove the old analytics code.
  • header.inc: Add the new stuff.

Nov 29, 2013:

11:41 PM Changeset in webkit [159884] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for EFL and GTK WK2 builds.

  • Scripts/generate-forwarding-headers.pl: Add Cocoa to the list of platform prefixes.
8:17 PM Changeset in webkit [159883] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL IC should nop-fill to make up the difference between the actual IC size and the requested patchpoint size
https://bugs.webkit.org/show_bug.cgi?id=124960

Reviewed by Sam Weinig.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::size):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::fillNops):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

  • ftl/FTLCompile.cpp:

(JSC::FTL::generateICFastPath):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

8:13 PM Changeset in webkit [159882] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Fix build warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::eventCallback):

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKArrayIsMutable):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

6:04 PM Changeset in webkit [159881] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

[Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
https://bugs.webkit.org/show_bug.cgi?id=125024

Reviewed by Dan Bernstein.

Introduce API::ObjectStorage which wraps std::aligned_storage and adds some convenience functions
to reinterpret the data as the corresponding type. Deploy it everywhere we were previously using
std::aligned_storage.

  • Shared/Cocoa/WKNSArray.mm:
  • Shared/Cocoa/WKNSDictionary.mm:
  • Shared/Cocoa/WKObject.h:
  • UIProcess/API/Cocoa/WKBackForwardList.mm:
  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
  • UIProcess/API/Cocoa/WKNavigationData.mm:
  • UIProcess/API/Cocoa/WKProcessGroup.mm:
5:46 PM Changeset in webkit [159880] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crashing API tests.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):

4:56 PM Changeset in webkit [159879] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix some style boo-boos.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:53 PM Changeset in webkit [159878] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the iOS build.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:27 PM Changeset in webkit [159877] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125022

Reviewed by Dan Bernstein.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/mac/ObjCObjectGraphCoders.mm:

Add support for WKProcessGroup.

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
Replace call to _browsingContextControllerForPageRef: with wrapper.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline.

(-[WKBrowsingContextController dealloc]):
Add explicit destructor call.

(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
Lazily set up the load and policy clients only once a delegate has been set to allow
continued use of the C-SPI clients for WebKitTestRunner.

(-[WKBrowsingContextController _finishInitialization]):
Move remaining work that was done in the initialize (setting up the observer) here,
and have the WebPageProxy call it.

  • UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
_initWithPageRef: and _browsingContextControllerForPageRef: helpers.

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
Switch to using wrapper().

  • UIProcess/API/ios/WKContentView.mm:
  • UIProcess/API/mac/WKView.mm:

Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
as the WebPageProxy.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitialize):
Inform the wrapper that it is safe to finish initialization.

3:21 PM Changeset in webkit [159876] by mitz@apple.com
  • 8 edits
    2 adds in trunk/Source/WebKit2

[Cocoa] Add a way to recover from load errors
https://bugs.webkit.org/show_bug.cgi?id=125020

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from
the given error, adding two keys to the user info dictionary: the context controller under
the recovery attempter key, and the frame under a private key.
(didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter.
(didFailLoadWithErrorForFrame): Ditto.
(-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this
WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the
frame from the error.

  • UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting

recovery from errors and declares the error user info dictionary key under which an object
conforming to this protocol may be stored.

  • UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines

WKRecoveryAttempterErrorKey.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page.

  • UIProcess/WebFrameProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame.
1:15 PM Changeset in webkit [159875] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Expose loadAlternateHTMLString via the API
https://bugs.webkit.org/show_bug.cgi?id=125019

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added.
Calls WebPageProxy::loadAlternateHTMLString.

12:54 PM Changeset in webkit [159874] by weinig@apple.com
  • 2 edits
    22 moves in trunk/Source/WebKit2

Move API files shared between Mac and iOS to the Cocoa directory
https://bugs.webkit.org/show_bug.cgi?id=125017

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm.
  • UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
  • UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h.
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h.
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm.
  • UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
  • UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h.
  • UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h.
  • UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h.
  • UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h.
  • UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm.
  • UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h.
  • UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h.
  • UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm.
  • UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
  • UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h.
  • UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h.
  • UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm.
  • UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h.
  • UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h.
  • UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h.
  • UIProcess/API/mac/WKBrowsingContextController.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextController.mm: Removed.
  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroup.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed.
  • UIProcess/API/mac/WKConnection.h: Removed.
  • UIProcess/API/mac/WKConnection.mm: Removed.
  • UIProcess/API/mac/WKConnectionInternal.h: Removed.
  • UIProcess/API/mac/WKProcessGroup.h: Removed.
  • UIProcess/API/mac/WKProcessGroup.mm: Removed.
  • UIProcess/API/mac/WKProcessGroupInternal.h: Removed.
  • UIProcess/API/mac/WKProcessGroupPrivate.h: Removed.
  • UIProcess/API/mac/WKTypeRefWrapper.h: Removed.
  • UIProcess/API/mac/WKTypeRefWrapper.mm: Removed.
  • UIProcess/API/mac/WKView.h: Removed.
  • UIProcess/API/mac/WKViewPrivate.h: Removed.
  • UIProcess/API/mac/WebKit2.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
10:50 AM Moving to Git edited by kallisti5@unixzen.com
(diff)
9:25 AM Changeset in webkit [159873] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
https://bugs.webkit.org/show_bug.cgi?id=124936

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

The moveDoubleToInts implementations in ARM, MIPS and SH4 macro assemblers do not clobber
src FPRegister and are likely to be more efficient than the current generic implementation
using the stack.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

6:32 AM Changeset in webkit [159872] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should check for extraneous newline between config.h and primary header.
https://bugs.webkit.org/show_bug.cgi?id=124821

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-29
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_line_break_after_own_header):
(OrderOfIncludesTest):
(OrderOfIncludesTest.test_check_line_break_before_own_header):

6:16 AM Changeset in webkit [159871] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
https://bugs.webkit.org/show_bug.cgi?id=124892

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::call): Pick a scratch register instead of getting it as a
parameter. The sh4 port was the only one to have this call(Address, RegisterID) prototype.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Use argumentGPRx and merge arm and sh4 paths.

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator): Use argumentGPRx and merge arm and sh4 paths.

4:23 AM Changeset in webkit [159870] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Accessibility rebaselines after r159848.

  • platform/efl-wk1/accessibility/table-detection-expected.txt:
  • platform/efl-wk2/accessibility/table-detection-expected.txt:
4:06 AM Changeset in webkit [159869] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove Symbian specific code.
https://bugs.webkit.org/show_bug.cgi?id=124939

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

Symbian is not supported, remove leftover code.

  • plugins/npapi.h:
3:41 AM Changeset in webkit [159868] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

test-webkit-scripts should show the failing tests and use an appropriate exit code
https://bugs.webkit.org/show_bug.cgi?id=124840

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-29
Reviewed by Ryosuke Niwa.

A fixme in test-webkit-scripts asked that the script should display success or failiure
and exit with a 0 or 1 value accordingly after all of the tests have completed.

  • Scripts/test-webkit-scripts:

(ScriptsTester.run_test_script):
The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
because at this point we don't need to pass on more information other than success or failiure.
(ScriptsTester.main):
The return values are now stored for each script and when all tests have completed successfully,
the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.

3:38 AM Changeset in webkit [159867] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk

[ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=124923

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-29
Reviewed by Mario Sanchez Prada.

Tools:

Added missing implementation of isAttributeSettable. Using
ATK_STATE_EDITABLE for checking whether attribute is settable.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isAttributeSettable):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isAttributeSettable):

LayoutTests:

Test could be reused by EFL and GTK as well.

  • accessibility/content-editable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-expected.txt.
  • accessibility/content-editable.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable.html.
3:26 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com
changeset 159572 is controversial (diff)
2:51 AM Changeset in webkit [159866] by commit-queue@webkit.org
  • 3 edits in trunk

[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace
https://bugs.webkit.org/show_bug.cgi?id=124899

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-29
Reviewed by Gyuyoung Kim.

  • Source/cmake/FindCairo.cmake:
  • Source/cmake/FindGStreamer.cmake:
12:37 AM Changeset in webkit [159865] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] viewport must be same with the size of webview
https://bugs.webkit.org/show_bug.cgi?id=124965

Patch by Hunseop Jeong <Hunseop Jeong> on 2013-11-29
Reviewed by Gyuyoung Kim.

Currently, size of the viewport is larger than size of webview.
Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired): Changed to use the (0,0).
(EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
(EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.

Nov 28, 2013:

11:51 PM Changeset in webkit [159864] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
https://bugs.webkit.org/show_bug.cgi?id=118548

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-11-28
Reviewed by Noam Rosenthal.

CoordinatedGraphics uses its own scaling logic - contents scaling - and
WebView of CoordinatedGraphics maintains contents position by scaling
with contents scaling factor.
However transformToScene() and updateViewportSize() of WebView regard
the contents position as a non-scaled value, so it should be fixed.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):

7:42 PM Changeset in webkit [159863] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL] PageViewportController does not need to be unique_ptr instance
https://bugs.webkit.org/show_bug.cgi?id=124993

Reviewed by Gyuyoung Kim.

PageViewportController and PageViewportControllerEfl have same life cycle
with EwkView. So, we don't need to make them as unique_ptr instance.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::handleEvasObjectCalculate):
(EwkView::scrollBy):

  • UIProcess/API/efl/EwkView.h:

(EwkView::pageViewportController):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::didChangeViewportAttributes):

5:35 PM Changeset in webkit [159862] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124992

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-28
Reviewed by Gyuyoung Kim.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.

  • UIProcess/API/gtk/PageClientImpl.h:
5:02 PM Changeset in webkit [159861] by jinwoo7.song@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124991

Reviewed by Gyuyoung Kim.

Redefined newly added pure virtual function in PageClient class after r159859.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):

  • UIProcess/CoordinatedGraphics/WebView.h:
3:25 PM Changeset in webkit [159860] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebCore

Rename InlineIterator::m_obj and make it private
https://bugs.webkit.org/show_bug.cgi?id=124837

Reviewed by Antti Koivisto.

InlineIterator has been exported m_obj as public though there is a getter function.
Besides *object* name isn't ambigious. So, changed it with m_renderer and renderer().
Additionally, setRenderer() is added as well.

No new tests, no behavior changes.

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::setObject):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineBidiResolver::appendRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::matchedEndLine):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::iteratorIsBeyondEndOfRenderCombineText):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::checkMidpoints):
(WebCore::BreakingContext::handleEndOfLine):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):

  • rendering/line/LineInlineHeaders.h:

(WebCore::skipNonBreakingSpace):
(WebCore::requiresLineBox):

2:23 PM WebKitGTK/Debugging edited by Andres Gomez
(diff)
1:01 PM Changeset in webkit [159859] by weinig@apple.com
  • 14 edits
    1 add in trunk/Source/WebKit2

Perform some spring cleaning to WKContentView and WKView
https://bugs.webkit.org/show_bug.cgi?id=124961

Reviewed by Dan Bernstein.

  • Store the PageClientImpl in a std::unique_ptr.
  • Remove the WKBrowsingContextController internal load delegate. Replace its use with a new PageClient function, didCommitLoadForMainFrame.
  • Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame -> contentViewDidCommitLoadForMainFrame.
  • Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. These are needed for WebKitTestRunner.
  • Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef).
  • Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView.
  • Remove incorrect implementations of initWithCoder.
  • Make WKContentView lazily create its WKBrowsingContextController wrapper.
  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType):

  • UIProcess/API/ios/WKContentView.h:
  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithCoder:]):
(-[WKContentView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKContentView browsingContextController]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didReceiveMobileDocTypeForMainFrame]):
(-[WKContentView _didChangeViewportArguments:WebCore::]):
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _pageRef]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/API/ios/WKContentViewPrivate.h: Added.
  • UIProcess/API/ios/WKView.mm:

(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]):
(-[WKView contentViewDidCommitLoadForMainFrame:]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView pageRef]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didCommitLoadForFrame):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

12:59 PM Changeset in webkit [159858] by Antti Koivisto
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove an oddly named css variables test

Rubber-stamped by Andreas Kling.

  • css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
  • css3/filters/reference-filter-update-after-remove.html: Removed.
12:55 PM Changeset in webkit [159857] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WTF

Nix Upstream: Updating Nix WTF files
https://bugs.webkit.org/show_bug.cgi?id=124980

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Just to sync our private repo files and the trunk, as part of the upstream process.

  • wtf/DisallowCType.h:
  • wtf/PlatformNix.cmake:
  • wtf/nix/FeatureDefinesNix.h:
  • wtf/nix/PlatformNix.h:
  • wtf/nix/RunLoopNix.cpp: Added.
12:53 PM Changeset in webkit [159856] by Antti Koivisto
  • 158 edits
    2 moves in trunk

Rename StylePropertySet to StyleProperties
https://bugs.webkit.org/show_bug.cgi?id=124990

Reviewed by Andreas Kling.

"Set" does not add useful information here. Use less clunky plural name.

12:33 PM Changeset in webkit [159855] by nrotem@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Revert the X86 assembler peephole changes
https://bugs.webkit.org/show_bug.cgi?id=124988

Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::branchAdd32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:43 AM Changeset in webkit [159854] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

Nix Upstream: Adding EditorNix to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124984

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

No new tests needed.

  • PlatformNix.cmake:
  • editing/nix/EditorNix.cpp: Added.
11:35 AM Changeset in webkit [159853] by Csaba Osztrogonác
  • 274 edits
    2 adds in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase EFL results (and the remaining Mac) after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • fast/table/anonymous-table-section-removed.html: Updated.
  • platform/efl/accessibility/table-attributes-expected.txt: Added.
  • platform/efl/accessibility/table-sections-expected.txt: Added.
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/table/[...]:
  • platform/efl/tables/[...]:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
11:33 AM Changeset in webkit [159852] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Building EFL Webkit again with mediastream enabled
https://bugs.webkit.org/show_bug.cgi?id=124930

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • CMakeLists.txt:
11:03 AM Changeset in webkit [159851] by Csaba Osztrogonác
  • 147 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/table/[...]:
  • platform/mac/tables/[...]:
10:54 AM Changeset in webkit [159850] by Csaba Osztrogonác
  • 269 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • platform/gtk/accessibility/table-detection-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/table/[...]:
  • platform/gtk/tables/[...]:
9:43 AM Changeset in webkit [159849] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
https://bugs.webkit.org/show_bug.cgi?id=124959

Reviewed by Brent Fulgham.

Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

No new tests, no behavior change.

  • WebCore.vcxproj/WebCore.vcxproj.filters:
9:40 AM Changeset in webkit [159848] by Csaba Osztrogonác
  • 4 edits in trunk

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Use border spacing at the end of all sections.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Skipped tests enabled.

8:55 AM Changeset in webkit [159847] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Unreviewed, rolling out r159839.
http://trac.webkit.org/changeset/159839
https://bugs.webkit.org/show_bug.cgi?id=124974

run-webkit-tests doesn't generate pretty diff (Requested by
Ossy on #webkit).

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.pretty_patch_available):
(Port.check_pretty_patch):
(Port.variable):
(Port.variable.pretty_patch_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

8:35 AM Changeset in webkit [159846] by Michał Pakuła vel Rutka
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/TestExpectations: Added test expectations for failing tests.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.
8:20 AM Changeset in webkit [159845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Buildfix after r159824 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=124968

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

  • Shared/APIObject.h:
8:19 AM Changeset in webkit [159844] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

No need to skip css variables tests as they were removed.

  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
8:02 AM Changeset in webkit [159843] by gns@gnome.org
  • 3 edits in trunk/Source/WebKit/gtk

REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

  • tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

7:46 AM Changeset in webkit [159842] by Antti Koivisto
  • 60 edits
    3 deletes in trunk

Remove feature: CSS variables
https://bugs.webkit.org/show_bug.cgi?id=114119

.:

Reviewed by Andreas Kling.

  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSBasicShapes.cpp:
  • css/CSSBasicShapes.h:
  • css/CSSCalculationValue.cpp:

(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):

  • css/CSSCalculationValue.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):

  • css/CSSParser.h:
  • css/CSSParserMode.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSProperty.cpp:
  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

  • css/CSSReflectValue.cpp:
  • css/CSSReflectValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::setCssText):

  • css/CSSValueList.cpp:
  • css/CSSValueList.h:
  • css/CSSVariableValue.h: Removed.
  • css/Pair.h:
  • css/Rect.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):

  • css/StyleResolver.h:
  • css/WebKitCSSTransformValue.cpp:
  • css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::equals):

  • css/makeprop.pl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleVariableData.h: Removed.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

  • wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/variables: Removed.
  • fast/css/variables/border-width-expected.html: Removed.
  • fast/css/variables/border-width.html: Removed.
  • fast/css/variables/build-supports-variables-expected.txt: Removed.
  • fast/css/variables/build-supports-variables.html: Removed.
  • fast/css/variables/calc-expected.html: Removed.
  • fast/css/variables/calc-inside-calc-expected.html: Removed.
  • fast/css/variables/calc-inside-calc.html: Removed.
  • fast/css/variables/calc-invalid-value-expected.html: Removed.
  • fast/css/variables/calc-invalid-value.html: Removed.
  • fast/css/variables/calc-invalid-variable-expected.html: Removed.
  • fast/css/variables/calc-invalid-variable.html: Removed.
  • fast/css/variables/calc-negated-variable-expected.html: Removed.
  • fast/css/variables/calc-negated-variable.html: Removed.
  • fast/css/variables/calc-vw-crash-expected.txt: Removed.
  • fast/css/variables/calc-vw-crash.html: Removed.
  • fast/css/variables/calc.html: Removed.
  • fast/css/variables/case-sensitive-expected.html: Removed.
  • fast/css/variables/case-sensitive.html: Removed.
  • fast/css/variables/colors-test-expected.html: Removed.
  • fast/css/variables/colors-test.html: Removed.
  • fast/css/variables/complex-cycle-expected.html: Removed.
  • fast/css/variables/complex-cycle.html: Removed.
  • fast/css/variables/computed-style-expected.html: Removed.
  • fast/css/variables/computed-style.html: Removed.
  • fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
  • fast/css/variables/deferred-image-load-from-variable.html: Removed.
  • fast/css/variables/inherited-values-expected.html: Removed.
  • fast/css/variables/inherited-values.html: Removed.
  • fast/css/variables/inline-styles-expected.html: Removed.
  • fast/css/variables/inline-styles.html: Removed.
  • fast/css/variables/invalid-font-reference-expected.txt: Removed.
  • fast/css/variables/invalid-font-reference.html: Removed.
  • fast/css/variables/invalid-shorthand-expected.html: Removed.
  • fast/css/variables/invalid-shorthand.html: Removed.
  • fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
  • fast/css/variables/invalid-value-list-crash.html: Removed.
  • fast/css/variables/invalid-variable-value-expected.html: Removed.
  • fast/css/variables/invalid-variable-value.html: Removed.
  • fast/css/variables/multi-level-cycle-expected.html: Removed.
  • fast/css/variables/multi-level-cycle.html: Removed.
  • fast/css/variables/redefinition-expected.html: Removed.
  • fast/css/variables/redefinition.html: Removed.
  • fast/css/variables/root-background-size-expected.html: Removed.
  • fast/css/variables/root-background-size.html: Removed.
  • fast/css/variables/shorthand-expected.html: Removed.
  • fast/css/variables/shorthand.html: Removed.
  • fast/css/variables/simple-cycle-expected.html: Removed.
  • fast/css/variables/simple-cycle.html: Removed.
  • fast/css/variables/transform-test-expected.html: Removed.
  • fast/css/variables/transform-test.html: Removed.
  • fast/css/variables/undefined-expected.html: Removed.
  • fast/css/variables/undefined.html: Removed.
  • fast/css/variables/use-before-defined-expected.html: Removed.
  • fast/css/variables/use-before-defined.html: Removed.
  • fast/css/variables/var-filter-expected.txt: Removed.
  • fast/css/variables/var-filter.html: Removed.
  • fast/css/variables/var-inside-box-reflect-expected.html: Removed.
  • fast/css/variables/var-inside-box-reflect.html: Removed.
  • fast/css/variables/var-inside-pair-expected.html: Removed.
  • fast/css/variables/var-inside-pair.html: Removed.
  • fast/css/variables/var-inside-quad-expected.html: Removed.
  • fast/css/variables/var-inside-quad.html: Removed.
  • fast/css/variables/var-inside-shape-expected.html: Removed.
  • fast/css/variables/var-inside-shape.html: Removed.
  • fast/css/variables/var-inside-shorthand-expected.html: Removed.
  • fast/css/variables/var-inside-shorthand.html: Removed.
  • fast/css/variables/variable-chain-expected.html: Removed.
  • fast/css/variables/variable-chain.html: Removed.
  • fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
  • fast/css/variables/variable-unparseable-value-crash.html: Removed.
7:27 AM Changeset in webkit [159841] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124879

Unreviewed, EFL rebaseline.

EFL tests need to be rebaselined after r159747

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-28

  • platform/efl/fast/table/011-expected.txt:
  • platform/efl/fast/table/border-collapsing/004-expected.txt:
  • platform/efl/fast/table/tableInsideCaption-expected.txt:
7:15 AM Changeset in webkit [159840] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::create):

  • platform/mock/RTCPeerConnectionHandlerMock.h:
7:14 AM Changeset in webkit [159839] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

6:20 AM WebKitGTK/2.2.x edited by gns@gnome.org
(diff)
6:09 AM WebKitGTK/2.2.x edited by gns@gnome.org
(diff)
5:46 AM Changeset in webkit [159838] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Checkout should own the scm object in Host
https://bugs.webkit.org/show_bug.cgi?id=124943

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/host.py:

(Host.init):
(Host.initialize_scm):
(Host.scm):

5:41 AM WebKitGTK/2.2.x edited by gns@gnome.org
(diff)
4:40 AM Changeset in webkit [159837] by gns@gnome.org
  • 9 edits in trunk

[GTK] Support custom types for drag and drop data
https://bugs.webkit.org/show_bug.cgi?id=124659

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-27
Reviewed by Martin Robinson.

Source/WebCore:

Covered by fast/events/drag-customData.html.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
(WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.

  • platform/gtk/DataObjectGtk.h:

(WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
(WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
(WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeString): handle unknown types as custom.
(WebCore::Pasteboard::writePasteboard): ditto.
(WebCore::Pasteboard::hasData): also check for custom types.
(WebCore::Pasteboard::types): also obtain the list of custom types.
(WebCore::Pasteboard::readString): handle unknown types as custom.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::initGdkAtoms): new unknown atom.
(WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
(WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
is in turn serialized to a single string for GtkSelectionData to hold.
(WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
set.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
from the serialized GVariant string held by GtkSelectionData.
(WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

Source/WebKit2:

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeDataObject): encode the unknown types data.
(CoreIPC::decodeDataObject): decode the unknown types data.

LayoutTests:

  • platform/gtk/TestExpectations: remove failure expectation for test that now passes.
4:22 AM WebKitGTK/2.2.x edited by tpopela@redhat.com
(diff)
2:28 AM Changeset in webkit [159836] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Typo fix after r159834 to fix 32 bit builds.

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Nov 27, 2013:

11:40 PM Changeset in webkit [159835] by nrotem@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add a bunch of early exits and local optimizations to the x86 assembler.
https://bugs.webkit.org/show_bug.cgi?id=124904

Reviewed by Filip Pizlo.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:10 PM Changeset in webkit [159834] by fpizlo@apple.com
  • 31 edits
    12 adds in trunk

Infer one-time scopes
https://bugs.webkit.org/show_bug.cgi?id=124812

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This detects JSActivations that are created only once. The JSActivation pointer is then
baked into the machine code.

This takes advantage of the one-time scope inference to reduce the number of
indirections needed to get to a closure variable in case where the scope is only
allocated once. This isn't really a speed-up since in the common case the total number
of instruction bytes needed to load the scope from the stack is about equal to the
number of instruction bytes needed to materialize the absolute address of a scoped
variable. But, this is a necessary prerequisite to
https://bugs.webkit.org/show_bug.cgi?id=124630, so it's probably a good idea anyway.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::notifyWrite):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolveScope):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetRegisters):

  • dfg/DFGGraph.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::varNumber):
(JSC::DFG::Node::hasSymbolTable):
(JSC::DFG::Node::symbolTable):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSActivation.h:

(JSC::JSActivation::create):

  • runtime/JSScope.cpp:

(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):

  • runtime/JSScope.h:

(JSC::ResolveOp::ResolveOp):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::registers):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):

  • runtime/SymbolTable.h:

LayoutTests:

Reviewed by Oliver Hunt.

  • js/regress/infer-one-time-closure-expected.txt: Added.
  • js/regress/infer-one-time-closure-ten-vars-expected.txt: Added.
  • js/regress/infer-one-time-closure-ten-vars.html: Added.
  • js/regress/infer-one-time-closure-two-vars-expected.txt: Added.
  • js/regress/infer-one-time-closure-two-vars.html: Added.
  • js/regress/infer-one-time-closure.html: Added.
  • js/regress/infer-one-time-deep-closure-expected.txt: Added.
  • js/regress/infer-one-time-deep-closure.html: Added.
  • js/regress/script-tests/infer-one-time-closure-ten-vars.js: Added.
  • js/regress/script-tests/infer-one-time-closure-two-vars.js: Added.
  • js/regress/script-tests/infer-one-time-closure.js: Added.
  • js/regress/script-tests/infer-one-time-deep-closure.js: Added.
8:34 PM Changeset in webkit [159833] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
https://bugs.webkit.org/show_bug.cgi?id=124955

Reviewed by Dan Bernstein.

Use the new PageClient function to remove the need for WKContentView to take over the WKPageUIClient.

  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _commonInitWithProcessGroup:browsingContextGroup:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

7:23 PM Changeset in webkit [159832] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the iOS build.

  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:
  • UIProcess/API/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:
7:14 PM Changeset in webkit [159831] by weinig@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit

Fix the iOS build.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

  • WebView/WebAllowDenyPolicyListener.h: Added.
  • WebView/WebUIDelegatePrivate.h:

Move the WebAllowDenyPolicyListener protocol to its own file.

6:25 PM Changeset in webkit [159830] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=124953

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController processGroup]):
(-[WKBrowsingContextController browsingContextGroup]):
Add accessors.

6:03 PM Changeset in webkit [159829] by weinig@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

Make WKProcessGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124952

Reviewed by Dan Bernstein.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add support for WKProcessGroup.

  • UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
(-[WKProcessGroup API::]):
(-[WKProcessGroup _contextRef]):
(-[WKProcessGroup _geolocationProvider]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline

  • UIProcess/API/mac/WKProcessGroupInternal.h: Added.

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::create):
(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

Make the WebContext constructor public (for use with Object::constructInWrapper) and remove unused ProcessModel parameter.

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

5:20 PM Changeset in webkit [159828] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] The remote inspector does not show the base page.
https://bugs.webkit.org/show_bug.cgi?id=124942

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-27
Reviewed by Gyuyoung Kim.

On EFL the remote inspector does not show the base page about
which pages are available for debug. This should be fixed for
further inspector development.

  • Source/PlatformEfl.cmake:
5:05 PM Changeset in webkit [159827] by eric.carlson@apple.com
  • 37 edits
    9 adds in trunk

Allow the QuickTime plug-in to be replaced by script in an isolated word
https://bugs.webkit.org/show_bug.cgi?id=124900

Reviewed by Dean Jackson.

Source/WebCore:

Test: plugins/quicktime-plugin-replacement.html

  • CMakeLists.txt: Add new Modules path.
  • DerivedSources.make: Add new files.
  • GNUmakefile.am: Add new Modules path.
  • GNUmakefile.list.am: Add new header.
  • WebCore.vcxproj/WebCore.vcxproj: Add new header.
  • WebCore.vcxproj/WebCoreCommon.props: Add new Modules path.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • Modules/plugins: Added.
  • Modules/plugins/PluginReplacement.h: Added. Defines the interface for a plug-in replacement.

Create a replacement for the QuickTime plug-in.

  • Modules/plugins/QuickTimePluginReplacement.cpp: Added.
  • Modules/plugins/QuickTimePluginReplacement.css: Added.
  • Modules/plugins/QuickTimePluginReplacement.h: Added.
  • Modules/plugins/QuickTimePluginReplacement.idl: Added.
  • Modules/plugins/QuickTimePluginReplacement.js: Added.

Allow plug-in replacement to be enabled at runtime.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setPluginReplacementEnabled):
(WebCore::RuntimeEnabledFeatures::pluginReplacementEnabled):

  • bindings/js/JSDOMBinding.h:

(WebCore::toJS): Add toJS(... const String& ...).

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject): Give a plug-in replacement a first shot at defining the

script interface.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Call base class requestObject.

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::fileSize): New, passthrough to media engine.

  • html/HTMLMediaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Call base class requestObject.

Moved some logic that was previously used only for creating a plug-in snapshot to the base
class so it can be shared by a plug-in replacement.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize timer used to swap renderers.
(WebCore::HTMLPlugInElement::createRenderer): Allow plug-in replacement to create the renderer.
(WebCore::HTMLPlugInElement::swapRendererTimerFired): Create a shadow root.
(WebCore::HTMLPlugInElement::setDisplayState): Set the new state, prime the swap renderer

timer if necessary.

(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): Tell the plug-in replacement to

install itself in the new shadow DOM.

(WebCore::registeredPluginReplacements): Return vector of all registered plug-in replacements.
(WebCore::registerPluginReplacement): Add a plug-in replacement.
(WebCore::pluginReplacementForType): Find a plug-in replacement for a MIME type.
(WebCore::HTMLPlugInElement::requestObject): If there is a plug-in replacement for the MIME type,

create it and set the display state.

(WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Return the script object for

the current plug-in replacement, if any.

  • html/HTMLPlugInElement.h:

Move some plug-in snapshot code into the base class.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): No need to initialize timer.
(WebCore::HTMLPlugInImageElement::setDisplayState): Call base class.
(WebCore::HTMLPlugInImageElement::createRenderer): Ditto.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Ditto.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Remove unnecessary class name.
(WebCore::HTMLPlugInImageElement::requestObject): New.

  • html/HTMLPlugInImageElement.h:
  • html/HTMLVideoElement.h: Make createRenderer public so the QuickTime plug-in replacement can

call it.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::fileSize): New.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): totalBytes returns an unsigned long long.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::fileSize):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes): Return an unsigned long long.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes): Ditto.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Backup the plug-in replacement runtime setting.
(WebCore::InternalSettings::Backup::restoreTo): Restore it.
(WebCore::InternalSettings::setPluginReplacementEnabled): Set it.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

  • platform/efl/TestExpectations: Skip the new test.
  • platform/gtk/TestExpectations: Ditto.
  • platform/wincairo/TestExpectations: Ditto.
  • plugins/quicktime-plugin-replacement.html: Added.
  • plugins/quicktime-plugin-replacement-expected.txt: Added.
  • plugins/resources/orange.mov: Replace movie compressed with ancient (and deprecated)

animated gif codec with one compressed with H.264 codec.

4:22 PM Changeset in webkit [159826] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Finally fix some obvious Bartlett bugs
https://bugs.webkit.org/show_bug.cgi?id=124951

Reviewed by Mark Hahnenberg.

Sanitize the stack (i.e. zero parts of it known to be dead) at three key points:

  • GC.


  • At beginning of OSR entry.


  • Just as we finish preparing OSR entry. This clears those slots on the stack that could have been live in baseline but that are known to be dead in DFG.


This is as much as a 2x speed-up on splay if you run it in certain modes, and run it
for a long enough interval. It appears to fix all instances of the dreaded exponential
heap growth that splay gets into when some stale pointer stays around.

This doesn't have much of an effect on real-world programs. This bug has only ever
manifested in splay and for that reason we thus far opted against fixing it. But splay
is, for what it's worth, the premiere GC stress test in JavaScript - so making sure we
can run it without pathologies - even when you tweak its configuration - is probably
fairly important.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:
  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::sanitizeStack):

  • interpreter/JSStack.h:
3:15 PM Changeset in webkit [159825] by fpizlo@apple.com
  • 15 edits
    1 add in trunk

Do bytecode validation as part of testing
https://bugs.webkit.org/show_bug.cgi?id=124913

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Also fix some small bugs in the bytecode liveness analysis that I found by doing
this validation thingy.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::validate):
(JSC::CodeBlock::beginValidationDidFail):
(JSC::CodeBlock::endValidationDidFail):

  • bytecode/CodeBlock.h:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::prepareForExecutionImpl):

  • runtime/Options.h:

Source/WTF:

Reviewed by Oliver Hunt.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/FastBitVector.cpp: Added.

(WTF::FastBitVector::dump):

  • wtf/FastBitVector.h:

(WTF::FastBitVector::resize):
(WTF::FastBitVector::bitCount):
(WTF::FastBitVector::arrayLength):

Tools:

Reviewed by Oliver Hunt.

  • Scripts/run-jsc-stress-tests:
2:48 PM Changeset in webkit [159824] by weinig@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

Make WKBrowsingContextGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124948

Reviewed by Dan Bernstein.

  • Adds mechanism to use the inline data wrapping mechanism when the Objective-C wrapper is created by the caller (rather than by Object::newObject).
  • Adopts the mechanism for WKBrowsingContextGroup.
  • Shared/APIObject.h:

(API::Object::constructInWrapper):
Add a helper which does a forwarding placement-new into the API::Object of the passed in wrapper, after which it sets up m_wrapper.

(API::TypedObject::operator new):
Add a operator new to for placement-new. Also make TypedObject friends with Object so that constructInWrapper can call this.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add support for WKBrowsingContextGroup.

  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup API::]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserStyleSheets]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserScripts]):
(-[WKBrowsingContextGroup _pageGroupRef]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline (modeled on WKBackForwardList).

  • UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):

  • UIProcess/WebPageGroup.h:

Make the WebPageGroup constructor public (for use with Object::constructInWrapper) and move being set in the webPageGroupMap()
to the constructor.

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

1:03 PM Changeset in webkit [159823] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Adding MediaConstraintsMock class
https://bugs.webkit.org/show_bug.cgi?id=124902

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-27
Reviewed by Eric Carlson.

Validate constraints used in RTCPeerConnection LayoutTests

Source/WebCore:

Existing test was updated.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • platform/mock/MediaConstraintsMock.cpp: Added.
  • platform/mock/MediaConstraintsMock.h: Added.
  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::validateRequestConstraints): Now using MediaConstraintsMock
(WebCore::MockMediaStreamCenter::createMediaStream): Ditto.

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::initialize): Ditto.

LayoutTests:

  • fast/mediastream/RTCPeerConnection-expected.txt:
12:19 PM Changeset in webkit [159822] by betravis@adobe.com
  • 10 edits in trunk

[CSS Shapes] Shape-Inside Should Default to 'auto'
https://bugs.webkit.org/show_bug.cgi?id=124851

Reviewed by Alexandru Chiculita.

Source/WebCore:

The current shape-inside specification has the property default to the 'auto'
value, not 'outside-shape'.

Updated tests are under fast/shapes.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

LayoutTests:

Update tests to reflect a default shape-inside value of 'auto'.

  • fast/shapes/css-shapes-disabled-expected.txt:
  • fast/shapes/css-shapes-disabled.html:
  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-inside.html:
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
12:17 PM Changeset in webkit [159821] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Shapes] shape-inside rectangle layout can fail
https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Andreas Kling.

Source/WebCore:

Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

Regression test.

  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.
11:02 AM Changeset in webkit [159820] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/Source

Remove Qt-specific .qrc files
https://bugs.webkit.org/show_bug.cgi?id=124944

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-27
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

  • WebCore.qrc: Removed.

Source/WebKit2:

  • WebKit2.qrc: Removed.
9:41 AM Changeset in webkit [159819] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
https://bugs.webkit.org/show_bug.cgi?id=124940

Patch by Andres Gomez <Andres Gomez> on 2013-11-27
Reviewed by Martin Robinson.

xserver-font-utils is needed for building gtk port dependencies
with jhbuild.

  • gtk/install-dependencies: Added xserver-font-utils to jhbuild

dependecies.

9:24 AM Changeset in webkit [159818] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
https://bugs.webkit.org/show_bug.cgi?id=124938

Patch by Andres Gomez <Andres Gomez> on 2013-11-27
Reviewed by Philippe Normand.

Added needed git dependency for building the gtk port with
jhbuild. Also, the dependencies needed for building the gtk port
are now sorted alphabetically.

  • gtk/install-dependencies: Added git as jhbuild dependency and

sorted dependencies alphabetically.

8:35 AM Changeset in webkit [159817] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

Remove Sparc specific code.
https://bugs.webkit.org/show_bug.cgi?id=124941

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-27
Reviewed by Michael Saboff.

Sparc is not supported, remove leftover code.

  • wtf/Platform.h:
  • wtf/dtoa/utils.h:
8:23 AM WebKitGTK/Releasing edited by Andres Gomez
(diff)
8:22 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
8:16 AM WebKitGTK/Releasing edited by Andres Gomez
(diff)
8:12 AM Changeset in webkit [159816] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix after r159805.

  • resources/runner.js:
8:09 AM WebKitGTK/StableRelease created by Andres Gomez
8:02 AM WebKitGTK edited by Andres Gomez
(diff)
7:55 AM Changeset in webkit [159815] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run_webkit_tests.py: error: no such option: --wincairo
https://bugs.webkit.org/show_bug.cgi?id=124927

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-27
Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports

the layout testing on wincairo, so it is turned off.

7:10 AM Changeset in webkit [159814] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Structure::m_staticFunctionReified should be a single bit.
<https://webkit.org/b/124912>

Shave 8 bytes off of JSC::Structure by jamming m_staticFunctionReified
into the bitfield just above.

Reviewed by Antti Koivisto.

7:05 AM Changeset in webkit [159813] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSActivation constructor should use NotNull placement new.
<https://webkit.org/b/124909>

Knock a null check outta the storage initialization loop.

Reviewed by Antti Koivisto.

6:34 AM Changeset in webkit [159812] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for flaky tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
5:04 AM Changeset in webkit [159811] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

4:21 AM WebKitGTK/SpeedUpBuild edited by Manuel Rego Casasnovas
Fix typo (diff)
3:48 AM WebKitGTK/SpeedUpBuild edited by Manuel Rego Casasnovas
Add documentation about icecc (diff)
2:47 AM Changeset in webkit [159810] by calvaris@igalia.com
  • 3 edits
    2 adds in trunk

[GStreamer] Invalid command line error when visiting www.chessbase.com
https://bugs.webkit.org/show_bug.cgi?id=124715

Reviewed by Philippe Normand.

Source/WebCore:

We were not handling the HTTP errors in the WebKit GStreamer
source and therefore the 404 error page was being 'decoded'. As no
decoder could be found (for obvious reasons), playback failed, but
it should be failing for the source not being found instead of the
decoding problem.

Test: http/tests/media/video-error-does-not-exist.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Handle HTTP errors in
the source and raise a GStreamer error to the pipeline.

LayoutTests:

Copied and adapted for HTTP from
media/video-error-does-not-exist.html.

  • http/tests/media/video-error-does-not-exist-expected.txt: Added.
  • http/tests/media/video-error-does-not-exist.html: Added.
12:43 AM Changeset in webkit [159809] by svillar@igalia.com
  • 8 edits
    2 adds in trunk

[CSS Grid Layout] Fix positioning of grid items with margins
https://bugs.webkit.org/show_bug.cgi?id=124345

Reviewed by David Hyatt.

From Blink r157925 and r158041 by <jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-margin-resolution.html

Adds margin start/before to the positions of grid items (removing
several FIXME's in the current code). This means calling
findChildLogicalPosition() after the layout in order to have the
right values for the margins.

In order to match flexbox and author's intents we're also
including the margins of grid items in the intrinsic size of the
grid. That's why flexbox's marginLogicalPositionForChild() is
moved up to RenderBlock in order to share it with RenderGrid.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
from RenderFlexibleBox::marginLogicalWidthForChild().

  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

LayoutTests:

New test case for grid items margin resolution. Extended the
preferred logical widths checks with grid items with margins.

  • fast/css-grid-layout/grid-item-margin-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-item-margin-resolution.html: Added.
  • fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
  • fast/css-grid-layout/grid-preferred-logical-widths.html:
12:31 AM Changeset in webkit [159808] by svillar@igalia.com
  • 7 edits
    2 adds in trunk

[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
https://bugs.webkit.org/show_bug.cgi?id=103312

Reviewed by Andreas Kling.

PerformanceTests:

Use the repeat() syntax to build the huge grids used by the
performance tests.

  • Layout/auto-grid-lots-of-data.html:
  • Layout/fixed-grid-lots-of-data.html:

Source/WebCore:

Added support for the repeat() syntax inside
grid-definition-{rows|columns} by just adding the repeated values
to our list of column|row definitions.

The parsing of <track-name> was refactored in a new function as
it's used now in three different places. The <track-size> parsing
was also refactored to share it with the repeat() parsing.

Test: fast/css-grid-layout/grid-element-repeat-get-set.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):

  • css/CSSParser.h:

LayoutTests:

Based on Blink r153155 by <jchaffraix@chromium.org>. Some code was
refactored in a helper function to have a more compact test.

  • fast/css-grid-layout/grid-element-repeat-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-element-repeat-get-set.html: Added.
Note: See TracTimeline for information about the timeline view.