Timeline



Dec 2, 2013:

10:20 PM Changeset in webkit [159993] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS initWithContext:]):

9:53 PM Changeset in webkit [159992] by commit-queue@webkit.org
  • 6 edits
    2 copies in trunk/Source/WebKit2

Add ability to iterate over API::Array
​https://bugs.webkit.org/show_bug.cgi?id=124533

Patch by Martin Hock <​mhock@apple.com> on 2013-12-02
Reviewed by Sam Weinig.

  • GNUmakefile.list.am:
  • Shared/APIArray.h:
  • Shared/FilterIterator.h:
  • Shared/IteratorPair.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::toStringVector):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

8:25 PM Changeset in webkit [159991] by mitz@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

[Cocoa] WebProtectionSpace has a generic wrapper
​https://bugs.webkit.org/show_bug.cgi?id=125125

Reviewed by Anders Carlsson.

Added WKNSURLProtectionSpace.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKNSURLProtectionSpace if the object is a
WebProtectionSpace.

  • Shared/Cocoa/WKNSURLProtectionSpace.h: Added.

(WebKit::wrapper): Added. Returns a WebProtecitonSpace’s wrapper as an NSURLProtectionSpace.

  • Shared/Cocoa/WKNSURLProtectionSpace.mm: Added.

(-[WKNSURLProtectionSpace copyWithZone:]): Retains self.

  • UIProcess/Authentication/WebProtectionSpace.h:

(WebKit::WebProtectionSpace::protectionSpace): Added an accessor for the
WebCore::ProtectionSpace.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
8:19 PM Changeset in webkit [159990] by fpizlo@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
​https://bugs.webkit.org/show_bug.cgi?id=125130

Reviewed by Geoffrey Garen.

  • Scripts/run-jsc-stress-tests:
7:19 PM Changeset in webkit [159989] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Avoid setting style twice for generated image content.
<​https://webkit.org/b/125128>

Take care of a FIXME I added in r158097 and avoid redundant work in
ImageContentData::createRenderer().

I changed the inheritance helper RenderImage::setPseudoStyle() into
a new createStyleInheritingFromPseudoStyle() function instead so it
can be used from both PseudoElement and ImageContentData.

Reviewed by Antti Koivisto.

6:36 PM Changeset in webkit [159988] by andersca@apple.com
  • 91 edits in trunk/Source/WebKit2

Replace uses of WebKit::APIClient with API::Client
​https://bugs.webkit.org/show_bug.cgi?id=125129

Reviewed by Andreas Kling.

  • Shared/API/c/WKConnectionRef.cpp:

(WKConnectionSetConnectionClient):

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::initializeConnectionClient):

  • Shared/WebConnection.h:
  • Shared/WebConnectionClient.cpp:

(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):

  • Shared/WebConnectionClient.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetClient):
(WKContextSetInjectedBundleClient):
(WKContextSetHistoryClient):
(WKContextSetDownloadClient):
(WKContextSetConnectionClient):

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

  • UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerSetProvider):

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):

  • UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerSetProvider):

  • UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerSetChangeClient):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageFindMatchesClient):
(WKPageSetPageFormClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::initializeProvider):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):
(WebKit::WebNotificationProvider::cancel):
(WebKit::WebNotificationProvider::didDestroyNotification):
(WebKit::WebNotificationProvider::clearNotifications):
(WebKit::WebNotificationProvider::addNotificationManager):
(WebKit::WebNotificationProvider::removeNotificationManager):
(WebKit::WebNotificationProvider::notificationPermissions):

  • UIProcess/Notifications/WebNotificationProvider.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeClient):
(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::initializeConnectionClient):
(WebKit::WebContext::initializeHistoryClient):
(WebKit::WebContext::initializeDownloadClient):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::plugInAutoStartOriginHashesChanged):
(WebKit::WebContextClient::networkProcessDidCrash):
(WebKit::WebContextClient::plugInInformationBecameAvailable):

  • UIProcess/WebContextClient.h:
  • UIProcess/WebContextConnectionClient.cpp:

(WebKit::WebContextConnectionClient::didCreateConnection):

  • UIProcess/WebContextConnectionClient.h:
  • UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::initializeClient):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebCookieManagerProxyClient.cpp:

(WebKit::WebCookieManagerProxyClient::cookiesDidChange):

  • UIProcess/WebCookieManagerProxyClient.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::initializeClient):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxyClient.cpp:

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxyClient.h:
  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didReceiveAuthenticationChallenge):
(WebKit::WebDownloadClient::didReceiveResponse):
(WebKit::WebDownloadClient::didReceiveData):
(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
(WebKit::WebDownloadClient::didFail):
(WebKit::WebDownloadClient::didCancel):
(WebKit::WebDownloadClient::processDidCrash):

  • UIProcess/WebDownloadClient.h:
  • UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::didFindString):
(WebKit::WebFindClient::didFailToFindString):
(WebKit::WebFindClient::didCountStringMatches):
(WebKit::WebFindMatchesClient::didFindStringMatches):
(WebKit::WebFindMatchesClient::didGetImageForMatchResult):

  • UIProcess/WebFindClient.h:
  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::initializeProvider):

  • UIProcess/WebGeolocationManagerProxy.h:
  • UIProcess/WebGeolocationProvider.cpp:

(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):
(WebKit::WebGeolocationProvider::setEnableHighAccuracy):

  • UIProcess/WebGeolocationProvider.h:
  • UIProcess/WebHistoryClient.cpp:

(WebKit::WebHistoryClient::didNavigateWithNavigationData):
(WebKit::WebHistoryClient::didPerformClientRedirect):
(WebKit::WebHistoryClient::didPerformServerRedirect):
(WebKit::WebHistoryClient::didUpdateHistoryTitle):
(WebKit::WebHistoryClient::populateVisitedLinks):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::initializeIconDatabaseClient):

  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabaseClient.cpp:

(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):
(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):

  • UIProcess/WebIconDatabaseClient.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::setChangeClient):

  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebOriginDataManagerProxyChangeClient.cpp:

(WebKit::WebOriginDataManagerProxyChangeClient::didChange):

  • UIProcess/WebOriginDataManagerProxyChangeClient.h:
  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::customContextMenuItemSelected):
(WebKit::WebPageContextMenuClient::contextMenuDismissed):
(WebKit::WebPageContextMenuClient::showContextMenu):
(WebKit::WebPageContextMenuClient::hideContextMenu):

  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializePolicyClient):
(WebKit::WebPageProxy::initializeFormClient):
(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::initializeFindClient):
(WebKit::WebPageProxy::initializeFindMatchesClient):
(WebKit::WebPageProxy::initializeContextMenuClient):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):
(WebKit::WebPolicyClient::unableToImplementPolicy):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):
(WebKit::WebUIClient::showPage):
(WebKit::WebUIClient::close):
(WebKit::WebUIClient::takeFocus):
(WebKit::WebUIClient::focus):
(WebKit::WebUIClient::unfocus):
(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):
(WebKit::WebUIClient::setStatusText):
(WebKit::WebUIClient::mouseDidMoveOverElement):
(WebKit::WebUIClient::unavailablePluginButtonClicked):
(WebKit::WebUIClient::didNotHandleKeyEvent):
(WebKit::WebUIClient::didNotHandleWheelEvent):
(WebKit::WebUIClient::toolbarsAreVisible):
(WebKit::WebUIClient::setToolbarsAreVisible):
(WebKit::WebUIClient::menuBarIsVisible):
(WebKit::WebUIClient::setMenuBarIsVisible):
(WebKit::WebUIClient::statusBarIsVisible):
(WebKit::WebUIClient::setStatusBarIsVisible):
(WebKit::WebUIClient::isResizable):
(WebKit::WebUIClient::setIsResizable):
(WebKit::WebUIClient::setWindowFrame):
(WebKit::WebUIClient::windowFrame):
(WebKit::WebUIClient::runBeforeUnloadConfirmPanel):
(WebKit::WebUIClient::didDraw):
(WebKit::WebUIClient::pageDidScroll):
(WebKit::WebUIClient::exceededDatabaseQuota):
(WebKit::WebUIClient::runOpenPanel):
(WebKit::WebUIClient::decidePolicyForGeolocationPermissionRequest):
(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):
(WebKit::WebUIClient::headerHeight):
(WebKit::WebUIClient::footerHeight):
(WebKit::WebUIClient::drawHeader):
(WebKit::WebUIClient::drawFooter):
(WebKit::WebUIClient::printFrame):
(WebKit::WebUIClient::runModal):
(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
(WebKit::WebUIClient::shouldInterruptJavaScript):
(WebKit::WebUIClient::showColorPicker):
(WebKit::WebUIClient::hideColorPicker):

  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):
(WKBundlePageSetEditorClient):
(WKBundlePageSetFormClient):
(WKBundlePageSetPageLoaderClient):
(WKBundlePageSetResourceLoadClient):
(WKBundlePageSetPolicyClient):
(WKBundlePageSetUIClient):
(WKBundlePageSetFullScreenClient):
(WKBundlePageSetDiagnosticLoggingClient):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::initializeClient):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp:

(WebKit::InjectedBundleClient::didCreatePage):
(WebKit::InjectedBundleClient::willDestroyPage):
(WebKit::InjectedBundleClient::didInitializePageGroup):
(WebKit::InjectedBundleClient::didReceiveMessage):
(WebKit::InjectedBundleClient::didReceiveMessageToPage):

  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
(WebKit::InjectedBundlePageEditorClient::didBeginEditing):
(WebKit::InjectedBundlePageEditorClient::didEndEditing):
(WebKit::InjectedBundlePageEditorClient::didChange):
(WebKit::InjectedBundlePageEditorClient::didChangeSelection):
(WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard):
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
(WebKit::InjectedBundlePageEditorClient::didWriteToPasteboard):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::didFocusTextField):
(WebKit::InjectedBundlePageFormClient::textFieldDidBeginEditing):
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):
(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayout):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
(WebKit::InjectedBundlePageLoaderClient::shouldForceUniversalAccessFromLocalURL):
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
(WebKit::InjectedBundlePageLoaderClient::willDestroyFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
(WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
(WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse):
(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage):

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldGenerateFileForUpload):
(WebKit::InjectedBundlePageUIClient::generateFileForUpload):
(WebKit::InjectedBundlePageUIClient::statusBarIsVisible):
(WebKit::InjectedBundlePageUIClient::menuBarIsVisible):
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible):
(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet):
(WebKit::InjectedBundlePageUIClient::plugInExtraScript):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleContextMenuClient):
(WebKit::WebPage::initializeInjectedBundleEditorClient):
(WebKit::WebPage::initializeInjectedBundleFormClient):
(WebKit::WebPage::initializeInjectedBundleLoaderClient):
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
(WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
(WebKit::WebPage::initializeInjectedBundleUIClient):
(WebKit::WebPage::initializeInjectedBundleFullScreenClient):
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):

  • WebProcess/WebPage/WebPage.h:
5:32 PM Changeset in webkit [159987] by mark.lam@apple.com
  • 12 edits in trunk/Source

Build failure when disabling JIT, YARR_JIT, and ASSEMBLER.
​https://bugs.webkit.org/show_bug.cgi?id=123809.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Also fixed build when disabling the DISASSEMBLER.
Added some needed #if's and some comments.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

  • dfg/DFGDisassembler.cpp:
  • dfg/DFGDisassembler.h:

(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::setStartOfCode):
(JSC::DFG::Disassembler::setForBlockIndex):
(JSC::DFG::Disassembler::setForNode):
(JSC::DFG::Disassembler::setEndOfMainPath):
(JSC::DFG::Disassembler::setEndOfCode):
(JSC::DFG::Disassembler::dump):
(JSC::DFG::Disassembler::reportToProfiler):

  • disassembler/Disassembler.cpp:
  • disassembler/X86Disassembler.cpp:
  • jit/FPRInfo.h:
  • jit/GPRInfo.h:
  • jit/JITDisassembler.cpp:
  • jit/JITDisassembler.h:

(JSC::JITDisassembler::JITDisassembler):
(JSC::JITDisassembler::setStartOfCode):
(JSC::JITDisassembler::setForBytecodeMainPath):
(JSC::JITDisassembler::setForBytecodeSlowPath):
(JSC::JITDisassembler::setEndOfSlowPath):
(JSC::JITDisassembler::setEndOfCode):
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::reportToProfiler):

Source/WTF:

  • wtf/Platform.h:
  • Ensure that the ASSEMBLER is enabled when the DISASSEMBLER is enabled.
5:27 PM Changeset in webkit [159986] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Possible crash in ProgressTracker::progressHeartbeatTimerFired(Timer<ProgressTracker>*)
​https://bugs.webkit.org/show_bug.cgi?id=125110

Reviewed by Darin Adler.

FrameLoader::loadProgressingStatusChanged() might be called while the Frame has a null FrameView.

It’s unclear how to reproduce, but there’s no harm in a null check.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

5:12 PM Changeset in webkit [159985] by enrica@apple.com
  • 17 edits in trunk/Source/WebKit2

Merging some more iOS WebKit2 stuff.
​https://bugs.webkit.org/show_bug.cgi?id=125119

Reviewed by Tim Horton.

  • Shared/EditorState.h:
  • Shared/NativeWebKeyboardEvent.h:
  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/mac/RemoteLayerBackingStore.h:
  • Shared/mac/RemoteLayerTreePropertyApplier.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/PageClient.h:
  • UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.mm:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
  • UIProcess/mac/SecItemShimProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
5:11 PM Changeset in webkit [159984] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Add versioned structs for the remaining clients
​https://bugs.webkit.org/show_bug.cgi?id=125123

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextConnectionClient.h:
  • UIProcess/API/C/WKContextDownloadClient.h:
  • UIProcess/API/C/WKContextHistoryClient.h:
  • UIProcess/API/C/WKContextInjectedBundleClient.h:
  • UIProcess/API/C/WKOriginDataManager.h:
4:54 PM Changeset in webkit [159983] by andersca@apple.com
  • 3 edits
    4 adds in trunk/Source/WebKit2

Move WKContext clients to separate files
​https://bugs.webkit.org/show_bug.cgi?id=125121

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextConnectionClient.h: Added.
  • UIProcess/API/C/WKContextDownloadClient.h: Added.
  • UIProcess/API/C/WKContextHistoryClient.h: Added.
  • UIProcess/API/C/WKContextInjectedBundleClient.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
4:43 PM Changeset in webkit [159982] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

WebPageGroups should keep track of what processes they are being used by
​https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Anders Carlsson.

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::addProcess):
(WebKit::WebPageGroup::disconnectProcess):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::webPageGroup):
(WebKit::WebProcessProxy::addWebPageGroup):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

4:40 PM Changeset in webkit [159981] by andersca@apple.com
  • 26 edits in trunk/Source/WebKit2

Add versioned structs for all clients except the ones in WKContext.h
​https://bugs.webkit.org/show_bug.cgi?id=125120

Reviewed by Andreas Kling.

  • Shared/API/c/WKConnectionRef.h:
  • UIProcess/API/C/WKCookieManager.h:
  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/API/C/WKIconDatabase.h:
  • UIProcess/API/C/WKNotificationProvider.h:
  • UIProcess/API/C/WKPageContextMenuClient.h:
  • UIProcess/API/C/WKPageFindClient.h:
  • UIProcess/API/C/WKPageFindMatchesClient.h:
  • UIProcess/API/C/WKPageFormClient.h:
  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/API/C/WKPagePolicyClient.h:
  • UIProcess/API/C/WKPageUIClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
4:36 PM Changeset in webkit [159980] by Samuel White
  • 18 edits
    2 adds in trunk

AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
​https://bugs.webkit.org/show_bug.cgi?id=124561

Reviewed by Chris Fleizach.

Added test to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute
works as it should and updated existing test that has exposes this new attribute.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/search-predicate-element-count-expected.txt: Added.
  • platform/mac/accessibility/search-predicate-element-count.html: Added.

Added ability to fetch the number of elements that match a specific criteria. This will enable VoiceOver
to interface with WebKit much more dynamically. We can now get an idea of how many interesting elements
exist on a page, and then fetch them in chunks as needed.

Test: platform/mac/accessibility/search-predicate-element-count.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute): (-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.

  • DumpRenderTree/AccessibilityUIElement.cpp: (uiElementCountForSearchPredicateCallback): (uiElementForSearchPredicateCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate):
  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::uiElementCountForSearchPredicate):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (searchPredicateParameterizedAttributeForSearchCriteria): (AccessibilityUIElement::uiElementCountForSearchPredicate): (AccessibilityUIElement::uiElementForSearchPredicate):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate):
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::searchPredicateParameterizedAttributeForSearchCriteria): (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4:10 PM Changeset in webkit [159979] by Bem Jones-Bey
  • 32 edits
    12 adds in trunk

[css shapes] Layout support for new circle shape syntax
​https://bugs.webkit.org/show_bug.cgi?id=124619

Reviewed by Dirk Schulze.

Source/WebCore:

Implement support for doing layout with the new circle shape syntax,
inclduing basic animation support.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html

fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html

  • css/BasicShapeFunctions.cpp:

(WebCore::floatValueForCenterCoordinate): Used by both the CSS Shapes

layout code and the clip path code.

  • css/BasicShapeFunctions.h:
  • css/CSSBasicShapes.cpp:

(WebCore::buildCircleString): Update to use appendLiteral, and remove

call to reserveCapacity - if we find that it's actually slow when
doing performance tests, we can hopefully do something smarter and
less ugly than that.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeRadius): Fix a logic error that caused

the radius keywords not to work properly.

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Convert new circle to a layout shape.

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend): Ignore circles with values that

cannot be interpolated.

(WebCore::BasicShapeCircle::floatValueForRadiusInBox): Convert circle

radius keywords to a float value.

(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeCircle::blend):

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::canBlend):
(WebCore::BasicShapeRadius::canBlend):

LayoutTests:

Add a few tests for the new circle syntax. The old tests in
LayoutTests/csswg will be removed when the old syntax is removed.

Also update existing shape-inside, animation, and clip-path tests to
test the new syntax.

  • animations/resources/animation-test-helpers.js:

(parseBasicShape):

  • LayoutTests/animations/resources/animation-test-helpers.js:
  • LayoutTests/css3/masking/clip-path-animation-expected.txt:
  • LayoutTests/css3/masking/clip-path-animation.html:
  • LayoutTests/css3/masking/clip-path-circle-filter.html:
  • LayoutTests/css3/masking/clip-path-circle-overflow-hidden.html:
  • LayoutTests/css3/masking/clip-path-circle-overflow.html:
  • LayoutTests/css3/masking/clip-path-circle-relative-overflow.html:
  • LayoutTests/css3/masking/clip-path-circle.html:
  • LayoutTests/css3/masking/clip-path-restore.html:
  • LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • LayoutTests/fast/shapes/parsing/parsing-test-utils.js:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-animation-expected.txt:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash.html:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-circle-padding.html:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-circle.html:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-nested.html:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html:
  • LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html:
  • fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
  • fast/shapes/shape-outside-floats/shape-outside-animation.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-003-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-004-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-005-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html: Added.
3:55 PM Changeset in webkit [159978] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
​https://bugs.webkit.org/show_bug.cgi?id=124714

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-12-02
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.write_failure):
(FailureText):
(FailureText.write_failure):
(FailureAudio):
(FailureAudio.write_failure):
(FailureCrash.write_failure):
(FailureMissingResult):
(FailureTextMismatch):
(FailureMissingImageHash.write_failure):
(FailureMissingImage.write_failure):
(FailureImageHashMismatch.write_failure):
(FailureReftestMismatch.write_failure):
(FailureReftestMismatchDidNotOccur.write_failure):
(FailureMissingAudio):
(FailureAudioMismatch):

3:52 PM Changeset in webkit [159977] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Remove the stderr_write attribute from StyleProcessorConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=124703

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Ryosuke Niwa.

Remove the stderr_write attribute from this class in checker and
replace its use with calls to a logging module logger. We Should
use logging module instead of writing to stderr directly.

  • Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch): Remove FIXME comment.
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

  • Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.

There is an "ERROR" prefix in log messiges from now.
(StyleProcessorConfigurationTest):
(StyleProcessorConfigurationTest._style_checker_configuration):
(StyleProcessorConfigurationTest.test_init):
(StyleProcessorConfigurationTest.test_write_style_error_emacs):
(StyleProcessorConfigurationTest.test_write_style_error_vs7):
(StyleProcessor_EndToEndTest.with):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.setUp):

  • Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.

(DefaultStyleErrorHandler.call):

  • Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.

There is an "ERROR" prefix in log messiges from now.
(DefaultStyleErrorHandlerTest):
(DefaultStyleErrorHandlerTest.setUp):
(DefaultStyleErrorHandlerTest._mock_increment_error_count):
(DefaultStyleErrorHandlerTest._style_checker_configuration):
(DefaultStyleErrorHandlerTest._check_initialized):
(DefaultStyleErrorHandlerTest.test_non_reportable_error):
(DefaultStyleErrorHandlerTest.test_max_reports_per_category):
(DefaultStyleErrorHandlerTest.test_line_numbers):

3:48 PM Changeset in webkit [159976] by andersca@apple.com
  • 3 edits
    9 adds in trunk/Source/WebKit2

Split bundle page clients out into separate headers
​https://bugs.webkit.org/show_bug.cgi?id=125115

Reviewed by Andreas Kling.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: Added.
3:43 PM Changeset in webkit [159975] by ap@apple.com
  • 3 edits
    2 adds in trunk

WebCrypto HMAC doesn't check key algorithm's hash
​https://bugs.webkit.org/show_bug.cgi?id=125114

Reviewed by Anders Carlsson.

Source/WebCore:

Test: crypto/subtle/hmac-check-algorithm.html

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches): Check it.

LayoutTests:

  • crypto/subtle/hmac-check-algorithm-expected.txt: Added.
  • crypto/subtle/hmac-check-algorithm.html: Added.
3:30 PM Changeset in webkit [159974] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Possible crash in ProgressTracker::progressHeartbeatTimerFired(Timer<ProgressTracker>*)
​https://bugs.webkit.org/show_bug.cgi?id=125110

Reviewed by Darin Adler.

It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires.

On the surface this seems impossible because the only time m_originatingProgressFrame is cleared
out the heartbeat timer is also stopped.

But there’s likely still a race condition in multi-threaded environments.

There’s no harm in null-checking m_originatingProgressFrame before accessing its loader.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressHeartbeatTimerFired):

3:17 PM Changeset in webkit [159973] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
​https://bugs.webkit.org/show_bug.cgi?id=125107

Reviewed by Mark Hahnenberg.

Just killing dead code.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):

3:03 PM Changeset in webkit [159972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Improve readability of 'generate_message_handler' function
​https://bugs.webkit.org/show_bug.cgi?id=125085

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py:

(generate_message_handler):

2:59 PM Changeset in webkit [159971] by commit-queue@webkit.org
  • 2 edits
    7 adds in trunk/Source/Platform

Nix Upstream: Updating Platform files
​https://bugs.webkit.org/show_bug.cgi?id=124982

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-12-02
Reviewed by Benjamin Poulain.

Adding new Platform files that are missing in the trunk.

  • PlatformNix.cmake:
  • nix/public/AudioDestinationConsumer.h: Added.

(Nix::AudioDestinationConsumer::~AudioDestinationConsumer):

  • nix/public/MediaConstraints.h: Added.
  • nix/public/MediaStream.h: Added.
  • nix/public/MediaStreamAudioSource.h: Added.
  • nix/public/MediaStreamCenter.h: Added.
  • nix/public/MediaStreamSource.h: Added.
  • nix/public/PrivatePtr.h: Added.
2:56 PM Changeset in webkit [159970] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Add more CachedPage null checks
​https://bugs.webkit.org/show_bug.cgi?id=125106

Reviewed by Sam Weinig.

Only some functions in PageCache.cpp null-check the CachedPages in HistoryItems.

Every part that manipulates the CachedPage should.

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
(WebCore::PageCache::markPagesForCaptionPreferencesChanged):

2:53 PM Changeset in webkit [159969] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

Add JavaScript style checker and teach checker.py about .js files
​https://bugs.webkit.org/show_bug.cgi?id=125049

Patch by Brian J. Burg <Brian Burg> on 2013-12-02
Reviewed by Joseph Pecoraro.

Add a JavaScript file type, extension, and checker (JSChecker).
Use TextChecker for JavaScript tests, libraries, website resources,
etc. and use JSChecker for files within WebInspectorUI/UserInterface.

Amended tests for TextChecker to reflect the rule above.

  • Scripts/webkitpy/style/checker.py:

(_all_categories): Add categories defined by JSChecker.
(FileType): Add file type for JS and re-number the enum.
(CheckerDispatcher._file_type): Detect .js files as JavaScript.
(CheckerDispatcher._create_checker):
Create a JSChecker or TextChecker depending on the file's path.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_js): Added.
(CheckerDispatcherDispatchTest.test_js_paths): Added.
(CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
that end in .js but should be checked with TextChecker.

  • Scripts/webkitpy/style/checkers/js.py: Added.

(JSChecker):
(JSChecker.init):
(JSChecker.check):

  • Scripts/webkitpy/style/checkers/js_unittest.py: Added.

(JSTestCase):
(JSTestCase.assertNoError):
(JSTestCase.assertNoError.error_for_test):
(JSTestCase.assertError):
(JSTestCase.assertError.error_for_test):
(JSTestCase.test_no_error):
(JSTestCase.test_error):

2:48 PM Changeset in webkit [159968] by zoltan@webkit.org
  • 19 edits in trunk

[CSS Shapes] Support inset parsing
​https://bugs.webkit.org/show_bug.cgi?id=124903

Reviewed by David Hyatt.

Source/WebCore:

In this patch I added support for inset shape parsing for CSS Shapes. Inset is defined
by CSS Shapes Level 1 (​http://dev.w3.org/csswg/css-shapes-1/#supported-basic-shapes).
Inset is going to be used by shape-outside (bug #124905), and eventually by shape-inside.

No new tests, I updated existing tests to cover the changes.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape): Add support for inset.
(WebCore::basicShapeForValue): Add support for inset.

  • css/CSSBasicShapes.cpp:

(WebCore::buildInsetString): Create inset css string.
(WebCore::CSSBasicShapeInset::cssText): Convert inset shape to a CSS string.
(WebCore::CSSBasicShapeInset::equals): Compare two inset rectangles.
(WebCore::CSSBasicShapeInset::serializeResolvingVariables): Create an inset string, with CSS variables resolved.
(WebCore::CSSBasicShapeInset::hasVariableReference): Determine if this inset has any CSS Variable references.

  • css/CSSBasicShapes.h: Add inset class.

(WebCore::CSSBasicShapeInset::create):
(WebCore::CSSBasicShapeInset::top):
(WebCore::CSSBasicShapeInset::right):
(WebCore::CSSBasicShapeInset::bottom):
(WebCore::CSSBasicShapeInset::left):
(WebCore::CSSBasicShapeInset::topLeftRadius):
(WebCore::CSSBasicShapeInset::topRightRadius):
(WebCore::CSSBasicShapeInset::bottomRightRadius):
(WebCore::CSSBasicShapeInset::bottomLeftRadius):
(WebCore::CSSBasicShapeInset::setTop):
(WebCore::CSSBasicShapeInset::setRight):
(WebCore::CSSBasicShapeInset::setBottom):
(WebCore::CSSBasicShapeInset::setLeft):
(WebCore::CSSBasicShapeInset::setTopLeftRadius):
(WebCore::CSSBasicShapeInset::setTopRightRadius):
(WebCore::CSSBasicShapeInset::setBottomRightRadius):
(WebCore::CSSBasicShapeInset::setBottomLeftRadius):
(WebCore::CSSBasicShapeInset::CSSBasicShapeInset):

  • css/CSSParser.cpp:

(WebCore::completeBorderRadii): Move static function before parseInsetBorderRadius.
(WebCore::CSSParser::parseInsetRoundedCorners): I added this helper function for parsing the rounded corners
(WebCore::CSSParser::parseBasicShapeInset): Parse inset.
(WebCore::CSSParser::parseBasicShape): Add call to parse inset.

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add constructor for LengthSize.
(WebCore::CSSPrimitiveValue::init): Initialize LengthSize.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create): Add support for creating PrimitiveValue from LengthSize.

  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue): Add support for LengthSize.

  • platform/LengthSize.h:

(WebCore::LengthSize::blend): Add blend for LengthSize.

  • rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor): Keep inset disabled for shape-inside now.

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeInset::path): Calculate path for an inset.
(WebCore::BasicShapeInset::blend): Blend two insets.

  • rendering/style/BasicShapes.h: Add higher level inset.

(WebCore::BasicShapeInset::create):
(WebCore::BasicShapeInset::top):
(WebCore::BasicShapeInset::right):
(WebCore::BasicShapeInset::bottom):
(WebCore::BasicShapeInset::left):
(WebCore::BasicShapeInset::topLeftRadius):
(WebCore::BasicShapeInset::topRightRadius):
(WebCore::BasicShapeInset::bottomRightRadius):
(WebCore::BasicShapeInset::bottomLeftRadius):
(WebCore::BasicShapeInset::setTop):
(WebCore::BasicShapeInset::setRight):
(WebCore::BasicShapeInset::setBottom):
(WebCore::BasicShapeInset::setLeft):
(WebCore::BasicShapeInset::setTopLeftRadius):
(WebCore::BasicShapeInset::setTopRightRadius):
(WebCore::BasicShapeInset::setBottomRightRadius):
(WebCore::BasicShapeInset::setBottomLeftRadius):
(WebCore::BasicShapeInset::BasicShapeInset):

LayoutTests:

  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
2:42 PM Changeset in webkit [159967] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

Remote Layer Tree: Support cloning layers
​https://bugs.webkit.org/show_bug.cgi?id=124874
<rdar://problem/15349468>

Reviewed by Simon Fraser.

We use PlatformCALayer::clone for CSS reflections, so implement it.

Also, since many reflections testcases also use masks,
working on this revealed that masks weren't working, because
we weren't flushing mask layers.

  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Rename maskLayer->maskLayerID since it's a LayerID.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
Don't try to look up the layer if it's null.

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
Keep track of all properties that have ever been changed on a layer.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
(PlatformCALayerRemote::clone):
Copy all of the layer properties from the original to the clone,
and mark all properties that have ever been modified as
needing to be flushed to the UI process.

(PlatformCALayerRemote::recursiveBuildTransaction):
Flush our mask layer, if we have one.

(PlatformCALayerRemote::setMask):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Store the mask layer we're given. Our owning GraphicsLayer will
hold on to it for us.

2:36 PM Changeset in webkit [159966] by ap@apple.com
  • 9 edits
    7 adds in trunk

Support WebCrypto AES-KW
​https://bugs.webkit.org/show_bug.cgi?id=125105

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/aes-kw-key-manipulation.html

crypto/subtle/aes-kw-wrap-unwrap-aes.html

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • crypto/CryptoAlgorithmIdentifier.h: (WebCore::CryptoAlgorithmIdentifier): Added AES-KW.

It's not standardized yet, but there appears to be a consensus that it will be specified.

  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
Added AES-KW cases everywhere.

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
Support importing/exporting AES-KW keys in JWK.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
Added some accidentally forgotten std::moves.

  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp: Added.
  • crypto/algorithms/CryptoAlgorithmAES_KW.h: Added.
  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp: Added.
  • crypto/keys/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::CryptoKeyAES): Allow AES-KW

as valid algorithm for AES keys.

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-KW.

LayoutTests:

  • crypto/subtle/aes-kw-key-manipulation-expected.txt: Added.
  • crypto/subtle/aes-kw-key-manipulation.html: Added.
  • crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt: Added.
  • crypto/subtle/aes-kw-wrap-unwrap-aes.html: Added.
2:35 PM Changeset in webkit [159965] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

WKPageLoaderClient should be versioned
​https://bugs.webkit.org/show_bug.cgi?id=125104

Reviewed by Sam Weinig.

Add multiple versions of the WKPageLoaderClient struct. In a subsequent patch,
WKPageLoaderClient and kWKPageLoaderClientCurrentVersion will be deprecated. Instead,
users of the API are supposed to explicitly choose a version and a versioned struct.

  • Shared/APIClient.h:

Add a new API::Client class with a new ClientTraits template that uses std::tuple for versions.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:

Remove WKPageLoaderClient interface sizes.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
Add an explicit cast to WKPageLoaderClientBase. In an upcoming patch, WKPageSetPageLoaderClient
will be changed to take a WKPageLoaderClientBase instead.

  • UIProcess/API/C/WKPageLoaderClient.h:

Add new versions.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPageLoaderClient):
Use an explicit version.

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didLayout):
(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::WebLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::WebLoaderClient::didRunInsecureContentForFrame):
(WebKit::WebLoaderClient::didDetectXSSForFrame):
(WebKit::WebLoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
(WebKit::WebLoaderClient::processDidBecomeResponsive):
(WebKit::WebLoaderClient::processDidCrash):
(WebKit::WebLoaderClient::didChangeBackForwardList):
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem):
(WebKit::WebLoaderClient::willGoToBackForwardListItem):
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
Go through client.base everywhere.

  • UIProcess/WebLoaderClient.h:

Add API::ClientTraits specialization. Change WebLoaderClient to derive from API::Client<WKPageLoaderClientBase>.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient):
This now takes a WKPageLoaderClientBase*.

2:33 PM Changeset in webkit [159964] by mhahnenberg@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests always copies the VM
​https://bugs.webkit.org/show_bug.cgi?id=125092

Reviewed by Filip Pizlo.

This can be slow, especially with full debug builds. It should just symlink the VM into the
bundle by default and do a full copy only when asked.

  • Scripts/run-jsc-stress-tests:
2:31 PM Changeset in webkit [159963] by Beth Dakin
  • 2 edits in trunk/Source/WebKit

Attempted build fix. I think this is no longer needed.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
2:25 PM Changeset in webkit [159962] by bshafiei@apple.com
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

2:21 PM Changeset in webkit [159961] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Port run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=124801

Reviewed by Filip Pizlo.

  • Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl

command on Windows so that stress tests can run.

2:06 PM WebInspectorCodingStyleGuide edited by timothy@apple.com
(diff)
1:53 PM Changeset in webkit [159960] by Beth Dakin
  • 11 edits in trunk/Source

Add a setting to opt into a mode where the background extends and fixed elements
don't move on rubber-band
​https://bugs.webkit.org/show_bug.cgi?id=124745

Reviewed by Tim Horton.

Source/WebCore:

New setting backgroundShouldExtendBeyondPage() will cause the tile cache to have a
margin, and it will also cause fixed elements and backgrounds to stick to the
viewport on scroll instead of sticking to the document.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::scrollBehaviorForFixedElements):

  • page/Settings.in:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Source/WebKit:

Keep Windows happy.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

Add SPI to enable the new setting.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBackgroundShouldExtendBeyondPage):
(WKPreferencesGetBackgroundShouldExtendBeyondPage):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:44 PM Changeset in webkit [159959] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.60.8

New tag.

1:41 PM Changeset in webkit [159958] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MediaStream] Use iterator-based loops instead of index-based loops
​https://bugs.webkit.org/show_bug.cgi?id=125021

Patch by Roger Zanoni <​rogerzanoni@gmail.com> on 2013-12-02
Reviewed by Eric Carlson.

Also, changing iterator variable names from iter to it and
initializing an 'end' variable in each loop instead of evaluating
'collection.end()' multiple times.

No new tests, covered by existing ones.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackDidEnd):
(WebCore::MediaStream::scheduledEventTimerFired):

1:15 PM Changeset in webkit [159957] by mhahnenberg@apple.com
  • 2 edits in trunk/Tools

Build fix after r159955

  • Scripts/run-jsc-stress-tests:
12:56 PM Changeset in webkit [159956] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Remote Layer Tree: Hook up setLayerTreeStateIsFrozen
​https://bugs.webkit.org/show_bug.cgi?id=124872

Reviewed by Brent Fulgham.

setLayerTreeStateIsFrozen is the mechanism used to ensure that
layer property changes (including new backing store) aren't committed
while e.g. the page is reconfigured for printing.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::flushLayers):
(WebKit::RemoteLayerTreeContext::setIsFlushingSuspended):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):

12:55 PM Changeset in webkit [159955] by mhahnenberg@apple.com
  • 3 edits
    1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
​https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Filip Pizlo.

  • Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation

of grep -i -q

  • Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
  • Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.

We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.

12:52 PM Changeset in webkit [159954] by commit-queue@webkit.org
  • 13 edits in trunk

[css shapes] Parse new ellipse shape syntax
​https://bugs.webkit.org/show_bug.cgi?id=124620

Patch by Rob Buis <​rob.buis@samsung.com> on 2013-12-02
Reviewed by Dirk Schulze.

Source/WebCore:

Implement parsing of the new ellipse shape syntax. This closely follows the patch
for the new circle syntax (​https://bugs.webkit.org/show_bug.cgi?id=124618), with
some refactoring of functionality shared by both.

Updated existing parsing tests to cover this.

  • css/BasicShapeFunctions.cpp:

(WebCore::BasicShapeRadiusToCSSValue):
(WebCore::valueForBasicShape):
(WebCore::CSSValueToBasicShapeRadius):
(WebCore::basicShapeForValue):

  • css/CSSBasicShapes.cpp:

(WebCore::buildEllipseString):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::buildDeprecatedEllipseString):
(WebCore::CSSDeprecatedBasicShapeEllipse::cssText):
(WebCore::CSSDeprecatedBasicShapeEllipse::equals):

  • css/CSSBasicShapes.h:

(WebCore::CSSDeprecatedBasicShapeEllipse::create):
(WebCore::CSSDeprecatedBasicShapeEllipse::centerX):
(WebCore::CSSDeprecatedBasicShapeEllipse::centerY):
(WebCore::CSSDeprecatedBasicShapeEllipse::radiusX):
(WebCore::CSSDeprecatedBasicShapeEllipse::radiusY):
(WebCore::CSSDeprecatedBasicShapeEllipse::setCenterX):
(WebCore::CSSDeprecatedBasicShapeEllipse::setCenterY):
(WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusX):
(WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusY):
(WebCore::CSSDeprecatedBasicShapeEllipse::CSSDeprecatedBasicShapeEllipse):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseDeprecatedBasicShapeEllipse):
(WebCore::CSSParser::parseBasicShape):

  • css/CSSParser.h:
  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

  • rendering/style/BasicShapes.cpp:

(WebCore::DeprecatedBasicShapeEllipse::path):
(WebCore::DeprecatedBasicShapeEllipse::blend):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapeEllipse::blend):

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(WebCore::DeprecatedBasicShapeEllipse::create):
(WebCore::DeprecatedBasicShapeEllipse::DeprecatedBasicShapeEllipse):

LayoutTests:

Test that the new ellipse syntax is properly parsed.

  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
12:44 PM Changeset in webkit [159953] by Brent Fulgham
  • 2 edits in branches/safari-537.60-branch/Source/WebKit

Merge r159941.

2013-12-02 Brent Fulgham <Brent Fulgham>

[Win] WebKit Project doesn't copy resource bundle
​https://bugs.webkit.org/show_bug.cgi?id=125078

Reviewed by Jer Noble.

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
12:40 PM Changeset in webkit [159952] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: popover can overlap target frame
​https://bugs.webkit.org/show_bug.cgi?id=125069

Reviewed by Joseph Pecoraro.

Fix a regression introduced in ​http://trac.webkit.org/changeset/159286. We should only
offset the frame of the popover in the y-axis if the target edge is on the x-axis, and
vice versa. We also remove the needsToDrawBackground check since it incorrectly disregarded
the anchor point. We now always draw the background which is a lot safer and guarantees
we'll always draw an adequate frame and anchor point.

  • UserInterface/Popover.js:

(WebInspector.Popover.prototype._update):
(WebInspector.Popover.prototype._bestMetricsForEdge):

12:28 PM Changeset in webkit [159951] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

Add support for WebCrypto RSA-OAEP
​https://bugs.webkit.org/show_bug.cgi?id=125084

Build fix.

  • crypto/CommonCryptoUtilities.h:
  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
  • crypto/mac/CryptoKeyRSAMac.cpp:
12:11 PM Changeset in webkit [159950] by commit-queue@webkit.org
  • 5 edits in trunk

Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
​https://bugs.webkit.org/show_bug.cgi?id=124811

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-12-02
Reviewed by Eric Carlson.

Source/WebCore:

No new tests because this is just refactoring.

  • html/track/TrackListBase.cpp:

(TrackListBase::TrackListBase): Replace event code with a GenericEventQueue.
(TrackListBase::scheduleTrackEvent): Factor out duplicate code in schedule{Add,Remove}TrackEvent functions.
(TrackListBase::scheduleAddTrackEvent): Same.
(TrackListBase::scheduleRemoveTrackEvent): Same.
(TrackListBase::scheduleChangeEvent): Use GenericEventQueue.

  • html/track/TrackListBase.h: Replace event code with GenericEventQueue.

LayoutTests:

  • platform/mac/TestExpectations: Unskip onremovetrack test which was fixed a long time ago.
12:05 PM Changeset in webkit [159949] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Add support for WebCrypto RSA-OAEP
​https://bugs.webkit.org/show_bug.cgi?id=125084

Build fix.

  • WebCore.xcodeproj/project.pbxproj: Fix an automatic merge failure by re-adding

CryptoAlgorithmRsaOaepParams.h.

12:00 PM Changeset in webkit [159948] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Disable direct image compositing
​https://bugs.webkit.org/show_bug.cgi?id=124875
<rdar://problem/15446024>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h:

Image-as-layer-contents is not implemented for the remote layer tree.

11:58 AM Changeset in webkit [159947] by vjaquez@igalia.com
  • 2 edits in trunk/Source/WebCore

[Gstreamer] update webkitvideosink metadata
​https://bugs.webkit.org/show_bug.cgi?id=125082

Reviewed by Philippe Normand.

No new tests, no behavior changes.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_class_init):

11:55 AM Changeset in webkit [159946] by Antoine Quint
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: add a method to add padding around a WebInspector.Rect
​https://bugs.webkit.org/show_bug.cgi?id=125072

Reviewed by Joseph Pecoraro.

Add a new WebInspector.Rect.prototype.pad() method which does not alter
the rectangle it's called and returns a new rect much like .inset(). I've
checked all call sites and there was no reuse of the rectangle that was
padded so this patch won't have any side effects.

  • UserInterface/Breakpoint.js:

(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):

  • UserInterface/CSSStyleDeclarationTextEditor.js:
  • UserInterface/Geometry.js:

(WebInspector.Rect.prototype.pad):

  • UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopover):

  • UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):

11:55 AM Changeset in webkit [159945] by vjaquez@igalia.com
  • 4 edits in trunk/Source/WebCore

Simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
​https://bugs.webkit.org/show_bug.cgi?id=125077

Remove the method's unused parameter.
Remove the GStreamer 0.10.22 run-time validation, since we are using
GStreamer 1.0 officially.
Remove the creation of a spurious Bin for the video sink, since
either the fpssink or the webkitsink are valid sink elements.
Change fpsink to a GRefPtr.

Now, createVideoSink() returns a simple pointer to the created sink
element.

Reviewed by Philippe Normand.

No new tests, no behavior changes.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
11:50 AM Changeset in webkit [159944] by ap@apple.com
  • 11 edits
    12 adds in trunk

Add support for WebCrypto RSA-OAEP
​https://bugs.webkit.org/show_bug.cgi?id=125084

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/rsa-oaep-key-manipulation.html

crypto/subtle/rsa-oaep-plaintext-length.html
crypto/subtle/rsa-oaep-wrap-unwrap-aes.html

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createRsaOaepParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
Added RSA-OAEP parameters.

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
Support RSA-OAEP in JWK. It is more limited than general WebCrypto, as JWK only
allows SHA-1 as hash.

  • crypto/CommonCryptoUtilities.cpp: Added. (WebCore::getCommonCryptoDigestAlgorithm):
  • crypto/CommonCryptoUtilities.h: Added.

Extracted some shared code and forward declarations for CommonCrypto.

  • crypto/CryptoAlgorithmParameters.h: (WebCore::CryptoAlgorithmParameters::Class):
  • crypto/parameters/CryptoAlgorithmRsaOaepParams.h: Added.

Added RsaOaepParams.

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: Added.
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h: Added.
  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp: Added.
  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::getCommonCryptoHMACAlgorithm):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
  • crypto/mac/CryptoKeyMac.cpp:
  • crypto/mac/CryptoKeyRSAMac.cpp:

Use CommonCryptoUtilities.

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register RSA-OAEP.

LayoutTests:

  • crypto/subtle/rsa-oaep-key-manipulation-expected.txt: Added.
  • crypto/subtle/rsa-oaep-key-manipulation.html: Added.
  • crypto/subtle/rsa-oaep-plaintext-length-expected.txt: Added.
  • crypto/subtle/rsa-oaep-plaintext-length.html: Added.
  • crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Added.
  • crypto/subtle/rsa-oaep-wrap-unwrap-aes.html: Added.
11:49 AM Changeset in webkit [159943] by fpizlo@apple.com
  • 18 edits
    4 adds in trunk

Stores to local captured variables should be intercepted
​https://bugs.webkit.org/show_bug.cgi?id=124883

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Previously, in bytecode, you could assign to a captured variable just as you would
assign to any other kind of variable. This complicates closure variable constant
inference because we don't have any place where we can intercept stores to captured
variables in the LLInt.

This patch institutes a policy that only certain instructions can store to captured
variables. If you interpret those instructions and you are required to notifyWrite()
then you need to check if the relevant variable is captured. Those instructions are
tracked in CodeBlock.cpp's VerifyCapturedDef. The main one is simply op_captured_mov.
In the future, we'll probably modify those instructions to have a pointer directly to
the VariableWatchpointSet; but for now we just introduce the captured instructions as
placeholders.

In order to validate that the placeholders are inserted correctly, this patch improves
the CodeBlock validation to be able to inspect every def in the bytecode. To do that,
this patch refactors the liveness analysis' use/def calculator to be reusable; it now
takes a functor for each use or def.

In the process of refactoring the liveness analysis, I noticed that op_enter was
claiming to def all callee registers. That's wrong; it only defs the non-temporary
variables. Making that change revealed preexisting bugs in the liveness analysis, since
now the validator would pick up cases where the bytecode claimed to use a temporary and
the def calculator never noticed the definition (or the converse - where the bytecode
was actually not using a temporary but the liveness analysis thought that it was a
use). This patch fixes a few of those bugs.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::stepOverInstruction):

  • bytecode/BytecodeUseDef.h: Added.

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::validate):

  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::isCaptured):
(JSC::BytecodeGenerator::local):
(JSC::BytecodeGenerator::constLocal):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):

  • bytecompiler/BytecodeGenerator.h:

(JSC::Local::Local):
(JSC::Local::isCaptured):
(JSC::Local::captureMode):
(JSC::BytecodeGenerator::captureMode):
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::pushOptimisedForIn):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/SymbolTable.h:

(JSC::SymbolTable::isCaptured):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • js/regress/captured-assignments-expected.txt: Added.
  • js/regress/captured-assignments.html: Added.
  • js/regress/script-tests/captured-assignments.js: Added.
11:09 AM Changeset in webkit [159942] by fpizlo@apple.com
  • 29 edits in trunk/Source/JavaScriptCore

Instead of watchpointing activation allocation, we should watchpoint entry into functions that have captured variables
​https://bugs.webkit.org/show_bug.cgi?id=125052

Reviewed by Mark Hahnenberg.

This makes us watch function entry rather than activation creation. We only incur the
costs of doing so for functions that have captured variables, and only on the first two
entries into the function. This means that closure variable constant inference will
naturally work even for local uses of the captured variable, like:

(function(){

var blah = 42;
... stuff
function () { ... blah /* we can fold this to 42 */ }
... blah we can also fold this to 42.

})();


Previously, only the nested use would have been foldable.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::touch):
(JSC::InlineWatchpointSet::touch):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasSymbolTable):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_touch_entry):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/JSActivation.h:

(JSC::JSActivation::create):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):

  • runtime/SymbolTable.h:
10:47 AM Changeset in webkit [159941] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] WebKit Project doesn't copy resource bundle
​https://bugs.webkit.org/show_bug.cgi?id=125078

Reviewed by Jer Noble.

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Correct post-build step

to copy WebKit.resources to build target.

10:23 AM Changeset in webkit [159940] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
​https://bugs.webkit.org/show_bug.cgi?id=125075

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Michael Saboff.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall): added UNUSED_PARAM(pc).
(JSC::LLInt::setUpCall): Doesn't pass 'pc' to LLINT_CALL macros.
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Ditto.

9:49 AM Changeset in webkit [159939] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Fails to build with freetype 2.5.1
​https://bugs.webkit.org/show_bug.cgi?id=125074

Patch by Andres Gomez <Andres Gomez> on 2013-12-02
Reviewed by Carlos Garcia Campos.

FreeType specifies a canonical way of including their own
headers. Now, we are following this recommendation so the
compilation won't be broken again due to an upgrade in FeeType's
including paths.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:
  • platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
9:28 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
9:20 AM Changeset in webkit [159938] by lauro.neto@openbossa.org
  • 5 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

[MediaStream] Update layout tests to newer spec.
​https://bugs.webkit.org/show_bug.cgi?id=124985

Reviewed by Eric Carlson.

  • TestExpectations:
  • fast/mediastream/MediaStream-onended-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrack-onended-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack-onended.html: Renamed from LayoutTests/fast/mediastream/MediaStream-onended.html.
  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-state-expected.txt:
  • fast/mediastream/RTCSessionDescription-expected.txt:
9:14 AM Changeset in webkit [159937] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Remove stdio.h from JSC files.
​https://bugs.webkit.org/show_bug.cgi?id=125066

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Michael Saboff.

Remove stdio.h, when it is not necessary to be included.

  • bytecode/CodeBlock.cpp:
  • bytecode/StructureSet.h:
  • profiler/LegacyProfiler.cpp:
  • profiler/Profile.cpp:
  • profiler/ProfileNode.cpp:
  • yarr/YarrInterpreter.cpp:
8:51 AM Changeset in webkit [159936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unused include files when building without JIT.
​https://bugs.webkit.org/show_bug.cgi?id=125062

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Michael Saboff.

We should organize the includes, and guard JIT methods
in ValueRecovery.

  • bytecode/ValueRecovery.cpp: Guard include files.
  • bytecode/ValueRecovery.h: Guard JIT methods.
8:41 AM Changeset in webkit [159935] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[MIPS] Small stack frame causes regressions.
​https://bugs.webkit.org/show_bug.cgi?id=124945

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-12-02
Reviewed by Michael Saboff.

Fix stack space for LLInt on MIPS.

  • llint/LowLevelInterpreter32_64.asm:
8:38 AM Changeset in webkit [159934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

jsc: implement a native readFile function
​https://bugs.webkit.org/show_bug.cgi?id=125059

Patch by Brian J. Burg <Brian Burg> on 2013-12-02
Reviewed by Filip Pizlo.

This adds a native readFile() function to jsc, used to slurp
an entire file into a JavaScript string.

  • jsc.cpp:

(GlobalObject::finishCreation): Add readFile() to globals.
(functionReadFile): Added.

7:36 AM Changeset in webkit [159933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC does not build if OPCODE_STATS is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=125011

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Filip Pizlo.

  • bytecode/Opcode.cpp:
6:19 AM Changeset in webkit [159932] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: Crash at WebCore::commonTreeScope
​https://bugs.webkit.org/show_bug.cgi?id=125042

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When an AX text marker that references a node in a detached document is used to create a text marker range, a crash occurs
because the method to determine commonTreeScopes does not account for when there are no common tree scopes.

Test: platform/mac/accessibility/ordered-textmarker-crash.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):

  • dom/TreeScope.cpp:

(WebCore::commonTreeScope):

LayoutTests:

  • platform/mac/accessibility/ordered-textmarker-crash-expected.txt: Added.
  • platform/mac/accessibility/ordered-textmarker-crash.html: Added.
5:58 AM Changeset in webkit [159931] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix a crash in the webaudio source provider when the audio track is going away.
​https://bugs.webkit.org/show_bug.cgi?id=124975

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Philippe Normand.

Merged ​https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23

Before this patch, it was hitting a use-after-free crash when the audio
track in the media stream is going away and the webaudio mediastreamsourcenode
is still running.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Passing audio track
pointer to MediaStreamAudioSourceNode constructor.

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

  • Modules/webaudio/MediaStreamAudioSourceNode.h: Added

MediaStreamTrack class variable and change the constructor to receive
it as parameter.

3:34 AM Changeset in webkit [159930] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for the

fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html reftest.

3:30 AM Changeset in webkit [159929] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed, EFL rebaseline since r159915.

Error messages are changed. So, test results need to be updated.

  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/forms/validationMessage-expected.txt:
3:27 AM Changeset in webkit [159928] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Remove unneeded autoconf macros
​https://bugs.webkit.org/show_bug.cgi?id=125044

Compilers that do not support const/inline/volatile and
systems with pre-C89-headers are anyway not supported.

Patch by Adrian Bunk <​bunk@stusta.de> on 2013-12-02
Reviewed by Gustavo Noronha Silva.

  • Source/autotools/CheckSystemAndBasicDependencies.m4:
2:47 AM Changeset in webkit [159927] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r159926 - [GTK] GTK2 paint code path does not render AC layers
​https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

  • webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

2:45 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:44 AM Changeset in webkit [159926] by Gustavo Noronha Silva
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] GTK2 paint code path does not render AC layers
​https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

  • webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

2:40 AM Changeset in webkit [159925] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

[ATK] Support active state for listbox elements.
​https://bugs.webkit.org/show_bug.cgi?id=125009

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2013-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ATK_STATE_ACTIVE for listbox elements.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

Tools:

Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

Establish expectations for the test (all PASS).

  • accessibility/multiselect-list-reports-active-option-expected.txt: Added.
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
2:24 AM Changeset in webkit [159924] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skip two unit tests that are causing the subsequent test to crash.

2:12 AM Changeset in webkit [159923] by Seokju Kwon
  • 3 edits in trunk/Source/WebCore

Web Inspector: Remove unused functions from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=125061

Reviewed by Antoine Quint.

Get rid of unused functions, redundant inclusion and forward declaration.

No new tests, no behavior changes.

  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
2:04 AM Changeset in webkit [159922] by Carlos Garcia Campos
  • 46 edits in releases/WebKitGTK/webkit-2.2

Merge r155201 - REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=120781

Reviewed by Mark Hahnenberg.

Roll this back in with a build fix.

  • Use some method table hacks to detect if the CheckStructure optimization is valid for to_this.
  • Introduce a FinalObjectUse and use it for ToThis->Identity conversion.

This looks like it might be perf-neutral on the major benchmarks, but it
introduces some horrible performance cliffs. For example if you add methods to
the Array prototype, you'll get horrible performance cliffs. As in virtual calls
to C++ every time you call a JS function even if it's inlined.
LongSpider/3d-cube appears to hit this.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):

2:00 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:58 AM Changeset in webkit [159921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warning in EventHandler.cpp
​https://bugs.webkit.org/show_bug.cgi?id=125010

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-12-02
Reviewed by Csaba Osztrogonác.

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

1:38 AM WebKitGTK/2.2.x edited by Andres Gomez
(diff)
1:28 AM Changeset in webkit [159920] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r159843 - REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
​https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

  • tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

1:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:24 AM Changeset in webkit [159919] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159615 - [GTK] Cannot scroll in option menu when it larger than the screen
​https://bugs.webkit.org/show_bug.cgi?id=124671

Reviewed by Martin Robinson.

The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.

1:21 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:20 AM Changeset in webkit [159918] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159811 - [GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
​https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

1:18 AM Changeset in webkit [159917] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/LayoutTests

Merge r159686 - Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

  • platform/gtk/TestExpectations:
1:17 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:15 AM Changeset in webkit [159916] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159572 - [GTK] Remove Chromium as user agent and claim to be Safari in OS X
​https://bugs.webkit.org/show_bug.cgi?id=124229

Reviewed by Martin Robinson.

​http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

1:08 AM Changeset in webkit [159915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HTML5 required attribute validation messages implemented.
​https://bugs.webkit.org/show_bug.cgi?id=125003

Patch by Attila Dusnoki <​adusnoki@inf.u-szeged.hu> on 2013-12-02
Reviewed by Gyuyoung Kim.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):

12:59 AM Changeset in webkit [159914] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r158687 - Fix register allocation inside control flow in GetByVal String
​https://bugs.webkit.org/show_bug.cgi?id=123816

Reviewed by Geoffrey Garen.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

12:58 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:56 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)

Dec 1, 2013:

11:48 PM Changeset in webkit [159913] by ChangSeok Oh
  • 5 edits in trunk/Source/WebKit2

Unreviewed Gtk port Build fix after r159903

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

9:44 PM Changeset in webkit [159912] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVG: Intersection/enclosure checks should use RenderElement.
<​https://webkit.org/b/125058>

Make RenderSVGModelObject's checkIntersection() and checkEnclosure()
take RenderElement* instead of RenderObject*. They are only ever
called with SVGElement's renderers.

Reviewed by Sam Weinig.

9:43 PM Changeset in webkit [159911] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unreachable labels for -webkit-margin-*-collapse properties.
<​https://webkit.org/b/125057>

The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:

-webkit-margin-before-collapse
-webkit-margin-top-collapse
-webkit-margin-after-collapse
-webkit-margin-bottom-collapse

This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.

Reviewed by Anders Carlsson.

9:41 PM Changeset in webkit [159910] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

CSSFunctionValue constructors should return PassRef.
<​https://webkit.org/b/125054>

Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.

Reviewed by Anders Carlsson.

7:36 PM Changeset in webkit [159909] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r159764.
​http://trac.webkit.org/changeset/159764
​https://bugs.webkit.org/show_bug.cgi?id=125055

appears to hurt html5-full-render times (Requested by kling on
#webkit).

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

  • html/parser/HTMLConstructionSite.h:
7:36 PM Changeset in webkit [159908] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

Give UserMessageEncoders WebProcessProxy reference (like the decoders already have)
​https://bugs.webkit.org/show_bug.cgi?id=125053

Reviewed by Dan Bernstein.

  • Give the UserMessageEncoders a process reference.
  • Switch UserMessageDecoders to storing a process reference, rather than pointer.
  • Shared/UserMessageCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:
  • UIProcess/WebConnectionToWebProcess.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContextUserMessageCoders.h:
  • UIProcess/WebPageProxy.cpp:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
6:47 PM Changeset in webkit [159907] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Make more computed style helpers return PassRef.
<​https://webkit.org/b/125043>

Reduce branchiness in computed style code by making more of the
file-local helpers return PassRef instead of PassRefPtr.

Reviewed by Anders Carlsson.

5:53 PM Changeset in webkit [159906] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] The PageLoadState::Observer is not being set on iOS
​https://bugs.webkit.org/show_bug.cgi?id=125051

Reviewed by Dan Bernstein.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformInitialize):
Add missing call to _finishInitialization.

5:16 PM Changeset in webkit [159905] by ryuan.choi@samsung.com
  • 9 edits in trunk/Source/WebKit2

Unreviewed EFL Build fix attempt after r159903

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::CoordinatedDrawingAreaProxy::update):
(WebKit::CoordinatedDrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::sendUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::renderNextFrame):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):

  • UIProcess/WebTextChecker.cpp:

(WebKit::WebTextChecker::checkSpelling):
(WebKit::WebTextChecker::changeSpellingToWord):

  • UIProcess/WebTextChecker.h:
  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

5:04 PM Changeset in webkit [159904] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix the iOS build.

  • UIProcess/API/ios/WKContentView.mm:
  • UIProcess/API/ios/WKInteractionView.mm:
  • UIProcess/ios/WebPageProxyIOS.mm:
4:50 PM Changeset in webkit [159903] by weinig@apple.com
  • 33 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebProcessProxy is never null so it should be stored in a Ref
​https://bugs.webkit.org/show_bug.cgi?id=125047

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Downloads/DownloadProxy.cpp:
  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxyMap.cpp:
  • UIProcess/Downloads/DownloadProxyMap.h:
  • UIProcess/DrawingAreaProxy.cpp:
  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/WebEditCommandProxy.cpp:
  • UIProcess/WebFrameProxy.cpp:
  • UIProcess/WebFullScreenManagerProxy.cpp:
  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
  • UIProcess/mac/RemoteLayerTreeHost.mm:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
4:50 PM Changeset in webkit [159902] by mitz@apple.com
  • 4 edits in trunk/Tools

[Mac] Transition MiniBrowser to the Cocoa API: policy delegate
​https://bugs.webkit.org/show_bug.cgi?id=125046

Reviewed by Sam Weinig.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
(-[BrowserAppDelegate openDocument:]): Ditto.

  • MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the

interface to the implementation.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
the policy client.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
Moved policy client implementation into this delegate method.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
Ditto.

3:40 PM Changeset in webkit [159901] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
​https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

11:14 AM WebInspectorCodingStyleGuide edited by Brian Burg
Fix tt styles, add links to mechanization tracking bug, repository … (diff)
11:00 AM WebInspectorCodingStyleGuide edited by Brian Burg
Add protected (diff)
10:46 AM WikiStart edited by Brian Burg
Move and relabel Web Inspector links; add inspector style guide (diff)
9:03 AM Changeset in webkit [159900] by mitz@apple.com
  • 3 edits
    2 deletes in trunk/Tools

[Mac] Remove the MiniBrowser injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=125041

Reviewed by Anders Carlsson.

It had no ops!

  • MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/Info.plist: Removed.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
5:45 AM Changeset in webkit [159899] by Philippe Normand
  • 4 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159896.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseUpdatePreferences):

12:07 AM Changeset in webkit [159898] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

Unreviewed build fix after r159896.

  • UIProcess/API/efl/ewk_settings.cpp:

(EwkSettings::preferences):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

Nov 30, 2013:

11:05 PM Changeset in webkit [159897] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebCore

[EFL] Implement scrollbarThickness for opaque scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=125034

Reviewed by Gyuyoung Kim.

Implemented scrollbarThickness to support opaque scrollbar.
Now, edj can decide whether to support opaque scrollbar by adding scrollbar.thickness.
In addition, added OVERRIDE/FINAL keyword and removed unnecessary destructor
in ScrollbarThemeEfl.cpp.

No new tests, no behavior changes with default theme.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::loadTheme):
Update thickness of scrollbar when theme was loaded.

  • platform/efl/ScrollbarThemeEfl.cpp:
  • platform/efl/ScrollbarThemeEfl.h:

(WebCore::ScrollbarThemeEfl::setScrollbarThickness):
(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

10:40 PM Changeset in webkit [159896] by weinig@apple.com
  • 17 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref
​https://bugs.webkit.org/show_bug.cgi?id=125038

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(WKPageIsURLKnownHSTSHost):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController browsingContextGroup]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorProxy::isInspectorPage):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::createNonNull):

  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::preferencesDidChange):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageGroup):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::pageIsProcessSuppressible):

10:24 PM Changeset in webkit [159895] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

Added a version of +[NSURL _web_URLWithWTFString:relativeToURL:] that doesn’t take a base URL and switched all callers to it.
​https://bugs.webkit.org/show_bug.cgi?id=125040

Reviewed by Sam Weinig.

  • Shared/Cocoa/WKNSURLExtras.h: Declared new method.
  • Shared/Cocoa/WKNSURLExtras.mm:

(urlWithWTFString): Added helper function.
(+[NSURL _web_URLWithWTFString:]): Added.
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Changed to use helper function.

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to call new method.
(-[WKBackForwardListItem originalURL]): Ditto.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Ditto.
(setUpPagePolicyClient): Ditto.

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

10:02 PM Changeset in webkit [159894] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Stop using the WKPageRef API in WKBrowsingContextController
​https://bugs.webkit.org/show_bug.cgi?id=125036

Reviewed by Sam Weinig.

  • Shared/Cocoa/WKNSURLExtras.h: Declared new method.
  • Shared/Cocoa/WKNSURLExtras.mm:

(-[NSURL _web_originalDataAsWTFString]): Added. Returns a WTF::String with the receiver’s
bytes.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadRequest:userData:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController _pageRef]):
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):

7:52 PM Changeset in webkit [159893] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159865.
​http://trac.webkit.org/changeset/159865
​https://bugs.webkit.org/show_bug.cgi?id=125037

the position of mouse events are wrong at MiniBrowser/efl
(Requested by ryuan on #webkit).

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):

7:33 PM Changeset in webkit [159892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Win] Some JavaScript date tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=124946

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-11-30
Reviewed by Brent Fulgham.

Use native Win32 api functions to compute Daylight saving time offset.

  • wtf/DateMath.cpp:

(WTF::UnixTimeToFileTime): Added method to calculate Win32 specific struct FILETIME from time_t value.
(WTF::calculateDSTOffset): Use native Win32 api functions to compute Daylight saving time offset.

6:25 PM Changeset in webkit [159891] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebBackForwardList is never null so it should be stored in a Ref
​https://bugs.webkit.org/show_bug.cgi?id=125035

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetBackForwardList):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Remove null check.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::currentItem): Constify.
(WebKit::WebBackForwardList::backItem): Constify.
(WebKit::WebBackForwardList::forwardItem): Constify.
(WebKit::WebBackForwardList::itemAtIndex): Constify.

  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::create):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::backForwardList):

12:15 PM Changeset in webkit [159890] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159889.

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::viewWidget): Adjust the static cast of the PageClient reference to PageClientImpl.

11:14 AM Changeset in webkit [159889] by weinig@apple.com
  • 15 edits in trunk/Source/WebKit2

[CTTE] WebPageProxy should store the PageClient as a reference
​https://bugs.webkit.org/show_bug.cgi?id=125030

Reviewed by Dan Bernstein.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:

(WebKit::WebPageProxy::didFindZoomableArea):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setViewNeedsDisplay):
(WebKit::WebPageProxy::displayView):
(WebKit::WebPageProxy::canScrollView):
(WebKit::WebPageProxy::scrollView):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::viewSize):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::screenToWindow):
(WebKit::WebPageProxy::windowToScreen):
(WebKit::WebPageProxy::pageDidRequestScroll):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):
(WebKit::WebPageProxy::didChangeViewportProperties):
(WebKit::WebPageProxy::handleDownloadRequest):
(WebKit::WebPageProxy::didChangeContentSize):
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::setFindIndicator):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::setToolTip):
(WebKit::WebPageProxy::setCursor):
(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::initializeCreationParameters):
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
(WebKit::WebPageProxy::updateAcceleratedCompositingMode):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::mainDocumentDidReceiveMobileDocType):
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
(WebKit::WebPageProxy::didChangeViewportArguments):
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedData):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::makeFirstResponder):
(WebKit::WebPageProxy::colorSpace):
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
(WebKit::WebPageProxy::setPluginComplexTextInputState):
(WebKit::WebPageProxy::executeSavedCommandBySelector):
(WebKit::WebPageProxy::wkView):
(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

10:55 AM Changeset in webkit [159888] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

[RTTE] The PermissionRequestManagerProxies should use WebPageProxy references.
​https://bugs.webkit.org/show_bug.cgi?id=125029

Reviewed by Dan Bernstein.

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::GeolocationPermissionRequestManagerProxy):
(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

  • UIProcess/GeolocationPermissionRequestManagerProxy.h:
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Do some additional modernization while we are here.

10:49 AM Changeset in webkit [159887] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/15560240> ResourceError encoding drops NSURL-valued keys in the NSError’s userInfo, including NSErrorFailingURLKey
​https://bugs.webkit.org/show_bug.cgi?id=125016

Reviewed by Anders “happy name day” Carlsson.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData): Encode all string- and URL-valued keys as a dictionary.
(CoreIPC::::decodePlatformData): Decode user info as a dictionary.

9:23 AM Changeset in webkit [159886] by fpizlo@apple.com
  • 28 edits in trunk/Source/JavaScriptCore

Finally remove those DFG_ENABLE things
​https://bugs.webkit.org/show_bug.cgi?id=125025

Rubber stamped by Sam Weinig.

This removes a bunch of unused and untested insanity.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getArrayModeConsideringSlowPath):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:

(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldDumpGraphAtEachPhase):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • dfg/DFGVariableEventStream.h:

(JSC::DFG::VariableEventStream::appendAndLog):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

9:05 AM Changeset in webkit [159885] by mrowe@apple.com
  • 3 edits in trunk/Websites/webkit.org

<​https://webkit.org/b/125027> Update the analytics account used by webkit.org

Switch to a Google Analytics id that's accessible to someone that's involved with the WebKit project.

Reviewed by Sam Weinig.

  • footer.inc: Remove the old analytics code.
  • header.inc: Add the new stuff.

Nov 29, 2013:

11:41 PM Changeset in webkit [159884] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for EFL and GTK WK2 builds.

  • Scripts/generate-forwarding-headers.pl: Add Cocoa to the list of platform prefixes.
8:17 PM Changeset in webkit [159883] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL IC should nop-fill to make up the difference between the actual IC size and the requested patchpoint size
​https://bugs.webkit.org/show_bug.cgi?id=124960

Reviewed by Sam Weinig.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::size):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::fillNops):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

  • ftl/FTLCompile.cpp:

(JSC::FTL::generateICFastPath):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

8:13 PM Changeset in webkit [159882] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Fix build warnings in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::eventCallback):

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKArrayIsMutable):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

6:04 PM Changeset in webkit [159881] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

[Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
​https://bugs.webkit.org/show_bug.cgi?id=125024

Reviewed by Dan Bernstein.

Introduce API::ObjectStorage which wraps std::aligned_storage and adds some convenience functions
to reinterpret the data as the corresponding type. Deploy it everywhere we were previously using
std::aligned_storage.

  • Shared/Cocoa/WKNSArray.mm:
  • Shared/Cocoa/WKNSDictionary.mm:
  • Shared/Cocoa/WKObject.h:
  • UIProcess/API/Cocoa/WKBackForwardList.mm:
  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
  • UIProcess/API/Cocoa/WKNavigationData.mm:
  • UIProcess/API/Cocoa/WKProcessGroup.mm:
5:46 PM Changeset in webkit [159880] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crashing API tests.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):

4:56 PM Changeset in webkit [159879] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix some style boo-boos.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:53 PM Changeset in webkit [159878] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the iOS build.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:27 PM Changeset in webkit [159877] by weinig@apple.com
  • 9 edits in trunk/Source/WebKit2

[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
​https://bugs.webkit.org/show_bug.cgi?id=125022

Reviewed by Dan Bernstein.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/mac/ObjCObjectGraphCoders.mm:

Add support for WKProcessGroup.

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
Replace call to _browsingContextControllerForPageRef: with wrapper.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline.

(-[WKBrowsingContextController dealloc]):
Add explicit destructor call.

(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
Lazily set up the load and policy clients only once a delegate has been set to allow
continued use of the C-SPI clients for WebKitTestRunner.

(-[WKBrowsingContextController _finishInitialization]):
Move remaining work that was done in the initialize (setting up the observer) here,
and have the WebPageProxy call it.

  • UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
_initWithPageRef: and _browsingContextControllerForPageRef: helpers.

  • UIProcess/API/Cocoa/WKProcessGroup.mm:

(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
Switch to using wrapper().

  • UIProcess/API/ios/WKContentView.mm:
  • UIProcess/API/mac/WKView.mm:

Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
as the WebPageProxy.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitialize):
Inform the wrapper that it is safe to finish initialization.

3:21 PM Changeset in webkit [159876] by mitz@apple.com
  • 8 edits
    2 adds in trunk/Source/WebKit2

[Cocoa] Add a way to recover from load errors
​https://bugs.webkit.org/show_bug.cgi?id=125020

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from
the given error, adding two keys to the user info dictionary: the context controller under
the recovery attempter key, and the frame under a private key.
(didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter.
(didFailLoadWithErrorForFrame): Ditto.
(-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this
WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the
frame from the error.

  • UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting

recovery from errors and declares the error user info dictionary key under which an object
conforming to this protocol may be stored.

  • UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines

WKRecoveryAttempterErrorKey.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page.

  • UIProcess/WebFrameProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame.
1:15 PM Changeset in webkit [159875] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Expose loadAlternateHTMLString via the API
​https://bugs.webkit.org/show_bug.cgi?id=125019

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added.
Calls WebPageProxy::loadAlternateHTMLString.

12:54 PM Changeset in webkit [159874] by weinig@apple.com
  • 2 edits
    22 moves in trunk/Source/WebKit2

Move API files shared between Mac and iOS to the Cocoa directory
​https://bugs.webkit.org/show_bug.cgi?id=125017

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm.
  • UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
  • UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h.
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h.
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm.
  • UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
  • UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h.
  • UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h.
  • UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h.
  • UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h.
  • UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm.
  • UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h.
  • UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h.
  • UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm.
  • UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
  • UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h.
  • UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h.
  • UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm.
  • UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h.
  • UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h.
  • UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h.
  • UIProcess/API/mac/WKBrowsingContextController.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextController.mm: Removed.
  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroup.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed.
  • UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed.
  • UIProcess/API/mac/WKConnection.h: Removed.
  • UIProcess/API/mac/WKConnection.mm: Removed.
  • UIProcess/API/mac/WKConnectionInternal.h: Removed.
  • UIProcess/API/mac/WKProcessGroup.h: Removed.
  • UIProcess/API/mac/WKProcessGroup.mm: Removed.
  • UIProcess/API/mac/WKProcessGroupInternal.h: Removed.
  • UIProcess/API/mac/WKProcessGroupPrivate.h: Removed.
  • UIProcess/API/mac/WKTypeRefWrapper.h: Removed.
  • UIProcess/API/mac/WKTypeRefWrapper.mm: Removed.
  • UIProcess/API/mac/WKView.h: Removed.
  • UIProcess/API/mac/WKViewPrivate.h: Removed.
  • UIProcess/API/mac/WebKit2.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
10:50 AM Moving to Git edited by kallisti5@unixzen.com
(diff)
9:25 AM Changeset in webkit [159873] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
​https://bugs.webkit.org/show_bug.cgi?id=124936

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

The moveDoubleToInts implementations in ARM, MIPS and SH4 macro assemblers do not clobber
src FPRegister and are likely to be more efficient than the current generic implementation
using the stack.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

6:32 AM Changeset in webkit [159872] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should check for extraneous newline between config.h and primary header.
​https://bugs.webkit.org/show_bug.cgi?id=124821

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-11-29
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_line_break_after_own_header):
(OrderOfIncludesTest):
(OrderOfIncludesTest.test_check_line_break_before_own_header):

6:16 AM Changeset in webkit [159871] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
​https://bugs.webkit.org/show_bug.cgi?id=124892

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::call): Pick a scratch register instead of getting it as a
parameter. The sh4 port was the only one to have this call(Address, RegisterID) prototype.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Use argumentGPRx and merge arm and sh4 paths.

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator): Use argumentGPRx and merge arm and sh4 paths.

4:23 AM Changeset in webkit [159870] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Accessibility rebaselines after r159848.

  • platform/efl-wk1/accessibility/table-detection-expected.txt:
  • platform/efl-wk2/accessibility/table-detection-expected.txt:
4:06 AM Changeset in webkit [159869] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove Symbian specific code.
​https://bugs.webkit.org/show_bug.cgi?id=124939

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

Symbian is not supported, remove leftover code.

  • plugins/npapi.h:
3:41 AM Changeset in webkit [159868] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

test-webkit-scripts should show the failing tests and use an appropriate exit code
​https://bugs.webkit.org/show_bug.cgi?id=124840

Patch by Jozsef Berta <​jberta@inf.u-szeged.hu> on 2013-11-29
Reviewed by Ryosuke Niwa.

A fixme in test-webkit-scripts asked that the script should display success or failiure
and exit with a 0 or 1 value accordingly after all of the tests have completed.

  • Scripts/test-webkit-scripts:

(ScriptsTester.run_test_script):
The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
because at this point we don't need to pass on more information other than success or failiure.
(ScriptsTester.main):
The return values are now stored for each script and when all tests have completed successfully,
the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.

3:38 AM Changeset in webkit [159867] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk

[ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
​https://bugs.webkit.org/show_bug.cgi?id=124923

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-11-29
Reviewed by Mario Sanchez Prada.

Tools:

Added missing implementation of isAttributeSettable. Using
ATK_STATE_EDITABLE for checking whether attribute is settable.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isAttributeSettable):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isAttributeSettable):

LayoutTests:

Test could be reused by EFL and GTK as well.

  • accessibility/content-editable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-expected.txt.
  • accessibility/content-editable.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable.html.
3:26 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com
changeset 159572 is controversial (diff)
2:51 AM Changeset in webkit [159866] by commit-queue@webkit.org
  • 3 edits in trunk

[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace
​https://bugs.webkit.org/show_bug.cgi?id=124899

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-29
Reviewed by Gyuyoung Kim.

  • Source/cmake/FindCairo.cmake:
  • Source/cmake/FindGStreamer.cmake:
12:37 AM Changeset in webkit [159865] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] viewport must be same with the size of webview
​https://bugs.webkit.org/show_bug.cgi?id=124965

Patch by Hunseop Jeong <Hunseop Jeong> on 2013-11-29
Reviewed by Gyuyoung Kim.

Currently, size of the viewport is larger than size of webview.
Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired): Changed to use the (0,0).
(EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
(EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.

Nov 28, 2013:

11:51 PM Changeset in webkit [159864] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
​https://bugs.webkit.org/show_bug.cgi?id=118548

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2013-11-28
Reviewed by Noam Rosenthal.

CoordinatedGraphics uses its own scaling logic - contents scaling - and
WebView of CoordinatedGraphics maintains contents position by scaling
with contents scaling factor.
However transformToScene() and updateViewportSize() of WebView regard
the contents position as a non-scaled value, so it should be fixed.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):

7:42 PM Changeset in webkit [159863] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL] PageViewportController does not need to be unique_ptr instance
​https://bugs.webkit.org/show_bug.cgi?id=124993

Reviewed by Gyuyoung Kim.

PageViewportController and PageViewportControllerEfl have same life cycle
with EwkView. So, we don't need to make them as unique_ptr instance.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::handleEvasObjectCalculate):
(EwkView::scrollBy):

  • UIProcess/API/efl/EwkView.h:

(EwkView::pageViewportController):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::didChangeViewportAttributes):

5:35 PM Changeset in webkit [159862] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Build fix after r159859
​https://bugs.webkit.org/show_bug.cgi?id=124992

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-28
Reviewed by Gyuyoung Kim.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.

  • UIProcess/API/gtk/PageClientImpl.h:
5:02 PM Changeset in webkit [159861] by jinwoo7.song@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL] Build fix after r159859
​https://bugs.webkit.org/show_bug.cgi?id=124991

Reviewed by Gyuyoung Kim.

Redefined newly added pure virtual function in PageClient class after r159859.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):

  • UIProcess/CoordinatedGraphics/WebView.h:
3:25 PM Changeset in webkit [159860] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebCore

Rename InlineIterator::m_obj and make it private
​https://bugs.webkit.org/show_bug.cgi?id=124837

Reviewed by Antti Koivisto.

InlineIterator has been exported m_obj as public though there is a getter function.
Besides *object* name isn't ambigious. So, changed it with m_renderer and renderer().
Additionally, setRenderer() is added as well.

No new tests, no behavior changes.

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::setObject):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineBidiResolver::appendRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::matchedEndLine):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::iteratorIsBeyondEndOfRenderCombineText):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::checkMidpoints):
(WebCore::BreakingContext::handleEndOfLine):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):

  • rendering/line/LineInlineHeaders.h:

(WebCore::skipNonBreakingSpace):
(WebCore::requiresLineBox):

2:23 PM WebKitGTK/Debugging edited by Andres Gomez
(diff)
1:01 PM Changeset in webkit [159859] by weinig@apple.com
  • 14 edits
    1 add in trunk/Source/WebKit2

Perform some spring cleaning to WKContentView and WKView
​https://bugs.webkit.org/show_bug.cgi?id=124961

Reviewed by Dan Bernstein.

  • Store the PageClientImpl in a std::unique_ptr.
  • Remove the WKBrowsingContextController internal load delegate. Replace its use with a new PageClient function, didCommitLoadForMainFrame.
  • Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame -> contentViewDidCommitLoadForMainFrame.
  • Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. These are needed for WebKitTestRunner.
  • Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef).
  • Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView.
  • Remove incorrect implementations of initWithCoder.
  • Make WKContentView lazily create its WKBrowsingContextController wrapper.
  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType):

  • UIProcess/API/ios/WKContentView.h:
  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithCoder:]):
(-[WKContentView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKContentView browsingContextController]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didReceiveMobileDocTypeForMainFrame]):
(-[WKContentView _didChangeViewportArguments:WebCore::]):
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _pageRef]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/API/ios/WKContentViewPrivate.h: Added.
  • UIProcess/API/ios/WKView.mm:

(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]):
(-[WKView contentViewDidCommitLoadForMainFrame:]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView pageRef]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didCommitLoadForFrame):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

12:59 PM Changeset in webkit [159858] by Antti Koivisto
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove an oddly named css variables test

Rubber-stamped by Andreas Kling.

  • css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
  • css3/filters/reference-filter-update-after-remove.html: Removed.
12:55 PM Changeset in webkit [159857] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WTF

Nix Upstream: Updating Nix WTF files
​https://bugs.webkit.org/show_bug.cgi?id=124980

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Just to sync our private repo files and the trunk, as part of the upstream process.

  • wtf/DisallowCType.h:
  • wtf/PlatformNix.cmake:
  • wtf/nix/FeatureDefinesNix.h:
  • wtf/nix/PlatformNix.h:
  • wtf/nix/RunLoopNix.cpp: Added.
12:53 PM Changeset in webkit [159856] by Antti Koivisto
  • 158 edits
    2 moves in trunk

Rename StylePropertySet to StyleProperties
​https://bugs.webkit.org/show_bug.cgi?id=124990

Reviewed by Andreas Kling.

"Set" does not add useful information here. Use less clunky plural name.

12:33 PM Changeset in webkit [159855] by nrotem@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Revert the X86 assembler peephole changes
​https://bugs.webkit.org/show_bug.cgi?id=124988

Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::branchAdd32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:43 AM Changeset in webkit [159854] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

Nix Upstream: Adding EditorNix to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=124984

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

No new tests needed.

  • PlatformNix.cmake:
  • editing/nix/EditorNix.cpp: Added.
11:35 AM Changeset in webkit [159853] by Csaba Osztrogonác
  • 274 edits
    2 adds in trunk/LayoutTests

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase EFL results (and the remaining Mac) after r159848.

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • fast/table/anonymous-table-section-removed.html: Updated.
  • platform/efl/accessibility/table-attributes-expected.txt: Added.
  • platform/efl/accessibility/table-sections-expected.txt: Added.
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/table/[...]:
  • platform/efl/tables/[...]:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
11:33 AM Changeset in webkit [159852] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Building EFL Webkit again with mediastream enabled
​https://bugs.webkit.org/show_bug.cgi?id=124930

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • CMakeLists.txt:
11:03 AM Changeset in webkit [159851] by Csaba Osztrogonác
  • 147 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/table/[...]:
  • platform/mac/tables/[...]:
10:54 AM Changeset in webkit [159850] by Csaba Osztrogonác
  • 269 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • platform/gtk/accessibility/table-detection-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/table/[...]:
  • platform/gtk/tables/[...]:
9:43 AM Changeset in webkit [159849] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
​https://bugs.webkit.org/show_bug.cgi?id=124959

Reviewed by Brent Fulgham.

Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

No new tests, no behavior change.

  • WebCore.vcxproj/WebCore.vcxproj.filters:
9:40 AM Changeset in webkit [159848] by Csaba Osztrogonác
  • 4 edits in trunk

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Use border spacing at the end of all sections.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Skipped tests enabled.

8:55 AM Changeset in webkit [159847] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Unreviewed, rolling out r159839.
​http://trac.webkit.org/changeset/159839
​https://bugs.webkit.org/show_bug.cgi?id=124974

run-webkit-tests doesn't generate pretty diff (Requested by
Ossy on #webkit).

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.pretty_patch_available):
(Port.check_pretty_patch):
(Port.variable):
(Port.variable.pretty_patch_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

8:35 AM Changeset in webkit [159846] by Michał Pakuła vel Rutka
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/TestExpectations: Added test expectations for failing tests.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.
8:20 AM Changeset in webkit [159845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Buildfix after r159824 for GCC 4.6
​https://bugs.webkit.org/show_bug.cgi?id=124968

Patch by Éva Balázsfalvi <​balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

  • Shared/APIObject.h:
8:19 AM Changeset in webkit [159844] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

No need to skip css variables tests as they were removed.

  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
8:02 AM Changeset in webkit [159843] by Gustavo Noronha Silva
  • 3 edits in trunk/Source/WebKit/gtk

REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
​https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

  • tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

7:46 AM Changeset in webkit [159842] by Antti Koivisto
  • 60 edits
    3 deletes in trunk

Remove feature: CSS variables
​https://bugs.webkit.org/show_bug.cgi?id=114119

.:

Reviewed by Andreas Kling.

  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSBasicShapes.cpp:
  • css/CSSBasicShapes.h:
  • css/CSSCalculationValue.cpp:

(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):

  • css/CSSCalculationValue.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):

  • css/CSSParser.h:
  • css/CSSParserMode.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSProperty.cpp:
  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

  • css/CSSReflectValue.cpp:
  • css/CSSReflectValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::setCssText):

  • css/CSSValueList.cpp:
  • css/CSSValueList.h:
  • css/CSSVariableValue.h: Removed.
  • css/Pair.h:
  • css/Rect.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):

  • css/StyleResolver.h:
  • css/WebKitCSSTransformValue.cpp:
  • css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::equals):

  • css/makeprop.pl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleVariableData.h: Removed.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

  • wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/variables: Removed.
  • fast/css/variables/border-width-expected.html: Removed.
  • fast/css/variables/border-width.html: Removed.
  • fast/css/variables/build-supports-variables-expected.txt: Removed.
  • fast/css/variables/build-supports-variables.html: Removed.
  • fast/css/variables/calc-expected.html: Removed.
  • fast/css/variables/calc-inside-calc-expected.html: Removed.
  • fast/css/variables/calc-inside-calc.html: Removed.
  • fast/css/variables/calc-invalid-value-expected.html: Removed.
  • fast/css/variables/calc-invalid-value.html: Removed.
  • fast/css/variables/calc-invalid-variable-expected.html: Removed.
  • fast/css/variables/calc-invalid-variable.html: Removed.
  • fast/css/variables/calc-negated-variable-expected.html: Removed.
  • fast/css/variables/calc-negated-variable.html: Removed.
  • fast/css/variables/calc-vw-crash-expected.txt: Removed.
  • fast/css/variables/calc-vw-crash.html: Removed.
  • fast/css/variables/calc.html: Removed.
  • fast/css/variables/case-sensitive-expected.html: Removed.
  • fast/css/variables/case-sensitive.html: Removed.
  • fast/css/variables/colors-test-expected.html: Removed.
  • fast/css/variables/colors-test.html: Removed.
  • fast/css/variables/complex-cycle-expected.html: Removed.
  • fast/css/variables/complex-cycle.html: Removed.
  • fast/css/variables/computed-style-expected.html: Removed.
  • fast/css/variables/computed-style.html: Removed.
  • fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
  • fast/css/variables/deferred-image-load-from-variable.html: Removed.
  • fast/css/variables/inherited-values-expected.html: Removed.
  • fast/css/variables/inherited-values.html: Removed.
  • fast/css/variables/inline-styles-expected.html: Removed.
  • fast/css/variables/inline-styles.html: Removed.
  • fast/css/variables/invalid-font-reference-expected.txt: Removed.
  • fast/css/variables/invalid-font-reference.html: Removed.
  • fast/css/variables/invalid-shorthand-expected.html: Removed.
  • fast/css/variables/invalid-shorthand.html: Removed.
  • fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
  • fast/css/variables/invalid-value-list-crash.html: Removed.
  • fast/css/variables/invalid-variable-value-expected.html: Removed.
  • fast/css/variables/invalid-variable-value.html: Removed.
  • fast/css/variables/multi-level-cycle-expected.html: Removed.
  • fast/css/variables/multi-level-cycle.html: Removed.
  • fast/css/variables/redefinition-expected.html: Removed.
  • fast/css/variables/redefinition.html: Removed.
  • fast/css/variables/root-background-size-expected.html: Removed.
  • fast/css/variables/root-background-size.html: Removed.
  • fast/css/variables/shorthand-expected.html: Removed.
  • fast/css/variables/shorthand.html: Removed.
  • fast/css/variables/simple-cycle-expected.html: Removed.
  • fast/css/variables/simple-cycle.html: Removed.
  • fast/css/variables/transform-test-expected.html: Removed.
  • fast/css/variables/transform-test.html: Removed.
  • fast/css/variables/undefined-expected.html: Removed.
  • fast/css/variables/undefined.html: Removed.
  • fast/css/variables/use-before-defined-expected.html: Removed.
  • fast/css/variables/use-before-defined.html: Removed.
  • fast/css/variables/var-filter-expected.txt: Removed.
  • fast/css/variables/var-filter.html: Removed.
  • fast/css/variables/var-inside-box-reflect-expected.html: Removed.
  • fast/css/variables/var-inside-box-reflect.html: Removed.
  • fast/css/variables/var-inside-pair-expected.html: Removed.
  • fast/css/variables/var-inside-pair.html: Removed.
  • fast/css/variables/var-inside-quad-expected.html: Removed.
  • fast/css/variables/var-inside-quad.html: Removed.
  • fast/css/variables/var-inside-shape-expected.html: Removed.
  • fast/css/variables/var-inside-shape.html: Removed.
  • fast/css/variables/var-inside-shorthand-expected.html: Removed.
  • fast/css/variables/var-inside-shorthand.html: Removed.
  • fast/css/variables/variable-chain-expected.html: Removed.
  • fast/css/variables/variable-chain.html: Removed.
  • fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
  • fast/css/variables/variable-unparseable-value-crash.html: Removed.
7:27 AM Changeset in webkit [159841] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Layout tests need to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=124879

Unreviewed, EFL rebaseline.

EFL tests need to be rebaselined after r159747

Patch by Jongwoo Choi <​jw0330.choi@samsung.com> on 2013-11-28

  • platform/efl/fast/table/011-expected.txt:
  • platform/efl/fast/table/border-collapsing/004-expected.txt:
  • platform/efl/fast/table/tableInsideCaption-expected.txt:
7:15 AM Changeset in webkit [159840] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Updating RTCPeerConnectionHandlerMock after r159769
​https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::create):

  • platform/mock/RTCPeerConnectionHandlerMock.h:
7:14 AM Changeset in webkit [159839] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Move PrettyPatch related code to prettypatch.py
​https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

6:20 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva
(diff)
6:09 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva
(diff)
5:46 AM Changeset in webkit [159838] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Checkout should own the scm object in Host
​https://bugs.webkit.org/show_bug.cgi?id=124943

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/host.py:

(Host.init):
(Host.initialize_scm):
(Host.scm):

5:41 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva
(diff)
4:40 AM Changeset in webkit [159837] by Gustavo Noronha Silva
  • 9 edits in trunk

[GTK] Support custom types for drag and drop data
​https://bugs.webkit.org/show_bug.cgi?id=124659

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-11-27
Reviewed by Martin Robinson.

Source/WebCore:

Covered by fast/events/drag-customData.html.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
(WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.

  • platform/gtk/DataObjectGtk.h:

(WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
(WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
(WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeString): handle unknown types as custom.
(WebCore::Pasteboard::writePasteboard): ditto.
(WebCore::Pasteboard::hasData): also check for custom types.
(WebCore::Pasteboard::types): also obtain the list of custom types.
(WebCore::Pasteboard::readString): handle unknown types as custom.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::initGdkAtoms): new unknown atom.
(WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
(WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
is in turn serialized to a single string for GtkSelectionData to hold.
(WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
set.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
from the serialized GVariant string held by GtkSelectionData.
(WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

Source/WebKit2:

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeDataObject): encode the unknown types data.
(CoreIPC::decodeDataObject): decode the unknown types data.

LayoutTests:

  • platform/gtk/TestExpectations: remove failure expectation for test that now passes.
4:22 AM WebKitGTK/2.2.x edited by tpopela@redhat.com
(diff)
2:28 AM Changeset in webkit [159836] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Typo fix after r159834 to fix 32 bit builds.

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Note: See TracTimeline for information about the timeline view.