Timeline
Feb 17, 2014:
- 11:53 PM Changeset in webkit [164275] by
-
- 6 edits in trunk/Source/WebCore
[CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=128914
Reviewed by Antti Koivisto.
Moved named flow specific methods regionContainer() and regionContainerLayer() from
RenderRegion to RenderNamedFlowFragment and renamed them to fragmentContainer and
fragmentContainerLayer.
No new tests required.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::fragmentContainer):
(WebCore::RenderNamedFlowFragment::fragmentContainerLayer):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
- 11:17 PM Changeset in webkit [164274] by
-
- 4 edits in trunk/Source/WebCore
Move PublicURLMansger to std::unique_ptr.
https://bugs.webkit.org/show_bug.cgi?id=128891
Patch by Sangho Kim <thomas.kim@lge.com> on 2014-02-17
Reviewed by Anders Carlsson.
Use std::unique_ptr and std::make_unique in place of PassOwnPtr and adoptPtr in the PublicURLManager
- dom/ScriptExecutionContext.h:
- html/PublicURLManager.cpp:
(WebCore::PublicURLManager::create):
- html/PublicURLManager.h:
- 10:51 PM Changeset in webkit [164273] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed gtk build fix.
- GNUmakefile.list.am: Remove WebHistoryClient.cpp/h after r164230.
- 9:18 PM Changeset in webkit [164272] by
-
- 15 edits in trunk/Source
Expose a way to clear cookies modified after a given date
https://bugs.webkit.org/show_bug.cgi?id=128845
Patch by Ricky Mondello <Ricky Mondello> on 2014-02-17
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- WebCore.exp.in: Add a symbol.
- platform/network/PlatformCookieJar.h: Declare deleteAllCookiesModifiedAfterDate.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::deleteAllCookiesModifiedAfterDate): Add a stub.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::deleteAllCookiesModifiedAfterDate): Ditto.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteAllCookiesModifiedAfterDate): Ditto.
- platform/network/mac/CookieJarMac.mm: Add a category NSHTTPCookieStorage category with the method
used for time-based clearing so we can build on all platforms. For now, we'll check for support
at runtime.
(WebCore::deleteAllCookiesModifiedAfterDate): Added. Without foundation API, we'll ignore the passed-in
NetworkStorageSession.
Source/WebKit2:
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerDeleteAllCookiesModifiedAfterDate): Added. Call out to the CookieManager.
- UIProcess/API/C/WKCookieManager.h: Declare WKCookieManagerDeleteAllCookiesModifiedAfterDate.
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedAfterDate): Added. Dispatch message to the
Network Process.
- UIProcess/WebCookieManagerProxy.h: Declare deleteAllCookiesModifiedAfterDate.
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteAllCookiesModifiedAfterDate): Added. Call out to WebCore to finish the job.
- WebProcess/Cookies/WebCookieManager.h: Declare deleteAllCookiesModifiedAfterDate.
- WebProcess/Cookies/WebCookieManager.messages.in: Add new message.
- 9:13 PM Changeset in webkit [164271] by
-
- 18 edits3 copies4 moves1 add in trunk/Source/WebKit2
[EFL][WK2] Move and make WKColorPickerResultListener to EFL specific interface
https://bugs.webkit.org/show_bug.cgi?id=119120
Reviewed by Gyuyoung Kim.
WKColorPickerResultListener and related files are only used in EFL since added.
Indeed, it does not work since refactored common logic for ColorPicker in WebPageProxy.
This patch moved them to EFL specfic and refactor to work well.
- CMakeLists.txt: Moved WebColorPickerResultListenerProxy.cpp to PlatformEfl.cmake.
- GNUmakefile.list.am: Removed ColorPickerResultListener related files which are only for Efl from source list.
- PlatformEfl.cmake: Added ColorPickerResultListenerProxy related files and newly added files into source list.
- UIProcess/API/APIUIClient.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/C/efl/WKColorPickerResultListener.cpp: Renamed from Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.cpp.
(WKColorPickerResultListenerGetTypeID):
(WKColorPickerResultListenerSetColor):
- UIProcess/API/C/efl/WKColorPickerResultListener.h: Renamed from Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.h.
- UIProcess/API/C/efl/WKViewEfl.cpp: Introduced WKColorPickerClient and setter.
(WKViewSetColorPickerClient):
- UIProcess/API/C/efl/WKViewEfl.h:
- UIProcess/API/efl/tests/test_ewk2_color_picker.cpp: Enabled test case for color picker.
(TEST_F):
- UIProcess/WebPageProxy.cpp: Removed unnecessary WebColorPickerResultListenerProxy dependency.
- UIProcess/WebPageProxy.h: Ditto.
- UIProcess/efl/PageUIClientEfl.cpp: Removed color picker callbacks of PageUIClient.
(WebKit::PageUIClientEfl::PageUIClientEfl):
- UIProcess/efl/PageUIClientEfl.h:
- UIProcess/efl/ViewClientEfl.cpp: Registered callbacks of WKColorPickerClient.
(WebKit::ViewClientEfl::showColorPicker):
(WebKit::ViewClientEfl::endColorPicker):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
- UIProcess/efl/WebColorPickerClient.cpp: Copied from Source/WebKit2/UIProcess/efl/ViewClientEfl.h.
(WebKit::WebColorPickerClient::showColorPicker):
(WebKit::WebColorPickerClient::endPicker):
- UIProcess/efl/WebColorPickerClient.h: Added.
- UIProcess/efl/WebColorPickerEfl.cpp: Copied from Source/WebKit2/UIProcess/efl/ViewClientEfl.h.
(WebKit::WebColorPickerEfl::WebColorPickerEfl):
(WebKit::WebColorPickerEfl::endPicker):
(WebKit::WebColorPickerEfl::showColorPicker):
(WebKit::WebColorPickerEfl::setSelectedColor):
(WebKit::WebColorPickerEfl::didChooseColor):
- UIProcess/efl/WebColorPickerEfl.h: Copied from Source/WebKit2/UIProcess/efl/ViewClientEfl.h.
(WebKit::WebColorPickerEfl::create):
(WebKit::WebColorPickerEfl::~WebColorPickerEfl):
- UIProcess/efl/WebColorPickerResultListenerProxy.cpp: Renamed from Source/WebKit2/UIProcess/WebColorPickerResultListenerProxy.cpp.
(WebKit::WebColorPickerResultListenerProxy::WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::~WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::invalidate):
(WebKit::WebColorPickerResultListenerProxy::setColor):
- UIProcess/efl/WebColorPickerResultListenerProxy.h: Renamed from Source/WebKit2/UIProcess/WebColorPickerResultListenerProxy.h.
(WebKit::WebColorPickerResultListenerProxy::create):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::initializeColorPickerClient):
(WebKit::WebViewEfl::createColorPicker):
- UIProcess/efl/WebViewEfl.h:
(WebKit::WebViewEfl::colorPickerClient):
- WebKit2.xcodeproj/project.pbxproj: Removed ColorPickerResultListener related files which are only for Efl from source list.
- 8:59 PM Changeset in webkit [164270] by
-
- 9 edits in trunk/Tools
Stop using PLATFORM(MAC) in DumpRenderTree except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128950
Reviewed by Anders Carlsson.
Changed all PLATFORM(MAC) instances that were not excluding iOS to PLATFORM(COCOA).
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityTextMarker.h:
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(computeMD5HashStringForBitmapContext):
- DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::~BitmapContext):
- DumpRenderTree/config.h:
- 8:20 PM Changeset in webkit [164269] by
-
- 12 edits1 delete in trunk
More ARM FTL glue
https://bugs.webkit.org/show_bug.cgi?id=128948
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Allow for an header search directory for LLVM's generated files.
- Configurations/LLVMForJSC.xcconfig: Link the right things for ARM.
- assembler/ARM64Assembler.h: Builds fix.
(JSC::ARM64Assembler::fillNops):
- disassembler/LLVMDisassembler.cpp: Use the right target triples.
(JSC::tryToDisassembleWithLLVM):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps): Build fix.
- jit/GPRInfo.h: Builds fix.
- llvm/library/LLVMExports.cpp: Link the right things.
(initializeAndGetJSCLLVMAPI):
Source/WTF:
- wtf/Platform.h:
Tools:
- Scripts/configure-llvm: Removed. This isn't really practical now that we require a separate build directory.
- Scripts/copy-webkitlibraries-to-product-directory: Switch to using a separate build directory, and for setting a PATH before running LLVM's make.
- 8:10 PM Changeset in webkit [164268] by
-
- 3 edits2 adds in trunk
SelectorCompiler incorrectly saves a backtracking register for a child chain without descendant relation on the right
https://bugs.webkit.org/show_bug.cgi?id=128944
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-17
Reviewed by Andreas Kling.
Source/WebCore:
When resolving the backtracking relations, the value of ancestorPositionSinceDescendantRelation was incorrect for the
rightmost child chain.
What was happenning is updateChainStates() would increment ancestorPositionSinceDescendantRelation even if there was
no descendant relation previously in the chain. As a result, the second SelectorFragment in the fragment chain would
save a backtracking register.
Previously this would just be a wasted register but since r163850, the number of registers available for compilation
is defined by SelectorCompiler::minimumRegisterRequirements(). Since we would have one less register available than computed,
we could run out of register and RegisterAllocator would invoke WTFCrash to avoid generating incorrect code.
This patch fixes the issue by not updating ancestorPositionSinceDescendantRelation until the first descendant relation
is seen. There was no need to fix the Adjacent relation because adjacentPositionSinceIndirectAdjacentTreeWalk already
had the correct guard.
Test: fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::updateChainStates):
(WebCore::SelectorCompiler::isFirstAdjacent): The name was a bad copy-paste, fix it.
LayoutTests:
- fast/selectors/querySelector-rightmost-child-chain-attribute-matching-expected.txt: Added.
- fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html: Added.
- 7:50 PM Changeset in webkit [164267] by
-
- 4 edits in trunk/Source/WebKit2
[iOS, WebKit2] Add settings and correct default values for settings important on iOS
https://bugs.webkit.org/show_bug.cgi?id=128947
Reviewed by Simon Fraser.
- Shared/WebPreferencesStore.cpp:
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 6:50 PM Changeset in webkit [164266] by
-
- 9 edits in trunk
[CoordinatedGraphics][EFL] Remove view_source functions.
https://bugs.webkit.org/show_bug.cgi?id=128945
Reviewed by Anders Carlsson.
EFL port has been broken since r164254 because of removing view source files in WK2.
This patch is to follow to remove remained view source functions.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
- UIProcess/CoordinatedGraphics/WebView.cpp:
- UIProcess/CoordinatedGraphics/WebView.h:
- 6:31 PM Changeset in webkit [164265] by
-
- 4 edits9 adds in trunk
Constrain replaced element layout to from-intrinsic aspect ratio if specified
https://bugs.webkit.org/show_bug.cgi?id=128629
Reviewed by Simon Fraser.
Source/WebCore:
First pass at implementing -webkit-aspect-ratio: from-instrinsics;
After RenderReplaced has done layout, attempt to update the
resulting size to match the desired aspect ratio. This step
will only reduce the size of an element, and never below the
minimum dimensions.
Tests: fast/css/aspect-ratio/columns.html
fast/css/aspect-ratio/containers.html
fast/css/aspect-ratio/simple.html
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged): If we get an update
to our intrinsic dimensions, and layout depends on this, trigger
another layout pass.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout): Implement the step described
above.
LayoutTests:
Three new tests that exercise aspect ratio on:
- normal content
- content that is constrained within a parent container
- content in columns (pages)
- fast/css/aspect-ratio/badchess-tall.png: Added.
- fast/css/aspect-ratio/badchess-wide.png: Added.
- fast/css/aspect-ratio/columns-expected.html: Added.
- fast/css/aspect-ratio/columns.html: Added.
- fast/css/aspect-ratio/containers-expected.html: Added.
- fast/css/aspect-ratio/containers.html: Added.
- fast/css/aspect-ratio/simple-expected.html: Added.
- fast/css/aspect-ratio/simple.html: Added.
- 6:03 PM Changeset in webkit [164264] by
-
- 5 edits in tags/Safari-538.16.7/Source
Versioning.
- 6:01 PM Changeset in webkit [164263] by
-
- 1 copy in tags/Safari-538.16.7
New Tag.
- 5:35 PM Changeset in webkit [164262] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.exp.in:
- 5:32 PM Changeset in webkit [164261] by
-
- 8 edits in trunk/Source
Remove ENABLE_GLOBAL_FASTMALLOC_NEW
https://bugs.webkit.org/show_bug.cgi?id=127067
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- parser/Nodes.h:
Source/WebCore:
- platform/Timer.h:
Source/WTF:
Remove the global operator new/operator delete overrides. Having ALWAYS_INLINE operators
like we do is really undefined behavior according to the C++ standard and we've been lucky enough
to get away with it so far, but any code that calls operator new/operator delete inside from the C++ standard
library (not from headers that are included) will be mismatched and potentially crash. libc++ calls
delete in it's std::thread implementation for example.
The only supported way to override operator new and operator delete globally is to not use inline
functions, but that would mean that any application using WebKit would not be able to provide custom
operator new/operator delete functions so we'll just reuse the already existing infrastructure consisting
of the WTF_MAKE_FAST_ALLOCATED macro.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/FastMalloc.h:
- wtf/Platform.h:
- 4:56 PM Changeset in webkit [164260] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][wk2] Custom layers are sometimes put on-screen without being parented
https://bugs.webkit.org/show_bug.cgi?id=128935
<rdar://problem/16022336>
Reviewed by Sam Weinig.
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForExternalHostingProcess):
Give an explicit and unlikely display ID, so that the layer will never
be brought on-screen unless explicitly parented.
- 4:53 PM Changeset in webkit [164259] by
-
- 4 edits in trunk/Source/WebCore
Move iOS only Settings into Settings.in and make them not-iOS only
https://bugs.webkit.org/show_bug.cgi?id=128942
Reviewed by Tim Horton.
- page/Settings.cpp:
- page/Settings.h:
- page/Settings.in:
- 4:44 PM Changeset in webkit [164258] by
-
- 7 edits2 copies1 add in trunk/Source/WebKit2
Add history delegate to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128930
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKHistoryDelegatePrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h.
- UIProcess/API/Cocoa/WKProcessClass.mm:
(-[WKProcessClass initWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _historyDelegate]):
(-[WKWebView _setHistoryDelegate:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/HistoryClient.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h.
- UIProcess/Cocoa/HistoryClient.mm: Added.
(WebKit::HistoryClient::HistoryClient):
(WebKit::HistoryClient::~HistoryClient):
(WebKit::HistoryClient::didNavigateWithNavigationData):
(WebKit::HistoryClient::didPerformClientRedirect):
(WebKit::HistoryClient::didPerformServerRedirect):
(WebKit::HistoryClient::didUpdateHistoryTitle):
(WebKit::HistoryClient::populateVisitedLinks):
(WebKit::HistoryClient::shouldTrackVisitedLinks):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::navigationStates):
(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::~NavigationState):
(WebKit::NavigationState::fromWebPage):
(WebKit::NavigationState::historyDelegate):
(WebKit::NavigationState::setHistoryDelegate):
(WebKit::NavigationState::didNavigateWithNavigationData):
(WebKit::NavigationState::didPerformClientRedirect):
(WebKit::NavigationState::didPerformServerRedirect):
(WebKit::NavigationState::didUpdateHistoryTitle):
- WebKit2.xcodeproj/project.pbxproj:
- 4:30 PM Changeset in webkit [164257] by
-
- 2 edits in trunk
[GTK] [CMake] JavaScriptCore crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434
Reviewed by Anders Carlsson.
- Source/cmake/OptionsGTK.cmake: Add -fno-omit-frame-pointer to the GTK+ CMake
port as well as -fno-tree-dce, like it is used in the autotools build.
- 4:16 PM Changeset in webkit [164256] by
-
- 3 edits1 move1 add1 delete in trunk/Source/WebKit2
[WebKit2] Merge WebProcessMac and WebProcessIOS into WebProcessCocoa
https://bugs.webkit.org/show_bug.cgi?id=128939
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
Add/remove files/groups.
- WebProcess/WebProcess.h:
Change stopRunLoop() to be AppKit only.
- WebProcess/cocoa: Added.
- WebProcess/cocoa/WebProcessCocoa.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessMac.mm.
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::initializeSandbox):
(WebKit::WebProcess::updateActivePages):
- WebProcess/ios/WebProcessIOS.mm: Removed.
- WebProcess/mac/WebProcessMac.mm: Removed.
Copy mac/WebProcessMac.mm to cocoa/WebProcessCocoa.mm, and add #if USE(APPKIT) where appropriate.
- 4:08 PM Changeset in webkit [164255] by
-
- 22 edits in trunk/Source/WebKit2
Stop using isMainThread() in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128940
<rdar://problem/15963666>
Reviewed by Enrica Casucci.
Since isMainThread() has a different meaning when the web thread is enabled on iOS,
just use RunLoop::isMain() to check if we're executing on the main thread.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::ensurePathExists):
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::shutdownBackingStore):
(WebKit::UniqueIDBDatabase::didShutdownBackingStore):
(WebKit::UniqueIDBDatabase::deleteDatabase):
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::didOpenBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::UniqueIDBDatabase::changeDatabaseVersion):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStore):
(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::rollbackBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::changeDatabaseVersionInBackingStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::deleteObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::clearObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::createIndexInBackingStore):
(WebKit::UniqueIDBDatabase::deleteIndexInBackingStore):
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::absoluteDatabaseDirectory):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::generateDatabaseId):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openSQLiteDatabaseAtPath):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::beginTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::commitTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::resetTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::rollbackTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::changeDatabaseVersion):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::clearObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::generateKeyNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::updateKeyGeneratorNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRange):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::count):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::notifyCursorsOfChanges):
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::shared):
- NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::scheduleResourceLoader):
(WebKit::HostRecord::addLoaderInProgress):
(WebKit::HostRecord::removeLoader):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::removeLoader):
(WebKit::NetworkResourceLoadScheduler::receivedRedirect):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::setHostRecord):
(WebKit::NetworkResourceLoader::hostRecord):
- NetworkProcess/mac/DiskCacheMonitor.mm:
(WebKit::DiskCacheMonitor::DiskCacheMonitor):
- Shared/AsyncRequest.cpp:
(WebKit::generateRequestID):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::generateAuthenticationChallengeID):
(WebKit::AuthenticationManager::establishIdentifierForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
- Shared/Downloads/mac/DownloadMac.mm:
(dispatchOnMainThread):
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy):
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
- Shared/SessionTracker.cpp:
(WebKit::staticSessionMap):
(WebKit::storageSessionToID):
(WebKit::identifierBase):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):
- UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::dispatchCookiesDidChange):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::deleteDatabase):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::generateServerConnectionIdentifier):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::dispatchWheelEvent):
- 3:53 PM Changeset in webkit [164254] by
-
- 43 edits7 deletes in trunk/Source
Remove view source code
https://bugs.webkit.org/show_bug.cgi?id=127233
Reviewed by Antti Koivisto.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts):
- css/CSSDefaultStyleSheets.cpp:
- css/CSSDefaultStyleSheets.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
(WebCore::DocumentRuleSets::collectFeatures):
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchUARules):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
- css/view-source.css: Removed.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.h:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
- html/HTMLAttributeNames.in:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::openURL):
- html/HTMLFrameElementBase.h:
- html/HTMLViewSourceDocument.cpp: Removed.
- html/HTMLViewSourceDocument.h: Removed.
- html/parser/HTMLToken.h:
- html/parser/HTMLViewSourceParser.cpp: Removed.
- html/parser/HTMLViewSourceParser.h: Removed.
- html/parser/TextViewSourceParser.cpp: Removed.
- html/parser/TextViewSourceParser.h: Removed.
- inspector/InspectorOverlayPage.css:
(.tag-name):
(.node-id):
(.class-name):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
- xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString):
- xml/XMLViewer.css:
(.tag):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
Source/WebKit/mac:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::inViewSourceMode):
(WebFrame::setInViewSourceMode):
- WebView.cpp:
(WebView::setInViewSourceMode):
(WebView::inViewSourceMode):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:53 PM Changeset in webkit [164253] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
- platform/win/TestExpectations: Remove a few duplicate test statements, as well as
some removed test cases.
- 3:45 PM Changeset in webkit [164252] by
-
- 5 edits2 adds in trunk
box-shadows get truncated with a combination of transforms and clip: (affects Google Maps)
https://bugs.webkit.org/show_bug.cgi?id=128937
Source/WebCore:
Reviewed by Dean Jackson.
RenderLayer::calculateLayerBounds() incorrectly assumed that if localClipRect() returns
a non-infinite rect, that rect is OK to use as the compositing bounds.
That is not a valid assumption when clip() has a larger rect than the element (e.g.
with negative top/left in the rect). In that case, localClipRect() still just
returns the background rect, but we actually need a larger compositing layer
to show the unclipped parts of descendants.
Fix by detecting clip() that exceeds the renderer bounds, and when it does,
not early returning in the UseLocalClipRectIfPossible clause.
Test: compositing/geometry/css-clip-oversize.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localClipRect): Do a convertToLayerCoords()
because we need offsetFromRoot later, and we can pass our value down to
calculateRects(). Compute clipExceedsBounds based on the CSS clip rect.
(WebCore::RenderLayer::calculateClipRects): Don't early return if clipExceedsBounds
is true.
- rendering/RenderLayer.h:
LayoutTests:
Reviewed by Dean Jackson.
Test with CSS clip() with a rect larger than the border box, and compositing.
- compositing/geometry/clip-expected.txt: New expectation. This is a progression.
- compositing/geometry/css-clip-oversize-expected.html: Added.
- compositing/geometry/css-clip-oversize.html: Added.
- 3:29 PM Changeset in webkit [164251] by
-
- 16 edits in trunk/Source/WebCore
Make TreeScope::rootNode return a reference
https://bugs.webkit.org/show_bug.cgi?id=128934
Reviewed by Andreas Kling.
It is never null.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
- dom/ContainerNode.h:
(WebCore::Node::isTreeScope):
- dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getAllElementsById):
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::moveToParentOrShadowHost):
(WebCore::eventTargetRespectingTargetRules):
(WebCore::shouldEventCrossShadowBoundary):
- dom/Node.cpp:
(WebCore::Node::containingShadowRoot):
(WebCore::Node::removedFrom):
- dom/ShadowRoot.h:
(WebCore::isShadowRoot):
- dom/TreeScope.h:
(WebCore::TreeScope::rootNode):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
- page/DragController.cpp:
(WebCore::asFileInput):
- page/FocusController.cpp:
(WebCore::FocusNavigationScope::rootNode):
- 2:44 PM Changeset in webkit [164250] by
-
- 2 edits in trunk/Tools
[Win] There's another Windows SDK. Make sure we recognize it.
https://bugs.webkit.org/show_bug.cgi?id=128932
Reviewed by Tim Horton.
- Scripts/webkitpy/port/win.py:
(WinPort._ntsd_location):
- 2:26 PM Changeset in webkit [164249] by
-
- 3 edits2 adds in trunk
AX: Invalid cast in WebCore::AccessibilityTable::isDataTable (CRBug 280352)
<https://webkit.org/b/128925>
<rdar://problem/16087351>
Merged from Blink (patch by Dominic Mazzoni):
https://src.chromium.org/viewvc/blink?revision=159711&view=revision
Reviewed by Oliver Hunt.
Source/WebCore:
Don't cast to a table cell element unless we are sure it is one.
Test: accessibility/display-table-cell-causes-crash.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
LayoutTests:
- accessibility/display-table-cell-causes-crash-expected.txt: Added.
- accessibility/display-table-cell-causes-crash.html: Added.
- 2:12 PM Changeset in webkit [164248] by
-
- 19 edits in trunk/Source/WebCore
Node constructor should take Document reference
https://bugs.webkit.org/show_bug.cgi?id=128931
Reviewed by Geoff Garen.
- dom/Attr.cpp:
(WebCore::Attr::Attr):
- dom/CharacterData.h:
(WebCore::CharacterData::CharacterData):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):
- dom/ContainerNode.h:
(WebCore::ContainerNode::ContainerNode):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Node::Node):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment):
(WebCore::DocumentFragment::create):
- dom/DocumentFragment.h:
- dom/DocumentType.cpp:
(WebCore::DocumentType::DocumentType):
- dom/Element.h:
(WebCore::Element::Element):
- dom/Entity.h:
(WebCore::Entity::Entity):
- dom/EntityReference.cpp:
(WebCore::EntityReference::EntityReference):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::willBeDeletedFrom):
- dom/Node.h:
- dom/Notation.cpp:
- dom/Notation.h:
(WebCore::Notation::publicId):
(WebCore::Notation::systemId):
(WebCore::Notation::Notation):
Remove cruft from this non-instantiated class.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
- dom/TemplateContentDocumentFragment.h:
- 1:40 PM Changeset in webkit [164247] by
-
- 2 edits in trunk/Tools
webkitpy test fix on Mac after r164244.
It's somewhat crazy that we're trying to run unittests for Windows on Mac but whatever.
- Scripts/webkitpy/port/win.py:
(WinPort._ntsd_location):
- 12:58 PM Changeset in webkit [164246] by
-
- 3 edits in trunk/LayoutTests
Fix layout test added in r164232 to avoid bug 128929
and use rects which don't have minor rendering differences when
drawn into compositing layers.
- compositing/contents-opaque/opaque-with-clip-path-expected.html:
- compositing/contents-opaque/opaque-with-clip-path.html:
- 12:35 PM Changeset in webkit [164245] by
-
- 64 edits in trunk/Source
Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=128681
Reviewed by Timothy Hatcher.
Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
WebCore/inspector/*. Besides files in there, a few other files in
JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
and WebCore/testing were touched.
Source/JavaScriptCore:
- inspector/ContentSearchUtilities.cpp:
- inspector/ContentSearchUtilities.h:
- inspector/agents/InspectorConsoleAgent.cpp:
- inspector/agents/InspectorConsoleAgent.h:
Source/WebCore:
No new tests; no new behavior.
- WebCore.exp.in:
- inspector/CommandLineAPIHost.cpp:
- inspector/CommandLineAPIHost.h:
- inspector/DOMEditor.cpp:
- inspector/DOMPatchSupport.cpp:
- inspector/DOMPatchSupport.h:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorHistory.cpp:
- inspector/InspectorHistory.h:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorOverlay.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp:
- inspector/InspectorStyleSheet.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/PageConsoleAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/WebConsoleAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- testing/Internals.cpp:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WebKit/efl:
- WebCoreSupport/InspectorClientEfl.cpp:
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
Source/WebKit/ios:
- WebCoreSupport/WebInspectorClientIOS.mm:
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
- WebCoreSupport/WebInspectorClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- 12:25 PM Changeset in webkit [164244] by
-
- 2 edits in trunk/Tools
[Win] Fall back to Windows symbol servers when necessary
https://bugs.webkit.org/show_bug.cgi?id=128926
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/port/win.py:
(WinPort):
(setup_crash_log_saving): Fall back to Microsoft Symbol Server when local symbols are
not specified.
- 12:23 PM Changeset in webkit [164243] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
FTL should support ToPrimitive and the DFG should fold it correctly
https://bugs.webkit.org/show_bug.cgi?id=128892
Reviewed by Geoffrey Garen.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileToPrimitive):
- tests/stress/fold-to-primitive-in-cfa.js: Added.
(foo):
(.result.foo):
- tests/stress/fold-to-primitive-to-identity-in-cfa.js: Added.
(foo):
(.result.foo):
- 12:19 PM Changeset in webkit [164242] by
-
- 5 edits in trunk/Source/WebCore
Rename Document::m_selfOnlyRefCount to m_referencingNodeCount
https://bugs.webkit.org/show_bug.cgi?id=128916
Reviewed by Andreas Kling.
Make the name more informative. Also make it zero based (document is not considered to reference itself).
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::removedLastRef):
- dom/Document.h:
(WebCore::Document::increaseReferencingNodeCount):
(WebCore::Document::decreaseReferencingNodeCount):
(WebCore::Node::Node):
- dom/Node.cpp:
(WebCore::Node::~Node):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- 12:07 PM Changeset in webkit [164241] by
-
- 3 edits in trunk/Source/JavaScriptCore
Register preservation wrapper should know about the possibility of callee-saved FPRs
https://bugs.webkit.org/show_bug.cgi?id=128923
Reviewed by Mark Hahnenberg.
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterPreservationWrapper):
(JSC::generateRegisterRestoration):
- jit/RegisterSet.cpp:
- 12:06 PM Changeset in webkit [164240] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix attempt
- CMakeLists.txt: Remove WebHistoryClient.cpp after r164230.
- 11:48 AM Changeset in webkit [164239] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build failure caused by missing jsmin module
https://bugs.webkit.org/show_bug.cgi?id=128742
Reviewed by Philippe Normand.
No new tests since no functionality changed.
- GNUmakefile.am: Relocate PYTHONPATH to make it meaningful.
- 11:46 AM HackingWebInspector edited by
- (diff)
- 11:45 AM Changeset in webkit [164238] by
-
- 2 edits in trunk/Source/JavaScriptCore
lr is a special register on ARM64
https://bugs.webkit.org/show_bug.cgi?id=128922
Reviewed by Mark Hahnenberg.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::specialRegisters):
- 11:44 AM HackingWebInspector edited by
- (diff)
- 11:39 AM Changeset in webkit [164237] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix RegisterSet::calleeSaveRegisters() by making it correct on ARM64
https://bugs.webkit.org/show_bug.cgi?id=128921
Reviewed by Mark Hahnenberg.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters):
- 11:39 AM HackingWebInspector edited by
- (diff)
- 11:36 AM Changeset in webkit [164236] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS selectors containing a color name shouldn't be considered for color editing
https://bugs.webkit.org/show_bug.cgi?id=128909
Reviewed by Joseph Pecoraro.
Disregard any text that might be contained within a CSS selector.
- UserInterface/CodeMirrorAdditions.js:
- 11:26 AM Changeset in webkit [164235] by
-
- 4 edits in trunk/Source
WebKitGTK+ should stop calling functions to set the view source mode
https://bugs.webkit.org/show_bug.cgi?id=128919
Reviewed by Carlos Garcia Campos.
This is a first step towards getting rid of the view source mode from WebCore.
View source shouldn't be a mode on the web page and can be implemented in other ways by
embedding apps. Furthermore, the inspector has an excellent view source mode.
Source/WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_set_view_source_mode):
(webkit_web_view_get_view_source_mode):
Turn these into no-ops.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_view_mode):
(webkit_web_view_get_view_mode):
Turn these into no-ops.
- 11:22 AM Changeset in webkit [164234] by
-
- 3 edits2 adds in trunk
[CSS Regions] Make regions unsplittable
https://bugs.webkit.org/show_bug.cgi?id=128811
Reviewed by David Hyatt.
Source/WebCore:
At the moment, nested regions are not properly fragmented across regions. For the moment,
the regions will become unsplittable elements to avoid slicing. At a later time a proper
fragmentation algorithm should be written, also taking into consideration pagination strut.
Test: fast/regions/unsplittable-nested-region.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):
LayoutTests:
Added test for checking that nested regions are unsplittable.
- fast/regions/unsplittable-nested-region-expected.html: Added.
- fast/regions/unsplittable-nested-region.html: Added.
- 11:15 AM Changeset in webkit [164233] by
-
- 2 edits in trunk/Source/JavaScriptCore
RegisterSet::calleeSaveRegisters() should know about ARM64
https://bugs.webkit.org/show_bug.cgi?id=128918
Reviewed by Mark Hahnenberg.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters):
- 11:13 AM Changeset in webkit [164232] by
-
- 3 edits2 adds in trunk
Graphics buffer issue with clip-path and fixed positioned element
https://bugs.webkit.org/show_bug.cgi?id=126262
Source/WebCore:
Reviewed by Tim Horton.
If an element has a clip-path, backgroundIsKnownToBeOpaqueInRect() needs
to return false so that we don't try to make opaque compositing layers.
Test: compositing/contents-opaque/opaque-with-clip-path.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Tim Horton.
- compositing/contents-opaque/opaque-with-clip-path-expected.html: Added.
- compositing/contents-opaque/opaque-with-clip-path.html: Added.
- 11:10 AM Changeset in webkit [164231] by
-
- 5 edits10 adds in trunk
[CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box
https://bugs.webkit.org/show_bug.cgi?id=128815
Reviewed by Andrei Bucur.
Source/WebCore:
Elements flowed into a region should not be painted past the region's content box
if they continue to flow into another region in that direction.
If they do not continue into another region in that direction, they should be
painted all the way to the region's border box.
Regions with overflow:hidden will apply clip at the border box, not the content box.
Tests: fast/regions/box-decorations-over-region-padding-fragmented.html
fast/regions/box-decorations-over-region-padding-horiz-bt.html
fast/regions/box-decorations-over-region-padding-vert-lr.html
fast/regions/box-decorations-over-region-padding-vert-rl.html
fast/regions/box-decorations-over-region-padding.html
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::flowThreadPortionRectForClipping):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::rectFlowPortionForBox):
LayoutTests:
Added tests for the painting of the borders of elements flowed into regions
over the region's padding area, for regions with overflow:hidden.
Tests were added for all writing modes.
- fast/regions/box-decorations-over-region-padding-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-fragmented-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-fragmented.html: Added.
- fast/regions/box-decorations-over-region-padding-horiz-bt-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-horiz-bt.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-lr-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-lr.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-rl-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-rl.html: Added.
- fast/regions/box-decorations-over-region-padding.html: Added.
- 11:08 AM Changeset in webkit [164230] by
-
- 7 edits1 move1 delete in trunk/Source/WebKit2
Turn the history client into a fancy API::HistoryClient abstract base class
https://bugs.webkit.org/show_bug.cgi?id=128917
Reviewed by Andreas Kling.
- UIProcess/API/APIHistoryClient.h: Renamed from Source/WebKit2/UIProcess/WebHistoryClient.h.
(API::HistoryClient::~HistoryClient):
(API::HistoryClient::didNavigateWithNavigationData):
(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):
(API::HistoryClient::populateVisitedLinks):
(API::HistoryClient::shouldTrackVisitedLinks):
- UIProcess/API/C/WKContext.cpp:
(WKContextSetHistoryClient):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::setHistoryClient):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::populateVisitedLinks):
- UIProcess/WebContext.h:
(WebKit::WebContext::historyClient):
- UIProcess/WebHistoryClient.cpp: Removed.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- 11:00 AM Changeset in webkit [164229] by
-
- 109 edits in trunk/Source/JavaScriptCore
Move back primary header includes next to config.h
https://bugs.webkit.org/show_bug.cgi?id=128912
Reviewed by Alexey Proskuryakov.
- dfg/DFGAbstractHeap.cpp:
- dfg/DFGAbstractValue.cpp:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGArithMode.cpp:
- dfg/DFGArrayMode.cpp:
- dfg/DFGAtTailAbstractState.cpp:
- dfg/DFGAvailability.cpp:
- dfg/DFGBackwardsPropagationPhase.cpp:
- dfg/DFGBasicBlock.cpp:
- dfg/DFGBinarySwitch.cpp:
- dfg/DFGBlockInsertionSet.cpp:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFAPhase.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCSEPhase.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGClobberSet.cpp:
- dfg/DFGClobberize.cpp:
- dfg/DFGCommon.cpp:
- dfg/DFGCommonData.cpp:
- dfg/DFGCompilationKey.cpp:
- dfg/DFGCompilationMode.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGCriticalEdgeBreakingPhase.cpp:
- dfg/DFGDCEPhase.cpp:
- dfg/DFGDesiredIdentifiers.cpp:
- dfg/DFGDesiredStructureChains.cpp:
- dfg/DFGDesiredTransitions.cpp:
- dfg/DFGDesiredWatchpoints.cpp:
- dfg/DFGDesiredWeakReferences.cpp:
- dfg/DFGDesiredWriteBarriers.cpp:
- dfg/DFGDisassembler.cpp:
- dfg/DFGDominators.cpp:
- dfg/DFGEdge.cpp:
- dfg/DFGFailedFinalizer.cpp:
- dfg/DFGFinalizer.cpp:
- dfg/DFGFixupPhase.cpp:
- dfg/DFGFlushFormat.cpp:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
- dfg/DFGFlushedAt.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGGraphSafepoint.cpp:
- dfg/DFGInPlaceAbstractState.cpp:
- dfg/DFGIntegerCheckCombiningPhase.cpp:
- dfg/DFGInvalidationPointInjectionPhase.cpp:
- dfg/DFGJITCode.cpp:
- dfg/DFGJITCompiler.cpp:
- dfg/DFGJITFinalizer.cpp:
- dfg/DFGJumpReplacement.cpp:
- dfg/DFGLICMPhase.cpp:
- dfg/DFGLazyJSValue.cpp:
- dfg/DFGLivenessAnalysisPhase.cpp:
- dfg/DFGLongLivedState.cpp:
- dfg/DFGLoopPreHeaderCreationPhase.cpp:
- dfg/DFGMinifiedNode.cpp:
- dfg/DFGNaturalLoops.cpp:
- dfg/DFGNode.cpp:
- dfg/DFGNodeFlags.cpp:
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
- dfg/DFGOSREntry.cpp:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.cpp:
- dfg/DFGOSRExitBase.cpp:
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
- dfg/DFGOSRExitCompilerCommon.cpp:
- dfg/DFGOSRExitJumpPlaceholder.cpp:
- dfg/DFGOSRExitPreparation.cpp:
- dfg/DFGPhase.cpp:
- dfg/DFGPlan.cpp:
- dfg/DFGPredictionInjectionPhase.cpp:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGResurrectionForValidationPhase.cpp:
- dfg/DFGSSAConversionPhase.cpp:
- dfg/DFGSSALoweringPhase.cpp:
- dfg/DFGSafepoint.cpp:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGStackLayoutPhase.cpp:
- dfg/DFGStoreBarrierElisionPhase.cpp:
- dfg/DFGStrengthReductionPhase.cpp:
- dfg/DFGThreadData.cpp:
- dfg/DFGThunks.cpp:
- dfg/DFGTierUpCheckInjectionPhase.cpp:
- dfg/DFGToFTLDeferredCompilationCallback.cpp:
- dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
- dfg/DFGTypeCheckHoistingPhase.cpp:
- dfg/DFGUnificationPhase.cpp:
- dfg/DFGUseKind.cpp:
- dfg/DFGValidate.cpp:
- dfg/DFGValueSource.cpp:
- dfg/DFGVariableAccessDataDump.cpp:
- dfg/DFGVariableEvent.cpp:
- dfg/DFGVariableEventStream.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
- dfg/DFGWatchpointCollectionPhase.cpp:
- dfg/DFGWorklist.cpp:
- heap/JITStubRoutineSet.cpp:
- jit/GCAwareJITStubRoutine.cpp:
- jit/JIT.cpp:
- jit/JITDisassembler.cpp:
- jit/JITOperations.cpp:
- jit/JITStubRoutine.cpp:
- jit/JITStubs.cpp:
- jit/TempRegisterSet.cpp:
- 10:59 AM Changeset in webkit [164228] by
-
- 6 edits in trunk/Source/JavaScriptCore
FTL OSR exit shouldn't make X86-specific assumptions
https://bugs.webkit.org/show_bug.cgi?id=128890
Reviewed by Mark Hahnenberg.
Mostly this is about not using push/pop, but instead using the more abstract pushToSave() and popToRestore() while reflecting on the stack alignment.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::pushToSaveImmediateWithoutTouchingRegisters):
(JSC::MacroAssembler::pushToSaveByteOffset):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::pushToSaveImmediateWithoutTouchingRegisters):
(JSC::MacroAssemblerARM64::pushToSaveByteOffset):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- 10:48 AM Changeset in webkit [164227] by
-
- 7 edits in trunk
DataCue.data should be a copy of the input ArrayBuffer, not a pointer
https://bugs.webkit.org/show_bug.cgi?id=128886
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, just updated existing track-datacue.html test.
- html/track/DataCue.cpp:
(WebCore::DataCue::DataCue): Add ExceptionCode and pass through to setData().
(WebCore::DataCue::data): Return a copy of m_data instead of a pointer.
(WebCore::DataCue::setData): Create a copy of the input data, or throw an exception if it's null.
- html/track/DataCue.h: Add ExceptionCode parameters to constructor and data setter.
- html/track/DataCue.idl: Same.
LayoutTests:
- media/track/track-datacue-expected.txt:
- media/track/track-datacue.html:
- 10:47 AM Changeset in webkit [164226] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, make this test pass without DFG. It was assuming that you always have DFG
and that it would always tier-up to the DFG - both wrong assumptions.
- tests/stress/tricky-array-bounds-checks.js:
(foo):
- 10:26 AM Changeset in webkit [164225] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix iOS Debug builds without breaking Release builds.
- WebProcess/WebPage/PageBanner.cpp:
- WebProcess/WebPage/PageBanner.h:
- 9:18 AM Changeset in webkit [164224] by
-
- 5 edits in trunk/Source/WebCore
CounterContentData::counter() and ImageContentData::image() should return references
<http://webkit.org/b/128671>
Reviewed by Darin Adler.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
- Update to use references. Remove useless ASSERTs.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
- Update to use references. StyleResolver::loadPendingImage() will be changed to take a reference in the near future.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
- Update to use references. The auto keyword wanted to instantiate a StyleImage instead a reference, so it was replaced.
- rendering/style/ContentData.h:
(WebCore::ImageContentData::ImageContentData): Add ASSERT that
m_image is not NULL.
(WebCore::ImageContentData::image): Return a reference. Remove
useless overload with identical name.
(WebCore::ImageContentData::cloneInternal): Simplify by using
implicit PassRefPtr constructor.
(WebCore::operator==): Remove unneeded deref operators.
(WebCore::CounterContentData::counter): Return a reference.
(WebCore::CounterContentData::cloneInternal): Remove unneeded
deref operator.
(WebCore::operator==): Remove unneeded deref operators.
- 9:17 AM Changeset in webkit [164223] by
-
- 3 edits in trunk/Source/WebCore
[MediaControls][iOS] Make mediacontrols match the system inline controls
https://bugs.webkit.org/show_bug.cgi?id=128833
Reviewed by Eric Carlson.
Move items slightly, fix button sizes, font sizes, and colors to match the
inline controls from MoviePlayer.framework.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-play-button.paused):
(audio::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb):
(audio::-webkit-media-controls-time-remaining-display):
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.configureInlineControls): Do not add the status text.
(ControllerIOS.prototype.updateTime): Call updateProgress().
(ControllerIOS.prototype.progressFillStyle): Draw a slightly different color.
(ControllerIOS.prototype.updateProgress): Draw white to the left of the currentTime.
(ControllerIOS.prototype.formatTime): Single leading zero in the time display fields.
(ControllerIOS.prototype.handleTimelineChange): Call updateProgress().
- 8:18 AM Changeset in webkit [164222] by
-
- 2 edits in trunk
[GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=128799
Reviewed by Philippe Normand.
MEDIA_CONTROLS_SCRIPT has a dependency on VIDEO_TRACK. So it causes a build break
if building with autotools. cmake system has enabled it as default. So I propose
enabling VIDEO_TRACK as well.
- Source/autotools/SetupWebKitFeatures.m4:
- 7:29 AM Changeset in webkit [164221] by
-
- 2 edits in trunk/Tools
Fix typos in Tools/efl/jhbuild.modules.
https://bugs.webkit.org/show_bug.cgi?id=128908
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- efl/jhbuild.modules: 's/<deb /<dep /g'
- 7:17 AM Changeset in webkit [164220] by
-
- 2 edits in trunk/Source/WTF
Enable DFG_JIT on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128898
Patch by Ryan Lortie <desrt@desrt.ca> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h:
- 6:56 AM Changeset in webkit [164219] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for crashing and failing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:12 AM Changeset in webkit [164218] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r162724 - [GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
https://bugs.webkit.org/show_bug.cgi?id=127064
When pressing <Esc> or <f> at full screen, the WebView shall emit the
event webkitfullscreenchange, but wk2gtk does not emit it. This is
because the WebView manages directly the exit of the full screen.
With this patch the WebView calls requestExitFullScreen to the full
screen manager, instead of managing directly the exit of the full
screen, and the event webkitfullscreenchange will be dispatched
correctly.
Reviewed by Martin Robinson.
No tests are included because there is a bug in WKTR that prevents the
execution of a test for this patch. See
https://bugs.webkit.org/show_bug.cgi?id=127348
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call
webkitWebViewBaseRequestExitFullScreen.
(webkitWebViewBaseRequestExitFullScreen): Added.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
- 6:09 AM WebKitGTK/2.2.x edited by
- (diff)
- 5:23 AM Changeset in webkit [164217] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the CLoop build after r163760
https://bugs.webkit.org/show_bug.cgi?id=128900
Patch by Dániel Bátyai <Dániel Bátyai> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- llint/LLIntThunks.cpp:
- 5:14 AM Changeset in webkit [164216] by
-
- 2 edits in trunk/Source/JavaScriptCore
CLoop buildfix after r164207
https://bugs.webkit.org/show_bug.cgi?id=128899
Patch by Dániel Bátyai <Dániel Bátyai> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
- 3:24 AM WebKitGTK/2.2.x edited by
- (diff)
- 3:11 AM WebKitGTK/2.4.x edited by
- Add bug #126927 as a future merge candidate. (diff)
- 3:09 AM Changeset in webkit [164215] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.90
Tagging the WebKitGTK+ 2.3.90 release
- 2:57 AM Changeset in webkit [164214] by
-
- 3 edits2 adds in trunk
[CSS Grid Layout] Fix missing layout in flexible and content sized columns
https://bugs.webkit.org/show_bug.cgi?id=128672
Reviewed by Sergio Villar Senin.
Source/WebCore:
RenderGrid::logicalContentHeightForChild() is called for some items at the beginning of RenderGrid::layoutGridItems()
from RenderGrid::computeUsedBreadthOfGridTracks(). This causes that the comparison inside the for loop in
RenderGrid::layoutGridItems() does not detect width changes, so elements won't be marked as needsLayout.
So the comparison is done in RenderGrid::logicalContentHeightForChild() and the element is marked to perform a layout if
the width has changed.
The issue can be reproduced easily with a simple grid with one flexible or content sized column, all the available width
is not used. On top of that, when you resize the window the flexible or content sized columns are not updating their
size properly.
CSS Grid Layout perftest results are around 4% worse, which is expected as we're adding a missing layout.
Test: fast/css-grid-layout/flex-content-sized-column-use-available-width.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild): Check width changes and mark element as needed layout if required.
LayoutTests:
Add test that reproduce the issue for both cases flexible and content sized columns.
- fast/css-grid-layout/flex-content-sized-column-use-available-width-expected.html: Added.
- fast/css-grid-layout/flex-content-sized-column-use-available-width.html: Added.
- 2:54 AM Changeset in webkit [164213] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.3.90 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.90.
- 2:51 AM Changeset in webkit [164212] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4/Source
Unreviewed. Fix make distcheck.
Source/WebCore:
- GNUmakefile.list.am: Add missing header files.
Source/WebKit2:
- GNUmakefile.list.am: Add missing header files.
- 12:47 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:32 AM Changeset in webkit [164211] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4
Merge r163954 - 'ar T' is not portable and breaks the build on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128596
Patch by Ryan Lortie <desrt@desrt.ca> on 2014-02-12
Reviewed by Gustavo Noronha Silva.
Create thin archives only if we are using GNU ar.
- Source/autotools/SetupLibtool.m4:
- 12:27 AM Changeset in webkit [164210] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r163875 - O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572
Reviewed by Darin Adler.
The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):
- 12:25 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:21 AM Changeset in webkit [164209] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.4
Merge r163871 - [GStreamer] High playback rate causes crash
https://bugs.webkit.org/show_bug.cgi?id=128453
Patch by Piotr Grad <p.grad@samsung.com> on 2014-02-11
Reviewed by Philippe Normand.
Source/WebCore:
To high playback rate passed to GStreamer was causing crash.
Added guard in setRate method.
Test: media/video-extreme-playbackrate-crash.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate):
LayoutTests:
Test checks if passing high playback rate causes crash.
- media/video-extreme-playbackrate-crash-expected.txt: Added.
- media/video-extreme-playbackrate-crash.html: Added.
- 12:20 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:15 AM WebKitGTK/2.4.x edited by
- (diff)
Feb 16, 2014:
- 10:47 PM Changeset in webkit [164208] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, 32-bit build fix.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::lshiftPtr):
- 10:35 PM Changeset in webkit [164207] by
-
- 40 edits9 adds in trunk
FTL should inline polymorphic heap accesses
https://bugs.webkit.org/show_bug.cgi?id=128795
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
We now inline GetByIds that we know are pure but polymorphic. They manifest in DFG IR
as MultiGetByOffset, and in LLVM IR as a switch with a basic block for each kind of
read.
2% speed-up on Octane mostly due to a 18% speed-up on deltablue.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/ExitingJITType.cpp: Added.
(WTF::printInternal):
- bytecode/ExitingJITType.h:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::dump):
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::numVariants):
(JSC::GetByIdStatus::variants):
(JSC::GetByIdStatus::at):
(JSC::GetByIdStatus::operator[]):
- bytecode/GetByIdVariant.cpp: Added.
(JSC::GetByIdVariant::dump):
(JSC::GetByIdVariant::dumpInContext):
- bytecode/GetByIdVariant.h: Added.
(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::isSet):
(JSC::GetByIdVariant::operator!):
(JSC::GetByIdVariant::structureSet):
(JSC::GetByIdVariant::chain):
(JSC::GetByIdVariant::specificValue):
(JSC::GetByIdVariant::offset):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommon.h:
(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldShowDisassembly):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasMultiGetByOffsetData):
(JSC::DFG::Node::multiGetByOffsetData):
- dfg/DFGNodeType.h:
- dfg/DFGPhase.h:
(JSC::DFG::Phase::graph):
(JSC::DFG::runAndLog):
- dfg/DFGPlan.cpp:
(JSC::DFG::dumpAndVerifyGraph):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
- ftl/FTLState.h:
(JSC::FTL::verboseCompilationEnabled):
(JSC::FTL::showDisassembly):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionEffectful42):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::dump):
(JSC::IntendedStructureChain::dumpInContext):
- runtime/IntendedStructureChain.h:
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- tests/stress/fold-multi-get-by-offset-to-get-by-offset-with-watchpoint.js: Added.
(foo):
(bar):
- tests/stress/fold-multi-get-by-offset-to-get-by-offset.js: Added.
(foo):
(bar):
- tests/stress/multi-get-by-offset-proto-and-self.js: Added.
(foo):
(Foo):
Source/WTF:
Reviewed by Oliver Hunt.
- wtf/PrintStream.h:
(WTF::PointerDumpInContext::PointerDumpInContext):
(WTF::PointerDumpInContext::dump):
(WTF::pointerDumpInContext):
LayoutTests:
Reviewed by Oliver Hunt.
- js/regress/polymorphic-get-by-id-expected.txt: Added.
- js/regress/polymorphic-get-by-id.html: Added.
- js/regress/script-tests/polymorphic-get-by-id.js: Added.
(foo):
- 10:26 PM Changeset in webkit [164206] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, add a useful comment for this test.
- js/regress/script-tests/marsaglia-osr-entry.js:
- 10:25 PM Changeset in webkit [164205] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG::prepareOSREntry should be nice to the stack
https://bugs.webkit.org/show_bug.cgi?id=128883
Reviewed by Oliver Hunt.
Previously OSR entry had some FIXME's and some really badly commented-out code for
clearing stack entries to help GC. It also did some permutations on a stack frame
above us, in such a way that it wasn't obviously that we wouldn't clobber our own
stack frame. This function also crashed in ASan.
It just seems like there was too much badness to the whole idea of prepareOSREntry
directly editing the stack. So, I changed it to create a stack frame in a scratch
buffer on the side and then have some assembly code just copy it into place. This
works fine, fixes a FIXME, possibly fixes some stack clobbering, and might help us
make more progress with ASan.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
- dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
- dfg/DFGThunks.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOperations.cpp:
- 7:52 PM Changeset in webkit [164204] by
-
- 3 edits2 adds in trunk
Ensure that removing an iframe from the DOM tree disconnects its Frame.
<https://webkit.org/b/128889>
<rdar://problem/15671221>
Merged from Blink (patch by Adam Klein):
https://src.chromium.org/viewvc/blink?revision=156174&view=revision
Source/WebCore:
SubframeLoadingDisabler wasn't catching the case when an <iframe> was,
in its unload handler, removed and re-added to the same parent.
Fix this by using a count of SubframeLoadingDisablers that are on the
stack for a given root, rather than a simple boolean.
Test: fast/frames/reattach-in-unload.html
- html/HTMLFrameOwnerElement.h:
(WebCore::SubframeLoadingDisabler::disabledSubtreeRoots):
LayoutTests:
- fast/frames/reattach-in-unload-expected.txt: Added.
- fast/frames/reattach-in-unload.html: Added.
- 7:19 PM Changeset in webkit [164203] by
-
- 3 edits4 adds in trunk
When applying style, attribute value matching should be case sensitive for SVG
https://bugs.webkit.org/show_bug.cgi?id=128882
Reviewed by Andreas Kling.
Source/WebCore:
SelectorChecker was incorrectly matching attribute values with a case insensitve comparison
in some cases.
The choice to use case sensitive matching was taking into account the document type but not
the element type. As a result, SVG (and likely MHTML) elements were incorrectly being tested
as if they were HTML element.
With the patch, WebKit also matches the behavior of Firefox, which is great.
Tests: fast/css/case-insensitive-attribute-with-svg.html
fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
LayoutTests:
- fast/css/case-insensitive-attribute-with-svg-expected.html: Added.
- fast/css/case-insensitive-attribute-with-svg.html: Added.
- fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt: Added.
- fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html: Added.
- 7:14 PM Changeset in webkit [164202] by
-
- 5 edits in trunk/Source/WebCore
Split compilation state between querySelector and CSS matching
https://bugs.webkit.org/show_bug.cgi?id=128869
Reviewed by Antti Koivisto.
Cleanup after recent changes:
-SelectorCompiler now has a SelectorContext defining if the code is compiled for QuerySelector
or for ElementRuleCollector.
-Generalize m_selectorCannotMatchAnything by making it part of the FunctionType. FunctionType now
fully represent the type of code generation and we don't rely implicitly on m_selectorFragments being
empty.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::compileSelector):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
There is no tree marking for QuerySelector, so we can generate a simple selector
for the sibling selectors.
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
The code is split to make it simpler. The classic code generation has been moved
to generateSelectorChecker().
The decision on what to generate is reduced to a simple switch-case.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
The code that was previously in compile().
(WebCore::SelectorCompiler::SelectorCodeGenerator::markParentElementIfResolvingStyle):
We should not generate tree marking on querySelector traversal. Since the constructor
now generate a SimpleChecker, it would also be incorrect to attempt to access the checkingContext
on the stack.
We can just skip the marking entierly.
- cssjit/SelectorCompiler.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
With the changes of SelectorContext, we can no longer generate a complex checker for querySelector.
This code may come back in the future but at the moment it is useless.
- 7:11 PM Changeset in webkit [164201] by
-
- 2 edits in trunk/Source/WebCore
The FTP view is squished to the left
https://bugs.webkit.org/show_bug.cgi?id=128856
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-16
Reviewed by Andreas Kling.
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- 5:48 PM Changeset in webkit [164200] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Make AreaAllocator fast allocated
https://bugs.webkit.org/show_bug.cgi?id=124995
Reviewed by Anders Carlsson.
AreaAllocator can be created and destroyed frequently (at least once per
frame) in case of animation with changing width or height. So, it's
better to make AreaAllocator fast allocated.
- platform/graphics/texmap/coordinated/AreaAllocator.h:
- 4:50 PM Changeset in webkit [164199] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebKit crashes if text is copied to pasteboard with style containing text-shadow
https://bugs.webkit.org/show_bug.cgi?id=128888
<rdar://problem/16065699>
Reviewed by Anders Carlsson.
Use the correct class on iOS so that we don't crash.
- platform/mac/HTMLConverter.mm:
(_shadowForShadowStyle):
- 2:59 PM Changeset in webkit [164198] by
-
- 4 edits in trunk/Source/WebCore
Atomicize frequently identical ResourceResponse string members.
<https://webkit.org/b/128887>
Store the mime type, text encoding and HTTP response status text in
AtomicStrings instead of Strings to deduplicate frequently occurring
values (e.g "text/html", "utf-8" and "OK".)
Reviewed by Geoffrey Garen.
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformLazyInit):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
- 2:45 PM Changeset in webkit [164197] by
-
- 2 edits in trunk/Source/WebKit2
Speculative iOS build fix.
- WebProcess/WebPage/mac/PageBannerMac.mm:
- 2:43 PM Changeset in webkit [164196] by
-
- 2 edits in trunk/Source/WebCore
Speculative iOS build fix.
- dom/Document.cpp:
(WebCore::Document::Document):
- 2:18 PM Changeset in webkit [164195] by
-
- 15 edits in trunk/Source/WebCore
Move document life time management from TreeScope to Document
https://bugs.webkit.org/show_bug.cgi?id=128877
Reviewed by Andreas Kling.
Document life time is managed in confusing manner by TreeScopes which are also inherited to ShadowRoots.
This patches moves the life time management to Document. Nodes in shadow trees selfOnlyRef the Document instead
of the ShadowRoot. ShadowRoot is treated like any other node and selfOnlyRefs the Document as well (which it
also did earlier, indirectly).
TreeScope is devirtualized.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
Author stylesheets never match in UA shadow trees.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::removedLastRef):
- dom/Document.h:
(WebCore::Document::selfOnlyRef):
(WebCore::Document::selfOnlyDeref):
To avoid branches Document self-refs itself like all other Nodes. This is why deletion will now happen on ref count of 1.
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
- dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
- dom/Node.h:
(WebCore::Node::document):
(WebCore::Node::inDocument):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
- dom/ShadowRoot.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::setParentTreeScope):
- dom/TreeScope.h:
(WebCore::TreeScope::documentScope):
Document can no longer ever be null.
(WebCore::TreeScope::rootNode):
(WebCore::TreeScope::setDocumentScope):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveShadowTreeToNewDocument):
Manage Document selfOnlyRefs for nodes in shadow trees too.
(WebCore::TreeScopeAdopter::updateTreeScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- dom/TreeScopeAdopter.h:
- 2:00 PM Changeset in webkit [164194] by
-
- 4 edits in trunk/Source/WebCore
setSelectionRange shouldn't directly instantiate VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=128881
Reviewed by Andreas Kling.
Added a new version of moveTo for setSelectionRange.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::moveTo): Added.
- editing/FrameSelection.h:
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange): Use the newly added FrameSelection::moveTo
instead of manually instantiating VisibleSelection here.
- 1:38 PM Changeset in webkit [164193] by
-
- 2 edits in trunk/Source/WebKit2
Speculative iOS build fix.
- WebProcess/WebPage/PageBanner.h:
- 12:38 PM Changeset in webkit [164192] by
-
- 59 edits in trunk/Source
Stop using PLATFORM(MAC) in Source except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128885
Reviewed by Anders Carlsson.
Source/WebCore:
- loader/FrameLoaderClient.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- platform/Cursor.h: Changed PLATFORM(MAC) to USE(APPKIT) around uses of NSCursor.
- platform/LocalizedStrings.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- platform/graphics/PlatformLayer.h: Ditto.
- platform/graphics/cg/PDFDocumentImage.cpp: Ditto.
- rendering/RenderLayerCompositor.cpp: Ditto.
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Source/WebKit2:
- Configurations/WebKit2.xcconfig: Removed PageBannerMac.mm and WKBundlePageBannerMac.mm
from EXCLUDED_SOURCE_FILE_NAMES_iphoneos, now that these files are guarded with
!PLATFORM(IOS).
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Changed PLATFORM(MAC) to
PLATFORM(COCOA).
(WKBundleFrameCopyWebArchiveFilteringSubframes):
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm: Guarded with !PLATFORM(IOS).
- WebProcess/InjectedBundle/InjectedBundle.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h: Changed PLATFORM(MAC) to USE(FOUNDATION)
around use of NSBundle.
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: Changed PLATFORM(MAC) to
PLATFORM(COCOA).
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/Network/WebResourceLoader.cpp: Ditto.
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: Ditto.
(WebKit::NPN_GetValue):
(WebKit::NPN_SetValue):
(WebKit::initializeBrowserFuncs):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: Ditto.
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::supportsSnapshotting):
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Ditto.
- WebProcess/Plugins/Plugin.cpp: Ditto.
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h: Ditto.
- WebProcess/Plugins/PluginController.h: Ditto.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: Changed PLATFORM(MAC) to
USE(DARWIN) around use of Mach-based IPC.
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/Plugins/PluginProxy.cpp: Chanegd PLATFORM(MAC) to PLATFORM(COCOA).
- WebProcess/Plugins/PluginProxy.h: Ditto.
- WebProcess/Plugins/PluginProxy.messages.in: Ditto.
- WebProcess/Plugins/PluginView.cpp: Ditto.
(WebKit::PluginView::destroyPluginAndReset):
(WebKit::PluginView::viewStateDidChange):
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::pluginSnapshotTimerFired):
- WebProcess/Plugins/PluginView.h: Ditto.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
(WebKit::WebChromeClient::windowRect):
- WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebContextMenuClient.h: Ditto.
- WebProcess/WebCoreSupport/WebDragClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebDragClient.h: Ditto.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: Ditto.
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Ditto.
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::createPlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Ditto.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Ditto.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Removed PLATFORM(MAC).
(InitWebCoreSystemInterface):
- WebProcess/WebPage/DrawingArea.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h: Ditto.
- WebProcess/WebPage/DrawingArea.messages.in: Ditto.
- WebProcess/WebPage/EventDispatcher.cpp: Ditto.
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/LayerTreeHost.h: Ditto.
- WebProcess/WebPage/PageBanner.cpp: Added !PLATFORM(IOS)
- WebProcess/WebPage/PageBanner.h: Ditto.
- WebProcess/WebPage/WebFrame.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- WebProcess/WebPage/WebFrame.h: Ditto.
- WebProcess/WebPage/WebInspector.cpp: Ditto.
(WebKit::WebInspector::WebInspector):
- WebProcess/WebPage/WebInspector.h: Ditto.
- WebProcess/WebPage/WebPage.cpp: Ditto.
(WebKit::WebPage::WebPage):
(WebKit::isContextClick):
(WebKit::WebPage::getSelectionAsWebArchiveData):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::sendSetWindowFrame):
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::computePagesForPrinting):
- WebProcess/WebPage/WebPage.h: Ditto.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- WebProcess/WebPage/mac/PageBannerMac.mm: Guarded with !PLATFORM(IOS).
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::WebProcess::initializeWebProcess): Ditto.
(WebKit::WebProcess::ensureNetworkProcessConnection): Changed PLATFORM(MAC) to OS(DARWIN).
(WebKit::WebProcess::ensurePrivateBrowsingSession): Changed PLATFORM(MAC) to
PLATFORM(COCOA).
(WebKit::WebProcess::destroyPrivateBrowsingSession): Ditto.
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Changed PLATFORM(MAC) to
OS(DARWIN).
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired): Changed PLATFORM(MAC) to
PLATFORM(COCOA)
- WebProcess/WebProcess.h: Ditto.
- WebProcess/WebProcess.messages.in: Removed PLATFORM(MAC) guard around
SetProcessSuppressionEnabled. Changed it to PLATFORM(COCOA) around SetQOS.
- 9:41 AM Changeset in webkit [164191] by
-
- 2 edits in trunk/Source/WebCore
Speculative iOS build fix after r164184.
- dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
- 1:11 AM Changeset in webkit [164190] by
-
- 2 edits in trunk/Source/WTF
Reintroduce const qualifiers for return types of (Filter|Transform)Iterator::operator*()
https://bugs.webkit.org/show_bug.cgi?id=126875
The const qualifiers for the return types of FilterIterator::operator*() and TransformIterator::operator*()
were removed in r161797 and r161802 because of compilation failures when using GCC and having an Iterator
type that already had the const qualifier. std::remove_const is now used to appease GCC and enforce the const
qualifier on the return type, regardless of the Iterator type and its qualifiers.
- wtf/IteratorAdaptors.h:
(WTF::FilterIterator::operator*):
(WTF::TransformIterator::operator*):
Feb 15, 2014:
- 9:07 PM Changeset in webkit [164189] by
-
- 2 edits in trunk/Tools
Build break when disabled ACCESSIBILITY since r162986
https://bugs.webkit.org/show_bug.cgi?id=128880
Unreviewed build fix.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
Added dummy implementations for newly added methods.
(WTR::AccessibilityUIElement::rowHeaders):
(WTR::AccessibilityUIElement::columnHeaders):
(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
- 7:33 PM Changeset in webkit [164188] by
-
- 2 edits in trunk/Source/WebCore
DOMSelection shouldn't instantiate VisibleSelection everywhere
https://bugs.webkit.org/show_bug.cgi?id=128879
Reviewed by Antti Koivisto.
Removed explicit instantiation of VisibleSelection from various member functions of VisibleSelection.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::collapseToEnd):
(WebCore::DOMSelection::collapseToStart):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::extend):
(WebCore::DOMSelection::getRangeAt):
(WebCore::DOMSelection::addRange):
- 7:11 PM Changeset in webkit [164187] by
-
- 4 edits3 deletes in trunk/Source/WebKit
[Mac] Remove WebSerializedJSValue SPI
https://bugs.webkit.org/show_bug.cgi?id=128720
Reviewed by Anders Carlsson.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Removed WebSerializedJSValue files from the project.
Source/WebKit/mac:
- WebKit.exp:
- WebView/WebSerializedJSValue.h: Removed.
- WebView/WebSerializedJSValue.mm: Removed.
- WebView/WebSerializedJSValuePrivate.h: Removed.
- 7:07 PM Changeset in webkit [164186] by
-
- 4 edits in trunk/Source/WebCore
Remove unused arguments from moveTo(Range*)
https://bugs.webkit.org/show_bug.cgi?id=128878
Reviewed by Antti Koivisto.
Cleanup.
- bindings/objc/DOMUIKitExtensions.mm:
(-[DOMRange move:inDirection:]):
(-[DOMRange extend:inDirection:]):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::moveTo):
- editing/FrameSelection.h:
- 6:54 PM Changeset in webkit [164185] by
-
- 9 edits in trunk
Vector with inline capacity should work with non-PODs
https://bugs.webkit.org/show_bug.cgi?id=128864
Source/JavaScriptCore:
Reviewed by Michael Saboff.
Deques no longer have inline capacity because it was broken, and we didn't need it
here anyway.
- dfg/DFGWorklist.h:
Source/WebCore:
Reviewed by Michael Saboff.
No new tests because no change behavior.
Deques no longer have inline capacity because it was broken, and we didn't need it
here anyway.
- page/WheelEventDeltaTracker.h:
Source/WTF:
Reviewed by Michael Saboff.
Previously, we would copy the inline storage of a vector as if it was a bag of bits.
This presumed that the element type was relocatable. In general this is only true for
PODs.
This patch changes this by introducing a swap operation over inline storage. This swap
operation requires being told about the size that is in use.
Deques would have required some cleverness to make this work, because the swap
operation needs to know which subset of elements are in-use and assumes that a size is
sufficient for this. That's not true for deques. Instead of trying to do very clever
things, I just removed the inline capacity option from Deque. I believe that this is
fine since there are only two users of Deque with inline capacity, and both of them
appear to be allocated rarely enough that inline capacity probably doesn't help much.
- wtf/Deque.h:
(WTF::DequeIterator::DequeIterator):
(WTF::DequeConstIterator::DequeConstIterator):
(WTF::Deque<T>::checkValidity):
(WTF::Deque<T>::checkIndexValidity):
(WTF::Deque<T>::invalidateIterators):
(WTF::Deque<T>::Deque):
(WTF::=):
(WTF::Deque<T>::destroyAll):
(WTF::Deque<T>::~Deque):
(WTF::Deque<T>::swap):
(WTF::Deque<T>::clear):
(WTF::Deque<T>::expandCapacityIfNeeded):
(WTF::Deque<T>::expandCapacity):
(WTF::Deque<T>::append):
(WTF::Deque<T>::prepend):
(WTF::Deque<T>::removeFirst):
(WTF::Deque<T>::removeLast):
(WTF::Deque<T>::remove):
(WTF::DequeIteratorBase<T>::checkValidity):
(WTF::DequeIteratorBase<T>::addToIteratorsList):
(WTF::DequeIteratorBase<T>::removeFromIteratorsList):
(WTF::DequeIteratorBase<T>::DequeIteratorBase):
(WTF::DequeIteratorBase<T>::~DequeIteratorBase):
(WTF::DequeIteratorBase<T>::isEqual):
(WTF::DequeIteratorBase<T>::increment):
(WTF::DequeIteratorBase<T>::decrement):
(WTF::DequeIteratorBase<T>::after):
(WTF::DequeIteratorBase<T>::before):
- wtf/Vector.h:
(WTF::VectorBuffer::swap):
(WTF::VectorBuffer::swapInlineBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::Vector::swap):
Tools:
Reviewed by Michael Saboff.
This test experiences really bizarre behavior on trunk without the rest of
this fix. On my machine, it usually times out because it gets itself into an
infinite loop of some kind. With the fix, it passes.
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 6:01 PM Changeset in webkit [164184] by
-
- 42 edits in trunk/Source/WebCore
Add checked casts for Event.
<https://webkit.org/b/128875>
Generate casting helpers for casting from Event to various subclasses
and go on static_cast replacement spree.
Reviewed by Sam Weinig.
- 4:36 PM Changeset in webkit [164183] by
-
- 5 edits in trunk/Source/WebCore
HTMLTextFormControlElement::subtreeHasChanged should be called before updating selection
https://bugs.webkit.org/show_bug.cgi?id=128870
Reviewed by Darin Adler.
Extracted HTMLTextFormControlElement::didEditInnerTextValue out of HTMLTextFormControlElement::defaultEventHandler
and called it in appliedEditing, unappliedEditing, and reappliedEditing before updating selection.
- editing/Editor.cpp:
(WebCore::notifyTextFromControls): Added.
(WebCore::Editor::appliedEditing): Update text form control's internal states before updating selection.
(WebCore::Editor::unappliedEditing): Ditto.
(WebCore::Editor::reappliedEditing): Ditto.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::subtreeHasChanged): Removed a stale assertion from the time we used to do
everything in the render tree.
- 4:26 PM Changeset in webkit [164182] by
-
- 21 edits in trunk/Source/WebCore
Add checked casts for ScriptExecutionContext.
<https://webkit.org/b/128874>
Generate casting helpers for casting from ScriptExecutionContext to
Document and WorkerGlobalScope. Apply heartily.
Reviewed by Antti Koivisto.
- 3:26 PM Changeset in webkit [164181] by
-
- 11 edits in trunk/Source
[Mac] All WebKit clients should encrypt WebCrypto keys automatically
https://bugs.webkit.org/show_bug.cgi?id=128852
Reviewed by Oliver Hunt.
Source/WebCore:
Install a persistent master key in Keychain on first use of WebCrypto key serialization.
The key is per application, protected with ACL.
- English.lproj/Localizable.strings:
- WebCore.exp.in:
- crypto/SerializedCryptoKeyWrap.h:
- crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::masterKeyAccountNameForCurrentApplication):
(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::createAndStoreMasterKey):
(WebCore::findMasterKey):
- platform/LocalizedStrings.cpp:
(WebCore::webCryptoMasterKeyKeychainLabel):
(WebCore::webCryptoMasterKeyKeychainComment):
- platform/LocalizedStrings.h:
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::wrapCryptoKey):
(WebChromeClient::unwrapCryptoKey):
Call the default implementation if key is not provided by a client.
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):
Call the default implementation if key is not provided by a client.
- 2:32 PM Changeset in webkit [164180] by
-
- 3 edits in trunk/Source/WebCore
computeSelectionStart and computeSelectionEnd shouldn't trigger synchronous layout
https://bugs.webkit.org/show_bug.cgi?id=128806
Reviewed by Darin Adler.
Added indexForPosition to HTMLTextFormControlElement. Like r163825, this patch traverses the DOM tree
instead of the render tree to compute the index for a given position.
We traverse the DOM Tree backwards starting at the specified Position all the way back to the beginning
of the inner text element. The index is computed as the number of characters we encountered during
this backwards DOM traversal.
It's worth noting that passedPosition.computeNodeBeforePosition() returns and only returns 0 when the
position is before the first node of its parent or inside a text node. In such cases, we call
passedPosition.containerNode() to find the parent or the text node.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition): Use indexForPosition.
(WebCore::HTMLTextFormControlElement::computeSelectionStart): Ditto.
(WebCore::HTMLTextFormControlElement::computeSelectionEnd): Dotto.
(WebCore::finishText): Cleanup. Use newlineCharacter instead of hard-coding '\n'.
(WebCore::HTMLTextFormControlElement::indexForPosition): Added. See above for the description.
- html/HTMLTextFormControlElement.h:
- 1:15 PM Changeset in webkit [164179] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Stop calling mktemp(3).
https://bugs.webkit.org/show_bug.cgi?id=128826
Reviewed by Gyuyoung Kim.
mktemp(3) is an insecure function and should be avoided at all costs.
Replace its usage with mkdtemp(3): instead of just getting a file name
that is supposed to be random and unused, we now create a directory
with a random name and then put whatever files we need there with fixed
names.
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
(TEST_F):
- 11:45 AM Changeset in webkit [164178] by
-
- 4 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, roll out r164166.
This broke three unique tests:
The following JSC stress test failures have been introduced:
regress/script-tests/variadic-closure-call.js.default-ftl
regress/script-tests/variadic-closure-call.js.ftl-no-cjit-validate
regress/script-tests/variadic-closure-call.js.ftl-no-cjit-osr-validation
regress/script-tests/variadic-closure-call.js.ftl-eager
regress/script-tests/variadic-closure-call.js.ftl-eager-no-cjit
regress/script-tests/variadic-closure-call.js.ftl-eager-no-cjit-osr-validation
jsc-layout-tests.yaml/js/script-tests/unmatching-argument-count.js.layout-ftl-eager-no-cjit
regress/script-tests/direct-arguments-getbyval.js.ftl-eager-no-cjit
regress/script-tests/direct-arguments-getbyval.js.ftl-eager-no-cjit-osr-validation
- bytecode/PolymorphicAccessStructureList.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
- tests/stress/ftl-getbyval-arguments.js:
- 11:25 AM Changeset in webkit [164177] by
-
- 2 edits in trunk/Source/WebCore
[Win] Avoid unnecessary asserts if "prepareToPlay" is called multiple times.
https://bugs.webkit.org/show_bug.cgi?id=128859
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createPlayer): Don't assert if player exists; just return the
existing copy.
(WebCore::AVFWrapper::createPlayerItem): Ditto (but with Player Items).
- 10:16 AM Changeset in webkit [164176] by
-
- 4 edits in trunk/Source/WebCore
Remove double hashing from DatasetDOMStringMap::deleteItem
https://bugs.webkit.org/show_bug.cgi?id=128865
Reviewed by Benjamin Poulain.
- dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::deleteItem): Removed call to hasAttribute, using the
result from removeAttribute instead.
- dom/Element.cpp:
(WebCore::Element::removeAttribute): Add a return value, false if nothing is removed,
and true if something is removed.
(WebCore::Element::removeAttributeNS): Ditto.
- dom/Element.h: Ditto.
- 10:15 AM Changeset in webkit [164175] by
-
- 2 edits in trunk/Source/WTF
Remove 'static' specifier from free inline functions in StringImpl.h
https://bugs.webkit.org/show_bug.cgi?id=118554
Reviewed by Darin Adler.
At first 'static' does not bring any use here, secondly static free
inline functions in headers is a bad practice in general as each instance
of function defined as inline is treated as a separate function and each
instance has its own copy of static locals and string literals.
- wtf/text/StringImpl.h:
(WTF::codePointCompare):
(WTF::codePointCompare8):
(WTF::codePointCompare16):
(WTF::codePointCompare8To16):
(WTF::isSpaceOrNewline):
- 10:00 AM Changeset in webkit [164174] by
-
- 5 edits2 adds in trunk
Setting currentTime on HTMLMediaElement with media controller should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=128867.
Patch by Piotr Grad <p.grad@samsung.com> on 2014-02-15
Reviewed by Eric Carlson.
Source/WebCore:
Added implementation for setting currentTime in HTMLMediaElement. Old implementation
was left to be used internally.
Test: media/video-controller-currentTime.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
LayoutTests:
- media/video-controller-currentTime-expected.txt: Added.
- media/video-controller-currentTime.html: Added.
- 9:51 AM Changeset in webkit [164173] by
-
- 4 edits in trunk/Source/WebCore
Form controls are always painted in the active state
https://bugs.webkit.org/show_bug.cgi?id=128872
<rdar://problem/9422677>
Reviewed by Dan Bernstein.
AppKit will always paint form controls in the active state if the view doesn't have a
window. Fix this by adding a fake window whose key appearance we'll update based on the
control state. Also, rename WebCoreFlippedView to WebCoreThemeView since it stopped being
just about the flippedness a long time ago.
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(-[WebCoreThemeWindow hasKeyAppearance]):
Return themeWindowHasKeyAppearance.
(-[WebCoreThemeView window]):
Create a WebCoreThemeWindow object lazily and return it.
(WebCore::paintCheckbox):
(WebCore::paintRadio):
(WebCore::paintButton):
Pass the control states to ThemeMac::ensuredView.
(WebCore::ThemeMac::ensuredView):
Set themeWindowHasKeyAppearance based on the control state.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::documentViewFor):
Pass the control states to ThemeMac::ensuredView.
- 9:06 AM Changeset in webkit [164172] by
-
- 34 edits1 delete in trunk/Source/WebKit2
Stop using PLATFORM(MAC) in WebKit2/UIProcess except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128868
Reviewed by Anders Carlsoon.
- UIProcess/API/C/WKPage.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection): Changed
PLATFORM(MAC) to OS(DARWIN) around use of Mach-based IPC.
- UIProcess/DrawingAreaProxy.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA)
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
- UIProcess/DrawingAreaProxy.h: Ditto.
- UIProcess/DrawingAreaProxy.messages.in: Ditto.
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::didFinishLaunchingProcess): Changed PLATFORM(MAC) to OS(DARWIN)
around use of Mach API.
- UIProcess/Launcher/ProcessLauncher.h: Ditto.
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h: Changed PLATFORM(MAC) to
PLATFORM(COCOA)
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch): Changed PLATFORM(MAC)
to OS(DARWIN).
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess): Ditto.
(WebKit::NetworkProcessProxy::didFinishLaunching): Changed PLATFORM(MAC) to PLATFORM(COCOA)
around process suppression call.
- UIProcess/Network/NetworkProcessProxy.h: Ditto.
- UIProcess/PageClient.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- UIProcess/Plugins/PluginInfoStore.cpp: Ditto.
- UIProcess/Plugins/PluginProcessManager.h: Ditto.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy): Ditto.
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch): Changed PLATFORM(MAC)
to OS(DARWIN).
(WebKit::PluginProcessProxy::didClose): Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::PluginProcessProxy::didFinishLaunching): Changed PLATFORM(MAC) to OS(DARWIN) around
use of Mach-based IPC, and to PLATFORM(COCOA) around SetQOS.
(WebKit::PluginProcessProxy::didCreateWebProcessConnection): Changed PLATFORM(MAC) to
OS(DARWIN).
- UIProcess/Plugins/PluginProcessProxy.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- UIProcess/Plugins/PluginProcessProxy.messages.in: Ditto.
- UIProcess/TextChecker.h: Ditto.
- UIProcess/WebContext.cpp: Ditto.
(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::setHTTPPipeliningEnabled):
(WebKit::WebContext::httpPipeliningEnabled):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebContext.h: Ditto.
- UIProcess/WebContext.messages.in: Ditto.
- UIProcess/WebContextUserMessageCoders.h: Ditto.
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebCookieManagerProxy.cpp: Ditto.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
- UIProcess/WebCookieManagerProxy.h: Ditto.
- UIProcess/WebFormSubmissionListenerProxy.h: Ditto.
- UIProcess/WebFramePolicyListenerProxy.h: Ditto.
- UIProcess/WebInspectorProxy.h: Added !PLATFORM(IOS) around members reltated to managing
the inspector window and its view.
- UIProcess/WebPageProxy.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::recordNavigationSnapshot):
(WebKit::WebPageProxy::canShowMIMEType):
(WebKit::canCoalesce):
(WebKit::coalesce):
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- UIProcess/WebPageProxy.h: Ditto.
- UIProcess/WebPageProxy.messages.in: Ditto.
- UIProcess/WebProcessProxy.cpp: Ditto.
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::createWebPage):
(WebKit::WebProcessProxy::addExistingWebPage):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::pageSuppressibilityChanged):
(WebKit::WebProcessProxy::pagePreferencesChanged):
- UIProcess/WebProcessProxy.h: Ditto.
- UIProcess/cf/WebPreferencesCF.cpp: Removed this file which was not used in any
configuration.
- UIProcess/ios/WebInspectorProxyIOS.mm: Removed functions that no longer need to be
implemented for iOS.
- WebKit2.xcodeproj/project.pbxproj: Removed reference to WebPreferencesCF.cpp.
- 1:28 AM Changeset in webkit [164171] by
-
- 9 edits in trunk/Source/WebKit2
messages.py doesn't handle parameters with more than one level of scope.
https://bugs.webkit.org/show_bug.cgi?id=128573
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-02-15
Reviewed by Simon Fraser.
Support .messages.in header include generation for parameter types with more than 1 level of scope.
Add a test case and update expected results.
- Scripts/webkit2/LegacyMessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveWebPageMessage):
- Scripts/webkit2/LegacyMessages-expected.h:
(Messages::WebPage::SetVideoLayerID::receiverName):
(Messages::WebPage::SetVideoLayerID::name):
(Messages::WebPage::SetVideoLayerID::SetVideoLayerID):
(Messages::WebPage::SetVideoLayerID::arguments):
- Scripts/webkit2/MessageReceiver-expected.cpp:
(WebKit::WebPage::didReceiveMessage):
- Scripts/webkit2/Messages-expected.h:
(Messages::WebPage::SetVideoLayerID::receiverName):
(Messages::WebPage::SetVideoLayerID::name):
(Messages::WebPage::SetVideoLayerID::SetVideoLayerID):
(Messages::WebPage::SetVideoLayerID::arguments):
- Scripts/webkit2/messages.py:
(headers_for_type):
- Scripts/webkit2/messages_unittest.py:
- Scripts/webkit2/test-legacy-messages.in:
- Scripts/webkit2/test-messages.in:
- 12:57 AM Changeset in webkit [164170] by
-
- 3 edits2 adds in trunk
ASSERT_WITH_SECURITY_IMPLICATION in WebCore::toElement
https://bugs.webkit.org/show_bug.cgi?id=128810
Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-02-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make CompositeEditCommand::cloneParagraphUnderNewElement() to work when |outerNode|
doesn't contain |start|.
Before this patch, CompositeEditCommand::cloneParagraphUnderNewElement() tried to copy
ancestry nodes from |start| to Document node when |start| position isn't in |outerNode|. This
patch changes CompositeEditCommand::cloneParagraphUnderNewElement() to copy |start| to
|outerNode| only if |outerNode| contains |start| position.
Merged from Blink https://src.chromium.org/viewvc/blink?revision=161762&view=revision by yosin@chromium.org.
Test: editing/execCommand/indent-with-uneditable-crash.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
LayoutTests:
- editing/execCommand/indent-with-uneditable-crash-expected.txt: Added.
- editing/execCommand/indent-with-uneditable-crash.html: Added.
- 12:39 AM Changeset in webkit [164169] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r164167 - [GTK] Fix marshaller used in WebKitWebPage::document-loaded signal
https://bugs.webkit.org/show_bug.cgi?id=128808
Reviewed by Sergio Villar Senin.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init): Use g_cclosure_marshal_VOIDVOID
instead of g_cclosure_marshal_VOIDOBJECT.
- 12:39 AM Changeset in webkit [164168] by
-
- 13 edits in trunk
[EFL][WK1] Do not include cairo header in the public headers
https://bugs.webkit.org/show_bug.cgi?id=128779
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Although ewebkit used cairo internally, it's not good for EFL developers
to use it.
Indeed, almost APIs which returns cairo_surface are duplicated with other APIs
which returns evas_object.
- ewk/ewk_history.cpp:
Removed ewk_history_item_icon_surface_get.
ewk_history_item_icon_object_add will be used instead.
- ewk/ewk_history.h:
- ewk/ewk_settings.cpp:
Removed ewk_settings_icon_database_icon_surface_get.
ewk_settings_icon_database_icon_object_get will be used instead.
- ewk/ewk_settings.h:
- ewk/ewk_view.cpp:
(ewk_view_screenshot_contents_get):
Implemented to replace ewk_view_paint and ewk_view_paint_contents.
- ewk/ewk_view.h:
- tests/test_ewk_view.cpp:
(TEST_F): Added test case for ewk_view_screenshot_contents_get
Tools:
- DumpRenderTree/PlatformEfl.cmake:
- DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
(createBitmapContextFromWebView):
Used ewk_view_screenshot_contents_get instead of ewk_view_paint.
- EWebLauncher/main.c:
(print_history): Replaced ewk_history_item_icon_surface_get to ewk_history_item_icon_object_add
(on_key_down):
- Scripts/webkitpy/style/checker.py:
Added -runtime/ctype_function for EWebLauncher because EWebLauncher is sample
and it does not use WTF.
- 12:36 AM Changeset in webkit [164167] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix marshaller used in WebKitWebPage::document-loaded signal
https://bugs.webkit.org/show_bug.cgi?id=128808
Reviewed by Sergio Villar Senin.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init): Use g_cclosure_marshal_VOIDVOID
instead of g_cclosure_marshal_VOIDOBJECT.
- 12:34 AM Changeset in webkit [164166] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Added GetMyArgumentByVal to FTL
https://bugs.webkit.org/show_bug.cgi?id=128850
Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-15
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentByVal):
- tests/stress/ftl-getbyval-arguments.js: Added.
(foo):
- 12:33 AM Changeset in webkit [164165] by
-
- 18 edits2 adds in trunk
AX: Add ability to specify descendant type when using AXUIElementsForSearchPredicate.
https://bugs.webkit.org/show_bug.cgi?id=128747
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for 'immediate descendant only' to existing predicate based searching. This
addition allows VoiceOver to fetch each child element lazily (rather than all at once via AXChildren).
Test: platform/mac/accessibility/search-predicate-immediate-descendants-only.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::findMatchingObjects):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute):
Tools:
Updated uiElementCountForSearchPredicate and uiElementForSearchPredicate test methods to support 'immediate descendant only' searching.
- DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementCountForSearchPredicateCallback):
(uiElementForSearchPredicateCallback):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::uiElementCountForSearchPredicate):
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::uiElementCountForSearchPredicate):
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(searchPredicateParameterizedAttributeForSearchCriteria):
(AccessibilityUIElement::uiElementCountForSearchPredicate):
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::uiElementCountForSearchPredicate):
(AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::searchPredicateParameterizedAttributeForSearchCriteria):
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests:
Added test to verify that 'immediate descendant only' predicate based searching works as expected.
- platform/mac/accessibility/search-predicate-immediate-descendants-only-expected.txt: Added.
- platform/mac/accessibility/search-predicate-immediate-descendants-only.html: Added.
- 12:30 AM Changeset in webkit [164164] by
-
- 18 edits in trunk/Source/JavaScriptCore
[Win] LLINT is not working.
https://bugs.webkit.org/show_bug.cgi?id=128115
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-02-15
Reviewed by Mark Lam.
This patch will generate assembly code with Intel syntax, which can be processed by the Microsoft assembler (MASM).
By creating an asm file instead of a header file with inline assembly, we can support 64-bit.
Only 32-bit compilation has been tested, not 64-bit.
The aim of this patch is to get LLINT up and running on Windows.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Added new files, and generated asm file.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- LLIntAssembly/build-LLIntAssembly.sh: Generate dummy asm file in case we're using C backend.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor): Compile fix when DFG is disabled.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor): Ditto.
- bytecode/GetByIdStatus.h: Ditto.
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor): Ditto.
- bytecode/PutByIdStatus.h: Ditto.
- llint/LLIntData.cpp:
(JSC::LLInt::initialize): Compile fix.
- llint/LLIntSlowPaths.h: Added llint_crash function.
- llint/LLIntSlowPaths.cpp: Ditto.
- llint/LowLevelInterpreter.cpp: Disable code for Windows.
- llint/LowLevelInterpreter.asm: Remove instruction which generates incorrect assembly code on Windows (MOV 0xbbadbeef, register), call llint_crash instead.
Make local labels visible to MASM on Windows.
- llint/LowLevelInterpreter32_64.asm: Make local labels visible to MASM on Windows.
- offlineasm/asm.rb: Generate asm file with Intel assembly syntax.
- offlineasm/settings.rb: Ditto.
- offlineasm/x86.rb: Ditto.
- 12:28 AM Changeset in webkit [164163] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: scope chain details sidebar doesn't update values modified via console
https://bugs.webkit.org/show_bug.cgi?id=126855
Patch by Chris J. Shull <chrisjshull@gmail.com> on 2014-02-15
Reviewed by Timothy Hatcher.
Add a RuntimeManager event that the scope chain details sidebar can
listen to to trigger refresh.
Testing on this is blocked by http://webkit.org/b/128724
(Web Inspector: Issue testing breakpoints).
- UserInterface/RuntimeManager.js:
(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
- UserInterface/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel):
- 12:27 AM Changeset in webkit [164162] by
-
- 1 edit1 add in trunk/PerformanceTests
[CSS Shapes] Add performance test for raster shape with shape-margin
https://bugs.webkit.org/show_bug.cgi?id=128770
Reviewed by Ryosuke Niwa.
This patch introduces a new performance test for image valued shapes,
where shape-margin is applied on the shape.
The test is skipped by default.
- Layout/Shapes/ShapeOutsideRasterWithMargin.html: Added.
- 12:25 AM Changeset in webkit [164161] by
-
- 3 edits in trunk/Source/WebCore
WK2 AVKit enter fullscreen doesn't work a second time.
https://bugs.webkit.org/show_bug.cgi?id=128558
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-02-15
Reviewed by Jer Noble.
Lazily create WebAVPlayerController when needed.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit):
(WebVideoFullscreenInterfaceAVKit::getPlayerController):
Add getPlayerController()
(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel):
(WebVideoFullscreenInterfaceAVKit::setDuration):
(WebVideoFullscreenInterfaceAVKit::setCurrentTime):
(WebVideoFullscreenInterfaceAVKit::setRate):
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions):
(WebVideoFullscreenInterfaceAVKit::setVideoLayer):
(WebVideoFullscreenInterfaceAVKit::enterFullscreenWithCompletionHandler):
use getPlayerController();
- 12:23 AM Changeset in webkit [164160] by
-
- 4 edits in trunk/Source/WebCore
[Mac] 10X slower than Chrome when drawing a video into a canvas
https://bugs.webkit.org/show_bug.cgi?id=124599
Reviewed by Darin Adler.
Follow up patch to r159518 to address Darin's post-commit review.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::nativeImageForCurrentTime): Use nullptr.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::nativeImageForCurrentTime): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Clear the
AVPlayerItemVideoOutput's delegate callback.
(WebCore::CVPixelBufferGetBytePointerCallback): Use static_cast.
(WebCore::CVPixelBufferReleaseBytePointerCallback): Ditto.
(WebCore::CVPixelBufferReleaseInfoCallback): Ditto.
(-[WebCoreAVFPullDelegate initWithCallback:]): Space changes.
(-[WebCoreAVFPullDelegate setCallback:]): Added.
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]): Check the value of m_callback.
- 12:18 AM Changeset in webkit [164159] by
-
- 3 edits in trunk/Tools
CQ fix after r164105.
- DumpRenderTree/mac/EventSendingController.mm:
- WebKitTestRunner/mac/EventSenderProxy.mm:
Feb 14, 2014:
- 11:41 PM Changeset in webkit [164158] by
-
- 22 edits in trunk/Source/WebCore
CTTE: WorkerGlobalScope is always owned by a WorkerThread.
<https://webkit.org/b/128834>
Codify this by storing the owner thread as a WorkerThread& and making
thread() return a reference.
This exposed a couple of unnecessary assertions.
Reviewed by Anders Carlsson.
- Modules/notifications/WorkerGlobalScopeNotifications.cpp:
(WebCore::WorkerGlobalScopeNotifications::webkitNotifications):
- Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::pauseWorkerGlobalScope):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::loadResourceSynchronously):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeRequestFromCache):
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::postMessage):
(WebCore::DedicatedWorkerGlobalScope::importScripts):
(WebCore::DedicatedWorkerGlobalScope::thread):
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
- workers/SharedWorkerGlobalScope.cpp:
(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::thread):
- workers/SharedWorkerGlobalScope.h:
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::createWorkerGlobalScope):
- workers/WorkerGlobalScope.cpp:
(WebCore::CloseWorkerGlobalScopeTask::performTask):
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::logExceptionToConsole):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
(WebCore::WorkerGlobalScope::isContextThread):
- workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::thread):
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
- 9:45 PM Changeset in webkit [164157] by
-
- 3 edits in trunk/PerformanceTests
Improve the appearance of DYEBench
https://bugs.webkit.org/show_bug.cgi?id=128866
Reviewed by Antti Koivisto.
Add a div that shows progress during the test. Also show 95th percentile,
and use a table instead of pre to show results.
- DoYouEvenBench/Full.html:
(.addResult): Added. Shows results in a table.
(benchmarkClient.willRunTest): Added to show the progress bar.
(benchmarkClient.didRunTest):
(benchmarkClient.didRunSuites):
(benchmarkClient.didFinishLastIteration): Compute 95th percentile using Statistics.js
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._appendFrame): Fix the bug where marginLeft and marginTop
weren't correctly parsed. We were treating top as left and bottom as top somehow.
(BenchmarkRunner.prototype._runTestAndRecordResults): Fixed a typo.
- 8:52 PM Changeset in webkit [164156] by
-
- 3 edits in trunk/Source/WebCore
setSelectionRange shouldn't trigger a synchronous layout to check focusability when text field is already focused
https://bugs.webkit.org/show_bug.cgi?id=128804
Reviewed by Enrica Casucci.
Don't trigger a synchronous layout at the beginning of setSelectionRange if the element is already focused
since we don't have to check the size of render box in that case.
We should be able to get rid of this synchronous layout entirely once we fix https://webkit.org/b/128797
but that's somewhat risky behavioral change so we'll do that in a separate patch.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll): Fixed the bug where selectAll selects the entire document even if the text
form contol is focused if the selection is none (i.e. not anchored to any node).
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange): Only update the layout if the element is not focused
already. Also pass in DoNotSetFocus option to setSelection since we already have the focus in that case.
- 8:33 PM Changeset in webkit [164155] by
-
- 1 edit2 copies in trunk/LayoutTests
Add back pre-r164154 results to platform/mac-mountainlion.
- platform/mac-mountainlion/fast/forms/search-styled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-styled-expected.png.
- platform/mac-mountainlion/fast/forms/search-styled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-styled-expected.txt.
- 8:28 PM Changeset in webkit [164154] by
-
- 3 edits in trunk/LayoutTests
Mac rebaseline after r164145.
- platform/mac/fast/forms/search-styled-expected.png:
- platform/mac/fast/forms/search-styled-expected.txt:
- 7:56 PM Changeset in webkit [164153] by
-
- 7 edits in trunk/LayoutTests
Windows rebaselines after dependency updates.
- platform/win/fast/css/first-letter-block-form-controls-crash-expected.txt:
- platform/win/fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
- platform/win/fast/forms/access-key-for-all-elements-expected.txt:
- platform/win/fast/forms/form-associated-element-crash3-expected.txt:
- platform/win/fast/forms/search-styled-expected.txt:
- platform/win/fast/multicol/renderer-positioned-assert-crash-expected.txt:
- 7:45 PM Changeset in webkit [164152] by
-
- 2 edits in trunk/Source/WebKit/mac
Control tints don't update inside WebViews
https://bugs.webkit.org/show_bug.cgi?id=128862
Reviewed by Ryosuke Niwa.
- WebView/WebView.mm:
(-[WebView _windowChangedKeyState]):
Call [super _windowChangedKeyState].
- 7:06 PM Changeset in webkit [164151] by
-
- 9 edits in trunk/Source/JavaScriptCore
Web Inspector: CRASH when debugger closes while paused and remote inspecting a JSContext
https://bugs.webkit.org/show_bug.cgi?id=127757
Reviewed by Timothy Hatcher.
The problem was that the lifetime of the InspectorController and all agents
was tied to the remote inspector session. So, if a remote inspector was
disconnected while in the nested run loop, everything would get torn
down and when execution continued out of the nested runloop we would be
back in the original call stack of destroyed objects.
This patch changes the lifetime of the InspectorController and agents to
the JSGlobalObject. This way the agents are always alive, just the
frontend and backend channels are destroyed and recreated each remote
inspector session. This matches the agent lifetime for WebCore agents.
We can also later take advantage of the agents being alive before
and between inspector debug sessions to stash exception messages to
pass on to a debugger if a debugger is connected later.
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Cleaner initialization of agents. Easier to follow.
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Move InjectedScript disconnection only once the global object is destroyed.
This way if a developer has attached once and included an injected script,
we will keep it around with any state it might want to remember until
the global object is destroyed.
(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
Disconnect agents and injected scripts when the global object is destroyed.
- inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::disconnect):
Now that the injected script manager is reused between remote
inspector sessions, don't clear the pointer on disconnect calls.
We now only call this once when the global object is getting
destroyed anyways so it doesn't matter. But if we wanted to call
disconnect multiple times, e.g. once per session, we could.
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):
If the only listener was removed during the nested runloop, then when
we dispatch an event after the nested runloop the listener list will
be empty. Instead of asserting, just pass by an empty list.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::inspectorController):
Tie the inspector controller lifetime to the JSGlobalObject.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::init):
Create the inspector controller, and eagerly signal teardown
in destruction.
- runtime/JSGlobalObjectDebuggable.h:
- runtime/JSGlobalObjectDebuggable.cpp:
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
Simplify by using the inspector controller on JSGlobalObject.
- 6:52 PM Changeset in webkit [164150] by
-
- 2 edits in trunk/Tools
Another build fix after r164149.
- Scripts/webkitpy/port/port_testcase.py:
(test_apache_config_file_name_for_platform):
- 6:50 PM Changeset in webkit [164149] by
-
- 3 edits1 move in trunk
Build fix after r164148.
Tools:
- Scripts/webkitpy/port/base.py:
(Port._apache_config_file_name_for_platform):
LayoutTests:
- http/conf/apache2-httpd.conf: Removed.
- http/conf/apache2.2-httpd.conf: Copied from LayoutTests/http/conf/apache2-httpd.conf.
- 6:33 PM Changeset in webkit [164148] by
-
- 3 edits1 add in trunk
run-webkit-tests doesn't work with Apache 2.4
https://bugs.webkit.org/show_bug.cgi?id=128861
Reviewed by Andreas Kling.
Tools:
Use apache<version>-httpd.conf like we do on Fedora and Debian.
- Scripts/webkitpy/port/base.py:
(Port._apache_config_file_name_for_platform):
LayoutTests:
- http/conf/apache2.4-httpd.conf: Added.
- 5:27 PM Changeset in webkit [164147] by
-
- 5 edits in trunk/Source/JavaScriptCore
-[JSManagedValue value] needs to be protected by the API lock
https://bugs.webkit.org/show_bug.cgi?id=128857
Reviewed by Mark Lam.
- API/APICast.h:
(toRef): Added an ASSERT so that we can detect these sorts of errors earlier. On 32-bit, toRef
can allocate objects so we need to be holding the lock.
- API/APIShims.h: Removed outdated comments.
- API/JSManagedValue.mm: Added RefPtr<JSLock> to JSManagedValue.
(-[JSManagedValue initWithValue:]): Initialize the m_lock field.
(-[JSManagedValue value]): Lock the JSLock, check the VM*, return nil if invalid, take the APIEntryShim otherwise.
- runtime/JSLock.cpp: Bug fix in JSLock. We were assuming that the VM was always non-null in JSLock::lock.
(JSC::JSLock::lock):
- 5:06 PM Changeset in webkit [164146] by
-
- 4 edits in trunk/Source/WebKit2
Add SPI for monitoring web process crashes
https://bugs.webkit.org/show_bug.cgi?id=128851
Reviewed by Beth Dakin.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::processDidCrash):
- 4:59 PM Changeset in webkit [164145] by
-
- 4 edits3 deletes in trunk
REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
https://bugs.webkit.org/show_bug.cgi?id=126295
Reviewed by Ryosuke Niwa.
Source/WebCore:
Reverted r157443 and improved comment.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
LayoutTests:
Reverted r157443.
- fast/forms/search/search-field-background-color-expected.txt: Removed.
- fast/forms/search/search-field-background-color.html: Removed.
- platform/efl/fast/forms/search: Removed.
- platform/efl/fast/forms/search/search-field-background-color-expected.png: Removed.
- platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Removed.
- platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
- platform/mac/fast/forms/search-styled-expected.txt:
- 4:54 PM Changeset in webkit [164144] by
-
- 5 edits2 adds in trunk/Source
Web Replay: AtomicString replay input names should be stored in a thread-local table
https://bugs.webkit.org/show_bug.cgi?id=128829
Reviewed by Andreas Kling.
Similar to how DOM event names are frequently-used AtomicStrings, replay input
names are also checked in many places as a "type tag". This patch puts all known
input names into a class held by ThreadGlobalData and adds the shortcutinputTypes()
so that replay input types can be referenced withinputTypes.InputName().
- WebCore.xcodeproj/project.pbxproj:
- platform/ThreadGlobalData.cpp: Add inputTypes() shortcut.
(WebCore::ThreadGlobalData::ThreadGlobalData):
- platform/ThreadGlobalData.h: Add inputTypes() shortcut.
(WebCore::ThreadGlobalData::inputTypes):
- replay/ReplayInputTypes.cpp: Added.
(WebCore::ReplayInputTypes::ReplayInputTypes):
- replay/ReplayInputTypes.h: Added.
(WebCore::inputTypes): The input names are provided by per-framework macros that
are generated by the replay inputs code generator.
- 4:51 PM Changeset in webkit [164143] by
-
- 2 edits in trunk/LayoutTests
[Win] Activate CSS Region Tests on Windows
https://bugs.webkit.org/show_bug.cgi?id=128854
Reviewed by Simon Fraser.
- platform/win/TestExpectations: Activate CSS Region tests, turning off a
few failures.
- 4:48 PM Changeset in webkit [164142] by
-
- 4 edits2 adds in trunk
Add support for specced event handlers to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=128292
Reviewed by Andreas Kling.
Source/WebCore:
Test: media/media-event-listeners.html
Add explicit event listener IDL attributes to HTMLMediaElement.
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
LayoutTests:
- media/media-event-listeners-expected.txt: Added.
- media/media-event-listeners.html: Added.
- 4:04 PM Changeset in webkit [164141] by
-
- 9 edits in trunk
[Win] Make tests more consistent with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=128848
Reviewed by Simon Fraser.
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl: Add access to the
mock scrollbar and screen font substitution features.
- WebPreferenceKeysPrivate.h: Ditto
- WebPreferences.cpp: Ditto
(WebPreferences::mockScrollbarsEnabled):
(WebPreferences::setMockScrollbarsEnabled):
(WebPreferences::screenFontSubstitutionEnabled):
(WebPreferences::setScreenFontSubstitutionEnabled):
- WebPreferences.h: Ditto
- WebView.cpp:
(WebView::notifyPreferencesChanged): Ditto
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Turn CSS regions on,
turn mock scrollbars on, and allow screen font
substitution.
- 4:01 PM Changeset in webkit [164140] by
-
- 7 edits in trunk/LayoutTests
Mac rebaseline after r164127.
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/controls-styling-strict-expected.txt:
- platform/mac/media/controls-without-preload-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- 3:29 PM Changeset in webkit [164139] by
-
- 23 edits12 adds in trunk
Implement a few more Array prototype functions in JS
https://bugs.webkit.org/show_bug.cgi?id=128788
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Remove a pile of awful C++, and rewrite in simple JS.
Needed to make a few other changes to get fully builtins
behavior to more accurately match a host function's.
- builtins/Array.prototype.js:
(every):
(forEach):
(filter):
(map):
(some):
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::BuiltinExecutables):
(JSC::BuiltinExecutables::createBuiltinExecutable):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitPutByVal):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- interpreter/Interpreter.cpp:
(JSC::GetStackTraceFunctor::operator()):
- parser/Nodes.h:
(JSC::FunctionBodyNode::overrideName):
- profiler/LegacyProfiler.cpp:
(JSC::createCallIdentifierFromFunctionImp):
- runtime/ArrayPrototype.cpp:
- runtime/JSFunction.cpp:
(JSC::JSFunction::deleteProperty):
- runtime/JSFunction.h:
Source/WebCore:
Minor change to ensure that the inspector is treating builtins
as host functions.
Tests: js/regress/array-prototype-filter.html
js/regress/array-prototype-forEach.html
js/regress/array-prototype-map.html
js/regress/array-prototype-some.html
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Make sure we treat builtins as regular host functions
LayoutTests:
Add performance tests, and update a couple of profiler tests as
we unavoidably show the call out to some of the builtin methods.
- fast/profiler/built-in-function-calls-anonymous-expected.txt:
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
- js/dom/array-foreach-expected.txt:
- js/dom/array-prototype-properties-expected.txt:
- js/dom/array-some-expected.txt:
- js/regress/array-prototype-filter-expected.txt: Added.
- js/regress/array-prototype-filter.html: Added.
- js/regress/array-prototype-forEach-expected.txt: Added.
- js/regress/array-prototype-forEach.html: Added.
- js/regress/array-prototype-map-expected.txt: Added.
- js/regress/array-prototype-map.html: Added.
- js/regress/array-prototype-some-expected.txt: Added.
- js/regress/array-prototype-some.html: Added.
- js/regress/script-tests/array-prototype-filter.js: Added.
(test1):
(test2):
(test3):
- js/regress/script-tests/array-prototype-forEach.js: Added.
(test1):
(test2):
(test3):
- js/regress/script-tests/array-prototype-map.js: Added.
(test1):
(test2):
(test3):
- js/regress/script-tests/array-prototype-some.js: Added.
(test1):
(test2):
(test3):
- 3:15 PM Changeset in webkit [164138] by
-
- 5 edits in trunk/Source/WebKit2
Add SPI for authentication
https://bugs.webkit.org/show_bug.cgi?id=128847
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame):
- 3:09 PM Changeset in webkit [164137] by
-
- 2 edits in trunk/Tools
Save ARGV in a local to avoid repeated lookups
Rubber stamped by Joseph Pecoraro.
- jsc-cli/jsc-cli/CLIInstance.m:
(-[CLIInstance didReceiveArguments:atOffset:withLength:]):
- 2:44 PM Changeset in webkit [164136] by
-
- 4 edits in trunk/Source/JavaScriptCore
ASSERT(isValidAllocation(bytes)) when ObjC API creates custom errors
https://bugs.webkit.org/show_bug.cgi?id=128840
Reviewed by Joseph Pecoraro.
We need to add APIEntryShims around places where we allocate errors in JSC.
Also converted some of the createTypeError call sites to use ASCIILiteral.
- API/JSValue.mm:
(valueToArray):
(valueToDictionary):
- API/ObjCCallbackFunction.mm:
(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunctionImpl::call):
- API/tests/testapi.mm:
- 2:30 PM Changeset in webkit [164135] by
-
- 2 edits in trunk/Source/WebCore
Margin tiles are not created for the top and left sides when there is a < 1.0
scale factor
https://bugs.webkit.org/show_bug.cgi?id=128842
Reviewed by Simon Fraser.
floor the result of the computation whenever we have a negative origin, to ensure
that we are rounding 'up' to a larger number of tiles.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::getTileIndexRangeForRect):
- 2:28 PM Changeset in webkit [164134] by
-
- 7 edits in trunk/Tools
jsc-cli should allow scripts to access argv
https://bugs.webkit.org/show_bug.cgi?id=127486
Reviewed by Oliver Hunt.
- jsc-cli/jsc-cli.xcodeproj/project.pbxproj:
- jsc-cli/jsc-cli/CLIInstance.h:
- jsc-cli/jsc-cli/CLIInstance.m:
(-[CLIInstance init]):
(-[CLIInstance loadFile:]):
(-[CLIInstance didReceiveArguments:atOffset:withLength:]):
- jsc-cli/jsc-cli/JSRunLoopThread.h:
- jsc-cli/jsc-cli/JSRunLoopThread.m:
(-[JSRunLoopThread initWithContext:]):
(-[JSRunLoopThread loadFile:]):
(-[JSRunLoopThread start]):
- jsc-cli/jsc-cli/main.m:
(printUsage):
(main):
- 2:27 PM Changeset in webkit [164133] by
-
- 4 edits in trunk/Source/WebCore
setSelection should not synchronously trigger layout
https://bugs.webkit.org/show_bug.cgi?id=128797
Reviewed by Antti Koivisto.
Only update the appearance and reveal selection when the style and the layout is already up to date.
Otherwise, do so in performPostLayoutTasks.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::setSelection): Set m_pendingSelectionUpdate and synchronously update caret rect
if we don't need to update style or layout.
(WebCore::updateSelectionByUpdatingLayoutOrStyle): Added. Used by FrameSelection member functions to
trigger layout or style recalc whichever is needed.
(WebCore::FrameSelection::updateAndRevealSelection): Extracted from setSelection.
(WebCore::FrameSelection::absoluteCaretBounds): Call updateSelectionByUpdatingLayoutOrStyle since caret rect
is no longer updated synchronously in setSelection.
(WebCore::FrameSelection::recomputeCaretRect): Don't assert that visibleStart().absoluteCaretBounds() is
equal to m_absCaretBounds since selection may no longer be caret at this point.
(WebCore::FrameSelection::setCaretVisibility): Call updateSelectionByUpdatingLayoutOrStyle since we're
synchronously calling into updateAppearance here. In the future, we should make this asynchronous as well.
(WebCore::FrameSelection::selectionBounds): Call updateSelectionByUpdatingLayoutOrStyle since selection bounds
could be outdated. This code only triggering style recalc was presumably a bug.
- editing/FrameSelection.h:
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks): Update selection's appearance and scroll to reveal selection
as needed.
- 2:09 PM Changeset in webkit [164132] by
-
- 11 edits in trunk/Source/WebKit2
Add WKBackForwardListDidChangeNotification
https://bugs.webkit.org/show_bug.cgi?id=128839
Reviewed by Dan Bernstein.
Also, make LoaderClient::didChangeBackForwardList take a Vector of WebBackForwardListItems
instead of a pointer to a Vector of API::Objects.
- Shared/API/Cocoa/WKFoundation.h:
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didChangeBackForwardList):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardList.mm:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didChangeBackForwardList):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
- UIProcess/WebPageProxy.h:
- 1:29 PM Changeset in webkit [164131] by
-
- 63 edits3 deletes in trunk
Purge remaining ENABLE(SHADOW_DOM) cruft.
<https://webkit.org/b/128827>
Source/WebCore:
Remove the remaining 8.8 million lines of Shadow DOM code to align
with goals for intent to ship 60fps on mobile in 2014.
Reviewed by Antti Koivisto.
Tools:
Reviewed by Antti Koivisto.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- Scripts/webkitperl/FeatureList.pm:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- 1:21 PM Changeset in webkit [164130] by
-
- 2 edits in trunk/Source/WebCore
[MediaControls][iOS] Embedded YouTube does not show a 'paused' button state after starting
https://bugs.webkit.org/show_bug.cgi?id=128755
Reviewed by Eric Carlson.
Don't rely on "canPlay()", instead, take the information directly from the event itself. I.e., when
handling the 'play' event, switch mode to playing, and vice versa for the 'pause' event.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handlePlay):
(Controller.prototype.handlePause):
(Controller.prototype.updatePlaying):
(Controller.prototype.setPlaying):
- 1:19 PM Changeset in webkit [164129] by
-
- 5 edits in trunk/Source/WebCore
[MediaControls][iOS] Start playback button is visible when playing embedded YouTube
https://bugs.webkit.org/show_bug.cgi?id=128754
Reviewed by Eric Carlson.
Update shouldHaveStartPlaybackButton to match the behavior of the plugin proxy.
Add a accessor to determine whether playback has been requested:
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::userGestureRequired):
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.idl:
Update the logic of shouldHaveStartPlaybackButton.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.shouldHaveStartPlaybackButton):
- 1:17 PM Changeset in webkit [164128] by
-
- 4 edits in trunk/Source/JavaScriptCore
Baseline JIT should have a fast path to bypass the write barrier on op_enter
https://bugs.webkit.org/show_bug.cgi?id=128832
Reviewed by Filip Pizlo.
- jit/JIT.h: Removed some random commented out functions.h
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_enter):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
- 1:15 PM Changeset in webkit [164127] by
-
- 4 edits in trunk/Source/WebCore
[MediaControls] Add support for a loading progress meter
https://bugs.webkit.org/show_bug.cgi?id=128651
Reviewed by Eric Carlson.
Draw the loaded ranges underneath the timeline slider. Use a -webkit-canvas()
CSS function to allow the track of the slider to reflect the current state of
the video's loadedTimeRanges property.
Since -webkit-canvas() will share a backing store with all other CSS images using
the same identifier, use a monotonically increasing identifier to uniquely identify the timeline on a per-document basis.
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-timeline):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller): Call updateProgress().
(Controller.prototype.createControls): Set up the canvas style and identifier.
(Controller.prototype.handleLoadStart): Call updateProgress().
(Controller.prototype.handleStalled): Ditto.
(Controller.prototype.handleReadyStateChange): Ditto.
(Controller.prototype.handleDurationChange): Ditto.
(Controller.prototype.handleProgress): Ditto.
(Controller.prototype.progressFillStyle): Added an easily overridable method
to determine the fill color of the progress bar.
(Controller.prototype.updateProgress): Draw the loadedTimeRanges into the timeline slider.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.progressFillStyle): Override.
- 1:13 PM Changeset in webkit [164126] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Always enable AVKit in WK2
https://bugs.webkit.org/show_bug.cgi?id=128686
Reviewed by Simon Fraser.
Enable AVKit in iOS WK2 by default. This enables <video> element full screen in WK2.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 1:00 PM Changeset in webkit [164125] by
-
- 4 edits in trunk/Source/WebCore
Clean up JSDOMStringMap::deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=128801
Reviewed by Geoffrey Garen.
Follow up on my cleaning of JSDOMStringMapCustom, this time for deletion.
Previously, we would query for the name, then call deleteItem() if the name was
found. Instead, everything is moved to deleteItem which then return if the deletion
is successful or not.
By using convertPropertyNameToAttributeName, we can use Element::hasAttribute() directly
to find if the attribute exists or not. If it exists, we remove it.
Theoretically we could have a single pass over the attributes to find->delete but this
code is not hot enough to justify anything fancy at this point.
Finally, we no longer check for isValidPropertyName() on deletion. JSDOMStringMapCustom
was the last client of DatasetDOMStringMap::deleteItem() and it could not call deleteItem()
with invalid name since the name would have failed DatasetDOMStringMap::contains().
The spec does not specify any name checking either for deletion so we are safe just ignoring
invalid input.
- bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty):
- dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::deleteItem):
- dom/DatasetDOMStringMap.h:
- 12:59 PM Changeset in webkit [164124] by
-
- 4 edits in trunk/Source
Improve the performance on mobile of FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=128778
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-14
Reviewed by Antti Koivisto.
Source/WebCore:
Little cleanup.
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::processFilesizeString):
(WebCore::wasLastDayOfMonth):
(WebCore::processFileDateString):
(WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
Source/WTF:
- wtf/text/WTFString.h:
(WTF::String::endsWith): add a missing overload.
- 12:58 PM Changeset in webkit [164123] by
-
- 6 edits in trunk/Source/WebCore
Do not attempt to synchronize attributes when no Simple Selector could match an animatable attribute
https://bugs.webkit.org/show_bug.cgi?id=128728
Reviewed by Andreas Kling.
In most cases, we don't even need to test for the flag animatedSVGAttributesNotDirty.
If the selector filter could never match an animatable attribute, there is no point in testing for one.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::canMatchStyleAttribute):
Skip the second test when the local name is equal to canonicalLocalName. That is the common case.
(WebCore::SelectorCompiler::canMatchAnimatableSVGAttribute):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributesMatching):
- svg/SVGElement.cpp:
(WebCore::addQualifiedName):
(WebCore::SVGElement::animatableAttributeForName):
(WebCore::SVGElement::isAnimatableAttribute):
(WebCore::SVGElement::filterOutAnimatableAttribute):
- svg/SVGElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::filterOutAnimatableAttribute):
- svg/SVGScriptElement.h:
Move the list of animatable attribute to a static function available in Release.
Selector matching is a lot more flexible than normal name matching. Since the local name must
always match, it is used as a key to get the full QualifiedName to compare to the selector.
Separating the list of animatable attributes between Selectors and SVGElement::isAnimatableAttribute
would be error prone. Instead, SVGElement::isAnimatableAttribute() is modified to use
SVGElement::animatableAttributeForName so that the two never get out of sync.
Since SVGScriptElement has one additional restriction to isAnimatableAttribute(), the function
filterOutAnimatableAttribute() is added to remove a qualified name from the complete list of animatable attributes.
This ensure SVGElement::animatableAttributeForName() always has the complete list, and subclasses of SVGElement
can only remove QualifiedNames, not add them.
- 12:57 PM Changeset in webkit [164122] by
-
- 3 edits3 copies in tags/Safari-538.16.6
Merged r164119.
- 12:56 PM Changeset in webkit [164121] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][iOS] Add WKContentObservation support when dispatching synthetic mouse events
https://bugs.webkit.org/show_bug.cgi?id=128715
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-14
Reviewed by Darin Adler.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap):
- 12:53 PM Changeset in webkit [164120] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/15994340> WK2: Cannot scroll to the bottom of the page when the keyboard is on the screen
https://bugs.webkit.org/show_bug.cgi?id=128710
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-14
Reviewed by Enrica Casucci.
WKView/WKWebView needs to adapt the UIScrollView insets to leave some space for the keyboard.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView dealloc]):
(-[WKWebView _keyboardChangedWithInfo:adjustScrollView:]):
(-[WKWebView _keyboardWillChangeFrame:]):
(-[WKWebView _keyboardDidChangeFrame:]):
(-[WKWebView _keyboardWillShow:]):
(-[WKWebView _keyboardWillHide:]):
- UIProcess/API/ios/WKContentView.h:
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView isAssistingNode]):
- UIProcess/API/ios/WKInteractionView.h:
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView dealloc]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView _keyboardChangedWithInfo:adjustScrollView:]):
(-[WKView _keyboardWillChangeFrame:]):
(-[WKView _keyboardDidChangeFrame:]):
(-[WKView _keyboardWillShow:]):
(-[WKView _keyboardWillHide:]):
- 12:51 PM Changeset in webkit [164119] by
-
- 3 edits3 adds in trunk
Don't optimize variadic closure calls
https://bugs.webkit.org/show_bug.cgi?id=128835
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
Read the check that had been in JITStubs.cpp, back in the day. This code came
from the DFG and the DFG didn't need these checks.
- jit/JITOperations.cpp:
LayoutTests:
Reviewed by Gavin Barraclough.
Add a test that covers both the performance and correctness of this case.
- js/regress/script-tests/variadic-closure-call.js: Added.
(foo.bar):
(foo):
- js/regress/variadic-closure-call-expected.txt: Added.
- js/regress/variadic-closure-call.html: Added.
- 12:47 PM Changeset in webkit [164118] by
-
- 2 edits in trunk/Source/WebCore
Make code generation of the unoptimized pseudo classes separate
https://bugs.webkit.org/show_bug.cgi?id=128704
Reviewed by Andreas Kling.
Mapping the unoptimized selectors when generating the code was useful for debugging
but those cases are so common that looping over unoptimizedPseudoCheckers was more
costly than anticipated.
This patch moves the unoptimized pseudo selector in their own array to simplify code generation.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
- 12:34 PM Changeset in webkit [164117] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: color wheel should support Retina displays
https://bugs.webkit.org/show_bug.cgi?id=124355
Reviewed by Timothy Hatcher.
Take into account the devicePixelRatio in order to draw the color wheel
with as many colors as we can draw with the current DPI and to correctly
convert from page coordinates to canvas coordinates when dealing with
mouse events.
- 12:28 PM Changeset in webkit [164116] by
-
- 3 edits in tags/Safari-538.16.6/Source/JavaScriptCore
Merged r164063.
- 12:08 PM Changeset in webkit [164115] by
-
- 10 edits2 adds in trunk
Implement text-decoration-skip: auto
https://bugs.webkit.org/show_bug.cgi?id=128786
Reviewed by Dean Jackson.
http://lists.w3.org/Archives/Public/www-style/2014Feb/0485.html
We are updating the initial value of text-decoration-skip to a new value, "auto".
On Mac + iOS, this will have the same behavior as "skip".
Source/WebCore:
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-default.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecorationSkip):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::valueToDecorationSkip):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-default-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-default.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:
- 12:04 PM QtWebKitBuildBots edited by
- (diff)
- 11:49 AM Changeset in webkit [164114] by
-
- 5 edits in tags/Safari-538.16.6/Source
Versioning.
- 11:47 AM Changeset in webkit [164113] by
-
- 1 copy in tags/Safari-538.16.6
New Tag.
- 11:38 AM Changeset in webkit [164112] by
-
- 8 edits in trunk/Source/WebKit2
Stop using PLATFORM(MAC) in WebKit2/PluginProcess except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128802
Reviewed by Darin Adler.
- PluginProcess/PluginControllerProxy.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::paint):
- PluginProcess/PluginControllerProxy.h: Ditto.
- PluginProcess/PluginControllerProxy.messages.in: Ditto.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess): Ditto.
(WebKit::PluginProcess::netscapePluginModule): Added && !PLATFORM(IOS) around Mac-specific
quirk.
(WebKit::PluginProcess::createWebProcessConnection): Changed PLATFORM(MAC) to OS(DARWIN)
around use of Mach-based IPC.
- PluginProcess/PluginProcess.h: Changed PLATFORM(MAC) to PLATFORM(COCOA), and to
USE(APPKIT) around override of stopRunLoop, which is implemented using AppKit.
- PluginProcess/PluginProcess.messages.in: Removed PLATFORM(MAC) guard around
SetProcessSuppressionEnabled. Changed it to PLATFORM(COCOA) around SetQOS.
- PluginProcess/WebProcessConnection.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::WebProcessConnection::createPluginInternal):
(WebKit::WebProcessConnection::createPlugin):
- 11:26 AM Changeset in webkit [164111] by
-
- 4 edits in trunk/Source/WebKit2
Add -[WKWebView estimatedProgress]
https://bugs.webkit.org/show_bug.cgi?id=128830
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView estimatedProgress]):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeEstimatedProgress):
(WebKit::NavigationState::didChangeEstimatedProgress):
- 11:13 AM Changeset in webkit [164110] by
-
- 14 edits in trunk/Source
Give ScrollingTree(State)Nodes a reference to another layer, which is used for moving overflow:scroll contents around
https://bugs.webkit.org/show_bug.cgi?id=128790
Reviewed by Beth Dakin.
Have scrolling tree nodes and state nodes track another layer, the
"scrolled contents layer", for accelerated overflow:scroll.
When making ScrollingTreeScrollingNodes for overflow:scroll, the node's
layer will point to the composited element's primary layer, and its
scrolledContentsLayer to the layer that gets moved around by scrolling.
Do some other cleanup on AsyncScrollingCoordinator, removing
functions that just called through to nodes.
Source/WebCore:
- WebCore.exp.in:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateScrollingNode):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrolledContentsLayer):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
- page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:
(WebCore::ScrollingTreeScrollingNodeIOS::updateBeforeChildren):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
Source/WebKit2:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
- 10:59 AM Changeset in webkit [164109] by
-
- 3 edits in trunk/Source/WebKit2
Add -[WKWebView _handle]
https://bugs.webkit.org/show_bug.cgi?id=128828
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _handle]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 10:31 AM Changeset in webkit [164108] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test correction to get bots green.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt: Don't
snapshot final pixel location, since these seems to be somewhat dependent
on the test machine.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html: Ditto
- 9:52 AM Changeset in webkit [164107] by
-
- 5 edits2 adds in trunk
AX: WebKit needs heuristics to differentiate lists used for layout from semantic data lists, similar to the heuristics for layout tables versus data tables.
https://bugs.webkit.org/show_bug.cgi?id=122320
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Many authors use lists for layout, rather than presenting data. Exposing these kinds of lists to accessibility users
makes the web harder to process and listen, while degrading the importance of real lists.
This introduces heuristics to filter out layout lists with the following:
- If it's a named list, like ol or aria=list, then it's a list. 1a. Unless the list has no children, then it's not a list.
- If it displays visible list markers, it's a list.
- If it does not display list markers and has only one child, it's not a list.
- If it does not have any listitem children, it's not a list.
- Otherwise it's a list (for now).
Test: accessibility/list-detection.html
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::determineAccessibilityRole):
(WebCore::AccessibilityList::roleValue):
- accessibility/AccessibilityList.h:
LayoutTests:
- accessibility/aria-roles.html:
- accessibility/list-detection-expected.txt: Added.
- accessibility/list-detection.html: Added.
- 9:51 AM Changeset in webkit [164106] by
-
- 8 edits in trunk/Source/WebCore
Use AtomicString arguments in TrackPrivateBaseClient callbacks
https://bugs.webkit.org/show_bug.cgi?id=128765
Reviewed by Eric Carlson.
No new tests because this doesn't change functionality.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::idChanged):
(WebCore::AudioTrack::labelChanged):
(WebCore::AudioTrack::languageChanged):
- html/track/AudioTrack.h:
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack):
(WebCore::InbandTextTrack::idChanged):
(WebCore::InbandTextTrack::labelChanged):
(WebCore::InbandTextTrack::languageChanged):
- html/track/InbandTextTrack.h:
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::idChanged):
(WebCore::VideoTrack::labelChanged):
(WebCore::VideoTrack::languageChanged):
- html/track/VideoTrack.h:
- platform/graphics/TrackPrivateBase.h:
- 9:48 AM Changeset in webkit [164105] by
-
- 12 edits37 adds in trunk
Create some latched scrolling tests.
https://bugs.webkit.org/show_bug.cgi?id=127606
<rdar://problem/15911348>
Reviewed by Simon Fraser.
Tools:
- DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize
the new "mouseScrollByX:andY:withWheel:andMomentumPhases:" selector.
(+[EventSendingController webScriptNameForSelector:]): Ditto.
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Implement
the new wheel event sender.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add declaration
of new mouseScrollByWithWheelAndMomentumPhases method.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Added
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Add stub for iOS.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle): Handle the new
mouseScrollByWithWheelAndMomentumPhases message.
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Handle the
new mouseScrollByWithWheelAndMomentumPhases.
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide stub that
relays to the standard mouse wheel handler.
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide implementation
of mouse wheel gesture method.
LayoutTests:
Add a series of tests to cover desired behavior with wheel events (including momentum).
This behavior is specific to the Mac platform, so is limited to the platform/mac and
platform/mac-wk2 directories.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html: Added.
- platform/mac/fast/scrolling: Added.
- platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-div-latched-div.html: Added.
- platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-div-latched-mainframe.html: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html: Added.
- platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-select-latched-mainframe.html: Added.
- platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-select-latched-select.html: Added.
- 9:41 AM Changeset in webkit [164104] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: comparePositions(newEnd, newStart) >= 0 in WebCore::ApplyStyleCommand::updateStartEnd
https://bugs.webkit.org/show_bug.cgi?id=121791
Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-02-14
Reviewed by Darin Adler.
Source/WebCore:
If WebCore::ApplyStyleCommand::applyBlockStyle() creates a TextIterator for a range
that has an element with ReplacedElement rendering object, then a ',' is emitted in the
constructor of TextIterator. Due to this comma the end of the run range can be at the
wrong position, what makes the assertion fire. This situation can be handled the same
way in TextIterator::rangeFromLocationAndLength() as we do in case of the emitted '\n's.
Test: editing/execCommand/remove-formatting-from-iframe-in-button.html
- editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
LayoutTests:
- editing/execCommand/remove-formatting-from-iframe-in-button-expected.txt: Added.
- editing/execCommand/remove-formatting-from-iframe-in-button.html: Added.
- 9:35 AM Changeset in webkit [164103] by
-
- 3 edits2 adds in trunk
[CSS Regions] visibility: hidden on a region should hide its content
https://bugs.webkit.org/show_bug.cgi?id=128814
Reviewed by Mihnea Ovidenie.
Source/WebCore:
The patch properly checks that the content of a region layer should be painted before actually
calling the paint function (for example, when visibility: hidden is specified on a region, its
content should be hidden).
Test: fast/regions/visibility-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
Add a test that verifies visibility: hidden on a region hides the content of
the flow thread.
- fast/regions/visibility-hidden-expected.html: Added.
- fast/regions/visibility-hidden.html: Added.
- 9:11 AM Changeset in webkit [164102] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ASan] Disable JSStack::sanitizeStack() to avoid false-positive stack-buffer-overflow errors
<http://webkit.org/b/128819>
Reviewed by Filip Pizlo.
- interpreter/JSStack.cpp:
(JSC::JSStack::sanitizeStack): When building with the clang
address sanitizer, don't sanitize the stack since it will
trigger false-positive stack-buffer-overflow errors. Disabling
this only results in a performance penalty, not a correctness
penalty.
- 6:02 AM WebKitGTK/SpeedUpBuild edited by
- More details for icecc compilation (diff)
- 5:58 AM WebKitGTK/SpeedUpBuild edited by
- Added more details about icecc compilation (diff)
- 5:57 AM Changeset in webkit [164101] by
-
- 6 edits in trunk/LayoutTests
Refactoring design-mode-spellcheck-off.html to use asynchronous spellchecking
https://bugs.webkit.org/show_bug.cgi?id=127770
Reviewed by Ryosuke Niwa.
Enable asynchronous spellchecking in design-mode-spellcheck-off.html.
Due to js-test-pre.js adds some HTML elements inside the BODY, the misspelled
phrase was moved into separated div element. It allows to check spelling marker
on desired element instead of whole body.
It turned out that the test does not underline "asdf" as misspelled although
spellcheck attribute is on. To force spellchecking, the caret needs to be moved
out of the misspelled word. To be more reliable, the test now contains two test
cases in 'desingMode=on' when spellcheck attribute is off and on.
- editing/spelling/design-mode-spellcheck-off-expected.txt:
- editing/spelling/design-mode-spellcheck-off.html:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
Skip the test for GTK.
- platform/win/TestExpectations:
Add failing test expectation.
- 4:26 AM Changeset in webkit [164100] by
-
- 6 edits in trunk/LayoutTests
Use asynchronous spellchecking in spelling-hasspellingmarker.js
https://bugs.webkit.org/show_bug.cgi?id=128526
Reviewed by Ryosuke Niwa.
Refactoring spelling-hasspellingmarker.js to use asynchronous spellchecking.
In addition, adds some bits for non-DumpRenderTree users.
- editing/spelling/script-tests/spelling-hasspellingmarker.js:
(addContainer): creates a new div element based on given markup.
(typeMisspelling): types 'zz' to the element.
(verifySpellingMarkers): calls shouldBecomeEqual to verify spelling markers.
(tests): contains test cases.
(done): invokes next test cases if any, otherwise calls finishJSTest().
- editing/spelling/spelling-hasspellingmarker-expected.txt:
Update baseline.
- editing/spelling/spelling-hasspellingmarker.html:
Include editing.js due to the test started using typeCharacterCommand().
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
Skip spelling-hasspellingmarker.html for GTK (wk1 and wk2).
- 3:52 AM Changeset in webkit [164099] by
-
- 2 edits in trunk/Source/WebCore
Follow-up fix after r164036.
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-02-14
Reviewed by Csaba Osztrogonác.
- dom/Document.cpp:
(WebCore::Document::create):
- 3:38 AM Changeset in webkit [164098] by
-
- 3 edits in trunk
Unreviewed, rolling out r164090.
http://trac.webkit.org/changeset/164090
https://bugs.webkit.org/show_bug.cgi?id=128807
It broke the EFL build (Requested by Ossy on #webkit).
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
- 3:14 AM Changeset in webkit [164097] by
-
- 2 edits in trunk/Source/WTF
(try)append and insert operations don't need new operator for PODs
https://bugs.webkit.org/show_bug.cgi?id=128185
Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2014-02-14
Reviewed by Darin Adler.
Vector's methods use VectorCopier to copy data.
VectorCopier for PODs exteded to be used with different types. For different types placement new copy approach is applied. For the same types memcpy is applied.
- wtf/Vector.h:
(WTF::OverflowHandler>::append): use VectorCopier to copy data.
(WTF::OverflowHandler>::tryAppend): use VectorCopier to copy data.
(WTF::OverflowHandler>::insert): use VectorCopier to copy data.
- 3:10 AM Changeset in webkit [164096] by
-
- 2 edits2 deletes in trunk/Source/JavaScriptCore
Cleaning the JSStaticScopeObject files left behind after renaming their objects to JSNameScope
https://bugs.webkit.org/show_bug.cgi?id=127595
Patch by Andres Gomez <Andres Gomez> on 2014-02-14
Reviewed by Mario Sanchez Prada.
JSStaticScopeObject was renamed to JSNameScope and removed long
ago but the files were left behind empty and the CMake compilation
in need of its existance. Now, we are definitely getting rid of
them.
- CMakeLists.txt:
- runtime/JSStaticScopeObject.cpp: Removed.
- runtime/JSStaticScopeObject.h: Removed.
- 1:47 AM Changeset in webkit [164095] by
-
- 2 edits in trunk/LayoutTests
Update Windows test expectations.
js/regress/emscripten-memops.html is timing out, not failing.
- platform/win/TestExpectations:
Feb 13, 2014:
- 10:04 PM Changeset in webkit [164094] by
-
- 4 edits1 add in trunk/Source/WebKit2
[Cocoa] Expose the bundle form client
https://bugs.webkit.org/show_bug.cgi?id=128792
Reviewed by Anders Carlsson.
- WebKit2.xcodeproj/project.pbxproj: Added new file.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didFocusTextField): Implemented this WKBundlePageFormClient callback by calling the form
delegate.
(setUpFormClient): Added. Initializes the form client with the above function.
(-[WKWebProcessPlugInBrowserContextController _formDelegate]): Added this getter.
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added. Initializes or
clears the form client.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
Declared _formDelegate property.
- 10:03 PM Changeset in webkit [164093] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add a way to get the page from a frame in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=128791
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _browserContextController]): Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Declared
_browserContextController property.
- 9:37 PM Changeset in webkit [164092] by
-
- 11 edits in trunk/Source/JavaScriptCore
Kill some of the last vestiges of the C++ interpreter's PICs
https://bugs.webkit.org/show_bug.cgi?id=128796
Reviewed by Michael Saboff.
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecode/PolymorphicAccessStructureList.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
(JSC::isGetByIdAccess):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/Repatch.cpp:
(JSC::getPolymorphicStructureList):
(JSC::tryBuildGetByIDList):
- llint/LowLevelInterpreter.asm:
- 8:03 PM Changeset in webkit [164091] by
-
- 5 edits in trunk/Source/WebCore
[MSE] Move PublicURLManager shutdown logic so ActiveDOMObjects associated with public URLs won't leak.
https://bugs.webkit.org/show_bug.cgi?id=128532
Patch by Byungseon Shin <sun.shin@lge.com> on 2014-02-13
Reviewed by Jer Noble.
This fixes a leak of DOM objects by breaking the circular reference
between Document, PublicURLManager, and MediaSource.
Instead of clearing PublicURLManager at destruction-time,
which is delayed indefinitely because of the circular reference,
clear the PublicURLManager during ActiveDOMObject::stop().
Frome Blink r151890 by <acolwell@chromium.org>
<https://src.chromium.org/viewvc/blink?view=rev&revision=151890>
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::publicURLManager):
- html/DOMURL.h:
- html/PublicURLManager.cpp:
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::PublicURLManager):
(WebCore::PublicURLManager::registerURL):
(WebCore::PublicURLManager::stop):
- html/PublicURLManager.h:
- 7:35 PM Changeset in webkit [164090] by
-
- 3 edits in trunk
[GTK] [CMake] JavaScriptCore crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434
Extend a fix for EFL to all ports that use GCC. Also include further fixes
that were applied only to the autotools build.
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsCommon.cmake: Add -fno-omit-frame-pointer to all ports as well
as -fno-tree-dce, which is necessary for GTK+.
- Source/cmake/OptionsEfl.cmake: The GCC flag additions are now in the common options file.
- 6:42 PM Changeset in webkit [164089] by
-
- 2 edits in trunk/Source/JavaScriptCore
The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs. Part 2.
<https://webkit.org/b/128764>
Reviewed by Mark Hahnenberg.
toJS() is the wrong cast function to use. We need to use toJSForGC() instead.
Also we need to acquire the JSLock to prevent concurrent accesses to the
Strong handle list.
- API/JSValue.mm:
(JSContainerConvertor::add):
(containerValueToObject):
(ObjcContainerConvertor::add):
(objectToValue):
- 6:36 PM Changeset in webkit [164088] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSManagedValue::dealloc modifies NSMapTable while iterating it
https://bugs.webkit.org/show_bug.cgi?id=128713
Reviewed by Geoffrey Garen.
Having to write a test for this revealed a bug in how addManagedReference:withOwner:
actually notifies JSManagedValues of new owners.
- API/JSManagedValue.mm:
(-[JSManagedValue dealloc]):
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):
- API/tests/testapi.mm:
(testObjectiveCAPI):
- 6:32 PM Changeset in webkit [164087] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix build.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
- 6:25 PM Changeset in webkit [164086] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed gardening of some timing out tests.
https://bugs.webkit.org/show_bug.cgi?id=128789.
- platform/win/TestExpectations:
- 6:04 PM Changeset in webkit [164085] by
-
- 2 edits in trunk/Source/JavaScriptCore
Speculative Release build fix after r164077.
- API/JSValue.mm:
- 5:59 PM Changeset in webkit [164084] by
-
- 7 edits in trunk/Source/WebCore
Remove position:sticky runtime flag
https://bugs.webkit.org/show_bug.cgi?id=128774
Reviewed by Simon Fraser.
Rollout of r128663
No new tests are necessary because there is no behavior change.
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSParserMode.h:
- dom/Document.cpp:
- dom/Document.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
- 5:53 PM Changeset in webkit [164083] by
-
- 3 edits in trunk/Source/WebKit2
Add -[WKWebView stopLoading:]
https://bugs.webkit.org/show_bug.cgi?id=128784
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading:]):
- 5:49 PM Changeset in webkit [164082] by
-
- 2 edits in trunk/Tools
DumpRenderTree fails to build: Perl support module building for OS X but linking for the simulator
https://bugs.webkit.org/show_bug.cgi?id=128780
Reviewed by Simon Fraser.
- DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
Use
xcrun -find clanginstead of `xcrun --sdk $ENV{SDKROOT} -find clang,
which will pick up SDKROOT=iphonesimulator from building the Xcode aggregate target.
- 5:44 PM Changeset in webkit [164081] by
-
- 12 edits25 deletes in trunk
Unreviewed, rolling out r164073 and r164080.
http://trac.webkit.org/changeset/164073
http://trac.webkit.org/changeset/164080
https://bugs.webkit.org/show_bug.cgi?id=128781
Broke Mac builds (Requested by rniwa on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2014-02-13
Tools:
- DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
- WebKitTestRunner/mac/EventSenderProxy.mm:
LayoutTests:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html: Removed.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html: Removed.
- platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt: Removed.
- platform/mac/fast/scrolling/scroll-div-latched-div.html: Removed.
- platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt: Removed.
- platform/mac/fast/scrolling/scroll-div-latched-mainframe.html: Removed.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt: Removed.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html: Removed.
- platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt: Removed.
- platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html: Removed.
- platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt: Removed.
- platform/mac/fast/scrolling/scroll-select-latched-mainframe.html: Removed.
- platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt: Removed.
- platform/mac/fast/scrolling/scroll-select-latched-select.html: Removed.
- 5:30 PM Changeset in webkit [164080] by
-
- 2 edits in trunk/Tools
Unreviewed build fix for Mountain Lion.
- DumpRenderTree/mac/EventSendingController.mm: Provide definition
for kCGScrollWheelEventScrollPhase if it isn't found in the
system headers.
- 5:24 PM Changeset in webkit [164079] by
-
- 4 edits in trunk/Source/WebKit2
Add -[WKWebView activeURL]
https://bugs.webkit.org/show_bug.cgi?id=128777
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView activeURL]):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeActiveURL):
(WebKit::NavigationState::didChangeActiveURL):
- 5:17 PM Changeset in webkit [164078] by
-
- 6 edits1 add in trunk/PerformanceTests
[CSS Shapes] Add performance test for complex polygon with shape-margin
https://bugs.webkit.org/show_bug.cgi?id=128769
Reviewed by Ryosuke Niwa.
This patch modifies the logic of createShapeOutsideTest to accept multiple
CSS properties from the test. The patch adds performance test for complex
polygon shape (self intersecting at multiple places) case, moreover we
apply shape-margin on the polygon also.
- Layout/Shapes/ShapeOutsideContentBox.html:
- Layout/Shapes/ShapeOutsideInset.html:
- Layout/Shapes/ShapeOutsidePolygonWithMargin.html: Added.
- Layout/Shapes/ShapeOutsideRaster.html:
- Layout/Shapes/ShapeOutsideSimplePolygon.html:
- Layout/Shapes/resources/shapes.js:
- 5:06 PM Changeset in webkit [164077] by
-
- 2 edits in trunk/Source/JavaScriptCore
The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs.
<https://webkit.org/b/128764>
Reviewed by Mark Hahnenberg.
Added a vector of Strong<Unknown> references in the 2 containers, and append
the newly created JSValues to those vectors. This will keep all those JS objects
alive for the duration of the conversion.
- API/JSValue.mm:
(JSContainerConvertor::add):
(ObjcContainerConvertor::add):
- 4:35 PM Changeset in webkit [164076] by
-
- 7 edits1 add in trunk
[GTK][CMake] Generate GObject DOM bindings .symbols files
https://bugs.webkit.org/show_bug.cgi?id=126210
Reviewed by Martin Robinson.
.:
- Source/PlatformGTK.cmake: add checking DOM bindings API as a dependency
for documentation generation.
Source/WebCore:
No new tests. Build change only.
- CMakeLists.txt: list Quota module files and IDLs even if the feature
is disabled, for GTK, since we rely on that for our DOM bindings.
- PlatformGTK.cmake: add a new target to check for DOM symbols API by
running the new python script.
- bindings/gobject/GNUmakefile.am: call the new python script instead
of using a custom rule.
Tools:
- gtk/check-gdom-symbols: Added. Checks symbols compatibility.
(should_update_symbols_file):
- 4:30 PM Changeset in webkit [164075] by
-
- 4 edits2 adds in trunk
text-decoration-skip: ink skips randomly when using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=128709
Reviewed by Simon Fraser.
Source/WebCore:
This patch simply disables skipping underlines being used with SVG fonts.
It's a stopgap until we can support skipping properly with SVG fonts.
Test: svg/custom/svg-fonts-skip-ink.html
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
LayoutTests:
This text checks that some text without descenders in an SVG font renders the same with and
without text-decoration-skip: ink.
- svg/custom/svg-fonts-skip-ink-expected.html: Added.
- svg/custom/svg-fonts-skip-ink.html: Added.
- 4:22 PM Changeset in webkit [164074] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Added GetMyArgumentsLength to FTL
https://bugs.webkit.org/show_bug.cgi?id=128758
Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-13
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
- tests/stress/ftl-getmyargumentslength.js: Added.
(foo):
- 4:22 PM Changeset in webkit [164073] by
-
- 12 edits37 adds in trunk
Create some latched scrolling tests.
https://bugs.webkit.org/show_bug.cgi?id=127606
<rdar://problem/15911348>
Reviewed by Simon Fraser.
Tools:
- DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize
the new "mouseScrollByX:andY:withWheel:andMomentumPhases:" selector.
(+[EventSendingController webScriptNameForSelector:]): Ditto.
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Implement
the new wheel event sender.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add declaration
of new mouseScrollByWithWheelAndMomentumPhases method.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Added
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Add stub for iOS.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle): Handle the new
mouseScrollByWithWheelAndMomentumPhases message.
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Handle the
new mouseScrollByWithWheelAndMomentumPhases.
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide stub that
relays to the standard mouse wheel handler.
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Provide implementation
of mouse wheel gesture method.
LayoutTests:
Add a series of tests to cover desired behavior with wheel events (including momentum).
This behavior is specific to the Mac platform, so is limited to the platform/mac and
platform/mac-wk2 directories.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html: Added.
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html: Added.
- platform/mac/fast/scrolling: Added.
- platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-div-latched-div.html: Added.
- platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-div-latched-mainframe.html: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html: Added.
- platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-select-latched-mainframe.html: Added.
- platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-select-latched-select.html: Added.
- 4:22 PM Changeset in webkit [164072] by
-
- 2 edits in trunk/Source/WTF
Fix the iOS build after <http://trac.webkit.org/changeset/164064
- wtf/Platform.h:
- 3:57 PM Changeset in webkit [164071] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out http://trac.webkit.org/changeset/164066.
It broke tests and it was just plain wrong.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
- runtime/Structure.h:
(JSC::Structure::takesSlowPathInDFGForImpureProperty):
- 3:41 PM Changeset in webkit [164070] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix.
Fixed typo.
- dfg/DFGIntegerCheckCombiningPhase.cpp:
(JSC::DFG::IntegerCheckCombiningPhase::run):
- 3:35 PM Changeset in webkit [164069] by
-
- 6 edits in trunk/Source/JavaScriptCore
Change FTL stack check to use VM's stackLimit
https://bugs.webkit.org/show_bug.cgi?id=128561
Reviewed by Filip Pizlo.
Changes FTL function entry to check the call frame register against the FTL
specific stack limit (VM::m_ftlStackLimit) and throw an exception if the
stack limit has been exceeded. Updated the exception handling code to have
a second entry that will unroll the current frame to the caller, since that
is where the exception should be processed.
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
- ftl/FTLState.h:
- runtime/VM.h:
(JSC::VM::addressOfFTLStackLimit):
- 3:34 PM Changeset in webkit [164068] by
-
- 2 edits in trunk/Source/WebCore
Fix the ARM build when HAVE_ARM_NEON_INTRINSICS is enabled
Add !HAVE(ARM_NEON_INTRINSICS)-guard around file-level inline function arithmeticSoftware to
avoid an unused function compiler warning when building with ARM Neon intrinsics.
- platform/graphics/filters/FEComposite.cpp:
- 3:33 PM Changeset in webkit [164067] by
-
- 3 edits in trunk/Source/WebKit2
Add -[WKWebView goToBackForwardListItem:]
https://bugs.webkit.org/show_bug.cgi?id=128773
Reviewed by Andreas Kling.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView goToBackForwardListItem:]):
- 3:31 PM Changeset in webkit [164066] by
-
- 3 edits in trunk/Source/JavaScriptCore
GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses, and calling that method should never assert about anything
https://bugs.webkit.org/show_bug.cgi?id=128772
Reviewed by Mark Hahnenberg.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
- runtime/Structure.h:
(JSC::Structure::takesSlowPathInDFGForImpureProperty):
- 3:28 PM Changeset in webkit [164065] by
-
- 1 edit2 adds in trunk/PerformanceTests
[CSS Shapes] Add performance test for raster shape
https://bugs.webkit.org/show_bug.cgi?id=128746
Reviewed by Ryosuke Niwa.
This patch adds performance testing for image valued shape-outside.
The test is skipped by default for now.
- Layout/Shapes/ShapeOutsideRaster.html: Added.
- Layout/Shapes/resources/shape.gif: Added.
- 3:17 PM Changeset in webkit [164064] by
-
- 2 edits in trunk/Source/WTF
[iOS] Disable HAVE_ARM_NEON_INTRINSICS
For now, disable HAVE_ARM_NEON_INTRINSICS when building for iOS. We want
to audit the applicable code before we enable this define.
- wtf/Platform.h:
- 3:07 PM Changeset in webkit [164063] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add some RELEASE_ASSERTs to catch JSLock bugs earlier
https://bugs.webkit.org/show_bug.cgi?id=128762
Reviewed by Mark Lam.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- runtime/JSLock.cpp:
(JSC::JSLock::DropAllLocks::DropAllLocks):
- 3:04 PM Changeset in webkit [164062] by
-
- 5 edits in trunk
IDB: Three tests crash the DatabaseProcess under ~KeyedDecoder
https://bugs.webkit.org/show_bug.cgi?id=128763
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests (Covered by three existing tests)
- platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeObjects): If the array is empty we still have to begin() and end() it.
LayoutTests:
- platform/mac-wk2/TestExpectations: One test passes, one passes with expectation changes, and the third is now a text failure.
- storage/indexeddb/key-type-array-expected.txt:
- 3:02 PM Changeset in webkit [164061] by
-
- 11 edits in trunk
[css3-text] Support -webkit-text-decoration-skip: objects
https://bugs.webkit.org/show_bug.cgi?id=128723
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2014-02-13
Reviewed by Dean Jackson.
Source/WebCore:
Implemented 'objects' value of text-decoration-skip.
http://www.w3.org/TR/2013/CR-css-text-decor-3-20130801/#text-decoration-skip
This is initial value and same behavior without
ENABLE_CSS3_TEXT_DECORATION_SKIP_INK flag. Threfore, this patch only
added parser code and constant for 'objects'.
Changed the initial value of text-decoration-skip.
The current implementation parses 'none', but the rendering code is
not match the spec, so this patch added FIXME to the rendering code.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecorationSkip):
- css/CSSValueKeywords.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::valueToDecorationSkip):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
Added 'objects' value to the current test case.
Added getComputedStyle() test to test renderTextDecorationSkipFlagsToCSSValue() code.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:
- 2:59 PM Changeset in webkit [164060] by
-
- 2 edits in trunk/Source/WebCore
Fix ARM NEON build following <http://trac.webkit.org/changeset/164058>
(https://bugs.webkit.org/show_bug.cgi?id=128767)
I inadvertently didn't include header NEONHelpers.h, which defines WebCore::loadRGBA8AsFloat().
- platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:
- 2:46 PM Changeset in webkit [164059] by
-
- 38 edits11 adds in trunk/Source
Hoist and combine array bounds checks
https://bugs.webkit.org/show_bug.cgi?id=125433
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This adds a phase for reasoning about overflow checks and array bounds checks. It's
block-local, and removes both overflow checks and bounds checks in one go.
This also improves reasoning about commutative operations, and CSE between
CheckOverflow and Unchecked arithmetic.
This strangely uncovered a DFG backend bug where we were trying to extract an int32
from a constant even when that constant was just simply a number. I fixed that bug.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArithMode.h:
(JSC::DFG::subsumes):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGEdge.cpp:
(JSC::DFG::Edge::dump):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::sanitized):
(JSC::DFG::Edge::hash):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueOfInt32Constant):
- dfg/DFGInsertionSet.h:
(JSC::DFG::InsertionSet::insertConstant):
- dfg/DFGIntegerCheckCombiningPhase.cpp: Added.
(JSC::DFG::IntegerCheckCombiningPhase::IntegerCheckCombiningPhase):
(JSC::DFG::IntegerCheckCombiningPhase::run):
(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
(JSC::DFG::IntegerCheckCombiningPhase::rangeKeyAndAddend):
(JSC::DFG::IntegerCheckCombiningPhase::isValid):
(JSC::DFG::IntegerCheckCombiningPhase::insertAdd):
(JSC::DFG::IntegerCheckCombiningPhase::insertMustAdd):
(JSC::DFG::performIntegerCheckCombining):
- dfg/DFGIntegerCheckCombiningPhase.h: Added.
- dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
(JSC::DFG::StrengthReductionPhase::handleCommutativity):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionFalse):
- runtime/Identifier.h:
- runtime/Intrinsic.h:
- runtime/JSObject.h:
- tests/stress/get-by-id-untyped.js: Added.
(foo):
- tests/stress/inverted-additive-subsumption.js: Added.
(foo):
- tests/stress/redundant-add-overflow-checks.js: Added.
(foo):
- tests/stress/redundant-array-bounds-checks-addition-skip-first.js: Added.
(foo):
(arraycmp):
- tests/stress/redundant-array-bounds-checks-addition.js: Added.
(foo):
(arraycmp):
- tests/stress/redundant-array-bounds-checks-unchecked-addition.js: Added.
(foo):
(arraycmp):
- tests/stress/redundant-array-bounds-checks.js: Added.
(foo):
(arraycmp):
- tests/stress/tricky-array-bounds-checks.js: Added.
(foo):
(arraycmp):
Source/WTF:
Reviewed by Mark Hahnenberg.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/HashMethod.h: Added.
(WTF::HashMethod::operator()):
- 2:45 PM Changeset in webkit [164058] by
-
- 2 edits in trunk/Source/WebCore
Write FEComposite::computeArithmeticPixelsNeon() in terms of loadRGBA8AsFloat()
https://bugs.webkit.org/show_bug.cgi?id=128767
Reviewed by Dean Jackson.
This patch was inspired by Gabor Rapcsanyi's work in <https://bugs.webkit.org/show_bug.cgi?id=90669>.
Currently we duplicate code in FEComposite::computeArithmeticPixelsNeon() to read pixel data.
Instead we should use the convenience function WebCore::loadRGBA8AsFloat. This also resolves
an uninitialized variable compiler warning in the existing code.
- platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:
(WebCore::FEComposite::computeArithmeticPixelsNeon):
- 2:34 PM Changeset in webkit [164057] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL should be OK with compact_unwind in a data section
https://bugs.webkit.org/show_bug.cgi?id=128756
Reviewed by Mark Hahnenberg.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):
- 2:18 PM Changeset in webkit [164056] by
-
- 3 edits in trunk/Tools
Unreviewed. changing my email address.
- 2:13 PM Changeset in webkit [164055] by
-
- 1 edit in trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp
Attempt to fix LevelDB builds.
- 2:13 PM Changeset in webkit [164054] by
-
- 2 edits in trunk/Source/WebKit2
Make WKWebViewConfigurationPrivate.h private
https://bugs.webkit.org/show_bug.cgi?id=128761
Reviewed by Tim Horton.
- WebKit2.xcodeproj/project.pbxproj:
- 1:55 PM Changeset in webkit [164053] by
-
- 19 edits2 adds in trunk
During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
https://bugs.webkit.org/show_bug.cgi?id=128688
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adds a field, m_needsPositionStyleConversion, to StyledMarkupAccumulator.
Also, renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
Test: editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy.html
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::createMarkupInternal):
- page/Settings.in:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldConvertPositionStyleOnCopy):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebKit/mac:
Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences shouldConvertPositionStyleOnCopy]):
(-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShouldConvertPositionStyleOnCopy):
(WKPreferencesGetShouldConvertPositionStyleOnCopy):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests:
Performs a copy of the contents of a particular div, rather than the entire body. Makes sure that
no position:fixed -> position:absolute conversion occurs.
- editing/pasteboard/copy-paste-converts-sticky-and-fixed-expected.txt:
- editing/pasteboard/copy-paste-converts-sticky-and-fixed.html:
- editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy-expected.txt: Added.
- editing/pasteboard/copy-paste-doesnt-convert-sticky-and-fixed-during-partial-copy.html: Added.
- 1:38 PM Changeset in webkit [164052] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: DataGrid should support editing tables with arbitrary columns
https://bugs.webkit.org/show_bug.cgi?id=128619
Reviewed by Timothy Hatcher.
The data grid editing code should work with any columns, but was previously
hardcoded with the column identifiers used by DOMStorageView. This patch
makes the editing code work with any column identifiers. It also fixes some
bugs in previous/next navigation during data entry.
- UserInterface/DOMStorageContentView.css: Highlight missing keys and values.
(.content-view.dom-storage > .data-grid tr.missing-value td.value-column):
(.content-view.dom-storage > .data-grid:focus tr.selected.missing-value td.value-column):
- UserInterface/DOMStorageContentView.js: Don't blow away the entire table
whenever the backend notifies us of an update to the storage object. This
caused the editing state to be destroyed when values were entered interactively.
(WebInspector.DOMStorageContentView.prototype.reset): Inline the callback
passed to DOMStorageObject.getEntries().
(WebInspector.DOMStorageContentView.prototype.itemsCleared):
(WebInspector.DOMStorageContentView.prototype.itemAdded): Request a sort
of the table rows after backend tells us about item additions or updates.
(WebInspector.DOMStorageContentView.prototype.itemUpdated): Request a sort
of the table rows after backend tells us about item additions or updates.
(WebInspector.DOMStorageContentView.prototype._sortDataGrid): Use DataGrid's
built-in sorting function.
(WebInspector.DOMStorageContentView.prototype._deleteCallback):
(WebInspector.DOMStorageContentView.prototype._editingCallback): Don't force
recreation of the entire table whenever editing finishes. Perform most
of the error checking and editing logic here, including when to insert a
new placeholder row, and when to commit the entered values to DOM storage.
- UserInterface/DOMStorageObject.js: Keep track of the DOM storage entries
in the model so we can detect duplicate entries. Remove unused
idarguments.
(WebInspector.DOMStorageObject):
(WebInspector.DOMStorageObject.prototype.get entries):
(WebInspector.DOMStorageObject.prototype.itemsCleared):
(WebInspector.DOMStorageObject.prototype.itemRemoved):
(WebInspector.DOMStorageObject.prototype.set this):
(WebInspector.DOMStorageObject.prototype.itemAdded):
(WebInspector.DOMStorageObject.prototype.set var):
(WebInspector.DOMStorageObject.prototype.itemUpdated):
- UserInterface/DataGrid.js:
(.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid): Use the built-in DataGrid
sortNodes() implementation.
(WebInspector.DataGrid.prototype._startEditingNodeAtColumnIndex): Renamed
from _startEditingColumnOfDataGridNode. It's easier to understand the navigation
code when presented in terms of adjusting column indexes rather than identifiers.
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.determineNextCell): Added. Decides which
column and row to edit next and whether the table can be sorted before the
next cell edit begins.
(WebInspector.DataGrid.prototype.moveToNextCell): Added. Wrapper method for
the above which handles sorting and beginning the next cell edit.
(WebInspector.DataGrid.prototype._editingCommitted): Use better helper methods.
(WebInspector.DataGrid.prototype._editingCancelled): Add an assert.
(WebInspector.DataGrid.prototype.get sortColumnIdentifier): Shorten.
(WebInspector.DataGrid.prototype.addPlaceholderNode):
(WebInspector.DataGrid.prototype.removeChild):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes): Remove unecessary copying
of all nodes into a separate array. Defer sorting if the user is in the
middle of editing a cell. Make placeholder nodes always sort to the bottom
regardless of the sort column identifier and sort direction.
(WebInspector.DataGridNode.prototype._attach):
(WebInspector.PlaceholderDataGridNode): Renamed from CreationDataGridNode.
(WebInspector.PlaceholderDataGridNode.prototype.makeNormal):
- UserInterface/StorageManager.js: Don't pass unused id argument.
(WebInspector.StorageManager.prototype.itemRemoved):
(WebInspector.StorageManager.prototype.itemAdded):
(WebInspector.StorageManager.prototype.itemUpdated):
- 1:37 PM Changeset in webkit [164051] by
-
- 11 edits in trunk/Source
Enable inspection of recently used IndexedDB databases.
https://bugs.webkit.org/show_bug.cgi?id=128687
Reviewed by Brady Eidson & Joseph Pecoraro.
Source/WebCore:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::getDatabaseNames):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Fix up the arguments passed to getDatabaseNames.
- WebCore.xcodeproj/project.pbxproj:
Make DOMStringList.h private so WebKit2 can use it.
- inspector/InspectorIndexedDBAgent.cpp:
Modernize the loops and remove some PLATFORM(COCOA) ifdefs to
compile the code.
- inspector/protocol/IndexedDB.json: Use number for version to
allow larger values instead of clamping to int.
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::sharedRecentDatabaseNameMap):
(WebKit::combinedSecurityOriginIdentifier):
(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::deleteDatabase):
Keep track of recently used database names per security-origin pair.
Implement getDatabaseNames to return the recently used names.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
Fix up the arguments passed to getDatabaseNames.
- 1:26 PM Changeset in webkit [164050] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/API/Cocoa/WKWebView.mm:
(layoutMilestones):
- 1:14 PM Changeset in webkit [164049] by
-
- 6 edits1 copy in trunk/Source/WebKit2
Add rendering progress events SPI
https://bugs.webkit.org/show_bug.cgi?id=128752
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _observedRenderingProgressEvents]):
(layoutMilestones):
(-[WKWebView _setObservedRenderingProgressEvents:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
(NS_OPTIONS):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::renderingProgressEvents):
(WebKit::NavigationState::LoaderClient::didLayout):
- WebKit2.xcodeproj/project.pbxproj:
- 12:46 PM Changeset in webkit [164048] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: long script names should be have text-overflow:ellipsis in probe details sidebar
https://bugs.webkit.org/show_bug.cgi?id=128550
Reviewed by Timothy Hatcher.
Make the link element 'display: block', place it after the floated icons,
and set the appropriate CSS overflow properties.
- UserInterface/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > a.go-to-link):
- UserInterface/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection):
- 12:45 PM Changeset in webkit [164047] by
-
- 5 edits2 adds in trunk
Copying (createMarkup) wrapping text results in space between wrapped lines stripped.
https://bugs.webkit.org/show_bug.cgi?id=63233
Source/WebCore:
The problem is StyledMarkupAccumulator uses renderedText and the space at
the end of the text has been stripped when the tag after the text was wrapped.
Patch by Chang Shu <cshu@webkit.org> on 2014-02-13
Reviewed by Ryosuke Niwa.
Test: editing/pasteboard/copy-text-with-wrapped-tag.html
- editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::handleTextBox):
- editing/TextIterator.h:
Check the special case when the iterator runs over a range that is followed by a non-text box.
In this case, the possible last space has been collapsed and needs to be restored.
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::renderedText):
Check if the range is followed by more nodes and pass this information to the constructed TextIterator.
LayoutTests:
Patch by Chang Shu <cshu@webkit.org> on 2014-02-13
Reviewed by Ryosuke Niwa.
The problem is StyledMarkupAccumulator uses renderedText and the space at
the end of the text has been stripped when the tag after the text was wrapped.
- editing/pasteboard/copy-text-with-wrapped-tag-expected.txt: Added.
- editing/pasteboard/copy-text-with-wrapped-tag.html: Added.
- 12:31 PM Changeset in webkit [164046] by
-
- 3 edits2 adds in trunk
Gaps for text-decoration-skip: ink are calculated assuming the glyph orientation is the same as the run orientation
https://bugs.webkit.org/show_bug.cgi?id=128718
Reviewed by Darin Adler.
Source/WebCore:
This is a stop-gap patch to make underlines in CJK text not look terrible. A long-term fix is to refactor
showGlyphsWithAdvances to move rotation logic into a common place that the text-decoration-skip: ink code
can use.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-orientation-upright.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
LayoutTests:
This test draws text that has descenders that would be skipped over if the glyph orientation was the same
as the run orientation. However, it uses text-orientation: upright to make those two orientations not equal.
It then compares this to no skipping at all.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-orientation-upright-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-orientation-upright.html: Added.
- 12:04 PM Changeset in webkit [164045] by
-
- 2 edits in tags/Safari-538.16.5/Source/WebKit2
Merged r164031.
- 11:50 AM Changeset in webkit [164044] by
-
- 5 edits in tags/Safari-538.16.5/Source
Versioning.
- 11:47 AM Changeset in webkit [164043] by
-
- 1 copy in tags/Safari-538.16.5
New Tag.
- 11:32 AM Changeset in webkit [164042] by
-
- 5 edits in trunk
[Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
https://bugs.webkit.org/show_bug.cgi?id=128725
Reviewed by Anders Carlsson.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::wrapCryptoKey):
(WebChromeClient::unwrapCryptoKey):
- WebView/WebUIDelegatePrivate.h:
Looks like UIDelegate is the closest we have to a reasonable place.
Tools:
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webCryptoMasterKeyForWebView:]):
Use the SPI to specify a key.
- 10:56 AM Changeset in webkit [164041] by
-
- 2 edits in trunk/LayoutTests
IDB: TestExpectations cleanup
Unreviewed.
- platform/mac-wk2/TestExpectations: More tests pass than fail, so only list failures.
- 10:52 AM Changeset in webkit [164040] by
-
- 5 edits in trunk/LayoutTests
IDB: TestExpectations batch - HTTP tests
Unreviewed.
- http/tests/security/cross-origin-indexeddb-allowed-expected.txt:
- http/tests/security/cross-origin-indexeddb-expected.txt:
- http/tests/security/resources/cross-origin-iframe-for-indexeddb.html:
- platform/mac-wk2/TestExpectations: Two of the http tests are worker tests. They remain skipped. The other three pass with test updates.
- 10:45 AM Changeset in webkit [164039] by
-
- 3 edits in trunk/Source/JavaScriptCore
CStack Branch: VM::currentReturnThunkPC appears to be unused and should be removed
https://bugs.webkit.org/show_bug.cgi?id=127205
Reviewed by Geoffrey Garen.
Removed ununsed references to VM::currentReturnThunkPC.
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
- runtime/VM.h:
- 10:39 AM Changeset in webkit [164038] by
-
- 2 edits in trunk/Source/WebCore
InsertIntoTextNodeCommand should get Settings from the Frame.
<https://webkit.org/b/128678>
EditCommands have a frame() accessor that returns a reference,
so there's no need to go through Document.
Reviewed by Anders Carlsson.
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
- 10:36 AM Changeset in webkit [164037] by
-
- 2 edits in trunk/Source/WebKit/mac
iOS build fix.
- WebView/WebView.mm:
(+[WebView registerForMemoryNotifications]):
- 10:31 AM Changeset in webkit [164036] by
-
- 7 edits2 adds in trunk
Document should be constructable
https://bugs.webkit.org/show_bug.cgi?id=115643
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-02-13
Reviewed by Darin Adler.
Source/WebCore:
http://www.w3.org/TR/2014/WD-dom-20140204/#interface-document
Make Document constructable so that one can do "new Document"
instead of "document.implementation.createHTMLDocument()".
Test: fast/dom/Document/document-constructor.html
- dom/Document.cpp:
(WebCore::Document::create):
(WebCore::Document::origin):
- dom/Document.h:
- dom/Document.idl:
LayoutTests:
- fast/dom/Document/document-constructor-expected.txt: Added.
- fast/dom/Document/document-constructor.html: Added.
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- 10:07 AM Changeset in webkit [164035] by
-
- 24 edits2 moves in trunk
[CSS Grid Layout] Rename named areas property
https://bugs.webkit.org/show_bug.cgi?id=127990
Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-02-13
Reviewed by Sergio Villar Senin.
From Blink r165891 by <Manuel Rego Casasnovas>
The property 'grid-template' has been renamed to 'grid-template-areas'
in the last two versions of the spec.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSGridTemplateAreasValue.cpp: Renamed from Source/WebCore/css/CSSGridTemplateValue.cpp.
(WebCore::CSSGridTemplateAreasValue::CSSGridTemplateAreasValue):
(WebCore::stringForPosition):
(WebCore::CSSGridTemplateAreasValue::customCSSText):
- css/CSSGridTemplateAreasValue.h: Renamed from Source/WebCore/css/CSSGridTemplateValue.h.
(WebCore::CSSGridTemplateAreasValue::create):
(WebCore::CSSGridTemplateAreasValue::~CSSGridTemplateAreasValue):
(WebCore::CSSGridTemplateAreasValue::gridAreaMap):
(WebCore::CSSGridTemplateAreasValue::rowCount):
(WebCore::CSSGridTemplateAreasValue::columnCount):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateAreas):
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isGridTemplateAreasValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Source/WebInspectorUI:
- Tools/PrettyPrinting/css.js:
- UserInterface/External/CodeMirror/css.js:
LayoutTests:
- fast/css-grid-layout/grid-item-area-get-set.html:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
- fast/css-grid-layout/grid-template-get-set-expected.txt:
- fast/css-grid-layout/grid-template-get-set.html:
- 10:06 AM Changeset in webkit [164034] by
-
- 2 edits in trunk/Source/WebCore
Remove the last remnants of Maemo support
https://bugs.webkit.org/show_bug.cgi?id=85238
Patch by Adrian Bunk <bunk@stusta.de> on 2014-02-13
Reviewed by Ryosuke Niwa.
- plugins/npapi.h:
- 10:05 AM Changeset in webkit [164033] by
-
- 8 edits in trunk/LayoutTests
IDB: TestExpectations batch - "transaction-abort.html to versionchangerequest-activedomobject.html”
Unreviewed.
- platform/mac-wk2/TestExpectations:
- storage/indexeddb/transaction-active-flag-expected.txt:
- storage/indexeddb/transaction-after-close-expected.txt:
- storage/indexeddb/transaction-read-only-expected.txt:
- storage/indexeddb/transaction-storeNames-required-expected.txt:
- storage/indexeddb/version-change-abort-expected.txt:
- storage/indexeddb/version-change-exclusive-expected.txt:
- 10:00 AM Changeset in webkit [164032] by
-
- 6 edits in trunk/Source
Code cleanup: remove gcc<4.7 guards.
https://bugs.webkit.org/show_bug.cgi?id=128729
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-13
Reviewed by Anders Carlsson.
Remove GCC_VERSION_AT_LEAST guards when it checks for pre-4.7 versions,
as WK does not compile with earlier gcc versions.
Source/JavaScriptCore:
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::cacheFlush):
- interpreter/StackVisitor.cpp:
(JSC::printif):
Source/WTF:
- wtf/Assertions.cpp:
- wtf/Platform.h:
- 9:30 AM Changeset in webkit [164031] by
-
- 2 edits in trunk/Source/WebKit2
Disable XPC for plug-ins that need executable heap
https://bugs.webkit.org/show_bug.cgi?id=128744
<rdar://problem/15962958>
Reviewed by Dan Bernstein.
When switching to XPC for plug-ins, we accidentally broke the "feature"
where plug-ins can ask for the heap to be executable.
This breaks Silverlight, so just disable XPC for any plug-ins that need this.
<rdar://problem/16059483> tracks fixing this in the XPC service.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
Only return true for 32-bit plug-ins, since we don't know any 64-bit plug-ins
that require this feature.
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Set launchOptions.useXPC to false if launchOptions.executableHeap is true.
- 9:24 AM Changeset in webkit [164030] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: fast/workers/use-machine-stack.html hits Heap::isMarked(cell) assertion
https://bugs.webkit.org/show_bug.cgi?id=128745
- TestExpectations: Marked as flakily asserting.
- 8:22 AM Changeset in webkit [164029] by
-
- 3 edits in trunk/LayoutTests
[EFL] Add or remove expectations for some media layout tests
https://bugs.webkit.org/show_bug.cgi?id=128535
Unreviewed EFL layout tests gardening
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-02-13
- platform/efl/TestExpectations:
- platform/efl-wk1/TestExpectations:
- 5:25 AM Changeset in webkit [164028] by
-
- 5 edits in trunk/Source/WebKit/efl
[EFL][WK1] Do not include libsoup header in the public headers
https://bugs.webkit.org/show_bug.cgi?id=128701
Reviewed by Gyuyoung Kim.
Although ewebkit used libsoup internally, it's not good for EFL developers
to use it.
Instead, we should provide some wrapper APIs like ewk_network_proxy_uri_set
for future changes.
- ewk/ewk_network.cpp: Removed soup related header,APIs and comments.
(ewk_network_tls_ca_certificates_path_set):
- ewk/ewk_network.h: Ditto.
- ewk/ewk_view.cpp: Ditto.
- ewk/ewk_view.h: Ditto.
- 5:20 AM Changeset in webkit [164027] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removed unexpected pass tests from TextExpections
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 4:58 AM Changeset in webkit [164026] by
-
- 9 edits in trunk/Source/WebCore
Support ANGLE_instanced_arrays for GLES backend.
https://bugs.webkit.org/show_bug.cgi?id=128579
Reviewed by Dean Jackson.
Add some APIs to Extensions3D to support ANGLE_instanced_arrays for GLES backend.
At the same time, drawArraysInstanced, drawElementsInstanced and vertexAttribDivisor
are moved from GC3DOpenGL.cpp to GC3DOpenGLCommon.cpp since they could be shareable
through Extensions3D.
Covered by fast/canvas/webgl/angle-instanced-arrays.html
- platform/graphics/Extensions3D.h:
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
- platform/graphics/opengl/Extensions3DOpenGL.h:
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::drawArraysInstanced):
(WebCore::Extensions3DOpenGLES::drawElementsInstanced):
(WebCore::Extensions3DOpenGLES::vertexAttribDivisor):
(WebCore::Extensions3DOpenGLES::supportsExtension):
- platform/graphics/opengl/Extensions3DOpenGLES.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
- 4:35 AM Changeset in webkit [164025] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/mathml/presentation/mspace-children-expected.txt: Added EFL expectation after r163626.
- 3:28 AM Changeset in webkit [164024] by
-
- 51 edits2 adds in trunk
[GTK] MEDIA_CONTROLS_SCRIPT support
https://bugs.webkit.org/show_bug.cgi?id=123097
Reviewed by Jer Noble.
.:
Part of the Autotools and CMake structure to build the media
controls script.
- Source/autotools/SetupWebKitFeatures.m4: Activated the media
controls script by default.
- Source/cmake/OptionsGTK.cmake: Activated the media controls
script by default.
- Source/cmake/WebKitFeatures.cmake: Created the option to
activate the controls script.
- Source/cmakeconfig.h.cmake: Created the define template the the
media controls script.
Source/WebCore:
WebKitGTK+ multimedia controls are now managed from Javascript
code. Apple controls are kept as common code and GTK+ ones are
subclassed for the specific behavior.
Both CMake and Autotools build support is provided.
- CMakeLists.txt: Added support to build the media controls
script and their associated files.
- GNUmakefile.am: Added support to generate the C++ code from the
Javascript.
- GNUmakefile.list.am: Added the media controls script associated
files.
- Modules/mediacontrols/MediaControlsHost.cpp:
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.idl:
(WebCore::MediaControlsHost::supportsFullscreen): Added attribute
to know if the element supports fullscreen.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.handleWrapperMouseOut):
(Controller.prototype.updatePlaying): Use clear and
resetHideControlsTimer.
(Controller.prototype.clearHideControlsTimer): Added.
(Controller.prototype.resetHideControlsTimer): Added.
- Modules/mediacontrols/mediaControlsGtk.js: Added.
(createControls): Calls ControllerGtk.
(ControllerGtk): Calls the superclass.
(contains): Defines a function to know if an object is contained
in an array.
(ControllerGtk.prototype.inheritFrom): Copies the method of the
superclass that are not reimplemented in the subclass.
(ControllerGtk.prototype.createControls): Calls the superclass and
create the remaining needed elements.
(ControllerGtk.prototype.configureInlineControls): Configures the
controls.
(ControllerGtk.prototype.setStatusHidden): Redefined empty.
(ControllerGtk.prototype.updateTime): Writes the duration and
current position. As it was so far, current time also includes
duration. If current time is bigger than 0 we show that.
(ControllerGtk.prototype.showCurrentTime): Shows current time and
hides duration label (that is included in current time).
(ControllerGtk.prototype.handlePlay): Calls the superclass and
force showing the current time.
(ControllerGtk.prototype.handleTimeUpdate): Always update the
time.
(ControllerGtk.prototype.handleMuteButtonMouseOver): Shows the
volume slider.
(ControllerGtk.prototype.handleVolumeBoxMouseOut): Hides the
volume slider.
(ControllerGtk.prototype.addControls): Adds the enclosure instead
of the panel directly. Panel is, of course, part of the enclosure.
(ControllerGtk.prototype.updateReadyState): Shows the fullscreen
button only if fullscreen is supported. Sets the volume in up or
down mode depending on its position in the document. Updates the
volume.
(ControllerGtk.prototype.setControlsType): Creates the controls it
they were not created before. Unlike Apple ones, WebKitGTK+
fullscreen and inline controls are the same.
(ControllerGtk.prototype.updatePlaying): Calls the superclass and
shows the controls if not playing.
(ControllerGtk.prototype.handleCaptionButtonClicked): Redefined
empty. To be coherent with volume, that also shows a popup, this
is handled with mouseover instead of click.
(ControllerGtk.prototype.buildCaptionMenu): Calls the superclass
to build the menu, sets some listeners, centers the popup with the
captions button, keeps the current height and sets the style to 0,
which is needed to animate it.
(ControllerGtk.prototype.destroyCaptionMenu): Hides the caption menu.
(ControllerGtk.prototype.showCaptionMenu): Resets the height to
its original. We don't animate it with CSS because we would need
to specify a height in the style and we don't know it in advance.
(ControllerGtk.prototype.hideCaptionMenu): Sets height to 0.
(ControllerGtk.prototype.captionMenuTransitionEnd): When the
captions menu transtition ends, it is destroyed.
(ControllerGtk.prototype.handleCaptionButtonMouseOver): Creates
the caption menu and shows it.
(ControllerGtk.prototype.handleCaptionButtonMouseOut): Hides the
captions menu.
(ControllerGtk.prototype.handleCaptionMouseOut): Hides the
captions menu.
- PlatformGTK.cmake: Added WebCore to the target link libraries
and initialized the variables needed at CMakelists.txt
- css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel)
(video::-webkit-media-controls-panel): Added transtion based on opacity.
(video::-webkit-media-controls-panel): Set video opacity to 0.
(video::-webkit-media-controls-panel.paused): Set video opacity to 1.
(audio::-webkit-media-controls-panel div.mute-box): Set the same
style as the mute button to preserve the layout.
(audio::-webkit-media-controls-panel div.mute-box.hidden): Sets
the display to none.
(audio::-webkit-media-controls-mute-button)
(video::-webkit-media-controls-mute-button): Removed the outline
and the margin that is managed by the mute box now.
(audio::-webkit-media-controls-play-button)
(video::-webkit-media-controls-play-button): Removed the outline.
(audio::-webkit-media-controls-time-remaining-display)
(video::-webkit-media-controls-time-remaining-display): Removed
the display.
(audio::-webkit-media-controls-current-time-display)
(video::-webkit-media-controls-current-time-display): Added the
display block.
(video::-webkit-media-controls-time-remaining-display): Set
display none.
(video::-webkit-media-controls-time-remaining-display.show): Set
display block.
(video::-webkit-media-controls-time-remaining-display.hidden): Set
display none.
(audio::-webkit-media-controls-timeline)
(video::-webkit-media-controls-timeline): Removed outline.
(audio::-webkit-media-controls-volume-slider-container)
(video::-webkit-media-controls-volume-slider-container): Set
overflow hidden and set a transition by height.
(video::-webkit-media-controls-volume-slider-container.hidden):
Set height 0.
(video::-webkit-media-controls-volume-slider-container.down): Set
bottom to be below the panel. Changed the border radius and
transition accordingly.
(video::-webkit-media-controls-panel .hidden.down): Sets default
bottom as 0.
(audio::-webkit-media-controls-volume-slider)
(video::-webkit-media-controls-volume-slider): Removed the outline.
(audio::-webkit-media-controls-toggle-closed-captions-button)
(video::-webkit-media-controls-toggle-closed-captions-button):
Removed the background that is painted from C++ and removed the
outline.
(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-container h3):
(video::-webkit-media-controls-closed-captions-container ul):
(video::-webkit-media-controls-closed-captions-container li):
(video::-webkit-media-controls-closed-captions-container li.selected): Changed
the style to make it more coherent with the rest of the controls.
(audio::-webkit-media-controls-fullscreen-button)
(video::-webkit-media-controls-fullscreen-button): Removed the outline.
(audio::-webkit-media-controls-panel button.hidden): Sets the
display to none.
- html/HTMLMediaElement.cpp: UserAgentScripts.h is not needed here
and build cmake build would need for changes to get this compiled.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::nodeHasPseudo): Added. Checks if a node has a certain
pseudo.
(WebCore::nodeHasClass): Added. Checks if a node has a certain
class.
(WebCore::supportsFocus): Removed some element types as outline is
now handled in CSS.
(WebCore::RenderThemeGtk::paintMediaPlayButton): Checks if the
play button has the class paused to show the play icon instead of
the pause one.
(WebCore::RenderThemeGtk::paintMediaToggleClosedCaptionsButton):
Added. Paints the captions icon.
(WebCore::RenderThemeGtk::mediaControlsScript): Added. Loads the
bundled scripts.
- platform/gtk/RenderThemeGtk.h: Added the mediaControlsScript
method and declared the redefinition of the method to play the
captions icon.
LayoutTests:
Tests infrastructure for the media controls script.
- media/click-volume-bar-not-pausing.html:
- media/media-volume-slider-rendered-normal.html:
- media/video-controls-captions-trackmenu-hide-on-click-outside.html:
- media/video-volume-slider.html: Fixed.
- platform/gtk-wk2/TestExpectations: Tests flagged.
- platform/gtk/TestExpectations: Changed tests flags.
- platform/gtk/accessibility/media-element-expected.txt:
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline.
- platform/gtk/fullscreen/video-controls-override-expected.txt: Added.
- platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
- platform/gtk/media/audio-controls-rendering-expected.png:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/controls-after-reload-expected.png:
- platform/gtk/media/controls-after-reload-expected.txt:
- platform/gtk/media/controls-strict-expected.png:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-strict-expected.png:
- platform/gtk/media/controls-styling-strict-expected.txt:
- platform/gtk/media/controls-without-preload-expected.png:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.png:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-display-toggle-expected.png:
- platform/gtk/media/video-display-toggle-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.png:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-volume-slider-expected.png:
- platform/gtk/media/video-volume-slider-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.png:
- platform/gtk/media/video-zoom-controls-expected.txt:
Rebaseline.
- 12:42 AM Changeset in webkit [164023] by
-
- 2 edits in trunk/Tools
Unreviewed. Moved myself to the list of reviewers.
- Scripts/webkitpy/common/config/contributors.json:
- 12:39 AM Changeset in webkit [164022] by
-
- 5 edits in trunk/Source
Versioning.
- 12:36 AM Changeset in webkit [164021] by
-
- 2 edits in trunk/Tools
Speculative build fix after r163998.
- DumpRenderTree/ios/PerlSupport/Makefile:
- 12:36 AM Changeset in webkit [164020] by
-
- 1 copy in tags/Safari-538.18
New tag.
