Timeline
Aug 4, 2014:
- 10:09 PM Changeset in webkit [172027] by
-
- 5 edits in trunk
AX: Select activity behavior does not work when an existing range is already selected
https://bugs.webkit.org/show_bug.cgi?id=135579
Reviewed by Mario Sanchez Prada.
Source/WebCore:
If you have an existing range selected, and try to apply a select and replace operation, like capitalize,
searching for that range will fail because it skips the currently selected range.
For these cases, it seems the best way is to start the search from the start position, rather than relying on the
entire range.
Updated existing test: platform/mac/accessibility/select-text.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
LayoutTests:
- platform/mac/accessibility/select-text-expected.txt:
- platform/mac/accessibility/select-text.html:
- 8:58 PM Changeset in webkit [172026] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Seeking past buffered range will not resume playback when seek completes.
https://bugs.webkit.org/show_bug.cgi?id=135591
Reviewed by Eric Carlson.
If a seek is delayed due to seeking into an unbuffered area, playback will not be restarted
at that point. Instead, playback must resume when enough media data has been added, and
the MediaSource indicates the seek should complete.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted):
- 8:57 PM Changeset in webkit [172025] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Videos will report a stall when within 1 frame-duration before the end of a movie.
https://bugs.webkit.org/show_bug.cgi?id=135586
Reviewed by Eric Carlson.
Under certain circumstances, videos which are within 1/24 seconds before the end of a media stream when
monitorSourceBuffers() is called will fail the hasFutureTime() check. This is because hasFutureTime()
checks whether enough media is buffered to play back at least some time in the future, but when the
current time is close to the duration, not enough data is buffered to satisfy that check.
Add some logic which will break out early when the SourceBuffer has buffered up to and including the
media's duration, and return that the buffer indeed hasFutureTime() available.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::hasFutureTime):
- 8:40 PM Changeset in webkit [172024] by
-
- 5 edits2 adds in trunk
Simplify the StyleInvalidation mode of rule collection
https://bugs.webkit.org/show_bug.cgi?id=135521
Reviewed by Antti Koivisto.
Source/WebCore:
There are two branches where StyleInvalidation code is removed:
-Pseudo elements for shadow dom elements.
-Pseudo elements without dom tree counterpart.
The first can never be hit because StyleInvalidationAnalysis does a complete invalidation
when there is any shadow dom styling involved in the stylesheets.
Even if that branch was hit, not failing on custom pseudo elements would be equivalent
to ignoring those pseudo elements from the Selector. By doing so, we would match elements
that do not have shadow dom and invalidate pretty much everything.
Unlike pseudo elements without real elements, shadow dom elements are not matched separately with a different
context, thus we could generalize StyleInvalidationAnalysis to handle this case.
The second case handle pseudo elements that do not have a real element. That case no longer need to be handled
separately at the filter time, it has become a special case of SelectorChecker::match() after everything else
has matched.
The only condition for this to work is that the Context's pseudoId must be NOPSEUDO. This is the case
in practice since matching specific pseudo types would be a waste of time. ElementRuleCollector::collectMatchingRules()
has a new assertion to enforce that.
Test: fast/css/stylesheet-change-updates-pseudo-elements.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
LayoutTests:
This test by:
1) Forcing the recalc of the user-agent stylesheet.
2) Wait for the page to finish loading.
3) Add a style changing only pseudo elements without corresponding shadow element.
- fast/css/stylesheet-change-updates-pseudo-elements-expected.html: Added.
- fast/css/stylesheet-change-updates-pseudo-elements.html: Added.
- 8:25 PM Changeset in webkit [172023] by
-
- 15 edits in trunk
Add a flag for the CSS Selectors level 4 implementation
https://bugs.webkit.org/show_bug.cgi?id=135535
Reviewed by Andreas Kling.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- 7:51 PM Changeset in webkit [172022] by
-
- 2 edits in trunk/Tools
[GTK] run-launcher --gtk is broken
https://bugs.webkit.org/show_bug.cgi?id=135571
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-04
Reviewed by Martin Robinson.
- Scripts/webkitdirs.pm:
(builtDylibPathForName): Search for libwebkit2gtk-4.0
- 7:47 PM Changeset in webkit [172021] by
-
- 3 edits in trunk/Source/WebCore
AX: add AccessibilityObject::computedLabelString() for WebAXI
https://bugs.webkit.org/show_bug.cgi?id=129939
Reviewed by Mario Sanchez Prada.
Provide a method that the WebKit Inspector can call in order to
display an accessible name for an AX node.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityComputedLabel):
- accessibility/AccessibilityObject.h:
- 7:01 PM Changeset in webkit [172020] by
-
- 5 edits in tags/Safari-600.1.2.6/Source
Versioning.
- 6:54 PM Changeset in webkit [172019] by
-
- 6 edits in tags/Safari-600.1.2.6
Apply custom patch from https://bugs.webkit.org/show_bug.cgi?id=135543
- 6:39 PM Changeset in webkit [172018] by
-
- 2 edits in trunk/Source/WebCore
Lots of crashes in WebKit1 after r172013.
https://bugs.webkit.org/show_bug.cgi?id=135582
<rdar://problem/17837636>
Reviewed by Enrica Casucci.
- editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::addRect):
(WebCore::SelectionRectGatherer::addGapRects):
Don't try to do local-to-absolute coordinate conversion if we don't have
a repaint container, which happens a lot in WebKit1.
- 6:31 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 6:28 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 6:22 PM Changeset in webkit [172017] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures after 172008 and r172010.
Remove expectations for test that now pass after r171964 (revert of r171957).
Update expectations for new flaky tests.
- 6:04 PM Changeset in webkit [172016] by
-
- 4 edits in trunk/Source
Check for null frame when processing geolocation authorization request
https://bugs.webkit.org/show_bug.cgi?id=135577
<rdar://problem/17896295>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-04
Reviewed by Geoffrey Garen.
Source/WebKit/mac:
- WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::requestPermission):
Source/WebKit2:
I could have put the null check in GeolocationController instead of the WebKit layer,
but that would be a little weird as GeolocationController knows nothing about how
the WebKit layer decides what to do with requests.
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
- 5:58 PM Changeset in webkit [172015] by
-
- 1 copy in tags/Safari-600.1.2.6
New Tag.
- 5:30 PM Changeset in webkit [172014] by
-
- 8 edits3 adds in trunk
Progress towards CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=135528
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsMac.cmake:
Made options list based on FeatureDefines.xcconfig files.
Source/JavaScriptCore:
- CMakeLists.txt:
Include necessary directories and copy all necessary forwarding headers.
Only compile UDis86Disassembler.cpp if we're using UDIS86.
- PlatformMac.cmake: Added.
- tools/CodeProfiling.cpp:
Compile fix. Include sys/time.h on darwin, too.
Source/WebCore:
- PlatformMac.cmake: Added.
Source/WTF:
- wtf/CMakeLists.txt:
Include text directory.
- wtf/PlatformMac.cmake: Added.
- 5:28 PM Changeset in webkit [172013] by
-
- 4 edits in trunk/Source/WebCore
Selection services menu dropdown is in the wrong place when selecting some text on Yelp
https://bugs.webkit.org/show_bug.cgi?id=135582
<rdar://problem/17837636>
Reviewed by Simon Fraser.
- editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::addRect):
(WebCore::SelectionRectGatherer::addGapRects):
(WebCore::SelectionRectGatherer::addRects): Deleted.
Rename addRects to addGapRects for clarity.
Map rects and gapRects to absolute RenderView coordinates so that
they are in a form WebKit2 can use. Previously they were sometimes
relative to a different repaint container, but that information was
lost when moving through SelectionRectGatherer.
Ideally we would keep selection rects as full quads instead of rects
for more of their life, but that problem is much deeper than just SelectionRectGatherer.
- editing/SelectionRectGatherer.h:
Add a comment clarifying the coordinate space of the stored selection rects.
- rendering/RenderView.cpp:
(WebCore::RenderView::applySubtreeSelection):
Rename addRects to addGapRects for clarity.
- 4:06 PM Changeset in webkit [172012] by
-
- 2 edits in trunk/Tools
lldb_webkit.py throws exception when generating summary of null StringImpl
https://bugs.webkit.org/show_bug.cgi?id=129448
Patch by Matt Baker <Matt Baker> on 2014-08-04
Reviewed by Jer Noble.
Added checks for null StringImpl and 0 byte ReadMemory calls.
- lldb/lldb_webkit.py:
(WTFStringImpl_SummaryProvider):
(ustring_to_string):
(lstring_to_string):
(WTFStringImplProvider.to_string):
(WTFStringImplProvider.is_initialized):
- 3:25 PM Changeset in webkit [172011] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 3:17 PM Changeset in webkit [172010] by
-
- 3 edits3 adds in trunk
[CSS Shapes] shape-margin not respected when it extends beyond an explicitly set margin
https://bugs.webkit.org/show_bug.cgi?id=135308
Reviewed by Dean Jackson.
Source/WebCore:
When a zero height line is supplied and the image shape extends into
the margin box (only possible when a shape-margin is supplied), then
only an empty interval was being returned. This patch makes it
properly return the interval for the line in question.
Test: fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::getExcludedIntervals): Handle the zero height
line case.
LayoutTests:
Test case based on the one supplied by Rebecca Hauck in the bug
report.
- fast/shapes/resources/square.png: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html: Added.
- 3:04 PM Changeset in webkit [172009] by
-
- 4 edits in trunk/Source/JavaScriptCore
Create a more generic way for VMEntryScope to notify those interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358
Patch by Saam Barati <sbarati@apple.com> on 2014-08-04
Reviewed by Geoffrey Garen.
When VMEntryScope is destroyed, and it has a flag set indicating that the
Debugger needs to recompile all functions, it calls Debugger::recompileAllJSFunctions.
This flag is only used by Debugger to have VMEntryScope notify it when the
Debugger is safe to recompile all functions. This patch will substitute this
Debugger-specific recompilation flag with a list of callbacks that are notified
when the outermost VMEntryScope dies. This creates a general purpose interface
for being notified when the VM stops executing code via the event of the outermost
VMEntryScope dying.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::addEntryScopeDidPopListener):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
(JSC::VMEntryScope::setRecompilationNeeded): Deleted.
- 3:01 PM Changeset in webkit [172008] by
-
- 7 edits2 adds in trunk
Subpixel rendering: InlineTextBox mistakenly rounds offset value before painting.
https://bugs.webkit.org/show_bug.cgi?id=135470
Reviewed by Simon Fraser.
This patch removes the premature paint offset adjustment for inlines. Premature snapping
could alter the final painting coordinates and push content to wrong positions.
This patch also enforces WebCore's pixel snapping strategy (round) on text painting.
It ensures that text positioning is in sync with other painting related operations including
clipping, box decorations etc. Underlying graphics libraries can take different directions on
text snapping, for example CG ceils text coordinates vertically (in horizontal context,
with the current settings). It can lead to undesired side effects.
Source/WebCore:
Test: fast/inline/hidpi-inline-selection-leaves-gap.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects): wrong direction used at r171896.
- rendering/SimpleLineLayoutFunctions.cpp: we don't paint vertical content here.
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
- fast/inline/hidpi-inline-selection-leaves-gap-expected.html: Added.
- fast/inline/hidpi-inline-selection-leaves-gap.html: Added.
- fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html:
- fast/multicol/newmulticol/multicol-clip-rounded-corners.html: pixels are distributed properly.
No need to have the special 122px shortened width for col2.
- 2:58 PM Changeset in webkit [172007] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r171992, r171995, & r172000.
The cumulative effect of those revisions was to cause decoding errors when switching resolutions on YouTube.
Reverted changesets:
https://bugs.webkit.org/show_bug.cgi?id=135422 / http://trac.webkit.org/changeset/171992
https://bugs.webkit.org/show_bug.cgi?id=135424 / http://trac.webkit.org/changeset/171995
https://bugs.webkit.org/show_bug.cgi?id=135572 / http://trac.webkit.org/changeset/172000
- 2:57 PM Changeset in webkit [172006] by
-
- 2 edits in trunk/Source/WebCore
Always clear ConsoleClient when Page/WindowShell is destroyed
https://bugs.webkit.org/show_bug.cgi?id=135569
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-04
Reviewed by Mark Lam.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
Whenever a window shell goes away, clear the console client.
We did this in clearWindowShell but not before destroying.
- 2:56 PM Changeset in webkit [172005] by
-
- 5 edits in trunk
AX: isWordEndMatch should allow for multiple word selections
https://bugs.webkit.org/show_bug.cgi?id=135573
Reviewed by Mario Sanchez Prada.
Source/WebCore:
isWordEndMatch was searching from the beginning of the selected range, which meant
that if the result was multiple words, we'd reject the result.
Instead, we should search from the end of the range, so that we encompass all words.
Modified existing test: platform/mac/accessibility/select-text-should-match-whole-words.html
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::isWordEndMatch):
LayoutTests:
- platform/mac/accessibility/select-text-should-match-whole-words-expected.txt:
- platform/mac/accessibility/select-text-should-match-whole-words.html:
- 2:25 PM Changeset in webkit [172004] by
-
- 1 delete in tags/Safari-600.1.2.5/safari-600.1.4-branch
Delete incorrect Tag.
- 2:18 PM Changeset in webkit [172003] by
-
- 1 copy in tags/Safari-600.1.4.5
New Tag.
- 2:17 PM Changeset in webkit [172002] by
-
- 3 edits2 adds in trunk
AX: Secure text fields need to support Search parameterized attributes
https://bugs.webkit.org/show_bug.cgi?id=135568
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Secure text fields still need to support the fast searching that WebKit exposes, even though they don't support
other parameterized attributes.
Test: platform/mac/accessibility/secure-text-field-supports-fast-search.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
LayoutTests:
- platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt: Added.
- platform/mac/accessibility/secure-text-field-supports-fast-search.html: Added.
- 2:13 PM Changeset in webkit [172001] by
-
- 1 copy in tags/Safari-600.1.2.5/safari-600.1.4-branch
New Tag.
- 1:54 PM Changeset in webkit [172000] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Further fixes for "fast forward" playback after seeking in YouTube behavior.
https://bugs.webkit.org/show_bug.cgi?id=135572
Reviewed by Eric Carlson.
Two related fixes:
In reenqueueMediaForTime(), update TrackBuffer.lastEnqueuedPresentationTime when we flush samples, so that
the next time samples are re-enqueued, the starting point for re-enqueueing is correct.
In sourceBufferPrivateDidReceiveSample(), do not add samples to the decode queue if they are before the
current media time.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::reenqueueMediaForTime):
- 1:50 PM Changeset in webkit [171999] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: All-caps CSS properties are not shown in Computed pane
https://bugs.webkit.org/show_bug.cgi?id=133700
Patch by Matt Baker <Matt Baker> on 2014-08-04
Reviewed by Timothy Hatcher.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
- 1:32 PM Changeset in webkit [171998] by
-
- 4 edits2 copies in branches/safari-600.1.4-branch
Merged r171882. <rdar://problem/17802531>
- 10:42 AM Changeset in webkit [171997] by
-
- 5 edits in trunk
AX: SelectText functionality always selects text after current selection even if closer selection is behind it
https://bugs.webkit.org/show_bug.cgi?id=135546
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Logic was incorrect for comparing ranges found before the current selection.
ASSERT was incorrect for allowed ranges. We need to allow ranges that are right at the boundaries of our found ranges.
Extended existing test: platform/mac/accessibility/select-text.html
- accessibility/AccessibilityObject.cpp:
(WebCore::rangeClosestToRange):
LayoutTests:
- platform/mac/accessibility/select-text-expected.txt:
- platform/mac/accessibility/select-text.html:
- 10:32 AM Changeset in webkit [171996] by
-
- 5 edits2 adds in trunk
AX: AXSelectTextWithCriteriaParameterizedAttribute incorrectly selects the beginning letters of a word
https://bugs.webkit.org/show_bug.cgi?id=135547
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Allow text search to specify that it wants to match end of words as well as start of words.
This allows select text criteria to match on whole words only.
Test: platform/mac/accessibility/select-text-should-match-whole-words.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
- editing/FindOptions.h:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::isWordEndMatch):
(WebCore::SearchBuffer::search):
LayoutTests:
- platform/mac/accessibility/select-text-should-match-whole-words-expected.txt: Added.
- platform/mac/accessibility/select-text-should-match-whole-words.html: Added.
- 10:26 AM Changeset in webkit [171995] by
-
- 3 edits in trunk/Source/WebCore
[MSE] Re-enqueing due to overlapping appended samples can cause stuttering playback
https://bugs.webkit.org/show_bug.cgi?id=135424
Reviewed by Eric Carlson.
If it become necessary to re-enqueue samples (due to appending overlapping samples which cause
existing samples to be removed), the previous behavior was to flush and re-enqueue the new
samples dependencies; i.e., everything up to and including the previous sync sample. This causes
the decoder to visibly stall while it decodes those non-displaying samples, which could be
a second or more worth of encoded video samples, depending on the frequency of sync samples.
Instead, when we are asked to re-enqueue, we will look for the next occurring sync sample.
If found, we can switch over to the replacement samples at that point in the decode queue.
This limits the overhead of a stream switch, and should allow for a visually seamless switch,
at the cost of having to wait for the next sync sample to occur to affect the switch.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::seekToTime): Clear the decode queue when seeking.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Call reenqueueMediaForCurrentTime.
(WebCore::SourceBuffer::reenqueueMediaForCurrentTime): Switch over to the new stream only
at the next sync sample.
- 10:23 AM Changeset in webkit [171994] by
-
- 3 edits2 adds in trunk
AX: The Dictation command "Replace <phrase> with <phrase>" always capitalizes the replacement string
https://bugs.webkit.org/show_bug.cgi?id=135557
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When replacing text, we should match the capitalization of the word being replaced
(unless the replacement looks like an abbreviation).
Test: platform/mac/accessibility/find-and-replace-match-capitalization.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
LayoutTests:
- platform/mac/accessibility/find-and-replace-match-capitalization-expected.txt: Added.
- platform/mac/accessibility/find-and-replace-match-capitalization.html: Added.
- 10:19 AM Changeset in webkit [171993] by
-
- 5 edits in trunk/Source/WebCore
QuickLook resources are cache-replaced with their original binary data causing ASSERT(m_data->size() == newBuffer->size()) in CachedResource.cpp
https://bugs.webkit.org/show_bug.cgi?id=135548
<rdar://problem/17891321>
Reviewed by David Kilzer.
When loading QuickLook resources, the SharedBuffer in the CachedResource is actually a
converted representation of the real QuickLook resource. Replacing this with the actual
network resource (which is what tryReplaceEncodedData() tried to do) is wrong and triggered
asserts in the code.
Fix this by having CachedRawResource::mayTryReplaceEncodedData() return false if we are
loading a QuickLook resource.
No new tests because we don't have a way to test QuickLook documents.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::didCreateQuickLookHandle):
Set a flag to indicate that we are loading a QuickLook document.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::isQuickLookResource):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::finishLoading):
Check if we were loading a QuickLook document and if so disable encoded data
replacement.
- loader/cache/CachedRawResource.h:
Add a new bool field returned by mayTryReplaceEncodedData(). Default is true but it is
set to false in finishLoading() if we were loading QuickLook document.
- 10:17 AM Changeset in webkit [171992] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Seeking occasionally causes many frames to be displayed in "fast forward" mode
https://bugs.webkit.org/show_bug.cgi?id=135422
Reviewed by Eric Carlson.
When a seek is pending, but samples for the new time is not yet present in the SourceBuffer,
the SourceBufferPrivate may signal that it's ready for new samples through the
sourceBufferPrivateDidBecomeReadyForMoreSamples() method. In this situation, we should not
continue to provideMediaData(), as that will append samples from the prior-to-seeking media
timeline. Since the timeline may have moved forward due to the seek, a decoder may decide to
display those frames as quickly as possible (the "fast forward" behavior) in order to catch
up to the new current time.
If a re-enqueue is pending, don't provide media data in response to being notified that the
SourceBufferPrivate is ready for more samples. Wait until samples for the new current time
are appended.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidBecomeReadyForMoreSamples):
- dom/Document.cpp:
(WebCore::Document::unregisterCollection):
- 8:08 AM Changeset in webkit [171991] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Install all unstable webkitdom headers
https://bugs.webkit.org/show_bug.cgi?id=135544
Reviewed by Gustavo Noronha Silva.
We were checking whether generated file existed before they had
been generated.
- PlatformGTK.cmake: Add Unstable.h header for all stable classes
to GObjectDOMBindingsUnstable_INSTALLED_HEADERS and split the
install command for stable and unstable headers making unstable
headers optional.
- 6:31 AM Changeset in webkit [171990] by
-
- 6 edits6 adds in trunk/LayoutTests
Unreviewed EFL gardening
- platform/efl/TestExpectations: Add or update test expectations for failing tests.
- platform/efl/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/efl/js/dom/global-constructors-attributes-expected.txt: Rebaseline after r167632.
- platform/efl/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
- platform/efl/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
- platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Rebaseline after r168350 and r168543.
- platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Ditto.
- platform/efl/transforms/2d/hindi-rotated-expected.txt: Fix baseline.
- 1:47 AM Changeset in webkit [171989] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error in OpenTypeMathData.cpp.
https://bugs.webkit.org/show_bug.cgi?id=135541
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-08-04
Reviewed by Brent Fulgham.
The SharedBuffer class needs to be defined.
Also, the OpenTypeMathData constructor should be implemented when OPENTYPE_MATH is not enabled.
- platform/graphics/opentype/OpenTypeMathData.cpp:
- 12:17 AM Changeset in webkit [171988] by
-
- 2 edits in trunk
[GTK] Windowing target support should reflect the support in the GTK+ dependency
https://bugs.webkit.org/show_bug.cgi?id=134736
Reviewed by Martin Robinson.
- Source/cmake/FindGTK3.cmake: Don't error out if the GTK+ dependency doesn't
support the X11 or Wayland windowing targets -- instead, if there's no support
the specific target is disabled, and an error is thrown only if neither of the
backends is enabled at the end..
For now the X11 target remains enabled by default, and the Wayland target is
kept disabled. Once it's possible to have both targets enabled at runtime in
WebKit, the Wayland target will be enabled as well and we'll leave it to the
GTK+ dependency to determine which targets can be enabled.
- 12:10 AM Changeset in webkit [171987] by
-
- 1 edit1 add in trunk
[CMake] Add FindWayland.cmake
https://bugs.webkit.org/show_bug.cgi?id=135540
Reviewed by Martin Robinson.
- Source/cmake/FindWayland.cmake: Added. Enables finding the Wayland
dependency. For now bundles the wayland-client, wayland-server and
wayland-egl pkg-config targets into one dependency, but these could
be split in the future if necessary.
- 12:00 AM Changeset in webkit [171986] by
-
- 2 edits in trunk/Tools
[GTK] Do not include JavaScriptCore stress tests in release tarballs
https://bugs.webkit.org/show_bug.cgi?id=135503
Reviewed by Martin Robinson.
- gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
Aug 3, 2014:
- 7:12 PM Changeset in webkit [171985] by
-
- 2 edits in trunk
[EFL] Move DATA_INSTALL_DIR to ewebkit2-0
https://bugs.webkit.org/show_bug.cgi?id=135553
Reviewed by Gyuyoung Kim.
Since WebKit1/Efl is dropped, we don't need to use ewebkit-1 and ewebkit2-1.
And removed WebKit_OUTPUT_NAME variable which is not used anymore on the EFL port.
- Source/cmake/OptionsEfl.cmake:
- 12:21 PM Changeset in webkit [171984] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/17782529> REGRESSION: OS marketing version in iOS Simulator user-agent string is the host OS’s
https://bugs.webkit.org/show_bug.cgi?id=135549
Reviewed by Mark Rowe.
- platform/cocoa/SystemVersion.mm:
(WebCore::createSystemMarketingVersion): On the iOS Simulator, locate the system Library
directory relative to the Simulator root.
- 1:16 AM Changeset in webkit [171983] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 1:12 AM Changeset in webkit [171982] by
-
- 1 copy in tags/Safari-600.1.4.4
New tag.
- 1:03 AM Changeset in webkit [171981] by
-
- 2 edits1 add in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merged patch for <rdar://problem/17887398>.
- 12:56 AM Changeset in webkit [171980] by
-
- 12 edits in branches/safari-600.1.4-branch/Source
Merged r171973. <rdar://problem/17834694>
- 12:45 AM Changeset in webkit [171979] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merged r171959. <rdar://problem/17671574>
- 12:43 AM Changeset in webkit [171978] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merged r171949. <rdar://problem/17888408>
- 12:40 AM Changeset in webkit [171977] by
-
- 5 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore
Merged r171946. <rdar://problem/17888408>
- 12:37 AM Changeset in webkit [171976] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merged r171944. <rdar://problem/17879156>
- 12:34 AM Changeset in webkit [171975] by
-
- 9 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merged r171943. <rdar://problem/17869279>
- 12:28 AM Changeset in webkit [171974] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merged r171887. <rdar://problem/17864139>
