Timeline
Jan 13, 2015:
- 11:29 PM Changeset in webkit [178410] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix build after r178390
https://bugs.webkit.org/show_bug.cgi?id=140424
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-13
Reviewed by Csaba Osztrogonác.
- CMakeLists.txt:
- 10:58 PM Changeset in webkit [178409] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r178375.
uint64_t navigationID -> API::Navigation*.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
- 10:08 PM Changeset in webkit [178408] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r178375.
WebFrameProxy is now a reference instead of a pointer.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
- 9:04 PM Changeset in webkit [178407] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Refactor TextFragment class.
https://bugs.webkit.org/show_bug.cgi?id=140417
Reviewed by Andreas Kling.
Introduce text fragment type and use class member initializers.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
- 9:01 PM Changeset in webkit [178406] by
-
- 2 edits in trunk/Tools
Fix TestWTF failed in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=140333
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-13
Reviewed by Sam Weinig.
Clear the std::ostringstream before starting test.
- TestWebKitAPI/Tests/WTF/RefLogger.h:
(TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
- 8:38 PM Changeset in webkit [178405] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed test gardening.
- platform/win/TestExpectations: Add Debug Crash documentation now that Bug 140425 has been filed.
- 7:39 PM Changeset in webkit [178404] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TextEditor doesn't update when resizing console, white space instead of content
https://bugs.webkit.org/show_bug.cgi?id=140240
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-13
Reviewed by Timothy Hatcher.
- UserInterface/Base/Main.js:
(WebInspector._consoleResizerMouseDown.dockedResizerDrag):
Dispatch the event that signals the console has changed size.
- 7:35 PM Changeset in webkit [178403] by
-
- 2 edits in trunk/LayoutTests
Only throttle DOM timers if they change CSS properties that cannot cause non-descendant elements to become visible
https://bugs.webkit.org/show_bug.cgi?id=140142
Reviewed by Daniel Bates.
Fix layout test introduced in r178014. I forgot to remove a
setTimeout() call.
- fast/dom/timer-height-change-no-throttling.html:
- 7:15 PM Changeset in webkit [178402] by
-
- 2 edits in trunk/LayoutTests
[Unreviewed] Skip webgl tests for temporarily.
https://bugs.webkit.org/show_bug.cgi?id=140423
- platform/mac/TestExpectations:
- 7:10 PM Changeset in webkit [178401] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r178400.
https://bugs.webkit.org/show_bug.cgi?id=140422
Test fix breaks build (Requested by rfong on #webkit).
Reverted changeset:
"[Unreviewed] Speculative test fix after r178390."
http://trac.webkit.org/changeset/178400
- 6:25 PM Changeset in webkit [178400] by
-
- 2 edits in trunk/Source/WebCore
[Unreviewed] Speculative test fix after r178390.
- html/canvas/WebGL1RenderingContext.idl:
- 6:18 PM Changeset in webkit [178399] by
-
- 5 edits2 copies in trunk/LayoutTests
Filters aren't applied to elements in columns after the first
https://bugs.webkit.org/show_bug.cgi?id=140331
<rdar://problem/19313858>
Unreviewed followup after discussion with Simon Fraser.
Add a new test that exercises nested blocks inside columns. Also
use valid properties in my existing tests :)
- fast/multicol/clip-in-columns-expected.html:
- fast/multicol/clip-in-columns.html:
- fast/multicol/filter-in-columns-expected.html:
- fast/multicol/filter-in-columns.html:
- fast/multicol/nested-filter-in-columns-expected.html: Copied from LayoutTests/fast/multicol/filter-in-columns-expected.html.
- fast/multicol/nested-filter-in-columns.html: Copied from LayoutTests/fast/multicol/filter-in-columns.html.
- 5:55 PM Changeset in webkit [178398] by
-
- 6 edits in trunk/Source/WebCore
[Unreviewed] Windows build fix after r178390.
- DerivedSources.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSBindingsAllInOne.cpp:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
- 5:34 PM Changeset in webkit [178397] by
-
- 2 edits in trunk/Source/WebCore
NSButtonCell leak allocated under WebCore::paintToggleButton
https://bugs.webkit.org/show_bug.cgi?id=137014
Reviewed by Alexey Proskuryakov.
- platform/mac/ThemeMac.mm:
(WebCore::createToggleButtonCell):
Immediately adopt the NSButtonCell allocation.
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):
Move from the RetainPtr into the static variable.
(WebCore::paintToggleButton):
Use RetainPtr logic to better manage lifetimes.
- 5:33 PM Changeset in webkit [178396] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Refactor SimpleLineLayout::nextFragment().
https://bugs.webkit.org/show_bug.cgi?id=140407
Reviewed by Andreas Kling.
Simplify the code by using content specific branches with early returns.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::nextFragment):
- 5:30 PM Changeset in webkit [178395] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r178375.
WebPageProxy is now a reference instead of a pointer.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
- 5:05 PM Changeset in webkit [178394] by
-
- 3 edits in trunk/Source/WebKit/ios
Unreviewed iOS build fix after r178375
Match FontSelector API changes.
- Misc/EmojiFallbackFontSelector.cpp:
(EmojiFallbackFontSelector::fallbackFontDataAt):
(EmojiFallbackFontSelector::getFallbackFontData): Deleted.
- Misc/EmojiFallbackFontSelector.h:
- 4:45 PM Changeset in webkit [178393] by
-
- 5 edits in trunk/Source/WebKit2
Fill in more of WebProcessLifetimeTracker
https://bugs.webkit.org/show_bug.cgi?id=140418
Reviewed by Andreas Kling.
- UIProcess/WebProcessLifetimeObserver.cpp:
(WebKit::WebProcessLifetimeObserver::WebProcessLifetimeObserver):
(WebKit::WebProcessLifetimeObserver::~WebProcessLifetimeObserver):
(WebKit::WebProcessLifetimeObserver::addWebPage):
(WebKit::WebProcessLifetimeObserver::removeWebPage):
- UIProcess/WebProcessLifetimeObserver.h:
- UIProcess/WebProcessLifetimeTracker.cpp:
(WebKit::WebProcessLifetimeTracker::WebProcessLifetimeTracker):
(WebKit::WebProcessLifetimeTracker::addObserver):
(WebKit::WebProcessLifetimeTracker::connectionWillOpen):
(WebKit::WebProcessLifetimeTracker::connectionWillClose):
(WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
(WebKit::WebProcessLifetimeTracker::processIsRunning):
- UIProcess/WebProcessLifetimeTracker.h:
- 4:44 PM Changeset in webkit [178392] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed iOS build fix after r178390.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
m_type is undeclared.
- html/canvas/WebGLContextGroup.h:
Fix bad include.
- 4:33 PM Changeset in webkit [178391] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed iOS build fix after r178375.
LoaderClient::didLayout() now takes a reference to the WebPageProxy
instead of a pointer.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
- 4:33 PM Changeset in webkit [178390] by
-
- 77 edits4 moves8 adds in trunk/Source/WebCore
WebGL2: Support webgl2 context creation.
https://bugs.webkit.org/show_bug.cgi?id=126408
<rdar://problem/15002170>
Reviewed by Dean Jackson.
Tests covered by existing Khronos tests for WebGL 1.0 conformance.
Create a WebGLRenderingContextBase class that extends to a WebGL1RenderingContext and WebGL2RenderingContext.
Replace all previous instances of WebGLRenderingContext usages with WebGLRenderingContextBase usages for now.
As the first step, the WebGL1 and WebGL2 contexts will have the exact same functionality.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/js/JSWebGL1RenderingContextCustom.cpp: Copied from Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp.
- bindings/js/JSWebGL2RenderingContextCustom.cpp: Added.
(WebCore::JSWebGL2RenderingContext::visitAdditionalChildren):
- bindings/js/JSWebGLRenderingContextBaseCustom.cpp: Added.
- bindings/js/JSWebGLRenderingContextCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::is3dType):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::getImageData):
- html/canvas/ANGLEInstancedArrays.cpp:
(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):
(WebCore::ANGLEInstancedArrays::supported):
- html/canvas/ANGLEInstancedArrays.h:
- html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::type):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
- html/canvas/EXTBlendMinMax.cpp:
(WebCore::EXTBlendMinMax::EXTBlendMinMax):
- html/canvas/EXTBlendMinMax.h:
- html/canvas/EXTFragDepth.cpp:
(WebCore::EXTFragDepth::EXTFragDepth):
- html/canvas/EXTFragDepth.h:
- html/canvas/EXTShaderTextureLOD.cpp:
(WebCore::EXTShaderTextureLOD::EXTShaderTextureLOD):
- html/canvas/EXTShaderTextureLOD.h:
- html/canvas/EXTTextureFilterAnisotropic.cpp:
(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):
- html/canvas/EXTTextureFilterAnisotropic.h:
- html/canvas/EXTsRGB.cpp:
(WebCore::EXTsRGB::EXTsRGB):
- html/canvas/EXTsRGB.h:
- html/canvas/OESElementIndexUint.cpp:
(WebCore::OESElementIndexUint::OESElementIndexUint):
- html/canvas/OESElementIndexUint.h:
- html/canvas/OESStandardDerivatives.cpp:
(WebCore::OESStandardDerivatives::OESStandardDerivatives):
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESTextureFloat.cpp:
(WebCore::OESTextureFloat::OESTextureFloat):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureFloatLinear.cpp:
(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):
- html/canvas/OESTextureFloatLinear.h:
- html/canvas/OESTextureHalfFloat.cpp:
(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
- html/canvas/OESTextureHalfFloat.h:
- html/canvas/OESTextureHalfFloatLinear.cpp:
(WebCore::OESTextureHalfFloatLinear::OESTextureHalfFloatLinear):
- html/canvas/OESTextureHalfFloatLinear.h:
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::OESVertexArrayObject):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGL1RenderingContext.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.cpp.
- html/canvas/WebGL1RenderingContext.h: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.h.
- html/canvas/WebGL1RenderingContext.idl: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.idl.
- html/canvas/WebGL2RenderingContext.cpp: Added.
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):
- html/canvas/WebGL2RenderingContext.h: Added.
- html/canvas/WebGL2RenderingContext.idl: Added.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::create):
(WebCore::WebGLBuffer::WebGLBuffer):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLCompressedTextureATC.cpp:
(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::supported):
- html/canvas/WebGLCompressedTextureATC.h:
- html/canvas/WebGLCompressedTexturePVRTC.cpp:
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::supported):
- html/canvas/WebGLCompressedTexturePVRTC.h:
- html/canvas/WebGLCompressedTextureS3TC.cpp:
(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::supported):
- html/canvas/WebGLCompressedTextureS3TC.h:
- html/canvas/WebGLContextGroup.cpp:
(WebCore::WebGLContextGroup::getAGraphicsContext3D):
(WebCore::WebGLContextGroup::addContext):
(WebCore::WebGLContextGroup::removeContext):
(WebCore::WebGLContextGroup::loseContextGroup):
- html/canvas/WebGLContextGroup.h:
- html/canvas/WebGLContextObject.cpp:
(WebCore::WebGLContextObject::WebGLContextObject):
- html/canvas/WebGLContextObject.h:
(WebCore::WebGLContextObject::context):
- html/canvas/WebGLDebugRendererInfo.cpp:
(WebCore::WebGLDebugRendererInfo::WebGLDebugRendererInfo):
- html/canvas/WebGLDebugRendererInfo.h:
- html/canvas/WebGLDebugShaders.cpp:
(WebCore::WebGLDebugShaders::WebGLDebugShaders):
- html/canvas/WebGLDebugShaders.h:
- html/canvas/WebGLDepthTexture.cpp:
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
- html/canvas/WebGLDepthTexture.h:
- html/canvas/WebGLDrawBuffers.cpp:
(WebCore::WebGLDrawBuffers::WebGLDrawBuffers):
(WebCore::WebGLDrawBuffers::supported):
(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):
- html/canvas/WebGLDrawBuffers.h:
- html/canvas/WebGLExtension.cpp:
(WebCore::WebGLExtension::WebGLExtension):
- html/canvas/WebGLExtension.h:
(WebCore::WebGLExtension::context):
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::create):
(WebCore::WebGLFramebuffer::WebGLFramebuffer):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLLoseContext.cpp:
(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::loseContext):
- html/canvas/WebGLLoseContext.h:
- html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::WebGLObject):
- html/canvas/WebGLObject.h:
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::create):
(WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLRenderbuffer.cpp:
(WebCore::WebGLRenderbuffer::create):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderingContext.cpp: Removed.
- html/canvas/WebGLRenderingContext.h: Removed.
- html/canvas/WebGLRenderingContext.idl: Removed.
- html/canvas/WebGLRenderingContextBase.cpp: Added.
- html/canvas/WebGLRenderingContextBase.h: Added.
- html/canvas/WebGLRenderingContextBase.idl: Added.
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::create):
(WebCore::WebGLShader::WebGLShader):
- html/canvas/WebGLShader.h:
- html/canvas/WebGLSharedObject.cpp:
(WebCore::WebGLSharedObject::WebGLSharedObject):
- html/canvas/WebGLSharedObject.h:
- html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::create):
(WebCore::WebGLTexture::WebGLTexture):
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLVertexArrayObjectOES.cpp:
(WebCore::WebGLVertexArrayObjectOES::create):
(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
- html/canvas/WebGLVertexArrayObjectOES.h:
- 4:19 PM Changeset in webkit [178389] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix Mac build after r178388
FontRanges::isEmpty() -> FontRanges::isNull().
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
- 3:57 PM Changeset in webkit [178388] by
-
- 17 edits2 moves2 deletes in trunk/Source/WebCore
Devirtualize FontData
https://bugs.webkit.org/show_bug.cgi?id=140390
Reviewed by Andreas Kling.
This patch removes the FontData base class and turns SegmentedFontData into a non-virtual FontRanges type.
SimpleFontData remains as is (without the base) and it can be renamed later to something more sensible.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fontRangesForFamily):
(WebCore::CSSFontSelector::fallbackFontDataAt):
(WebCore::CSSFontSelector::getFontData): Deleted.
(WebCore::CSSFontSelector::getFallbackFontData): Deleted.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable):
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore::CSSSegmentedFontFace::fontRanges):
(WebCore::CSSSegmentedFontFace::loadFont):
(WebCore::CSSSegmentedFontFace::getFontData): Deleted.
- css/CSSSegmentedFontFace.h:
- platform/graphics/Font.h:
(WebCore::Font::fallbackRangesAt):
(WebCore::Font::fontDataAt): Deleted.
- platform/graphics/FontData.cpp: Removed.
- platform/graphics/FontData.h: Removed.
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::determinePitch):
(WebCore::FontGlyphs::isLoadingCustomFonts):
(WebCore::realizeNextFallback):
(WebCore::FontGlyphs::realizeFallbackRangesAt):
(WebCore::FontGlyphs::glyphDataForSystemFallback):
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForNormalVariant):
(WebCore::glyphPageFromFontRanges):
(WebCore::FontGlyphs::glyphDataForCharacter):
(WebCore::realizeNextFamily): Deleted.
(WebCore::FontGlyphs::realizeFontDataAt): Deleted.
(WebCore::glyphPageFromFontData): Deleted.
- platform/graphics/FontGlyphs.h:
(WebCore::FontGlyphs::primarySimpleFontData):
- platform/graphics/FontRanges.cpp: Copied from Source/WebCore/platform/graphics/SegmentedFontData.cpp.
(WebCore::FontRanges::FontRanges):
(WebCore::FontRanges::~FontRanges):
(WebCore::FontRanges::fontDataForCharacter):
(WebCore::FontRanges::fontDataForFirstRange):
(WebCore::FontRanges::isLoading):
(WebCore::SegmentedFontData::SegmentedFontData): Deleted.
(WebCore::SegmentedFontData::~SegmentedFontData): Deleted.
(WebCore::SegmentedFontData::simpleFontDataForCharacter): Deleted.
(WebCore::SegmentedFontData::simpleFontDataForFirstRange): Deleted.
(WebCore::SegmentedFontData::isCustomFont): Deleted.
(WebCore::SegmentedFontData::isLoading): Deleted.
(WebCore::SegmentedFontData::isSegmented): Deleted.
(WebCore::SegmentedFontData::description): Deleted.
- platform/graphics/FontRanges.h: Copied from Source/WebCore/platform/graphics/SegmentedFontData.h.
(WebCore::FontRanges::Range::Range):
(WebCore::FontRanges::Range::from):
(WebCore::FontRanges::Range::to):
(WebCore::FontRanges::Range::fontData):
(WebCore::FontRanges::isEmpty):
(WebCore::FontRanges::appendRange):
(WebCore::FontRanges::size):
(WebCore::FontRanges::rangeAt):
(WebCore::FontDataRange::FontDataRange): Deleted.
(WebCore::FontDataRange::from): Deleted.
(WebCore::FontDataRange::to): Deleted.
(WebCore::FontDataRange::fontData): Deleted.
(WebCore::SegmentedFontData::create): Deleted.
(WebCore::SegmentedFontData::appendRange): Deleted.
(WebCore::SegmentedFontData::numRanges): Deleted.
(WebCore::SegmentedFontData::rangeAt): Deleted.
(isType): Deleted.
- platform/graphics/FontSelector.h:
- platform/graphics/SegmentedFontData.cpp: Removed.
- platform/graphics/SegmentedFontData.h: Removed.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::simpleFontDataForCharacter): Deleted.
(WebCore::SimpleFontData::simpleFontDataForFirstRange): Deleted.
(WebCore::SimpleFontData::isSegmented): Deleted.
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::isCustomFont):
(WebCore::SimpleFontData::isLoading):
(isType): Deleted.
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(-[WebCascadeList initWithFont:character:]):
(-[WebCascadeList objectAtIndex:]):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
- 3:56 PM Changeset in webkit [178387] by
-
- 6 edits in trunk/Source/WebKit/mac
Temporarily reintroduce the informal delegate protocols
https://bugs.webkit.org/show_bug.cgi?id=140416
Reviewed by Dan Bernstein.
- WebView/WebEditingDelegate.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebResourceLoadDelegate.h:
- WebView/WebUIDelegate.h:
- 3:49 PM Changeset in webkit [178386] by
-
- 8 edits2 adds in trunk/LayoutTests
Missed images and missed new lines in the expected results of the imported w3c canvas layout tests.
https://bugs.webkit.org/show_bug.cgi?id=140409.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-01-13
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Fix some failures in the imported W3C canvas tests. These failures were happening because
of missing images or missing new lines at the end of the expected results.
- canvas/2d.pattern.paint.repeat.basic-expected.txt:
- canvas/2d.pattern.paint.repeat.outside-expected.txt:
- canvas/2d.pattern.paint.repeatx.basic-expected.txt:
- canvas/2d.pattern.paint.repeaty.basic-expected.txt:
- canvas/resources/background.png: Added.
- canvas/resources/green-16x16.png: Added.
- common/canvas-tests.css:
LayoutTests:
Fix some failures in the imported W3C canvas tests. These failures were happening because
of missing images or missing new lines at the end of the expected results.
- 3:35 PM Changeset in webkit [178385] by
-
- 7 edits in trunk/Source/WebKit2
Convert WebUserContentControllerProxy to an API::Object bridged to WKUserContentController
https://bugs.webkit.org/show_bug.cgi?id=140414
Reviewed by Dan Bernstein.
- Shared/API/APIObject.h:
Add Type::UserContentController.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Allocate WebUserContentControllerProxy using [WKUserContentController alloc].
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController init]):
(-[WKUserContentController dealloc]):
(-[WKUserContentController _apiObject]):
- UIProcess/API/Cocoa/WKUserContentControllerInternal.h:
(WebKit::wrapper):
Convert to using API::ObjectStorage for the internal WebUserContentControllerProxy.
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::create): Deleted.
- UIProcess/UserContent/WebUserContentControllerProxy.h:
Convert to inherit from API::ObjectImpl<> and remove create function.
- 3:35 PM Changeset in webkit [178384] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 3:32 PM Changeset in webkit [178383] by
-
- 5 edits in trunk/Source/WebKit2
Stub out more of the process lifetime tracker code
https://bugs.webkit.org/show_bug.cgi?id=140411
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::connectionWillOpen):
(WebKit::WebPageProxy::connectionWillClose):
- UIProcess/WebProcessLifetimeTracker.cpp:
(WebKit::WebProcessLifetimeTracker::connectionWillOpen):
(WebKit::WebProcessLifetimeTracker::connectionWillClose):
(WebKit::WebProcessLifetimeTracker::pageWasInvalidated):
- UIProcess/WebProcessLifetimeTracker.h:
- 3:28 PM Changeset in webkit [178382] by
-
- 1 copy in tags/Safari-600.1.17.6
New tag.
- 3:26 PM Changeset in webkit [178381] by
-
- 5 edits in branches/safari-600.1.17-branch/Source/JavaScriptCore
Merged r178364. <rdar://problem/19450807>
- 3:22 PM Changeset in webkit [178380] by
-
- 4 edits4 adds in trunk
Filters aren't applied to elements in columns after the first
https://bugs.webkit.org/show_bug.cgi?id=140331
Source/WebCore:
Reviewed by Simon Fraser.
The important bits of this change came from Simon.
Filters and clipping were not taking columns into
account when using their offset rectangles. The fix
is to recalculate the rects if you're in such a
situation.
Tests: fast/multicol/clip-in-columns.html
fast/multicol/filter-in-columns.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasFilterThatIsPainting): New method used
to check if we're about to paint a filter.
(WebCore::RenderLayer::setupFilters): Use the new helper if possible.
(WebCore::RenderLayer::paintLayerContents): If we're in columns,
and we either have a clip or a filter, recalculate the offset rectangles.
- rendering/RenderLayer.h:
LayoutTests:
<rdar://problem/19313858>
Reviewed by Simon Fraser.
Tests for filters and clipping on a column other
than the first.
- fast/multicol/clip-in-columns-expected.html: Added.
- fast/multicol/clip-in-columns.html: Added.
- fast/multicol/filter-in-columns-expected.html: Added.
- fast/multicol/filter-in-columns.html: Added.
- 3:04 PM Changeset in webkit [178379] by
-
- 2 edits in trunk/Source/WebKit2
[CMake] Unreviewed build fix after r178366.
- CMakeLists.txt: Add new files added by r178366.
- 2:33 PM Changeset in webkit [178378] by
-
- 4 edits in trunk/Source
Should disable immediate actions for iTunes
https://bugs.webkit.org/show_bug.cgi?id=140405
-and corresponding-
rdar://problem/19461358
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit/mac:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _updateImmediateActionItem]):
- 2:26 PM Changeset in webkit [178377] by
-
- 3 edits in trunk/Source/bmalloc
Consider alignment when allocating from a SegregatedFreeList
https://bugs.webkit.org/show_bug.cgi?id=140408
Reviewed by Sam Weinig.
In preparation for supporting aligned allocation.
No performance change.
Since this is just one extra branch in an already expensive function,
I decided not to duplicate the function just to avoid the branch in
the un-aligned case.
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::take):
- bmalloc/SegregatedFreeList.h:
- 2:23 PM Changeset in webkit [178376] by
-
- 6 edits in trunk/Source/WebCore
Remove pure virtual functions from DatabaseBackendBase
https://bugs.webkit.org/show_bug.cgi?id=140402
Reviewed by Sam Weinig.
Also change DatabaseBackendBase to Database in a couple of places.
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::maximumSize):
- Modules/webdatabase/DatabaseBackendBase.h:
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::createDatabase):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- Modules/webdatabase/DatabaseTracker.h:
- 2:22 PM Changeset in webkit [178375] by
-
- 7 edits in trunk/Source/WebKit2
Move more of the Navigation infrastructure down to WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=140395
Reviewed by Anders Carlsson.
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didStartProvisionalLoadForFrame):
(API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::LoaderClient::didCommitLoadForFrame):
(API::LoaderClient::didFinishDocumentLoadForFrame):
(API::LoaderClient::didFinishLoadForFrame):
(API::LoaderClient::didFailLoadWithErrorForFrame):
(API::LoaderClient::didSameDocumentNavigationForFrame):
(API::LoaderClient::didReceiveTitleForFrame):
(API::LoaderClient::didFirstLayoutForFrame):
(API::LoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(API::LoaderClient::didRemoveFrameFromHierarchy):
(API::LoaderClient::didDisplayInsecureContentForFrame):
(API::LoaderClient::didRunInsecureContentForFrame):
(API::LoaderClient::didDetectXSSForFrame):
(API::LoaderClient::didLayout):
(API::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(API::LoaderClient::didReceiveAuthenticationChallengeInFrame):
(API::LoaderClient::didStartProgress):
(API::LoaderClient::didChangeProgress):
(API::LoaderClient::didFinishProgress):
(API::LoaderClient::processDidBecomeUnresponsive):
(API::LoaderClient::interactionOccurredWhileProcessUnresponsive):
(API::LoaderClient::processDidBecomeResponsive):
(API::LoaderClient::processDidCrash):
(API::LoaderClient::didChangeBackForwardList):
(API::LoaderClient::shouldKeepCurrentBackForwardListItemInList):
(API::LoaderClient::willGoToBackForwardListItem):
(API::LoaderClient::pluginLoadPolicy):
(API::LoaderClient::didFailToInitializePlugin):
(API::LoaderClient::didBlockInsecurePluginVersion):
(API::LoaderClient::webGLLoadPolicy):
(API::LoaderClient::resolveWebGLLoadPolicy):
(API::LoaderClient::didDestroyNavigation): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didSameDocumentNavigationForFrame):
(WebKit::NavigationState::LoaderClient::didLayout):
(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame):
(WebKit::NavigationState::LoaderClient::processDidCrash):
(WebKit::NavigationState::LoaderClient::didDestroyNavigation): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::shouldKeepCurrentBackForwardListItemInList):
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::didStartProgress):
(WebKit::WebPageProxy::didChangeProgress):
(WebKit::WebPageProxy::didFinishProgress):
(WebKit::WebPageProxy::didDestroyNavigation):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didLayout):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::didDetectXSSForFrame):
(WebKit::WebPageProxy::webGLPolicyForURL):
(WebKit::WebPageProxy::resolveWebGLPolicyForURL):
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- Moves conversion from navigationID to API::Navigation into WebPageProxy from NavigationState.
- Changes API::LoaderClient to pass WebPageProxy and WebFrameProxy by reference rather than pointer, and to take an API::Navigation instead of a navigationID.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
Move access of the navigationID to after calling into the client bundle to avoid
passing a navigationID of a deleted navigation to the UIProcess. This problem was
caught via the WebKit2.StopLoadingDuringDidFailProvisionalLoadTest API test, which
now exercises the Navigation code path. Had that test been written using a Navigation
delegate, the issue would have happened prior to this change.
- 2:00 PM Changeset in webkit [178374] by
-
- 2 edits in trunk/Source/bmalloc
Renamed minimum to size in SegregatedFreeList
https://bugs.webkit.org/show_bug.cgi?id=140406
Reviewed by Sam Weinig.
In preparation for supporting aligned allocation.
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::takeGreedy):
(bmalloc::SegregatedFreeList::take): Every size passed to malloc is
really just a minimum. Let's not imply that this value is special.
- 1:44 PM Changeset in webkit [178373] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: I do not expect to see the same rule multiple times in styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=138185
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-13
Reviewed by Timothy Hatcher.
In the styles sidebar, don't show a duplicate, lesser-specificity rule even
if it matches the selected element multiple times with different selectors
in the list.
- UserInterface/Models/CSSRule.js:
(WebInspector.CSSRule.prototype.isEqualTo):
CSSRule identifiers are objects.
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh):
Remove duplicates from the ordered list of style declarations.
- 1:21 PM Changeset in webkit [178372] by
-
- 2 edits in trunk/Source/WTF
Make WTF::Optional work with msvc 2013
https://bugs.webkit.org/show_bug.cgi?id=140401
Reviewed by Anders Carlsson.
Update the WTF::Optional implementation to use std::aligned_memory and
placement new instead of an unrestricted union because msvc 2013 still
doesn't support unrestricted unions.
This change is a pre-requirement to fix Bug 140347 as this change uses
WTF::Optional with types that have non-trivial copy constructors.
This change is covered by the existing Optional WTF test.
- wtf/Optional.h:
- 12:31 PM Changeset in webkit [178371] by
-
- 7 edits in trunk/Source
Web Inspector: Remove unused ResizeImage and DecodeImageData timeline events
https://bugs.webkit.org/show_bug.cgi?id=140404
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-13
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
Source/WebCore:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::toProtocol):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createDecodeImageData): Deleted.
(WebCore::TimelineRecordFactory::createResizeImageData): Deleted.
- inspector/TimelineRecordFactory.h:
- 12:17 PM Changeset in webkit [178370] by
-
- 4 edits3 adds in trunk
DFG can call PutByValDirect for generic arrays
https://bugs.webkit.org/show_bug.cgi?id=140389
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Computed properties in object initializers (ES6) use the put_by_val_direct operation.
However, current DFG asserts that put_by_val_direct is not used for the generic array,
the assertion failure is raised.
This patch allow DFG to use put_by_val_direct to generic arrays.
And fix the DFG put_by_val_direct implementation for string properties.
At first, put_by_val_direct is inteded to be used for spread elements.
So the property keys were limited to numbers (indexes).
But now, it's also used for computed properties in object initializers.
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
- js/dfg-put-by-val-direct-to-generic-array-expected.txt: Added.
- js/dfg-put-by-val-direct-to-generic-array.html: Added.
- js/script-tests/dfg-put-by-val-direct-to-generic-array.js: Added.
(foo1):
(foo2):
- 12:17 PM Changeset in webkit [178369] by
-
- 2 edits in trunk/Tools
TestWebKitWebContext depends on British English spellcheck dictionary
https://bugs.webkit.org/show_bug.cgi?id=140403
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-13
Reviewed by Martin Robinson.
Install all English hunspell dictionaries on Fedora and Arch.
- gtk/install-dependencies:
- 12:16 PM Changeset in webkit [178368] by
-
- 2 edits in trunk/Tools
[GTK] install-dependencies should grok dnf
https://bugs.webkit.org/show_bug.cgi?id=140396
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-13
Reviewed by Martin Robinson.
Fedora: install dependencies with dnf if yum is not installed.
- gtk/install-dependencies:
- 12:01 PM Changeset in webkit [178367] by
-
- 15 edits2 adds in trunk
defaultPlaybackRate not respected when set before source is loaded
https://bugs.webkit.org/show_bug.cgi?id=140282
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-defaultplaybackrate-before-load.html
When the HTMLMediaElement is notified that the media player's rate has changed, it asks
for the rate from MediaPlayer. However, MediaPlayer never requests the playback rate
from the underlying MediaPlayerPrivate; it just returns the last rate which was set, or
1 if no rate was set. HTMLMediaElement then sets its playbackRate to the returned
value. So the end result is that the value from defaultPlaybackRate is overwritten by
the default value of 1 in MediaPlayer.
Rather than caching the requested rate in MediaPlayer, cache the value reported by
MediaPlayer inside HTMLMediaElement. And instead of returning the reported playback
rate from HTMLMediaElement.playbackRate, just return the last value set. The reported
value is still used for estimating the current time during playback.
Add MediaPlayerPrivate interface method to return the current playback rate.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_reportedPlaybackRate.
(WebCore::HTMLMediaElement::effectivePlaybackRate): Return m_reportedPlaybackRate.
(WebCore::HTMLMediaElement::requestedPlaybackRate): Return m_playbackRate.
(WebCore::HTMLMediaElement::updatePlaybackRate): Use requestedPlaybackRate() instead
of effectivePlaybackRate();
(WebCore::HTMLMediaElement::ended): Ditto.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
(WebCore::HTMLMediaElement::endedPlayback): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Set m_reportedPlaybackRate.
(WebCore::HTMLMediaElement::mediaPlayerRequestedPlaybackRate): Return
requestedPlaybackRate() if playing and 0 if not.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Removed m_rate.
(WebCore::MediaPlayer::rate): Pass to MediaPlayerPrivate.
(WebCore::MediaPlayer::setRate): Do not cache the rate.
(WebCore::MediaPlayer::requestedRate): Added; ask HTMLMediaElement.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerRequestedPlaybackRate): Added.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::rate): Added.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
Do not cache the requested rate.
(WebCore::MediaPlayerPrivateAVFoundation::requestedRate): Pass to MediaPlayer.
(WebCore::MediaPlayerPrivateAVFoundation::setRate): Deleted.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::requestedRate): Deleted.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::setRate): Renamed from updateRate.
(WebCore::MediaPlayerPrivateAVFoundationCF::rate): Fetch the rate from the player.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setRateDouble): Renamed from updateRate.
(WebCore::MediaPlayerPrivateAVFoundationObjC::rate): Fetch the rate from the player.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::rate): Fetch the rate from the QTMovie.
LayoutTests:
- media/video-defaultplaybackrate-before-load-expected.txt: Added.
- media/video-defaultplaybackrate-before-load.html: Added.
- 11:53 AM Changeset in webkit [178366] by
-
- 3 edits4 adds in trunk/Source/WebKit2
Begin stubbing out a per page process lifetime tracker object
https://bugs.webkit.org/show_bug.cgi?id=140399
Reviewed by Beth Dakin.
This will make it easier for certain objects that track a set of web page proxy objects
(user content controller, visited link provider, data store) to be notified when their
underlying processes come and go.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessLifetimeObserver.cpp: Added.
- UIProcess/WebProcessLifetimeObserver.h: Added.
- UIProcess/WebProcessLifetimeTracker.cpp: Added.
(WebKit::WebProcessLifetimeTracker::WebProcessLifetimeTracker):
(WebKit::WebProcessLifetimeTracker::~WebProcessLifetimeTracker):
(WebKit::WebProcessLifetimeTracker::addObserver):
(WebKit::WebProcessLifetimeTracker::removeObserver):
- UIProcess/WebProcessLifetimeTracker.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 11:42 AM Changeset in webkit [178365] by
-
- 2 edits in trunk/Source/JavaScriptCore
Out of bounds access in BytecodeGenerator::emitGetById under DotAccessorNode::emitBytecode
https://bugs.webkit.org/show_bug.cgi?id=140397
Reviewed by Geoffrey Garen.
Patch by Alexey Proskuryakov.
Reviewed, performance tested, and ChangeLogged by Geoffrey Garen.
No performance change.
No test, since this is a small past-the-end read, which is very
difficult to turn into a reproducible failing test -- and existing tests
crash reliably using ASan.
- bytecompiler/NodesCodegen.cpp:
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::DeleteBracketNode::emitBytecode):
(JSC::DeleteDotNode::emitBytecode):
(JSC::PrefixNode::emitResolve):
(JSC::UnaryOpNode::emitBytecode):
(JSC::BitwiseNotNode::emitBytecode):
(JSC::BinaryOpNode::emitBytecode):
(JSC::EqualNode::emitBytecode):
(JSC::StrictEqualNode::emitBytecode):
(JSC::ThrowableBinaryOpNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode): Use RefPtr in more places. Any
register used across a call to a function that might allocate a new
temporary register must be held in a RefPtr.
- 9:46 AM Changeset in webkit [178364] by
-
- 5 edits in trunk/Source/JavaScriptCore
Local JSArray* "keys" in objectConstructorKeys() is not marked during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=140348
Reviewed by Mark Lam.
We used to read registers in MachineThreads::gatherFromCurrentThread(), but that is too late
because those registers may have been spilled on the stack and replaced with other values by
the time we call down to gatherFromCurrentThread().
Now we get the register contents at the same place that we demarcate the current top of
stack using the address of a local variable, in Heap::markRoots(). The register contents
buffer is passed along with the demarcation pointer. These need to be done at this level
in the call tree and no lower, as markRoots() calls various functions that visit object
pointers that may be latter proven dead. Any of those pointers that are left on the
stack or in registers could be incorrectly marked as live if we scan the stack contents
from a called function or one of its callees. The stack demarcation pointer and register
saving need to be done in the same function so that we have a consistent stack, active
and spilled registers.
Because we don't want to make unnecessary calls to get the register contents, we use
a macro to allocated, and possibly align, the register structure and get the actual
register contents.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::gatherStackRoots):
- heap/Heap.h:
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):
- heap/MachineStackMarker.h:
- 8:59 AM Changeset in webkit [178363] by
-
- 3 edits2 adds in trunk
Element::normalizeAttributes() needs to handle arbitrary JS executing between loop iterations.
<https://webkit.org/b/140379>
<rdar://problem/19446901>
Reviewed by Benjamin Poulain.
Source/WebCore:
Since DOM mutation events may arise below the call to Node::normalize(),
have the loop in Element::normalizeAttributes() make a copy of the Attr nodes
beforehand, to guard against mutations.
Based on a patch by Chris "Chris Dumez" Dumez.
Test: fast/dom/Element/normalize-crash2.html
- dom/Element.cpp:
(WebCore::Element::normalizeAttributes):
LayoutTests:
- fast/dom/Element/normalize-crash2-expected.txt: Added.
- fast/dom/Element/normalize-crash2.html: Added.
- 5:14 AM Changeset in webkit [178362] by
-
- 4 edits in trunk/LayoutTests
AX: [ATK] Mark accessibility/table-with-footer-section-above-body.html as a suitable test for EFL and GTK
https://bugs.webkit.org/show_bug.cgi?id=140355
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-13
Reviewed by Chris Fleizach.
The test shows the text contents of an AccessibilityTableCell object using tableCell.childAtIndex(0).stringValue.
In the case of ATK childAtIndex(0) returns a non-empty object, but it is not the ATK_OBJECT,
so the stringValue produces an empty string.
To avoid this, the cell text content is obtained by direct reading of stringValue of TableCell.
- accessibility/table-with-footer-section-above-body.html:
This test is also suitable for EFL and GTK port.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 4:58 AM Changeset in webkit [178361] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix test expectations after r178310.
https://bugs.webkit.org/show_bug.cgi?id=140387.
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-01-13
Reviewed by Gyuyoung Kim.
Clean reference to SharedWorkers in test expecations since they were removed.
- platform/efl/TestExpectations:
- 4:42 AM WebKitGTK/2.6.x edited by
- (diff)
- 4:40 AM Changeset in webkit [178360] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r178231 - Calling clearSelection on a detached RenderObject leads to segfault.
https://bugs.webkit.org/show_bug.cgi?id=140275
Reviewed by Simon Fraser.
We collect selection rects and compute selection gaps in order to
paint/clear selection. With certain content, we need to be able
to walk the tree up to a particular container to compute the selection rect.
However this container might not be available when the selection is part of a detached tree.
This is a null-check fix to ensure we don't crash in such cases, but in the long run
selection gaps and rect should be cached between two layouts so that we don't need to
keep collecting/recomputing them. Tracked here: webkit.org/b/140321
Source/WebCore:
Test: editing/selection/clearselection-on-detached-subtree-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalHeightForContent):
- rendering/RenderView.cpp:
(WebCore::RenderView::clearSelection):
LayoutTests:
- editing/selection/clearselection-on-detached-subtree-crash-expected.txt: Added.
- editing/selection/clearselection-on-detached-subtree-crash.html: Added.
- 4:09 AM Changeset in webkit [178359] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6
Merge r177537 - AX: Recursive crash at WebCore::accessibleNameForNode
https://bugs.webkit.org/show_bug.cgi?id=139616
Reviewed by Mario Sanchez Prada.
Source/WebCore:
An image that uses aria-labelledby to reference its own parent can lead to a recursion crash.
There needs to be some information we can pass through these methods to ensure we don't hit this case.
Test: accessibility/accessibility-description-crash.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityTextUnderElementMode::AccessibilityTextUnderElementMode):
LayoutTests:
- accessibility/accessibility-description-crash-expected.txt: Added.
- accessibility/accessibility-description-crash.html: Added.
- 4:05 AM Changeset in webkit [178358] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r177518 - Web Inspector: ASSERT seen closing/opening multiple inspectors
https://bugs.webkit.org/show_bug.cgi?id=139783
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-18
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForObjectId):
- 3:55 AM Changeset in webkit [178357] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r177360 - REGRESSION (r163928): Animated GIFs are not resumed when translated into view using -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=139672
<rdar://problem/19260797>
Reviewed by Antti Koivisto.
Source/WebCore:
After r163928, animated GIFs were not resumed when translated into view
using '-webkit-transform' CSS property.
This broke animated gifs on the mobile version of weibo.com (which is
one of the most popular blogging sites in China) on iPhone. e.g.
http://m.weibo.cn/page/tpl?containerid=1005052150182731_-_WEIBO_SECOND_PROFILE_WEIBO&itemid=&title=全部微博
This patch calls FrameView::resumeVisibleImageAnimationsIncludingSubframes()
after style recalc so that we resume animated images if they become visible
after the style has changed. Doing so after layout wouldn't work because
no layout happens in this case.
Test: fast/images/animated-gif-webkit-transform.html
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
LayoutTests:
Add a layout test to verity that animated images are properly paused /
resumed when translated in and out of view using '-webkit-transform'
CSS property.
- fast/images/animated-gif-webkit-transform-expected.txt: Added.
- fast/images/animated-gif-webkit-transform.html: Added.
- 3:50 AM Changeset in webkit [178356] by
-
- 7 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r177302 - REGRESSION (r168217): Images are cropped out during animation at jetblue.com
https://bugs.webkit.org/show_bug.cgi?id=136410
rdar://problem/18188533
Reviewed by Dean Jackson.
During GraphicsLayer flushing, for tiled layers we can compute a visible rect using
the current state of an animation, which is obtained via the AnimationController.
If that animation was running in a subframe, AnimationController could use a stale
beginAnimationUpdateTime since no-one called its beginAnimationUpdate(). That
resulted in an incorrect computation of the visible rect, resulting in missing tiles.
There are two parts to this fix. First, add an assertion that beginAnimationUpdateTime()
is being called inside an animation update block. This required moving m_beginAnimationUpdateCount
into AnimationControllerPrivate, and changes to endAnimationUpdate().
The second is adding a AnimationUpdateBlock to getAnimatedStyleForRenderer(), which
can be called outside of style resolution. We also need some in other API functions.
Testing revealed that layout can call via layoutOverflowRectForPropagation(), suggesting
that we should have an animation batch inside FrameView::layout(). In addition, a single
resolveStyle/layout should use the same animationBeginTime, so we add a batch to
updateLayoutAndStyleIfNeededRecursive().
No test because it's timing-dependent. Existing tests exercise the new assertion.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/animation/AnimationController.cpp:
(WebCore::AnimationPrivateUpdateBlock::AnimationPrivateUpdateBlock):
(WebCore::AnimationPrivateUpdateBlock::~AnimationPrivateUpdateBlock):
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::animationTimerFired):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::AnimationControllerPrivate::beginAnimationUpdate):
(WebCore::AnimationControllerPrivate::endAnimationUpdate):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationController::AnimationController):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::resumeAnimationsForDocument):
(WebCore::AnimationController::startAnimationsIfNotSuspended):
(WebCore::AnimationController::beginAnimationUpdate):
(WebCore::AnimationController::endAnimationUpdate):
- page/animation/AnimationController.h:
- page/animation/AnimationControllerPrivate.h:
- 3:40 AM Changeset in webkit [178355] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r177279 - [GStreamer] the webkitwebsrc element can stale
https://bugs.webkit.org/show_bug.cgi?id=138425
Patch by Xavier Claessens <xavier.claessens@collabora.com> on 2014-12-15
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(removeTimeoutSources):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
- 3:35 AM Changeset in webkit [178354] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r177263 - REGRESSION(r160182): Fragment parser doesn't close a form element with a close tag
https://bugs.webkit.org/show_bug.cgi?id=139561
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by us not setting the form pointer in insertHTMLFormElement.
Since we already avoid associating a form inside HTMLConstructionSite::createHTMLElement,
we didn't need this code at all.
Fixed the bug by partially reverting r160182.
Test: fast/dom/dom-parse-close-form.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insideTemplateElement): Deleted.
- html/parser/HTMLConstructionSite.h:
LayoutTests:
Added a regression test.
- fast/dom/dom-parse-close-form-expected.txt: Added.
- fast/dom/dom-parse-close-form.html: Added.
- 3:28 AM Changeset in webkit [178353] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r177245 - shiftCountWithArrayStorage should exit to slow path if the object has a sparse map.
https://bugs.webkit.org/show_bug.cgi?id=139598
<rdar://problem/18779367>
Reviewed by Filip Pizlo.
- runtime/JSArray.cpp:
(JSC::JSArray::shiftCountWithArrayStorage): Added check for object having a sparse map.
- tests/stress/sparse_splice.js: Added.
- 3:20 AM Changeset in webkit [178352] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r177188 - Initialize m_ownsGeneratedFile when decoding a FormDataElement
https://bugs.webkit.org/show_bug.cgi?id=139566
Reviewed by Tim Horton.
No tests, because it's random, and I couldn't reproduce an assertion failure in
controlled circumstances.
- platform/network/FormData.h: (WebCore::FormDataElement::decode): A newly created
FormDataElement by definition doesn't own the file.
- 3:03 AM Changeset in webkit [178351] by
-
- 4 edits4 adds in releases/WebKitGTK/webkit-2.6
Merge r177165 - InstancedArray crashes attempting to draw out of bounds
https://bugs.webkit.org/show_bug.cgi?id=139521
Source/WebCore:
Reviewed by Simon Fraser.
We were not doing index validation correctly for instancing.
Test: fast/canvas/webgl/angle-instanced-arrays-out-of-bounds.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateVertexAttributes): We need to check
the number of instances drawn against the amount of instance data that has
been provided, taking into account the number of repeats (the divisor).
(WebCore::WebGLRenderingContext::drawArrays): Added some whitespace to make it more clear.
(WebCore::WebGLRenderingContext::validateDrawElements): This needs to take a primcount
parameter so that it can correctly validate the call (when used from drawElementsInstanced).
(WebCore::WebGLRenderingContext::drawElements): New signature to validate.
(WebCore::WebGLRenderingContext::drawArraysInstanced): Rearrange this a bit. The
primcount validation is already being done by the validateDrawArrays call. Also, there
was a bogus UNUSED_PARAM hanging around.
(WebCore::WebGLRenderingContext::drawElementsInstanced): Similar rearrangement. Use
the primcount parameter.
- html/canvas/WebGLRenderingContext.h:
LayoutTests:
<rdar://problem/17540398>
Reviewed by Simon Fraser.
This is a copy of the official webgl/1.0.3 test.
- platform/mac-mountainlion/fast/canvas/webgl/angle-instanced-arrays-out-of-bounds-expected.txt: Added. This extension is not available on Mountain Lion.
- fast/canvas/webgl/angle-instanced-arrays-out-of-bounds-expected.txt: Added.
- fast/canvas/webgl/angle-instanced-arrays-out-of-bounds.html: Added.
- fast/canvas/webgl/resources/out-of-bounds-test.js: Added.
(OutOfBoundsTest):
- 2:59 AM Changeset in webkit [178350] by
-
- 18 edits in releases/WebKitGTK/webkit-2.6/Source
Merge r177152 - REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
https://bugs.webkit.org/show_bug.cgi?id=139504
rdar://problem/19034674
Reviewed by Enrica Casucci.
Source/WebCore:
Explicitly notify EditorClient when a composition is voluntarily canceled by WebCore.
These are almost certainly not all the places where this happens, but this fixes the bug,
and lays the groundwork for using this new client call instead of didChangeSelection
hacks.
- editing/Editor.cpp:
(WebCore::Editor::clear):
(WebCore::Editor::cancelComposition):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::willTransitionToCommitted):
- page/EditorClient.h:
Source/WebKit/mac:
Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::discardedComposition):
Source/WebKit/win:
Stub out new client calls, this patch doesn't attempt to make any changes on Windows.
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::discardedComposition):
- WebCoreSupport/WebEditorClient.h:
Source/WebKit2:
WebKit2 used to look at EditorState changes and guess when to cancel a composition.
This was quite unreliable, and needlessly complicated - WebCore knows when it decides
to destroy a composition, so it now explicitly notifies the clients.
- UIProcess/API/mac/WKView.mm: (-[WKView _processDidExit]): Address crashing case too.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::discardedComposition):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::discardedComposition):
- WebProcess/WebPage/WebPage.h:
- 2:53 AM Changeset in webkit [178349] by
-
- 2 edits in trunk/Source/WebCore
Fix Debug Build Error in Webcore module.
https://bugs.webkit.org/show_bug.cgi?id=140383
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2015-01-13
Reviewed by Csaba Osztrogonác.
No new tests because there is no visible behavior change.
- platform/linux/MemoryPressureHandlerLinux.cpp:
(WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
- 2:49 AM Changeset in webkit [178348] by
-
- 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r177144 - [GTK] Timers might never be fired during animations
https://bugs.webkit.org/show_bug.cgi?id=139062
Reviewed by Martin Robinson.
This can happen in old/slow machines where the time to render
layers might take more than 0.016. Since the layer flush timer is
using a higher priority than WebCore timers, when scheduling all
(or several) layer flushes immediately, no other sources with
lower priority are dispatched in the main loop. We could detect if
we are scheduling layer flushes immediately for too long (100ms)
and schedule the next flush after a delay to ensure other sources
with lower priority have a chance to be dispatched. Also use a
lower priority, GDK_PRIORITY_EVENTS is too high, so we use
GDK_PRIORITY_REDRAW - 1 to ensure it's higher than WebCore timers.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Rename
m_lastFlushTime as m_lastImmediateFlushTime.
(WebKit::LayerTreeHostGtk::layerFlushTimerFired): Save the
fireTime before calling flushAndRenderLayers() and compute the
next flush delay based on the elapsed time using monotonically
increasing time instead of current time. Use the target delay
as next flush delay if we have scheduled flushes immediately for
more than 100ms.
(WebKit::LayerTreeHostGtk::flushAndRenderLayers): Do not save the
layer flush time here, it's done in layerFlushTimerFired() so that
we don't need to keep it as a member.
(WebKit::LayerTreeHostGtk::scheduleLayerFlush): Use global
layerFlushTimerPriority.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 2:44 AM Changeset in webkit [178347] by
-
- 6 edits6 adds in releases/WebKitGTK/webkit-2.6
Merge r177135 - http://omfgdogs.info/ only animates when you resize the window
https://bugs.webkit.org/show_bug.cgi?id=139435
<rdar://problem/19190493>
Reviewed by Simon Fraser.
Source/WebCore:
After r163928, we would fail to animate a gif if:
- it is used as a background image of a 0-height html element
- it is used as a background image of a 0-height body element whose background is delegated to the root (because the root has no background).
This is because in such cases, shouldRepaintForImageAnimation()
should use the background rect instead of the renderer's overflow
rect to determine if the image is inside the viewport. Both cases
are addressed in this patch.
Tests: fast/images/animated-gif-body-delegated-background-image.html
fast/images/animated-gif-body-outside-viewport.html
fast/images/animated-gif-html-background-image.html
- rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
- testing/Internals.cpp:
(WebCore::Internals::hasPausedImageAnimations):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add layout tests to make sure a gif image is still animated if:
- It is used as a background image of a 0-height html element
- It is used as a background image of a 0-height body element that is delegated to the root (because the root has no background)
Also add a layout test to make sure we still stop the gif animation
if it is used as background image of a body that is outside the
viewport.
- fast/images/animated-gif-body-delegated-background-image-expected.txt: Added.
- fast/images/animated-gif-body-delegated-background-image.html: Added.
- fast/images/animated-gif-body-outside-viewport-expected.txt: Added.
- fast/images/animated-gif-body-outside-viewport.html: Added.
- fast/images/animated-gif-html-background-image-expected.txt: Added.
- fast/images/animated-gif-html-background-image.html: Added.
- 2:43 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:42 AM WebKitGTK/2.4.x edited by
- (diff)
- 2:37 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:37 AM WebKitGTK/2.4.x edited by
- (diff)
- 2:32 AM Changeset in webkit [178346] by
-
- 6 edits4 adds in releases/WebKitGTK/webkit-2.6
Merge r177128 - Continuously repainting large parts of Huffington Post.
https://bugs.webkit.org/show_bug.cgi?id=139468
Reviewed by Antti Koivisto.
This patch eliminates redundant repaint requests for inlines when neither the parent
block flow nor any of the inline children are dirty.
Previously,
- simple line layout always recalculated inline content positions regardless of whether
the content needed relayout at all; as a result, it always triggered full repaint.
- inline tree layout ignored the needslayout flag on the last line and treated it dirty
(unless it broke cleanly (<div>foo<br></div>)).
This was an ancient workaround for an editing/insert use case, but it seems not to be the case anymore.
Source/WebCore:
Tests: fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html
fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::layoutSimpleLines): Check if we need to trigger layout at all.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::determineStartPosition): Remove the last line dirty hack. If it
happens to introduce regression, we should fix it at the caller site to make the line dirty.
LayoutTests:
- fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt: Added.
- fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html: Added.
- fast/repaint/implicitly-positioned-block-repaint-simple-line-layout-expected.txt: Added.
- fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html: Added.
- platform/mac/fast/line-grid/line-align-right-edges-expected.txt:
- 2:22 AM Changeset in webkit [178345] by
-
- 3 edits6 adds in releases/WebKitGTK/webkit-2.6
Merge r177098 - REGRESSION(r164329): Input fields are not honoring the maxlength attribute
https://bugs.webkit.org/show_bug.cgi?id=139447
Reviewed by Benjamin Poulain.
Source/WebCore:
The bug was caused by String::substring being called with the selection's end offset
in the second argument instead of the selection's length in handleBeforeTextInsertedEvent.
Fixed the bug by passing the right second argument to String::substring.
Test: fast/forms/input-maxlength-inserting-in-middle.html
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
LayoutTests:
Added regression tests.
- fast/forms/input-maxlength-inserting-in-middle-expected.txt: Added.
- fast/forms/input-maxlength-inserting-in-middle.html: Added.
- fast/forms/input-maxlength-paste-clusters-in-middle-expected.txt: Added.
- fast/forms/input-maxlength-paste-clusters-in-middle.html: Added.
- fast/forms/input-maxlength-paste-in-middle-expected.txt: Added.
- fast/forms/input-maxlength-paste-in-middle.html: Added.
- 2:19 AM Changeset in webkit [178344] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r177089 - Crash when creating CSSCalcBinaryOperation
https://bugs.webkit.org/show_bug.cgi?id=134886
rdar://problem/17663561
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/css/calc-binary-operation-crash.html
- css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
Ensure that both axis are within the addSubtractResult table.
Remove unneeded CalcOther test. The call site guarantees it doesn't happen and the normal cases would handle it anyway.
Also strengthen some asserts.
LayoutTests:
- fast/css/calc-binary-operation-crash-expected.txt: Added.
- fast/css/calc-binary-operation-crash.html: Added.
- 2:17 AM Changeset in webkit [178343] by
-
- 5 edits8 adds in releases/WebKitGTK/webkit-2.6
Merge r177050 - Scrolling to anchor tags does nothing in vertical-rl writing mode
https://bugs.webkit.org/show_bug.cgi?id=137838
Reviewed by David Hyatt.
Source/WebCore:
Scroll to a particular tag, and make sure the viewport is rendered as expected.
Tests: fast/events/scroll-to-anchor-vertical-lr-writing-mode.html
fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html
fast/events/scroll-to-anchor-vertical-writing-mode-contained.html
fast/events/scroll-to-anchor-vertical-writing-mode.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- rendering/ScrollBehavior.cpp:
- rendering/ScrollBehavior.h:
LayoutTests:
When we specify the behavior regarding scrolling to anchor tags, we previously had
only described behavior regarding horizontal text. When we have vertical text, we
need to switch the horizontal and vertical scrolling policies.
- fast/events/scroll-to-anchor-vertical-lr-writing-mode-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-lr-writing-mode.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained-2-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode.html: Added.
- 2:09 AM Changeset in webkit [178342] by
-
- 3 edits in releases/WebKitGTK/webkit-2.6
Merge r177049 - REGRESSION(r155906): Page content disappears on Tuaw article after loading
https://bugs.webkit.org/show_bug.cgi?id=138100
Reviewed by Simon Fraser.
.:
DRT causes an extra paint which makes it impossible to test this with
an automated test.
- ManualTests/float-layer-not-painting.html: Added.
Source/WebCore:
Test: ManualTests/float-layer-not-painting.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject): If a layout happens,
it can change whether the float's renderer has a self painting layer.
So in that case, we need to update the flag on the FloatingObject
instance for that float.
- 2:02 AM Changeset in webkit [178341] by
-
- 3 edits5 adds in releases/WebKitGTK/webkit-2.6
Merge r177033 - [WK2] Crash when answering notification permission request after navigating
https://bugs.webkit.org/show_bug.cgi?id=139429
<rdar://problem/18921122>
Reviewed by Andreas Kling.
Source/WebKit2:
When requesting a notification permission, navigating away and then
answering the permission, WebKit2 would crash. This is because upon
navigating, the request is cancelled and removed from the HashMaps
in NotificationPermissionRequestManager. When
didReceiveNotificationPermissionDecision() is later called, it would
look for the request identifier in m_idToOriginMap HashMap. As the
request was cancelled, HashMap::take() call would return null for
the SecurityOrigin*. This security origin pointer is then removed
from m_originToIDMap, but the code was failing to do a null check
first. Calling HashMap::remove(nullptr) would then crash.
This patch adds the missing null check and a layout test to cover
this case.
Test: http/tests/notifications/legacy/notification-request-permission-then-navigate.html
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
LayoutTests:
Add layout test to cover the case where the notification permission is
requesting before navigating to a new URL and answered after the page
is navigated away.
- http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt: Added.
- http/tests/notifications/legacy/notification-request-permission-then-navigate.html: Added.
- http/tests/notifications/legacy/resources/notify-opener-done.html: Added.
- http/tests/notifications/legacy/resources/request-permission-then-navigate.html: Added.
- 1:59 AM Changeset in webkit [178340] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WTF
Merge r177023 - Undefined Symbol build error "_objc_registerThreadWithCollector" when building WebKit GTK Mac OS X on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=58737
Reviewed by Darin Adler.
Replace OS(MAC_OS_X) with PLATFORM(MAC) to prevent using
osx-specific code in WebKitGTK+ builds.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- 1:58 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:57 AM Changeset in webkit [178339] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6
Merge r177019 - convertToUTF8String converts null string to empty string
https://bugs.webkit.org/show_bug.cgi?id=133904
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Test added to Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp
Return 0 if the string is null.
- bindings/gobject/ConvertToUTF8String.cpp:
(convertToUTF8String):
Tools:
Test that trying to get the value of a non-existent attribute
returns 0 instead of an empty string.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testInsertion):
- 1:56 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:54 AM Changeset in webkit [178338] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r177016 - [GTK] LDFLAGS is ignored when running g-ir-scanner
https://bugs.webkit.org/show_bug.cgi?id=138832
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-12-09
Reviewed by Carlos Garcia Campos.
GTK+ requires libintl on FreeBSD because there is no gettext
implementation in FreeBSD libc. In order to link to libintl, which is
not located in the default search path of the linker, we need to add
the required path via the linker command line. However, LDFLAGS is
ignored when running g-ir-scanner starting from r167873, so we have
to manually pick required flags from CMAKE_SHARED_LINKER_FLAGS and
put them in correct order to prevent g-ir-scanner from linking to
the installed version of libraries.
- PlatformGTK.cmake:
- 1:53 AM Changeset in webkit [178337] by
-
- 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r177015 - [Media][GTK][EFL] Reduce style updates (painting) in controls
https://bugs.webkit.org/show_bug.cgi?id=137773
Reviewed by Carlos Garcia Campos.
Don't update media controls if they are not visible, and
initialize slider to a zero value.
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.createControls):
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.updateTime):
- 1:46 AM Changeset in webkit [178336] by
-
- 4 edits1 add in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r177083 - Fixes operationPutByIds such that they check that the put didn't
change the structure of the object who's property access is being
cached.
https://bugs.webkit.org/show_bug.cgi?id=139196
Reviewed by Filip Pizlo.
- jit/JITOperations.cpp:
(JSC::operationGetByIdOptimize): changed get to getPropertySlot
(JSC::operationPutByIdStrictBuildList): saved the structure before the put.
(JSC::operationPutByIdNonStrictBuildList): ditto.
(JSC::operationPutByIdDirectStrictBuildList): ditto.
(JSC::operationPutByIdDirectNonStrictBuildList): ditto.
- jit/Repatch.cpp:
(JSC::tryCachePutByID): fixed structure() to use the existant vm.
(JSC::tryBuildPutByIdList): Added a check that the old structure's id
is the same as the new.
(JSC::buildPutByIdList): Added an argument
- jit/Repatch.h:
(JSC::buildPutByIdList): Added an argument
- tests/stress/put-by-id-strict-build-list-order.js: Added.
- 1:43 AM Changeset in webkit [178335] by
-
- 20 edits3 adds1 delete in releases/WebKitGTK/webkit-2.6
Merge r176978 - Inline elements whose parents have small line-height are laid out too low
https://bugs.webkit.org/show_bug.cgi?id=139375
Reviewed by Dave Hyatt.
Source/WebCore:
This is a port of the Blink patch at
https://src.chromium.org/viewvc/blink?revision=155253&view=revision.
When laying out inline elements, we try to align leaf children's parents'
baselines across the entire line. However, if you set line-height: 0px on a
span, the entire InlineBox which represents that span will have a height of
0, and therefore be laid out entirely on the baseline. In addition, we will
try to vertically center the leaf text in the span's InlineBox, which means
the leaf text will be vertically centered on the baseline. All the other
major browsers do not have this behavior; instead, they line up the boxes
as you would expect.
This bug led to a rendering problem on the front page of the New York Times.
Here is the ChangeLog from the Blink patch:
Fix baseline position when it is outside the element's box
Specifically, we shouldn't force the baseline to be inside the element. IE
and FF don't do this, and it's incompatible with the CSS spec:
"The baseline of an 'inline-block' is the baseline of its last line box in
the normal flow, unless it has either no in-flow line boxes or if its
'overflow' property has a computed value other than 'visible', in which case
the baseline is the bottom margin edge."
-- http://www.w3.org/TR/CSS21/visudet.html#leading
It doesn't have a special case for "baseline is outside of the element's
margin box".
Test: fast/text/small-line-height.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
LayoutTests:
Add fast/text/small-line-height.html for a simple example. In addition, update
existing tests.
- fast/forms/textfield-overflow-by-value-update-expected.txt:
- fast/regions/cssom/client-rects-inline-complex.html:
- fast/regions/overflow/overflow-region-inline-expected.html:
- fast/text/small-line-height-expected.html: Added.
- fast/text/small-line-height.html: Added.
- platform/mac/fast/box-sizing/box-sizing-expected.png:
- platform/mac/fast/box-sizing/box-sizing-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.png:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
- platform/mac/fast/multicol/client-rects-expected.png:
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-expected.txt:
- platform/mac/fast/multicol/layers-split-across-columns-expected.png:
- platform/mac/fast/multicol/layers-split-across-columns-expected.txt:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.png:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
- 1:32 AM Changeset in webkit [178334] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-2.6
Merge r176972 - CFA wrongly assumes that a speculation for SlowPutArrayStorageShape disallows ArrayStorageShape arrays.
<https://webkit.org/b/139327>
Reviewed by Michael Saboff.
Source/JavaScriptCore:
The code generator and runtime slow paths expects otherwise. This patch fixes
CFA to match the code generator's expectation.
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShapes):
LayoutTests:
- js/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage-expected.txt: Added.
- js/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage.html: Added.
- js/script-tests/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage.js: Added.
(foo):
(test):
- 1:24 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:23 AM Changeset in webkit [178333] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176945 - Webkit using Harfbuzz does not display Arabic script correctly
https://bugs.webkit.org/show_bug.cgi?id=136337
Patch by Doron Wloschowsky <doron_wloschowsky@scee.net> on 2014-12-08
Reviewed by Carlos Garcia Campos.
Using reinterpret_cast to convert hb_codepoint_t* into UChar*
doesn't work on big endian systems.
- platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::harfBuzzGetGlyph):
- 1:22 AM Changeset in webkit [178332] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po
Merge r176944 - [as] Updated Assamese translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=137487
Patch by Nilamdyuti Goswami <nilamdyuti@gmail.com> on 2014-12-08
Reviewed by Carlos Garcia Campos.
- as.po:
- 1:19 AM Changeset in webkit [178331] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176938 - [GStreamer] Add video/flv to the list of supported mimetypes
https://bugs.webkit.org/show_bug.cgi?id=139344
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Gustavo Noronha Silva.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
Add video/flv additional to video/x-flv to the list of supported
mimetypes. It's used on some websites, e.g.
http://www.jwplayer.com/html5/formats/
- 1:18 AM InspectorConsoleSelection edited by
- (diff)
- 1:17 AM InspectorConsoleSelection edited by
- (diff)
- 1:16 AM Changeset in webkit [178330] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176936 - [GStreamer] Add application/x-mpegurl to the list of supported mimetypes.
https://bugs.webkit.org/show_bug.cgi?id=139343
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Gustavo Noronha Silva.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
It's an alternative mimetype for the already supported
application/vnd.apple.mpegurl (aka HLS) and adding it
allows all streams on http://www.jwplayer.com/html5/hls/
to be played.
- 1:15 AM InspectorConsoleSelection edited by
- (diff)
- 1:13 AM InspectorConsoleSelection edited by
- (diff)
- 1:12 AM Changeset in webkit [178329] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176931 - [TextureMapper] Normalize pattern transform for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=139374
Reviewed by Martin Robinson.
In CoordGfx/TexMapGL, pattern compositing (for background image) uses
the patternTransform shader uniform. However, current implementation
miscalculates its transform matrix. It uses simple rectToRect
transformationMatrix which produces unnormalized garbage term.
This causes unexpected behavior at the fragmentation stage in some
mobile GPUs.
It should calculate its scale based on tileSize and contentSize,
and its position based on tilePhase and contentSize.
No new tests because the bug only occurs on some mobile GPUs.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):
- 1:11 AM Changeset in webkit [178328] by
-
- 6 edits4 adds2 deletes in releases/WebKitGTK/webkit-2.6
Merge r176930 - [Soup][Curl] HTTP header values should be treated as latin1, not UTF-8
https://bugs.webkit.org/show_bug.cgi?id=128739
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-12-07
Reviewed by Martin Robinson.
Source/WebCore:
Removed UTF-8 conversion of HTTP header values (SOUP and CURL).
Removed unnecessary UTF-8 conversion of HTTP header names (SOUP).
Changed conversion of HTTP method from UTF-8 to ASCII (SOUP and CURL).
Added explicit UTF-8 conversion of Content-Disposition header to compute download suggested filename.
Test: http/tests/xmlhttprequest/response-special-characters.html
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::headerCallback): Removed header conversion.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Ditto.
(WebCore::ResourceHandleManager::initializeHandle): Changed HTTP method conversion to ASCI.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): Removed header conversion.
(WebCore::ResourceRequest::updateSoupMessage): Changed HTTP method conversion to ASCII.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Rmoved header conversion.
(WebCore::ResourceResponse::platformSuggestedFilename): Added explicit conversion of contentDisposition to UTF-8.
LayoutTests:
Tests that non ascii header & reason phrase values are correctly retrieved by the web application.
headers.php script sends a response that includes non ascii header value.
not-ascii-status.php sends a response that includes non ascii reason phrase.
Removed specific gtk/efl expectations as now aligned with regular expectation.
- http/tests/xmlhttprequest/resources/headers.php: Added.
- http/tests/xmlhttprequest/resources/not-ascii-status.php: Added.
- http/tests/xmlhttprequest/response-special-characters-expected.txt: Added.
- http/tests/xmlhttprequest/response-special-characters.html: Added.
- platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
- 1:07 AM Changeset in webkit [178327] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/LayoutTests/http/tests/multipart
Merge r176990 - REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313
Test by Antti Koivisto, reviewed and tweaked by Alexey Proskuryakov.
- http/tests/multipart/multipart-image-expected.html: Added.
- http/tests/multipart/multipart-image.html: Added.
- http/tests/multipart/resources/multipart.php: Multiopart boundary must start on
a new line, so make it so. In newwer OS versions, CFNetwork has a workaround that
makes invalid multipart response work, which is why the test was passing locally.
- 1:06 AM InspectorConsoleSelection created by
- 12:54 AM Changeset in webkit [178326] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176905 - REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.
LayoutTests:
We had no coverage for actually rendering multipart content.
- http/tests/multipart/multipart-image-expected.html: Added.
- http/tests/multipart/multipart-image.html: Added.
- 12:49 AM Changeset in webkit [178325] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176903 - Directional single quotation marks are not rotated in vertical text
https://bugs.webkit.org/show_bug.cgi?id=138526
Source/WebCore:
Reviewed by Darin Adler.
In vertical text, directional single quotation marks are not rotated along with
the rest of the letters.
Test: fast/text/vertical-quotation-marks.html
- platform/graphics/FontGlyphs.cpp:
(WebCore::shouldIgnoreRotation):
LayoutTests:
Compare vertical and horizontal renderings.
Reviewed by Darin Adler.
- fast/text/vertical-quotation-marks-expected.html: Added.
- fast/text/vertical-quotation-marks.html: Added.
- 12:44 AM Changeset in webkit [178324] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176874 - Issue repaint at setUnavailablePluginIndicatorIsHidden() only when embedded object's indicator status changes.
https://bugs.webkit.org/show_bug.cgi?id=139311
Reviewed by Tim Horton.
Not testable.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsHidden):
- 12:44 AM WebKitGTK/2.6.x edited by
- (diff)
- 12:32 AM Changeset in webkit [178323] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r176824 - REGRESSION(r173188): Text inserted when trying to delete a word from the Twitter message box.
<https://webkit.org/b/139076>
Reviewed by Geoffrey Garen.
The StringImpl* -> Weak<JSString> cache used by the DOM bindings
had a bug where the key could become a stale pointer if the cached
JSString had its internal StringImpl atomicized.
If a new StringImpl was then later constructed at the exact same
address as the stale key, before the Weak<JSString> got booted out
of the string cache, we'd now have a situation where asking the
string cache for that key would return the old JSString.
Solve this by not allowing JSString::toExistingAtomicString() to
change the JSString's internal StringImpl unless it's resolving a
rope string. (The StringImpl nullity determines rope state.)
This means that calling toExistingAtomicString() may now have to
query the AtomicString table on each call rather than just once.
All clients of this API would be forced to do this regardless,
since they return value will be used to key into containers with
AtomicStringImpl* keys.
No test because this relies on malloc putting two StringImpls
at the same address at different points in time and we have no
mechanism to reliably test that.
- runtime/JSString.h:
(JSC::JSString::toExistingAtomicString):
- 12:15 AM Changeset in webkit [178322] by
-
- 5 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176818 - REGRESSION (r173468): Cannot step in WebInspector
https://bugs.webkit.org/show_bug.cgi?id=139260
Reviewed by Alexey Proskuryakov.
Inspector defers all loads and starts a nested runloop when it hits a breakpoint. When continuing it undefers the loads.
If the script execution was triggered from the didFinishLoading callback of the main resource then the main resource would
already be in the finished state in the network process side and setDefersLoading(false) message would end up restarting its load.
Since loads are not meant to restart the generated callbacks would assert or crash the web process when handled in the next
nested inspector runloop.
Fix by taking care that cleaned up NetworkResourceLoaders are always removed from the loader map of
the NetworkConnectionToWebProcess and so can't end up handling late messages.
No test, this requires JS debugger to trigger.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader):
This is now the only way to remove resource loaders.
It is called from NetworkResourceLoader::cleanup only.
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
Calling abort removes the resource loader (since it calls cleanup) so no need to do it explicitly anymore.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
We are guaranteed to be reffed by NetworkConnectionToWebProcess until cleanup so the explicit ref/deref can be removed.
(WebKit::NetworkResourceLoader::cleanup):
Call to NetworkConnectionToWebProcess::didCleanupResourceLoader to make the loader unreachable.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::identifier):
- 12:14 AM Changeset in webkit [178321] by
-
- 4 edits6 adds in releases/WebKitGTK/webkit-2.6
Merge r176816 - Groove/inset/outset borders show solid if the color is black
https://bugs.webkit.org/show_bug.cgi?id=58608
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/borders/mixed-border-style2.html
This patch will lighten/darken the border side colors, handling
border decoration in a similar way as Firefox does.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::calculateBorderStyleColor):
- rendering/RenderObject.h:
LayoutTests:
- fast/borders/mixed-border-style2.html: Added.
- platform/mac-mavericks/fast/borders/mixed-border-style2-expected.png: Added.
- platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt: Added.
- 12:05 AM Changeset in webkit [178320] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6/Source
Merge r176803 - Serialization of MapData object provides unsafe access to internal types
https://bugs.webkit.org/show_bug.cgi?id=138653
Patch by Oliver Hunt <oliver@apple.com> on 2014-12-04
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Converting these ASSERTs into RELEASE_ASSERTs, as it is now obvious
that despite trying hard to be safe in all cases it's simply to easy
to use an iterator in an unsafe state.
- runtime/MapData.h:
(JSC::MapData::const_iterator::key):
(JSC::MapData::const_iterator::value):
Source/WebCore:
We now keep the value portion of the key/value pair in MapData as a
separate stack. This allows us to maintain the spec semantic of
"atomic" serialisation of the key/value pair without retaining the
use of a potentially invalid iterator.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
- 12:00 AM Changeset in webkit [178319] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6
Merge r176787 - can not find cairo-gl.h when build webkit with gtk on ubuntu 14.04
https://bugs.webkit.org/show_bug.cgi?id=136576
Reviewed by Carlos Garcia Campos.
CMake should complain if Accelerated 2D Canvas is explicitly
enabled but cairo-gl is not found.
- Source/cmake/OptionsGTK.cmake:
Jan 12, 2015:
- 11:58 PM Changeset in webkit [178318] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176768 - List markers in RTL languages do not draw the first character.
https://bugs.webkit.org/show_bug.cgi?id=139244
Reviewed by Simon Fraser.
Source/WebCore:
Off-by-one error when reversing the string (from LTR to RTL)
Test: fast/lists/rtl-marker.html
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
LayoutTests:
- fast/lists/rtl-marker-expected.html: Added.
- fast/lists/rtl-marker.html: Added.
- 11:54 PM Changeset in webkit [178317] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176750 - ASSERTION: RenderMultiColumnFlowThread::processPossibleSpannerDescendant() when column spanner's parent is not a RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=139188
rdar://problem/18502182
Reviewed by David Hyatt.
This patch ensures that the validation check for spanner in isValidColumnSpanner() is in synch
with the expectation in RenderMultiColumnFlowThread::processPossibleSpannerDescendant().
(descendant's parent is expected to be a RenderBlockFlow)
Source/WebCore:
Test: fast/multicol/svg-content-as-column-spanner-crash.html
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::isValidColumnSpanner):
LayoutTests:
- fast/multicol/svg-content-as-column-spanner-crash-expected.txt: Added.
- fast/multicol/svg-content-as-column-spanner-crash.html: Added.
- 10:23 PM Changeset in webkit [178316] by
-
- 2 edits in trunk/Tools
[EFL][GTK] Fix build after r178309
https://bugs.webkit.org/show_bug.cgi?id=140381
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-12
Reviewed by Gyuyoung Kim.
- TestWebKitAPI/CMakeLists.txt: Added the API directory
- 9:18 PM Changeset in webkit [178315] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline: when Network Requests view is selected, in progress requests are absent.
https://bugs.webkit.org/show_bug.cgi?id=140090
Reviewed by Timothy Hatcher.
TimelineContentView#_updateTimes() changed to call WebInspector.timelineSidebarPanel.updateFilter() in addition
to updating the layout of the current timeline view. TimelineSidebarPanel.updateFilter() now responsible for
updating filtered resources in a TimelineView.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
Now handles updating the UI associated with filtering of navigation sidebar tree elements.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.updateLayout):
No longer handles updating other UI along with the navigation sidebar tree elements. That is now handled by
WebInspector.TimelineView.prototype.filterUpdated.
(WebInspector.OverviewTimelineView.prototype._compareTreeElementsByDetails): Drive-by fix. Missing vars.
- UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._updateTimes): Add call to updateFilter().
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.filterUpdated):
Function added to dispatch a SelectionPathComponentsDidChange event.
- 7:26 PM Changeset in webkit [178314] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo in r178313
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::GraphBuilder::atomPatternCharacter):
- 5:37 PM Changeset in webkit [178313] by
-
- 10 edits2 adds in trunk/Source
Add basic pattern matching support to the url filters
https://bugs.webkit.org/show_bug.cgi?id=140283
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
Make YarrParser.h private in order to use it from WebCore.
Source/WebCore:
This patch adds some basic generic pattern support for the url filters
of ContentExtensions.
Instead of writting a new parser, I re-used Gavin's parser for JavaScript
RegExp.
This patch only implements the very basic stuffs: transition on any character
and repetition.
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::setRuleList):
Use the new parser.
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::DFA):
(WebCore::ContentExtensions::printRange):
(WebCore::ContentExtensions::printTransition):
(WebCore::ContentExtensions::DFA::debugPrintDot):
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::printRange):
(WebCore::ContentExtensions::printTransition):
(WebCore::ContentExtensions::NFA::debugPrintDot):
The graphs generated with the extended patterns are vastly more complicated
than the old prefix matcher.
I changed the debug output to have a single link between any two nodes
instead of one per transition. This makes the graph a little more manageable.
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::addTransition):
(WebCore::ContentExtensions::NFA::addEpsilonTransition):
(WebCore::ContentExtensions::NFA::graphSize):
(WebCore::ContentExtensions::NFA::restoreToGraphSize):
- contentextensions/NFA.h:
- contentextensions/NFANode.h:
(WebCore::ContentExtensions::epsilonClosure):
The new parser can generate transitions back to the root node of index zero.
All the hash structures had to be updated to support this kind of key.
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::HashableNodeIdSetHash::hash):
Two tiny improvements:
-Don't hash zero to zero, it causes more conflicts that needed.
-The hash operation must use a commutative operation, otherwise the order
of elements can affect the hash, which is undesired for a set.
I'll improve this further later.
(WebCore::ContentExtensions::NFAToDFA::convert):
- contentextensions/URLFilterParser.cpp: Added.
(WebCore::ContentExtensions::GraphBuilder::GraphBuilder):
(WebCore::ContentExtensions::GraphBuilder::m_lastAtom):
(WebCore::ContentExtensions::GraphBuilder::finalize):
(WebCore::ContentExtensions::GraphBuilder::errorMessage):
(WebCore::ContentExtensions::GraphBuilder::atomPatternCharacter):
(WebCore::ContentExtensions::GraphBuilder::atomBuiltInCharacterClass):
(WebCore::ContentExtensions::GraphBuilder::quantifyAtom):
(WebCore::ContentExtensions::GraphBuilder::atomBackReference):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassAtom):
(WebCore::ContentExtensions::GraphBuilder::assertionBOL):
(WebCore::ContentExtensions::GraphBuilder::assertionEOL):
(WebCore::ContentExtensions::GraphBuilder::assertionWordBoundary):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassBegin):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassRange):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassBuiltIn):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassEnd):
(WebCore::ContentExtensions::GraphBuilder::atomParenthesesSubpatternBegin):
(WebCore::ContentExtensions::GraphBuilder::atomParentheticalAssertionBegin):
(WebCore::ContentExtensions::GraphBuilder::atomParenthesesEnd):
(WebCore::ContentExtensions::GraphBuilder::disjunction):
(WebCore::ContentExtensions::GraphBuilder::hasError):
(WebCore::ContentExtensions::GraphBuilder::fail):
(WebCore::ContentExtensions::URLFilterParser::parse):
- contentextensions/URLFilterParser.h:
(WebCore::ContentExtensions::URLFilterParser::hasError):
(WebCore::ContentExtensions::URLFilterParser::errorMessage):
- 5:20 PM Changeset in webkit [178312] by
-
- 2 edits in trunk/Source/WebKit2
[CMake] Unreviewed build fix after r178309.
- CMakeLists.txt: Rename moved files at r178309.
- 5:04 PM Changeset in webkit [178311] by
-
- 2 edits in trunk/Source/JavaScriptCore
Out of bounds read in IdentifierArena::makeIdentifier
https://bugs.webkit.org/show_bug.cgi?id=140376
Patch by Alexey Proskuryakov.
Reviewed and ChangeLogged by Geoffrey Garen.
No test, since this is a small past-the-end read, which is very
difficult to turn into a reproducible failing test -- and existing tests
crash reliably using ASan.
- parser/ParserArena.h:
(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar): Check for a
zero-length string input, like we do in the literal parser, since it is
not valid to dereference characters in a zero-length string.
A zero-length string is allowed in JavaScript -- for example, "".
- 4:40 PM Changeset in webkit [178310] by
-
- 82 edits116 deletes in trunk
Remove support for SharedWorkers
https://bugs.webkit.org/show_bug.cgi?id=140344
Reviewed by Anders Carlsson.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled): Deleted.
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSSharedWorkerCustom.cpp: Removed.
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::toJSWorkerGlobalScope):
(WebCore::toJSSharedWorkerGlobalScope): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/preprocess-idls.pl:
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
- dom/EventTarget.h:
- dom/EventTargetFactory.in:
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- loader/FrameLoader.cpp:
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessLocalStorage):
(WebCore::SecurityOrigin::canAccessSharedWorkers): Deleted.
- platform/FeatureCounterKeys.h:
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::sharedWorkerStrategy): Deleted.
- workers/DefaultSharedWorkerRepository.cpp: Removed.
- workers/DefaultSharedWorkerRepository.h: Removed.
- workers/SharedWorker.cpp: Removed.
- workers/SharedWorker.h: Removed.
- workers/SharedWorker.idl: Removed.
- workers/SharedWorkerGlobalScope.cpp: Removed.
- workers/SharedWorkerGlobalScope.h: Removed.
- workers/SharedWorkerGlobalScope.idl: Removed.
- workers/SharedWorkerRepository.cpp: Removed.
- workers/SharedWorkerRepository.h: Removed.
- workers/SharedWorkerStrategy.h: Removed.
- workers/SharedWorkerThread.cpp: Removed.
- workers/SharedWorkerThread.h: Removed.
- workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::isSharedWorkerGlobalScope): Deleted.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createSharedWorkerStrategy): Deleted.
- NetworkProcess/NetworkProcessPlatformStrategies.h:
- WebKit2Prefix.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
(WebKit::WebPlatformStrategies::isAvailable): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Remove shared worker specific tests and update others to remove references to shared workers.
- fast/constructors/constructor-as-function-crash-expected.txt:
- fast/constructors/constructor-as-function-crash.html:
- fast/dom/call-a-constructor-as-a-function-expected.txt:
- fast/dom/call-a-constructor-as-a-function.html:
- fast/workers/resources/create-shared-worker-frame.html: Removed.
- fast/workers/resources/shared-worker-common.js: Removed.
- fast/workers/resources/shared-worker-count-connections.js: Removed.
- fast/workers/resources/shared-worker-create-common.js: Removed.
- fast/workers/resources/shared-worker-exception.js: Removed.
- fast/workers/resources/shared-worker-iframe.html: Removed.
- fast/workers/resources/shared-worker-lifecycle.js: Removed.
- fast/workers/resources/shared-worker-name.js: Removed.
- fast/workers/resources/shared-worker-script-error.js: Removed.
- fast/workers/shared-worker-constructor-expected.txt: Removed.
- fast/workers/shared-worker-constructor.html: Removed.
- fast/workers/shared-worker-context-gc-expected.txt: Removed.
- fast/workers/shared-worker-context-gc.html: Removed.
- fast/workers/shared-worker-event-listener-expected.txt: Removed.
- fast/workers/shared-worker-event-listener.html: Removed.
- fast/workers/shared-worker-exception-expected.txt: Removed.
- fast/workers/shared-worker-exception.html: Removed.
- fast/workers/shared-worker-frame-lifecycle-expected.txt: Removed.
- fast/workers/shared-worker-frame-lifecycle.html: Removed.
- fast/workers/shared-worker-gc-expected.txt: Removed.
- fast/workers/shared-worker-gc.html: Removed.
- fast/workers/shared-worker-in-iframe-expected.txt: Removed.
- fast/workers/shared-worker-in-iframe.html: Removed.
- fast/workers/shared-worker-lifecycle-expected.txt: Removed.
- fast/workers/shared-worker-lifecycle.html: Removed.
- fast/workers/shared-worker-load-error-expected.txt: Removed.
- fast/workers/shared-worker-load-error.html: Removed.
- fast/workers/shared-worker-location-expected.txt: Removed.
- fast/workers/shared-worker-location.html: Removed.
- fast/workers/shared-worker-messageevent-source-expected.txt: Removed.
- fast/workers/shared-worker-messageevent-source.html: Removed.
- fast/workers/shared-worker-name-expected.txt: Removed.
- fast/workers/shared-worker-name.html: Removed.
- fast/workers/shared-worker-navigator-expected.txt: Removed.
- fast/workers/shared-worker-navigator.html: Removed.
- fast/workers/shared-worker-replace-global-constructor-expected.txt: Removed.
- fast/workers/shared-worker-replace-global-constructor.html: Removed.
- fast/workers/shared-worker-replace-self-expected.txt: Removed.
- fast/workers/shared-worker-replace-self.html: Removed.
- fast/workers/shared-worker-script-error-expected.txt: Removed.
- fast/workers/shared-worker-script-error.html: Removed.
- fast/workers/shared-worker-shared-expected.txt: Removed.
- fast/workers/shared-worker-shared.html: Removed.
- fast/workers/shared-worker-simple-expected.txt: Removed.
- fast/workers/shared-worker-simple.html: Removed.
- fast/workers/shared-worker-storagequota-query-usage-expected.txt: Removed.
- fast/workers/shared-worker-storagequota-query-usage.html: Removed.
- fast/workers/worker-crash-with-invalid-location-expected.txt:
- fast/workers/worker-crash-with-invalid-location.html:
- http/tests/resources/js-test-pre.js:
(startWorker):
(.worker.port.onmessage): Deleted.
(.self.onconnect.workerPort.onmessage): Deleted.
(.self.onconnect): Deleted.
- http/tests/security/contentSecurityPolicy/resources/shared-worker-make-xhr.js: Removed.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-allowed.html: Removed.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked.html: Removed.
- http/tests/security/cross-origin-shared-worker-allowed-expected.txt: Removed.
- http/tests/security/cross-origin-shared-worker-allowed.html: Removed.
- http/tests/security/cross-origin-shared-worker-expected.txt: Removed.
- http/tests/security/cross-origin-shared-worker.html: Removed.
- http/tests/security/resources/cross-origin-iframe-for-shared-worker.html: Removed.
- http/tests/security/resources/iframe-for-storage-blocking-changed-shared-worker.html: Removed.
- http/tests/security/resources/shared-worker.js: Removed.
- http/tests/security/same-origin-shared-worker-blocked-expected.txt: Removed.
- http/tests/security/same-origin-shared-worker-blocked.html: Removed.
- http/tests/security/storage-blocking-loosened-shared-worker-expected.txt: Removed.
- http/tests/security/storage-blocking-loosened-shared-worker.html: Removed.
- http/tests/security/storage-blocking-strengthened-shared-worker-expected.txt: Removed.
- http/tests/security/storage-blocking-strengthened-shared-worker.html: Removed.
- http/tests/websocket/tests/hybi/workers/close-in-shared-worker-expected.txt: Removed.
- http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html: Removed.
- http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt: Removed.
- http/tests/websocket/tests/hybi/workers/shared-worker-simple.html: Removed.
- http/tests/workers/shared-worker-importScripts-expected.txt: Removed.
- http/tests/workers/shared-worker-importScripts.html: Removed.
- http/tests/workers/shared-worker-invalid-url-expected.txt: Removed.
- http/tests/workers/shared-worker-invalid-url.html: Removed.
- http/tests/workers/shared-worker-redirect-expected.txt: Removed.
- http/tests/workers/shared-worker-redirect.html: Removed.
- http/tests/xmlhttprequest/workers/resources/shared-worker-create.js: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-close-expected.txt: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-close.html: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async.html: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-methods.html: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-referer.html: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found-expected.txt: Removed.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html: Removed.
- js/dom/constructor-length.html:
- js/dom/global-constructors-attributes-expected.txt:
- js/dom/global-constructors-attributes-shared-worker-expected.txt: Removed.
- js/dom/global-constructors-attributes-shared-worker.html: Removed.
- platform/efl/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
- platform/efl/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Removed.
- platform/efl/js/dom/constructor-length-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Removed.
- platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
- platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Removed.
- platform/gtk/js/dom/constructor-length-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/ios-sim-deprecated/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/ios-sim-deprecated/fast/js/constructor-length-expected.txt:
- platform/ios-sim-deprecated/fast/js/global-constructors-expected.txt:
- platform/ios-sim-deprecated/fast/workers/shared-worker-storagequota-query-usage-expected.txt: Removed.
- platform/ios-sim-deprecated/http/tests/security/cross-origin-shared-worker-allowed-expected.txt: Removed.
- platform/ios-sim-deprecated/http/tests/security/cross-origin-shared-worker-expected.txt: Removed.
- platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt:
- platform/ios-sim-deprecated/storage/indexeddb/basics-shared-workers-expected.txt: Removed.
- platform/ios-simulator/js/dom/constructor-length-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk2/TestExpectations:
- platform/mac/js/dom/constructor-length-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt: Removed.
- resources/js-test-pre.js:
(startWorker):
(.worker.port.onmessage): Deleted.
(.self.onconnect.workerPort.onmessage): Deleted.
(.self.onconnect): Deleted.
- resources/js-test.js:
(startWorker):
(.worker.port.onmessage): Deleted.
(.self.onconnect.workerPort.onmessage): Deleted.
(.self.onconnect): Deleted.
- storage/indexeddb/basics-shared-workers-expected.txt: Removed.
- storage/indexeddb/basics-shared-workers.html: Removed.
- 4:35 PM Changeset in webkit [178309] by
-
- 2 edits6 moves in trunk/Source/WebKit2
Move a couple of API files to UIProcess/API.
Rubber-stamped by Tim Horton.
- UIProcess/API/APINavigationData.cpp: Renamed from Source/WebKit2/UIProcess/APINavigationData.cpp.
- UIProcess/API/APINavigationData.h: Renamed from Source/WebKit2/UIProcess/APINavigationData.h.
- UIProcess/API/APIProcessPoolConfiguration.cpp: Renamed from Source/WebKit2/UIProcess/APIProcessPoolConfiguration.cpp.
- UIProcess/API/APIProcessPoolConfiguration.h: Renamed from Source/WebKit2/UIProcess/APIProcessPoolConfiguration.h.
- UIProcess/API/APISession.cpp: Renamed from Source/WebKit2/UIProcess/APISession.cpp.
- UIProcess/API/APISession.h: Renamed from Source/WebKit2/UIProcess/APISession.h.
- WebKit2.xcodeproj/project.pbxproj:
- 4:35 PM Changeset in webkit [178308] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r178029): [GTK][EFL] Caused no-backing-for-clip-overlap test failures
https://bugs.webkit.org/show_bug.cgi?id=140336
Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-12
Reviewed by Simon Fraser.
Avoid creating childClippingMaskLayer when renderer has not border radius nor clip path.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateChildClippingStrategy):
- 4:30 PM Changeset in webkit [178307] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Push content bounds on layer tree commit to prevent drawing stale fixed position rects
https://bugs.webkit.org/show_bug.cgi?id=140264
<rdar://problem/18873545>
Reviewed by Benjamin Poulain.
When a resize occurs, we need to push the new content bounds to the web
process or stale fixed position rects may draw incorrectly.
As an example, suppose that WKWebView in UIProcess performs
_frameOrBoundsChanged with new view bounds.
Meanwhile, we'll switch to WebContentProcess and perform layout.
Switching back to UIProcess, _frameOrBoundsChanged calls WKWebView
_updateVisibleContentRects.
_updateVisibleContentRects calls WKContentView didUpdateVisibleRect with
the new bounds.
didUpdateVisibleRects in turn calls WebPageProxyIOS
computeCustomFixedPositionRect.
computeCustomFixedPositionRect asks for the content bounds from
PageClientImplIOS contentsSize which queries WKContentView's bounds
size. But those bounds are stale because the layer tree commit hasn't
occurred yet.
By informing the WKWebView of the updated content size on layer tree
commit, we ensure that the fixed position rects will be drawn correctly.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLayerTree:]): Push new content bounds to the web process.
- 4:30 PM Changeset in webkit [178306] by
-
- 2 edits in trunk/Source/WebCore
[Apple] Squelch stderr log regarding negative stroke thickness
https://bugs.webkit.org/show_bug.cgi?id=140372
<rdar://problem/19426485>
Reviewed by Eric Carlson.
No new tests because there is no visible behavior change.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformStrokeThickness):
- 4:25 PM Changeset in webkit [178305] by
-
- 5 edits in trunk/Source
Get rid of unnecessary reimplementations of CGFloor/Ceiling
https://bugs.webkit.org/show_bug.cgi?id=140375
Reviewed by Simon Fraser.
- platform/mac/DragImageMac.mm:
(WebCore::widthWithFont):
(WebCore::drawAtPoint):
(WebCore::webkit_CGCeiling): Deleted.
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
(webkit_CGFloor): Deleted.
Delete unnecessary code, use the real CGFloor/Ceiling instead.
- Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(webkit_CGCeiling): Deleted.
Delete unnecessary code, use the real CGFloor/Ceiling instead.
- 3:57 PM Changeset in webkit [178304] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r177656): Text in find-in-page yellow bouncy rectangle is not crisp
https://bugs.webkit.org/show_bug.cgi?id=140373
<rdar://problem/19447156>
Reviewed by Simon Fraser.
- page/mac/TextIndicatorWindow.mm:
(WebCore::TextIndicatorWindow::setTextIndicator):
Expand the window margin to the nearest integer.
The window was already being pixel-snapped, but then we'd translate by
the non-integral margin when building up the layer tree.
It's OK to do this on 2x because it's fine to have the margin be bigger
than needed.
- platform/spi/cg/CoreGraphicsSPI.h:
Add a CGCeiling to match CGFloor.
- 3:53 PM Changeset in webkit [178303] by
-
- 2 edits in trunk/Source/WebCore
Guard web thread stuff with USE(WEB_THREAD) instead of PLATFORM(IOS).
Dan pointed out that we should guard WebThreadIsLockedOrDisabled() with
USE(WEB_THREAD) to communicate our ambitions to someday have an iOS
build of WebKit that doesn't need any of that.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::resume):
- 3:42 PM Changeset in webkit [178302] by
-
- 2 edits in trunk/Source/WebCore
Fix build for non-iOS platforms. :|
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::resume):
- 3:32 PM Changeset in webkit [178301] by
-
- 2 edits in trunk/Source/WebCore
[Freetype] Don't use non-scalable fonts.
https://bugs.webkit.org/show_bug.cgi?id=31931
Reviewed by Martin Robinson.
No new tests needed.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData): Prefer scalable fonts.
- 3:14 PM Changeset in webkit [178300] by
-
- 5 edits2 moves1 add7 deletes in trunk
Geolocation objects shouldn't prevent page caching.
<https://webkit.org/b/140369>
Reviewed by Joseph Pecoraro.
Source/WebCore:
Enable the code for suspend/resume of Geolocation objects on all platforms
instead of just iOS. This allows pages using geolocation to use page cache
instead of reloading on back/forward navigation.
Test: fast/history/page-cache-geolocation.html
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::setError):
- Modules/geolocation/Geolocation.h:
LayoutTests:
Take the existing test for this and make it not-specific-to-iOS.
Also remove a test whose only purpose was confirming that we don't cache these pages.
- fast/dom/Geolocation/no-page-cache-expected.txt: Removed.
- fast/dom/Geolocation/no-page-cache.html: Removed.
- fast/dom/Geolocation/script-tests/no-page-cache.js: Removed.
- fast/history/page-cache-geolocation-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/history/page-cache-geolocation-expected.txt.
- fast/history/page-cache-geolocation.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/history/script-tests/page-cache-geolocation.js.
- fast/history/resources/page-cache-helper.html: Added.
- platform/ios-sim-deprecated/iphone/fast/history/page-cache-geolocation-expected.txt: Removed.
- platform/ios-sim-deprecated/iphone/fast/history/page-cache-geolocation.html: Removed.
- platform/ios-sim-deprecated/iphone/fast/history/script-tests/page-cache-geolocation.js: Removed.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/ios/fast/history/page-cache-geolocation.html: Removed.
- 2:40 PM Changeset in webkit [178299] by
-
- 1 edit1 add9 deletes in trunk/LayoutTests
Make fast/css/first-letter-skip-out-of-flow.html a ref-test
https://bugs.webkit.org/show_bug.cgi?id=140324
Reviewed by Andreas Kling.
- fast/css/first-letter-skip-out-of-flow-expected.html: Added.
- platform/efl/fast/css/first-letter-skip-out-of-flow-expected.png: Removed.
- platform/efl/fast/css/first-letter-skip-out-of-flow-expected.txt: Removed.
- platform/gtk/fast/css/first-letter-skip-out-of-flow-expected.png: Removed.
- platform/gtk/fast/css/first-letter-skip-out-of-flow-expected.txt: Removed.
- platform/ios-sim-deprecated/fast/css/first-letter-skip-out-of-flow-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/css/first-letter-skip-out-of-flow-expected.txt: Removed.
- platform/mac-mountainlion/fast/css/first-letter-skip-out-of-flow-expected.txt: Removed.
- platform/mac/fast/css/first-letter-skip-out-of-flow-expected.png: Removed.
- platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Removed.
- 2:30 PM Changeset in webkit [178298] by
-
- 4 edits in trunk/Source/WebCore
Log navigation types using DiagnosticLoggingClient
https://bugs.webkit.org/show_bug.cgi?id=140323
Reviewed by Darin Adler.
Log navigation types using DiagnosticLoggingClient to help us understand
what types of navigations are common and give us an estimate on the
total number of navigations.
- loader/FrameLoader.cpp:
(WebCore::logNavigation):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::logNavigationWithFeatureCounter): Deleted.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::navigationKey):
- page/DiagnosticLoggingKeys.h:
- 2:02 PM Changeset in webkit [178297] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: ASSERT under WebCore::InspectorResourceAgent::loadResource
https://bugs.webkit.org/show_bug.cgi?id=140367
Reviewed by Andreas Kling.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::loadResource): use copyRef() instead of move(),
since we check the callback after giving it to the loader client.
- 1:58 PM Changeset in webkit [178296] by
-
- 10 edits in trunk/Source/WebCore
Move DatabaseBackend functions back to Database
https://bugs.webkit.org/show_bug.cgi?id=140368
Reviewed by Sam Weinig.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::runTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::inProgressTransactionCompleted):
(WebCore::Database::transactionClient):
(WebCore::Database::transactionCoordinator):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::openAndVerifyVersion): Deleted.
(WebCore::DatabaseBackend::performOpenAndVerify): Deleted.
(WebCore::DatabaseBackend::close): Deleted.
(WebCore::DatabaseBackend::runTransaction): Deleted.
(WebCore::DatabaseBackend::inProgressTransactionCompleted): Deleted.
(WebCore::DatabaseBackend::scheduleTransaction): Deleted.
(WebCore::DatabaseBackend::scheduleTransactionStep): Deleted.
(WebCore::DatabaseBackend::transactionClient): Deleted.
(WebCore::DatabaseBackend::transactionCoordinator): Deleted.
- Modules/webdatabase/DatabaseBackend.h:
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):
- Modules/webdatabase/DatabaseThread.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionBackend.h:
(WebCore::SQLTransactionBackend::database):
- 1:41 PM Changeset in webkit [178295] by
-
- 1 copy in tags/Safari-600.1.4.15.1
New tag.
- 1:12 PM Changeset in webkit [178294] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comment after r178292
https://bugs.webkit.org/show_bug.cgi?id=136769
Unreviewed.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
- 1:07 PM Changeset in webkit [178293] by
-
- 40 edits in trunk
Make delegates conform to formal delegate protocols
https://bugs.webkit.org/show_bug.cgi?id=140370
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- DefaultDelegates/WebDefaultPolicyDelegate.h:
- WebCoreSupport/WebInspectorClient.mm:
Add protocols to the interface declarations.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _updateImmediateActionItem]):
(-[WebImmediateActionController _menuItemForDataDetectedText]):
Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::setGeolocationPermission):
- 12:55 PM Changeset in webkit [178292] by
-
- 15 edits in trunk/Source
Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
https://bugs.webkit.org/show_bug.cgi?id=136769
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
If ENABLE(SVG_OTF_CONVERTER) is defined, use the converter. It can be defined at the same
time as ENABLE(SVG_FONTS) but, if so, the SVG font code will be dead code.
No new tests because the define is off by default. Tests will come soon, I promise.
- Configurations/FeatureDefines.xcconfig:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): When creating a font, if the ENABLE is on,
do the transcode and take the non-SVG path.
(WebCore::CSSFontFaceSource::ensureFontData): Pass extra arguments to
CachedFont::ensureCustomFontData()
- css/CSSFontFaceSource.h: For the case of in-document SVG fonts, keep the transcoded
bytes around.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData): For out-of-document SVG fonts, do the
transcode if the ENABLE is on, then treat as if the font is any old webfont.
(WebCore::CachedFont::getSVGFontById): This function looks up the relevant <font>
element. Modify it to take a pointer to a (possibly external) document within which
to search.
- loader/cache/CachedFont.h: Extra arguments to CachedFont::ensureCustomFontData()
and CachedFont::getSVGFontById()
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 12:22 PM Changeset in webkit [178291] by
-
- 6 edits in trunk/Source
Clean up FrameTree::traverseNext() traversals of main frames
https://bugs.webkit.org/show_bug.cgi?id=140338
Reviewed by Andreas Kling.
There's no reason to pass the main frame as the stayWithin parameter
to FrameTree::traverseNext() when traversing over that same main frame.
Source/WebCore:
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::searchInResources):
- replay/SerializationMethods.cpp:
(WebCore::frameIndexFromFrame):
(WebCore::frameFromFrameIndex):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithSpotlight):
- 12:22 PM Changeset in webkit [178290] by
-
- 10 edits in trunk/Source
Multi-rect TextIndicators are vertically flipped in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=140350
<rdar://problem/19441243>
Reviewed by Beth Dakin.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
(WebCore::TextIndicator::TextIndicator):
- page/TextIndicator.h:
(WebCore::TextIndicator::selectionRectInRootViewCoordinates):
(WebCore::TextIndicator::textBoundingRectInRootViewCoordinates):
(WebCore::TextIndicator::selectionRectInWindowCoordinates): Deleted.
(WebCore::TextIndicator::textBoundingRectInWindowCoordinates): Deleted.
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(WebCore::TextIndicatorWindow::setTextIndicator):
Compute, store, and use TextIndicator's selectionRect and textBoundingRect
in root view coordinates instead of window coordinates; this way, each
WebKit can do the conversion itself, and the rootView vs. window flipping
isn't wrongly factored into textRectsInBoundingRectCoordinates.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
Adjust to the field name changes.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setTextIndicator:fadeOut:]):
Convert the textBoundingRect from root view to screen coordinates.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
Adjust to the new name, and use contentsToRootView when comparing against
the stored m_findIndicatorRect.
- WebView/WebView.mm:
(-[WebView _setTextIndicator:fadeOut:]):
Convert the textBoundingRect from root view to screen coordinates.
- 12:02 PM Changeset in webkit [178289] by
-
- 15 edits2 deletes in trunk
Unreviewed, rolling out r178281.
https://bugs.webkit.org/show_bug.cgi?id=140366
Broke many media tests (Requested by ap on #webkit).
Reverted changeset:
"defaultPlaybackRate not respected when set before source is
loaded"
https://bugs.webkit.org/show_bug.cgi?id=140282
http://trac.webkit.org/changeset/178281
- 11:43 AM Changeset in webkit [178288] by
-
- 21 edits2 deletes in trunk/Source/WebCore
Merge DatabaseBackendContext into DatabaseContext
https://bugs.webkit.org/show_bug.cgi?id=140365
Reviewed by Antti Koivisto.
- CMakeLists.txt:
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
- Modules/webdatabase/DatabaseBackend.h:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
- Modules/webdatabase/DatabaseBackendBase.h:
(WebCore::DatabaseBackendBase::databaseContext):
- Modules/webdatabase/DatabaseBackendContext.cpp: Removed.
- Modules/webdatabase/DatabaseBackendContext.h: Removed.
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::securityOrigin):
(WebCore::DatabaseContext::isContextThread):
(WebCore::DatabaseContext::backend): Deleted.
- Modules/webdatabase/DatabaseContext.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::interruptAllDatabasesForContext):
(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
- Modules/webdatabase/SQLTransactionClient.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 10:50 AM Changeset in webkit [178287] by
-
- 2 edits in trunk/Source/WebKit/mac
Make WebResourceDelegate a formal protocol as well
https://bugs.webkit.org/show_bug.cgi?id=140364
Reviewed by Dan Bernstein.
- WebView/WebResourceLoadDelegate.h:
- 10:47 AM Changeset in webkit [178286] by
-
- 4 edits1 add in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r176676 - Fixes inline cache fast path accessing nonexistant getters.
<rdar://problem/18416918>
https://bugs.webkit.org/show_bug.cgi?id=136961
Reviewed by Filip Pizlo.
Fixes a bug in inline caching where getters would have been able to
modify the property they are getting during
building the inline cache and then accessing that
property through the inline cache site causing a recursive
inline cache building and allowing the fast path of the cache to
try to load a getter for the property that no longer exists.
- jit/JITOperations.cpp: Switched use of get to getPropertySlot.
- runtime/JSCJSValue.h:
added getPropertySlot for when you don't want to perform the get quite yet but want
to fill out the slot.
- runtime/JSCJSValueInlines.h: Added implementation for getPropertySlot
(JSC::JSValue::get): changed to simply call getPropertySlot
(JSC::JSValue::getPropertySlot): added.
- tests/stress/recursive_property_redefine_during_inline_caching.js: Added test case for bug.
(test):
- 10:41 AM Changeset in webkit [178285] by
-
- 7 edits in trunk/Source/WebKit/mac
Delegates should be formal protocols
https://bugs.webkit.org/show_bug.cgi?id=140360
rdar://problem/17380856
Reviewed by Dan Bernstein.
This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
- DefaultDelegates/WebDefaultUIDelegate.h:
- Misc/WebDownload.h:
- WebView/WebEditingDelegate.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebUIDelegate.h:
- 10:26 AM Changeset in webkit [178284] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r178266.
https://bugs.webkit.org/show_bug.cgi?id=140363
Broke a JSC test (Requested by ap on #webkit).
Reverted changeset:
"Local JSArray* "keys" in objectConstructorKeys() is not
marked during garbage collection"
https://bugs.webkit.org/show_bug.cgi?id=140348
http://trac.webkit.org/changeset/178266
- 10:20 AM Changeset in webkit [178283] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r176624 - Crash (integer overflow) beneath ByteCodeParser::handleGetById typing in search field on weather.com
https://bugs.webkit.org/show_bug.cgi?id=139165
Reviewed by Oliver Hunt.
If we don't have any getById or putById variants, emit non-cached versions of these operations.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
- 10:17 AM Changeset in webkit [178282] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176619 - Twitter avatar moves when hovering/unhovering the "follow" button.
https://bugs.webkit.org/show_bug.cgi?id=139147
rdar://problem/19096508
Reviewed by Simon Fraser.
This patch ensures that the out of flow positioned render boxes (RenderReplaced) do not
get repositioned when their inline box wrappers move.
Ideally, out of flow positioned renderers do not have inline wrappers by the time we start
placing inline boxes, but in certain case (optimized code path for descendantsHaveSameLineHeightAndBaseline()),
they are still part of the inline box tree.
This patch prevents those renderer boxes from getting positioned as part of the inline box placement.
They will get removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().
Source/WebCore:
Test: fast/inline/out-of-flow-positioned-render-replaced-box-moves.html
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
LayoutTests:
- fast/inline/out-of-flow-positioned-render-replaced-box-moves-expected.html: Added.
- fast/inline/out-of-flow-positioned-render-replaced-box-moves.html: Added.
- 10:15 AM Changeset in webkit [178281] by
-
- 15 edits2 adds in trunk
defaultPlaybackRate not respected when set before source is loaded
https://bugs.webkit.org/show_bug.cgi?id=140282
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-defaultplaybackrate-before-load.html
When the HTMLMediaElement is notified that the media player's rate has changed, it asks
for the rate from MediaPlayer. However, MediaPlayer never requests the playback rate
from the underlying MediaPlayerPrivate; it just returns the last rate which was set, or
1 if no rate was set. HTMLMediaElement then sets its playbackRate to the returned
value. So the end result is that the value from defaultPlaybackRate is overwritten by
the default value of 1 in MediaPlayer.
Rather than caching the requested rate in MediaPlayer, cache the value reported by
MediaPlayer inside HTMLMediaElement. And instead of returning the reported playback
rate from HTMLMediaElement.playbackRate, just return the last value set. The reported
value is still used for estimating the current time during playback.
Add MediaPlayerPrivate interface method to return the current playback rate.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_reportedPlaybackRate.
(WebCore::HTMLMediaElement::effectivePlaybackRate): Return m_reportedPlaybackRate.
(WebCore::HTMLMediaElement::requestedPlaybackRate): Return m_playbackRate.
(WebCore::HTMLMediaElement::updatePlaybackRate): Use requestedPlaybackRate() instead
of effectivePlaybackRate();
(WebCore::HTMLMediaElement::ended): Ditto.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
(WebCore::HTMLMediaElement::endedPlayback): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Set m_reportedPlaybackRate.
(WebCore::HTMLMediaElement::mediaPlayerRequestedPlaybackRate): Return
requestedPlaybackRate() if playing and 0 if not.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Removed m_rate.
(WebCore::MediaPlayer::rate): Pass to MediaPlayerPrivate.
(WebCore::MediaPlayer::setRate): Do not cache the rate.
(WebCore::MediaPlayer::requestedRate): Added; ask HTMLMediaElement.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerRequestedPlaybackRate): Added.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::rate): Added.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
Do not cache the requested rate.
(WebCore::MediaPlayerPrivateAVFoundation::requestedRate): Pass to MediaPlayer.
(WebCore::MediaPlayerPrivateAVFoundation::setRate): Deleted.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::requestedRate): Deleted.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::setRate): Renamed from updateRate.
(WebCore::MediaPlayerPrivateAVFoundationCF::rate): Fetch the rate from the player.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setRateDouble): Renamed from updateRate.
(WebCore::MediaPlayerPrivateAVFoundationObjC::rate): Fetch the rate from the player.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::rate): Fetch the rate from the QTMovie.
LayoutTests:
- media/video-defaultplaybackrate-before-load-expected.txt: Added.
- media/video-defaultplaybackrate-before-load.html: Added.
- 10:10 AM Changeset in webkit [178280] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176574 - Crash when calling WKPageClose on the originated page from within createNewPage callback
https://bugs.webkit.org/show_bug.cgi?id=139099
<rdar://problem/19052564>
Reviewed by Sam Weinig.
Source/WebKit2:
Null check the namespace ID.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
Tools:
Add a test.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::createNewPage):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
- 10:09 AM Changeset in webkit [178279] by
-
- 9 edits2 deletes in trunk/Source/WebCore
Merge DatabaseBase into Database
https://bugs.webkit.org/show_bug.cgi?id=140345
Reviewed by Antti Koivisto.
- CMakeLists.txt:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::runTransaction):
(WebCore::Database::logErrorMessage):
- Modules/webdatabase/Database.h:
(WebCore::Database::scriptExecutionContext):
- Modules/webdatabase/DatabaseBackendBase.cpp:
- Modules/webdatabase/DatabaseBackendBase.h:
(WebCore::DatabaseBackendBase::setFrontend):
- Modules/webdatabase/DatabaseBase.cpp: Removed.
- Modules/webdatabase/DatabaseBase.h: Removed.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 10:06 AM Changeset in webkit [178278] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6
Merge r176565 - [CMake] Build failure against GStreamer git master
https://bugs.webkit.org/show_bug.cgi?id=138872
Reviewed by Csaba Osztrogon.
- Source/cmake/FindGStreamer.cmake: Simplified the
FIND_GSTREAMER_COMPONENT macro. Trust pkg-config for include
headers lookup, there's no need to do this manually. Also
explicitely check the version specified in GStreamer_FIND_VERSION.
- 10:04 AM Changeset in webkit [178277] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176561 - [GStreamer] HTTP source element lacks SCHEDULING query support
https://bugs.webkit.org/show_bug.cgi?id=139064
Reviewed by Carlos Garcia Campos.
No new tests, covered by http/tests/media/hls.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
to configure itself for adaptive streaming playback scenarios.
- 10:02 AM Changeset in webkit [178276] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176554 - CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057
Reviewed by Anders Carlsson.
No test, don't know how to repro.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
- 9:57 AM Changeset in webkit [178275] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI
Merge r176548 - Web Inspector: Update NavigationItemProbes icon for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=139074
Reviewed by Carlos Garcia Campos.
NavigationItemProbes was updated for the Mac port and we are now
having a similar ideogram in GTK+.
- UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
- 9:56 AM Changeset in webkit [178274] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176541 - [GStreamer] gstmpegts is not initialized
https://bugs.webkit.org/show_bug.cgi?id=139039
Reviewed by Carlos Garcia Campos.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer): Initialize the gstmpegts library.
- 9:55 AM WebKitGTK/2.6.x edited by
- (diff)
- 9:54 AM Changeset in webkit [178273] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176540 - [GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
https://bugs.webkit.org/show_bug.cgi?id=138833
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-25
Reviewed by Carlos Garcia Campos.
This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.
- PlatformGTK.cmake:
- 9:50 AM WebKitGTK/2.6.x edited by
- (diff)
- 9:48 AM Changeset in webkit [178272] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176519 - Webkit2 doesnt build on powerpc 32 bits
https://bugs.webkit.org/show_bug.cgi?id=130837
Reviewed by Carlos Garcia Campos.
Check if libatomic is needed in order to use std::atomic, and add
it to the list of WebKit2 libraries.
- PlatformGTK.cmake:
- 9:45 AM Changeset in webkit [178271] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r176506 - r176455: ASSERT(!m_vector.isEmpty()) in IntendedStructureChain.cpp(143)
https://bugs.webkit.org/show_bug.cgi?id=139000
Reviewed by Darin Adler.
Check that the chainCount is non-zero before using a StructureChain.
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- 9:28 AM Changeset in webkit [178270] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176458 - Crash when setting 'transition-delay' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138784
Reviewed by Sam Weinig.
Source/WebCore:
Update CSSPrimitiveValue::computeTime() to use primitiveType() instead
of m_primitiveUnitType so that it properly handles calculated values.
Without this, we would hit the ASSERT_NOT_REACHED() assertion in
computeTime() for calculated values.
Test: fast/css/transition-delay-calculated-value.html
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::computeTime):
LayoutTests:
Add a layout test to check that setting the 'transition-delay' CSS
property to a calculated value does not crash and works as intended.
- fast/css/transition-delay-calculated-value-expected.txt: Added.
- fast/css/transition-delay-calculated-value.html: Added.
- 8:54 AM Changeset in webkit [178269] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176171 - Crash when setting 'order' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138780
Reviewed by Darin Adler.
Source/WebCore:
CSS Calculated values were not handled by the CSS parser for 'order'
CSS property. As a result, using calculated values wouldn't work in
release builds and would hit an assertion in debug builds.
This patch updates the CSS parser to directly convert the
CSS Calculated value into a simple integer CSSPrimitiveValue for
'order' property. We could have marked CSS Calculated values as
valid in the CSS Parser instead but this would have brought issues:
- The calculated value needs to be adjusted to INT_MIN + 2 if it is less than that. This would force us to calculate the expression anyway.
- The StyleBuilder would need updating to properly handle CSS Calculated values for 'order'.
Test: fast/css/order-calculated-value.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
Add a layout test to validate that setting a calculated value to the
'order' CSS property does not crash and behaves as expected.
- fast/css/order-calculated-value-expected.txt: Added.
- fast/css/order-calculated-value.html: Added.
- 8:50 AM Changeset in webkit [178268] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176454 - Crash when setting 'font' CSS property to 'calc(2 * 3)'
https://bugs.webkit.org/show_bug.cgi?id=138933
Reviewed by Darin Adler.
Source/WebCore:
The CSS Parser was not handling calculated values when parsing the font
weight. This would lead us to hit an assertion when parsing a font
property whose weight is set to a calculated value.
This patch updates parseFontWeight() to properly handle calculated
values.
Test: fast/css/font-calculated-value.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontWeight):
LayoutTests:
Add a layout test to cover the case where the 'font' CSS property is
set to a value whose weight is a calculated value, to make sure it
does not crash and behaves as intended.
- fast/css/font-calculated-value-expected.txt: Added.
- fast/css/font-calculated-value.html: Added.
- 8:47 AM Changeset in webkit [178267] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176432 - REGRESSION (174986): CSS clip property is ignored when border-radius is present.
https://bugs.webkit.org/show_bug.cgi?id=138935
rdar://problem/18965984
Reviewed by Simon Fraser.
Revert back to r163382 and fix bug 127729 properly. Save the graphics context when paint and clip rects are
the same, but the clip rect has radius.
Each iteration on ::clipRect() from r163382 onwards just introduced yet another regression.
Source/WebCore:
Test: fast/clip/css-clip-does-not-work-when-border-radius-is-present.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
LayoutTests:
- fast/clip/css-clip-does-not-work-when-border-radius-is-present-expected.html: Added.
- fast/clip/css-clip-does-not-work-when-border-radius-is-present.html: Added.
- 8:29 AM Changeset in webkit [178266] by
-
- 5 edits in trunk/Source/JavaScriptCore
Local JSArray* "keys" in objectConstructorKeys() is not marked during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=140348
Reviewed by Mark Lam.
Move the address of the local variable that is used to demarcate the top of the stack for
conservative roots down to MachineThreads::gatherFromCurrentThread() since it also gets
the register values using setjmp(). That way we don't lose any callee save register
contents between Heap::markRoots(), where it was set, and gatherFromCurrentThread().
If we lose any JSObject* that are only in callee save registers, they will be GC'ed
erroneously.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::gatherStackRoots):
- heap/Heap.h:
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):
- heap/MachineStackMarker.h:
- 8:22 AM Changeset in webkit [178265] by
-
- 30 edits in trunk/Source
Modernize and streamline HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=140166
Reviewed by Sam Weinig.
Source/WebCore:
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::initializeAttributes): Removed unneeded assertions
based on fields I removed.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser): Change to use updateStateFor
to set the initial state when parsing a fragment, since it implements the same
rule taht the tokenizerStateForContextElement function did.
(WebCore::HTMLDocumentParser::pumpTokenizer): Updated to use the revised
interfaces for HTMLSourceTracker and HTMLTokenizer.
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken): Changed to take a
TokenPtr instead of an HTMLToken, so we can clear out the TokenPtr earlier
for non-character tokens, and let them get cleared later for character tokens.
(WebCore::HTMLDocumentParser::insert): Pass references.
(WebCore::HTMLDocumentParser::append): Ditto.
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan): Ditto.
- html/parser/HTMLDocumentParser.h: Updated argument type for constructTreeFromHTMLToken
and removed now-unneeded m_token data members.
- html/parser/HTMLEntityParser.cpp: Removed unneeded uses of the inline keyword.
(WebCore::HTMLEntityParser::consumeNamedEntity): Replaced two uses of
advanceAndASSERT with just plain advance; there's really no need to assert the
character is the one we just got out of the string.
- html/parser/HTMLInputStream.h: Moved the include of TextPosition.h here from
its old location since this class has two data members that are OrdinalNumber.
- html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser): Removed most of the
initialization, since it's now done by defaults.
(WebCore::extractCharset): Rewrote this to be a non-member function, and to
use a for loop, and to handle quote marks in a simpler way. Also changed it
to return a StringView so we don't have to allocate a new string.
(WebCore::HTMLMetaCharsetParser::processMeta): Use a modern for loop, and
also take a token argument since it's no longer a data member.
(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes): Use a modern for
loop, StringView instead of string, and don't bother naming the local enum.
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset): Updated for the new
way of getting tokens from the tokenizer.
- html/parser/HTMLMetaCharsetParser.h: Got rid of some data members and
tightened up the formatting a little. Don't bother allocating the tokenizer
on the heap.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::TokenPreloadScanner): Removed unneeded
initialization.
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Ditto.
(WebCore::HTMLPreloadScanner::scan): Changed to take a reference.
- html/parser/HTMLPreloadScanner.h: Removed unneeded includes, typedefs,
and forward declarations. Removed explicit declaration of the destructor,
since the default one works. Removed unused createCheckpoint and rewindTo
functions. Gave initial values for various data members. Marked the device
scale factor const beacuse it's set in the constructor and never changed.
Also removed the unneeded isSafeToSendToAnotherThread.
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::PreloadRequest::isSafeToSendToAnotherThread): Deleted.
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::PreloadRequest): Removed unneeded calls to
isolatedCopy. Also removed isSafeToSendToAnotherThread.
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::startToken): Renamed. Changed to keep state
in the source tracker itself, not the token.
(WebCore::HTMLSourceTracker::endToken): Ditto.
(WebCore::HTMLSourceTracker::source): Renamed. Changed to use the state
from the source tracker.
- html/parser/HTMLSourceTracker.h: Removed unneeded include of HTMLToken.h.
Renamed functions, removed now-unneeded comment.
- html/parser/HTMLToken.h: Cut down on the fields used by the source tracker.
It only needs to know the start and end of each attribute, not each part of
each attribute. Removed setBaseOffset, setEndOffset, length, addNewAttribute,
beginAttributeName, endAttributeName, beginAttributeValue, endAttributeValue,
m_baseOffset and m_length. Added beginAttribute and endAttribute.
(WebCore::HTMLToken::clear): No need to zero m_length or m_baseOffset any more.
(WebCore::HTMLToken::length): Deleted.
(WebCore::HTMLToken::setBaseOffset): Deleted.
(WebCore::HTMLToken::setEndOffset): Deleted.
(WebCore::HTMLToken::beginStartTag): Only null out m_currentAttribute if we
are compiling in assertions.
(WebCore::HTMLToken::beginEndTag): Ditto.
(WebCore::HTMLToken::addNewAttribute): Deleted.
(WebCore::HTMLToken::beginAttribute): Moved the code from addNewAttribute in
here and set the start offset.
(WebCore::HTMLToken::beginAttributeName): Deleted.
(WebCore::HTMLToken::endAttributeName): Deleted.
(WebCore::HTMLToken::beginAttributeValue): Deleted.
(WebCore::HTMLToken::endAttributeValue): Deleted.
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLToken::endAttribute): Added. Sets the end offset.
(WebCore::HTMLToken::appendToAttributeName): Updated assertion.
(WebCore::HTMLToken::appendToAttributeValue): Ditto.
(WebCore::convertASCIIAlphaToLower): Renamed from toLowerCase and changed
so it's legal to call on lower case letters too.
(WebCore::vectorEqualsString): Changed to take a string literal rather than
a WTF::String.
(WebCore::HTMLTokenizer::inEndTagBufferingState): Made this a member function.
(WebCore::HTMLTokenizer::HTMLTokenizer): Updated for data member changes.
(WebCore::HTMLTokenizer::bufferASCIICharacter): Added. Optimized version of
bufferCharacter for the common case where we know the character is ASCII.
(WebCore::HTMLTokenizer::bufferCharacter): Moved this function here from the
header since it's only used inside the class.
(WebCore::HTMLTokenizer::emitAndResumeInDataState): Moved this here, renamed
it and removed the state argument.
(WebCore::HTMLTokenizer::emitAndReconsumeInDataState): Ditto.
(WebCore::HTMLTokenizer::emitEndOfFile): More of the same.
(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded): Ditto.
(WebCore::HTMLTokenizer::haveBufferedCharacterToken): Ditto.
(WebCore::HTMLTokenizer::flushBufferedEndTag): Updated since m_token is now
the actual token, not just a pointer.
(WebCore::HTMLTokenizer::flushEmitAndResumeInDataState): Renamed this and
removed the state argument.
(WebCore::HTMLTokenizer::processToken): This function, formerly nextToken,
is now the internal function used by nextToken. Updated its contents to use
simpler macros, changed code to set m_state when returning, rather than
constantly setting it when cycling through states, switched style to use
early return/goto rather than lots of else statements, took out unneeded
braces now that BEGIN/END_STATE handles the braces, collapsed upper and
lower case letter handling in many states, changed lookAhead call sites to
use the new advancePast function instead.
(WebCore::HTMLTokenizer::updateStateFor): Set m_state directly instead of
calling a setstate function.
(WebCore::HTMLTokenizer::appendToTemporaryBuffer): Moved here from header.
(WebCore::HTMLTokenizer::temporaryBufferIs): Changed argument type to
a literal instead of a WTF::String.
(WebCore::HTMLTokenizer::appendToPossibleEndTag): Renamed and changed type
to be a UChar instead of LChar, although all characters will be ASCII.
(WebCore::HTMLTokenizer::isAppropriateEndTag): Marked const, and changed
type from size_t to unsigned.
- html/parser/HTMLTokenizer.h: Changed interface of nextToken so it returns
a TokenPtr so code doesn't have to understand special rules about when to
work with an HTMLToken and when to clear it. Made most functions private,
and made the State enum private as well. Replaced the state and setState
functions with more specific functions for the few states we need to deal
with outside the class. Moved function bodies outside the class definition
so it's easier to read the class definition.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Updated to use the
new set state functions instead of setState.
(WebCore::HTMLTreeBuilder::processEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processScriptStartTag): Ditto.
- html/parser/InputStreamPreprocessor.h: Marked the constructor explicit,
and mde it take a reference rather than a pointer.
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement): Updated to use the
new set state functions instead of setState.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForName): Updated for name change.
(WebCore::XSSAuditor::decodedSnippetForAttribute): Updated for changes to
attribute range tracking.
(WebCore::XSSAuditor::decodedSnippetForJavaScript): Updated for name change.
(WebCore::XSSAuditor::isSafeToSendToAnotherThread): Deleted.
- html/parser/XSSAuditor.h: Deleted isSafeToSendToAnotherThread.
- html/track/WebVTTTokenizer.cpp: Removed the local state variable from
WEBVTT_ADVANCE_TO; there is no need for it.
(WebCore::WebVTTTokenizer::WebVTTTokenizer): Use a reference instead of a
pointer for the preprocessor.
(WebCore::WebVTTTokenizer::nextToken): Ditto. Also removed the state local
variable and the switch statement, replacing with labels instead since we
go between states with goto.
- platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::operator=): Changed the return type to be non-const
to match normal C++ design rules.
(WebCore::SegmentedString::pushBack): Renamed from prepend since this is not a
general purpose prepend function. Also fixed assertions to not use the strangely
named "escaped" function, since we are deleting it.
(WebCore::SegmentedString::append): Ditto.
(WebCore::SegmentedString::advancePastNonNewlines): Renamed from advance, since
the function only works for non-newlines.
(WebCore::SegmentedString::currentColumn): Got rid of unneeded local variable.
(WebCore::SegmentedString::advancePastSlowCase): Moved here from header and
renamed. This function now consumes the characters if they match.
- platform/text/SegmentedString.h: Made the changes mentioned above.
(WebCore::SegmentedString::excludeLineNumbers): Deleted.
(WebCore::SegmentedString::advancePast): Renamed from lookAhead. Also changed
behavior so the characters are consumed.
(WebCore::SegmentedString::advancePastIgnoringCase): Ditto.
(WebCore::SegmentedString::advanceAndASSERT): Deleted.
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase): Deleted.
(WebCore::SegmentedString::escaped): Deleted.
- xml/parser/CharacterReferenceParserInlines.h:
(WebCore::isHexDigit): Deleted.
(WebCore::unconsumeCharacters): Updated for name change.
(WebCore::consumeCharacterReference): Removed unneeded name for local enum,
renamed local variable "cc" to character. Changed code to use helpers like
isASCIIAlpha and toASCIIHexValue. Removed unneeded use of advanceAndASSERT,
since we don't really need to assert the character we just extracted.
- xml/parser/MarkupTokenizerInlines.h:
(WebCore::isTokenizerWhitespace): Renamed argument to character.
(WebCore::advanceStringAndASSERTIgnoringCase): Deleted.
(WebCore::advanceStringAndASSERT): Deleted.
Changed all the macro implementations so they set m_state only when
returning from the function and just use goto inside the state machine.
Source/WTF:
- wtf/Forward.h: Removed PassRef, added OrdinalNumber and TextPosition.
- 8:20 AM WebKitGTK/2.6.x edited by
- Propose devhelp fix for 2.6.5 (diff)
- 6:48 AM Changeset in webkit [178264] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.6
Merge r176399 - WTFCrashWithSecurityImplication under SpeculativeJIT::compile() when loading a page from theblaze.com.
<https://webkit.org/b/137642>
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
In the DFG, we have a ConstantFolding phase that occurs after all LocalCSE
phases have already transpired. Hence, Identity nodes introduced in the
ConstantFolding phase will be left in the node graph. Subsequently, the
DFG code generator asserts that CSE phases have consumed all Identity nodes.
This turns out to not be true. Hence, the crash. We fix this by teaching
the DFG code generator to emit code for Identity nodes.
Unlike the DFG, the FTL does not have this issue. That is because the FTL
plan has GlobalCSE phases that come after ConstantFolding and any other
phases that can generate Identity nodes. Hence, for the FTL, it is true that
CSE will consume all Identity nodes, and the code generator should not see any
Identity nodes.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
- js/dfg-inline-identity-expected.txt: Added.
- js/dfg-inline-identity.html: Added.
- js/script-tests/dfg-inline-identity.js: Added.
(o.toKey):
(foo):
(test):
- 6:41 AM Changeset in webkit [178263] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176384 - REGRESSION (r172854): Web Viewer in FileMaker does not render a Base64 encoded animated-GIF
https://bugs.webkit.org/show_bug.cgi?id=138807
<rdar://problem/18829540>
Reviewed by Simon Fraser.
Animation gets paused because WebKit thinks the GIF is outside of the view.
- page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
We need to convert to window coordinates in paintsEntireContents mode too so these functions are consistent.
This matters with some WK1 API clients.
- 6:25 AM Changeset in webkit [178262] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.6
Merge r176301 - Crash when setting 'z-index' / 'flex-shrink' CSS properties to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138783
Reviewed by Andreas Kling.
Source/WebCore:
Update operators converting CSSPrimitiveValue to integer / floating
point types to properly handle calculated values (e.g. 'calc(2 * 3)').
Previously, this was not working in release builds and we would hit an
ASSERT_NOT_REACHED() in debug builds.
Tests: fast/css/flex-shrink-calculated-value.html
fast/css/z-index-calculated-value.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):
LayoutTests:
Add layout tests to check that settings 'z-index' / 'flex-shrink' CSS
properties to a calculated value does not crash and behaves as
expected.
- fast/css/flex-shrink-calculated-value-expected.txt: Added.
- fast/css/flex-shrink-calculated-value.html: Added.
- fast/css/z-index-calculated-value-expected.txt: Added.
- fast/css/z-index-calculated-value.html: Added.
- 6:22 AM Changeset in webkit [178261] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176295 - REGRESSION (r167210): Invalid cast in WebCore::RenderBlock::blockSelectionGaps
https://bugs.webkit.org/show_bug.cgi?id=137590
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/block/selection-block-gaps-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockSelectionGaps):
Check that we really are a RenderBlock before recurring.
LayoutTests:
- fast/block/selection-block-gap-crash-expected.txt: Added.
- fast/block/selection-block-gap-crash.html: Added.
- 6:20 AM Changeset in webkit [178260] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176287 - REGRESSION(r152313): Inline-block element doesn't wrap properly
https://bugs.webkit.org/show_bug.cgi?id=138846 - <rdar://problem/18838703>
Reviewed by Simon Fraser.
Source/WebCore:
Added fast/inline-block/inline-block-empty-spans.html
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::canBreakAtThisPosition):
LayoutTests:
- fast/inline-block/inline-block-empty-spans-expected.html: Added.
- fast/inline-block/inline-block-empty-spans.html: Added.
- 6:16 AM Changeset in webkit [178259] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176285 - Multicolumn layout with negative line spacing and orphans causes pieces of letters to be shown at the bottom of columns
https://bugs.webkit.org/show_bug.cgi?id=138204
Source/WebCore:
Reviewed by Dave Hyatt.
This code is responsible for pushing block elements to the next column if
the "orphans" CSS property is triggered. The mechanism by which this is
achieved is to push the block down such that the origin of the block is
at the origin of the next column. However, if there is negative line
spacing, the top portion of the text might actually be on top of the
origin of the block. Therefore, the block wasn't being pushed down enough
to entirely contain its text, so the top pieces were being drawn on the
previous column.
Test: fast/multicol/orphans-negative-line-spacing.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
LayoutTests:
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.
Create a layout where the "orphans" css property causes a block element to
be pushed to the next column.
- fast/multicol/orphans-negative-line-spacing-expected.html: Added.
- fast/multicol/orphans-negative-line-spacing.html: Added.
- 6:14 AM Changeset in webkit [178258] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176322 - Missing NULL-check in VideoTrack::setLanguage
https://bugs.webkit.org/show_bug.cgi?id=138867
Reviewed by Jer Noble.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::setLanguage): Prevent change event creation
on an empty video track list.
- 6:13 AM Changeset in webkit [178257] by
-
- 8 edits in releases/WebKitGTK/webkit-2.6
Merge r176311 - start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
https://bugs.webkit.org/show_bug.cgi?id=138739
Reviewed by Darin Adler.
Source/WebCore:
The patch is inspired by the following Blink revision by
<Raymond Toy>:
<https://src.chromium.org/viewvc/blink?view=rev&revision=160845>
Test: webaudio/dom-exceptions.html
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::start):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::noteGrainOn):
(WebCore::AudioBufferSourceNode::startGrain): Deleted.
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/OscillatorNode.idl:
LayoutTests:
- webaudio/dom-exceptions-expected.txt: Added.
- webaudio/dom-exceptions.html: Added.
- 6:06 AM Changeset in webkit [178256] by
-
- 10 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176259 - HRTFDatabaseLoader is not an absolute condition to run audioContext
https://bugs.webkit.org/show_bug.cgi?id=138829
Reviewed by Jer Noble.
This patch is a port of the following Blink revision by
<keonho07.kim@samsung.com>:
<https://src.chromium.org/viewvc/blink?revision=167887&view=revision>
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::isRunnable): Deleted.
- Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::hrtfDatabaseLoader): Deleted.
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::render):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/RealtimeAnalyser.cpp:
- Modules/webaudio/RealtimeAnalyser.h:
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
- 5:50 AM Changeset in webkit [178255] by
-
- 4 edits2 adds in trunk/LayoutTests
AX: [ATK] Whether to show the title attribute, if there is a label with the attribute for?
https://bugs.webkit.org/show_bug.cgi?id=139986
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-12
Reviewed by Chris Fleizach.
- accessibility/radio-button-title-label.html:
This test is also suitable for EFL and GTK port.
- platform/efl/TestExpectations:
- platform/efl/accessibility/radio-button-title-label-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/radio-button-title-label-expected.txt: Added.
- 2:42 AM Changeset in webkit [178254] by
-
- 3 edits in trunk/LayoutTests
Fix lint-test-files warnings in TestExpectations files.
https://bugs.webkit.org/show_bug.cgi?id=140351
Unreviewed gardening.
Removed the test cases from TestExpectations files.
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2015-01-12
- platform/efl/TestExpectations:
- platform/wk2/TestExpectations:
Jan 11, 2015:
- 8:33 PM Changeset in webkit [178253] by
-
- 2 edits in trunk/Source/WebCore
Enable Vector bounds checking for ElementDescendantIterator.
<https://webkit.org/b/140346>
Reviewed by Sam Weinig.
I had originally disabled Vector bounds checking for
ElementDescendantIterator's internal ancestor stack, but upon
re-running performance benchmarks, it appears to have little-to-no
measurable benefit.
This change adds back the bounds checking.
- dom/ElementDescendantIterator.h:
- 6:47 PM Changeset in webkit [178252] by
-
- 3 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Suspend or resume when visibility is changed
https://bugs.webkit.org/show_bug.cgi?id=140285
Reviewed by Gyuyoung Kim.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp: Copied the logic from TiledCoreAnimationDrawingArea.
(WebKit::CoordinatedDrawingArea::viewStateDidChange):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- 4:17 PM Changeset in webkit [178251] by
-
- 10 edits1 delete in trunk/Source/WebCore
Drop legacy SVGCSSStyleSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=140342
Reviewed by Antti Koivisto.
Drop legacy SVGCSSStyleSelector.cpp by porting the remaining SVG CSS
properties to the generated StyleBuilder. This patch also removes
support for the "LegacyStyleBuilder" option in CSSPropertyNames.in
as all properties have now been ported over.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Drop SVGCSSStyleSelector.cpp file as it was removed.
- css/CSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp: Removed.
- css/StyleBuilder.h:
StyleBuilder::applyProperty() no longer need to return a boolean as
it now handles ALL CSS properties.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueBaselineShift):
(WebCore::StyleBuilderCustom::applyInitialFill):
(WebCore::StyleBuilderCustom::applyInheritFill):
(WebCore::StyleBuilderCustom::applyValueFill):
(WebCore::StyleBuilderCustom::applyInitialStroke):
(WebCore::StyleBuilderCustom::applyInheritStroke):
(WebCore::StyleBuilderCustom::applyValueStroke):
(WebCore::StyleBuilderCustom::applyInitialWebkitSvgShadow):
(WebCore::StyleBuilderCustom::applyInheritWebkitSvgShadow):
(WebCore::StyleBuilderCustom::applyValueWebkitSvgShadow):
Move 'fill', 'stroke' and '-webkit-svg-shadow' to the new
StyleBuilder.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- css/makeprop.pl:
- 2:58 PM Changeset in webkit [178250] by
-
- 23 edits in trunk/Source
Remove FontCachePurgePreventer
https://bugs.webkit.org/show_bug.cgi?id=139628
Reviewed by Anders Carlsson.
This stack type is bug prone and invasive. A missing FontCachePurgePreventer in a code that touches fonts is always
a hard-to-detect bug and there are many places that need it. Instead purge the font cache on top of the runloop.
The purge timer could in principle fire in a nested runloop. However we should never have unreferenced
SimpleFontData objects in the stack in such case (GlyphData objects don't currently ref the font) because those
only occur during layout and painting. Layout and painting can't trigger a nested runloops as there would be
bigger problems.
Purging may also be triggered synchronously by a memory notification. That case won't have any GlyphDatas in the stack either.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::FontCache):
(WebCore::FontCache::fontForFamily):
(WebCore::FontCache::purgeTimerFired):
(WebCore::FontCache::purgeInactiveFontData):
- platform/graphics/FontCache.h:
(WebCore::FontCache::disablePurging): Deleted.
(WebCore::FontCache::enablePurging): Deleted.
(WebCore::FontCachePurgePreventer::FontCachePurgePreventer): Deleted.
(WebCore::FontCachePurgePreventer::~FontCachePurgePreventer): Deleted.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::drawEmphasisMarks):
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
- platform/mac/DragImageMac.mm:
(WebCore::widthWithFont):
(WebCore::drawAtPoint):
(WebCore::createDragImageForLink):
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink):
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint):
(WebCore::WebCoreTextFloatWidth):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::setImageSizeForAltText):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(RenderMenuList::updateOptionsWidth):
- rendering/RenderThemeIOS.mm:
(WebCore::adjustInputElementButtonStyle):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateStyle):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeStyleDidChange):
(WebCore::RenderSVGText::subtreeTextDidChange):
(WebCore::RenderSVGText::removeChild):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
- 2:55 PM Changeset in webkit [178249] by
-
- 2 edits in trunk/Source/WebCore
[SVG -> OTF Converter] Implement ligatures
https://bugs.webkit.org/show_bug.cgi?id=137094
Reviewed by Dan Bernstein.
Use the "liga" OpenType feature to implement ligatures inside the GSUB table.
Tests: svg/W3C-SVG-1.1/fonts-glyph-04-t.svg
svg/W3C-SVG-1.1/text-text-06-t.svg
svg/text/kerning.svg
svg/text/multichar-glyph.svg
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::grow):
(WebCore::SVGToOTFFontConverter::appendCMAPTable): Use StringView::codePoints().
(WebCore::SVGToOTFFontConverter::firstGlyph): Returns the first element of the input
vector, along with some ASSERTs.
(WebCore::SVGToOTFFontConverter::appendLigatureSubtable):
(WebCore::SVGToOTFFontConverter::appendScriptSubtable): Used inside appendGSUBTable.
(WebCore::SVGToOTFFontConverter::appendGSUBTable): Updating for ligatures.
(WebCore::codepointToString): Wrapper around U16_APPEND().
(WebCore::SVGToOTFFontConverter::glyphsForCodepoint): Call codepointToString and look
in internal map.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Use glyphsForCodepoint().
(WebCore::SVGToOTFFontConverter::appendLigatureGlyphs): Ligatures are implemented as
mapping a sequence of glyphs to another glyph inside OpenType. However, SVG models
ligatures as mapping a sequence of codepoints to a glyph. This function makes dummy
glyphs for all the codepoints that we don't have glyphs for and appends them to
m_glyphs.
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Use appendEmptyGlyph() and
call appendLigatureGlyphs().
- 2:39 PM Changeset in webkit [178248] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/JavaScriptCore
Update WebKit branch to build with newer LLVM.
<https://webkit.org/b/140341>
Reviewed by Filip Pizlo.
- Configurations/LLVMForJSC.xcconfig:
- Add the ability to pick up LLVM_LIBS_iphoneos from AspenLLVM.xcconfig.
- llvm/LLVMAPIFunctions.h:
- Removed some erroneous and unused APIs.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- Removed an unneeded option that is also not supported by the new LLVM.
- 2:14 PM Changeset in webkit [178247] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix typo in testate.c error messages
https://bugs.webkit.org/show_bug.cgi?id=140305
Reviewed by Geoffrey Garen.
- API/tests/testapi.c:
(main): "... script did not timed out ..." -> "... script did not time out ..."
- 12:04 PM Changeset in webkit [178246] by
-
- 5 edits in trunk/Source/WebCore
Move more SVG CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140340
Reviewed by Antti Koivisto.
Move more SVG CSS properties to the new StyleBuilder by introducing
the necessary converters in StyleBuilderConverter.
- css/CSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
(WebCore::roundToNearestGlyphOrientationAngle): Deleted.
(WebCore::angleToGlyphOrientation): Deleted.
(WebCore::colorFromSVGColorCSSValue): Deleted.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertNumber):
(WebCore::StyleBuilderConverter::convertNumberOrAuto):
(WebCore::StyleBuilderConverter::convertOpacity):
(WebCore::StyleBuilderConverter::convertSVGURIReference):
(WebCore::StyleBuilderConverter::convertSVGColor):
(WebCore::StyleBuilderConverter::convertGlyphOrientation):
(WebCore::StyleBuilderConverter::convertGlyphOrientationOrAuto):
- rendering/style/RenderStyle.h:
- 10:20 AM Changeset in webkit [178245] by
-
- 2 edits in trunk/Source/bmalloc
Geoff is organized, but he is not an organization.
Rubber-stamped by Anders Carlsson.
- bmalloc.xcodeproj/project.pbxproj: Removed the ORGANIZATIONNAME project attribute.
- 1:17 AM Changeset in webkit [178244] by
-
- 2 edits in trunk/LayoutTests
editing/spelling/grammar-paste.html is flaky in debug after r177682
https://bugs.webkit.org/show_bug.cgi?id=139903
- TestExpectations: The test if flaky on release bots too, updating expectations.
Jan 10, 2015:
- 3:29 PM Changeset in webkit [178243] by
-
- 2 edits in trunk/Tools
build-webkit: silence output of 'which'
https://bugs.webkit.org/show_bug.cgi?id=140278
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-10
Reviewed by Daniel Bates.
Use a more elegent test for the existance of ninja and eclipse.
- Scripts/webkitdirs.pm:
(commandExists): Don't assume the command supports --version
(canUseNinja): Use commandExists()
(canUseEclipse): Use commandExists()
- 2:02 PM Changeset in webkit [178242] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix. Removed the stale code.
- public/admin/triggerables.php:
- 1:57 PM Changeset in webkit [178241] by
-
- 2 edits in trunk
[Xcode, iOS] Files are recompiled when alternating between using make and the Xcode IDE
https://bugs.webkit.org/show_bug.cgi?id=140339
Reviewed by Mark Rowe.
- Makefile.shared: Run xcodebuild with the same PATH with which the Xcode IDE runs. This
prevents unnecessary rebuilding due to PATH differences.
- 10:59 AM Changeset in webkit [178240] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix for !ENABLE(INSPECTOR) builds after r178201.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
- 6:57 AM Changeset in webkit [178239] by
-
- 2 edits in trunk/Source/WebKit/win
[WinCairo] Accelerated compositing has stopped working.
https://bugs.webkit.org/show_bug.cgi?id=140334
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-10
Reviewed by Brent Fulgham.
The method GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly()
is not updating the backingstore anymore, we need to call the new method
GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers().
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::flushPendingLayerChanges):
(AcceleratedCompositingContext::flushAndRenderLayers):
- 4:07 AM Changeset in webkit [178238] by
-
- 3 edits in trunk/Source/WebKit2
[ThreadedCompositor] Prevent excessive rendering call.
https://bugs.webkit.org/show_bug.cgi?id=140297
Reviewed by Žan Doberšek.
Not to waste CPU time on waiting V-Sync interval, the update timer of
compositing thread should be throttled.
In case of updating scene state, this update timer should be called as
soon as possible. However, when CoordinatedGraphicsScene requests update
viewport to advance the animations, this call should be scheduled for
a next frame.
No new tests. No change in functionality.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::setUpdateTimer):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::ThreadedCompositor::setNeedsDisplay):
(WebKit::ThreadedCompositor::updateViewport):
(WebKit::ThreadedCompositor::scheduleDisplayImmediately):
(WebKit::ThreadedCompositor::didChangeVisibleRect):
(WebKit::ThreadedCompositor::scheduleDisplayIfNeeded): Deleted.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- 12:49 AM Changeset in webkit [178237] by
-
- 6 edits in trunk/Source/WebCore
Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140327
Reviewed by Sam Weinig.
Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties
to the new StyleBuilder by introducing the necessary converters in
StyleBuilderConverter.
- css/CSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertSVGLength):
(WebCore::StyleBuilderConverter::convertSVGLengthVector):
(WebCore::StyleBuilderConverter::convertStrokeDashArray):
(WebCore::StyleBuilderConverter::convertPaintOrder):
- svg/SVGLength.cpp:
(WebCore::SVGLength::fromCSSPrimitiveValue):
- svg/SVGLength.h:
- 12:01 AM Changeset in webkit [178236] by
-
- 3 edits in trunk/Tools
Update the output format for run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=140332
Reviewed by Dan Bernstein.
Changes the output format for run-api-tests be a bit simpler (no longer
indented based on suite, as we were not really using suite very well) but
also include details in the case of failure.
Changes verbose mode to no longer spew out the gtest default printer output,
as the custom printer now includes the failure information.
- Scripts/run-api-tests:
(runTestsBySuite):
(runTest):
Augment the custom gtest printer by replacing the tokens "PASS" and "FAIL"
with colorized variants and strip out leaks spew (the leaks can be added back using
the new --show-leaks argument).
- TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::Printer::OnTestPartResult):
(TestWebKitAPI::Printer::OnTestEnd):
(TestWebKitAPI::TestsController::run):
Implement a custom result printer that just prints out the information we want.
Jan 9, 2015:
- 9:48 PM Changeset in webkit [178235] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the GTK and EFL builds.
- CMakeLists.txt:
- 9:26 PM Changeset in webkit [178234] by
-
- 13 edits7 adds in trunk/Websites/perf.webkit.org
Perf dashboard should have the ability to post A/B testing builds
https://bugs.webkit.org/show_bug.cgi?id=140317
Rubber-stamped by Simon Fraser.
This patch adds the support for triggering A/B testing from the perf dashboard.
We add a few new tables to the database. "build_triggerables", which represents a set of builders
that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
of repositories for which an arbitrary revision can be specified for A/B testing.
"triggerable_configurations" specifies a triggerable available on a given test on a given platform.
"roots" table which specifies the revision used in a given root set in each repository.
- init-database.sql: Added "build_triggerables", "triggerable_repositories",
"triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
"platforms", and "tests" tables as well as columns to store status, status url, and creation time
to build_requests table. Also made each test group's name unique in a given analysis task as it
would be confusing to have multiple test groups of the same name.
- public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
- public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
for which a specific revision can be set in an A/B testing on a given triggerable.
- public/api/build-requests.php: Added. Returns the list of open build requests on a specified
triggerable. Also updates the status' and the status urls of specified build requests when
buildRequestUpdates is provided in the raw POST data.
(main):
- public/api/runs.php:
(fetch_runs_for_config): Don't include results associated with a build request, meaning they are
results of an A/B testing.
- public/api/test-groups.php:
(main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
- public/api/triggerables.php: Added.
(main): Returns a list of triggerables or a triggerable associated with a given analysis task.
- public/include/admin-header.php:
- public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
(BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
and root sets used in those requests.D
(BuildRequestsFetcher::construct):
(BuildRequestsFetcher::fetch_for_task):
(BuildRequestsFetcher::fetch_for_group):
(BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
(BuildRequestsFetcher::has_results):
(BuildRequestsFetcher::results):
(BuildRequestsFetcher::results_with_resolved_ids):
(BuildRequestsFetcher::results_internal):
(BuildRequestsFetcher::root_sets):
(BuildRequestsFetcher::fetch_roots_for_set):
- public/include/db.php:
(Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
(Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
table since it only has the primary key, id, column.
(Database::select_or_insert_row):
(Database::update_or_insert_row):
(Database::update_row): Added.
(Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
should be inserted when no row matches the specified criteria. This is used while updating
build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
new build requests in that API.
(Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
This is used in public/api/triggerables.php when no analysis task is specified.
- public/include/json-header.php:
(find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
triggerable associated with the closest ancestor of the test. Since issuing a new query for each
ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
find the closest ancestor with a triggerable.
- public/include/report-processor.php:
(ReportProcessor::process):
(ReportProcessor::resolve_build_id): Associate a build request with the newly created build
if jobId or buildRequest is specified.
- public/include/test-name-resolver.php:
(TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
(TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
a given platform.
- public/include/test-path-resolver.php: Added.
(TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
"tests" table to do this since there could be arbitrary number of ancestors for a given test.
This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
in order to compute full test metric names.
(TestPathResolver::construct):
(TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
the highest (a test without a parent).
(TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
the highest ancestor to the test itself.
(TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
- public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
(main):
(commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
result in WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4.
- public/v2/analysis.js:
(App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
(App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
(App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
(App.TestGroup.create): Added. Creates a new A/B testing group.
(App.Triggerable): Added.
(App.TriggerableAdapter): Added.
(App.TriggerableAdapter.buildURL): Added.
(App.BuildRequest.testGroup): Renamed from group.
(App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
(App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
in this build request.
(App.BuildRequest.status): Added.
(App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
(App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
- public/v2/app.js:
(App.AnalysisTaskController.testGroups): Added.
(App.AnalysisTaskController.possibleRepetitionCounts): Added.
(App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
but an observer that updates "roots" property. Filter out the repositories that are not accepted
by the associated triggerable as they will be ignored.
(App.AnalysisTaskController.actions.createTestGroup): Added.
- public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
- tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
the status of those builds to the perf dashboard. A similar script can be written to support
other continuous builds systems.
(main): Fetches the list of pending builds as well as currently running or completed builds from
a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
a single new build on each builder with no pending builds, and marks the set of open build requests
that have been scheduled to run on the buildbot but not found in the first step as stale.
(load_config): Loads a JSON that contains the configurations for each builder. e.g.
[
{
"platform": "mac-mavericks",
"test": ["Parser", "html5-full-render.html"],
"builder": "Trunk Syrah Production Perf AB Tests",
"arguments": {
"forcescheduler": "force-mac-mavericks-release-perf",
"webkit_revision": "$WebKit",
"jobid": "$buildRequest"
}
}
]
(find_request_updates): Return a list of build request status updates to make based on the pending
builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
if the build request had not been completed. This is necessary because a failed build will not
report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
(update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
of open requests the perf dashboard has.
(find_stale_request_updates): Compute the list of build requests that have been scheduled on the
buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
or human canceling a build may trigger such a state.
(schedule_request): Schedules a build with the arguments specified in the configuration JSON after
replacing repository names with their revisions and buildRequest with the build request id.
(config_for_request): Finds a builder for the test and the platform of a build request.
(fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
(property_value_from_build): Returns the value of a specific property in a buildbot build.
(request_id_from_build): Returns the build request id of a given buildbot build if there is one.
- 7:53 PM Changeset in webkit [178233] by
-
- 3 edits in trunk/Source/WebCore
CTTE: GeolocationController always has a client.
<https://webkit.org/b/140330>
Reviewed by Anders Carlsson.
Change GeolocationController::m_client to be a reference and remove
a whole bunch of unnecessary null checks.
- Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
(WebCore::GeolocationController::lastPosition):
(WebCore::GeolocationController::viewStateDidChange):
(WebCore::provideGeolocationTo):
- Modules/geolocation/GeolocationController.h:
(WebCore::GeolocationController::client):
- 6:44 PM Changeset in webkit [178232] by
-
- 3 edits4 adds in trunk
Breakpoint doesn't fire in this HTML5 game
https://bugs.webkit.org/show_bug.cgi?id=140269
Reviewed by Mark Lam.
Source/JavaScriptCore:
When parsing a single line cached function, use the lineStartOffset of the
location where we found the cached function instead of the cached lineStartOffset.
The cache location's lineStartOffset has not been adjusted for any possible
containing functions.
This change is not needed for multi-line cached functions. Consider the
single line source:
function outer(){function inner1(){doStuff();}; (function inner2() {doMoreStuff()})()}
The first parser pass, we parse and cache inner1() and inner2() with a lineStartOffset
of 0. Later when we parse outer() and find inner1() in the cache, SourceCode start
character is at outer()'s outermost open brace. That is what we should use for
lineStartOffset for inner1(). When done parsing inner1() we set the parsing token
to the saved location for inner1(), including the lineStartOffset of 0. We need
to use the value of lineStartOffset before we started parsing inner1(). That is
what the fix does. When we parse inner2() the lineStartOffset will be correct.
For a multi-line function, the close brace is guaranteed to be on a different line
than the open brace. Hence, its lineStartOffset will not change with the change of
the SourceCode start character
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
LayoutTests:
New tests that set breakpoints in functions with various line split
combinations.
- inspector/debugger/breakpoint-columns-expected.txt: Added.
- inspector/debugger/breakpoint-columns.html: Added.
- inspector/debugger/resources/column-breakpoints-1.js: Added.
(columnTest1.x):
(columnTest1):
(columnTest2.x):
(columnTest2.f):
(columnTest3.x):
(columnTest3.f):
(runColumnTest1):
(runColumnTest2):
(runColumnTest3):
- inspector/debugger/resources/column-breakpoints-2.js: Added.
(columnTest4.x):
(columnTest4.f):
(columnTest5.x):
(columnTest5):
(runColumnTest4):
(runColumnTest5):
- 6:12 PM Changeset in webkit [178231] by
-
- 4 edits2 adds in trunk
Calling clearSelection on a detached RenderObject leads to segfault.
https://bugs.webkit.org/show_bug.cgi?id=140275
Reviewed by Simon Fraser.
We collect selection rects and compute selection gaps in order to
paint/clear selection. With certain content, we need to be able
to walk the tree up to a particular container to compute the selection rect.
However this container might not be available when the selection is part of a detached tree.
This is a null-check fix to ensure we don't crash in such cases, but in the long run
selection gaps and rect should be cached between two layouts so that we don't need to
keep collecting/recomputing them. Tracked here: webkit.org/b/140321
Source/WebCore:
Test: editing/selection/clearselection-on-detached-subtree-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalHeightForContent):
- rendering/RenderView.cpp:
(WebCore::RenderView::clearSelection):
LayoutTests:
- editing/selection/clearselection-on-detached-subtree-crash-expected.txt: Added.
- editing/selection/clearselection-on-detached-subtree-crash.html: Added.
- 6:00 PM Changeset in webkit [178230] by
-
- 10 edits in trunk/Source/WebCore
Remove more sync database code
https://bugs.webkit.org/show_bug.cgi?id=140328
Reviewed by Sam Weinig.
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
- Modules/webdatabase/DatabaseBackendBase.h:
(WebCore::DatabaseBackendBase::isSyncDatabase): Deleted.
- Modules/webdatabase/DatabaseBasicTypes.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
- Modules/webdatabase/DatabaseServer.h:
- 5:50 PM Changeset in webkit [178229] by
-
- 3 edits in trunk/Source/WebCore
Fix the iOS build after <http://trac.webkit.org/changeset/178213>
(https://bugs.webkit.org/show_bug.cgi?id=140310)
Patch by Daniel Bates <dabates@apple.com> on 2015-01-09
- platform/spi/cocoa/CoreTextSPI.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::systemFont):
- 5:48 PM Changeset in webkit [178228] by
-
- 5 edits in trunk/Source/WebCore
Get rid of legacy StyleBuilder switch in StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=140315
Reviewed by Sam Weinig.
Get rid of legacy StyleBuilder switch in StyleResolver.cpp now that most
properties have been ported to the new generated StyleBuilder in previous
patches. The properties that remained in this switch were shorthand
properties or other properties that do not require any handling in the
StyleBuilder.
To achieve this, this patch introduces 2 parameters in
CSSPropertyNames.in:
- SkipBuilder: Indicates that no StyleBuilder code should be generated for this property.
- Shorthand: Indicates that this is a shorthand property, which therefore does not use the StyleBuilder. makeprop.pl will merely generate assertions for such properties, to validate that this is a shorthand property and that the StyleBuilder code is never reached.
- css/CSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- css/makeprop.pl:
- 5:40 PM Changeset in webkit [178227] by
-
- 1 copy in tags/Safari-600.3.17
New tag.
- 5:29 PM Changeset in webkit [178226] by
-
- 2 edits in trunk/Tools
TestWebKitAPI should print out the lists that fail at the end
https://bugs.webkit.org/show_bug.cgi?id=140329
Reviewed by Tim Horton.
- Scripts/run-api-tests:
(runTestsBySuite):
Print out failures and timeouts in all modes, not just verbose.
- 5:15 PM Changeset in webkit [178225] by
-
- 6 edits in trunk/Source
[Win] Build fix after r178219.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj: Remove PaintHooks.asm references in project file.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
Source/WebKit:
Update the project file settings to understand how to process assembly files.
Also tidy up the plugin code in the project hieararchy.
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
- 5:04 PM Changeset in webkit [178224] by
-
- 3 edits3 adds in trunk
Web Inspector: Uncaught Exception in ProbeManager deleting breakpoint
https://bugs.webkit.org/show_bug.cgi?id=140279
rdar://problem/19422299
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/MapData.cpp:
(JSC::MapData::replaceAndPackBackingStore):
The cell table also needs to have its values fixed.
LayoutTests:
- js/map-repack-with-object-keys-expected.txt: Added.
- js/map-repack-with-object-keys.html: Added.
- js/script-tests/map-repack-with-object-keys.js: Added.
- 4:43 PM Changeset in webkit [178223] by
-
- 35 edits in trunk/Source/WebCore
Log which ActiveDOMObject(s) can't be suspended for PageCache.
<https://webkit.org/b/139697>
Reviewed by Chris Dumez.
Give ActiveDOMObject a pure virtual activeDOMObjectName() so we can
find their names.
Dump the names of all the ActiveDOMObjects that fail to suspend when
we're trying to put a page into PageCache.
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBuffer.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
- Modules/mediastream/RTCStatsRequestImpl.h:
- Modules/mediastream/RTCVoidRequestImpl.h:
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.h:
- Modules/webaudio/AudioContext.h:
- Modules/webdatabase/DatabaseContext.h:
- Modules/websockets/WebSocket.h:
- WebCore.exp.in:
- css/FontLoader.h:
- dom/ActiveDOMObject.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
- dom/ScriptExecutionContext.h:
- fileapi/FileReader.h:
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.h:
- html/PublicURLManager.h:
- html/canvas/WebGLRenderingContext.h:
- page/EventSource.h:
- page/SuspendableTimer.h:
- workers/AbstractWorker.h:
- xml/XMLHttpRequest.h:
- 4:34 PM Changeset in webkit [178222] by
-
- 19 edits2 deletes in trunk/Source
Get rid of the database strategy
https://bugs.webkit.org/show_bug.cgi?id=140322
Reviewed by Sam Weinig.
Source/WebCore:
- CMakeLists.txt:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::ProposedDatabase::ProposedDatabase):
(WebCore::DatabaseManager::DatabaseManager):
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/DatabaseStrategy.cpp: Removed.
- platform/DatabaseStrategy.h: Removed.
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::databaseStrategy): Deleted.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createDatabaseStrategy): Deleted.
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createDatabaseStrategy): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
Source/WebKit2:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createDatabaseStrategy): Deleted.
- NetworkProcess/NetworkProcessPlatformStrategies.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createDatabaseStrategy): Deleted.
(WebKit::WebPlatformStrategies::getDatabaseServer): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 4:30 PM Changeset in webkit [178221] by
-
- 2 edits in trunk/Tools
Make bmalloc work with ASan
https://bugs.webkit.org/show_bug.cgi?id=140194
Reviewed by Mark Lam.
- asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
ASan automatically (by forwarding to system malloc at runtime).
- 4:20 PM Changeset in webkit [178220] by
-
- 3 edits1 delete in trunk/Source/WebKit2
[Cocoa] Remove deprecated WKRenderingProgressEvents
https://bugs.webkit.org/show_bug.cgi?id=140325
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKRenderingProgressEvents.h: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
- 4:16 PM Changeset in webkit [178219] by
-
- 18 edits6 copies12 moves1 add1 delete in trunk/Source
Move the Windows only plug-in code to WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=140133
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
Source/WebKit/win:
- Plugins/PaintHooks.asm: Renamed from Source/WebCore/plugins/win/PaintHooks.asm.
- Plugins/PluginDatabase.cpp: Renamed from Source/WebCore/plugins/PluginDatabase.cpp.
(WebCore::persistentPluginMetadataCachePath):
(WebCore::PluginDatabase::PluginDatabase):
(WebCore::PluginDatabase::installedPlugins):
(WebCore::PluginDatabase::isMIMETypeRegistered):
(WebCore::PluginDatabase::addExtraPluginDirectory):
(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::plugins):
(WebCore::PluginDatabase::preferredPluginCompare):
(WebCore::PluginDatabase::pluginForMIMEType):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::findPlugin):
(WebCore::PluginDatabase::setPreferredPluginForMIMEType):
(WebCore::PluginDatabase::fileExistsAndIsNotDisabled):
(WebCore::PluginDatabase::getDeletedPlugins):
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::remove):
(WebCore::PluginDatabase::clear):
(WebCore::PluginDatabase::removeDisabledPluginFile):
(WebCore::PluginDatabase::addDisabledPluginFile):
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::fillBufferWithContentsOfFile):
(WebCore::readUTF8String):
(WebCore::readTime):
(WebCore::PluginDatabase::loadPersistentMetadataCache):
(WebCore::writeUTF8String):
(WebCore::writeTime):
(WebCore::PluginDatabase::updatePersistentMetadataCache):
(WebCore::PluginDatabase::isPersistentMetadataCacheEnabled):
(WebCore::PluginDatabase::setPersistentMetadataCacheEnabled):
(WebCore::PluginDatabase::persistentMetadataCachePath):
(WebCore::PluginDatabase::setPersistentMetadataCachePath):
- Plugins/PluginDatabase.h: Renamed from Source/WebCore/plugins/PluginDatabase.h.
(WebCore::PluginDatabase::setPluginDirectories):
(WebCore::PluginDatabase::pluginDirectories):
- Plugins/PluginDatabaseWin.cpp: Renamed from Source/WebCore/plugins/win/PluginDatabaseWin.cpp.
(WebCore::addPluginPathsFromRegistry):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::parseVersionString):
(WebCore::compareVersions):
(WebCore::addMozillaPluginDirectories):
(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
(WebCore::safariPluginsDirectory):
(WebCore::addMacromediaPluginDirectories):
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
- Plugins/PluginDebug.cpp: Renamed from Source/WebCore/plugins/PluginDebug.cpp.
(WebCore::prettyNameForNPError):
(WebCore::prettyNameForDrawingModel):
(WebCore::prettyNameForEventModel):
(WebCore::prettyNameForNPNVariable):
(WebCore::prettyNameForNPPVariable):
(WebCore::prettyNameForNPNURLVariable):
- Plugins/PluginDebug.h: Renamed from Source/WebCore/plugins/PluginDebug.h.
- Plugins/PluginMessageThrottlerWin.cpp: Renamed from Source/WebCore/plugins/win/PluginMessageThrottlerWin.cpp.
(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::~PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::appendMessage):
(WebCore::PluginMessageThrottlerWin::processQueuedMessage):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
(WebCore::PluginMessageThrottlerWin::allocateMessage):
(WebCore::PluginMessageThrottlerWin::isInlineMessage):
(WebCore::PluginMessageThrottlerWin::freeMessage):
- Plugins/PluginMessageThrottlerWin.h: Renamed from Source/WebCore/plugins/win/PluginMessageThrottlerWin.h.
- Plugins/PluginPackage.cpp: Renamed from Source/WebCore/plugins/PluginPackage.cpp.
(WebCore::PluginPackage::~PluginPackage):
(WebCore::PluginPackage::freeLibrarySoon):
(WebCore::PluginPackage::freeLibraryTimerFired):
(WebCore::PluginPackage::compare):
(WebCore::PluginPackage::PluginPackage):
(WebCore::PluginPackage::unload):
(WebCore::PluginPackage::unloadWithoutShutdown):
(WebCore::PluginPackage::setEnabled):
(WebCore::PluginPackage::createPackage):
(WebCore::PluginPackage::createPackageFromCache):
(WebCore::PluginPackage::determineQuirks):
(WebCore::PluginPackage::determineModuleVersionFromDescription):
(WebCore::getListFromVariantArgs):
(WebCore::makeSource):
(WebCore::NPN_Evaluate):
(WebCore::NPN_Invoke):
(WebCore::PluginPackage::initializeBrowserFuncs):
(WebCore::PluginPackage::hash):
(WebCore::PluginPackage::equal):
(WebCore::PluginPackage::compareFileVersion):
(WebCore::PluginPackage::ensurePluginLoaded):
- Plugins/PluginPackage.h: Renamed from Source/WebCore/plugins/PluginPackage.h.
(WebCore::PluginPackage::name):
(WebCore::PluginPackage::description):
(WebCore::PluginPackage::path):
(WebCore::PluginPackage::fileName):
(WebCore::PluginPackage::parentDirectory):
(WebCore::PluginPackage::module):
(WebCore::PluginPackage::lastModified):
(WebCore::PluginPackage::mimeToDescriptions):
(WebCore::PluginPackage::mimeToExtensions):
(WebCore::PluginPackage::isEnabled):
(WebCore::PluginPackage::pluginFuncs):
(WebCore::PluginPackage::quirks):
(WebCore::PluginPackage::version):
(WebCore::PluginPackage::fullMIMEDescription):
(WebCore::PluginPackageHash::hash):
(WebCore::PluginPackageHash::equal):
- Plugins/PluginPackageWin.cpp: Renamed from Source/WebCore/plugins/win/PluginPackageWin.cpp.
(WebCore::getVersionInfo):
(WebCore::PluginPackage::isPluginBlacklisted):
(WebCore::PluginPackage::determineQuirks):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
(WebCore::PluginPackage::hash):
(WebCore::PluginPackage::equal):
(WebCore::PluginPackage::NPVersion):
- Plugins/PluginQuirkSet.h: Renamed from Source/WebCore/plugins/PluginQuirkSet.h.
(WebCore::PluginQuirkSet::PluginQuirkSet):
(WebCore::PluginQuirkSet::add):
(WebCore::PluginQuirkSet::contains):
- Plugins/PluginStream.cpp: Renamed from Source/WebCore/plugins/PluginStream.cpp.
(WebCore::streams):
(WebCore::PluginStream::PluginStream):
(WebCore::PluginStream::~PluginStream):
(WebCore::PluginStream::start):
(WebCore::PluginStream::stop):
(WebCore::lastModifiedDate):
(WebCore::PluginStream::startStream):
(WebCore::PluginStream::ownerForStream):
(WebCore::PluginStream::cancelAndDestroyStream):
(WebCore::PluginStream::destroyStream):
(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::deliverData):
(WebCore::PluginStream::sendJavaScriptStream):
(WebCore::PluginStream::didReceiveResponse):
(WebCore::PluginStream::didReceiveData):
(WebCore::PluginStream::didFail):
(WebCore::PluginStream::didFinishLoading):
(WebCore::PluginStream::wantsAllStreams):
- Plugins/PluginStream.h: Renamed from Source/WebCore/plugins/PluginStream.h.
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore::PluginStream::create):
(WebCore::PluginStream::setLoadManually):
- Plugins/PluginView.cpp: Renamed from Source/WebCore/plugins/PluginView.cpp.
(WebCore::instanceMap):
(WebCore::scriptStringIfJavaScriptURL):
(WebCore::PluginView::popPopupsStateTimerFired):
(WebCore::PluginView::windowClipRect):
(WebCore::PluginView::setFrameRect):
(WebCore::PluginView::frameRectsChanged):
(WebCore::PluginView::clipRectChanged):
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::init):
(WebCore::PluginView::startOrAddToUnstartedList):
(WebCore::PluginView::start):
(WebCore::PluginView::mediaCanStart):
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::stop):
(WebCore::PluginView::setCurrentPluginView):
(WebCore::PluginView::currentPluginView):
(WebCore::createUTF8String):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::scheduleRequest):
(WebCore::PluginView::load):
(WebCore::makeURL):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::postURLNotify):
(WebCore::PluginView::postURL):
(WebCore::PluginView::newStream):
(WebCore::PluginView::write):
(WebCore::PluginView::destroyStream):
(WebCore::PluginView::status):
(WebCore::PluginView::setValue):
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::pushPopupsEnabledState):
(WebCore::PluginView::popPopupsEnabledState):
(WebCore::PluginView::arePopupsAllowed):
(WebCore::PluginView::setJavaScriptPaused):
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::disconnectStream):
(WebCore::PluginView::setParameters):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::focusPluginElement):
(WebCore::PluginView::didReceiveResponse):
(WebCore::PluginView::didReceiveData):
(WebCore::PluginView::didFinishLoading):
(WebCore::PluginView::didFail):
(WebCore::PluginView::setCallingPlugin):
(WebCore::PluginView::isCallingPlugin):
(WebCore::PluginView::create):
(WebCore::PluginView::freeStringArray):
(WebCore::startsWithBlankLine):
(WebCore::locationAfterFirstBlankLine):
(WebCore::findEOL):
(WebCore::capitalizeRFC822HeaderFieldName):
(WebCore::parseRFC822HeaderFields):
(WebCore::PluginView::handlePost):
(WebCore::PluginView::invalidateWindowlessPluginRect):
(WebCore::PluginView::paintMissingPluginIcon):
(WebCore::PluginView::userAgent):
(WebCore::PluginView::userAgentStatic):
(WebCore::PluginView::lifeSupportTimerFired):
(WebCore::PluginView::keepAlive):
(WebCore::PluginView::getValueStatic):
(WebCore::PluginView::getValue):
(WebCore::getFrame):
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
(WebCore::PluginView::getAuthenticationInfo):
(WebCore::PluginView::privateBrowsingStateChanged):
- Plugins/PluginView.h: Renamed from Source/WebCore/plugins/PluginView.h.
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):
(WebCore::PluginManualLoader::~PluginManualLoader):
(WebCore::PluginView::plugin):
(WebCore::PluginView::instance):
(WebCore::PluginView::status):
(WebCore::PluginView::streamDidFinishLoading):
(WebCore::PluginView::parentFrame):
(WebCore::PluginView::pluginsPage):
(WebCore::PluginView::mimeType):
(WebCore::PluginView::url):
(WebCore::PluginView::pluginWndProc):
(WebCore::PluginView::platformPluginWidget):
(WebCore::PluginView::setPlatformPluginWidget):
(WebCore::toPluginView):
- Plugins/PluginViewWin.cpp: Renamed from Source/WebCore/plugins/win/PluginViewWin.cpp.
(windowHandleForPageClient):
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):
(WebCore::setUpOffscreenPaintingHooks):
(WebCore::registerPluginView):
(WebCore::PluginView::PluginViewWndProc):
(WebCore::isWindowsMessageUserGesture):
(WebCore::contentsToNativeWindow):
(WebCore::PluginView::wndProc):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::snapshot):
- Plugins/npapi.cpp: Renamed from Source/WebCore/plugins/npapi.cpp.
(pluginViewForInstance):
(NPN_MemAlloc):
(NPN_MemFree):
(NPN_MemFlush):
(NPN_ReloadPlugins):
(NPN_RequestRead):
(NPN_GetURLNotify):
(NPN_GetURL):
(NPN_PostURLNotify):
(NPN_PostURL):
(NPN_NewStream):
(NPN_Write):
(NPN_DestroyStream):
(NPN_UserAgent):
(NPN_Status):
(NPN_InvalidateRect):
(NPN_InvalidateRegion):
(NPN_ForceRedraw):
(NPN_GetValue):
(NPN_SetValue):
(NPN_GetJavaEnv):
(NPN_GetJavaPeer):
(NPN_PushPopupsEnabledState):
(NPN_PopPopupsEnabledState):
(NPN_PluginThreadAsyncCall):
(NPN_GetValueForURL):
(NPN_SetValueForURL):
(NPN_GetAuthenticationInfo):
(NPN_PopUpContextMenu):
- 4:09 PM Changeset in webkit [178218] by
-
- 1 copy in tags/Safari-600.1.4.14.1
New tag.
- 4:00 PM Changeset in webkit [178217] by
-
- 14 edits2 adds in trunk/Source/WebKit2
Move Navigation creation out of the Cocoa layer and down into the WebPageProxy level
https://bugs.webkit.org/show_bug.cgi?id=140319
Reviewed by Anders Carlsson.
- Adds WebNavigationState, a class at the WebPageProxy level to handle the creation and storage of Navigations. Starts moving some of the functionality from NavigationState there.
- UIProcess/API/APINavigation.cpp:
(API::Navigation::Navigation):
- UIProcess/API/APINavigation.h:
(API::Navigation::create):
(API::Navigation::navigationID):
Have each Navigation store its navigationID and generate it via the WebNavigationState
that is passed to the constructor.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _restoreFromSessionStateData:]):
(-[WKWebView _restoreSessionState:andNavigate:]):
Update for WebPageProxy functions returning the Navigations directly, rather than
the navigationID.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
Remove creation of the load request navigation which is now handled by the WebPageProxy.
(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didSameDocumentNavigationForFrame):
(WebKit::NavigationState::LoaderClient::didDestroyNavigation):
(WebKit::NavigationState::LoaderClient::processDidCrash):
Change to get/take/remove Navigations from the WebPageProxy's WebNavigationState
(WebKit::NavigationState::createLoadRequestNavigation): Deleted.
(WebKit::NavigationState::createBackForwardNavigation): Deleted.
(WebKit::NavigationState::createReloadNavigation): Deleted.
(WebKit::NavigationState::createLoadDataNavigation): Deleted.
Move Navigation creation to WebNavigationState.
- UIProcess/WebFrameListenerProxy.cpp:
(WebKit::WebFrameListenerProxy::WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::receivedPolicyDecision):
- UIProcess/WebFrameListenerProxy.h:
(WebKit::WebFrameListenerProxy::navigation):
(WebKit::WebFrameListenerProxy::setNavigation):
(WebKit::WebFrameListenerProxy::navigationID): Deleted.
(WebKit::WebFrameListenerProxy::setNavigationID): Deleted.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::receivedPolicyDecision):
- UIProcess/WebFrameProxy.h:
Store a Navigation rather than a navigationID on the WebFrameListenerProxy.
- UIProcess/WebNavigationState.cpp: Added.
(WebKit::WebNavigationState::WebNavigationState):
(WebKit::WebNavigationState::~WebNavigationState):
(WebKit::WebNavigationState::createLoadRequestNavigation):
(WebKit::WebNavigationState::createBackForwardNavigation):
(WebKit::WebNavigationState::createReloadNavigation):
(WebKit::WebNavigationState::createLoadDataNavigation):
(WebKit::WebNavigationState::navigation):
(WebKit::WebNavigationState::takeNavigation):
(WebKit::WebNavigationState::didDestroyNavigation):
(WebKit::WebNavigationState::clearAllNavigations):
- UIProcess/WebNavigationState.h: Added.
(WebKit::WebNavigationState::generateNavigationID):
New class to manage navigations.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcessForReload):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::generateNavigationID): Deleted.
Create navigations directly rather than generating a navigation ID and letting
the API level create Navigation.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::navigationState):
Add WebNavigationState member and accessor.
- WebKit2.xcodeproj/project.pbxproj:
Add WebNavigationState.h/cpp
- 3:57 PM Changeset in webkit [178216] by
-
- 2 edits in trunk/Source/WebCore
Another Windows build fix.
- DerivedSources.cpp:
- 3:41 PM Changeset in webkit [178215] by
-
- 2 edits in trunk/LayoutTests
plugins/crash-restoring-plugin-page-from-page-cache.html and plugins/netscape-plugin-page-cache-works.html timing out on Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81392
Reviewed by Alexey Proskuryakov.
Unskip those 2 plugins / page cache tests as they seem to be passing on
WK2 nowadays.
- platform/wk2/TestExpectations:
- 3:40 PM Changeset in webkit [178214] by
-
- 4 edits in trunk
[iOS] Make DumpRenderTree build with public SDK
https://bugs.webkit.org/show_bug.cgi?id=140311
Reviewed by Sam Weinig.
Source/WebKit2:
Add more SPI declarations.
- Platform/spi/ios/UIKitSPI.h:
Tools:
Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
Additionally, remove unused header CoreGraphics/CGFontDB.h.
- DumpRenderTree/mac/DumpRenderTree.mm:
(-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
- 3:36 PM Changeset in webkit [178213] by
-
- 8 edits in trunk
[iOS] Support additional text styles.
https://bugs.webkit.org/show_bug.cgi?id=140310
rdar://problem/18568864
Reviewed by Joseph Pecoraro.
Source/WebCore:
Add support for three new text styles.
- css/CSSValueKeywords.in:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::systemFont):
Source/WebInspectorUI:
Add support for three new text styles.
- UserInterface/Models/CSSKeywordCompletions.js:
LayoutTests:
Updates the existing test to include the new text styles.
- platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle-expected.txt:
- platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle.html:
- 3:35 PM Changeset in webkit [178212] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- bindings/js/JSBindingsAllInOne.cpp:
- 3:28 PM Changeset in webkit [178211] by
-
- 2 edits in trunk/Source/WebCore
Remove more worker database code
https://bugs.webkit.org/show_bug.cgi?id=140320
Reviewed by Tim Horton.
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
- 3:16 PM Changeset in webkit [178210] by
-
- 2 edits in trunk/LayoutTests
After updating tests to use kerning, ligatures, and printer fonts, some tests fail
https://bugs.webkit.org/show_bug.cgi?id=139968
- platform/mac/TestExpectations: Add more flaky tests.
- 3:15 PM Changeset in webkit [178209] by
-
- 11 edits15 deletes in trunk/Source/WebCore
Remove more sync database code
https://bugs.webkit.org/show_bug.cgi?id=140318
Reviewed by Sam Weinig.
- CMakeLists.txt:
- DerivedSources.make:
- Modules/webdatabase/DatabaseBackendSync.cpp: Removed.
- Modules/webdatabase/DatabaseBackendSync.h: Removed.
- Modules/webdatabase/DatabaseCallback.h:
- Modules/webdatabase/DatabaseCallback.idl:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseSync): Deleted.
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::createDatabase):
- Modules/webdatabase/DatabaseSync.cpp: Removed.
- Modules/webdatabase/DatabaseSync.h: Removed.
- Modules/webdatabase/DatabaseSync.idl: Removed.
- Modules/webdatabase/SQLStatementSync.cpp: Removed.
- Modules/webdatabase/SQLStatementSync.h: Removed.
- Modules/webdatabase/SQLTransactionBackendSync.cpp: Removed.
- Modules/webdatabase/SQLTransactionBackendSync.h: Removed.
- Modules/webdatabase/SQLTransactionSync.cpp: Removed.
- Modules/webdatabase/SQLTransactionSync.h: Removed.
- Modules/webdatabase/SQLTransactionSync.idl: Removed.
- Modules/webdatabase/SQLTransactionSyncCallback.h: Removed.
- Modules/webdatabase/SQLTransactionSyncCallback.idl: Removed.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSQLTransactionSyncCustom.cpp: Removed.
- 2:39 PM Changeset in webkit [178208] by
-
- 6 edits in trunk/Websites/perf.webkit.org
Cache-control should be set only on api/runs
https://bugs.webkit.org/show_bug.cgi?id=140312
Reviewed by Andreas Kling.
Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
just set cache-control there instead of json-header.php which is used by other JSON APIs.
Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
- public/api/analysis-tasks.php:
- public/api/runs.php: Set the cache control headers.
- public/api/test-groups.php:
- public/include/db.php: Set the default timezone to UTC.
- public/include/json-header.php: Don't set the cache control headers.
- 2:34 PM Changeset in webkit [178207] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176441. rdar://problem/19409536
- 2:33 PM Changeset in webkit [178206] by
-
- 4 edits1 copy in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174742. rdar://problem/19286019
- 2:32 PM Changeset in webkit [178205] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174299. rdar://problem/19286019
- 2:30 PM Changeset in webkit [178204] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174081. rdar://problem/19286019
- 2:28 PM Changeset in webkit [178203] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r173975. rdar://problem/19286019
- 2:26 PM Changeset in webkit [178202] by
-
- 6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177163. rdar://problem/19273192
- 2:26 PM Changeset in webkit [178201] by
-
- 19 edits in trunk/Source
Web Inspector: Remove or use TimelineAgent Resource related event types
https://bugs.webkit.org/show_bug.cgi?id=140155
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-09
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Remove unused / stale Timeline event types.
- inspector/protocol/Timeline.json:
Source/WebCore:
Remove unused timeline events. The frontend was ignoring these events
and was often already getting nearly identical data from the Network domain.
- WebCore.exp.in:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl): Deleted.
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl): Deleted.
(WebCore::InspectorInstrumentation::didReceiveResourceDataImpl): Deleted.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didScheduleResourceRequest): Deleted.
(WebCore::InspectorInstrumentation::willReceiveResourceData): Deleted.
(WebCore::InspectorInstrumentation::didReceiveResourceData): Deleted.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest): Deleted.
(WebCore::InspectorTimelineAgent::willSendResourceRequest): Deleted.
(WebCore::InspectorTimelineAgent::willReceiveResourceData): Deleted.
(WebCore::InspectorTimelineAgent::didReceiveResourceData): Deleted.
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse): Deleted.
(WebCore::InspectorTimelineAgent::didReceiveResourceResponse): Deleted.
(WebCore::InspectorTimelineAgent::didFinishLoadingResource): Deleted.
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createScheduleResourceRequestData): Deleted.
(WebCore::TimelineRecordFactory::createResourceSendRequestData): Deleted.
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData): Deleted.
(WebCore::TimelineRecordFactory::createResourceFinishData): Deleted.
(WebCore::TimelineRecordFactory::createReceiveResourceData): Deleted.
- inspector/TimelineRecordFactory.h:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::notifyDidScheduleResourceRequest): Deleted.
- loader/ResourceLoadScheduler.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didReceiveBuffer):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
- loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::didReceiveDataArray):
Source/WebKit2:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 2:25 PM Changeset in webkit [178200] by
-
- 5 edits in trunk/Websites/perf.webkit.org
api/report-commit should authenticate with a slave name and password
https://bugs.webkit.org/show_bug.cgi?id=140308
Reviewed by Benjamin Poulain.
Use a slave name and a password to authenticate new commit reports.
- public/api/report-commits.php:
(main):
- public/include/json-header.php:
(verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
a slave name and a password instead of a builder name and a password.
- tests/api-report-commits.js: Updated tests.
- tools/pull-svn.py:
(main): Renamed variables.
(submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
- 2:24 PM Changeset in webkit [178199] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Fix the WebKit2 build with the public SDK
Forward declare class WebView.
- Platform/spi/ios/UIKitSPI.h:
- 2:15 PM Changeset in webkit [178198] by
-
- 2 edits in trunk/Source/WebCore
Update r177745, one of the review comments was not integrated
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-09
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):
I cq+ before Dhi could make an update and this was left out.
- 2:14 PM Changeset in webkit [178197] by
-
- 3 edits6 copies290 adds2 deletes in trunk/LayoutTests
[iOS] Add iOS-specific tests and consolidate iOS-specific accessibility tests
Copied iOS-specific tests from directory LayoutTests/platform/ios-sim-deprecated/iphone
to LayoutTests/platform/ios-simulator/ios and fixed references to external JavaScript
scripts and external style sheets. Moved iOS-specific tests in directories LayoutTests/platform/ios-sim/accessibility
and LayoutTests/platform/ios-simulator/ios-accessibility into LayoutTests/platform/ios-simulator/ios/accessibility.
I will remove directory LayoutTests/platform/ios-sim-deprecated, including
LayoutTests/platform/ios-sim-deprecated/iphone, in a subsequent commit.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/ios/accessibility/press-fires-touch-events-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events-expected.txt.
- platform/ios-simulator/ios/accessibility/press-fires-touch-events.html: Renamed from LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events.html.
- platform/ios-simulator/ios/accessibility/set-value-expected.txt: Copied from LayoutTests/platform/ios-sim/accessibility/set-value-expected.txt.
- platform/ios-simulator/ios/accessibility/set-value.html: Renamed from LayoutTests/platform/ios-sim/accessibility/set-value.html.
- platform/ios-simulator/ios/compositing/overlap-page-scale-expected.txt: Added.
[...]
- 2:13 PM Changeset in webkit [178196] by
-
- 2 edits in trunk/LayoutTests
Mark css3/background/background-repeat-space-content.html as ImgaeOnlyFailure
This test is failing with a subtle pixel difference, need to figure out what's
going on, but results are not visually wrong.
- 2:00 PM Changeset in webkit [178195] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 1:57 PM Changeset in webkit [178194] by
-
- 2 edits in trunk/Source/WebCore
Fix error handling of ContentExtensionsManager when the top level input is unusable
https://bugs.webkit.org/show_bug.cgi?id=140284
Reviewed by Andreas Kling.
There are a couple of ways the WebProcess would crash if the input
is really really bad:
-If the JSON is unreadable, we can have an exception or decodedRules can be null.
-On any of the error, we cannot return immediately or we will skip vm.clear().
This patch adds a branch to fix the first issue.
For the second issue, a new function, loadEncodedRules(), encapsulate all the early
returns to make sure we execute the end of loadExtension().
- contentextensions/ContentExtensionsManager.cpp:
(WebCore::ContentExtensions::ExtensionsManager::loadEncodedRules):
(WebCore::ContentExtensions::ExtensionsManager::loadExtension):
- 1:25 PM Changeset in webkit [178193] by
-
- 2 edits in trunk/Source/WebCore
Simplify LineWidth::wrapNextToShapeOutside()
https://bugs.webkit.org/show_bug.cgi?id=140304
Reviewed by Zoltan Horvath.
This function used to manually check to see if the entire height of
the line would have enough space next to the float. However, the code
to compute the offsets will do this automatically (and probably a lot
faster), if the line height is passed in. This patch does just that.
No new tests, no behavior change.
- rendering/line/LineWidth.cpp:
(WebCore::availableWidthAtOffset): Remove now unused override, allow
passing in lineHeight.
(WebCore::LineWidth::wrapNextToShapeOutside): Pass the lineHeight
when computing the available width, so we don't need to check
isWholeLineFit anymore.
(WebCore::isWholeLineFit): Deleted.
- 1:01 PM Changeset in webkit [178192] by
-
- 3 edits2 adds in trunk
[CSS Shapes] content inside second shape area when two floats interact
https://bugs.webkit.org/show_bug.cgi?id=137702
Reviewed by Zalan Bujtas.
Source/WebCore:
If a float has a shape-outside, we cannot assume that it has a uniform
width for the height of the float, so we cannot use simple line
layout.
Test: fast/shapes/shape-outside-floats/shape-outside-text-overlap-float.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): Don't use simple line layout
if we have shape-outside. Also, rename floatRenderer to
floatingObject, since the variable doesn't contain a renderer.
LayoutTests:
- fast/shapes/shape-outside-floats/shape-outside-text-overlap-float-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-text-overlap-float.html: Added.
- 12:59 PM Changeset in webkit [178191] by
-
- 3 edits4 adds in trunk
Allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache
https://bugs.webkit.org/show_bug.cgi?id=140302
Reviewed by Andreas Kling.
Source/WebCore:
Allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache.
We already restore 'no-store' sub-resources on history navigation from
the memory cache so there is no reason for our page cache policy to be
more restrictive.
We should align our memory cache / history navigation policy with our
page cache policy.
For now, 'no-store' main resources are not restored from either cache
(memory cache / page cache) on history navigation though. This behavior
does not change.
Test: http/tests/navigation/https-no-store-subframe-in-page-cache.html
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
LayoutTests:
Add a layout test to make sure a page is restored from the page cache
on history navigation, even though its has an HTTPS sub-frame with
"cache-control: no-cache".
- http/tests/navigation/https-no-store-subframe-in-page-cache-expected.txt: Added.
- http/tests/navigation/https-no-store-subframe-in-page-cache.html: Added.
- http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html: Added.
- http/tests/navigation/resources/no-store-frame.php: Added.
- 12:57 PM Changeset in webkit [178190] by
-
- 2 edits in trunk/Source/WebCore
Try to trigger a rebuild of generated JS bindings.
- bindings/scripts/CodeGeneratorJS.pm:
- 12:32 PM Changeset in webkit [178189] by
-
- 8 edits1 delete in trunk/Source/WebCore
Add support for SVG CSS Properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140277
Reviewed by Andreas Kling.
Update the new StyleBuilder generator to add support for SVG CSS
Properties whose methods are on SVGRenderStyle instead of RenderStyle.
A new "SVG" parameter is now supported by makeprop.pl to correctly
generate such properties.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPropertyNames.in:
- css/SVGCSSPropertyNames.in: Removed.
Merged SVG CSS properties into CSSPropertyNames.in. I personally don't
think having a separate file for SVG CSS properties is really helpful.
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
Drop legacy StyleBuilder code for several SVG properties and generate
them instead. Those are trivial and do not require any custom code or
converter.
- css/StyleResolver.cpp:
Update the id of the first low-priority property.
- css/makeprop.pl:
Add support for SVG CSS Properties whose methods are on SVGRenderStyle
instead of RenderStyle.
- 12:30 PM Changeset in webkit [178188] by
-
- 7 edits8 deletes in trunk
Start removing Web Database support from workers
https://bugs.webkit.org/show_bug.cgi?id=140271
Reviewed by Sam Weinig.
Source/WebCore:
Remove WorkerGlobalScopeWebDatabase which is the entry point for web database in workers.
- CMakeLists.txt:
- DerivedSources.make:
- Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp: Removed.
- Modules/webdatabase/WorkerGlobalScopeWebDatabase.h: Removed.
- Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl: Removed.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
Remove Web Database worker tests.
- fast/workers/storage/change-version-handle-reuse-sync-expected.txt: Removed.
- fast/workers/storage/change-version-handle-reuse-sync.html: Removed.
- fast/workers/storage/change-version-handle-reuse-worker-expected.txt: Removed.
- fast/workers/storage/change-version-handle-reuse-worker.html: Removed.
- fast/workers/storage/change-version-sync-expected.txt: Removed.
- fast/workers/storage/change-version-sync.html: Removed.
- fast/workers/storage/empty-statement-sync-expected.txt: Removed.
- fast/workers/storage/empty-statement-sync.html: Removed.
- fast/workers/storage/execute-sql-args-sync-expected.txt: Removed.
- fast/workers/storage/execute-sql-args-sync.html: Removed.
- fast/workers/storage/execute-sql-args-worker-expected.txt: Removed.
- fast/workers/storage/execute-sql-args-worker.html: Removed.
- fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt: Removed.
- fast/workers/storage/executesql-accepts-only-one-statement-sync.html: Removed.
- fast/workers/storage/interrupt-database-expected.txt: Removed.
- fast/workers/storage/interrupt-database-sync-expected.txt: Removed.
- fast/workers/storage/interrupt-database-sync.html-disabled: Removed.
- fast/workers/storage/interrupt-database.html: Removed.
- fast/workers/storage/multiple-databases-garbage-collection-expected.txt: Removed.
- fast/workers/storage/multiple-databases-garbage-collection.html: Removed.
- fast/workers/storage/multiple-transactions-expected.txt: Removed.
- fast/workers/storage/multiple-transactions-on-different-handles-expected.txt: Removed.
- fast/workers/storage/multiple-transactions-on-different-handles-sync-expected.txt: Removed.
- fast/workers/storage/multiple-transactions-on-different-handles-sync.html: Removed.
- fast/workers/storage/multiple-transactions-on-different-handles.html: Removed.
- fast/workers/storage/multiple-transactions.html: Removed.
- fast/workers/storage/open-database-creation-callback-sync-expected.txt: Removed.
- fast/workers/storage/open-database-creation-callback-sync.html: Removed.
- fast/workers/storage/open-database-empty-version-sync-expected.txt: Removed.
- fast/workers/storage/open-database-empty-version-sync.html: Removed.
- fast/workers/storage/open-database-inputs-sync-expected.txt: Removed.
- fast/workers/storage/open-database-inputs-sync.html: Removed.
- fast/workers/storage/open-database-set-empty-version-sync-expected.txt: Removed.
- fast/workers/storage/open-database-set-empty-version-sync.html: Removed.
- fast/workers/storage/open-database-while-transaction-in-progress-expected.txt: Removed.
- fast/workers/storage/open-database-while-transaction-in-progress-sync-expected.txt: Removed.
- fast/workers/storage/open-database-while-transaction-in-progress-sync.html: Removed.
- fast/workers/storage/open-database-while-transaction-in-progress.html: Removed.
- fast/workers/storage/read-and-write-transactions-dont-run-together-expected.txt: Removed.
- fast/workers/storage/read-and-write-transactions-dont-run-together.html: Removed.
- fast/workers/storage/resources/change-version-handle-reuse-sync.js: Removed.
- fast/workers/storage/resources/change-version-sync-1.js: Removed.
- fast/workers/storage/resources/change-version-sync-2.js: Removed.
- fast/workers/storage/resources/database-worker-controller.js: Removed.
- fast/workers/storage/resources/database-worker.js: Removed.
- fast/workers/storage/resources/empty-statement-sync.js: Removed.
- fast/workers/storage/resources/execute-sql-args-sync.js: Removed.
- fast/workers/storage/resources/executesql-accepts-only-one-statement-sync.js: Removed.
- fast/workers/storage/resources/interrupt-database-sync.js: Removed.
- fast/workers/storage/resources/interrupt-database.js: Removed.
- fast/workers/storage/resources/multiple-transactions-on-different-handles-sync.js: Removed.
- fast/workers/storage/resources/multiple-transactions-sync.js: Removed.
- fast/workers/storage/resources/open-database-creation-callback-sync.js: Removed.
- fast/workers/storage/resources/open-database-empty-version-sync.js: Removed.
- fast/workers/storage/resources/open-database-inputs-sync.js: Removed.
- fast/workers/storage/resources/open-database-set-empty-version-sync.js: Removed.
- fast/workers/storage/resources/open-database-while-transaction-in-progress-sync.js: Removed.
- fast/workers/storage/resources/sql-data-types-sync.js: Removed.
- fast/workers/storage/resources/sql-exception-codes-sync.js: Removed.
- fast/workers/storage/resources/test-authorizer-sync.js: Removed.
- fast/workers/storage/resources/test-inputs-common.js: Removed.
- fast/workers/storage/resources/transaction-in-transaction-sync.js: Removed.
- fast/workers/storage/resources/use-same-database-in-page-and-workers.js: Removed.
- fast/workers/storage/sql-data-types-sync-expected.txt: Removed.
- fast/workers/storage/sql-data-types-sync.html: Removed.
- fast/workers/storage/sql-exception-codes-sync-expected.txt: Removed.
- fast/workers/storage/sql-exception-codes-sync.html: Removed.
- fast/workers/storage/test-authorizer-expected.txt: Removed.
- fast/workers/storage/test-authorizer-sync-expected.txt: Removed.
- fast/workers/storage/test-authorizer-sync.html: Removed.
- fast/workers/storage/test-authorizer.html: Removed.
- fast/workers/storage/transaction-in-transaction-sync-expected.txt: Removed.
- fast/workers/storage/transaction-in-transaction-sync.html: Removed.
- fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.
- fast/workers/storage/use-same-database-in-page-and-workers.html: Removed.
- http/tests/security/cross-origin-worker-websql-allowed-expected.txt: Removed.
- http/tests/security/cross-origin-worker-websql-allowed.html: Removed.
- http/tests/security/cross-origin-worker-websql-expected.txt: Removed.
- http/tests/security/cross-origin-worker-websql.html: Removed.
- 12:19 PM Changeset in webkit [178187] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed test gardening.
- platform/win/TestExpectations: Unskip fast/canvas/canvas-path-addPath.html now
that it doesn't crash anymore.
- 12:17 PM Changeset in webkit [178186] by
-
- 2 edits in trunk/Source/WebCore
[Win] Layout Test fast/canvas/canvas-path-addPath.html is failing
https://bugs.webkit.org/show_bug.cgi?id=140303
<rdar://problem/19428865>
Reviewed by Simon Fraser.
Although the code clearly states that CG doesn't allow adding a path to itself,
and branches to handle this case, it simply uses the branch to try adding the
path to itself (ignoring the copy it just made)!
Fix this copy/paste bug so that we use the copy and avoid violating the CG
API contract.
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addPath): Fix path used.
- 12:10 PM Changeset in webkit [178185] by
-
- 9 edits2 adds in trunk/Source/WebKit2
Make WKNavigation bridged to API::Navigation (Take 2)
https://bugs.webkit.org/show_bug.cgi?id=140272
Reviewed by Dan Bernstein.
- Shared/API/APIObject.h:
Add Navigation.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Bridge to WKNavigation.
- UIProcess/API/APINavigation.cpp: Added.
(API::Navigation::Navigation):
(API::Navigation::~Navigation):
- UIProcess/API/APINavigation.h: Added.
(API::Navigation::create):
(API::Navigation::request):
Add initial implementation.
- UIProcess/API/Cocoa/WKNavigation.mm:
(-[WKNavigation dealloc]):
(-[WKNavigation _request]):
(-[WKNavigation _apiObject]):
- UIProcess/API/Cocoa/WKNavigationInternal.h:
(API::wrapper):
Implement bridging to API::Navigation and get the request from the underlying object.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _restoreSessionState:andNavigate:]):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::createLoadRequestNavigation):
(WebKit::NavigationState::createBackForwardNavigation):
(WebKit::NavigationState::createReloadNavigation):
(WebKit::NavigationState::createLoadDataNavigation):
(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didSameDocumentNavigationForFrame):
Switch to storing API::Navigations.
- WebKit2.xcodeproj/project.pbxproj:
Add the new files.
- 12:08 PM Changeset in webkit [178184] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view
https://bugs.webkit.org/show_bug.cgi?id=140291
Reviewed by Joseph Pecoraro.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded): Don't restore collapsed false if selectedSidebarPanel is null.
(WebInspector._sidebarCollapsedStateDidChange): Support a _ignoreNavigationSidebarPanelCollapsedEvent flag
to avoid setting _navigationSidebarCollapsedSetting.
(WebInspector._navigationSidebarPanelSelected): Force collapsed if selectedSidebarPanel is null.
(WebInspector._contentBrowserCurrentContentViewDidChange): Set _ignoreNavigationSidebarPanelCollapsedEvent
when forcing the collapsed state to avoid setting _navigationSidebarCollapsedSetting and calling
_updateContentViewForCurrentNavigationSidebar.
- 12:07 PM Changeset in webkit [178183] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Make decoded image data purgeable ASAP.
<https://webkit.org/b/140298>
Reviewed by Antti Koivisto.
Mark decoded images as "transient" which makes CoreGraphics mark
the backing stores as purgeable shortly after they're used.
The decoded representation will remain in CoreGraphics's caches
indefinitely unless the kernel gets starved and needs the pages.
Most resources will now reach a state where the encoded data is
mmap'ed from disk cache (once the entire resource is downloaded)
and the decoded data is purgeable.
This also has the side effect of making the MemoryCache more
palatial since the decoded data cost can be deducted for images,
allowing us to cache more resources.
Note that the worst case for this new behavior would be something
like hovering below 100% memory utilization and constantly having
to drop and re-decode images. While churny, it still beats
crashing the process, plus there's tiling to remove many of the
reasons we'd need the decoded data.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):
- 11:55 AM Changeset in webkit [178182] by
-
- 16 edits2 moves in trunk/Source
Rename GraphicsLayerAnimation to TextureMapperAnimation
https://bugs.webkit.org/show_bug.cgi?id=140296
Reviewed by Martin Robinson.
Source/WebCore:
GraphicsLayerAnimation is only used by TextureMapper and CoordinatedGraphics.
This should be placed in the platform/graphics/texmap.
And this patch also changes its name to TextureMapperAnimation to remove ambiguity.
No new tests because this is a simply refactoring.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperAnimation.cpp: Renamed from Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp.
- platform/graphics/texmap/TextureMapperAnimation.h: Renamed from Source/WebCore/platform/graphics/GraphicsLayerAnimation.h.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setAnimations):
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
Source/WebKit2:
GraphicsLayerAnimation is changed to TextureMapperAnimation
- Scripts/webkit/messages.py:
(headers_for_type):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<TextureMapperAnimation>::encode):
(IPC::ArgumentCoder<TextureMapperAnimation>::decode):
(IPC::ArgumentCoder<TextureMapperAnimations>::encode):
(IPC::ArgumentCoder<TextureMapperAnimations>::decode):
(IPC::ArgumentCoder<GraphicsLayerAnimation>::encode): Deleted.
(IPC::ArgumentCoder<GraphicsLayerAnimation>::decode): Deleted.
(IPC::ArgumentCoder<GraphicsLayerAnimations>::encode): Deleted.
(IPC::ArgumentCoder<GraphicsLayerAnimations>::decode): Deleted.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
- 11:41 AM Changeset in webkit [178181] by
-
- 2 edits in trunk/LayoutTests
[Win] Temporarily disable all media tests.
- platform/win/TestExpectations:
- 11:33 AM Changeset in webkit [178180] by
-
- 11 edits in trunk/Source/WebCore
FontCache should only deal with SimpleFontData
https://bugs.webkit.org/show_bug.cgi?id=140293
Reviewed by Andreas Kling.
FontCache::fontForFamilyAtIndex hands out FontData objects and calls to FontSelector. That sort
of code does not belong to the cache layer. Move the functionality up to FontGlyphs.
- platform/graphics/Font.cpp:
(WebCore::Font::operator==):
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::isLoadingCustomFonts):
- platform/graphics/Font.h:
(WebCore::Font::loadingCustomFonts): Deleted.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::similarFontPlatformData):
Generic null implementation to reduce #ifs.
(WebCore::FontCache::fontForFamilyAtIndex): Deleted.
- platform/graphics/FontCache.h:
Unfriend FontGlyphs.
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::isLoadingCustomFonts):
We can figure thus out cheaply without caching a bit.
(WebCore::realizeNextFamily):
(WebCore::FontGlyphs::realizeFontDataAt):
Reorganize a bit to make the logic clearer.
Get rid of the strange cAllFamiliesScanned constant.
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForNormalVariant):
Loop until null, that always works.
- platform/graphics/FontGlyphs.h:
(WebCore::FontGlyphs::loadingCustomFonts): Deleted.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::similarFontPlatformData):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::similarFontPlatformData):
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
- 11:29 AM Changeset in webkit [178179] by
-
- 3 edits in trunk/Tools
platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
https://bugs.webkit.org/show_bug.cgi?id=140300
Reviewed by Simon Fraser.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::updateWindowScaleForTest):
(WTR::TestController::configureViewForTest):
- WebKitTestRunner/TestController.h:
- 11:29 AM Changeset in webkit [178178] by
-
- 2 edits in trunk/LayoutTests
Update expectations for fast/text/atsui-rtl-override-selection.html, which also
fails on Mountain Lion after enabling kerning and ligatures.
- platform/mac/TestExpectations:
- 11:27 AM Changeset in webkit [178177] by
-
- 6 edits in trunk/Source
REGRESSION(r177925): It broke the !ENABLE(INSPECTOR) build
https://bugs.webkit.org/show_bug.cgi?id=140098
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/InspectorBackendDispatcher.h: Missing ENABLE(INSPECTOR) guard added.
Source/WebCore:
- inspector/InspectorInstrumentationCookie.cpp: Removed ENABLE(INSPECTOR) guard,
becaue InspectorInstrumentationCookie is used everywhere unconditionally.
- inspector/InspectorInstrumentationCookie.h: Removed ENABLE(INSPECTOR) guard.
- loader/appcache/ApplicationCacheGroup.h: Removed ENABLE(INSPECTOR) guard around
m_currentResourceIdentifier, because it is used unconditionally in the cpp.
- 10:58 AM Changeset in webkit [178176] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix crash introduced in r178029
https://bugs.webkit.org/show_bug.cgi?id=140289
Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-09
Reviewed by Martin Robinson.
Clearing childClippingMaskLayer of CoordinatedGraphics should be called
before clearing childClippingLayer.
No new tests, covered by existing tests.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
- 10:31 AM Changeset in webkit [178175] by
-
- 6 edits in trunk/Source
[iOS] Cannot paste an image URL in a plain text field in a page.
https://bugs.webkit.org/show_bug.cgi?id=140274
rdar://problem/18590809
Reviewed by Alexey Proskuryakov.
Source/WebCore:
When we want to get plain text from the pasteboard, we
should also try kUTTypeURL if there is no kUTTypeText available.
- WebCore.exp.in:
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::readString):
Source/WebKit2:
supportedPasteboardTypesForCurrentSelection should include kUTTypeURL for plain
text controls and WebArchivePboardType for rich text controls.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView supportedPasteboardTypesForCurrentSelection]): Remove obsolete and
incorrect FIXME.
- 9:50 AM Changeset in webkit [178174] by
-
- 9 edits2 deletes in trunk/Source/WebKit2
Unreviewed, rolling out r178141.
https://bugs.webkit.org/show_bug.cgi?id=140294
Broke multiple API tests (Requested by ap on #webkit).
Reverted changeset:
"Make WKNavigation bridged to API::Navigation"
https://bugs.webkit.org/show_bug.cgi?id=140272
http://trac.webkit.org/changeset/178141
- 9:44 AM Changeset in webkit [178173] by
-
- 30 edits in trunk/Source
Unreviewed, rolling out r178154, r178163, and r178164.
https://bugs.webkit.org/show_bug.cgi?id=140292
Still multiple assertion failures on tests (Requested by ap on
#webkit).
Reverted changesets:
"Modernize and streamline HTMLTokenizer"
https://bugs.webkit.org/show_bug.cgi?id=140166
http://trac.webkit.org/changeset/178154
"Unreviewed speculative buildfix after r178154."
http://trac.webkit.org/changeset/178163
"One more unreviewed speculative buildfix after r178154."
http://trac.webkit.org/changeset/178164
- 9:16 AM Changeset in webkit [178172] by
-
- 5 edits2 adds in trunk
[MSE] Implement Append Window support.
https://bugs.webkit.org/show_bug.cgi?id=139861
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-01-09
Reviewed by Jer Noble.
Source/WebCore:
Implement Append Windows support for SourceBuffer as per spec.
Also change order in idl to match spec order.
Test: media/media-source/media-source-append-buffer-with-append-window.html
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::appendWindowStart):
(WebCore::SourceBuffer::setAppendWindowStart):
(WebCore::SourceBuffer::appendWindowEnd):
(WebCore::SourceBuffer::setAppendWindowEnd):
(WebCore::SourceBuffer::abort):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBuffer.idl:
LayoutTests:
Added test which checks whether correct samples from contiguous range of samples are added
when manipulating appendWindow.
- media/media-source/media-source-append-buffer-with-append-window-expected.txt: Added.
- media/media-source/media-source-append-buffer-with-append-window.html: Added.
- 7:29 AM Changeset in webkit [178171] by
-
- 5 edits in trunk/Source/WebCore
AX: Crash at -[WebAccessibilityObjectWrapperBase accessibilityTitle] + 31
https://bugs.webkit.org/show_bug.cgi?id=140286
Reviewed by Mario Sanchez Prada.
This is crashing because AppKit is checking if certain method names like "accessibilityTitle" exist,
and then it bypasses accessibilityAttributeValue: to call directly into those methods.
That bypasses are safety checks. I think a safe way to avoid this is rename our methods.
No new tests, problem only occurs when triggered through AppKit.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]): Deleted.
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]): Deleted.
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]): Deleted.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 5:50 AM Changeset in webkit [178170] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the committer section.
- Scripts/webkitpy/common/config/contributors.json:
- 5:33 AM Changeset in webkit [178169] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer][MSE] ASSERT in MediaSourceClientGStreamer::addSourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=140119
Reviewed by Carlos Garcia Campos.
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
(WebCore::MediaSourceClientGStreamer::addSourceBuffer): Use a raw
pointer for the ghost pad, its reference is then taken once attached
to the parent element.
- 5:26 AM Changeset in webkit [178168] by
-
- 2 edits in trunk/Source/WebCore
After r178166, ANGLE's EGL/GLES/GLES2 headers are included before the
system-default headers because the Source/ThirdParty/ANGLE/include
directory is searched through. This shouldn't be the case for ports
which want to use system-default headers and are searching for them
explicitly. To avoid that, OPENGL_INCLUDE_DIR or OPENGLES2_INCLUDE_DIR
should be added to WebCore_INCLUDE_DIRECTORIES before ANGLE directories.
Rubber-stamped by Carlos Garcia Campos.
- CMakeLists.txt:
- 3:48 AM Changeset in webkit [178167] by
-
- 1 edit1 add in trunk/Tools
Add a script to check for platform layering violations
https://bugs.webkit.org/show_bug.cgi?id=140248
Reviewed by Darin Adler.
It prints all the cases where files inside platform include
headers that are not in platform directory.
- Scripts/check-for-platform-layering-violations: Added.
(get_platform_headers):
(check_source_file):
- 3:46 AM Changeset in webkit [178166] by
-
- 16 edits in trunk/Source/WebCore
Use angle-bracket form to include external headers in WebCore
https://bugs.webkit.org/show_bug.cgi?id=140288
Reviewed by Žan Doberšek.
- CMakeLists.txt:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
- platform/graphics/harfbuzz/HarfBuzzFace.cpp:
- platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp:
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
- platform/graphics/win/GraphicsContext3DWin.cpp:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- platform/image-decoders/png/PNGImageDecoder.cpp:
- platform/image-decoders/webp/WEBPImageDecoder.cpp:
- platform/image-encoders/JPEGImageEncoder.cpp:
- platform/image-encoders/PNGImageEncoder.cpp:
- platform/text/TextEncodingDetectorICU.cpp:
- 12:07 AM Changeset in webkit [178165] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source
Versioning.
- 12:06 AM Changeset in webkit [178164] by
-
- 2 edits in trunk/Source/WebCore
One more unreviewed speculative buildfix after r178154.
- xml/parser/CharacterReferenceParserInlines.h:
(WebCore::consumeCharacterReference): Remove highestValidCharacter too, it became unused after r178163.
- 12:01 AM Changeset in webkit [178163] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed speculative buildfix after r178154.
- xml/parser/CharacterReferenceParserInlines.h:
(WebCore::consumeCharacterReference): Remove unused overflow variable.
