Timeline



Mar 30, 2015:

8:27 PM Changeset in webkit [182173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r182172.
​https://bugs.webkit.org/show_bug.cgi?id=143250

Since this class is an API object, we don't know for sure when
it will be destroyed. (Requested by kling on #webkit).

Reverted changeset:

"WebBackForwardList doesn't need to manually clear the
snapshot of an entry when removing it."
​https://bugs.webkit.org/show_bug.cgi?id=143231
​http://trac.webkit.org/changeset/182172

8:02 PM Changeset in webkit [182172] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
<​https://webkit.org/b/143231>

Reviewed by Tim Horton.

Now that we don't keep WebBackForwardListItem objects alive forever, it's not necessary
to clear the snapshot when removing them from the WebBackForwardList, since the entire
object will be deleted shortly after that anyway.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem):

6:59 PM Changeset in webkit [182171] by rniwa@webkit.org
  • 9 edits in trunk

Extending null should set proto to null
​https://bugs.webkit.org/show_bug.cgi?id=142882

Reviewed by Geoffrey Garen and Benjamin Poulain.

Source/JavaScriptCore:

Set Derived.prototype.proto to null when extending null.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

LayoutTests:

Added more test cases for extending from null, and added checks for prototypes.

Also rebaselined existing tests.

  • js/class-syntax-call-expected.txt:
  • js/class-syntax-extends-expected.txt:
  • js/class-syntax-super-expected.txt:
  • js/script-tests/class-syntax-call.js:
  • js/script-tests/class-syntax-extends.js:
  • js/script-tests/class-syntax-super.js:
6:21 PM Changeset in webkit [182170] by msaboff@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

Fix failing v8-deltablue.js for ARM
​https://bugs.webkit.org/show_bug.cgi?id=138392

Rubber-stamped by Mark Lam.

Re-enable this test for ARM32 on iOS as the tests now run without issues.

  • tests/v8-v6/v8-deltablue.js:
6:09 PM Changeset in webkit [182169] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r182168.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
Explicitly cast to unsigned.

5:48 PM Changeset in webkit [182168] by achristensen@apple.com
  • 13 edits
    3 adds in trunk

[Content Extensions] Correctly handle regular expressions matching everything
​https://bugs.webkit.org/show_bug.cgi?id=143235

Reviewed by Benjamin Poulain.

Source/WebCore:

Test: http/tests/contentextensions/whitelist.html

  • contentextensions/CompiledContentExtension.cpp:

(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):
Global actions can have non-css actions. Only put the selectors into the list of selectors.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeSelector):
(WebCore::ContentExtensions::serializeActions):
Merge sequential css selectors with identical triggers (usually .*) into one action to reduce the number of actions.
(WebCore::ContentExtensions::compileRuleList):
Fail if a regular expression matches everything after ignore-previous-rules.

  • contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

  • contentextensions/ContentExtensionError.h:

Add more failure cases.

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Trigger::operator==):
Allow comparing of Triggers to determine if sequential triggers are equal.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
Put non-css actions that match everything into the list of actions if ignore-previous-rules was not hit.
These actions will be out of order, but order only matters when determining if ignore-previous-rules, and this case is handled correctly.

  • contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
Added an assertion that all actions that match everything should be in the first DFA root.
We should catch them all with URLFilterParser::MatchesEverything.

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::checkCompilerError):
(TestWebKitAPI::TEST_F):
Test ContentExtensionErrors.

LayoutTests:

  • http/tests/contentextensions/css-display-none.html:
  • http/tests/contentextensions/css-display-none.html.json:

Test multiple selectors with triggers that match everything.

  • http/tests/contentextensions/whitelist-expected.txt: Added.
  • http/tests/contentextensions/whitelist.html: Added.
  • http/tests/contentextensions/whitelist.html.json: Added.
5:43 PM Changeset in webkit [182167] by mark.lam@apple.com
  • 8 edits in trunk

REGRESSION (r181993): inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html crashes.
<​https://webkit.org/b/143105>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

With r181993, the DFG and FTL may elide the storing of the scope register. As a result,
on OSR exits from DFG / FTL frames where this elision has take place, we may get baseline
JIT frames that may have its scope register not set. The Debugger's current implementation
which relies on the scope register is not happy about this. For example, this results in a
crash in the layout test inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html.

The fix is to disable inlining when the debugger is in use. Also, we add Flush nodes to
ensure that the scope register value is flushed to the register in the stack frame.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flush):

  • Add code to flush the scope register.

(JSC::DFG::ByteCodeParser::inliningCost):

  • Pretend that all codeBlocks are too expensive to inline if the debugger is in use, thereby disabling inlining whenever the debugger is in use.
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::hasDebuggerEnabled):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • Update the DFG codeBlock's scopeRegister since it can be moved during stack layout.
  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • Update the FTL codeBlock's scopeRegister since it can be moved during stack layout.

LayoutTests:

5:33 PM Changeset in webkit [182166] by ap@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
​https://bugs.webkit.org/show_bug.cgi?id=143241
rdar://problem/20351297

Reviewed by Mark Lam.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
5:29 PM Changeset in webkit [182165] by gyuyoung.kim@samsung.com
  • 4 edits in trunk

[CMake][EFL] Remove redundant library link and include path
​https://bugs.webkit.org/show_bug.cgi?id=143221

Reviewed by Csaba Osztrogonác.

Source/WTF:

  • wtf/PlatformEfl.cmake: Remove unnecessary library link and include path.

Tools:

  • ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
4:59 PM Changeset in webkit [182164] by mmaxfield@apple.com
  • 7 edits
    1 move in trunk/Source/WebCore

Allow building on Windows without Cygwin
​https://bugs.webkit.org/show_bug.cgi?id=143219

Reviewed by Brent Fulgham.

  • AVFoundationSupport.py: Renamed from Source/WebCore/WebCore.vcxproj/MigrateScripts.

Move logic from DerivedSources.make to its own script
(lookFor):

  • DerivedSources.make: Paths like /usr/bin don't exist on Windows.

Windows uses del instead of rm -f
Windows doesn't have printf

  • WebCore.vcxproj/WebCoreGenerated.make: Pass the CC executable to

build-generated-files.pl

  • WebCore.vcxproj/build-generated-files.pl: Export the CC executable as an environment

variable. Don't use /usr/bin.

  • WebCore.vcxproj/migrate-scripts.pl: Deleted the MigrateScripts makefile. We don't

need a whole Makefile just to copy 5 files. Moved this logic into migrate-scripts.pl.
(copyFile):

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): Support passing preprocessing flags to the Visual Studio
compiler.

  • dom/make_names.pl: Ditto.
4:54 PM Changeset in webkit [182163] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/spi/mac/AVFoundationSPI.h:
4:25 PM Changeset in webkit [182162] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] WebContent crashing at WebCore: WebCore::Range::collectSelectionRects.
​https://bugs.webkit.org/show_bug.cgi?id=143234
<rdar://problem/18571345>

Reviewed by Tim Horton.

This is a speculative fix that adds a null check before referencing the range.
In both places where the check has been added the range returned by the call
that should create it could be null.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState):

4:22 PM Changeset in webkit [182161] by commit-queue@webkit.org
  • 18 edits
    2 copies
    1 add in trunk

[Content Extensions] Flesh out the UserContentExtensionStore
​https://bugs.webkit.org/show_bug.cgi?id=143123

Patch by Sam Weinig <​sam@webkit.org> on 2015-03-30
Reviewed by Benjamin Poulain.

Source/WebCore:

  • Adds a variant of getFileSize() that takes a PlatformFileHandle.
  • Adds a new file system function, rename() which operates as the POSIX rename function does.
  • platform/FileSystem.h:

Add new functions.

  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::renameFile):
(WebCore::getFileSize):
Add implementations.

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::renameFile):
(WebCore::getFileSize):

  • platform/win/FileSystemWin.cpp:

(WebCore::getFileSize):
(WebCore::renameFile):
Add stubs.

Source/WebKit2:

  • Shared/WebCompiledContentExtension.cpp:

(WebKit::WebCompiledContentExtension::createFromCompiledContentExtensionData):

  • Shared/WebCompiledContentExtensionData.cpp:

(WebKit::WebCompiledContentExtensionData::encode):
(WebKit::WebCompiledContentExtensionData::decode):

  • Shared/WebCompiledContentExtensionData.h:

(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData):
Switch the order in memory of actions and bytecode (and switch the order of the
variables as well, to keep it clear). This will become necessary when streaming
the data to disk, as actions are created before the bytecode and we would have to keep them
in memory until the bytecode was finished compiling if they didn't come before in the file.

  • UIProcess/API/APIUserContentExtensionStore.h:
  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::UserContentExtensionStore::defaultStore):
Add accessor for the processes default shared store.

(API::constructedPath):
Helper for constructing the path to a file in the store based on identifier.

(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
Helpers for encoding/decoding the file metadata (version, bytecode size, actions size).

(API::openAndMapContentExtension):
Helper to open and map a filed back content extension.

(API::writeDataToFile):
Helper to write a Data object to a file.

(API::compiledToFile):
Helper to run the content extension compiler and write it to disk. It first
writes it to a temporary file and then does an atomic rename operation to put
the file in the final location. Doing this means that if the process crashes while
the compile is taking place, the partially written file won't end up in the cache,
but rather, will be cleaned up by the OS.

(API::UserContentExtensionStore::lookupContentExtension):
API entry point to lookup an extension that has been compiled to disk. On a background queue,
it attempts to open and map the extension (based on the identifier passed in) and return it
to the caller via the callback function passed in.

(API::UserContentExtensionStore::compileContentExtension):
API entry point to compile an extension and write it to store. On a background queue, it
compiles the file to disk and if successful, returns the memory mapped data via the callback
function passed in.

(API::UserContentExtensionStore::removeContentExtension):
API entry point to remove an extension from the store. On a background queue, it
unlinks the extension (based on the identifier passed in) and tells the caller it completed
the action vial the callback function passed in.

(API::UserContentExtensionStore::synchronousRemoveAllContentExtensions):
Helper for testing which synchronously unlinks all the files in the store.

(API::userContentExtensionStoreErrorCategory):
std::error_code adaptor for some generic errors that can happen in the store. We will want
to flesh these out further.

  • UIProcess/API/Cocoa/APIUserContentExtensionStoreCocoa.mm: Added.

(API::UserContentExtensionStore::defaultStorePath):
Helper to get the platform specific path for the store.

  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(WKUserContentExtensionStoreGetTypeID):
Add ENABLE(CONTENT_EXTENSIONS) guards.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(-[_WKUserContentExtensionStore dealloc]):
(+[_WKUserContentExtensionStore defaultStore]):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
(-[_WKUserContentExtensionStore init]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStoreInternal.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h: Added.

SPI wrappers for the store.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.

Add tests for _WKUserContentExtensionStore.

4:01 PM Changeset in webkit [182160] by peavo@outlook.com
  • 3 edits in trunk/Source/WebCore

[WinCairo] Crash when closing window while video is loading
​https://bugs.webkit.org/show_bug.cgi?id=143088

Reviewed by Mark Lam.

When the media player is destroyed, we have to cancel possible calls on the
main thread made by a worker thread. Otherwise the destroyed media player
will be accessed when performing the call.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySet):
(WebCore::MediaPlayerPrivateMediaFoundation::onCreatedMediaSourceCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySetCallback):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
3:59 PM Changeset in webkit [182159] by yoon@igalia.com
  • 13 edits in trunk/Source/WebCore

[Threaded Compositor] Crash when animation changes frequently.
​https://bugs.webkit.org/show_bug.cgi?id=143213

Reviewed by Simon Fraser.

CompositingCoordinator copies CoordinatedGraphicsLayerState when
flushing GraphicsLayer changes, and ThreadedCoordinatedCompositor passes
it to compositing thread.

To ensure thread-safety, we need to provide copy constructor to copy
Animation object in TextureMapperAnimation instead of referencing it.

Since TimingFunction and TransformOperation used by KeyframeValueList are
not ThreadSafeRefCounted, these should be cloned also.

No new tests needed.

  • platform/graphics/GraphicsLayer.h:

(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::FilterAnimationValue):
Adds deep copy constructor.

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimation::TextureMapperAnimation):
Because the name of the animation can be AtomicString, we need to create
isolated version of string to ensure thread safty.

  • platform/graphics/texmap/TextureMapperAnimation.h:
  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TranslateTransformOperation.h:

Adds TransformOperation::clone() for threadsafety.

3:58 PM Changeset in webkit [182158] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64
​https://bugs.webkit.org/show_bug.cgi?id=138391

Reviewed by Mark Lam.

Re-enabling these tests as I can't get them to fail on local iOS test devices.
There have been many changes since these tests were disabled.
I'll watch automated test results for failures. If there are failures running automated
testing, it might be due to the device's relative CPU performance.

  • tests/stress/float32-repeat-out-of-bounds.js:
  • tests/stress/int8-repeat-out-of-bounds.js:
3:47 PM Changeset in webkit [182157] by Chris Dumez
  • 5 edits
    2 adds in trunk

Cached "Expires" header is not updated upon successful resource revalidation
​https://bugs.webkit.org/show_bug.cgi?id=143228
<rdar://problem/20348059>

Reviewed by Antti Koivisto.

Source/WebCore:

Cached "Expires" header was not updated upon successful resource
revalidation. This affected both our disk cache and our memory cache.
This was caused by shouldUpdateHeaderAfterRevalidation() in
CacheValidation.cpp returning false for the "Expires" header.

There is a comment there stating that the list of ignored headers
matches Chromium's net library but that's not the case, at least not
anymore:
​http://osxr.org/android/source/external/chromium/net/http/http_response_headers.cc

HTTP servers such as Apache return an "Expires" header in their 304
responses and the "Expires" header is potentially a new one. However,
our caches were ignoring the updated expiration date and kept using the
old one, which meant that the cached resource expired sooner than it
should have.

See the following Apache bugs that explain the issue:
​https://bz.apache.org/bugzilla/show_bug.cgi?id=24884
​https://bz.apache.org/bugzilla/show_bug.cgi?id=25123

Test: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html

  • platform/network/CacheValidation.cpp:

LayoutTests:

Add layout test to check that a cached response's "Expires" header is
updated from the 304 response's headers upon successful revalidation.

  • http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html: Added.
  • http/tests/cache/disk-cache/resources/cache-test.js:

(generateTestURL):
(loadResource):

  • http/tests/cache/disk-cache/resources/generate-response.cgi:
3:43 PM Changeset in webkit [182156] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: Regression: Preview for null shouldn't be []
​https://bugs.webkit.org/show_bug.cgi?id=143208

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-30
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • inspector/InjectedScriptSource.js:

Handle null when generating simple object previews.

LayoutTests:

  • inspector/model/remote-object-expected.txt:
  • inspector/model/remote-object.html:
3:41 PM Changeset in webkit [182155] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Regression: null shouldn't be expandable in object outline
​https://bugs.webkit.org/show_bug.cgi?id=143209

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-30
Reviewed by Mark Lam.

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createObjectTreeOrFormattedValueForRemoteObject):
When creating an object tree or formatted value, choose just a formatted value
for "null", since it does not have properties.

3:00 PM Changeset in webkit [182154] by Antti Koivisto
  • 4 edits in trunk

Don't cache resources that are very unlikely to be reused
​https://bugs.webkit.org/show_bug.cgi?id=143226

Reviewed by Chris Dumez.

Source/WebKit2:

Follow-up to cover Cache-control: no-cache case which also has zero cache lifetime.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeStoreDecision):

LayoutTests:

  • http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy-expected.txt:
2:25 PM Changeset in webkit [182153] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Include cache entry worth to json dump
​https://bugs.webkit.org/show_bug.cgi?id=143202

Follow-up fix.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::computeRecordWorth):

This accidentally gave the error case worth 1 rather than 0 as it should be.

2:09 PM Changeset in webkit [182152] by Antti Koivisto
  • 17 edits in trunk

Don't cache resources that are very unlikely to be reused
​https://bugs.webkit.org/show_bug.cgi?id=143226
<rdar://problem/20347160>

Reviewed by Geoff Garen.

Source/WebCore:

Allow overriding resource load priorities via Internals for testing.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::clearTestingOverrides):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::setOverrideResourceLoadPriorityForTesting):
(WebCore::FrameLoader::clearOverrideCachePolicyForTesting): Deleted.

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):

  • page/DiagnosticLoggingKeys.h:

Add a key.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::stringToResourceLoadPriority):
(WebCore::Internals::setOverrideResourceLoadPriority):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

We are writing lots of resources to the cache that are never used again.

In browse-around-randomly test this reduced number of cache entries created by ~20% and bytes written by ~5%.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):

Rename for clarity.

(WebKit::NetworkCache::makeStoreDecision):

Store only if the resource has non-zero expiration or has validation headers.

Very High priority resources (main resources) keep the existing policy to minimize impact
on back navigation and tab restore.

(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::canUse): Deleted.
(WebKit::NetworkCache::canRetrieve): Deleted.
(WebKit::NetworkCache::canStore): Deleted.

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::storeDecisionToDiagnosticKey):

LayoutTests:

  • http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.txt:
  • http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.html:

Keep max-age: 0 cacheable in this test by adding a validation header.

  • http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy-expected.txt:
  • http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html:

Rebase and expand to cover the high priority resource case.

1:12 PM Changeset in webkit [182151] by peavo@outlook.com
  • 3 edits in trunk/Source/JavaScriptCore

Avoid using hardcoded values for JSValue::Int32Tag, if possible.
​https://bugs.webkit.org/show_bug.cgi?id=143134

Reviewed by Geoffrey Garen.

  • jit/JSInterfaceJIT.h:
  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):

12:52 PM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
12:02 PM Changeset in webkit [182150] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

Swipe snapshot removed too early (jumps around) on arstechnica and NYT
​https://bugs.webkit.org/show_bug.cgi?id=143199
<rdar://problem/18420467>

Reviewed by Dan Bernstein.

Make ViewGestureControllerIOS's snapshot removal timing behave more like the Mac version.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
Let ViewGestureController know when the page has finished state restoration.

(-[WKWebView _didFinishLoadForMainFrame]):
(-[WKWebView _didSameDocumentNavigationForMainFrame:]):
Forward these to ViewGestureController.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didFinishLoadForMainFrame):
Forward didFinishLoadForMainFrame to WKWebView.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
Split the swipe snapshot removal state into a bunch of bools.

(WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::removeSwipeSnapshotIfReady):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Unify the snapshot removal logic into one function; removeSwipeSnapshotIfReady
completely owns the decision. For now, we're waiting for everything, but
we can do better in the future (using firstVisuallyNonEmptyLayout like Mac used to).

(WebKit::ViewGestureController::didRestoreScrollPosition):
(WebKit::ViewGestureController::didFinishLoadForMainFrame):
(WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
(WebKit::ViewGestureController::activeLoadMonitoringTimerFired):
Add more conditions for swipe snapshot removal. We'll now wait for
didFinishLoadForMainFrame (or didSameDocumentNavigationForMainFrame),
for active loads to finish, and for the scroll position to be restored.
This brings the iOS implementation in line with the slightly better Mac
implementation, and also sets the stage for deduplication of all of this code.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):

11:58 AM Changeset in webkit [182149] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline accessibility/aria-toggle-button-with-title.html
​https://bugs.webkit.org/show_bug.cgi?id=143229

Unreviewed.

Revision r182012 updates the way a role=button + aria-pressed object should be exposed as AXCheckbox. We need to create a new baseline.

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-30

  • platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Added.
11:52 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
11:36 AM Changeset in webkit [182148] by fpizlo@apple.com
  • 4 edits
    5 adds in trunk/Source/JavaScriptCore

REGRESSION: js/regress/inline-arguments-local-escape.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=143104

Reviewed by Geoffrey Garen.

Created a test that is a 100% repro of the flaky failure. This test is called
get-my-argument-by-val-for-inlined-escaped-arguments.js. It fails all of the time because it
always causes the compiler to emit a GetMyArgumentByVal of the arguments object returned by
the inlined function. Other than that, it's the same as inline-arguments-local-escape.

Also created three more tests for three similar, but not identical, failures.

Then fixed the bug: PreciseLocalClobberize was assuming that if we read(Stack) then we are
only reading those parts of the stack that are relevant to the current semantic code origin.
That's false after ArgumentsEliminationPhase - we might have operations on phantom arguments,
like GetMyArgumentByVal, ForwardVarargs, CallForwardVarargs, and ConstructForwardVarargs, that
read parts of the stack associated with the inline call frame for the phantom arguments. This
may not be subsumed by the current semantic origin's stack area in cases that the arguments
were allowed to "locally" escape.

The higher-order lesson here is that in DFG SSA IR, the current semantic origin's stack area
is not really a meaningful concept anymore. It is only meaningful for nodes that will read
the stack due to function.arguments, but there are a bunch of other ways that we could also
read the stack and those operations may read any stack slot. I believe that this change makes
PreciseLocalClobberize right: it will refine a read(Stack) from Clobberize correctly by casing
on node type. In future, if we add a read(Stack) to Clobberize, we'll have to make sure that
readTop() in PreciseLocalClobberize does the right thing.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

  • dfg/DFGPutStackSinkingPhase.cpp:
  • tests/stress/call-forward-varargs-for-inlined-escaped-arguments.js: Added.
  • tests/stress/construct-forward-varargs-for-inlined-escaped-arguments.js: Added.
  • tests/stress/forward-varargs-for-inlined-escaped-arguments.js: Added.
  • tests/stress/get-my-argument-by-val-for-inlined-escaped-arguments.js: Added.
  • tests/stress/real-forward-varargs-for-inlined-escaped-arguments.js: Added.
11:33 AM Changeset in webkit [182147] by jfernandez@igalia.com
  • 34 edits
    5 adds in trunk

[CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3
​https://bugs.webkit.org/show_bug.cgi?id=133359

Reviewed by David Hyatt.

From Blink r164817 and r165264 by <​jchaffraix@chromium.org>

Source/WebCore:

Broaden justify-self's parsing name

This is in preparation of migrating align-self, align-items
and justify-items to the CSS 3 Alignment syntax.

The current naming was too tied to justify-self and needs to
be broadened. This will reduce the follow-up implementations'
patches.

Upgrade align-self and align-items parsing to CSS 3

This change migrates the 2 properties to the CSS 3 Alignment
parsing. The new parsing is identical to how we parse
'justify-self'. The 2 properties need to be migrated together
as they are used in tandem in CSSComputedStyleDeclaration.

This change also removes EAlignItems as it is now unused.

Tests: css3/parse-align-items.html

css3/parse-align-self.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::resolveAlignmentAuto): Added. Resolves the "auto" value for the alignment properties.
(WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties.
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): Removed align-self, align-items and justify-items.

(WebCore::isKeywordPropertyID): Removed align-self, align-items and justify-items.
(WebCore::isBaselinePositionKeyword): Added. Set of keywords related to baseline value.
(WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties.
(WebCore::CSSParser::parseJustifySelf): Deleted.
(WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties.

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added.
(WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration.
(WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added.
(WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted.

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInheritAlignSelf): Added.
(WebCore::StyleBuilderCustom::applyInitialAlignSelf): Added.
(WebCore::StyleBuilderCustom::applyValueAlignSelf): Added.
(WebCore::StyleBuilderCustom::applyInheritAlignItems): Added.
(WebCore::StyleBuilderCustom::applyInitialAlignItems): Added.
(WebCore::StyleBuilderCustom::applyValueAlignItems): Added.
(WebCore::StyleBuilderCustom::applyInheritJustifySelf): Added.
(WebCore::StyleBuilderCustom::applyInitialJustifySelf): Added.
(WebCore::StyleBuilderCustom::applyValueJustifySelf): Added.
(WebCore::StyleBuilderCustom::applyValueWebkitJustifySelf): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): isDisplayFlexibleOrGridBox now a RenderStyle function.
(WebCore::isDisplayFlexibleBox): Deleted. Moved to RenderStyle.
(WebCore::isDisplayGridBox): Deleted. Moved to RenderStyle.
(WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to RenderStyle.

  • rendering/RenderBox.cpp:

(WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPostition enum.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPostition enum.
(WebCore::resolveAlignment): Deleted. Moved to RenderStyle.

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFullScreen.cpp:

(WebCore::createFullScreenStyle): Adapted to the new ItemPostition enum.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPostition enum.

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPostition enum.

  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPostition enum.
(WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPostition enum.

  • rendering/style/ContentData.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::resolveAlignment): Added.

  • rendering/style/RenderStyle.h: Adapted to the new ItemPostition enum.
  • rendering/style/RenderStyleConstants.h: Adapted to the new ItemPostition enum.
  • rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPostition enum.

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPostition enum.
(WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPostition enum.

  • rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPostition enum.
  • style/StyleResolveTree.cpp:

(WebCore::Style::determineChange): Changes in the alignItems property cause a Detach.

LayoutTests:

Broaden justify-self's parsing name and upgrade align-self and
align-items parsing to CSS 3.

  • TestExpectations:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/parse-align-items-expected.txt: Added.
  • css3/parse-align-items.html: Added.
  • css3/parse-align-self-expected.txt: Added.
  • css3/parse-align-self.html: Added.
  • css3/resources/alignment-parsing-utils.js: Added.

(checkValues):
(checkBadValues):
(checkInitialValues):
(checkInheritValues):
(checkLegacyValues):

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/css/parse-justify-self-expected.txt:
  • fast/css/parse-justify-self.html:
  • svg/css/getComputedStyle-basic-expected.txt:
11:02 AM Changeset in webkit [182146] by hyatt@apple.com
  • 5 edits
    6 adds in trunk

[New Block-Inside-Inline Model] Create anonymous inline blocks to hold blocks-inside-inlines.
​https://bugs.webkit.org/show_bug.cgi?id=143145

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/block/inside-inlines/ tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::renderName):
Add support for labeling anonymous inline-blocks when dumped by the render tree.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):
When the pref is set to use the new block-inside-inline model, create an anonymous inline block to
hold block children of RenderInlines instead of splitting flows or creating continuations.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousInlineBlock):
Add the definition of isAnonymousInlineBlock (note the exclusion of Ruby, since Ruby creates anonymous
inline-blocks also).

LayoutTests:

  • fast/block/inside-inlines: Added.
  • fast/block/inside-inlines/empty-block-expected.html: Added.
  • fast/block/inside-inlines/empty-block.html: Added.
  • fast/block/inside-inlines/new-model: Added.
  • fast/block/inside-inlines/new-model/empty-block-expected.html: Added.
  • fast/block/inside-inlines/new-model/empty-block.html: Added.
10:35 AM Changeset in webkit [182145] by Chris Dumez
  • 6 edits
    2 adds in trunk

[WK2][NetworkCache] Add support for "Cache-Control: max-stale" request header
​https://bugs.webkit.org/show_bug.cgi?id=143159
<rdar://problem/20333296>

Reviewed by Antti Koivisto.

Source/WebCore:

Add support for "Cache-Control: max-stale" request header:
​https://tools.ietf.org/html/rfc7234#section-5.2.1.2

Test: http/tests/cache/disk-cache/disk-cache-request-max-stale.html

  • platform/network/CacheValidation.cpp:

(WebCore::parseCacheControlDirectives):

  • platform/network/CacheValidation.h:

Source/WebKit2:

Add support for "Cache-Control: max-stale" request header:
​https://tools.ietf.org/html/rfc7234#section-5.2.1.2

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::responseHasExpired):
(WebKit::NetworkCache::requestRequiresRevalidation):
(WebKit::NetworkCache::canUse):

LayoutTests:

Add layout test to cover support for "Cache-Control: max-stale" request
header.

  • http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-request-max-stale.html: Added.
10:06 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
10:04 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
10:01 AM Changeset in webkit [182144] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update install-dependencies Fedora packages after r181624
​https://bugs.webkit.org/show_bug.cgi?id=143215

Add json-glib, libv4l, openssl and pulseaudio development packages to
the Fedora list providing we need them to build WebKit dependencies
for this distribution.

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-30
Reviewed by Philippe Normand.

  • gtk/install-dependencies:
10:01 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
9:45 AM Changeset in webkit [182143] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix iOS internal build after r182132.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):

9:34 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
9:30 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
9:29 AM Changeset in webkit [182142] by commit-queue@webkit.org
  • 20 edits in trunk/Source/WebInspectorUI

Web Inspector: Add more ESLint rules that reflect the current state of the code base
​https://bugs.webkit.org/show_bug.cgi?id=143212

Patch by Tobias Reiss <​tobi+webkit@basecode.de> on 2015-03-30
Reviewed by Timothy Hatcher.

  • .eslintrc:

Define some utilities as globals.
Replace "no-comma-dangle" with "comma-dangle". "no-comma-dangle" is deprecated and does not trigger in ESLint v.0.17.1
Set "new-cap" to 0 due to the usage of "WebInspector.UIString".
Disable "no-redeclare" for now and enable it back as soon as block scoped let is used.
Disable "dot-notation", "no-shadow" and "no-use-before-define" due to a lot of hits.
Disable "no-inner-declarations" as this is a common pattern to save memory.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:
  • UserInterface/Models/SourceCodeLocation.js:

It's not necessary to initialize x to undefined.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:
  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
  • UserInterface/Views/TextEditor.js:
  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

Remove unused variable x.

  • UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
  • UserInterface/Models/PropertyPath.js:
  • UserInterface/Views/RadioButtonNavigationItem.js:
  • UserInterface/Views/ReplayDashboardView.js:
  • UserInterface/Models/ScriptSyntaxTree.js:
  • UserInterface/Views/SourceCodeTextEditor.js:
  • UserInterface/Views/SourceCodeTreeElement.js:

Remove trailing and unexpected whitespace.

  • UserInterface/Views/ProbeSetDataGrid.js:
  • UserInterface/Views/TimelineRuler.js:

Add missing semicolon.

  • UserInterface/Views/TimelineDataGrid.js:
  • UserInterface/Views/TimelineRecordFrame.js:

Add missing var statement.

  • UserInterface/Views/TypeTokenView.js:

Remove unnecessary bind.

9:15 AM Changeset in webkit [182141] by jer.noble@apple.com
  • 31 edits
    4 adds in trunk

[iOS] When Web Audio is interrupted by a phone call, it cannot be restarted.
​https://bugs.webkit.org/show_bug.cgi?id=143190

Reviewed by Darin Adler.

Source/WebCore:

Tests: webaudio/audiocontext-state-interrupted.html

webaudio/audiocontext-state.html

Implement the following methods and properties from the Web Audio spec:
close(), suspend(), resume(), onstatechange.

AudioContext will take more responsibility for tracking state and interruptions (and
AudioDestination will give up that responsibility). This means AudioContext must be a
MediaSessionClient, and own its own MediaSession. In return, AudioDestinationIOS and
AudioDestinationMac relinquish both.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext): Set default values in header.
(WebCore::AudioContext::uninitialize): Call setState() instead of setting m_state.
(WebCore::AudioContext::addReaction): Added. Append the callback to the appropriate vector for the state.
(WebCore::AudioContext::setState): Added. Fire events and resolve the appropriate reaction callbacks for the new state.
(WebCore::AudioContext::state): Return a string representing the context's state.
(WebCore::AudioContext::stop): Close the event queue.
(WebCore::AudioContext::startRendering): Call setState().
(WebCore::AudioContext::fireCompletionEvent): Call setState().
(WebCore::AudioContext::suspendContext): Added. Add reaction callback and call suspend() on the destination node.
(WebCore::AudioContext::resumeContext): Added. Add reaction callback and call resume() on the destination node.
(WebCore::AudioContext::closeContext): Added. Add reaction callback and call close() on the destination node.
(WebCore::AudioContext::suspendPlayback): Added. Suspend playback and set state to interrupted.
(WebCore::AudioContext::mayResumePlayback): Added. Conditionally resume playback.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::suspend): Added. Create and return a new Promise object.
(WebCore::JSAudioContext::resume): Ditto.
(WebCore::JSAudioContext::close): Ditto.

  • Modules/webaudio/AudioContext.idl: Add new methods and properties.

Extensive organizational changes were made to AudioContext.h to group instance
variables together and add C++11 initializers in their declarations:

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::mediaType): Moved from AudioDestinationNode.
(WebCore::AudioContext::presentationType): Ditto.
(WebCore::AudioContext::canReceiveRemoteControlCommands): Ditto.
(WebCore::AudioContext::didReceiveRemoteControlCommand): Ditto.
(WebCore::AudioContext::overrideBackgroundPlaybackRestriction): Ditto.

Other changes to support the new AudioContext methods:

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::resume): Add empty default virtual method.
(WebCore::AudioDestinationNode::suspend): Ditto.
(WebCore::AudioDestinationNode::close): Ditto.

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume): Added. Pass to AudioDestination.
(WebCore::DefaultAudioDestinationNode::suspend): Ditto.
(WebCore::DefaultAudioDestinationNode::close): Ditto.

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve): Add an overload for a nullptr resolve value.

  • dom/EventNames.h: Added 'statechange'.
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::Task::Task): Add a constructor which takes a void() callback.

Modify MediaSession, AudioSession, and MediaSessionManager to support the new
interruption behavior.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspendPlayback): Renamed from pausePlayback().
(WebCore::HTMLMediaElement::mayResumePlayback): Renamed from resumePlayback().

  • html/HTMLMediaElement.h:
  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::tryToSetActive): Renamed from setActive. Return true by default.
(WebCore::AudioSession::setActive): Deleted.

  • platform/audio/AudioSession.h:
  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::beginInterruption): pausePlayback() was renamed to suspendPlayback().
(WebCore::MediaSession::endInterruption): Always notify the client, telling it whether to resume.
(WebCore::MediaSession::clientWillBeginPlayback): Bail early if reentrant. Check the (new)

return value of sessionWillBeginPlayback() and remember to resume once the interruption ends.

(WebCore::MediaSession::clientWillPausePlayback): Bail early if reentrant.
(WebCore::MediaSession::pauseSession): pausePlayback() was renamed to suspendPlayback().

  • platform/audio/MediaSession.h:
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::sessionWillBeginPlayback): Return false if not allowed to break interruption or

if activating the audio session failed. Otherwise, end the interruption.

  • platform/audio/MediaSessionManager.h:
  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::AudioDestinationIOS): m_mediaSession was removed.
(WebCore::AudioDestinationIOS::start): Ditto.

  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::tryToSetActive): Renamed from setActive. Return false if the AVAudioSession could not be activated.
(WebCore::AudioSession::setActive): Deleted.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback): Do not update the now playing info if session playback was blocked.

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac): m_mediaSession was removed.

  • platform/audio/mac/AudioDestinationMac.h:
  • platform/audio/mac/AudioSessionMac.cpp:

(WebCore::AudioSession::tryToSetActive): Renamed from setActive(). Return true by default.
(WebCore::AudioSession::setActive): Deleted.

  • platform/audio/mac/MediaSessionManagerMac.cpp:

(MediaSessionManager::updateSessionState): No longer attempt to activate the session, as this is done

MediaSessionManager::sessionWillBeginPlayback().

  • testing/Internals.cpp:

(WebCore::Internals::setMediaSessionRestrictions): Add "InterruptedPlaybackNotPermitted".

LayoutTests:

  • webaudio/audiocontext-state-expected.txt: Added.
  • webaudio/audiocontext-state-interrupted-expected.txt: Added.
  • webaudio/audiocontext-state-interrupted.html: Added.
  • webaudio/audiocontext-state.html: Added.
8:32 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
8:23 AM Changeset in webkit [182140] by youenn.fablet@crf.canon.fr
  • 7 edits in trunk

[Streams API] Error storage should be moved from source to stream/reader
​https://bugs.webkit.org/show_bug.cgi?id=143048

Reviewed by Benjamin Poulain.

This patch removes error storage from the source as it should be stored at the stream level as error access goes through the reader.
It removes abstract ReadableStreamSource::isErrored and the storage of JavaScript errors from ReadableStreamJSSource.

Existing tests cover most of the changes.
Added test case for creating readable stream from empty JS object.

  • Modules/streams/ReadableStreamSource.h: Removing isErrored().
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::constructJSReadableStream): Added JS stream constructor parameters checking.

  • bindings/js/ReadableStreamJSSource.cpp:

(WebCore::ReadableStreamJSSource::ReadableStreamJSSource): Removed JS stream constructor parameters checking.
(WebCore::ReadableStreamJSSource::start): Changed prototype of start so that start can throw errors directly.
(WebCore::ReadableStreamJSSource::setInternalError): Deleted.

  • bindings/js/ReadableStreamJSSource.h: Removed m_error, setInternalError and updated start declaration.
8:22 AM Changeset in webkit [182139] by Philippe Normand
  • 5 edits in trunk/Source/WebCore

[GStreamer] More GL shared context fixes
​https://bugs.webkit.org/show_bug.cgi?id=143216

Reviewed by Carlos Garcia Campos.

Moved the GLX/EGL context tests to be done at runtime rather than
using build-time macros because in the GTK port at least, both EGL
and GLX support are mutually exclusive. Also fixed a couple wrong
defines (USE(GLES2) doesn't exist).

  • platform/graphics/GLContext.h: Simple utility method to check if

the platform context is compatible with EGL APIs or not.

  • platform/graphics/egl/GLContextEGL.h:

(WebCore::GLContextEGL::isEGLContext):

  • platform/graphics/glx/GLContextGLX.h:

(WebCore::GLContextGLX::isEGLContext):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): Do
runtime checks and properly ensure GLES2/GL API usage.

6:17 AM Changeset in webkit [182138] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[EFL][GTK] WebKit2's generate-forwarding-headers.pl should fail if clashing headers found
​https://bugs.webkit.org/show_bug.cgi?id=142909

Reviewed by Philippe Normand.

  • Scripts/generate-forwarding-headers.pl:

(createForwardingHeadersForFramework):

5:41 AM Changeset in webkit [182137] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore:
Add support for deleting emoji on GTK
​https://bugs.webkit.org/show_bug.cgi?id=141419

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.

The code for deleting special group of characters was specific for
COCOA and EFL platforms. The fix consists on add GTK to the #if
preprocessor directive.

  • rendering/RenderText.cpp:

(WebCore::RenderText::previousOffsetForBackwardDeletion):

LayoutTests:
Update expectations for delete-emoji test since the bug is fixed now.
​https://bugs.webkit.org/show_bug.cgi?id=141419

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.

  • platform/gtk/TestExpectations:
5:22 AM Changeset in webkit [182136] by Antti Koivisto
  • 6 edits in trunk/Source/WebKit2

Include cache entry worth to json dump
​https://bugs.webkit.org/show_bug.cgi?id=143202

Reviewed by Darin Adler.

This is useful for analyzing cache performance.
Also include the body size, total item count and average worth.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::traverse):
(WebKit::NetworkCache::Cache::dumpContentsToFile):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::asJSON):

  • NetworkProcess/cache/NetworkCacheEntry.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::traverse):

Add flags for specificying what sort of information is needed.

(WebKit::NetworkCache::computeRecordWorth):

Factor to a function.

(WebKit::NetworkCache::deletionProbability):

  • NetworkProcess/cache/NetworkCacheStorage.h:
12:25 AM Changeset in webkit [182135] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Tools

Unreviewed, rolling out r182119.
​https://bugs.webkit.org/show_bug.cgi?id=143196

problem with syntax (Requested by youenn on #webkit).

Reverted changeset:

"[buildbot] clean-build script should remove untracked files
and revert local changes too"
​https://bugs.webkit.org/show_bug.cgi?id=142400
​http://trac.webkit.org/changeset/182119

12:20 AM Changeset in webkit [182134] by benjamin@webkit.org
  • 5 edits
    2 adds in trunk

Start the features.json files
​https://bugs.webkit.org/show_bug.cgi?id=143207

Reviewed by Darin Adler.

Source/JavaScriptCore:

Start the features.json files to have something to experiment
with for the UI.

  • features.json: Added.

Source/WebCore:

  • features.json: Added.

Tools:

I kept the style checking light. We'll have to figure
what is the best format for each field.

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONContributorsChecker.check):
(JSONFeaturesChecker):
(JSONFeaturesChecker.check):

12:11 AM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)

Mar 29, 2015:

9:17 PM Changeset in webkit [182133] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix iOS scrollperf crash after a web process crash
​https://bugs.webkit.org/show_bug.cgi?id=143110

Reviewed by Dean Jackson.

When we destroy the drawing area after a web process crash, we also need to destroy
the scrollingPerformanceData which has a reference to the drawing area.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

9:13 PM Changeset in webkit [182132] by Simon Fraser
  • 24 edits in trunk/Source

Convert arguments to ScrollingCoordinator functions to references
​https://bugs.webkit.org/show_bug.cgi?id=143198

Reviewed by Darin Adler.

Convert all the FrameView* and ScrollableArea* arguments to ScrollingCoordinator functions to
references, and use references in a few other places.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

  • page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/FrameView.cpp:

(WebCore::FrameView::prepareForDetach):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::requestScrollPositionUpdate):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::scrollableAreaSetChanged):
(WebCore::FrameView::wheelEvent):

  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

  • page/Page.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::AsyncScrollingCoordinator::updateMainFrameScrollLayerPosition):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore::ScrollingCoordinator::scrollLayerForFrameView):
(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):
(WebCore::ScrollingCoordinator::counterScrollingLayerForFrameView):
(WebCore::ScrollingCoordinator::insetClipLayerForFrameView):
(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):
(WebCore::ScrollingCoordinator::rootContentLayerForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::synchronousScrollingReasons):
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons):
(WebCore::ScrollingCoordinator::setForceSynchronousScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionSynchronously):
(WebCore::ScrollingCoordinator::replaySessionStateDidChange):
(WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):

  • page/scrolling/ScrollingCoordinator.h: Align the bitmask enums to make mistakes easier to spot.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::handleWheelEvent):
(WebCore::ScrollingCoordinator::willDestroyScrollableArea):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateOverflowControlsLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::hasCoordinatedScrolling):
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::destroyRootLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):

  • testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects):

Source/WebKit2:

  • WebProcess/Scrolling/RemoteScrollingCoordinator.h:
  • WebProcess/Scrolling/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::coordinatesScrollingForFrameView):

8:43 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
8:12 PM Changeset in webkit [182131] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Use :matches() instead of :-webkit-any() for the sections and headings default style
​https://bugs.webkit.org/show_bug.cgi?id=143197

Reviewed by Darin Adler.

We no longer need to use the :-webkit-any() hack in the default stylesheet.

The pseudo class :matches() also support correct specificity. This is not observable
since those selector do not conflict with any other rule in the default stylesheet.

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkMatchType):

  • css/html.css:

(:matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.

8:10 PM Changeset in webkit [182130] by benjamin@webkit.org
  • 5 edits
    6 adds in trunk

currentColor computes to the same colour on all elements, even if 'color' is inherited differently
​https://bugs.webkit.org/show_bug.cgi?id=133420

Reviewed by Darin Adler.

Source/WebCore:

When resolving a style with the help of the property cache, we were
completely ignoring currentColor.

Since you can set currentColor on properties that are not inherited,
those properties would just be copied from the cached style, which
may have a completely different inherited color.

This pacth fixes the issue by preventing any MatchResult from hitting
the cache if it contains any non-inherited property that would require
resolution by the cache:
-Using the inherit value.
-Using the currentColor value.

Tests: fast/css/currentColor-on-before-after-pseudo-elements.html

fast/css/currentColor-style-update-reftest.html
fast/css/currentColor-value-style-update.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::findFromMatchedPropertiesCache):
(WebCore::StyleResolver::addToMatchedPropertiesCache):
(WebCore::extractDirectionAndWritingMode):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::CascadedProperties::addStyleProperties):
(WebCore::StyleResolver::CascadedProperties::addMatches):

  • css/StyleResolver.h:

(WebCore::StyleResolver::MatchResult::matchedProperties):

LayoutTests:

  • fast/css/currentColor-on-before-after-pseudo-elements-expected.html: Added.
  • fast/css/currentColor-on-before-after-pseudo-elements.html: Added.
  • fast/css/currentColor-style-update-reftest-expected.html: Added.
  • fast/css/currentColor-style-update-reftest.html: Added.
  • fast/css/currentColor-value-style-update-expected.txt: Added.
  • fast/css/currentColor-value-style-update.html: Added.
8:05 PM Changeset in webkit [182129] by benjamin@webkit.org
  • 10 edits in trunk/Source/WebCore

Enable :any-link by default
​https://bugs.webkit.org/show_bug.cgi?id=143201

Reviewed by Sam Weinig.

The pseudo class :any-link has been stable for a while. This patch enables
it by default and remove the -webkit- prefix on the default style.

  • css/CSSDefaultStyleSheets.cpp:
  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • css/html.css:

(a:any-link):
(a:any-link:active):
(:any-link img):
(a:-webkit-any-link): Deleted.
(a:-webkit-any-link:active): Deleted.
(:-webkit-any-link img): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):

7:27 PM Changeset in webkit [182128] by gyuyoung.kim@samsung.com
  • 4 edits
    1 delete in trunk

[CMake] Update old CMakeList.txt in gtest
​https://bugs.webkit.org/show_bug.cgi?id=143192

Reviewed by Darin Adler.

CMake ports have used cmake/gtest/CMakeLists.txt instead of ThirdParty/test/CMakeLists.txt
in order to build gtest. However it looks ThirdParty/test/CMakeLists.txt won't be used anymore.
So this patch moves cmake/gtest/CMakeLists.txt to ThirdPart/test/CMakeLists.txt, and use it.

.:

  • Source/CMakeLists.txt:
  • Source/cmake/gtest/CMakeLists.txt: Removed.

Source/ThirdParty:

  • gtest/CMakeLists.txt:
7:00 PM Changeset in webkit [182127] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

nullptr cleanup in RenderFooBox classes
​https://bugs.webkit.org/show_bug.cgi?id=143182

Patch by Joonghun Park <​jh718.park@samsung.com> on 2015-03-29
Reviewed by Ryosuke Niwa.

No new tests, no behavior changes

Replace 0 with nullptr in RenderFooBox classes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::paintFillLayer):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:

(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(WebCore::RenderBox::setInlineBoxWrapper):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::firstLetterRemainingText):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveAllChildrenTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):

  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::checkConsistency):

  • rendering/RenderLineBoxList.h:

(WebCore::RenderLineBoxList::RenderLineBoxList):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::enclosingScrollableArea):
(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderListBox.h:
6:03 PM Changeset in webkit [182126] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WK2] WKContentView should implement _selectionClipRect
​https://bugs.webkit.org/show_bug.cgi?id=143143
rdar://problem/20330075

Reviewed by Benjamin Poulain.

UIKit checks if the text delegate responds to this selector
to retrieve the clipping rectangle for the editable element
where the selection is being create.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _selectionClipRect]):

5:33 PM Changeset in webkit [182125] by Darin Adler
  • 3 edits
    2 adds in trunk

HTMLCollection caches incorrect length if item(0) is called before length on an empty collection
​https://bugs.webkit.org/show_bug.cgi?id=143203
Source/WebCore:

rdar://problem/18460462

Reviewed by Antti Koivisto.

Test: fast/dom/htmlcollection-length-after-item-2.html

  • dom/CollectionIndexCache.h:

(CollectionIndexCache::nodeAt): If we hit the end looking for index 0, cache a length
of 0, not a length of 1.

LayoutTests:

Reviewed by Antti Koivisto.

  • fast/dom/htmlcollection-length-after-item-2-expected.txt: Added.
  • fast/dom/htmlcollection-length-after-item-2.html: Added.
4:43 PM Changeset in webkit [182124] by Antti Koivisto
  • 4 edits in trunk/Source/WebKit2

Use st_mtime instead of st_atime to track file access time
​https://bugs.webkit.org/show_bug.cgi?id=143200

Reviewed by Darin Adler.

On OS X atime updates automatically on read so calling Storage::traverse() would always ends up updating access times
for all cache entries to the current time. This would make entry worth computation produce unexpected results.
We update mtime manually on successful cache retrieve only so switching to it fixes the problem.

  • NetworkProcess/cache/NetworkCacheFileSystemPosix.h:

(WebKit::NetworkCache::fileTimes):
(WebKit::NetworkCache::updateFileModificationTimeIfNeeded):
(WebKit::NetworkCache::updateFileAccessTimeIfNeeded): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::deletionProbability):
(WebKit::NetworkCache::Storage::updateFileAccessTime): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.h:
2:54 PM Changeset in webkit [182123] by mmaxfield@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Addresing post-review comment after r182122
​https://bugs.webkit.org/show_bug.cgi?id=143189

Unreviewed.

1:56 PM Changeset in webkit [182122] by mmaxfield@apple.com
  • 8 edits
    1 copy in trunk/Source/JavaScriptCore

[Win] Allow building JavaScriptCore without Cygwin
​https://bugs.webkit.org/show_bug.cgi?id=143189

Reviewed by Brent Fulgham.

Paths like /usr/bin/ don't exist on Windows.
Hashbangs don't work on Windows. Instead we must explicitly call the executable.
Prefixing commands with environment variables doesn't work on Windows.
Windows doesn't have 'cmp'
Windows uses 'del' instead of 'rm'
Windows uses 'type NUL' intead of 'touch'

  • DerivedSources.make:
  • JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl:
  • JavaScriptCore.vcxproj/build-generated-files.pl:
  • UpdateContents.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl.
1:40 PM Changeset in webkit [182121] by Darin Adler
  • 124 edits in trunk/Source/WebCore

Remove unneeded SVG code, including most isSupportedAttribute functions
​https://bugs.webkit.org/show_bug.cgi?id=143194

Reviewed by Antti Koivisto.

  • Removed most implementations of isSupportedAttribute. Others can be removed in future patches. The ones left behind are now all private static member functions. It's dangerous for them to be public because they tend to indicate which attributes are supported at a particular level in the class hierarchy and they are not virtual functions; might want to rethink the function name if we keep any of these long term.
  • Removed unneeded includes, especially of Attr.h and Attribute.h.
  • Changed most parseAttribute and svgAttributeChanged functions so they no longer rely on checking attribute names against a set. Also removed lots of unneeded calls to SVGLangSpace::parseAttribute, which is called by SVGElement::parseAttribute and need not be called by derived classes.
  • Removed return values from parseAttribute functions. Skipping other parseAttribute logic is not an important optimization and makes functions needlessly complex.
  • Moved use of InstanceInvalidationGuard closer to where they are needed. Eventually we may be able to remove many of these.
  • Used auto in a few places where the same type is repeated twice on the same line of code, and auto makes it a bit smaller.
  • Got rid of protected sections in some final classes; doesn't make sense to combine these two. Also moved a few functions from protected to private in other classes.
  • Made a number of functions into static member functions in the base classes such as SVGLangSpace; they were not making any use of the object, and so it was wasteful to compile them as non-static member functions.
  • rendering/svg/RenderSVGImage.cpp: Removed unneeded includes.
  • svg/SVGAElement.cpp: Removed unneeded includes.

(WebCore::SVGAElement::isSupportedAttribute): Deleted.
(WebCore::SVGAElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGAElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGAElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimateMotionElement.cpp: Removed unneeded includes.

(WebCore::SVGAnimateMotionElement::isSupportedAttribute): Deleted.
(WebCore::SVGAnimateMotionElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGAnimateMotionElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute): Deleted.
(WebCore::SVGAnimateTransformElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGAnimateTransformElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute): Deleted.
(WebCore::SVGCircleElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGCircleElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGCircleElement.h: Removed isSupportedAttribute.
  • svg/SVGClipPathElement.cpp: Removed unneeded includes.

(WebCore::SVGClipPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGCursorElement.cpp: Removed unneeded includes.

(WebCore::SVGCursorElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGCursorElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGElement.cpp: Removed unneeded includes.
  • svg/SVGEllipseElement.cpp: Removed unneeded includes.

(WebCore::SVGEllipseElement::isSupportedAttribute): Deleted.
(WebCore::SVGEllipseElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGEllipseElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGEllipseElement.h: Removed isSupportedAttribute.
  • svg/SVGExternalResourcesRequired.cpp: Removed unneeded includes.

(WebCore::SVGExternalResourcesRequired::parseAttribute): Don't return a boolean.

  • svg/SVGExternalResourcesRequired.h: Don't return a boolean.
  • svg/SVGFEBlendElement.cpp: Removed unneeded includes.

(WebCore::SVGFEBlendElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEBlendElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEBlendElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEBlendElement.h: Removed isSupportedAttribute.
  • svg/SVGFEColorMatrixElement.cpp: Removed unneeded includes.

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEColorMatrixElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEColorMatrixElement.h: Removed isSupportedAttribute.
  • svg/SVGFEComponentTransferElement.cpp: Removed unneeded includes.

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEComponentTransferElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFEComponentTransferElement.h: Removed unneeded includes.
  • svg/SVGFECompositeElement.cpp: Removed unneeded includes.

(WebCore::SVGFECompositeElement::isSupportedAttribute): Deleted.
(WebCore::SVGFECompositeElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFECompositeElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: Removed unneeded includes.

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEConvolveMatrixElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDiffuseLightingElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDisplacementMapElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDropShadowElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDropShadowElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDropShadowElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEFloodElement.cpp: Removed unneeded includes.
  • svg/SVGFEGaussianBlurElement.cpp: Removed unneeded includes.

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEGaussianBlurElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: Removed unneeded includes.

(WebCore::SVGFEImageElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEImageElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEImageElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: Removed unneeded includes.

(WebCore::SVGFELightElement::isSupportedAttribute): Deleted.
(WebCore::SVGFELightElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFELightElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp: Removed unneeded includes.

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEMergeNodeElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: Removed unneeded includes.

(WebCore::SVGFEMorphologyElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEMorphologyElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEMorphologyElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: Removed unneeded includes.

(WebCore::SVGFEOffsetElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEOffsetElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEOffsetElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: Removed unneeded includes.

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute): Deleted.
(WebCore::SVGFESpecularLightingElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: Removed unneeded includes.

(WebCore::SVGFETileElement::isSupportedAttribute): Deleted.
(WebCore::SVGFETileElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFETileElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: Removed unneeded includes.

(WebCore::SVGFETurbulenceElement::isSupportedAttribute): Deleted.
(WebCore::SVGFETurbulenceElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFETurbulenceElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: Removed unneeded includes.

(WebCore::SVGFilterElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFilterPrimitiveStandardAttributes.cpp: Removed unneeded includes.

(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFilterPrimitiveStandardAttributes.h: Removed isSupportedAttribute and also moved a

couple functions out of the class definition.

  • svg/SVGFitToViewBox.cpp: Removed unneeded includes.
  • svg/SVGFontFaceElement.cpp: Removed unneeded includes.
  • svg/SVGFontFaceUriElement.cpp: Removed unneeded includes.
  • svg/SVGForeignObjectElement.cpp: Removed unneeded includes.

(WebCore::SVGForeignObjectElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGElement.cpp: Removed unneeded includes.

(WebCore::SVGGElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGlyphElement.cpp: Removed unneeded includes.
  • svg/SVGGlyphRefElement.cpp: Removed unneeded includes.

(WebCore::SVGGlyphRefElement::hasValidGlyphElement): Rewrote to use is<> instead of hasTagName.
(WebCore::SVGGlyphRefElement::parseAttribute): Don't use return value from SVGURIReference::parseAttribute.

  • svg/SVGGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGraphicsElement.cpp: Removed unneeded includes.

(WebCore::SVGGraphicsElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGImageElement.cpp: Removed unneeded includes.

(WebCore::SVGImageElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGLangSpace.cpp: Removed unneeded includes.

(WebCore::SVGLangSpace::parseAttribute): Removed the return value.

  • svg/SVGLangSpace.h: Converted functions to static member functions and removed the

return value from parseAttribute.

  • svg/SVGLineElement.cpp: Removed unneeded includes.

(WebCore::SVGLineElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGLinearGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGLinearGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGMPathElement.cpp: Removed unneeded includes.

(WebCore::SVGMPathElement::isSupportedAttribute): Deleted.
(WebCore::SVGMPathElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGMPathElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGMPathElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions

private instead of protected.

  • svg/SVGMarkerElement.cpp: Removed unneeded includes.

(WebCore::SVGMarkerElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGMaskElement.cpp: Removed unneeded includes.

(WebCore::SVGMaskElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPathElement.cpp: Removed unneeded includes.

(WebCore::SVGPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPatternElement.cpp: Removed unneeded includes.

(WebCore::SVGPatternElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPolyElement.cpp: Removed unneeded includes.

(WebCore::SVGPolyElement::isSupportedAttribute): Deleted.
(WebCore::SVGPolyElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGPolyElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGRadialGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGRectElement.cpp: Removed unneeded includes.

(WebCore::SVGRectElement::isSupportedAttribute): Deleted.
(WebCore::SVGRectElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGRectElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: Removed unneeded includes.

(WebCore::SVGSVGElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGScriptElement.cpp: Removed unneeded includes.
  • svg/SVGStopElement.cpp: Removed unneeded includes.

(WebCore::SVGStopElement::isSupportedAttribute): Deleted.
(WebCore::SVGStopElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGStopElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGStopElement.h: Removed isSupportedAttribute.
  • svg/SVGStyleElement.cpp: Removed unneeded includes.

(WebCore::SVGStyleElement::isSupportedAttribute): Deleted.
(WebCore::SVGStyleElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGStyleElement.h: Removed isSupportedAttribute.
  • svg/SVGSymbolElement.cpp: Removed unneeded includes.

(WebCore::SVGSymbolElement::isSupportedAttribute): Deleted.
(WebCore::SVGSymbolElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGSymbolElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGSymbolElement.h: Removed isSupportedAttribute.
  • svg/SVGTRefElement.cpp: Removed unneeded includes.

(WebCore::SVGTRefElement::isSupportedAttribute): Deleted.
(WebCore::SVGTRefElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTRefElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTRefElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions

private instead of protected.

  • svg/SVGTests.cpp: Removed unneeded includes.

(WebCore::SVGTests::parseAttribute): Removed return value.

  • svg/SVGTests.h: Removed return value of parseAttribute.
  • svg/SVGTextContentElement.cpp: Removed unneeded includes.

(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute): Don't use
isSupportedAttribute. Also removed global to optimize comparing attribute value against
the string "preserve".
(WebCore::SVGTextContentElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTextContentElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTextContentElement.h: Made isSupportedAttribute private instead of protected.
  • svg/SVGTextElement.cpp: Removed unneeded includes.
  • svg/SVGTextPathElement.cpp: Removed unneeded includes.

(WebCore::SVGTextPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGTextPositioningElement.cpp: Removed unneeded includes.

(WebCore::SVGTextPositioningElement::isSupportedAttribute): Deleted.
(WebCore::SVGTextPositioningElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTextPositioningElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTextPositioningElement.h: Removed isSupportedAttribute and made some functions

private insetad of protected.

  • svg/SVGURIReference.cpp: Removed unneeded includes.

(WebCore::SVGURIReference::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGURIReference.h:

(WebCore::SVGURIReference::isExternalURIReference):

  • svg/SVGUseElement.cpp: Removed unneeded includes.

(WebCore::SVGUseElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGViewElement.h: Removed isSupportedAttribute.
  • svg/animation/SVGSMILElement.cpp: Removed unneeded includes.
1:38 PM Changeset in webkit [182120] by Darin Adler
  • 42 edits in trunk/Source/WebCore

Remove unneeded includes of "Attribute.h"
​https://bugs.webkit.org/show_bug.cgi?id=143195

Reviewed by Antti Koivisto.

  • css/StyleResolver.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp:
  • html/HTMLBRElement.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLButtonElement.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLDivElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFontElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFrameElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHRElement.cpp:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLOListElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLParagraphElement.cpp:
  • html/HTMLParamElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPreElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLScriptElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLStyleElement.cpp:
  • html/HTMLTableCaptionElement.cpp:
  • html/HTMLTableCellElement.cpp:
  • html/HTMLTableColElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLUListElement.cpp:
  • html/HTMLVideoElement.cpp:
  • html/parser/HTMLScriptRunner.cpp:
  • inspector/InspectorNodeFinder.cpp:

Removed includes of "Attribute.h".

11:47 AM Changeset in webkit [182119] by youenn.fablet@crf.canon.fr
  • 6 edits
    1 add in trunk/Tools

[buildbot] clean-build script should remove untracked files and revert local changes too
​https://bugs.webkit.org/show_bug.cgi?id=142400

Reviewed by Ryosuke Niwa.

This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.

  • BuildSlaveSupport/clean-build:

(main): Adding call to Tools/Scripts/clean-webkit.

  • Scripts/clean-webkit: Added.

(main): Removes untracked and changed files.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.untracked_files): Retrieves GIT untracked files.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.untracked_files): Retrieves SVN untracked files.
(SCM):
(SCM.discard_untracked_files): Deletes untracked files/folders.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_untracked_files): Unit testing for untracked files.
(test_untracked_files):
(GitSVNTest.test_untracked_files):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.untracked_files):

Mar 28, 2015:

11:58 PM Changeset in webkit [182118] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Clean up JavaScriptCore/builtins
​https://bugs.webkit.org/show_bug.cgi?id=143177

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Ryosuke Niwa.

  • builtins/ArrayConstructor.js:

(from):

  • We can compare to undefined instead of using a typeof undefined check.
  • Converge on double quoted strings everywhere.
  • builtins/ArrayIterator.prototype.js:

(next):

  • builtins/StringIterator.prototype.js:

(next):

  • Use shorthand object construction to avoid duplication.
  • Improve grammar in error messages.
  • tests/stress/array-iterators-next-with-call.js:
  • tests/stress/string-iterators.js:
  • Update for new error message strings.
7:07 PM Changeset in webkit [182117] by eric.carlson@apple.com
  • 8 edits
    1 move
    1 add in trunk/Source/WebCore

[Mac] Update for output device API change
​https://bugs.webkit.org/show_bug.cgi?id=143187

Reviewed by Zalan Bujtas.

The API used for output device is being deprecated, update to the replacement.

  • WebCore.xcodeproj/project.pbxproj: Add SPI headers.
  • platform/graphics/MediaPlaybackTarget.h:

(WebCore::MediaPlaybackTarget::MediaPlaybackTarget): Update for API change.
(WebCore::MediaPlaybackTarget::setDevicePickerContext):
(WebCore::MediaPlaybackTarget::devicePickerContext):

  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:

(WebCore::MediaPlaybackTarget::encode):
(WebCore::MediaPlaybackTarget::decode):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::outputeDeviceAvailabilityChangedTimerFired):
(WebCore::MediaPlaybackTargetPickerMac::devicePicker):
(WebCore::MediaPlaybackTargetPickerMac::currentDeviceDidChange):
(WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets):
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVOutputDevicePickerMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

  • platform/spi/cocoa/AVKitSPI.h: Copied from Source/WebCore/platform/spi/ios/AVKitSPI.h. Moved

from ios directory, added Mac includes and prototypes.

  • platform/spi/ios/AVKitSPI.h: Removed.
  • platform/spi/mac/AVFoundationSPI.h: Added.
4:17 PM Changeset in webkit [182116] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Optimize RenderLayer::intersectsDamageRect() slightly
​https://bugs.webkit.org/show_bug.cgi?id=143186

Reviewed by Zalan Bujtas.

We can early return from RenderLayer::intersectsDamageRect() if the
damageRect is empty, since nothing will intersect with the empty rect.

Slight performance gain when scrolling overflow-scroll with lots of nested,
clipping layers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

1:44 PM Changeset in webkit [182115] by andersca@apple.com
  • 6 edits in trunk/Source

Remove an unused SPI method from WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=143185

Reviewed by Sam Weinig.

Source/WebCore:

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::storeCopyOfCache): Deleted.

  • loader/appcache/ApplicationCacheStorage.h:

Source/WebKit/mac:

  • WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]): Deleted.

  • WebView/WebDataSourcePrivate.h:
10:28 AM Changeset in webkit [182114] by saambarati1@gmail.com
  • 12 edits
    1 add in trunk/Source

Web Inspector: ES6: Better support for Symbol types in Type Profiler
​https://bugs.webkit.org/show_bug.cgi?id=141257

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

ES6 introduces the new primitive type Symbol. This patch makes JSC's
type profiler support this new primitive type.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • inspector/protocol/Runtime.json:
  • runtime/RuntimeType.cpp:

(JSC::runtimeTypeForValue):

  • runtime/RuntimeType.h:

(JSC::runtimeTypeIsPrimitive):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::dumpTypes):
(JSC::TypeSet::doesTypeConformTo):
(JSC::TypeSet::displayName):
(JSC::TypeSet::inspectorTypeSet):
(JSC::TypeSet::toJSONString):

  • runtime/TypeSet.h:

(JSC::TypeSet::seenTypes):

  • tests/typeProfiler/driver/driver.js:
  • tests/typeProfiler/symbol.js: Added.

(wrapper.foo):
(wrapper.bar):
(wrapper.bar.bar.baz):
(wrapper):

Source/WebInspectorUI:

The Web Inspector's visualization of JSC's type profiler
should have support for the Symbol type.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

  • UserInterface/Views/TypeTokenView.css:

TypeTokenView will display Symbol type tokens using the same color that
Symbol values are displayed as formatted values.

(.type-token-symbol):

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._displayTypeName):
(WebInspector.TypeTokenView):

9:38 AM Changeset in webkit [182113] by commit-queue@webkit.org
  • 27 edits in trunk

Web Inspector: Adopt Array.prototype.includes and String.prototype.includes
​https://bugs.webkit.org/show_bug.cgi?id=143176

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

Remove our custom implementations of Array/String contains functions.

  • UserInterface/Base/Main.js:

(WebInspector._updateContentViewForCurrentNavigationSidebar):
(WebInspector._contentBrowserCurrentContentViewDidChange):

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions.):
(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):

  • UserInterface/Controllers/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
(WebInspector.FrameResourceManager):

  • UserInterface/Controllers/LayerTreeManager.js:

(WebInspector.LayerTreeManager.prototype.layerTreeMutations):

  • UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype._extraDomainsActivated):
(WebInspector.StorageManager):

  • UserInterface/Models/Branch.js:

(WebInspector.Branch.prototype.addRevision):

  • UserInterface/Models/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):

  • UserInterface/Models/CSSRule.js:

(WebInspector.CSSRule.prototype.get matchedSelectors):

  • UserInterface/Models/CSSStyleDeclaration.js:
  • UserInterface/Models/Color.js:

(WebInspector.Color.fromString):

  • UserInterface/Models/DOMNode.js:
  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
(WebInspector.CSSStyleDetailsSidebarPanel):

  • UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype._updateContentViewSelectionPathNavigationItem):

  • UserInterface/Views/DOMTreeElement.js:
  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._resourceAdded):

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.addClassName):
(WebInspector.GeneralTreeElement.prototype.removeClassName):

  • UserInterface/Views/LegacyConsoleMessageImpl.js:

(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._updateMessagesSelection):

  • UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype._findNavigationItem):

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.findSidebarPanel):
Replace contains with includes where appropriate.

LayoutTests:

  • inspector/css/pseudo-element-matches.html:
9:33 AM Changeset in webkit [182112] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Tweak node styles in ObjectTreeView
​https://bugs.webkit.org/show_bug.cgi?id=143179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:

(.console-group-messages .outline-disclosure.single-node li):

  • UserInterface/Views/DOMTreeOutline.css:

(.dom-tree-outline.single-node li):
This style makes sense as a generic DOMTreeOutline style.

  • UserInterface/Views/FormattedValue.css:

(.formatted-node > .dom-tree-outline):
(.formatted-node > .dom-tree-outline ol):
(.formatted-node > .dom-tree-outline li.hovered:not(.selected) .selection):
Style for nodes in ObjectTreeView.

  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree-array-index .index-value .formatted-node .dom-tree-outline):
Styles for node in Array value.

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForNode):
Address the FIXME.

4:59 AM Changeset in webkit [182111] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

nullptr cleanup in InlineFooBox classes
​https://bugs.webkit.org/show_bug.cgi?id=143178

Patch by Joonghun Park <​jh718.park@samsung.com> on 2015-03-28
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes

Replace 0 with nullptr in InlineFooBox classes.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::removeChild):
(WebCore::InlineFlowBox::deleteLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::getLogicalStartBoxWithNode):
(WebCore::RootInlineBox::getLogicalEndBoxWithNode):

  • rendering/RootInlineBox.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::SVGInlineTextBox):
(WebCore::SVGInlineTextBox::releasePaintingResource):
(WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::findFirstAndLastAttributesInVector):

  • rendering/svg/SVGRootInlineBox.h:
2:57 AM Changeset in webkit [182110] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

REGRESSION(r181326): It made dfg-int16array.js and dfg-int8array.js fail on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=142629

Unreviewed gardening, unskip now passing tests after r182091.

  • js/script-tests/dfg-int16array.js:
  • js/script-tests/dfg-int8array.js:

Mar 27, 2015:

11:01 PM Changeset in webkit [182109] by saambarati1@gmail.com
  • 3 edits
    3 adds in trunk

Deconstruction parameters are bound too late
​https://bugs.webkit.org/show_bug.cgi?id=143148

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Currently, a deconstruction pattern named with the same
name as a function will shadow the function. This is
wrong. It should be the other way around.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

LayoutTests:

  • js/regress/deconstructing-parameters-overridden-by-function-expected.txt: Added.
  • js/regress/deconstructing-parameters-overridden-by-function.html: Added.
  • js/regress/script-tests/deconstructing-parameters-overridden-by-function.js: Added.

(f):
(test):
(.arg):

10:45 PM Changeset in webkit [182108] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

More modern loops in RenderLayer.cpp
​https://bugs.webkit.org/show_bug.cgi?id=143175

Reviewed by Ryosuke Niwa.

Use modern loops in more places in RenderLayer.app.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::update3DTransformedDescendantStatus):
(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::calculateClipRects):

10:45 PM Changeset in webkit [182107] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

nullptr cleanup in RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=143174

Reviewed by Ryosuke Niwa.

Replace 0 with nullptr in RenderLayer.cpp.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::filterRenderer):
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll):
(WebCore::RenderLayer::positionNewlyCreatedOverflowControls):
(WebCore::RenderLayer::enclosingOverflowClipLayer):
(WebCore::RenderLayer::enclosingCompositingLayer):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::enclosingFilterLayer):
(WebCore::RenderLayer::enclosingFilterRepaintLayer):
(WebCore::RenderLayer::clippingRootForPainting):
(WebCore::RenderLayer::transparentPaintingAncestor):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::removeOnlyThisLayer):
(WebCore::RenderLayer::insertOnlyThisLayer):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::enclosingScrollableArea):
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree):
(WebCore::RenderLayer::enclosingElement):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::clipRects):
(WebCore::RenderLayer::calculateClipRects):

10:04 PM Changeset in webkit [182106] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax
​https://bugs.webkit.org/show_bug.cgi?id=143169

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):
Add basic support for Esprima's ES6 Class/Method/Spread nodes.
There are more ES6 features that should be covered, but this
covers all the features we use in Web Inspector source, so
Type Profiling can work with our own source.

Treat Methods like getters / setters right now because their
syntax is very similiar to getters/setters. There is a bug
handling generic ES6 cleanup to better name things.

9:42 PM Changeset in webkit [182105] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught TDZ Exception with Type Profiler
​https://bugs.webkit.org/show_bug.cgi?id=143167

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TypePropertiesSection.js:

(WebInspector.TypePropertyTreeElement):
Avoid TDZ issue by not using "this" before "super".

  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):
Better handle unsupported node types by returning null and avoiding an exception.

  • UserInterface/Views/SourceCodeTextEditor.js:

Fix an issue I saw once where the sourceCode was a Script itself.

9:41 PM Changeset in webkit [182104] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception while debugging, after performSearch callback line does not exists
​https://bugs.webkit.org/show_bug.cgi?id=143172

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.customPerformSearch.searchResultCallback):
(WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
Gracefully handle if the line does not exist.

9:18 PM Changeset in webkit [182103] by gyuyoung.kim@samsung.com
  • 6 edits in trunk

.:
[CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
​https://bugs.webkit.org/show_bug.cgi?id=143138

Reviewed by Csaba Osztrogonác.

INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.

  • Source/cmake/OptionsWindows.cmake:

Set "PORT" instead of "PORT_FALLBACK" because there is no benefit to define PORT_FALLBACK.

  • Source/cmake/WebKitMacros.cmake:

Tools:
[CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
​https://bugs.webkit.org/show_bug.cgi?id=143138

Reviewed by Csaba Osztrogonác.

INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.

  • ImageDiff/CMakeLists.txt:

Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.

  • WebKitTestRunner/CMakeLists.txt: ditto.
9:02 PM Changeset in webkit [182102] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
​https://bugs.webkit.org/show_bug.cgi?id=143170

Reviewed by Benjamin Poulain.

Assert that we never use 16-bit version of the parser to parse a default constructor
since both base and derived default constructors should be using a 8-bit string.

  • parser/Parser.h:

(JSC::parse):

8:15 PM Changeset in webkit [182101] by yoon@igalia.com
  • 12 edits
    8 adds in trunk/Source

[TexMap] Seperate BitmapTexture related classes implementations from TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=142386

Reviewed by Žan Doberšek.

TextureMapper and TextureMapperGL are bloated and tightly coupled with
BitmapTexture. We should move these classes to seperated file of their own.
Also, this patch removes friend relationship from TextureMapperGL and its
subsidiary classes.

The main purpose of this refactoring is to expose BitmapTexturePool to
renderers of platformlayers like Video and Canvas. By doing this, each
renderer can acquire textures from the global texture pool to paint
their contents directly.

Source/WebCore:

No new tests needed.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Include BitmapTextureGL and BitmapTexturePool explicitly

  • platform/graphics/texmap/BitmapTexture.cpp: Added.
  • platform/graphics/texmap/BitmapTexture.h: Added.

(WebCore::BitmapTexture::updateContents):
Exclude BitmapTexture class from TextureMapper

  • platform/graphics/texmap/BitmapTextureGL.cpp: Added.
  • platform/graphics/texmap/BitmapTextureGL.h: Added.

Exclude BitmapTextureGL class from TextureMapperGL
(WebCore::BitmapTextureGL::clipStack): Added.
Add the getter for clipStack for TextureMapperGL
(WebCore::BitmapTextureGL::Bind): Deleted.
(WebCore::BitmapTextureGL::BindAsSurface): Added.
Bind used TextureMapperGL's internal data directly to compute projection matrix as a friend class,
However, TextureMapperGL can compute projection matrix itself after binding job, so this
friend ship is not needed. Also, this patch renames Bind to BindAsSurface to remove ambiguity.

  • platform/graphics/texmap/BitmapTextureImageBuffer.cpp: Added.
  • platform/graphics/texmap/BitmapTextureImageBuffer.h: Added.

Exclude BitmapTextureImageBuffer class from TextureMapperImageBuffer

  • platform/graphics/texmap/BitmapTexturePool.cpp: Added.
  • platform/graphics/texmap/BitmapTexturePool.h: Added.

Exclude BitmapTexturePool class from TextureMapperGL
(WebCore::BitmapTexturePool::acquireTexture):
Modified to use passed GraphicsContext3D instead of TextureMapperGL to remove redundant coupling

  • platform/graphics/texmap/TextureMapper.cpp:
  • platform/graphics/texmap/TextureMapper.h:

Remove BitmapTexturePool and BitmapTexture from its implementation.

  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/texmap/TextureMapperGL.h:

Remove BitmapTextureGL from its implementation.
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::clipStack):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::currentSurface):
Add a getter of the current surface for filtering operation in BitmapTextureGL.
It would be clear to move filtering operation from BitmapTextureGL to TextureMapperGL later.

(WebCore::TextureMapperGL::ClipStack):
Move inner class declaration to public.

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:
  • platform/graphics/texmap/TextureMapperImageBuffer.h:

Remove BitmapTextureImageBuffer from its implementation.

Source/WebKit2:

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Include BitmapTextureGL.h explicitly
8:09 PM Changeset in webkit [182100] by rniwa@webkit.org
  • 7 edits
    1 add in trunk/Source

ES6 Classes: Runtime error in JIT'd class calling super() with arguments and superclass has default constructor
​https://bugs.webkit.org/show_bug.cgi?id=142862

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Add a test that used to fail in DFG now that the bug has been fixed by r181993.

  • tests/stress/class-syntax-derived-default-constructor.js: Added.

Source/WebInspectorUI:

Removed the workaround for the bug since it has been fixed by r181993.

  • UserInterface/Base/Object.js:
  • UserInterface/Models/DebuggerDashboard.js:
  • UserInterface/Models/NetworkTimeline.js:
  • UserInterface/Models/ReplayDashboard.js:
  • UserInterface/Models/Revision.js:
7:56 PM Changeset in webkit [182099] by Joseph Pecoraro
  • 6 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Add Setter Icon for ObjectTreeView
​https://bugs.webkit.org/show_bug.cgi?id=143129

Reviewed by Timothy Hatcher.

  • UserInterface/Images/Pencil.svg: Added.

New icon used to indicate setter properties.

  • Localizations/en.lproj/localizedStrings.js:

Remove "Read only" and replace with "Setter".

  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:

(WebInspector.ObjectTreeArrayIndexTreeElement.prototype._titleFragment):
(WebInspector.ObjectTreeArrayIndexTreeElement):

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._createTitlePropertyStyle):
(WebInspector.ObjectTreePropertyTreeElement.prototype._createTitleAPIStyle):
Update cases that created setter / getter elements.

  • UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
(WebInspector.ObjectTreeBaseTreeElement.prototype.createInteractiveGetterElement): Deleted.

  • UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.object-tree-property :matches(.getter, .setter)):
(.object-tree-property .spacer):
(.object-tree-property .getter):
(.object-tree-property .setter):
(.object-tree-property .getter + .setter):
New setter element and styles. Setters are always non-interactable right now.

7:55 PM Changeset in webkit [182098] by msaboff@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

load8Signed() and load16Signed() should be renamed to avoid confusion
​https://bugs.webkit.org/show_bug.cgi?id=143168

Reviewed by Benjamin Poulain.

Renamed load8Signed() to load8SignedExtendTo32() and load16Signed() to load16SignedExtendTo32().

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8SignedExtendTo32):
(JSC::MacroAssemblerARM::load16SignedExtendTo32):
(JSC::MacroAssemblerARM::load8Signed): Deleted.
(JSC::MacroAssemblerARM::load16Signed): Deleted.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load16SignedExtendTo32):
(JSC::MacroAssemblerARM64::load8SignedExtendTo32):
(JSC::MacroAssemblerARM64::load16Signed): Deleted.
(JSC::MacroAssemblerARM64::load8Signed): Deleted.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16SignedExtendTo32):
(JSC::MacroAssemblerARMv7::load8SignedExtendTo32):
(JSC::MacroAssemblerARMv7::load16Signed): Deleted.
(JSC::MacroAssemblerARMv7::load8Signed): Deleted.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::load8SignedExtendTo32):
(JSC::MacroAssemblerMIPS::load16SignedExtendTo32):
(JSC::MacroAssemblerMIPS::load8Signed): Deleted.
(JSC::MacroAssemblerMIPS::load16Signed): Deleted.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8SignedExtendTo32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16SignedExtendTo32):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load8Signed): Deleted.
(JSC::MacroAssemblerSH4::load16Signed): Deleted.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load8SignedExtendTo32):
(JSC::MacroAssemblerX86Common::load16SignedExtendTo32):
(JSC::MacroAssemblerX86Common::load8Signed): Deleted.
(JSC::MacroAssemblerX86Common::load16Signed): Deleted.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitIntTypedArrayGetByVal):

6:57 PM Changeset in webkit [182097] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use a typedef for the WKPluginLoadClientPolicy enum
​https://bugs.webkit.org/show_bug.cgi?id=143161

Reviewed by Tim Horton.

  • UIProcess/API/C/WKPluginLoadPolicy.h:
5:59 PM Changeset in webkit [182096] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exceptions with Context Menus
​https://bugs.webkit.org/show_bug.cgi?id=143162

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.contextMenuCleared):

5:57 PM Changeset in webkit [182095] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable editing in Metrics section while it is not working
​https://bugs.webkit.org/show_bug.cgi?id=143165

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
Disable double click to edit while it is not working. The value setter
and add methods no longer exist.

5:56 PM Changeset in webkit [182094] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exceptions evaluating code while paused
​https://bugs.webkit.org/show_bug.cgi?id=143163

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame.prototype.collectScopeChainVariableNames):
We define a property named "valueForCaseInsensitiveKey" on Object.prototype
that is readonly. So we should avoid Object.prototype when building our
result list. This should probably move to a Map object eventually.

5:54 PM Changeset in webkit [182093] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused testing properties
​https://bugs.webkit.org/show_bug.cgi?id=143156

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LegacyConsoleMessageImpl.js:

(WebInspector.LegacyConsoleMessageImpl.prototype._formatMessage):

  • UserInterface/Views/Section.js:

(WebInspector.Section.prototype.get subtitleAsTextForTest): Deleted.

5:51 PM Changeset in webkit [182092] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: Attempted to assign to readonly - DOMNodeDetailsSidebarPanel.js
​https://bugs.webkit.org/show_bug.cgi?id=143139

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

DataGridNodes do not have a selectable setter. TreeElements do.
DataGridNodes are always selectable. Match current behavior by
removing all instances of attempting to set the selectability
which would, under strict mode, result in an error.

  • UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView.prototype._populateDataGrid):

  • UserInterface/Views/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype._rebuildTable):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid):
(WebInspector.DOMNodeDetailsSidebarPanel):

  • UserInterface/Views/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.reset):

  • UserInterface/Views/DataGrid.js:
5:40 PM Changeset in webkit [182091] by msaboff@apple.com
  • 5 edits in trunk

Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
​https://bugs.webkit.org/show_bug.cgi?id=138390

Reviewed by Mark Lam.

Source/JavaScriptCore:

Changed load8Signed() and load16Signed() to only sign extend the loaded value to 32 bits
instead of 64 bits. This is what X86-64 does.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load16Signed):
(JSC::MacroAssemblerARM64::load8Signed):

LayoutTests:

Reenabled the tests for ARM64/iOS. Left the tests disabled for ARM64/linux and will let linux
developers test and reenable under existing but ​https://bugs.webkit.org/show_bug.cgi?id=142629.

  • js/script-tests/dfg-int16array.js:
  • js/script-tests/dfg-int8array.js:
4:49 PM Changeset in webkit [182090] by Chris Dumez
  • 3 edits
    1 move in trunk/Source/WebKit2

[WK2][NetworkCache] Use WTF::WorkQueue abstraction inside NetworkCacheStatistics
​https://bugs.webkit.org/show_bug.cgi?id=143154

Reviewed by Antti Koivisto.

Use WTF::WorkQueue abstraction inside NetworkCacheStatistics, like we
already do in NetworkCacheStorage.

  • NetworkProcess/cache/NetworkCacheStatistics.cpp: Renamed from Source/WebKit2/NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm.

(WebKit::NetworkCache::executeSQLCommand):
(WebKit::NetworkCache::executeSQLStatement):
(WebKit::NetworkCache::Statistics::open):
(WebKit::NetworkCache::Statistics::Statistics):
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::bootstrapFromNetworkCache):
(WebKit::NetworkCache::Statistics::shrinkIfNeeded):
(WebKit::NetworkCache::Statistics::recordRetrievalRequest):
(WebKit::NetworkCache::Statistics::recordNotCachingResponse):
(WebKit::NetworkCache::retrieveDecisionToDiagnosticKey):
(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::storeDecisionToDiagnosticKey):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):
(WebKit::NetworkCache::cachedEntryReuseFailureToDiagnosticKey):
(WebKit::NetworkCache::Statistics::recordRetrievedCachedEntry):
(WebKit::NetworkCache::Statistics::markAsRequested):
(WebKit::NetworkCache::Statistics::writeTimerFired):
(WebKit::NetworkCache::Statistics::queryWasEverRequested):
(WebKit::NetworkCache::Statistics::clear):
(WebKit::NetworkCache::Statistics::addHashesToDatabase):
(WebKit::NetworkCache::Statistics::addStoreDecisionsToDatabase):

  • NetworkProcess/cache/NetworkCacheStatistics.h:

(WebKit::NetworkCache::Statistics::serialBackgroundIOQueue):

  • WebKit2.xcodeproj/project.pbxproj:
4:08 PM Changeset in webkit [182089] by mmaxfield@apple.com
  • 6 edits in trunk

Support building WTF on Windows without Cygwin
​https://bugs.webkit.org/show_bug.cgi?id=143084

Reviewed by Brent Fulgham.

Tools:
Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
This patch also migrates to using File::Spec->catfile() for directory separators.

  • Scripts/update-webkit-dependency:

(wanted):

  • Scripts/update-webkit-support-libs:

(wanted):
(downloadExpectedVersionNumber):
(zipFileVersion):
(toUnixPath): Deleted.

  • Scripts/webkitdirs.pm:

(determineSourceDir):
(windowsSourceSourceDir):
(windowsLibrariesDir):
(windowsOutputDir):
(checkInstalledTools):
(buildVisualStudioProject):

Source/WTF:
Windows doesn't have "touch".

  • WTF.vcxproj/WTFGenerated.make:
4:01 PM Changeset in webkit [182088] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

WebProcess started by editable WKWebView spends 15% of its initialization time loading DataDetectors
​https://bugs.webkit.org/show_bug.cgi?id=143142
<rdar://problem/20324495>

Reviewed by Anders Carlsson.

Calling DataDetectorsLibrary() is expensive; we should avoid doing it
until actually necessary. When loading a page that makes a caret selection,
ServicesOverlayController was calling DataDetectorsLibrary() (ignoring the fact
that a caret selection can't have any services associated with it) to avoid
crashing on systems where DataDetectors is not available. Instead, we should
first check if there's anything to do, and then check for the existence
of DataDetectors.

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
Build the list of phone number ranges, and bail (clearing the potential highlights)
if it is empty, before calling DataDetectorsLibrary().

(WebCore::ServicesOverlayController::buildSelectionHighlight):
Check the list of selection rects, and bail (clearing the potential highlights)
if it is empty, before calling DataDetectorsLibrary().

3:56 PM Changeset in webkit [182087] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebKit2

Safari clears selection when its window gets activated via mouse down
​https://bugs.webkit.org/show_bug.cgi?id=143157

Reviewed by Anders Carlsson.

The bug was caused by PlatformMouseEvent created in WebKit2 not having its event number
even though we were correctly calling setActivationEventNumber in WebPage::acceptsFirstMouse.

Fixed the bug by storing [NSEvent eventNumber] in WebMouseEvent on Mac in WebKit2 as done in WebKit1.

  • Shared/WebEvent.h:

(WebKit::WebMouseEvent::eventNumber):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):

3:39 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
3:07 PM Changeset in webkit [182086] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Only do the Connection::setShouldCloseConnectionOnMachExceptions() hack where necessary
​https://bugs.webkit.org/show_bug.cgi?id=143141
rdar://problem/19471284

Reviewed by Andreas Kling.

  • Platform/IPC/Connection.h:
  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::platformInvalidate):
(IPC::Connection::platformInitialize):
(IPC::Connection::open):

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

3:04 PM Changeset in webkit [182085] by timothy_horton@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

Implement iOS WebKit2 PDF Find-in-Page
​https://bugs.webkit.org/show_bug.cgi?id=143065
<rdar://problem/16793370>

Reviewed by Dan Bernstein.

  • Platform/spi/ios/CorePDFSPI.h:

Add some SPI.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _countStringMatches:options:maxCount:]):
(-[WKWebView _findString:options:maxCount:]):
(-[WKWebView _hideFindUI]):
If we have a custom content view, forward find-in-page methods to it.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/_WKFindOptions.h:

Move _WKFindOptions into its own file.

  • UIProcess/Cocoa/WKWebViewContentProvider.h:

Add find-related methods to the WKWebViewContentProvider protocol.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_initWithFrame:webView:]):
(-[WKPDFView dealloc]):
Maintain a dispatch queue for searching the PDF.

(-[WKPDFView web_setContentProviderData:suggestedFilename:]):
Fix a type.

(-[WKPDFView _ensureViewForPage:]):
Split the code to create/parent a page view out from _revalidateViews,
so that the find code can create/parent the targetted UIPDFPageView
in order to install the find highlight in it, but before it is scrolled into view.

(-[WKPDFView _revalidateViews]):
Use the stored page index instead of counting again.
Don't unparent page views that have find-in-page highlights in them, because
we won't know enough to recreate them later.

(-[WKPDFView _computePageAndDocumentFrames]):
Put the page index in PDFPageInfo, for reference elsewhere.

(-[WKPDFView _stringCompareOptionsFromWKFindOptions:]):
(-[WKPDFView _computeMatchesForString:options:maxCount:completionHandler:]):
Asynchronously (and on our serial queue) search the PDF for the given string.
We'll cache the most recent results to avoid searching more than once,
cancel existing searches when another begins (since it's a serial queue,
this ensures we'll only have one search active at a time).

(-[WKPDFView web_countStringMatches:options:maxCount:]):
Count the number of matches for the given string, and inform the FindClient
of the result.

(-[WKPDFView _didFindMatch:]):
When we find a match, create a view for it, highlight the match, and
zoom so that it's in-view.

(-[WKPDFView web_findString:options:maxCount:]):
Incrementally search the document for the given string. We do an incremental
search even if we have all of the results so that we can anchor the search
in the right place if the new string is a prefix of the old string, etc.
Wrap around appropriately when searching past the beginning or end of the
document. If we have all of the results (there were less than maxCount results),
look through the cached matches for the incrementally-found result and
report its index to the client.

(-[WKPDFView web_hideFindUI]):
Dismiss the selection and clear some state so we start the next search afresh.

  • WebKit2.xcodeproj/project.pbxproj:
3:01 PM Changeset in webkit [182084] by akling@apple.com
  • 5 edits in trunk/Source/WebKit2

WebProcessProxy should not retain WebBackForwardListItems forever.
<​https://webkit.org/b/143152>
<rdar://problem/19925709>

Reviewed by Anders Carlsson.

Have WebProcessProxy actually forget about a WebBackForwardListItem after it's removed from
the WebBackForwardList.

This ensures that we don't accumulate too many of these objects, which can get quite large
due to the session state encoded in them.

We already have graceful handling of the case where an incoming IPC message references
a removed back/forward list item.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::backForwardRemovedItem):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::removeBackForwardItem):

  • UIProcess/WebProcessProxy.h:
2:56 PM Changeset in webkit [182083] by saambarati1@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Add back previously broken assert from bug 141869
​https://bugs.webkit.org/show_bug.cgi?id=143005

Reviewed by Michael Saboff.

  • runtime/ExceptionHelpers.cpp:

(JSC::invalidParameterInSourceAppender):

2:56 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
2:49 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
2:38 PM Changeset in webkit [182082] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Use the correct timebase to log scrollperf blank pixel counts on iOS
​https://bugs.webkit.org/show_bug.cgi?id=143149

Reviewed by Tim Horton.

MobileSafari and WebKit need to collect scrollperf data using the same timebase;
MobileSafari can't call WTF::monotonicallyIncreasingTime(), so use CFAbsoluteTimeGetCurrent()
everywhere.

  • UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm:

(WebKit::RemoteLayerTreeScrollingPerformanceData::appendBlankPixelCount):

2:32 PM Changeset in webkit [182081] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

[Mac] Safari fails to fire page "load" event with video[preload=none]
​https://bugs.webkit.org/show_bug.cgi?id=143147

Reviewed by Simon Fraser.

Source/WebCore:

Test: media/video-page-load-preload-none.html

When told to load() when preload == None, set the networkState to Idle.
This causes HTMLMediaElement to set the shouldDelayLoadEvent flag to
false, and allows the page's 'load' event to fire.

Drive-by fix: add setNetworkState() and setReadyState() methods to
MediaPlayerPrivateAVFoundation, reducing a bunch of code duplication.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):
(WebCore::MediaPlayerPrivateAVFoundation::setNetworkState):
(WebCore::MediaPlayerPrivateAVFoundation::setReadyState):
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

LayoutTests:

  • media/video-page-load-preload-none-expected.txt: Added.
  • media/video-page-load-preload-none.html: Added.
2:10 PM Changeset in webkit [182080] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.23.4/Source/WebKit2

Merged r182045. rdar://problem/20233711

2:08 PM Changeset in webkit [182079] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.23.4/Source/WebKit2

Merged r182044. rdar://problem/20233711

2:07 PM Changeset in webkit [182078] by bshafiei@apple.com
  • 4 edits in tags/Safari-601.1.23.4/Source/WebKit2

Merged r182037. rdar://problem/20233711

2:02 PM Changeset in webkit [182077] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Calling crypto.webkitSubtle.generateKey causes page memory to never be released
​https://bugs.webkit.org/show_bug.cgi?id=143151
rdar://problem/18940687

Reviewed by Tim Horton.

  • crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::generatePair): Don't.
1:41 PM Changeset in webkit [182076] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Null dereference in InbandMetadataTextTrack handling
​https://bugs.webkit.org/show_bug.cgi?id=143144
<rdar://problem/18983250>

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:

(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes): Check for null return value from
'client()', just like we do in all other methods.

1:39 PM Changeset in webkit [182075] by Brent Fulgham
  • 2 edits
    2 deletes in trunk/LayoutTests

Correct test results after r182012.

The test now produces identical results on all platforms, so update the root test result,
and remove custom non-matching expectations. This corrects Windows, GTK, and EFL builds, and
should not harm the Mac build.

  • accessibility/aria-toggle-button-with-title-expected.txt:
  • platform/mac/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
  • platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
1:17 PM Changeset in webkit [182074] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Rename requestNeedsRevalidation() to requestRequiresRevalidation()
​https://bugs.webkit.org/show_bug.cgi?id=143137

Reviewed by Antti Koivisto.

Rename requestNeedsRevalidation() to requestRequiresRevalidation() as I
think it is more accurate. It is not the request that needs revalidating.
The requests just requires us to revalidate the response.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::requestRequiresRevalidation):
(WebKit::NetworkCache::canUse):
(WebKit::NetworkCache::requestNeedsRevalidation): Deleted.

12:44 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
12:34 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
12:04 PM Changeset in webkit [182073] by oliver@apple.com
  • 13 edits in trunk/Source

Forward additional CFNetwork ATS information to child processes
​https://bugs.webkit.org/show_bug.cgi?id=143136

Reviewed by Anders Carlsson.

Source/WebCore:

Declare SPI.

  • platform/spi/cf/CFNetworkSPI.h:

Source/WebKit2:

Add additional process creation parameter information, and pass it
to the child processes that actually use CFNetwork.

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

12:04 PM Changeset in webkit [182072] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Gardening: skipping inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html until crash is fixed.
<​https://webkit.org/b/143105>

Not reviewed.

11:24 AM Changeset in webkit [182071] by Chris Dumez
  • 9 edits
    2 adds in trunk

[WK2][NetworkCache] We only cache responses with status codes that are cacheable by default
​https://bugs.webkit.org/show_bug.cgi?id=143125
<rdar://problem/20321172>

Reviewed by Antti Koivisto.

Source/WebCore:

Export a couple of extra symbols.

  • platform/network/ResourceResponseBase.h:

Source/WebKit2:

We Previously only cached responses with status codes that are cacheable
by default [1]. However, RFC 7234 [2] allows us to cache responses with
other status codes, as long as they have explicit headers allowing
caching:

  • 'Expires' header field
  • 'max-age' response directive

This patch updates our caching policy accordingly to improve efficiency.

[1] ​http://tools.ietf.org/html/rfc7231#page-48
[2] ​http://tools.ietf.org/html/rfc7234#section-4.3.2

Test: http/tests/cache/disk-cache/disk-cache-307-status-code.html

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::canStore):

LayoutTests:

Add layout test to check that responses with status code 307 (which is not
cacheable by default) are cached if they have explicit expiration headers.

Also update a couple of other disk cache tests to cover heuristic
freshness (​http://tools.ietf.org/html/rfc7234#section-4.2.2), relying on
'Last-Modified' header to estimate freshness if usual expiration headers
are not available.

  • http/tests/cache/disk-cache/disk-cache-204-status-code-expected.txt:
  • http/tests/cache/disk-cache/disk-cache-204-status-code.html:
  • http/tests/cache/disk-cache/disk-cache-307-status-code-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-307-status-code.html: Added.
  • http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt:
  • http/tests/cache/disk-cache/disk-cache-404-status-code.html:
11:00 AM Changeset in webkit [182070] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • js/script-tests/array-length-shortening.js: Unskip, r182058 fixed it.
10:30 AM Changeset in webkit [182069] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement will fire 'seeked' before seek completes, leading to currentTime discontinuities.
​https://bugs.webkit.org/show_bug.cgi?id=143132

Reviewed by Eric Carlson.

When seeking, if the ready state rises to >= HAVE_CURRENT_DATA, we will fire the 'seeked'
event and continue playback. However, if a media engine updates the ready state before its
seek operation actually completes, the currentTime it returns may still be the time before
the seek.

Wait until both the ready state rises to HAVE_CURRENT_DATA and m_player->seeking() returns
false before firing the 'seeked' event.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

10:27 AM Changeset in webkit [182068] by ggaren@apple.com
  • 28 edits in trunk/Source

Make some more objects use FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=143122

Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

  • API/JSCallbackObject.h:
  • heap/IncrementalSweeper.h:
  • jit/JITThunks.h:
  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/RegExpCache.h:

Source/WebCore:

  • Modules/geolocation/GeolocationController.h:
  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/indexeddb/DOMWindowIndexedDatabase.h:
  • Modules/notifications/NotificationController.h:
  • Modules/webdatabase/DatabaseServer.h:
  • css/CSSFontFaceSource.h:
  • html/HTMLMediaSession.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorReplayAgent.h:
  • page/CaptionUserPreferencesMediaAF.h:
  • page/PageConsoleClient.h:
  • page/PageDebuggable.h:
  • page/animation/CSSPropertyAnimation.cpp:
  • page/mac/ServicesOverlayController.h:
  • platform/RemoteCommandListener.h:
  • platform/Timer.h:
  • platform/audio/MediaSessionManager.h:
  • platform/mac/SystemSleepListenerMac.h:
  • platform/mac/ThemeMac.h:
  • rendering/svg/RenderSVGResourceSolidColor.h:
  • replay/ReplayController.h:
10:02 AM Changeset in webkit [182067] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

FEMorphology::platformApplyGeneric() should bail out if the radius is less than or equal to zero.
​https://bugs.webkit.org/show_bug.cgi?id=142885.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-03-27
Reviewed by Dean Jackson.

Source/WebCore:

FEMorphology class implementation code clean up.

Tests: svg/filters/feMorphology-radius-cases.svg

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::shouldSupersedeExtremum): Reuse code instead of repeating it and
use < and > instead of =< and >=.

(WebCore::pixelArrayIndex): Returns the array index of a pixel in an image
buffer, given: position(x, y), image width and the color channel.

(WebCore::columnExtremum): Returns the extremum of a column of pixels.

(WebCore::kernelExtremum): Returns the extremum of a filter kernel.

(WebCore::FEMorphology::platformApplyGeneric): Apply some code clean-up.
The kernel size should be equal to radius of the filter. The extra pixel
was causing the resulted image to be asymmetric in some cases.

(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware): After applying scaling, we
still need to check the resulted radius is negative (overflow case) or less
than one (zero radius case) and treat these cases differently.

(WebCore::FEMorphology::morphologyOperator): Deleted.
(WebCore::FEMorphology::radiusX): Deleted.
(WebCore::FEMorphology::radiusY): Deleted.

  • platform/graphics/filters/FEMorphology.h:

(WebCore::FEMorphology::morphologyOperator):
(WebCore::FEMorphology::radiusX):
(WebCore::FEMorphology::radiusY):
Move a single line functions from the source file to the header file.

LayoutTests:

  • svg/filters/feMorphology-radius-cases-expected.svg: Added.
  • svg/filters/feMorphology-radius-cases.svg: Added.

Test different cases for radius of the feMorphology filter. There are three
cases for the radius:

  1. radius < 0: This is an error case, the source image should not be rendered.
  2. radius = 0: This case is treated as if the filter never exists.
  3. radius > 0: If the scaled radius is > 0, the filter is applied.
10:00 AM Changeset in webkit [182066] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.23.4/Source/WebCore

Merged r182052. rdar://problem/20263463

9:59 AM Changeset in webkit [182065] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix WinCairo bot.
​https://bugs.webkit.org/show_bug.cgi?id=143086

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-03-27
Reviewed by Brent Fulgham.

  • Scripts/webkitdirs.pm:

(buildVisualStudioProject):
(runSvnUpdateAndResolveChangeLogs):
Use ActivePerl-friendly perl.

9:49 AM Changeset in webkit [182064] by Antti Koivisto
  • 4 edits
    2 moves in trunk/Source/WebCore

Move CacheValidation to platform
​https://bugs.webkit.org/show_bug.cgi?id=143133

Reviewed by Chris Dumez.

It deals with platform types only and is currently violating layering.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CacheValidation.cpp: Removed.
  • loader/cache/CacheValidation.h: Removed.
  • platform/network/CacheValidation.cpp: Copied from Source/WebCore/loader/cache/CacheValidation.cpp.
  • platform/network/CacheValidation.h: Copied from Source/WebCore/loader/cache/CacheValidation.h.
9:42 AM Changeset in webkit [182063] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

URTBF after r182059 to fix the EFL build.

  • TestWebKitAPI/CMakeLists.txt:
9:15 AM Changeset in webkit [182062] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r177896.
​https://bugs.webkit.org/show_bug.cgi?id=142978

Loading libgstclutter.so in-process hangs web process
(Requested by mcatanzaro on #webkit).

Reverted changeset:

"[GStreamer] Disable gst-plugin-scanner if seccomp filters are
enabled"
​https://bugs.webkit.org/show_bug.cgi?id=140069
​http://trac.webkit.org/changeset/177896

8:29 AM Changeset in webkit [182061] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.23.4/Source

Versioning.

8:26 AM Changeset in webkit [182060] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.23.4

New tag.

8:13 AM Changeset in webkit [182059] by Antti Koivisto
  • 11 edits
    2 adds in trunk

Respect cache-control directives in request
​https://bugs.webkit.org/show_bug.cgi?id=143121
Source/WebCore:

rdar://problem/19714040

Reviewed by Chris Dumez.

Test: http/tests/cache/disk-cache/disk-cache-request-headers.html

  • loader/cache/CacheValidation.cpp:

(WebCore::isCacheHeaderSeparator):
(WebCore::isControlCharacter):
(WebCore::trimToNextSeparator):
(WebCore::parseCacheHeader):
(WebCore::parseCacheControlDirectives):

Factor Cache-control parsing here so it can be used for both requests and responses.

  • loader/cache/CacheValidation.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::cacheControlContainsNoCache):
(WebCore::ResourceResponseBase::cacheControlContainsNoStore):
(WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate):
(WebCore::ResourceResponseBase::cacheControlMaxAge):
(WebCore::isCacheHeaderSeparator): Deleted.
(WebCore::isControlCharacter): Deleted.
(WebCore::trimToNextSeparator): Deleted.
(WebCore::parseCacheHeader): Deleted.

  • platform/network/ResourceResponseBase.h:

Source/WebKit2:

rdar://problem/19714040

Reviewed by Chris Dumez.

Better support for ​https://tools.ietf.org/html/rfc7234#section-5.2.1

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::canUse):

Consider requests with Cache-control: no-cache and max-age=0 expired.

(WebKit::NetworkCache::canStore):

Don't store requests with Cache-control: no-store.

(WebKit::NetworkCache::Cache::store):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm:

(WebKit::NetworkCache::storeDecisionToDiagnosticKey):

LayoutTests:

Reviewed by Chris Dumez.

  • http/tests/cache/disk-cache/disk-cache-request-headers-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-request-headers.html: Added.
7:28 AM Changeset in webkit [182058] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

Objects with numeric properties intermittently get a phantom 'length' property
​https://bugs.webkit.org/show_bug.cgi?id=142792

Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

Fixed a > (greater than) that should be a >> (right shift) in the code that disassembles
test and branch instructions. This function is used for linking tbz/tbnz branches between
two seperately JIT'ed sections of code. Sometime we'd create a bogus tbz instruction in
the failure case checks in the GetById array length stub created for "obj.length" access.
If the failure case code address was at a negative offset from the stub, we'd look for bit 1
being set when we should have been looking for bit 0.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::disassembleTestAndBranchImmediate):

LayoutTests:

New regression test.

  • js/regress-142792-expected.txt: Added.
  • js/regress-142792.html: Added.
  • js/script-tests/regress-142792.js: Added.

(isArrayLike):
(filter):

4:08 AM Changeset in webkit [182057] by Yusuke Suzuki
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

Insert exception check around toPropertyKey call
​https://bugs.webkit.org/show_bug.cgi?id=142922

Reviewed by Geoffrey Garen.

In some places, exception check is missing after/before toPropertyKey.
However, since it calls toString, it's observable to users,

Missing exception checks in Object.prototype methods can be
observed since it would be overridden with toObject(null/undefined) errors.
We inserted exception checks after toPropertyKey.

Missing exception checks in GetById related code can be
observed since it would be overridden with toObject(null/undefined) errors.
In this case, we need to insert exception checks before/after toPropertyKey
since RequireObjectCoercible followed by toPropertyKey can cause exceptions.

JSValue::get checks null/undefined and raise an exception if |this| is null or undefined.
However, we need to check whether the baseValue is object coercible before executing JSValue::toPropertyKey.
According to the spec, we first perform RequireObjectCoercible and check the exception.
And second, we perform ToPropertyKey and check the exception.
Since JSValue::toPropertyKey can cause toString call, this is observable to users.
For example, if the target is not object coercible,
ToPropertyKey should not be executed, and toString should not be executed by ToPropertyKey.
So the order of observable actions (RequireObjectCoercible and ToPropertyKey) should be correct to the spec.

This patch introduces JSValue::requireObjectCoercible and use it because of the following 2 reasons.

  1. Using toObject instead of requireObjectCoercible produces unnecessary wrapper object.

toObject converts primitive types into wrapper objects.
But it is not efficient since wrapper objects are not necessary
if we look up methods from primitive values's prototype. (using synthesizePrototype is better).

  1. Using the result of toObject is not correct to the spec.

To align to the spec correctly, we cannot use JSObject::get
by using the wrapper object produced by the toObject suggested in (1).
If we use JSObject that is converted by toObject, getter will be called by using this JSObject as |this|.
It is not correct since getter should be called with the original |this| value that may be primitive types.

So in this patch, we use JSValue::requireObjectCoercible
to check the target is object coercible and raise an error if it's not.

  • dfg/DFGOperations.cpp:
  • jit/JITOperations.cpp:

(JSC::getByVal):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::requireObjectCoercible):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):

  • tests/stress/exception-in-to-property-key-should-be-handled-early-in-object-methods.js: Added.

(shouldThrow):
(if):

  • tests/stress/exception-in-to-property-key-should-be-handled-early.js: Added.

(shouldThrow):
(.):

3:31 AM Changeset in webkit [182056] by vjaquez@igalia.com
  • 5 edits in trunk

[GStreamer] share GL context in pipeline, part 2
​https://bugs.webkit.org/show_bug.cgi?id=143049

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/OptionsGTK.cmake: USE_GSTREAMER_GL is set only if

OpenGL/ES2 is found and GLX/EGL is found too.

Source/WebCore:

This patch, instead of cluttering the GstGL attributes creation in
::handleSyncMessage(), creates a new method ::ensureGstGLContext(),
where those attributes are defined. This method is guarded by
USE(GSTREAMER_GL)

::handlSyncMessage() shall return nothing, according to GStreamer
documentation, not a boolean.

The GstGL attributes are now GRefPtr<> to avoid memory leaks.

The GstGLAPI and GstGLPlatform are now set given by the pre-processor
directives, and the code in ::ensureGstGLContext() is simpler.

No new tests because this is platform specific and it depends in the
run-time availability and configurations of GstGL elements.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Don't initialise the GstGL attributes since are GRefPtr<>
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage): Changed the
signature to use void instead of gboolean.
(WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): New method.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:26 AM Changeset in webkit [182055] by timothy@apple.com
  • 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert more misc View classes to ES6
​https://bugs.webkit.org/show_bug.cgi?id=143128

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CompletionSuggestionsView.js:
  • UserInterface/Views/ComputedStyleDetailsPanel.js:
  • UserInterface/Views/DashboardContainerView.js:
  • UserInterface/Views/DashboardView.js:
  • UserInterface/Views/DebuggerDashboardView.js:
  • UserInterface/Views/DefaultDashboardView.js:
  • UserInterface/Views/FilterBarButton.js:
  • UserInterface/Views/MetricsStyleDetailsPanel.js:
  • UserInterface/Views/ObjectPreviewView.js:
  • UserInterface/Views/ObjectTreeView.js:
  • UserInterface/Views/QuickConsole.js:
  • UserInterface/Views/ReplayDashboardView.js:
  • UserInterface/Views/RulesStyleDetailsPanel.js:
  • UserInterface/Views/StyleDetailsPanel.js:

Converted to ES6 classes.

12:26 AM Changeset in webkit [182054] by timothy@apple.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert TextEditor classes to ES6
​https://bugs.webkit.org/show_bug.cgi?id=143127

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

Removed a comment about const, we can't use it in strict mode / classes.

  • UserInterface/Views/SourceCodeTextEditor.js:
  • UserInterface/Views/TextEditor.js:

Converted to ES6 classes.

Mar 26, 2015:

11:48 PM Changeset in webkit [182053] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: clicking on console record while REPL is focused does not select a new record
​https://bugs.webkit.org/show_bug.cgi?id=142171

Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._mousedown):

11:36 PM Changeset in webkit [182052] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimized Fullscreen fails to cleanup because of no longer necessary release of m_playerController in exitFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=143120

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-03-26
Reviewed by Eric Carlson.

We used to release m_playerController in WebVideoFullscreenInterfaceAVKit::exitFullscreen() in order to make sure
media state was reset. This is no longer necessary as we now have a way the model can explicitly request resetting the
media state via resetMediaState(). m_playerController is already released in
WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releasing it prematurely can actually prevent the exit
fullscreen process from completing successfully.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::exitFullscreen):

9:41 PM Changeset in webkit [182051] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Inline continuation code should not take anonymous containing wrapper granted.
​https://bugs.webkit.org/show_bug.cgi?id=133312

Reviewed by Dave Hyatt.

It's wrong to assume that when RenderInline is part of an inline continuation, its containing block
is an anonymous wrapper and its sibling might be a block level renderer.
When the inline continuation is no longer needed, for example when the block level renderer that initiated the continuation
is detached from the render tree, the inline renderes still continue to form continuation.(however they no longer require
anonymous wrappers)

Source/WebCore:

Test: fast/inline/crash-when-position-property-is-changed-and-no-longer-in-continuation.html

  • rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):

LayoutTests:

  • fast/inline/crash-when-position-property-is-changed-and-no-longer-in-continuation-expected.txt: Added.
  • fast/inline/crash-when-position-property-is-changed-and-no-longer-in-continuation.html: Added.
7:55 PM Changeset in webkit [182050] by Joseph Pecoraro
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

WebContent Crash when instantiating class with Type Profiling enabled
​https://bugs.webkit.org/show_bug.cgi?id=143037

Reviewed by Ryosuke Niwa.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitMoveEmptyValue):
We cannot profile the type of an uninitialized empty JSValue.
Nor do we expect this to be necessary, since it is effectively
an unseen undefined value. So add a way to put the empty value
without profiling.

(JSC::BytecodeGenerator::emitMove):
Add an assert to try to catch this issue early on, and force
callers to explicitly use emitMoveEmptyValue instead.

  • tests/typeProfiler/classes.js: Added.

(wrapper.Base):
(wrapper.Derived):
(wrapper):
Add test coverage both for this case and classes in general.

7:24 PM Changeset in webkit [182049] by jhoneycutt@apple.com
  • 3 edits in trunk/Source/WebKit2

iOS file upload panel menu items need icons
<​https://bugs.webkit.org/show_bug.cgi?id=143042>
<rdar://problem/20178678>

Reviewed by Andy Estes.

  • Platform/spi/ios/UIKitSPI.h:

Declare new SPI methods _UIImageGetWebKitTakePhotoOrVideoIcon and
_UIImageGetWebKitPhotoLibraryIcon().

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(photoLibraryIcon):
(cameraIcon):
If UIKit SPI exists, use it. Otherwise, return nil.

(-[WKFileUploadPanel _showDocumentPickerMenu]):
Use icons.

6:53 PM Changeset in webkit [182048] by Andres Gomez
  • 2 edits
    14 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: New Images for Console Types
​https://bugs.webkit.org/show_bug.cgi?id=142301

Reviewed by Joseph Pecoraro.

Add more free icons and for the Web Inspector in GTK+.

  • UserInterface/Images/gtk/Eye.svg: Added.
  • UserInterface/Images/gtk/Frames.png: Added.
  • UserInterface/Images/gtk/​Frames@2x.png: Added.
  • UserInterface/Images/gtk/FramesLarge.png: Added.
  • UserInterface/Images/gtk/​FramesLarge@2x.png: Added.
  • UserInterface/Images/gtk/Reload.svg:
  • UserInterface/Images/gtk/ReloadFull.svg: Added.
  • UserInterface/Images/gtk/TypeBoolean.svg: Added.
  • UserInterface/Images/gtk/TypeNull.svg: Added.
  • UserInterface/Images/gtk/TypeNumber.svg: Added.
  • UserInterface/Images/gtk/TypeObject.svg: Added.
  • UserInterface/Images/gtk/TypeRegex.svg: Added.
  • UserInterface/Images/gtk/TypeString.svg: Added.
  • UserInterface/Images/gtk/TypeSymbol.svg: Added.
  • UserInterface/Images/gtk/TypeUndefined.svg: Added.
6:42 PM Changeset in webkit [182047] by Joseph Pecoraro
  • 22 edits in trunk

Web Inspector: ES6: Provide a better view for Classes in the console
​https://bugs.webkit.org/show_bug.cgi?id=142999

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/Runtime.json:

Provide a new subtype enum "class". This is a subtype of type
"function", all other subtypes are subtypes of object types.
For a class, the frontend will immediately want to get the prototype
to enumerate its methods, so include the classPrototype.

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
Denote class construction functions as "class" subtypes.

  • inspector/InjectedScriptSource.js:

Handling for the new "class" type.

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::isClassConstructorFunction):

  • runtime/Executable.h:

(JSC::FunctionExecutable::isClassConstructorFunction):

  • runtime/JSFunction.h:
  • runtime/JSFunctionInlines.h:

(JSC::JSFunction::isClassConstructorFunction):
Check if this function is a class constructor function. That information
is on the UnlinkedFunctionExecutable, so plumb it through to JSFunction.

Source/WebInspectorUI:

  • UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get classPrototype):
(WebInspector.RemoteObject.prototype.isClass):
Update our RemoteObject model object for the new subtype
and its unique properties.

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForTypesAndValue):
(WebInspector.FormattedValue.createObjectTreeOrFormattedValueForRemoteObject):
Better handle "class", as it is a new function subtype.

  • UserInterface/Views/LegacyConsoleMessageImpl.js:

(WebInspector.LegacyConsoleMessageImpl):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsObject):
Format a "class" with ObjectTreeView.

  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:
  • UserInterface/Views/ObjectTreeBaseTreeElement.js:
  • UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.object-tree-property .getter.disabled):
(.object-tree-property .getter:not(.disabled):hover):
(.object-tree-property .getter:hover): Deleted.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

In ClassAPI mode, you cannot invoke a getter since we don't have
an instance to invoke it on. So disable interactivity with getters.

  • UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView):
Update the modes to include an API mode for instances and classes.

(WebInspector.ObjectTreeView.defaultModeForObject):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
Simplify ObjectTree construction to automatically determine mode based
on the RemoteObject that was provided.

  • Localizations/en.lproj/localizedStrings.js:

"Getter" tooltip.

LayoutTests:

  • inspector/model/remote-object-expected.txt:
  • inspector/model/remote-object.html:

Update the test to include coverage of the new "class" subtype of "function".

6:02 PM Changeset in webkit [182046] by timothy_horton@apple.com
  • 11 edits in trunk

REGRESSION (r181358 and r181507): Lots of sites think that we support touch events on OS X
​https://bugs.webkit.org/show_bug.cgi?id=142888
<rdar://problem/20227304>

Reviewed by Beth Dakin.

  • dom/Document.idl:
  • dom/Element.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.idl:

Re-conditionalize a lot of event listeners; sites test ("ontouchstart" in window), which
is not covered by NotEnumerable, and so r181358 and r181507 broke a bunch of sites
(apple.com, blaze.com, anything using nicescroll.js, etc.) by causing them to think
that (Mac) Safari was touch-enabled.

  • fast/dom/event-handler-attributes-expected.txt:
  • fast/dom/event-handler-attributes.html:
  • fast/events/event-attribute-expected.txt:
  • platform/win/fast/events/event-attribute-expected.txt:

Revert some changes to these tests and their results.

5:13 PM Changeset in webkit [182045] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

OS X build fix after r182037.

Unreviewed.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _addFontPanelObserver]):
(-[WKView removeWindowObservers]):
(-[WKView observeValueForKeyPath:ofObject:change:context:]):

5:08 PM Changeset in webkit [182044] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix after r182037.

Unreviewed.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setEditable:]):

4:41 PM Changeset in webkit [182043] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Function.prototype.toString should not decompile the AST
​https://bugs.webkit.org/show_bug.cgi?id=142853

Reviewed by Darin Adler.

Following up on Darin's review comments.

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

4:38 PM Changeset in webkit [182042] by timothy@apple.com
  • 45 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert TreeElement classes to ES6
​https://bugs.webkit.org/show_bug.cgi?id=143111

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ApplicationCacheFrameTreeElement.js:
  • UserInterface/Views/ApplicationCacheManifestTreeElement.js:
  • UserInterface/Views/BreakpointTreeElement.js:
  • UserInterface/Views/CallFrameTreeElement.js:
  • UserInterface/Views/ContentFlowTreeElement.js:
  • UserInterface/Views/CookieStorageTreeElement.js:
  • UserInterface/Views/DOMStorageTreeElement.js:
  • UserInterface/Views/DOMTreeElement.js:
  • UserInterface/Views/DOMTreeOutline.js:
  • UserInterface/Views/DatabaseHostTreeElement.js:
  • UserInterface/Views/DatabaseTableTreeElement.js:
  • UserInterface/Views/DatabaseTreeElement.js:
  • UserInterface/Views/FolderTreeElement.js:
  • UserInterface/Views/FolderizedTreeElement.js:
  • UserInterface/Views/FrameTreeElement.js:
  • UserInterface/Views/GeneralTreeElement.js:
  • UserInterface/Views/IndexedDatabaseHostTreeElement.js:
  • UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js:
  • UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
  • UserInterface/Views/IndexedDatabaseTreeElement.js:
  • UserInterface/Views/LegacyConsoleMessageImpl.js:
  • UserInterface/Views/LogTreeElement.js:
  • UserInterface/Views/NavigationSidebarPanel.js:
  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:
  • UserInterface/Views/ObjectTreeBaseTreeElement.js:
  • UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
  • UserInterface/Views/ObjectTreePropertyTreeElement.js:
  • UserInterface/Views/ObjectTreeSetIndexTreeElement.js:
  • UserInterface/Views/ObjectTreeView.js:
  • UserInterface/Views/ProfileNodeTreeElement.js:
  • UserInterface/Views/PropertiesSection.js:
  • UserInterface/Views/ResourceTreeElement.js:
  • UserInterface/Views/ScriptTreeElement.js:
  • UserInterface/Views/SearchResultTreeElement.js:
  • UserInterface/Views/SourceCodeTimelineTreeElement.js:
  • UserInterface/Views/SourceCodeTreeElement.js:
  • UserInterface/Views/SourceMapResourceTreeElement.js:
  • UserInterface/Views/StorageTreeElement.js:
  • UserInterface/Views/TimelineDataGrid.js:
  • UserInterface/Views/TimelineRecordTreeElement.js:
  • UserInterface/Views/TreeElementStatusButton.js:
  • UserInterface/Views/TreeOutline.js:
  • UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
  • UserInterface/Views/TypePropertiesSection.js:

Converted to ES6 classes where possible.

4:37 PM Changeset in webkit [182041] by timothy@apple.com
  • 17 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert sidebar classes to ES6
​https://bugs.webkit.org/show_bug.cgi?id=143108

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut._handleKeyDown): Continue if callback is null.
(WebInspector.KeyboardShortcut.prototype.set callback): Added.

  • UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
  • UserInterface/Views/DOMDetailsSidebarPanel.js:
  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
  • UserInterface/Views/DebuggerSidebarPanel.js:
  • UserInterface/Views/DetailsSidebarPanel.js:
  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
  • UserInterface/Views/NavigationSidebarPanel.js:
  • UserInterface/Views/ProbeDetailsSidebarPanel.js:
  • UserInterface/Views/ResourceDetailsSidebarPanel.js:
  • UserInterface/Views/ResourceSidebarPanel.js:
  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
  • UserInterface/Views/Sidebar.js:
  • UserInterface/Views/SidebarPanel.js:
  • UserInterface/Views/TimelineSidebarPanel.js:

Converted to ES6 classes.

4:37 PM Changeset in webkit [182040] by timothy@apple.com
  • 37 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert some View classes to ES6 classes
​https://bugs.webkit.org/show_bug.cgi?id=143107

Reviewed by Joseph Pecoraro.

  • UserInterface/Protocol/InspectorBackend.js:
  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.contextMenuItemSelected): Updated to the right function path.

  • UserInterface/Views/BoxModelDetailsSectionRow.js:
  • UserInterface/Views/BreakpointActionView.js:
  • UserInterface/Views/CodeMirrorAdditions.js:
  • UserInterface/Views/ColorPicker.js:
  • UserInterface/Views/ColorWheel.js:
  • UserInterface/Views/ContextMenu.js:
  • UserInterface/Views/DOMTreeElementPathComponent.js:
  • UserInterface/Views/DetailsSection.js:
  • UserInterface/Views/DetailsSectionDataGridRow.js:
  • UserInterface/Views/DetailsSectionGroup.js:
  • UserInterface/Views/DetailsSectionPropertiesRow.js:
  • UserInterface/Views/DetailsSectionRow.js:
  • UserInterface/Views/DetailsSectionSimpleRow.js:
  • UserInterface/Views/DetailsSectionTextRow.js:
  • UserInterface/Views/EditingSupport.js:
  • UserInterface/Views/EventListenerSection.js:
  • UserInterface/Views/EventListenerSectionGroup.js:
  • UserInterface/Views/FilterBar.js:
  • UserInterface/Views/FindBanner.js:
  • UserInterface/Views/GeneralTreeElementPathComponent.js:
  • UserInterface/Views/GoToLineDialog.js:
  • UserInterface/Views/GradientSlider.js:
  • UserInterface/Views/HierarchicalPathComponent.js:
  • UserInterface/Views/HierarchicalPathNavigationItem.js:
  • UserInterface/Views/HoverMenu.js:
  • UserInterface/Views/Popover.js:
  • UserInterface/Views/ProbeSetDetailsSection.js:
  • UserInterface/Views/ResourceTimelineDataGridNodePathComponent.js:
  • UserInterface/Views/SearchBar.js:
  • UserInterface/Views/Slider.js:

Converted to ES6 ckasses.

4:37 PM Changeset in webkit [182039] by timothy@apple.com
  • 20 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert Base and Protocol files to ES6 classes
​https://bugs.webkit.org/show_bug.cgi?id=143106

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/EventListener.js:
  • UserInterface/Base/EventListenerSet.js:
  • UserInterface/Protocol/ApplicationCacheObserver.js:
  • UserInterface/Protocol/CSSObserver.js:
  • UserInterface/Protocol/ConsoleObserver.js:
  • UserInterface/Protocol/DOMObserver.js:
  • UserInterface/Protocol/DOMStorageObserver.js:
  • UserInterface/Protocol/DatabaseObserver.js:
  • UserInterface/Protocol/DebuggerObserver.js:
  • UserInterface/Protocol/InspectorBackend.js:
  • UserInterface/Protocol/InspectorObserver.js:
  • UserInterface/Protocol/LayerTreeObserver.js:
  • UserInterface/Protocol/MessageDispatcher.js:
  • UserInterface/Protocol/NetworkObserver.js:
  • UserInterface/Protocol/PageObserver.js:
  • UserInterface/Protocol/RemoteObject.js:
  • UserInterface/Protocol/ReplayObserver.js:
  • UserInterface/Protocol/RuntimeObserver.js:
  • UserInterface/Protocol/TimelineObserver.js:

Converted to ES6 classes where possible.

4:35 PM Changeset in webkit [182038] by ggaren@apple.com
  • 23 edits in trunk/Source

"lineNo" does not match WebKit coding style guidelines
​https://bugs.webkit.org/show_bug.cgi?id=143119

Reviewed by Michael Saboff.

We can afford to use whole words.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

  • bytecode/UnlinkedCodeBlock.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::WhileNode::emitBytecode):

  • debugger/Debugger.cpp:

(JSC::Debugger::toggleBreakpoint):

  • interpreter/Interpreter.cpp:

(JSC::StackFrame::computeLineAndColumn):
(JSC::GetStackTraceFunctor::operator()):
(JSC::Interpreter::execute):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::computeLineAndColumn):

  • parser/Nodes.h:

(JSC::Node::firstLine):
(JSC::Node::lineNo): Deleted.
(JSC::StatementNode::firstLine): Deleted.

  • parser/ParserError.h:

(JSC::ParserError::toErrorObject):

  • profiler/LegacyProfiler.cpp:

(JSC::createCallIdentifierFromFunctionImp):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

  • runtime/Executable.cpp:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::ScriptExecutable::firstLine):
(JSC::ScriptExecutable::setOverrideLineNumber):
(JSC::ScriptExecutable::hasOverrideLineNumber):
(JSC::ScriptExecutable::overrideLineNumber):
(JSC::ScriptExecutable::lineNo): Deleted.
(JSC::ScriptExecutable::setOverrideLineNo): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNo): Deleted.
(JSC::ScriptExecutable::overrideLineNo): Deleted.

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionConstructor.h:
  • tools/CodeProfile.cpp:

(JSC::CodeProfile::report):

  • tools/CodeProfile.h:

(JSC::CodeProfile::CodeProfile):

Source/WebCore:

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSMainThreadExecStateInstrumentation.h:

(WebCore::JSMainThreadExecState::instrumentFunctionCall):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • testing/Internals.cpp:

(WebCore::Internals::parserMetaData):

4:24 PM Changeset in webkit [182037] by enrica@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION(r1807689): Slower startup time for WKWebView.
​https://bugs.webkit.org/show_bug.cgi?id=143115
rdar://problem/20233711

Reviewed by Anders Carlsson.

In ​http://trac.webkit.org/changeset/180768 we added an observer to
track visibility of the NSFontPanel to ensure we could fetch the font
information for the current selection when the panel first becomes visible.
It turns out that adding the observer requires the shared font panel
object to be created.
That is apparently a very expensive operation that is regressing
the initialization time for the WKWebView.
We should initialize the NSFontPanel lazily, only when we make the entire
view editable.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setEditable:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView _addFontPanelObserver]):
(-[WKView removeWindowObservers]):
(-[WKView observeValueForKeyPath:ofObject:change:context:]):

  • UIProcess/API/mac/WKViewInternal.h:
4:23 PM Changeset in webkit [182036] by roger_fong@apple.com
  • 5 edits in trunk

Apply blur effect to media control background.
​https://bugs.webkit.org/show_bug.cgi?id=143116.
<rdar://problem/20316964>.

Reviewed by Brent Fulgham.

There are still a few issues, like the borders of the controls being blurred with black,
and the volume slider background not showing the blur effect. Will fix those separately.
Add CSS for new divs to create blur effect using back drop filters and blend modes.

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-panel-tint):
(audio::-webkit-media-controls-panel-background):
(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-volume-slider-container-background):
(audio::-webkit-media-controls-volume-slider-container-tint):
(audio::-webkit-media-controls-toggle-closed-captions-button): Adjust fill.
(audio::-webkit-media-controls-fullscreen-button): Adjust fill.
(audio::-webkit-media-controls-fullscreen-button.exit): Adjust fill.
(video:-webkit-full-screen::-webkit-media-controls-panel):
(audio:-webkit-full-screen::-webkit-media-controls-panel-tint):
(audio:-webkit-full-screen::-webkit-media-controls-panel-background):
(video:-webkit-full-screen::-webkit-media-controls-panel .volume-box):
(video:-webkit-full-screen::-webkit-media-controls-play-button):
(video:-webkit-full-screen::-webkit-media-controls-seek-back-button):
(video:-webkit-full-screen::-webkit-media-controls-seek-forward-button):
(video:-webkit-full-screen::-webkit-media-controls-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-status-display):
(audio::-webkit-media-controls-panel .volume-box:active): Deleted.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.configureInlineControls): Add new divs for blurred background effect.
(Controller.prototype.configureFullScreenControls): Ditto.
(Controller.prototype.handlePanelMouseDown): The tint div is now in front.
(Controller.prototype.drawTimelineBackground): Adjust colors to make border look better with new background.
(Controller.prototype.drawVolumeBackground): Ditto.

4:22 PM Changeset in webkit [182035] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

4:12 PM Changeset in webkit [182034] by ggaren@apple.com
  • 19 edits
    2 adds in trunk

Assertion firing in JavaScriptCore/parser/parser.h for statesman.com site
​https://bugs.webkit.org/show_bug.cgi?id=142974

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch does two things:

(1) Restore JavaScriptCore's sanitization of line and column numbers to
one-based values.

We need this because WebCore sometimes provides huge negative column
numbers.

(2) Solve the attribute event listener line numbering problem a different
way: Rather than offseting all line numbers by -1 in an attribute event
listener in order to arrange for a custom result, instead use an explicit
feature for saying "all errors in this code should map to this line number".

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

  • bytecode/UnlinkedCodeBlock.h:
  • interpreter/Interpreter.cpp:

(JSC::StackFrame::computeLineAndColumn):
(JSC::GetStackTraceFunctor::operator()):

  • interpreter/Interpreter.h:
  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::computeLineAndColumn):

  • parser/ParserError.h:

(JSC::ParserError::toErrorObject): Plumb through an override line number.
When a function has an override line number, all syntax and runtime
errors in the function will map to it. This is useful for attribute event
listeners.

  • parser/SourceCode.h:

(JSC::SourceCode::SourceCode): Restore the old sanitization of line and
column numbers to one-based integers. It was kind of a hack to remove this.

  • runtime/Executable.cpp:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::ScriptExecutable::setOverrideLineNo):
(JSC::ScriptExecutable::hasOverrideLineNo):
(JSC::ScriptExecutable::overrideLineNo):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionConstructor.h: Plumb through an override line number.

Source/WebCore:

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction): Use the new override
line number API to guarantee that errors will map to the .html file locations
that we like.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition): Added a FIXME to cover
some cases where our line and column numbers are still nonsense.

LayoutTests:

No test covering this ASSERT because I couldn't design a way to reproduce
it after trying for a few hours. Simply loading the original ASSERTing
content from disk is not enough to reproduce this bug.

  • fast/profiler/dead-time-expected.txt:
  • fast/profiler/inline-event-handler-expected.txt:
  • fast/profiler/stop-profiling-after-setTimeout-expected.txt: These are

progressions, where we used to get the line number wrong.

  • fast/dom/attribute-event-listener-errors-expected.txt: Added.
  • fast/dom/attribute-event-listener-errors.html: Added. This test covers

a subtle way in which the new mechanism for attribute event listener
line numbers is more accurate than the old one.

4:06 PM Changeset in webkit [182033] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Relevant repainted objects callback is inaccurate and inconsistent for PDF
documents
​https://bugs.webkit.org/show_bug.cgi?id=143118
-and corresponding-
rdar://problem/13371582

Reviewed by Tim Horton.

Investigating this bug resulted in finding two things that should change for the
relevant repainted objects heuristic. First, we should not count any objects
painted while updating control tints. And secondly, we should not use it at all
for plugin documents. In other documents, we count the plugin area as “painted”
when we get to paint whether or not the plugin has actually loaded. This is
intentional because it allows us to account for chunks of the page that will be
filled in by possibly slow-loading ads. However, if the plugin is the whole
document, then the heuristic just doesn’t make any sense and it leads to
inconsistent behavior at different window sizes. So we’ll only count plugins when
the document is not a plugin document.

Don’t count objects during this paint!

  • page/FrameView.cpp:

(WebCore::FrameView::updateControlTints):

  • page/Page.h:

(WebCore::Page::setIsCountingRelevantRepaintedObjects):

Make sure the document is not a plugin document.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paint):

3:53 PM Changeset in webkit [182032] by commit-queue@webkit.org
  • 18 edits in trunk

Progress towards CMake on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=143112

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-03-26
Reviewed by Chris Dumez.

.:

  • Source/cmake/OptionsMac.cmake:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • platform/graphics/mac/IconMac.mm:

Source/WebKit:

  • PlatformMac.cmake:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

  • CMakeLists.txt:
  • PlatformMac.cmake:
  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

Source/WTF:

  • wtf/PlatformMac.cmake:
3:52 PM Changeset in webkit [182031] by Chris Dumez
  • 12 edits in trunk/Source/WebKit2

[WK2][Cocoa] Add private API to override the network disk cache size
​https://bugs.webkit.org/show_bug.cgi?id=143113
<rdar://problem/20315669>

Reviewed by Antti Koivisto.

Add private API to let the client override the network disk cache size.
By default, the network disk cache is automatically determined based on
the CacheModel and the available disk space. However, for testing
purposes, it can be used for the client-side to be able to override
the disk cache size.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::setMaximumSize):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformSetCacheModel):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration diskCacheSizeOverride]):
(-[_WKProcessPoolConfiguration setDiskCacheSizeOverride:]):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::ensureNetworkProcess):

  • UIProcess/WebProcessPool.h:
3:35 PM Changeset in webkit [182030] by ap@apple.com
  • 2 edits in trunk/Tools

Layout test results URL loads in WK1 but not WK2 minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=143117

Reviewed by Tim Horton.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
everything.
(-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.

3:31 PM Changeset in webkit [182029] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Accessibility crashing because MediaPlayer is laying out UI off the main thread
​https://bugs.webkit.org/show_bug.cgi?id=142970

Reviewed by Eric Carlson.

isMainThread() will (ironically) return true if called from the web thread. Rather than dispatch
synchronously to the main thread to allocate the _volumeView, dispatch asynchronously and handle
the case where the MPVolumeView has not yet been created.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper allocateVolumeView]): Dispatch to the main thread to allocate. Move notification

registration to -setVolumeView:.

(-[WebMediaSessionHelper setVolumeView:]): Added. Register/Unregister for route availablitiy notifications.
(-[WebMediaSessionHelper hasWirelessTargetsAvailable]): Handle the possibility of a nil _volumeView.

3:20 PM Changeset in webkit [182028] by akling@apple.com
  • 6 edits in trunk/Source/WebKit2

[Darwin] Boost the web process QoS level while handling a synchronous IPC message.
<​https://webkit.org/b/142988>
<rdar://problem/20264346>

Reviewed by Antti Koivisto and Anders Carlsson.

Add a mechanism for IPC::Connection to boost the main thread for the duration
of processing a synchronous message.

This fixes an issue where the UI process would block on a synchronous request
to the web process that was being carried out at a lower QoS level.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::Connection): Save the main thread's pthread_t while we have
a chance to retreive it.

(IPC::Connection::processIncomingMessage): Optionally boost the main thread when
processing an incoming message with the IsSyncMessage flag set.

  • Platform/IPC/Connection.h:

(IPC::Connection::setShouldBoostMainThreadOnSyncMessage): Added. When this mode is
enabled, Connection will give a temporary QoS override to the main thread when
receiving a synchronous message. Ownership of the override is handed to the
MessageDecoder, which resets the main thread QoS in its destructor.

  • Platform/IPC/MessageDecoder.cpp:

(IPC::MessageDecoder::~MessageDecoder): Remove any QoS override owned by this message.

  • Platform/IPC/MessageDecoder.h:

(IPC::MessageDecoder::setQOSClassOverride): Added. Takes ownership of a QoS override
to make sure it stays in effect until this message has been dispatched.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection): Set up main thread QoS boosting for the
web process's connection to the UI process.

3:09 PM Changeset in webkit [182027] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.16

New tag.

2:43 PM Changeset in webkit [182026] by rniwa@webkit.org
  • 5 edits in trunk/Source

Cursor doesn't change back to pointer when leaving Mail
​https://bugs.webkit.org/show_bug.cgi?id=132038

Reviewed by Anders Carlsson.

Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
AppKit will reset the cursor as it leaves the WebView.

We use nil cursor here since we manually update the cursor by calling [NSCursor set].

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processPool:configuration:webView:]):

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

2:30 PM Changeset in webkit [182025] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r182014. rdar://problem/20313011

2:02 PM Changeset in webkit [182024] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix state maching debugging after r181964
​https://bugs.webkit.org/show_bug.cgi?id=143082

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-03-26
Reviewed by Alex Christensen.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

1:48 PM Changeset in webkit [182023] by fpizlo@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

If we're in code for accessing scoped arguments, we should probably check if the object is a scoped arguments rather than checking if it's a direct arguments.

Reviewed by Michael Saboff.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

  • tests/stress/scoped-then-direct-arguments-get-by-val-in-baseline.js: Added.
12:09 PM Changeset in webkit [182022] by hyatt@apple.com
  • 4 edits in trunk/Source/WebCore

Improve the offsetWidth/Height layout optimization
​https://bugs.webkit.org/show_bug.cgi?id=143008

Reviewed by Zalan Bujtas.

  • dom/Document.cpp:

(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

  • dom/Document.h:

Change Element* to Element&. Clean up the dimension bits to use shifting. Remove both the inline and
the positioning restrictions on the optimization check.

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
Change to use Element& instead of Element*.

(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
(WebCore::Element::scrollWidth):
(WebCore::Element::scrollHeight):
Turn on the optimization for clientWidth/Height and scrollWidth/Height.

12:00 PM Changeset in webkit [182021] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Linux] SeccompFilters: improve the port-agnostic whitelist
​https://bugs.webkit.org/show_bug.cgi?id=140064

Patch by Michael Catanzaro <Michael Catanzaro> on 2015-03-26
Reviewed by Žan Doberšek.

Allow the web process to access several files and directories that it
was previously prohibited from accessing. This makes the web process
much less likely to break.

  • Shared/linux/SeccompFilters/SyscallPolicy.cpp:

(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

11:49 AM Changeset in webkit [182020] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Remove unneeded isConditionalRequest check from NetworkResourceLoader
​https://bugs.webkit.org/show_bug.cgi?id=143096

Reviewed by Anders Carlsson.

This check is leftover from implementation that allowed disk cache to validate conditional
request itself. The case can't happen as NetworkCache canRetrieve test does not allow
conditional requests in the first place.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::isConditionalRequest): Deleted.

11:39 AM Changeset in webkit [182019] by Antti Koivisto
  • 6 edits in trunk/Source/WebKit2

Rename Storage::Entry to Storage::Record
​https://bugs.webkit.org/show_bug.cgi?id=143101

Reviewed by Chris Dumez.

Lets have just one type called Entry in the cache code.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::update):
(WebKit::NetworkCache::Cache::traverse):
(WebKit::NetworkCache::Cache::dumpContentsToFile):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):
(WebKit::NetworkCache::Entry::encodeAsStorageRecord):
(WebKit::NetworkCache::Entry::decodeStorageRecord):
(WebKit::NetworkCache::Entry::initializeBufferFromStorageRecord):
(WebKit::NetworkCache::Entry::buffer):
(WebKit::NetworkCache::Entry::shareableResourceHandle):
(WebKit::NetworkCache::Entry::encode): Deleted.
(WebKit::NetworkCache::Entry::decode): Deleted.
(WebKit::NetworkCache::Entry::initializeBufferFromStorageEntry): Deleted.

  • NetworkProcess/cache/NetworkCacheEntry.h:

(WebKit::NetworkCache::Entry::sourceStorageRecord):
(WebKit::NetworkCache::Entry::sourceStorageEntry): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::RecordMetaData::RecordMetaData):
(WebKit::NetworkCache::decodeRecordMetaData):
(WebKit::NetworkCache::decodeRecordHeader):
(WebKit::NetworkCache::decodeRecord):
(WebKit::NetworkCache::encodeRecordMetaData):
(WebKit::NetworkCache::encodeRecordHeader):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::retrieveFromMemory):
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::update):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::dispatchPendingWriteOperations):
(WebKit::NetworkCache::Storage::dispatchFullWriteOperation):
(WebKit::NetworkCache::Storage::dispatchHeaderWriteOperation):
(WebKit::NetworkCache::EntryMetaData::EntryMetaData): Deleted.
(WebKit::NetworkCache::decodeEntryMetaData): Deleted.
(WebKit::NetworkCache::decodeEntryHeader): Deleted.
(WebKit::NetworkCache::decodeEntry): Deleted.
(WebKit::NetworkCache::encodeEntryMetaData): Deleted.
(WebKit::NetworkCache::encodeEntryHeader): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.h:
11:16 AM Changeset in webkit [182018] by jer.noble@apple.com
  • 4 edits in trunk/Tools

Add --allowed-host support to run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=142938

Reviewed by Brent Fulgham.

Accept --allowed-host arguments from run-webkit-tests and pass them through to
DumpRenderTree and WebKitTestRunner.

Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
are placed in the wrong location. The argument is compared with each tests's path, and if a
relative path or a path with '..' was used, results are placed alongside the test. Take the
absolute path of the --layout-test-dir argument, collapsing path components like '..'.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.allowed_hosts):

  • Scripts/webkitpy/port/driver.py:

(Driver.cmd_line):

11:12 AM Changeset in webkit [182017] by jer.noble@apple.com
  • 12 edits in trunk/Tools

[Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
​https://bugs.webkit.org/show_bug.cgi?id=142931

Reviewed by Brent Fulgham.

Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
runtime.

To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
hostname to a whitelist; requests to these hosts will allowed to proceed normally.

Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
the top loading frame from the page, as we do elsewhere in this class.

  • DumpRenderTree/TestRunner.h:

(TestRunner::allowedHosts):
(TestRunner::setAllowedHosts):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions):
(runTest):

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(isAllowedHost):
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::isAllowedHost):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::isAllowedHost):
(WTR::InjectedBundlePage::willSendRequestForFrame):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/Options.cpp:

(WTR::handleOptionAllowedHost):
(WTR::OptionsHandler::OptionsHandler):

  • WebKitTestRunner/Options.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
10:45 AM Changeset in webkit [182016] by beidson@apple.com
  • 15 edits
    10 adds in trunk

Apply ContentExtension actions after redirects.
<rdar://problem/20062613> and ​https://bugs.webkit.org/show_bug.cgi?id=143055

Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/tests/contentextensions/loading/main-resource-redirect-blocked.php

http/tests/contentextensions/subresource-redirect-blocked.html

This patch moves the "run a URL against the content extension" code from CachedResourceLoader to
the ContentExtensionsBackend.

That allows it to be shared between the CachedResourceLoader where loads are initiated and
ResourceLoader where redirects are handled.

  • contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::globalDisplayNoneStyleSheet):

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::displayNoneCSSRule):

  • contentextensions/ContentExtensionsBackend.h:
  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):

  • loader/ResourceLoadInfo.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::willSendRequest):

  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • page/UserContentController.cpp:

(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad): Deleted.
(WebCore::UserContentController::globalDisplayNoneStyleSheet): Deleted.
(WebCore::UserContentController::displayNoneCSSRule): Deleted.

  • page/UserContentController.h:

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL

which is specifically interesting to a new test.

LayoutTests:

  • http/tests/contentextensions/loading/main-resource-redirect-blocked-expected.txt: Added.
  • http/tests/contentextensions/loading/main-resource-redirect-blocked.php: Added.
  • http/tests/contentextensions/loading/main-resource-redirect-blocked.php.json: Added.
  • http/tests/contentextensions/loading/resources/main-resource-redirect-blocked-target.html: Added.
  • http/tests/contentextensions/resources/subresource-redirect.php: Added.
  • http/tests/contentextensions/subresource-redirect-blocked-expected.txt: Added.
  • http/tests/contentextensions/subresource-redirect-blocked.html: Added.
  • http/tests/contentextensions/subresource-redirect-blocked.html.json: Added.
10:29 AM Changeset in webkit [182015] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when laying out (char)0
​https://bugs.webkit.org/show_bug.cgi?id=143103

Reviewed by Dean Jackson.

We currently cache a character -> Font mapping in a HashMap.
However, keys in Hashmaps can't be 0. This patch simply skips
the cache in this case.

No new tests, for now. I'm having trouble creating a test because
the site that causes this bug generates their page using script,
and the script is all minified, and difficult to understand. I
will contact the owner of the site and ask for and unminified
version of their sources. However, I don't want to that to block
this tiny fix from going in.

  • platform/graphics/Font.cpp:

(WebCore::Font::systemFallbackFontForCharacter):

10:24 AM Changeset in webkit [182014] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac][EME] Crash at com.apple.WebCore: WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys + 177
​https://bugs.webkit.org/show_bug.cgi?id=143080

Reviewed by Eric Carlson.

Null-check m_certificate before dereferencing.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):

10:04 AM Changeset in webkit [182013] by msaboff@apple.com
  • 2 edits in trunk/LayoutTests

js/promises-tests/promises-tests-2-3-3.html sometimes crashes under DFG::SpeculativeJIT::compile
​https://bugs.webkit.org/show_bug.cgi?id=139865

Reviewed by Alexey Proskuryakov.

It appears that r181993 fixed this test as it removed the code where the crash occurred.

  • TestExpectations: Re-enabled js/promises-tests/promises-tests-2-3-3 including marking it as Slow.
9:35 AM Changeset in webkit [182012] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: [role="button"][aria-pressed] should be exposed as AXCheckbox:AXToggleButton, with role description of "toggle button"
​https://bugs.webkit.org/show_bug.cgi?id=115298

Reviewed by Mario Sanchez Prada.

Source/WebCore:

A role=button + aria-pressed object should be exposed as AXCheckbox on Mac now. It should also convert the
aria-pressed state into a 0, 1, 2 number value for the Mac.

Test: platform/mac/accessibility/aria-pressed-button-attributes.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::checkboxOrRadioValue):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isToggleButton):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • accessibility/aria-toggle-button-with-title.html:

Bad path for post test resources file, so that is fixed.

  • platform/mac/accessibility/aria-pressed-button-attributes-expected.txt: Added.
  • platform/mac/accessibility/aria-pressed-button-attributes.html: Added.
  • platform/mac/accessibility/aria-toggle-button-with-title-expected.txt:

Updated to reflect the new role of this object.

9:24 AM Changeset in webkit [182011] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

[WK2] Let the compiler generate the NetworkCache::Key move constructor
​https://bugs.webkit.org/show_bug.cgi?id=143079

Reviewed by Antti Koivisto.

Let the compiler generate the NetworkCache::Key move constructor. The
generated one will do exactly the same thing as the one we had except
that it will move the m_hash member as well. I don't see any reason why
we weren't moving this member before (it is an std::array<uint8_t, 16>).

Also have the compiler generate a move assignment operator for
consistency. Although it is not currently useful, it could be at some
point.

  • NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::Key::Key): Deleted.

  • NetworkProcess/cache/NetworkCacheKey.h:
9:21 AM Changeset in webkit [182010] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Compute if a cached response has expired only when actually needed
​https://bugs.webkit.org/show_bug.cgi?id=143070

Reviewed by Antti Koivisto.

Compute if a cached response has expired only when actually needed:

  • This is not a history navigation

and

  • It does not have "Cache-Control: no-cache" header

Previously, we would always determine if the response has expired and
we often end up not using this information.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::responseHasExpired):
(WebKit::NetworkCache::canUse):

8:29 AM Changeset in webkit [182009] by fpizlo@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

FTL ScopedArguments GetArrayLength generates incorrect code and crashes in LLVM
​https://bugs.webkit.org/show_bug.cgi?id=143098

Reviewed by Csaba Osztrogonác.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength): Fix a typo.

  • tests/stress/scoped-arguments-array-length.js: Added. This test previously always crashed in ftl-no-cjit mode.
5:23 AM Changeset in webkit [182008] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[EFL] Disable building libseccomp on AArch64
​https://bugs.webkit.org/show_bug.cgi?id=143094

Reviewed by Gyuyoung Kim.

  • efl/jhbuildrc:
5:21 AM Changeset in webkit [182007] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[jhbuild] git should use only 1 thread for cloning jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=143095

Reviewed by Gyuyoung Kim.

  • jhbuild/jhbuild-wrapper:

(clone_jhbuild):

3:47 AM Changeset in webkit [182006] by Csaba Osztrogonác
  • 8 edits in trunk

Unreviewed gardening, skip failing tests on AArch64 Linux.

Source/JavaScriptCore:

  • tests/mozilla/mozilla-tests.yaml:
  • tests/stress/cached-prototype-setter.js:

LayoutTests:

  • js/script-tests/array-from.js:
  • js/script-tests/array-length-shortening.js:
  • js/script-tests/dfg-int16array.js:
  • js/script-tests/dfg-int8array.js:
12:51 AM Changeset in webkit [182005] by zandobersek@gmail.com
  • 9 edits in trunk/Source/WebKit2

Avoid the Vector<> copy in WebTouchEvent constructor
​https://bugs.webkit.org/show_bug.cgi?id=143043

Reviewed by Carlos Garcia Campos.

Have the WebTouchEvent accept a Vector<> rvalue.
The relevant code is updated so the Vector<> object is moved
through the call chain and finally into the WebTouchEvent constructor.

  • Shared/NativeWebTouchEvent.h:
  • Shared/WebEvent.h:
  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::WebTouchEvent):

  • Shared/efl/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/gtk/NativeWebTouchEventGtk.cpp:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseTouchEvent):

12:17 AM Changeset in webkit [182004] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, fixes to silly things. While landing fixes to r181993, I introduced crashes. This fixes them.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants): I landed a fix for a VS warning. It broke this. Now I'm fixing it.

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile): Make sure we pass the module when dumping. This makes FTL debugging possible again.

  • ftl/FTLState.cpp:

(JSC::FTL::State::dumpState): New overload that takes a module, so that we can call this after FTL::compile() clears State's module.

  • ftl/FTLState.h:
12:00 AM Changeset in webkit [182003] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/track/track-mode.html flakily times out
​https://bugs.webkit.org/show_bug.cgi?id=143085

Note: See TracTimeline for information about the timeline view.