Timeline



May 25, 2015:

11:29 PM Changeset in webkit [184855] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Export DatabaseProcessMainUnix symbol.

Add DatabaseProcessMainUnix symbol to gtksymbols.filter so that it
is exported in production builds.

  • Source/cmake/gtksymbols.filter:
10:20 PM Changeset in webkit [184854] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed a failing bindings test after r184853.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation): Removed an extraneous semicolon.

7:26 PM Changeset in webkit [184853] by mitz@apple.com
  • 42 edits in trunk/Source

ASSERT_MAIN_THREAD and DOM_ASSERT_MAIN_THREAD are unnecessary no-ops
​https://bugs.webkit.org/show_bug.cgi?id=145372

Reviewed by Sam Weinig.

Source/WebCore:

  • Configurations/Base.xcconfig: Removed DISABLE_THREAD_CHECK from DEBUG_DEFINES.
  • bindings/objc/DOMAbstractView.mm:

(-[DOMAbstractView dealloc]): Removed use of DOM_ASSERT_MAIN_THREAD.
(kit): Ditto.

  • bindings/objc/ExceptionHandlers.h: Removed definition of DOM_ASSERT_MAIN_THREAD.
  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation): Don’t emit DOM_ASSERT_MAIN_THREAD.

Updated expected bindings test results:

  • bindings/scripts/test/ObjC/DOMFloat64Array.mm:
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm:
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.mm:
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm:
  • bindings/scripts/test/ObjC/DOMTestException.mm:
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.mm:
  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.mm:
  • bindings/scripts/test/ObjC/DOMTestNode.mm:
  • bindings/scripts/test/ObjC/DOMTestNondeterministic.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
  • bindings/scripts/test/ObjC/DOMattribute.mm:
  • bindings/scripts/test/ObjC/DOMreadonly.mm:

Source/WebKit/ios:

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider initWithListener:]): Removed use of ASSERT_MAIN_THREAD.
(-[WebGeolocationCoreLocationProvider dealloc]): Ditto.
(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]): Ditto.
(-[WebGeolocationCoreLocationProvider start]): Ditto.
(-[WebGeolocationCoreLocationProvider stop]): Ditto.
(-[WebGeolocationCoreLocationProvider setEnableHighAccuracy:]): Ditto.

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter finalize]): Removed use of ASSERT_MAIN_THREAD.

  • Configurations/Base.xcconfig: Removed DISABLE_THREAD_CHECK from DEBUG_DEFINES.
  • History/WebHistoryItem.mm:

(-[WebHistoryItem URLString]): Removed use of ASSERT_MAIN_THREAD.
(-[WebHistoryItem originalURLString]): Ditto.
(-[WebHistoryItem title]): Ditto.
(-[WebHistoryItem lastVisitedTimeInterval]): Ditto.
(-[WebHistoryItem isEqual:]): Ditto.
(-[WebHistoryItem description]): Ditto.
(-[WebHistoryItem initFromDictionaryRepresentation:]): Ditto.
(-[WebHistoryItem scrollPoint]): Ditto.

  • Misc/WebElementDictionary.mm:

(-[WebElementDictionary finalize]): Ditto.

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase iconForURL:withSize:cache:]): Ditto.
(-[WebIconDatabase iconURLForURL:]): Ditto.
(-[WebIconDatabase defaultIconWithSize:]): Ditto.
(-[WebIconDatabase retainIconForURL:]): Ditto.
(-[WebIconDatabase releaseIconForURL:]): Ditto.
(+[WebIconDatabase delayDatabaseCleanup]): Ditto.
(+[WebIconDatabase allowDatabaseCleanup]): Ditto.
(-[WebIconDatabase removeAllIcons]): Ditto.
(-[WebIconDatabase _iconForFileURL:withSize:]): Ditto.
(webGetNSImage): Ditto.

  • Misc/WebKitLogging.h: Removed definition of ASSERT_MAIN_THREAD.
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView finalize]): Removed use of ASSERT_MAIN_THREAD.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage finalize]): Ditto.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView finalize]): Ditto.

  • WebCoreSupport/WebEditorClient.mm:

(-[WebUndoStep finalize]): Ditto.

  • WebView/WebDataSource.mm:

(-[WebDataSource finalize]): Ditto.

  • WebView/WebHTMLView.mm:

(-[WebHTMLViewPrivate finalize]): Ditto.
(-[WebHTMLView finalize]): Ditto.
(-[WebHTMLView drawRect:]): Ditto.

  • WebView/WebViewData.mm:

(-[WebViewPrivate finalize]): Ditto.

Source/WebKit2:

  • Configurations/Base.xcconfig: Removed DISABLE_THREAD_CHECK from DEBUG_DEFINES.
6:46 PM Changeset in webkit [184852] by commit-queue@webkit.org
  • 36 edits in trunk/Source/WebCore

Replaced 0 with nullptr in WebCore/svg.
​https://bugs.webkit.org/show_bug.cgi?id=145367

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-25
Reviewed by Gyuyoung Kim.

No new tests, no behavior changes.

  • svg/PatternAttributes.h:

(WebCore::PatternAttributes::PatternAttributes):

  • svg/SVGAnimatedType.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::cursorElementRemoved):
(WebCore::SVGElement::cursorImageValueRemoved):
(WebCore::SVGElement::getPresentationAttribute):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::removedFrom):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

  • svg/SVGLength.h:

(WebCore::SVGLength::blend):

  • svg/SVGPathBlender.cpp:

(WebCore::SVGPathBlender::SVGPathBlender):
(WebCore::SVGPathBlender::cleanup):

  • svg/SVGPathBuilder.cpp:

(WebCore::SVGPathBuilder::SVGPathBuilder):

  • svg/SVGPathBuilder.h:
  • svg/SVGPathByteStreamBuilder.cpp:

(WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder):

  • svg/SVGPathByteStreamBuilder.h:
  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::dPropertyInfo):

  • svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::SVGPathParser):
(WebCore::SVGPathParser::cleanup):

  • svg/SVGPathSegListBuilder.cpp:

(WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):

  • svg/SVGPathSegListBuilder.h:
  • svg/SVGPathTraversalStateBuilder.cpp:

(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):

  • svg/SVGPathUtilities.cpp:

(WebCore::globalSVGPathBuilder):
(WebCore::globalSVGPathSegListBuilder):
(WebCore::globalSVGPathByteStreamBuilder):
(WebCore::globalSVGPathStringBuilder):
(WebCore::globalSVGPathTraversalStateBuilder):
(WebCore::globalSVGPathParser):
(WebCore::globalSVGPathBlender):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::pointsPropertyInfo):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefTargetEventListener::cast):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthPropertyInfo):

  • svg/SVGURIReference.h:
  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):

  • svg/SVGViewSpec.h:

(WebCore::SVGViewSpec::resetContextElement):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::ConditionEventListener::cast):
(WebCore::ConditionEventListener::disconnectAnimation):
(WebCore::SVGSMILElement::SVGSMILElement):
(WebCore::SVGSMILElement::removedFrom):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawForContainer):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::FEImage):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearEffects):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

  • svg/properties/SVGAnimatedPropertyDescription.h:

(WebCore::SVGAnimatedPropertyDescription::SVGAnimatedPropertyDescription):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

  • svg/properties/SVGPropertyTearOff.h:

(WebCore::SVGPropertyTearOff::SVGPropertyTearOff):

8:15 AM Changeset in webkit [184851] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
​https://bugs.webkit.org/show_bug.cgi?id=140882

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitWebContext:indexed-db-database-directory construct only property.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):

Tools:

Make sure unit tests write IndexedDB databases to the temporary
directory, and add a test case to check that the directory is
correctly created at the expected path.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextConfiguration):
(serverCallback):

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::Test):

12:05 AM Changeset in webkit [184850] by Carlos Garcia Campos
  • 7 edits in trunk

[GTK] Enable IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=98932

Reviewed by Žan Doberšek.

.:

  • Source/cmake/OptionsGTK.cmake: Enable DATABASE_PROCESS and INDEXED_DATABASE.
  • Source/cmake/WebKitFeatures.cmake: Add ENABLE_DATABASE_PROCESS.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.

LayoutTests:

  • platform/gtk/TestExpectations: Update IndexedDB test expectations.

May 24, 2015:

11:55 PM Changeset in webkit [184849] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Bump GCC requirements to 4.9.0
​https://bugs.webkit.org/show_bug.cgi?id=145211

Reviewed by Žan Doberšek.

It's required to build with IndexedDB support when using GCC,
clang works just fine. See ​https://bugs.webkit.org/show_bug.cgi?id=98932.

  • Source/cmake/OptionsGTK.cmake:
8:51 PM Changeset in webkit [184848] by commit-queue@webkit.org
  • 7 edits in trunk

Array#findIndex/find should not skip holes
​https://bugs.webkit.org/show_bug.cgi?id=145361
Source/JavaScriptCore:

per ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.findindex
and ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.find

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-05-24
Reviewed by Yusuke Suzuki.

  • builtins/Array.prototype.js:

(find): Deleted.
(findIndex): Deleted.

LayoutTests:

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-05-24
Reviewed by Yusuke Suzuki.

  • js/array-find-expected.txt:
  • js/array-findIndex-expected.txt:
  • js/script-tests/array-find.js:
  • js/script-tests/array-findIndex.js:
7:38 PM Changeset in webkit [184847] by Brian Burg
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Uncaught exception when using Inspect tool on SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=145363

Reviewed by Joseph Pecoraro.

The injected script failed by chaining a call to String.prototype.trim to the result of
SVG*Element.className, which is an SVGAnimatedString and lacks useful methods. So, obtain
the class name using Node.getAttribute, which always returns a DOMString.

  • inspector/InjectedScriptSource.js:

(InjectedScriptSource.prototype._getDescription): use getAttribute instead of className.

4:22 PM Changeset in webkit [184846] by weinig@apple.com
  • 13 edits in trunk

Crash when using a removed ScriptMessageHandler
<rdar://problem/20888499>
​https://bugs.webkit.org/show_bug.cgi?id=145359

Reviewed by Dan Bernstein.

Source/WebCore:

Added tests:

WKUserContentController.ScriptMessageHandlerBasicRemove
WKUserContentController.ScriptMessageHandlerCallRemovedHandler

  • page/UserMessageHandler.cpp:

(WebCore::UserMessageHandler::~UserMessageHandler):
(WebCore::UserMessageHandler::postMessage):
(WebCore::UserMessageHandler::name):

  • page/UserMessageHandler.h:

(WebCore::UserMessageHandler::create):

  • page/UserMessageHandler.idl:
  • page/UserMessageHandlerDescriptor.cpp:

(WebCore::UserMessageHandlerDescriptor::UserMessageHandlerDescriptor):

  • page/UserMessageHandlerDescriptor.h:

(WebCore::UserMessageHandlerDescriptor::client):
(WebCore::UserMessageHandlerDescriptor::invalidateClient):
Add support for invalidating the descriptor and throw an exception if someone tries
to post a message using an invalidated descriptor.

  • page/UserMessageHandlersNamespace.cpp:

(WebCore::UserMessageHandlersNamespace::handler):
Add logic to remove message handlers if their descriptor has been invalidated.

Source/WebKit2:

  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserMessageHandlerDescriptorProxy::~WebUserMessageHandlerDescriptorProxy):
Invalidate the descriptor when the message handler client (as implemented by WebUserMessageHandlerDescriptorProxy)
goes away. This will happen if a script message handler is removed at the API level or the WebUserContentController
is destroyed (which will happen if all the pages get destroyed).

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:

Add tests for removing script message handlers.

12:30 PM Changeset in webkit [184845] by mitz@apple.com
  • 17 edits in trunk

Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
​https://bugs.webkit.org/show_bug.cgi?id=145345

Reviewed by Sam Weinig.

Source/bmalloc:

  • Configurations/Base.xcconfig: Also changed to use $(inherited).

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Also changed to use $(inherited).

Source/WebCore:

  • Configurations/WebCore.xcconfig: Also changed to use $(inherited).

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKitLegacy.xcconfig: Also changed to use $(inherited).

Source/WTF:

  • Configurations/Base.xcconfig: Also changed to use $(inherited).

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • LayoutTestRelay/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
11:31 AM Changeset in webkit [184844] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/svg.
​https://bugs.webkit.org/show_bug.cgi?id=145209

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-24
Reviewed by Darin Adler.

No new tests, no behavior changes.

  • svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::~SVGCursorElement):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):

  • svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):

  • svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::append):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearResultsRecursive):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.cpp:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):

10:43 AM Changeset in webkit [184843] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Register media MIME types as supported by HTML view in WebKit1.
​https://bugs.webkit.org/show_bug.cgi?id=145356

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-05-24
Reviewed by Eric Carlson.

Source/WebCore:

getSupportedMediaMIMETypes is now used in WebKit1.

  • platform/MIMETypeRegistry.h: Export getSupportedMediaMIMETypes.

Source/WebKit/mac:

WebDataSource and WebFrame view knew about suppotedImageMIMETypes and supportedNonImageMIMETypes,
but not a third category supportedMediaMIMETypes. These are now included along-side
supportedNonImageMIMETypes.

  • WebView/WebDataSource.mm:

(+[WebDataSource _repTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.

  • WebView/WebFrameView.mm:

(+[WebFrameView _viewTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.

  • WebView/WebHTMLRepresentation.h: declare -supportedMediaMIMETypes
  • WebView/WebHTMLRepresentation.mm:

(+[WebHTMLRepresentation supportedMIMETypes]): include supportedMediaMIMETypes
(+[WebHTMLRepresentation supportedMediaMIMETypes]): added

  • WebView/WebHTMLView.mm:

(+[WebHTMLView supportedMediaMIMETypes]): added

  • WebView/WebHTMLViewPrivate.h: declare -supportedMediaMIMETypes

May 23, 2015:

9:00 PM Changeset in webkit [184842] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

8:28 PM Changeset in webkit [184841] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.8

New tag.

8:21 PM Changeset in webkit [184840] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.32.2.82/Source/WebKit2

Merged r184834. rdar://problem/21090327

8:17 PM Changeset in webkit [184839] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.32.2.82/Source

Versioning.

8:15 PM Changeset in webkit [184838] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.82

New tag.

8:15 PM Changeset in webkit [184837] by Antti Koivisto
  • 5 edits in trunk

Permanent redirects should have long implicit cache lifetime
​https://bugs.webkit.org/show_bug.cgi?id=145348
Source/WebCore:

rdar://problem/20680519

Reviewed by Sam Weinig.

301 Moved Permanently response that doesn't specify explicit lifetime should have long implicit lifetime.
This matches other browsers.

  • platform/network/CacheValidation.cpp:

(WebCore::computeFreshnessLifetimeForHTTPFamily):

Give 301 Moved Permanently (and similarly semantically permanent 410 Gone) long implicit lifetime.

(WebCore::updateRedirectChainStatus):

LayoutTests:

Reviewed by Sam Weinig.

  • http/tests/cache/cache-redirections.html:
  • http/tests/cache/resources/cache-control-redirect.php:

Use less confusing name (max_age->expiration vs. max-age) and fix logic.

8:14 PM Changeset in webkit [184836] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184834. rdar://problem/21090327

8:08 PM Changeset in webkit [184835] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

7:50 PM Changeset in webkit [184834] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/21090327> /S/L/PrivateFrameworks/WebKit.framework is missing Headers and PrivateHeaders symlinks
​https://bugs.webkit.org/show_bug.cgi?id=145354

Reviewed by David Kilzer.

  • WebKit2.xcodeproj/project.pbxproj: Create Headers and PrivateHeaders symlinks alongside

the dylib symlink.

6:26 PM Changeset in webkit [184833] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Rename ShareableResource::create(Handle&) to map(Handle&) to match SharedMemory.
​https://bugs.webkit.org/show_bug.cgi?id=145288

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-05-23
Reviewed by Sam Weinig.

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::create): Deleted.

  • Shared/ShareableResource.h:
6:22 PM Changeset in webkit [184832] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Cleanup after r184796
​https://bugs.webkit.org/show_bug.cgi?id=145333

Reviewed by Alexey Proskuryakov.

No new tests because there is no behavior change.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.

2:32 PM Changeset in webkit [184831] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.7

New tag.

2:04 PM Changeset in webkit [184830] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merge patch for rdar://problem/21084541.

12:28 PM Changeset in webkit [184829] by Alan Bujtas
  • 6 edits in trunk/LayoutTests

Rebaseline after r184825. Remove artificial extra space between 2 text renderers.

Reviewed by Antti Koivisto.

  • animations/lineheight-animation-expected.txt:
  • animations/simultaneous-start-transform-expected.txt:
  • animations/width-using-ems-expected.txt:
  • fast/events/window-events-bubble-expected.txt:
  • fast/events/window-events-bubble2-expected.txt:
11:41 AM Changeset in webkit [184828] by Yusuke Suzuki
  • 80 edits
    2 copies in trunk

Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
​https://bugs.webkit.org/show_bug.cgi?id=144848

Reviewed by Darin Adler.

Source/JavaScriptCore:

Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.

  • API/JSCallbackObject.h:
  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::isPrivateName):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/ComplexGetStatus.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdStatus.h:
  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdStatus.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::visibleNameForParameter):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::addConstant):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • dfg/DFGDesiredIdentifiers.h:

(JSC::DFG::DesiredIdentifiers::operator[]):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperation):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLInlineCacheDescriptor.h:

(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::InlineCacheDescriptor::uid):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::CheckInDescriptor::CheckInDescriptor):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutById):
(JSC::FTL::LowerDFGToLLVM::compileIn):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation):
(JSC::FTL::LowerDFGToLLVM::getById):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

  • ftl/FTLSlowPathCall.cpp:

(JSC::FTL::callOperation):

  • ftl/FTLSlowPathCall.h:
  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • parser/Nodes.cpp:

(JSC::ProgramNode::setClosedVariables):

  • parser/Nodes.h:

(JSC::ScopeNode::captures):
(JSC::ScopeNode::setClosedVariables):
(JSC::ProgramNode::closedVariables):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::didFinishParsing):
(JSC::Parser<LexerType>::parseContinueStatement):

  • parser/Parser.h:

(JSC::Scope::Scope):
(JSC::Scope::pushLabel):
(JSC::Scope::getLabel):
(JSC::Scope::declareCallee):
(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(JSC::Scope::declareBoundParameter):
(JSC::Scope::useVariable):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Parser::closedVariables):
(JSC::ScopeLabelInfo::ScopeLabelInfo): Deleted.

  • parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::create):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::isPrivateName):

  • runtime/CommonIdentifiers.h:
  • runtime/Identifier.h:

(JSC::Identifier::impl):
(JSC::Identifier::Identifier):
(JSC::parseIndex):
(JSC::IdentifierRepHash::hash):

  • runtime/IdentifierInlines.h:

(JSC::Identifier::fromUid):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::mayInterceptStoreTo):

  • runtime/IntendedStructureChain.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/Lookup.h:

(JSC::HashTable::entry):

  • runtime/MapData.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertySymbols):

  • runtime/PrivateName.h:

(JSC::PrivateName::PrivateName):
(JSC::PrivateName::uid):

  • runtime/PropertyMapHashTable.h:
  • runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
(JSC::parseIndex):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::addKnownUnique):
(JSC::PropertyNameArray::add):

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::add):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):
(JSC::Structure::toStructureShape):

  • runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::Hash::hash):

  • runtime/Symbol.cpp:

(JSC::Symbol::Symbol):

  • runtime/Symbol.h:
  • runtime/SymbolConstructor.cpp:

(JSC::symbolConstructorFor):
(JSC::symbolConstructorKeyFor):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::globalTypeSetForVariable):

  • runtime/SymbolTable.h:
  • runtime/TypeSet.cpp:

(JSC::StructureShape::addProperty):
(JSC::StructureShape::propertyHash):

  • runtime/TypeSet.h:

Source/WebCore:

Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):

Source/WTF:

he current AtomicStringImpl accidentally means the symbol OR atomic StringImpl.
t's not correct to its name and it's error prone.

In this patch, we'll introduce/changes classes into WTF.

  1. UniquedStringImpl
It's derived class from StringImpl. And it represents symbol
atomic StringImpl.
  1. SymbolImpl

It's derived class from UniquedStringImpl. Only symbol strings can become this.
It ensures the given StringImpl is symbol in compile time.

  1. AtomicStringImpl

It's derived class from UniquedStringImpl. Only atomic (non-normal && non-symbol) strings can become this.
It ensures the given StringImpl is atomic in compile time.

And, in this time, I just accept UniqueStringImpl in AtomicString. As the result,

  1. Now AtomicStringImpl issue is fixed. Its SymbolImpl is separated and UniquedStringImpl is introduced.
  2. But AtomicString still have both symbol and atomic strings.

This should be solved in the separated patch.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PrintStream.cpp:
  • wtf/PrintStream.h:

(WTF::printInternal):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/AtomicStringImpl.h:
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createSymbol):
(WTF::StringImpl::createSymbolEmpty):

  • wtf/text/StringImpl.h:
  • wtf/text/SymbolImpl.h: Copied from Source/JavaScriptCore/runtime/PrivateName.h.
  • wtf/text/SymbolRegistry.cpp:

(WTF::SymbolRegistry::symbolForKey):
(WTF::SymbolRegistry::keyForSymbol):
(WTF::SymbolRegistry::remove):

  • wtf/text/SymbolRegistry.h:
  • wtf/text/UniquedStringImpl.h: Copied from Source/JavaScriptCore/runtime/PrivateName.h.

Tools:

Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:
9:21 AM Changeset in webkit [184827] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32-branch/Source

Versioning.

9:21 AM Changeset in webkit [184826] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

9:06 AM Changeset in webkit [184825] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Simple line layout: Ignore -webkit-flow-*content while collecting text content for innerText.
​https://bugs.webkit.org/show_bug.cgi?id=145344
rdar://problem/20959522

Reviewed by Antti Koivisto.

This patch ensures that when a -webkit-flow-into content is present in a simple line layout container,
we skip it while collecting the text content for innerText.
It's not always guaranteed that a simple line layout container only contains simple text nodes. In such cases,
we need to ensure that text offset computing only takes the simple text nodes into account.

Source/WebCore:

Test: fast/text/simple-line-layout-inner-text-with-flow-content.html

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):

  • editing/TextIterator.h:

LayoutTests:

  • fast/text/simple-line-layout-inner-text-with-flow-content-expected.txt: Added.
  • fast/text/simple-line-layout-inner-text-with-flow-content.html: Added.
8:07 AM Changeset in webkit [184824] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove code related with unused style classes
​https://bugs.webkit.org/show_bug.cgi?id=145332

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
The "type-string" class has no styles associated with it. So the entire span can be removed.

  • UserInterface/Views/DOMTreeElement.js:

Both of these style classes have no styles associated with them. Remove the class names.

8:03 AM Changeset in webkit [184823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve native parameter lists a bit
​https://bugs.webkit.org/show_bug.cgi?id=145338

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

  • UserInterface/Models/NativeFunctionParameters.js:
  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):

8:01 AM Changeset in webkit [184822] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update CSS Autocompletion properties and values
​https://bugs.webkit.org/show_bug.cgi?id=145341

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

  • UserInterface/Models/CSSKeywordCompletions.js:

May 22, 2015:

11:40 PM Changeset in webkit [184821] by ap@apple.com
  • 2 edits in trunk/Tools

Fix one more merge error in static analyzer support.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:

(BuildbotStaticAnalyzerQueueView):

11:31 PM Changeset in webkit [184820] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Adopt Object.setPrototypeOf
​https://bugs.webkit.org/show_bug.cgi?id=145335

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Timothy Hatcher.

For a case that won't easily move to ES6 classes use Object.setPrototypeOf.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackend.Command.create):

11:27 PM Changeset in webkit [184819] by commit-queue@webkit.org
  • 39 edits in trunk/Source/WebInspectorUI

Web Inspector: Inline use once class names and remove some unused class names
​https://bugs.webkit.org/show_bug.cgi?id=145334

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Timothy Hatcher.

  • UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView):

  • UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow):

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):

  • UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView):

  • UserInterface/Views/CompletionSuggestionsView.js:

(WebInspector.CompletionSuggestionsView):

  • UserInterface/Views/ConsolePrompt.js:

(WebInspector.ConsolePrompt):

  • UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser):

  • UserInterface/Views/ContentFlowTreeElement.js:

(WebInspector.ContentFlowTreeElement):

  • UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

  • UserInterface/Views/ContentViewContainer.js:

(WebInspector.ContentViewContainer):

  • UserInterface/Views/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView):

  • UserInterface/Views/CookieStorageTreeElement.js:

(WebInspector.CookieStorageTreeElement):

  • UserInterface/Views/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView):

  • UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView):

  • UserInterface/Views/DashboardView.js:

(WebInspector.DashboardView):

  • UserInterface/Views/DatabaseTableContentView.js:

(WebInspector.DatabaseTableContentView):

  • UserInterface/Views/DebuggerDashboardView.js:

(WebInspector.DebuggerDashboardView):
(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):

  • UserInterface/Views/DetailsSection.js:

(WebInspector.DetailsSection):

  • UserInterface/Views/DetailsSectionSimpleRow.js:
  • UserInterface/Views/FontResourceContentView.js:

(WebInspector.FontResourceContentView):
(WebInspector.FontResourceContentView.prototype.createMetricElement):
(WebInspector.FontResourceContentView.prototype.contentAvailable):

  • UserInterface/Views/HierarchicalPathComponent.js:

(WebInspector.HierarchicalPathComponent):
(WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):

  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
  • UserInterface/Views/LayoutTimelineOverviewGraph.js:

(WebInspector.LayoutTimelineOverviewGraph):

  • UserInterface/Views/NetworkTimelineOverviewGraph.js:

(WebInspector.NetworkTimelineOverviewGraph):

  • UserInterface/Views/OverviewTimelineView.js:
  • UserInterface/Views/ProbeSetDetailsSection.js:
  • UserInterface/Views/QuickConsole.js:
  • UserInterface/Views/ReplayDashboardView.js:
  • UserInterface/Views/ScriptContentView.js:

(WebInspector.ScriptContentView):

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph):

  • UserInterface/Views/TextContentView.js:

(WebInspector.TextContentView):

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):

  • UserInterface/Views/TimelineOverviewGraph.js:

(WebInspector.TimelineOverviewGraph):

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar):

  • UserInterface/Views/TimelineRecordFrame.js:

(WebInspector.TimelineRecordFrame):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView):

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):

11:04 PM Changeset in webkit [184818] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Update tests broken by MediaPlaybackRequiresUserGesture renaming.

  • media/no-autoplay-with-user-gesture-requirement.html:
  • media/video-load-require-user-gesture.html:
  • media/video-play-require-user-gesture.html:
10:50 PM Changeset in webkit [184817] by ap@apple.com
  • 2 edits in trunk/LayoutTests

New test media/accessiblity-describes-video.html is flaky.

  • platform/mac/TestExpectations: Marking as such, as suggested by Jer.
8:54 PM Changeset in webkit [184816] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Document::ensurePlugInsInjectedScript() should evaluate the injected script on its own frame.
​https://bugs.webkit.org/show_bug.cgi?id=145328

Reviewed by Jon Lee.

trac.webkit.org/r184329 fixed HTMLPlugInImageElement::didAddUserAgentShadowRoot()
to use the document's frame instead of the page's main frame. However,
Document::ensurePlugInsInjectedScript() is still evaluating the injected script on
the main frame.

As a result, HTMLPlugInImageElement::didAddUserAgentShadowRoot()'s attempt to get
the injected createOverlay function from the document frame's global object will
fail. Fixing Document::ensurePlugInsInjectedScript() to evaluating the injected
script on the document's frame fixes the issue.

No new tests.

  • dom/Document.cpp:

(WebCore::Document::ensurePlugInsInjectedScript):

7:12 PM Changeset in webkit [184815] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: DOMTree Keyboard Shortcut 'H' to toggle element visibility is not working
​https://bugs.webkit.org/show_bug.cgi?id=145331

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Brian Burg.

We no longer have CSSProperty.value setters. Instead of attempting
to toggle and clobber inline style values on the element we:

  1. inject a <style> on the page like ".WebInspectorHide { visibility:hidden }"
  2. toggle the WebInspectorHide class on the selected element

This approach is inspired by the original WebKit change in the
old inspector frontend: <​https://webkit.org/b/110641>.

The old approach toggled a few properties (opacity and pointer events)
while the new approach uses visibility, matching other browsers.

  • UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode.injectStyleAndToggleClass):
(WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode):
(WebInspector.DOMTreeOutline.prototype._hideElement):
(WebInspector.DOMTreeOutline.prototype._hideElement.toggleProperties): Deleted.

7:11 PM Changeset in webkit [184814] by eric.carlson@apple.com
  • 10 edits in trunk/Source/WebCore

MediaPlayer doesn't need isPlayingToWirelessPlaybackTarget and isCurrentPlaybackTargetWireless
​https://bugs.webkit.org/show_bug.cgi?id=145325

Reviewed by Brent Fulgham.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless): Call isCurrentPlaybackTargetWireless
directly.
(WebCore::HTMLMediaElement::wirelessRoutesAvailableDidChange): Ditto.
(WebCore::HTMLMediaElement::isPlayingToWirelessPlaybackTarget): Ditto.
(WebCore::HTMLMediaElement::mediaState): Ditto.

  • html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::currentPlaybackTargetIsWireless): Deleted.

  • html/HTMLMediaSession.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::isPlayingToWirelessPlaybackTarget): Deleted.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::isPlayingToWirelessPlaybackTarget): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::isPlayingToWirelessPlaybackTarget): Deleted.

  • platform/ios/WebVideoFullscreenModelVideoElement.mm:

(WebVideoFullscreenModelVideoElement::updateForEventName): Call webkitCurrentPlaybackTargetIsWireless.

6:57 PM Changeset in webkit [184813] by jonlee@apple.com
  • 22 edits in trunk/Source

Rename MediaPlaybackAllowsInline
​https://bugs.webkit.org/show_bug.cgi?id=145315

Reviewed by Eric Carlson.

Our API uses allowsInlineMediaPlayback. Our symbols should reflect the same.

Source/WebCore:

  • page/Settings.cpp: Update the static variable name as well as the setting.
  • page/Settings.in: Ditto.
  • Modules/mediacontrols/MediaControlsHost.idl: Rename to allowsInlineMediaPlayback.

Affects the media controls code.

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::allowsInlineMediaPlayback):
(WebCore::MediaControlsHost::mediaPlaybackAllowsInline): Deleted.

Update to use the new name in the media controls.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.shouldHaveControls):

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.shouldHaveStartPlaybackButton):

  • css/MediaQueryEvaluator.cpp:

(WebCore::video_playable_inlineMediaFeatureEval):

  • html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::requiresFullscreenForVideoPlayback):

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its

value, for backwards compatibility.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Update the symbol.
(-[WebPreferences mediaPlaybackAllowsInline]): Ditto. This setting will not
be renamed in a future patch.
(-[WebPreferences setMediaPlaybackAllowsInline:]): Ditto.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Update the call to settings.

Source/WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged): Use the new name.

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMediaPlaybackAllowsInline): Update the call to preferences.
The C API will not change in a future patch.
(WKPreferencesGetMediaPlaybackAllowsInline): Ditto.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): Update the name of the key.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Ditto.

  • UIProcess/API/gtk/WebKitSettings.cpp: Update the call.

(webkit_settings_get_media_playback_allows_inline):
(webkit_settings_set_media_playback_allows_inline):

6:57 PM Changeset in webkit [184812] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.6

New tag.

6:55 PM Changeset in webkit [184811] by jonlee@apple.com
  • 13 edits in trunk/Source

Rename MediaPlaybackAllowsAirPlay
​https://bugs.webkit.org/show_bug.cgi?id=145316

Reviewed by Eric Carlson.

In preparation for an API rename, update internal symbols from mediaPlaybackAllowsAirPlay
to allowsAirPlayForMediaPlayback.

Source/WebCore:

  • page/Settings.in: Update the setting name.
  • html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Update the call to settings.

  • testing/InternalSettings.h: Update the name of the member variable.
  • testing/InternalSettings.cpp: Update the names and calls to settings.

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::resetToConsistentState):
(WebCore::InternalSettings::setWirelessPlaybackDisabled):

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: Update the name but keep its value, for backwards

compatibility.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Update to reference the new key name.
(-[WebPreferences mediaPlaybackAllowsAirPlay]): Ditto. This API will not change in a future
patch.
(-[WebPreferences setMediaPlaybackAllowsAirPlay:]): Ditto.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Update the call to settings.

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h: Update the name.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the call to settings.

6:15 PM Changeset in webkit [184810] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix for Windows.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

5:54 PM Changeset in webkit [184809] by dburkart@apple.com
  • 2 edits in trunk/Tools

Fix internal dashboard breakage from recent commit.
​https://bugs.webkit.org/show_bug.cgi?id=144814

Unreviewed build fix.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:

(BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
(BuildbotStaticAnalyzerQueueView.prototype.update):

5:38 PM Changeset in webkit [184808] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.6

New tag.

5:26 PM Changeset in webkit [184807] by ap@apple.com
  • 3 edits in trunk/Tools

REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
​https://bugs.webkit.org/show_bug.cgi?id=130463
rdar://problem/20461342

Reviewed by Tim Horton.

This was more of a timing related flakiness than an actual OS version specific bug,
we weren't getting window visibility notifications.

I will look into adding this function call to DumpRenderTree separately, layout tests
might actually rely on the broken behavior.

  • TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/mac/mainMac.mm:

(main):

5:25 PM Changeset in webkit [184806] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Show results and status before revisions for A/B testing results
​https://bugs.webkit.org/show_bug.cgi?id=145327

Reviewed by Chris Dumez.

Place the results and the status columns before the columns for revisions.
Also show the absolute difference as well as the relative difference between the averages of A and B.

  • public/v2/app.js:

(App.TestGroupPane._populate):
(App.TestGroupPane._computeStatisticalSignificance):

  • public/v2/index.html:
5:19 PM Changeset in webkit [184805] by dburkart@apple.com
  • 1 edit
    1 add in trunk/Tools

Add missing file from r184804 (mis-applied diff).
​https://bugs.webkit.org/show_bug.cgi?id=144814

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.

(BuildbotStaticAnalyzerQueueView):
(BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
(BuildbotStaticAnalyzerQueueView.prototype.update):

5:11 PM Changeset in webkit [184804] by dburkart@apple.com
  • 6 edits in trunk/Tools

Add support to the botwatchers dashboard for a static analyzer bot.
​https://bugs.webkit.org/show_bug.cgi?id=144814

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

scan-build should be considered a productive step.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue):
Adds support for the staticAnalyzer property

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults.prototype._parseResults):
Get bug count from the scan-build step output

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady):
Rename the performance column 'Other', and merge the current 'Other' column with it.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):
Now that performance bots are part of the 'Other' column, give them better headings.

4:57 PM Changeset in webkit [184803] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK fix after r184802.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_get_media_playback_requires_user_gesture):
(webkit_settings_set_media_playback_requires_user_gesture):

4:56 PM Changeset in webkit [184802] by jonlee@apple.com
  • 14 edits in trunk/Source

Rename MediaPlaybackRequiresUserGesture
​https://bugs.webkit.org/show_bug.cgi?id=145314

Reviewed by Anders Carlsson.

In preparation for an API rename, update internal symbols from mediaPlaybackRequiresUserGesture
to requiresUserGestureForMediaPlayback.

Source/WebCore:

  • page/Settings.cpp: update static const default variable name.
  • page/Settings.in: update the setting name and static const default variable name.
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::constructCommon): Update settings call.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Ditto.

Source/WebKit/mac:

No changes are being made to the API in this patch.

  • WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its value, for backwards

compatibility.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Update the symbol.
(-[WebPreferences mediaPlaybackRequiresUserGesture]): Ditto. This setting will not be renamed
in a future patch.
(-[WebPreferences setMediaPlaybackRequiresUserGesture:]): Ditto.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Update the call to settings.

Source/WebKit2:

No changes are being made to the API in this patch.

  • Shared/WebPreferencesDefinitions.h: Update the name of the macro and the setting.
  • UIProcess/API/C/WKPreferences.cpp: The C API will not change in a future patch.

(WKPreferencesSetMediaPlaybackRequiresUserGesture): Update the call to preferences.
(WKPreferencesGetMediaPlaybackRequiresUserGesture): Ditto.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): Update the name of the key.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Ditto.

4:44 PM Changeset in webkit [184801] by jdiggs@igalia.com
  • 2 edits in trunk/Source/WebCore

AX: Figure out why list-detection2.html test fails on GTK
​https://bugs.webkit.org/show_bug.cgi?id=145273

Reviewed by Chris Fleizach.

Only consider the text under the pseudo element for GTK and EFL.
The other platforms expose rendered text content through their
own accessible objects. This will fix the crash on Windows until
it can be looked into properly.

No new tests. This should stop list-detection2.html to stop crashing on Windows.

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):

4:29 PM Changeset in webkit [184800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r183647.
​https://bugs.webkit.org/show_bug.cgi?id=145326

broke some toolbar blurring behavior (Requested by thorton on
#webkit).

Reverted changeset:

"Asynchronous (or timed-out synchronous) resize flashes white
instead of page background color"
​https://bugs.webkit.org/show_bug.cgi?id=144468
​http://trac.webkit.org/changeset/183647

4:15 PM Changeset in webkit [184799] by jer.noble@apple.com
  • 24 edits
    9 adds in trunk

[Mac] Audio tracks tagged as 'describes-video' are not automatically selected when that system accessibility option is set.
​https://bugs.webkit.org/show_bug.cgi?id=145228

Reviewed by Eric Carlson.

Source/WebCore:

Tests: http/tests/media/hls/hls-accessiblity-describes-video.html

media/accessiblity-describes-video.html

Add support to CaptionUserPreferences to return the user's preferred audio characteristics,
including "public.accessibility.describes-video". When the media accessibility options change,
trigger the HTMLMediaElement to update the list of tracks, and chose a new audio track if
appropriate. Manually filter those tracks matching the requested characteristics in
MediaSelectionGroupAVFObjC. Allow these characteristics to be overrided by Internals for
testing purposes.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::captionPreferencesChanged): Call tracksChanged().
(WebCore::HTMLMediaElement::mediaPlayerPreferredAudioCharacteristics): Pass through to the page's caption preferences.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::setPreferredAudioCharacteristic): Simple setter.
(WebCore::CaptionUserPreferences::preferredAudioCharacteristics): Simple getter.

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::~CaptionUserPreferencesMediaAF): Unregister for audio characteristics change notifications.
(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): Register for same.
(WebCore::CaptionUserPreferencesMediaAF::setPreferredAudioCharacteristic): If in testing mode, pass to superclass; otherwise no-op.
(WebCore::CaptionUserPreferencesMediaAF::preferredAudioCharacteristics): If in testing mode, pass to superclass;

otherwise, ask the media accessibility framework.

  • page/CaptionUserPreferencesMediaAF.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::tracksChanged): Pass through to m_private.
(WebCore::MediaPlayer::preferredAudioCharacteristics): Pass through to HTMLMediaElement.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerPreferredAudioCharacteristics): Added; return empty vector by default.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::tracksChanged): Added; no-op by default.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::create): Added characteristics parameter.
(WebCore::MediaSelectionGroupAVFObjC::MediaSelectionGroupAVFObjC): Ditto.
(WebCore::MediaSelectionGroupAVFObjC::updateOptions): Add an additional filter against the

passed-in characteristics.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::determineChangedTracksFromNewTracksAndOldItems): Pass the characteristics to the media selection group.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass in the user's preferred characteristics.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Pass in an empty vector.

  • testing/Internals.cpp:

(WebCore::Internals::userPreferredAudioCharacteristics): Added; return the current setting.
(WebCore::Internals::setUserPreferredAudioCharacteristic): Added; pass through to CaptionUserPreferences.

  • testing/Internals.h:
  • testing/Internals.idl:

Add soft link macros which account for a possible failure to look up constants.

  • platform/cf/MediaAccessibilitySoftLink.cpp:
  • platform/cf/MediaAccessibilitySoftLink.h:
  • platform/mac/SoftLinking.h:
  • platform/win/SoftLinking.h:

LayoutTests:

  • http/tests/media/hls/hls-accessiblity-describes-video-expected.txt: Added.
  • http/tests/media/hls/hls-accessiblity-describes-video.html: Added.
  • http/tests/media/resources/hls/audio-describes-video.m3u8: Added.
  • http/tests/media/resources/hls/english/description.aac: Added.
  • http/tests/media/resources/hls/english/description.m3u8: Added.
  • media/accessiblity-describes-video-expected.txt: Added.
  • media/accessiblity-describes-video.html: Added.
  • media/content/audio-describes-video.mp4: Added.
  • platform/mac-mavericks/TestExpectations:
3:52 PM Changeset in webkit [184798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Image link doesn't create a preview view controller.
​https://bugs.webkit.org/show_bug.cgi?id=145320

Also try to create the preview view controller if the hit-tested node
is a image link.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2015-05-22
Reviewed by Beth Dakin.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView previewViewControllerForPosition:inSourceView:]):

2:48 PM Changeset in webkit [184797] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Avoid doing an extra layout in some cases while doing scale-to-fit
​https://bugs.webkit.org/show_bug.cgi?id=145321
<rdar://problem/21051165>

Reviewed by Beth Dakin.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
If we make it to scaleViewToFitDocumentIfNeeded with valid layout,
the view width is still less than the last-known minimum document size,
and the document size hasn't changed, update the view scale without
doing an extra layout, keeping the fixed layout size at the previously
computed minimum document size.

2:43 PM Changeset in webkit [184796] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] Use CTFontDrawGlyphs() instead of CGContextShowGlyphsWithAdvances()/CGContextShowGlyphsAtPositions()
​https://bugs.webkit.org/show_bug.cgi?id=145234

Reviewed by Enrica Casucci.

Eventually, we want to migrate entirely off of text-related CoreGraphics calls
and onto CoreText calls (in order to reduce complexity as well as eventually
removing the need for FontPlatformData to hold a CGFontRef). There is an
equivalent call to CGContextShowGlyphsWithAdvances() and
CGContextShowGlyphsAtPositions(), namely, CTFontDrawGlyphs(), which we have
found is as performant as its CoreGraphics counterparts. This patch simply
migrates these two CG calls to its CT counterpart.

Performance was measured on a iPhone 4s as well as a Mid 2010 Mac Pro.

No new tests because there is no behavior change.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::showGlyphsWithAdvances):
(WebCore::FontCascade::drawGlyphs):

2:23 PM Changeset in webkit [184795] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Build fix after r184774.

2:01 PM Changeset in webkit [184794] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Don't show default controls after playing to wireless target
​https://bugs.webkit.org/show_bug.cgi?id=145317

Reviewed by Dean Jackson.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handlePanelTransitionEnd): Don't show controls unless the video
element has the 'controls' attribute.
(Controller.prototype.setPlaying): Check this.video.controls directly because we never want
to show controls unless the attribute is present.
(Controller.prototype.showControls): Ditto.
(Controller.prototype.updateWirelessPlaybackStatus): Call reconnectControls.
(Controller.prototype.handleWirelessPlaybackChange): Don't call reconnectControls, it will
happen in updateWirelessPlaybackStatus.
(Controller.prototype.showInlinePlaybackPlaceholderOnly): Deleted.

1:47 PM Changeset in webkit [184793] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

[CG] Regression(r78652): Partially decoded images are not properly removed from MemoryCache when pruning
​https://bugs.webkit.org/show_bug.cgi?id=145310

Reviewed by Antti Koivisto.

r78652 added partially decoded images to the MemoryCache's list of live
decoded resources so that they can be pruned on memory pressure. This
was needed because CG decodes part of the image to determine its
properties (e.g. its size). On memory pressure, we call
BitmapImage::destroyDecodedData() which clears the ImageSource and
frees up this extra decoded data.

However, we would fail to remove such partially decoded images from the
MemoryCache's list of live resources when pruning. This is because
BitmapImage::destroyMetadataAndNotify() fails to take into account the
decoded properties size when no frame has been cleared. We would thus
fail to detect a decoded size change and not call
CachedImage::decodedSizeChanged(). As a result, the CachedImage's
decoded size is not reset to 0 and we don't remove it from live decoded
resources.

This patch updates BitmapImage::destroyMetadataAndNotify() to account
for m_decodedPropertiesSize even if frameBytesCleared is 0. This way,
images for which we have't decoded any frames yet will correctly report
that we cleared the decoded data used to determine the image properties
and their decoded size will be properly reset to 0. As a result, these
will be removed from the MemoryCache's list of live decoded resources.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::destroyMetadataAndNotify):
(WebCore::BitmapImage::dataChanged):

  • platform/graphics/BitmapImage.h:
1:31 PM Changeset in webkit [184792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Unable to get cursor in new Rule section after creating multiple New Rules
​https://bugs.webkit.org/show_bug.cgi?id=145294

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Timothy Hatcher.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ensureParsedDataReady):
Allow stylesheets with mutations for the inspector stylesheet
which we control mutations of.

1:30 PM Changeset in webkit [184791] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Turn on autosaving of toolbar configuration in MiniBrowser

Rubber-stamped by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindow.xib:
1:23 PM Changeset in webkit [184790] by Beth Dakin
  • 3 edits in trunk/Source/WebKit2

Yellow highlight and DD popover don't go away when scrolling an iframe
​https://bugs.webkit.org/show_bug.cgi?id=145312
-and corresponding-
rdar://problem/19692334

Reviewed by Tim Horton.

Match what Lookup already does for their popover and dismiss our popovers on
scroll.

  • UIProcess/API/mac/WKView.mm:

(-[WKView scrollWheel:]):

This should not be needed anymore.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::pageDidScroll):

1:00 PM Changeset in webkit [184789] by bshafiei@apple.com
  • 7 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184774. rdar://problem/21033029

12:14 PM Changeset in webkit [184788] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] Device picker menu should be persistent
​https://bugs.webkit.org/show_bug.cgi?id=145311

Reviewed by Brent Fulgham.

  • Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::addPlaybackTargetPickerClient): Add logging.
(WebCore::WebMediaSessionManager::removePlaybackTargetPickerClient): Ditto.
(WebCore::WebMediaSessionManager::removeAllPlaybackTargetPickerClients): Ditto.
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Ditto.
(WebCore::WebMediaSessionManager::clientStateDidChange): Ditto.
(WebCore::WebMediaSessionManager::externalOutputDeviceAvailableDidChange): Ditto.
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring): Ditto.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaState): Don't set ExternalDeviceAutoPlayCandidate unless
there is an event listener.

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac): Release the menu
controller and remove observers.
(WebCore::MediaPlaybackTargetPickerMac::create): Add logging.
(WebCore::MediaPlaybackTargetPickerMac::pendingActionTimerFired): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::availableDevicesDidChange): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::devicePicker): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::addPendingAction): Start the timer after
a brief pause to debounce multiple identical notifications.
(WebCore::MediaPlaybackTargetPickerMac::currentDeviceDidChange): Add logging.
(WebCore::MediaPlaybackTargetPickerMac::startingMonitoringPlaybackTargets): Add logging.
(WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets): Don't release
the menu controller delegate.
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Add logging.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget): Update logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget): Ditto.

12:11 PM Changeset in webkit [184787] by bshafiei@apple.com
  • 4 edits
    3 copies in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merged r184781. rdar://problem/21030149

12:11 PM Changeset in webkit [184786] by bshafiei@apple.com
  • 4 edits
    3 copies in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merged r184781. rdar://problem/21030149

12:05 PM Changeset in webkit [184785] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184692. rdar://problem/20967937

12:03 PM Changeset in webkit [184784] by ap@apple.com
  • 7 edits in trunk/Tools

build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
​https://bugs.webkit.org/show_bug.cgi?id=145297

Reviewed by Tim Horton.

This is a refactoring to simplify code, and to make it more logical.

It is up to the view to decide how to present the queues, and whether to split
them into debug and release, or in some different way.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:

(BuildbotBuilderQueueView.filterQueues):
(BuildbotBuilderQueueView):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:

(BuildbotLeaksQueueView):
(BuildbotLeaksQueueView.prototype.update):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:

(BuildbotPerformanceQueueView):
(BuildbotPerformanceQueueView.prototype.update):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView):
(BuildbotQueueView.prototype._updateQueues):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady):

11:57 AM Changeset in webkit [184783] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix. Added a platform ifdef.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::isUserInitiatedKey):

11:54 AM Changeset in webkit [184782] by bshafiei@apple.com
  • 3 edits in tags/Safari-601.1.32.2.81/Source/JavaScriptCore

Merged r184581. rdar://problem/20968297

11:48 AM Changeset in webkit [184781] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk/Source/JavaScriptCore

Arguments elimination phase mishandles arity check failure in its reduction of LoadVarargs to GetStack/PutStacks
​https://bugs.webkit.org/show_bug.cgi?id=145298

Reviewed by Geoffrey Garen.

  • dfg/DFGArgumentsEliminationPhase.cpp: Fix the bug. I restructured the loop to make it more obvious that we're initializing everything that we're supposed to initialize.
  • dfg/DFGNode.h: Add a comment to clarify something I was confused about while writing this code.
  • dfg/DFGPutStackSinkingPhase.cpp: Hacking on PutStacks made me think deep thoughts, and I added some FIXMEs.
  • tests/stress/fold-load-varargs-arity-check-fail-barely.js: Added. This test crashes or fails before this patch.
  • tests/stress/fold-load-varargs-arity-check-fail.js: Added. This is even more sure to crash or fail.
  • tests/stress/simplify-varargs-mandatory-minimum-smaller-than-limit.js: Added. Not sure if we had coverage for this case before.
11:43 AM Changeset in webkit [184780] by timothy_horton@apple.com
  • 44 edits
    10 deletes in trunk

Remove action menu support
​https://bugs.webkit.org/show_bug.cgi?id=145305
<rdar://problem/21070771>

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/spi/mac/NSMenuSPI.h:
  • platform/spi/mac/NSViewSPI.h: Removed.

Remove some SPI.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
  • TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.

Remove the tests.

  • WebKit.xcodeproj/project.pbxproj:

Remove some files.

  • Configurations/WebKitLegacy.xcconfig:
  • WebView/WebActionMenuController.h: Removed.
  • WebView/WebActionMenuController.mm: Removed.
  • WebView/WebHTMLView.mm:

(-[WebHTMLView otherMouseDown:]):
(-[WebHTMLView scrollWheel:scrollWheel:]): Deleted.
(-[WebHTMLView mouseDown:mouseDown:]): Deleted.

  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Deleted.
(-[WebView _close]): Deleted.
(-[WebView prepareForMenu:withEvent:]): Deleted.
(-[WebView willOpenMenu:withEvent:]): Deleted.
(-[WebView didCloseMenu:withEvent:]): Deleted.
(-[WebView _actionMenuController]): Deleted.

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]): Deleted.

  • WebView/WebViewInternal.h:

Remove everything, except some enums that clients still refer to.

  • Configurations/WebKit.xcconfig:
  • Shared/API/c/WKActionMenuItemTypes.h:
  • Shared/API/c/WKActionMenuTypes.h:
  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKView dealloc]): Deleted.
(-[WKView mouseDown:]): Deleted.
(-[WKView initWithFrame:processPool:configuration:webView:]): Deleted.
(-[WKView prepareForMenu:withEvent:]): Deleted.
(-[WKView willOpenMenu:withEvent:]): Deleted.
(-[WKView didCloseMenu:withEvent:]): Deleted.
(-[WKView _didPerformActionMenuHitTest:forImmediateAction:contentPreventsDefault:userData:]): Deleted.
(-[WKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:]): Deleted.
(-[WKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]): Deleted.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performImmediateActionHitTestAtLocation):
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):
(WebKit::WebPageProxy::performActionMenuHitTestAtLocation): Deleted.
(WebKit::WebPageProxy::selectLastActionMenuRange): Deleted.
(WebKit::WebPageProxy::focusAndSelectLastActionMenuHitTestResult): Deleted.
(WebKit::WebPageProxy::didPerformActionMenuHitTest): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformImmediateActionHitTest):
(WebKit::PageClientImpl::didPerformActionMenuHitTest): Deleted.

  • UIProcess/mac/WKActionMenuController.h: Removed.
  • UIProcess/mac/WKActionMenuController.mm: Removed.
  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
(-[WKImmediateActionController didPerformActionMenuHitTest:contentPreventsDefault:userData:]): Deleted.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h:

(API::InjectedBundle::PageContextMenuClient::prepareForImmediateAction):
(API::InjectedBundle::PageContextMenuClient::prepareForActionMenu): Deleted.

  • WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::prepareForImmediateAction):
(WebKit::InjectedBundlePageContextMenuClient::prepareForActionMenu): Deleted.

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/WebPageOverlay.cpp:

(WebKit::WebPageOverlay::actionContextForResultAtPoint):

  • WebProcess/WebPage/WebPageOverlay.h:

(WebKit::WebPageOverlay::Client::actionContextForResultAtPoint):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::textIndicatorTransitionForImmediateAction):
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
(WebKit::textIndicatorTransitionForActionMenu): Deleted.
(WebKit::WebPage::performActionMenuHitTestAtLocation): Deleted.
(WebKit::WebPage::selectLastActionMenuRange): Deleted.
(WebKit::WebPage::focusAndSelectLastActionMenuHitTestResult): Deleted.
Remove everything, except some enums that clients still refer to.
Also, leave SPI that used to be shared between immediate actions and
action menus intact, even if it had "action menu" in the name. We can
deprecate and rename in another patch... except for the very recently-added
support from r184106, which we'll revert entirely, removing WKBundlePageOverlayV2,
which was not adopted by any clients.

10:41 AM Changeset in webkit [184779] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

MaskImageOperation code does not manage CachedImageClients correctly
​https://bugs.webkit.org/show_bug.cgi?id=145276
rdar://problem/20959822

  • rendering/RenderLayerMaskImageInfo.cpp:

(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):

Followup fix: clear m_maskImageOperations vector.

10:36 AM Changeset in webkit [184778] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184773. rdar://problem/20830673

10:34 AM Changeset in webkit [184777] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.32.2.81/Source/WebKit2

Merged r184773. rdar://problem/20830673

10:24 AM Changeset in webkit [184776] by basile_clement@apple.com
  • 13 edits
    4 adds in trunk

Allow DFGClobberize to return non-node constants that must be later created
​https://bugs.webkit.org/show_bug.cgi?id=145272

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This adds a new LazyNode class in DFG that represents either a Node*,
or a FrozenValue* with a way to convert it to a Node* provided a block
to insert it into. DFGClobberize is converted to use LazyNode instead
of Node* when def()'ing values, which allows to now define the array's
length as well as the value of its various fields in NewArray and
NewArrayBuffer nodes.

We also introduce a Vector<uint32_t> in DFG::Graph to collect all the
values that can be used as index, in order to avoid def()'ing too many
values at once for big NewArrayBuffers.

HeapLocation had to be updated to use a LazyNode as its index to be
able to define array values.

(JSC::DFG::clobberize):
(JSC::DFG::DefMethodClobberize::operator()):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::freezeFragile):

  • dfg/DFGGraph.h:
  • dfg/DFGHeapLocation.h:

(JSC::DFG::HeapLocation::HeapLocation):
(JSC::DFG::HeapLocation::index):
(JSC::DFG::HeapLocation::hash):

  • dfg/DFGLazyNode.cpp: Added.

(JSC::DFG::LazyNode::dump):

  • dfg/DFGLazyNode.h: Added.

(JSC::DFG::LazyNode::LazyNode):
(JSC::DFG::LazyNode::setNode):
(JSC::DFG::LazyNode::isHashTableDeletedValue):
(JSC::DFG::LazyNode::isNode):
(JSC::DFG::LazyNode::op):
(JSC::DFG::LazyNode::asNode):
(JSC::DFG::LazyNode::asValue):
(JSC::DFG::LazyNode::hash):
(JSC::DFG::LazyNode::operator==):
(JSC::DFG::LazyNode::operator!=):
(JSC::DFG::LazyNode::ensureIsNode):
(JSC::DFG::LazyNode::operator->):
(JSC::DFG::LazyNode::operator*):
(JSC::DFG::LazyNode::operator!):
(JSC::DFG::LazyNode::operator UnspecifiedBoolType*):
(JSC::DFG::LazyNode::setFrozenValue):

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::def):

  • dfg/DFGPutStackSinkingPhase.cpp:

LayoutTests:

  • js/regress/script-tests/cse-new-array-buffer.js: Added.

(foo):

  • js/regress/script-tests/cse-new-array.js: Added.

(foo):

10:24 AM Changeset in webkit [184775] by beidson@apple.com
  • 10 edits in trunk/Source

Rework how the ResourceRequest user initiated property key is used.
Followup to ​https://bugs.webkit.org/show_bug.cgi?id=145281
Source/WebCore:

Reviewed by NOBODY (OOPS!).

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::isUserInitiatedKey):

  • platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

Source/WebKit/mac:

Reviewed by NOBODY (OOPS!).

  • WebCoreSupport/WebSystemInterface.mm:

(WKResourceRequestIsUserInitiatedKey): Deleted.
(InitWebCoreSystemInterface): Deleted.

Source/WebKit2:

Reviewed by NOBODY (OOPS!).

  • Shared/API/Cocoa/_WKNSURLRequestExtras.mm:

(-[NSURLRequest _web_isUserInitiated]):
(-[NSMutableURLRequest _web_setIsUserInitiated:]):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(WKResourceRequestIsUserInitiatedKey): Deleted.
(InitWebCoreSystemInterface): Deleted.

10:19 AM Changeset in webkit [184774] by barraclough@apple.com
  • 7 edits in trunk/Source/WebKit2

Networking process sometimes suspended while WebContent runnable
​https://bugs.webkit.org/show_bug.cgi?id=145291
<rdar://problem/21033029>

Reviewed by Andreas Kling.

There is an asymmetry in how the Networking process suspension is managed.
We drop the assertion (& suspend the process) whenever the WebProcess says
it is ready to suspend, but we only take the assertion (& resume execution)
when the WebContent process is actually resumed. This leaves a race – where
the WebContent process was willing to be suspended, but the UI app changed
its mind suspending it. Since the WebContent process never actually suspended
(we only prepared it to), we never send a resume, and since we never resume,
we never wake the Networking process.

The fix is pretty clean. A web process should take a token on the networking
process precisely whenever it holds an assertion on the web content process.
This also enables a nice refinement, that when holding a BG assertion on the
WebContent process we only need to hold a BG assertion on the networking
process.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didSetAssertionState):

  • no-op
  • UIProcess/Network/NetworkProcessProxy.h:
    • added didSetAssertionState.
  • UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertionNow):
(WebKit::ProcessThrottler::updateAssertion):
(WebKit::ProcessThrottler::didConnectToProcess):

  • whenever taking/updating the assertion, inform the client via didSetAssertionState.
  • UIProcess/ProcessThrottlerClient.h:
    • added didSetAssertionState.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):

removed initializeNetworkProcessActivityToken - this is taken via ProcessThrottler::didConnectToProcess.

(WebKit::WebProcessProxy::sendProcessDidResume):

  • removed call to initializeNetworkProcessActivityToken - updated via didSetAssertionState.

(WebKit::WebProcessProxy::processReadyToSuspend):

  • removed update of m_tokenForNetworkProcess - updated via didSetAssertionState.

(WebKit::WebProcessProxy::didSetAssertionState):

  • update m_backgroundTokenForNetworkProcess/m_foregroundTokenForNetworkProcess.

(WebKit::WebProcessProxy::initializeNetworkProcessActivityToken): Deleted.

  • updated via didSetAssertionState.
  • UIProcess/WebProcessProxy.h:
    • added didSetAssertionState, added separate FG/BG activity tokens for Networking process.
10:09 AM Changeset in webkit [184773] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed the fix for <rdar://problem/20830673> Symlink the WebKit dylib instead of just the framework directory
​https://bugs.webkit.org/show_bug.cgi?id=145287

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Give the symlink the correct destination.
10:04 AM Changeset in webkit [184772] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.32.2.81/Source

Versioning.

10:02 AM Changeset in webkit [184771] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.81

New tag.

9:31 AM Changeset in webkit [184770] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Unreviewed build fix for ENABLE(TREE_DEBUGGING)

  • editing/VisibleSelection.h:
  • html/parser/HTMLElementStack.h:
  • html/parser/HTMLFormattingElementList.h:
8:52 AM Changeset in webkit [184769] by mitz@apple.com
  • 2 edits in trunk/Tools

Removed the Use Shrink To Fit button from the toolbar’s default set.

Rubber-stamped by Tim Horton.

  • MiniBrowser/mac/BrowserWindow.xib:
4:36 AM Changeset in webkit [184768] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Gardening 21st May.
​https://bugs.webkit.org/show_bug.cgi?id=145250

Unreviewed.

Patch by Marcos Chavarría Teijeiro <​mchavarria@igalia.com> on 2015-05-22

  • platform/gtk/TestExpectations:
3:18 AM Changeset in webkit [184767] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] Speed up new array construction in Array.prototype.splice().
<​https://webkit.org/b/145303>

Reviewed by Benjamin Poulain.

Give splice() a fast path just like slice(), for indexing types where the backing
store can be memcpy'd. I generalized JSArray::fastSlice() a little bit so it works
for this optimization as well.

7% progression on Kraken/stanford-crypto-pbkdf2.

  • runtime/JSArray.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::fastSlice): Tweak this to return JSArray*, and don't bother throwing
out-of-memory exceptions. Let the caller worry about that.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSlice): Update for fastSlice() changes.
(JSC::arrayProtoFuncSplice): If the object we're splicing out of is a bona fide
JSArray, use fastSlice() to create the returned array instead of doing a generic
get/put loop.

1:15 AM Changeset in webkit [184766] by berto@igalia.com
  • 1 edit
    1 add in trunk/Source/WebCore/platform/gtk/po

[l10n] Add Catalan translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=142928

Patch by Jordi Mas <​jmas@softcatala.org> on 2015-05-22
Reviewed by Carlos Garcia Campos.

  • ca.po: Added.
1:03 AM Changeset in webkit [184765] by jdiggs@igalia.com
  • 4 edits in trunk

AX: Figure out why list-detection2.html test fails on GTK
​https://bugs.webkit.org/show_bug.cgi?id=145273

Reviewed by Chris Fleizach.

Source/WebCore:

Platforms which expose rendered text content through the parent element "ignore" the
child renderers. This was causing AccessibilityList::childHasPseudoVisibleListItemMarker
to fail, which in turn caused the list detection heuristic to fail. Therefore add one
final check to this method to look for non-empty, non-whitespace text under the ::before
pseudo element.

No new tests; list-detection2.html now passes on GTK.

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):

LayoutTests:

  • platform/gtk/TestExpectations: Removed list-detection2.html from the list of expected failures.
1:01 AM Changeset in webkit [184764] by bshafiei@apple.com
  • 9 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merged r184760. rdar://problem/21064692

1:00 AM Changeset in webkit [184763] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit/mac

Merged r184678.

12:59 AM Changeset in webkit [184762] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit/mac

Merged r184674.

12:59 AM Changeset in webkit [184761] by bshafiei@apple.com
  • 29 edits
    2 copies in branches/safari-601.1.32.2-branch/Source

Merged r184670.

May 21, 2015:

11:57 PM Changeset in webkit [184760] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

[iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=145289

Reviewed by Eric Carlson.

AVFoundation would normally already know that its AVPlayerLayer is in optimized
fullscreen mode, but because of the WebProcess/UIProcess split, they need to be
told explicitly in the WebProcess when the UIProcess enters optimized fullscreen
mode.

  • html/HTMLMediaElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::fullscreenModeChanged): Pass to private().

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVideoFullscreenMode): Pass to m_private.
(WebCore::MediaPlayer::fullscreenMode): Pass to m_client.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerFullscreenMode): Default implementation returns None.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenMode): Default implementation is a no-op.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Get the fullscreen

mode from MediaPlayer and tell the AVPlayerLayer if the mode is optimized.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):

Ditto.

  • platform/spi/mac/AVFoundationSPI.h:
11:36 PM Changeset in webkit [184759] by bshafiei@apple.com
  • 15 edits in branches/safari-601.1.32.2-branch/Source

Merged r184740. rdar://problem/21068522

11:35 PM Changeset in webkit [184758] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184739. rdar://problem/20892362

11:35 PM Changeset in webkit [184757] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184738. rdar://problem/20830673

11:34 PM Changeset in webkit [184756] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184726. rdar://problem/21031414

11:32 PM Changeset in webkit [184755] by fpizlo@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

CPS rethreading should really get rid of GetLocals
​https://bugs.webkit.org/show_bug.cgi?id=145290

Reviewed by Benjamin Poulain.

CPS rethreading is intended to get rid of redundant GetLocals. CSE can also do it, but
the idea is that you should be able to disable CSE and everything would still work. This
fixes a bug in CPS rethreading's GetLocal elimination: we should be calling replaceWith
rather than setReplacement, since setReplacement still leaves the original node.

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor): Fix the bug.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Eliminating GetLocals means that they turn into Check. We should handle Checks that have zero inputs.

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS): Add a validation for what a GetLocal should look like in ThreadedCPS.

  • tests/stress/get-local-elimination.js: Added.

(foo):

11:12 PM Changeset in webkit [184754] by jdiggs@igalia.com
  • 15 edits
    3 adds in trunk

AX: [GTK] Implement computedRoleString in AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=128420

Reviewed by Chris Fleizach.

Source/WebCore:

Expose all ARIA roles (not just landmark-related roles) via an "xml-roles" AtkObject
attribute as per ​http://www.w3.org/TR/core-aam-1.1/#roleMappingGeneralRules

Expose non-empty computed role strings via AtkObject attribute named "computed-role".
Currently the computed role and the ARIA role value happen to be the same string, but
that might not always be the case. And AtkObject attributes are cheap.

Test: platform/gtk/accessibility/xml-roles-exposed.html.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::computedRoleString): Implemented.

LayoutTests:

  • platform/gtk/TestExpectations: Removed roles-computedRoleString from the failing test.
  • platform/gtk/accessibility/image-link-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/lists-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/roles-computedRoleString-expected.txt: Added.
  • platform/gtk/accessibility/table-attributes-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/table-cell-spans-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/table-cells-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/table-detection-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/table-sections-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/table-with-rules-expected.txt: Updated to reflect the new object attribute.
  • platform/gtk/accessibility/xml-roles-exposed-expected.txt: Added.
  • platform/gtk/accessibility/xml-roles-exposed.html: Added.
10:46 PM Changeset in webkit [184753] by bshafiei@apple.com
  • 5 edits in branches/safari-600.7-branch/Source

Versioning.

10:46 PM Changeset in webkit [184752] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32-branch/Source

Versioning.

10:46 PM Changeset in webkit [184751] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

9:35 PM Changeset in webkit [184750] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Give Toolbar buttons an active style
​https://bugs.webkit.org/show_bug.cgi?id=145292

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-21
Reviewed by Timothy Hatcher.

  • UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button:active):

8:59 PM Changeset in webkit [184749] by Antti Koivisto
  • 8 edits
    2 adds in trunk

MaskImageOperation code does not manage CachedImageClients correctly
​https://bugs.webkit.org/show_bug.cgi?id=145276
Source/WebCore:

rdar://problem/20959822

Reviewed by Andreas Kling.

Test: css3/masking/mask-image-client-crash.html

  • platform/graphics/MaskImageOperation.cpp:

(WebCore::MaskImageOperation::isMaskLoaded):
(WebCore::MaskImageOperation::setImage):

If image changes transfer the clients to the new image.

(WebCore::MaskImageOperation::setRenderLayerImageClient):

Always use setImage.

(WebCore::MaskImageOperation::notifyFinished):

  • platform/graphics/MaskImageOperation.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerMaskImageInfo.cpp:

(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients):

Store the MaskImageOperations where we added clients.

(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):

Make sure we remove the clients from the same MaskImageOperations we added them to.

  • rendering/RenderLayerMaskImageInfo.h:

LayoutTests:

Reviewed by Andreas Kling.

  • css3/masking/mask-image-client-crash-expected.txt: Added.
  • css3/masking/mask-image-client-crash.html: Added.
7:54 PM Changeset in webkit [184748] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dashboard debugger information can be clipped
​https://bugs.webkit.org/show_bug.cgi?id=144209

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
Make dashboard flexible by using vw (viewport width units).

  • UserInterface/Views/DefaultDashboardView.css:

(.toolbar .dashboard.default):
Center default dashboard icons in the middle, don't spread them along the dashboard.

7:39 PM Changeset in webkit [184747] by saambarati1@gmail.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

Object allocation sinking phase should explicitly create bottom values for CreateActivation sink candidates and CreateActivation should have SymbolTable as a child node
​https://bugs.webkit.org/show_bug.cgi?id=145192

Reviewed by Filip Pizlo.

When we sink CreateActivation and generate MaterializeCreateActivation
in the object allocation sinking phase, we now explictly add PutHints for
all variables on the activation setting those variables to their default value
(undefined for Function activations and soon to be JS Empty Value for block scope activations).
This allows us to remove code that fills FTL fast activation allocations with Undefined.

This patch also adds the constant SymbolTable as an OpInfo of CreateActivation and MaterializeCreateActivation
nodes. This is in preparation for ES6 block scoping which will introduce a new
op code that gets lowered to CreateActivation.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::cellOperand):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize):

  • dfg/DFGPromotedHeapLocation.cpp:

(WTF::printInternal):

  • dfg/DFGPromotedHeapLocation.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateActivation):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCreateActivation):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

  • tests/stress/activation-sink-default-value.js: Added.

(bar):

  • tests/stress/activation-sink-osrexit-default-value.js: Added.

(foo.set result):

6:22 PM Changeset in webkit [184746] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.5

New tag.

6:15 PM Changeset in webkit [184745] by dbates@webkit.org
  • 5 edits in trunk

Update Autofill button icon
​https://bugs.webkit.org/show_bug.cgi?id=145191
<rdar://problem/20178942>

Reviewed by Jessie Berlin.

Source/WebCore:

  • css/html.css:

(input::-webkit-auto-fill-button):
(input::-webkit-auto-fill-button:active):
(input::-webkit-auto-fill-button:hover):

LayoutTests:

Update expected results.

  • fast/forms/input-auto-fill-button-expected.txt:
  • platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt:
5:43 PM Changeset in webkit [184744] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.32.2.80/Source/WebKit2

Merged r184738. rdar://problem/20830673

5:41 PM Changeset in webkit [184743] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.32.2.80/Source

Versioning.

5:39 PM Changeset in webkit [184742] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.80

New tag.

5:35 PM Changeset in webkit [184741] by beidson@apple.com
  • 12 edits
    2 adds in trunk/Source

Add an "initiated by user gesture" flag to ResourceRequest.
​https://bugs.webkit.org/show_bug.cgi?id=145281

Reviewed by Alex Christensen.

Source/WebCore:

Allow WebKit to tell WebCore what the new property key is:

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add the flag to ResourceRequest, and make sure it encodes/decodes:

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::initiatedByUserGesture):
(WebCore::ResourceRequestBase::setInitiatedByUserGesture):
(WebCore::ResourceRequestBase::encodeWithoutPlatformData):
(WebCore::ResourceRequestBase::decodeWithoutPlatformData):

Set/get the property on native CFURLRequestRefs:

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

Set/get the property on native NSURLRequests:

  • platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(WKResourceRequestIsUserInitiatedKey):
(InitWebCoreSystemInterface):

Source/WebKit2:

Expose a new category on NSURLRequest to allow SPI clients to easily set/get the flag:

  • Shared/API/Cocoa/_WKNSURLRequestExtras.h: Added.
  • Shared/API/Cocoa/_WKNSURLRequestExtras.mm: Added.

(-[NSURLRequest _web_isUserInitiated]):
(-[NSMutableURLRequest _web_setIsUserInitiated:]):

  • WebKit2.xcodeproj/project.pbxproj:

Expose the new property key to WebCore:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(WKResourceRequestIsUserInitiatedKey):
(InitWebCoreSystemInterface):

5:34 PM Changeset in webkit [184740] by dbates@webkit.org
  • 15 edits in trunk/Source

Rollout <​http://trac.webkit.org/changeset/183909>
(​https://bugs.webkit.org/show_bug.cgi?id=144657)

Revert <​http://trac.webkit.org/changeset/183909> since pausing the database
thread prevents in-progress transactions from completing. We need to think
about this change some more.

Source/WebCore:

  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::setPauseAllDatabases): Deleted.

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::setPauseAllDatabases): Deleted.

  • Modules/webdatabase/DatabaseServer.h:

Source/WebKit2:

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _applicationDidEnterBackground:]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidEnterBackground): Deleted.

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::setPauseAllDatabases): Deleted.

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillEnterForeground): Deleted.
(WebKit::WebPage::applicationDidEnterBackground): Deleted.

5:31 PM Changeset in webkit [184739] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Crash when taking a snapshot of a large PDF.
​https://bugs.webkit.org/show_bug.cgi?id=145286
rdar://problem/20892362

Reviewed by Tim Horton.

The code for the PDF case was incorrectly computing the snapshot rect.
On top of that drawViewHierarchyInRect was ignoring the rect and
always creating an image using the view bounds causing the crash.
We are now always using the IOSurface if we are parented or
an image context when we are not.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

5:29 PM Changeset in webkit [184738] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Symlink the WebKit dylib instead of just the framework directory
​https://bugs.webkit.org/show_bug.cgi?id=145287
rdar://problem/20830673

Reviewed by Dan Bernstein.

  • WebKit2.xcodeproj/project.pbxproj:
5:12 PM Changeset in webkit [184737] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.5

New tag.

4:33 PM Changeset in webkit [184736] by Joseph Pecoraro
  • 10 edits
    1 move
    5 adds
    3 deletes in trunk/Source/WebInspectorUI

Web Inspector: Improve the UI of the type profiler popover
​https://bugs.webkit.org/show_bug.cgi?id=140737

Reviewed by Timothy Hatcher.

Display TypeDescriptions in a Tree similiar to ObjectTrees.
Currently the only information we have in a TypeDescription
is the property names, and not their types, so all we can
display in the tree are names.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):

  • UserInterface/Main.html:
  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype.updateTypes):

  • UserInterface/Models/StructureDescription.js: Added.

(WebInspector.StructureDescription):
(WebInspector.StructureDescription.fromPayload):
(WebInspector.StructureDescription.prototype.get fields):
(WebInspector.StructureDescription.prototype.get optionalFields):
(WebInspector.StructureDescription.prototype.get constructorName):
(WebInspector.StructureDescription.prototype.get prototypeStructure):
(WebInspector.StructureDescription.prototype.get imprecise):

  • UserInterface/Models/TypeDescription.js: Added.

(WebInspector.TypeDescription):
(WebInspector.TypeDescription.fromPayload):
(WebInspector.TypeDescription.prototype.get leastCommonAncestor):
(WebInspector.TypeDescription.prototype.get typeSet):
(WebInspector.TypeDescription.prototype.get structures):
(WebInspector.TypeDescription.prototype.get valid):
(WebInspector.TypeDescription.prototype.get truncated):

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

  • UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype._updateChildren):

  • UserInterface/Views/Section.css: Removed.
  • UserInterface/Views/Section.js: Removed.
  • UserInterface/Views/SourceCodeTextEditor.css:

(.popover .expandable):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
(WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):

  • UserInterface/Views/TypePropertiesSection.js: Removed.
  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView):
(WebInspector.TypeTokenView.titleForPopover):
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):

  • UserInterface/Views/TypeTreeElement.css: Added.

(.type-tree-element):
(.type-tree-element > .titles):
(.type-tree-element > .disclosure-button):
(.type-tree-element.parent > .disclosure-button):
(.type-tree-element.parent.expanded > .disclosure-button):
(.type-tree-element > .icon):
(.type-tree-element.prototype):
(.type-tree-element.prototype:focus):
(.type-tree-element.prototype + ol):

  • UserInterface/Views/TypeTreeElement.js: Added.

(WebInspector.TypeTreeElement):
(WebInspector.TypeTreeElement.prototype.get name):
(WebInspector.TypeTreeElement.prototype.get isPrototype):
(WebInspector.TypeTreeElement.prototype.onpopulate):
(WebInspector.TypeTreeElement.prototype.onexpand):

  • UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js.

(.type-tree):
(.type-tree-outline):
(.type-tree-outline li):
(.type-tree-outline ol):
(.type-tree-outline ol.expanded):
(.type-tree-outline li .empty-message):

  • UserInterface/Views/TypeTreeView.js: Added.

(WebInspector.TypeTreeView):
(WebInspector.TypeTreeView.prototype.get typeDescription):
(WebInspector.TypeTreeView.prototype.get element):
(WebInspector.TypeTreeView.prototype.get treeOutline):
(WebInspector.TypeTreeView.prototype._populate):

4:30 PM Changeset in webkit [184735] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.7.9

New tag.

3:45 PM Changeset in webkit [184734] by jacob_nielsen@apple.com
  • 19 edits in trunk/Source/WebCore

r184718 and r184725 caused four tests to begin crashing

Unreviewed rollback.

Tests that started crashing:

svg/carto.net/textbox.svg svg/custom/tref-clone-crash.html svg/custom/use-animation-in-fill.html svg/custom/use-multiple-on-nested-disallowed-font.html

  • svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::~SVGCursorElement):
(WebCore::SVGCursorElement::isSupportedAttribute):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::rebuildElements):

  • svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::attributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::cssPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):

  • svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::begin):
(WebCore::SVGPathByteStream::end):
(WebCore::SVGPathByteStream::append):
(WebCore::SVGPathByteStream::clear):
(WebCore::SVGPathByteStream::isEmpty):

  • svg/SVGPathUtilities.cpp:

(WebCore::appendSVGPathByteStreamFromSVGPathSeg):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearResultsRecursive):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.cpp:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):

1:27 PM Changeset in webkit [184733] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merged r184728. rdar://problem/21051039

1:26 PM Changeset in webkit [184732] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1.32-branch/Source/WebCore

Merged r184728. rdar://problem/21051039

12:53 PM Changeset in webkit [184731] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184514. rdar://problem/20368630

12:52 PM Changeset in webkit [184730] by bshafiei@apple.com
  • 12 edits
    1 copy in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184503. rdar://problem/20368630

12:51 PM Changeset in webkit [184729] by bshafiei@apple.com
  • 17 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184370. rdar://problem/20368630

12:37 PM Changeset in webkit [184728] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

Scroll-snap points needs to be updated during programmatic scrolls
​https://bugs.webkit.org/show_bug.cgi?id=145216
<rdar://problem/21051039>

Reviewed by Dean Jackson.

Whenever we adjust the current scroll position, make sure we also update the current
active scroll snap offset index (if applicable).

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
method after moving to a new position.
(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
to track these new values.

  • platform/ScrollAnimator.h:
  • platform/cocoa/ScrollController.h:

(WebCore::ScrollController::activeScrollSnapIndexDidChange):
(WebCore::ScrollController::setScrollSnapIndexDidChange):

  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
index for the given scroll offset, and update the internal scroll snap state to reflect it.
(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
set the relevant scroll snap offset indices.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
after moving to a new position.
(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.

12:12 PM Changeset in webkit [184727] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WKWebsiteDataStore doesn't track and remove iOS Safari's offline application cache entries
​https://bugs.webkit.org/show_bug.cgi?id=145279
rdar://problem/20657912

Reviewed by Dan Bernstein.

Special-case iOS Safari and WebApp when computing the default application cache directory.

  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::applicationCacheDirectory):
(API::WebsiteDataStore::defaultDataStoreConfiguration):

11:54 AM Changeset in webkit [184726] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit2

Add a _WKWebKitContentExtensionStore initializer that takes a path.
​https://bugs.webkit.org/show_bug.cgi?id=145269 and work towards <rdar://problem/21031414>

Reviewed by Anders Carlsson.

  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::UserContentExtensionStore::storeWithPath):

  • UIProcess/API/APIUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(+[_WKUserContentExtensionStore storeWithURL:]):

11:32 AM Changeset in webkit [184725] by Matt Baker
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent): should be type.properties, not type.properties().

11:24 AM Changeset in webkit [184724] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184716.

11:08 AM Changeset in webkit [184723] by youenn.fablet@crf.canon.fr
  • 4 edits in trunk/Source/WebCore

[Streams API] Remove ReadableStreamReader closed promise internal slot
​https://bugs.webkit.org/show_bug.cgi?id=145215

Reviewed by Darin Adler.

Using the new JSPromiseDeferred member generated by binding generator to handle closed promise attribute.
Removed internal slots routines previously used to ensure persistency of the promise.

Existing tests cover the changes.

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed):
(WebCore::JSReadableStreamReader::cancel): Deleted.
(WebCore::JSReadableStreamReader::releaseLock): Deleted.

  • bindings/js/ReadableJSStream.cpp:

(WebCore::getPropertyFromObject): Deleted.
(WebCore::callFunction): Deleted.
(WebCore::ReadableJSStream::Source::create): Deleted.
(WebCore::ReadableJSStream::Source::Source): Deleted.

  • bindings/js/ReadableJSStream.h:
10:52 AM Changeset in webkit [184722] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Media Controls stop updating after hovering for a few seconds.
​https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.

Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):

Override methods to use add and remove panelContainer for iOS.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):

10:45 AM Changeset in webkit [184721] by Chris Fleizach
  • 4 edits in trunk/LayoutTests

AX: improve list heuristics (presentational use versus actual lists)
​https://bugs.webkit.org/show_bug.cgi?id=134187

Unreviewed layout test fixage.

Skip the list-detection2.html test on GTK until it can be investigated.

​https://bugs.webkit.org/show_bug.cgi?id=145273

Fix a failing test on GTK that needed an update after the last set of changes.
Skip the test on windows until a time someone can decide if we even expose or need lists in Windows AX API.

​https://bugs.webkit.org/show_bug.cgi?id=145271

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/list-detection-expected.txt:
  • platform/win/TestExpectations:
10:45 AM Changeset in webkit [184720] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=145270
<rdar://problem/20734901>

Reviewed by Andreas Kling.

We no longer call destroyDecodedData() on CachedResources on memory
pressure after r179293. In r179293, we started calling
MemoryCache::evictResources() on memory pressure instead of
MemoryCache::pruneToPercentage(0). However, unlike
MemoryCache::pruneToPercentage(), it appears
MemoryCache::evictResources() removes the CachedResources from the
memory cache without calling destroyDecodedData() on them.
This caused a regression on Membuster.

This patch now calls MemoryCache::pruneLiveResourcesToSize(0) on
critical memory pressure, instead of evictResources(). We don't need to
call pruneDeadResourcesToSize(0) here because the non-critical memory
pressure handler already takes care of this.

During local testing, this change seemed to decrease the overall memory
usage of WebProcesses by ~10MB on Membuster (tested on Yosemite).

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):

10:36 AM Changeset in webkit [184719] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

SVG as image uses very tiny default font-size
​https://bugs.webkit.org/show_bug.cgi?id=68090

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-05-21
Reviewed by Darin Adler.

Source/WebCore:

When loading a document, WebKit creates a Page object and then changes its setting
from the browser's preferences. This is true for interactive resources also, such as a
stand-alone SVG or an SVG embedded in an <object> tag for example. For non-interactive
resources, like an SVG embedded in an <img> tag for example, this function is called
after loading the resource is finished. This function creates an artificial page and
fabricates a scoped settings for it. This turns out to be problematic for cases like
the default font size because its initial value is zero. We cannot go from WebCore to
WebKit to ask for the global settings. But we can inherit the global settings from the
the master page. This is not the best solution because of two reasons. (1) Once the
resource is cached and the styles for the text elements are calculated, nothing can
change the values of styles except removing the resource itself from the cache if the
browser's preferences change. Also there is no mechanism to notify this artificial
page if the browser's preferences change. (2) An image like a non-interactive SVG,
should be displayed the same way regardless of the browser's preferences. A user may
be able to change the default font size for other text. But this should not affect
images even if they are vector images like SVG. An easy and more agreeable solution
is to hard-code the default font size for this case and do not depend on the global
settings at all.

Test: svg/text/text-default-font-size.html

  • page/Settings.in: Set the initial value of the setting defaultFontSize to be 16.

LayoutTests:

  • svg/text/text-default-font-size-expected.html: Added.
  • svg/text/text-default-font-size.html: Added.

Ensure the default font size for non-interactive SVG images is not zero.

10:34 AM Changeset in webkit [184718] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/svg.
​https://bugs.webkit.org/show_bug.cgi?id=145209

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-21
Reviewed by Darin Adler.

No new tests, no new tests.

  • svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::~SVGCursorElement):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):

  • svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):

  • svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::append):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearResultsRecursive):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.cpp:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):

10:27 AM Changeset in webkit [184717] by peavo@outlook.com
  • 2 edits in trunk/Source/JavaScriptCore

MSVC internal compiler error when compiling TemplateRegistryKey class.
​https://bugs.webkit.org/show_bug.cgi?id=145259

Reviewed by Alex Christensen.

MSVC is not able to handle the brace initialization of a class member in this case.

  • runtime/TemplateRegistryKey.h:
10:10 AM Changeset in webkit [184716] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

Build fix. Silence some deprecation warnings.

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):

  • UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKDateTimePopover initWithView:datePickerMode:]):

  • UIProcess/ios/forms/WKFormPopover.h:
  • UIProcess/ios/forms/WKFormPopover.mm:
  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):

8:49 AM Changeset in webkit [184715] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/LayoutTests

streams/reference-implementation/readable-stream.html should now pass
​https://bugs.webkit.org/show_bug.cgi?id=145266

Unreviewed.

  • TestExpectations: removing falky expectation of streams/reference-implementation/readable-stream.html.
8:24 AM Changeset in webkit [184714] by bshafiei@apple.com
  • 5 edits
    2 copies in branches/safari-601.1.32.2-branch

Merged r184308. rdar://problem/20895753

5:29 AM Changeset in webkit [184713] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

Fix the !ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) build after r184337
​https://bugs.webkit.org/show_bug.cgi?id=145248

Reviewed by Yusuke Suzuki.

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

5:28 AM Changeset in webkit [184712] by Csaba Osztrogonác
  • 2 edits
    2 deletes in trunk/Tools

[EFL] Bump libsoup version to 2.50.0
​https://bugs.webkit.org/show_bug.cgi?id=145127

Reviewed by Gyuyoung Kim.

  • efl/jhbuild.modules:
  • efl/patches/soup-clang-warning-fix1.patch: Removed.
  • efl/patches/soup-clang-warning-fix2.patch: Removed.
5:02 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
3:51 AM Changeset in webkit [184711] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[EFL] Remove an unused private field from EwkPopupMenuItem class
​https://bugs.webkit.org/show_bug.cgi?id=145249

Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/ewk_popup_menu.cpp:

(EwkPopupMenu::EwkPopupMenu):

  • UIProcess/API/efl/ewk_popup_menu_private.h:
2:27 AM Changeset in webkit [184710] by Csaba Osztrogonác
  • 32 edits in trunk/Source/WebKit2

[EFL] Fix mismatched-tags warnings in UIProcess/API/efl
​https://bugs.webkit.org/show_bug.cgi?id=145129

Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/EwkViewCallbacks.h:
  • UIProcess/API/efl/ewk_application_cache_manager.h:
  • UIProcess/API/efl/ewk_auth_request.h:
  • UIProcess/API/efl/ewk_back_forward_list.h:
  • UIProcess/API/efl/ewk_back_forward_list_item.h:
  • UIProcess/API/efl/ewk_color_picker.h:
  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_menu_item.h:
  • UIProcess/API/efl/ewk_cookie_manager.h:
  • UIProcess/API/efl/ewk_database_manager.h:
  • UIProcess/API/efl/ewk_download_job.h:
  • UIProcess/API/efl/ewk_error.h:
  • UIProcess/API/efl/ewk_favicon_database.h:
  • UIProcess/API/efl/ewk_file_chooser_request.h:
  • UIProcess/API/efl/ewk_form_submission_request.h:
  • UIProcess/API/efl/ewk_navigation_data.h:
  • UIProcess/API/efl/ewk_navigation_policy_decision.h:
  • UIProcess/API/efl/ewk_object.h:
  • UIProcess/API/efl/ewk_page_group.h:
  • UIProcess/API/efl/ewk_popup_menu.h:
  • UIProcess/API/efl/ewk_popup_menu_item.h:
  • UIProcess/API/efl/ewk_security_origin.h:
  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/ewk_storage_manager.h:
  • UIProcess/API/efl/ewk_url_request.h:
  • UIProcess/API/efl/ewk_url_response.h:
  • UIProcess/API/efl/ewk_url_scheme_request.h:
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_window_features.h:
  • WebProcess/InjectedBundle/API/efl/ewk_extension.h:
  • WebProcess/InjectedBundle/API/efl/ewk_page.h:
2:23 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
12:26 AM Changeset in webkit [184709] by Gyuyoung Kim
  • 47 edits in trunk/Source/WebCore

Purge PassRefPtr in WebCore/Modules
​https://bugs.webkit.org/show_bug.cgi?id=145112

Reviewed by Darin Adler.

As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr
depends on null of return value.

No new tests, no behavior changes.

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::create):
(WebCore::MediaKeys::createSession):

  • Modules/encryptedmedia/MediaKeys.h:
  • Modules/gamepad/Gamepad.h:
  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::gamepadFromPlatformGamepad):

  • Modules/gamepad/deprecated/Gamepad.h:
  • Modules/geolocation/GeolocationError.h:

(WebCore::GeolocationError::create):

  • Modules/geolocation/GeolocationPosition.h:

(WebCore::GeolocationPosition::create):

  • Modules/geolocation/Geoposition.h:

(WebCore::Geoposition::create):

  • Modules/geolocation/PositionError.h:

(WebCore::PositionError::create):

  • Modules/geolocation/PositionOptions.h:

(WebCore::PositionOptions::create):

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::create):

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::create):

  • Modules/mediasource/MediaSource.h:
  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):

  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

  • Modules/mediastream/RTCIceCandidate.h:
  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

  • Modules/webaudio/OfflineAudioContext.h:
  • Modules/webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::create):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

  • Modules/webaudio/OscillatorNode.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::runTransaction):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::originLockFor):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/SQLError.h:

(WebCore::SQLError::create):

  • Modules/webdatabase/SQLResultSet.h:

(WebCore::SQLResultSet::create):

  • Modules/webdatabase/SQLResultSetRowList.h:

(WebCore::SQLResultSetRowList::create):

  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::create):

  • Modules/webdatabase/SQLStatementBackend.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::create):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::create):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

  • editing/InsertListCommand.h:

(WebCore::InsertListCommand::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/Worker.h:
  • xml/XPathExpression.cpp:

(WebCore::XPathExpression::createExpression):
(WebCore::XPathExpression::evaluate):

  • xml/XPathExpression.h:
12:26 AM Changeset in webkit [184708] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

Fix mismatched-tags warnings related to CoordinatedGraphics
​https://bugs.webkit.org/show_bug.cgi?id=145130

Reviewed by Darin Adler.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
Note: See TracTimeline for information about the timeline view.