Timeline



Aug 3, 2015:

11:51 PM Changeset in webkit [187819] by Csaba Osztrogonác
  • 35 edits in trunk/Source

Introduce COMPILER(GCC_OR_CLANG) guard and make COMPILER(GCC) true only for GCC
https://bugs.webkit.org/show_bug.cgi?id=146833

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • assembler/ARM64Assembler.h:
  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

  • assembler/MacroAssemblerARM.cpp:

(JSC::isVFPPresent):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::isSSE2Present):

  • heap/MachineStackMarker.h:
  • interpreter/StackVisitor.cpp: Removed redundant COMPILER(CLANG) guards.

(JSC::logF):

  • jit/HostCallReturnValue.h:
  • jit/JIT.h:
  • jit/JITOperations.cpp:
  • jit/JITStubsARM.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86Common.h:
  • jit/JITStubsX86_64.h:
  • jit/ThunkGenerators.cpp:
  • runtime/JSExportMacros.h:
  • runtime/MathCommon.h: Removed redundant COMPILER(CLANG) guard.

(JSC::clz32):

Source/WebCore:

  • platform/graphics/cpu/arm/filters/FELightingNEON.cpp:
  • platform/graphics/cpu/arm/filters/FELightingNEON.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApply):

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/Assertions.h: Removed redundant COMPILER(CLANG) guard.
  • wtf/Atomics.cpp:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):
(WTF::compilerFence):

  • wtf/Compiler.h:
    • Renamed COMPILER(GCC) to COMPILER(GCC_OR_CLANG), because it is true for both compiler.
    • Added COMPILER(GCC) which is true only for GCC.
    • Moved all GCC related stuff to one block and removed redundant guards accordingly.
    • Removed the unused default false definition of GCC_VERSION_AT_LEAST for non GCC compilers.
  • wtf/ExportMacros.h:
  • wtf/FastMalloc.h:
  • wtf/Platform.h:
  • wtf/StdLibExtras.h:
  • wtf/Vector.h:
  • wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

11:49 PM Changeset in webkit [187818] by Csaba Osztrogonác
  • 10 edits in trunk

[CMake] Add an option to build AllInOne files
https://bugs.webkit.org/show_bug.cgi?id=102647

Reviewed by Alex Christensen.

.:

  • Source/cmake/OptionsEfl.cmake: Disabled by default.
  • Source/cmake/OptionsGTK.cmake: Disabled by default.
  • Source/cmake/OptionsWindows.cmake: Enabled by default.
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

  • CMakeLists.txt:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
11:44 PM Changeset in webkit [187817] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix.

  • wtf/text/StringConcatenate.h: Include <tuple> to avoid missing

std::tuple<> class definitions.

11:44 PM Changeset in webkit [187816] by Csaba Osztrogonác
  • 4 edits
    1 delete in trunk/Source/WebCore

Fix the all-in-one build on Linux after r187659
https://bugs.webkit.org/show_bug.cgi?id=147557

Reviewed by Alex Christensen.

Removed MediaFeatureNames.cpp from the all-in-one build, because it caused build failures on Linux.
Additionally removed css/MediaAllInOne.cpp since it is unused.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • css/CSSAllInOne.cpp:
  • css/MediaAllInOne.cpp: Removed.
11:27 PM Changeset in webkit [187815] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WTF

[WTF] Turn tryMakeString(), makeString() into variadic templates
https://bugs.webkit.org/show_bug.cgi?id=147142

Reviewed by Sam Weinig.

Built upon the original work by Anders Carlsson, Mark Rowe and Sam Weinig.

Implement tryMakeString() and makeString() as variadic templates, replacing
the argument count-based overloads.

tryMakeString() now constructs a stack-based tuple of necessary StringTypeAdapter
objects and utilizes the StringAdapterTuple struct template to operate on that
tuple, recursively calling the necessary operations on each element in the tuple.
This effectively mimics the process of previous tryMakeString() implementation,
but makes it scalable to a tuple of elements that are to be concatenated.

StringAppend class template now stores two StringTypeAdapter objects for the
two passed-in string objects, packed in a tuple, calling
StringAdapterTuple<>::createString() directly when concatenating the two objects
into one String.

  • wtf/text/StringConcatenate.h:

(WTF::StringTypeAdapter<char>::length):
(WTF::StringTypeAdapter<char>::is8Bit):
(WTF::StringAdapterTuple::sumWithOverflow):
(WTF::StringAdapterTuple::is8Bit):
(WTF::StringAdapterTuple::writeTo):
(WTF::StringAdapterTuple::createString):
(WTF::tryMakeString):
(WTF::makeString):
(WTF::sumWithOverflow): Deleted.

  • wtf/text/StringOperators.h:

(WTF::StringAppend::StringAppend):
(WTF::StringAppend::operator String):
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
(WTF::StringAppend::length):
(WTF::StringAppend::string1):
(WTF::StringAppend::string2):

11:05 PM Changeset in webkit [187814] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

Add WK1 Mac result for this test.

  • platform/mac-wk1/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
10:14 PM Changeset in webkit [187813] by benjamin@webkit.org
  • 87 edits
    2 adds in trunk

Returns inconsistent types for el.style.property and el.style.getPropertyValue('color')
https://bugs.webkit.org/show_bug.cgi?id=147549

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-03
Reviewed by Andreas Kling.

Source/WebCore:

Kudos to Greg Whitworth for finding this bug.

Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html

  • css/CSSStyleDeclaration.idl:

Our definition was wrong.
Current spec: http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue
Current draft: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue
Gecko and EdgeHTML follow the spec.

LayoutTests:

The bug is very old, there were a lot of tests to update.

The tests in css3/shapes are incorrect W3C tests. I only updated the expected
results.

The test fast/css/getPropertyValue-returns-empty-on-missing-property.html
is the new one covering the bug fix.

  • animations/script-tests/trigger-parsing.js:

(testTriggerRule):

  • animations/trigger-parsing-expected.txt:
  • animations/unprefixed-properties-expected.txt:
  • animations/unprefixed-properties.html:
  • css3/blending/blend-mode-property-parsing-invalid-expected.txt:
  • css3/blending/script-tests/blend-mode-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt:
  • css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt:
  • css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt:
  • css3/shapes/shape-outside/values/shape-margin-004-expected.txt:
  • css3/shapes/shape-outside/values/shape-margin-005-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt:
  • fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
  • fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:
  • fast/box-decoration-break/box-decoration-break-parsing-expected.txt:
  • fast/box-decoration-break/box-decoration-break-parsing.html:
  • fast/box-shadow/box-shadow-parsing-invalid-expected.txt:
  • fast/box-shadow/script-tests/box-shadow-parsing-invalid.js:

(testInvalidFilterRule):

  • fast/css/background-clip-text-expected.txt:
  • fast/css/border-spacing-without-vertical-value.html:
  • fast/css/getPropertyValue-border-expected.txt:
  • fast/css/getPropertyValue-border.html:
  • fast/css/getPropertyValue-column-rule-expected.txt:
  • fast/css/getPropertyValue-column-rule.html:
  • fast/css/getPropertyValue-columns-expected.txt:
  • fast/css/getPropertyValue-columns.html:
  • fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added.
  • fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added.
  • fast/css/getPropertyValue-webkit-margin-collapse-expected.txt:
  • fast/css/getPropertyValue-webkit-margin-collapse.html:
  • fast/css/getPropertyValue-webkit-marquee-expected.txt:
  • fast/css/getPropertyValue-webkit-marquee.html:
  • fast/css/getPropertyValue-webkit-text-stroke-expected.txt:
  • fast/css/getPropertyValue-webkit-text-stroke.html:
  • fast/css/line-height-text-autosizing.html:
  • fast/css/outline-offset-parsing-expected.txt:
  • fast/css/parsing-color-correction-expected.txt:
  • fast/css/parsing-object-fit-expected.txt:
  • fast/css/parsing-object-fit.html:
  • fast/css/parsing-text-rendering-expected.txt:
  • fast/css/parsing-webkit-font-smoothing-expected.txt:
  • fast/css/resources/parsing-color-correction.js:
  • fast/css/resources/parsing-text-rendering.js:
  • fast/css/resources/parsing-webkit-font-smoothing.js:
  • fast/css/script-tests/background-clip-text.js:
  • fast/css/script-tests/outline-offset-parsing.js:
  • fast/css/script-tests/transform-origin-parsing.js:
  • fast/css/sticky/parsing-position-sticky-expected.txt:
  • fast/css/sticky/resources/parsing-position-sticky.js:
  • fast/css/transform-origin-parsing-expected.txt:
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:
  • fast/css3-text/font-synthesis-parse-expected.txt:
  • fast/css3-text/font-synthesis-parse.html:
  • fast/filter-image/parse-filter-image-expected.txt:
  • fast/filter-image/parse-filter-image.html:
  • fast/masking/parsing-clip-path-shape-expected.txt:
  • fast/masking/parsing-clip-path-shape.html:
  • fast/masking/parsing-mask-expected.txt:
  • fast/masking/parsing-mask.html:
  • fast/shapes/css-shapes-disabled-expected.txt:
  • fast/shapes/css-shapes-disabled.html:
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
  • platform/mac/fast/css/dashboard-region-parser-expected.txt:
  • platform/mac/fast/css/dashboard-region-parser.html:
  • platform/mac/fast/text/trailing-word-parse-expected.txt:
  • platform/mac/fast/text/trailing-word-parse.html:
  • svg/paint-order/parsing-paint-order-expected.txt:
  • svg/paint-order/parsing-paint-order.html:
10:01 PM Changeset in webkit [187812] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2] Reserve Vector capacity in VectorArgumentCoder<false, T, inlineCapacity>::decode()
https://bugs.webkit.org/show_bug.cgi?id=147619

Reviewed by Andreas Kling.

Reserve Vector capacity in VectorArgumentCoder<false, T, inlineCapacity>::decode()
as we know the size of the Vector in advance.

  • Platform/IPC/ArgumentCoders.h:
9:45 PM Changeset in webkit [187811] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

Add a result missed in earlier file moves.

  • accessibility/mac/crash-invalid-text-marker-node-expected.txt: Added.
9:44 PM Changeset in webkit [187810] by Simon Fraser
  • 1 edit
    2 moves in trunk/LayoutTests

Make LayoutTests/platform/gtk/fast/css/rect-shadow-tiled.html a cross-platform test.

  • fast/css/rect-shadow-tiled-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/rect-shadow-tiled-expected.txt.
  • fast/css/rect-shadow-tiled.html: Renamed from LayoutTests/platform/gtk/fast/css/rect-shadow-tiled.html.
9:44 PM Changeset in webkit [187809] by Simon Fraser
  • 1 edit
    2 moves in trunk/LayoutTests

Make platform/gtk/editing/selection/caret-mode-document-begin-end.html into cross-platform test.

  • editing/selection/caret-mode-document-begin-end-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt.
  • editing/selection/caret-mode-document-begin-end.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-document-begin-end.html.
9:43 PM Changeset in webkit [187808] by Simon Fraser
  • 3 edits
    1 move
    1 add in trunk/LayoutTests

Make accessibility/media-emits-object-replacement.html not specific to EFL.

  • accessibility/media-emits-object-replacement-expected.txt: Added.
  • accessibility/media-emits-object-replacement.html: Renamed from LayoutTests/platform/efl/accessibility/media-emits-object-replacement.html.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
9:40 PM Changeset in webkit [187807] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix crashing Mavericks test

Unreviewed.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::registeredFont):

8:42 PM Changeset in webkit [187806] by mmaxfield@apple.com
  • 5 edits in trunk/Source

Unreviewed post-review feedback on r187797

The correct terminology is "registered" instead of "activated."

Source/WebCore:

No new tests because there is no behavior change.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::registeredFont):
(WebCore::FontPlatformData::activatedFont): Deleted.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

8:32 PM Changeset in webkit [187805] by mmaxfield@apple.com
  • 4 edits in trunk/Source

Clean up casts between NSFont*s and CTFontRefs
https://bugs.webkit.org/show_bug.cgi?id=147618

Source/WebCore:

Reviewed by Mitz Pettel.

For toll free bridged types, it makes more sense to do a C-style cast, than jump
through hoops for older compilers.

No new tests because there is no behavior change.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::nsFont):
(WebCore::FontPlatformData::hash):

Source/WebKit/mac:

Reviewed by Mitz Pettel

For toll free bridged types, it makes more sense to do a C-style cast, than jump
through hoops for older compilers.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

8:21 PM Changeset in webkit [187804] by Simon Fraser
  • 48 edits
    1 move
    1 add in trunk/LayoutTests

Fix paths to js-test-pre.js and js-test-post.js after earlier file move.
Move platform/gtk/resources/atk-helpers.js into accessibility/gtk since
these are the only callers.

  • accessibility/gtk/aria-listbox-crash.html:
  • accessibility/gtk/aria-options-and-menuitems-crash.html:
  • accessibility/gtk/aria-roles-unignored.html:
  • accessibility/gtk/aria-slider-required-attributes.html:
  • accessibility/gtk/aria-toggle-button-role.html:
  • accessibility/gtk/button-accessible-name.html:
  • accessibility/gtk/caret-browsing-select-focus.html:
  • accessibility/gtk/caret-browsing-text-focus.html:
  • accessibility/gtk/caret-offsets-and-extraneous-white-spaces.html:
  • accessibility/gtk/caret-offsets.html:
  • accessibility/gtk/combobox-descendants-orientation-crash.html:
  • accessibility/gtk/detached-object-role.html:
  • accessibility/gtk/entry-and-password.html:
  • accessibility/gtk/list-items-always-exposed.html:
  • accessibility/gtk/media-controls-panel-title.html:
  • accessibility/gtk/media-emits-object-replacement.html:
  • accessibility/gtk/menu-list-unfocused-notifications.html:
  • accessibility/gtk/name-from-label.html:
  • accessibility/gtk/no-notification-for-unrendered-iframe-children.html:
  • accessibility/gtk/object-attributes.html:
  • accessibility/gtk/object-with-title.html:
  • accessibility/gtk/remapped-aria-crash.html:
  • accessibility/gtk/replaced-objects-in-anonymous-blocks.html:
  • accessibility/gtk/resources/atk-helpers.js: Renamed from LayoutTests/platform/gtk/resources/atk-helpers.js.

(setCaretOffset):

  • accessibility/gtk/spans-paragraphs-and-divs.html:
  • accessibility/gtk/spans.html:
  • accessibility/gtk/text-at-offset-embedded-objects.html:
  • accessibility/gtk/text-at-offset-newlines.html:
  • accessibility/gtk/text-at-offset-preformatted.html:
  • accessibility/gtk/text-at-offset-simple.html:
  • accessibility/gtk/text-at-offset-special-chars.html:
  • accessibility/gtk/text-at-offset-textarea.html:
  • accessibility/gtk/text-at-offset-textinput.html:
  • accessibility/gtk/text-at-offset-wrapped-lines.html:
  • accessibility/gtk/text-for-range-combo-box.html:
  • accessibility/gtk/text-for-range-embedded-objects.html:
  • accessibility/gtk/text-for-range-entry-and-password.html:
  • accessibility/gtk/text-for-range-extraneous-whitespace.html:
  • accessibility/gtk/text-for-range-formatted.html:
  • accessibility/gtk/text-for-range-heading.html:
  • accessibility/gtk/text-for-range-list-items.html:
  • accessibility/gtk/text-for-range-simple.html:
  • accessibility/gtk/text-for-range-table-cells.html:
  • accessibility/gtk/text-for-range-with-link.html:
  • accessibility/gtk/text-for-table.html:
  • accessibility/gtk/text-in-span-block-in-a-block.html:
  • accessibility/gtk/title-and-alt.html:
  • accessibility/gtk/xml-roles-exposed.html:
8:11 PM Changeset in webkit [187803] by Simon Fraser
  • 3 edits
    6 moves
    2 adds in trunk/LayoutTests

Move platform/gtk/editing/pasteboard tests into editing/pasteboard/gtk.

  • TestExpectations:
  • editing/pasteboard/gtk/middle-button-paste-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt.
  • editing/pasteboard/gtk/middle-button-paste.html: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html.
  • editing/pasteboard/gtk/middle-click-onpaste-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt.
  • editing/pasteboard/gtk/middle-click-onpaste.html: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste.html.
  • editing/pasteboard/gtk/script-tests/TEMPLATE.html: Renamed from LayoutTests/platform/gtk/editing/pasteboard/script-tests/TEMPLATE.html.
  • editing/pasteboard/gtk/script-tests/middle-click-onpaste.js: Renamed from LayoutTests/platform/gtk/editing/pasteboard/script-tests/middle-click-onpaste.js.

(handlePaste):

  • platform/gtk/TestExpectations:
8:08 PM Changeset in webkit [187802] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r187707, r187709, r187724, and
r187728.
https://bugs.webkit.org/show_bug.cgi?id=147617

fast/text/international/arabic-justify.html is flakey
(Requested by litherum on #webkit).

Reverted changesets:

"[OS X] Migrate to CTFontCreateForCharactersWithLanguage from
[NSFont findFontLike:forString:withRange:inLanguage]"
https://bugs.webkit.org/show_bug.cgi?id=147483
http://trac.webkit.org/changeset/187707

"Fix the build"
http://trac.webkit.org/changeset/187709

"Expand CharacterFallbackMapKey to a struct"
https://bugs.webkit.org/show_bug.cgi?id=147530
http://trac.webkit.org/changeset/187724

"CharacterFallbackMapKey should be locale-specific"
https://bugs.webkit.org/show_bug.cgi?id=147532
http://trac.webkit.org/changeset/187728

Patch by Commit Queue <commit-queue@webkit.org> on 2015-08-03

8:06 PM Changeset in webkit [187801] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix the Yosemite build after r187797

Unreviewed.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

8:00 PM Changeset in webkit [187800] by Simon Fraser
  • 3 edits
    42 moves
    1 add
    1 delete in trunk/LayoutTests

Move platform/win/accessibility tests to accessibility/win.

Fix paths to script files in the tests. Fix TestExpectations. Remove an unused result.

  • TestExpectations:
  • accessibility/win/detached-object-notification-crash-expected.txt: Renamed from LayoutTests/platform/win/accessibility/detached-object-notification-crash-expected.txt.
  • accessibility/win/detached-object-notification-crash.html: Renamed from LayoutTests/platform/win/accessibility/detached-object-notification-crash.html.
  • accessibility/win/document-enabled-state-expected.txt: Renamed from LayoutTests/platform/win/accessibility/document-enabled-state-expected.txt.
  • accessibility/win/document-enabled-state.html: Renamed from LayoutTests/platform/win/accessibility/document-enabled-state.html.
  • accessibility/win/document-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/document-role-expected.txt.
  • accessibility/win/document-role.html: Renamed from LayoutTests/platform/win/accessibility/document-role.html.
  • accessibility/win/focus-events-expected.txt: Renamed from LayoutTests/platform/win/accessibility/focus-events-expected.txt.
  • accessibility/win/focus-events.html: Renamed from LayoutTests/platform/win/accessibility/focus-events.html.
  • accessibility/win/heading-elements-expected.txt: Renamed from LayoutTests/platform/win/accessibility/heading-elements-expected.txt.
  • accessibility/win/heading-elements.html: Renamed from LayoutTests/platform/win/accessibility/heading-elements.html.
  • accessibility/win/img-alt-attribute-expected.txt: Renamed from LayoutTests/platform/win/accessibility/img-alt-attribute-expected.txt.
  • accessibility/win/img-alt-attribute.html: Renamed from LayoutTests/platform/win/accessibility/img-alt-attribute.html.
  • accessibility/win/linked-elements-expected.txt: Renamed from LayoutTests/platform/win/accessibility/linked-elements-expected.txt.
  • accessibility/win/linked-elements.html: Renamed from LayoutTests/platform/win/accessibility/linked-elements.html.
  • accessibility/win/list-item-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/list-item-role-expected.txt.
  • accessibility/win/list-item-role.html: Renamed from LayoutTests/platform/win/accessibility/list-item-role.html.
  • accessibility/win/list-marker-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/list-marker-role-expected.txt.
  • accessibility/win/list-marker-role.html: Renamed from LayoutTests/platform/win/accessibility/list-marker-role.html.
  • accessibility/win/list-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/list-role-expected.txt.
  • accessibility/win/list-role.html: Renamed from LayoutTests/platform/win/accessibility/list-role.html.
  • accessibility/win/multiple-select-element-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/multiple-select-element-role-expected.txt.
  • accessibility/win/multiple-select-element-role.html: Renamed from LayoutTests/platform/win/accessibility/multiple-select-element-role.html.
  • accessibility/win/option-element-position-and-size-expected.txt: Renamed from LayoutTests/platform/win/platform/win/accessibility/option-element-position-and-size-expected.txt.
  • accessibility/win/option-element-position-and-size.html: Renamed from LayoutTests/platform/win/accessibility/option-element-position-and-size.html.
  • accessibility/win/option-element-selection-and-focus-events-expected.txt: Renamed from LayoutTests/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt.
  • accessibility/win/option-element-selection-and-focus-events.html: Renamed from LayoutTests/platform/win/accessibility/option-element-selection-and-focus-events.html.
  • accessibility/win/parent-element-expected.txt: Renamed from LayoutTests/platform/win/accessibility/parent-element-expected.txt.
  • accessibility/win/parent-element.html: Renamed from LayoutTests/platform/win/accessibility/parent-element.html.
  • accessibility/win/scroll-to-anchor-expected.txt: Renamed from LayoutTests/platform/win/accessibility/scroll-to-anchor-expected.txt.
  • accessibility/win/scroll-to-anchor.html: Renamed from LayoutTests/platform/win/accessibility/scroll-to-anchor.html.
  • accessibility/win/select-element-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/select-element-role-expected.txt.
  • accessibility/win/select-element-role.html: Renamed from LayoutTests/platform/win/accessibility/select-element-role.html.
  • accessibility/win/select-element-valuechange-event-expected.txt: Renamed from LayoutTests/platform/win/accessibility/select-element-valuechange-event-expected.txt.
  • accessibility/win/select-element-valuechange-event.html: Renamed from LayoutTests/platform/win/accessibility/select-element-valuechange-event.html.
  • accessibility/win/selection-and-focus-expected.txt: Renamed from LayoutTests/platform/win/accessibility/selection-and-focus-expected.txt.
  • accessibility/win/selection-and-focus.html: Renamed from LayoutTests/platform/win/accessibility/selection-and-focus.html.
  • accessibility/win/single-select-children-changed-expected.txt: Renamed from LayoutTests/platform/win/accessibility/single-select-children-changed-expected.txt.
  • accessibility/win/single-select-children-changed.html: Renamed from LayoutTests/platform/win/accessibility/single-select-children-changed.html.
  • accessibility/win/single-select-children-expected.txt: Renamed from LayoutTests/platform/win/accessibility/single-select-children-expected.txt.
  • accessibility/win/single-select-children.html: Renamed from LayoutTests/platform/win/accessibility/single-select-children.html.
  • accessibility/win/text-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/text-role-expected.txt.
  • accessibility/win/text-role.html: Renamed from LayoutTests/platform/win/accessibility/text-role.html.
  • platform/win/TestExpectations:
  • platform/win/accessibility/option-element-position-and-size-expected.txt: Removed.
8:00 PM Changeset in webkit [187799] by Simon Fraser
  • 5 edits
    465 moves
    3 adds
    2 deletes in trunk/LayoutTests

Move platform/mac/accessibility tests to accessibility/mac.

Fix paths to script files in the tests. Fix TestExpectations. Remove an unused result.

  • TestExpectations:
  • accessibility/mac/abbr-acronym-tags-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/abbr-acronym-tags-expected.txt.
  • accessibility/mac/abbr-acronym-tags.html: Renamed from LayoutTests/platform/mac/accessibility/abbr-acronym-tags.html.
  • accessibility/mac/accesskey-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/accesskey-expected.txt.
  • accessibility/mac/accesskey.html: Renamed from LayoutTests/platform/mac/accessibility/accesskey.html.
  • accessibility/mac/alt-for-css-content-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/alt-for-css-content-expected.txt.
  • accessibility/mac/alt-for-css-content.html: Renamed from LayoutTests/platform/mac/accessibility/alt-for-css-content.html.
  • accessibility/mac/area-with-aria-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/area-with-aria-label-expected.txt.
  • accessibility/mac/area-with-aria-label.html: Renamed from LayoutTests/platform/mac/accessibility/area-with-aria-label.html.
  • accessibility/mac/aria-alerts-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-alerts-expected.txt.
  • accessibility/mac/aria-alerts.html: Renamed from LayoutTests/platform/mac/accessibility/aria-alerts.html.
  • accessibility/mac/aria-columnrowheaders-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-columnrowheaders-expected.txt.
  • accessibility/mac/aria-columnrowheaders.html: Renamed from LayoutTests/platform/mac/accessibility/aria-columnrowheaders.html.
  • accessibility/mac/aria-directory-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-directory-expected.txt.
  • accessibility/mac/aria-directory.html: Renamed from LayoutTests/platform/mac/accessibility/aria-directory.html.
  • accessibility/mac/aria-divs-not-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-divs-not-ignored-expected.txt.
  • accessibility/mac/aria-divs-not-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/aria-divs-not-ignored.html.
  • accessibility/mac/aria-drag-drop-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-drag-drop-expected.txt.
  • accessibility/mac/aria-drag-drop.html: Renamed from LayoutTests/platform/mac/accessibility/aria-drag-drop.html.
  • accessibility/mac/aria-expanded-not-exposed-when-undefined-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-not-exposed-when-undefined-expected.txt.
  • accessibility/mac/aria-expanded-not-exposed-when-undefined.html: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-not-exposed-when-undefined.html.
  • accessibility/mac/aria-expanded-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-notifications-expected.txt.
  • accessibility/mac/aria-expanded-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-notifications.html.
  • accessibility/mac/aria-expanded-standard-items-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-standard-items-expected.txt.
  • accessibility/mac/aria-expanded-standard-items.html: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-standard-items.html.
  • accessibility/mac/aria-grid-with-strange-hierarchy-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-grid-with-strange-hierarchy-expected.txt.
  • accessibility/mac/aria-grid-with-strange-hierarchy.html: Renamed from LayoutTests/platform/mac/accessibility/aria-grid-with-strange-hierarchy.html.
  • accessibility/mac/aria-grouping-roles-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-grouping-roles-expected.txt.
  • accessibility/mac/aria-grouping-roles.html: Renamed from LayoutTests/platform/mac/accessibility/aria-grouping-roles.html.
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-hidden-changes-for-non-ignored-elements-expected.txt.
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html: Renamed from LayoutTests/platform/mac/accessibility/aria-hidden-changes-for-non-ignored-elements.html.
  • accessibility/mac/aria-image-emits-object-replacement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt.
  • accessibility/mac/aria-image-emits-object-replacement.html: Renamed from LayoutTests/platform/mac/accessibility/aria-image-emits-object-replacement.html.
  • accessibility/mac/aria-label-overrides-visible-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-label-overrides-visible-text-expected.txt.
  • accessibility/mac/aria-label-overrides-visible-text.html: Renamed from LayoutTests/platform/mac/accessibility/aria-label-overrides-visible-text.html.
  • accessibility/mac/aria-listbox-selectedchildren-change-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt.
  • accessibility/mac/aria-listbox-selectedchildren-change.html: Renamed from LayoutTests/platform/mac/accessibility/aria-listbox-selectedchildren-change.html.
  • accessibility/mac/aria-liveregion-marquee-default-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-marquee-default-expected.txt.
  • accessibility/mac/aria-liveregion-marquee-default.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-marquee-default.html.
  • accessibility/mac/aria-liveregion-on-image-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-on-image-expected.txt.
  • accessibility/mac/aria-liveregion-on-image.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-on-image.html.
  • accessibility/mac/aria-liveregions-addedelement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-addedelement-expected.txt.
  • accessibility/mac/aria-liveregions-addedelement.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-addedelement.html.
  • accessibility/mac/aria-liveregions-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt.
  • accessibility/mac/aria-liveregions-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-attributes.html.
  • accessibility/mac/aria-liveregions-changedalt-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedalt-expected.txt.
  • accessibility/mac/aria-liveregions-changedalt.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedalt.html.
  • accessibility/mac/aria-liveregions-changedtext-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedtext-expected.txt.
  • accessibility/mac/aria-liveregions-changedtext.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedtext.html.
  • accessibility/mac/aria-liveregions-notifications-always-sent-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt.
  • accessibility/mac/aria-liveregions-notifications-always-sent.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html.
  • accessibility/mac/aria-liveregions-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-expected.txt.
  • accessibility/mac/aria-liveregions-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html.
  • accessibility/mac/aria-liveregions-removedelement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-removedelement-expected.txt.
  • accessibility/mac/aria-liveregions-removedelement.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-removedelement.html.
  • accessibility/mac/aria-menu-closed-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-closed-notification-expected.txt.
  • accessibility/mac/aria-menu-closed-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-closed-notification.html.
  • accessibility/mac/aria-menu-item-selected-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt.
  • accessibility/mac/aria-menu-item-selected-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification.html.
  • accessibility/mac/aria-menu-open-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-open-notification-expected.txt.
  • accessibility/mac/aria-menu-open-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-open-notification.html.
  • accessibility/mac/aria-menu-role-descriptions-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-role-descriptions-expected.txt.
  • accessibility/mac/aria-menu-role-descriptions.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-role-descriptions.html.
  • accessibility/mac/aria-menubar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menubar-expected.txt.
  • accessibility/mac/aria-menubar.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menubar.html.
  • accessibility/mac/aria-menuitem-checked-value-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-checked-value-expected.txt.
  • accessibility/mac/aria-menuitem-checked-value.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-checked-value.html.
  • accessibility/mac/aria-menuitem-focus-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-focus-expected.txt.
  • accessibility/mac/aria-menuitem-focus.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-focus.html.
  • accessibility/mac/aria-multiline-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-multiline-expected.txt.
  • accessibility/mac/aria-multiline.html: Renamed from LayoutTests/platform/mac/accessibility/aria-multiline.html.
  • accessibility/mac/aria-multiple-liveregions-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification-expected.txt.
  • accessibility/mac/aria-multiple-liveregions-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification.html.
  • accessibility/mac/aria-multiselectable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-multiselectable-expected.txt.
  • accessibility/mac/aria-multiselectable.html: Renamed from LayoutTests/platform/mac/accessibility/aria-multiselectable.html.
  • accessibility/mac/aria-owns-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-owns-expected.txt.
  • accessibility/mac/aria-owns.html: Renamed from LayoutTests/platform/mac/accessibility/aria-owns.html.
  • accessibility/mac/aria-popup-buttons-on-native-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt.
  • accessibility/mac/aria-popup-buttons-on-native-elements.html: Renamed from LayoutTests/platform/mac/accessibility/aria-popup-buttons-on-native-elements.html.
  • accessibility/mac/aria-popup-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-popup-expected.txt.
  • accessibility/mac/aria-popup.html: Renamed from LayoutTests/platform/mac/accessibility/aria-popup.html.
  • accessibility/mac/aria-pressed-button-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-pressed-button-attributes-expected.txt.
  • accessibility/mac/aria-pressed-button-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/aria-pressed-button-attributes.html.
  • accessibility/mac/aria-radiobutton-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-radiobutton-text-expected.txt.
  • accessibility/mac/aria-radiobutton-text.html: Renamed from LayoutTests/platform/mac/accessibility/aria-radiobutton-text.html.
  • accessibility/mac/aria-radiogroup-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-radiogroup-expected.txt.
  • accessibility/mac/aria-radiogroup.html: Renamed from LayoutTests/platform/mac/accessibility/aria-radiogroup.html.
  • accessibility/mac/aria-required-popup-button-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-required-popup-button-expected.txt.
  • accessibility/mac/aria-required-popup-button.html: Renamed from LayoutTests/platform/mac/accessibility/aria-required-popup-button.html.
  • accessibility/mac/aria-slider-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-slider-expected.txt.
  • accessibility/mac/aria-slider.html: Renamed from LayoutTests/platform/mac/accessibility/aria-slider.html.
  • accessibility/mac/aria-spinbutton-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton-crash-expected.txt.
  • accessibility/mac/aria-spinbutton-crash.html: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton-crash.html.
  • accessibility/mac/aria-spinbutton-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton-expected.txt.
  • accessibility/mac/aria-spinbutton.html: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton.html.
  • accessibility/mac/aria-table-with-colspan-cells-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt.
  • accessibility/mac/aria-table-with-colspan-cells.html: Renamed from LayoutTests/platform/mac/accessibility/aria-table-with-colspan-cells.html.
  • accessibility/mac/aria-toolbar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-toolbar-expected.txt.
  • accessibility/mac/aria-toolbar.html: Renamed from LayoutTests/platform/mac/accessibility/aria-toolbar.html.
  • accessibility/mac/aria-tree-activedescendant-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-activedescendant-expected.txt.
  • accessibility/mac/aria-tree-activedescendant.html: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-activedescendant.html.
  • accessibility/mac/aria-tree-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-expected.txt.
  • accessibility/mac/aria-tree-index-of-items-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-index-of-items-expected.txt.
  • accessibility/mac/aria-tree-index-of-items.html: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-index-of-items.html.
  • accessibility/mac/aria-tree.html: Renamed from LayoutTests/platform/mac/accessibility/aria-tree.html.
  • accessibility/mac/aria-treegrid-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-treegrid-expected.txt.
  • accessibility/mac/aria-treegrid.html: Renamed from LayoutTests/platform/mac/accessibility/aria-treegrid.html.
  • accessibility/mac/aria-valuetext-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext-expected.txt.
  • accessibility/mac/aria-valuetext-on-native-slider-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt.
  • accessibility/mac/aria-valuetext-on-native-slider.html: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext-on-native-slider.html.
  • accessibility/mac/aria-valuetext.html: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext.html.
  • accessibility/mac/attributed-string-includes-highlighting-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-highlighting-expected.txt.
  • accessibility/mac/attributed-string-includes-highlighting.html: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-highlighting.html.
  • accessibility/mac/attributed-string-includes-misspelled-with-selection-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt.
  • accessibility/mac/attributed-string-includes-misspelled-with-selection.html: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html.
  • accessibility/mac/bounds-for-range-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/bounds-for-range-expected.txt.
  • accessibility/mac/bounds-for-range.html: Renamed from LayoutTests/platform/mac/accessibility/bounds-for-range.html.
  • accessibility/mac/button-shouldnot-have-axvalue-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/button-shouldnot-have-axvalue-expected.txt.
  • accessibility/mac/button-shouldnot-have-axvalue.html: Renamed from LayoutTests/platform/mac/accessibility/button-shouldnot-have-axvalue.html.
  • accessibility/mac/canvas-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/canvas-expected.txt.
  • accessibility/mac/canvas.html: Renamed from LayoutTests/platform/mac/accessibility/canvas.html.
  • accessibility/mac/caret-browsing-arrow-nav-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-arrow-nav-expected.txt.
  • accessibility/mac/caret-browsing-arrow-nav.html: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-arrow-nav.html.
  • accessibility/mac/caret-browsing-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-attribute-expected.txt.
  • accessibility/mac/caret-browsing-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-attribute.html.
  • accessibility/mac/caret-browsing-tab-selection-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-tab-selection-expected.txt.
  • accessibility/mac/caret-browsing-tab-selection.html: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-tab-selection.html.
  • accessibility/mac/change-notification-on-scroll-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/change-notification-on-scroll-expected.txt.
  • accessibility/mac/change-notification-on-scroll.html: Renamed from LayoutTests/platform/mac/accessibility/change-notification-on-scroll.html.
  • accessibility/mac/checkbox-posts-value-change-notification-after-activation-with-space-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space-expected.txt.
  • accessibility/mac/checkbox-posts-value-change-notification-after-activation-with-space.html: Renamed from LayoutTests/platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space.html.
  • accessibility/mac/clipped-text-under-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/clipped-text-under-element-expected.txt.
  • accessibility/mac/clipped-text-under-element.html: Renamed from LayoutTests/platform/mac/accessibility/clipped-text-under-element.html.
  • accessibility/mac/combobox-activedescendant-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt.
  • accessibility/mac/combobox-activedescendant-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html.
  • accessibility/mac/combox-box-value-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/combox-box-value-expected.txt.
  • accessibility/mac/combox-box-value.html: Renamed from LayoutTests/platform/mac/accessibility/combox-box-value.html.
  • accessibility/mac/content-editable-range-properties-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-range-properties-expected.txt.
  • accessibility/mac/content-editable-range-properties.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable-range-properties.html.
  • accessibility/mac/crash-in-element-for-text-marker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/crash-in-element-for-text-marker-expected.txt.
  • accessibility/mac/crash-in-element-for-text-marker.html: Renamed from LayoutTests/platform/mac/accessibility/crash-in-element-for-text-marker.html.
  • accessibility/mac/crash-invalid-text-marker-node.html: Renamed from LayoutTests/platform/mac/accessibility/crash-invalid-text-marker-node.html.
  • accessibility/mac/css-speech-speak-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/css-speech-speak-expected.txt.
  • accessibility/mac/css-speech-speak.html: Renamed from LayoutTests/platform/mac/accessibility/css-speech-speak.html.
  • accessibility/mac/definition-list-term-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/definition-list-term-expected.txt.
  • accessibility/mac/definition-list-term.html: Renamed from LayoutTests/platform/mac/accessibility/definition-list-term.html.
  • accessibility/mac/descriptionlist-not-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored-expected.txt.
  • accessibility/mac/descriptionlist-not-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored.html.
  • accessibility/mac/details-summary-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/details-summary-expected.txt.
  • accessibility/mac/details-summary.html: Renamed from LayoutTests/platform/mac/accessibility/details-summary.html.
  • accessibility/mac/div-containing-div-with-aria-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/div-containing-div-with-aria-expected.txt.
  • accessibility/mac/div-containing-div-with-aria.html: Renamed from LayoutTests/platform/mac/accessibility/div-containing-div-with-aria.html.
  • accessibility/mac/document-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/document-attributes-expected.txt.
  • accessibility/mac/document-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/document-attributes.html.
  • accessibility/mac/document-links-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/document-links-expected.txt.
  • accessibility/mac/document-links.html: Renamed from LayoutTests/platform/mac/accessibility/document-links.html.
  • accessibility/mac/document-title-used-for-description-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/document-title-used-for-description-expected.txt.
  • accessibility/mac/document-title-used-for-description.html: Renamed from LayoutTests/platform/mac/accessibility/document-title-used-for-description.html.
  • accessibility/mac/double-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/double-title-expected.txt.
  • accessibility/mac/double-title.html: Renamed from LayoutTests/platform/mac/accessibility/double-title.html.
  • accessibility/mac/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt.
  • accessibility/mac/editable-webarea-context-menu-point.html: Renamed from LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point.html.
  • accessibility/mac/element-busy-changed-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-busy-changed-expected.txt.
  • accessibility/mac/element-busy-changed.html: Renamed from LayoutTests/platform/mac/accessibility/element-busy-changed.html.
  • accessibility/mac/element-focus-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-focus-expected.txt.
  • accessibility/mac/element-focus.html: Renamed from LayoutTests/platform/mac/accessibility/element-focus.html.
  • accessibility/mac/element-for-text-marker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-for-text-marker-expected.txt.
  • accessibility/mac/element-for-text-marker.html: Renamed from LayoutTests/platform/mac/accessibility/element-for-text-marker.html.
  • accessibility/mac/element-is-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-is-ignored-expected.txt.
  • accessibility/mac/element-is-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/element-is-ignored.html.
  • accessibility/mac/element-level-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-level-expected.txt.
  • accessibility/mac/element-level.html: Renamed from LayoutTests/platform/mac/accessibility/element-level.html.
  • accessibility/mac/element-paths-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-paths-expected.txt.
  • accessibility/mac/element-paths.html: Renamed from LayoutTests/platform/mac/accessibility/element-paths.html.
  • accessibility/mac/estimated-progress-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/estimated-progress-expected.txt.
  • accessibility/mac/estimated-progress.html: Renamed from LayoutTests/platform/mac/accessibility/estimated-progress.html.
  • accessibility/mac/expanded-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/expanded-notification-expected.txt.
  • accessibility/mac/expanded-notification.html: Renamed from LayoutTests/platform/mac/accessibility/expanded-notification.html.
  • accessibility/mac/file-upload-button-subrole-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/file-upload-button-subrole-expected.txt.
  • accessibility/mac/file-upload-button-subrole.html: Renamed from LayoutTests/platform/mac/accessibility/file-upload-button-subrole.html.
  • accessibility/mac/find-and-replace-match-capitalization-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/find-and-replace-match-capitalization-expected.txt.
  • accessibility/mac/find-and-replace-match-capitalization.html: Renamed from LayoutTests/platform/mac/accessibility/find-and-replace-match-capitalization.html.
  • accessibility/mac/focus-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/focus-crash-expected.txt.
  • accessibility/mac/focus-crash.html: Renamed from LayoutTests/platform/mac/accessibility/focus-crash.html.
  • accessibility/mac/focus-setting-selection-syncronizing-not-clearing-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/focus-setting-selection-syncronizing-not-clearing-expected.txt.
  • accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html: Renamed from LayoutTests/platform/mac/accessibility/focus-setting-selection-syncronizing-not-clearing.html.
  • accessibility/mac/footer-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/footer-expected.txt.
  • accessibility/mac/footer-roledescription-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/footer-roledescription-expected.txt.
  • accessibility/mac/footer-roledescription.html: Renamed from LayoutTests/platform/mac/accessibility/footer-roledescription.html.
  • accessibility/mac/footer.html: Renamed from LayoutTests/platform/mac/accessibility/footer.html.
  • accessibility/mac/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt.
  • accessibility/mac/form-control-value-settable.html: Renamed from LayoutTests/platform/mac/accessibility/form-control-value-settable.html.
  • accessibility/mac/frame-with-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/frame-with-title-expected.txt.
  • accessibility/mac/frame-with-title.html: Renamed from LayoutTests/platform/mac/accessibility/frame-with-title.html.
  • accessibility/mac/header-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/header-expected.txt.
  • accessibility/mac/header.html: Renamed from LayoutTests/platform/mac/accessibility/header.html.
  • accessibility/mac/heading-clickpoint-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/heading-clickpoint-expected.txt.
  • accessibility/mac/heading-clickpoint.html: Renamed from LayoutTests/platform/mac/accessibility/heading-clickpoint.html.
  • accessibility/mac/hr-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/hr-element-expected.txt.
  • accessibility/mac/hr-element.html: Renamed from LayoutTests/platform/mac/accessibility/hr-element.html.
  • accessibility/mac/html-section-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html-section-elements-expected.txt.
  • accessibility/mac/html-section-elements.html: Renamed from LayoutTests/platform/mac/accessibility/html-section-elements.html.
  • accessibility/mac/html-slider-indicator-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html-slider-indicator-expected.txt.
  • accessibility/mac/html-slider-indicator.html: Renamed from LayoutTests/platform/mac/accessibility/html-slider-indicator.html.
  • accessibility/mac/html-with-aria-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html-with-aria-label-expected.txt.
  • accessibility/mac/html-with-aria-label.html: Renamed from LayoutTests/platform/mac/accessibility/html-with-aria-label.html.
  • accessibility/mac/html5-input-number-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html5-input-number-expected.txt.
  • accessibility/mac/html5-input-number.html: Renamed from LayoutTests/platform/mac/accessibility/html5-input-number.html.
  • accessibility/mac/id-class-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/id-class-attributes-expected.txt.
  • accessibility/mac/id-class-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/id-class-attributes.html.
  • accessibility/mac/iframe-aria-hidden-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/iframe-aria-hidden-expected.txt.
  • accessibility/mac/iframe-aria-hidden.html: Renamed from LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html.
  • accessibility/mac/iframe-with-title-correct-hierarchy-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt.
  • accessibility/mac/iframe-with-title-correct-hierarchy.html: Renamed from LayoutTests/platform/mac/accessibility/iframe-with-title-correct-hierarchy.html.
  • accessibility/mac/imagemap-hittest-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/imagemap-hittest-expected.txt.
  • accessibility/mac/imagemap-hittest.html: Renamed from LayoutTests/platform/mac/accessibility/imagemap-hittest.html.
  • accessibility/mac/inherited-presentational-lists-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/inherited-presentational-lists-expected.txt.
  • accessibility/mac/inherited-presentational-lists.html: Renamed from LayoutTests/platform/mac/accessibility/inherited-presentational-lists.html.
  • accessibility/mac/input-image-url-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-image-url-expected.txt.
  • accessibility/mac/input-image-url.html: Renamed from LayoutTests/platform/mac/accessibility/input-image-url.html.
  • accessibility/mac/input-replacevalue-userinfo-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-replacevalue-userinfo-expected.txt.
  • accessibility/mac/input-replacevalue-userinfo.html: Renamed from LayoutTests/platform/mac/accessibility/input-replacevalue-userinfo.html.
  • accessibility/mac/input-slider-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-slider-expected.txt.
  • accessibility/mac/input-slider.html: Renamed from LayoutTests/platform/mac/accessibility/input-slider.html.
  • accessibility/mac/input-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-title-expected.txt.
  • accessibility/mac/input-title.html: Renamed from LayoutTests/platform/mac/accessibility/input-title.html.
  • accessibility/mac/internal-link-anchors-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/internal-link-anchors-expected.txt.
  • accessibility/mac/internal-link-anchors.html: Renamed from LayoutTests/platform/mac/accessibility/internal-link-anchors.html.
  • accessibility/mac/internal-link-when-document-has-fragment-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/internal-link-when-document-has-fragment-expected.txt.
  • accessibility/mac/internal-link-when-document-has-fragment.html: Renamed from LayoutTests/platform/mac/accessibility/internal-link-when-document-has-fragment.html.
  • accessibility/mac/invalid-menu-role-does-not-send-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/invalid-menu-role-does-not-send-notification-expected.txt.
  • accessibility/mac/invalid-menu-role-does-not-send-notification.html: Renamed from LayoutTests/platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html.
  • accessibility/mac/label-element-with-hidden-control-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/label-element-with-hidden-control-expected.txt.
  • accessibility/mac/label-element-with-hidden-control.html: Renamed from LayoutTests/platform/mac/accessibility/label-element-with-hidden-control.html.
  • accessibility/mac/label-elements-exposed-as-title-ui-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/label-elements-exposed-as-title-ui-elements-expected.txt.
  • accessibility/mac/label-elements-exposed-as-title-ui-elements.html: Renamed from LayoutTests/platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html.
  • accessibility/mac/landmark-not-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/landmark-not-ignored-expected.txt.
  • accessibility/mac/landmark-not-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/landmark-not-ignored.html.
  • accessibility/mac/line-range-for-text-marker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/line-range-for-text-marker-expected.txt.
  • accessibility/mac/line-range-for-text-marker.html: Renamed from LayoutTests/platform/mac/accessibility/line-range-for-text-marker.html.
  • accessibility/mac/link-with-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/link-with-title-expected.txt.
  • accessibility/mac/link-with-title.html: Renamed from LayoutTests/platform/mac/accessibility/link-with-title.html.
  • accessibility/mac/list-items-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/list-items-ignored-expected.txt.
  • accessibility/mac/list-items-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/list-items-ignored.html.
  • accessibility/mac/listbox-hit-test-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listbox-hit-test-expected.txt.
  • accessibility/mac/listbox-hit-test.html: Renamed from LayoutTests/platform/mac/accessibility/listbox-hit-test.html.
  • accessibility/mac/listmarker-suffix-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listmarker-suffix-expected.txt.
  • accessibility/mac/listmarker-suffix.html: Renamed from LayoutTests/platform/mac/accessibility/listmarker-suffix.html.
  • accessibility/mac/live-region-creation-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/live-region-creation-notification-expected.txt.
  • accessibility/mac/live-region-creation-notification.html: Renamed from LayoutTests/platform/mac/accessibility/live-region-creation-notification.html.
  • accessibility/mac/live-region-on-span-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/live-region-on-span-expected.txt.
  • accessibility/mac/live-region-on-span.html: Renamed from LayoutTests/platform/mac/accessibility/live-region-on-span.html.
  • accessibility/mac/main-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/main-element-expected.txt.
  • accessibility/mac/main-element.html: Renamed from LayoutTests/platform/mac/accessibility/main-element.html.
  • accessibility/mac/malformed-tree-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/malformed-tree-expected.txt.
  • accessibility/mac/malformed-tree.html: Renamed from LayoutTests/platform/mac/accessibility/malformed-tree.html.
  • accessibility/mac/math-alttext-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/math-alttext-expected.txt.
  • accessibility/mac/math-alttext.html: Renamed from LayoutTests/platform/mac/accessibility/math-alttext.html.
  • accessibility/mac/mathml-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-elements-expected.txt.
  • accessibility/mac/mathml-elements.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-elements.html.
  • accessibility/mac/mathml-line-fraction-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-line-fraction-expected.txt.
  • accessibility/mac/mathml-line-fraction.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-line-fraction.html.
  • accessibility/mac/mathml-multiscript-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-multiscript-expected.txt.
  • accessibility/mac/mathml-multiscript.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-multiscript.html.
  • accessibility/mac/mathml-root-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-root-expected.txt.
  • accessibility/mac/mathml-root.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-root.html.
  • accessibility/mac/media-emits-object-replacement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/media-emits-object-replacement-expected.txt.
  • accessibility/mac/media-emits-object-replacement.html: Renamed from LayoutTests/platform/mac/accessibility/media-emits-object-replacement.html.
  • accessibility/mac/media-role-descriptions-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/media-role-descriptions-expected.txt.
  • accessibility/mac/media-role-descriptions.html: Renamed from LayoutTests/platform/mac/accessibility/media-role-descriptions.html.
  • accessibility/mac/menu-item-values-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/menu-item-values-expected.txt.
  • accessibility/mac/menu-item-values.html: Renamed from LayoutTests/platform/mac/accessibility/menu-item-values.html.
  • accessibility/mac/misspelled-attributed-string-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/misspelled-attributed-string-expected.txt.
  • accessibility/mac/misspelled-attributed-string.html: Renamed from LayoutTests/platform/mac/accessibility/misspelled-attributed-string.html.
  • accessibility/mac/mixed-checkbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox-expected.txt.
  • accessibility/mac/mixed-checkbox.html: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox.html.
  • accessibility/mac/native-list-item-should-not-expose-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt.
  • accessibility/mac/native-list-item-should-not-expose-label.html: Renamed from LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label.html.
  • accessibility/mac/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt.
  • accessibility/mac/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes.html.
  • accessibility/mac/no-unknown-objects-when-title-attribute-present-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt.
  • accessibility/mac/no-unknown-objects-when-title-attribute-present.html: Renamed from LayoutTests/platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html.
  • accessibility/mac/object-replacement-with-no-rendered-children-at-node-start-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start-expected.txt.
  • accessibility/mac/object-replacement-with-no-rendered-children-at-node-start.html: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html.
  • accessibility/mac/object-replacement-with-rendered-children-at-node-start-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start-expected.txt.
  • accessibility/mac/object-replacement-with-rendered-children-at-node-start.html: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html.
  • accessibility/mac/option-with-arialabel-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/option-with-arialabel-expected.txt.
  • accessibility/mac/option-with-arialabel.html: Renamed from LayoutTests/platform/mac/accessibility/option-with-arialabel.html.
  • accessibility/mac/option-with-lang-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/option-with-lang-expected.txt.
  • accessibility/mac/option-with-lang.html: Renamed from LayoutTests/platform/mac/accessibility/option-with-lang.html.
  • accessibility/mac/ordered-textmarker-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/ordered-textmarker-crash-expected.txt.
  • accessibility/mac/ordered-textmarker-crash.html: Renamed from LayoutTests/platform/mac/accessibility/ordered-textmarker-crash.html.
  • accessibility/mac/parent-of-table-row-is-table-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/parent-of-table-row-is-table-expected.txt.
  • accessibility/mac/parent-of-table-row-is-table.html: Renamed from LayoutTests/platform/mac/accessibility/parent-of-table-row-is-table.html.
  • accessibility/mac/popup-button-exposes-axvalue-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/popup-button-exposes-axvalue-expected.txt.
  • accessibility/mac/popup-button-exposes-axvalue.html: Renamed from LayoutTests/platform/mac/accessibility/popup-button-exposes-axvalue.html.
  • accessibility/mac/press-action-for-presentational-descendants-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/press-action-for-presentational-descendants-expected.txt.
  • accessibility/mac/press-action-for-presentational-descendants.html: Renamed from LayoutTests/platform/mac/accessibility/press-action-for-presentational-descendants.html.
  • accessibility/mac/press-action-is-first-expected.txt: Renamed from LayoutTests/platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt.
  • accessibility/mac/press-action-is-first.html: Renamed from LayoutTests/platform/mac/accessibility/press-action-is-first.html.
  • accessibility/mac/press-action-not-exposed-for-event-delegation-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/press-action-not-exposed-for-event-delegation-expected.txt.
  • accessibility/mac/press-action-not-exposed-for-event-delegation.html: Renamed from LayoutTests/platform/mac/accessibility/press-action-not-exposed-for-event-delegation.html.
  • accessibility/mac/prevent-keyboard-event-dispatch-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/prevent-keyboard-event-dispatch-expected.txt.
  • accessibility/mac/prevent-keyboard-event-dispatch.html: Renamed from LayoutTests/platform/mac/accessibility/prevent-keyboard-event-dispatch.html.
  • accessibility/mac/progressbar-indeterminate-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt.
  • accessibility/mac/progressbar-indeterminate.html: Renamed from LayoutTests/platform/mac/accessibility/progressbar-indeterminate.html.
  • accessibility/mac/radio-button-checkbox-size-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/radio-button-checkbox-size-expected.txt.
  • accessibility/mac/radio-button-checkbox-size.html: Renamed from LayoutTests/platform/mac/accessibility/radio-button-checkbox-size.html.
  • accessibility/mac/range-for-line-textarea-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/range-for-line-textarea-expected.txt.
  • accessibility/mac/range-for-line-textarea.html: Renamed from LayoutTests/platform/mac/accessibility/range-for-line-textarea.html.
  • accessibility/mac/range-for-position-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/range-for-position-expected.txt.
  • accessibility/mac/range-for-position.html: Renamed from LayoutTests/platform/mac/accessibility/range-for-position.html.
  • accessibility/mac/removing-textarea-after-edit-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt.
  • accessibility/mac/removing-textarea-after-edit-crash.html: Renamed from LayoutTests/platform/mac/accessibility/removing-textarea-after-edit-crash.html.
  • accessibility/mac/resources/accessibility-helper.js: Renamed from LayoutTests/platform/mac/accessibility/resources/accessibility-helper.js.

(clearSelectionAndFocusOnWebArea):
(elementAtStartMarkerOfSelectedTextMarkerRange):
(caretBrowsingEnabled):
(setCaretBrowsingEnabled):

  • accessibility/mac/resources/cake.png: Renamed from LayoutTests/platform/mac/accessibility/resources/cake.png.
  • accessibility/mac/rowheader-outside-table-role-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/rowheader-outside-table-role-expected.txt.
  • accessibility/mac/rowheader-outside-table-role.html: Renamed from LayoutTests/platform/mac/accessibility/rowheader-outside-table-role.html.
  • accessibility/mac/ruby-hierarchy-roles-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/ruby-hierarchy-roles-expected.txt.
  • accessibility/mac/ruby-hierarchy-roles.html: Renamed from LayoutTests/platform/mac/accessibility/ruby-hierarchy-roles.html.
  • accessibility/mac/scroll-to-visible-action-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/scroll-to-visible-action-expected.txt.
  • accessibility/mac/scroll-to-visible-action.html: Renamed from LayoutTests/platform/mac/accessibility/scroll-to-visible-action.html.
  • accessibility/mac/scrollbars-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/scrollbars-expected.txt.
  • accessibility/mac/scrollbars.html: Renamed from LayoutTests/platform/mac/accessibility/scrollbars.html.
  • accessibility/mac/search-field-cancel-button-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-field-cancel-button-expected.txt.
  • accessibility/mac/search-field-cancel-button.html: Renamed from LayoutTests/platform/mac/accessibility/search-field-cancel-button.html.
  • accessibility/mac/search-predicate-container-not-included-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-container-not-included-expected.txt.
  • accessibility/mac/search-predicate-container-not-included.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-container-not-included.html.
  • accessibility/mac/search-predicate-element-count-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt.
  • accessibility/mac/search-predicate-element-count.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-element-count.html.
  • accessibility/mac/search-predicate-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-expected.txt.
  • accessibility/mac/search-predicate-immediate-descendants-only-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-immediate-descendants-only-expected.txt.
  • accessibility/mac/search-predicate-immediate-descendants-only.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-immediate-descendants-only.html.
  • accessibility/mac/search-predicate-start-not-specified-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-start-not-specified-expected.txt.
  • accessibility/mac/search-predicate-start-not-specified.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-start-not-specified.html.
  • accessibility/mac/search-predicate.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate.html.
  • accessibility/mac/search-subrole-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-subrole-expected.txt.
  • accessibility/mac/search-subrole.html: Renamed from LayoutTests/platform/mac/accessibility/search-subrole.html.
  • accessibility/mac/search-when-element-starts-in-table-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt.
  • accessibility/mac/search-when-element-starts-in-table.html: Renamed from LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html.
  • accessibility/mac/search-with-frames-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-with-frames-expected.txt.
  • accessibility/mac/search-with-frames.html: Renamed from LayoutTests/platform/mac/accessibility/search-with-frames.html.
  • accessibility/mac/secure-text-field-supports-fast-search-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt.
  • accessibility/mac/secure-text-field-supports-fast-search.html: Renamed from LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search.html.
  • accessibility/mac/select-element-selection-with-optgroups-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt.
  • accessibility/mac/select-element-selection-with-optgroups.html: Renamed from LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups.html.
  • accessibility/mac/select-text-should-match-whole-words-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text-should-match-whole-words-expected.txt.
  • accessibility/mac/select-text-should-match-whole-words.html: Renamed from LayoutTests/platform/mac/accessibility/select-text-should-match-whole-words.html.
  • accessibility/mac/select-text-stays-inside-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text-stays-inside-text-controls-expected.txt.
  • accessibility/mac/select-text-stays-inside-text-controls.html: Renamed from LayoutTests/platform/mac/accessibility/select-text-stays-inside-text-controls.html.
  • accessibility/mac/select-text/select-text-1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-1-expected.txt.
  • accessibility/mac/select-text/select-text-1.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-1.html.
  • accessibility/mac/select-text/select-text-135546-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135546-expected.txt.
  • accessibility/mac/select-text/select-text-135546.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135546.html.
  • accessibility/mac/select-text/select-text-135575-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135575-expected.txt.
  • accessibility/mac/select-text/select-text-135575.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135575.html.
  • accessibility/mac/select-text/select-text-2-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-2-expected.txt.
  • accessibility/mac/select-text/select-text-2.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-2.html.
  • accessibility/mac/select-text/select-text-3-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-3-expected.txt.
  • accessibility/mac/select-text/select-text-3.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-3.html.
  • accessibility/mac/select-text/select-text-4-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-4-expected.txt.
  • accessibility/mac/select-text/select-text-4.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-4.html.
  • accessibility/mac/select-text/select-text-5-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-5-expected.txt.
  • accessibility/mac/select-text/select-text-5.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-5.html.
  • accessibility/mac/select-text/select-text-6-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-6-expected.txt.
  • accessibility/mac/select-text/select-text-6.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-6.html.
  • accessibility/mac/select-text/select-text-7-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-7-expected.txt.
  • accessibility/mac/select-text/select-text-7.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-7.html.
  • accessibility/mac/select-text/select-text-8-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-8-expected.txt.
  • accessibility/mac/select-text/select-text-8.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-8.html.
  • accessibility/mac/select-text/select-text-9-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-9-expected.txt.
  • accessibility/mac/select-text/select-text-9.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-9.html.
  • accessibility/mac/selected-rows-table-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selected-rows-table-expected.txt.
  • accessibility/mac/selected-rows-table.html: Renamed from LayoutTests/platform/mac/accessibility/selected-rows-table.html.
  • accessibility/mac/selected-tab-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selected-tab-crash-expected.txt.
  • accessibility/mac/selected-tab-crash.html: Renamed from LayoutTests/platform/mac/accessibility/selected-tab-crash.html.
  • accessibility/mac/selected-text-range-for-empty-textarea-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selected-text-range-for-empty-textarea-expected.txt.
  • accessibility/mac/selected-text-range-for-empty-textarea.html: Renamed from LayoutTests/platform/mac/accessibility/selected-text-range-for-empty-textarea.html.
  • accessibility/mac/selection-change-userinfo-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-change-userinfo-expected.txt.
  • accessibility/mac/selection-change-userinfo.html: Renamed from LayoutTests/platform/mac/accessibility/selection-change-userinfo.html.
  • accessibility/mac/selection-element-tabbing-to-link-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-element-tabbing-to-link-expected.txt.
  • accessibility/mac/selection-element-tabbing-to-link.html: Renamed from LayoutTests/platform/mac/accessibility/selection-element-tabbing-to-link.html.
  • accessibility/mac/selection-initial-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-initial-expected.txt.
  • accessibility/mac/selection-initial.html: Renamed from LayoutTests/platform/mac/accessibility/selection-initial.html.
  • accessibility/mac/selection-notification-focus-change-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-notification-focus-change-expected.txt.
  • accessibility/mac/selection-notification-focus-change.html: Renamed from LayoutTests/platform/mac/accessibility/selection-notification-focus-change.html.
  • accessibility/mac/selection-sync-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-sync-expected.txt.
  • accessibility/mac/selection-sync.html: Renamed from LayoutTests/platform/mac/accessibility/selection-sync.html.
  • accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt.
  • accessibility/mac/selection-value-changes-for-aria-textbox.html: Renamed from LayoutTests/platform/mac/accessibility/selection-value-changes-for-aria-textbox.html.
  • accessibility/mac/setting-attributes-is-asynchronous-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt.
  • accessibility/mac/setting-attributes-is-asynchronous.html: Renamed from LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous.html.
  • accessibility/mac/slider-allows-title-ui-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt.
  • accessibility/mac/slider-allows-title-ui-element.html: Renamed from LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html.
  • accessibility/mac/slider-supports-actions-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/slider-supports-actions-expected.txt.
  • accessibility/mac/slider-supports-actions.html: Renamed from LayoutTests/platform/mac/accessibility/slider-supports-actions.html.
  • accessibility/mac/spinbutton-valuedescription-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/spinbutton-valuedescription-expected.txt.
  • accessibility/mac/spinbutton-valuedescription.html: Renamed from LayoutTests/platform/mac/accessibility/spinbutton-valuedescription.html.
  • accessibility/mac/stale-table-rows-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/stale-table-rows-expected.txt.
  • accessibility/mac/stale-table-rows.html: Renamed from LayoutTests/platform/mac/accessibility/stale-table-rows.html.
  • accessibility/mac/stale-textmarker-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/stale-textmarker-crash-expected.txt.
  • accessibility/mac/stale-textmarker-crash.html: Renamed from LayoutTests/platform/mac/accessibility/stale-textmarker-crash.html.
  • accessibility/mac/static-text-role-uses-text-under-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt.
  • accessibility/mac/static-text-role-uses-text-under-element.html: Renamed from LayoutTests/platform/mac/accessibility/static-text-role-uses-text-under-element.html.
  • accessibility/mac/static-text-with-aria-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/static-text-with-aria-label-expected.txt.
  • accessibility/mac/static-text-with-aria-label.html: Renamed from LayoutTests/platform/mac/accessibility/static-text-with-aria-label.html.
  • accessibility/mac/string-range-contains-listmarker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/string-range-contains-listmarker-expected.txt.
  • accessibility/mac/string-range-contains-listmarker.html: Renamed from LayoutTests/platform/mac/accessibility/string-range-contains-listmarker.html.
  • accessibility/mac/submit-button-default-value-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/submit-button-default-value-expected.txt.
  • accessibility/mac/submit-button-default-value.html: Renamed from LayoutTests/platform/mac/accessibility/submit-button-default-value.html.
  • accessibility/mac/supports-focus-setting-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/supports-focus-setting-expected.txt.
  • accessibility/mac/supports-focus-setting.html: Renamed from LayoutTests/platform/mac/accessibility/supports-focus-setting.html.
  • accessibility/mac/table-column-and-row-count-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-column-and-row-count-expected.txt.
  • accessibility/mac/table-column-and-row-count.html: Renamed from LayoutTests/platform/mac/accessibility/table-column-and-row-count.html.
  • accessibility/mac/table-headers-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-headers-attribute-expected.txt.
  • accessibility/mac/table-headers-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/table-headers-attribute.html.
  • accessibility/mac/table-multi-bodies-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-multi-bodies-expected.txt.
  • accessibility/mac/table-multi-bodies.html: Renamed from LayoutTests/platform/mac/accessibility/table-multi-bodies.html.
  • accessibility/mac/table-updating-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-updating-expected.txt.
  • accessibility/mac/table-updating.html: Renamed from LayoutTests/platform/mac/accessibility/table-updating.html.
  • accessibility/mac/table-visible-rows-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-visible-rows-expected.txt.
  • accessibility/mac/table-visible-rows.html: Renamed from LayoutTests/platform/mac/accessibility/table-visible-rows.html.
  • accessibility/mac/table-with-row-col-of-headers-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-with-row-col-of-headers-expected.txt.
  • accessibility/mac/table-with-row-col-of-headers.html: Renamed from LayoutTests/platform/mac/accessibility/table-with-row-col-of-headers.html.
  • accessibility/mac/table-with-zebra-rows-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-with-zebra-rows-expected.txt.
  • accessibility/mac/table-with-zebra-rows.html: Renamed from LayoutTests/platform/mac/accessibility/table-with-zebra-rows.html.
  • accessibility/mac/test-convenience-methods-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/test-convenience-methods-expected.txt.
  • accessibility/mac/test-convenience-methods.html: Renamed from LayoutTests/platform/mac/accessibility/test-convenience-methods.html.
  • accessibility/mac/text-marker-for-bounds-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/text-marker-for-bounds-expected.txt.
  • accessibility/mac/text-marker-for-bounds.html: Renamed from LayoutTests/platform/mac/accessibility/text-marker-for-bounds.html.
  • accessibility/mac/text-marker-length-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/text-marker-length-expected.txt.
  • accessibility/mac/text-marker-length.html: Renamed from LayoutTests/platform/mac/accessibility/text-marker-length.html.
  • accessibility/mac/textbox-role-reports-line-number-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-line-number-expected.txt.
  • accessibility/mac/textbox-role-reports-line-number.html: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-line-number.html.
  • accessibility/mac/textbox-role-reports-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-notifications-expected.txt.
  • accessibility/mac/textbox-role-reports-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-notifications.html.
  • accessibility/mac/textmarker-for-index-out-of-bounds-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt.
  • accessibility/mac/textmarker-for-index-out-of-bounds-crash.html: Renamed from LayoutTests/platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html.
  • accessibility/mac/textmarker-routines-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textmarker-routines-expected.txt.
  • accessibility/mac/textmarker-routines.html: Renamed from LayoutTests/platform/mac/accessibility/textmarker-routines.html.
  • accessibility/mac/title-attribute-not-used-as-axtitle-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-not-used-as-axtitle-expected.txt.
  • accessibility/mac/title-attribute-not-used-as-axtitle.html: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-not-used-as-axtitle.html.
  • accessibility/mac/title-attribute-used-as-last-resort-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt.
  • accessibility/mac/title-attribute-used-as-last-resort.html: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-used-as-last-resort.html.
  • accessibility/mac/unexpected-help-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/unexpected-help-text-expected.txt.
  • accessibility/mac/unexpected-help-text.html: Renamed from LayoutTests/platform/mac/accessibility/unexpected-help-text.html.
  • accessibility/mac/unsupported-attribute-does-not-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/unsupported-attribute-does-not-crash-expected.txt.
  • accessibility/mac/unsupported-attribute-does-not-crash.html: Renamed from LayoutTests/platform/mac/accessibility/unsupported-attribute-does-not-crash.html.
  • accessibility/mac/update-children-when-aria-role-changes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt.
  • accessibility/mac/update-children-when-aria-role-changes.html: Renamed from LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes.html.
  • accessibility/mac/updating-attribute-in-table-row-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt.
  • accessibility/mac/updating-attribute-in-table-row-crash.html: Renamed from LayoutTests/platform/mac/accessibility/updating-attribute-in-table-row-crash.html.
  • accessibility/mac/value-change-userinfo-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/value-change-userinfo-expected.txt.
  • accessibility/mac/value-change-userinfo.html: Renamed from LayoutTests/platform/mac/accessibility/value-change-userinfo.html.
  • accessibility/mac/visible-position-crash-for-text-node-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt.
  • accessibility/mac/visible-position-crash-for-text-node.html: Renamed from LayoutTests/platform/mac/accessibility/visible-position-crash-for-text-node.html.
  • accessibility/mac/webarea-can-set-focus-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webarea-can-set-focus-expected.txt.
  • accessibility/mac/webarea-can-set-focus.html: Renamed from LayoutTests/platform/mac/accessibility/webarea-can-set-focus.html.
  • accessibility/mac/webarea-size-equals-content-size-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webarea-size-equals-content-size-expected.txt.
  • accessibility/mac/webarea-size-equals-content-size.html: Renamed from LayoutTests/platform/mac/accessibility/webarea-size-equals-content-size.html.
  • accessibility/mac/webkit-alt-for-css-content-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webkit-alt-for-css-content-expected.txt.
  • accessibility/mac/webkit-alt-for-css-content.html: Renamed from LayoutTests/platform/mac/accessibility/webkit-alt-for-css-content.html.
  • accessibility/mac/webkit-scrollarea-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea-expected.txt.
  • accessibility/mac/webkit-scrollarea-position-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea-position-expected.txt.
  • accessibility/mac/webkit-scrollarea-position.html: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea-position.html.
  • accessibility/mac/webkit-scrollarea.html: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea.html.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/accessibility/press-action-is-first-expected.txt: Removed.
  • platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Removed.
  • platform/wk2/TestExpectations:
7:12 PM Changeset in webkit [187798] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

6:39 PM Changeset in webkit [187797] by mmaxfield@apple.com
  • 6 edits
    2 adds in trunk

REGRESSION(r184899): Crash when focusing an input element styled with a web font
https://bugs.webkit.org/show_bug.cgi?id=147616
<rdar://problem/21838271>

Reviewed by Dean Jackson.

Source/WebCore:

NSFontManager can't handle web fonts. We used to pass null to NSFontManager in this case,
but r184899 changed that.

Test: fast/text/input-webfont-focus.html

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::activatedFont):

Source/WebKit/mac:

NSFontManager can't handle web fonts. We used to pass null to NSFontManager in this case,
but r184899 changed that.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

LayoutTests:

  • fast/text/input-webfont-focus-expected.txt: Added.
  • fast/text/input-webfont-focus.html: Added.
6:27 PM Changeset in webkit [187796] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.1

New tag.

6:16 PM Changeset in webkit [187795] by Gyuyoung Kim
  • 21 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Rearrange uses of USE_COORDINATED_GRAPHICS_MULTIPROCESS
https://bugs.webkit.org/show_bug.cgi?id=147256

Reviewed by Benjamin Poulain.

Reduce uses of USE_COORDINATED_GRAPHICS_MULTIPROCESS guard in order to fix build
breaks when USE_COORDINATED_GRAPHICS_MULTIPROCESS is off. This is first step to switch
between multiprocess model to thread model.

  • PlatformEfl.cmake:
  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewFindZoomableAreaForRect):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::commitCoordinatedGraphicsState):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • UIProcess/CoordinatedGraphics/PageViewportController.cpp:

(WebKit::PageViewportController::pageTransitionViewportReady):

  • UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:
  • UIProcess/CoordinatedGraphics/WebView.cpp:
  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::commitPageTransitionViewport):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::pageDidRequestScroll):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
6:14 PM Changeset in webkit [187794] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix uninitialized property leading to an assert.

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::PutPropertySlot):

6:11 PM Changeset in webkit [187793] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix.

It turns out that the IFEQ command (at least on Cygwin) does not
understand Wildcards for OS types. Consequently, we should not use
Windows* in makefiles. Luckily, we only need Windows_NT anymore.

  • DerivedSources.make: Change Windows* -> Windows_NT to correct build.
5:48 PM Changeset in webkit [187792] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r186916): TextIndicators for multiline link previews are unreadable/offset/blank
https://bugs.webkit.org/show_bug.cgi?id=147615
<rdar://problem/22116575>

Reviewed by Dean Jackson.

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
No need to offset by the difference between the text bounding rect and the selection bounding rect,
because the snapshot is now (after r186916) taken of exactly the text bounding rect.

5:39 PM Changeset in webkit [187791] by basile_clement@apple.com
  • 29 edits
    1 add in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Implement the tail call opcodes in the DFG
https://bugs.webkit.org/show_bug.cgi?id=146850

Reviewed by Michael Saboff.

This patch adds support for tail calls in the DFG. This requires a slightly high number of nodes:

  • TailCall and TailCallVarargs are straightforward. They are terminal nodes and have the semantics of an actual tail call.
  • TailCallInlinedCaller and TailCallVarargsInlinedCaller are here to perform a tail call inside an inlined function. They are non terminal nodes, and are performing the call as a regular call after popping an appropriate number of inlined tail call frames.
  • TailCallForwardVarargs and TailCallForwardVarargsInlinedCaller are the extension of TailCallVarargs and TailCallVarargsInlinedCaller to enable the varargs forwarding optimization so that we don't lose performance with a tail call instead of a regular call.

This also required two broad kind of changes:

  • Changes in the JIT itself (DFGSpeculativeJIT) are pretty straightforward since they are just an extension of the baseline JIT changes introduced previously.
  • Changes in the runtime are mostly related with handling inline call frames. The idea here is that we have a special TailCall type for call frames that indicates to the various pieces of code walking the inline call frame that they should (recursively) skip the caller in their analysis.
  • bytecode/CallMode.h:

(JSC::specializationKindFor):

  • bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):
(JSC::CodeOrigin::inlineStack):
(JSC::InlineCallFrame::dumpInContext):
(WTF::printInternal):

  • bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::callModeFor):
(JSC::InlineCallFrame::kindFor):
(JSC::InlineCallFrame::varargsKindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::isVarargs):
(JSC::InlineCallFrame::isTail):
(JSC::InlineCallFrame::computeCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerInlineFrameSkippingDeadFrames):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::findTerminal):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::allInlineFramesAreTailCalls):
(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsLiveInBytecode):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasCallVarargsData):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVarargsForwardingPhase.cpp:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeOffsetFromCodeOriginIndex):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::gotoNextFrame):

  • jit/CCallHelpers.h:
  • tests/stress/dfg-tail-calls.js: Added.
5:30 PM Changeset in webkit [187790] by mrajca@apple.com
  • 9 edits in trunk/Source

Media Session: let UI clients query whether a media element is paused
https://bugs.webkit.org/show_bug.cgi?id=147588

Reviewed by Tim Horton.

WebCore:

  • page/Page.cpp:

(WebCore::Page::isMediaElementPaused): Determine if the media element with the given ID is paused.

  • page/Page.h:

WebKit2: Added plumbing to determine if a page's media element is paused.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isMediaElementPaused):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::isMediaElementPaused):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:19 PM Changeset in webkit [187789] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187751. rdar://problem/22018044

5:19 PM Changeset in webkit [187788] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/LayoutTests

Merge r187778. rdar://problem/22098457

5:19 PM Changeset in webkit [187787] by matthew_hanson@apple.com
  • 1 edit
    5 adds in branches/safari-601.1-branch/LayoutTests

Merge r187752. rdar://problem/22098457

5:19 PM Changeset in webkit [187786] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187740. rdar://problem/22098457

5:19 PM Changeset in webkit [187785] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187466. rdar://problem/21960398

5:19 PM Changeset in webkit [187784] by matthew_hanson@apple.com
  • 1 edit in branches/safari-601.1-branch/Source/WebCore/ChangeLog

Merge r187675. rdar://problem/21632211

4:45 PM Changeset in webkit [187783] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows.

  • bytecode/ObjectPropertyConditionSet.h:

(JSC::ObjectPropertyConditionSet::fromRawPointer):

4:29 PM Changeset in webkit [187782] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r187778. rdar://problem/22098457

4:29 PM Changeset in webkit [187781] by matthew_hanson@apple.com
  • 1 edit
    5 adds in branches/safari-601.1.46-branch/LayoutTests

Merge r187752. rdar://problem/22098457

4:13 PM Changeset in webkit [187780] by fpizlo@apple.com
  • 48 edits
    24 adds
    4 deletes in trunk

DFG should have adaptive structure watchpoints
https://bugs.webkit.org/show_bug.cgi?id=146929

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Before this change, if you wanted to efficiently validate whether an object has (or doesn't have) a
property, you'd check that the object still has the structure that you first saw the object have. We
optimized this a bit with transition watchpoints on the structure, which sometimes allowed us to
elide the structure check.

But this approach fails when that object frequently has new properties added to it. This would
change the structure and fire the transition watchpoint, so the code we emitted would be invalid and
we'd have to recompile either the IC or an entire code block.

This change introduces a new concept: an object property condition. This value describes some
condition involving a property on some object. There are four kinds: presence, absence,
absence-of-setter, and equivalence. For example, a presence condition says that we expect that the
object has some property at some offset with some attributes. This allows us to implement a new kind
of watchpoint, which knows about the object property condition that it's being used to enforce. If
the watchpoint fires because of a structure transition, the watchpoint may simply reinstall itself
on the new structure.

Object property conditions are used on the prototype chain of PutById transitions, GetById misses,
and prototype accesses. They are also used for any DFG accesses to object constants, including
global property accesses.

Mostly because of the effect on global property access, this is a 9% speed-up on Kraken. It's
neutral on most other things. It's a 68x speed-up on a microbenchmark that illustrates the prototype
chain situation. It's also a small speed-up on getter-richards.

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):

  • bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/ComplexGetStatus.h:

(JSC::ComplexGetStatus::ComplexGetStatus):
(JSC::ComplexGetStatus::takesSlowPath):
(JSC::ComplexGetStatus::kind):
(JSC::ComplexGetStatus::offset):
(JSC::ComplexGetStatus::conditionSet):
(JSC::ComplexGetStatus::attributes): Deleted.
(JSC::ComplexGetStatus::specificValue): Deleted.
(JSC::ComplexGetStatus::chain): Deleted.

  • bytecode/ConstantStructureCheck.cpp: Removed.
  • bytecode/ConstantStructureCheck.h: Removed.
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::~GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):
(JSC::GetByIdVariant::baseStructure): Deleted.

  • bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::operator!):
(JSC::GetByIdVariant::structureSet):
(JSC::GetByIdVariant::conditionSet):
(JSC::GetByIdVariant::offset):
(JSC::GetByIdVariant::callLinkStatus):
(JSC::GetByIdVariant::constantChecks): Deleted.
(JSC::GetByIdVariant::alternateBase): Deleted.

  • bytecode/ObjectPropertyCondition.cpp: Added.

(JSC::ObjectPropertyCondition::dumpInContext):
(JSC::ObjectPropertyCondition::dump):
(JSC::ObjectPropertyCondition::structureEnsuresValidityAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::validityRequiresImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::isStillValid):
(JSC::ObjectPropertyCondition::structureEnsuresValidity):
(JSC::ObjectPropertyCondition::isWatchableAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::isWatchable):
(JSC::ObjectPropertyCondition::isStillLive):
(JSC::ObjectPropertyCondition::validateReferences):
(JSC::ObjectPropertyCondition::attemptToMakeEquivalenceWithoutBarrier):

  • bytecode/ObjectPropertyCondition.h: Added.

(JSC::ObjectPropertyCondition::ObjectPropertyCondition):
(JSC::ObjectPropertyCondition::presenceWithoutBarrier):
(JSC::ObjectPropertyCondition::presence):
(JSC::ObjectPropertyCondition::absenceWithoutBarrier):
(JSC::ObjectPropertyCondition::absence):
(JSC::ObjectPropertyCondition::absenceOfSetterWithoutBarrier):
(JSC::ObjectPropertyCondition::absenceOfSetter):
(JSC::ObjectPropertyCondition::equivalenceWithoutBarrier):
(JSC::ObjectPropertyCondition::equivalence):
(JSC::ObjectPropertyCondition::operator!):
(JSC::ObjectPropertyCondition::object):
(JSC::ObjectPropertyCondition::condition):
(JSC::ObjectPropertyCondition::kind):
(JSC::ObjectPropertyCondition::uid):
(JSC::ObjectPropertyCondition::hasOffset):
(JSC::ObjectPropertyCondition::offset):
(JSC::ObjectPropertyCondition::hasAttributes):
(JSC::ObjectPropertyCondition::attributes):
(JSC::ObjectPropertyCondition::hasPrototype):
(JSC::ObjectPropertyCondition::prototype):
(JSC::ObjectPropertyCondition::hasRequiredValue):
(JSC::ObjectPropertyCondition::requiredValue):
(JSC::ObjectPropertyCondition::hash):
(JSC::ObjectPropertyCondition::operator==):
(JSC::ObjectPropertyCondition::isHashTableDeletedValue):
(JSC::ObjectPropertyCondition::isCompatibleWith):
(JSC::ObjectPropertyCondition::watchingRequiresStructureTransitionWatchpoint):
(JSC::ObjectPropertyCondition::watchingRequiresReplacementWatchpoint):
(JSC::ObjectPropertyCondition::isValidValueForPresence):
(JSC::ObjectPropertyConditionHash::hash):
(JSC::ObjectPropertyConditionHash::equal):

  • bytecode/ObjectPropertyConditionSet.cpp: Added.

(JSC::ObjectPropertyConditionSet::forObject):
(JSC::ObjectPropertyConditionSet::forConditionKind):
(JSC::ObjectPropertyConditionSet::numberOfConditionsWithKind):
(JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition):
(JSC::ObjectPropertyConditionSet::slotBaseCondition):
(JSC::ObjectPropertyConditionSet::mergedWith):
(JSC::ObjectPropertyConditionSet::structuresEnsureValidity):
(JSC::ObjectPropertyConditionSet::structuresEnsureValidityAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyConditionSet::needImpurePropertyWatchpoint):
(JSC::ObjectPropertyConditionSet::areStillLive):
(JSC::ObjectPropertyConditionSet::dumpInContext):
(JSC::ObjectPropertyConditionSet::dump):
(JSC::generateConditionsForPropertyMiss):
(JSC::generateConditionsForPropertySetterMiss):
(JSC::generateConditionsForPrototypePropertyHit):
(JSC::generateConditionsForPrototypePropertyHitCustom):
(JSC::generateConditionsForPropertySetterMissConcurrently):

  • bytecode/ObjectPropertyConditionSet.h: Added.

(JSC::ObjectPropertyConditionSet::ObjectPropertyConditionSet):
(JSC::ObjectPropertyConditionSet::invalid):
(JSC::ObjectPropertyConditionSet::nonEmpty):
(JSC::ObjectPropertyConditionSet::isValid):
(JSC::ObjectPropertyConditionSet::isEmpty):
(JSC::ObjectPropertyConditionSet::begin):
(JSC::ObjectPropertyConditionSet::end):
(JSC::ObjectPropertyConditionSet::releaseRawPointer):
(JSC::ObjectPropertyConditionSet::adoptRawPointer):
(JSC::ObjectPropertyConditionSet::fromRawPointer):
(JSC::ObjectPropertyConditionSet::Data::Data):

  • bytecode/PolymorphicGetByIdList.cpp:

(JSC::GetByIdAccess::GetByIdAccess):
(JSC::GetByIdAccess::~GetByIdAccess):
(JSC::GetByIdAccess::visitWeak):

  • bytecode/PolymorphicGetByIdList.h:

(JSC::GetByIdAccess::GetByIdAccess):
(JSC::GetByIdAccess::structure):
(JSC::GetByIdAccess::conditionSet):
(JSC::GetByIdAccess::stubRoutine):
(JSC::GetByIdAccess::chain): Deleted.
(JSC::GetByIdAccess::chainCount): Deleted.

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::conditionSet):
(JSC::PutByIdAccess::stubRoutine):
(JSC::PutByIdAccess::chain): Deleted.
(JSC::PutByIdAccess::chainCount): Deleted.

  • bytecode/PropertyCondition.cpp: Added.

(JSC::PropertyCondition::dumpInContext):
(JSC::PropertyCondition::dump):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint):
(JSC::PropertyCondition::isStillValid):
(JSC::PropertyCondition::isWatchableWhenValid):
(JSC::PropertyCondition::isWatchableAssumingImpurePropertyWatchpoint):
(JSC::PropertyCondition::isWatchable):
(JSC::PropertyCondition::isStillLive):
(JSC::PropertyCondition::validateReferences):
(JSC::PropertyCondition::isValidValueForAttributes):
(JSC::PropertyCondition::isValidValueForPresence):
(JSC::PropertyCondition::attemptToMakeEquivalenceWithoutBarrier):
(WTF::printInternal):

  • bytecode/PropertyCondition.h: Added.

(JSC::PropertyCondition::PropertyCondition):
(JSC::PropertyCondition::presenceWithoutBarrier):
(JSC::PropertyCondition::presence):
(JSC::PropertyCondition::absenceWithoutBarrier):
(JSC::PropertyCondition::absence):
(JSC::PropertyCondition::absenceOfSetterWithoutBarrier):
(JSC::PropertyCondition::absenceOfSetter):
(JSC::PropertyCondition::equivalenceWithoutBarrier):
(JSC::PropertyCondition::equivalence):
(JSC::PropertyCondition::operator!):
(JSC::PropertyCondition::kind):
(JSC::PropertyCondition::uid):
(JSC::PropertyCondition::hasOffset):
(JSC::PropertyCondition::offset):
(JSC::PropertyCondition::hasAttributes):
(JSC::PropertyCondition::attributes):
(JSC::PropertyCondition::hasPrototype):
(JSC::PropertyCondition::prototype):
(JSC::PropertyCondition::hasRequiredValue):
(JSC::PropertyCondition::requiredValue):
(JSC::PropertyCondition::hash):
(JSC::PropertyCondition::operator==):
(JSC::PropertyCondition::isHashTableDeletedValue):
(JSC::PropertyCondition::isCompatibleWith):
(JSC::PropertyCondition::watchingRequiresStructureTransitionWatchpoint):
(JSC::PropertyCondition::watchingRequiresReplacementWatchpoint):
(JSC::PropertyConditionHash::hash):
(JSC::PropertyConditionHash::equal):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::makesCalls):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::attemptToMergeTransitionWithReplace):
(JSC::PutByIdVariant::dumpInContext):
(JSC::PutByIdVariant::baseStructure): Deleted.

  • bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::kind):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::structureSet):
(JSC::PutByIdVariant::oldStructure):
(JSC::PutByIdVariant::conditionSet):
(JSC::PutByIdVariant::offset):
(JSC::PutByIdVariant::callLinkStatus):
(JSC::PutByIdVariant::constantChecks): Deleted.
(JSC::PutByIdVariant::alternateBase): Deleted.

  • bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint):
(JSC::StructureStubClearingWatchpoint::push):
(JSC::StructureStubClearingWatchpoint::fireInternal):
(JSC::WatchpointsOnStructureStubInfo::~WatchpointsOnStructureStubInfo):
(JSC::WatchpointsOnStructureStubInfo::addWatchpoint):
(JSC::WatchpointsOnStructureStubInfo::ensureReferenceAndAddWatchpoint):

  • bytecode/StructureStubClearingWatchpoint.h:

(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):
(JSC::WatchpointsOnStructureStubInfo::codeBlock):
(JSC::WatchpointsOnStructureStubInfo::stubInfo):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::setSeen):
(JSC::StructureStubInfo::addWatchpoint):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp: Added.

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::AdaptiveInferredPropertyValueWatchpoint):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::install):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::fireInternal):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::fireInternal):

  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h: Added.

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::key):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::StructureWatchpoint):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::PropertyWatchpoint):

  • dfg/DFGAdaptiveStructureWatchpoint.cpp: Added.

(JSC::DFG::AdaptiveStructureWatchpoint::AdaptiveStructureWatchpoint):
(JSC::DFG::AdaptiveStructureWatchpoint::install):
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

  • dfg/DFGAdaptiveStructureWatchpoint.h: Added.

(JSC::DFG::AdaptiveStructureWatchpoint::key):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstantWithStructureCheck):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::check):
(JSC::DFG::ByteCodeParser::promoteToConstant):
(JSC::DFG::ByteCodeParser::planLoad):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::presenceLike):
(JSC::DFG::ByteCodeParser::checkPresenceLike):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::emitChecks): Deleted.

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::validateReferences):

  • dfg/DFGCommonData.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::addBaseCheck):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::addChecks): Deleted.

  • dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
(JSC::DFG::InferredValueAdaptor::add):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):
(JSC::DFG::DesiredWatchpoints::DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::consider):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid):
(JSC::DFG::DesiredWatchpoints::dumpInContext):

  • dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::SetPointerAdaptor::add):
(JSC::DFG::SetPointerAdaptor::hasBeenInvalidated):
(JSC::DFG::SetPointerAdaptor::dumpInContext):
(JSC::DFG::InferredValueAdaptor::hasBeenInvalidated):
(JSC::DFG::InferredValueAdaptor::dumpInContext):
(JSC::DFG::ArrayBufferViewWatchpointAdaptor::hasBeenInvalidated):
(JSC::DFG::ArrayBufferViewWatchpointAdaptor::dumpInContext):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::hasBeenInvalidated):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::dumpInContext):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::isWatched):
(JSC::DFG::GenericDesiredWatchpoints::dumpInContext):
(JSC::DFG::DesiredWatchpoints::isWatched):
(JSC::DFG::GenericSetAdaptor::add): Deleted.
(JSC::DFG::GenericSetAdaptor::hasBeenInvalidated): Deleted.

  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::addLazily):
(JSC::DFG::DesiredWeakReferences::contains):

  • dfg/DFGDesiredWeakReferences.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::clearFlagsOnAllNodes):
(JSC::DFG::Graph::watchCondition):
(JSC::DFG::Graph::isSafeToLoad):
(JSC::DFG::Graph::livenessFor):
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::visitChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::identifiers):
(JSC::DFG::Graph::watchpoints):

  • dfg/DFGMultiGetByOffsetData.cpp: Added.

(JSC::DFG::GetByOffsetMethod::dumpInContext):
(JSC::DFG::GetByOffsetMethod::dump):
(JSC::DFG::MultiGetByOffsetCase::dumpInContext):
(JSC::DFG::MultiGetByOffsetCase::dump):
(WTF::printInternal):

  • dfg/DFGMultiGetByOffsetData.h: Added.

(JSC::DFG::GetByOffsetMethod::GetByOffsetMethod):
(JSC::DFG::GetByOffsetMethod::constant):
(JSC::DFG::GetByOffsetMethod::load):
(JSC::DFG::GetByOffsetMethod::loadFromPrototype):
(JSC::DFG::GetByOffsetMethod::operator!):
(JSC::DFG::GetByOffsetMethod::kind):
(JSC::DFG::GetByOffsetMethod::prototype):
(JSC::DFG::GetByOffsetMethod::offset):
(JSC::DFG::MultiGetByOffsetCase::MultiGetByOffsetCase):
(JSC::DFG::MultiGetByOffsetCase::set):
(JSC::DFG::MultiGetByOffsetCase::method):

  • dfg/DFGNode.h:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiGetByOffset):

  • jit/Repatch.cpp:

(JSC::repatchByIdSelfAccess):
(JSC::checkObjectPropertyCondition):
(JSC::checkObjectPropertyConditions):
(JSC::replaceWithJump):
(JSC::generateByIdStub):
(JSC::actionForCell):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::addStructureTransitionCheck): Deleted.
(JSC::emitPutTransitionStubAndGetOldStructure): Deleted.

  • runtime/IntendedStructureChain.cpp: Removed.
  • runtime/IntendedStructureChain.h: Removed.
  • runtime/JSCJSValue.h:
  • runtime/JSObject.cpp:

(JSC::throwTypeError):
(JSC::JSObject::convertToDictionary):
(JSC::JSObject::shiftButterflyAfterFlattening):

  • runtime/JSObject.h:

(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::convertToDictionary): Deleted.

  • runtime/Operations.h:

(JSC::normalizePrototypeChain):
(JSC::normalizePrototypeChainForChainAccess): Deleted.
(JSC::isPrototypeChainNormalized): Deleted.

  • runtime/PropertySlot.h:

(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::slotBase):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::ensurePropertyReplacementWatchpointSet):
(JSC::Structure::startWatchingPropertyForReplacements):
(JSC::Structure::didCachePropertyReplacement):
(JSC::Structure::dump):

  • runtime/Structure.h:
  • runtime/VM.h:
  • tests/stress/fold-multi-get-by-offset-to-get-by-offset-without-folding-the-structure-check-new.js: Added.

(foo):
(bar):
(baz):

  • tests/stress/multi-get-by-offset-self-or-proto.js: Added.

(foo):

  • tests/stress/replacement-watchpoint-dictionary.js: Added.

(foo):

  • tests/stress/replacement-watchpoint.js: Added.

(foo):

  • tests/stress/undefined-access-dictionary-then-proto-change.js: Added.

(foo):

  • tests/stress/undefined-access-then-proto-change.js: Added.

(foo):

LayoutTests:

  • js/regress/global-object-access-with-mutating-structure-expected.txt: Added.
  • js/regress/global-object-access-with-mutating-structure.html: Added.
  • js/regress/prototype-access-with-mutating-prototype-expected.txt: Added.
  • js/regress/prototype-access-with-mutating-prototype.html: Added.
  • js/regress/script-tests/global-object-access-with-mutating-structure.js: Added.

(foo):

  • js/regress/script-tests/prototype-access-with-mutating-prototype.js: Added.

(foo):

  • js/regress/script-tests/undefined-property-access.js:

(foo):
(bar):
(baz):

3:45 PM Changeset in webkit [187779] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/Websites/webkit.org

Prepare screenshots for a potential blog post

  • blog-files/css-selectors-level-4/dynamic-specificity-1x.png: Added.
  • blog-files/css-selectors-level-4/dynamic-specificity-2x.png: Added.
3:40 PM Changeset in webkit [187778] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Fix ASSERTy test added in r187752

  • http/tests/appcache/resources/identifier-test-real.php: Only post one message.
3:34 PM Changeset in webkit [187777] by Simon Fraser
  • 3 edits
    144 moves
    1 add in trunk/LayoutTests

Move platform/gtk/accessibility tests into accessibility/gtk
https://bugs.webkit.org/show_bug.cgi?id=147594

Move platform/gtk/accessibility tests into accessibility/gtk. Skip them in global TestExpectations, re-enable them in platform/gtk/TestExpectations.

  • TestExpectations:
  • accessibility/gtk/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt.
  • accessibility/gtk/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-fallback-roles-expected.txt.
  • accessibility/gtk/aria-help-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-help-expected.txt.
  • accessibility/gtk/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt.
  • accessibility/gtk/aria-inherits-presentational-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-inherits-presentational-expected.txt.
  • accessibility/gtk/aria-listbox-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-listbox-crash-expected.txt.
  • accessibility/gtk/aria-listbox-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html.
  • accessibility/gtk/aria-menubar-menuitems-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-menubar-menuitems-expected.txt.
  • accessibility/gtk/aria-options-and-menuitems-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-options-and-menuitems-crash-expected.txt.
  • accessibility/gtk/aria-options-and-menuitems-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-options-and-menuitems-crash.html.
  • accessibility/gtk/aria-roles-unignored-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt.
  • accessibility/gtk/aria-roles-unignored.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html.
  • accessibility/gtk/aria-slider-required-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt.
  • accessibility/gtk/aria-slider-required-attributes.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html.
  • accessibility/gtk/aria-switch-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-switch-text-expected.txt.
  • accessibility/gtk/aria-table-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-table-hierarchy-expected.txt.
  • accessibility/gtk/aria-toggle-button-role-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-toggle-button-role-expected.txt.
  • accessibility/gtk/aria-toggle-button-role.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-toggle-button-role.html.
  • accessibility/gtk/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt.
  • accessibility/gtk/button-accessible-name-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt.
  • accessibility/gtk/button-accessible-name.html: Renamed from LayoutTests/platform/gtk/accessibility/button-accessible-name.html.
  • accessibility/gtk/caret-browsing-select-focus-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-select-focus-expected.txt.
  • accessibility/gtk/caret-browsing-select-focus.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-select-focus.html.
  • accessibility/gtk/caret-browsing-text-focus-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-text-focus-expected.txt.
  • accessibility/gtk/caret-browsing-text-focus.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-text-focus.html.
  • accessibility/gtk/caret-offsets-and-extraneous-white-spaces-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces-expected.txt.
  • accessibility/gtk/caret-offsets-and-extraneous-white-spaces.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces.html.
  • accessibility/gtk/caret-offsets-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets-expected.txt.
  • accessibility/gtk/caret-offsets.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets.html.
  • accessibility/gtk/color-well-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/color-well-expected.txt.
  • accessibility/gtk/combobox-descendants-orientation-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt.
  • accessibility/gtk/combobox-descendants-orientation-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/combobox-descendants-orientation-crash.html.
  • accessibility/gtk/css-content-attribute-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/css-content-attribute-expected.txt.
  • accessibility/gtk/detached-object-role-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/detached-object-role-expected.txt.
  • accessibility/gtk/detached-object-role.html: Renamed from LayoutTests/platform/gtk/accessibility/detached-object-role.html.
  • accessibility/gtk/dimensions-include-descendants-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/dimensions-include-descendants-expected.txt.
  • accessibility/gtk/disabled-controls-not-focusable-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt.
  • accessibility/gtk/entry-and-password-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt.
  • accessibility/gtk/entry-and-password.html: Renamed from LayoutTests/platform/gtk/accessibility/entry-and-password.html.
  • accessibility/gtk/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt.
  • accessibility/gtk/image-link-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-link-expected.txt.
  • accessibility/gtk/image-map1-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-map1-expected.txt.
  • accessibility/gtk/image-map2-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-map2-expected.txt.
  • accessibility/gtk/image-with-alt-and-map-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-with-alt-and-map-expected.txt.
  • accessibility/gtk/img-fallsback-to-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt.
  • accessibility/gtk/inline-continuations-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/inline-continuations-expected.txt.
  • accessibility/gtk/input-slider-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/input-slider-expected.txt.
  • accessibility/gtk/input-slider.html: Renamed from LayoutTests/platform/gtk/accessibility/input-slider.html.
  • accessibility/gtk/list-detection-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/list-detection-expected.txt.
  • accessibility/gtk/list-items-always-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/list-items-always-exposed-expected.txt.
  • accessibility/gtk/list-items-always-exposed.html: Renamed from LayoutTests/platform/gtk/accessibility/list-items-always-exposed.html.
  • accessibility/gtk/lists-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/lists-expected.txt.
  • accessibility/gtk/math-multiscript-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-multiscript-attributes-expected.txt.
  • accessibility/gtk/math-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-text-expected.txt.
  • accessibility/gtk/media-controls-panel-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt.
  • accessibility/gtk/media-controls-panel-title.html: Renamed from LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html.
  • accessibility/gtk/media-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/media-element-expected.txt.
  • accessibility/gtk/media-emits-object-replacement-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt.
  • accessibility/gtk/media-emits-object-replacement.html: Renamed from LayoutTests/platform/gtk/accessibility/media-emits-object-replacement.html.
  • accessibility/gtk/menu-list-crash2-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-crash2-expected.txt.
  • accessibility/gtk/menu-list-sends-change-notification-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt.
  • accessibility/gtk/menu-list-unfocused-notifications-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-unfocused-notifications-expected.txt.
  • accessibility/gtk/menu-list-unfocused-notifications.html: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-unfocused-notifications.html.
  • accessibility/gtk/meter-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/meter-element-expected.txt.
  • accessibility/gtk/name-from-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt.
  • accessibility/gtk/name-from-label.html: Renamed from LayoutTests/platform/gtk/accessibility/name-from-label.html.
  • accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/no-notification-for-unrendered-iframe-children-expected.txt.
  • accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Renamed from LayoutTests/platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html.
  • accessibility/gtk/object-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/object-attributes-expected.txt.
  • accessibility/gtk/object-attributes.html: Renamed from LayoutTests/platform/gtk/accessibility/object-attributes.html.
  • accessibility/gtk/object-with-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt.
  • accessibility/gtk/object-with-title.html: Renamed from LayoutTests/platform/gtk/accessibility/object-with-title.html.
  • accessibility/gtk/platform-name-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/platform-name-expected.txt.
  • accessibility/gtk/plugin-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/plugin-expected.txt.
  • accessibility/gtk/press-targets-center-point-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/press-targets-center-point-expected.txt.
  • accessibility/gtk/radio-button-title-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/radio-button-title-label-expected.txt.
  • accessibility/gtk/remapped-aria-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/remapped-aria-crash-expected.txt.
  • accessibility/gtk/remapped-aria-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/remapped-aria-crash.html.
  • accessibility/gtk/render-counter-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/render-counter-text-expected.txt.
  • accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt.
  • accessibility/gtk/replaced-objects-in-anonymous-blocks.html: Renamed from LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html.
  • accessibility/gtk/roles-computedRoleString-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt.
  • accessibility/gtk/roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt.
  • accessibility/gtk/spans-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/spans-expected.txt.
  • accessibility/gtk/spans-paragraphs-and-divs-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt.
  • accessibility/gtk/spans-paragraphs-and-divs.html: Renamed from LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html.
  • accessibility/gtk/spans.html: Renamed from LayoutTests/platform/gtk/accessibility/spans.html.
  • accessibility/gtk/spinbutton-value-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt.
  • accessibility/gtk/tabindex-elements-are-accessible-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt.
  • accessibility/gtk/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt.
  • accessibility/gtk/table-cell-spans-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-cell-spans-expected.txt.
  • accessibility/gtk/table-cells-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-cells-expected.txt.
  • accessibility/gtk/table-column-headers-with-captions-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-column-headers-with-captions-expected.txt.
  • accessibility/gtk/table-detection-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-detection-expected.txt.
  • accessibility/gtk/table-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-hierarchy-expected.txt.
  • accessibility/gtk/table-one-cell-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-one-cell-expected.txt.
  • accessibility/gtk/table-roles-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-roles-hierarchy-expected.txt.
  • accessibility/gtk/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-sections-expected.txt.
  • accessibility/gtk/table-with-rules-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-with-rules-expected.txt.
  • accessibility/gtk/text-at-offset-embedded-objects-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-embedded-objects-expected.txt.
  • accessibility/gtk/text-at-offset-embedded-objects.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-embedded-objects.html.
  • accessibility/gtk/text-at-offset-newlines-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-newlines-expected.txt.
  • accessibility/gtk/text-at-offset-newlines.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-newlines.html.
  • accessibility/gtk/text-at-offset-preformatted-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-preformatted-expected.txt.
  • accessibility/gtk/text-at-offset-preformatted.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-preformatted.html.
  • accessibility/gtk/text-at-offset-simple-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-simple-expected.txt.
  • accessibility/gtk/text-at-offset-simple.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-simple.html.
  • accessibility/gtk/text-at-offset-special-chars-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-special-chars-expected.txt.
  • accessibility/gtk/text-at-offset-special-chars.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-special-chars.html.
  • accessibility/gtk/text-at-offset-textarea-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textarea-expected.txt.
  • accessibility/gtk/text-at-offset-textarea.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textarea.html.
  • accessibility/gtk/text-at-offset-textinput-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textinput-expected.txt.
  • accessibility/gtk/text-at-offset-textinput.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textinput.html.
  • accessibility/gtk/text-at-offset-wrapped-lines-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-wrapped-lines-expected.txt.
  • accessibility/gtk/text-at-offset-wrapped-lines.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-wrapped-lines.html.
  • accessibility/gtk/text-for-range-combo-box-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-combo-box-expected.txt.
  • accessibility/gtk/text-for-range-combo-box.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-combo-box.html.
  • accessibility/gtk/text-for-range-embedded-objects-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-embedded-objects-expected.txt.
  • accessibility/gtk/text-for-range-embedded-objects.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-embedded-objects.html.
  • accessibility/gtk/text-for-range-entry-and-password-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-entry-and-password-expected.txt.
  • accessibility/gtk/text-for-range-entry-and-password.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-entry-and-password.html.
  • accessibility/gtk/text-for-range-extraneous-whitespace-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-extraneous-whitespace-expected.txt.
  • accessibility/gtk/text-for-range-extraneous-whitespace.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-extraneous-whitespace.html.
  • accessibility/gtk/text-for-range-formatted-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-formatted-expected.txt.
  • accessibility/gtk/text-for-range-formatted.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-formatted.html.
  • accessibility/gtk/text-for-range-heading-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-heading-expected.txt.
  • accessibility/gtk/text-for-range-heading.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-heading.html.
  • accessibility/gtk/text-for-range-list-items-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-list-items-expected.txt.
  • accessibility/gtk/text-for-range-list-items.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-list-items.html.
  • accessibility/gtk/text-for-range-simple-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-simple-expected.txt.
  • accessibility/gtk/text-for-range-simple.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-simple.html.
  • accessibility/gtk/text-for-range-table-cells-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-table-cells-expected.txt.
  • accessibility/gtk/text-for-range-table-cells.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-table-cells.html.
  • accessibility/gtk/text-for-range-with-link-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-with-link-expected.txt.
  • accessibility/gtk/text-for-range-with-link.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-with-link.html.
  • accessibility/gtk/text-for-table-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-table-expected.txt.
  • accessibility/gtk/text-for-table.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-table.html.
  • accessibility/gtk/text-in-span-block-in-a-block-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt.
  • accessibility/gtk/text-in-span-block-in-a-block.html: Renamed from LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block.html.
  • accessibility/gtk/title-and-alt-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/title-and-alt-expected.txt.
  • accessibility/gtk/title-and-alt.html: Renamed from LayoutTests/platform/gtk/accessibility/title-and-alt.html.
  • accessibility/gtk/transformed-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt.
  • accessibility/gtk/xml-roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/xml-roles-exposed-expected.txt.
  • accessibility/gtk/xml-roles-exposed.html: Renamed from LayoutTests/platform/gtk/accessibility/xml-roles-exposed.html.
  • platform/gtk/TestExpectations:
3:20 PM Changeset in webkit [187776] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Always require user gesture to begin playing to AppleTV automatically
https://bugs.webkit.org/show_bug.cgi?id=147591

Reviewed by Jer Noble.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaState): Don't set the ExternalDeviceAutoPlayCandidate

flag until the user has explicitly triggered playback.

3:05 PM Changeset in webkit [187775] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing broken
https://bugs.webkit.org/show_bug.cgi?id=147553

Reviewed by Joseph Pecoraro.

Passing a widget to CodeMirror.setBookmark generates a viewportChange event, causing the
BreakpointActionView to update the popup for the breakpoint. The spurious update dismisses
the suggestion list, removes the CodeMirror completion hint, and causes other problems.

Now we ignore viewportChange events unless the viewport size changes. We still want to update
the popup when a carriage return or text wrap modifies the viewport.

  • UserInterface/Views/BreakpointActionView.js:

(WebInspector.BreakpointActionView.prototype._updateBody):
Evaluate and Probe actions store the current viewport size.
(WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged):
Check if viewport size has changed since last event.

2:59 PM Changeset in webkit [187774] by ap@apple.com
  • 2 edits in trunk/Tools

AppScale: Add required indices
https://bugs.webkit.org/show_bug.cgi?id=147593

Reviewed by Tim Horton.

  • QueueStatusServer/index.yaml:
2:56 PM Changeset in webkit [187773] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Application cache DataGrid has incorrect column heading styles
https://bugs.webkit.org/show_bug.cgi?id=147531

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView): Remove erroneous
"storage-view" class, which is intended for databases, not AppCache.

2:53 PM Changeset in webkit [187772] by fpizlo@apple.com
  • 3 edits
    2 adds in trunk

Check in LLVM 3.6.2 binary drops for El Capitan
https://bugs.webkit.org/show_bug.cgi?id=147582

Reviewed by Alexey Proskuryakov.

Tools:

Recognize 10.11 and use the right drops.

  • Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

Check in drops built from the LLVM 3.6.2 open source release.

These drops were built by doing:

1) Check out WebKit to a directory like /some/path/OpenSource.

2) Unpack LLVM 3.6.2 into /some/path/OpenSource/llvm. I got LLVM 3.6.2 from:

http://llvm.org/releases/3.6.2/llvm-3.6.2.src.tar.xz

3) While in /some/path/OpenSource, run Tools/Scripts/build-jsc --release. Make sure it's a
totally clean build (i.e. delete WebKitBuild before starting).

4) Run the following to create binary drops:

Tools/Scripts/export-llvm-build -i WebKitLibraries/LLVMIncludesElCapitan.tar.bz2 -l WebKitLibraries/LLVMLibrariesElCapitan.tar.bz2 -b llvm/wkLLVMBuild -B llvm/wkLLVMBuild/Release+Asserts -s llvm

  • LLVMIncludesElCapitan.tar.bz2: Added.
  • LLVMLibrariesElCapitan.tar.bz2: Added.
2:49 PM Changeset in webkit [187771] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187740. rdar://problem/22098457

2:49 PM Changeset in webkit [187770] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187466. rdar://problem/21960398

2:49 PM Changeset in webkit [187769] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187731. rdar://problem/22052829

2:49 PM Changeset in webkit [187768] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r187751. rdar://problem/22018044

2:39 PM Changeset in webkit [187767] by basile_clement@apple.com
  • 5 edits
    1 add in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Kraken/stanford-crypto-ccm crashes
https://bugs.webkit.org/show_bug.cgi?id=147561

Reviewed by Michael Saboff.

When performing a tail call, we assume that if the top of the tail
caller's frame is not stack-aligned, we can use the stack slot above it
in case we need to move the top of the frame. However, we don't enforce
this when actually performing a call, which leads to interesting (and
crashing) situations. We are already enforcing this in the "special
call" cases (calls from native code, inlined cache calls, etc.), so
this is just a matter of making sure the bytecode generator, DFG and
FTL ensure proper padding.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):

  • tests/stress/mutual-tail-call-no-stack-overflow.js:

(odd):
(even):

  • tests/stress/tail-calls-dont-overwrite-live-stack.js: Added.

(tail):
(obj.method):
(obj.get fromNative):
(getThis):

2:37 PM Changeset in webkit [187766] by Simon Fraser
  • 1 edit
    64 deletes in trunk/LayoutTests

Remove Windows XP test results
https://bugs.webkit.org/show_bug.cgi?id=147592

Reviewed by Brent Fulgham.

We no longer need to maintain Windows XP test results.

  • platform/win-xp/TestExpectations: Removed.
  • platform/win-xp/*: Removed.
2:30 PM Changeset in webkit [187765] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

Make sure error handling code APIUserContentExtensionStore closes open file descriptors
https://bugs.webkit.org/show_bug.cgi?id=147562

Reviewed by Alex Christensen.

Make sure error handling code APIUserContentExtensionStore closes open
file descriptors to avoid leaking them.

  • NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::adoptAndMapFile):

  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::compiledToFile):

2:27 PM Changeset in webkit [187764] by Beth Dakin
  • 7 edits in trunk/Source/WebKit2

Need WKWebView API to enable/disable link preview
https://bugs.webkit.org/show_bug.cgi?id=147573
-and corresponding-
rdar://problem/22077836

Reviewed by Dan Bernstein.

WKView implementation.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

New API. Call into WKView to handle Mac.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView allowsLinkPreview]):
(-[WKWebView setAllowsLinkPreview:]):

Remove the SPI declaration from WKWebViewPrivate in order to make this API.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Handle the Mac side.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView initWithFrame:processPool:configuration:webView:]):
(-[WKView allowsBackForwardNavigationGestures]):
(-[WKView allowsLinkPreview]):
(-[WKView setAllowsLinkPreview:]):

Don’t register previews when link preview is prevented.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _registerPreview]):

2:26 PM Changeset in webkit [187763] by Yusuke Suzuki
  • 4 edits
    1 add in trunk

JavascriptCore Crash in JSC::ASTBuilder::Property JSC::Parser<JSC::Lexer<unsigned char> >::parseProperty<JSC::ASTBuilder>(JSC::ASTBuilder&, bool)
https://bugs.webkit.org/show_bug.cgi?id=147538

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Due to the order of the ARROWFUNCTION token in JSTokenType enum, it is categorized as the one of the Keyword.
As a result, when lexing the property name that can take the keywords, the ARROWFUNCTION token is accidentally accepted.
This patch changes the order of the ARROWFUNCTION token in JSTokenType to make it the operator token.

  • parser/ParserTokens.h:
  • tests/stress/arrow-function-token-is-not-keyword.js: Added.

(testSyntaxError):

LayoutTests:

Update the test expectation file because '=>' is a token, not a keywowrd.

  • js/arrowfunction-syntax-errors-expected.txt:
2:05 PM Changeset in webkit [187762] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Inline video controls overlap each other while playing video in slideover mode
https://bugs.webkit.org/show_bug.cgi?id=147535
<rdar://problem/22026864>

Reviewed by Eric Carlson.

Now that the resizing code is in the shared controller, we need to
make sure to hide the timeline scrubber in iOS when the controls
get too small. This involved adding the dropped class to the timeline,
and rules for hiding to the CSS.

Meanwhile, when the page scale factor is less than one, we use the CSS zoom property
and don't need to factor in the page scale factor when calculating
the size.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateLayoutForDisplayedWidth): Don't use pageScaleFactor.

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel .dropped): Add display none for this rule.

1:56 PM Changeset in webkit [187761] by basile_clement@apple.com
  • 2 edits
    1 add in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Get and put inline caches are not properly restoring the stack pointer
https://bugs.webkit.org/show_bug.cgi?id=147583

Reviewed by Michael Saboff.

If there is a tail call in a getter, we can't rely on the stack pointer
being valid after returning from the call.

  • jit/Repatch.cpp:

(JSC::generateByIdStub):

  • tests/stress/tail-call-in-inline-cache.js: Added.

(tail):
(obj.get x):

1:47 PM Changeset in webkit [187760] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Clean up the naming for AST expression generation.
https://bugs.webkit.org/show_bug.cgi?id=147581

Patch by Keith Miller <keith_miller@apple.com> on 2015-08-03
Reviewed by Yusuke Suzuki.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createThisExpr):
(JSC::ASTBuilder::createSuperExpr):
(JSC::ASTBuilder::createNewTargetExpr):
(JSC::ASTBuilder::thisExpr): Deleted.
(JSC::ASTBuilder::superExpr): Deleted.
(JSC::ASTBuilder::newTargetExpr): Deleted.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createThisExpr):
(JSC::SyntaxChecker::createSuperExpr):
(JSC::SyntaxChecker::createNewTargetExpr):
(JSC::SyntaxChecker::thisExpr): Deleted.
(JSC::SyntaxChecker::superExpr): Deleted.
(JSC::SyntaxChecker::newTargetExpr): Deleted.

1:46 PM Changeset in webkit [187759] by msaboff@apple.com
  • 4 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Callee save registers should be saved after the stack pointer is set up
https://bugs.webkit.org/show_bug.cgi?id=147580

Reviewed by Basile Clement.

Moved the saving of callee saves to after we check for stack overflow and have
set up the stack pointer.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • llint/LowLevelInterpreter.asm:
1:40 PM Changeset in webkit [187758] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Safari is failing to remove SQLite Databases via Remove All Website Data
https://bugs.webkit.org/show_bug.cgi?id=147584
rdar://problem/22095006

Reviewed by Brady Eidson.

If we end up deleting every single database for an origin, make sure to also delete the origin.

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince):

1:29 PM Changeset in webkit [187757] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Move "starting from root" frame flattening logging to the correct place.
https://bugs.webkit.org/show_bug.cgi?id=147571

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded):
(WebCore::FrameView::layout): Deleted.

1:23 PM Changeset in webkit [187756] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Link previews sometimes don't hide the link highlight
https://bugs.webkit.org/show_bug.cgi?id=147585
<rdar://problem/22119648>

Reviewed by Beth Dakin.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interactionStartedFromPreviewItemController:]):
(-[WKContentView _interactionStoppedFromPreviewItemController:]):
(-[WKContentView _previewItemController:didDismissPreview:committing:]):
(-[WKContentView _previewItemController:willPresentPreview:forPosition:inSourceView:]): Deleted.
Use interactionStarted/Stopped, which are always called, instead of didDismiss/willPresent,
which are only called if we return a custom view controller from _presentedViewControllerForPreviewItemController.
We continue using didDismiss to inform clients of dismissal because they'll
only care if they customized the view controller.

12:54 PM Changeset in webkit [187755] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

12:52 PM Changeset in webkit [187754] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46-branch

New Branch.

12:35 PM Changeset in webkit [187753] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Do not munmap() on the main thread
https://bugs.webkit.org/show_bug.cgi?id=147569

Reviewed by Geoffrey Garen.

Do not munmap() on the main thread for performance reasons and
consistency as we already make sure to mmap() on another thread.

  • NetworkProcess/cache/NetworkCacheDataCocoa.mm:

(WebKit::NetworkCache::Data::adoptMap):

12:35 PM Changeset in webkit [187752] by beidson@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Adding a test for:
Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
<rdar://problem/22098457> and https://bugs.webkit.org/show_bug.cgi?id=147560

Reviewed by Alexey Proskuryakov.

  • http/tests/appcache/identifier-test-expected.txt: Added.
  • http/tests/appcache/identifier-test.html: Added.
  • http/tests/appcache/resources/identifier-test-real.php: Added.
  • http/tests/appcache/resources/identifier-test.manifest: Added.
  • http/tests/appcache/resources/identifier-test.php: Added.
12:29 PM Changeset in webkit [187751] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit2

Inputs with the autofocus attribute cause the keyboard to not deploy
https://bugs.webkit.org/show_bug.cgi?id=147555
<rdar://problem/22018044>

Reviewed by Andreas Kling.

Upon submitting a form by pressing "Go" on the keyboard, an <input> on the next page with the
autofocus attribute may become non-interactible. When attempting to tap on the input, nothing
seems to happen. This is because the state of WebPage upon invoking WebPage::elementDidFocus
indicates (incorrectly) that the input element is already focused, and therefore hits an early
return. To solve this, we explicitly reset m_hasFocusedDueToUserInteraction upon transitioning
to a new page.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didStartPageTransition): On iOS, resets m_hasFocusedDueToUserInteraction as

well. It was previously thought that this would be handled by blur() called on the assisted
element when submitting a form. However, pressing "Go" on the iOS keyboard is an implicit
submission and does not trigger a blur event.

12:25 PM Changeset in webkit [187750] by Yusuke Suzuki
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

Don't set up the callsite to operationGetByValDefault when the optimization is already done
https://bugs.webkit.org/show_bug.cgi?id=147577

Reviewed by Filip Pizlo.

operationGetByValDefault should be called only when the IC is not set.
operationGetByValString breaks this invariant and ASSERT(!byValInfo.stubRoutine) in
operationGetByValDefault raises the assertion failure.
In this patch, we change the callsite setting up code in operationGetByValString when
the IC is already set. And to make the operation's meaning explicitly, we changed the
name operationGetByValDefault to operationGetByValOptimize, that is aligned to the
GetById case.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • tests/stress/operation-get-by-val-default-should-not-called-for-already-optimized-site.js: Added.

(hello):

12:20 PM Changeset in webkit [187749] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Fix error handling case in Cache::dumpContentsToFile()
https://bugs.webkit.org/show_bug.cgi?id=147567

Reviewed by Andreas Kling.

Cache::dumpContentsToFile() was expecting openFile() to return 0 in case
of error. However, it returns invalidPlatformFileHandle, which is -1 on
Unix.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::dumpContentsToFile):

11:47 AM Changeset in webkit [187748] by mmaxfield@apple.com
  • 35 edits
    2 deletes in trunk

Unreviewed, rolling out r187729.
https://bugs.webkit.org/show_bug.cgi?id=147575

10% performance hit (Requested by litherum on #webkit).

Reverted changeset:

"[OS X] Font fallback is not language-sensitive"
https://bugs.webkit.org/show_bug.cgi?id=147390
http://trac.webkit.org/changeset/187729

Patch by Commit Queue <commit-queue@webkit.org> on 2015-08-03

11:45 AM Changeset in webkit [187747] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

Make sure WebMemorySampler doesn't leak file descriptor
https://bugs.webkit.org/show_bug.cgi?id=147564

Reviewed by Anders Carlsson.

WebMemorySampler was opening files but never closing them.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::stop):

  • Shared/WebMemorySampler.h:
11:24 AM Changeset in webkit [187746] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

ChildWidgetState::ChildWidgetIs* naming is redundant.
https://bugs.webkit.org/show_bug.cgi?id=147565

Reviewed by Simon Fraser.

Since strongly typed enum requires to write out 'ChildWidgetState::ChildWidgetIsDestroyed',
the enumerator list names can be shortened.

No change in behaviour.

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::peformLayoutWithFlattening):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition):

  • rendering/RenderWidget.h:
10:59 AM Changeset in webkit [187745] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Make it possible to use String::utf8() in the debugger
https://bugs.webkit.org/show_bug.cgi?id=147566

Reviewed by Tim Horton.

Add a new utf8() overload that doesn't take any parameters and just calls utf8(LenientConversion), since lldb doesn't support evaluating
function calls with default parameters at the moment.

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

  • wtf/text/WTFString.h:
10:52 AM Changeset in webkit [187744] by bshafiei@apple.com
  • 5 edits in branches/safari-600.8-branch/Source

Versioning.

10:28 AM Changeset in webkit [187743] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.17-branch/Source

Versioning.

10:28 AM Changeset in webkit [187742] by Csaba Osztrogonác
  • 1 edit
    4 deletes in trunk/Source/JavaScriptCore

[FTL] Remove unused scripts related to native call inlining
https://bugs.webkit.org/show_bug.cgi?id=147448

Reviewed by Filip Pizlo.

  • build-symbol-table-index.py: Removed.
  • copy-llvm-ir-to-derived-sources.sh: Removed.
  • create-llvm-ir-from-source-file.py: Removed.
  • create-symbol-table-index.py: Removed.
10:14 AM Changeset in webkit [187741] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

Pass ControlStates& to RenderTheme methods instead of ControlStates*
https://bugs.webkit.org/show_bug.cgi?id=147521

Reviewed by Andreas Kling.

No change in functionality.

  • platform/Theme.h:

(WebCore::Theme::selectionColor):
(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm:

(WebCore::updateStates):
(WebCore::convertControlStatesToThemeDrawState):
(WebCore::configureToggleButton):
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):
(WebCore::paintToggleButton):
(WebCore::setUpButtonCell):
(WebCore::button):
(WebCore::paintButton):
(WebCore::paintStepper):
(WebCore::ThemeMac::ensuredView):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::updateControlStatesForRenderer):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::documentViewFor):

10:06 AM Changeset in webkit [187740] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
<rdar://problem/22098457> and https://bugs.webkit.org/show_bug.cgi?id=147560

Reviewed by Alexey Proskuryakov.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest): Only grab identifierForLoadWithoutResourceLoader() if there's no ResourceLoader.

9:06 AM Changeset in webkit [187739] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

themePainted in RenderBox::paintBoxDecorations() is confusing.
https://bugs.webkit.org/show_bug.cgi?id=147492

Reviewed by Andreas Kling.

What themePainted is supposed to indicate is whether the theme requires additional border and background painting.
Rename it to borderOrBackgroundPaintingIsNeeded.

No change in behaviour.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

8:55 AM Changeset in webkit [187738] by achristensen@apple.com
  • 2 edits in trunk/Tools

[Win] Build fix after r187733.

  • WinLauncher/PageLoadTestClient.cpp:

(PageLoadTestClient::dumpRunStatistics):
wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.

8:38 AM Changeset in webkit [187737] by youenn.fablet@crf.canon.fr
  • 4 edits
    2 deletes in trunk/Source/WebCore

[EFL] http/tests/media/media-stream/disconnected-frame-already.html is crashing after r185903
https://bugs.webkit.org/show_bug.cgi?id=146834

Reviewed by Eric Carlson.

r185903 went to far in removing some tests, in particular whether the current process is related to a frame.
Readded that check.
Refactored the code to remove the need for NavigatorUserMedia class.

Covered by existing tests.

  • CMakeLists.txt: Removed NavigatorUserMedia.cpp.
  • Modules/mediastream/NavigatorUserMedia.cpp: Removed.
  • Modules/mediastream/NavigatorUserMedia.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::webkitGetUserMedia): Inlined NavigatorUserMeia::webkitGetUserMedia.

5:48 AM Changeset in webkit [187736] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/Source/WebCore

JSXMLHttpRequest::visitAdditionalChildren does not need to explicitly mark m_response
https://bugs.webkit.org/show_bug.cgi?id=147488

Reviewed by Andreas Kling.

Covered by existing tests.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitAdditionalChildren): Removed m_response marking.

1:36 AM Changeset in webkit [187735] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.9.5

WebKitGTK+ 2.9.5

1:34 AM Changeset in webkit [187734] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.9.5 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.9.5.

Aug 2, 2015:

9:33 PM Changeset in webkit [187733] by benjamin@webkit.org
  • 6 edits in trunk

Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
https://bugs.webkit.org/show_bug.cgi?id=118455

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-02
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

LivenessAnalysisPhase lights up like a christmas tree in profiles.

This patch cuts its cost by 4.
About half of the gains come from removing many rehash() when copying
the HashSet.
The last quarter is achieved by having a special add() function for initializing
a HashSet.

This makes benchmarks progress by 1-2% here and there. Nothing massive.

  • dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::process):
The m_live HashSet is only useful per block. When we are done with it,
we can transfer it to liveAtHead to avoid a copy.

Source/WTF:

Previously, when copying a HashTable, we would start from scratch
with an empty table and insert elements one by one, growing-rehashing
the table as needed.

With this patch, we have 2 improvements to remove most of the cost.

First, we compute a good size from the start. This removes all the
reallocations and rehashs.
This is where the biggest gain comes from.

The second part is a simpler version of add() when we know that
we cannot find a bucket with the same key and there cannot
be any deleted bucket.
This removes most branches from the hot loop, cutting another 25%
of the time.

  • wtf/HashTable.h:

(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::HashTable):

Tools:

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

6:44 PM Changeset in webkit [187732] by Matt Baker
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Unnamespaced Formatter classes break CSSStyleDeclarationTextEditor
https://bugs.webkit.org/show_bug.cgi?id=147544

Reviewed by Brian Burg.

Added Formatter and FormatterContentBuilder to WebInspector namespace.

  • UserInterface/Controllers/Formatter.js:
  • UserInterface/Controllers/FormatterContentBuilder.js:
  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):

  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor.prototype.prettyPrint.prettyPrintAndUpdateEditor):
(WebInspector.TextEditor.prototype.prettyPrint):

12:28 PM Changeset in webkit [187731] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: On some complex sites, iOS instantly crashes once VoiceOver is turned on
https://bugs.webkit.org/show_bug.cgi?id=147529

Reviewed by Dan Bernstein.

Sometimes after focusing on a node, it seems like the entire document is destroyed.
Accessibility the axObjectCache returns nullptr and we crash.

Despite my best efforts, I couldn't make a layout test that reproduced this. It's possible
the entire document needs to be destroyed and replaced with something.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setFocused):

11:48 AM Changeset in webkit [187730] by Matt Baker
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r187689): Timeline overview graph layout is broken
https://bugs.webkit.org/show_bug.cgi?id=147539

Reviewed by Brian Burg.

Removed timeline argument being passed to TimelineOverviewGraph constructor.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:

(WebInspector.LayoutTimelineOverviewGraph):

  • UserInterface/Views/NetworkTimelineOverviewGraph.js:

(WebInspector.NetworkTimelineOverviewGraph):

  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WebInspector.RenderingFrameTimelineOverviewGraph):

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph):

Aug 1, 2015:

5:48 PM Changeset in webkit [187729] by mmaxfield@apple.com
  • 35 edits
    2 adds in trunk

[OS X] Font fallback is not language-sensitive
https://bugs.webkit.org/show_bug.cgi?id=147390

Reviewed by Dean Jackson.

Source/WebCore:

We need to make our font fallback code sensitive to locale.

Test: fast/text/fallback-language-han.html

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):

LayoutTests:

Updating tests.

  • css3/line-break/line-break-auto-centered-expected.html:
  • css3/line-break/line-break-auto-centered.html:
  • css3/line-break/line-break-auto-postfixes-expected.html:
  • css3/line-break/line-break-auto-postfixes.html:
  • css3/line-break/line-break-loose-centered-expected.html:
  • css3/line-break/line-break-loose-centered.html:
  • css3/line-break/line-break-loose-hyphens-expected.html:
  • css3/line-break/line-break-loose-hyphens.html:
  • css3/line-break/line-break-loose-postfixes-expected.html:
  • css3/line-break/line-break-loose-postfixes.html:
  • css3/line-break/line-break-loose-sound-marks-expected.html:
  • css3/line-break/line-break-loose-sound-marks.html:
  • css3/line-break/line-break-normal-centered-expected.html:
  • css3/line-break/line-break-normal-centered.html:
  • css3/line-break/line-break-normal-hyphens-expected.html:
  • css3/line-break/line-break-normal-hyphens.html:
  • css3/line-break/line-break-normal-postfixes-expected.html:
  • css3/line-break/line-break-normal-postfixes.html:
  • css3/line-break/line-break-normal-sound-marks-expected.html:
  • css3/line-break/line-break-normal-sound-marks.html:
  • css3/line-break/line-break-strict-centered-expected.html:
  • css3/line-break/line-break-strict-centered.html:
  • css3/line-break/line-break-strict-hyphens-expected.html:
  • css3/line-break/line-break-strict-hyphens.html:
  • css3/line-break/line-break-strict-postfixes-expected.html:
  • css3/line-break/line-break-strict-postfixes.html:
  • css3/line-break/line-break-strict-sound-marks-expected.html:
  • css3/line-break/line-break-strict-sound-marks.html:
  • fast/text/fallback-language-han-expected.html: Added.
  • fast/text/fallback-language-han.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
4:49 PM Changeset in webkit [187728] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

CharacterFallbackMapKey should be locale-specific
https://bugs.webkit.org/show_bug.cgi?id=147532

Reviewed by Dean Jackson.

This is in preparation for locale-specific font fallback.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):

4:39 PM Changeset in webkit [187727] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

2:53 PM Changeset in webkit [187726] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix 64-bit CMake build on Windows.

  • PlatformWin.cmake:

Win64 needs PaintHooks.asm.

1:43 PM Changeset in webkit [187725] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Test gardening

Unreviewed

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-08-01

  • platform/win/TestExpectations:
1:15 PM Changeset in webkit [187724] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Expand CharacterFallbackMapKey to a struct
https://bugs.webkit.org/show_bug.cgi?id=147530

Reviewed by Dean Jackson.

This is in prepraration for making this struct locale-specific.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::isHashTableDeletedValue):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::CharacterFallbackMapKeyHash::equal):
(WebCore::Font::systemFallbackFontForCharacter):

1:14 PM Changeset in webkit [187723] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WTF

HashTraits<AtomicString> can use SimpleClassHashTraits
https://bugs.webkit.org/show_bug.cgi?id=147528

Reviewed by Andreas Kling.

No point in duplicating the code inside SimpleClassHashTraits.

  • wtf/text/AtomicStringHash.h:

(WTF::HashTraits<WTF::AtomicString>::constructDeletedValue): Deleted.
(WTF::HashTraits<WTF::AtomicString>::isDeletedValue): Deleted.

1:08 PM Changeset in webkit [187722] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build after r187721

Unreviewed.

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-08-01

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):

12:55 PM Changeset in webkit [187721] by achristensen@apple.com
  • 6 edits in trunk/Source

Fix compile errors with VS2015
https://bugs.webkit.org/show_bug.cgi?id=147526

Reviewed by Myles Maxfield.

Source/WebCore:

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):
Explicitly call the Ref constructor to avoid unresolved symbols with VS2015.
Otherwise, VS2015 tries to use CSSPrimitiveValue::operator<Ref<CSSPrimitiveValue> > which doesn't exist.

Source/WebKit/win:

  • WebKitDLL.cpp:

(shutDownWebKit):
(loadResourceIntoBuffer): Needs to be exported from WebKit.dll to link with CMake using VS2015.

Source/WTF:

  • wtf/StringExtras.h:

(snprintf):
(wtf_vsnprintf):
VS2015 has an implementation of snprintf.

11:16 AM Changeset in webkit [187720] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46

New tag.

10:11 AM WebKitGTK/2.8.x edited by Michael Catanzaro
Propose some merges (diff)
10:06 AM Changeset in webkit [187719] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187686. rdar://problem/22083354

8:34 AM Changeset in webkit [187718] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187687. rdar://problem/21939014

8:27 AM Changeset in webkit [187717] by saambarati1@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Remove unintentional "print" statement in test case.
https://bugs.webkit.org/show_bug.cgi?id=142567

  • tests/stress/class-syntax-definition-semantics.js:

(shouldBeSyntaxError):

8:23 AM Changeset in webkit [187716] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

3:55 AM Changeset in webkit [187715] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Replace "unknown-mac" CSS class with "el-capitan"
https://bugs.webkit.org/show_bug.cgi?id=147524

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Platform.js:

No need to repeat WebInspector.Platform.version.release for every possible case.

  • UserInterface/Views/Toolbar.css:

(body:not(.el-capitan) .toolbar .dashboard-container):
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]):
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]:focus):
(body:not(.el-capitan) .toolbar .item.button:active):
(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container):
(body.el-capitan .toolbar .dashboard-container):
(body.el-capitan .toolbar .search-bar > input[type="search"]):
(body.el-capitan .toolbar .search-bar > input[type="search"]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.el-capitan .toolbar .item.button:active):
(body.el-capitan.window-inactive .toolbar .dashboard-container):
(body:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]): Deleted.
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body:not(.unknown-mac) .toolbar .item.button:active): Deleted.
(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
(body.unknown-mac .toolbar .dashboard-container): Deleted.
(body.unknown-mac .toolbar .search-bar > input[type="search"]): Deleted.
(body.unknown-mac .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body.unknown-mac .toolbar .item.button:active): Deleted.
(body.unknown-mac.window-inactive .toolbar .dashboard-container): Deleted.

Jul 31, 2015:

11:48 PM Changeset in webkit [187714] by Devin Rousso
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: inherited CSS rules disappear from Styles sidebar while editing
https://bugs.webkit.org/show_bug.cgi?id=147441

Reviewed by Timothy Hatcher.

If the user edits a style declaration such that it would dissapear mid-edit, prevent
the rules panel from refreshing until that editor is blurred.

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):
(WebInspector.CSSStyleDeclarationSection.prototype.get editorActive):
(WebInspector.CSSStyleDeclarationSection.prototype.get _hasInvalidSelector):
(WebInspector.CSSStyleDeclarationSection.prototype._editorContentChanged):
(WebInspector.CSSStyleDeclarationSection.prototype._editorBlurred):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._editorBlured):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel):
(WebInspector.RulesStyleDetailsPanel.prototype._removeSectionWithActiveEditor):

  • UserInterface/Views/StyleDetailsPanel.js:

(WebInspector.StyleDetailsPanel.prototype._refreshPreservingScrollPosition):

11:47 PM Changeset in webkit [187713] by mrajca@apple.com
  • 9 edits in trunk/Source

Media Session: inform the UI process when the focused Content media element changes
https://bugs.webkit.org/show_bug.cgi?id=147323

Reviewed by Tim Horton.

WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playInternal): Eventually tell the UI process that the focused Content media element changed.

  • page/ChromeClient.h:

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedContentMediaElementDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:39 PM Changeset in webkit [187712] by mrajca@apple.com
  • 3 edits in trunk/Source/WebCore

Media Session: give media elements unique IDs https://bugs.webkit.org/show_bug.cgi?id=147322

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::elementIDsToElements): Create a global map of element IDs to elements.
(WebCore::HTMLMediaElement::elementWithID): Retrieve the element with the given ID.
(WebCore::HTMLMediaElement::HTMLMediaElement): Give the element a unique ID.
(WebCore::HTMLMediaElement::playInternal): Removed whitespace.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::elementID):

11:27 PM Changeset in webkit [187711] by mmaxfield@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Adding -expected.png for fast/text/international/arabic-justify.html

  • platform/mac-yosemite/fast/text/international/arabic-justify-expected.png: Added
10:33 PM Changeset in webkit [187710] by mrajca@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Media Session: add test to ensure that switching media sessions pauses elements
https://bugs.webkit.org/show_bug.cgi?id=147493

Reviewed by Eric Carlson.

  • media/session/switching-sessions-expected.txt: Added.
  • media/session/switching-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:27 PM Changeset in webkit [187709] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build

Unreviewed.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::lookupCTFont):

9:15 PM Changeset in webkit [187708] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Autocomplete: Undo (Cmd+Z) doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=147316

Reviewed by Timothy Hatcher.

Instead of replacing the text for a completion, which messes up the undo history, add
a unique marker that contains the remaining text for the current completion.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):

9:06 PM Changeset in webkit [187707] by mmaxfield@apple.com
  • 6 edits in trunk/Source/WebCore

[OS X] Migrate to CTFontCreateForCharactersWithLanguage from [NSFont findFontLike:forString:withRange:inLanguage]
https://bugs.webkit.org/show_bug.cgi?id=147483

Reviewed by Dean Jackson.

[NSFont findFontLike:forString:withRange:inLanguage] doesn't properly handle its last argument. In
addition, we want to be moving away from NSFont in the first place and on to Core Text. This new
CoreText function correctly handles its language argument, which is required for language-specific
font fallback.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/FontCache.h:

(WebCore::FontCache::platformPurgeInactiveFontData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fallbackDedupSet):
(WebCore::FontCache::platformPurgeInactiveFontData):
(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/spi/cocoa/CoreTextSPI.h:
  • platform/spi/mac/NSFontSPI.h:
8:41 PM Changeset in webkit [187706] by Chris Dumez
  • 31 edits in trunk/Source

Drop dummy Timer callbacks
https://bugs.webkit.org/show_bug.cgi?id=147516

Reviewed by Alexey Proskuryakov.

Drop dummy Timer callbacks in the code base. A lot of Timer callbacks
do nothing else beside calling a particular method. In such case, we
can use the called method as Timer callback instead.

Source/WebCore:

  • css/FontLoader.cpp:

(WebCore::FontLoader::FontLoader):

  • css/FontLoader.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::styleRecalcTimerFired): Deleted.
(WebCore::Document::domCookieCacheExpiryTimerFired): Deleted.

  • dom/Document.h:
  • html/MediaController.cpp:

(MediaController::MediaController):
(MediaController::timeupdateTimerFired): Deleted.

  • html/MediaController.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired): Deleted.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::MemoryCache):
(WebCore::MemoryCache::pruneTimerFired): Deleted.

  • loader/cache/MemoryCache.h:
  • page/EventSource.cpp:

(WebCore::EventSource::EventSource):
(WebCore::EventSource::connectTimerFired): Deleted.

  • page/EventSource.h:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::delayedScrollEventTimerFired): Deleted.
(WebCore::FrameView::postLayoutTimerFired): Deleted.

  • page/FrameView.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired): Deleted.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired): Deleted.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::FontCache):
(WebCore::FontCache::purgeTimerFired): Deleted.

  • platform/graphics/FontCache.h:
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::timerFired): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired): Deleted.

Source/WebKit/mac:

  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverDataTimerFired): Deleted.

Source/WebKit2:

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired): Deleted.

8:03 PM Changeset in webkit [187705] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.45

New tag.

7:39 PM Changeset in webkit [187704] by mdaiter@apple.com
  • 2 edits in trunk/Source/WebCore

Removed pointSize from _addMarkersToList
https://bugs.webkit.org/show_bug.cgi?id=147515

Reviewed by Eric Carlson.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_addMarkersToList): Deleted.

7:39 PM Changeset in webkit [187703] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Roll out r187466. rdar://problem/21960398

6:56 PM Changeset in webkit [187702] by achristensen@apple.com
  • 8 edits in trunk

Prepare for VS2015
https://bugs.webkit.org/show_bug.cgi?id=146579

Reviewed by Jon Honeycutt.

Source/JavaScriptCore:

  • heap/Heap.h:

Fix compiler error by explicitly casting zombifiedBits to the size of a pointer.

Source/WebCore:

  • WebCore.vcxproj/build-generated-files.pl:

Find a correct preprocessor when using VS2015.

Source/WTF:

  • wtf/StdLibExtras.h:

(std::exchange):
Added preprocessor macros around functions implemented in VS2015's standard library.

Tools:

  • WinLauncher/stdafx.h:

Define STDC_LIMIT_MACROS to have access to INTMAX_MAX.

6:36 PM Changeset in webkit [187701] by Joseph Pecoraro
  • 4 edits in trunk/LayoutTests

Unreviewed gardening. Skip Media Sessions tests, the feature is not yet enabled.

  • TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
6:32 PM Changeset in webkit [187700] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Scrolling "jumps" in console
https://bugs.webkit.org/show_bug.cgi?id=147482

Reviewed by Joseph Pecoraro.

Removed focus call on messageElement.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._mousedown): Deleted.
(WebInspector.LogContentView.prototype._didFocus): Deleted.
(WebInspector.LogContentView.prototype._didBlur): Deleted.

6:22 PM Changeset in webkit [187699] by Joseph Pecoraro
  • 4 edits in trunk/LayoutTests

Unreviewed gardening. Update inspector test skips based on bots.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
5:43 PM Changeset in webkit [187698] by Chris Dumez
  • 4 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Drop HTTP method from NetworkCache::Key
https://bugs.webkit.org/show_bug.cgi?id=143348

Reviewed by Antti Koivisto.

Drop HTTP method from NetworkCache::Key as we only cache GET responses
for now. Even when we start caching HEAD responses, we likely will not
want the method to be part of the key because:

  • A HEAD response can be used to update the headers of a previously cached response to GET
  • A cached GET response may be used to satisfy subsequent HEAD requests
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeCacheKey):

  • NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::operator==):
(WebKit::NetworkCache::Key::decode):
(WebKit::NetworkCache::Key::operator=): Deleted.
(WebKit::NetworkCache::Key::computeHash): Deleted.
(WebKit::NetworkCache::Key::encode): Deleted.

  • NetworkProcess/cache/NetworkCacheKey.h:

(WebKit::NetworkCache::Key::method): Deleted.

5:29 PM Changeset in webkit [187697] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187694. rdar://problem/22015509

5:27 PM Changeset in webkit [187696] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187688. rdar://problem/22015509

5:19 PM Changeset in webkit [187695] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187684. rdar://problem/22000865

5:09 PM Changeset in webkit [187694] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] use a media-specific user gesture check
https://bugs.webkit.org/show_bug.cgi?id=147509

Reviewed by Tim Horton.

Change an enum name added in r187688.

  • dom/UserGestureIndicator.cpp:

(WebCore::isDefinite): DefinitelyProcessingMediaUserGesture -> DefinitelyProcessingPotentialUserGesture
(WebCore::UserGestureIndicator::processingUserGestureForMedia): Ditto.

  • dom/UserGestureIndicator.h: Ditto.
5:00 PM Changeset in webkit [187693] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] Latin quotes are used with the system font on Chinese devices
https://bugs.webkit.org/show_bug.cgi?id=147504

Reviewed by Dean Jackson.

The system font has some fancy logic regarding character selection which requires
using Core Text for glyph selection.

No new tests because tests can't change the system language of the device.

  • platform/graphics/mac/GlyphPageMac.cpp:

(WebCore::shouldUseCoreText):

4:57 PM Changeset in webkit [187692] by Joseph Pecoraro
  • 10 edits
    1 move
    1 add in trunk

Web Inspector: Unskip / Unflake inspector tests after r187627
https://bugs.webkit.org/show_bug.cgi?id=147503

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Base/Test.js:

(InspectorTest.completeTest):
(InspectorTest.completeTest.signalCompletionToTestPage): Deleted.
(InspectorTest.testPageDidLoad):
Instead of immediately resending results if completeTest was called
during a reload before the load has completed, we just set a flag
to complete the test when the load completes. This consistently
resends the output to the new page for test output.

(InspectorTest._resendResults):
Delete clear results. If the page had logged anything directly on
the page side (using InspectorTestProxy) this clearMessages would
have deleted those messages and not been able to recreate them.
Clearing messages wasn't really serving a purpose.

LayoutTests:

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:

Unskip and unflake inspector tests.

  • http/tests/inspector/inspector-test.js:

(InspectorTestProxy.addResult):
Simplify with the new append API.

(InspectorTestProxy.clearResults): Deleted.
Delete, as it is no longer used.

  • inspector/debugger/probe-manager-add-remove-actions-expected.txt:

Include output that was getting erronously cleared by clearResults
which we removed.

  • inspector/dom/highlightSelector-expected.txt:
  • inspector/dom/highlightSelector.html:

Make this test more reliable when run with other tests.
Never assume the frame id for the main frame or sub frame,
instead compute them and mask them in the output.

  • inspector/dom/resources/highlightSelector-iframe.html: Renamed from LayoutTests/inspector/dom/highlightSelector-iframe.html.

Move the non-test iframe html resource into a sub-folder
so it won't be treated like an actual test.

4:56 PM Changeset in webkit [187691] by Chris Dumez
  • 5 edits in trunk/Source

Source/WebCore:
Coalesce authentication credential requests
https://bugs.webkit.org/show_bug.cgi?id=128006
<rdar://problem/16839069>

Reviewed by Alexey Proskuryakov.

Export symbol for ProtectionSpace::compare() so it can be called from
WebKit2.

  • platform/network/ProtectionSpaceBase.h:

Source/WebKit2:
Coalesce concurrent authentication challenges for the same ProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=147496
<rdar://problem/16839069>

Reviewed by Alexey Proskuryakov.

Coalesce concurrent authentication challenges for the same ProtectionSpace.
Ideally, this would be done in the network layer but short term, this will
make sure the user no longer gets repeating authentication dialogs for the
same protection space.

This gets rid of a long-standing bug in WebKit / Safari where visiting a
site using HTTP authentication would pop up one authentication dialog for
each subresource being loaded from the network (especially when the main
resource is loaded from the cache).

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::canCoalesceChallenge):
(WebKit::AuthenticationManager::addChallengeToChallengeMap):
(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
(WebKit::AuthenticationManager::AuthenticationManager): Deleted.

  • Shared/Authentication/AuthenticationManager.h:
4:50 PM Changeset in webkit [187690] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip more inspector tests on Windows.

It may be that no inspector tests are working on Windows,
if that is the case we may move to skipping all of them
and investigate unskipping in chunks.

  • platform/win/TestExpectations:
4:27 PM Changeset in webkit [187689] by Brian Burg
  • 20 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert timeline view classes to ES6 classes
https://bugs.webkit.org/show_bug.cgi?id=147381

Reviewed by Joseph Pecoraro.

Along the way, inline a few style class names.

Elided mechanical changes from the Changelog.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:
  • UserInterface/Views/LayoutTimelineView.js:
  • UserInterface/Views/LinearTimelineOverview.js:
  • UserInterface/Views/NetworkTimelineOverviewGraph.js:
  • UserInterface/Views/NetworkTimelineView.js:
  • UserInterface/Views/OverviewTimelineView.js:
  • UserInterface/Views/RenderingFrameTimelineOverview.js:
  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
  • UserInterface/Views/RenderingFrameTimelineView.js:
  • UserInterface/Views/ScriptTimelineOverviewGraph.js:
  • UserInterface/Views/ScriptTimelineView.js:
  • UserInterface/Views/TimelineOverview.js:
  • UserInterface/Views/TimelineOverviewGraph.js:
  • UserInterface/Views/TimelineRecordBar.js:
  • UserInterface/Views/TimelineRecordFrame.js:
  • UserInterface/Views/TimelineRecordingContentView.js:
  • UserInterface/Views/TimelineRuler.js:
  • UserInterface/Views/TimelineTabContentView.js:
  • UserInterface/Views/TimelineView.js:
3:59 PM Changeset in webkit [187688] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

[iOS] use a media-specific user gesture check
https://bugs.webkit.org/show_bug.cgi?id=147509

Reviewed by Jer Noble.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGestureForMedia): New.

  • bindings/js/ScriptController.h:
  • dom/UserGestureIndicator.cpp:

(WebCore::isDefinite): Allow DefinitelyProcessingMediaUserGesture.
(WebCore::UserGestureIndicator::processingUserGestureForMedia): New.

  • dom/UserGestureIndicator.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load): Use ScriptController::processingUserGestureForMedia instead of

ScriptController::processingUserGesture

(WebCore::HTMLMediaElement::play): Ditto.

3:43 PM Changeset in webkit [187687] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Crashes under HTMLMediaElement::updateActiveTextTrackCues() when destroying CachedPage.
<https://webkit.org/b/147506>
<rdar://problem/21939014>

Reviewed by Chris Dumez.

Don't mess with the media element's text tracks below its ActiveDOMObject::stop()
implementation, since that may cause DOM mutations.

I don't have a repro or a test for this, but plenty of crash logs to indicate that
we're getting ourselves into trouble by modifying the DOM during CachedPage teardown.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackDisplay):

3:34 PM Changeset in webkit [187686] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] DOMNode preview snapshot rects are wrong for user-select: none links
https://bugs.webkit.org/show_bug.cgi?id=147513
<rdar://problem/22083354>

Reviewed by Simon Fraser.

  • bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):
Use the same code as WebKit2 to compute the fallback rect (if TextIndicator fails),
asking the RenderObject (or RenderImage) for its bounding box instead of using the
(often wrong) Range bounding rect.

Make sure to use the fallback rect *any* time TextIndicator fails (before
we would return no rects at all if TextIndicator::createWithRange returned null,
and the fallback rect if it returned with an empty image).

Inverse-page-scale the margin, to match the appearance in WebKit2.

3:24 PM Changeset in webkit [187685] by mmaxfield@apple.com
  • 3 edits
    3 adds in trunk

[SVG -> OTF Converter] Crash when converting Arabic fonts
https://bugs.webkit.org/show_bug.cgi?id=147510

Reviewed by Anders Carlsson.

Source/WebCore:

SVGToOTFFontConverter::compareCodepointsLexicographically() wasn't transitive.

Test: fast/text/arabic-duplicate-glyph-font.html

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):

LayoutTests:

  • fast/text/arabic-duplicate-glyph-font-expected.txt: Added.
  • fast/text/arabic-duplicate-glyph-font.html: Added.
  • fast/text/resources/arabic-duplicate-glyph-font.svg: Added.
3:20 PM Changeset in webkit [187684] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Rename AVPlayerLayerView to _AVPlayerLayerView.
https://bugs.webkit.org/show_bug.cgi?id=147399

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-31
Reviewed by Eric Carlson.

Change class name AVPlayerLayerView to match change in AVKit SPI.
This prevents conflicts with 3rd party apps.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPlayerLayerView_dealloc):
(getWebAVPlayerLayerViewClass):

  • platform/spi/cocoa/AVKitSPI.h:
2:40 PM Changeset in webkit [187683] by msaboff@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: REGRESSION(r187676): Broke stress/tail-call-no-stack-overflow.js
https://bugs.webkit.org/show_bug.cgi?id=147507

Reviewed by Basile Clement.

Changed strictLoopArityFixup1 and strictLoopArityFixup2 to recursively call
themselves instead of nonexistent strictLoopArityFixup.

  • tests/stress/tail-call-no-stack-overflow.js:

(strictLoopArityFixup1):
(strictLoopArityFixup2):

2:26 PM Changeset in webkit [187682] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

Unreviewed parameter name typo fix.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):

2:16 PM Changeset in webkit [187681] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

ImageBufferDataCG should not add IOSurfaces to the pool
https://bugs.webkit.org/show_bug.cgi?id=147494

Reviewed by Tim Horton.

ImageBufferDataCG should not add IOSurfaces to the pool as it is not
safe. IOSurfaceIsInUse() does not return accurate result for those
surfaces.

This is a partial revert of r181301.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::~ImageBufferData): Deleted.

  • platform/graphics/cg/ImageBufferDataCG.h:
2:05 PM Changeset in webkit [187680] by saambarati1@gmail.com
  • 25 edits
    2 adds in trunk

ES6 class syntax should use block scoping
https://bugs.webkit.org/show_bug.cgi?id=142567

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We treat class declarations like we do "let" declarations.
The class name is under TDZ until the class declaration
statement is evaluated. Class declarations also follow
the same rules as "let": No duplicate definitions inside
a lexical environment.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createClassDeclStatement):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClassDeclaration):

  • tests/stress/class-syntax-block-scoping.js: Added.

(assert):
(truth):
(.):

  • tests/stress/class-syntax-definition-semantics.js: Added.

(shouldBeSyntaxError):
(shouldNotBeSyntaxError):
(truth):

  • tests/stress/class-syntax-tdz.js:

(assert):
(shouldThrowTDZ):
(truth):
(.):

LayoutTests:

  • js/class-constructor-return-expected.txt:
  • js/class-syntax-call-expected.txt:
  • js/class-syntax-declaration-expected.txt:
  • js/class-syntax-default-constructor-expected.txt:
  • js/class-syntax-extends-expected.txt:
  • js/class-syntax-name-expected.txt:
  • js/class-syntax-super-expected.txt:
  • js/script-tests/class-constructor-return.js:

(shouldThrow):
(shouldNotThrow):
(shouldBeTrue):
(shouldBeFalse):

  • js/script-tests/class-syntax-call.js:

(A):
(B):
(shouldThrow):
(shouldNotThrow):

  • js/script-tests/class-syntax-declaration.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):

  • js/script-tests/class-syntax-default-constructor.js:

(shouldThrow):
(shouldBe):
(shouldBeTrue):
(assert):
(A):
(B):

  • js/script-tests/class-syntax-extends.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(Base):
(Base.prototype.baseMethod):

  • js/script-tests/class-syntax-name.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(runTestShouldBe):

  • js/script-tests/class-syntax-super.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):

1:38 PM Changeset in webkit [187679] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187675. rdar://problem/21632211

1:36 PM Changeset in webkit [187678] by basile_clement@apple.com
  • 3 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Emit a single callee-save restoration for fast and slow tail call paths
https://bugs.webkit.org/show_bug.cgi?id=147501

Reviewed by Michael Saboff.

We are currently emitting this twice for no reason.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

1:34 PM Changeset in webkit [187677] by commit-queue@webkit.org
  • 9 edits
    5 adds in trunk/Source/JavaScriptCore

Implement WebAssembly module parser
https://bugs.webkit.org/show_bug.cgi?id=147293

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-31
Reviewed by Mark Lam.

Re-landing after fix for the "..\..\jsc.cpp(46): fatal error C1083: Cannot open
include file: 'JSWASMModule.h'" issue on Windows.

Implement WebAssembly module parser for WebAssembly files produced by pack-asmjs
<https://github.com/WebAssembly/polyfill-prototype-1>. This patch only checks
the magic number at the beginning of the files. Parsing of the rest will be
implemented in a subsequent patch.

(GlobalObject::finishCreation):
(functionLoadWebAssembly):

  • parser/SourceProvider.h:

(JSC::WebAssemblySourceProvider::create):
(JSC::WebAssemblySourceProvider::data):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::wasmModuleStructure):

  • wasm/WASMMagicNumber.h: Added.
  • wasm/WASMModuleParser.cpp: Added.

(JSC::WASMModuleParser::WASMModuleParser):
(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::parseWebAssembly):

  • wasm/WASMModuleParser.h: Added.
  • wasm/WASMReader.cpp: Added.

(JSC::WASMReader::readUnsignedInt32):
(JSC::WASMReader::readFloat):
(JSC::WASMReader::readDouble):

  • wasm/WASMReader.h: Added.

(JSC::WASMReader::WASMReader):

1:31 PM Changeset in webkit [187676] by basile_clement@apple.com
  • 6 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Don't waste stack space when arity fixup was performed
https://bugs.webkit.org/show_bug.cgi?id=147447

Reviewed by Michael Saboff.

r187618 tried to handle this, but did not include the LLInt and did it
wrong anyway. When making a call, the caller first aligns the callee's
frame, then makes the call. If the callee later performs arity fixup,
it does not try to reuse the potential slot left empty by the caller's
frame alignment: instead, it aligns the parameters - arguments delta.
So when trying to find out where our frame starts, we should replicate
this behavior, which we were previously not doing and was the cause of
https://bugs.webkit.org/show_bug.cgi?id=147491.

While here, I also removed the extra slot that used to save the
returnPC for the arity fixup return thunk (that we got rid of in
https://bugs.webkit.org/show_bug.cgi?id=146847) and was now just
wasting stack space.

  • jit/CCallHelpers.h:
  • jit/ThunkGenerators.cpp:

(JSC::arityFixupGenerator):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

  • tests/stress/tail-call-no-stack-overflow.js:

(strictLoopArityFixup1):
(strictLoopArityFixup2):

1:21 PM Changeset in webkit [187675] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::postTask + 38
https://bugs.webkit.org/show_bug.cgi?id=147485

Rubber-stamped by Joseph Pecoraro.

Follow-up test crash fix: call superclass's contextDestroyed() which allows the
m_scriptExecutionContext variable to be cleared.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::contextDestroyed):
1:17 PM Changeset in webkit [187674] by msaboff@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: REGRESSION(r187639): Need to restore callee saves in LLInt before tail call
https://bugs.webkit.org/show_bug.cgi?id=147500

Reviewed by Basile Clement.

Restore callee saves at the head of the prepareForTailCall() macro.

  • llint/LowLevelInterpreter.asm:
1:15 PM Changeset in webkit [187673] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187655. rdar://problem/21632211

1:15 PM Changeset in webkit [187672] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187630. rdar://problem/18835799

1:15 PM Changeset in webkit [187671] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187614. rdar://problem/22064327

1:01 PM Changeset in webkit [187670] by msaboff@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X86-64 Windows
https://bugs.webkit.org/show_bug.cgi?id=147499

Reviewed by Basile Clement.

For X86-64, Windows, regT0 is free so use that register instead of regT5.

  • jit/ThunkGenerators.cpp:

(JSC::arityFixupGenerator):

12:43 PM Changeset in webkit [187669] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect:
<rdar://problem/22060183> and https://bugs.webkit.org/show_bug.cgi?id=147497

Reviewed by Tim Horton.

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.

Instead do a [[retain] autorelease] on it while still valid.

12:25 PM Changeset in webkit [187668] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Only generate "themeWin*" UserAgentStyleSheet constants for Windows builds
https://bugs.webkit.org/show_bug.cgi?id=147378

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-31
Reviewed by Alex Christensen.

  • DerivedSources.make:

Only include windows user agent style sheets for Windows OSes.

11:41 AM Changeset in webkit [187667] by Lucas Forschler
  • 2 edits
    1 copy in branches/safari-601.1-branch/Source/JavaScriptCore

Merged r187579. rdar://problem/21668986

11:38 AM Changeset in webkit [187666] by Lucas Forschler
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187557. rdar://problem/21412186

11:33 AM Changeset in webkit [187665] by Lucas Forschler
  • 8 edits in branches/safari-601.1-branch

Merged r187556. rdar://problem/21771620

11:30 AM Changeset in webkit [187664] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-601.1-branch

Merged r187535. rdar://problem/21852603

11:22 AM Changeset in webkit [187663] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187530. rdar://problem/21833987

11:19 AM Changeset in webkit [187662] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-601.1-branch

Merged r187525. rdar://problem/22022011

11:10 AM Changeset in webkit [187661] by Lucas Forschler
  • 26 edits in branches/safari-601.1-branch/LayoutTests

Merged r187523. rdar://problem/22010303

11:08 AM Changeset in webkit [187660] by Lucas Forschler
  • 13 edits in branches/safari-601.1-branch/Source

Merged r187522. rdar://problem/19892014

11:07 AM Changeset in webkit [187659] by achristensen@apple.com
  • 18 edits in trunk

Prepare for debug CMake builds on Windows.
https://bugs.webkit.org/show_bug.cgi?id=147484

Reviewed by Tim Horton.

.:

  • Source/cmake/OptionsWindows.cmake:

Don't use debug runtimes in debug builds because the dependencies are only built with multithreaded runtimes.

Source/WebCore:

In order to get debug builds to link on Windows with CMake, we will need to use AllInOnes.
This patch includes more files in the AllInOnes and removes some duplicate code.

  • WebCore.vcxproj/WebCore.vcxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • css/CSSAllInOne.cpp:

Many files were added to the AllInOne files. They should not be included in the Visual Studio solutions.

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::create):
Use CSSParserString::equalIgnoringCase to avoid ambiguous calls to overloaded functions.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::shouldApplyPropertyInParseOrder):
(WebCore::convertToFloatLength): Deleted.

  • css/TransformFunctions.cpp:

(WebCore::transformOperationType):
(WebCore::convertToFloatLength):

  • css/TransformFunctions.h:

Removed duplicate convertToFloatLength function.

  • html/HTMLElementsAllInOne.cpp:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::compareZIndexFlowThreadController): Renamed from compareZIndex to prevent naming conflicts.
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::compareZIndex): Deleted.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldRepaintAfterLayout):
(WebCore::compositedWithOwnBackingStore):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::compositedWithOwnBackingStore): Deleted.
Removed duplicate compositedWithOwnBackingStore.
(WebCore::paintScrollbar): Deleted duplicate function.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresScrollLayer):
(WebCore::paintScrollbar):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderingAllInOne.cpp:
11:01 AM Changeset in webkit [187658] by Lucas Forschler
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187521. rdar://problem/22038421

10:56 AM Changeset in webkit [187657] by Lucas Forschler
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187516. rdar://problem/20847009

10:49 AM Changeset in webkit [187656] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/LayoutTests

Merged r187512. rdar://problem/22010303

10:49 AM Changeset in webkit [187655] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::postTask + 38
https://bugs.webkit.org/show_bug.cgi?id=147485

Reviewed by Eric Carlson.

CrashLogs indicate a use-after-free of the ScriptExecutionContext (i.e., Document) used by
the GenericTaskQueue objects owned by HTMLMediaElement. When the ScriptExecutionContext
notifies its ActiveDOMObjects that it is about to be destroyed, close() the
GenericTaskQueues so that they can no longer accept new tasks.

Previously, enqueueing a task on a closed GenericTaskQueue ASSERTed in debug builds, but
silently succeeded in release builds. Calling enqueueTask() on a closed GenericTaskQueue is
now a no-op.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::contextDestroyed):

  • html/HTMLMediaElement.h:
  • platform/GenericTaskQueue.h:

(WebCore::GenericTaskQueue::enqueueTask):

10:08 AM Changeset in webkit [187654] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: add test for MediaSession.releaseSession()
https://bugs.webkit.org/show_bug.cgi?id=147478

Reviewed by Eric Carlson.

  • media/session/releasing-sessions-expected.txt: Added.
  • media/session/releasing-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:59 AM Changeset in webkit [187653] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: add test to ensure next/previous-track event handlers are not fired when they are disabled
https://bugs.webkit.org/show_bug.cgi?id=147477

Reviewed by Eric Carlson.

  • media/session/track-media-events-disabled-expected.txt: Added.
  • media/session/track-media-events-disabled.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:51 AM Changeset in webkit [187652] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: add test to ensure media sessions are in an Idle state after creation
https://bugs.webkit.org/show_bug.cgi?id=147471

Reviewed by Eric Carlson.

  • media/session/session-creation-expected.txt: Added.
  • media/session/session-creation.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:44 AM Changeset in webkit [187651] by Lucas Forschler
  • 12 edits in branches/safari-601.1-branch/Source

Merged r187491. rdar://problem/21718407

9:42 AM Changeset in webkit [187650] by Lucas Forschler
  • 18 edits
    34 copies
    2 deletes in branches/safari-601.1-branch

Merged r187489. rdar://problem/22010303

9:35 AM Changeset in webkit [187649] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187471. rdar://problem/22021772

9:33 AM Changeset in webkit [187648] by Lucas Forschler
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187466. rdar://problem/21960398

9:25 AM Changeset in webkit [187647] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187462. rdar://problem/22020770

9:05 AM Changeset in webkit [187646] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187459. rdar://problem/21701858

9:01 AM Changeset in webkit [187645] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187448. rdar://problem/21948230

9:00 AM Changeset in webkit [187644] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187379. rdar://problem/21948230

8:58 AM Changeset in webkit [187643] by Lucas Forschler
  • 9 edits in branches/safari-601.1-branch/Source

Merged r187375. rdar://problem/21948230

7:28 AM Changeset in webkit [187642] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[EFL] Fix pixman build on ARM with GCC 4.9.3
https://bugs.webkit.org/show_bug.cgi?id=147224

Reviewed by Gyuyoung Kim.

  • efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
5:24 AM Changeset in webkit [187641] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] NPAPI code crashes on Wayland
https://bugs.webkit.org/show_bug.cgi?id=147297

Reviewed by Žan Doberšek.

Do not crete NPAPI plugins when runing on Wayland, since they are
not supported. ENABLE_NETSCAPE_PLUGIN_API option used to be
incompatible with building with the Wayland target, but now that
we allow to build X11 and Wayland targets at the same time, we
need runtime checks to avoid creating NPAPI plugins in Wayland.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_set_enable_plugins): Do not allow to change the
setting when running in Wayland.

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore): Initialize
EnablePlugins preference to false when running in Wayland.

1:06 AM Changeset in webkit [187640] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[GTK] Have DataObjectGtk::unknownTypes() return a reference to the HashMap object
https://bugs.webkit.org/show_bug.cgi?id=147401

Reviewed by Carlos Garcia Campos.

Don't copy the DataObjectGtk::m_unknownTypes HashMap on every retrieval through
DataObjectGtk::unknownTypes(). The range-based for-loops that iterate over the
map in PasteboardGtk.cpp and PasteboardHelper.cpp are also cleaned up.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes):

  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writePasteboard):
(WebCore::Pasteboard::types):

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

Jul 30, 2015:

11:02 PM Changeset in webkit [187639] by msaboff@apple.com
  • 33 edits
    2 adds in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: LLint, Baseline and DFG JIT should save & restore platform's callee-save registers
https://bugs.webkit.org/show_bug.cgi?id=146946

Reviewed by Basile Clement.

We save platform callee save registers right below the call frame header, in the location(s)
starting with VirtualRegister 0. Allocated local space in the bytecode compiler.
This space is the maximum space needed for the callee registers that the LLInt or baseline JIT
will used, rounded up to number of VirtualRegisters. The LLInt explicitly saves and restores
the registers in the functions preserveCalleeSavesUsedByLLInt and restoreCalleeSavesUsedByLLInt.
The baseline and DFG JITs saves and restores callee saves registers by what registers are included
in m_calleeSaveRegisters in the code block.

Added code to transition callee saves from one VM's format to the another as part of OSR entry and
OSR exit. Added a helper class RegisterSaveMap that has the cannonical locations for a set of
saved registers. This is used not only to save and restore registers on function entry and exit,
but also to handle OSR entry and exit cases.

Added RegisterSaveMap to build configurations.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setCalleeSaveRegisters):
(JSC::roundCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::countReoptimization):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfLLIntBaselineCalleeSaveRegisters):
(JSC::CodeBlock::calleeSaveRegisters):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::numberOfDFGCompiles):
Methods to manage a set of callee save registers. Also to allocate the appropriate
number of VritualRegisters for callee saves.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::allocateCalleeSaveSpace):

  • bytecompiler/BytecodeGenerator.h:

Allocate the appropriate number of VritualRegisters for callee saves needed by LLInt or baseline JIT.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):
Properly handle VirtualRegisters set aside for LLInt or baseline JIT callee saves.

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::storeTrustedValue):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveCalleeSaves):
(JSC::AssemblyHelpers::emitRestoreCalleeSaves):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitMaterializeTagCheckRegisters):
(JSC::AssemblyHelpers::prologueStackPointerDelta):
Functions to save and restore callee save registers in a stack frame or other buffer.

(JSC::AssemblyHelpers::emitMaterializeTagCheckRegisters):
Helper to populate tagTypeNumberRegister and tagMaskRegister with the appropriate
constants.

  • jit/GPRInfo.h:

(JSC::GPRInfo::numberOfLLIntBaselineCalleeSaveRegisters):
Added this constant to hold the maximum number of callee save registers that we use in
the LLInt or baseline JIT.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_end):

  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):
Emit code to save and restore callee save registers and materialize tagTypeNumberRegister
and tagMaskRegister. Also handle callee saves when tiering up to the DFG.

  • jit/RegisterSaveMap.cpp: Added.

(JSC::RegisterSaveMap::RegisterSaveMap):
(JSC::RegisterSaveMap::getIndexFor):

  • jit/RegisterSaveMap.h: Added.

(JSC::RegisterSaveMap::size):
(JSC::RegisterSaveMap::has):
(JSC::RegisterSaveMap::maxOffset):
(JSC::RegisterSaveMap::getOffsetFor):
New class to track register offsets in the stack or other memory.

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::allVMCalleeSaveRegisters):
(JSC::RegisterSet::baselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):

  • jit/RegisterSet.h:

Fixed set of callee save registers for callee save regsiters in any VM, for the baseline JIT and for the
DFG.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:

Save and restor callee saves used by the LLInt. Added code to handle OSR entry.
Changed the LLInt arity fixup to always use the LLInt supplied loop as the LLInt needs to include
callee saves as they need to be saved before calling the slow path that does arity checking since the
PC register is derived from the value in a callee save register. Therefore that callee save needs to
be used before arity fixup, meaning that we need to save the prior contents.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::calleeSaveRegistersBufferOffset):
(JSC::VM::getAllCalleeSaveRegistersMap):
Provide a RegisterSaveMap that has all registers that might be saved. Added a callee save buffer to be
used for OSR exit and for exception processing in a future patch.

8:48 PM Changeset in webkit [187638] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

RenderTheme::paintBorderOnly and paintDecorations should take RenderBox instead of RenderObject.
https://bugs.webkit.org/show_bug.cgi?id=147470

Reviewed by Simon Fraser.

Tighten the code so that RenderTheme paint functions take RenderBox instead of RenderObject.

No change in functionality.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):

  • rendering/RenderTheme.h:
8:40 PM Changeset in webkit [187637] by msaboff@apple.com
  • 6 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Eliminate rdi from temp register list for X86-64 Windows
https://bugs.webkit.org/show_bug.cgi?id=147461

Reviewed by Basile Clement.

Eliminated rdi from the list of temporary registers for X86-64 Windows as it
is a callee saves register. This reduced the number of temporary registers
for X86-64 Windows. Since the LLInt needs 6 available registers in a couple
of places, added a register alias called extraTempReg which is t0 on X86-64
Windows and t5 on all other platforms.

As a result of this change, I changed the "PC" register in the LLInt from t5
to t4.

  • jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/x86.rb:
7:07 PM Changeset in webkit [187636] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.8.9

New tag.

7:06 PM Changeset in webkit [187635] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.17.8

New tag.

6:55 PM Changeset in webkit [187634] by Matt Baker
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Better share objects generated from timeline events (Records)
https://bugs.webkit.org/show_bug.cgi?id=147029

Reviewed by Brian Burg.

This patch changes the way TimelineManager processes events, preserving the event hierarchy after
converting payloads to TimelineRecord objects by retaining parent-child relationships between records.
This eliminates the need for RenderingFrameTimelineRecord objects to create a separate copy of their child
records, and provides richer data for the Timelines UI.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded):
Track the parent TimelineRecord as child record payloads are unpacked, and create
a hierarchy of TimelineRecords that mirrors the original event payload hierarchy.
(WebInspector.TimelineManager.prototype._processRecord):
RenderingFrameTimelineRecord is now processed like any other event.
(WebInspector.TimelineManager.prototype._processNestedRecords): Deleted.
Reverted back to a single pass over the incoming timeline event payload.

  • UserInterface/Models/LayoutTimelineRecord.js:

(WebInspector.LayoutTimelineRecord):
(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Deleted.
Removed duringComposite property and constructor parameter. No longer needed.

  • UserInterface/Models/RenderingFrameTimelineRecord.js:

(WebInspector.RenderingFrameTimelineRecord.prototype.get children): Deleted.
Removed children property. It now exists on the base class TimelineRecord.
Also removed code that was needed to prevent paint time from being added twice.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
(WebInspector.ScriptTimelineRecord):
Removed workaround added in:
<https://webkit.org/b/147025> Web Inspector: REGRESSION (r186218) ScriptTimelineRecord attempts to access null property

  • UserInterface/Models/TimelineRecord.js:

(WebInspector.TimelineRecord):
(WebInspector.TimelineRecord.prototype.get children):
Added children property.

  • UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
Now that we preserve the frame's child record hierarchy, we process the entire tree,
yielding richer data grid output:

Frame X

Styles Recalculated

Layout Invalidated

Composite

Paint
Paint

Compared to the previous output:

Frame X

Styles Recalculated
Layout Invalidated
Composite
Paint
Paint

6:49 PM Changeset in webkit [187633] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore

Roll out r186895. rdar://problem/21714851

6:43 PM Changeset in webkit [187632] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore

Roll out r187048. rdar://problem/21714851

6:40 PM Changeset in webkit [187631] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore

Roll out r187490. rdar://problem/22035036

5:52 PM Changeset in webkit [187630] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

[CF] Web process continually eating memory on simple, shared Google Docs spreadsheet.
<https://webkit.org/b/147403>
<rdar://problem/18835799>

Reviewed by Geoffrey Garen.

Make sure we service the CFRunLoop on worker threads, since ports using CoreFoundation
will be scheduling garbage collections and heap sweeps using CFRunLoop timers.

This fix is a stopgap. Long term we need a better design for integrating GC tasks with
with the web worker run loop.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode): Instead of sleeping forever, calculate a better
wakeup deadline by asking the CFRunLoop when its next timer will fire. Then, when a
timeout occurs, call CFRunLoopRunInMode (with seconds=0) to service pending timers.

5:43 PM Changeset in webkit [187629] by basile_clement@apple.com
  • 12 edits
    2 adds in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Add enums for type-safety
https://bugs.webkit.org/show_bug.cgi?id=147475

Reviewed by Michael Saboff.

This adds:

  • A CallMode enum to distinguish tail calls from regular calls from construct
  • A FrameAction enum to indicate whether to keep or reuse the call frame. It also changes JITOperations.h to correctly use this to tell slowPathFor to *not* trash the frame on a regular call (before r187505, this was statically known in slowPathFor).

(JSC::AbstractMacroAssembler::repatchNearCall):

  • assembler/CodeLocation.h:

(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationNearCall::callMode):
(JSC::CodeLocationCommon::nearCallAtOffset):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::locationOfNearCall):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callModeFor):
(JSC::CallLinkInfo::callMode):
(JSC::CallLinkInfo::isTailCall):
(JSC::CallLinkInfo::isVarargs):

  • bytecode/CallMode.cpp: Added.

(WTF::printInternal):

  • bytecode/CallMode.h: Added.
  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • jit/ThunkGenerators.cpp:

(JSC::slowPathFor):
(JSC::virtualThunkFor):

5:37 PM Changeset in webkit [187628] by bshafiei@apple.com
  • 2 edits in branches/safari-600.8-branch/Source/WebCore

Roll out r186863. rdar://problem/21714843

5:17 PM Changeset in webkit [187627] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1
https://bugs.webkit.org/show_bug.cgi?id=147456

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-30
Reviewed by Timothy Hatcher.

By default, WebKit2 WebPage's on PLATFORM(COCOA) enabling DOM Timer
throttling. Under testing, this ends up impacting Web Inspector
tests that create their own WKWebView which never gets displayed
and so gets throttled. Disable throttling on the Inspector's view
during testing.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _hiddenPageDOMTimerThrottlingEnabled]):
(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):
SPI to toggle DOM timer throttling.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isUnderTest):
Provide a way to get if we are under test, and set it before
calling into the platform method.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
When testing, disable timer throttling.

5:12 PM Changeset in webkit [187626] by mmaxfield@apple.com
  • 13 edits in trunk/Source/WebCore

Move locale information into FontDescription
https://bugs.webkit.org/show_bug.cgi?id=147457

Reviewed by Andreas Kling.

Currently, the "lang" attribute on a node sets locale information in RenderStyle.
Font selection is sensitive to this locale information, and occurs deep within
platform/ code, far away from RenderStyle. Because every RenderStyle owns a
FontDescription, and font selection can consult with FontDescriptions, it makes
sense to move the variable from RenderStyle to FontDescription, and provide
convenience methods on RenderStyle which inspect its FontDescription for locale
information.

This patch is in preparation for correctly obeying locale information when
performing font fallback.

No new tests because there is no behavior change.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueWebkitLocale):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):

  • platform/graphics/FontCascade.cpp:
  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::setLocale):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::locale):
(WebCore::FontDescription::initialLocale):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::FontDescription): Deleted.
(WebCore::FontDescription::setScript): Deleted.

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::localeToScriptCodeForFontSelection):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Deleted.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Deleted.
(WebCore::StyleRareInheritedData::operator==): Deleted.

  • rendering/style/StyleRareInheritedData.h:
  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

4:56 PM Changeset in webkit [187625] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Support smart-pasting in the Rules sidebar panel
https://bugs.webkit.org/show_bug.cgi?id=147362

Reviewed by Timothy Hatcher.

When pasting over the selector, if the pasted text matches CSS rule
formatting, replace the selected rule with the selector and text in
the pasted data.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.changeRule.changeCompleted):
(WebInspector.DOMNodeStyles.prototype.changeRule.styleChanged):
(WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
(WebInspector.DOMNodeStyles.prototype.changeRule.ruleSelectorChanged):
(WebInspector.DOMNodeStyles.prototype.changeRule):

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
(WebInspector.CSSStyleDeclarationSection):

4:51 PM Changeset in webkit [187624] by andersca@apple.com
  • 2 edits in trunk/Tools

Add support for window.open to WK1BrowserWindowController
https://bugs.webkit.org/show_bug.cgi?id=147474

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController awakeFromNib]):
Set javaScriptCanOpenWindowsAutomatically to YES.
If this becomes a nuisance, we can always add a menu item to toggle this.

(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
Implement this UI delegate method.

4:47 PM Changeset in webkit [187623] by andersca@apple.com
  • 2 edits in trunk/Tools

Undo stray commit.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):

4:46 PM Changeset in webkit [187622] by andersca@apple.com
  • 3 edits in trunk

Remove stray printf.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

4:41 PM Changeset in webkit [187621] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Make Path::apply() take a function reference
https://bugs.webkit.org/show_bug.cgi?id=147472

Reviewed by Anders Carlsson.

Path::apply() should take a const reference to a std::function.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cg/PathCG.cpp:

(WebCore::CGPathApplierToPathApplier):
(WebCore::Path::apply):

4:38 PM Changeset in webkit [187620] by andersca@apple.com
  • 9 edits
    3 adds in trunk

Assertion failure when a plug-in loads a resource that redirects somewhere
https://bugs.webkit.org/show_bug.cgi?id=147469

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/plugins/get-url-redirect.html

r186597 moved the call to addPlugInStreamLoader to willSendRequest. This is wrong since
willSendRequest can be invoked more than once.

Fix this by making the initialization phase of NetscapePlugInStreamLoader be more like
SubresourceLoader where we only call addPlugInStreamLoader once we've successfully initialized
the loader, and only call removePlugInStreamLoader if we've called addPlugInStreamLoader.

Also change addPlugInStreamLoader and removePlugInStreamLoader to take references.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::addPlugInStreamLoader):
(WebCore::DocumentLoader::removePlugInStreamLoader):

  • loader/DocumentLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::create):
(WebCore::NetscapePlugInStreamLoader::init):
(WebCore::NetscapePlugInStreamLoader::didFinishLoading):
(WebCore::NetscapePlugInStreamLoader::didFail):
(WebCore::NetscapePlugInStreamLoader::didCancel):
(WebCore::NetscapePlugInStreamLoader::notifyDone):

  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest): Deleted.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::isPlugInStreamLoader): Deleted.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

LayoutTests:

Add a test.

  • http/tests/plugins/get-url-redirect-expected.txt: Added.
  • http/tests/plugins/get-url-redirect.html: Added.
  • http/tests/plugins/resources/redirection-response.php: Added.
4:25 PM Changeset in webkit [187619] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix typo in frame duration filtering console.assert message
https://bugs.webkit.org/show_bug.cgi?id=147458

Rubber-stamped by Joseph Pecoraro.

  • UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView.displayNameForDurationFilter):

4:19 PM Changeset in webkit [187618] by basile_clement@apple.com
  • 8 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Don't waste stack space when arity fixup was performed
https://bugs.webkit.org/show_bug.cgi?id=147447

Reviewed by Michael Saboff.

When doing a tail call, we overwrite an amount of stack space based on
the number of arguments in the call frame. If we entered the tail
caller by performing an arity fixup, this is incorrect and leads to
wasted stack space - we must use the CodeBlock's number of parameters
instead in that case.

This patch is also moving the prepareForTailCall() function from
jit/ThunkGenerators.h to the place where it should have always been,
namely jit/CCallHelpers.h

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::prepareForTailCallSlow):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • jit/ThunkGenerators.cpp:

(JSC::slowPathFor):
(JSC::virtualThunkFor):

  • jit/ThunkGenerators.h:
  • tests/stress/tail-call-no-stack-overflow.js:

(strictLoopArityFixup):

4:17 PM Changeset in webkit [187617] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=147367

Reviewed by Eric Carlson.

During the request to exit fullscreen, the video element's m_videoFullscreenMode variable
is set, but no exitFullscreen() request is sent up to the UIProcess. Previous threading
issues have been discovered and fixed, but may have been re-introduced (or never fully
fixed in the first place). To solve the bad behavior this threading issue creates, add
a watchdog timer, similar to the one used in the desktop fullscreen controller, to ensure
that if an exit fullscreen request is not acted upon, the UIProcess forcibly exits fullscreen
anyway.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit): Initialize the timer.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Cancel the timer.
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): Set the timer.
(WebVideoFullscreenInterfaceAVKit::watchdogTimerFired): Forcibly exit fullscreen mode.

4:08 PM Changeset in webkit [187616] by basile_clement@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: We should consider a tail call as an exit in the LLInt for the purpose of switching to the JIT
https://bugs.webkit.org/show_bug.cgi?id=147449

Reviewed by Michael Saboff.

  • llint/LowLevelInterpreter.asm:
4:07 PM Changeset in webkit [187615] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Clean up makeFontCascadeCacheKey()
https://bugs.webkit.org/show_bug.cgi?id=147430

Reviewed by Benjamin Poulain.

FontDescriptionKey is designed to encapsulate all the cacheable properties of a FontDescription.
However, a higher-level cache, FontCascadeCacheKey, was taking some values from FontDescriptions.
The fact that there wasn't a bug before is just a happy coincidence. This patch moves those bits
from the higher-level cache and puts them into FontDescriptionKey where they belong.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagKey):

  • platform/graphics/FontCascade.cpp:

(WebCore::operator==):
(WebCore::makeFontSelectorFlags): Deleted.
(WebCore::makeFontCascadeCacheKey): Deleted.
(WebCore::computeFontCascadeCacheHash): Deleted.

3:56 PM Changeset in webkit [187614] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Set AirPlay discovery mode to disabled when page is hidden
https://bugs.webkit.org/show_bug.cgi?id=147455

Reviewed by Enrica Casucci.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Set discovery mode to disabled after

the picker has been closed.

(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Ditto.

3:26 PM Changeset in webkit [187613] by mrajca@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Media Session: add support for more telephony interruptions
https://bugs.webkit.org/show_bug.cgi?id=147079

Reviewed by Eric Carlson.

  • platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm:

(WebCore::callDidEndRinging): End 'Transient' interruptions.
(WebCore::callDidConnect): Forward this event to media sessions as a 'Content' interruption.
(WebCore::MediaSessionInterruptionProviderMac::beginListeningForInterruptions): Register observers for new

notification types.

(WebCore::MediaSessionInterruptionProviderMac::stopListeningForInterruptions): Unregister all observers.

3:13 PM Changeset in webkit [187612] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: test Play/Pause media control events delivered to non-Content media sessions https://bugs.webkit.org/show_bug.cgi?id=147414

Reviewed by Eric Carlson.

  • media/session/play-pause-media-events-in-non-content-sessions-expected.txt: Added.
  • media/session/play-pause-media-events-in-non-content-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
2:58 PM Changeset in webkit [187611] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: test Play/Pause media control events delivered to Content media sessions
https://bugs.webkit.org/show_bug.cgi?id=147413

Reviewed by Eric Carlson.

  • media/session/play-pause-media-events-in-content-sessions-expected.txt: Added.
  • media/session/play-pause-media-events-in-content-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
2:50 PM Changeset in webkit [187610] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187490. rdar://problem/21995928

2:22 PM Changeset in webkit [187609] by dino@apple.com
  • 45 edits
    3 copies in trunk

Don't use (Details) when exposing SPI
https://bugs.webkit.org/show_bug.cgi?id=147426
<rdar://problem/22062407>

Reviewed by Dan Bernstein.

If we are declaring the interface without any implementation,
we should use class extensions.

Source/WebCore:

Added three new SPI.h files for NSButtonCell, NSURLConnection and
NSURLRequest.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/ThemeMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
  • platform/spi/cf/CFNetworkSPI.h:
  • platform/spi/cocoa/AVKitSPI.h:
  • platform/spi/cocoa/CFNSURLConnectionSPI.h:
  • platform/spi/cocoa/NSButtonCellSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
  • platform/spi/cocoa/NSCalendarDateSPI.h:
  • platform/spi/cocoa/NSColorSPI.h:
  • platform/spi/cocoa/NSFileManagerSPI.h:
  • platform/spi/cocoa/NSStringSPI.h:
  • platform/spi/cocoa/NSURLConnectionSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
  • platform/spi/cocoa/NSURLDownloadSPI.h:
  • platform/spi/cocoa/NSURLRequestSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
  • platform/spi/cocoa/QuartzCoreSPI.h:
  • platform/spi/cocoa/WebFilterEvaluatorSPI.h:
  • platform/spi/ios/CoreUISPI.h:
  • platform/spi/ios/LaunchServicesSPI.h:
  • platform/spi/ios/MediaPlayerSPI.h:
  • platform/spi/ios/QuickLookSPI.h:
  • platform/spi/ios/UIColorSPI.h:
  • platform/spi/mac/QuickLookMacSPI.h:
  • rendering/RenderThemeMac.mm:

Source/WebKit/mac:

  • WebView/WebFrameView.mm:
  • WebView/WebPDFView.mm:

Source/WebKit2:

  • Platform/spi/ios/AssertionServicesSPI.h:
  • Platform/spi/ios/CorePDFSPI.h:
  • Platform/spi/ios/DataDetectorsUISPI.h:
  • Platform/spi/ios/ManagedConfigurationSPI.h:
  • Platform/spi/ios/UIKitSPI.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:
  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
  • UIProcess/_WKWebViewPrintFormatter.mm:
  • UIProcess/mac/WebPageProxyMac.mm:

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/EventSendingController.mm:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:
  • WebKitTestRunner/mac/TestControllerMac.mm:
2:20 PM Changeset in webkit [187608] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187565. rdar://problem/22061043

2:20 PM Changeset in webkit [187607] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187517. rdar://problem/21645007

2:20 PM Changeset in webkit [187606] by matthew_hanson@apple.com
  • 9 edits
    2 adds in branches/safari-601.1-branch

Merge r187278. rdar://problem/19908029

1:57 PM Changeset in webkit [187605] by ap@apple.com
  • 23 edits in trunk

Replace Google App Engine with AppScale
https://bugs.webkit.org/show_bug.cgi?id=147178

Patch by Aakash Jain <aakash_jain@apple.com> on 2015-07-30
Reviewed by Daniel Bates.

Tools:

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:

(TestHistory):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  • QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
  • TestResultServer/app.yaml: Ditto
  • Scripts/webkitpy/common/config/urls.py:
  • TestResultServer/main.py:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/loader.js:

Websites/bugs.webkit.org:

  • code-review.js:
  • template/en/default/attachment/edit.html.tmpl:
  • template/en/default/attachment/list.html.tmpl:
  • template/en/default/attachment/reviewform.html.tmpl:

LayoutTests:

  • fast/harness/results.html:
1:23 PM Changeset in webkit [187604] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601.1-branch

Merge r187504. rdar://problem/21915355

1:23 PM Changeset in webkit [187603] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187478. rdar://problem/21838764

1:20 PM Changeset in webkit [187602] by achristensen@apple.com
  • 4 edits
    2 deletes in trunk/Source/WebCore

Remove LegacyCACFLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=147388

Reviewed by Geoffrey Garen.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Removed.
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Removed.
1:15 PM Changeset in webkit [187601] by achristensen@apple.com
  • 5 edits in trunk/Source/WebCore

Fix Windows build after r187587.

  • loader/SubresourceLoader.h:
  • loader/cache/CachedResource.h:
  • platform/graphics/Font.h:

(WebCore::Font::DerivedFontData::DerivedFontData):

  • rendering/RenderLayerFilterInfo.h:

Visual Studio doesn't like making std::unique_ptrs of private nested classes.
It tries to make a std::default_delete with the private class as a template parameter.

12:40 PM Changeset in webkit [187600] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Stop closing files on the main thread
https://bugs.webkit.org/show_bug.cgi?id=147410

Reviewed by Andreas Kling.

After r186510, we no longer open cache files on the main thread.
However, we still close them on the main thread. This patch makes
sure we close the files on another thread instead.

  • NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:

(WebKit::NetworkCache::IOChannel::IOChannel):

12:26 PM Changeset in webkit [187599] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Regression: %c is broken for console.group
https://bugs.webkit.org/show_bug.cgi?id=147436

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):

12:24 PM Changeset in webkit [187598] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Add special case for deleting the next character when editing rules in the CSS Sidebar
https://bugs.webkit.org/show_bug.cgi?id=147442

Reviewed by Timothy Hatcher.

If the cursor is on the first position of the first line in a CSS Rule and that line
has no content, delete the line instead of doing nothing.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange):

12:13 PM Changeset in webkit [187597] by Simon Fraser
  • 15 edits in trunk/Source

Convert Path applier to use std::function
https://bugs.webkit.org/show_bug.cgi?id=147368

Reviewed by Sam Weinig.

Use std::function for Path::apply().

Source/WebCore:

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(convertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
(ConvertPathToScreenSpaceFunction): Deleted.

  • inspector/InspectorOverlay.cpp:

(WebCore::appendPathSegment):
(WebCore::buildObjectForShapeOutside):

  • platform/graphics/Path.cpp:

(WebCore::Path::length):
(WebCore::Path::traversalStateAtLength):
(WebCore::pathLengthApplierFunction): Deleted.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::findPathIntersections):
(WebCore::FontCascade::dashesForIntersectionsWithRect):

  • platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::apply):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::CGPathApplierToPathApplier):
(WebCore::Path::apply):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::updateZeroLengthSubpaths):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::processMarkerPositions):

  • rendering/svg/SVGMarkerData.h:

(WebCore::SVGMarkerData::updateFromPathElement):

  • rendering/svg/SVGSubpathData.h:

(WebCore::SVGSubpathData::updateFromPathElement):
(WebCore::SVGSubpathData::SVGSubpathData): Deleted.

  • svg/SVGPathUtilities.cpp:

(WebCore::pathIteratorForBuildingString):
(WebCore::buildStringFromPath):

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::pathEncodeApplierFunction):
(IPC::ArgumentCoder<Path>::encode):
(IPC::pathPointCountApplierFunction): Deleted.

11:47 AM Changeset in webkit [187596] by commit-queue@webkit.org
  • 12 edits in trunk

[EFL] Enable IndexedDB based on DatabaseProcess
https://bugs.webkit.org/show_bug.cgi?id=147221

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-07-30
Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

  • DatabaseProcess/efl/DatabaseProcessMainEfl.cpp: Add ecore_init().

Without this call, it leads to crash when launching DatabaseProcess.

  • PlatformEfl.cmake: Add missing include_directory.
  • Shared/efl/ProcessExecutablePathEfl.cpp:

(WebKit::executablePathOfDatabaseProcess):

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
Add default path for indexedDB sqlite3 db file.

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/TestExpectations: Update IndexedDB test expectations.
11:39 AM Changeset in webkit [187595] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

aria-liveregions-notifications tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147299
<rdar://problem/21998675>

Patch by Nan Wang <n_wang@apple.com> on 2015-07-30
Reviewed by Chris Fleizach.

These tests were flaky because they relied on timer notification callbacks.
Fixed these tests by using different objects to capture the notifications instead.

  • platform/mac/TestExpectations:
  • platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
  • platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
  • platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
  • platform/mac/accessibility/aria-liveregions-notifications.html:
11:36 AM Changeset in webkit [187594] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
https://bugs.webkit.org/show_bug.cgi?id=147446

Reviewed by Simon Fraser.

Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
by leveraging the fact that we know in advance how many layer IDs are going to be added. We
now set the Vector size from the start, instead of clearing it and then growing the vector
capacity when appending the layer IDs one by one.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

11:32 AM Changeset in webkit [187593] by Simon Fraser
  • 4 edits
    2 adds in trunk

Selecting in an iframe can cause main page scrolling
https://bugs.webkit.org/show_bug.cgi?id=147431
rdar://problem/19244589

Reviewed by Zalan Bujtas.

Source/WebCore:

The RenderLayer auatoscroll code walks up the RenderLayer hierarchy, crossing
frame boundaries. However, as it crosses into an ancestor frame it failed to
map the target rect into the coordinate space of the new frame, which caused
us to scroll to an incorrect location in that parent frame.

Test: fast/events/autoscroll-in-iframe.html

  • rendering/RenderLayer.cpp:

(WebCore::parentLayerCrossFrame): Make the layer a reference, and pass in
an optional rect. When crossing frame boundaries, map the rect from the
contents of the child frame to the contents of the parent frame.
(WebCore::RenderLayer::enclosingScrollableLayer): Pass optional rect.
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::hasScrollableOrRubberbandableAncestor):

  • rendering/RenderLayer.h:

LayoutTests:

Test that uses eventSender to select in an iframe after scrolling the
main page.

  • fast/events/autoscroll-in-iframe-expected.txt: Added.
  • fast/events/autoscroll-in-iframe.html: Added.
11:31 AM Changeset in webkit [187592] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Improve the history logging output
https://bugs.webkit.org/show_bug.cgi?id=147429

Reviewed by Alexey Proskuryakov.

Improve the History log channel output to show which frame is navigating,
print the addresses of the HistoryController and Frame, and print URLs
for everything.

Remove the BackForward log channel which had just one calling location,
and log for pushState/replaceState.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForClientRedirect):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

  • platform/Logging.h:
11:29 AM Changeset in webkit [187591] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add the "wasm" directory to the Additional Include Directories for jsc.exe
https://bugs.webkit.org/show_bug.cgi?id=147443

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-30
Reviewed by Mark Lam.

This patch should fix the "..\..\jsc.cpp(46): fatal error C1083:
Cannot open include file: 'JSWASMModule.h'" error in the Windows build.

11:21 AM Changeset in webkit [187590] by basile_clement@apple.com
  • 14 edits in branches/jsc-tailcall/Source/JavaScriptCore

Merged r187505 from trunk.

Simplify call linking
https://bugs.webkit.org/show_bug.cgi?id=147363

Reviewed by Filip Pizlo.

Previously, we were passing both the CallLinkInfo and a
(CodeSpecializationKind, RegisterPreservationMode) pair to the
different call linking slow paths. However, the CallLinkInfo already
has all of that information, and we don't gain anything by having them
in additional static parameters - except possibly a very small
performance gain in presence of inlining. However since those are
already slow paths, this performance loss (if it exists) will not be
visible in practice.

This patch removes the various specialized thunks and JIT operations
for regular and polymorphic call linking with a single thunk and
operation for each case. Moreover, it removes the four specialized
virtual call thunks and operations with one virtual call thunk for each
call link info, allowing for better branch prediction by the CPU and
fixing a pre-existing FIXME.

  • bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::unlink): (JSC::CallLinkInfo::dummy): Deleted.
  • bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::registerPreservationMode): (JSC::CallLinkInfo::setUpCallFromFTL): (JSC::CallLinkInfo::setSlowStub): (JSC::CallLinkInfo::clearSlowStub): (JSC::CallLinkInfo::slowStub):
  • dfg/DFGDriver.cpp: (JSC::DFG::compileImpl):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link):
  • ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::link):
  • jit/JITCall.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITOperations.cpp:
  • jit/JITOperations.h: (JSC::operationLinkFor): Deleted. (JSC::operationVirtualFor): Deleted. (JSC::operationLinkPolymorphicCallFor): Deleted.
  • jit/Repatch.cpp: (JSC::generateByIdStub): (JSC::linkSlowFor): (JSC::linkFor): (JSC::revertCall): (JSC::unlinkFor): (JSC::linkVirtualFor): (JSC::linkPolymorphicCall):
  • jit/Repatch.h:
  • jit/ThunkGenerators.cpp: (JSC::linkCallThunkGenerator): (JSC::linkPolymorphicCallThunkGenerator): (JSC::virtualThunkFor): (JSC::linkForThunkGenerator): Deleted. (JSC::linkConstructThunkGenerator): Deleted. (JSC::linkCallThatPreservesRegsThunkGenerator): Deleted. (JSC::linkConstructThatPreservesRegsThunkGenerator): Deleted. (JSC::linkPolymorphicCallForThunkGenerator): Deleted. (JSC::linkPolymorphicCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualForThunkGenerator): Deleted. (JSC::virtualCallThunkGenerator): Deleted. (JSC::virtualConstructThunkGenerator): Deleted. (JSC::virtualCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualConstructThatPreservesRegsThunkGenerator): Deleted.
  • jit/ThunkGenerators.h: (JSC::linkThunkGeneratorFor): Deleted. (JSC::linkPolymorphicCallThunkGeneratorFor): Deleted. (JSC::virtualThunkGeneratorFor): Deleted.
10:19 AM Changeset in webkit [187589] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: test Next/Previous Track media control events delivered to Content media sessions https://bugs.webkit.org/show_bug.cgi?id=147416

Reviewed by Eric Carlson.

  • media/session/track-media-events-in-content-sessions-expected.txt: Added.
  • media/session/track-media-events-in-content-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
10:02 AM Changeset in webkit [187588] by mrajca@apple.com
  • 5 edits in trunk/Source/WebCore

Media Session: add infrastructure for testing media control events
https://bugs.webkit.org/show_bug.cgi?id=147412

Reviewed by Eric Carlson.

  • Modules/mediasession/MediaSessionManager.h:
  • testing/Internals.cpp:

(WebCore::Internals::sendMediaControlEvent): Let tests simulate media control events.

  • testing/Internals.h:
  • testing/Internals.idl:
9:25 AM Changeset in webkit [187587] by Chris Dumez
  • 48 edits in trunk/Source

Mark more classes as fast allocated
https://bugs.webkit.org/show_bug.cgi?id=147440

Reviewed by Sam Weinig.

Mark more classes as fast allocated for performance. We heap-allocate
objects of those types throughout the code base.

Source/JavaScriptCore:

  • API/JSCallbackObject.h:
  • API/ObjCCallbackFunction.mm:
  • bytecode/BytecodeKills.h:
  • bytecode/BytecodeLivenessAnalysis.h:
  • bytecode/CallLinkStatus.h:
  • bytecode/FullBytecodeLiveness.h:
  • bytecode/SamplingTool.h:
  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGBlockMap.h:
  • dfg/DFGInPlaceAbstractState.h:
  • dfg/DFGThreadData.h:
  • heap/HeapVerifier.h:
  • heap/SlotVisitor.h:
  • parser/Lexer.h:
  • runtime/ControlFlowProfiler.h:
  • runtime/TypeProfiler.h:
  • runtime/TypeProfilerLog.h:
  • runtime/Watchdog.h:

Source/WebCore:

  • editing/Editor.h:
  • history/CachedFrame.h:
  • history/CachedPage.h:
  • html/parser/HTMLResourcePreloader.h:
  • loader/PolicyChecker.h:
  • loader/SubresourceLoader.h:
  • loader/cache/CachedResource.h:
  • page/animation/AnimationController.h:
  • page/scrolling/ScrollingConstraints.h:
  • page/scrolling/ScrollingStateTree.h:
  • platform/graphics/Font.h:
  • platform/graphics/GraphicsLayerUpdater.h:
  • rendering/FilterEffectRenderer.h:
  • rendering/ImageQualityController.h:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/SimpleLineLayoutResolver.h:
  • rendering/shapes/RasterShape.h:
  • rendering/shapes/Shape.h:

Source/WebKit2:

  • NetworkProcess/cache/NetworkCacheStorage.cpp:
  • NetworkProcess/cache/NetworkCacheStorage.h:
  • Platform/IPC/MessageRecorder.h:
  • Platform/mac/LayerHostingContext.h:

Source/WTF:

  • wtf/Bag.h:
  • wtf/SegmentedVector.h:
  • wtf/SentinelLinkedList.h:
9:21 AM Changeset in webkit [187586] by Michael Catanzaro
  • 3 edits in trunk/Source/WebCore

[GTK] Crashes when SoupSession is destroyed in exit handler
https://bugs.webkit.org/show_bug.cgi?id=145347

Reviewed by Carlos Garcia Campos.

Leak the default SoupSession with NeverDestroyed to avoid races at program exit.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::defaultSession):

  • platform/network/soup/SoupNetworkSession.h:
9:16 AM Changeset in webkit [187585] by achristensen@apple.com
  • 11 edits in trunk

Build AppleWin port with CMake
https://bugs.webkit.org/show_bug.cgi?id=147385

Reviewed by Martin Robinson.

.:

  • Source/cmake/OptionsWindows.cmake:

Use the static multithreaded runtime. Based on
http://www.cmake.org/Wiki/CMake_FAQ#How_can_I_build_my_MSVC_application_with_a_static_runtime.3F

Source/WebCore:

  • CMakeLists.txt:

Add makesafeseh.asm to 32-bit build. It needs to be after the ADD_PRECOMPILED_HEADER macro
because CMake can only set COMPILE_FLAGS once with set_source_files_properties, and we want
to use that to add /safeseh instead of a precompiled header (which wouldn't be used anyway in assembly).

  • PlatformAppleWin.cmake:
  • PlatformWin.cmake:
  • PlatformWinCairo.cmake:

Added missing source files and libraries.

Source/WebKit:

  • PlatformWin.cmake:

Added missing source files and libraries.

Tools:

  • WinLauncher/CMakeLists.txt:

Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.

8:56 AM Changeset in webkit [187584] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r187582.

  • accessibility/AccessibilityAllInOne.cpp:

Include new files.

7:51 AM Changeset in webkit [187583] by Michael Catanzaro
  • 6 edits
    2 adds in trunk

Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
https://bugs.webkit.org/show_bug.cgi?id=147018

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests; unskipped inspector/css/get-system-fonts.html

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::patternToFamilies): Added.
(WebCore::FontCache::systemFontFamilies): Implemented.
(WebCore::strongAliasesForFamily): Split some code off to patternToFamilies.

LayoutTests:

  • inspector/css/get-system-fonts-expected.txt: Expect some free fonts to be missing....
  • inspector/css/get-system-fonts.html: Check for some free fonts.
  • platform/gtk/TestExpectations: Unskip the test.
  • platform/gtk/inspector/css/get-system-fonts-expected.txt: Added.
4:10 AM Changeset in webkit [187582] by commit-queue@webkit.org
  • 12 edits
    6 adds in trunk

AX: VoiceOver unable to access content in malformed trees
https://bugs.webkit.org/show_bug.cgi?id=147295
<rdar://problem/14862892>

Patch by Nan Wang <n_wang@apple.com> on 2015-07-30
Reviewed by Chris Fleizach.

Source/WebCore:

VoiceOver is skipping the content of malformed trees. This fixes the problem
by having the tree check if it has valid children (treeitems) and makes treeitems
check if they are inside trees.

Test: platform/mac/accessibility/malformed-tree.html

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::addChildren):
(WebCore::AccessibilityObject::addChild):
(WebCore::AccessibilityObject::insertChild):
(WebCore::AccessibilityObject::shouldIgnoreAttributeRole):
(WebCore::AccessibilityObject::canHaveChildren):
(WebCore::AccessibilityObject::hasChildren):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/AccessibilityTree.cpp: Added.

(WebCore::AccessibilityTree::AccessibilityTree):
(WebCore::AccessibilityTree::~AccessibilityTree):
(WebCore::AccessibilityTree::create):
(WebCore::AccessibilityTree::computeAccessibilityIsIgnored):
(WebCore::AccessibilityTree::determineAccessibilityRole):
(WebCore::AccessibilityTree::isTreeValid):

  • accessibility/AccessibilityTree.h: Added.
  • accessibility/AccessibilityTreeItem.cpp: Added.

(WebCore::AccessibilityTreeItem::AccessibilityTreeItem):
(WebCore::AccessibilityTreeItem::~AccessibilityTreeItem):
(WebCore::AccessibilityTreeItem::create):
(WebCore::AccessibilityTreeItem::determineAccessibilityRole):

  • accessibility/AccessibilityTreeItem.h: Added.

LayoutTests:

  • accessibility/aria-mappings.html:
  • accessibility/treeitem-child-exposed-expected.txt:
  • accessibility/treeitem-child-exposed.html:
  • platform/mac/accessibility/malformed-tree-expected.txt: Added.
  • platform/mac/accessibility/malformed-tree.html: Added.
2:52 AM Changeset in webkit [187581] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Update JSC's standalone-pre.js for r187575
https://bugs.webkit.org/show_bug.cgi?id=147444

Unreviewed.

  • resources/standalone-pre.js:

(shouldBeType):
Copy shouldBeType() from the non-standalone version.

Note: See TracTimeline for information about the timeline view.