Timeline
Oct 13, 2015:
- 11:26 PM Changeset in webkit [191036] by
-
- 5 edits in trunk/Tools
More debug queue build fixing.
Preserve the build style in one more place. Changed mock build_style from "both"
to "release", as we don't support testing both debug and release.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.archive_last_test_results):
(MockCommitQueue):
(MockCommitQueue.build_style):
(MockCommitQueue.did_pass_testing_ews):
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 11:16 PM Changeset in webkit [191035] by
-
- 34 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r191002 - Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091
Reviewed by Sam Weinig.
Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:
- bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::processObjectLog):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame getDictationResultRanges:andMetadatas:]):
Source/WebKit2:
- UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):
- 11:11 PM Changeset in webkit [191034] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r190991 - REGRESSION: ASSERT (impl->isAtomic()) @ facebook.com
https://bugs.webkit.org/show_bug.cgi?id=149965
Reviewed by Geoffrey Garen.
Edge filtering for CheckIdent ensures that a given value is either Symbol or StringIdent.
However, this filtering is not applied to CheckIdent when propagating a constant value in
the constant folding phase. As a result, it is not guaranteeed that a constant value
propagated in constant folding is Symbol or StringIdent.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 10:11 PM Changeset in webkit [191033] by
-
- 2 edits in trunk/Tools
More debug queue build fixing.
Add build_style argument to derived classes as well.
- Scripts/webkitpy/common/config/ports.py:
(MacPort):
(MacPort.run_webkit_tests_command):
(WinPort.run_bindings_tests_command):
(WinPort):
(WinPort.run_webkit_tests_command):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port):
(GtkWK2Port.run_webkit_tests_command):
- 10:10 PM Changeset in webkit [191032] by
-
- 3 edits in trunk/Tools
[iOS] Build fix
Unreviewed.
Mach-O section names are limited to 16 characters.
- DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
- 9:54 PM Changeset in webkit [191031] by
-
- 7 edits in trunk/Tools
Build fix for mac-debug EWS queue.
Unreviewed.
Pass --debug to run-webkit-tests.
While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
will need to be substantially modified to work in EWS, so the dummy implementation
was not helpful.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_webkit_unit_tests_command): Deleted.
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_javascriptcore_tests_command):
(MockPort):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):
(MockPort.run_webkit_unit_tests_command): Deleted.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):
- 8:56 PM Changeset in webkit [191030] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
[ES6] Class expression should have lexical environment that has itself as an imutable binding
https://bugs.webkit.org/show_bug.cgi?id=150089
Reviewed by Geoffrey Garen.
According to ES6 spec, class expression has its own lexical environment that holds itself
as an immutable binding[1] (section 14.5.14 step 2, 3, 4, 23)
As a result, even if the binding declared in the outer scope is overridden, methods inside
class expression can refer its class by the class name.
[1]: http://ecma-international.org/ecma-262/6.0/#sec-runtime-semantics-classdefinitionevaluation
- bytecompiler/NodesCodegen.cpp:
(JSC::ClassExprNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createClassExpr):
- parser/NodeConstructors.h:
(JSC::ClassExprNode::ClassExprNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClass):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createClassExpr):
- tests/es6.yaml:
- tests/stress/class-expression-generates-environment.js: Added.
(shouldBe):
(shouldThrow):
(prototype.method):
(staticMethod):
(A.prototype.method):
(A.staticMethod):
(A):
- tests/stress/class-expression-should-be-tdz-in-heritage.js: Added.
(shouldThrow):
(shouldThrow.A):
- 8:05 PM Changeset in webkit [191029] by
-
- 1 edit17 adds in trunk/LayoutTests
[iOS] Update anonymous table results for iOS port.
Unreviewed gardening.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
- 7:38 PM Changeset in webkit [191028] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL Gardening on 13th Oct.
https://bugs.webkit.org/show_bug.cgi?id=150084
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-13
- platform/efl/TestExpectations:
- 7:18 PM Changeset in webkit [191027] by
-
- 12 edits in branches/safari-601-branch/Source
Merge r189834. rdar://problem/22801966
- 7:14 PM Changeset in webkit [191026] by
-
- 1 edit16 adds in trunk/LayoutTests
[Win] Update anonymous table results for Windows port.
Unreviewed gardening.
- platform/win/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
- 6:09 PM Changeset in webkit [191025] by
-
- 1 copy in tags/Safari-601.1.46.25.2
New tag.
- 6:02 PM Changeset in webkit [191024] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merged r191022. rdar://problem/23100514
- 5:29 PM Changeset in webkit [191023] by
-
- 2 edits in branches/safari-601.1.46.25-branch/Source/WebKit2
Merged r191022. rdar://problem/23100514
- 5:25 PM Changeset in webkit [191022] by
-
- 2 edits in trunk/Source/WebKit2
Use the correct notification strings for view service applications state change.
https://bugs.webkit.org/show_bug.cgi?id=150107
Use the correct notification names "_UIViewServiceHostDidEnterBackgroundNotification" and
"_UIViewServiceHostWillEnterForegroundNotification" to listen to view service application state changes.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-10-13
Reviewed by Gavin Barraclough.
- UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::ApplicationStateTracker):
- 5:15 PM Changeset in webkit [191021] by
-
- 5 edits in branches/safari-601.1.46.25-branch/Source
Versioning.
- 5:15 PM Changeset in webkit [191020] by
-
- 3 edits in branches/safari-601-branch/Source/WebKit2
Merge r190141. rdar://problem/23075536
- 5:15 PM Changeset in webkit [191019] by
-
- 7 edits in branches/safari-601-branch/Source
Merge r188443. rdar://problem/22801969
- 5:15 PM Changeset in webkit [191018] by
-
- 5 edits in trunk/Tools
[Win] Generate Crash Traces
https://bugs.webkit.org/show_bug.cgi?id=150103
Reviewed by Daniel Bates.
We were using an exception filter to try to emit "#CRASHED" to stderr
when a test program crashed. However, the modern Python implementation
seems capable of recognizing crashes on its own. Furthermore, registering
the exception handler was preventing the JIT debugger (NTSD) from
automatically attaching to the crashing program, so we were not getting
crash traces.
- DumpRenderTree/win/DumpRenderTree.cpp:
(main): Don't register an exception filter.
(exceptionFilter): Deleted.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs): Add another regular expression to handle a second crash trace
syntax I encountered during testing.
(CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
try the new one. The PID found by the new expression is in hexadecimal, so
convert it to an integer before returning it.
- Scripts/webkitpy/port/driver.py:
(Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
check for "#CRASHED" after stripping off the EOL characters.
- Scripts/webkitpy/port/win.py:
(WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
invocation. This is apparently used to signal an event when the debugger is finished.
- 5:14 PM Changeset in webkit [191017] by
-
- 15 edits1 add in trunk/Source
Add helper funtion for checking pointer equivalency and use it
https://bugs.webkit.org/show_bug.cgi?id=150022
Reviewed by Darin Adler.
Source/WebCore:
A common pattern in WebCore code is to check for equivalency of two pointers,
either both null, or both non-null and with equal values. This was written in
several different ways in different places.
Add arePointingToEqualData() to standardize this pattern.
This obviates the need for StyleImage::imagesEquivalent(), counterDataEquivalent()
etc.
Also change some comparisons of DataRef<> which checked the pointer and then the
values to use DataRef<>::operator== which does the same thing. Comparisons of
m_grid and m_gridItem only checked pointer equality, so this is probably a bug fix there.
page/animation/CSSPropertyAnimation.cpp: if ((!a && !b) a == b) is redundant so fix, and add checks for a and b RenderStyle* first.
(WebCore::PropertyWrapperGetter::equals):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperMaybeInvalidColor::equals):
(WebCore::FillLayerPropertyWrapperGetter::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::equals):
(WebCore::ShorthandPropertyWrapper::equals):
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperSVGPaint::equals):
- platform/network/ResourceRequestBase.cpp:
(WebCore::equalIgnoringHeaderFields):
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::operator==):
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImageData::operator==):
- rendering/style/RenderStyle.cpp: Some nullptr cleanup.
(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::changeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::setWillChange):
- rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleShadowSVGData::operator==):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::operator==):
- rendering/style/StyleImage.h:
(WebCore::StyleImage::imagesEquivalent): Deleted.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
(WebCore::cursorDataEquivalent): Deleted.
(WebCore::quotesDataEquivalent): Deleted.
(WebCore::StyleRareInheritedData::shadowDataEquivalent): Deleted.
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::counterDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::shadowDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::willChangeDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::reflectionDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::animationDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::transitionDataEquivalent): Deleted.
- rendering/style/StyleRareNonInheritedData.h:
Source/WTF:
Add PointerComparison.h which contains the templated pointer comparison
function.
- WTF.xcodeproj/project.pbxproj:
- wtf/PointerComparison.h: Added.
(WTF::arePointingToEqualData):
- 5:12 PM Changeset in webkit [191016] by
-
- 3 edits in trunk/Source/JavaScriptCore
We were creating a GCAwareJITStubRoutineWithExceptionHandler when we didn't actually have an exception handler in the CodeBlock's exception handler table
https://bugs.webkit.org/show_bug.cgi?id=150016
Reviewed by Geoffrey Garen.
There was a bug where we created a GCAwareJITStubRoutineWithExceptionHandler
for inline caches that were custom setters/getters (but not JS getters/setters).
This is wrong; we only create GCAwareJITStubRoutineWithExceptionHandler when we have
an inline cache with a JS getter/setter call which causes the inline cache to add itself
to the CodeBlock's exception handling table. The problem was that we created
a GCAwareJITStubRoutineWithExceptionHandler that tried to remove itself from
the exception handler table only to find out that it didn't have an entry in the table.
- bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::regenerate):
- 5:10 PM Changeset in webkit [191015] by
-
- 4 edits in trunk/Source/JavaScriptCore
Simplify WeakBlock visit and reap phases
https://bugs.webkit.org/show_bug.cgi?id=150045
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-13
Reviewed by Geoffrey Garen.
WeakBlock visiting and reaping both happen after MarkedBlock marking.
All the MarkedBlocks we encounter should be either Marked or Retired.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::isMarkedOrRetired):
- heap/WeakBlock.cpp:
(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):
- heap/WeakBlock.h:
- 4:40 PM Changeset in webkit [191014] by
-
- 26 edits1 delete in trunk/Source
Split TypesettingFeatures into kerning and ligatures bools
https://bugs.webkit.org/show_bug.cgi?id=150074
Reviewed by Simon Fraser.
Source/WebCore:
Our TypesettingFeatures type represents whether kerning or ligatures are enabled
when laying out text. However, now that I have implemented font-feature-settings
and font-variant-*, this type is wildly inadequate. There are now multiple kinds
of ligatures, and many other features which are neither kerning nor ligatures.
Adding tons of information to this type doesn't make sense because 1) We already
have a FontVariantSettings struct which contains this information, and 2) None
of the users of TypesettingFeatures care about most of these new features.
In this new world of font features, the font-kerning property isn't changing.
Therefore, all the code which relies only on the Kerning value in
TypesettingFeatures doesn't need to change. The places which rely on Ligatures,
however, need to be updated to understand that there are many different kinds
of ligatures.
Indeed, after inspection, all of the places which inspect ligatures are more
interested in a high-level concept of whether or not we can trust some simple
computation. Therefore, we really have two things we care about: Kerning, and
this high-level concept.
This patch is the second step to update our view of the world to include
font-feature-settings and font-variant-*. In particular, this patch simply
splits TypesettingFeatures into two Booleans, one for Kerning, and one for
Ligatures (which has no behavior change). Then, once they are separated, I can
migrate the Ligatures Boolean to take on its new meaning.
This change is purely mechanical.
No new tests because there is no behavior change.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontCascadeDescription::Kerning):
- platform/graphics/Font.cpp:
(WebCore::Font::applyTransforms):
- platform/graphics/Font.h:
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::FontCascade):
(WebCore::FontCascade::operator=):
(WebCore::FontCascade::update):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::width):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::FontCascade::offsetForPosition):
(WebCore::FontCascade::setDefaultKerning):
(WebCore::FontCascade::setDefaultLigatures):
(WebCore::FontCascade::codePath):
(WebCore::FontCascade::floatWidthForSimpleText):
(WebCore::FontCascade::setDefaultTypesettingFeatures): Deleted.
(WebCore::FontCascade::defaultTypesettingFeatures): Deleted.
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::enableKerning):
(WebCore::FontCascade::enableLigatures):
(WebCore::FontCascade::computeEnableKerning):
(WebCore::FontCascade::computeEnableLigatures):
(WebCore::FontCascade::typesettingFeatures): Deleted.
(WebCore::FontCascade::computeTypesettingFeatures): Deleted.
- platform/graphics/FontDescription.cpp:
(WebCore::FontCascadeDescription::FontCascadeDescription):
- platform/graphics/FontDescription.h:
(WebCore::FontCascadeDescription::setKerning):
(WebCore::FontCascadeDescription::initialKerning):
- platform/graphics/TypesettingFeatures.h: Removed.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
- platform/graphics/WidthIterator.h:
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::canRenderCombiningCharacterSequence):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::Font::getCFStringAttributes):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
- rendering/line/BreakingContext.h:
(WebCore::WordTrailingSpace::width):
- svg/SVGFontData.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView initialize]):
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 4:28 PM Changeset in webkit [191013] by
-
- 4 edits in trunk/Source/WebKit2
Fix iOS-family builds.
- UIProcess/API/C/mac/WKPagePrivateMac.mm:
(WKPageGetObjectRegistry):
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _remoteObjectRegistry]):
- UIProcess/API/mac/WKViewInternal.h:
- 4:01 PM Changeset in webkit [191012] by
-
- 3 edits in trunk/LayoutTests
[Win] Unreviewed test gardening after r190995.
Update to correct test output, based on similar changes to Mac expectations.
- platform/win/fast/html/details-add-child-2-expected.txt:
- platform/win/fast/html/details-open2-expected.txt:
- 3:53 PM Changeset in webkit [191011] by
-
- 9 edits34 adds in trunk
Anonymous table objects: inline parent box requires inline-table child.
https://bugs.webkit.org/show_bug.cgi?id=150090
Reviewed by David Hyatt.
According to the CSS2.1 specification, if a child needs anonymous table wrapper
and the child's parent is an inline box, the generated table needs to be inline-table.
(inline-block and block parents generate non-inline table)
Import W3C CSS2.1 anonymous table tests.
Source/WebCore:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::childRequiresTable):
(WebCore::RenderElement::addChild):
- rendering/RenderElement.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::newChildIsInline):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::addChildToContinuation):
- rendering/RenderInline.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):
LayoutTests:
- css2.1/tables/table-anonymous-objects-177.xht: Added.
- css2.1/tables/table-anonymous-objects-178.xht: Added.
- css2.1/tables/table-anonymous-objects-179.xht: Added.
- css2.1/tables/table-anonymous-objects-180.xht: Added.
- css2.1/tables/table-anonymous-objects-181.xht: Added.
- css2.1/tables/table-anonymous-objects-189.xht: Added.
- css2.1/tables/table-anonymous-objects-190.xht: Added.
- css2.1/tables/table-anonymous-objects-191.xht: Added.
- css2.1/tables/table-anonymous-objects-192.xht: Added.
- css2.1/tables/table-anonymous-objects-193.xht: Added.
- css2.1/tables/table-anonymous-objects-194.xht: Added.
- css2.1/tables/table-anonymous-objects-195.xht: Added.
- css2.1/tables/table-anonymous-objects-196.xht: Added.
- css2.1/tables/table-anonymous-objects-205.xht: Added.
- css2.1/tables/table-anonymous-objects-206.xht: Added.
- css2.1/tables/table-anonymous-objects-207.xht: Added.
- css2.1/tables/table-anonymous-objects-208.xht: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
- 3:17 PM Changeset in webkit [191010] by
-
- 2 edits in trunk/Source/WebKit2
Fix 32-bit build.
- UIProcess/API/C/mac/WKPagePrivateMac.mm:
(WKPageGetObjectRegistry):
- 2:56 PM Changeset in webkit [191009] by
-
- 6 edits in trunk/Source/WebKit2
Add and implement WKPageGetObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150102
Reviewed by Tim Horton.
Put the _WKObjectRegistry used by WKPageRef and WKBrowsingContextController on the WKView for now.
If we decide to share more code between WKView and WKWebView, the object registry could live in an object that would be shared
between WKView and WKWebView.
- UIProcess/API/C/mac/WKPagePrivateMac.h:
- UIProcess/API/C/mac/WKPagePrivateMac.mm:
(WKPageGetObjectRegistry):
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _remoteObjectRegistry]):
(-[WKBrowsingContextController dealloc]): Deleted.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
(-[WKView _remoteObjectRegistry]):
- UIProcess/API/mac/WKViewInternal.h:
- 2:46 PM Changeset in webkit [191008] by
-
- 4 edits2 adds in trunk
Device motion and orientation should only be visible from the main frame's security origin
https://bugs.webkit.org/show_bug.cgi?id=150072
<rdar://problem/23082036>
Reviewed by Brent Fulgham.
.:
Add a manual test for cross-origin device orientation events, while
we're waiting on the mock client to be supported everywhere.
- ManualTests/deviceorientation-child-frame.html: Added.
- ManualTests/deviceorientation-main-frame-only.html: Added.
Source/WebCore:
There are reports that gyroscope and accelerometer information can
be used to detect keyboard entry. One initial step to reduce the
risk is to forbid device motion and orientation events from
being fired in frames that are a different security origin from the main page.
Manual test: deviceorientation-main-frame-only.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::isSameSecurityOriginAsMainFrame): New helper function.
(WebCore::DOMWindow::addEventListener): Check if we are the main frame, or the
same security origin as the main frame. If not, don't add the event
listeners.
- 2:45 PM Changeset in webkit [191007] by
-
- 3 edits in trunk/Source/WebCore
ASSERT(m_motionManager) on emgn.com page
https://bugs.webkit.org/show_bug.cgi?id=150070
<rdar://problem/18383732>
Reviewed by Simon Fraser.
In the WebCoreMotionManager init method, we call
into another setup method on the main thread.
However, if a listener was attached before that
ran, we'd ASSERT. This wasn't actually causing a bug
because the main thread initialization would
check the listeners once it got a chance to run.
The fix is to only check status when we've
actually initialized.
- platform/ios/WebCoreMotionManager.h: New m_initialized boolean.
- platform/ios/WebCoreMotionManager.mm: Check m_initialized before doing real work.
(-[WebCoreMotionManager init]):
(-[WebCoreMotionManager addMotionClient:]):
(-[WebCoreMotionManager removeMotionClient:]):
(-[WebCoreMotionManager addOrientationClient:]):
(-[WebCoreMotionManager removeOrientationClient:]):
(-[WebCoreMotionManager initializeOnMainThread]):
- 2:28 PM Changeset in webkit [191006] by
-
- 2 edits in trunk/LayoutTests
A lot of the http/tests/cache/disk-cache/ tests are flaky on mac-wk2, marking them as such.
https://bugs.webkit.org/show_bug.cgi?id=149087
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-13
Reviewed by Alexey Proskuryakov.
- platform/mac-wk2/TestExpectations:
- 1:30 PM Changeset in webkit [191005] by
-
- 4 edits in trunk/Tools
Mac Debug and 32-bit queues should be separate
https://bugs.webkit.org/show_bug.cgi?id=150092
Reviewed by Lucas Forschler.
- QueueStatusServer/config/queues.py:
- QueueStatusServer/model/queues.py:
(Queue._capitalize_after_dash):
(Queue._caplitalize_after_dash): Deleted.
- Scripts/webkitpy/common/config/ews.json:
- 1:23 PM Changeset in webkit [191004] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r189567): Web Inspector: Clipped filter icons when debugger sidebar is narrow
https://bugs.webkit.org/show_bug.cgi?id=150023
r189567 changed flexbox items' default min-width from 0 to auto.
Explicitly set it to 0 in CSS.
Reviewed by Brian Burg.
- UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
- 1:08 PM Changeset in webkit [191003] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeBlock write barriers should be precise
https://bugs.webkit.org/show_bug.cgi?id=150042
Reviewed by Saam Barati.
CodeBlock performs lots of unnecessary write barriers. This wastes
performance and makes the code a bit harder to follow, and it might mask
important bugs. Now is a good time to unmask important bugs.
- bytecode/CodeBlock.h:
(JSC::CodeBlockSet::mark): Don't write barrier all CodeBlocks on the
stack. Only CodeBlocks that do value profiling need write barriers, and
they do those themselves.
In steady state, when most of our CodeBlocks are old and FTL-compiled,
and we're doing eden GC's, we should almost never visit a CodeBlock.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget): Don't write barrier all inlined
CodeBlocks on exit. That's not necessary. Instead, write barrier the
CodeBlock(s) we will exit to, along with the one we will write a value
profile to.
- 12:15 PM Changeset in webkit [191002] by
-
- 35 edits in trunk/Source
Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091
Reviewed by Sam Weinig.
Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:
- bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::processObjectLog):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame getDictationResultRanges:andMetadatas:]):
Source/WebKit2:
- UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):
- 12:03 PM Changeset in webkit [191001] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't shadow global Object constructor in WebInspector.Object class definition
https://bugs.webkit.org/show_bug.cgi?id=150093
Reviewed by Joseph Pecoraro.
Currently, class expression does not define any variables. So even in
class Object { },
we were able to touch the global Object constructor (likeObject.keys).
However, that is a bug. After https://bugs.webkit.org/show_bug.cgi?id=150089 fixes that bug,
the globalObjectis shadowed by the user-definedclass Objectname.
To solve this issue, we changed the
class Objecttoclass WebInspectorObject.
And we expose this class as aWebInspector.Object.
- UserInterface/Base/Object.js:
- 12:03 PM Changeset in webkit [191000] by
-
- 6 edits in trunk/Source/WebCore
Move Image::drawPattern for CG into GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=150077
Reviewed by Myles C. Maxfield.
In order to consolidate code that calls into Core Graphics inside
GraphicsContext, move the body of Image::drawPattern() into
GraphicsContextCG.cpp, and do the same for Cairo.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawPattern):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::drawPatternCallback):
(WebCore::patternReleaseCallback):
(WebCore::GraphicsContext::drawPattern):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
(WebCore::drawPatternCallback): Deleted.
(WebCore::patternReleaseCallback): Deleted.
- 11:49 AM Changeset in webkit [190999] by
-
- 5 edits in trunk
Unprefix font-kerning
https://bugs.webkit.org/show_bug.cgi?id=150080
Reviewed by Sam Weinig.
This is the last property in CSS3 Fonts which is prefixed.
Source/WebCore:
Test: fast/text/font-kerning.html
- css/CSSPropertyNames.in:
LayoutTests:
- fast/text/font-kerning-expected.html:
- fast/text/font-kerning.html:
- 11:46 AM Changeset in webkit [190998] by
-
- 16 edits in trunk/Source
Add debug settings for using giant tiles (4096x4096)
https://bugs.webkit.org/show_bug.cgi?id=149977
<rdar://problem/23017093>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-13
Reviewed by Tim Horton.
Source/WebCore:
Instead of creating the GraphicsLayer with a fixed size 512x512, we need
to read the useGiantTiles setting. If its value is true, we set the layer
tileSize to 4096x4096.
- page/Settings.in:
Define the name of the setting and its default value.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::tileSize):
Define tileSize() in the base class GraphicsLayerClient. This is going to
be overridden RenderLayerBacking.
- platform/graphics/TiledBacking.h:
(WebCore::defaultTileSize):
Define the default tileSize which will depend on the useGiantTiles
setting.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerTileSize):
Implement the virtual function GraphicsLayerCA::platformCALayerTileSize().
It passes the call to client GraphicsLayerClient which can be RenderLayerBacking
in our case.
- platform/graphics/ca/GraphicsLayerCA.h:
Override base class function PlatformCALayerClient::PlatformCALayerClient().
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerTileSize):
Define platformCALayerTileSize() in the base class PlatformCALayerClient.
This is going to be overridden GraphicsLayerCA.
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::TileController):
No need for the member m_tileSize.
(WebCore::TileController::computeTileCoverageRect):
Use the function tileSize() instead of using the static values.
(WebCore::TileController::tileSize):
The tileSize will be retrieved from the owning graphics layer.
- platform/graphics/ca/TileController.h:
No need for the member m_tileSize. The tileSize will be retrieved from the owning graphics layer.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
Use the function tileSize() instead of using the static values.
(WebCore::RenderLayerBacking::tileSize):
Override base class function GraphicsLayerClient::tileSize().
- rendering/RenderLayerBacking.h:
Define the concrete method RenderLayerBacking::tilSize().
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetUseGiantTiles):
(WKPreferencesGetUseGiantTiles):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 11:35 AM Changeset in webkit [190997] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 11:34 AM Changeset in webkit [190996] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 11:34 AM Changeset in webkit [190995] by
-
- 3 edits in trunk/Source/WebCore
Try to fix ENABLE(DETAILS_ELEMENT) with SHADOW_DOM disabled.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Node.cpp:
(WebCore::traverseStyleParent):
- 11:05 AM Changeset in webkit [190994] by
-
- 3 edits1 delete in trunk/LayoutTests
http/tests/multipart/multipart-replace-non-html-content.php shouldn't exercise
edge cases of multipart parsing
https://bugs.webkit.org/show_bug.cgi?id=149978
rdar://problem/22981062
Reviewed by Anders Carlsson.
This test is not about HTTP edge cases, but about handling of multipart content in WebKit.
- http/tests/multipart/multipart-replace-non-html-content.php:
- platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
- platform/win/TestExpectations:
- 10:44 AM Changeset in webkit [190993] by
-
- 5 edits in trunk/Source/WebCore
Fix license and copyrights of WebCore js binding builtin files
https://bugs.webkit.org/show_bug.cgi?id=150027
Reviewed by Darin Adler.
Fixing copyright on all three files.
Moving to BSD-like license as they should have been in the first place.
Ordering lexicographically the builtin names in WebCoreBuiltinNames.h.
No change in behaviour.
- bindings/js/WebCoreBuiltinNames.h:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- bindings/js/WebCoreJSBuiltinInternals.h:
- 9:54 AM Changeset in webkit [190992] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Avoid crash due to invalid screen bounds
https://bugs.webkit.org/show_bug.cgi?id=150048
<rdar://problem/22112664>
Reviewed by Jer Noble.
Check for an invalid bounds, and reset it to a known state before
attempting to use it.
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::setVideoLayerFrameFenced):
- 9:03 AM Changeset in webkit [190991] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION: ASSERT (impl->isAtomic()) @ facebook.com
https://bugs.webkit.org/show_bug.cgi?id=149965
Reviewed by Geoffrey Garen.
Edge filtering for CheckIdent ensures that a given value is either Symbol or StringIdent.
However, this filtering is not applied to CheckIdent when propagating a constant value in
the constant folding phase. As a result, it is not guaranteeed that a constant value
propagated in constant folding is Symbol or StringIdent.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 8:42 AM Changeset in webkit [190990] by
-
- 1 edit47 adds in trunk/LayoutTests
[iOS] Update anonymous table results for iOS port.
Unreviewed gardening.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-015-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-016-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-023-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-024-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-035-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-036-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-037-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-038-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-045-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-046-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-047-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-048-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-049-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-050-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-055-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-056-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-091-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-092-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-099-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-100-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-105-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-106-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-107-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-108-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-109-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-110-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-111-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-112-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-113-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-114-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-115-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-116-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-121-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-122-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-123-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-124-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-139-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-140-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-149-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-150-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-155-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-156-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-159-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-160-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-165-expected.txt: Added.
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-166-expected.txt: Added.
- 8:10 AM Changeset in webkit [190989] by
-
- 9 edits in releases/WebKitGTK/webkit-2.10
Merge r190987 - [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- Shared/gtk/NativeWebTouchEventGtk.cpp:
- Shared/gtk/WebEventFactory.cpp:
- Shared/gtk/WebEventFactory.h:
- UIProcess/API/gtk/PageClientImpl.cpp:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
Tools:
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
- 8:09 AM Changeset in webkit [190988] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r190930 - Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061
Reviewed by Carlos Garcia Campos.
Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):
- 7:42 AM Changeset in webkit [190987] by
-
- 9 edits in trunk
[GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- Shared/gtk/NativeWebTouchEventGtk.cpp:
- Shared/gtk/WebEventFactory.cpp:
- Shared/gtk/WebEventFactory.h:
- UIProcess/API/gtk/PageClientImpl.cpp:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
Tools:
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
- 6:48 AM Changeset in webkit [190986] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r189912 - [GTK] Crash in WebKit::BackingStore::createBackend running under Wayland
https://bugs.webkit.org/show_bug.cgi?id=147453
Reviewed by Carlos Garcia Campos.
Except when running on X11, this function always crashes if called before the web view is
realized, as gdk_window_create_similar_surface will return null in that case. Avoid this by
simply realizing the widget before calling that.
Thanks to Carlos Garnacho for some debugging help.
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend):
- 6:48 AM WebKitGTK/2.10.x edited by
- (diff)
- 6:47 AM Changeset in webkit [190985] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Merge r190909 - [GTK] OSX linker doesn't understand --whole-archive
https://bugs.webkit.org/show_bug.cgi?id=144557
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Martin Robinson.
.:
- Source/cmake/OptionsGTK.cmake: Turn the macro
ADD_WHOLE_ARCHIVE_TO_LIBRARIES into a no-op on Darwin systems,
because XCode's linker doesn't have the --whole-archive option.
Source/WebKit2:
- PlatformGTK.cmake: Link with extra libraries on Darwin, since
we don't have the --whole-archive linker option.
- 6:43 AM WebKitGTK/2.10.x edited by
- (diff)
- 6:29 AM Changeset in webkit [190984] by
-
- 12 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r190879 - Clip-path transitions sometimes trigger endless animation timers
https://bugs.webkit.org/show_bug.cgi?id=150018
Reviewed by Tim Horton.
Source/WebCore:
Transitioning -webkit-clip-path could trigger endless animation
timers, because when CompositeAnimation::updateTransitions() calls
isTargetPropertyEqual(), a false negative answer triggers canceling the
current transition and starting a new one over and over.
This happened because StyleRareNonInheritedData simply tested pointer
equality for m_clipPath and m_shapeOutside. Both of these need to do deep
equality testing, requiring the implementation of operator== in BasicShapes
classes.
In addition, the PropertyWrappers in CSSPropertyAnimation need equals()
implementations that also do more than pointer equality testing.
Tests: transitions/clip-path-transitions.html
transitions/shape-outside-transitions.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperClipPath::equals):
(WebCore::PropertyWrapperShape::equals):
- rendering/ClipPathOperation.h:
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCircle::operator==):
(WebCore::BasicShapeEllipse::operator==):
(WebCore::BasicShapePolygon::operator==):
(WebCore::BasicShapeInset::operator==):
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::operator==):
(WebCore::BasicShapeRadius::operator==):
- rendering/style/ShapeValue.cpp:
(WebCore::pointersOrValuesEqual):
(WebCore::ShapeValue::operator==):
- rendering/style/ShapeValue.h:
(WebCore::ShapeValue::operator!=):
(WebCore::ShapeValue::operator==): Deleted.
(WebCore::ShapeValue::ShapeValue): Deleted.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::clipPathOperationsEquivalent):
(WebCore::StyleRareNonInheritedData::shapeOutsideDataEquivalent):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
New tests for transitions of clip-path and shape-outside.
- transitions/clip-path-transitions-expected.txt: Added.
- transitions/clip-path-transitions.html: Added.
- transitions/resources/transition-test-helpers.js:
(parseClipPath):
(checkExpectedValue):
- transitions/shape-outside-transitions-expected.txt: Added.
- transitions/shape-outside-transitions.html: Added.
- transitions/svg-transitions-expected.txt:
- 6:12 AM Changeset in webkit [190983] by
-
- 18 edits2 adds in trunk
Implement iterator for traversing composed DOM
https://bugs.webkit.org/show_bug.cgi?id=149997
Reviewed by Ryosuke Niwa.
Source/WebCore:
ComposedTreeIterator traverses the DOM in composed tree order. This means it enters
shadow trees and follows slots created by Shadow DOM API correctly.
auto children = composedTreeChildren(containerNode);
for (auto& composedChild : children)
...
auto descendants = composedTreeDescendants(containerNode);
for (auto& composedDescendant : descendants)
...
- WebCore.xcodeproj/project.pbxproj:
- dom/ComposedTreeIterator.cpp: Added.
(WebCore::ComposedTreeIterator::initializeShadowStack):
(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::traverseNextSiblingSlot):
(WebCore::ComposedTreeIterator::traversePreviousSiblingSlot):
(WebCore::ComposedTreeIterator::traverseParentInShadowTree):
- dom/ComposedTreeIterator.h: Added.
(WebCore::ComposedTreeIterator::operator*):
(WebCore::ComposedTreeIterator::operator->):
(WebCore::ComposedTreeIterator::operator==):
(WebCore::ComposedTreeIterator::operator!=):
(WebCore::ComposedTreeIterator::ShadowContext::ShadowContext):
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
(WebCore::ComposedTreeIterator::traverseNext):
(WebCore::ComposedTreeIterator::traverseNextSibling):
(WebCore::ComposedTreeIterator::traversePreviousSibling):
(WebCore::ComposedTreeIterator::traverseParent):
(WebCore::ComposedTreeChildAdapter::Iterator::Iterator):
(WebCore::ComposedTreeChildAdapter::Iterator::operator++):
(WebCore::ComposedTreeChildAdapter::Iterator::operator--):
(WebCore::ComposedTreeChildAdapter::ComposedTreeChildAdapter):
(WebCore::ComposedTreeChildAdapter::begin):
(WebCore::ComposedTreeChildAdapter::end):
(WebCore::ComposedTreeChildAdapter::at):
(WebCore::composedTreeChildren):
- dom/NodeRenderingTraversal.cpp:
(WebCore::NodeRenderingTraversal::parentSlow):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::firstChildSlow): Deleted.
(WebCore::NodeRenderingTraversal::nextSiblingSlow): Deleted.
(WebCore::NodeRenderingTraversal::previousSiblingSlow): Deleted.
- dom/NodeRenderingTraversal.h:
(WebCore::NodeRenderingTraversal::parent):
(WebCore::NodeRenderingTraversal::firstChild): Deleted.
(WebCore::NodeRenderingTraversal::nextSibling): Deleted.
(WebCore::NodeRenderingTraversal::previousSibling): Deleted.
- style/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::computeNextSibling):
Restore the full assert.
(WebCore::RenderTreePosition::invalidateNextSibling):
(WebCore::RenderTreePosition::previousSiblingRenderer):
(WebCore::RenderTreePosition::nextSiblingRenderer):
Make these member functions.
Use the iterator. This is fixes some bugs and allows enabling a test case.
- style/RenderTreePosition.h:
- style/StyleResolveTree.cpp:
(WebCore::Style::textRendererIsNeeded):
LayoutTests:
Re-enable fast/html/details-replace-text.html which is fixed by this change.
- fast/forms/select-listbox-focus-displaynone-expected.txt:
- fast/repaint/text-in-relative-positioned-inline-expected.txt:
- fullscreen/full-screen-fixed-pos-parent-expected.txt:
- platform/mac-mavericks/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-add-child-2-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
Non-visual whitespace changes.
- 6:05 AM Changeset in webkit [190982] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r190862 - webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand
Don't include CoreFoundation.h when building the GTK port.
- Source/JavaScriptCore/API/WebKitAvailability.h: Add !defined(BUILDING_GTK) to defined(APPLE).
- 6:03 AM Changeset in webkit [190981] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r190857 - webkit-gtk-2.3.4 fails to link JavaScriptCore, missing symbols add_history and readline
https://bugs.webkit.org/show_bug.cgi?id=127059
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.
- shell/CMakeLists.txt: Link JSC with -ledit on Mac OSX.
- 6:01 AM Changeset in webkit [190980] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10
Merge r190856 - [GTK] Use --version-script only on Linux
https://bugs.webkit.org/show_bug.cgi?id=144555
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.
- Source/cmake/OptionsGTK.cmake: Don't add --version-script
option on Darwin (whose linker doesn't support it.)
- 5:46 AM WebKitGTK/2.10.x edited by
- (diff)
- 5:44 AM WebKitGTK/2.8.x edited by
- (diff)
- 5:43 AM Changeset in webkit [190979] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r190843 - Reduce pointless malloc traffic in CodeBlock construction.
<https://webkit.org/b/149999>
Reviewed by Antti Koivisto.
Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
- bytecode/CodeBlock.h:
- 5:05 AM Changeset in webkit [190978] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190842 - Reduce pointless malloc traffic in ElementRuleCollector.
<https://webkit.org/b/150003>
Reviewed by Antti Koivisto.
Don't use a unique_ptr for the m_matchedRules vector in ElementRuleCollector.
This is one of our heaviest sources of transient allocations, with ~88000
malloc/free pairs on loading theverge.com.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::hasMatchedRules):
- 5:03 AM Changeset in webkit [190977] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190835 - Check if start and end positions are still valid after updating them through VisibleSelection.
https://bugs.webkit.org/show_bug.cgi?id=149982
Reviewed by Ryosuke Niwa.
This patch is required to be able to clean up anonymous tables structure.
In certain edge cases, start/end positions could become nullptr after various text splitting
operations.
Covered by editing/execCommand/crash-137961.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):
- 5:01 AM Changeset in webkit [190976] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190820 - Garbage texture data with composited table row
https://bugs.webkit.org/show_bug.cgi?id=148984
Reviewed by Zalan Bujtas.
Source/WebCore:
Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.
Test: compositing/contents-opaque/table-parts.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
- compositing/contents-opaque/table-parts-expected.txt: Added.
- compositing/contents-opaque/table-parts.html: Added.
- 5:00 AM Changeset in webkit [190975] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190818 - Garbage pixels on enphaseenergy.com site
https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184
Reviewed by Darin Adler.
Source/WebCore:
When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.
Also improve the compositing logging to indicate when fore- and background layers
are present.
Test: compositing/contents-opaque/negative-z-before-html.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
LayoutTests:
New ref test. Also update the expected result for another test that uses negative
z-index children.
- compositing/contents-opaque/body-background-painted-expected.txt:
- compositing/contents-opaque/negative-z-before-html-expected.html: Added.
- compositing/contents-opaque/negative-z-before-html.html: Added.
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
- 4:56 AM Changeset in webkit [190974] by
-
- 5 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r190760 - Gracefully handle XMLDocumentParser being detached by mutation events.
https://bugs.webkit.org/show_bug.cgi?id=149485
<rdar://problem/22811489>
Source/WebCore:
This is a merge of Blink change 200026,
https://codereview.chromium.org/1267283002
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.
Test: fast/parser/xhtml-dom-character-data-modified-crash.html
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::createLeafTextNode):
Renamed from enterText() to make it more descriptive.
(WebCore::XMLDocumentParser::updateLeafTextNode):
Renamed from exitText to firm up this stage.
(WebCore::XMLDocumentParser::end):
Gracefully handle stopped states.
(WebCore::XMLDocumentParser::enterText): Deleted.
(WebCore::XMLDocumentParser::exitText): Deleted.
- xml/parser/XMLDocumentParser.h:
Rename enterText to createLeafTextNode.
Rename exitText to updateLeafTextNode.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::endDocument):
Rename function calls and firm up updateLeafTextNode stage accordingly.
LayoutTests:
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.
- fast/parser/resources/xhtml-overwrite-frame.xhtml: Added.
- fast/parser/xhtml-dom-character-data-modified-crash-expected.txt: Added.
- fast/parser/xhtml-dom-character-data-modified-crash.html: Added.
- 4:50 AM Changeset in webkit [190973] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190755 - data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829
Reviewed by Darin Adler.
Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
- 4:47 AM Changeset in webkit [190972] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190732 - Add NULL check for renderBox::layer() on applying zoom level change
https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/zoom-on-nested-scroll-crash.html
This is a merge of Blink r158238:
https://chromiumcodereview.appspot.com/23526081
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
- fast/css/zoom-on-nested-scroll-crash.html: Added.
- 4:38 AM Changeset in webkit [190971] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190728 - CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359
Reviewed by Andreas Kling.
Source/WebCore:
Test: svg/css/use-window-inactive-crash.html
- css/SelectorCheckerTestFunctions.h:
(WebCore::isWindowInactive):
Null check page.
LayoutTests:
The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.
- svg/css/use-window-inactive-crash-expected.html: Added.
- svg/css/use-window-inactive-crash.html: Added.
- 4:30 AM Changeset in webkit [190970] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Use GUniquePtr for GtkIconInfo
https://bugs.webkit.org/show_bug.cgi?id=150082
Reviewed by Carlos Garcia Campos.
GtkIconInfo cab be wrapped by a smart pointer, GUniqueptr.
No new test required since no functionality changed.
- rendering/RenderThemeGtk.cpp:
(WebCore::getStockSymbolicIconForWidgetType):
- 4:24 AM Changeset in webkit [190969] by
-
- 3 edits5 adds in releases/WebKitGTK/webkit-2.10
Merge r190662 - [GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.
Test: fast/dom/HTMLProgressElement/native-progress-bar.html
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):
LayoutTests:
- fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
- platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
- platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
- platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
- platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
- 4:21 AM Changeset in webkit [190968] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190658 - Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920
Reviewed by Simon Fraser.
When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.
When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.
Source/WebCore:
Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html
- rendering/RenderLayer.h:
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
LayoutTests:
- css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
- fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
- fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
- fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.
- 4:04 AM Changeset in webkit [190967] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190641 - Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
https://bugs.webkit.org/show_bug.cgi?id=149847
Reviewed by Antti Koivisto.
Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only
process attributes that make sense given the current tagId. In particular,
- We only process the charset parameter if the tag is a link or a script.
- We only process the sizes / srcset attributes if the tag is an img.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.
- 4:03 AM Changeset in webkit [190966] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r190634 - Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300
<rdar://problem/22747046>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-06
Reviewed by Chris Dumez.
Source/WebCore:
This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/177093016
https://codereview.chromium.org/1124863003
Test: editing/style/apply-style-crash2.html
editing/style/apply-style-crash3.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.
Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.
This CL also adds a few more assertions to catch similar issues
more easily in the future.
LayoutTests:
- editing/style/apply-style-crash2-expected.txt: Added.
- editing/style/apply-style-crash2.html: Added.
- editing/style/apply-style-crash3-expected.txt: Added.
- editing/style/apply-style-crash3.html: Added.
- 4:02 AM Changeset in webkit [190965] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190627 - Remove redundant isComposited() function and replace
hasLayer() && layer()->isComposited() with RenderObject::isComposited().
https://bugs.webkit.org/show_bug.cgi?id=149846
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
- rendering/RenderView.cpp:
(WebCore::rendererObscuresBackground):
(WebCore::isComposited): Deleted.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
- 4:00 AM Changeset in webkit [190964] by
-
- 20 edits in releases/WebKitGTK/webkit-2.10
Merge r190615 - Fix ENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=146511
Patch by Emanuele Aina <Emanuele Aina> on 2015-10-06
Reviewed by Darin Adler.
.:
- Source/cmake/OptionsGTK.cmake: Make ENABLE_WAYLAND_TARGET depend on
ENABLE_OPENGL due to EGL usage.
Source/WebCore:
- platform/graphics/texmap/BitmapTextureGL.h:
- platform/graphics/texmap/BitmapTextureGL.cpp:
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/texmap/TextureMapperShaderProgram.h:
- platform/graphics/texmap/TextureMapperShaderProgram.cpp:
Fix TEXTURE_MAPPER_GL vs. TEXTURE_MAPPER guards to make sure that
ENABLE_OPENGL=OFF only disables the GL-related parts.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):
(webkitWebViewBaseDraw):
(webkitWebViewBaseDidRelaunchWebProcess):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
webkitWebViewRenderAcceleratedCompositingResults()
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::DrawingArea):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/LayerTreeHost.h:
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):
Default to no AC if no GL support has been built.
- WebProcess/WebPage/DrawingArea.messages.in:
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
SetNativeSurfaceHandleForCompositing.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
Force setAcceleratedCompositingEnabled() only if a LayerTreeHost
implementation is available, to avoid crashing when building without
any GL support.
- 3:57 AM Changeset in webkit [190963] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190605 - data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829
Reviewed by Ryosuke Niwa.
Source/WebCore:
Update the HTMLPreloadScanner so that data: URLs do not get preloaded.
There is no need as the data is already available.
Test: fast/preloader/image-data-url.html
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
LayoutTests:
Add layout test to make sure that images with a data: URL do not
get preloaded.
- fast/preloader/image-data-url-expected.txt: Added.
- fast/preloader/image-data-url.html: Added.
- 3:56 AM Changeset in webkit [190962] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190597 - CSSGradientValue should check whether gradientLength is zero or not.
https://bugs.webkit.org/show_bug.cgi?id=149373
<rdar://problem/22771418>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Darin Adler.
Source/WebCore:
This is a merge of Blink r158220,
https://chromiumcodereview.appspot.com/24350008
Test: fast/gradients/css3-repeating-radial-gradients-crash.html
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
Check whether gradientLength > 0 before using it as denominator.
LayoutTests:
- fast/gradients/css3-repeating-radial-gradients-crash-expected.txt: Added.
- fast/gradients/css3-repeating-radial-gradients-crash.html: Added.
- 3:55 AM Changeset in webkit [190961] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190592 - Reference cycles during SVG dependency invalidation
https://bugs.webkit.org/show_bug.cgi?id=149824
<rdar://problem/22771412>
Reviewed by Tim Horton.
Source/WebCore:
Detect any reference cycles as we are invalidating.
This is mostly a merge of the following Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51
Test: svg/custom/reference-cycle.svg
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies): Keep around a hash
table of dependencies, so that we can detect if an element is already
present before marking it.
LayoutTests:
Adding a test that has a cycle between feImage resources.
Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51
- svg/custom/reference-cycle-expected.txt: Added.
- svg/custom/reference-cycle.svg: Added.
- 3:54 AM Changeset in webkit [190960] by
-
- 7 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r190588 - Fix null pointer dereference in WebSocket::connect()
https://bugs.webkit.org/show_bug.cgi?id=149311
<rdar://problem/22748858>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Chris Dumez.
Source/WebCore:
This is a merge of Blink r187441,
https://codereview.chromium.org/785933005
Test: http/tests/websocket/construct-in-detached-frame.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
Call function implemented below instead of duplicating the code.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::shouldBypassMainWorldContentSecurityPolicy):
- page/ContentSecurityPolicy.h:
Factor the logic to check shouldBypassMainWorldContentSecurityPolicy into
a function in this class. Check Frame pointers are not null before getting
shouldBypassMainWorldContentSecurityPolicy via those pointers.
- page/EventSource.cpp:
(WebCore::EventSource::create):
This got fixed as a bonus.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
This got fixed as a bonus too.
LayoutTests:
- http/tests/websocket/construct-in-detached-frame-expected.txt: Added.
- http/tests/websocket/construct-in-detached-frame.html: Added.
- http/tests/websocket/resources/construct-in-detached-frame.html: Added.
- 3:53 AM Changeset in webkit [190959] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to the committers list.
- 3:51 AM Changeset in webkit [190958] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r190585 - ShadowRoot with leading or trailing white space cause a crash
https://bugs.webkit.org/show_bug.cgi?id=149782
Reviewed by Chris Dumez.
Source/WebCore:
Fixed the crash by adding a null pointer check since a TextNode that appears as a direct child
of a ShadowRoot doesn't have a parent element.
Test: fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html
- style/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::previousSiblingRenderer):
LayoutTests:
Added a regression test.
- fast/shadow-dom/shadow-root-with-child-whitespace-text-crash-expected.txt: Added.
- fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html: Added.
- 3:49 AM Changeset in webkit [190957] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190570 - Mark the line dirty when RenderQuote's text changes.
https://bugs.webkit.org/show_bug.cgi?id=149784
rdar://problem/22558169
Reviewed by Antti Koivisto.
When quotation mark changes ( " -> ' or empty string), we
need to mark the line dirty to ensure its content gets laid out properly.
Source/WebCore:
Test: fast/inline/quotation-text-changes-dynamically.html
- rendering/RenderQuote.cpp:
(WebCore::quoteTextRenderer):
(WebCore::RenderQuote::updateText):
(WebCore::fragmentChild): Deleted.
LayoutTests:
- fast/inline/quotation-text-changes-dynamically-expected.txt: Added.
- fast/inline/quotation-text-changes-dynamically.html: Added.
- 3:47 AM Changeset in webkit [190956] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190558 - GLContext should control ownership of context-related objects
https://bugs.webkit.org/show_bug.cgi?id=149794
Reviewed by Martin Robinson.
Creation of GLContext objects can depend on various platform-specific
objects like native window representations. Since these objects are
used solely for the GLContext purposes, it would make sense to allow
GLContext to provide an extensible way to impose ownership on these
objects and control their lifetime.
GLContext::Data is declared with a defaulted virtual destructor.
Users of these implementations can declare classes that derive from
GLContext::Data and store context-related objects in instances of the
derived class, and ensure that these objects are properly cleaned up
when GLContext destroys the Data object.
The GLContext::Data object is managed through a protected
std::unique_ptr<> member in the GLContext class. For now the member
is only set in GLContextEGL::createWindowContext() and is destroyed
during the GLContext destruction.
The local OffscreenContextData class in
PlatformDisplayWayland::createSharingGLContext() derives from
GLContext::Data and is used to store the wl_surface and
EGLNativeWindowType (aka wl_egl_window) objects for offscreen
GLContexts under the Wayland platform that are used for the sharing
context and WebGL, effectively avoiding the leak that would further
propagate problems into the compositor and the graphics library.
(Such offscreen contexts are actually mimicked via a 1x1px
wl_egl_window object that acts as a dummy base for the related
wl_surface object).
- platform/graphics/GLContext.h:
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createWindowContext):
- platform/graphics/egl/GLContextEGL.h:
- platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::createSharingGLContext):
- 3:45 AM Changeset in webkit [190955] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190557 - Make gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
https://bugs.webkit.org/show_bug.cgi?id=149793
Reviewed by Carlos Garcia Campos.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
Instead of including <gdk/gdk.h> header for all platforms but EFL, only
include it for the GTK platform, since no other platform depends on the
GDK library.
- 3:41 AM Changeset in webkit [190954] by
-
- 28 edits in releases/WebKitGTK/webkit-2.10
Merge r190505 - popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265
Patch by Antoine Quint <Antoine Quint> on 2015-10-02
Reviewed by Darin Adler.
Source/WebCore:
Don't fire popstate event on initial document load
According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it. A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.
Patch adapted from work by jl@opera.com on Blink [2].
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision
- dom/Document.cpp:
(WebCore::Document::implicitClose):
Source/WebKit2:
Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState):
LayoutTests:
Updating tests that relied on a "popstate" event being fired at page load.
- fast/history/same-document-iframes-changing-fragment-expected.txt:
- fast/history/same-document-iframes-changing-pushstate-expected.txt:
- fast/loader/javascript-url-iframe-remove-on-navigate.html:
- fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
- fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
- fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
- fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
- fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
- fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
- fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
- fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
- fast/loader/stateobjects/popstate-fires-with-page-cache.html:
- fast/loader/stateobjects/pushstate-object-types.html:
- fast/loader/stateobjects/pushstate-then-replacestate.html:
- fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
- fast/loader/stateobjects/replacestate-then-pushstate.html:
- fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
- fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
- fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
- http/tests/history/popstate-fires-with-pending-requests.html:
- http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
- http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:
- 3:35 AM Changeset in webkit [190953] by
-
- 3 edits6 adds in releases/WebKitGTK/webkit-2.10
Merge r190418 - Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174
Reviewed by Chris Dumez.
Source/WebKit2:
If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
runs through the same code paths as when receiving a redirect from network.
LayoutTests:
- http/tests/cache/redirect-referer-expected.html: Added.
- http/tests/cache/redirect-referer.html: Added.
- http/tests/cache/resources/load-and-check-referer.php: Added.
- http/tests/cache/resources/permanent-redirect.php: Added.
- http/tests/cache/resources/redirect-referer-iframe.html: Added.
- http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.
- 3:34 AM Changeset in webkit [190952] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10
Merge r190413 - [GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710
Reviewed by Martin Robinson.
Source/WebCore:
We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.
- platform/network/gtk/CredentialBackingStore.cpp:
(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):
Source/WebKit2:
Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.
- UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize):
Tools:
Add test case to check that we can authenticate sites with an
empty realm.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):
- 3:30 AM Changeset in webkit [190951] by
-
- 1 edit2 adds in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI
Merge r190405 - [GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847
Reviewed by Carlos Garcia Campos.
- UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
- UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
- 3:30 AM Changeset in webkit [190950] by
-
- 3 edits19 adds in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI
Merge r190404 - [GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846
Reviewed by Carlos Garcia Campos.
- UserInterface/Images/gtk/AUTHORS: Updated.
- UserInterface/Images/gtk/ClearBoth.svg: Added.
- UserInterface/Images/gtk/ClearLeft.svg: Added.
- UserInterface/Images/gtk/ClearRight.svg: Added.
- UserInterface/Images/gtk/CubicBezier.svg: Updated.
- UserInterface/Images/gtk/FloatLeft.svg: Added.
- UserInterface/Images/gtk/FloatRight.svg: Added.
- UserInterface/Images/gtk/FontStyleItalic.svg: Added.
- UserInterface/Images/gtk/FontStyleNormal.svg: Added.
- UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
- UserInterface/Images/gtk/TextAlignCenter.svg: Added.
- UserInterface/Images/gtk/TextAlignJustify.svg: Added.
- UserInterface/Images/gtk/TextAlignLeft.svg: Added.
- UserInterface/Images/gtk/TextAlignRight.svg: Added.
- UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
- UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
- UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
- UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
- UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
- UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
- UserInterface/Images/gtk/VisualStyleNone.svg: Added.
- 3:26 AM Changeset in webkit [190949] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190382 - GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>
Reviewed by Simon Fraser.
While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.
- 3:25 AM Changeset in webkit [190948] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190375 - Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>
Reviewed by Simon Fraser.
Source/WebCore:
The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.
The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.
Tests: svg/custom/many-glyphs.svg
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendCFFTable):
LayoutTests:
- svg/custom/many-glyphs-expected.svg: Added.
- svg/custom/many-glyphs.svg: Added.
- 3:23 AM Changeset in webkit [190947] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI
Merge r190369 - [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681
Reviewed by Joseph Pecoraro.
- UserInterface/Images/gtk/CubicBezier.svg: Added.
- 3:23 AM Changeset in webkit [190946] by
-
- 15 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r190364 - Unreviewed, roll out r188331: "NetworkProcess: DNS prefetch happens in the Web Process"
<rdar://problem/22560715>
Speculative roll out of r188331 as we had a ~2.5% PLT regression around
the time it landed and it seems the most likely culprit. I'll reland if
the perf bots do not recover after the roll out.
Source/WebCore:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- loader/FrameLoaderClient.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession): Deleted.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- 3:17 AM Changeset in webkit [190945] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r190345 - [GTK] Build error with -DENABLE_SPELLCHECK=OFF
https://bugs.webkit.org/show_bug.cgi?id=146904
Reviewed by Carlos Garcia Campos.
Add ifdef guards to allow building when SPELLCHECK is not enabled.
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
(WebKit::TextChecker::requestCheckingOfString):
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::setSpellCheckingLanguages):
(WebKit::TextChecker::loadedSpellCheckingLanguages):
- 3:16 AM Changeset in webkit [190944] by
-
- 14 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r190344 - [GTK] Support HiDPI Properly in WebKitGtk+ with the TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=141782
Reviewed by Carlos Garcia Campos.
Source/WebCore:
This patch fixes HiDPI issue in the TextureMapper.
To support HiDPI in the TextureMapper, we need to draw scaled contents
in the TextureMapperTile, and apply the global scale in the root layer
to apply transforms correctly.
Supporting the device scale is handled at LayerTreeHostGtk and
TextureMapperBackingStore, and GraphicsLayerTextureMapper doesn't handle
the device scale directly.
From the TextureMapperLayer, deviceScale and pageScale do not have to be
handled differently. These are multiplied and provided to
TextureMapperBackingStore.
- platform/graphics/texmap/TextureMapperTile.cpp:
(WebCore::TextureMapperTile::updateContents):
- platform/graphics/texmap/TextureMapperTile.h:
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
Modified to increase the cover rect for tiles creation. For the image
contents, it just creates texture with a image size, regardless of the
contents scale.
- platform/graphics/texmap/BitmapTexture.cpp:
(WebCore::BitmapTexture::updateContents):
Apply the device scale to the graphics context before painting contents.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
Apply the device scale and the page scale to the backing store
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
- UIProcess/gtk/RedirectedXCompositeWindow.cpp:
Modified to create scaled size of window.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):
We should apply device scale factor to the root layer to apply
the scale matrix before applying other transform matrices.
(WebKit::LayerTreeHostGtk::deviceScaleFactor): Added.
(WebKit::LayerTreeHostGtk::pageScaleFactor): Added.
- 3:06 AM Changeset in webkit [190943] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190339 - Avoid reparsing an XSLT stylesheet after the first failure.
https://bugs.webkit.org/show_bug.cgi?id=149188
<rdar://problem/22709912>
Reviewed by Dave Hyatt.
Patch by Jiewen Tan, jiewen_tan@apple.com.
Source/WebCore:
Test: svg/custom/invalid-xslt-crash.svg
- xml/XSLStyleSheet.h:
Add a new member variable m_compilationFailed that tracks whether
compilation has failed. Default value is false.
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::compileStyleSheet):
Return early if the compilation has failed before. After compiling the
style sheet, if we failed, set m_compilationFailed to true.
LayoutTests:
- svg/custom/invalid-xslt-crash-expected.txt: Added.
- svg/custom/invalid-xslt-crash.svg: Added.
- 3:00 AM Changeset in webkit [190942] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190320 - Memory cache revalidations should refresh the network disk cache
https://bugs.webkit.org/show_bug.cgi?id=149606
Reviewed by Darin Adler.
Source/WebKit2:
Previously, resource revalidations triggered by the memory cache would
bypass the disk cache entirely because the requests are conditional. As
a result, when the server responds with a 304, we were unable to update
the headers (e.g. new expiration date) of the corresponding entry in
the disk cache.
This patch updates our disk cache implementation to not bypass the disk
cache when the request is conditional. Instead, we look up the cached
entry and force its revalidation from the network. If the server then
returns a 304, we are now able to update the headers of this cached
entry. In such case though, we let the 304 response through to WebCore
unlike revalidations triggered by the disk cache.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):
LayoutTests:
Add layout test to check that revalidations requested by the memory cache
update the corresponding disk cache entry when the server responds with a
304 status code.
- http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache-expected.txt: Added.
- http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html: Added.
- 2:48 AM Changeset in webkit [190941] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Merge r190238 - [GTK] ASSERTION FAILED: !m_inUpdateBackingStoreState in DrawingAreaImpl::display() after DrawingAreaImpl::forceRepaint()
https://bugs.webkit.org/show_bug.cgi?id=148956
Reviewed by Žan Doberšek.
Source/WebKit2:
This is because those tests call notifyDone in the onresize event
handler. InjectedBundlePage::dump() always calls WKBundlePageForceRepaint()
before dumping. When the view is resized DrawingAreaImpl::updateBackingStoreState()
is called, so if the size has changed the FrameView::resize()
method is called and all children are resized, so the onresize
handlers happen at that point, before the
m_inUpdateBackingStoreState is set to false again. For WTR we
could probably just return early from froceReapaint() when
m_inUpdateBackingStoreState is true, because in that case we know
the layout is updated because of the resize and the actual display
is not really needed. But the UI process can also request a force
repaint, so we could wait until the backing store update is done
and then force the repaint. For WTR it will happen after the
dump, but it shouldn't be a problem.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updateBackingStoreState):
- WebProcess/WebPage/DrawingAreaImpl.h:
LayoutTests:
Unskip tests that should pass now.
- platform/gtk/TestExpectations:
- 2:40 AM Changeset in webkit [190940] by
-
- 3 edits5 adds in releases/WebKitGTK/webkit-2.10
Merge r190160 - [GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113
Reviewed by Philippe Normand.
Source/WebCore:
When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.
Test: media/media-controls-play-button-updates.html
- css/mediaControlsGtk.css:
(video::-webkit-media-controls-play-button.paused):
LayoutTests:
- media/media-controls-play-button-updates-expected.png: Added.
- media/media-controls-play-button-updates-expected.txt: Added.
- media/media-controls-play-button-updates.html: Added.
- platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
- platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
- 2:39 AM Changeset in webkit [190939] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190153 - Event fired on a detached node does not bubble up
https://bugs.webkit.org/show_bug.cgi?id=149488
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaselined a test now that one more test case passes.
- web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
Source/WebCore:
The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
Since Firefox's behavior has changed to match DOM4: https://dom.spec.whatwg.org/#concept-event-dispatch
Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.
Test: fast/events/event-propagation-in-detached-tree.html
- dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
LayoutTests:
Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
since our new behavior matches that of the latest Firefox as well as Chrome.
- fast/events/event-propagation-in-detached-tree-expected.txt: Added.
- fast/events/event-propagation-in-detached-tree.html: Added.
- fast/events/mouseout-dead-node-expected.txt:
- fast/events/mouseout-dead-node.html:
- 2:35 AM Changeset in webkit [190938] by
-
- 31 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r190124 - Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
https://bugs.webkit.org/show_bug.cgi?id=149428
Reviewed by Simon Fraser and Darin Adler.
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
Make the RenderingMode parameter to ImageBuffer::create non-optional.
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::renderingMode):
- platform/graphics/GraphicsTypes.h:
Add renderingMode() getter so that every caller doesn't need to do the conversion to RenderingMode.
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::putByteArray):
These five callers create unconditionally unaccelerated ImageBuffers which
should probably instead respect the acceleration bit from the context
that the ImageBuffer will eventually be painted into. Bugs have been filed.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
Adjust the argument order and remove defaults which are passed explicitly.
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRect):
Snapshots are (currently) meant to be taken without accelerated drawing.
Make this explicit.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
Make use of createCompatibleBuffer. This caller was previously creating
an unconditionally unaccelerated context!
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):
Remove a comment.
- platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::getScratchBuffer):
ShadowBlur is only used with unaccelerated contexts, so it's OK to hardcode Unaccelerated here.
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
Flip the order of the arguments.
(WebCore::FilterEffect::openCLImageToImageBuffer):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded):
Adjust the argument order and remove defaults which are passed explicitly.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
Get rid of the unneeded renderingMode local, and factor out retrieval of Frame.
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
These two callers are unconditionally creating unaccelerated buffers,
and changing this to match the destination context seems to actually
break things. This needs further investigation.
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
Make use of renderingMode().
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::createImageBuffer):
Adjust the argument order.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:
(WebKit::ThreadSafeCoordinatedSurface::create):
- 2:19 AM Changeset in webkit [190937] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r190121 - [WK2][NetworkCache] New entry bodies remain in dirty memory after being written to disk.
<https://webkit.org/b/149463>
Reviewed by Antti Koivisto.
Call msync(MS_ASYNC) on cache entry bodies after writing their data to a
memory-mapped file. This turns the previously dirty memory into clean memory,
reducing our effective footprint.
I previously believed this would happen automatically when the kernel finds
itself under memory pressure, around the same time as it starts dropping
volatile pages. Turns out that's not the case. Even under considerable pressure,
we never flush this memory to file. So let's take care of it ourselves.
If this ends up generating more IO activity than we're comfortable with on some
scenario, we can look at throttling.
- NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::Data::mapToFile):
- 2:18 AM Changeset in webkit [190936] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10
Merge r190114 - Source/WebCore:
CurrentTime on mediaController is set as 0 when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154
Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.
Test : media/media-controller-time-clamp.html
- html/MediaController.cpp:
(MediaController::setCurrentTime):
(MediaController::updatePlaybackState):
- html/MediaController.h:
LayoutTests:
Add test for checking currentTime of mediacontroller when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154
Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.
- media/media-controller-time-clamp-expected.txt:
- media/media-controller-time-clamp.html:
- 2:14 AM Changeset in webkit [190935] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190079 - svg/custom/hidpi-masking-clipping.svg fails with accelerated drawing on
https://bugs.webkit.org/show_bug.cgi?id=149413
<rdar://problem/22787058>
Reviewed by Dean Jackson.
No new tests, this is covered by existing tests.
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/RenderSVGResourcePattern.h:
Make pattern images respect the accelerated bit of the parent GraphicsContext.
- 2:03 AM Changeset in webkit [190934] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190054 - [GTK] media controls does not show up when playing video finishes.
https://bugs.webkit.org/show_bug.cgi?id=149112
Reviewed by Philippe Normand.
Source/WebCore:
GTK port does not show controls after playing video. This behavior is different
from what Mac port does. They do show controls when playing video finishes.
At least, we should update the timeline before showing it up not to show incorrect numbers
when reappearing.
Test: media/media-controls-timeline-updates-after-playing.html
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.setPlaying):
(Controller.prototype.showControls):
LayoutTests:
- media/media-controls-timeline-updates-after-playing-expected.txt: Added.
- media/media-controls-timeline-updates-after-playing.html: Added.
- 2:02 AM Changeset in webkit [190933] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190053 - [GTK] timeline is not updated after few seconds when mouse hovers on controls
https://bugs.webkit.org/show_bug.cgi?id=149111
Reviewed by Philippe Normand.
Source/WebCore:
Timeline is not updated if controlsAreHidden is true. The problem here is that
the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
class existences. The panel's visibility are not only controlled by the two classes,
but also by video::-webkit-media-controls-panel:hover. The panel could be visible
by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().
Test: media/media-controls-timeline-updates-when-hovered.html
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreHidden):
LayoutTests:
- media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
- media/media-controls-timeline-updates-when-hovered.html: Added.
- 2:01 AM Changeset in webkit [190932] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Tools
Merge r190046 - [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
https://bugs.webkit.org/show_bug.cgi?id=149252
Reviewed by Darin Adler.
In case of glib tests the test runner notifies about tests
crashing, but for google tests we don't get any feedback, which
means that in case of a test crashing we get a list of PASS
messages and at the summary we are notified that the test suite
has failed, but it's impossible to know which test cases have failed.
- Scripts/run-gtk-tests:
(TestRunner._run_google_test): Add a CRASH message if test
case crashed.
- 1:53 AM Changeset in webkit [190931] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r190013 - Null dereference loading Blink layout test svg/filters/feImage-failed-load-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149316
<rdar://problem/22749532>
Reviewed by Tim Horton.
Source/WebCore:
If an feImage triggered loading a resource, and then was removed from the document,
we'd still try to notify its parent when the resource arrived (or failed).
Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/9cbcfd7866bbaff0c4b3c4c8508b7c97b46d6e6a
Test: svg/filters/feImage-failed-load-crash.html
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::notifyFinished): Add a null check to the parent element
before sending the notification.
LayoutTests:
Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/9cbcfd7866bbaff0c4b3c4c8508b7c97b46d6e6a
- svg/filters/feImage-failed-load-crash-expected.txt: Added.
- svg/filters/feImage-failed-load-crash.html: Added.
- 1:53 AM Changeset in webkit [190930] by
-
- 2 edits in trunk/Source/WebKit2
Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061
Reviewed by Carlos Garcia Campos.
Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):
- 1:52 AM Changeset in webkit [190929] by
-
- 3 edits6 adds in releases/WebKitGTK/webkit-2.10
Merge r190012 - Null dereference loading Blink layout test svg/custom/use-href-attr-removal-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149315
<rdar://problem/22749358>
Reviewed by Tim Horton.
Source/WebCore:
We were not checking if the corresponding element referenced from
the SVG <use> actually existed before trying to set attributes on it.
The original Blink change is a little more detailed:
https://chromium.googlesource.com/chromium/blink/+/e2f1087f32bb088160ab7d59a715a1403ef267c7
However, we've significantly diverged at this point.
Tests: svg/custom/use-href-attr-removal-crash.html
svg/custom/use-href-attr-removal-crash2.svg
svg/custom/use-href-change-local-to-invalid-remote.html
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferSizeAttributesToTargetClone):
LayoutTests:
These tests, copied from Blink, should not crash.
The originals come from:
https://chromium.googlesource.com/chromium/blink/+/e2f1087f32bb088160ab7d59a715a1403ef267c7
- svg/custom/use-href-attr-removal-crash.html: Added.
- svg/custom/use-href-attr-removal-crash-expected.txt: Added.
- svg/custom/use-href-attr-removal-crash2.svg: Added.
- svg/custom/use-href-attr-removal-crash2-expected.txt: Added.
- svg/custom/use-href-change-local-to-invalid-remote.html: Added.
- svg/custom/use-href-change-local-to-invalid-remote-expected.txt: Added.
- 1:49 AM Changeset in webkit [190928] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r190097 - Fix release builds with security assertion after r190007.
- dom/DocumentOrderedMap.cpp:
- dom/DocumentOrderedMap.h:
Oct 12, 2015:
- 11:30 PM Changeset in webkit [190927] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, register symbol structure to fix Debug build
https://bugs.webkit.org/show_bug.cgi?id=149622
Since InferredTypes for String or Symbol claim that they don't have any structure,
registerInferredTypedoes not register the structure for Symbol.
We take the similar way to String to fix this issue; Registering Symbol structure
explicitly in DFGStructureRegisterationPhase. Because,
- InferredType::structure is only allowed for ObjectWithStructure / ObjectWithStructureOrOther. It looks clear to me that only ObjectWithStructure has structure.
- Symbol is similar primitive value to String. So handling its structure in similar way to String is nice.
- dfg/DFGStructureRegistrationPhase.cpp:
(JSC::DFG::StructureRegistrationPhase::run):
- 11:00 PM Changeset in webkit [190926] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, fix debug build warning.
%llu needs 'long long unsigned int'.
Type casting unit64_t to long long unsigned int.
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::notifyConnectionsOfVersionChange):
- 10:13 PM Changeset in webkit [190925] by
-
- 3 edits in trunk/Tools
Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
https://bugs.webkit.org/show_bug.cgi?id=149983
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- 10:08 PM Changeset in webkit [190924] by
-
- 4 edits in trunk/Tools
Fix webkitpy tests after r190922.
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 8:24 PM Changeset in webkit [190923] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Iterator loops over key twice after delete
https://bugs.webkit.org/show_bug.cgi?id=149811
Reviewed by Geoffrey Garen.
When an object is the dictionary mode, JSPropertyNameEnumerator collects property names through generic property name enumeration
getPropertyNames.
The result vector contains indexed property names. But in this case,publicLength()may not be 0.
So without disabling indexed names enumeration phase explicitly, JSPropertyNameEnumerator produces indexed property names twice.
One in indexed name enumeration phase, and another in generic property name enumeration phase.
This patch disables indexed names enumeration by settingindexedLengthto 0 when collecting names through generic property name enumeration.
- runtime/JSPropertyNameEnumerator.h:
(JSC::propertyNameEnumerator):
- tests/stress/property-name-enumerator-should-not-look-into-indexed-values-when-it-is-a-dictionary.js: Added.
(shouldBe):
(col2.of.Reflect.enumerate):
- 7:49 PM Changeset in webkit [190922] by
-
- 4 edits in trunk/Tools
Add a Mac debug EWS queue
https://bugs.webkit.org/show_bug.cgi?id=150069
Reviewed by Geoffrey Garen.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.archive_last_test_results):
(AbstractEarlyWarningSystem.build_style):
(AbstractEarlyWarningSystem.refetch_patch):
(AbstractEarlyWarningSystem.load_ews_classes):
- 7:12 PM Changeset in webkit [190921] by
-
- 3 edits in trunk/PerformanceTests
Add canvas line dash test
https://bugs.webkit.org/show_bug.cgi?id=150078
<rdar://problem/23082347>
Reviewed by Dean Jackson.
- Animometer/runner/resources/tests.js: Add line dash test.
- Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLineDashStage): Create a new stage with a default dash pattern and stroke style.
Maintain a step which will animate the dash.
(CanvasLineDashStage.prototype.animate): Render the line path with the dash. Increment
the dash offset to animate.
(CanvasPathBenchmark.prototype.createStage): Add the test.
- 7:11 PM Changeset in webkit [190920] by
-
- 3 edits in trunk/PerformanceTests
Add canvas line path tests
https://bugs.webkit.org/show_bug.cgi?id=150076
<rdar://problem/23082285>
Reviewed by Dean Jackson.
- Animometer/runner/resources/tests.js: Add new line path tests, with different
line joins.
- Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLinePathStage): The stage is the same as the SimpleCanvasPathStrokeStage
but sets the lineJoin on the context.
(CanvasPathBenchmark.prototype.createStage): Add the tests.
- 7:11 PM Changeset in webkit [190919] by
-
- 2 edits in trunk/PerformanceTests
Add missing paint objects for arc and arcTo fills
https://bugs.webkit.org/show_bug.cgi?id=150075
<rdar://problem/23082233>
Reviewed by Dean Jackson.
- Animometer/tests/simple/resources/simple-canvas-paths.js: Add missing paint objects
for arcTo and arc segment fills.
(CanvasArcToSegmentFill):
(CanvasArcToSegmentFill.prototype.draw):
(CanvasArcSegmentFill):
(CanvasArcSegmentFill.prototype.draw):
- 7:10 PM Changeset in webkit [190918] by
-
- 3 edits in trunk/PerformanceTests
Add canvas line segment tests
https://bugs.webkit.org/show_bug.cgi?id=150073
<rdar://problem/23082138>
Reviewed by Dean Jackson.
- Animometer/runner/resources/tests.js: Add new line segment tests, with different
line caps.
- Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLineSegment): Add new line segment paint object.
(CanvasLineSegmentStage): Create a new stage that sets the lineCap.
- 7:10 PM Changeset in webkit [190917] by
-
- 3 edits in trunk/PerformanceTests
Add canvas path fill tests
https://bugs.webkit.org/show_bug.cgi?id=150071
<rdar://problem/23082001>
Reviewed by Dean Jackson.
- Animometer/runner/resources/tests.js: Add new pathTypes for path fills.
- Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLinePoint): Add basic point for a line, and call lineTo.
(SimpleCanvasPathFillStage): Add a new stage similar to SimpleCanvasPathStrokeStage.
(CanvasPathBenchmark.prototype.createStage): Add the tests.
- 7:09 PM Changeset in webkit [190916] by
-
- 12 edits2 adds in trunk/Source/JavaScriptCore
Introduce Symbol type for property type inference
https://bugs.webkit.org/show_bug.cgi?id=149622
Reviewed by Geoffrey Garen.
This patch introduces Symbol type into property type inference.
One of the use cases of ES6 Symbol is enum value. In this case,
we may hold different symbols as the same property of the same structure.
Current property type inference does not support Symbol type, so in the
above case, the property will be inferred as Top type.
- bytecode/PutByIdFlags.h:
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
- dfg/DFGInferredTypeCheck.cpp:
(JSC::DFG::insertInferredTypeCheck):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::checkInferredType):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::branchIfNotType):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/InferredType.cpp:
(JSC::InferredType::kindForFlags):
(JSC::InferredType::Descriptor::forValue):
(JSC::InferredType::Descriptor::putByIdFlags):
(JSC::InferredType::Descriptor::merge):
(WTF::printInternal):
- runtime/InferredType.h:
- tests/stress/prop-type-symbol-then-object.js: Added.
(foo):
(bar):
(toString):
- tests/stress/prop-type-symbol-then-string.js: Added.
(foo):
(bar):
- 6:54 PM Changeset in webkit [190915] by
-
- 1 edit47 adds in trunk/LayoutTests
[Win] Update anonymous table results for Windows port.
Unreviewed gardening.
- platform/win/css2.1/tables/table-anonymous-objects-015-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-016-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-023-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-024-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-035-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-036-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-037-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-038-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-045-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-046-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-047-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-048-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-049-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-050-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-055-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-056-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-091-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-092-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-099-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-100-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-105-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-106-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-107-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-108-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-109-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-110-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-111-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-112-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-113-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-114-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-115-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-116-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-121-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-122-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-123-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-124-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-139-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-140-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-149-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-150-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-155-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-156-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-159-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-160-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-165-expected.txt: Added.
- platform/win/css2.1/tables/table-anonymous-objects-166-expected.txt: Added.
- 6:39 PM Changeset in webkit [190914] by
-
- 3 edits in trunk/Source/WebCore
Speculative Cairo build fixes after r190910.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::drawPattern):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
- 6:18 PM Changeset in webkit [190913] by
-
- 4 edits in trunk/PerformanceTests
Add canvas path tests
https://bugs.webkit.org/show_bug.cgi?id=150067
rdar://problem/23081463
Reviewed by Dean Jackson.
- Animometer/runner/resources/tests.js: Add a quadratic and bezier path test.
- Animometer/tests/simple/resources/simple-canvas.js:
(SimpleCanvasStage.prototype.tune): This kind of test joins all of the segments
into one long path, and tries to render that one path. Random points make it
difficult to tell what is going on, so add a parameter to the constructor to
confine the area where the random coordinates can land. The more complicated the
case is, the larger an area the path will cover. Add an artificial minimum so
that the first 200 points aren't confined to a space that is too small.
- Animometer/tests/simple/resources/simple-canvas-paths.js:
(SimpleCanvasPathStrokeStage): Add a new kind of stage that inherits from
SimpleCanvasStage. Each time the frame animates a random line width and stroke
color are chosen. The path setup is done outside of each paint object.
(CanvasQuadraticPoint): This point just calls quadraticCurveTo.
(CanvasPathBenchmark.prototype.createStage): Add the tests.
- 6:11 PM Changeset in webkit [190912] by
-
- 3 edits5 adds in trunk/PerformanceTests
Add basic canvas tests
https://bugs.webkit.org/show_bug.cgi?id=150066
rdar://problem/23081143
Reviewed by Dean Jackson.
This adds a new test suite that will cover all of the path-based canvas calls.
The patch will be divided up to cover tests with similar techniques.
The simplest version uses a SimpleCanvasStage.
- Animometer/runner/resources/tests.js: Add tests for quadratic, bezier, arcTo,
arc, and rect segments. Also include arcTo, arc, and rect fills.
- Animometer/tests/resources/stage.js:
(Stage.prototype.randomBool): Added for counterclockwise property for arc segments.
(Stage.prototype.randomInt): Fix how values are rounded, used by randomBool. It should
round instead of flooring everything.
- Animometer/tests/simple/resources/simple-canvas.js: Added. Defines common classes
used by all simple canvas tests. The page reads best bottom to top.
(SimpleCanvasStage): Basic stage. Pass a canvasObject which will be used to create new
objects as needed in tune().
(SimpleCanvasStage.prototype.tune): Modeled on other tests. Adds and removed objects
as specified by the provided |count|.
(SimpleCanvasStage.prototype.animate): Iterate over all the objects and ask them to draw.
There is no "animating" of the objects; they will just paint statically on the canvas.
(SimpleCanvasAnimator): Basic animator clears the canvas prior to painting.
(SimpleCanvasBenchmark): Hard-code the feedback loop parameters instead of including
them in the query parameters to the test URLs.
(SimpleCanvasBenchmark.prototype.createAnimator):
- Animometer/tests/simple/simple-canvas-paths.html: Added.
- Animometer/tests/simple/resources/simple-canvas-paths.js: Added. There is no "animating"
of these objects--they just paint statically on the canvas.
(CanvasQuadraticSegment): Paint a quadratic segment stroke.
(CanvasBezierSegment): Paint a bezier segment stroke.
(CanvasArcToSegment): Paint an arcTo stroke.
(CanvasArcSegment): Paint an arc stroke.
(CanvasRect): Paint a rect.
(CanvasRectFill): Paint a filled rect.
(CanvasPathBenchmark):
(CanvasPathBenchmark.prototype.createStage): Look for the pathType and create the
stage using the right paint object.
(window.benchmarkClient.create):
- 6:04 PM WebKitGTK/2.10.x edited by
- More proposed changes for 2.10.1 (diff)
- 5:55 PM Changeset in webkit [190911] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS and Efl builds.
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):
- 5:52 PM Changeset in webkit [190910] by
-
- 22 edits in trunk/Source/WebCore
Remove Image::spaceSize() and ImageBuffer::spaceSize()
https://bugs.webkit.org/show_bug.cgi?id=150064
Reviewed by Tim Horton.
Image spacing when tiled should not be a property of the image; but a description
of how it's drawn, like tile size. So remove spacing from Image and ImageBuffer,
and pass it in as an argument.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
- platform/graphics/BitmapImage.h:
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
- platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern):
- platform/graphics/GradientImage.h:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(WebCore::Image::spaceSize): Deleted.
(WebCore::Image::setSpaceSize): Deleted.
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::spaceSize): Deleted.
(WebCore::ImageBuffer::setSpaceSize): Deleted.
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):
- platform/graphics/NamedImageGeneratedImage.h:
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::drawPattern):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h:
- 5:37 PM Changeset in webkit [190909] by
-
- 4 edits in trunk
[GTK] OSX linker doesn't understand --whole-archive
https://bugs.webkit.org/show_bug.cgi?id=144557
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Martin Robinson.
.:
- Source/cmake/OptionsGTK.cmake: Turn the macro
ADD_WHOLE_ARCHIVE_TO_LIBRARIES into a no-op on Darwin systems,
because XCode's linker doesn't have the --whole-archive option.
Source/WebKit2:
- PlatformGTK.cmake: Link with extra libraries on Darwin, since
we don't have the --whole-archive linker option.
- 5:11 PM Changeset in webkit [190908] by
-
- 6 edits in trunk/PerformanceTests
Refactor tune() to pass in an integer-based count
https://bugs.webkit.org/show_bug.cgi?id=150060
<rdar://problem/23079425>
Reviewed by Dean Jackson.
All of the tune functions do an initial step of flooring the
# of painting objects to add or remove. Factor that out since
the complexity of all of these tests is always expressed in terms
of countable items.
- Animometer/tests/resources/main.js:
(Benchmark.prototype.update): Update the tuneValue.
- Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(BouncingParticlesStage.prototype.tune): Remove the count adjustment.
- Animometer/tests/examples/resources/canvas-electrons.js:
(CanvasElectronsStage.prototype.tune): Ditto.
- Animometer/tests/examples/resources/canvas-stars.js:
(CanvasStarsStage.prototype.tune): Ditto.
- Animometer/tests/text/resources/layering-text.js:
(LayeringTextStage.prototype.tune): Ditto.
- 5:03 PM Changeset in webkit [190907] by
-
- 2 edits in trunk/PerformanceTests
Store test-interval in localStorage
https://bugs.webkit.org/show_bug.cgi?id=150055
<rdar://problem/23078879>
Reviewed by Dean Jackson.
- Animometer/runner/resources/animometer.js:
(populateSettings): Keep track of the specified test interval in localStorage
to make it easy to repeat a test suite.
- 4:39 PM Changeset in webkit [190906] by
-
- 4 edits in trunk/Source/WebCore
Have TransformState::mappedSecondaryQuad() return an Optional<FloatQuad>.
<https://webkit.org/b/150057>
Reviewed by Simon Fraser.
Using Optional instead of std::unique_ptr allows us to signal the absence of a
secondary quad without incurring a heap allocation in cases where one is present.
This dodges ~132000 malloc/free pairs on loading thelocal.se
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleAndCoverageRect):
- platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::mappedSecondaryQuad):
- platform/graphics/transforms/TransformState.h:
- 4:37 PM Changeset in webkit [190905] by
-
- 18 edits in trunk/Source/JavaScriptCore
Web Inspector: Rebaseline Inspector generator tests and make better use of RWIProtocol constant
https://bugs.webkit.org/show_bug.cgi?id=150044
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-12
Reviewed by Brian Burg.
- inspector/scripts/codegen/generate_objc_configuration_header.py:
(ObjCConfigurationHeaderGenerator.generate_output):
(ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains):
- inspector/scripts/codegen/generate_objc_configuration_implementation.py:
(ObjCBackendDispatcherImplementationGenerator._generate_configuration_implementation_for_domains):
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator.generate_output):
- inspector/scripts/codegen/generate_objc_internal_header.py:
(ObjCInternalHeaderGenerator.generate_output):
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- 4:26 PM Changeset in webkit [190904] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix
- runtime/JSObject.cpp:
(JSC::JSObject::reallocateAndShrinkButterfly):
- 4:25 PM Changeset in webkit [190903] by
-
- 3 edits in trunk/PerformanceTests
Remove "../tests/" from the URLs of all tests
https://bugs.webkit.org/show_bug.cgi?id=150054
<rdar://problem/23078784>
Reviewed by Dean Jackson.
Presumably all tests will be running from the tests/ directory,
so we don't have to specify it in all of the test URLs.
- Animometer/runner/resources/benchmark-runner.js:
(BenchmarkRunnerState.prototype.prepareCurrentTest): Prepend
"../tests/" to all tests.
- Animometer/runner/resources/tests.js: Remove "../tests/" from
all URLs.
- 4:22 PM Changeset in webkit [190902] by
-
- 4 edits in trunk/PerformanceTests
Refactor test suites to a separate class.
https://bugs.webkit.org/show_bug.cgi?id=150053
<rdar://problem/23078645>
Reviewed by Dean Jackson.
Create a Suite class to refactor out prepare() and run().
Generate the checkboxes representing the suites using Suites
instead of maintaining a separate list. Also, save the
selections out to localStorage.
- Animometer/runner/animometer.html: Remove the explicitly listed
suites. These will be generated from Suites instead.
- Animometer/runner/resources/animometer.js:
(populateSettings): Iterate through Suites, and create the
label and checkbox. Attach the Suite object to the checkbox so
when the benchmark is started, we get direct access. Initialize
the checkmark based on its value in localStorage. Set this to
run when DOMContentLoaded is dispatched.
(startBenchmark): Grab all of the checkboxes, inspect their
values, add it to enabledSuites if selected. Remember whether
the suite was enabled in localStorage, so that it's easy to do
repeated runs.
- Animometer/runner/resources/tests.js:
(Suite): Create a new Suite class. Refactor out prepare() and
run(), since all of them have the same implementation. Populate
Suites with Suite instances instead of generic objects.
- 4:20 PM Changeset in webkit [190901] by
-
- 3 edits in trunk/PerformanceTests
Update graph styles for legibility.
https://bugs.webkit.org/show_bug.cgi?id=150052
<rdar://problem/23078503>
Reviewed by Dean Jackson.
- Animometer/runner/resources/animometer.css: Update colors and
stroke thicknesses to make the graphs easier to read.
(.smaple-time): Correct to .sample-time
- Animometer/runner/resources/graph.js:
(graph): Ditto.
- 4:05 PM Changeset in webkit [190900] by
-
- 6 edits in trunk/Websites/perf.webkit.org
Perf dashboard tools shouldn't require server credentials in multiple configuration files
https://bugs.webkit.org/show_bug.cgi?id=149994
Reviewed by Chris Dumez.
Made detect-changes.js and pull-svn.py pull username and passwords from the server config JSON to reduce
the number of JSON files that need to include credentials.
Also made each script reload the server config after sleep to allow dynamic credential updates.
In addition, change the server config JSON's format to include scheme, host, and port numbers separately
instead of a url since detect-changes.js needs each value separately.
This reduces the number of JSONs with credentials to two for our internal dashboard.
- tools/detect-changes.js:
(main): Added a property argument parsing. Now takes --server-config-json, --change-detection-config-json,
and --seconds-to-sleep like other scripts.
(parseArgument): Added.
(fetchManifestAndAnalyzeData): Reload the server config JSON.
(loadServerConfig): Added. Set settings.perfserver and settings.slave from the server config JSON. Also
add settings.perfserver.host to match the old format.
(configurationsForTesting): Fixed a bug that we throw an exception when a dashboard contains an empty cell.
- tools/pull-os-versions.py:
(main): Use load_server_config after each sleep.
- tools/pull-svn.py:
(main): Use load_server_config after each sleep.
(fetch_commits_and_submit): Use the perf dashboard's auth as subversion credential when useServerAuth is set.
- tools/sync-with-buildbot.py:
(main): Use load_server_config after each sleep.
- tools/util.py:
(load_server_config): Extracted from python scripts. Computes server's url from scheme, host, and port number
to match the old format python scripts except.
- 3:51 PM Changeset in webkit [190899] by
-
- 2 edits in trunk/Source/WebCore
Followup to:
Modern IDB: Start version change transaction for connections to new database.
https://bugs.webkit.org/show_bug.cgi?id=150033
Reviewed by NOBODY (Fixing existing test flakiness)
No new tests (Covered by existing tests)
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations): Early return if a version change transaction
is already in progress.
- 3:43 PM Changeset in webkit [190898] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix after r190817. Now that pull-os-versions store fake timestamps, we need to bypass timestamp
checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
with a MismatchingCommitTime error.
- public/include/report-processor.php:
(ReportProcessor::resolve_build_id):
- 3:42 PM Changeset in webkit [190897] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed, revert an unintended commit.
- JetStream/Octane2/crypto.js:
(montRevert):
(montReduce):
- 3:41 PM Changeset in webkit [190896] by
-
- 55 edits1 move2 adds in trunk
GC should have a Baker barrier for concurrent copying
https://bugs.webkit.org/show_bug.cgi?id=149852
Reviewed by Geoffrey Garen.
This adds a Baker-style read barrier [1] to copied space accesses. This barrier incurs some
overhead (0%-2% depending on benchmark suite), but what it buys is the ability to make the GC copy
phase concurrent.
The barrier relies on copied space pointers having two "space bits" in the low pointer bits. The
space bits indicate whether the backing store is being copied right now or not, and if it is being
copied, what stage of copying it's in. Two barrier variants are supported:
Read only barrier: if you load a backing store and immediately load from it without doing anything
else, you can just mask off the bits. In the worst case, you'll get the old backing store while
some copying thread is already allocating and populating the new version of the backing store. But
in that case, forwarding to the new backing store will not enable you to load a more up-to-date
value from the backing store. So, just masking the bits is enough. The read-only barrier is only
used in ICs where we know that we are only reading, and opportunistically within the DFG and FTL
thanks to the CopyBarrierOptimizationPhase. We never explicitly emit a read-only barrier in those
compilers; instead the phase will turn a GetButterfly into GetButterflyReadOnly if it proves that a
bunch of requirements are met.
Normal barrier: if the space bits are non-zero, call a slow path. The slow path will either do
nothing (if the copy phase hasn't started yet), or it will copy the backing store and update the
pointer (if the copy phase hasn't gotten around to copying this particular backing store), or it
will wait for the copying thread to finish (if some thread is copying this backing store right
now), or it will do nothing (if by the time we called into the slow path the backing store was
already copied). This is just like Baker's CAR/CDR barrier, but with a lock thrown in to handle
concurrent execution.
This is a 1% slow-down on SunSpider, a 1.5% slow-down on Octane, a 1.5% slow-down on Kraken, and a
0% slow-down on AsmBench. Note that the Octane slow-down is excluding the SplayLatency benchmark.
That benchmark will eventually speed up a lot once we finish doing all of this stuff. Probably, the
JetStream splay-latency will see an even larger speed-up, since our version of the latency tests do
a better job of punishing bad worst-case behavior.
[1] http://dspace.mit.edu/bitstream/handle/1721.1/41976/AI_WP_139.pdf, look for the CAR and CDR
procedures on page 9.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGArgumentsEliminationPhase.cpp:
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCopyBarrierOptimizationPhase.cpp: Added.
(JSC::DFG::performCopyBarrierOptimization):
- dfg/DFGCopyBarrierOptimizationPhase.h: Added.
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
- dfg/DFGHeapLocation.h:
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetButterflyReadOnly):
(JSC::FTL::DFG::LowerDFGToLLVM::compileConstantStoragePointer):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckArray):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToLLVM::storageForTransition):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::loadButterflyWithBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::loadVectorWithBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::copyBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::loadButterflyReadOnly):
(JSC::FTL::DFG::LowerDFGToLLVM::loadVectorReadOnly):
(JSC::FTL::DFG::LowerDFGToLLVM::removeSpaceBits):
(JSC::FTL::DFG::LowerDFGToLLVM::baseIndex):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationNewObjectWithButterfly):
(JSC::FTL::operationPopulateObjectInOSR):
- ftl/FTLOutput.h:
(JSC::FTL::Output::testNonZero32):
(JSC::FTL::Output::testIsZero64):
(JSC::FTL::Output::testNonZero64):
(JSC::FTL::Output::testIsZeroPtr):
(JSC::FTL::Output::testNonZeroPtr):
(JSC::FTL::Output::select):
(JSC::FTL::Output::extractValue):
- heap/CopyBarrier.h: Copied from Source/JavaScriptCore/heap/CopyWriteBarrier.h.
(JSC::CopyBarrierBase::CopyBarrierBase):
(JSC::CopyBarrierBase::operator!):
(JSC::CopyBarrierBase::operator bool):
(JSC::CopyBarrierBase::getWithoutBarrier):
(JSC::CopyBarrierBase::get):
(JSC::CopyBarrierBase::copyState):
(JSC::CopyBarrierBase::setCopyState):
(JSC::CopyBarrierBase::clear):
(JSC::CopyBarrierBase::set):
(JSC::CopyBarrierBase::setWithoutBarrier):
(JSC::CopyBarrierBase::weakCASWithoutBarrier):
(JSC::CopyBarrier::CopyBarrier):
(JSC::CopyBarrier::getWithoutBarrier):
(JSC::CopyBarrier::get):
(JSC::CopyBarrier::set):
(JSC::CopyBarrier::setWithoutBarrier):
(JSC::CopyBarrier::weakCASWithoutBarrier):
(JSC::CopyWriteBarrier::CopyWriteBarrier): Deleted.
(JSC::CopyWriteBarrier::operator!): Deleted.
(JSC::CopyWriteBarrier::operator bool): Deleted.
(JSC::CopyWriteBarrier::get): Deleted.
(JSC::CopyWriteBarrier::operator*): Deleted.
(JSC::CopyWriteBarrier::operator->): Deleted.
(JSC::CopyWriteBarrier::set): Deleted.
(JSC::CopyWriteBarrier::setWithoutWriteBarrier): Deleted.
(JSC::CopyWriteBarrier::clear): Deleted.
- heap/CopyVisitorInlines.h:
(JSC::CopyVisitor::checkIfShouldCopy):
- heap/CopyWriteBarrier.h: Removed.
- heap/Heap.cpp:
(JSC::Heap::addToRememberedSet):
(JSC::Heap::copyBarrier):
(JSC::Heap::collectAndSweep):
- heap/Heap.h:
(JSC::Heap::writeBarrierBuffer):
- heap/HeapInlines.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::branchStructure):
(JSC::AssemblyHelpers::branchIfNotToSpace):
(JSC::AssemblyHelpers::removeSpaceBits):
(JSC::AssemblyHelpers::addressForByteOffset):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emit_op_get_direct_pname):
(JSC::JIT::emitSlow_op_get_direct_pname):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_direct_pname):
(JSC::JIT::emitSlow_op_get_direct_pname):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/DirectArguments.cpp:
(JSC::DirectArguments::visitChildren):
(JSC::DirectArguments::copyBackingStore):
(JSC::DirectArguments::overrideThings):
(JSC::DirectArguments::overrideThingsIfNecessary):
(JSC::DirectArguments::overrideArgument):
(JSC::DirectArguments::copyToArguments):
- runtime/DirectArguments.h:
(JSC::DirectArguments::canAccessIndexQuickly):
(JSC::DirectArguments::canAccessArgumentIndexQuicklyInDFG):
- runtime/JSArray.cpp:
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::fastSlice):
(JSC::JSArray::fastConcatWith):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
- runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
(JSC::JSArrayBufferView::JSArrayBufferView):
(JSC::JSArrayBufferView::finishCreation):
(JSC::JSArrayBufferView::finalize):
- runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::vector):
(JSC::JSArrayBufferView::length):
- runtime/JSArrayBufferViewInlines.h:
(JSC::JSArrayBufferView::neuter):
(JSC::JSArrayBufferView::byteOffset):
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::typedVector):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
(JSC::JSGenericTypedArrayView<Adaptor>::copyBackingStore):
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):
- runtime/JSMap.h:
(JSC::JSMap::JSMap):
- runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::visitChildren):
(JSC::JSObject::copyBackingStore):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::setIndexQuicklyToUndecided):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::reallocateAndShrinkButterfly):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getEnumerableLength):
- runtime/JSObject.h:
(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::canSetIndexQuicklyForPutDirect):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::inlineStorage):
(JSC::JSObject::butterfly):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::locationForOffset):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::arrayStorage):
(JSC::JSObject::arrayStorageOrNull):
(JSC::JSObject::ensureLength):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/JSSet.h:
(JSC::JSSet::JSSet):
- runtime/MapData.h:
(JSC::JSIterator>::MapDataImpl):
(JSC::JSIterator>::IteratorData::next):
(JSC::JSIterator>::IteratorData::refreshCursor):
- runtime/MapDataInlines.h:
(JSC::JSIterator>::clear):
(JSC::JSIterator>::find):
(JSC::JSIterator>::add):
(JSC::JSIterator>::remove):
(JSC::JSIterator>::replaceAndPackBackingStore):
(JSC::JSIterator>::replaceBackingStore):
(JSC::JSIterator>::ensureSpaceForAppend):
(JSC::JSIterator>::visitChildren):
(JSC::JSIterator>::copyBackingStore):
- runtime/Options.h:
- 3:40 PM Changeset in webkit [190895] by
-
- 3 edits in trunk/Source/WebCore
[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
https://bugs.webkit.org/show_bug.cgi?id=150051
Reviewed by Simon Fraser.
There are no typesetting features which aren't kerning nor ligatures.
No new tests because there is no behavior difference.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::codePath):
- platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::supportsTypesettingFeatures): Deleted.
- 3:36 PM Changeset in webkit [190894] by
-
- 3 edits in trunk/Source/WebCore
Add a CGContextStateSaver and use it
https://bugs.webkit.org/show_bug.cgi?id=150049
Reviewed by Tim Horton.
Add a stack-based graphics state save/restore class for CGContext,
like the one we have for GraphicsContext, and use it in GraphicsContextCG.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawJoinedLines):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::strokeRect):
- platform/graphics/cg/GraphicsContextCG.h:
(WebCore::CGContextStateSaver::CGContextStateSaver):
(WebCore::CGContextStateSaver::~CGContextStateSaver):
(WebCore::CGContextStateSaver::save):
(WebCore::CGContextStateSaver::restore):
- 3:33 PM Changeset in webkit [190893] by
-
- 3 edits94 adds in trunk
display: table-cell; bug when resizing window
https://bugs.webkit.org/show_bug.cgi?id=138167
Reviewed by David Hyatt.
Clean up anonymous table wrappers all the way up to RenderTable.
This patch ensures that we don't keep the generated RenderTable/RenderSection/RenderCaption/RenderRow
objects around in the tree anymore when the last child is destroyed.
Import W3C CSS2.1 anonymous table tests.
Source/WebCore:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
LayoutTests:
- css2.1/tables/table-anonymous-objects-015.xht: Added.
- css2.1/tables/table-anonymous-objects-016.xht: Added.
- css2.1/tables/table-anonymous-objects-023.xht: Added.
- css2.1/tables/table-anonymous-objects-024.xht: Added.
- css2.1/tables/table-anonymous-objects-035.xht: Added.
- css2.1/tables/table-anonymous-objects-036.xht: Added.
- css2.1/tables/table-anonymous-objects-037.xht: Added.
- css2.1/tables/table-anonymous-objects-038.xht: Added.
- css2.1/tables/table-anonymous-objects-045.xht: Added.
- css2.1/tables/table-anonymous-objects-046.xht: Added.
- css2.1/tables/table-anonymous-objects-047.xht: Added.
- css2.1/tables/table-anonymous-objects-048.xht: Added.
- css2.1/tables/table-anonymous-objects-049.xht: Added.
- css2.1/tables/table-anonymous-objects-050.xht: Added.
- css2.1/tables/table-anonymous-objects-055.xht: Added.
- css2.1/tables/table-anonymous-objects-056.xht: Added.
- css2.1/tables/table-anonymous-objects-091.xht: Added.
- css2.1/tables/table-anonymous-objects-092.xht: Added.
- css2.1/tables/table-anonymous-objects-099.xht: Added.
- css2.1/tables/table-anonymous-objects-100.xht: Added.
- css2.1/tables/table-anonymous-objects-105.xht: Added.
- css2.1/tables/table-anonymous-objects-106.xht: Added.
- css2.1/tables/table-anonymous-objects-107.xht: Added.
- css2.1/tables/table-anonymous-objects-108.xht: Added.
- css2.1/tables/table-anonymous-objects-109.xht: Added.
- css2.1/tables/table-anonymous-objects-110.xht: Added.
- css2.1/tables/table-anonymous-objects-111.xht: Added.
- css2.1/tables/table-anonymous-objects-112.xht: Added.
- css2.1/tables/table-anonymous-objects-113.xht: Added.
- css2.1/tables/table-anonymous-objects-114.xht: Added.
- css2.1/tables/table-anonymous-objects-115.xht: Added.
- css2.1/tables/table-anonymous-objects-116.xht: Added.
- css2.1/tables/table-anonymous-objects-121.xht: Added.
- css2.1/tables/table-anonymous-objects-122.xht: Added.
- css2.1/tables/table-anonymous-objects-123.xht: Added.
- css2.1/tables/table-anonymous-objects-124.xht: Added.
- css2.1/tables/table-anonymous-objects-139.xht: Added.
- css2.1/tables/table-anonymous-objects-140.xht: Added.
- css2.1/tables/table-anonymous-objects-149.xht: Added.
- css2.1/tables/table-anonymous-objects-150.xht: Added.
- css2.1/tables/table-anonymous-objects-155.xht: Added.
- css2.1/tables/table-anonymous-objects-156.xht: Added.
- css2.1/tables/table-anonymous-objects-159.xht: Added.
- css2.1/tables/table-anonymous-objects-160.xht: Added.
- css2.1/tables/table-anonymous-objects-165.xht: Added.
- css2.1/tables/table-anonymous-objects-166.xht: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-015-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-016-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-023-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-024-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-035-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-036-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-037-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-038-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-045-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-046-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-047-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-048-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-049-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-050-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-055-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-056-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-091-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-092-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-099-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-100-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-105-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-106-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-107-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-108-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-109-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-110-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-111-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-112-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-113-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-114-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-115-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-116-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-121-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-122-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-123-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-124-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-139-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-140-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-149-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-150-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-155-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-156-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-159-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-160-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-165-expected.txt: Added.
- platform/mac/css2.1/tables/table-anonymous-objects-166-expected.txt: Added.
- 3:15 PM Changeset in webkit [190892] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, more Mac test gardening after r190629.
- platform/mac-wk1/TestExpectations:
Add a new expected time out. Group expected time outs for imported
Blink tests using requestAnimationFrame.
- 3:08 PM Changeset in webkit [190891] by
-
- 3 edits3 adds in trunk
REGRESSION(r182192): Ligatures do not interact correctly with SHY in some fonts
https://bugs.webkit.org/show_bug.cgi?id=150006
Reviewed by Simon Fraser.
Source/WebCore:
When performing font transforms and we encounter kCGFontIndexInvalid, we filter it out of the
GlyphBuffer. However, this filter was only interacting with part of the GlyphBuffer instead
of the whole thing. This causes glyph IDs from one font to be rendered with other fonts,
thereby showing garbage glyphs.
However, now that <rdar://problem/20230073> is fixed, we don't need to perform this filter in
the first place.
Test: fast/text/undefined-glyph-with-ligature.html
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::copyItem):
(WebCore::GlyphBuffer::swap):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):
LayoutTests:
- fast/text/resources/tiny-ligature-font.svg: Added.
- fast/text/undefined-glyph-with-ligature-expected.html: Added.
- fast/text/undefined-glyph-with-ligature.html: Added.
- 2:48 PM Changeset in webkit [190890] by
-
- 5 edits4 adds in trunk
[SVG] Handle endEvent for svg animations
https://bugs.webkit.org/show_bug.cgi?id=121587
Patch by Antoine Quint <Antoine Quint> on 2015-10-12
Reviewed by Dean Jackson.
Source/WebCore:
Add support for the "endEvent" SVG event triggered when an animation completes, as
specified in http://www.w3.org/TR/SMIL3/smil-timing.html#q135. This event doesn't
bubble and can't be canceled. Added test coverage for the event through the DOM
Events API as well as the declarative SMIL Animation syntax.
Adapted from a Chromium patch by pavan.e@samsung.com
https://chromium.googlesource.com/chromium/blink/+/4d415ca0268231aa80e3552fe21bf3480a6978f8
Tests: svg/animations/end-event-declarative-expected.svg
svg/animations/end-event-declarative.svg
svg/animations/end-event-script-expected.svg
svg/animations/end-event-script.svg
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::smilEndEventSender):
(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore::SVGSMILElement::progress):
(WebCore::SVGSMILElement::dispatchPendingEvent):
- svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::hasConditionsConnected):
LayoutTests:
Tests for the "endEvent" event for SVG animations.
- svg/animations/end-event-declarative-expected.svg: Added.
- svg/animations/end-event-declarative.svg: Added.
- svg/animations/end-event-script-expected.svg: Added.
- svg/animations/end-event-script.svg: Added.
- 2:31 PM Changeset in webkit [190889] by
-
- 2 edits in trunk/Source/JavaScriptCore
Update JSC features.json
https://bugs.webkit.org/show_bug.cgi?id=150043
Reviewed by Mark Lam.
There were a lot of things implemented that weren't in
the list. We should be better about updating the list
as we land patches for new ES6 features.
- features.json:
- 2:29 PM Changeset in webkit [190888] by
-
- 10 edits in trunk/Source/JavaScriptCore
Cleanup Heap.h and some related headers
https://bugs.webkit.org/show_bug.cgi?id=149981
Reviewed by Geoffrey Garen.
- heap/Heap.h:
- Some functions did not need export.
- threadDupStrings never had an implementation.
- heap/ConservativeRoots.cpp:
- heap/ConservativeRoots.h:
- heap/Heap.cpp:
- heap/ListableHandler.h:
- heap/WeakReferenceHarvester.h:
- jit/Repatch.cpp:
- runtime/JSONObject.h:
- runtime/VM.h:
- Stale forward declarations / includes.
- 2:22 PM Changeset in webkit [190887] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Increase limit of parallel network requests.
https://bugs.webkit.org/show_bug.cgi?id=150035
Reviewed by Alex Christensen.
If the limit is too low, other network requests will often be blocked until
active requests finishes. This can affect performance in a negative way.
- platform/network/curl/ResourceHandleManager.cpp:
- 2:04 PM Changeset in webkit [190886] by
-
- 2 edits in trunk/Source/bmalloc
bmalloc: Don't ASSERT that all syscalls succeed
https://bugs.webkit.org/show_bug.cgi?id=150047
<rdar://problem/22649531>
Reviewed by Mark Lam.
madvise can fail due to VM behaviors outside of our control:
copy-on-write, fork, mprotect, and other stuff.
Older darwin kernels sometimes return this error value, and new kernels
might again in future.
We haven't gained much from this ASSERT so far, so let's remove it.
Perhaps in future we can come up with a scheme that makes madvise
never fail, or that responds to failure.
- bmalloc/Syscall.h:
- 1:37 PM Changeset in webkit [190885] by
-
- 7 edits in trunk/Source/JavaScriptCore
Each *ById inline cache in the FTL must have its own CallSiteIndex
https://bugs.webkit.org/show_bug.cgi?id=150039
Reviewed by Geoffrey Garen and Filip Pizlo.
When lowering to LLVM, we create a patchpoint intrinsic for each
*ById in DFG IR. LLVM may choose to duplicate these patchpoints.
Therefore, we want each resulting inline cache to have a unique
CallSiteIndex because each inline cache will have its own set of
used registers. This change is necessary when we implement try/catch
in the FTL because an inline cache will ask for the set of used
registers it will need to restore in the event of an exception
being thrown. It asks for this set of registers by giving JITCode
a CallSiteIndex. Because each corresponding inline cache that results
from a duplicated patchpoint may all ask this for this set of registers,
we must assign each inline cache a unique CallSiteIndex.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addUniqueCallSiteIndex):
(JSC::DFG::CommonData::addCodeOriginUnconditionally): Deleted.
- dfg/DFGCommonData.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLInlineCacheDescriptor.h:
(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::InlineCacheDescriptor::stackmapID):
(JSC::FTL::InlineCacheDescriptor::codeOrigin):
(JSC::FTL::InlineCacheDescriptor::uid):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::CheckInDescriptor::CheckInDescriptor):
(JSC::FTL::LazySlowPathDescriptor::LazySlowPathDescriptor):
(JSC::FTL::InlineCacheDescriptor::callSiteIndex): Deleted.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
- 1:26 PM WebKitGTK/2.10.x edited by
- Propose some merges for 2.10.1 (diff)
- 1:24 PM Changeset in webkit [190884] by
-
- 34 edits12 copies2 adds in trunk
Modern IDB: Start version change transaction for connections to new database.
https://bugs.webkit.org/show_bug.cgi?id=150033
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Covered by changes to existing tests).
- CMakeLists.txt:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/client/IDBAnyImpl.cpp:
(WebCore::IDBClient::IDBAny::IDBAny):
(WebCore::IDBClient::IDBAny::~IDBAny):
(WebCore::IDBClient::IDBAny::idbDatabase):
(WebCore::IDBClient::IDBAny::domStringList):
(WebCore::IDBClient::IDBAny::idbCursor):
(WebCore::IDBClient::IDBAny::idbCursorWithValue):
(WebCore::IDBClient::IDBAny::idbFactory):
(WebCore::IDBClient::IDBAny::idbIndex):
(WebCore::IDBClient::IDBAny::idbObjectStore):
(WebCore::IDBClient::IDBAny::idbTransaction):
(WebCore::IDBClient::IDBAny::scriptValue):
(WebCore::IDBClient::IDBAny::integer):
(WebCore::IDBClient::IDBAny::string):
(WebCore::IDBClient::IDBAny::keyPath):
- Modules/indexeddb/client/IDBAnyImpl.h:
(WebCore::IDBClient::IDBAny::create):
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::fireVersionChangeEvent):
(WebCore::IDBClient::IDBConnectionToServer::registerDatabaseConnection):
(WebCore::IDBClient::IDBConnectionToServer::unregisterDatabaseConnection):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp: Added.
(WebCore::IDBClient::IDBDatabase::create):
(WebCore::IDBClient::IDBDatabase::IDBDatabase):
(WebCore::IDBClient::IDBDatabase::~IDBDatabase):
(WebCore::IDBClient::IDBDatabase::name):
(WebCore::IDBClient::IDBDatabase::version):
(WebCore::IDBClient::IDBDatabase::objectStoreNames):
(WebCore::IDBClient::IDBDatabase::createObjectStore):
(WebCore::IDBClient::IDBDatabase::transaction):
(WebCore::IDBClient::IDBDatabase::deleteObjectStore):
(WebCore::IDBClient::IDBDatabase::close):
(WebCore::IDBClient::IDBDatabase::activeDOMObjectName):
(WebCore::IDBClient::IDBDatabase::canSuspendForPageCache):
(WebCore::IDBClient::IDBDatabase::startVersionChangeTransaction):
- Modules/indexeddb/client/IDBDatabaseImpl.h: Added.
(WebCore::IDBClient::IDBDatabase::info):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onError):
(WebCore::IDBClient::IDBOpenDBRequest::onSuccess):
(WebCore::IDBClient::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBClient::IDBOpenDBRequest::requestCompleted):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.h:
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::IDBRequest):
(WebCore::IDBClient::IDBRequest::result):
(WebCore::IDBClient::IDBRequest::source):
(WebCore::IDBClient::IDBRequest::transaction):
- Modules/indexeddb/client/IDBRequestImpl.h:
(WebCore::IDBClient::IDBRequest::connection):
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::create):
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::~IDBTransaction):
(WebCore::IDBClient::IDBTransaction::mode):
(WebCore::IDBClient::IDBTransaction::db):
(WebCore::IDBClient::IDBTransaction::error):
(WebCore::IDBClient::IDBTransaction::objectStore):
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::activeDOMObjectName):
(WebCore::IDBClient::IDBTransaction::canSuspendForPageCache):
- Modules/indexeddb/client/IDBTransactionImpl.h:
(WebCore::IDBClient::IDBTransaction::info):
- Modules/indexeddb/client/IDBVersionChangeEventImpl.cpp:
(WebCore::IDBClient::IDBVersionChangeEvent::IDBVersionChangeEvent):
(WebCore::IDBClient::IDBVersionChangeEvent::eventInterface):
- Modules/indexeddb/client/IDBVersionChangeEventImpl.h:
(WebCore::IDBClient::IDBVersionChangeEvent::create):
- Modules/indexeddb/legacy/LegacyDatabase.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::fireVersionChangeEvent):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::registerDatabaseConnection):
(WebCore::IDBServer::IDBServer::unregisterDatabaseConnection):
(WebCore::IDBServer::IDBServer::deleteDatabase):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::info):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::hasAnyOpenConnections):
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::notifyConnectionsOfVersionChange):
(WebCore::IDBServer::UniqueIDBDatabase::addOpenDatabaseConnection):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::nextDatabaseConnectionIdentifier):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::create):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::fireVersionChangeEvent):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::identifier):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::database):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionToClient):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::closePending):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::create):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::databaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::info):
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
(WebCore::IDBDatabaseInfo::name):
(WebCore::IDBDatabaseInfo::version):
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo): Deleted.
- Modules/indexeddb/shared/IDBError.h:
- Modules/indexeddb/shared/IDBRequestData.cpp:
(WebCore::IDBRequestData::IDBRequestData):
(WebCore::IDBRequestData::requestedVersion):
- Modules/indexeddb/shared/IDBRequestData.h:
- Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::nextClientResourceNumber):
(WebCore::nextServerResourceNumber):
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
(WebCore::IDBResourceIdentifier::emptyValue):
(WebCore::IDBResourceIdentifier::deletedValue):
(WebCore::nextResourceNumber): Deleted.
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
(WebCore::IDBResultData::error):
(WebCore::IDBResultData::openDatabaseSuccess):
(WebCore::IDBResultData::openDatabaseUpgradeNeeded):
(WebCore::IDBResultData::databaseInfo):
(WebCore::IDBResultData::transactionInfo):
- Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::type):
(WebCore::IDBResultData::databaseConnectionIdentifier):
- Modules/indexeddb/shared/IDBTransactionInfo.cpp:
(WebCore::IDBTransactionInfo::IDBTransactionInfo):
(WebCore::IDBTransactionInfo::versionChange):
(WebCore::IDBTransactionInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::identifier):
(WebCore::IDBTransactionInfo::mode):
(WebCore::IDBTransactionInfo::newVersion):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::fireVersionChangeEvent):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- WebCore.xcodeproj/project.pbxproj:
- platform/CrossThreadCopier.cpp:
(WebCore::IDBTransactionInfo>::copy):
- platform/CrossThreadCopier.h:
LayoutTests:
- storage/indexeddb/modern/opendatabase-request-event-expected.txt:
- storage/indexeddb/modern/opendatabase-request-event.html:
- 12:51 PM Changeset in webkit [190883] by
-
- 11 edits2 adds in trunk
REGRESSION(r184895): border-image should always slice the SVG image to nine pieces when drawing it in the container element
https://bugs.webkit.org/show_bug.cgi?id=149901
<rdar://problem/21995596>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-12
Reviewed by Darin Adler.
Source/WebCore:
The nine-pieces algorithm should be applied to the border-image regardless
whether the image has an intrinsic size or not. It is not guaranteed to have
a meaningful border-image in all the cases of non-intrinsic size images. But
it should work as expected in most of the cases.
- rendering/RenderBoxModelObject.cpp:
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
Revert the changes which were added to return whether the image has
intrinsic size or not.
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Size of the image is now the return value of calculateImageIntrinsicDimensions().
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage):
Size of the image is now the return value of calculateImageIntrinsicDimensions().
- rendering/style/NinePieceImage.cpp:
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::paint):
Delete the logic for the non-intrinsic case. Both intrinsic and non-intrinsic
cases will be treated the same.
(WebCore::NinePieceImage::computeNineRects):
(WebCore::NinePieceImage::computeSideTileScale):
(WebCore::NinePieceImage::computeMiddleTileScale):
(WebCore::NinePieceImage::computeTileScales):
(WebCore::NinePieceImage::computeIntrinsicRects): Deleted.
(WebCore::NinePieceImage::computeIntrinsicSideTileScale): Deleted.
(WebCore::NinePieceImage::computeIntrinsicMiddleTileScale): Deleted.
(WebCore::NinePieceImage::computeIntrinsicTileScales): Deleted.
Remove *Intrinsic* from the name of the functions.
(WebCore::NinePieceImage::computeNonIntrinsicRects): Deleted.
(WebCore::NinePieceImage::computeNonIntrinsicTileScales): Deleted.
Delete the *NonIntrinsic* functions.
LayoutTests:
- fast/borders/border-image-fill-no-intrinsic-size-expected.html:
- fast/borders/border-image-fill-no-intrinsic-size.html:
- fast/borders/resources/svg-border-100x100-relative.svg: Added.
- fast/borders/resources/svg-border-100x100-viewbox.svg: Added.
- fast/borders/resources/svg-border-140x140-intrinsic.svg:
New test cases for relative lengths border images were added. The relative
lengths can be specified by using percentage lengths or adding viewBox to
the root element.
One of the non-intrinsic image-borders must be removed from this test.
The SVG image in the expected file has to be scaled by (100 / 140), which
can be done. But run-webkit-tests found a very slight difference between
the actual and the result files.
- 12:44 PM Changeset in webkit [190882] by
-
- 8 edits in trunk/Source
"A + B" with strings shouldn't copy if A or B is empty.
<https://webkit.org/b/150034>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
- runtime/Lookup.cpp:
(JSC::reifyStaticAccessor):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
Source/WTF:
Add a fast path to WTF's operator+ magic for concatenation of two strings where
one of them is empty. In that case, try to avoid allocation altogether by returning
the non-empty string.
Spotted this while analyzing memory peaks during page load; it turns out we were
duplicating whole text resources (JS, CSS) at the end of decoding, below
TextResourceDecoder::decodeAndFlush(). That function effectively does:
return decode() + flush();
Very often, flush() returns an empty string, so due to the naive operator+,
we'd allocate a new StringImpl of length (decode().length() + flush().length())
and copy the return value from decode() into it. So silly!
Had to make the tryMakeString() machinery use String as a return type instead of
RefPtr<StringImpl> to make all the right overloads gel. StringTypeAdapter templates
are now required to provide a toString() function.
- wtf/text/StringConcatenate.h:
(WTF::StringTypeAdapter<char>::toString):
(WTF::StringTypeAdapter<UChar>::toString):
(WTF::StringTypeAdapter<Vector<char>>::toString):
(WTF::StringTypeAdapter<String>::toString):
(WTF::tryMakeString):
(WTF::makeString):
- wtf/text/StringOperators.h:
(WTF::StringAppend::operator String):
- wtf/text/StringView.h:
(WTF::StringTypeAdapter<StringView>::toString):
- 12:36 PM Changeset in webkit [190881] by
-
- 2 edits in trunk/Source/JavaScriptCore
VisitedValueCount GC Counter misses parallel SlotVisitors
https://bugs.webkit.org/show_bug.cgi?id=149980
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-12
Reviewed by Geoffrey Garen.
- heap/Heap.cpp:
(JSC::Heap::updateObjectCounts):
Include threaded slot visitor's object counts in the debugging value.
- 12:24 PM EnvironmentVariables edited by
- (diff)
- 12:18 PM Changeset in webkit [190880] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening
Unskip a bunch of passing tests.
- platform/win/TestExpectations:
- 12:15 PM EnvironmentVariables edited by
- (diff)
- 12:15 PM Changeset in webkit [190879] by
-
- 12 edits4 adds in trunk
Clip-path transitions sometimes trigger endless animation timers
https://bugs.webkit.org/show_bug.cgi?id=150018
Reviewed by Tim Horton.
Source/WebCore:
Transitioning -webkit-clip-path could trigger endless animation
timers, because when CompositeAnimation::updateTransitions() calls
isTargetPropertyEqual(), a false negative answer triggers canceling the
current transition and starting a new one over and over.
This happened because StyleRareNonInheritedData simply tested pointer
equality for m_clipPath and m_shapeOutside. Both of these need to do deep
equality testing, requiring the implementation of operator== in BasicShapes
classes.
In addition, the PropertyWrappers in CSSPropertyAnimation need equals()
implementations that also do more than pointer equality testing.
Tests: transitions/clip-path-transitions.html
transitions/shape-outside-transitions.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperClipPath::equals):
(WebCore::PropertyWrapperShape::equals):
- rendering/ClipPathOperation.h:
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCircle::operator==):
(WebCore::BasicShapeEllipse::operator==):
(WebCore::BasicShapePolygon::operator==):
(WebCore::BasicShapeInset::operator==):
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::operator==):
(WebCore::BasicShapeRadius::operator==):
- rendering/style/ShapeValue.cpp:
(WebCore::pointersOrValuesEqual):
(WebCore::ShapeValue::operator==):
- rendering/style/ShapeValue.h:
(WebCore::ShapeValue::operator!=):
(WebCore::ShapeValue::operator==): Deleted.
(WebCore::ShapeValue::ShapeValue): Deleted.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::clipPathOperationsEquivalent):
(WebCore::StyleRareNonInheritedData::shapeOutsideDataEquivalent):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
New tests for transitions of clip-path and shape-outside.
- transitions/clip-path-transitions-expected.txt: Added.
- transitions/clip-path-transitions.html: Added.
- transitions/resources/transition-test-helpers.js:
(parseClipPath):
(checkExpectedValue):
- transitions/shape-outside-transitions-expected.txt: Added.
- transitions/shape-outside-transitions.html: Added.
- transitions/svg-transitions-expected.txt:
- 12:15 PM Changeset in webkit [190878] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix non-FTL build for real.
- ftl/FTLLazySlowPath.h:
- 12:15 PM EnvironmentVariables edited by
- (diff)
- 12:14 PM WikiStart edited by
- (diff)
- 12:10 PM EnvironmentVariables created by
- 12:09 PM WebKitGTK/Debugging edited by
- (diff)
- 12:03 PM Changeset in webkit [190877] by
-
- 2 edits in trunk/LayoutTests
Marking storage/domstorage/events/basic-body-attribute.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=148435
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-12
Reviewed by Alexey Proskuryakov.
- platform/mac/TestExpectations:
- 12:00 PM Changeset in webkit [190876] by
-
- 7 edits in trunk
Test font-variant-* and font-feature-settings on Yosemite and Mavericks
https://bugs.webkit.org/show_bug.cgi?id=149778
Reviewed by Simon Fraser.
Source/WebCore:
We can simply call the function which enables features on Yosemite and Mavericks.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamily):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 11:52 AM WebKitGTK/Debugging edited by
- (diff)
- 11:50 AM WebKitGTK/Debugging edited by
- (diff)
- 11:45 AM Changeset in webkit [190875] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, fix style in the hopes that it fixes Windows.
- wtf/ParallelHelperPool.cpp:
(WTF::ParallelHelperClient::~ParallelHelperClient):
(WTF::ParallelHelperClient::setTask):
(WTF::ParallelHelperClient::doSomeHelping):
(WTF::ParallelHelperClient::runTaskInParallel):
(WTF::ParallelHelperClient::finish):
(WTF::ParallelHelperClient::claimTask):
(WTF::ParallelHelperClient::runTask):
(WTF::ParallelHelperPool::doSomeHelping):
(WTF::ParallelHelperPool::helperThreadBody):
- wtf/ParallelHelperPool.h:
(WTF::ParallelHelperClient::setFunction):
(WTF::ParallelHelperClient::runFunctionInParallel):
(WTF::ParallelHelperClient::pool):
- 11:43 AM Changeset in webkit [190874] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed test gardening after r190800.
Skip mac-specific 'fast/forms/hidpi-textfield-background-bleeding.html' test
on Windows.
- platform/win/TestExpectations:
- 11:39 AM Changeset in webkit [190873] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r190735, not fixed by r190741) failures.
https://bugs.webkit.org/show_bug.cgi?id=150040
- platform/win/TestExpectations: Skip several test failures introduced by JSC changes.
- 11:23 AM Changeset in webkit [190872] by
-
- 5 edits in branches/safari-601.2.7.2-branch/Source
Versioning.
- 11:18 AM Changeset in webkit [190871] by
-
- 1 copy in tags/Safari-601.2.7.2.2
New tag.
- 11:17 AM Changeset in webkit [190870] by
-
- 2 edits in branches/safari-601.2.7.2-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 11:14 AM Changeset in webkit [190869] by
-
- 5 edits in branches/safari-601.2.7.2-branch/Source
Versioning.
- 11:11 AM Changeset in webkit [190868] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed test gardening after r190667.
Mark fast/css/will-change/will-change-create-stacking-context-inline.html as failing, because
Windows does not support backdrop-filter.
- platform/win/TestExpectations:
- 11:11 AM Changeset in webkit [190867] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, clarify a comment. The example code had a bug.
- ftl/FTLLowerDFGToLLVM.cpp:
- 11:10 AM Changeset in webkit [190866] by
-
- 3 edits in branches/safari-601.2.7.2-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 11:08 AM Changeset in webkit [190865] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix no-FTL build.
- ftl/FTLLazySlowPath.cpp:
- 11:06 AM Changeset in webkit [190864] by
-
- 5 edits in branches/safari-601.2.7.2-branch/Source
Versioning.
- 11:04 AM Changeset in webkit [190863] by
-
- 1 copy in branches/safari-601.2.7.2-branch
New Branch.
- 10:59 AM Changeset in webkit [190862] by
-
- 2 edits in trunk/Source/JavaScriptCore
webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand
Don't include CoreFoundation.h when building the GTK port.
- Source/JavaScriptCore/API/WebKitAvailability.h: Add !defined(BUILDING_GTK) to defined(APPLE).
- 10:59 AM Changeset in webkit [190861] by
-
- 6 edits in trunk/LayoutTests
[Win] Unreviewed test gardening after r190840.
Rebaseline tests to match new output (same changes as Mac).
- platform/win/fast/css-generated-content/details-summary-before-after-expected.txt:
- platform/win/fast/html/details-add-child-2-expected.txt:
- platform/win/fast/html/details-open2-expected.txt:
- platform/win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/win/fast/html/details-remove-summary-4-and-click-expected.txt:
- 10:56 AM Changeset in webkit [190860] by
-
- 28 edits3 adds in trunk/Source
FTL should generate code to call slow paths lazily
https://bugs.webkit.org/show_bug.cgi?id=149936
Reviewed by Saam Barati.
Source/JavaScriptCore:
We often have complex slow paths in FTL-generated code. Those slow paths may never run. Even
if they do run, they don't need stellar performance. So, it doesn't make sense to have LLVM
worry about compiling such slow path code.
This patch enables us to use our own MacroAssembler for compiling the slow path inside FTL
code. It does this by using a crazy lambda thingy (see FTLLowerDFGToLLVM.cpp's lazySlowPath()
and its documentation). The result is quite natural to use.
Even for straight slow path calls via something like vmCall(), the lazySlowPath offers the
benefit that the call marshalling and the exception checking are not expressed using LLVM IR
and do not require LLVM to think about it. It also has the benefit that we never generate the
code if it never runs. That's great, since function calls usually involve ~10 instructions
total (move arguments to argument registers, make the call, check exception, etc.).
This patch adds the lazy slow path abstraction and uses it for some slow paths in the FTL.
The code we generate with lazy slow paths is worse than the code that LLVM would have
generated. Therefore, a lazy slow path only makes sense when we have strong evidence that
the slow path will execute infrequently relative to the fast path. This completely precludes
the use of lazy slow paths for out-of-line Nodes that unconditionally call a C++ function.
It also precludes their use for the GetByVal out-of-bounds handler, since when we generate
a GetByVal with an out-of-bounds handler it means that we only know that the out-of-bounds
case executed at least once. So, for all we know, it may actually be the common case. So,
this patch just deployed the lazy slow path for GC slow paths and masquerades-as-undefined
slow paths. It makes sense for GC slow paths because those have a statistical guarantee of
slow path frequency - probably bounded at less than 1/10. It makes sense for masquerades-as-
undefined because we can say quite confidently that this is an uncommon scenario on the
modern Web.
Something that's always been challenging about abstractions involving the MacroAssembler is
that linking is a separate phase, and there is no way for someone who is just given access to
the MacroAssembler& to emit code that requires linking, since linking happens once we have
emitted all code and we are creating the LinkBuffer. Moreover, the FTL requires that the
final parts of linking happen on the main thread. This patch ran into this issue, and solved
it comprehensively, by introducing MacroAssembler::addLinkTask(). This takes a lambda and
runs it at the bitter end of linking - when performFinalization() is called. This ensure that
the task added by addLinkTask() runs on the main thread. This patch doesn't replace all of
the previously existing idioms for dealing with this issue; we can do that later.
This shows small speed-ups on a bunch of things. No big win on any benchmark aggregate. But
mainly this is done for https://bugs.webkit.org/show_bug.cgi?id=149852, where we found that
outlining the slow path in this way was a significant speed boost.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::replaceWithAddressComputation):
(JSC::AbstractMacroAssembler::addLinkTask):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
(JSC::LinkBuffer::performFinalization):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::wasAlreadyDisassembled):
(JSC::LinkBuffer::didAlreadyDisassemble):
(JSC::LinkBuffer::vm):
(JSC::LinkBuffer::executableOffsetFor):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):
(JSC::CodeOrigin::operator bool):
(JSC::CodeOrigin::isHashTableDeletedValue):
(JSC::CodeOrigin::operator!): Deleted.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLInlineCacheDescriptor.h:
(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::CheckInDescriptor::CheckInDescriptor):
(JSC::FTL::LazySlowPathDescriptor::LazySlowPathDescriptor):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLazySlowPath.cpp: Added.
(JSC::FTL::LazySlowPath::LazySlowPath):
(JSC::FTL::LazySlowPath::~LazySlowPath):
(JSC::FTL::LazySlowPath::generate):
- ftl/FTLLazySlowPath.h: Added.
(JSC::FTL::LazySlowPath::createGenerator):
(JSC::FTL::LazySlowPath::patchpoint):
(JSC::FTL::LazySlowPath::usedRegisters):
(JSC::FTL::LazySlowPath::callSiteIndex):
(JSC::FTL::LazySlowPath::stub):
- ftl/FTLLazySlowPathCall.h: Added.
(JSC::FTL::createLazyCallGenerator):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNotifyWrite):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIsObjectOrNull):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIsFunction):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMaterializeCreateActivation):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckWatchdogTimer):
(JSC::FTL::DFG::LowerDFGToLLVM::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateObject):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToLLVM::buildTypeOf):
(JSC::FTL::DFG::LowerDFGToLLVM::sensibleDoubleToInt32):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::speculate):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
(JSC::FTL::compileFTLLazySlowPath):
- ftl/FTLOperations.h:
- ftl/FTLSlowPathCall.cpp:
(JSC::FTL::SlowPathCallContext::SlowPathCallContext):
(JSC::FTL::SlowPathCallContext::~SlowPathCallContext):
(JSC::FTL::SlowPathCallContext::keyWithTarget):
(JSC::FTL::SlowPathCallContext::makeCall):
(JSC::FTL::callSiteIndexForCodeOrigin):
(JSC::FTL::storeCodeOrigin): Deleted.
(JSC::FTL::callOperation): Deleted.
- ftl/FTLSlowPathCall.h:
(JSC::FTL::callOperation):
- ftl/FTLState.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::genericGenerationThunkGenerator):
(JSC::FTL::osrExitGenerationThunkGenerator):
(JSC::FTL::lazySlowPathGenerationThunkGenerator):
(JSC::FTL::registerClobberCheck):
- ftl/FTLThunks.h:
- interpreter/CallFrame.h:
(JSC::CallSiteIndex::CallSiteIndex):
(JSC::CallSiteIndex::operator bool):
(JSC::CallSiteIndex::bits):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgument):
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITOperations.cpp:
Source/WTF:
Enables SharedTask to handle any function type, not just void().
It's probably better to use SharedTask instead of std::function in performance-sensitive
code. std::function uses the system malloc and has copy semantics. SharedTask uses FastMalloc
and has aliasing semantics. So, you can just trust that it will have sensible performance
characteristics.
- wtf/ParallelHelperPool.cpp:
(WTF::ParallelHelperClient::~ParallelHelperClient):
(WTF::ParallelHelperClient::setTask):
(WTF::ParallelHelperClient::doSomeHelping):
(WTF::ParallelHelperClient::runTaskInParallel):
(WTF::ParallelHelperClient::finish):
(WTF::ParallelHelperClient::claimTask):
(WTF::ParallelHelperClient::runTask):
(WTF::ParallelHelperPool::doSomeHelping):
(WTF::ParallelHelperPool::helperThreadBody):
- wtf/ParallelHelperPool.h:
(WTF::ParallelHelperClient::setFunction):
(WTF::ParallelHelperClient::runFunctionInParallel):
(WTF::ParallelHelperClient::pool):
- wtf/SharedTask.h:
(WTF::createSharedTask):
(WTF::SharedTask::SharedTask): Deleted.
(WTF::SharedTask::~SharedTask): Deleted.
(WTF::SharedTaskFunctor::SharedTaskFunctor): Deleted.
- 10:25 AM Changeset in webkit [190859] by
-
- 22 edits2 deletes in trunk
Don't allow plug-ins to override image types for <embed> elements
https://bugs.webkit.org/show_bug.cgi?id=149979
Reviewed by Tim Horton.
Source/WebCore:
Stop allowing plug-ins to take over image types for <embed> elements. We already do this
for <object> elements, but had to make <embed> elements exempt because of webkit.org/b/49016.
The QuickTime plug-in hasn't supported image types since Lion, so there's no point in keeping this code around.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::HTMLEmbedElement):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::parametersForPlugin):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
- html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::shouldPreferPlugInsForImages): Deleted.
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::resourceWillUsePlugin):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::shouldUsePlugin):
- loader/SubframeLoader.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::objectContentType):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
LayoutTests:
Remove test.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
- plugins/embed-prefers-plugins-for-images.html: Removed.
- 10:23 AM Changeset in webkit [190858] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/notifications/events.html as flaky again as patch did not resolve crashes
https://bugs.webkit.org/show_bug.cgi?id=149218
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-12
Reviewed by Brian Burg.
- platform/mac/TestExpectations:
- 10:03 AM Changeset in webkit [190857] by
-
- 2 edits in trunk/Source/JavaScriptCore
webkit-gtk-2.3.4 fails to link JavaScriptCore, missing symbols add_history and readline
https://bugs.webkit.org/show_bug.cgi?id=127059
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.
- shell/CMakeLists.txt: Link JSC with -ledit on Mac OSX.
- 10:01 AM Changeset in webkit [190856] by
-
- 2 edits in trunk
[GTK] Use --version-script only on Linux
https://bugs.webkit.org/show_bug.cgi?id=144555
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.
- Source/cmake/OptionsGTK.cmake: Don't add --version-script
option on Darwin (whose linker doesn't support it.)
- 8:30 AM Changeset in webkit [190855] by
-
- 2 edits in trunk/Tools
[GTK] Update jhbuild's version of harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=149749
Reviewed by Martin Robinson.
Update harfbuzz to 0.9.35, following the lead of Debian Stable.
- gtk/jhbuild.modules: Updated details for harfbuzz.
- 5:37 AM Changeset in webkit [190854] by
-
- 2 edits1 add in trunk/Tools
[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
https://bugs.webkit.org/show_bug.cgi?id=150026
Reviewed by Philippe Normand.
Backport upstream patch from gst-plugins-bad so that the right version
of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
gets compiled properly, avoiding crashes on runtime while running tests.
- gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
- gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
- 4:31 AM Changeset in webkit [190853] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, fixing debug builds with Clang on Linux
by including the stdio.h header where it's required
under a debug configuration.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
- rendering/SimpleLineLayoutFunctions.cpp:
- 4:24 AM Changeset in webkit [190852] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, followup to r190643.
Inline the std::function<> constructor wrappings around lambdas
into a single line, instead of spanning it across four lines.
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
- 12:52 AM Changeset in webkit [190851] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Bump Version/X in user agent
https://bugs.webkit.org/show_bug.cgi?id=150013
Reviewed by Csaba Osztrogonác.
EFL port needs to ensure maximum compatibility with existing web sites.
Thus version number needs to be bumped from 5.0 to 8.0 as GTK port.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):
Oct 11, 2015:
- 9:41 PM Changeset in webkit [190850] by
-
- 2 edits in trunk/Source/WebCore
Add missing builtins files to the Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=150015
Reviewed by Yusuke Suzuki.
- WebCore.xcodeproj/project.pbxproj:
- 8:34 PM Changeset in webkit [190849] by
-
- 20 edits in trunk/Source/WebCore
Cleanup and simplification of SVG path-related classes
https://bugs.webkit.org/show_bug.cgi?id=150011
Reviewed by Zalan Bujtas.
Many SVG path-related subclasses were stateful, but only because code in
SVGPathUtilities kept global copies around for no reason. A microbenchmark
showed that there was no benefit to keeping global singletons of SVGPathBuilder,
SVGPathSegListBuilder, SVGPathByteStreamBuilder, SVGPathStringBuilder,
SVGPathTraversalStateBuilder, SVGPathParser and SVGPathBlender.
Making these classes not be re-usable makes the code much simpler, allowing
their SVGPathSources, SVGPathConsumers, SVGPathByteStream etc. to be stored
by reference, and eliminating the cleanup() function which created annoying
ordering issues.
Code that uses SVGPathParser and SVGPathBlender is further simplified by having
these classes expose only static functions, hiding any internal statefulness.
- svg/SVGPathBlender.cpp: Remove the m_progress member variable and instead
pass progress to the various blend functions, as we do for other blend functions.
Expose two only static functions. Pointers to references.
(WebCore::SVGPathBlender::addAnimatedPath):
(WebCore::SVGPathBlender::blendAnimatedPath):
(WebCore::SVGPathBlender::SVGPathBlender):
(WebCore::SVGPathBlender::blendAnimatedDimensonalFloat):
(WebCore::SVGPathBlender::blendAnimatedFloatPoint):
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendLineToSegment):
(WebCore::SVGPathBlender::blendLineToHorizontalSegment):
(WebCore::SVGPathBlender::blendLineToVerticalSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
(WebCore::SVGPathBlender::blendArcToSegment):
(WebCore::SVGPathBlender::cleanup): Deleted.
- svg/SVGPathBlender.h: Make the constructor take a ref to the destination Path,
which is stored by reference.
- svg/SVGPathBuilder.cpp:
(WebCore::SVGPathBuilder::SVGPathBuilder):
(WebCore::SVGPathBuilder::moveTo):
(WebCore::SVGPathBuilder::lineTo):
(WebCore::SVGPathBuilder::curveToCubic):
(WebCore::SVGPathBuilder::closePath):
- svg/SVGPathBuilder.h:
(WebCore::SVGPathBuilder::setCurrentPath): Deleted.
- svg/SVGPathByteStreamBuilder.cpp: References, assertions removed.
(WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder):
- svg/SVGPathByteStreamBuilder.h:
(WebCore::SVGPathByteStreamBuilder::writeType):
(WebCore::SVGPathByteStreamBuilder::setCurrentByteStream): Deleted.
- svg/SVGPathConsumer.h:
- svg/SVGPathElement.cpp:
- svg/SVGPathParser.cpp: Expose some static helper functions for parsing
to byte streams and strings. References.
(WebCore::SVGPathParser::parse):
(WebCore::SVGPathParser::parseToByteStream):
(WebCore::SVGPathParser::parseToString):
(WebCore::SVGPathParser::SVGPathParser):
(WebCore::SVGPathParser::parseClosePathSegment):
(WebCore::SVGPathParser::parseMoveToSegment):
(WebCore::SVGPathParser::parseLineToSegment):
(WebCore::SVGPathParser::parseLineToHorizontalSegment):
(WebCore::SVGPathParser::parseLineToVerticalSegment):
(WebCore::SVGPathParser::parseCurveToCubicSegment):
(WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathParser::parseArcToSegment):
(WebCore::SVGPathParser::parsePathData):
(WebCore::SVGPathParser::decomposeArcToCubic):
(WebCore::SVGPathParser::parsePathDataFromSource): Deleted.
(WebCore::SVGPathParser::cleanup): Deleted.
- svg/SVGPathParser.h:
(WebCore::SVGPathParser::setCurrentConsumer): Deleted.
(WebCore::SVGPathParser::setCurrentSource): Deleted.
- svg/SVGPathSegListBuilder.cpp:
(WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
(WebCore::SVGPathSegListBuilder::moveTo):
(WebCore::SVGPathSegListBuilder::lineTo):
(WebCore::SVGPathSegListBuilder::lineToHorizontal):
(WebCore::SVGPathSegListBuilder::lineToVertical):
(WebCore::SVGPathSegListBuilder::curveToCubic):
(WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
(WebCore::SVGPathSegListBuilder::curveToQuadratic):
(WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathSegListBuilder::arcTo):
(WebCore::SVGPathSegListBuilder::closePath):
- svg/SVGPathSegListBuilder.h:
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement): Deleted.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): Deleted.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole): Deleted.
- svg/SVGPathStringBuilder.cpp:
(WebCore::SVGPathStringBuilder::cleanup): Deleted.
- svg/SVGPathStringBuilder.h:
- svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
(WebCore::SVGPathTraversalStateBuilder::moveTo):
(WebCore::SVGPathTraversalStateBuilder::lineTo):
(WebCore::SVGPathTraversalStateBuilder::curveToCubic):
(WebCore::SVGPathTraversalStateBuilder::closePath):
(WebCore::SVGPathTraversalStateBuilder::continueConsuming):
(WebCore::SVGPathTraversalStateBuilder::totalLength):
(WebCore::SVGPathTraversalStateBuilder::currentPoint):
(WebCore::SVGPathTraversalStateBuilder::setDesiredLength): Deleted.
- svg/SVGPathTraversalStateBuilder.h:
(WebCore::SVGPathTraversalStateBuilder::pathSegmentIndex):
(WebCore::SVGPathTraversalStateBuilder::setCurrentTraversalState): Deleted.
- svg/SVGPathUtilities.cpp: Remove globals accessors, making things on the stack
instead. Use SVGPathParser helper functions where possible.
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):
(WebCore::getSVGPathSegAtLengthFromSVGPathByteStream):
(WebCore::getTotalLengthOfSVGPathByteStream):
(WebCore::getPointAtLengthOfSVGPathByteStream):
(WebCore::buildStringFromPath):
(WebCore::globalSVGPathBuilder): Deleted.
(WebCore::globalSVGPathSegListBuilder): Deleted.
(WebCore::globalSVGPathByteStreamBuilder): Deleted.
(WebCore::globalSVGPathStringBuilder): Deleted.
(WebCore::globalSVGPathTraversalStateBuilder): Deleted.
(WebCore::globalSVGPathParser): Deleted.
(WebCore::globalSVGPathBlender): Deleted.
- svg/SVGPathUtilities.h:
- svg/SVGToOTFFontConversion.cpp: CFFBuilder no longer inherits from SVGPathBuilder.
It did nothing with the Path, re-implemented all the functions, and only made use of
the m_current member var, so just make it inherit from SVGPathConsumer, and have
its own m_current.
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths):
- 6:47 PM Writing Layout Tests to test iOS UI features edited by
- Fix typos and make the content read well. (diff)
- 1:23 PM Changeset in webkit [190848] by
-
- 16 edits4 copies3 adds15 deletes in trunk
Test font-variant-* and font-feature-settings with mocked preinstalled fonts
https://bugs.webkit.org/show_bug.cgi?id=149777
Reviewed by Simon Fraser.
Tools:
Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
to the list of tests to preinstall at startup time.
Also, update the generation of the 'name' table in the FontWithFeatures font.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
(activateFontsIOS):
- FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(Generator::generate):
(Generator::appendCFFTable):
(Generator::appendNameSubtable):
(Generator::appendNAMETable):
- FontWithFeatures/FontWithFeatures/main.cpp:
(main):
- WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::allowedFontFamilySet):
LayoutTests:
See per-file comments.
- css3/font-feature-settings-preinstalled-fonts.html: Removed. Superseded by
css3/font-feature-settings-rendering.html.
- css3/font-feature-settings-rendering-2-expected.html: Removed.
- css3/font-feature-settings-rendering-2.html: Removed. Renamed to
css3/font-feature-settings-rendering.html
- css3/font-feature-settings-rendering-expected.html: Added.
- css3/font-feature-settings-rendering.html:
- css3/font-variant-all-expected.html:
- css3/font-variant-all.html:
- css3/resources/FontWithFeatures.otf: Update for new 'name' table.
- css3/resources/FontWithFeatures.ttf: Ditto.
- 11:46 AM Changeset in webkit [190847] by
-
- 9 edits1 add in trunk
ES6 classes: When a class extends B, super() invokes B.prototype.constructor() instead of B()
https://bugs.webkit.org/show_bug.cgi?id=149001
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch matches the
super()call in the constructor to the latest spec.
Before this patch, when callingsuper(), it loadscallee.[[HomeObject]].__proto__.constructor
as a super constructor. But after this patch, it loadscallee.__proto__as a super constructor.
This behavior corresponds to the section 12.3.5.2[1].
[1]: http://www.ecma-international.org/ecma-262/6.0/#sec-getsuperconstructor
- bytecompiler/NodesCodegen.cpp:
(JSC::SuperNode::emitBytecode):
- tests/stress/super-call-does-not-look-up-constructor.js: Added.
(shouldBe):
(B):
(C):
(B.prototype):
LayoutTests:
An error message becomes changed.
- js/class-syntax-call-expected.txt:
- js/class-syntax-extends-expected.txt:
- js/class-syntax-super-expected.txt:
- js/script-tests/class-syntax-call.js:
- js/script-tests/class-syntax-extends.js:
- js/script-tests/class-syntax-super.js:
- 9:09 AM Changeset in webkit [190846] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Jinyoung Hur as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 12:18 AM Changeset in webkit [190845] by
-
- 17 edits4 deletes in trunk/Source/WebCore
Remove InsertionPoint and ContentDistributor
https://bugs.webkit.org/show_bug.cgi?id=150004
Rubber-stamped by Sam Weinig.
Now that <details> is on top of the modern Shadow DOM remove the last vestiges of the V0 Shadow DOM API.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- css/SelectorChecker.cpp:
- css/StyleResolver.cpp:
- dom/ContainerNode.cpp:
- dom/Element.cpp:
(WebCore::shouldUseNodeRenderingTraversalSlowPath):
(WebCore::Element::resetNeedsNodeRenderingTraversalSlowPath):
- dom/Node.cpp:
(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::insertedInto):
(WebCore::Node::insertionParentForBinding): Deleted.
- dom/Node.h:
(WebCore::Node::isCharacterDataNode):
(WebCore::Node::isFrameOwnerElement):
(WebCore::Node::isPluginElement):
(WebCore::Node::isImageControlsRootElement):
(WebCore::Node::isImageControlsButtonElement):
(WebCore::Node::isDocumentFragment):
(WebCore::Node::isShadowRoot):
(WebCore::Node::isInsertionPointNode): Deleted.
(WebCore::Node::isInsertionPoint): Deleted.
- dom/NodeRenderingTraversal.cpp:
(WebCore::NodeRenderingTraversal::traverseParent):
(WebCore::NodeRenderingTraversal::traverseFirstChild):
(WebCore::NodeRenderingTraversal::traverseLastChild):
(WebCore::NodeRenderingTraversal::traverseNextSibling):
(WebCore::NodeRenderingTraversal::traversePreviousSibling):
(WebCore::NodeRenderingTraversal::parentSlow):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::previousInScope):
(WebCore::NodeRenderingTraversal::parentInScope):
(WebCore::NodeRenderingTraversal::lastChildInScope):
(WebCore::NodeRenderingTraversal::nodeCanBeDistributed): Deleted.
(WebCore::NodeRenderingTraversal::findFirstSiblingEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findFirstEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findFirstFromDistributedNode): Deleted.
(WebCore::NodeRenderingTraversal::findLastSiblingEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findLastEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findLastFromDistributedNode): Deleted.
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::distributor): Deleted.
- html/HTMLInputElement.cpp:
- html/HTMLSlotElement.cpp:
- html/HTMLSlotElement.h:
- html/shadow/ContentDistributor.cpp: Removed.
- html/shadow/ContentDistributor.h: Removed.
- html/shadow/InsertionPoint.cpp: Removed.
- html/shadow/InsertionPoint.h: Removed.
- page/FocusController.cpp:
(WebCore::FocusController::previousFocusableElement):
- testing/Internals.cpp:
Oct 10, 2015:
- 11:16 PM Changeset in webkit [190844] by
-
- 10 edits in trunk/Source/WebCore
Use references and more const in SVGPathUtilities
https://bugs.webkit.org/show_bug.cgi?id=150007
Reviewed by Zalan Bujtas.
SVGPathUtilities had lots of pointers whose non-nullness was asserted,
little const, and was very trigger-happy with stack allocations. Clean
that all up.
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPathAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::begin):
(WebCore::SVGPathByteStream::end):
(WebCore::SVGPathByteStream::append):
- svg/SVGPathByteStreamSource.cpp:
(WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource):
- svg/SVGPathByteStreamSource.h:
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::SVGPathElement): Deleted.
- svg/SVGPathElement.h:
- svg/SVGPathUtilities.cpp:
(WebCore::globalSVGPathBuilder):
(WebCore::globalSVGPathSegListBuilder):
(WebCore::globalSVGPathByteStreamBuilder):
(WebCore::globalSVGPathStringBuilder):
(WebCore::globalSVGPathTraversalStateBuilder):
(WebCore::globalSVGPathParser):
(WebCore::globalSVGPathBlender):
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):
(WebCore::getSVGPathSegAtLengthFromSVGPathByteStream):
(WebCore::getTotalLengthOfSVGPathByteStream):
(WebCore::getPointAtLengthOfSVGPathByteStream):
(WebCore::buildStringFromPath):
- svg/SVGPathUtilities.h:
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):
- 2:14 PM Changeset in webkit [190843] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reduce pointless malloc traffic in CodeBlock construction.
<https://webkit.org/b/149999>
Reviewed by Antti Koivisto.
Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
- bytecode/CodeBlock.h:
- 2:13 PM Changeset in webkit [190842] by
-
- 3 edits in trunk/Source/WebCore
Reduce pointless malloc traffic in ElementRuleCollector.
<https://webkit.org/b/150003>
Reviewed by Antti Koivisto.
Don't use a unique_ptr for the m_matchedRules vector in ElementRuleCollector.
This is one of our heaviest sources of transient allocations, with ~88000
malloc/free pairs on loading theverge.com.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::hasMatchedRules):
- 1:05 PM Changeset in webkit [190841] by
-
- 66 edits in trunk
[iOS] Remove unnecessary iOS version checks
https://bugs.webkit.org/show_bug.cgi?id=150002
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
Source/WebCore:
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
- loader/cocoa/DiskCacheMonitorCocoa.h:
(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):
- page/mac/SettingsMac.mm:
(WebCore::sansSerifTraditionalHanFontFamily):
(WebCore::sansSerifSimplifiedHanFontFamily):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::appendOpenTypeFeature):
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::getSystemFontFallbackForCharacters):
(WebCore::platformLookupFallbackFont):
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
- platform/ios/WebCoreSystemInterfaceIOS.h:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
- platform/ios/wak/WAKWindow.mm:
(+[WAKWindow hasLandscapeOrientation]):
(-[WAKWindow hostLayer]):
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::createCookies):
- platform/network/mac/CertificateInfoMac.mm:
(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate):
- platform/spi/cf/CFNetworkSPI.h:
- platform/spi/cocoa/AVKitSPI.h:
- platform/spi/cocoa/CoreTextSPI.h:
- platform/spi/cocoa/NEFilterSourceSPI.h:
- platform/spi/cocoa/QuartzCoreSPI.h:
- platform/spi/cocoa/SecuritySPI.h:
- platform/spi/ios/LaunchServicesSPI.h:
- platform/spi/mac/AVFoundationSPI.h:
- platform/text/TextBreakIterator.cpp:
- platform/text/TextFlags.h:
- platform/text/ios/LocalizedDateCache.mm:
(WebCore::LocalizedDateCache::calculateMaximumWidth):
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::LocaleMac):
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::cachedSystemFontDescription):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendKERNTable):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):
Source/WebKit/mac:
- Plugins/WebPluginController.h:
- Plugins/WebPluginController.mm:
(-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(+[WebPluginController addPlugInView:]):
(+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): Deleted.
- WebCoreSupport/WebFrameLoaderClient.mm:
(pluginView):
- WebView/WebPreferences.mm:
(-[WebPreferences isDNSPrefetchingEnabled]):
(-[WebPreferences setWebInspectorServerEnabled:]): Deleted.
(-[WebPreferences _setAllowCompositingLayerVisualDegradation:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(shouldAllowPictureInPictureMediaPlayback):
Source/WebKit2:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::AccessibilityProcessSuspendedNotification):
- Platform/spi/ios/SafariServicesSPI.h:
- Platform/spi/ios/UIKitSPI.h:
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::NativeWebTouchEvent::extractWebTouchPoint):
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
- Shared/ios/WebPlatformTouchPointIOS.cpp:
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mayAutomaticallyShowVideoPictureInPicture]):
(shouldAllowPictureInPictureMediaPlayback):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
- UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _ensureFormAccessoryView]):
(-[WKContentView webSelectionAssistant]):
(-[WKContentView selectionInteractionAssistant]):
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::create):
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(photoLibraryIcon):
(cameraIcon):
(fallbackIconForFile):
(iconForImageFile):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Source/WTF:
- wtf/Platform.h:
Tools:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
- WebKitTestRunner/ios/UIKitSPI.h:
- 11:16 AM Changeset in webkit [190840] by
-
- 27 edits in trunk
Rewrite HTMLDetailsElement using HTMLSlotElement
https://bugs.webkit.org/show_bug.cgi?id=149698
Reviewed by Andreas Kling.
Source/WebCore:
Use the modern Shadow DOM to implement <details> element. After this the legacy InsertionPoint and
related code can be removed.
Based on a patch by Ryosuke.
- dom/Element.cpp:
(WebCore::Element::childrenChanged):
- dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::removeAllEventListeners):
(WebCore::ShadowRoot::findAssignedSlot):
(WebCore::ShadowRoot::addSlotElementByName):
(WebCore::ShadowRoot::removeSlotElementByName):
(WebCore::ShadowRoot::invalidateSlotAssignments):
(WebCore::ShadowRoot::invalidateDefaultSlotAssignments):
(WebCore::ShadowRoot::assignedNodesForSlot):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::distributor):
(WebCore::ShadowRoot::isOrphan):
- dom/SlotAssignment.cpp:
(WebCore::slotNameFromAttributeValue):
Rename for clarity.
(WebCore::slotNameFromSlotAttribute):
SlotAssignment can now be specialized by providing function that maps from node to slot name.
This is the default function that gets the name from the slot attribute.
(WebCore::SlotAssignment::SlotAssignment):
(WebCore::SlotAssignment::findAssignedSlot):
Use the name mapping function.
Ensure that the slots are assigned.
(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::removeSlotElementByName):
(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::invalidate):
(WebCore::SlotAssignment::invalidateDefaultSlot):
(WebCore::SlotAssignment::resolveAllSlotElements):
(WebCore::SlotAssignment::assignSlots):
Use the name mapping function.
(WebCore::SlotAssignment::assignToSlot):
Factor into function.
(WebCore::treatNullAsEmpty): Deleted.
- dom/SlotAssignment.h:
(WebCore::SlotAssignment::~SlotAssignment):
(WebCore::SlotAssignment::defaultSlotName):
Add static getter for emptyAtom for clarity.
(WebCore::SlotAssignment::SlotAssignment): Deleted.
- html/HTMLDetailsElement.cpp:
(WebCore::summarySlotName):
(WebCore::slotNameFunction):
Slot name function for <details>. It assigns the first <summary> child to the summary slot and others
to the default content slot if the element is open.
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
(WebCore::HTMLDetailsElement::isActiveSummary):
(WebCore::HTMLDetailsElement::parseAttribute):
(WebCore::HTMLDetailsElement::toggleOpen):
(WebCore::summaryQuerySelector): Deleted.
(WebCore::DetailsContentElement::create): Deleted.
(WebCore::DetailsSummaryElement::create): Deleted.
(WebCore::HTMLDetailsElement::findMainSummary): Deleted.
(WebCore::HTMLDetailsElement::childShouldCreateRenderer): Deleted.
- html/HTMLDetailsElement.h:
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::createElementRenderer):
(WebCore::HTMLSummaryElement::didAddUserAgentShadowRoot):
(WebCore::HTMLSummaryElement::detailsElement):
(WebCore::HTMLSummaryElement::isActiveSummary):
(WebCore::isClickableControl):
(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore::HTMLSummaryElement::defaultEventHandler):
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):
(WebCore::SummaryContentElement::create): Deleted.
(WebCore::HTMLSummaryElement::childShouldCreateRenderer): Deleted.
(WebCore::HTMLSummaryElement::isMainSummary): Deleted.
- html/HTMLSummaryElement.h:
- html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::rendererIsNeeded):
- style/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::computeNextSibling):
Skip the verification assert for shadow host children. Getting this right requires
better shadow-aware traversal code.
- style/StyleResolveTree.cpp:
(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachSlotAssignees):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachShadowRoot):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::detachRenderTree):
(WebCore::Style::resolveChildren):
(WebCore::Style::resolveSlotAssignees):
(WebCore::Style::resolveTree):
(WebCore::Style::attachDistributedChildren): Deleted.
(WebCore::Style::detachDistributedChildren): Deleted.
Remove InsertionPoint related code paths.
LayoutTests:
- TestExpectations:
- platform/mac/fast/html/details-add-child-2-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- 8:50 AM Changeset in webkit [190839] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve error messages for internal Inspector code
https://bugs.webkit.org/show_bug.cgi?id=149995
Don't log "error.stack" since the error view already includes a nicely formatted stacktrace.
Reviewed by Timothy Hatcher.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype._dispatchResponseToCallback):
(InspectorBackendClass.prototype._dispatchEvent):
- 8:27 AM Changeset in webkit [190838] by
-
- 4 edits in trunk
SerializedScriptValue should use a compact encoding for 8-bit strings.
<https://webkit.org/b/149934>
Reviewed by Antti Koivisto.
Source/WebCore:
We were encoding known 8-bit strings in a 16-bit format when serializing script values.
Extend the format to support 8-bit strings. The 8-bittiness is encoded in the highest bit
of the string length. This is possible while supporting all older formats due to string
lengths >= 0x7FFFFFFF being disallowed.
This patch knocks ~1 MB off of theverge.com, where some ad or tracker or whatever likes to
do a ton of postMessage() business.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CurrentVersion): Bump the serialization format version. Also updated the grammar
comment to describe the new format. Artistic license applied in description of bitfield.
(WebCore::writeLittleEndianUInt16): Deleted.
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserializeString):
(WebCore::CloneDeserializer::readString):
(WebCore::CloneDeserializer::readStringData): Support 8-bit strings. I kept the string
length limit at UINT_MAX/sizeof(UChar) since the highest bit of the length is no longer
available. Besides, it seems flimsy to support longer strings if they happen to have all
8-bit characters.
LayoutTests:
Update a test to reflect changes to the serialization format.
- fast/storage/serialized-script-value.html:
- 1:40 AM Changeset in webkit [190837] by
-
- 31 edits in trunk/Source
[iOS] Remove project support for iOS 8
https://bugs.webkit.org/show_bug.cgi?id=149993
Reviewed by Alexey Proskuryakov.
Source/bmalloc:
- Configurations/Base.xcconfig:
- Configurations/bmalloc.xcconfig:
- Configurations/mbmalloc.xcconfig:
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/JSC.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/LLVMForJSC.xcconfig:
- Configurations/ToolExecutable.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/ANGLE.xcconfig:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/WebCore.xcconfig:
- Configurations/WebCoreTestSupport.xcconfig:
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseLegacyProcess.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/PluginProcessShim.xcconfig:
- Configurations/SecItemShim.xcconfig:
- Configurations/WebKit.xcconfig:
- Configurations/WebKit2.xcconfig:
- Configurations/WebProcessShim.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/WTF.xcconfig:
- Configurations/mbmalloc.xcconfig:
Oct 9, 2015:
- 8:52 PM Changeset in webkit [190836] by
-
- 9 edits1 copy in trunk
Unreviewed, rolling out r190689
https://bugs.webkit.org/show_bug.cgi?id=149992
Fixed in other repository.
Reverted changesets:
"Unreviewed, rolling out r190572, r190593, r190594, and r190639."
https://bugs.webkit.org/show_bug.cgi?id=149897
- 7:53 PM Changeset in webkit [190835] by
-
- 2 edits in trunk/Source/WebCore
Check if start and end positions are still valid after updating them through VisibleSelection.
https://bugs.webkit.org/show_bug.cgi?id=149982
Reviewed by Ryosuke Niwa.
This patch is required to be able to clean up anonymous tables structure.
In certain edge cases, start/end positions could become nullptr after various text splitting
operations.
Covered by editing/execCommand/crash-137961.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):
- 7:20 PM Changeset in webkit [190834] by
-
- 23 edits in trunk/Source/WebCore
Rename RenderObject::isRoot() to isDocumentElementRenderer()
https://bugs.webkit.org/show_bug.cgi?id=149976
Reviewed by Zalan Bujtas.
RenderObject::isRoot() was confusingly named, because it returns true for
the document element's renderer, not for the actual root (the RenderView).
In this way it mismatched RenderLayer::isRootLayer(), which returned true
for the RenderView's layer.
Rename it to the more accurate isDocumentElementRenderer().
- dom/Node.cpp:
(WebCore::Node::renderRect):
- page/ios/FrameIOS.mm:
(WebCore::Frame::renderRectForPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::selectionGaps):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::requiresColumns):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::createsNewFormattingContext):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):
- rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::fixedBackgroundPaintsInLocalCoordinates):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::rendererForRootBackground):
(WebCore::shouldRepaintForImageAnimation):
- rendering/RenderElement.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderLayer.cpp:
(WebCore::shouldSuppressPaintingLayer):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintSlowRepaintObject):
(WebCore::RenderObject::offsetParent):
- rendering/RenderObject.h:
(WebCore::RenderObject::isDocumentElementRenderer):
(WebCore::RenderObject::isRoot): Deleted.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::shouldApplyViewportClip):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::isOverflowHidden):
- 6:08 PM Changeset in webkit [190833] by
-
- 22 edits2 adds in trunk
AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan
https://bugs.webkit.org/show_bug.cgi?id=148967
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for ARIA 1.1 table/grid related attributes. Created new attributes for mac, so
VoiceOver can pick up the information and speak accordingly.
Test: accessibility/mac/aria-table-attributes.html
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
(WebCore::AccessibilityARIAGridCell::parentRowGroup):
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::initializeRoleMap):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::title):
(WebCore::AccessibilityTable::ariaColumnCount):
(WebCore::AccessibilityTable::ariaRowCount):
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::titleUIElement):
(WebCore::AccessibilityTableCell::ariaColumnIndex):
(WebCore::AccessibilityTableCell::ariaRowIndex):
(WebCore::AccessibilityTableCell::ariaColumnSpan):
(WebCore::AccessibilityTableCell::ariaRowSpan):
- accessibility/AccessibilityTableCell.h:
(WebCore::AccessibilityTableCell::setARIAColIndexFromRow):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::ariaColumnIndex):
(WebCore::AccessibilityTableRow::ariaRowIndex):
- accessibility/AccessibilityTableRow.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
LayoutTests:
- accessibility/mac/aria-columnrowheaders-expected.txt:
- accessibility/mac/aria-table-attributes-expected.txt: Added.
- accessibility/mac/aria-table-attributes.html: Added.
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cell-spans-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- platform/mac/accessibility/table-with-rules-expected.txt:
- 4:30 PM Changeset in webkit [190832] by
-
- 6 edits in trunk/Source/WebKit2
Rubber-stamped by Anders Carlsson.
Remove unnecessary includes.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
- 4:19 PM Changeset in webkit [190831] by
-
- 2 edits in trunk/Source/JavaScriptCore
Modernize and cleanup an NSNumber constant
https://bugs.webkit.org/show_bug.cgi?id=149962
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Andreas Kling.
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine addExternalRememberedObject:]):
- 4:19 PM Changeset in webkit [190830] by
-
- 3 edits2 deletes in trunk/Source/WebKit2
Build fix.
- CMakeLists.txt:
- Shared/API/APIHitTestResult.cpp: Removed.
- Shared/API/APIHitTestResult.h: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 4:17 PM Changeset in webkit [190829] by
-
- 3 edits in trunk/Source/JavaScriptCore
No need to keep setting needsVisit flag in SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=149961
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Andreas Kling.
SmallStrings are all initialized at once privately before the VM
enables Garbage Collection. There is no need to keep updating
this flag, as it couldn't have changed.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::initialize):
- runtime/SmallStrings.h:
- 4:15 PM Changeset in webkit [190828] by
-
- 2 edits2 copies in trunk/Source/WebKit2
Build fix.
- UIProcess/API/APIHitTestResult.cpp: Copied from Shared/API/APIHitTestResult.cpp.
- UIProcess/API/APIHitTestResult.h: Copied from Shared/API/APIHitTestResult.h.
- UIProcess/mac/PageClientImpl.mm:
- 4:10 PM Changeset in webkit [190827] by
-
- 57 edits in trunk/Source/JavaScriptCore
2015-10-09 Geoffrey Garen <ggaren@apple.com>
Unreviewed, rolling back in r190694
https://bugs.webkit.org/show_bug.cgi?id=149727
This time for double sure?
The cause of the crash was an incorrect write barrier.
OSR exit was barriering the baseline codeblock for the top of the stack
twice, missing the baseline codeblock for the bottom of the stack.
Restored changesets:
"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/r190694
- 3:48 PM Changeset in webkit [190826] by
-
- 2 edits in trunk/Source/WebCore
Remove hack that allowed plug-ins to always take over certain image formats
https://bugs.webkit.org/show_bug.cgi?id=149972
Reviewed by Tim Horton.
This hack was added 8 years ago to allow a certain plug-in to show multi-page TIFF images on uspto.gov.
We now support said TIFFs natively, and the plug-in has been discontinued so it's safe to get rid of this.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::shouldUsePlugin): Deleted.
- 3:27 PM Changeset in webkit [190825] by
-
- 1 copy in tags/Safari-601.1.46.41
New tag.
- 3:26 PM Changeset in webkit [190824] by
-
- 1 copy in tags/Safari-601.3.3
New tag.
- 3:24 PM Changeset in webkit [190823] by
-
- 41 edits3 moves5 adds in trunk/Source/WebKit2
WKWebView needs SPI to customize immediate actions
https://bugs.webkit.org/show_bug.cgi?id=149939
-and corresponding-
rdar://problem/20016849
Reviewed by Anders Carlsson.
This patch breaks WebHitTestResult into two files. WebHiTestResultData
continues to live in the WebKit namespace and contains the old
WebHitTestResult::Data struct. The rest of WebHitTestResult is now
API::HitTestResult. The patch also adds _WKHitTestResult as Obj-C API to wrap
API::HitTestResult.
Attempt to keep other ports happy with new files.
- CMakeLists.txt:
WebKit::WebHitTestResult no longer contains the Data struct and is now called
API::HitTestResult.
- Shared/API/APIHitTestResult.cpp: Copied from Shared/WebHitTestResult.cpp.
(API::HitTestResult::create):
(WebKit::WebHitTestResult::create): Deleted.
(WebKit::WebHitTestResult::Data::Data): Deleted.
(WebKit::WebHitTestResult::Data::~Data): Deleted.
(WebKit::WebHitTestResult::Data::encode): Deleted.
(WebKit::WebHitTestResult::Data::decode): Deleted.
(WebKit::WebHitTestResult::Data::platformEncode): Deleted.
(WebKit::WebHitTestResult::Data::platformDecode): Deleted.
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates): Deleted.
- Shared/API/APIHitTestResult.h: Copied from Shared/WebHitTestResult.h.
(API::HitTestResult::absoluteImageURL):
(API::HitTestResult::absolutePDFURL):
(API::HitTestResult::absoluteLinkURL):
(API::HitTestResult::absoluteMediaURL):
(API::HitTestResult::linkLabel):
(API::HitTestResult::linkTitle):
(API::HitTestResult::lookupText):
(API::HitTestResult::isContentEditable):
(API::HitTestResult::isDownloadableMedia):
(API::HitTestResult::HitTestResult):
(WebKit::WebHitTestResult::absoluteImageURL): Deleted.
(WebKit::WebHitTestResult::absolutePDFURL): Deleted.
(WebKit::WebHitTestResult::absoluteLinkURL): Deleted.
(WebKit::WebHitTestResult::absoluteMediaURL): Deleted.
(WebKit::WebHitTestResult::linkLabel): Deleted.
(WebKit::WebHitTestResult::linkTitle): Deleted.
(WebKit::WebHitTestResult::lookupText): Deleted.
(WebKit::WebHitTestResult::isContentEditable): Deleted.
(WebKit::WebHitTestResult::isDownloadableMedia): Deleted.
(WebKit::WebHitTestResult::WebHitTestResult): Deleted.
This is a new obj-c object that we can use for the modern immediate action
API.
- Shared/API/Cocoa/_WKHitTestResult.h: Added.
- Shared/API/Cocoa/_WKHitTestResult.mm: Added.
(-[_WKHitTestResult dealloc]):
(-[_WKHitTestResult absoluteImageURL]):
(-[_WKHitTestResult absolutePDFURL]):
(-[_WKHitTestResult absoluteLinkURL]):
(-[_WKHitTestResult absoluteMediaURL]):
(-[_WKHitTestResult linkLabel]):
(-[_WKHitTestResult linkTitle]):
(-[_WKHitTestResult lookupText]):
(-[_WKHitTestResult isContentEditable]):
(-[_WKHitTestResult elementBoundingBox]):
(-[_WKHitTestResult copyWithZone:]):
(-[_WKHitTestResult _apiObject]):
_WKHitTestResult wraps API::HitTestResult.
- Shared/API/Cocoa/_WKHitTestResultInternal.h: Added.
(API::wrapper):
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Since we want to use the same enum name for the new enum, use a #define instead of a typedef in the old C SPI. This should keep old clients working in the meantime.
- Shared/API/c/WKImmediateActionTypes.h:
WebHitTestResult::Data is now WebHitTestResultData.
- Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::webHitTestResultData):
(WebKit::ContextMenuContextData::selectedText):
Remove WebHitTestResult, and add WebHitTestResultData for the Data struct.
- Shared/WebHitTestResult.cpp: Removed.
- Shared/WebHitTestResult.h: Removed.
- Shared/WebHitTestResultData.cpp: Added.
(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::~WebHitTestResultData):
(WebKit::WebHitTestResultData::encode):
(WebKit::WebHitTestResultData::decode):
(WebKit::WebHitTestResultData::platformEncode):
(WebKit::WebHitTestResultData::platformDecode):
(WebKit::WebHitTestResultData::elementBoundingBoxInWindowCoordinates):
- Shared/WebHitTestResultData.h: Added.
- Shared/mac/WebHitTestResult.mm: Removed.
- Shared/mac/WebHitTestResultData.mm: Copied from Shared/mac/WebHitTestResult.mm.
(WebKit::WebHitTestResultData::platformEncode):
(WebKit::WebHitTestResultData::platformDecode):
(WebKit::WebHitTestResult::Data::platformEncode): Deleted.
(WebKit::WebHitTestResult::Data::platformDecode): Deleted.
WebHitTestResult::Data is now WebHitTestResultData.
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::~ContextMenuClient):
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::customContextMenuItemSelected):
(API::ContextMenuClient::contextMenuDismissed):
(API::ContextMenuClient::showContextMenu):
WebHitTestResult is now WebHitTestResult
- UIProcess/API/APIUIClient.h:
(API::UIClient::runJavaScriptPrompt):
(API::UIClient::setStatusText):
(API::UIClient::mouseDidMoveOverElement):
(API::UIClient::unavailablePluginButtonClicked):
(API::UIClient::pinnedStateDidChange):
(API::UIClient::didBeginTrackingPotentialLongMousePress):
(API::UIClient::didRecognizeLongMousePress):
(API::UIClient::didCancelTrackingPotentialLongMousePress):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKHitTestResult.cpp:
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
(WKPageSetPageUIClient):
New WKWebView SPI _immediateActionAnimationControllerForHitTestResult
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Attempts to keep other ports happy with the re-name.
- UIProcess/API/efl/WebAccessibility.cpp:
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
- UIProcess/API/gtk/WebKitHitTestResult.cpp:
(webkit_hit_test_result_class_init):
(webkitHitTestResultCreate):
(stringIsEqualToCString):
(webkitHitTestResultCompare):
- UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
- UIProcess/API/gtk/WebKitUIClient.cpp:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewMakePermissionRequest):
(webkitWebViewMouseTargetChanged):
(contextMenuDismissed):
(webkitWebViewPopulateContextMenu):
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
Re-name, and just use uint32_t for the old SPI.
- UIProcess/API/mac/WKView.mm:
(-[WKView _didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKView _setDidMoveSwipeSnapshotCallback:]):
(-[WKView _immediateActionAnimationControllerForHitTestResult:withType:userData:]):
- UIProcess/API/mac/WKViewInternal.h:
PageClient will figure out whether to call into WKWebView or WKView for this
SPI.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::immediateActionAnimationControllerForHitTestResult):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::immediateActionAnimationControllerForHitTestResult):
WebKit::WebHitTestResult::Data is now WebKit::WebHitTestResultData.
- UIProcess/WebPageProxy.messages.in:
WKImmediateActionController calls through to WebPageProxy which calls to
PageClient, which figures out which API to call. Also cache the type as a
uint32_t
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _updateImmediateActionItem]):
WebHitTestResult::Data is now WebHitTestResultData.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::platformInitializeShareMenuItem):
New files!
- WebKit2.xcodeproj/project.pbxproj:
Deal with the #define situation for the enum.
- WebKit2Prefix.h:
New names for things. WebHitTestResult::Data -> WebHitTestResultData
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::pointInLayoutSpaceForPointInWindowSpace):
(WebKit::PDFPlugin::lookupTextAtLocation):
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
- 3:06 PM Changeset in webkit [190822] by
-
- 7 edits1 delete in trunk/Source/JavaScriptCore
Remove unused RecursiveAllocationScope
https://bugs.webkit.org/show_bug.cgi?id=149967
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Csaba Osztrogonác.
RecursiveAllocationScope has been unused since r163691.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
- heap/Heap.h:
- heap/RecursiveAllocationScope.h: Removed.
- runtime/VM.h:
- 3:01 PM Changeset in webkit [190821] by
-
- 3 edits in trunk/Tools
Teach webkitperl how to figure out IOS versions from the SDK
https://bugs.webkit.org/show_bug.cgi?id=149963
Reviewed by Daniel Bates.
It should be easier to check the major and minor version of IOS SDKs.
- Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
- Scripts/webkitdirs.pm:
(splitVersionString): Added.
(determineOSXVersion): Use splitVersionString.
(determineIOSVersion): Added. Look at the SDK version and make a tuple.
(iosVersion): Added.
- 2:50 PM Changeset in webkit [190820] by
-
- 3 edits2 adds in trunk
Garbage texture data with composited table row
https://bugs.webkit.org/show_bug.cgi?id=148984
Reviewed by Zalan Bujtas.
Source/WebCore:
Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.
Test: compositing/contents-opaque/table-parts.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
- compositing/contents-opaque/table-parts-expected.txt: Added.
- compositing/contents-opaque/table-parts.html: Added.
- 2:34 PM Changeset in webkit [190819] by
-
- 3 edits in trunk/Tools
[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
https://bugs.webkit.org/show_bug.cgi?id=149960
Reviewed by Tim Horton.
Use adoptWK(), and null out some members (file is not using ARC).
- WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::uiScriptComplete):
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
- 2:07 PM Changeset in webkit [190818] by
-
- 7 edits2 adds in trunk
Garbage pixels on enphaseenergy.com site
https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184
Reviewed by Darin Adler.
Source/WebCore:
When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.
Also improve the compositing logging to indicate when fore- and background layers
are present.
Test: compositing/contents-opaque/negative-z-before-html.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
LayoutTests:
New ref test. Also update the expected result for another test that uses negative
z-index children.
- compositing/contents-opaque/body-background-painted-expected.txt:
- compositing/contents-opaque/negative-z-before-html-expected.html: Added.
- compositing/contents-opaque/negative-z-before-html.html: Added.
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
- 2:00 PM Changeset in webkit [190817] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Perf dashboard erroneously shows an old OS build in A/B testing range
https://bugs.webkit.org/show_bug.cgi?id=149942
Reviewed by Darin Adler.
Ordering OS builds lexicologically turned out be a bad idea since 15A25 falls between 15A242 and 15A251.
Use a fake/synthetic timestamp to force the commonly understood total order instead.
Refactored pull-os-versions.py to share the server config JSON with other scripts. Also made the script
support pulling multiple sources; e.g. both OS X and iOS.
Also removed superfluous feature to submit results in chunks. The perf dashboard can handle thousands of
revisions being submitted at once just fine.
- public/api/commits.php:
(main): A partial revert of r185574 since we no longer need to order builds lexicologically.
- tools/pull-os-versions.py:
(main): Takes --os-config-json, --server-config-json, and --seconds-to-sleep as arguments instead of
a single --config argument to share the server config JSON with other scripts.
(OSBuildFetcher): Extracted out of main. This class is instantiated for each OS kind (e.g. OS X).
(OSBuildFetcher.init): Added.
(OSBuildFetcher._fetch_available_builds): Extracted out of main. Fetches available builds from a website
or custom commands.
(OSBuildFetcher.fetch_and_report_new_builds): Extracted out of main. Submits the fetched builds after
filtering out the ones we've already reported.
(OSBuildFetcher._assign_fake_timestamps): Creates a fake timestamp to establish a total order amongst each
OS X / iOS style build number such as 12A3456b.
- 12:59 PM Changeset in webkit [190816] by
-
- 8 edits14 adds in trunk
Dynamic background color changes do not update until a layout is forced
https://bugs.webkit.org/show_bug.cgi?id=131623
Source/WebCore:
Compute correct repaint rect for decorated RenderSVGRoots.
The current implementation of clippedOverflowRectForRepaint() uses the
generic repaint-rect calculations in SVGRenderSupport. Those in turn make
use of repaintRectInLocalCoordinates(), which for RenderSVGRoot is the
union of the painted children (w/ some expansion). If there're no children,
or they do not fill the entire content box, then a repaint would not
repaint the correct parts.
Fix by calculating the union of the border-box and the SVG content
when the SVG root is decorated (has background/border/etc.)
Adapted from a Chromium patch by fs@opera.com
https://src.chromium.org/viewvc/blink?revision=170890&view=revision
Patch by Antoine Quint <Antoine Quint> on 2015-10-09
Reviewed by Darin Adler.
Tests: svg/repaint/add-background-property-on-root.html
svg/repaint/add-border-property-on-root.html
svg/repaint/add-outline-property-on-root.html
svg/repaint/change-background-color.html
svg/repaint/remove-background-property-on-root.html
svg/repaint/remove-border-property-on-root.html
svg/repaint/remove-outline-property-on-root.html
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
LayoutTests:
Add some new tests checking that dynamically updating the "background",
"border" and "outline" CSS properties repaint correctly and rebase a few
existing tests that yield the same rendered results but slightly different
DRT output.
Patch by Antoine Quint <Antoine Quint> on 2015-10-09
Reviewed by Darin Adler.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/mac/svg/custom/simple-text-double-shadow-expected.txt:
- svg/css/composite-shadow-example-expected.txt:
- svg/css/composite-shadow-with-opacity-expected.txt:
- svg/repaint/add-background-property-on-root-expected.html: Added.
- svg/repaint/add-background-property-on-root.html: Added.
- svg/repaint/add-border-property-on-root-expected.html: Added.
- svg/repaint/add-border-property-on-root.html: Added.
- svg/repaint/add-outline-property-on-root-expected.html: Added.
- svg/repaint/add-outline-property-on-root.html: Added.
- svg/repaint/change-background-color-expected.html: Added.
- svg/repaint/change-background-color.html: Added.
- svg/repaint/remove-background-property-on-root-expected.html: Added.
- svg/repaint/remove-background-property-on-root.html: Added.
- svg/repaint/remove-border-property-on-root-expected.html: Added.
- svg/repaint/remove-border-property-on-root.html: Added.
- svg/repaint/remove-outline-property-on-root-expected.html: Added.
- svg/repaint/remove-outline-property-on-root.html: Added.
- svg/repaint/repaint-webkit-svg-shadow-expected.txt:
- 12:58 PM Changeset in webkit [190815] by
-
- 18 edits in branches/safari-601.1.46-branch
Roll out r190434. rdar://problem/22865007
- 12:56 PM Changeset in webkit [190814] by
-
- 3 edits in branches/safari-601.1.46-branch/LayoutTests
Roll out r190438. rdar://problem/22865007
- 12:55 PM Changeset in webkit [190813] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Roll out r190447. rdar://problem/22865007
- 12:53 PM Changeset in webkit [190812] by
-
- 19 edits in branches/safari-601.1.46-branch
Roll out r190604. rdar://problem/22993012
- 11:41 AM Changeset in webkit [190811] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r189168.
- 11:36 AM Changeset in webkit [190810] by
-
- 2 edits in trunk/Source/WebCore
[iOS WK2] Fix assertion in ViewportConfiguration::setDefaultConfiguration seen in testing
https://bugs.webkit.org/show_bug.cgi?id=149959
Reviewed by Tim Horton.
When loading tests which set a flexible viewport, ViewportConfiguration::setDefaultConfiguration()
is called first with testingParameters() and then with webpageParameters(). This
would trigger the assertion that m_defaultConfiguration.initialScaleIsSet but
the new initial scale is zero.
The assertion seems wrong anyway; it's consulting m_defaultConfiguration.initialScaleIsSet
but defaultConfiguration.initialScale, so fix it to test defaultConfiguration.initialScaleIsSet.
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setDefaultConfiguration):
- 10:54 AM Changeset in webkit [190809] by
-
- 57 edits in trunk/Source/JavaScriptCore
2015-10-09 Geoffrey Garen <ggaren@apple.com>
Unreviewed, rolling out r190694
https://bugs.webkit.org/show_bug.cgi?id=148560
Crashes seen on PLT bots and facebook.com.
Reverted changesets:
"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190694
- 10:53 AM Changeset in webkit [190808] by
-
- 1 edit3 adds in trunk/LayoutTests
Add some missing iOS results.
- fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Added.
- platform/ios-simulator/compositing/transitions/scale-transition-no-start-expected.txt: Added.
- platform/ios-simulator/compositing/transitions/singular-scale-transition-expected.txt: Added.
- 10:31 AM Changeset in webkit [190807] by
-
- 1 edit in branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt
Rebaseline after r190494.
- 10:30 AM Changeset in webkit [190806] by
-
- 3 edits in trunk/Source/WebKit2
Remove two unused WKFrame functions
https://bugs.webkit.org/show_bug.cgi?id=149958
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames): Deleted.
(WKFrameGetParentFrame): Deleted.
- UIProcess/API/C/WKFrame.h:
- 10:20 AM Changeset in webkit [190805] by
-
- 2 edits in trunk/Tools
Remove ENABLE_SUID_SANDBOX_LINUX cruft
https://bugs.webkit.org/show_bug.cgi?id=149954
Reviewed by Darin Adler.
- Scripts/webkitperl/FeatureList.pm:
- 10:08 AM Changeset in webkit [190804] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(STREAM_API) build after r190794
https://bugs.webkit.org/show_bug.cgi?id=149955
Reviewed by Darin Adler.
- bindings/js/WebCoreJSBuiltinInternals.h:
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):
- 10:04 AM Changeset in webkit [190803] by
-
- 11 edits in trunk/Source/WebCore
Fix the binding generator after r190785
https://bugs.webkit.org/show_bug.cgi?id=149956
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::getConstructData):
- 9:52 AM Changeset in webkit [190802] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, more Mac test gardening after r190629.
These more accurate expectations are based on several days
of builds with the newly-imported Blink tests.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 9:31 AM WebKitIDL edited by
- (diff)
- 8:55 AM Changeset in webkit [190801] by
-
- 2 edits in trunk/Tools
Make iOS builders generate debug information in a separate dSYM file
https://bugs.webkit.org/show_bug.cgi?id=149696
Reviewed by Darin Adler.
Similar to the Mac builders, the iOS builders should write debug information
into a separate dSYM file instead of including such information in the binary
itself (default Xcode behavior)
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 8:18 AM Changeset in webkit [190800] by
-
- 5 edits2 adds in trunk
Backgrounds bleed out of natively rendered text fields
https://bugs.webkit.org/show_bug.cgi?id=149843
<rdar://problem/22896977>
Reviewed by Darin Adler.
Source/WebCore:
When natively rendering a text field with a background on Mac, the background bleeds out
of the text field's border when the graphics context is scaled (as a result of a retina
display or zoom/scale effects). This is because when we render the text field in bezeled
style within a certain frame, AppKit adds 1 device pixel insets on all sides of the frame,
which renders a text field that is slightly smaller than the frame. To adjust for this, we
inflate the paint rect.
Test: fast/forms/hidpi-textfield-background-bleeding.html
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):
LayoutTests:
Add a layout test to check that the background of a natively rendered text field
cell does not bleed.
- TestExpectations:
- fast/forms/hidpi-textfield-background-bleeding-expected.html: Added.
- fast/forms/hidpi-textfield-background-bleeding.html: Added.
- 7:22 AM Changeset in webkit [190799] by
-
- 19 edits in branches/safari-601.1.46-branch
Merge r190604. rdar://problem/22993012
- 7:22 AM Changeset in webkit [190798] by
-
- 3 edits3 adds in branches/safari-601.1.46-branch
Merge r190602. rdar://problem/22995810
- 7:22 AM Changeset in webkit [190797] by
-
- 7 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r190568. rdar://problem/22974825
- 7:22 AM Changeset in webkit [190796] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r190512. rdar://problem/22974818
- 7:21 AM Changeset in webkit [190795] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r190447. rdar://problem/22865007
- 7:21 AM Changeset in webkit [190794] by
-
- 19 edits2 adds in trunk/Source
Source/JavaScriptCore:
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751
Reviewed by Darin Adler.
- generate-js-builtins: updating the part related to WebCore JS binding.
Source/WebCore:
Refactor WebCore JS builtins to prepare for automatic generation
https://bugs.webkit.org/show_bug.cgi?id=149751
Reviewed by Darin Adler.
Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names should be exported automatically.
Added WebCoreJSBuiltins.h to simplify handling of builtins in JSVMClientData.
Added WebCoreJSInternals.h to simplify handling of builtin private function in JSDOMWindowBase.
Renamed WebCoreJSClientData to JSVMClientData.
Covered by existing tests.
- CMakeLists.txt:
- Modules/streams/ByteLengthQueuingStrategy.js:
- Modules/streams/CountQueuingStrategy.js:
- Modules/streams/ReadableStream.js:
- Modules/streams/ReadableStreamController.js:
- Modules/streams/ReadableStreamInternals.js:
- Modules/streams/ReadableStreamReader.js:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
(WebCore::JSDOMWindowBase::destroy): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
- bindings/js/WebCoreJSBuiltinInternals.h: Added.
(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::readableStreamInternals):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h: Added.
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::byteLengthQueuingStrategyBuiltins):
(WebCore::JSBuiltinFunctions::countQueuingStrategyBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamControllerBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamInternalsBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamReaderBuiltins):
- bindings/js/WebCoreJSClientData.h:
(WebCore::JSVMClientData::JSVMClientData):
(WebCore::JSVMClientData::~JSVMClientData):
(WebCore::JSVMClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::JSVMClientData::normalWorld): Deleted.
(WebCore::JSVMClientData::getAllWorlds): Deleted.
- 7:21 AM Changeset in webkit [190793] by
-
- 3 edits in branches/safari-601.1.46-branch/LayoutTests
Merge r190438. rdar://problem/22865007
- 7:21 AM Changeset in webkit [190792] by
-
- 18 edits in branches/safari-601.1.46-branch
Merge r190434. rdar://problem/22865007
- 7:21 AM Changeset in webkit [190791] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r189979. rdar://problem/23033080
- 7:21 AM Changeset in webkit [190790] by
-
- 12 edits in branches/safari-601.1.46-branch/Source
Merge r189834. rdar://problem/22807373
- 7:21 AM Changeset in webkit [190789] by
-
- 3 edits1 add in branches/safari-601.1.46-branch/Source/WTF
Merge r189633. rdar://problem/22824424
- 7:21 AM Changeset in webkit [190788] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r189460. rdar://problem/22823239
- 7:21 AM Changeset in webkit [190787] by
-
- 15 edits2 adds in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r189454. rdar://problem/22823239
- 7:21 AM Changeset in webkit [190786] by
-
- 9 edits3 adds in branches/safari-601.1.46-branch
Merge r189421. rdar://problem/22823243
- 6:44 AM Changeset in webkit [190785] by
-
- 11 edits in trunk/Source/WebCore
Rationalize JSXXConstructor class definition
https://bugs.webkit.org/show_bug.cgi?id=149923
Reviewed by Darin Adler.
Declaration of JSXXConstructor::construct and JSXXConstructor::getConstructData
as long as JSXX is constructable from JavaScript.
Previously, JSXXConstructor::construct was not generated in case of CustomConstructor.
It is now generated and directly calls the custom constructor function.
getConstructData was declared conditionally with #if in case of ConstructorConditional.
The #if are now within getConstructData body.
Covered by binding tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(GenerateConstructorDefinitions):.
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::construct):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::JSTestEventConstructorConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::JSTestInterfaceConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::construct):
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
(WebCore::JSTestNodeConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
(WebCore::JSTestObjConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
(WebCore::JSTestOverloadedConstructorsConstructor::construct):
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::JSTestTypedefsConstructor::getConstructData):
- 5:56 AM Changeset in webkit [190784] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Include freeSpace in GridSizingData struct
https://bugs.webkit.org/show_bug.cgi?id=149876
Reviewed by Darin Adler.
During the layout process we keep the free space for rows and
columns in two variables that are passed to a few methods
along with the GridSizingData struct. Those two variables
should clearly be part of GridSizingData as they're temporary
values used just for the sake of the layout.
No new tests required as this is just a refactoring.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::GridSizingData::freeSpaceForDirection):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::applyStretchAlignmentToTracksIfNeeded):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
- rendering/RenderGrid.h:
- 5:47 AM Changeset in webkit [190783] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Remove unneeded calls to compute(Content)LogicalWidth(Height)
https://bugs.webkit.org/show_bug.cgi?id=149926
Reviewed by Darin Adler.
In order to resolve a Length to a LayoutUnit we need to
provide a maximum value so that i.e. percentages are correctly
computed. That maximum value was computeLogicalWidth() for
columns and computeContentLogicalHeight() for rows. We were
calling it for every single track with a definite size instead
of computing it once and reusing it multiple times.
This brings some nice performance improvements:
- 2.9% in /Layout/fixed-grid-lots-of-data
- 2.95% in /Layout/fixed-grid-lots-of-stretched-data
No new tests required as there is no change in functionality.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeUsedBreadthOfMinLength):
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
- rendering/RenderGrid.h:
- 2:07 AM Changeset in webkit [190782] by
-
- 2 edits in trunk/Tools
Fix webkitpy tests after r190779
https://bugs.webkit.org/show_bug.cgi?id=149949
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults.format):
(BenchmarkResults._format_values):
- 1:18 AM Changeset in webkit [190781] by
-
- 4 edits in trunk
[CMake] Remove ENABLE_SUBPIXEL_LAYOUT macro
https://bugs.webkit.org/show_bug.cgi?id=149947
Reviewed by Csaba Osztrogonác.
ENABLE(SUBPIXEL_LAYOUT) was removed though, it is still alive in .cmake.
Removed it.
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
